{"action":"created","comment":{"url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/comments/224987403","pull_request_review_id":164493008,"id":224987403,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk4NzQwMw==","diff_hunk":"@@ -135,16 +135,16 @@ func NewGetObjectInput(bucketName, source string) (*s3.GetObjectInput, error) {\n // NewPutObjectInput returns a new *s3.PutObjectInput\n func NewPutObjectInput(bucketName, fileName, contentType string, image []byte, size int64) (*s3.PutObjectInput, error) {\n \n-\tif len(bucketName) == 0 {\n+\tif bucketName == \"\" {\n \t\treturn nil, intErr.Format(BucketName, ErrEmptyParameter)\n \t}\n-\tif len(fileName) == 0 {\n+\tif fileName == \"\" {\n \t\treturn nil, intErr.Format(FileName, ErrEmptyParameter)\n \t}\n-\tif len(contentType) == 0 {\n+\tif contentType == \"\" {\n \t\treturn nil, intErr.Format(ContentType, ErrEmptyParameter)\n \t}\n-\tif len(image) == 0 {","path":"pkg/aws/s3/util.go","position":56,"original_position":56,"commit_id":"f1cf472082348e2465992fb7ee000f1e2ecddb7f","original_commit_id":"f1cf472082348e2465992fb7ee000f1e2ecddb7f","user":{"login":"AndreaM16","id":6943457,"node_id":"MDQ6VXNlcjY5NDM0NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/6943457?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreaM16","html_url":"https://github.com/AndreaM16","followers_url":"https://api.github.com/users/AndreaM16/followers","following_url":"https://api.github.com/users/AndreaM16/following{/other_user}","gists_url":"https://api.github.com/users/AndreaM16/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaM16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaM16/subscriptions","organizations_url":"https://api.github.com/users/AndreaM16/orgs","repos_url":"https://api.github.com/users/AndreaM16/repos","events_url":"https://api.github.com/users/AndreaM16/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaM16/received_events","type":"User","site_admin":false},"body":"These are bytes, not strings.","created_at":"2018-10-14T10:27:51Z","updated_at":"2018-10-14T10:27:52Z","html_url":"https://github.com/AndreaM16/aws-sdk-go-bindings/pull/14#discussion_r224987403","pull_request_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/comments/224987403"},"html":{"href":"https://github.com/AndreaM16/aws-sdk-go-bindings/pull/14#discussion_r224987403"},"pull_request":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14","id":222706250,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzA2MjUw","html_url":"https://github.com/AndreaM16/aws-sdk-go-bindings/pull/14","diff_url":"https://github.com/AndreaM16/aws-sdk-go-bindings/pull/14.diff","patch_url":"https://github.com/AndreaM16/aws-sdk-go-bindings/pull/14.patch","issue_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues/14","number":14,"state":"open","locked":false,"title":"Made empty string checking more idomatic. This fixes #13","user":{"login":"WerWolv98","id":10835354,"node_id":"MDQ6VXNlcjEwODM1MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/10835354?v=4","gravatar_id":"","url":"https://api.github.com/users/WerWolv98","html_url":"https://github.com/WerWolv98","followers_url":"https://api.github.com/users/WerWolv98/followers","following_url":"https://api.github.com/users/WerWolv98/following{/other_user}","gists_url":"https://api.github.com/users/WerWolv98/gists{/gist_id}","starred_url":"https://api.github.com/users/WerWolv98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WerWolv98/subscriptions","organizations_url":"https://api.github.com/users/WerWolv98/orgs","repos_url":"https://api.github.com/users/WerWolv98/repos","events_url":"https://api.github.com/users/WerWolv98/events{/privacy}","received_events_url":"https://api.github.com/users/WerWolv98/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-14T10:24:31Z","updated_at":"2018-10-14T10:27:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3413c00b2e48b86552c7392d31bd58a6c90e2ba1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14/commits","review_comments_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14/comments","review_comment_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues/14/comments","statuses_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/statuses/f1cf472082348e2465992fb7ee000f1e2ecddb7f","head":{"label":"WerWolv98:master","ref":"master","sha":"f1cf472082348e2465992fb7ee000f1e2ecddb7f","user":{"login":"WerWolv98","id":10835354,"node_id":"MDQ6VXNlcjEwODM1MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/10835354?v=4","gravatar_id":"","url":"https://api.github.com/users/WerWolv98","html_url":"https://github.com/WerWolv98","followers_url":"https://api.github.com/users/WerWolv98/followers","following_url":"https://api.github.com/users/WerWolv98/following{/other_user}","gists_url":"https://api.github.com/users/WerWolv98/gists{/gist_id}","starred_url":"https://api.github.com/users/WerWolv98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WerWolv98/subscriptions","organizations_url":"https://api.github.com/users/WerWolv98/orgs","repos_url":"https://api.github.com/users/WerWolv98/repos","events_url":"https://api.github.com/users/WerWolv98/events{/privacy}","received_events_url":"https://api.github.com/users/WerWolv98/received_events","type":"User","site_admin":false},"repo":{"id":152961588,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5NjE1ODg=","name":"aws-sdk-go-bindings","full_name":"WerWolv98/aws-sdk-go-bindings","private":false,"owner":{"login":"WerWolv98","id":10835354,"node_id":"MDQ6VXNlcjEwODM1MzU0","avatar_url":"https://avatars0.githubusercontent.com/u/10835354?v=4","gravatar_id":"","url":"https://api.github.com/users/WerWolv98","html_url":"https://github.com/WerWolv98","followers_url":"https://api.github.com/users/WerWolv98/followers","following_url":"https://api.github.com/users/WerWolv98/following{/other_user}","gists_url":"https://api.github.com/users/WerWolv98/gists{/gist_id}","starred_url":"https://api.github.com/users/WerWolv98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WerWolv98/subscriptions","organizations_url":"https://api.github.com/users/WerWolv98/orgs","repos_url":"https://api.github.com/users/WerWolv98/repos","events_url":"https://api.github.com/users/WerWolv98/events{/privacy}","received_events_url":"https://api.github.com/users/WerWolv98/received_events","type":"User","site_admin":false},"html_url":"https://github.com/WerWolv98/aws-sdk-go-bindings","description":"Helper package to easily access some aws-sdk-go's methods (SNS, SQS, DynamoDB, Rekognition, S3)","fork":true,"url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings","forks_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/forks","keys_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/teams","hooks_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/hooks","issue_events_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/issues/events{/number}","events_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/events","assignees_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/assignees{/user}","branches_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/branches{/branch}","tags_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/tags","blobs_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/git/refs{/sha}","trees_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/statuses/{sha}","languages_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/languages","stargazers_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/stargazers","contributors_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/contributors","subscribers_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/subscribers","subscription_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/subscription","commits_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/commits{/sha}","git_commits_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/git/commits{/sha}","comments_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/comments{/number}","issue_comment_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/issues/comments{/number}","contents_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/contents/{+path}","compare_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/merges","archive_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/downloads","issues_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/issues{/number}","pulls_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/pulls{/number}","milestones_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/milestones{/number}","notifications_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/labels{/name}","releases_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/releases{/id}","deployments_url":"https://api.github.com/repos/WerWolv98/aws-sdk-go-bindings/deployments","created_at":"2018-10-14T10:13:39Z","updated_at":"2018-10-14T10:23:33Z","pushed_at":"2018-10-14T10:23:32Z","git_url":"git://github.com/WerWolv98/aws-sdk-go-bindings.git","ssh_url":"git@github.com:WerWolv98/aws-sdk-go-bindings.git","clone_url":"https://github.com/WerWolv98/aws-sdk-go-bindings.git","svn_url":"https://github.com/WerWolv98/aws-sdk-go-bindings","homepage":"","size":276,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AndreaM16:master","ref":"master","sha":"7e32b3f70288bdb75c159fa5a129e4f6afaee212","user":{"login":"AndreaM16","id":6943457,"node_id":"MDQ6VXNlcjY5NDM0NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/6943457?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreaM16","html_url":"https://github.com/AndreaM16","followers_url":"https://api.github.com/users/AndreaM16/followers","following_url":"https://api.github.com/users/AndreaM16/following{/other_user}","gists_url":"https://api.github.com/users/AndreaM16/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaM16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaM16/subscriptions","organizations_url":"https://api.github.com/users/AndreaM16/orgs","repos_url":"https://api.github.com/users/AndreaM16/repos","events_url":"https://api.github.com/users/AndreaM16/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaM16/received_events","type":"User","site_admin":false},"repo":{"id":137505095,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MDUwOTU=","name":"aws-sdk-go-bindings","full_name":"AndreaM16/aws-sdk-go-bindings","private":false,"owner":{"login":"AndreaM16","id":6943457,"node_id":"MDQ6VXNlcjY5NDM0NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/6943457?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreaM16","html_url":"https://github.com/AndreaM16","followers_url":"https://api.github.com/users/AndreaM16/followers","following_url":"https://api.github.com/users/AndreaM16/following{/other_user}","gists_url":"https://api.github.com/users/AndreaM16/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreaM16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreaM16/subscriptions","organizations_url":"https://api.github.com/users/AndreaM16/orgs","repos_url":"https://api.github.com/users/AndreaM16/repos","events_url":"https://api.github.com/users/AndreaM16/events{/privacy}","received_events_url":"https://api.github.com/users/AndreaM16/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AndreaM16/aws-sdk-go-bindings","description":"Helper package to easily access some aws-sdk-go's methods (SNS, SQS, DynamoDB, Rekognition, S3)","fork":false,"url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings","forks_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/forks","keys_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/teams","hooks_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/hooks","issue_events_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues/events{/number}","events_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/events","assignees_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/assignees{/user}","branches_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/branches{/branch}","tags_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/tags","blobs_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/statuses/{sha}","languages_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/languages","stargazers_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/stargazers","contributors_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/contributors","subscribers_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/subscribers","subscription_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/subscription","commits_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/contents/{+path}","compare_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/merges","archive_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/downloads","issues_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues{/number}","pulls_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls{/number}","milestones_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/milestones{/number}","notifications_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/labels{/name}","releases_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/releases{/id}","deployments_url":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/deployments","created_at":"2018-06-15T15:40:21Z","updated_at":"2018-10-14T10:15:25Z","pushed_at":"2018-10-14T10:24:32Z","git_url":"git://github.com/AndreaM16/aws-sdk-go-bindings.git","ssh_url":"git@github.com:AndreaM16/aws-sdk-go-bindings.git","clone_url":"https://github.com/AndreaM16/aws-sdk-go-bindings.git","svn_url":"https://github.com/AndreaM16/aws-sdk-go-bindings","homepage":"","size":276,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14"},"html":{"href":"https://github.com/AndreaM16/aws-sdk-go-bindings/pull/14"},"issue":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues/14"},"comments":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/AndreaM16/aws-sdk-go-bindings/statuses/f1cf472082348e2465992fb7ee000f1e2ecddb7f"}},"author_association":"NONE"}}
{"actor":{"display_login":"AndreaM16"}}