{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments/200993572","pull_request_review_id":135406501,"id":200993572,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk5MzU3Mg==","diff_hunk":"@@ -50,7 +50,7 @@ public void should_update_document_url_of_scannable_item() throws IOException {\n \n         // and\n         dbItems.forEach(item ->\n-            assertThat(item.getDocumentUrl()).isEqualTo(\"localhost/document/\" + item.getId())\n+            assertThat(item.getDocumentUrl()).isEqualTo(\"localhost/document/\" + item.hashCode())","path":"src/integrationTest/java/uk/gov/hmcts/reform/bulkscanprocessor/entity/ScannableItemTest.java","position":14,"original_position":14,"commit_id":"31f9af009e5fe25a63762d44562860e2ca3a6875","original_commit_id":"31f9af009e5fe25a63762d44562860e2ca3a6875","user":{"login":"nitinprabhu","id":13840402,"node_id":"MDQ6VXNlcjEzODQwNDAy","avatar_url":"https://avatars1.githubusercontent.com/u/13840402?v=4","gravatar_id":"","url":"https://api.github.com/users/nitinprabhu","html_url":"https://github.com/nitinprabhu","followers_url":"https://api.github.com/users/nitinprabhu/followers","following_url":"https://api.github.com/users/nitinprabhu/following{/other_user}","gists_url":"https://api.github.com/users/nitinprabhu/gists{/gist_id}","starred_url":"https://api.github.com/users/nitinprabhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitinprabhu/subscriptions","organizations_url":"https://api.github.com/users/nitinprabhu/orgs","repos_url":"https://api.github.com/users/nitinprabhu/repos","events_url":"https://api.github.com/users/nitinprabhu/events{/privacy}","received_events_url":"https://api.github.com/users/nitinprabhu/received_events","type":"User","site_admin":false},"body":"same goes here","created_at":"2018-07-09T13:04:21Z","updated_at":"2018-07-09T13:35:59Z","html_url":"https://github.com/hmcts/bulk-scan-processor/pull/35#discussion_r200993572","pull_request_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments/200993572"},"html":{"href":"https://github.com/hmcts/bulk-scan-processor/pull/35#discussion_r200993572"},"pull_request":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35","id":200080393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDgwMzkz","html_url":"https://github.com/hmcts/bulk-scan-processor/pull/35","diff_url":"https://github.com/hmcts/bulk-scan-processor/pull/35.diff","patch_url":"https://github.com/hmcts/bulk-scan-processor/pull/35.patch","issue_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/35","number":35,"state":"open","locked":false,"title":"Bugfix: JPA entities","user":{"login":"doncem","id":1420191,"node_id":"MDQ6VXNlcjE0MjAxOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1420191?v=4","gravatar_id":"","url":"https://api.github.com/users/doncem","html_url":"https://github.com/doncem","followers_url":"https://api.github.com/users/doncem/followers","following_url":"https://api.github.com/users/doncem/following{/other_user}","gists_url":"https://api.github.com/users/doncem/gists{/gist_id}","starred_url":"https://api.github.com/users/doncem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doncem/subscriptions","organizations_url":"https://api.github.com/users/doncem/orgs","repos_url":"https://api.github.com/users/doncem/repos","events_url":"https://api.github.com/users/doncem/events{/privacy}","received_events_url":"https://api.github.com/users/doncem/received_events","type":"User","site_admin":false},"body":"### JIRA link (if applicable) ###\r\n\r\n[Persist child entities correctly](https://tools.hmcts.net/jira/browse/RPE-572)\r\n\r\n### Change description ###\r\n\r\nNotes:\r\n- Envelope ID was never saved due to entity not being assigned to each child element [major fix]\r\n- Moving transactional scope to source code [minor fix]. It allows to trust test cases are using DB for retrieving entities rather than in-memory built-up proxies\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2018-07-09T12:14:29Z","updated_at":"2018-07-09T13:35:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be9b8386933deba9d8cf408ed5a603ef32be3e18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35/commits","review_comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35/comments","review_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/35/comments","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/31f9af009e5fe25a63762d44562860e2ca3a6875","head":{"label":"hmcts:bugfix/jpa-entities","ref":"bugfix/jpa-entities","sha":"31f9af009e5fe25a63762d44562860e2ca3a6875","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":133028120,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMjgxMjA=","name":"bulk-scan-processor","full_name":"hmcts/bulk-scan-processor","owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/bulk-scan-processor","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/bulk-scan-processor","forks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/forks","keys_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/teams","hooks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/hooks","issue_events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/events","assignees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/tags","blobs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/languages","stargazers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/stargazers","contributors_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contributors","subscribers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscribers","subscription_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscription","commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/merges","archive_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/downloads","issues_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/deployments","created_at":"2018-05-11T10:51:58Z","updated_at":"2018-07-06T14:33:13Z","pushed_at":"2018-07-09T12:14:30Z","git_url":"git://github.com/hmcts/bulk-scan-processor.git","ssh_url":"git@github.com:hmcts/bulk-scan-processor.git","clone_url":"https://github.com/hmcts/bulk-scan-processor.git","svn_url":"https://github.com/hmcts/bulk-scan-processor","homepage":null,"size":1158,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"20d1c7829c9b193d39f5aada6d1a0e0337f6cf4b","user":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":133028120,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwMjgxMjA=","name":"bulk-scan-processor","full_name":"hmcts/bulk-scan-processor","owner":{"login":"hmcts","id":22817111,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODE3MTEx","avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/bulk-scan-processor","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/bulk-scan-processor","forks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/forks","keys_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/teams","hooks_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/hooks","issue_events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/events","assignees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/tags","blobs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/languages","stargazers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/stargazers","contributors_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contributors","subscribers_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscribers","subscription_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/subscription","commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/merges","archive_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/downloads","issues_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/bulk-scan-processor/deployments","created_at":"2018-05-11T10:51:58Z","updated_at":"2018-07-06T14:33:13Z","pushed_at":"2018-07-09T12:14:30Z","git_url":"git://github.com/hmcts/bulk-scan-processor.git","ssh_url":"git@github.com:hmcts/bulk-scan-processor.git","clone_url":"https://github.com/hmcts/bulk-scan-processor.git","svn_url":"https://github.com/hmcts/bulk-scan-processor","homepage":null,"size":1158,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35"},"html":{"href":"https://github.com/hmcts/bulk-scan-processor/pull/35"},"issue":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/35"},"comments":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/bulk-scan-processor/statuses/31f9af009e5fe25a63762d44562860e2ca3a6875"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nitinprabhu"}}