{"action":"created","comment":{"url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/comments/201125278","pull_request_review_id":135566061,"id":201125278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTEyNTI3OA==","diff_hunk":"@@ -0,0 +1,29 @@\n+import unittest\n+from excercises.PracticePython_SecondLargestNumber import second_largest_element\n+\n+\n+class SecondLargestElementTests(unittest.TestCase):\n+\n+    def test_second_largest_element(self):\n+        list_of_numbers = [1, 3, 5, 9, 3, 8]\n+        self.assertEqual(8, second_largest_element(list_of_numbers))\n+\n+    def test_negative_list(self):\n+        list_of_numbers = [-1, -3, -5, -9, - 3, -8]\n+        self.assertEqual(-3, second_largest_element(list_of_numbers))\n+","path":"coding-practice/tests/test_SecondLargestNumber.py","position":14,"original_position":14,"commit_id":"be24be60b0c1b52831e3564f2f793c354a9b3ac4","original_commit_id":"be24be60b0c1b52831e3564f2f793c354a9b3ac4","user":{"login":"BasilBibi","id":4756910,"node_id":"MDQ6VXNlcjQ3NTY5MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4756910?v=4","gravatar_id":"","url":"https://api.github.com/users/BasilBibi","html_url":"https://github.com/BasilBibi","followers_url":"https://api.github.com/users/BasilBibi/followers","following_url":"https://api.github.com/users/BasilBibi/following{/other_user}","gists_url":"https://api.github.com/users/BasilBibi/gists{/gist_id}","starred_url":"https://api.github.com/users/BasilBibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BasilBibi/subscriptions","organizations_url":"https://api.github.com/users/BasilBibi/orgs","repos_url":"https://api.github.com/users/BasilBibi/repos","events_url":"https://api.github.com/users/BasilBibi/events{/privacy}","received_events_url":"https://api.github.com/users/BasilBibi/received_events","type":"User","site_admin":false},"body":"Interesting to find this in the python docs for the max function.\r\n\r\nhttps://docs.python.org/3/library/functions.html#max\r\n\r\n\"If multiple items are maximal, the function returns the first one encountered. This is consistent with other sort-stability preserving tools such as sorted(iterable, key=keyfunc, reverse=True)[0] and heapq.nlargest(1, iterable, key=keyfunc).\"\r\n\r\nSo perhaps there is a test  that has to be written : \r\n\r\nsecond_largest_element( [5, 1, 1] )\r\n\r\nTo be consistent with other function in the python library like max it should return 1\r\n","created_at":"2018-07-09T19:48:44Z","updated_at":"2018-07-09T19:48:45Z","html_url":"https://github.com/SufyaanBibi/PracticePython/pull/1#discussion_r201125278","pull_request_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/comments/201125278"},"html":{"href":"https://github.com/SufyaanBibi/PracticePython/pull/1#discussion_r201125278"},"pull_request":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1"}},"in_reply_to_id":201120404},"pull_request":{"url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1","id":200150268,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTUwMjY4","html_url":"https://github.com/SufyaanBibi/PracticePython/pull/1","diff_url":"https://github.com/SufyaanBibi/PracticePython/pull/1.diff","patch_url":"https://github.com/SufyaanBibi/PracticePython/pull/1.patch","issue_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/1","number":1,"state":"open","locked":false,"title":"Check initial commit to develop.","user":{"login":"SufyaanBibi","id":37698037,"node_id":"MDQ6VXNlcjM3Njk4MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/37698037?v=4","gravatar_id":"","url":"https://api.github.com/users/SufyaanBibi","html_url":"https://github.com/SufyaanBibi","followers_url":"https://api.github.com/users/SufyaanBibi/followers","following_url":"https://api.github.com/users/SufyaanBibi/following{/other_user}","gists_url":"https://api.github.com/users/SufyaanBibi/gists{/gist_id}","starred_url":"https://api.github.com/users/SufyaanBibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SufyaanBibi/subscriptions","organizations_url":"https://api.github.com/users/SufyaanBibi/orgs","repos_url":"https://api.github.com/users/SufyaanBibi/repos","events_url":"https://api.github.com/users/SufyaanBibi/events{/privacy}","received_events_url":"https://api.github.com/users/SufyaanBibi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-09T16:13:13Z","updated_at":"2018-07-09T19:48:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f169fd4510edac58a39a9968ad3700cc12d26de6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1/commits","review_comments_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1/comments","review_comment_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/1/comments","statuses_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/statuses/be24be60b0c1b52831e3564f2f793c354a9b3ac4","head":{"label":"SufyaanBibi:issue_1","ref":"issue_1","sha":"be24be60b0c1b52831e3564f2f793c354a9b3ac4","user":{"login":"SufyaanBibi","id":37698037,"node_id":"MDQ6VXNlcjM3Njk4MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/37698037?v=4","gravatar_id":"","url":"https://api.github.com/users/SufyaanBibi","html_url":"https://github.com/SufyaanBibi","followers_url":"https://api.github.com/users/SufyaanBibi/followers","following_url":"https://api.github.com/users/SufyaanBibi/following{/other_user}","gists_url":"https://api.github.com/users/SufyaanBibi/gists{/gist_id}","starred_url":"https://api.github.com/users/SufyaanBibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SufyaanBibi/subscriptions","organizations_url":"https://api.github.com/users/SufyaanBibi/orgs","repos_url":"https://api.github.com/users/SufyaanBibi/repos","events_url":"https://api.github.com/users/SufyaanBibi/events{/privacy}","received_events_url":"https://api.github.com/users/SufyaanBibi/received_events","type":"User","site_admin":false},"repo":{"id":140308864,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMDg4NjQ=","name":"PracticePython","full_name":"SufyaanBibi/PracticePython","owner":{"login":"SufyaanBibi","id":37698037,"node_id":"MDQ6VXNlcjM3Njk4MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/37698037?v=4","gravatar_id":"","url":"https://api.github.com/users/SufyaanBibi","html_url":"https://github.com/SufyaanBibi","followers_url":"https://api.github.com/users/SufyaanBibi/followers","following_url":"https://api.github.com/users/SufyaanBibi/following{/other_user}","gists_url":"https://api.github.com/users/SufyaanBibi/gists{/gist_id}","starred_url":"https://api.github.com/users/SufyaanBibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SufyaanBibi/subscriptions","organizations_url":"https://api.github.com/users/SufyaanBibi/orgs","repos_url":"https://api.github.com/users/SufyaanBibi/repos","events_url":"https://api.github.com/users/SufyaanBibi/events{/privacy}","received_events_url":"https://api.github.com/users/SufyaanBibi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SufyaanBibi/PracticePython","description":"A depository of my practice python exercises ","fork":false,"url":"https://api.github.com/repos/SufyaanBibi/PracticePython","forks_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/forks","keys_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/teams","hooks_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/hooks","issue_events_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/events{/number}","events_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/events","assignees_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/assignees{/user}","branches_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/branches{/branch}","tags_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/tags","blobs_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/refs{/sha}","trees_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/statuses/{sha}","languages_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/languages","stargazers_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/stargazers","contributors_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/contributors","subscribers_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/subscribers","subscription_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/subscription","commits_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/commits{/sha}","git_commits_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/commits{/sha}","comments_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/comments{/number}","issue_comment_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/comments{/number}","contents_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/contents/{+path}","compare_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/merges","archive_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/downloads","issues_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues{/number}","pulls_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls{/number}","milestones_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/milestones{/number}","notifications_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/labels{/name}","releases_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/releases{/id}","deployments_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/deployments","created_at":"2018-07-09T15:56:52Z","updated_at":"2018-07-09T15:56:56Z","pushed_at":"2018-07-09T16:13:14Z","git_url":"git://github.com/SufyaanBibi/PracticePython.git","ssh_url":"git@github.com:SufyaanBibi/PracticePython.git","clone_url":"https://github.com/SufyaanBibi/PracticePython.git","svn_url":"https://github.com/SufyaanBibi/PracticePython","homepage":null,"size":699,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"SufyaanBibi:develop","ref":"develop","sha":"5019263cca70867c3f79093760bad49042d61b95","user":{"login":"SufyaanBibi","id":37698037,"node_id":"MDQ6VXNlcjM3Njk4MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/37698037?v=4","gravatar_id":"","url":"https://api.github.com/users/SufyaanBibi","html_url":"https://github.com/SufyaanBibi","followers_url":"https://api.github.com/users/SufyaanBibi/followers","following_url":"https://api.github.com/users/SufyaanBibi/following{/other_user}","gists_url":"https://api.github.com/users/SufyaanBibi/gists{/gist_id}","starred_url":"https://api.github.com/users/SufyaanBibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SufyaanBibi/subscriptions","organizations_url":"https://api.github.com/users/SufyaanBibi/orgs","repos_url":"https://api.github.com/users/SufyaanBibi/repos","events_url":"https://api.github.com/users/SufyaanBibi/events{/privacy}","received_events_url":"https://api.github.com/users/SufyaanBibi/received_events","type":"User","site_admin":false},"repo":{"id":140308864,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzMDg4NjQ=","name":"PracticePython","full_name":"SufyaanBibi/PracticePython","owner":{"login":"SufyaanBibi","id":37698037,"node_id":"MDQ6VXNlcjM3Njk4MDM3","avatar_url":"https://avatars0.githubusercontent.com/u/37698037?v=4","gravatar_id":"","url":"https://api.github.com/users/SufyaanBibi","html_url":"https://github.com/SufyaanBibi","followers_url":"https://api.github.com/users/SufyaanBibi/followers","following_url":"https://api.github.com/users/SufyaanBibi/following{/other_user}","gists_url":"https://api.github.com/users/SufyaanBibi/gists{/gist_id}","starred_url":"https://api.github.com/users/SufyaanBibi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SufyaanBibi/subscriptions","organizations_url":"https://api.github.com/users/SufyaanBibi/orgs","repos_url":"https://api.github.com/users/SufyaanBibi/repos","events_url":"https://api.github.com/users/SufyaanBibi/events{/privacy}","received_events_url":"https://api.github.com/users/SufyaanBibi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SufyaanBibi/PracticePython","description":"A depository of my practice python exercises ","fork":false,"url":"https://api.github.com/repos/SufyaanBibi/PracticePython","forks_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/forks","keys_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/teams","hooks_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/hooks","issue_events_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/events{/number}","events_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/events","assignees_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/assignees{/user}","branches_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/branches{/branch}","tags_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/tags","blobs_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/refs{/sha}","trees_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/statuses/{sha}","languages_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/languages","stargazers_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/stargazers","contributors_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/contributors","subscribers_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/subscribers","subscription_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/subscription","commits_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/commits{/sha}","git_commits_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/git/commits{/sha}","comments_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/comments{/number}","issue_comment_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/comments{/number}","contents_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/contents/{+path}","compare_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/merges","archive_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/downloads","issues_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues{/number}","pulls_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls{/number}","milestones_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/milestones{/number}","notifications_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/labels{/name}","releases_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/releases{/id}","deployments_url":"https://api.github.com/repos/SufyaanBibi/PracticePython/deployments","created_at":"2018-07-09T15:56:52Z","updated_at":"2018-07-09T15:56:56Z","pushed_at":"2018-07-09T16:13:14Z","git_url":"git://github.com/SufyaanBibi/PracticePython.git","ssh_url":"git@github.com:SufyaanBibi/PracticePython.git","clone_url":"https://github.com/SufyaanBibi/PracticePython.git","svn_url":"https://github.com/SufyaanBibi/PracticePython","homepage":null,"size":699,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1"},"html":{"href":"https://github.com/SufyaanBibi/PracticePython/pull/1"},"issue":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/1"},"comments":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/SufyaanBibi/PracticePython/statuses/be24be60b0c1b52831e3564f2f793c354a9b3ac4"}},"author_association":"OWNER"}}
{"actor":{"display_login":"BasilBibi"}}