{"action":"created","comment":{"url":"https://api.github.com/repos/adobe/helix-pipeline/pulls/comments/242540593","pull_request_review_id":186072987,"id":242540593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjU0MDU5Mw==","diff_hunk":"@@ -25,18 +25,11 @@\n                 \"/index.html?foo=bar\"\n             ]\n         },\n-        \"resourcePath\": {\n-            \"type\": \"string\",\n-            \"description\": \"The resource path (without extension) that has been requested\",\n-            \"examples\": [\n-                \"/index\"\n-            ]\n-        },","path":"docs/request.schema.json","position":10,"original_position":10,"commit_id":"e5e8763107175d56952bd4a16b5027e031c3f706","original_commit_id":"466f378bf1f2bfe4de3019393ce405e3f3a4110d","user":{"login":"trieloff","id":39613,"node_id":"MDQ6VXNlcjM5NjEz","avatar_url":"https://avatars3.githubusercontent.com/u/39613?v=4","gravatar_id":"","url":"https://api.github.com/users/trieloff","html_url":"https://github.com/trieloff","followers_url":"https://api.github.com/users/trieloff/followers","following_url":"https://api.github.com/users/trieloff/following{/other_user}","gists_url":"https://api.github.com/users/trieloff/gists{/gist_id}","starred_url":"https://api.github.com/users/trieloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trieloff/subscriptions","organizations_url":"https://api.github.com/users/trieloff/orgs","repos_url":"https://api.github.com/users/trieloff/repos","events_url":"https://api.github.com/users/trieloff/events{/privacy}","received_events_url":"https://api.github.com/users/trieloff/received_events","type":"User","site_admin":false},"body":"I'd drop it. We can't do proper (read: Sling-like) resource resolution anyway and it would only be a duplication of the owner, repo, ref, path quadruple that we use to address content.","created_at":"2018-12-18T13:44:02Z","updated_at":"2018-12-18T13:44:03Z","html_url":"https://github.com/adobe/helix-pipeline/pull/141#discussion_r242540593","pull_request_url":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/adobe/helix-pipeline/pulls/comments/242540593"},"html":{"href":"https://github.com/adobe/helix-pipeline/pull/141#discussion_r242540593"},"pull_request":{"href":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141"}},"in_reply_to_id":242461015},"pull_request":{"url":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141","id":239412426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDEyNDI2","html_url":"https://github.com/adobe/helix-pipeline/pull/141","diff_url":"https://github.com/adobe/helix-pipeline/pull/141.diff","patch_url":"https://github.com/adobe/helix-pipeline/pull/141.patch","issue_url":"https://api.github.com/repos/adobe/helix-pipeline/issues/141","number":141,"state":"open","locked":false,"title":"Consolidate request properties in dev and publish env #140","user":{"login":"rofe","id":1609742,"node_id":"MDQ6VXNlcjE2MDk3NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1609742?v=4","gravatar_id":"","url":"https://api.github.com/users/rofe","html_url":"https://github.com/rofe","followers_url":"https://api.github.com/users/rofe/followers","following_url":"https://api.github.com/users/rofe/following{/other_user}","gists_url":"https://api.github.com/users/rofe/gists{/gist_id}","starred_url":"https://api.github.com/users/rofe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rofe/subscriptions","organizations_url":"https://api.github.com/users/rofe/orgs","repos_url":"https://api.github.com/users/rofe/repos","events_url":"https://api.github.com/users/rofe/events{/privacy}","received_events_url":"https://api.github.com/users/rofe/received_events","type":"User","site_admin":false},"body":"Fixes #140 ","created_at":"2018-12-18T09:11:14Z","updated_at":"2018-12-18T13:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5444cfaceb2a44fd8292e61f1867bbb8c86c8cbd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"trieloff","id":39613,"node_id":"MDQ6VXNlcjM5NjEz","avatar_url":"https://avatars3.githubusercontent.com/u/39613?v=4","gravatar_id":"","url":"https://api.github.com/users/trieloff","html_url":"https://github.com/trieloff","followers_url":"https://api.github.com/users/trieloff/followers","following_url":"https://api.github.com/users/trieloff/following{/other_user}","gists_url":"https://api.github.com/users/trieloff/gists{/gist_id}","starred_url":"https://api.github.com/users/trieloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trieloff/subscriptions","organizations_url":"https://api.github.com/users/trieloff/orgs","repos_url":"https://api.github.com/users/trieloff/repos","events_url":"https://api.github.com/users/trieloff/events{/privacy}","received_events_url":"https://api.github.com/users/trieloff/received_events","type":"User","site_admin":false},{"login":"kptdobe","id":474200,"node_id":"MDQ6VXNlcjQ3NDIwMA==","avatar_url":"https://avatars3.githubusercontent.com/u/474200?v=4","gravatar_id":"","url":"https://api.github.com/users/kptdobe","html_url":"https://github.com/kptdobe","followers_url":"https://api.github.com/users/kptdobe/followers","following_url":"https://api.github.com/users/kptdobe/following{/other_user}","gists_url":"https://api.github.com/users/kptdobe/gists{/gist_id}","starred_url":"https://api.github.com/users/kptdobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kptdobe/subscriptions","organizations_url":"https://api.github.com/users/kptdobe/orgs","repos_url":"https://api.github.com/users/kptdobe/repos","events_url":"https://api.github.com/users/kptdobe/events{/privacy}","received_events_url":"https://api.github.com/users/kptdobe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141/commits","review_comments_url":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141/comments","review_comment_url":"https://api.github.com/repos/adobe/helix-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe/helix-pipeline/issues/141/comments","statuses_url":"https://api.github.com/repos/adobe/helix-pipeline/statuses/e5e8763107175d56952bd4a16b5027e031c3f706","head":{"label":"adobe:request-props","ref":"request-props","sha":"e5e8763107175d56952bd4a16b5027e031c3f706","user":{"login":"adobe","id":476009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":138998076,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5OTgwNzY=","name":"helix-pipeline","full_name":"adobe/helix-pipeline","private":false,"owner":{"login":"adobe","id":476009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adobe/helix-pipeline","description":null,"fork":false,"url":"https://api.github.com/repos/adobe/helix-pipeline","forks_url":"https://api.github.com/repos/adobe/helix-pipeline/forks","keys_url":"https://api.github.com/repos/adobe/helix-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/helix-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/helix-pipeline/teams","hooks_url":"https://api.github.com/repos/adobe/helix-pipeline/hooks","issue_events_url":"https://api.github.com/repos/adobe/helix-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/helix-pipeline/events","assignees_url":"https://api.github.com/repos/adobe/helix-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/helix-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/helix-pipeline/tags","blobs_url":"https://api.github.com/repos/adobe/helix-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/helix-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/helix-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/helix-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/helix-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/helix-pipeline/languages","stargazers_url":"https://api.github.com/repos/adobe/helix-pipeline/stargazers","contributors_url":"https://api.github.com/repos/adobe/helix-pipeline/contributors","subscribers_url":"https://api.github.com/repos/adobe/helix-pipeline/subscribers","subscription_url":"https://api.github.com/repos/adobe/helix-pipeline/subscription","commits_url":"https://api.github.com/repos/adobe/helix-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/helix-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/helix-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/helix-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/helix-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/helix-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/helix-pipeline/merges","archive_url":"https://api.github.com/repos/adobe/helix-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/helix-pipeline/downloads","issues_url":"https://api.github.com/repos/adobe/helix-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/helix-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/helix-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/helix-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/helix-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/adobe/helix-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/helix-pipeline/deployments","created_at":"2018-06-28T09:38:29Z","updated_at":"2018-12-13T02:07:56Z","pushed_at":"2018-12-18T12:26:15Z","git_url":"git://github.com/adobe/helix-pipeline.git","ssh_url":"git@github.com:adobe/helix-pipeline.git","clone_url":"https://github.com/adobe/helix-pipeline.git","svn_url":"https://github.com/adobe/helix-pipeline","homepage":null,"size":948,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":22,"watchers":2,"default_branch":"master"}},"base":{"label":"adobe:master","ref":"master","sha":"6f6b0869cf503be736d583c4924e16505623126d","user":{"login":"adobe","id":476009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"repo":{"id":138998076,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg5OTgwNzY=","name":"helix-pipeline","full_name":"adobe/helix-pipeline","private":false,"owner":{"login":"adobe","id":476009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjAwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/476009?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe","html_url":"https://github.com/adobe","followers_url":"https://api.github.com/users/adobe/followers","following_url":"https://api.github.com/users/adobe/following{/other_user}","gists_url":"https://api.github.com/users/adobe/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe/subscriptions","organizations_url":"https://api.github.com/users/adobe/orgs","repos_url":"https://api.github.com/users/adobe/repos","events_url":"https://api.github.com/users/adobe/events{/privacy}","received_events_url":"https://api.github.com/users/adobe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/adobe/helix-pipeline","description":null,"fork":false,"url":"https://api.github.com/repos/adobe/helix-pipeline","forks_url":"https://api.github.com/repos/adobe/helix-pipeline/forks","keys_url":"https://api.github.com/repos/adobe/helix-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe/helix-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe/helix-pipeline/teams","hooks_url":"https://api.github.com/repos/adobe/helix-pipeline/hooks","issue_events_url":"https://api.github.com/repos/adobe/helix-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/adobe/helix-pipeline/events","assignees_url":"https://api.github.com/repos/adobe/helix-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/adobe/helix-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/adobe/helix-pipeline/tags","blobs_url":"https://api.github.com/repos/adobe/helix-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe/helix-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe/helix-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe/helix-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe/helix-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe/helix-pipeline/languages","stargazers_url":"https://api.github.com/repos/adobe/helix-pipeline/stargazers","contributors_url":"https://api.github.com/repos/adobe/helix-pipeline/contributors","subscribers_url":"https://api.github.com/repos/adobe/helix-pipeline/subscribers","subscription_url":"https://api.github.com/repos/adobe/helix-pipeline/subscription","commits_url":"https://api.github.com/repos/adobe/helix-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe/helix-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe/helix-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe/helix-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe/helix-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/adobe/helix-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe/helix-pipeline/merges","archive_url":"https://api.github.com/repos/adobe/helix-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe/helix-pipeline/downloads","issues_url":"https://api.github.com/repos/adobe/helix-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/adobe/helix-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe/helix-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe/helix-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe/helix-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/adobe/helix-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/adobe/helix-pipeline/deployments","created_at":"2018-06-28T09:38:29Z","updated_at":"2018-12-13T02:07:56Z","pushed_at":"2018-12-18T12:26:15Z","git_url":"git://github.com/adobe/helix-pipeline.git","ssh_url":"git@github.com:adobe/helix-pipeline.git","clone_url":"https://github.com/adobe/helix-pipeline.git","svn_url":"https://github.com/adobe/helix-pipeline","homepage":null,"size":948,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":22,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141"},"html":{"href":"https://github.com/adobe/helix-pipeline/pull/141"},"issue":{"href":"https://api.github.com/repos/adobe/helix-pipeline/issues/141"},"comments":{"href":"https://api.github.com/repos/adobe/helix-pipeline/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe/helix-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe/helix-pipeline/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/adobe/helix-pipeline/statuses/e5e8763107175d56952bd4a16b5027e031c3f706"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"trieloff"}}