{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35041","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35041/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35041/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35041/events","html_url":"https://github.com/NixOS/nixpkgs/pull/35041","id":297806003,"number":35041,"title":"tree-wide: no pulseaudio by default","user":{"login":"oxij","id":391919,"avatar_url":"https://avatars2.githubusercontent.com/u/391919?v=4","gravatar_id":"","url":"https://api.github.com/users/oxij","html_url":"https://github.com/oxij","followers_url":"https://api.github.com/users/oxij/followers","following_url":"https://api.github.com/users/oxij/following{/other_user}","gists_url":"https://api.github.com/users/oxij/gists{/gist_id}","starred_url":"https://api.github.com/users/oxij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxij/subscriptions","organizations_url":"https://api.github.com/users/oxij/orgs","repos_url":"https://api.github.com/users/oxij/repos","events_url":"https://api.github.com/users/oxij/events{/privacy}","received_events_url":"https://api.github.com/users/oxij/received_events","type":"User","site_admin":false},"labels":[{"id":731735222,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734523,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":60265212,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-16T14:39:28Z","updated_at":"2018-02-16T16:39:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/35041","html_url":"https://github.com/NixOS/nixpkgs/pull/35041","diff_url":"https://github.com/NixOS/nixpkgs/pull/35041.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/35041.patch"},"body":"###### Motivation for this change\r\n\r\nI run with `config.pulseaudio = false` for years, it works perfectly.\r\nBut having it enabled by default in some packages and disabled in others in nixpkgs sends a mixed message: many people think that you need this broken piece of insecure bloatware to have sound, which is as far from being true as humanly possible (see #29250).\r\n\r\nLets just disable it by default so that \"its already in the closure, so lets add it proper\" (see #24012, #35005) motivation goes away.\r\nAlso lets just disable it by default to minimize the attack surface it provides.\r\n\r\nIf you think you need it by default go read #29250. If you think its ok to have it by default go read #29250.\r\n\r\nIf you do use it, the second patch to nixos now enables it.\r\n\r\n###### Things done\r\n\r\n- [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [X] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Tested execution of many binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/366288273","html_url":"https://github.com/NixOS/nixpkgs/pull/35041#issuecomment-366288273","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/35041","id":366288273,"user":{"login":"oxij","id":391919,"avatar_url":"https://avatars2.githubusercontent.com/u/391919?v=4","gravatar_id":"","url":"https://api.github.com/users/oxij","html_url":"https://github.com/oxij","followers_url":"https://api.github.com/users/oxij/followers","following_url":"https://api.github.com/users/oxij/following{/other_user}","gists_url":"https://api.github.com/users/oxij/gists{/gist_id}","starred_url":"https://api.github.com/users/oxij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oxij/subscriptions","organizations_url":"https://api.github.com/users/oxij/orgs","repos_url":"https://api.github.com/users/oxij/repos","events_url":"https://api.github.com/users/oxij/events{/privacy}","received_events_url":"https://api.github.com/users/oxij/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T16:39:27Z","updated_at":"2018-02-16T16:39:27Z","author_association":"CONTRIBUTOR","body":"Right, the higher-tier SLNOS branch does exactly this (SLNOS is separated into tiers, from very NixOS-like experience where most of hydra cache still helps, to the very suckless system where you have to rebuild everything yourself).\r\n\r\nTo be honest, in the current state of things I wouldn't merge this PR to NixOS myself (I made it to make a point that it is that easy to get 90% there with only trivial changes). What I would do is I would still disable libpulseaudio for all the leaf packages, but leave it enabled by default for libraries like libao and ffmpeg. This seems like a okay middle ground suitable for NixOS to me. We can discuss the finer points of this if anyone cares."}}
{"actor":{"display_login":"oxij"}}