{"action":"created","comment":{"url":"https://api.github.com/repos/davidsansome/tsurukame/pulls/comments/223230297","pull_request_review_id":162306931,"id":223230297,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIzMDI5Nw==","diff_hunk":"@@ -323,6 +323,22 @@ static void EnsureInitialised() {\n   });\n }\n \n+NSString *convertHiraganaToKatakana(NSString *string) {\n+    int differenceHiraganaKatakana = u'ア' - u'あ';","path":"ios/TKMKanaInput.m","position":5,"original_position":5,"commit_id":"ba740a829883e4435579556a7a187687c78eacb2","original_commit_id":"ba740a829883e4435579556a7a187687c78eacb2","user":{"login":"davidsansome","id":314463,"node_id":"MDQ6VXNlcjMxNDQ2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/314463?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsansome","html_url":"https://github.com/davidsansome","followers_url":"https://api.github.com/users/davidsansome/followers","following_url":"https://api.github.com/users/davidsansome/following{/other_user}","gists_url":"https://api.github.com/users/davidsansome/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsansome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsansome/subscriptions","organizations_url":"https://api.github.com/users/davidsansome/orgs","repos_url":"https://api.github.com/users/davidsansome/repos","events_url":"https://api.github.com/users/davidsansome/events{/privacy}","received_events_url":"https://api.github.com/users/davidsansome/received_events","type":"User","site_admin":false},"body":"Please use 2-space indentation throughout","created_at":"2018-10-07T22:15:25Z","updated_at":"2018-10-07T22:40:13Z","html_url":"https://github.com/davidsansome/tsurukame/pull/56#discussion_r223230297","pull_request_url":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/davidsansome/tsurukame/pulls/comments/223230297"},"html":{"href":"https://github.com/davidsansome/tsurukame/pull/56#discussion_r223230297"},"pull_request":{"href":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56","id":220967110,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTY3MTEw","html_url":"https://github.com/davidsansome/tsurukame/pull/56","diff_url":"https://github.com/davidsansome/tsurukame/pull/56.diff","patch_url":"https://github.com/davidsansome/tsurukame/pull/56.patch","issue_url":"https://api.github.com/repos/davidsansome/tsurukame/issues/56","number":56,"state":"open","locked":false,"title":"Katakana can now be typed into the Textfield","user":{"login":"hesch","id":10466994,"node_id":"MDQ6VXNlcjEwNDY2OTk0","avatar_url":"https://avatars3.githubusercontent.com/u/10466994?v=4","gravatar_id":"","url":"https://api.github.com/users/hesch","html_url":"https://github.com/hesch","followers_url":"https://api.github.com/users/hesch/followers","following_url":"https://api.github.com/users/hesch/following{/other_user}","gists_url":"https://api.github.com/users/hesch/gists{/gist_id}","starred_url":"https://api.github.com/users/hesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesch/subscriptions","organizations_url":"https://api.github.com/users/hesch/orgs","repos_url":"https://api.github.com/users/hesch/repos","events_url":"https://api.github.com/users/hesch/events{/privacy}","received_events_url":"https://api.github.com/users/hesch/received_events","type":"User","site_admin":false},"body":"I added the capability to type in Katakana into the review textfield. It is not 100% equivalent with the WaniKani input (e.g. my implementation converts Nn to ン, WaniKani does not). I also added some simple tests for this functionality. Solves the first Issue of #38","created_at":"2018-10-07T19:17:05Z","updated_at":"2018-10-07T22:40:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4595b50b2302851ee9627b9ca0cd67959761bf3f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56/commits","review_comments_url":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56/comments","review_comment_url":"https://api.github.com/repos/davidsansome/tsurukame/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davidsansome/tsurukame/issues/56/comments","statuses_url":"https://api.github.com/repos/davidsansome/tsurukame/statuses/ba740a829883e4435579556a7a187687c78eacb2","head":{"label":"hesch:katakana-display","ref":"katakana-display","sha":"ba740a829883e4435579556a7a187687c78eacb2","user":{"login":"hesch","id":10466994,"node_id":"MDQ6VXNlcjEwNDY2OTk0","avatar_url":"https://avatars3.githubusercontent.com/u/10466994?v=4","gravatar_id":"","url":"https://api.github.com/users/hesch","html_url":"https://github.com/hesch","followers_url":"https://api.github.com/users/hesch/followers","following_url":"https://api.github.com/users/hesch/following{/other_user}","gists_url":"https://api.github.com/users/hesch/gists{/gist_id}","starred_url":"https://api.github.com/users/hesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesch/subscriptions","organizations_url":"https://api.github.com/users/hesch/orgs","repos_url":"https://api.github.com/users/hesch/repos","events_url":"https://api.github.com/users/hesch/events{/privacy}","received_events_url":"https://api.github.com/users/hesch/received_events","type":"User","site_admin":false},"repo":{"id":151642680,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2NDI2ODA=","name":"tsurukame","full_name":"hesch/tsurukame","private":false,"owner":{"login":"hesch","id":10466994,"node_id":"MDQ6VXNlcjEwNDY2OTk0","avatar_url":"https://avatars3.githubusercontent.com/u/10466994?v=4","gravatar_id":"","url":"https://api.github.com/users/hesch","html_url":"https://github.com/hesch","followers_url":"https://api.github.com/users/hesch/followers","following_url":"https://api.github.com/users/hesch/following{/other_user}","gists_url":"https://api.github.com/users/hesch/gists{/gist_id}","starred_url":"https://api.github.com/users/hesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hesch/subscriptions","organizations_url":"https://api.github.com/users/hesch/orgs","repos_url":"https://api.github.com/users/hesch/repos","events_url":"https://api.github.com/users/hesch/events{/privacy}","received_events_url":"https://api.github.com/users/hesch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hesch/tsurukame","description":null,"fork":true,"url":"https://api.github.com/repos/hesch/tsurukame","forks_url":"https://api.github.com/repos/hesch/tsurukame/forks","keys_url":"https://api.github.com/repos/hesch/tsurukame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hesch/tsurukame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hesch/tsurukame/teams","hooks_url":"https://api.github.com/repos/hesch/tsurukame/hooks","issue_events_url":"https://api.github.com/repos/hesch/tsurukame/issues/events{/number}","events_url":"https://api.github.com/repos/hesch/tsurukame/events","assignees_url":"https://api.github.com/repos/hesch/tsurukame/assignees{/user}","branches_url":"https://api.github.com/repos/hesch/tsurukame/branches{/branch}","tags_url":"https://api.github.com/repos/hesch/tsurukame/tags","blobs_url":"https://api.github.com/repos/hesch/tsurukame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hesch/tsurukame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hesch/tsurukame/git/refs{/sha}","trees_url":"https://api.github.com/repos/hesch/tsurukame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hesch/tsurukame/statuses/{sha}","languages_url":"https://api.github.com/repos/hesch/tsurukame/languages","stargazers_url":"https://api.github.com/repos/hesch/tsurukame/stargazers","contributors_url":"https://api.github.com/repos/hesch/tsurukame/contributors","subscribers_url":"https://api.github.com/repos/hesch/tsurukame/subscribers","subscription_url":"https://api.github.com/repos/hesch/tsurukame/subscription","commits_url":"https://api.github.com/repos/hesch/tsurukame/commits{/sha}","git_commits_url":"https://api.github.com/repos/hesch/tsurukame/git/commits{/sha}","comments_url":"https://api.github.com/repos/hesch/tsurukame/comments{/number}","issue_comment_url":"https://api.github.com/repos/hesch/tsurukame/issues/comments{/number}","contents_url":"https://api.github.com/repos/hesch/tsurukame/contents/{+path}","compare_url":"https://api.github.com/repos/hesch/tsurukame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hesch/tsurukame/merges","archive_url":"https://api.github.com/repos/hesch/tsurukame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hesch/tsurukame/downloads","issues_url":"https://api.github.com/repos/hesch/tsurukame/issues{/number}","pulls_url":"https://api.github.com/repos/hesch/tsurukame/pulls{/number}","milestones_url":"https://api.github.com/repos/hesch/tsurukame/milestones{/number}","notifications_url":"https://api.github.com/repos/hesch/tsurukame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hesch/tsurukame/labels{/name}","releases_url":"https://api.github.com/repos/hesch/tsurukame/releases{/id}","deployments_url":"https://api.github.com/repos/hesch/tsurukame/deployments","created_at":"2018-10-04T22:16:32Z","updated_at":"2018-10-04T22:16:35Z","pushed_at":"2018-10-07T19:42:38Z","git_url":"git://github.com/hesch/tsurukame.git","ssh_url":"git@github.com:hesch/tsurukame.git","clone_url":"https://github.com/hesch/tsurukame.git","svn_url":"https://github.com/hesch/tsurukame","homepage":null,"size":23396,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davidsansome:master","ref":"master","sha":"cd09347e28cf656b24950e36beb9bdb183c156c1","user":{"login":"davidsansome","id":314463,"node_id":"MDQ6VXNlcjMxNDQ2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/314463?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsansome","html_url":"https://github.com/davidsansome","followers_url":"https://api.github.com/users/davidsansome/followers","following_url":"https://api.github.com/users/davidsansome/following{/other_user}","gists_url":"https://api.github.com/users/davidsansome/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsansome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsansome/subscriptions","organizations_url":"https://api.github.com/users/davidsansome/orgs","repos_url":"https://api.github.com/users/davidsansome/repos","events_url":"https://api.github.com/users/davidsansome/events{/privacy}","received_events_url":"https://api.github.com/users/davidsansome/received_events","type":"User","site_admin":false},"repo":{"id":111207450,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyMDc0NTA=","name":"tsurukame","full_name":"davidsansome/tsurukame","private":false,"owner":{"login":"davidsansome","id":314463,"node_id":"MDQ6VXNlcjMxNDQ2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/314463?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsansome","html_url":"https://github.com/davidsansome","followers_url":"https://api.github.com/users/davidsansome/followers","following_url":"https://api.github.com/users/davidsansome/following{/other_user}","gists_url":"https://api.github.com/users/davidsansome/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsansome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsansome/subscriptions","organizations_url":"https://api.github.com/users/davidsansome/orgs","repos_url":"https://api.github.com/users/davidsansome/repos","events_url":"https://api.github.com/users/davidsansome/events{/privacy}","received_events_url":"https://api.github.com/users/davidsansome/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidsansome/tsurukame","description":null,"fork":false,"url":"https://api.github.com/repos/davidsansome/tsurukame","forks_url":"https://api.github.com/repos/davidsansome/tsurukame/forks","keys_url":"https://api.github.com/repos/davidsansome/tsurukame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidsansome/tsurukame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidsansome/tsurukame/teams","hooks_url":"https://api.github.com/repos/davidsansome/tsurukame/hooks","issue_events_url":"https://api.github.com/repos/davidsansome/tsurukame/issues/events{/number}","events_url":"https://api.github.com/repos/davidsansome/tsurukame/events","assignees_url":"https://api.github.com/repos/davidsansome/tsurukame/assignees{/user}","branches_url":"https://api.github.com/repos/davidsansome/tsurukame/branches{/branch}","tags_url":"https://api.github.com/repos/davidsansome/tsurukame/tags","blobs_url":"https://api.github.com/repos/davidsansome/tsurukame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidsansome/tsurukame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidsansome/tsurukame/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidsansome/tsurukame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidsansome/tsurukame/statuses/{sha}","languages_url":"https://api.github.com/repos/davidsansome/tsurukame/languages","stargazers_url":"https://api.github.com/repos/davidsansome/tsurukame/stargazers","contributors_url":"https://api.github.com/repos/davidsansome/tsurukame/contributors","subscribers_url":"https://api.github.com/repos/davidsansome/tsurukame/subscribers","subscription_url":"https://api.github.com/repos/davidsansome/tsurukame/subscription","commits_url":"https://api.github.com/repos/davidsansome/tsurukame/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidsansome/tsurukame/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidsansome/tsurukame/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidsansome/tsurukame/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidsansome/tsurukame/contents/{+path}","compare_url":"https://api.github.com/repos/davidsansome/tsurukame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidsansome/tsurukame/merges","archive_url":"https://api.github.com/repos/davidsansome/tsurukame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidsansome/tsurukame/downloads","issues_url":"https://api.github.com/repos/davidsansome/tsurukame/issues{/number}","pulls_url":"https://api.github.com/repos/davidsansome/tsurukame/pulls{/number}","milestones_url":"https://api.github.com/repos/davidsansome/tsurukame/milestones{/number}","notifications_url":"https://api.github.com/repos/davidsansome/tsurukame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidsansome/tsurukame/labels{/name}","releases_url":"https://api.github.com/repos/davidsansome/tsurukame/releases{/id}","deployments_url":"https://api.github.com/repos/davidsansome/tsurukame/deployments","created_at":"2017-11-18T13:24:11Z","updated_at":"2018-10-07T22:27:27Z","pushed_at":"2018-10-07T19:42:39Z","git_url":"git://github.com/davidsansome/tsurukame.git","ssh_url":"git@github.com:davidsansome/tsurukame.git","clone_url":"https://github.com/davidsansome/tsurukame.git","svn_url":"https://github.com/davidsansome/tsurukame","homepage":null,"size":28008,"stargazers_count":14,"watchers_count":14,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":27,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56"},"html":{"href":"https://github.com/davidsansome/tsurukame/pull/56"},"issue":{"href":"https://api.github.com/repos/davidsansome/tsurukame/issues/56"},"comments":{"href":"https://api.github.com/repos/davidsansome/tsurukame/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/davidsansome/tsurukame/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davidsansome/tsurukame/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/davidsansome/tsurukame/statuses/ba740a829883e4435579556a7a187687c78eacb2"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidsansome"}}