{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/190301995","pull_request_review_id":122651143,"id":190301995,"diff_hunk":"@@ -546,7 +558,7 @@ public StreamProperties visitSample(SampleNode node, List<StreamProperties> inpu\n \n         private final Optional<List<Symbol>> partitioningColumns; // if missing => partitioned with some unknown scheme\n \n-        private final boolean ordered;\n+        private final Optional<OrderingScheme> ordering;","path":"presto-main/src/main/java/com/facebook/presto/sql/planner/optimizations/StreamPropertyDerivations.java","position":113,"original_position":113,"commit_id":"03f6c4ab3a971db299ca3a238db3a987291dc649","original_commit_id":"03f6c4ab3a971db299ca3a238db3a987291dc649","user":{"login":"mbasmanova","id":27965151,"avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"body":"@martint @sopel39 Are we going to delete `boolean ordered;` flag and update the code to set and check `otherActualProperties.local.grouping(cols)` instead?","created_at":"2018-05-23T15:50:07Z","updated_at":"2018-05-23T15:50:07Z","html_url":"https://github.com/prestodb/presto/pull/10682#discussion_r190301995","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/10682","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/190301995"},"html":{"href":"https://github.com/prestodb/presto/pull/10682#discussion_r190301995"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10682"}},"in_reply_to_id":190256436},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/10682","id":189933923,"html_url":"https://github.com/prestodb/presto/pull/10682","diff_url":"https://github.com/prestodb/presto/pull/10682.diff","patch_url":"https://github.com/prestodb/presto/pull/10682.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/10682","number":10682,"state":"open","locked":false,"title":"WIP assign unique id stream properties","user":{"login":"sopel39","id":5989165,"avatar_url":"https://avatars1.githubusercontent.com/u/5989165?v=4","gravatar_id":"","url":"https://api.github.com/users/sopel39","html_url":"https://github.com/sopel39","followers_url":"https://api.github.com/users/sopel39/followers","following_url":"https://api.github.com/users/sopel39/following{/other_user}","gists_url":"https://api.github.com/users/sopel39/gists{/gist_id}","starred_url":"https://api.github.com/users/sopel39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sopel39/subscriptions","organizations_url":"https://api.github.com/users/sopel39/orgs","repos_url":"https://api.github.com/users/sopel39/repos","events_url":"https://api.github.com/users/sopel39/events{/privacy}","received_events_url":"https://api.github.com/users/sopel39/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-23T10:54:21Z","updated_at":"2018-05-23T15:50:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24da64a683d79160890c63e73f30cbc43312acac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/10682/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/10682/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/10682/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/03f6c4ab3a971db299ca3a238db3a987291dc649","head":{"label":"starburstdata:ks/assign_unique_id_stream_properties","ref":"ks/assign_unique_id_stream_properties","sha":"03f6c4ab3a971db299ca3a238db3a987291dc649","user":{"login":"starburstdata","id":33209422,"avatar_url":"https://avatars3.githubusercontent.com/u/33209422?v=4","gravatar_id":"","url":"https://api.github.com/users/starburstdata","html_url":"https://github.com/starburstdata","followers_url":"https://api.github.com/users/starburstdata/followers","following_url":"https://api.github.com/users/starburstdata/following{/other_user}","gists_url":"https://api.github.com/users/starburstdata/gists{/gist_id}","starred_url":"https://api.github.com/users/starburstdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starburstdata/subscriptions","organizations_url":"https://api.github.com/users/starburstdata/orgs","repos_url":"https://api.github.com/users/starburstdata/repos","events_url":"https://api.github.com/users/starburstdata/events{/privacy}","received_events_url":"https://api.github.com/users/starburstdata/received_events","type":"Organization","site_admin":false},"repo":{"id":108882128,"name":"presto","full_name":"starburstdata/presto","owner":{"login":"starburstdata","id":33209422,"avatar_url":"https://avatars3.githubusercontent.com/u/33209422?v=4","gravatar_id":"","url":"https://api.github.com/users/starburstdata","html_url":"https://github.com/starburstdata","followers_url":"https://api.github.com/users/starburstdata/followers","following_url":"https://api.github.com/users/starburstdata/following{/other_user}","gists_url":"https://api.github.com/users/starburstdata/gists{/gist_id}","starred_url":"https://api.github.com/users/starburstdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starburstdata/subscriptions","organizations_url":"https://api.github.com/users/starburstdata/orgs","repos_url":"https://api.github.com/users/starburstdata/repos","events_url":"https://api.github.com/users/starburstdata/events{/privacy}","received_events_url":"https://api.github.com/users/starburstdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/starburstdata/presto","description":"Starburst Enterprise Distribution of Presto","fork":true,"url":"https://api.github.com/repos/starburstdata/presto","forks_url":"https://api.github.com/repos/starburstdata/presto/forks","keys_url":"https://api.github.com/repos/starburstdata/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starburstdata/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starburstdata/presto/teams","hooks_url":"https://api.github.com/repos/starburstdata/presto/hooks","issue_events_url":"https://api.github.com/repos/starburstdata/presto/issues/events{/number}","events_url":"https://api.github.com/repos/starburstdata/presto/events","assignees_url":"https://api.github.com/repos/starburstdata/presto/assignees{/user}","branches_url":"https://api.github.com/repos/starburstdata/presto/branches{/branch}","tags_url":"https://api.github.com/repos/starburstdata/presto/tags","blobs_url":"https://api.github.com/repos/starburstdata/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starburstdata/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starburstdata/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/starburstdata/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starburstdata/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/starburstdata/presto/languages","stargazers_url":"https://api.github.com/repos/starburstdata/presto/stargazers","contributors_url":"https://api.github.com/repos/starburstdata/presto/contributors","subscribers_url":"https://api.github.com/repos/starburstdata/presto/subscribers","subscription_url":"https://api.github.com/repos/starburstdata/presto/subscription","commits_url":"https://api.github.com/repos/starburstdata/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/starburstdata/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/starburstdata/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/starburstdata/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/starburstdata/presto/contents/{+path}","compare_url":"https://api.github.com/repos/starburstdata/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starburstdata/presto/merges","archive_url":"https://api.github.com/repos/starburstdata/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starburstdata/presto/downloads","issues_url":"https://api.github.com/repos/starburstdata/presto/issues{/number}","pulls_url":"https://api.github.com/repos/starburstdata/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/starburstdata/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/starburstdata/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starburstdata/presto/labels{/name}","releases_url":"https://api.github.com/repos/starburstdata/presto/releases{/id}","deployments_url":"https://api.github.com/repos/starburstdata/presto/deployments","created_at":"2017-10-30T17:05:09Z","updated_at":"2018-05-23T12:27:18Z","pushed_at":"2018-05-23T12:27:16Z","git_url":"git://github.com/starburstdata/presto.git","ssh_url":"git@github.com:starburstdata/presto.git","clone_url":"https://github.com/starburstdata/presto.git","svn_url":"https://github.com/starburstdata/presto","homepage":"https://www.starburstdata.com","size":95394,"stargazers_count":27,"watchers_count":27,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":27,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"4f1cd22ea9777a65102931b238f3ce960dee772e","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"name":"presto","full_name":"prestodb/presto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-05-23T15:37:08Z","pushed_at":"2018-05-23T13:44:30Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":91483,"stargazers_count":7532,"watchers_count":7532,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2531,"mirror_url":null,"archived":false,"open_issues_count":1297,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2531,"open_issues":1297,"watchers":7532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10682"},"html":{"href":"https://github.com/prestodb/presto/pull/10682"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/10682"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/10682/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10682/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/10682/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/03f6c4ab3a971db299ca3a238db3a987291dc649"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mbasmanova"}}