{"action":"closed","number":86,"pull_request":{"url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/86","id":208581963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTgxOTYz","html_url":"https://github.com/feathersjs-ecosystem/feathers-sync/pull/86","diff_url":"https://github.com/feathersjs-ecosystem/feathers-sync/pull/86.diff","patch_url":"https://github.com/feathersjs-ecosystem/feathers-sync/pull/86.patch","issue_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues/86","number":86,"state":"closed","locked":false,"title":"add adapterType option","user":{"login":"ramzes13","id":2761359,"node_id":"MDQ6VXNlcjI3NjEzNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2761359?v=4","gravatar_id":"","url":"https://api.github.com/users/ramzes13","html_url":"https://github.com/ramzes13","followers_url":"https://api.github.com/users/ramzes13/followers","following_url":"https://api.github.com/users/ramzes13/following{/other_user}","gists_url":"https://api.github.com/users/ramzes13/gists{/gist_id}","starred_url":"https://api.github.com/users/ramzes13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramzes13/subscriptions","organizations_url":"https://api.github.com/users/ramzes13/orgs","repos_url":"https://api.github.com/users/ramzes13/repos","events_url":"https://api.github.com/users/ramzes13/events{/privacy}","received_events_url":"https://api.github.com/users/ramzes13/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nHello\r\nI encountered such a problem, when an adapter has a secure url, like: `amqps://user:pass` feathers-sync throw an exception:\r\n`amqps is an invalid adapter (uri amqps)`\r\nIn this PR I added a `adapterType` with which you can choose the explicit adapter.","created_at":"2018-08-15T14:39:11Z","updated_at":"2018-08-16T06:53:10Z","closed_at":"2018-08-16T06:53:10Z","merged_at":null,"merge_commit_sha":"6482306af2caa2101af440374407c2c81834ab45","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/86/commits","review_comments_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/86/comments","review_comment_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues/86/comments","statuses_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/statuses/0eac8bb793d24d7251d1756774252a5c9995783e","head":{"label":"ramzes13:master","ref":"master","sha":"0eac8bb793d24d7251d1756774252a5c9995783e","user":{"login":"ramzes13","id":2761359,"node_id":"MDQ6VXNlcjI3NjEzNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2761359?v=4","gravatar_id":"","url":"https://api.github.com/users/ramzes13","html_url":"https://github.com/ramzes13","followers_url":"https://api.github.com/users/ramzes13/followers","following_url":"https://api.github.com/users/ramzes13/following{/other_user}","gists_url":"https://api.github.com/users/ramzes13/gists{/gist_id}","starred_url":"https://api.github.com/users/ramzes13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramzes13/subscriptions","organizations_url":"https://api.github.com/users/ramzes13/orgs","repos_url":"https://api.github.com/users/ramzes13/repos","events_url":"https://api.github.com/users/ramzes13/events{/privacy}","received_events_url":"https://api.github.com/users/ramzes13/received_events","type":"User","site_admin":false},"repo":{"id":144859939,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4NTk5Mzk=","name":"feathers-sync","full_name":"ramzes13/feathers-sync","owner":{"login":"ramzes13","id":2761359,"node_id":"MDQ6VXNlcjI3NjEzNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2761359?v=4","gravatar_id":"","url":"https://api.github.com/users/ramzes13","html_url":"https://github.com/ramzes13","followers_url":"https://api.github.com/users/ramzes13/followers","following_url":"https://api.github.com/users/ramzes13/following{/other_user}","gists_url":"https://api.github.com/users/ramzes13/gists{/gist_id}","starred_url":"https://api.github.com/users/ramzes13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramzes13/subscriptions","organizations_url":"https://api.github.com/users/ramzes13/orgs","repos_url":"https://api.github.com/users/ramzes13/repos","events_url":"https://api.github.com/users/ramzes13/events{/privacy}","received_events_url":"https://api.github.com/users/ramzes13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ramzes13/feathers-sync","description":"Synchronize service events between Feathers application instances","fork":true,"url":"https://api.github.com/repos/ramzes13/feathers-sync","forks_url":"https://api.github.com/repos/ramzes13/feathers-sync/forks","keys_url":"https://api.github.com/repos/ramzes13/feathers-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ramzes13/feathers-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ramzes13/feathers-sync/teams","hooks_url":"https://api.github.com/repos/ramzes13/feathers-sync/hooks","issue_events_url":"https://api.github.com/repos/ramzes13/feathers-sync/issues/events{/number}","events_url":"https://api.github.com/repos/ramzes13/feathers-sync/events","assignees_url":"https://api.github.com/repos/ramzes13/feathers-sync/assignees{/user}","branches_url":"https://api.github.com/repos/ramzes13/feathers-sync/branches{/branch}","tags_url":"https://api.github.com/repos/ramzes13/feathers-sync/tags","blobs_url":"https://api.github.com/repos/ramzes13/feathers-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ramzes13/feathers-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ramzes13/feathers-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/ramzes13/feathers-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ramzes13/feathers-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/ramzes13/feathers-sync/languages","stargazers_url":"https://api.github.com/repos/ramzes13/feathers-sync/stargazers","contributors_url":"https://api.github.com/repos/ramzes13/feathers-sync/contributors","subscribers_url":"https://api.github.com/repos/ramzes13/feathers-sync/subscribers","subscription_url":"https://api.github.com/repos/ramzes13/feathers-sync/subscription","commits_url":"https://api.github.com/repos/ramzes13/feathers-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/ramzes13/feathers-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/ramzes13/feathers-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/ramzes13/feathers-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/ramzes13/feathers-sync/contents/{+path}","compare_url":"https://api.github.com/repos/ramzes13/feathers-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ramzes13/feathers-sync/merges","archive_url":"https://api.github.com/repos/ramzes13/feathers-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ramzes13/feathers-sync/downloads","issues_url":"https://api.github.com/repos/ramzes13/feathers-sync/issues{/number}","pulls_url":"https://api.github.com/repos/ramzes13/feathers-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/ramzes13/feathers-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/ramzes13/feathers-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ramzes13/feathers-sync/labels{/name}","releases_url":"https://api.github.com/repos/ramzes13/feathers-sync/releases{/id}","deployments_url":"https://api.github.com/repos/ramzes13/feathers-sync/deployments","created_at":"2018-08-15T13:57:34Z","updated_at":"2018-08-15T15:04:39Z","pushed_at":"2018-08-16T06:48:32Z","git_url":"git://github.com/ramzes13/feathers-sync.git","ssh_url":"git@github.com:ramzes13/feathers-sync.git","clone_url":"https://github.com/ramzes13/feathers-sync.git","svn_url":"https://github.com/ramzes13/feathers-sync","homepage":"","size":229,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feathersjs-ecosystem:master","ref":"master","sha":"9cedc20d5ecf8e2039c794903584a4e6de352e7f","user":{"login":"feathersjs-ecosystem","id":32400533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDAwNTMz","avatar_url":"https://avatars2.githubusercontent.com/u/32400533?v=4","gravatar_id":"","url":"https://api.github.com/users/feathersjs-ecosystem","html_url":"https://github.com/feathersjs-ecosystem","followers_url":"https://api.github.com/users/feathersjs-ecosystem/followers","following_url":"https://api.github.com/users/feathersjs-ecosystem/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs-ecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs-ecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs-ecosystem/subscriptions","organizations_url":"https://api.github.com/users/feathersjs-ecosystem/orgs","repos_url":"https://api.github.com/users/feathersjs-ecosystem/repos","events_url":"https://api.github.com/users/feathersjs-ecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs-ecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":32042756,"node_id":"MDEwOlJlcG9zaXRvcnkzMjA0Mjc1Ng==","name":"feathers-sync","full_name":"feathersjs-ecosystem/feathers-sync","owner":{"login":"feathersjs-ecosystem","id":32400533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDAwNTMz","avatar_url":"https://avatars2.githubusercontent.com/u/32400533?v=4","gravatar_id":"","url":"https://api.github.com/users/feathersjs-ecosystem","html_url":"https://github.com/feathersjs-ecosystem","followers_url":"https://api.github.com/users/feathersjs-ecosystem/followers","following_url":"https://api.github.com/users/feathersjs-ecosystem/following{/other_user}","gists_url":"https://api.github.com/users/feathersjs-ecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/feathersjs-ecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feathersjs-ecosystem/subscriptions","organizations_url":"https://api.github.com/users/feathersjs-ecosystem/orgs","repos_url":"https://api.github.com/users/feathersjs-ecosystem/repos","events_url":"https://api.github.com/users/feathersjs-ecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/feathersjs-ecosystem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/feathersjs-ecosystem/feathers-sync","description":"Synchronize service events between Feathers application instances","fork":false,"url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync","forks_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/forks","keys_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/teams","hooks_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/hooks","issue_events_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues/events{/number}","events_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/events","assignees_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/assignees{/user}","branches_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/branches{/branch}","tags_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/tags","blobs_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/languages","stargazers_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/stargazers","contributors_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/contributors","subscribers_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/subscribers","subscription_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/subscription","commits_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/contents/{+path}","compare_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/merges","archive_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/downloads","issues_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues{/number}","pulls_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/labels{/name}","releases_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/releases{/id}","deployments_url":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/deployments","created_at":"2015-03-11T21:42:12Z","updated_at":"2018-08-11T08:18:10Z","pushed_at":"2018-08-15T15:04:38Z","git_url":"git://github.com/feathersjs-ecosystem/feathers-sync.git","ssh_url":"git@github.com:feathersjs-ecosystem/feathers-sync.git","clone_url":"https://github.com/feathersjs-ecosystem/feathers-sync.git","svn_url":"https://github.com/feathersjs-ecosystem/feathers-sync","homepage":"","size":272,"stargazers_count":123,"watchers_count":123,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":1,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/86"},"html":{"href":"https://github.com/feathersjs-ecosystem/feathers-sync/pull/86"},"issue":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues/86"},"comments":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/feathersjs-ecosystem/feathers-sync/statuses/0eac8bb793d24d7251d1756774252a5c9995783e"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"ramzes13"}}