{"action":"closed","number":1613,"pull_request":{"url":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/1613","id":150972439,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUwOTcyNDM5","html_url":"https://github.com/SpiderLabs/ModSecurity/pull/1613","diff_url":"https://github.com/SpiderLabs/ModSecurity/pull/1613.diff","patch_url":"https://github.com/SpiderLabs/ModSecurity/pull/1613.patch","issue_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues/1613","number":1613,"state":"closed","locked":false,"title":"Let body parsers observe SecRequestBodyNoFilesLimit","user":{"login":"allanbomsft","id":21695978,"node_id":"MDQ6VXNlcjIxNjk1OTc4","avatar_url":"https://avatars1.githubusercontent.com/u/21695978?v=4","gravatar_id":"","url":"https://api.github.com/users/allanbomsft","html_url":"https://github.com/allanbomsft","followers_url":"https://api.github.com/users/allanbomsft/followers","following_url":"https://api.github.com/users/allanbomsft/following{/other_user}","gists_url":"https://api.github.com/users/allanbomsft/gists{/gist_id}","starred_url":"https://api.github.com/users/allanbomsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanbomsft/subscriptions","organizations_url":"https://api.github.com/users/allanbomsft/orgs","repos_url":"https://api.github.com/users/allanbomsft/repos","events_url":"https://api.github.com/users/allanbomsft/events{/privacy}","received_events_url":"https://api.github.com/users/allanbomsft/received_events","type":"User","site_admin":false},"body":"Previously, modsecurity_request_body_store would keep feeding the body parsers (JSON/XML/Multipart) even after the SecRequestBodyNoFilesLimit limit was met. This change prevents this. Also, modsecurity_request_body_end now returns an error code when the limit is met, so that a message can be logged for this event.","created_at":"2017-11-06T22:06:39Z","updated_at":"2018-09-05T19:30:20Z","closed_at":"2018-09-05T19:30:20Z","merged_at":null,"merge_commit_sha":"3be441d2a526661e728b6e64db263c5a202b97c6","assignee":{"login":"zimmerle","id":428268,"node_id":"MDQ6VXNlcjQyODI2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/428268?v=4","gravatar_id":"","url":"https://api.github.com/users/zimmerle","html_url":"https://github.com/zimmerle","followers_url":"https://api.github.com/users/zimmerle/followers","following_url":"https://api.github.com/users/zimmerle/following{/other_user}","gists_url":"https://api.github.com/users/zimmerle/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmerle/subscriptions","organizations_url":"https://api.github.com/users/zimmerle/orgs","repos_url":"https://api.github.com/users/zimmerle/repos","events_url":"https://api.github.com/users/zimmerle/events{/privacy}","received_events_url":"https://api.github.com/users/zimmerle/received_events","type":"User","site_admin":false},"assignees":[{"login":"zimmerle","id":428268,"node_id":"MDQ6VXNlcjQyODI2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/428268?v=4","gravatar_id":"","url":"https://api.github.com/users/zimmerle","html_url":"https://github.com/zimmerle","followers_url":"https://api.github.com/users/zimmerle/followers","following_url":"https://api.github.com/users/zimmerle/following{/other_user}","gists_url":"https://api.github.com/users/zimmerle/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmerle/subscriptions","organizations_url":"https://api.github.com/users/zimmerle/orgs","repos_url":"https://api.github.com/users/zimmerle/repos","events_url":"https://api.github.com/users/zimmerle/events{/privacy}","received_events_url":"https://api.github.com/users/zimmerle/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":297098835,"node_id":"MDU6TGFiZWwyOTcwOTg4MzU=","url":"https://api.github.com/repos/SpiderLabs/ModSecurity/labels/2.x","name":"2.x","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/1613/commits","review_comments_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/1613/comments","review_comment_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues/1613/comments","statuses_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/statuses/ef0b61b8a25a2da548c0b8aec5baa5c57be9bf1b","head":{"label":"Microsoft:v2/bodyparserslimit-cherry","ref":"v2/bodyparserslimit-cherry","sha":"ef0b61b8a25a2da548c0b8aec5baa5c57be9bf1b","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":90289274,"node_id":"MDEwOlJlcG9zaXRvcnk5MDI4OTI3NA==","name":"ModSecurity","full_name":"Microsoft/ModSecurity","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ModSecurity","description":"ModSecurity is an open source, cross platform web application firewall (WAF) engine for Apache, IIS and Nginx that is developed by Trustwave's SpiderLabs. It has a robust event-based programming language which provides protection from a range of attacks against web applications and allows for HTTP traffic monitoring, logging and real-time analysis. With over 10,000 deployments world-wide, ModSecurity is the most widely deployed WAF in existence. ","fork":true,"url":"https://api.github.com/repos/Microsoft/ModSecurity","forks_url":"https://api.github.com/repos/Microsoft/ModSecurity/forks","keys_url":"https://api.github.com/repos/Microsoft/ModSecurity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ModSecurity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ModSecurity/teams","hooks_url":"https://api.github.com/repos/Microsoft/ModSecurity/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ModSecurity/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ModSecurity/events","assignees_url":"https://api.github.com/repos/Microsoft/ModSecurity/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ModSecurity/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ModSecurity/tags","blobs_url":"https://api.github.com/repos/Microsoft/ModSecurity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ModSecurity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ModSecurity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ModSecurity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ModSecurity/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ModSecurity/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ModSecurity/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ModSecurity/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ModSecurity/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ModSecurity/subscription","commits_url":"https://api.github.com/repos/Microsoft/ModSecurity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ModSecurity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ModSecurity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ModSecurity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ModSecurity/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ModSecurity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ModSecurity/merges","archive_url":"https://api.github.com/repos/Microsoft/ModSecurity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ModSecurity/downloads","issues_url":"https://api.github.com/repos/Microsoft/ModSecurity/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ModSecurity/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ModSecurity/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ModSecurity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ModSecurity/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ModSecurity/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ModSecurity/deployments","created_at":"2017-05-04T17:11:53Z","updated_at":"2018-08-30T05:15:50Z","pushed_at":"2018-09-05T01:09:36Z","git_url":"git://github.com/Microsoft/ModSecurity.git","ssh_url":"git@github.com:Microsoft/ModSecurity.git","clone_url":"https://github.com/Microsoft/ModSecurity.git","svn_url":"https://github.com/Microsoft/ModSecurity","homepage":"www.modsecurity.org","size":41385,"stargazers_count":11,"watchers_count":11,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":2,"watchers":11,"default_branch":"v2/master"}},"base":{"label":"SpiderLabs:v2/master","ref":"v2/master","sha":"4ee1d9c1796700bb85a494291fc3a6f27410c068","user":{"login":"SpiderLabs","id":508521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/508521?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiderLabs","html_url":"https://github.com/SpiderLabs","followers_url":"https://api.github.com/users/SpiderLabs/followers","following_url":"https://api.github.com/users/SpiderLabs/following{/other_user}","gists_url":"https://api.github.com/users/SpiderLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderLabs/subscriptions","organizations_url":"https://api.github.com/users/SpiderLabs/orgs","repos_url":"https://api.github.com/users/SpiderLabs/repos","events_url":"https://api.github.com/users/SpiderLabs/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1320594,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwNTk0","name":"ModSecurity","full_name":"SpiderLabs/ModSecurity","owner":{"login":"SpiderLabs","id":508521,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwODUyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/508521?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiderLabs","html_url":"https://github.com/SpiderLabs","followers_url":"https://api.github.com/users/SpiderLabs/followers","following_url":"https://api.github.com/users/SpiderLabs/following{/other_user}","gists_url":"https://api.github.com/users/SpiderLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiderLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiderLabs/subscriptions","organizations_url":"https://api.github.com/users/SpiderLabs/orgs","repos_url":"https://api.github.com/users/SpiderLabs/repos","events_url":"https://api.github.com/users/SpiderLabs/events{/privacy}","received_events_url":"https://api.github.com/users/SpiderLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiderLabs/ModSecurity","description":"ModSecurity is an open source, cross platform web application firewall (WAF) engine for Apache, IIS and Nginx that is developed by Trustwave's SpiderLabs. It has a robust event-based programming language which provides protection from a range of attacks against web applications and allows for HTTP traffic monitoring, logging and real-time analysis. With over 10,000 deployments world-wide, ModSecurity is the most widely deployed WAF in existence. ","fork":false,"url":"https://api.github.com/repos/SpiderLabs/ModSecurity","forks_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/forks","keys_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/teams","hooks_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/hooks","issue_events_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues/events{/number}","events_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/events","assignees_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/assignees{/user}","branches_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/branches{/branch}","tags_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/tags","blobs_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/languages","stargazers_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/stargazers","contributors_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/contributors","subscribers_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/subscribers","subscription_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/subscription","commits_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/contents/{+path}","compare_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/merges","archive_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/downloads","issues_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues{/number}","pulls_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/labels{/name}","releases_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/releases{/id}","deployments_url":"https://api.github.com/repos/SpiderLabs/ModSecurity/deployments","created_at":"2011-02-02T14:57:01Z","updated_at":"2018-09-05T19:29:34Z","pushed_at":"2018-09-05T19:29:31Z","git_url":"git://github.com/SpiderLabs/ModSecurity.git","ssh_url":"git@github.com:SpiderLabs/ModSecurity.git","clone_url":"https://github.com/SpiderLabs/ModSecurity.git","svn_url":"https://github.com/SpiderLabs/ModSecurity","homepage":"https://www.modsecurity.org","size":69573,"stargazers_count":2305,"watchers_count":2305,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":728,"mirror_url":null,"archived":false,"open_issues_count":224,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":728,"open_issues":224,"watchers":2305,"default_branch":"v2/master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/1613"},"html":{"href":"https://github.com/SpiderLabs/ModSecurity/pull/1613"},"issue":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues/1613"},"comments":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/issues/1613/comments"},"review_comments":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/1613/comments"},"review_comment":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/pulls/1613/commits"},"statuses":{"href":"https://api.github.com/repos/SpiderLabs/ModSecurity/statuses/ef0b61b8a25a2da548c0b8aec5baa5c57be9bf1b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":18,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"zimmerle"}}