{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/8531","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/8531/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/8531/comments","events_url":"https://api.github.com/repos/istio/istio/issues/8531/events","html_url":"https://github.com/istio/istio/pull/8531","id":357777217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzEyMzky","number":8531,"title":"Fix the minikube e2e test broken by Error: ImagePullBackOff.","user":{"login":"yangminzhu","id":2189160,"node_id":"MDQ6VXNlcjIxODkxNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/2189160?v=4","gravatar_id":"","url":"https://api.github.com/users/yangminzhu","html_url":"https://github.com/yangminzhu","followers_url":"https://api.github.com/users/yangminzhu/followers","following_url":"https://api.github.com/users/yangminzhu/following{/other_user}","gists_url":"https://api.github.com/users/yangminzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/yangminzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangminzhu/subscriptions","organizations_url":"https://api.github.com/users/yangminzhu/orgs","repos_url":"https://api.github.com/users/yangminzhu/repos","events_url":"https://api.github.com/users/yangminzhu/events{/privacy}","received_events_url":"https://api.github.com/users/yangminzhu/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":669419450,"node_id":"MDU6TGFiZWw2Njk0MTk0NTA=","url":"https://api.github.com/repos/istio/istio/labels/area/test%20and%20release","name":"area/test and release","color":"0e8a16","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"node_id":"MDU6TGFiZWw2NjA1NTY5ODY=","url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"hklai","id":31747472,"node_id":"MDQ6VXNlcjMxNzQ3NDcy","avatar_url":"https://avatars3.githubusercontent.com/u/31747472?v=4","gravatar_id":"","url":"https://api.github.com/users/hklai","html_url":"https://github.com/hklai","followers_url":"https://api.github.com/users/hklai/followers","following_url":"https://api.github.com/users/hklai/following{/other_user}","gists_url":"https://api.github.com/users/hklai/gists{/gist_id}","starred_url":"https://api.github.com/users/hklai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hklai/subscriptions","organizations_url":"https://api.github.com/users/hklai/orgs","repos_url":"https://api.github.com/users/hklai/repos","events_url":"https://api.github.com/users/hklai/events{/privacy}","received_events_url":"https://api.github.com/users/hklai/received_events","type":"User","site_admin":false},"assignees":[{"login":"hklai","id":31747472,"node_id":"MDQ6VXNlcjMxNzQ3NDcy","avatar_url":"https://avatars3.githubusercontent.com/u/31747472?v=4","gravatar_id":"","url":"https://api.github.com/users/hklai","html_url":"https://github.com/hklai","followers_url":"https://api.github.com/users/hklai/followers","following_url":"https://api.github.com/users/hklai/following{/other_user}","gists_url":"https://api.github.com/users/hklai/gists{/gist_id}","starred_url":"https://api.github.com/users/hklai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hklai/subscriptions","organizations_url":"https://api.github.com/users/hklai/orgs","repos_url":"https://api.github.com/users/hklai/repos","events_url":"https://api.github.com/users/hklai/events{/privacy}","received_events_url":"https://api.github.com/users/hklai/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-09-06T18:40:10Z","updated_at":"2018-09-11T23:18:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8531","html_url":"https://github.com/istio/istio/pull/8531","diff_url":"https://github.com/istio/istio/pull/8531.diff","patch_url":"https://github.com/istio/istio/pull/8531.patch"},"body":"The minikube e2e test is broken in my local environment due to the test couldn't fetch the necessary images:\r\n\r\n```\r\nEvents:\r\n  Type     Reason                 Age                From               Message\r\n  ----     ------                 ----               ----               -------\r\n  Normal   SuccessfulMountVolume  49s                kubelet, minikube  MountVolume.SetUp succeeded for volume \"istio-envoy\"\r\n  Normal   SuccessfulMountVolume  49s                kubelet, minikube  MountVolume.SetUp succeeded for volume \"a-token-77n2v\"\r\n  Normal   SuccessfulMountVolume  49s                kubelet, minikube  MountVolume.SetUp succeeded for volume \"istio-certs\"\r\n  Normal   Scheduled              49s                default-scheduler  Successfully assigned a-849db664d9-x55s8 to minikube\r\n  Normal   Started                48s                kubelet, minikube  Started container\r\n  Normal   Pulled                 48s                kubelet, minikube  Container image \"localhost:5000/proxy_init:latest\" already present on mach\r\nine\r\n  Normal   Created                48s                kubelet, minikube  Created container\r\n  Normal   Pulled                 46s                kubelet, minikube  Container image \"localhost:5000/proxy_init:latest\" already present on mach\r\nine\r\n  Normal   Created                46s                kubelet, minikube  Created container\r\n  Normal   Pulled                 45s                kubelet, minikube  Container image \"localhost:5000/proxyv2:latest\" already present on machine\r\n  Normal   Started                45s                kubelet, minikube  Started container\r\n  Normal   Created                44s                kubelet, minikube  Created container\r\n  Normal   Started                44s                kubelet, minikube  Started container\r\n  Warning  Failed                 26s (x2 over 45s)  kubelet, minikube  Failed to pull image \"localhost:5000/app:latest\": rpc error: code = Unknow\r\nn desc = Error response from daemon: Get http://localhost:5000/v2/: dial tcp 127.0.0.1:5000: getsockopt: connection refused\r\n  Warning  Failed                 26s (x2 over 45s)  kubelet, minikube  Error: ErrImagePull\r\n  Normal   BackOff                12s (x3 over 43s)  kubelet, minikube  Back-off pulling image \"localhost:5000/app:latest\"\r\n  Warning  Failed                 12s (x3 over 43s)  kubelet, minikube  Error: ImagePullBackOff\r\n  Normal   Pulling                0s (x3 over 45s)   kubelet, minikube  pulling image \"localhost:5000/app:latest\"\r\n```\r\n\r\nIt seems this is caused by the `TAG=latest` as according to https://kubernetes.io/docs/concepts/containers/images/#updating-images, k8s will always pull the image when TAG is set to `latest`.\r\n\r\nAfter changed the TAG to something different than `latest`, it works again in my local environment.\r\n\r\nIt seems this becomes broken after #8290 which removed the local registry. /cc @JimmyCYJ \r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/420458122","html_url":"https://github.com/istio/istio/pull/8531#issuecomment-420458122","issue_url":"https://api.github.com/repos/istio/istio/issues/8531","id":420458122,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDQ1ODEyMg==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T23:18:35Z","updated_at":"2018-09-11T23:18:35Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/8531#pullrequestreview-154434092\" title=\"LGTM\">hklai</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[tests/e2e/local/OWNERS](https://github.com/istio/istio/blob/master/tests/e2e/local/OWNERS)~~ [hklai]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"istio-testing"}}