{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/plotly.js/pulls/comments/215749344","pull_request_review_id":153085626,"id":215749344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTc0OTM0NA==","diff_hunk":"@@ -1134,6 +1155,38 @@ describe('@flaky Test select box and lasso in general:', function() {\n         .then(done);\n     });\n \n+    it('should cleanly clear and restart selections on double click when add/subtract mode on', function(done) {\n+        var gd = createGraphDiv();\n+        var fig = Lib.extendDeep({}, require('@mocks/0.json'));\n+\n+        fig.layout.dragmode = 'select';\n+        Plotly.plot(gd, fig)\n+          .then(function() {\n+              return drag([[350, 100], [400, 400]]);\n+          })\n+          .then(function() {\n+              _assertSelectedPoints([49, 50, 51, 52, 53, 54, 55, 56, 57]);\n+              return doubleClick(500, 200, { shiftKey: true });","path":"test/jasmine/tests/select_test.js","position":null,"original_position":43,"commit_id":"a5a90f9b97182a54b426eaf0736d27ee041375de","original_commit_id":"bb44b6d16263c694daf5945f1ef83afd8aee1bcc","user":{"login":"rmoestl","id":4652260,"node_id":"MDQ6VXNlcjQ2NTIyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4652260?v=4","gravatar_id":"","url":"https://api.github.com/users/rmoestl","html_url":"https://github.com/rmoestl","followers_url":"https://api.github.com/users/rmoestl/followers","following_url":"https://api.github.com/users/rmoestl/following{/other_user}","gists_url":"https://api.github.com/users/rmoestl/gists{/gist_id}","starred_url":"https://api.github.com/users/rmoestl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmoestl/subscriptions","organizations_url":"https://api.github.com/users/rmoestl/orgs","repos_url":"https://api.github.com/users/rmoestl/repos","events_url":"https://api.github.com/users/rmoestl/events{/privacy}","received_events_url":"https://api.github.com/users/rmoestl/received_events","type":"User","site_admin":false},"body":"I just added a commit adding the comment.","created_at":"2018-09-06T19:28:28Z","updated_at":"2018-09-06T19:28:29Z","html_url":"https://github.com/plotly/plotly.js/pull/2944#discussion_r215749344","pull_request_url":"https://api.github.com/repos/plotly/plotly.js/pulls/2944","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/comments/215749344"},"html":{"href":"https://github.com/plotly/plotly.js/pull/2944#discussion_r215749344"},"pull_request":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2944"}},"in_reply_to_id":213716787},"pull_request":{"url":"https://api.github.com/repos/plotly/plotly.js/pulls/2944","id":211130744,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTMwNzQ0","html_url":"https://github.com/plotly/plotly.js/pull/2944","diff_url":"https://github.com/plotly/plotly.js/pull/2944.diff","patch_url":"https://github.com/plotly/plotly.js/pull/2944.patch","issue_url":"https://api.github.com/repos/plotly/plotly.js/issues/2944","number":2944,"state":"open","locked":false,"title":"1852 persistent click via select points","user":{"login":"rmoestl","id":4652260,"node_id":"MDQ6VXNlcjQ2NTIyNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/4652260?v=4","gravatar_id":"","url":"https://api.github.com/users/rmoestl","html_url":"https://github.com/rmoestl","followers_url":"https://api.github.com/users/rmoestl/followers","following_url":"https://api.github.com/users/rmoestl/following{/other_user}","gists_url":"https://api.github.com/users/rmoestl/gists{/gist_id}","starred_url":"https://api.github.com/users/rmoestl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmoestl/subscriptions","organizations_url":"https://api.github.com/users/rmoestl/orgs","repos_url":"https://api.github.com/users/rmoestl/repos","events_url":"https://api.github.com/users/rmoestl/events{/privacy}","received_events_url":"https://api.github.com/users/rmoestl/received_events","type":"User","site_admin":false},"body":"*Superseding PR #2824*, this PR will introduce the select-on-click / persistent selection feature discussed in issue #1852.\r\n\r\nA few remarks:\r\n- There's one uncertainty regarding testing interactions that should have no effect but might be processed asynchronously. See open TODOs in `select_test.js`.\r\n- For now I've decided to not clear selection when user clicks a blank spot. I felt, that this cause losing a selection to easily. Instead clear a selection by click is easy with double click in lasso / select mode, and in zoom / pan mode one only needs to select one point and click it again.\r\n- As per the original request in #1852 we've not decided how the user \"would be informed that points are clickable\".","created_at":"2018-08-27T14:39:56Z","updated_at":"2018-09-06T19:28:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a34bb266c7a7580505560a03590c7c3b9d1cbf33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":330750748,"node_id":"MDU6TGFiZWwzMzA3NTA3NDg=","url":"https://api.github.com/repos/plotly/plotly.js/labels/status:%20reviewable","name":"status: reviewable","color":"33a02c","default":false},{"id":282886923,"node_id":"MDU6TGFiZWwyODI4ODY5MjM=","url":"https://api.github.com/repos/plotly/plotly.js/labels/type:%20bug","name":"type: bug","color":"e31a1c","default":false},{"id":282886925,"node_id":"MDU6TGFiZWwyODI4ODY5MjU=","url":"https://api.github.com/repos/plotly/plotly.js/labels/type:%20feature","name":"type: feature","color":"1f78b4","default":false}],"milestone":{"url":"https://api.github.com/repos/plotly/plotly.js/milestones/37","html_url":"https://github.com/plotly/plotly.js/milestone/37","labels_url":"https://api.github.com/repos/plotly/plotly.js/milestones/37/labels","id":3583715,"node_id":"MDk6TWlsZXN0b25lMzU4MzcxNQ==","number":37,"title":"v1.41.0","description":"","creator":{"login":"etpinard","id":6675409,"node_id":"MDQ6VXNlcjY2NzU0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6675409?v=4","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":4,"state":"open","created_at":"2018-08-20T14:07:46Z","updated_at":"2018-09-06T17:37:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/plotly/plotly.js/pulls/2944/commits","review_comments_url":"https://api.github.com/repos/plotly/plotly.js/pulls/2944/comments","review_comment_url":"https://api.github.com/repos/plotly/plotly.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/plotly.js/issues/2944/comments","statuses_url":"https://api.github.com/repos/plotly/plotly.js/statuses/a5a90f9b97182a54b426eaf0736d27ee041375de","head":{"label":"plotly:1852-persistent-click-via-selectPoints","ref":"1852-persistent-click-via-selectPoints","sha":"a5a90f9b97182a54b426eaf0736d27ee041375de","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":45646037,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY0NjAzNw==","name":"plotly.js","full_name":"plotly/plotly.js","owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/plotly.js","description":"The open source JavaScript graphing library that powers plotly","fork":false,"url":"https://api.github.com/repos/plotly/plotly.js","forks_url":"https://api.github.com/repos/plotly/plotly.js/forks","keys_url":"https://api.github.com/repos/plotly/plotly.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/plotly.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/plotly.js/teams","hooks_url":"https://api.github.com/repos/plotly/plotly.js/hooks","issue_events_url":"https://api.github.com/repos/plotly/plotly.js/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/plotly.js/events","assignees_url":"https://api.github.com/repos/plotly/plotly.js/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/plotly.js/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/plotly.js/tags","blobs_url":"https://api.github.com/repos/plotly/plotly.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/plotly.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/plotly.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/plotly.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/plotly.js/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/plotly.js/languages","stargazers_url":"https://api.github.com/repos/plotly/plotly.js/stargazers","contributors_url":"https://api.github.com/repos/plotly/plotly.js/contributors","subscribers_url":"https://api.github.com/repos/plotly/plotly.js/subscribers","subscription_url":"https://api.github.com/repos/plotly/plotly.js/subscription","commits_url":"https://api.github.com/repos/plotly/plotly.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/plotly.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/plotly.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/plotly.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/plotly.js/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/plotly.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/plotly.js/merges","archive_url":"https://api.github.com/repos/plotly/plotly.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/plotly.js/downloads","issues_url":"https://api.github.com/repos/plotly/plotly.js/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/plotly.js/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/plotly.js/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/plotly.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/plotly.js/labels{/name}","releases_url":"https://api.github.com/repos/plotly/plotly.js/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/plotly.js/deployments","created_at":"2015-11-05T23:27:17Z","updated_at":"2018-09-06T15:38:17Z","pushed_at":"2018-09-06T19:28:02Z","git_url":"git://github.com/plotly/plotly.js.git","ssh_url":"git@github.com:plotly/plotly.js.git","clone_url":"https://github.com/plotly/plotly.js.git","svn_url":"https://github.com/plotly/plotly.js","homepage":"https://plot.ly/javascript/","size":448736,"stargazers_count":8862,"watchers_count":8862,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1014,"mirror_url":null,"archived":false,"open_issues_count":562,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1014,"open_issues":562,"watchers":8862,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"bff736d1efdbb471e212374c50c12044ccedcad5","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":45646037,"node_id":"MDEwOlJlcG9zaXRvcnk0NTY0NjAzNw==","name":"plotly.js","full_name":"plotly/plotly.js","owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/plotly.js","description":"The open source JavaScript graphing library that powers plotly","fork":false,"url":"https://api.github.com/repos/plotly/plotly.js","forks_url":"https://api.github.com/repos/plotly/plotly.js/forks","keys_url":"https://api.github.com/repos/plotly/plotly.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/plotly.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/plotly.js/teams","hooks_url":"https://api.github.com/repos/plotly/plotly.js/hooks","issue_events_url":"https://api.github.com/repos/plotly/plotly.js/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/plotly.js/events","assignees_url":"https://api.github.com/repos/plotly/plotly.js/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/plotly.js/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/plotly.js/tags","blobs_url":"https://api.github.com/repos/plotly/plotly.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/plotly.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/plotly.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/plotly.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/plotly.js/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/plotly.js/languages","stargazers_url":"https://api.github.com/repos/plotly/plotly.js/stargazers","contributors_url":"https://api.github.com/repos/plotly/plotly.js/contributors","subscribers_url":"https://api.github.com/repos/plotly/plotly.js/subscribers","subscription_url":"https://api.github.com/repos/plotly/plotly.js/subscription","commits_url":"https://api.github.com/repos/plotly/plotly.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/plotly.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/plotly.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/plotly.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/plotly.js/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/plotly.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/plotly.js/merges","archive_url":"https://api.github.com/repos/plotly/plotly.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/plotly.js/downloads","issues_url":"https://api.github.com/repos/plotly/plotly.js/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/plotly.js/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/plotly.js/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/plotly.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/plotly.js/labels{/name}","releases_url":"https://api.github.com/repos/plotly/plotly.js/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/plotly.js/deployments","created_at":"2015-11-05T23:27:17Z","updated_at":"2018-09-06T15:38:17Z","pushed_at":"2018-09-06T19:28:02Z","git_url":"git://github.com/plotly/plotly.js.git","ssh_url":"git@github.com:plotly/plotly.js.git","clone_url":"https://github.com/plotly/plotly.js.git","svn_url":"https://github.com/plotly/plotly.js","homepage":"https://plot.ly/javascript/","size":448736,"stargazers_count":8862,"watchers_count":8862,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1014,"mirror_url":null,"archived":false,"open_issues_count":562,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1014,"open_issues":562,"watchers":8862,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2944"},"html":{"href":"https://github.com/plotly/plotly.js/pull/2944"},"issue":{"href":"https://api.github.com/repos/plotly/plotly.js/issues/2944"},"comments":{"href":"https://api.github.com/repos/plotly/plotly.js/issues/2944/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2944/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/plotly.js/pulls/2944/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/plotly.js/statuses/a5a90f9b97182a54b426eaf0736d27ee041375de"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rmoestl"}}