{"action":"created","issue":{"url":"https://api.github.com/repos/StevenBlack/hosts/issues/877","repository_url":"https://api.github.com/repos/StevenBlack/hosts","labels_url":"https://api.github.com/repos/StevenBlack/hosts/issues/877/labels{/name}","comments_url":"https://api.github.com/repos/StevenBlack/hosts/issues/877/comments","events_url":"https://api.github.com/repos/StevenBlack/hosts/issues/877/events","html_url":"https://github.com/StevenBlack/hosts/pull/877","id":396157208,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDM1MTgy","number":877,"title":"Specify encoding to UTF-8 when opening source file","user":{"login":"ghostduck","id":24493647,"node_id":"MDQ6VXNlcjI0NDkzNjQ3","avatar_url":"https://avatars3.githubusercontent.com/u/24493647?v=4","gravatar_id":"","url":"https://api.github.com/users/ghostduck","html_url":"https://github.com/ghostduck","followers_url":"https://api.github.com/users/ghostduck/followers","following_url":"https://api.github.com/users/ghostduck/following{/other_user}","gists_url":"https://api.github.com/users/ghostduck/gists{/gist_id}","starred_url":"https://api.github.com/users/ghostduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghostduck/subscriptions","organizations_url":"https://api.github.com/users/ghostduck/orgs","repos_url":"https://api.github.com/users/ghostduck/repos","events_url":"https://api.github.com/users/ghostduck/events{/privacy}","received_events_url":"https://api.github.com/users/ghostduck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2019-01-05T11:21:27Z","updated_at":"2019-01-05T16:15:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/StevenBlack/hosts/pulls/877","html_url":"https://github.com/StevenBlack/hosts/pull/877","diff_url":"https://github.com/StevenBlack/hosts/pull/877.diff","patch_url":"https://github.com/StevenBlack/hosts/pull/877.patch"},"body":"Hi there, new user here. \r\n\r\nI am just a normal user using this tool to update hosts file. In my Windows machine, I have trouble updating hosts file running `updateHostsWindows.bat`.\r\n\r\n```\r\n... (All the Updating sorce data\\xxx messages)\r\nUpdating source data\\malwaredomainlist.com from https://www.malwaredomainlist.com/hostslist/hosts.txt\r\nUpdating source data\\mvps.org from http://winhelp2002.mvps.org/hosts.txt\r\nTraceback (most recent call last):\r\n  File \"updateHostsFile.py\", line 1525, in <module>\r\n    main()\r\n  File \"updateHostsFile.py\", line 164, in main\r\n    update_all_sources(source_data_filename, settings[\"hostfilename\"])\r\n  File \"updateHostsFile.py\", line 590, in update_all_sources\r\n    update_data = json.load(update_file)\r\n  File \"C:\\Program Files\\Python37\\lib\\json\\__init__.py\", line 293, in load\r\n    return loads(fp.read(),\r\nUnicodeDecodeError: 'cp932' codec can't decode byte 0x93 in position 29: illegal multibyte sequence\r\n        1 file(s) copied.\r\n```\r\n\r\nI guess this happens since I am using CJKV language options in Windows and Python follows it.\r\n\r\nMy fix to the issue is specifying encoding to UTF-8. Please see if the 'fix' is acceptable or not."},"comment":{"url":"https://api.github.com/repos/StevenBlack/hosts/issues/comments/451668154","html_url":"https://github.com/StevenBlack/hosts/pull/877#issuecomment-451668154","issue_url":"https://api.github.com/repos/StevenBlack/hosts/issues/877","id":451668154,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTY2ODE1NA==","user":{"login":"funilrys","id":14127285,"node_id":"MDQ6VXNlcjE0MTI3Mjg1","avatar_url":"https://avatars0.githubusercontent.com/u/14127285?v=4","gravatar_id":"","url":"https://api.github.com/users/funilrys","html_url":"https://github.com/funilrys","followers_url":"https://api.github.com/users/funilrys/followers","following_url":"https://api.github.com/users/funilrys/following{/other_user}","gists_url":"https://api.github.com/users/funilrys/gists{/gist_id}","starred_url":"https://api.github.com/users/funilrys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/funilrys/subscriptions","organizations_url":"https://api.github.com/users/funilrys/orgs","repos_url":"https://api.github.com/users/funilrys/repos","events_url":"https://api.github.com/users/funilrys/events{/privacy}","received_events_url":"https://api.github.com/users/funilrys/received_events","type":"User","site_admin":false},"created_at":"2019-01-05T16:15:30Z","updated_at":"2019-01-05T16:15:30Z","author_association":"CONTRIBUTOR","body":"@ghostduck, let's say that it is a good practice to unify such things as it can be confusing.\r\n\r\nI'm not talking about experienced developer (even if it can also happen) but new developer who try to learn or understand with our source code.\r\n\r\nI'm not against taking the time to answer questions per issues but with our scale I'm more concerned about escalation as some issues can escalate really fast. And it is really bad the kind of escalation we have here sometimes. "}}
{"actor":{"display_login":"funilrys"}}