{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments/198321392","pull_request_review_id":132232983,"id":198321392,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMyMTM5Mg==","diff_hunk":"@@ -351,6 +351,22 @@ var _ = Describe(\"backup end to end integration tests\", func() {\n \n \t\t\t\tos.RemoveAll(backupdir)\n \t\t\t})\n+\t\t\tIt(\"runs gpbackup and gprestore on database with all objects\", func() {\n+\t\t\t\ttesthelper.AssertQueryRuns(backupConn, \"DROP SCHEMA IF EXISTS schema2 CASCADE; DROP SCHEMA public CASCADE; CREATE SCHEMA public; DROP PROCEDURAL LANGUAGE IF EXISTS plpythonu;\")\n+\t\t\t\tdefer testutils.ExecuteSQLFile(backupConn, \"test_tables_data.sql\")\n+\t\t\t\tdefer testutils.ExecuteSQLFile(backupConn, \"test_tables_ddl.sql\")\n+\t\t\t\tdefer testhelper.AssertQueryRuns(backupConn, \"DROP SCHEMA IF EXISTS schema2 CASCADE; DROP SCHEMA public CASCADE; CREATE SCHEMA public; DROP PROCEDURAL LANGUAGE IF EXISTS plpythonu;\")\n+\t\t\t\ttestutils.ExecuteSQLFile(backupConn, \"gpdb4_objects.sql\")\n+\t\t\t\tif backupConn.Version.AtLeast(\"5\") {\n+\t\t\t\t\ttestutils.ExecuteSQLFile(backupConn, \"gpdb5_objects.sql\")\n+\t\t\t\t}\n+\t\t\t\tif backupConn.Version.AtLeast(\"6\") {\n+\t\t\t\t\ttestutils.ExecuteSQLFile(backupConn, \"gpdb6_objects.sql\")\n+\t\t\t\t}\n+\t\t\t\ttimestamp := gpbackup(gpbackupPath, \"--leaf-partition-data\", \"--single-data-file\")\n+\t\t\t\tgprestore(gprestorePath, timestamp, \"--redirect-db\", \"restoredb\")\n+","path":"end_to_end/end_to_end_suite_test.go","position":18,"original_position":18,"commit_id":"407cb2429bf729f99a5f1bb17478f081484d3258","original_commit_id":"407cb2429bf729f99a5f1bb17478f081484d3258","user":{"login":"soumyadeep2007","id":11961043,"node_id":"MDQ6VXNlcjExOTYxMDQz","avatar_url":"https://avatars3.githubusercontent.com/u/11961043?v=4","gravatar_id":"","url":"https://api.github.com/users/soumyadeep2007","html_url":"https://github.com/soumyadeep2007","followers_url":"https://api.github.com/users/soumyadeep2007/followers","following_url":"https://api.github.com/users/soumyadeep2007/following{/other_user}","gists_url":"https://api.github.com/users/soumyadeep2007/gists{/gist_id}","starred_url":"https://api.github.com/users/soumyadeep2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumyadeep2007/subscriptions","organizations_url":"https://api.github.com/users/soumyadeep2007/orgs","repos_url":"https://api.github.com/users/soumyadeep2007/repos","events_url":"https://api.github.com/users/soumyadeep2007/events{/privacy}","received_events_url":"https://api.github.com/users/soumyadeep2007/received_events","type":"User","site_admin":false},"body":"There is no assert here?","created_at":"2018-06-26T22:50:55Z","updated_at":"2018-06-26T22:50:55Z","html_url":"https://github.com/greenplum-db/gpbackup/pull/96#discussion_r198321392","pull_request_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments/198321392"},"html":{"href":"https://github.com/greenplum-db/gpbackup/pull/96#discussion_r198321392"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96","id":197254863,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MjU0ODYz","html_url":"https://github.com/greenplum-db/gpbackup/pull/96","diff_url":"https://github.com/greenplum-db/gpbackup/pull/96.diff","patch_url":"https://github.com/greenplum-db/gpbackup/pull/96.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/96","number":96,"state":"open","locked":false,"title":"Fix backup of external tables with --single-data-file","user":{"login":"chrishajas","id":1610524,"node_id":"MDQ6VXNlcjE2MTA1MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1610524?v=4","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"body":"During the gpbackup --single-data-file refactor to use an agent\r\napproach, the oid list created for the master included external tables,\r\nwhile the oid list on the segments did not. This caused the backup to\r\nfail as the pipe names did not match (the segment created a pipe with\r\nthe name of a regular table, whereas the master executed a COPY TO\r\ncommand to a pipe with an external table). This only occurred when\r\n--single-data-file was used.\r\n\r\nAuthored-by: Chris Hajas <chajas@pivotal.io>","created_at":"2018-06-25T22:37:31Z","updated_at":"2018-06-26T22:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c8cdfdc5b6f11437f254cf55a1e412f932b435d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/96/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/407cb2429bf729f99a5f1bb17478f081484d3258","head":{"label":"greenplum-db:ext_single_data","ref":"ext_single_data","sha":"407cb2429bf729f99a5f1bb17478f081484d3258","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":91118401,"node_id":"MDEwOlJlcG9zaXRvcnk5MTExODQwMQ==","name":"gpbackup","full_name":"greenplum-db/gpbackup","owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpbackup","description":"GPDB Backup Utility","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpbackup","forks_url":"https://api.github.com/repos/greenplum-db/gpbackup/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpbackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpbackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpbackup/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpbackup/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpbackup/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpbackup/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpbackup/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpbackup/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpbackup/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpbackup/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpbackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpbackup/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpbackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpbackup/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpbackup/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpbackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpbackup/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpbackup/deployments","created_at":"2017-05-12T18:18:13Z","updated_at":"2018-06-26T16:47:12Z","pushed_at":"2018-06-26T17:25:25Z","git_url":"git://github.com/greenplum-db/gpbackup.git","ssh_url":"git@github.com:greenplum-db/gpbackup.git","clone_url":"https://github.com/greenplum-db/gpbackup.git","svn_url":"https://github.com/greenplum-db/gpbackup","homepage":null,"size":1944,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":2,"watchers":6,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"9c69b21e78af42c78d955f56956a0164bcfb412b","user":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":91118401,"node_id":"MDEwOlJlcG9zaXRvcnk5MTExODQwMQ==","name":"gpbackup","full_name":"greenplum-db/gpbackup","owner":{"login":"greenplum-db","id":14097842,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk3ODQy","avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpbackup","description":"GPDB Backup Utility","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpbackup","forks_url":"https://api.github.com/repos/greenplum-db/gpbackup/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpbackup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpbackup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpbackup/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpbackup/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpbackup/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpbackup/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpbackup/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpbackup/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpbackup/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpbackup/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpbackup/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpbackup/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpbackup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpbackup/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpbackup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpbackup/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpbackup/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpbackup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpbackup/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpbackup/deployments","created_at":"2017-05-12T18:18:13Z","updated_at":"2018-06-26T16:47:12Z","pushed_at":"2018-06-26T17:25:25Z","git_url":"git://github.com/greenplum-db/gpbackup.git","ssh_url":"git@github.com:greenplum-db/gpbackup.git","clone_url":"https://github.com/greenplum-db/gpbackup.git","svn_url":"https://github.com/greenplum-db/gpbackup","homepage":null,"size":1944,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":8,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96"},"html":{"href":"https://github.com/greenplum-db/gpbackup/pull/96"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/issues/96"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpbackup/statuses/407cb2429bf729f99a5f1bb17478f081484d3258"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"soumyadeep2007"}}