{"action":"closed","issue":{"url":"https://api.github.com/repos/atom/atom/issues/16663","repository_url":"https://api.github.com/repos/atom/atom","labels_url":"https://api.github.com/repos/atom/atom/issues/16663/labels{/name}","comments_url":"https://api.github.com/repos/atom/atom/issues/16663/comments","events_url":"https://api.github.com/repos/atom/atom/issues/16663/events","html_url":"https://github.com/atom/atom/issues/16663","id":293404987,"node_id":"MDU6SXNzdWUyOTM0MDQ5ODc=","number":16663,"title":"[build script] lack of 'break' on switch statement on codeSign phase","user":{"login":"t9md","id":155205,"node_id":"MDQ6VXNlcjE1NTIwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/155205?v=4","gravatar_id":"","url":"https://api.github.com/users/t9md","html_url":"https://github.com/t9md","followers_url":"https://api.github.com/users/t9md/followers","following_url":"https://api.github.com/users/t9md/following{/other_user}","gists_url":"https://api.github.com/users/t9md/gists{/gist_id}","starred_url":"https://api.github.com/users/t9md/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t9md/subscriptions","organizations_url":"https://api.github.com/users/t9md/orgs","repos_url":"https://api.github.com/users/t9md/repos","events_url":"https://api.github.com/users/t9md/events{/privacy}","received_events_url":"https://api.github.com/users/t9md/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-01T05:04:14Z","updated_at":"2018-10-23T20:38:11Z","closed_at":"2018-10-23T20:38:11Z","author_association":"CONTRIBUTOR","body":"Noticed while reading build script.\r\n\r\nhttps://github.com/atom/atom/blob/287b554d637dec1ff1d53ef25e33fa113e5fc913/script/build#L82-L121\r\n\r\nLack of **break** in `switch` statement.\r\nCause unwanted fallthrough.\r\nPlatform `darwin` matches, `win32` and `linux` too.\r\n\r\n### Steps to Reproduce\r\n\r\nJust evaluated following code snippet\r\n\r\n```javascript\r\nfunction test() {\r\n  switch ('hello') {\r\n    case 'hello': {\r\n      console.log('hello')\r\n    }\r\n    case 'world': {\r\n      console.log('world')\r\n    }\r\n    default: {\r\n      console.log('bye')\r\n    }\r\n  }\r\n}\r\ntest()\r\n\r\n//--- output is bellow ---------\r\n// hello\r\n// world\r\n// bye\r\n```\r\n"}}
{"actor":{"display_login":"lee-dohm"}}