{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1371","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1371/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1371/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1371/events","html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1371","id":290996136,"number":1371,"title":"Refactors deps","user":{"login":"AllenBW","id":6640236,"avatar_url":"https://avatars0.githubusercontent.com/u/6640236?v=4","gravatar_id":"","url":"https://api.github.com/users/AllenBW","html_url":"https://github.com/AllenBW","followers_url":"https://api.github.com/users/AllenBW/followers","following_url":"https://api.github.com/users/AllenBW/following{/other_user}","gists_url":"https://api.github.com/users/AllenBW/gists{/gist_id}","starred_url":"https://api.github.com/users/AllenBW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AllenBW/subscriptions","organizations_url":"https://api.github.com/users/AllenBW/orgs","repos_url":"https://api.github.com/users/AllenBW/repos","events_url":"https://api.github.com/users/AllenBW/events{/privacy}","received_events_url":"https://api.github.com/users/AllenBW/received_events","type":"User","site_admin":false},"labels":[{"id":588251349,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels/cleanup","name":"cleanup","color":"fef2c0","default":false},{"id":704819489,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels/dependencies","name":"dependencies","color":"b4a8d1","default":false},{"id":324821696,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"assignees":[{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-01-23T21:17:50Z","updated_at":"2018-02-12T12:46:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/pulls/1371","html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1371","diff_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1371.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1371.patch"},"body":"* updates and refactors sui deps\r\n* remediates missing dependency warnings\r\n* removes unused deps (ie use of the module `patternfly.table` is the only reason to have any data tables deps)\r\n* improves readability of inter-dependency dependencies \r\n\r\nOnes that are seemingly innocuous but required by other libs are grouped together and annotated as being related, the following links rather helpful in this work:\r\nhttps://github.com/patternfly/angular-patternfly/blob/master/README.md\r\nhttps://github.com/ManageIQ/ui-components/blob/master/package.json#L89\r\n\r\nCleans up some awkward (service-details) styling that was hidden by a magic bug, long story short, we `require('bootstrap')` but which didn't resolve due to the packages package.json (it doesn't have a root `main`)\r\n\r\n### see, look, its not broken, its the same! \r\n<img width=\"1920\" alt=\"screen shot 2018-01-31 at 9 41 17 am\" src=\"https://user-images.githubusercontent.com/6640236/35628783-f585c79e-066a-11e8-8e4d-fbee35f94875.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/comments/364912726","html_url":"https://github.com/ManageIQ/manageiq-ui-service/pull/1371#issuecomment-364912726","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-service/issues/1371","id":364912726,"user":{"login":"himdel","id":289743,"avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T12:46:27Z","updated_at":"2018-02-12T12:46:27Z","author_association":"COLLABORATOR","body":"Removed `require`s:\r\n\r\n  * `angular-datatables`\r\n  * `angular-datatables/dist/plugins/select/angular-datatables.select`\r\n  * `angular-file-saver`\r\n  * `bootstrap`\r\n  * `bootstrap-select`\r\n  * `bootstrap-switch`\r\n  * `bootstrap-touchspin`\r\n  * `datatables.net-select/js/dataTables.select`\r\n  * `datatables.net/js/jquery.dataTables`"}}
{"actor":{"display_login":"himdel"}}