{"action":"created","comment":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/193061216","pull_request_review_id":125955518,"id":193061216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzA2MTIxNg==","diff_hunk":"@@ -41,54 +41,6 @@ def get_list_of_block_numbers(item):\n     return list()\n \n \n-def test_call_inexisting_address(deploy_client, blockchain_backend):","path":"raiden/tests/integration/rpc/test_assumptions.py","position":13,"original_position":13,"commit_id":"d2067b36c0619944eb3785e537dc745d804e9f51","original_commit_id":"6a394bd3d92a7263465ff48818ca70978636b927","user":{"login":"hackaugusto","id":310139,"node_id":"MDQ6VXNlcjMxMDEzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/310139?v=4","gravatar_id":"","url":"https://api.github.com/users/hackaugusto","html_url":"https://github.com/hackaugusto","followers_url":"https://api.github.com/users/hackaugusto/followers","following_url":"https://api.github.com/users/hackaugusto/following{/other_user}","gists_url":"https://api.github.com/users/hackaugusto/gists{/gist_id}","starred_url":"https://api.github.com/users/hackaugusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackaugusto/subscriptions","organizations_url":"https://api.github.com/users/hackaugusto/orgs","repos_url":"https://api.github.com/users/hackaugusto/repos","events_url":"https://api.github.com/users/hackaugusto/events{/privacy}","received_events_url":"https://api.github.com/users/hackaugusto/received_events","type":"User","site_admin":false},"body":"These were **not** tests for the `eth_call` function, please don't remove tests you don't understand. This was added to make sure our assumptions on the rest api are sane, and it caught a bug for when the `revert` opcode was introduced and these assumptions changed.","created_at":"2018-06-05T12:57:53Z","updated_at":"2018-06-05T12:57:53Z","html_url":"https://github.com/raiden-network/raiden/pull/1497#discussion_r193061216","pull_request_url":"https://api.github.com/repos/raiden-network/raiden/pulls/1497","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments/193061216"},"html":{"href":"https://github.com/raiden-network/raiden/pull/1497#discussion_r193061216"},"pull_request":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/1497"}},"in_reply_to_id":192762040},"pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/1497","id":192368071,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzY4MDcx","html_url":"https://github.com/raiden-network/raiden/pull/1497","diff_url":"https://github.com/raiden-network/raiden/pull/1497.diff","patch_url":"https://github.com/raiden-network/raiden/pull/1497.patch","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/1497","number":1497,"state":"open","locked":false,"title":"Remove ContractProxy","user":{"login":"pcppcp","id":6489721,"node_id":"MDQ6VXNlcjY0ODk3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6489721?v=4","gravatar_id":"","url":"https://api.github.com/users/pcppcp","html_url":"https://github.com/pcppcp","followers_url":"https://api.github.com/users/pcppcp/followers","following_url":"https://api.github.com/users/pcppcp/following{/other_user}","gists_url":"https://api.github.com/users/pcppcp/gists{/gist_id}","starred_url":"https://api.github.com/users/pcppcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcppcp/subscriptions","organizations_url":"https://api.github.com/users/pcppcp/orgs","repos_url":"https://api.github.com/users/pcppcp/repos","events_url":"https://api.github.com/users/pcppcp/events{/privacy}","received_events_url":"https://api.github.com/users/pcppcp/received_events","type":"User","site_admin":false},"body":"This removes old ContractProxy class - a replacement is available in web3 already.\r\n\r\nThe idea is as follows:\r\n- any SC used by Raiden should be abstracted as one of the classes in `raiden.network.proxies`\r\n- no contract function should be called directly - use of web3.eth.contract is permitted to proxies only (with exceptions to tests etc.)\r\n- these classes subclass `raiden.network.rpc.smartcontract_proxy.ContractProxy` which includes some common functionality\r\n- transactions are signed locally by the `raiden.network.rpc.client.JSONRPCClient`'s `send_transaction` method\r\n\r\nSome of the dead code in `JSONRPCClient` and tests that basically test whatever `web3` library does have been removed as well.","created_at":"2018-06-04T10:46:12Z","updated_at":"2018-06-05T12:57:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d438575bd9fcc96067f983f5923f074b05d0f7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":456350195,"node_id":"MDU6TGFiZWw0NTYzNTAxOTU=","url":"https://api.github.com/repos/raiden-network/raiden/labels/dev:%20Please%20Review","name":"dev: Please Review","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/raiden-network/raiden/pulls/1497/commits","review_comments_url":"https://api.github.com/repos/raiden-network/raiden/pulls/1497/comments","review_comment_url":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/1497/comments","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/d2067b36c0619944eb3785e537dc745d804e9f51","head":{"label":"pcppcp:refactor_contracts","ref":"refactor_contracts","sha":"d2067b36c0619944eb3785e537dc745d804e9f51","user":{"login":"pcppcp","id":6489721,"node_id":"MDQ6VXNlcjY0ODk3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6489721?v=4","gravatar_id":"","url":"https://api.github.com/users/pcppcp","html_url":"https://github.com/pcppcp","followers_url":"https://api.github.com/users/pcppcp/followers","following_url":"https://api.github.com/users/pcppcp/following{/other_user}","gists_url":"https://api.github.com/users/pcppcp/gists{/gist_id}","starred_url":"https://api.github.com/users/pcppcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcppcp/subscriptions","organizations_url":"https://api.github.com/users/pcppcp/orgs","repos_url":"https://api.github.com/users/pcppcp/repos","events_url":"https://api.github.com/users/pcppcp/events{/privacy}","received_events_url":"https://api.github.com/users/pcppcp/received_events","type":"User","site_admin":false},"repo":{"id":92982894,"node_id":"MDEwOlJlcG9zaXRvcnk5Mjk4Mjg5NA==","name":"raiden","full_name":"pcppcp/raiden","owner":{"login":"pcppcp","id":6489721,"node_id":"MDQ6VXNlcjY0ODk3MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/6489721?v=4","gravatar_id":"","url":"https://api.github.com/users/pcppcp","html_url":"https://github.com/pcppcp","followers_url":"https://api.github.com/users/pcppcp/followers","following_url":"https://api.github.com/users/pcppcp/following{/other_user}","gists_url":"https://api.github.com/users/pcppcp/gists{/gist_id}","starred_url":"https://api.github.com/users/pcppcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcppcp/subscriptions","organizations_url":"https://api.github.com/users/pcppcp/orgs","repos_url":"https://api.github.com/users/pcppcp/repos","events_url":"https://api.github.com/users/pcppcp/events{/privacy}","received_events_url":"https://api.github.com/users/pcppcp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pcppcp/raiden","description":"Raiden Network","fork":true,"url":"https://api.github.com/repos/pcppcp/raiden","forks_url":"https://api.github.com/repos/pcppcp/raiden/forks","keys_url":"https://api.github.com/repos/pcppcp/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcppcp/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcppcp/raiden/teams","hooks_url":"https://api.github.com/repos/pcppcp/raiden/hooks","issue_events_url":"https://api.github.com/repos/pcppcp/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/pcppcp/raiden/events","assignees_url":"https://api.github.com/repos/pcppcp/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/pcppcp/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/pcppcp/raiden/tags","blobs_url":"https://api.github.com/repos/pcppcp/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcppcp/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcppcp/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcppcp/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcppcp/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/pcppcp/raiden/languages","stargazers_url":"https://api.github.com/repos/pcppcp/raiden/stargazers","contributors_url":"https://api.github.com/repos/pcppcp/raiden/contributors","subscribers_url":"https://api.github.com/repos/pcppcp/raiden/subscribers","subscription_url":"https://api.github.com/repos/pcppcp/raiden/subscription","commits_url":"https://api.github.com/repos/pcppcp/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcppcp/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcppcp/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcppcp/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcppcp/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/pcppcp/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcppcp/raiden/merges","archive_url":"https://api.github.com/repos/pcppcp/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcppcp/raiden/downloads","issues_url":"https://api.github.com/repos/pcppcp/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/pcppcp/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/pcppcp/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/pcppcp/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcppcp/raiden/labels{/name}","releases_url":"https://api.github.com/repos/pcppcp/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/pcppcp/raiden/deployments","created_at":"2017-05-31T19:48:37Z","updated_at":"2017-05-31T19:48:40Z","pushed_at":"2018-06-05T12:47:45Z","git_url":"git://github.com/pcppcp/raiden.git","ssh_url":"git@github.com:pcppcp/raiden.git","clone_url":"https://github.com/pcppcp/raiden.git","svn_url":"https://github.com/pcppcp/raiden","homepage":null,"size":6861,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"raiden-network:master","ref":"master","sha":"17b969500c05429d1811187ccaf9cd4b9bbf7454","user":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"repo":{"id":50646767,"node_id":"MDEwOlJlcG9zaXRvcnk1MDY0Njc2Nw==","name":"raiden","full_name":"raiden-network/raiden","owner":{"login":"raiden-network","id":19666847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjY2ODQ3","avatar_url":"https://avatars1.githubusercontent.com/u/19666847?v=4","gravatar_id":"","url":"https://api.github.com/users/raiden-network","html_url":"https://github.com/raiden-network","followers_url":"https://api.github.com/users/raiden-network/followers","following_url":"https://api.github.com/users/raiden-network/following{/other_user}","gists_url":"https://api.github.com/users/raiden-network/gists{/gist_id}","starred_url":"https://api.github.com/users/raiden-network/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raiden-network/subscriptions","organizations_url":"https://api.github.com/users/raiden-network/orgs","repos_url":"https://api.github.com/users/raiden-network/repos","events_url":"https://api.github.com/users/raiden-network/events{/privacy}","received_events_url":"https://api.github.com/users/raiden-network/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/raiden-network/raiden","description":"Raiden Network","fork":false,"url":"https://api.github.com/repos/raiden-network/raiden","forks_url":"https://api.github.com/repos/raiden-network/raiden/forks","keys_url":"https://api.github.com/repos/raiden-network/raiden/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raiden-network/raiden/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raiden-network/raiden/teams","hooks_url":"https://api.github.com/repos/raiden-network/raiden/hooks","issue_events_url":"https://api.github.com/repos/raiden-network/raiden/issues/events{/number}","events_url":"https://api.github.com/repos/raiden-network/raiden/events","assignees_url":"https://api.github.com/repos/raiden-network/raiden/assignees{/user}","branches_url":"https://api.github.com/repos/raiden-network/raiden/branches{/branch}","tags_url":"https://api.github.com/repos/raiden-network/raiden/tags","blobs_url":"https://api.github.com/repos/raiden-network/raiden/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raiden-network/raiden/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raiden-network/raiden/git/refs{/sha}","trees_url":"https://api.github.com/repos/raiden-network/raiden/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raiden-network/raiden/statuses/{sha}","languages_url":"https://api.github.com/repos/raiden-network/raiden/languages","stargazers_url":"https://api.github.com/repos/raiden-network/raiden/stargazers","contributors_url":"https://api.github.com/repos/raiden-network/raiden/contributors","subscribers_url":"https://api.github.com/repos/raiden-network/raiden/subscribers","subscription_url":"https://api.github.com/repos/raiden-network/raiden/subscription","commits_url":"https://api.github.com/repos/raiden-network/raiden/commits{/sha}","git_commits_url":"https://api.github.com/repos/raiden-network/raiden/git/commits{/sha}","comments_url":"https://api.github.com/repos/raiden-network/raiden/comments{/number}","issue_comment_url":"https://api.github.com/repos/raiden-network/raiden/issues/comments{/number}","contents_url":"https://api.github.com/repos/raiden-network/raiden/contents/{+path}","compare_url":"https://api.github.com/repos/raiden-network/raiden/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raiden-network/raiden/merges","archive_url":"https://api.github.com/repos/raiden-network/raiden/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raiden-network/raiden/downloads","issues_url":"https://api.github.com/repos/raiden-network/raiden/issues{/number}","pulls_url":"https://api.github.com/repos/raiden-network/raiden/pulls{/number}","milestones_url":"https://api.github.com/repos/raiden-network/raiden/milestones{/number}","notifications_url":"https://api.github.com/repos/raiden-network/raiden/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raiden-network/raiden/labels{/name}","releases_url":"https://api.github.com/repos/raiden-network/raiden/releases{/id}","deployments_url":"https://api.github.com/repos/raiden-network/raiden/deployments","created_at":"2016-01-29T07:40:47Z","updated_at":"2018-06-05T12:28:14Z","pushed_at":"2018-06-05T12:47:47Z","git_url":"git://github.com/raiden-network/raiden.git","ssh_url":"git@github.com:raiden-network/raiden.git","clone_url":"https://github.com/raiden-network/raiden.git","svn_url":"https://github.com/raiden-network/raiden","homepage":null,"size":6800,"stargazers_count":1429,"watchers_count":1429,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":275,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":275,"open_issues":144,"watchers":1429,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/1497"},"html":{"href":"https://github.com/raiden-network/raiden/pull/1497"},"issue":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/1497"},"comments":{"href":"https://api.github.com/repos/raiden-network/raiden/issues/1497/comments"},"review_comments":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/1497/comments"},"review_comment":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raiden-network/raiden/pulls/1497/commits"},"statuses":{"href":"https://api.github.com/repos/raiden-network/raiden/statuses/d2067b36c0619944eb3785e537dc745d804e9f51"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hackaugusto"}}