{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/201707733","pull_request_review_id":136261429,"id":201707733,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTcwNzczMw==","diff_hunk":"@@ -85,8 +86,11 @@ export function setOutOfScopeLocations() {\n     const source = getSourceFromId(getState(), location.sourceId);\n \n     let locations = null;\n-    if (location.line && source && isPaused(getState())) {\n-      locations = await findOutOfScopeLocations(source.id, location);\n+    if (location.line && location.column && source && isPaused(getState())) {","path":"src/actions/ast.js","position":16,"original_position":16,"commit_id":"3ca050f39d047a25401fc45125e803a304133cbe","original_commit_id":"3ca050f39d047a25401fc45125e803a304133cbe","user":{"login":"jasonLaster","id":254562,"node_id":"MDQ6VXNlcjI1NDU2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/254562?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"why do we have to do this?\r\nwould `if (location && ..) {}` do the job?","created_at":"2018-07-11T14:19:58Z","updated_at":"2018-07-11T14:30:09Z","html_url":"https://github.com/devtools-html/debugger.html/pull/6625#discussion_r201707733","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/201707733"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/6625#discussion_r201707733"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625"}}},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625","id":200701860,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzAxODYw","html_url":"https://github.com/devtools-html/debugger.html/pull/6625","diff_url":"https://github.com/devtools-html/debugger.html/pull/6625.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/6625.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6625","number":6625,"state":"open","locked":false,"title":"Add types to parser worker methods","user":{"login":"ryanjduffy","id":788456,"node_id":"MDQ6VXNlcjc4ODQ1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788456?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"body":"Fixes Issue: #<issue number>\r\n\r\nI had discussed a couple options for typing the functions. The first, using a generic `Task` type, worked fine for flow typing and was more terse but didn't give useful information to developers (e.g. the flow tooltip in vscode) because it only presented the generic (e.g. `Task<[SourceId], string>`) which required understanding of the generic.\r\n\r\nThe second option is to document the function signature explicitly (e.g. `(sourceId: SourceId) => Promise<string>`). While more verbose, the type support is identical and provides a better DX so was chosen for this PR.\r\n\r\n### Summary of Changes\r\n\r\n* Adds types to dispatcher tasks for the parser worker\r\n* Fixes a few related type issues\r\n* Removes `replaceOriginalVariableName` and `getClosestExpression` worker exports which do not appear to be exist/referenced.\r\n\r\n### Screenshots/Videos (OPTIONAL)\r\n\r\nFrom VS Code, the first line of the tooltip shows the default typing for a dispatcher task which is what would be used for a task that hadn't had typing defined for it. I'm not sure why VS code displays it here. The second line (under [Flow]) shows the actual typing for this method as seen by Flow.\r\n\r\n<img width=\"620\" alt=\"image\" src=\"https://user-images.githubusercontent.com/788456/42574740-c39df370-84e4-11e8-91e6-60fb36f5641b.png\">\r\n\r\n","created_at":"2018-07-11T13:34:07Z","updated_at":"2018-07-11T14:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba49e2e1abc7dacf27353cf19ef969335b39c3a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6625/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/3ca050f39d047a25401fc45125e803a304133cbe","head":{"label":"ryanjduffy:feature/addParserTypes","ref":"feature/addParserTypes","sha":"3ca050f39d047a25401fc45125e803a304133cbe","user":{"login":"ryanjduffy","id":788456,"node_id":"MDQ6VXNlcjc4ODQ1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788456?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"repo":{"id":83244486,"node_id":"MDEwOlJlcG9zaXRvcnk4MzI0NDQ4Ng==","name":"debugger.html","full_name":"ryanjduffy/debugger.html","owner":{"login":"ryanjduffy","id":788456,"node_id":"MDQ6VXNlcjc4ODQ1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/788456?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanjduffy","html_url":"https://github.com/ryanjduffy","followers_url":"https://api.github.com/users/ryanjduffy/followers","following_url":"https://api.github.com/users/ryanjduffy/following{/other_user}","gists_url":"https://api.github.com/users/ryanjduffy/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjduffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjduffy/subscriptions","organizations_url":"https://api.github.com/users/ryanjduffy/orgs","repos_url":"https://api.github.com/users/ryanjduffy/repos","events_url":"https://api.github.com/users/ryanjduffy/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjduffy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ryanjduffy/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":true,"url":"https://api.github.com/repos/ryanjduffy/debugger.html","forks_url":"https://api.github.com/repos/ryanjduffy/debugger.html/forks","keys_url":"https://api.github.com/repos/ryanjduffy/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryanjduffy/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryanjduffy/debugger.html/teams","hooks_url":"https://api.github.com/repos/ryanjduffy/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/ryanjduffy/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/ryanjduffy/debugger.html/events","assignees_url":"https://api.github.com/repos/ryanjduffy/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/ryanjduffy/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/ryanjduffy/debugger.html/tags","blobs_url":"https://api.github.com/repos/ryanjduffy/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryanjduffy/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryanjduffy/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryanjduffy/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryanjduffy/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/ryanjduffy/debugger.html/languages","stargazers_url":"https://api.github.com/repos/ryanjduffy/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/ryanjduffy/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/ryanjduffy/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/ryanjduffy/debugger.html/subscription","commits_url":"https://api.github.com/repos/ryanjduffy/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryanjduffy/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryanjduffy/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryanjduffy/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryanjduffy/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/ryanjduffy/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryanjduffy/debugger.html/merges","archive_url":"https://api.github.com/repos/ryanjduffy/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryanjduffy/debugger.html/downloads","issues_url":"https://api.github.com/repos/ryanjduffy/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/ryanjduffy/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/ryanjduffy/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/ryanjduffy/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryanjduffy/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/ryanjduffy/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/ryanjduffy/debugger.html/deployments","created_at":"2017-02-26T22:13:11Z","updated_at":"2017-02-26T22:13:13Z","pushed_at":"2018-07-11T13:19:34Z","git_url":"git://github.com/ryanjduffy/debugger.html.git","ssh_url":"git@github.com:ryanjduffy/debugger.html.git","clone_url":"https://github.com/ryanjduffy/debugger.html.git","svn_url":"https://github.com/ryanjduffy/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":21871,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"6cbdae34d6745251e642fc039c040bde46f355e9","user":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"node_id":"MDEwOlJlcG9zaXRvcnk1NDU4NTQxOA==","name":"debugger.html","full_name":"devtools-html/debugger.html","owner":{"login":"devtools-html","id":19979421,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTc5NDIx","avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere  :boom:","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2018-07-11T12:26:23Z","pushed_at":"2018-07-11T13:34:07Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"git@github.com:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":25224,"stargazers_count":3868,"watchers_count":3868,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":648,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":648,"open_issues":250,"watchers":3868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/6625"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/6625"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/6625/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6625/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/3ca050f39d047a25401fc45125e803a304133cbe"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jasonLaster"}}