{"action":"created","issue":{"url":"https://api.github.com/repos/kulshekhar/ts-jest/issues/626","repository_url":"https://api.github.com/repos/kulshekhar/ts-jest","labels_url":"https://api.github.com/repos/kulshekhar/ts-jest/issues/626/labels{/name}","comments_url":"https://api.github.com/repos/kulshekhar/ts-jest/issues/626/comments","events_url":"https://api.github.com/repos/kulshekhar/ts-jest/issues/626/events","html_url":"https://github.com/kulshekhar/ts-jest/pull/626","id":342618538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDc0Mzcw","number":626,"title":"upgrade deps - coverage, caching and source-mapping fixes, ...","user":{"login":"huafu","id":1162602,"node_id":"MDQ6VXNlcjExNjI2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1162602?v=4","gravatar_id":"","url":"https://api.github.com/users/huafu","html_url":"https://github.com/huafu","followers_url":"https://api.github.com/users/huafu/followers","following_url":"https://api.github.com/users/huafu/following{/other_user}","gists_url":"https://api.github.com/users/huafu/gists{/gist_id}","starred_url":"https://api.github.com/users/huafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huafu/subscriptions","organizations_url":"https://api.github.com/users/huafu/orgs","repos_url":"https://api.github.com/users/huafu/repos","events_url":"https://api.github.com/users/huafu/events{/privacy}","received_events_url":"https://api.github.com/users/huafu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-07-19T07:56:48Z","updated_at":"2018-07-27T14:08:19Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kulshekhar/ts-jest/pulls/626","html_url":"https://github.com/kulshekhar/ts-jest/pull/626","diff_url":"https://github.com/kulshekhar/ts-jest/pull/626.diff","patch_url":"https://github.com/kulshekhar/ts-jest/pull/626.patch"},"body":"What does this PR:\r\n\r\n- [x] ⬆️ upgrade `babel-core` => `@babel/core` and related modifications\r\n\r\n    This will hopefully resolves some issues related to incompatible versions between babel and jest\r\n\r\n- [x] ➖ `babel-plugin-istanbul` and `babel-plugin-jest`: dependencies => dev deps\r\n\r\n    Those are included automatically when adding `babel-jest` and we should leverage it to choose the correct versions. Plus it allows users to use their desired versions if necessary\r\n\r\n- [x] 🔨 uses `jest` core types\r\n- [x] 🐛 fixes some coverage issues\r\n- [x] 🐛 fixes line mapping issues #606 \r\n- [x] ⬆️ upgrades `typescript` and `tslint` to latest versions (dev deps)\r\n- [x] :bug: fixes caching issues (#524 and maybe others)\r\n\r\n     I first thought this was related to jest itself, but then saw how the cache key was created and read some issues in this repo. Now the content of package.json and babel config if any are included in the hash builder input.\r\n\r\n- [x] 🐛 fixes an issue when transforming html files that would contain `${...}` or backtilts (`)\r\n\r\n__Possibly__ related issues: #601, #614\r\n\r\nThose are breaking changes! It could still work (I've not tested it), but I expect that using this modules with babel < 7 might be broken now.\r\n\r\n---\r\n\r\nSome minor stuff to note:\r\n\r\n- removed js entry points in root, all are ts in `src/`, entry point is `index` there\r\n- refactored some files\r\n- dropped many types to use the ones provided by jest package\r\n- split tsconfig.json (one for editing and tests, another for build)\r\n- cleaned-up a tiny bit some package scripts"},"comment":{"url":"https://api.github.com/repos/kulshekhar/ts-jest/issues/comments/408429599","html_url":"https://github.com/kulshekhar/ts-jest/pull/626#issuecomment-408429599","issue_url":"https://api.github.com/repos/kulshekhar/ts-jest/issues/626","id":408429599,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQyOTU5OQ==","user":{"login":"huafu","id":1162602,"node_id":"MDQ6VXNlcjExNjI2MDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1162602?v=4","gravatar_id":"","url":"https://api.github.com/users/huafu","html_url":"https://github.com/huafu","followers_url":"https://api.github.com/users/huafu/followers","following_url":"https://api.github.com/users/huafu/following{/other_user}","gists_url":"https://api.github.com/users/huafu/gists{/gist_id}","starred_url":"https://api.github.com/users/huafu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huafu/subscriptions","organizations_url":"https://api.github.com/users/huafu/orgs","repos_url":"https://api.github.com/users/huafu/repos","events_url":"https://api.github.com/users/huafu/events{/privacy}","received_events_url":"https://api.github.com/users/huafu/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T14:08:19Z","updated_at":"2018-07-27T14:08:19Z","author_association":"COLLABORATOR","body":"- @GeeWee I think you'll definitely prefer [this](https://github.com/kulshekhar/ts-jest/pull/626/commits/fb5cd12a664b159ac841dfa3646f766a75f84134#diff-ae9757f32870dd5a0d6aafdc4d89af2d) as the test helper to mock jest config object\r\n\r\n- also made the [test related to html-transform](https://github.com/huafu/ts-jest/blob/fb5cd12a664b159ac841dfa3646f766a75f84134/tests/__tests__/html-transform.spec.ts) much more readable (I hope at least)\r\n\r\n- all the rest is just changes related to removing the ugly stuff about `__helpers__/jest-config.ts`"}}
{"actor":{"display_login":"huafu"}}