{"action":"created","comment":{"url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/comments/215445812","pull_request_review_id":152713292,"id":215445812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ0NTgxMg==","diff_hunk":"@@ -0,0 +1,50 @@\n+\"\"\"\n+A factory for Database sockets\n+\"\"\"\n+\n+\n+def storage_socket_factory(url,","path":"qcfractal/storage_sockets/storage_socket.py","position":6,"original_position":6,"commit_id":"6802c047ab44eebb2f277ffd584577968f801688","original_commit_id":"6802c047ab44eebb2f277ffd584577968f801688","user":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"body":"Try to remember `git mv` if you can. Saves drastically on the history.","created_at":"2018-09-05T22:31:43Z","updated_at":"2018-09-05T22:32:57Z","html_url":"https://github.com/MolSSI/QCFractal/pull/44#discussion_r215445812","pull_request_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/comments/215445812"},"html":{"href":"https://github.com/MolSSI/QCFractal/pull/44#discussion_r215445812"},"pull_request":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44","id":213399610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzk5NjEw","html_url":"https://github.com/MolSSI/QCFractal/pull/44","diff_url":"https://github.com/MolSSI/QCFractal/pull/44.diff","patch_url":"https://github.com/MolSSI/QCFractal/pull/44.patch","issue_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/44","number":44,"state":"open","locked":false,"title":"Refactor naming structure for MongoDB","user":{"login":"Lnaden","id":3809383,"node_id":"MDQ6VXNlcjM4MDkzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3809383?v=4","gravatar_id":"","url":"https://api.github.com/users/Lnaden","html_url":"https://github.com/Lnaden","followers_url":"https://api.github.com/users/Lnaden/followers","following_url":"https://api.github.com/users/Lnaden/following{/other_user}","gists_url":"https://api.github.com/users/Lnaden/gists{/gist_id}","starred_url":"https://api.github.com/users/Lnaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lnaden/subscriptions","organizations_url":"https://api.github.com/users/Lnaden/orgs","repos_url":"https://api.github.com/users/Lnaden/repos","events_url":"https://api.github.com/users/Lnaden/events{/privacy}","received_events_url":"https://api.github.com/users/Lnaden/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR makes an overhaul to the storage layer to avoid confusion between the MongoDB \"Database\" and the QC traditional \"Database.\"\r\n\r\nFollowing renames have been done:\r\n\r\n* Mongo DB (or whatever storage medium) -> \"Storage\"\r\n* Quantum Chemistry Database (e.g. S22) -> \"Database\"\r\n* Grouping of calculations -> \"Collections\"\r\n\r\nThis does not fully rename everything yet as discussed in our sprint, but I did not want too much of a massive change so reviewing it is not too large. Because of the massive rename here, I also want to get this in before too many changes, otherwise there will be many diff clashes on future PR's \r\n\r\n## Todos\r\nNotable points that this PR has either accomplished or will accomplish.\r\n  - [ ] There is one change which I made that I *think* is a bug, but I need @dgasmith to verify: [here](https://github.com/Lnaden/QCFractal/blob/6802c047ab44eebb2f277ffd584577968f801688/qcfractal/storage_sockets/mongo_socket.py#L644). I changed the one line there for the `isinstance` argument.\r\n\r\n## Status\r\n- [ ] Ready to go","created_at":"2018-09-05T19:16:07Z","updated_at":"2018-09-05T22:32:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9f639faec259dbc4d7e3b19824852e71b644e47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":522022809,"node_id":"MDU6TGFiZWw1MjIwMjI4MDk=","url":"https://api.github.com/repos/MolSSI/QCFractal/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":1027447891,"node_id":"MDU6TGFiZWwxMDI3NDQ3ODkx","url":"https://api.github.com/repos/MolSSI/QCFractal/labels/Database","name":"Database","color":"54ba35","default":false},{"id":522022814,"node_id":"MDU6TGFiZWw1MjIwMjI4MTQ=","url":"https://api.github.com/repos/MolSSI/QCFractal/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/MolSSI/QCFractal/milestones/2","html_url":"https://github.com/MolSSI/QCFractal/milestone/2","labels_url":"https://api.github.com/repos/MolSSI/QCFractal/milestones/2/labels","id":3579295,"node_id":"MDk6TWlsZXN0b25lMzU3OTI5NQ==","number":2,"title":"v0.2.0a","description":"Second alpha release with bug fixes, fleshed out documentation, and examples.","creator":{"login":"dgasmith","id":1769841,"node_id":"MDQ6VXNlcjE3Njk4NDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1769841?v=4","gravatar_id":"","url":"https://api.github.com/users/dgasmith","html_url":"https://github.com/dgasmith","followers_url":"https://api.github.com/users/dgasmith/followers","following_url":"https://api.github.com/users/dgasmith/following{/other_user}","gists_url":"https://api.github.com/users/dgasmith/gists{/gist_id}","starred_url":"https://api.github.com/users/dgasmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgasmith/subscriptions","organizations_url":"https://api.github.com/users/dgasmith/orgs","repos_url":"https://api.github.com/users/dgasmith/repos","events_url":"https://api.github.com/users/dgasmith/events{/privacy}","received_events_url":"https://api.github.com/users/dgasmith/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":1,"state":"open","created_at":"2018-08-17T16:22:34Z","updated_at":"2018-09-05T19:16:07Z","due_on":"2018-10-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44/commits","review_comments_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44/comments","review_comment_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/44/comments","statuses_url":"https://api.github.com/repos/MolSSI/QCFractal/statuses/6802c047ab44eebb2f277ffd584577968f801688","head":{"label":"Lnaden:collections","ref":"collections","sha":"6802c047ab44eebb2f277ffd584577968f801688","user":{"login":"Lnaden","id":3809383,"node_id":"MDQ6VXNlcjM4MDkzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3809383?v=4","gravatar_id":"","url":"https://api.github.com/users/Lnaden","html_url":"https://github.com/Lnaden","followers_url":"https://api.github.com/users/Lnaden/followers","following_url":"https://api.github.com/users/Lnaden/following{/other_user}","gists_url":"https://api.github.com/users/Lnaden/gists{/gist_id}","starred_url":"https://api.github.com/users/Lnaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lnaden/subscriptions","organizations_url":"https://api.github.com/users/Lnaden/orgs","repos_url":"https://api.github.com/users/Lnaden/repos","events_url":"https://api.github.com/users/Lnaden/events{/privacy}","received_events_url":"https://api.github.com/users/Lnaden/received_events","type":"User","site_admin":false},"repo":{"id":145884903,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4ODQ5MDM=","name":"QCFractal","full_name":"Lnaden/QCFractal","owner":{"login":"Lnaden","id":3809383,"node_id":"MDQ6VXNlcjM4MDkzODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3809383?v=4","gravatar_id":"","url":"https://api.github.com/users/Lnaden","html_url":"https://github.com/Lnaden","followers_url":"https://api.github.com/users/Lnaden/followers","following_url":"https://api.github.com/users/Lnaden/following{/other_user}","gists_url":"https://api.github.com/users/Lnaden/gists{/gist_id}","starred_url":"https://api.github.com/users/Lnaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lnaden/subscriptions","organizations_url":"https://api.github.com/users/Lnaden/orgs","repos_url":"https://api.github.com/users/Lnaden/repos","events_url":"https://api.github.com/users/Lnaden/events{/privacy}","received_events_url":"https://api.github.com/users/Lnaden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lnaden/QCFractal","description":"A distributed compute and database platform for quantum chemistry. ","fork":true,"url":"https://api.github.com/repos/Lnaden/QCFractal","forks_url":"https://api.github.com/repos/Lnaden/QCFractal/forks","keys_url":"https://api.github.com/repos/Lnaden/QCFractal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lnaden/QCFractal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lnaden/QCFractal/teams","hooks_url":"https://api.github.com/repos/Lnaden/QCFractal/hooks","issue_events_url":"https://api.github.com/repos/Lnaden/QCFractal/issues/events{/number}","events_url":"https://api.github.com/repos/Lnaden/QCFractal/events","assignees_url":"https://api.github.com/repos/Lnaden/QCFractal/assignees{/user}","branches_url":"https://api.github.com/repos/Lnaden/QCFractal/branches{/branch}","tags_url":"https://api.github.com/repos/Lnaden/QCFractal/tags","blobs_url":"https://api.github.com/repos/Lnaden/QCFractal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lnaden/QCFractal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lnaden/QCFractal/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lnaden/QCFractal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lnaden/QCFractal/statuses/{sha}","languages_url":"https://api.github.com/repos/Lnaden/QCFractal/languages","stargazers_url":"https://api.github.com/repos/Lnaden/QCFractal/stargazers","contributors_url":"https://api.github.com/repos/Lnaden/QCFractal/contributors","subscribers_url":"https://api.github.com/repos/Lnaden/QCFractal/subscribers","subscription_url":"https://api.github.com/repos/Lnaden/QCFractal/subscription","commits_url":"https://api.github.com/repos/Lnaden/QCFractal/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lnaden/QCFractal/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lnaden/QCFractal/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lnaden/QCFractal/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lnaden/QCFractal/contents/{+path}","compare_url":"https://api.github.com/repos/Lnaden/QCFractal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lnaden/QCFractal/merges","archive_url":"https://api.github.com/repos/Lnaden/QCFractal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lnaden/QCFractal/downloads","issues_url":"https://api.github.com/repos/Lnaden/QCFractal/issues{/number}","pulls_url":"https://api.github.com/repos/Lnaden/QCFractal/pulls{/number}","milestones_url":"https://api.github.com/repos/Lnaden/QCFractal/milestones{/number}","notifications_url":"https://api.github.com/repos/Lnaden/QCFractal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lnaden/QCFractal/labels{/name}","releases_url":"https://api.github.com/repos/Lnaden/QCFractal/releases{/id}","deployments_url":"https://api.github.com/repos/Lnaden/QCFractal/deployments","created_at":"2018-08-23T17:14:39Z","updated_at":"2018-08-23T17:14:41Z","pushed_at":"2018-09-05T19:01:13Z","git_url":"git://github.com/Lnaden/QCFractal.git","ssh_url":"git@github.com:Lnaden/QCFractal.git","clone_url":"https://github.com/Lnaden/QCFractal.git","svn_url":"https://github.com/Lnaden/QCFractal","homepage":"https://qcfractal.readthedocs.io/en/latest/?badge=latest","size":1827,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MolSSI:master","ref":"master","sha":"f33cf068f4d0562171618d36306f4498febddb2a","user":{"login":"MolSSI","id":26232579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjMyNTc5","avatar_url":"https://avatars3.githubusercontent.com/u/26232579?v=4","gravatar_id":"","url":"https://api.github.com/users/MolSSI","html_url":"https://github.com/MolSSI","followers_url":"https://api.github.com/users/MolSSI/followers","following_url":"https://api.github.com/users/MolSSI/following{/other_user}","gists_url":"https://api.github.com/users/MolSSI/gists{/gist_id}","starred_url":"https://api.github.com/users/MolSSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MolSSI/subscriptions","organizations_url":"https://api.github.com/users/MolSSI/orgs","repos_url":"https://api.github.com/users/MolSSI/repos","events_url":"https://api.github.com/users/MolSSI/events{/privacy}","received_events_url":"https://api.github.com/users/MolSSI/received_events","type":"Organization","site_admin":false},"repo":{"id":79492087,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQ5MjA4Nw==","name":"QCFractal","full_name":"MolSSI/QCFractal","owner":{"login":"MolSSI","id":26232579,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MjMyNTc5","avatar_url":"https://avatars3.githubusercontent.com/u/26232579?v=4","gravatar_id":"","url":"https://api.github.com/users/MolSSI","html_url":"https://github.com/MolSSI","followers_url":"https://api.github.com/users/MolSSI/followers","following_url":"https://api.github.com/users/MolSSI/following{/other_user}","gists_url":"https://api.github.com/users/MolSSI/gists{/gist_id}","starred_url":"https://api.github.com/users/MolSSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MolSSI/subscriptions","organizations_url":"https://api.github.com/users/MolSSI/orgs","repos_url":"https://api.github.com/users/MolSSI/repos","events_url":"https://api.github.com/users/MolSSI/events{/privacy}","received_events_url":"https://api.github.com/users/MolSSI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MolSSI/QCFractal","description":"A distributed compute and database platform for quantum chemistry. ","fork":false,"url":"https://api.github.com/repos/MolSSI/QCFractal","forks_url":"https://api.github.com/repos/MolSSI/QCFractal/forks","keys_url":"https://api.github.com/repos/MolSSI/QCFractal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MolSSI/QCFractal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MolSSI/QCFractal/teams","hooks_url":"https://api.github.com/repos/MolSSI/QCFractal/hooks","issue_events_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/events{/number}","events_url":"https://api.github.com/repos/MolSSI/QCFractal/events","assignees_url":"https://api.github.com/repos/MolSSI/QCFractal/assignees{/user}","branches_url":"https://api.github.com/repos/MolSSI/QCFractal/branches{/branch}","tags_url":"https://api.github.com/repos/MolSSI/QCFractal/tags","blobs_url":"https://api.github.com/repos/MolSSI/QCFractal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MolSSI/QCFractal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MolSSI/QCFractal/git/refs{/sha}","trees_url":"https://api.github.com/repos/MolSSI/QCFractal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MolSSI/QCFractal/statuses/{sha}","languages_url":"https://api.github.com/repos/MolSSI/QCFractal/languages","stargazers_url":"https://api.github.com/repos/MolSSI/QCFractal/stargazers","contributors_url":"https://api.github.com/repos/MolSSI/QCFractal/contributors","subscribers_url":"https://api.github.com/repos/MolSSI/QCFractal/subscribers","subscription_url":"https://api.github.com/repos/MolSSI/QCFractal/subscription","commits_url":"https://api.github.com/repos/MolSSI/QCFractal/commits{/sha}","git_commits_url":"https://api.github.com/repos/MolSSI/QCFractal/git/commits{/sha}","comments_url":"https://api.github.com/repos/MolSSI/QCFractal/comments{/number}","issue_comment_url":"https://api.github.com/repos/MolSSI/QCFractal/issues/comments{/number}","contents_url":"https://api.github.com/repos/MolSSI/QCFractal/contents/{+path}","compare_url":"https://api.github.com/repos/MolSSI/QCFractal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MolSSI/QCFractal/merges","archive_url":"https://api.github.com/repos/MolSSI/QCFractal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MolSSI/QCFractal/downloads","issues_url":"https://api.github.com/repos/MolSSI/QCFractal/issues{/number}","pulls_url":"https://api.github.com/repos/MolSSI/QCFractal/pulls{/number}","milestones_url":"https://api.github.com/repos/MolSSI/QCFractal/milestones{/number}","notifications_url":"https://api.github.com/repos/MolSSI/QCFractal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MolSSI/QCFractal/labels{/name}","releases_url":"https://api.github.com/repos/MolSSI/QCFractal/releases{/id}","deployments_url":"https://api.github.com/repos/MolSSI/QCFractal/deployments","created_at":"2017-01-19T20:28:18Z","updated_at":"2018-09-05T16:17:35Z","pushed_at":"2018-09-05T19:16:08Z","git_url":"git://github.com/MolSSI/QCFractal.git","ssh_url":"git@github.com:MolSSI/QCFractal.git","clone_url":"https://github.com/MolSSI/QCFractal.git","svn_url":"https://github.com/MolSSI/QCFractal","homepage":"https://qcfractal.readthedocs.io/en/latest/?badge=latest","size":1780,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":5,"open_issues":17,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44"},"html":{"href":"https://github.com/MolSSI/QCFractal/pull/44"},"issue":{"href":"https://api.github.com/repos/MolSSI/QCFractal/issues/44"},"comments":{"href":"https://api.github.com/repos/MolSSI/QCFractal/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MolSSI/QCFractal/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/MolSSI/QCFractal/statuses/6802c047ab44eebb2f277ffd584577968f801688"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dgasmith"}}