{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59851","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59851/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59851/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59851/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59851","id":296976266,"number":59851,"title":"Use DeleteOptions.PropagationPolicy instead of OrphanDependents (deprecated) in kubectl","user":{"login":"nilebox","id":6176360,"avatar_url":"https://avatars0.githubusercontent.com/u/6176360?v=4","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":450823910,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"caesarxuchao","id":2823529,"avatar_url":"https://avatars2.githubusercontent.com/u/2823529?v=4","gravatar_id":"","url":"https://api.github.com/users/caesarxuchao","html_url":"https://github.com/caesarxuchao","followers_url":"https://api.github.com/users/caesarxuchao/followers","following_url":"https://api.github.com/users/caesarxuchao/following{/other_user}","gists_url":"https://api.github.com/users/caesarxuchao/gists{/gist_id}","starred_url":"https://api.github.com/users/caesarxuchao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caesarxuchao/subscriptions","organizations_url":"https://api.github.com/users/caesarxuchao/orgs","repos_url":"https://api.github.com/users/caesarxuchao/repos","events_url":"https://api.github.com/users/caesarxuchao/events{/privacy}","received_events_url":"https://api.github.com/users/caesarxuchao/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-14T05:00:03Z","updated_at":"2018-03-01T09:36:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59851","html_url":"https://github.com/kubernetes/kubernetes/pull/59851","diff_url":"https://github.com/kubernetes/kubernetes/pull/59851.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59851.patch"},"body":"\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nReplaces the deprecated `DeleteOptions.OrphanDependents` deletion option with `DeleteOptions.PropagationPolicy`. It will improve the cascade deletion by using `Foreground` GC deletion instead of the old `OrphanDependents: false` which has a confusing behavior (leaves orphans if children has finalizers set).\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #59850\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/369534264","html_url":"https://github.com/kubernetes/kubernetes/pull/59851#issuecomment-369534264","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59851","id":369534264,"user":{"login":"nilebox","id":6176360,"avatar_url":"https://avatars0.githubusercontent.com/u/6176360?v=4","gravatar_id":"","url":"https://api.github.com/users/nilebox","html_url":"https://github.com/nilebox","followers_url":"https://api.github.com/users/nilebox/followers","following_url":"https://api.github.com/users/nilebox/following{/other_user}","gists_url":"https://api.github.com/users/nilebox/gists{/gist_id}","starred_url":"https://api.github.com/users/nilebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilebox/subscriptions","organizations_url":"https://api.github.com/users/nilebox/orgs","repos_url":"https://api.github.com/users/nilebox/repos","events_url":"https://api.github.com/users/nilebox/events{/privacy}","received_events_url":"https://api.github.com/users/nilebox/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T09:36:45Z","updated_at":"2018-03-01T09:36:45Z","author_association":"CONTRIBUTOR","body":"@caesarxuchao fixed the bug in API server, all tests pass now."}}
{"actor":{"display_login":"nilebox"}}