{"action":"created","issue":{"url":"https://api.github.com/repos/collective/collective.auditlog/issues/15","repository_url":"https://api.github.com/repos/collective/collective.auditlog","labels_url":"https://api.github.com/repos/collective/collective.auditlog/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/collective/collective.auditlog/issues/15/comments","events_url":"https://api.github.com/repos/collective/collective.auditlog/issues/15/events","html_url":"https://github.com/collective/collective.auditlog/pull/15","id":340203670,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNjcwNDcz","number":15,"title":"Skip retrieving rule when audit log is disabled completely.","user":{"login":"reinhardt","id":202439,"node_id":"MDQ6VXNlcjIwMjQzOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/202439?v=4","gravatar_id":"","url":"https://api.github.com/users/reinhardt","html_url":"https://github.com/reinhardt","followers_url":"https://api.github.com/users/reinhardt/followers","following_url":"https://api.github.com/users/reinhardt/following{/other_user}","gists_url":"https://api.github.com/users/reinhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/reinhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinhardt/subscriptions","organizations_url":"https://api.github.com/users/reinhardt/orgs","repos_url":"https://api.github.com/users/reinhardt/repos","events_url":"https://api.github.com/users/reinhardt/events{/privacy}","received_events_url":"https://api.github.com/users/reinhardt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-11T11:35:28Z","updated_at":"2018-07-11T12:51:04Z","closed_at":"2018-07-11T12:13:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/collective/collective.auditlog/pulls/15","html_url":"https://github.com/collective/collective.auditlog/pull/15","diff_url":"https://github.com/collective/collective.auditlog/pull/15.diff","patch_url":"https://github.com/collective/collective.auditlog/pull/15.patch"},"body":"When ```disable.auditlog``` is set then we don't need to look at which rule triggered the audit executor but can simply return, because ```canExecute()``` will return False anyway. This improves performance because retrieving the rule via ```inspect``` is relatively expensive."},"comment":{"url":"https://api.github.com/repos/collective/collective.auditlog/issues/comments/404157506","html_url":"https://github.com/collective/collective.auditlog/pull/15#issuecomment-404157506","issue_url":"https://api.github.com/repos/collective/collective.auditlog/issues/15","id":404157506,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDE1NzUwNg==","user":{"login":"ale-rt","id":1300763,"node_id":"MDQ6VXNlcjEzMDA3NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1300763?v=4","gravatar_id":"","url":"https://api.github.com/users/ale-rt","html_url":"https://github.com/ale-rt","followers_url":"https://api.github.com/users/ale-rt/followers","following_url":"https://api.github.com/users/ale-rt/following{/other_user}","gists_url":"https://api.github.com/users/ale-rt/gists{/gist_id}","starred_url":"https://api.github.com/users/ale-rt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ale-rt/subscriptions","organizations_url":"https://api.github.com/users/ale-rt/orgs","repos_url":"https://api.github.com/users/ale-rt/repos","events_url":"https://api.github.com/users/ale-rt/events{/privacy}","received_events_url":"https://api.github.com/users/ale-rt/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T12:51:04Z","updated_at":"2018-07-11T12:51:04Z","author_association":"CONTRIBUTOR","body":"> But then it would have failed already - the getRequest() call was already there, only a bit further down.\r\n\r\nRight!\r\n\r\n> Thanks for merging! I'll probably have another PR soon...\r\n\r\nYou are more than welcome!"}}
{"actor":{"display_login":"ale-rt"}}