{"action":"created","issue":{"url":"https://api.github.com/repos/miscreant/miscreant/issues/154","repository_url":"https://api.github.com/repos/miscreant/miscreant","labels_url":"https://api.github.com/repos/miscreant/miscreant/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/miscreant/miscreant/issues/154/comments","events_url":"https://api.github.com/repos/miscreant/miscreant/issues/154/events","html_url":"https://github.com/miscreant/miscreant/issues/154","id":296585252,"number":154,"title":"js: node-webcrypto-ossl 1.0.26 incompatible with typescript 2.6.2","user":{"login":"aegarbutt","id":1959675,"avatar_url":"https://avatars3.githubusercontent.com/u/1959675?v=4","gravatar_id":"","url":"https://api.github.com/users/aegarbutt","html_url":"https://github.com/aegarbutt","followers_url":"https://api.github.com/users/aegarbutt/followers","following_url":"https://api.github.com/users/aegarbutt/following{/other_user}","gists_url":"https://api.github.com/users/aegarbutt/gists{/gist_id}","starred_url":"https://api.github.com/users/aegarbutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aegarbutt/subscriptions","organizations_url":"https://api.github.com/users/aegarbutt/orgs","repos_url":"https://api.github.com/users/aegarbutt/repos","events_url":"https://api.github.com/users/aegarbutt/events{/privacy}","received_events_url":"https://api.github.com/users/aegarbutt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-13T01:38:47Z","updated_at":"2018-02-14T08:23:57Z","closed_at":null,"author_association":"NONE","body":"Hey,\r\n\r\nWhen trying to install miscrants dev-dependencies today, the node-webcrypto-ossl install failed with an error in build:e5 tsc. \r\n\r\njust running the following:\r\n```\r\n$ npm install\r\n\r\n...SNIP...\r\n\r\n> node-webcrypto-ossl@1.0.26 postinstall /Users/aegarbutt/src/miscreant/js/node_modules/node-webcrypto-ossl\r\n> npm run build\r\n\r\n\r\n> node-webcrypto-ossl@1.0.26 build /Users/aegarbutt/src/miscreant/js/node_modules/node-webcrypto-ossl\r\n> npm run build:es5\r\n\r\n\r\n> node-webcrypto-ossl@1.0.26 build:es5 /Users/aegarbutt/src/miscreant/js/node_modules/node-webcrypto-ossl\r\n> tsc\r\n\r\nlib/crypto/aes.ts(94,13): error TS2322: Type 'Promise<{}>' is not assignable to type 'PromiseLike<ArrayBuffer>'.\r\n  Types of property 'then' are incompatible.\r\n    Type '<TResult1 = {}, TResult2 = never>(onfulfilled?: ((value: {}) => TResult1 | PromiseLike<TResult1>)...' is not assignable to type '<TResult1 = ArrayBuffer, TResult2 = never>(onfulfilled?: ((value: ArrayBuffer) => TResult1 | Prom...'.\r\n      Types of parameters 'onfulfilled' and 'onfulfilled' are incompatible.\r\n        Types of parameters 'value' and 'value' are incompatible.\r\n          Type '{}' is not assignable to type 'ArrayBuffer'.\r\n            Property 'byteLength' is missing in type '{}'.\r\nlib/crypto/aes.ts(102,13): error TS2322: Type 'Promise<{}>' is not assignable to type 'PromiseLike<ArrayBuffer>'.\r\nlib/crypto/hmac.ts(26,29): error TS2345: Argument of type 'CryptoKey' is not assignable to parameter of type 'CryptoKeyPair | PromiseLike<CryptoKeyPair> | undefined'.\r\n  Type 'CryptoKey' is not assignable to type 'PromiseLike<CryptoKeyPair>'.\r\n    Property 'then' is missing in type 'CryptoKey'.\r\nlib/crypto/pbkdf2.ts(44,9): error TS2322: Type 'Promise<CryptoKey>' is not assignable to type 'PromiseLike<CryptoKey>'.\r\n  Types of property 'then' are incompatible.\r\n    Type '<TResult1 = CryptoKey, TResult2 = never>(onfulfilled?: ((value: CryptoKey) => TResult1 | PromiseL...' is not assignable to type '<TResult1 = CryptoKey, TResult2 = never>(onfulfilled?: ((value: CryptoKey) => TResult1 | PromiseL...'. Two different types with this name exist, but they are unrelated.\r\n      Types of parameters 'onfulfilled' and 'onfulfilled' are incompatible.\r\n        Types of parameters 'value' and 'value' are incompatible.\r\n          Type 'CryptoKey' is not assignable to type 'CryptoKey'. Two different types with this name exist, but they are unrelated.\r\n            Property 'native_' is missing in type 'CryptoKey'.\r\n```\r\n\r\nHowever, if I drop the typescript version to @2.3.4 (as found in this issue: https://github.com/PeculiarVentures/node-webcrypto-ossl/issues/107)\r\n```\r\n$ npm install\r\n\r\n...SNIP...\r\n\r\nz\r\n> node-webcrypto-ossl@1.0.26 postinstall /Users/aegarbutt/src/miscreant/js/node_modules/node-webcrypto-ossl\r\n> npm run build\r\n\r\n\r\n> node-webcrypto-ossl@1.0.26 build /Users/aegarbutt/src/miscreant/js/node_modules/node-webcrypto-ossl\r\n> npm run build:es5\r\n\r\n\r\n> node-webcrypto-ossl@1.0.26 build:es5 /Users/aegarbutt/src/miscreant/js/node_modules/node-webcrypto-ossl\r\n> tsc\r\n\r\nadded 487 packages in 53.381s\r\n```\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/miscreant/miscreant/issues/comments/365529578","html_url":"https://github.com/miscreant/miscreant/issues/154#issuecomment-365529578","issue_url":"https://api.github.com/repos/miscreant/miscreant/issues/154","id":365529578,"user":{"login":"microshine","id":7333669,"avatar_url":"https://avatars3.githubusercontent.com/u/7333669?v=4","gravatar_id":"","url":"https://api.github.com/users/microshine","html_url":"https://github.com/microshine","followers_url":"https://api.github.com/users/microshine/followers","following_url":"https://api.github.com/users/microshine/following{/other_user}","gists_url":"https://api.github.com/users/microshine/gists{/gist_id}","starred_url":"https://api.github.com/users/microshine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microshine/subscriptions","organizations_url":"https://api.github.com/users/microshine/orgs","repos_url":"https://api.github.com/users/microshine/repos","events_url":"https://api.github.com/users/microshine/events{/privacy}","received_events_url":"https://api.github.com/users/microshine/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T08:23:57Z","updated_at":"2018-02-14T08:23:57Z","author_association":"NONE","body":"@aegarbutt thank you for your PR. I published new version of node-webcrypto-ossl and used it in `miscreant` tests. All tests were passed"}}
{"actor":{"display_login":"microshine"}}