{"action":"closed","number":1420,"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1420","id":194877961,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0ODc3OTYx","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1420","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1420.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1420.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1420","number":1420,"state":"closed","locked":false,"title":"xlat_v2: add a check on mm_cursor->size to avoid infinite loop","user":{"login":"Yann-lms","id":26569241,"node_id":"MDQ6VXNlcjI2NTY5MjQx","avatar_url":"https://avatars2.githubusercontent.com/u/26569241?v=4","gravatar_id":"","url":"https://api.github.com/users/Yann-lms","html_url":"https://github.com/Yann-lms","followers_url":"https://api.github.com/users/Yann-lms/followers","following_url":"https://api.github.com/users/Yann-lms/following{/other_user}","gists_url":"https://api.github.com/users/Yann-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/Yann-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yann-lms/subscriptions","organizations_url":"https://api.github.com/users/Yann-lms/orgs","repos_url":"https://api.github.com/users/Yann-lms/repos","events_url":"https://api.github.com/users/Yann-lms/events{/privacy}","received_events_url":"https://api.github.com/users/Yann-lms/received_events","type":"User","site_admin":false},"body":"The issue can occur if end_va is equal to the max architecture address,\r\nand when mm_cursor point to the last entry of mmap_region_t table: {0}.\r\nThe first line of the while will then be true, e.g. on AARCH32, we have:\r\nmm_cursor->base_va (=0) + mm_cursor->size (=0) - 1 == end_va (=0xFFFFFFFF)\r\nAnd the mm_cursor->size = 0 will be lesser than mm->size\r\n\r\nA check on mm_cursor->size != 0 should be done as in the previous while,\r\nto avoid such kind of infinite loop.\r\n\r\nfixes arm-software/tf-issues#594\r\n\r\nSigned-off-by: Yann Gautier <yann.gautier@st.com>","created_at":"2018-06-14T12:33:51Z","updated_at":"2018-06-19T12:39:56Z","closed_at":"2018-06-19T12:39:56Z","merged_at":"2018-06-19T12:39:56Z","merge_commit_sha":"c0b7606f914e2ab913f969fb3d1af1380a8590d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1420/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1420/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1420/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/75df62699b9911de0ed0b9b4e95c5d682910cc0e","head":{"label":"Yann-lms:mm_cursor_size_check","ref":"mm_cursor_size_check","sha":"75df62699b9911de0ed0b9b4e95c5d682910cc0e","user":{"login":"Yann-lms","id":26569241,"node_id":"MDQ6VXNlcjI2NTY5MjQx","avatar_url":"https://avatars2.githubusercontent.com/u/26569241?v=4","gravatar_id":"","url":"https://api.github.com/users/Yann-lms","html_url":"https://github.com/Yann-lms","followers_url":"https://api.github.com/users/Yann-lms/followers","following_url":"https://api.github.com/users/Yann-lms/following{/other_user}","gists_url":"https://api.github.com/users/Yann-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/Yann-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yann-lms/subscriptions","organizations_url":"https://api.github.com/users/Yann-lms/orgs","repos_url":"https://api.github.com/users/Yann-lms/repos","events_url":"https://api.github.com/users/Yann-lms/events{/privacy}","received_events_url":"https://api.github.com/users/Yann-lms/received_events","type":"User","site_admin":false},"repo":{"id":131152321,"node_id":"MDEwOlJlcG9zaXRvcnkxMzExNTIzMjE=","name":"arm-trusted-firmware","full_name":"Yann-lms/arm-trusted-firmware","owner":{"login":"Yann-lms","id":26569241,"node_id":"MDQ6VXNlcjI2NTY5MjQx","avatar_url":"https://avatars2.githubusercontent.com/u/26569241?v=4","gravatar_id":"","url":"https://api.github.com/users/Yann-lms","html_url":"https://github.com/Yann-lms","followers_url":"https://api.github.com/users/Yann-lms/followers","following_url":"https://api.github.com/users/Yann-lms/following{/other_user}","gists_url":"https://api.github.com/users/Yann-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/Yann-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yann-lms/subscriptions","organizations_url":"https://api.github.com/users/Yann-lms/orgs","repos_url":"https://api.github.com/users/Yann-lms/repos","events_url":"https://api.github.com/users/Yann-lms/events{/privacy}","received_events_url":"https://api.github.com/users/Yann-lms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yann-lms/arm-trusted-firmware","description":"Trusted Firmware-A","fork":true,"url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware","forks_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/Yann-lms/arm-trusted-firmware/deployments","created_at":"2018-04-26T12:27:26Z","updated_at":"2018-06-18T14:03:16Z","pushed_at":"2018-06-18T14:06:13Z","git_url":"git://github.com/Yann-lms/arm-trusted-firmware.git","ssh_url":"git@github.com:Yann-lms/arm-trusted-firmware.git","clone_url":"https://github.com/Yann-lms/arm-trusted-firmware.git","svn_url":"https://github.com/Yann-lms/arm-trusted-firmware","homepage":"","size":13657,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"841cb4f7251258010344dfa7bcd5f3faa51eb532","user":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0MDU4OQ==","name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"Trusted Firmware-A","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2018-06-19T09:30:45Z","pushed_at":"2018-06-19T12:39:56Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":"","size":13670,"stargazers_count":592,"watchers_count":592,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":498,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":498,"open_issues":17,"watchers":592,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1420"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1420"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1420"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1420/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1420/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1420/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/75df62699b9911de0ed0b9b4e95c5d682910cc0e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dp-arm","id":19554439,"node_id":"MDQ6VXNlcjE5NTU0NDM5","avatar_url":"https://avatars3.githubusercontent.com/u/19554439?v=4","gravatar_id":"","url":"https://api.github.com/users/dp-arm","html_url":"https://github.com/dp-arm","followers_url":"https://api.github.com/users/dp-arm/followers","following_url":"https://api.github.com/users/dp-arm/following{/other_user}","gists_url":"https://api.github.com/users/dp-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/dp-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dp-arm/subscriptions","organizations_url":"https://api.github.com/users/dp-arm/orgs","repos_url":"https://api.github.com/users/dp-arm/repos","events_url":"https://api.github.com/users/dp-arm/events{/privacy}","received_events_url":"https://api.github.com/users/dp-arm/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"dp-arm"}}