{"action":"created","comment":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/173522682","pull_request_review_id":102734384,"id":173522682,"diff_hunk":"@@ -175,18 +156,7 @@ def install\n     args << \"CPPFLAGS=#{cppflags.join(\" \")}\" unless cppflags.empty?\n \n     system \"./configure\", *args\n-\n-    # HAVE_POLL is \"broken\" on macOS. See:\n-    # https://trac.macports.org/ticket/18376\n-    # https://bugs.python.org/issue5154\n-    if build.without? \"poll\"\n-      inreplace \"pyconfig.h\", /.*?(HAVE_POLL[_A-Z]*).*/, '#undef \\1'\n-    end","path":"Formula/python@2.rb","position":110,"original_position":110,"commit_id":"85d8a0fe15f072946e013f7a8ef8053b21bddf03","original_commit_id":"0c941fb6123b1b44f82978f4364b72e2eef329ef","user":{"login":"fxcoudert","id":1980544,"avatar_url":"https://avatars0.githubusercontent.com/u/1980544?v=4","gravatar_id":"","url":"https://api.github.com/users/fxcoudert","html_url":"https://github.com/fxcoudert","followers_url":"https://api.github.com/users/fxcoudert/followers","following_url":"https://api.github.com/users/fxcoudert/following{/other_user}","gists_url":"https://api.github.com/users/fxcoudert/gists{/gist_id}","starred_url":"https://api.github.com/users/fxcoudert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxcoudert/subscriptions","organizations_url":"https://api.github.com/users/fxcoudert/orgs","repos_url":"https://api.github.com/users/fxcoudert/repos","events_url":"https://api.github.com/users/fxcoudert/events{/privacy}","received_events_url":"https://api.github.com/users/fxcoudert/received_events","type":"User","site_admin":false},"body":"After reviewing the history of this hack, we want to get rid of it (i.e. in effect make `--with-poll` the new behavior).\r\n\r\nSome background: the `poll()` system call on macOS is limited in some cases (devices, rather than regular files). Someone reported it to python, and suggested turning it off completely, i.e. mimicking a system that has no poll support at all. Upstream considered it, and decided they’d rather ship with poll support “as close to the OS”, rather than disable it altogether. We should follow that decision.","created_at":"2018-03-09T18:00:24Z","updated_at":"2018-03-09T18:00:24Z","html_url":"https://github.com/Homebrew/homebrew-core/pull/25060#discussion_r173522682","pull_request_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments/173522682"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/25060#discussion_r173522682"},"pull_request":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060"}},"in_reply_to_id":173519795},"pull_request":{"url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060","id":174029295,"html_url":"https://github.com/Homebrew/homebrew-core/pull/25060","diff_url":"https://github.com/Homebrew/homebrew-core/pull/25060.diff","patch_url":"https://github.com/Homebrew/homebrew-core/pull/25060.patch","issue_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25060","number":25060,"state":"open","locked":false,"title":"python, python@2: make PEP 394 compliant","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/master/CONTRIBUTING.md)?\r\n- [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change?\r\n- [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting?\r\n- [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)?\r\n\r\n-----\r\n\r\nhttps://www.python.org/dev/peps/pep-0394/\r\n\r\nThis means python (Python 3) installs as `python3` and that python@2\r\n(Python 2) installs as `python` and `python2`.\r\n\r\nAlso,\r\n\r\npython:\r\n- make gdbm, readline, sqlite and xz required instead of recommended\r\n- depend on sphinx-doc at build-time non-optionally to build the docs\r\n- remove quicktest option\r\n- remove the poll option and make poll enabled as it is upstream\r\n\r\npython@2:\r\n- make non-keg_only\r\n- make gdbm, readline and sqlite required instead of recommended\r\n- depend on sphinx-doc at build-time non-optionally to build the docs\r\n- remove berkeley-db@4 optional dependency\r\n- remove quicktest option\r\n","created_at":"2018-03-09T15:12:57Z","updated_at":"2018-03-09T18:00:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75c0f9ea0fcaad778209750f76fad19648cd20f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":351930070,"url":"https://api.github.com/repos/Homebrew/homebrew-core/labels/python","name":"python","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060/commits","review_comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060/comments","review_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25060/comments","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/85d8a0fe15f072946e013f7a8ef8053b21bddf03","head":{"label":"ilovezfs:PEP-394","ref":"PEP-394","sha":"85d8a0fe15f072946e013f7a8ef8053b21bddf03","user":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"repo":{"id":55388441,"name":"homebrew-core","full_name":"ilovezfs/homebrew-core","owner":{"login":"ilovezfs","id":5268928,"avatar_url":"https://avatars2.githubusercontent.com/u/5268928?v=4","gravatar_id":"","url":"https://api.github.com/users/ilovezfs","html_url":"https://github.com/ilovezfs","followers_url":"https://api.github.com/users/ilovezfs/followers","following_url":"https://api.github.com/users/ilovezfs/following{/other_user}","gists_url":"https://api.github.com/users/ilovezfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ilovezfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilovezfs/subscriptions","organizations_url":"https://api.github.com/users/ilovezfs/orgs","repos_url":"https://api.github.com/users/ilovezfs/repos","events_url":"https://api.github.com/users/ilovezfs/events{/privacy}","received_events_url":"https://api.github.com/users/ilovezfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilovezfs/homebrew-core","description":":beers: Core formulae for the Homebrew package manager","fork":true,"url":"https://api.github.com/repos/ilovezfs/homebrew-core","forks_url":"https://api.github.com/repos/ilovezfs/homebrew-core/forks","keys_url":"https://api.github.com/repos/ilovezfs/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilovezfs/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilovezfs/homebrew-core/teams","hooks_url":"https://api.github.com/repos/ilovezfs/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/ilovezfs/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/ilovezfs/homebrew-core/events","assignees_url":"https://api.github.com/repos/ilovezfs/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/ilovezfs/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/ilovezfs/homebrew-core/tags","blobs_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilovezfs/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ilovezfs/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/ilovezfs/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/ilovezfs/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/ilovezfs/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/ilovezfs/homebrew-core/subscription","commits_url":"https://api.github.com/repos/ilovezfs/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilovezfs/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilovezfs/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilovezfs/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilovezfs/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/ilovezfs/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilovezfs/homebrew-core/merges","archive_url":"https://api.github.com/repos/ilovezfs/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilovezfs/homebrew-core/downloads","issues_url":"https://api.github.com/repos/ilovezfs/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/ilovezfs/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ilovezfs/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ilovezfs/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilovezfs/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/ilovezfs/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/ilovezfs/homebrew-core/deployments","created_at":"2016-04-04T05:59:03Z","updated_at":"2017-09-06T13:14:21Z","pushed_at":"2018-03-09T17:28:58Z","git_url":"git://github.com/ilovezfs/homebrew-core.git","ssh_url":"git@github.com:ilovezfs/homebrew-core.git","clone_url":"https://github.com/ilovezfs/homebrew-core.git","svn_url":"https://github.com/ilovezfs/homebrew-core","homepage":"http://brew.sh","size":184035,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"fba87cb5f5c7e926ce68434a40b5ab4ed5259cec","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":52855516,"name":"homebrew-core","full_name":"Homebrew/homebrew-core","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/homebrew-core","description":"🍻 Default formulae for the missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/homebrew-core","forks_url":"https://api.github.com/repos/Homebrew/homebrew-core/forks","keys_url":"https://api.github.com/repos/Homebrew/homebrew-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/homebrew-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/homebrew-core/teams","hooks_url":"https://api.github.com/repos/Homebrew/homebrew-core/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/homebrew-core/events","assignees_url":"https://api.github.com/repos/Homebrew/homebrew-core/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/homebrew-core/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/tags","blobs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/homebrew-core/languages","stargazers_url":"https://api.github.com/repos/Homebrew/homebrew-core/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/homebrew-core/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/homebrew-core/subscription","commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/homebrew-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/homebrew-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/homebrew-core/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/homebrew-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/homebrew-core/merges","archive_url":"https://api.github.com/repos/Homebrew/homebrew-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/homebrew-core/downloads","issues_url":"https://api.github.com/repos/Homebrew/homebrew-core/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/homebrew-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/homebrew-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/homebrew-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/homebrew-core/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/homebrew-core/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/homebrew-core/deployments","created_at":"2016-03-01T06:58:36Z","updated_at":"2018-03-09T17:48:39Z","pushed_at":"2018-03-09T17:29:02Z","git_url":"git://github.com/Homebrew/homebrew-core.git","ssh_url":"git@github.com:Homebrew/homebrew-core.git","clone_url":"https://github.com/Homebrew/homebrew-core.git","svn_url":"https://github.com/Homebrew/homebrew-core","homepage":"https://brew.sh","size":172848,"stargazers_count":3203,"watchers_count":3203,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4037,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":4037,"open_issues":84,"watchers":3203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060"},"html":{"href":"https://github.com/Homebrew/homebrew-core/pull/25060"},"issue":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25060"},"comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/issues/25060/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/pulls/25060/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/homebrew-core/statuses/85d8a0fe15f072946e013f7a8ef8053b21bddf03"}},"author_association":"OWNER"}}
{"actor":{"display_login":"fxcoudert"}}