{"action":"created","issue":{"url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1212","repository_url":"https://api.github.com/repos/nusmodifications/nusmods","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1212/labels{/name}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1212/comments","events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1212/events","html_url":"https://github.com/nusmodifications/nusmods/issues/1212","id":368930392,"node_id":"MDU6SXNzdWUzNjg5MzAzOTI=","number":1212,"title":"Add a fullscreen toggle for venue maps ","user":{"login":"ZhangYiJiang","id":445650,"node_id":"MDQ6VXNlcjQ0NTY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/445650?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYiJiang","html_url":"https://github.com/ZhangYiJiang","followers_url":"https://api.github.com/users/ZhangYiJiang/followers","following_url":"https://api.github.com/users/ZhangYiJiang/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYiJiang/subscriptions","organizations_url":"https://api.github.com/users/ZhangYiJiang/orgs","repos_url":"https://api.github.com/users/ZhangYiJiang/repos","events_url":"https://api.github.com/users/ZhangYiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYiJiang/received_events","type":"User","site_admin":false},"labels":[{"id":1075434596,"node_id":"MDU6TGFiZWwxMDc1NDM0NTk2","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/Hacktoberfest","name":"Hacktoberfest","color":"4f283a","default":false},{"id":1076421680,"node_id":"MDU6TGFiZWwxMDc2NDIxNjgw","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/Taken","name":"Taken","color":"ad1a35","default":false},{"id":114040679,"node_id":"MDU6TGFiZWwxMTQwNDA2Nzk=","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/good%20first%20issue","name":"good first issue","color":"fbca04","default":true},{"id":793729405,"node_id":"MDU6TGFiZWw3OTM3Mjk0MDU=","url":"https://api.github.com/repos/nusmodifications/nusmods/labels/venues%20page","name":"venues page","color":"082d66","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-11T02:48:24Z","updated_at":"2018-10-12T06:54:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We use a React Leaflet map component to show venue locations (eg. https://nusmods.com/venues/AS1-0207). It would be great if a fullscreen button can be added so the map expands out to fill the whole screen, or at least the entire right side of the page (on desktop). \r\n\r\nThis would be even more helpful for the update location form, which can definitely benefit from allowing the map to use the full width / height of the screen instead of just the form. \r\n\r\n![screenshot from 2018-10-11 10-47-38](https://user-images.githubusercontent.com/445650/46777734-23af6400-cd43-11e8-91a3-20b159ae5676.png)\r\n"},"comment":{"url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments/429224066","html_url":"https://github.com/nusmodifications/nusmods/issues/1212#issuecomment-429224066","issue_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1212","id":429224066,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTIyNDA2Ng==","user":{"login":"ZhangYiJiang","id":445650,"node_id":"MDQ6VXNlcjQ0NTY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/445650?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYiJiang","html_url":"https://github.com/ZhangYiJiang","followers_url":"https://api.github.com/users/ZhangYiJiang/followers","following_url":"https://api.github.com/users/ZhangYiJiang/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYiJiang/subscriptions","organizations_url":"https://api.github.com/users/ZhangYiJiang/orgs","repos_url":"https://api.github.com/users/ZhangYiJiang/repos","events_url":"https://api.github.com/users/ZhangYiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYiJiang/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T06:54:54Z","updated_at":"2018-10-12T06:54:54Z","author_association":"CONTRIBUTOR","body":"@schalkneethling Sure! The component in question is here: https://github.com/nusmodifications/nusmods/blob/master/www/src/js/views/venues/VenueLocation/VenueLocation.jsx. You can find instructions for setting up the project at https://github.com/nusmodifications/nusmods/tree/master/www, and if you have problem setting up you can talk to us on Telegram at https://telegram.me/nusmods "}}
{"actor":{"display_login":"ZhangYiJiang"}}