{"action":"opened","number":432,"pull_request":{"url":"https://api.github.com/repos/nextic/IC/pulls/432","id":166604560,"html_url":"https://github.com/nextic/IC/pull/432","diff_url":"https://github.com/nextic/IC/pull/432.diff","patch_url":"https://github.com/nextic/IC/pull/432.patch","issue_url":"https://api.github.com/repos/nextic/IC/issues/432","number":432,"state":"open","locked":false,"title":"Cities safety checks","user":{"login":"gonzaponte","id":8233521,"avatar_url":"https://avatars1.githubusercontent.com/u/8233521?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzaponte","html_url":"https://github.com/gonzaponte","followers_url":"https://api.github.com/users/gonzaponte/followers","following_url":"https://api.github.com/users/gonzaponte/following{/other_user}","gists_url":"https://api.github.com/users/gonzaponte/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzaponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzaponte/subscriptions","organizations_url":"https://api.github.com/users/gonzaponte/orgs","repos_url":"https://api.github.com/users/gonzaponte/repos","events_url":"https://api.github.com/users/gonzaponte/events{/privacy}","received_events_url":"https://api.github.com/users/gonzaponte/received_events","type":"User","site_admin":false},"body":"This PR fixes a bug in the output of `Irene`, where the event number of empty (at the pmap level) events were being stored, creating an inconsistency between two different tables in the file. At the same time, `PCity` contained a check when reading the input that allowed the bug to pass silently. In #417 this check was removed, which revealed the bug.\r\n\r\nThis PR filters out empty events from `Irene`'s output and reintroduces the check in `PCity` for backward-compatibility (so we can run the city on old data). Three tests have been introduced to ensure this bug doesn't cause any further problems.","created_at":"2018-02-01T17:37:02Z","updated_at":"2018-02-01T17:37:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/nextic/IC/pulls/432/commits","review_comments_url":"https://api.github.com/repos/nextic/IC/pulls/432/comments","review_comment_url":"https://api.github.com/repos/nextic/IC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nextic/IC/issues/432/comments","statuses_url":"https://api.github.com/repos/nextic/IC/statuses/988af83e4e7dcb8747691ad083bcfb943e6149cf","head":{"label":"gonzaponte:cities-safety-checks","ref":"cities-safety-checks","sha":"988af83e4e7dcb8747691ad083bcfb943e6149cf","user":{"login":"gonzaponte","id":8233521,"avatar_url":"https://avatars1.githubusercontent.com/u/8233521?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzaponte","html_url":"https://github.com/gonzaponte","followers_url":"https://api.github.com/users/gonzaponte/followers","following_url":"https://api.github.com/users/gonzaponte/following{/other_user}","gists_url":"https://api.github.com/users/gonzaponte/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzaponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzaponte/subscriptions","organizations_url":"https://api.github.com/users/gonzaponte/orgs","repos_url":"https://api.github.com/users/gonzaponte/repos","events_url":"https://api.github.com/users/gonzaponte/events{/privacy}","received_events_url":"https://api.github.com/users/gonzaponte/received_events","type":"User","site_admin":false},"repo":{"id":80111367,"name":"IC","full_name":"gonzaponte/IC","owner":{"login":"gonzaponte","id":8233521,"avatar_url":"https://avatars1.githubusercontent.com/u/8233521?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzaponte","html_url":"https://github.com/gonzaponte","followers_url":"https://api.github.com/users/gonzaponte/followers","following_url":"https://api.github.com/users/gonzaponte/following{/other_user}","gists_url":"https://api.github.com/users/gonzaponte/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzaponte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzaponte/subscriptions","organizations_url":"https://api.github.com/users/gonzaponte/orgs","repos_url":"https://api.github.com/users/gonzaponte/repos","events_url":"https://api.github.com/users/gonzaponte/events{/privacy}","received_events_url":"https://api.github.com/users/gonzaponte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gonzaponte/IC","description":null,"fork":true,"url":"https://api.github.com/repos/gonzaponte/IC","forks_url":"https://api.github.com/repos/gonzaponte/IC/forks","keys_url":"https://api.github.com/repos/gonzaponte/IC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonzaponte/IC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonzaponte/IC/teams","hooks_url":"https://api.github.com/repos/gonzaponte/IC/hooks","issue_events_url":"https://api.github.com/repos/gonzaponte/IC/issues/events{/number}","events_url":"https://api.github.com/repos/gonzaponte/IC/events","assignees_url":"https://api.github.com/repos/gonzaponte/IC/assignees{/user}","branches_url":"https://api.github.com/repos/gonzaponte/IC/branches{/branch}","tags_url":"https://api.github.com/repos/gonzaponte/IC/tags","blobs_url":"https://api.github.com/repos/gonzaponte/IC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonzaponte/IC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonzaponte/IC/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonzaponte/IC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonzaponte/IC/statuses/{sha}","languages_url":"https://api.github.com/repos/gonzaponte/IC/languages","stargazers_url":"https://api.github.com/repos/gonzaponte/IC/stargazers","contributors_url":"https://api.github.com/repos/gonzaponte/IC/contributors","subscribers_url":"https://api.github.com/repos/gonzaponte/IC/subscribers","subscription_url":"https://api.github.com/repos/gonzaponte/IC/subscription","commits_url":"https://api.github.com/repos/gonzaponte/IC/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonzaponte/IC/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonzaponte/IC/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonzaponte/IC/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonzaponte/IC/contents/{+path}","compare_url":"https://api.github.com/repos/gonzaponte/IC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonzaponte/IC/merges","archive_url":"https://api.github.com/repos/gonzaponte/IC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonzaponte/IC/downloads","issues_url":"https://api.github.com/repos/gonzaponte/IC/issues{/number}","pulls_url":"https://api.github.com/repos/gonzaponte/IC/pulls{/number}","milestones_url":"https://api.github.com/repos/gonzaponte/IC/milestones{/number}","notifications_url":"https://api.github.com/repos/gonzaponte/IC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonzaponte/IC/labels{/name}","releases_url":"https://api.github.com/repos/gonzaponte/IC/releases{/id}","deployments_url":"https://api.github.com/repos/gonzaponte/IC/deployments","created_at":"2017-01-26T12:07:41Z","updated_at":"2017-01-26T12:10:53Z","pushed_at":"2018-02-01T17:34:14Z","git_url":"git://github.com/gonzaponte/IC.git","ssh_url":"git@github.com:gonzaponte/IC.git","clone_url":"https://github.com/gonzaponte/IC.git","svn_url":"https://github.com/gonzaponte/IC","homepage":null,"size":32636,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nextic:master","ref":"master","sha":"a31b0a404761eb9b8d6781eba9634ad51b286adb","user":{"login":"nextic","id":23397670,"avatar_url":"https://avatars1.githubusercontent.com/u/23397670?v=4","gravatar_id":"","url":"https://api.github.com/users/nextic","html_url":"https://github.com/nextic","followers_url":"https://api.github.com/users/nextic/followers","following_url":"https://api.github.com/users/nextic/following{/other_user}","gists_url":"https://api.github.com/users/nextic/gists{/gist_id}","starred_url":"https://api.github.com/users/nextic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextic/subscriptions","organizations_url":"https://api.github.com/users/nextic/orgs","repos_url":"https://api.github.com/users/nextic/repos","events_url":"https://api.github.com/users/nextic/events{/privacy}","received_events_url":"https://api.github.com/users/nextic/received_events","type":"Organization","site_admin":false},"repo":{"id":76445486,"name":"IC","full_name":"nextic/IC","owner":{"login":"nextic","id":23397670,"avatar_url":"https://avatars1.githubusercontent.com/u/23397670?v=4","gravatar_id":"","url":"https://api.github.com/users/nextic","html_url":"https://github.com/nextic","followers_url":"https://api.github.com/users/nextic/followers","following_url":"https://api.github.com/users/nextic/following{/other_user}","gists_url":"https://api.github.com/users/nextic/gists{/gist_id}","starred_url":"https://api.github.com/users/nextic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nextic/subscriptions","organizations_url":"https://api.github.com/users/nextic/orgs","repos_url":"https://api.github.com/users/nextic/repos","events_url":"https://api.github.com/users/nextic/events{/privacy}","received_events_url":"https://api.github.com/users/nextic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nextic/IC","description":null,"fork":false,"url":"https://api.github.com/repos/nextic/IC","forks_url":"https://api.github.com/repos/nextic/IC/forks","keys_url":"https://api.github.com/repos/nextic/IC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nextic/IC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nextic/IC/teams","hooks_url":"https://api.github.com/repos/nextic/IC/hooks","issue_events_url":"https://api.github.com/repos/nextic/IC/issues/events{/number}","events_url":"https://api.github.com/repos/nextic/IC/events","assignees_url":"https://api.github.com/repos/nextic/IC/assignees{/user}","branches_url":"https://api.github.com/repos/nextic/IC/branches{/branch}","tags_url":"https://api.github.com/repos/nextic/IC/tags","blobs_url":"https://api.github.com/repos/nextic/IC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nextic/IC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nextic/IC/git/refs{/sha}","trees_url":"https://api.github.com/repos/nextic/IC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nextic/IC/statuses/{sha}","languages_url":"https://api.github.com/repos/nextic/IC/languages","stargazers_url":"https://api.github.com/repos/nextic/IC/stargazers","contributors_url":"https://api.github.com/repos/nextic/IC/contributors","subscribers_url":"https://api.github.com/repos/nextic/IC/subscribers","subscription_url":"https://api.github.com/repos/nextic/IC/subscription","commits_url":"https://api.github.com/repos/nextic/IC/commits{/sha}","git_commits_url":"https://api.github.com/repos/nextic/IC/git/commits{/sha}","comments_url":"https://api.github.com/repos/nextic/IC/comments{/number}","issue_comment_url":"https://api.github.com/repos/nextic/IC/issues/comments{/number}","contents_url":"https://api.github.com/repos/nextic/IC/contents/{+path}","compare_url":"https://api.github.com/repos/nextic/IC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nextic/IC/merges","archive_url":"https://api.github.com/repos/nextic/IC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nextic/IC/downloads","issues_url":"https://api.github.com/repos/nextic/IC/issues{/number}","pulls_url":"https://api.github.com/repos/nextic/IC/pulls{/number}","milestones_url":"https://api.github.com/repos/nextic/IC/milestones{/number}","notifications_url":"https://api.github.com/repos/nextic/IC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nextic/IC/labels{/name}","releases_url":"https://api.github.com/repos/nextic/IC/releases{/id}","deployments_url":"https://api.github.com/repos/nextic/IC/deployments","created_at":"2016-12-14T09:37:40Z","updated_at":"2017-11-01T20:09:37Z","pushed_at":"2018-01-30T14:33:27Z","git_url":"git://github.com/nextic/IC.git","ssh_url":"git@github.com:nextic/IC.git","clone_url":"https://github.com/nextic/IC.git","svn_url":"https://github.com/nextic/IC","homepage":null,"size":31982,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":17,"open_issues":39,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nextic/IC/pulls/432"},"html":{"href":"https://github.com/nextic/IC/pull/432"},"issue":{"href":"https://api.github.com/repos/nextic/IC/issues/432"},"comments":{"href":"https://api.github.com/repos/nextic/IC/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/nextic/IC/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/nextic/IC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nextic/IC/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/nextic/IC/statuses/988af83e4e7dcb8747691ad083bcfb943e6149cf"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":83,"deletions":15,"changed_files":7}}
{"actor":{"display_login":"gonzaponte"}}