{"action":"created","issue":{"url":"https://api.github.com/repos/auraphp/Aura.Di/issues/167","repository_url":"https://api.github.com/repos/auraphp/Aura.Di","labels_url":"https://api.github.com/repos/auraphp/Aura.Di/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/auraphp/Aura.Di/issues/167/comments","events_url":"https://api.github.com/repos/auraphp/Aura.Di/issues/167/events","html_url":"https://github.com/auraphp/Aura.Di/pull/167","id":331186171,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTc5MTUw","number":167,"title":"Added support for variadic constructor parameters","user":{"login":"marcusjhdon","id":299708,"node_id":"MDQ6VXNlcjI5OTcwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/299708?v=4","gravatar_id":"","url":"https://api.github.com/users/marcusjhdon","html_url":"https://github.com/marcusjhdon","followers_url":"https://api.github.com/users/marcusjhdon/followers","following_url":"https://api.github.com/users/marcusjhdon/following{/other_user}","gists_url":"https://api.github.com/users/marcusjhdon/gists{/gist_id}","starred_url":"https://api.github.com/users/marcusjhdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcusjhdon/subscriptions","organizations_url":"https://api.github.com/users/marcusjhdon/orgs","repos_url":"https://api.github.com/users/marcusjhdon/repos","events_url":"https://api.github.com/users/marcusjhdon/events{/privacy}","received_events_url":"https://api.github.com/users/marcusjhdon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"harikt","id":120454,"node_id":"MDQ6VXNlcjEyMDQ1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/120454?v=4","gravatar_id":"","url":"https://api.github.com/users/harikt","html_url":"https://github.com/harikt","followers_url":"https://api.github.com/users/harikt/followers","following_url":"https://api.github.com/users/harikt/following{/other_user}","gists_url":"https://api.github.com/users/harikt/gists{/gist_id}","starred_url":"https://api.github.com/users/harikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harikt/subscriptions","organizations_url":"https://api.github.com/users/harikt/orgs","repos_url":"https://api.github.com/users/harikt/repos","events_url":"https://api.github.com/users/harikt/events{/privacy}","received_events_url":"https://api.github.com/users/harikt/received_events","type":"User","site_admin":false},"assignees":[{"login":"harikt","id":120454,"node_id":"MDQ6VXNlcjEyMDQ1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/120454?v=4","gravatar_id":"","url":"https://api.github.com/users/harikt","html_url":"https://github.com/harikt","followers_url":"https://api.github.com/users/harikt/followers","following_url":"https://api.github.com/users/harikt/following{/other_user}","gists_url":"https://api.github.com/users/harikt/gists{/gist_id}","starred_url":"https://api.github.com/users/harikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harikt/subscriptions","organizations_url":"https://api.github.com/users/harikt/orgs","repos_url":"https://api.github.com/users/harikt/repos","events_url":"https://api.github.com/users/harikt/events{/privacy}","received_events_url":"https://api.github.com/users/harikt/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-06-11T13:20:34Z","updated_at":"2018-06-18T05:31:20Z","closed_at":"2018-06-18T04:52:00Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/auraphp/Aura.Di/pulls/167","html_url":"https://github.com/auraphp/Aura.Di/pull/167","diff_url":"https://github.com/auraphp/Aura.Di/pull/167.diff","patch_url":"https://github.com/auraphp/Aura.Di/pull/167.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/auraphp/Aura.Di/issues/comments/397946012","html_url":"https://github.com/auraphp/Aura.Di/pull/167#issuecomment-397946012","issue_url":"https://api.github.com/repos/auraphp/Aura.Di/issues/167","id":397946012,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzk0NjAxMg==","user":{"login":"harikt","id":120454,"node_id":"MDQ6VXNlcjEyMDQ1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/120454?v=4","gravatar_id":"","url":"https://api.github.com/users/harikt","html_url":"https://github.com/harikt","followers_url":"https://api.github.com/users/harikt/followers","following_url":"https://api.github.com/users/harikt/following{/other_user}","gists_url":"https://api.github.com/users/harikt/gists{/gist_id}","starred_url":"https://api.github.com/users/harikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harikt/subscriptions","organizations_url":"https://api.github.com/users/harikt/orgs","repos_url":"https://api.github.com/users/harikt/repos","events_url":"https://api.github.com/users/harikt/events{/privacy}","received_events_url":"https://api.github.com/users/harikt/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T05:31:20Z","updated_at":"2018-06-18T05:31:20Z","author_association":"MEMBER","body":"Just to verify I did the tests as in the issue #164 . And it fails. It only have one value in the array.\r\n\r\n```php\r\n<?php\r\nrequire __DIR__ . '/vendor/autoload.php';\r\n\r\nclass Test {\r\n    public function __construct(...$items) {\r\n        print_r($items);\r\n    }\r\n}\r\n\r\nclass Config extends Aura\\Di\\ContainerConfig {\r\n    public function define(Aura\\Di\\Container $di)  {\r\n        $di->params[Test::class][] = 'one';\r\n        $di->params[Test::class][] = 'two';\r\n        $di->set('test', $di->lazyNew(Test::class));\r\n    }\r\n}\r\n\r\n(new Aura\\Di\\ContainerBuilder())\r\n    ->newConfiguredInstance([Config::class])\r\n    ->get('test');\r\n```\r\n\r\nResult :\r\n\r\n```\r\nArray\r\n(\r\n    [0] => one\r\n)\r\n```\r\n\r\nExpected : \r\n\r\n```\r\nArray ( [0] => one [1] => two )\r\n```\r\n\r\nSo this looks not fixed yet ? I am reverting the merge."}}
{"actor":{"display_login":"harikt"}}