{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/178597305","pull_request_review_id":108678608,"id":178597305,"diff_hunk":"@@ -1047,7 +1047,7 @@ Future<int> countActivePlayers(String teamName) [!async!] {\n {% prettify dart %}\n Future<int> countActivePlayers(String teamName) {\n   return downloadTeam(teamName).then((team) {\n-    if (team == null) return 0;","path":"src/_guides/language/effective-dart/usage.md","position":null,"original_position":4,"commit_id":"a918ecd21ad5274555ae3a59a5e1b78b5ba0d56c","original_commit_id":"a918ecd21ad5274555ae3a59a5e1b78b5ba0d56c","user":{"login":"munificent","id":46275,"avatar_url":"https://avatars0.githubusercontent.com/u/46275?v=4","gravatar_id":"","url":"https://api.github.com/users/munificent","html_url":"https://github.com/munificent","followers_url":"https://api.github.com/users/munificent/followers","following_url":"https://api.github.com/users/munificent/following{/other_user}","gists_url":"https://api.github.com/users/munificent/gists{/gist_id}","starred_url":"https://api.github.com/users/munificent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munificent/subscriptions","organizations_url":"https://api.github.com/users/munificent/orgs","repos_url":"https://api.github.com/users/munificent/repos","events_url":"https://api.github.com/users/munificent/events{/privacy}","received_events_url":"https://api.github.com/users/munificent/received_events","type":"User","site_admin":false},"body":"It will at runtime, but type inference gets a little confused when you have a function body that returns both an immediate value and a future, I think.","created_at":"2018-04-02T17:30:09Z","updated_at":"2018-04-02T17:30:09Z","html_url":"https://github.com/dart-lang/site-www/pull/730#discussion_r178597305","pull_request_url":"https://api.github.com/repos/dart-lang/site-www/pulls/730","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments/178597305"},"html":{"href":"https://github.com/dart-lang/site-www/pull/730#discussion_r178597305"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/730"}},"in_reply_to_id":178596396},"pull_request":{"url":"https://api.github.com/repos/dart-lang/site-www/pulls/730","id":178657110,"html_url":"https://github.com/dart-lang/site-www/pull/730","diff_url":"https://github.com/dart-lang/site-www/pull/730.diff","patch_url":"https://github.com/dart-lang/site-www/pull/730.patch","issue_url":"https://api.github.com/repos/dart-lang/site-www/issues/730","number":730,"state":"open","locked":false,"title":"Better async example.","user":{"login":"munificent","id":46275,"avatar_url":"https://avatars0.githubusercontent.com/u/46275?v=4","gravatar_id":"","url":"https://api.github.com/users/munificent","html_url":"https://github.com/munificent","followers_url":"https://api.github.com/users/munificent/followers","following_url":"https://api.github.com/users/munificent/following{/other_user}","gists_url":"https://api.github.com/users/munificent/gists{/gist_id}","starred_url":"https://api.github.com/users/munificent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munificent/subscriptions","organizations_url":"https://api.github.com/users/munificent/orgs","repos_url":"https://api.github.com/users/munificent/repos","events_url":"https://api.github.com/users/munificent/events{/privacy}","received_events_url":"https://api.github.com/users/munificent/received_events","type":"User","site_admin":false},"body":"Also remove a bullet point that no longer applies with sync-async.\r\n\r\nFix #79.","created_at":"2018-03-31T00:33:23Z","updated_at":"2018-04-02T17:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d73521c63d952564dbef36b38f4cdf399bb92077","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chalin","id":4140793,"avatar_url":"https://avatars1.githubusercontent.com/u/4140793?v=4","gravatar_id":"","url":"https://api.github.com/users/chalin","html_url":"https://github.com/chalin","followers_url":"https://api.github.com/users/chalin/followers","following_url":"https://api.github.com/users/chalin/following{/other_user}","gists_url":"https://api.github.com/users/chalin/gists{/gist_id}","starred_url":"https://api.github.com/users/chalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chalin/subscriptions","organizations_url":"https://api.github.com/users/chalin/orgs","repos_url":"https://api.github.com/users/chalin/repos","events_url":"https://api.github.com/users/chalin/events{/privacy}","received_events_url":"https://api.github.com/users/chalin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":421018044,"url":"https://api.github.com/repos/dart-lang/site-www/labels/cla:%20yes","name":"cla: yes","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/site-www/pulls/730/commits","review_comments_url":"https://api.github.com/repos/dart-lang/site-www/pulls/730/comments","review_comment_url":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/site-www/issues/730/comments","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/a918ecd21ad5274555ae3a59a5e1b78b5ba0d56c","head":{"label":"dart-lang:async","ref":"async","sha":"a918ecd21ad5274555ae3a59a5e1b78b5ba0d56c","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2018-04-02T16:40:20Z","pushed_at":"2018-04-02T17:24:19Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"git@github.com:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":11784,"stargazers_count":86,"watchers_count":86,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":151,"watchers":86,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"2612bd3a25d1a0c817e152f66f8166dc2160ee17","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":63089994,"name":"site-www","full_name":"dart-lang/site-www","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/site-www","description":"Source for Dart website","fork":false,"url":"https://api.github.com/repos/dart-lang/site-www","forks_url":"https://api.github.com/repos/dart-lang/site-www/forks","keys_url":"https://api.github.com/repos/dart-lang/site-www/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/site-www/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/site-www/teams","hooks_url":"https://api.github.com/repos/dart-lang/site-www/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/site-www/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/site-www/events","assignees_url":"https://api.github.com/repos/dart-lang/site-www/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/site-www/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/site-www/tags","blobs_url":"https://api.github.com/repos/dart-lang/site-www/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/site-www/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/site-www/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/site-www/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/site-www/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/site-www/languages","stargazers_url":"https://api.github.com/repos/dart-lang/site-www/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/site-www/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/site-www/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/site-www/subscription","commits_url":"https://api.github.com/repos/dart-lang/site-www/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/site-www/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/site-www/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/site-www/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/site-www/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/site-www/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/site-www/merges","archive_url":"https://api.github.com/repos/dart-lang/site-www/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/site-www/downloads","issues_url":"https://api.github.com/repos/dart-lang/site-www/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/site-www/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/site-www/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/site-www/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/site-www/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/site-www/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/site-www/deployments","created_at":"2016-07-11T17:57:36Z","updated_at":"2018-04-02T16:40:20Z","pushed_at":"2018-04-02T17:24:19Z","git_url":"git://github.com/dart-lang/site-www.git","ssh_url":"git@github.com:dart-lang/site-www.git","clone_url":"https://github.com/dart-lang/site-www.git","svn_url":"https://github.com/dart-lang/site-www","homepage":"https://www.dartlang.org/","size":11784,"stargazers_count":86,"watchers_count":86,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":151,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":151,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/730"},"html":{"href":"https://github.com/dart-lang/site-www/pull/730"},"issue":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/730"},"comments":{"href":"https://api.github.com/repos/dart-lang/site-www/issues/730/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/730/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/site-www/pulls/730/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/site-www/statuses/a918ecd21ad5274555ae3a59a5e1b78b5ba0d56c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"munificent"}}