{"action":"created","issue":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/1004","repository_url":"https://api.github.com/repos/adafruit/circuitpython","labels_url":"https://api.github.com/repos/adafruit/circuitpython/issues/1004/labels{/name}","comments_url":"https://api.github.com/repos/adafruit/circuitpython/issues/1004/comments","events_url":"https://api.github.com/repos/adafruit/circuitpython/issues/1004/events","html_url":"https://github.com/adafruit/circuitpython/pull/1004","id":339578536,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTk3NTY2","number":1004,"title":"Nrf52840 usbboot","user":{"login":"hathach","id":249515,"node_id":"MDQ6VXNlcjI0OTUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/249515?v=4","gravatar_id":"","url":"https://api.github.com/users/hathach","html_url":"https://github.com/hathach","followers_url":"https://api.github.com/users/hathach/followers","following_url":"https://api.github.com/users/hathach/following{/other_user}","gists_url":"https://api.github.com/users/hathach/gists{/gist_id}","starred_url":"https://api.github.com/users/hathach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hathach/subscriptions","organizations_url":"https://api.github.com/users/hathach/orgs","repos_url":"https://api.github.com/users/hathach/repos","events_url":"https://api.github.com/users/hathach/events{/privacy}","received_events_url":"https://api.github.com/users/hathach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2018-07-09T19:32:20Z","updated_at":"2018-07-12T18:47:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/adafruit/circuitpython/pulls/1004","html_url":"https://github.com/adafruit/circuitpython/pull/1004","diff_url":"https://github.com/adafruit/circuitpython/pull/1004.diff","patch_url":"https://github.com/adafruit/circuitpython/pull/1004.patch"},"body":"this PR add uf2 bootloader, also up-gradable via CDC with nrfutil and OTA. It also add the MSC with internal flash + CDC as serial for circuitpython. To go into uf2 mode, press button0 (on pca10056) while reset (double reset won't work for nrf series). \r\n\r\nThere is still (at least) some known bugs.\r\n1. On Linux the very first time we connect to cp with minicom, there is ~10 seconds delay. Afterwards (welcome prompt is printed) the terminal can disconnect/reconnect and work normally. On windows, it seems to be OK. I am suspecting some background task is not run properly at first. Spend a few hours to debug, but I want to make the initial PR for testing first ( come back to this later)\r\n2. The flash filesystem only work when SD is disabled. When SD is enabled, application basically only queue the flash operation (erase + write), SD will report complete asynchronously via callback  (write buffer must remain valid until then).  Some sync method is needed, we come back to this later.\r\n\r\n@arturo182  to continue to use hwuart (jlink) for serial instead of usb cdc, you can change this macro from 0 to 1. The name of macro is not good at all, I will try to \r\nfind a better name for it later or if you could, please suggest one.  https://github.com/adafruit/circuitpython/blob/nrf52840_usbboot/ports/nrf/boards/pca10056/mpconfigboard.h#L40 \r\n\r\nPS: First time I pushed an PR to circuitpy, let's me know if anything I should changes to get merged."},"comment":{"url":"https://api.github.com/repos/adafruit/circuitpython/issues/comments/404612419","html_url":"https://github.com/adafruit/circuitpython/pull/1004#issuecomment-404612419","issue_url":"https://api.github.com/repos/adafruit/circuitpython/issues/1004","id":404612419,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDYxMjQxOQ==","user":{"login":"tannewt","id":52649,"node_id":"MDQ6VXNlcjUyNjQ5","avatar_url":"https://avatars1.githubusercontent.com/u/52649?v=4","gravatar_id":"","url":"https://api.github.com/users/tannewt","html_url":"https://github.com/tannewt","followers_url":"https://api.github.com/users/tannewt/followers","following_url":"https://api.github.com/users/tannewt/following{/other_user}","gists_url":"https://api.github.com/users/tannewt/gists{/gist_id}","starred_url":"https://api.github.com/users/tannewt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannewt/subscriptions","organizations_url":"https://api.github.com/users/tannewt/orgs","repos_url":"https://api.github.com/users/tannewt/repos","events_url":"https://api.github.com/users/tannewt/events{/privacy}","received_events_url":"https://api.github.com/users/tannewt/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T18:47:22Z","updated_at":"2018-07-12T18:47:22Z","author_association":"COLLABORATOR","body":"Thank you all!"}}
{"actor":{"display_login":"tannewt"}}