{"action":"created","comment":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/comments/179805278","pull_request_review_id":110121737,"id":179805278,"diff_hunk":"@@ -77,17 +77,32 @@ although it will be valid, the bundle may not be *useful*.\n For further usage information, see the integration test projects under the included\n `src/test/resources/integration-test/test` directory.\n \n-## Configuration Properties\n+## Configuration Parameters\n \n-|Configuration Property | Description |\n+|Configuration Parameter | Description |\n | ---                   | ---         |\n+|`bndfile`            | File path to a bnd file containing bnd instructions for this project. The file path can be either absolute or relative to the project directory. _Defaults to `bnd.bnd`_.|\n+|`bnd`            | Bnd instructions for this project specified directly in the pom file. This is generally be done using a {@code <![CDATA[]]>} section. If the projects has a `bndfile` configuration property or a file in the default location `bnd.bnd`, then this configuration element is ignored. |\n |`targetDir`            | The director into which to export the result. _Defaults to `${project.build.directory}`._|\n |`sourceDir`            | Specify an alternative source directory. _Defaults to `${project.build.sourceDirectory}`._|\n |`resources`            | Specify an alternative resources directory. _Defaults to `${project.build.resources}`._|\n |`classesDir`           | Specify an alternative classes directory. _Defaults to `${project.build.outputDirectory}`._|\n |`manifestPath`         | Specify the path to a manifest file to use. _Defaults to `${project.build.outputDirectory}/META-INF/MANIFEST.MF`._|\n |`skip`                 | Skip the index process altogether. _Defaults to `false`._ Override with property `bnd.skip`.|\n \n+## Inheritance of bnd instructions\n+\n+Bnd instructions in general are being merged with the ones being set on the Maven project's parent. This works slightly differently than [default plugin configuration merging in Maven](http://blog.sonatype.com/2011/01/maven-how-to-merging-plugin-configuration-in-complex-projects/). From the following places the bnd instructions are collected from all pom.xmls in the hierarchy (starting with the top level parent pom and ending with the leaf project's pom):\n+\n+1. From the `<pluginManagement>` section for this plugin (both configuration within the current execution and the global one)","path":"maven/bnd-maven-plugin/README.md","position":23,"original_position":23,"commit_id":"157785f4a78ae154abd98547984b9880e4bc75a9","original_commit_id":"157785f4a78ae154abd98547984b9880e4bc75a9","user":{"login":"kwin","id":185025,"avatar_url":"https://avatars2.githubusercontent.com/u/185025?v=4","gravatar_id":"","url":"https://api.github.com/users/kwin","html_url":"https://github.com/kwin","followers_url":"https://api.github.com/users/kwin/followers","following_url":"https://api.github.com/users/kwin/following{/other_user}","gists_url":"https://api.github.com/users/kwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwin/subscriptions","organizations_url":"https://api.github.com/users/kwin/orgs","repos_url":"https://api.github.com/users/kwin/repos","events_url":"https://api.github.com/users/kwin/events{/privacy}","received_events_url":"https://api.github.com/users/kwin/received_events","type":"User","site_admin":false},"body":"> Only if the project does not have an execution configuration do you look for pluginManagement configuration. pluginManagement is not checked if the project has an execution configuration. \r\n\r\nThis is not correct from a functional perspective. PluginMgmt is always being merged by Maven and both plugin as well as pluginMgmt support execution and global configuration!","created_at":"2018-04-06T16:09:21Z","updated_at":"2018-04-06T16:09:21Z","html_url":"https://github.com/bndtools/bnd/pull/2272#discussion_r179805278","pull_request_url":"https://api.github.com/repos/bndtools/bnd/pulls/2272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments/179805278"},"html":{"href":"https://github.com/bndtools/bnd/pull/2272#discussion_r179805278"},"pull_request":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2272"}},"in_reply_to_id":164152643},"pull_request":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/2272","id":164910084,"html_url":"https://github.com/bndtools/bnd/pull/2272","diff_url":"https://github.com/bndtools/bnd/pull/2272.diff","patch_url":"https://github.com/bndtools/bnd/pull/2272.patch","issue_url":"https://api.github.com/repos/bndtools/bnd/issues/2272","number":2272,"state":"open","locked":false,"title":"clarify bnd instruction inheritance/merging","user":{"login":"kwin","id":185025,"avatar_url":"https://avatars2.githubusercontent.com/u/185025?v=4","gravatar_id":"","url":"https://api.github.com/users/kwin","html_url":"https://github.com/kwin","followers_url":"https://api.github.com/users/kwin/followers","following_url":"https://api.github.com/users/kwin/following{/other_user}","gists_url":"https://api.github.com/users/kwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwin/subscriptions","organizations_url":"https://api.github.com/users/kwin/orgs","repos_url":"https://api.github.com/users/kwin/repos","events_url":"https://api.github.com/users/kwin/events{/privacy}","received_events_url":"https://api.github.com/users/kwin/received_events","type":"User","site_admin":false},"body":"also document all mojo configuration parameters","created_at":"2018-01-24T17:15:19Z","updated_at":"2018-04-06T16:09:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8913cac3959d04250b1c1acb5dd3f37faffdea4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bndtools/bnd/pulls/2272/commits","review_comments_url":"https://api.github.com/repos/bndtools/bnd/pulls/2272/comments","review_comment_url":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bndtools/bnd/issues/2272/comments","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/157785f4a78ae154abd98547984b9880e4bc75a9","head":{"label":"kwin:update-inheritance-documentation","ref":"update-inheritance-documentation","sha":"157785f4a78ae154abd98547984b9880e4bc75a9","user":{"login":"kwin","id":185025,"avatar_url":"https://avatars2.githubusercontent.com/u/185025?v=4","gravatar_id":"","url":"https://api.github.com/users/kwin","html_url":"https://github.com/kwin","followers_url":"https://api.github.com/users/kwin/followers","following_url":"https://api.github.com/users/kwin/following{/other_user}","gists_url":"https://api.github.com/users/kwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwin/subscriptions","organizations_url":"https://api.github.com/users/kwin/orgs","repos_url":"https://api.github.com/users/kwin/repos","events_url":"https://api.github.com/users/kwin/events{/privacy}","received_events_url":"https://api.github.com/users/kwin/received_events","type":"User","site_admin":false},"repo":{"id":38263595,"name":"bnd","full_name":"kwin/bnd","owner":{"login":"kwin","id":185025,"avatar_url":"https://avatars2.githubusercontent.com/u/185025?v=4","gravatar_id":"","url":"https://api.github.com/users/kwin","html_url":"https://github.com/kwin","followers_url":"https://api.github.com/users/kwin/followers","following_url":"https://api.github.com/users/kwin/following{/other_user}","gists_url":"https://api.github.com/users/kwin/gists{/gist_id}","starred_url":"https://api.github.com/users/kwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwin/subscriptions","organizations_url":"https://api.github.com/users/kwin/orgs","repos_url":"https://api.github.com/users/kwin/repos","events_url":"https://api.github.com/users/kwin/events{/privacy}","received_events_url":"https://api.github.com/users/kwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwin/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build bundles.","fork":true,"url":"https://api.github.com/repos/kwin/bnd","forks_url":"https://api.github.com/repos/kwin/bnd/forks","keys_url":"https://api.github.com/repos/kwin/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwin/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwin/bnd/teams","hooks_url":"https://api.github.com/repos/kwin/bnd/hooks","issue_events_url":"https://api.github.com/repos/kwin/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/kwin/bnd/events","assignees_url":"https://api.github.com/repos/kwin/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/kwin/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/kwin/bnd/tags","blobs_url":"https://api.github.com/repos/kwin/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwin/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwin/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwin/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwin/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/kwin/bnd/languages","stargazers_url":"https://api.github.com/repos/kwin/bnd/stargazers","contributors_url":"https://api.github.com/repos/kwin/bnd/contributors","subscribers_url":"https://api.github.com/repos/kwin/bnd/subscribers","subscription_url":"https://api.github.com/repos/kwin/bnd/subscription","commits_url":"https://api.github.com/repos/kwin/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwin/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwin/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwin/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwin/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/kwin/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwin/bnd/merges","archive_url":"https://api.github.com/repos/kwin/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwin/bnd/downloads","issues_url":"https://api.github.com/repos/kwin/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/kwin/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/kwin/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/kwin/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwin/bnd/labels{/name}","releases_url":"https://api.github.com/repos/kwin/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/kwin/bnd/deployments","created_at":"2015-06-29T18:26:40Z","updated_at":"2016-01-25T11:44:53Z","pushed_at":"2018-01-26T21:09:58Z","git_url":"git://github.com/kwin/bnd.git","ssh_url":"git@github.com:kwin/bnd.git","clone_url":"https://github.com/kwin/bnd.git","svn_url":"https://github.com/kwin/bnd","homepage":"http://www.aQute.biz/Bnd","size":296797,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bndtools:master","ref":"master","sha":"edaa8ef05485f8502eccc444643d424dec9d6e79","user":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"repo":{"id":606956,"name":"bnd","full_name":"bndtools/bnd","owner":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bndtools/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build OSGi bundles.","fork":false,"url":"https://api.github.com/repos/bndtools/bnd","forks_url":"https://api.github.com/repos/bndtools/bnd/forks","keys_url":"https://api.github.com/repos/bndtools/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bndtools/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bndtools/bnd/teams","hooks_url":"https://api.github.com/repos/bndtools/bnd/hooks","issue_events_url":"https://api.github.com/repos/bndtools/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/bndtools/bnd/events","assignees_url":"https://api.github.com/repos/bndtools/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/bndtools/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/bndtools/bnd/tags","blobs_url":"https://api.github.com/repos/bndtools/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bndtools/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bndtools/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bndtools/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/bndtools/bnd/languages","stargazers_url":"https://api.github.com/repos/bndtools/bnd/stargazers","contributors_url":"https://api.github.com/repos/bndtools/bnd/contributors","subscribers_url":"https://api.github.com/repos/bndtools/bnd/subscribers","subscription_url":"https://api.github.com/repos/bndtools/bnd/subscription","commits_url":"https://api.github.com/repos/bndtools/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bndtools/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bndtools/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bndtools/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bndtools/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/bndtools/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bndtools/bnd/merges","archive_url":"https://api.github.com/repos/bndtools/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bndtools/bnd/downloads","issues_url":"https://api.github.com/repos/bndtools/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/bndtools/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/bndtools/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/bndtools/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bndtools/bnd/labels{/name}","releases_url":"https://api.github.com/repos/bndtools/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/bndtools/bnd/deployments","created_at":"2010-04-12T17:30:15Z","updated_at":"2018-04-03T18:38:15Z","pushed_at":"2018-04-02T16:48:38Z","git_url":"git://github.com/bndtools/bnd.git","ssh_url":"git@github.com:bndtools/bnd.git","clone_url":"https://github.com/bndtools/bnd.git","svn_url":"https://github.com/bndtools/bnd","homepage":"http://bnd.bndtools.org","size":300473,"stargazers_count":302,"watchers_count":302,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":198,"open_issues":68,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2272"},"html":{"href":"https://github.com/bndtools/bnd/pull/2272"},"issue":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2272"},"comments":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2272/comments"},"review_comments":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2272/comments"},"review_comment":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2272/commits"},"statuses":{"href":"https://api.github.com/repos/bndtools/bnd/statuses/157785f4a78ae154abd98547984b9880e4bc75a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kwin"}}