{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/12","id":181332450,"html_url":"https://github.com/croaky/recipient_interceptor/pull/12","diff_url":"https://github.com/croaky/recipient_interceptor/pull/12.diff","patch_url":"https://github.com/croaky/recipient_interceptor/pull/12.patch","issue_url":"https://api.github.com/repos/croaky/recipient_interceptor/issues/12","number":12,"state":"closed","locked":false,"title":"Setting cc and bcc fields to nil instead of []","user":{"login":"uri","id":676443,"avatar_url":"https://avatars3.githubusercontent.com/u/676443?v=4","gravatar_id":"","url":"https://api.github.com/users/uri","html_url":"https://github.com/uri","followers_url":"https://api.github.com/users/uri/followers","following_url":"https://api.github.com/users/uri/following{/other_user}","gists_url":"https://api.github.com/users/uri/gists{/gist_id}","starred_url":"https://api.github.com/users/uri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uri/subscriptions","organizations_url":"https://api.github.com/users/uri/orgs","repos_url":"https://api.github.com/users/uri/repos","events_url":"https://api.github.com/users/uri/events{/privacy}","received_events_url":"https://api.github.com/users/uri/received_events","type":"User","site_admin":false},"body":"This was causing a problem with a certain ActionMailer proivder\r\n(Mailgun/Railgun).\r\n\r\nThis should also be the more canonical approach to unsetting these\r\nfields as by default they are `nil`.\r\n\r\nSetting the Mail::Message's header differently was also require. The\r\nprevious approach would encode the message's headers to a string and\r\nthen append another encoded string to create the new headers. However,\r\nthe Bcc field is not encoded by default (see Mail::BccField#encoded @ 2.7.0).\r\n\r\nSince the Bcc field is not present in the encoded version of the\r\nheaders, it is effectively deleted and set to []. Due to how setting\r\nheaders works in Mail, `message.bcc = nil` will not actually work.\r\n\r\nBy using Mail::Header[]= instead of Mail::Header= we do not nuke the Bcc\r\nfield and can properly use `message.bcc = nil` to remove it.","created_at":"2018-04-12T21:36:40Z","updated_at":"2018-04-13T15:18:14Z","closed_at":"2018-04-13T15:18:14Z","merged_at":null,"merge_commit_sha":"e2db08d1ae3559ce8b9693da14c210b27c544f92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/12/commits","review_comments_url":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/12/comments","review_comment_url":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/croaky/recipient_interceptor/issues/12/comments","statuses_url":"https://api.github.com/repos/croaky/recipient_interceptor/statuses/c5228e7cdf7fd3ab7c8c2d41f75e7bb311fddc98","head":{"label":"uri:mailgun-fix","ref":"mailgun-fix","sha":"c5228e7cdf7fd3ab7c8c2d41f75e7bb311fddc98","user":{"login":"uri","id":676443,"avatar_url":"https://avatars3.githubusercontent.com/u/676443?v=4","gravatar_id":"","url":"https://api.github.com/users/uri","html_url":"https://github.com/uri","followers_url":"https://api.github.com/users/uri/followers","following_url":"https://api.github.com/users/uri/following{/other_user}","gists_url":"https://api.github.com/users/uri/gists{/gist_id}","starred_url":"https://api.github.com/users/uri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uri/subscriptions","organizations_url":"https://api.github.com/users/uri/orgs","repos_url":"https://api.github.com/users/uri/repos","events_url":"https://api.github.com/users/uri/events{/privacy}","received_events_url":"https://api.github.com/users/uri/received_events","type":"User","site_admin":false},"repo":{"id":129303744,"name":"recipient_interceptor","full_name":"uri/recipient_interceptor","owner":{"login":"uri","id":676443,"avatar_url":"https://avatars3.githubusercontent.com/u/676443?v=4","gravatar_id":"","url":"https://api.github.com/users/uri","html_url":"https://github.com/uri","followers_url":"https://api.github.com/users/uri/followers","following_url":"https://api.github.com/users/uri/following{/other_user}","gists_url":"https://api.github.com/users/uri/gists{/gist_id}","starred_url":"https://api.github.com/users/uri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uri/subscriptions","organizations_url":"https://api.github.com/users/uri/orgs","repos_url":"https://api.github.com/users/uri/repos","events_url":"https://api.github.com/users/uri/events{/privacy}","received_events_url":"https://api.github.com/users/uri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uri/recipient_interceptor","description":"Intercept recipients when delivering email with the Mail gem.","fork":true,"url":"https://api.github.com/repos/uri/recipient_interceptor","forks_url":"https://api.github.com/repos/uri/recipient_interceptor/forks","keys_url":"https://api.github.com/repos/uri/recipient_interceptor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uri/recipient_interceptor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uri/recipient_interceptor/teams","hooks_url":"https://api.github.com/repos/uri/recipient_interceptor/hooks","issue_events_url":"https://api.github.com/repos/uri/recipient_interceptor/issues/events{/number}","events_url":"https://api.github.com/repos/uri/recipient_interceptor/events","assignees_url":"https://api.github.com/repos/uri/recipient_interceptor/assignees{/user}","branches_url":"https://api.github.com/repos/uri/recipient_interceptor/branches{/branch}","tags_url":"https://api.github.com/repos/uri/recipient_interceptor/tags","blobs_url":"https://api.github.com/repos/uri/recipient_interceptor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uri/recipient_interceptor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uri/recipient_interceptor/git/refs{/sha}","trees_url":"https://api.github.com/repos/uri/recipient_interceptor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uri/recipient_interceptor/statuses/{sha}","languages_url":"https://api.github.com/repos/uri/recipient_interceptor/languages","stargazers_url":"https://api.github.com/repos/uri/recipient_interceptor/stargazers","contributors_url":"https://api.github.com/repos/uri/recipient_interceptor/contributors","subscribers_url":"https://api.github.com/repos/uri/recipient_interceptor/subscribers","subscription_url":"https://api.github.com/repos/uri/recipient_interceptor/subscription","commits_url":"https://api.github.com/repos/uri/recipient_interceptor/commits{/sha}","git_commits_url":"https://api.github.com/repos/uri/recipient_interceptor/git/commits{/sha}","comments_url":"https://api.github.com/repos/uri/recipient_interceptor/comments{/number}","issue_comment_url":"https://api.github.com/repos/uri/recipient_interceptor/issues/comments{/number}","contents_url":"https://api.github.com/repos/uri/recipient_interceptor/contents/{+path}","compare_url":"https://api.github.com/repos/uri/recipient_interceptor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uri/recipient_interceptor/merges","archive_url":"https://api.github.com/repos/uri/recipient_interceptor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uri/recipient_interceptor/downloads","issues_url":"https://api.github.com/repos/uri/recipient_interceptor/issues{/number}","pulls_url":"https://api.github.com/repos/uri/recipient_interceptor/pulls{/number}","milestones_url":"https://api.github.com/repos/uri/recipient_interceptor/milestones{/number}","notifications_url":"https://api.github.com/repos/uri/recipient_interceptor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uri/recipient_interceptor/labels{/name}","releases_url":"https://api.github.com/repos/uri/recipient_interceptor/releases{/id}","deployments_url":"https://api.github.com/repos/uri/recipient_interceptor/deployments","created_at":"2018-04-12T19:50:01Z","updated_at":"2018-04-12T19:50:03Z","pushed_at":"2018-04-13T13:52:50Z","git_url":"git://github.com/uri/recipient_interceptor.git","ssh_url":"git@github.com:uri/recipient_interceptor.git","clone_url":"https://github.com/uri/recipient_interceptor.git","svn_url":"https://github.com/uri/recipient_interceptor","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"croaky:master","ref":"master","sha":"953feec027d8c5933a477a5a0f820d3697652112","user":{"login":"croaky","id":198,"avatar_url":"https://avatars1.githubusercontent.com/u/198?v=4","gravatar_id":"","url":"https://api.github.com/users/croaky","html_url":"https://github.com/croaky","followers_url":"https://api.github.com/users/croaky/followers","following_url":"https://api.github.com/users/croaky/following{/other_user}","gists_url":"https://api.github.com/users/croaky/gists{/gist_id}","starred_url":"https://api.github.com/users/croaky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croaky/subscriptions","organizations_url":"https://api.github.com/users/croaky/orgs","repos_url":"https://api.github.com/users/croaky/repos","events_url":"https://api.github.com/users/croaky/events{/privacy}","received_events_url":"https://api.github.com/users/croaky/received_events","type":"User","site_admin":false},"repo":{"id":8398963,"name":"recipient_interceptor","full_name":"croaky/recipient_interceptor","owner":{"login":"croaky","id":198,"avatar_url":"https://avatars1.githubusercontent.com/u/198?v=4","gravatar_id":"","url":"https://api.github.com/users/croaky","html_url":"https://github.com/croaky","followers_url":"https://api.github.com/users/croaky/followers","following_url":"https://api.github.com/users/croaky/following{/other_user}","gists_url":"https://api.github.com/users/croaky/gists{/gist_id}","starred_url":"https://api.github.com/users/croaky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croaky/subscriptions","organizations_url":"https://api.github.com/users/croaky/orgs","repos_url":"https://api.github.com/users/croaky/repos","events_url":"https://api.github.com/users/croaky/events{/privacy}","received_events_url":"https://api.github.com/users/croaky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/croaky/recipient_interceptor","description":"Intercept recipients when delivering email with the Mail gem.","fork":false,"url":"https://api.github.com/repos/croaky/recipient_interceptor","forks_url":"https://api.github.com/repos/croaky/recipient_interceptor/forks","keys_url":"https://api.github.com/repos/croaky/recipient_interceptor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/croaky/recipient_interceptor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/croaky/recipient_interceptor/teams","hooks_url":"https://api.github.com/repos/croaky/recipient_interceptor/hooks","issue_events_url":"https://api.github.com/repos/croaky/recipient_interceptor/issues/events{/number}","events_url":"https://api.github.com/repos/croaky/recipient_interceptor/events","assignees_url":"https://api.github.com/repos/croaky/recipient_interceptor/assignees{/user}","branches_url":"https://api.github.com/repos/croaky/recipient_interceptor/branches{/branch}","tags_url":"https://api.github.com/repos/croaky/recipient_interceptor/tags","blobs_url":"https://api.github.com/repos/croaky/recipient_interceptor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/croaky/recipient_interceptor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/croaky/recipient_interceptor/git/refs{/sha}","trees_url":"https://api.github.com/repos/croaky/recipient_interceptor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/croaky/recipient_interceptor/statuses/{sha}","languages_url":"https://api.github.com/repos/croaky/recipient_interceptor/languages","stargazers_url":"https://api.github.com/repos/croaky/recipient_interceptor/stargazers","contributors_url":"https://api.github.com/repos/croaky/recipient_interceptor/contributors","subscribers_url":"https://api.github.com/repos/croaky/recipient_interceptor/subscribers","subscription_url":"https://api.github.com/repos/croaky/recipient_interceptor/subscription","commits_url":"https://api.github.com/repos/croaky/recipient_interceptor/commits{/sha}","git_commits_url":"https://api.github.com/repos/croaky/recipient_interceptor/git/commits{/sha}","comments_url":"https://api.github.com/repos/croaky/recipient_interceptor/comments{/number}","issue_comment_url":"https://api.github.com/repos/croaky/recipient_interceptor/issues/comments{/number}","contents_url":"https://api.github.com/repos/croaky/recipient_interceptor/contents/{+path}","compare_url":"https://api.github.com/repos/croaky/recipient_interceptor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/croaky/recipient_interceptor/merges","archive_url":"https://api.github.com/repos/croaky/recipient_interceptor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/croaky/recipient_interceptor/downloads","issues_url":"https://api.github.com/repos/croaky/recipient_interceptor/issues{/number}","pulls_url":"https://api.github.com/repos/croaky/recipient_interceptor/pulls{/number}","milestones_url":"https://api.github.com/repos/croaky/recipient_interceptor/milestones{/number}","notifications_url":"https://api.github.com/repos/croaky/recipient_interceptor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/croaky/recipient_interceptor/labels{/name}","releases_url":"https://api.github.com/repos/croaky/recipient_interceptor/releases{/id}","deployments_url":"https://api.github.com/repos/croaky/recipient_interceptor/deployments","created_at":"2013-02-24T23:53:55Z","updated_at":"2018-03-28T16:08:41Z","pushed_at":"2018-04-12T21:36:41Z","git_url":"git://github.com/croaky/recipient_interceptor.git","ssh_url":"git@github.com:croaky/recipient_interceptor.git","clone_url":"https://github.com/croaky/recipient_interceptor.git","svn_url":"https://github.com/croaky/recipient_interceptor","homepage":null,"size":13,"stargazers_count":184,"watchers_count":184,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":18,"open_issues":3,"watchers":184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/12"},"html":{"href":"https://github.com/croaky/recipient_interceptor/pull/12"},"issue":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/issues/12"},"comments":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/croaky/recipient_interceptor/statuses/c5228e7cdf7fd3ab7c8c2d41f75e7bb311fddc98"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"uri"}}