{"action":"created","comment":{"url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/comments/234249935","pull_request_review_id":175857580,"id":234249935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDI0OTkzNQ==","diff_hunk":"@@ -18,15 +18,24 @@ struct CreativeParameterAttributes {\n     static let type = \"type\"\n }\n \n-public struct VastCreativeParameter {\n-    public var creativeId: String\n-    public var name: String\n-    public var type: String // TODO: enum\n-    public var content: String?\n+@objc public class VastCreativeParameter: NSObject {","path":"VastClient/VastClient/models/VastCreativeParameter.swift","position":9,"original_position":9,"commit_id":"3cae51bd31a7041addc14554bfc9fdbce9acdb60","original_commit_id":"3cae51bd31a7041addc14554bfc9fdbce9acdb60","user":{"login":"jgainfort","id":8740959,"node_id":"MDQ6VXNlcjg3NDA5NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8740959?v=4","gravatar_id":"","url":"https://api.github.com/users/jgainfort","html_url":"https://github.com/jgainfort","followers_url":"https://api.github.com/users/jgainfort/followers","following_url":"https://api.github.com/users/jgainfort/following{/other_user}","gists_url":"https://api.github.com/users/jgainfort/gists{/gist_id}","starred_url":"https://api.github.com/users/jgainfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgainfort/subscriptions","organizations_url":"https://api.github.com/users/jgainfort/orgs","repos_url":"https://api.github.com/users/jgainfort/repos","events_url":"https://api.github.com/users/jgainfort/events{/privacy}","received_events_url":"https://api.github.com/users/jgainfort/received_events","type":"User","site_admin":false},"body":"I don't want to do this in this library, I want to keep everything as structs.","created_at":"2018-11-16T15:42:45Z","updated_at":"2018-11-16T15:42:46Z","html_url":"https://github.com/realeyes-media/ios-vast-client/pull/5#discussion_r234249935","pull_request_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/comments/234249935"},"html":{"href":"https://github.com/realeyes-media/ios-vast-client/pull/5#discussion_r234249935"},"pull_request":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5","id":231545300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTQ1MzAw","html_url":"https://github.com/realeyes-media/ios-vast-client/pull/5","diff_url":"https://github.com/realeyes-media/ios-vast-client/pull/5.diff","patch_url":"https://github.com/realeyes-media/ios-vast-client/pull/5.patch","issue_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/5","number":5,"state":"open","locked":false,"title":"NIC 407","user":{"login":"benashby","id":1023089,"node_id":"MDQ6VXNlcjEwMjMwODk=","avatar_url":"https://avatars2.githubusercontent.com/u/1023089?v=4","gravatar_id":"","url":"https://api.github.com/users/benashby","html_url":"https://github.com/benashby","followers_url":"https://api.github.com/users/benashby/followers","following_url":"https://api.github.com/users/benashby/following{/other_user}","gists_url":"https://api.github.com/users/benashby/gists{/gist_id}","starred_url":"https://api.github.com/users/benashby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benashby/subscriptions","organizations_url":"https://api.github.com/users/benashby/orgs","repos_url":"https://api.github.com/users/benashby/repos","events_url":"https://api.github.com/users/benashby/events{/privacy}","received_events_url":"https://api.github.com/users/benashby/received_events","type":"User","site_admin":false},"body":"NIC-407\r\n\r\nexposes creativeParameters in the VastAd","created_at":"2018-11-16T14:21:46Z","updated_at":"2018-11-16T15:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8830fae8be4b7b013c4a903acc379b2aea14fb2e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5/commits","review_comments_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5/comments","review_comment_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/5/comments","statuses_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/statuses/3cae51bd31a7041addc14554bfc9fdbce9acdb60","head":{"label":"realeyes-media:NIC-407","ref":"NIC-407","sha":"3cae51bd31a7041addc14554bfc9fdbce9acdb60","user":{"login":"realeyes-media","id":1156486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTY0ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1156486?v=4","gravatar_id":"","url":"https://api.github.com/users/realeyes-media","html_url":"https://github.com/realeyes-media","followers_url":"https://api.github.com/users/realeyes-media/followers","following_url":"https://api.github.com/users/realeyes-media/following{/other_user}","gists_url":"https://api.github.com/users/realeyes-media/gists{/gist_id}","starred_url":"https://api.github.com/users/realeyes-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realeyes-media/subscriptions","organizations_url":"https://api.github.com/users/realeyes-media/orgs","repos_url":"https://api.github.com/users/realeyes-media/repos","events_url":"https://api.github.com/users/realeyes-media/events{/privacy}","received_events_url":"https://api.github.com/users/realeyes-media/received_events","type":"Organization","site_admin":false},"repo":{"id":128412655,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MTI2NTU=","name":"ios-vast-client","full_name":"realeyes-media/ios-vast-client","private":false,"owner":{"login":"realeyes-media","id":1156486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTY0ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1156486?v=4","gravatar_id":"","url":"https://api.github.com/users/realeyes-media","html_url":"https://github.com/realeyes-media","followers_url":"https://api.github.com/users/realeyes-media/followers","following_url":"https://api.github.com/users/realeyes-media/following{/other_user}","gists_url":"https://api.github.com/users/realeyes-media/gists{/gist_id}","starred_url":"https://api.github.com/users/realeyes-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realeyes-media/subscriptions","organizations_url":"https://api.github.com/users/realeyes-media/orgs","repos_url":"https://api.github.com/users/realeyes-media/repos","events_url":"https://api.github.com/users/realeyes-media/events{/privacy}","received_events_url":"https://api.github.com/users/realeyes-media/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/realeyes-media/ios-vast-client","description":null,"fork":false,"url":"https://api.github.com/repos/realeyes-media/ios-vast-client","forks_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/forks","keys_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/teams","hooks_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/hooks","issue_events_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/events{/number}","events_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/events","assignees_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/assignees{/user}","branches_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/branches{/branch}","tags_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/tags","blobs_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/statuses/{sha}","languages_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/languages","stargazers_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/stargazers","contributors_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/contributors","subscribers_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/subscribers","subscription_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/subscription","commits_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/contents/{+path}","compare_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/merges","archive_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/downloads","issues_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues{/number}","pulls_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls{/number}","milestones_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/milestones{/number}","notifications_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/labels{/name}","releases_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/releases{/id}","deployments_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/deployments","created_at":"2018-04-06T15:27:51Z","updated_at":"2018-11-15T21:32:17Z","pushed_at":"2018-11-16T14:21:47Z","git_url":"git://github.com/realeyes-media/ios-vast-client.git","ssh_url":"git@github.com:realeyes-media/ios-vast-client.git","clone_url":"https://github.com/realeyes-media/ios-vast-client.git","svn_url":"https://github.com/realeyes-media/ios-vast-client","homepage":null,"size":79,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"realeyes-media:master","ref":"master","sha":"2cadafb34c917e9ed763aa375ed310f74c437d1b","user":{"login":"realeyes-media","id":1156486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTY0ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1156486?v=4","gravatar_id":"","url":"https://api.github.com/users/realeyes-media","html_url":"https://github.com/realeyes-media","followers_url":"https://api.github.com/users/realeyes-media/followers","following_url":"https://api.github.com/users/realeyes-media/following{/other_user}","gists_url":"https://api.github.com/users/realeyes-media/gists{/gist_id}","starred_url":"https://api.github.com/users/realeyes-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realeyes-media/subscriptions","organizations_url":"https://api.github.com/users/realeyes-media/orgs","repos_url":"https://api.github.com/users/realeyes-media/repos","events_url":"https://api.github.com/users/realeyes-media/events{/privacy}","received_events_url":"https://api.github.com/users/realeyes-media/received_events","type":"Organization","site_admin":false},"repo":{"id":128412655,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg0MTI2NTU=","name":"ios-vast-client","full_name":"realeyes-media/ios-vast-client","private":false,"owner":{"login":"realeyes-media","id":1156486,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTY0ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/1156486?v=4","gravatar_id":"","url":"https://api.github.com/users/realeyes-media","html_url":"https://github.com/realeyes-media","followers_url":"https://api.github.com/users/realeyes-media/followers","following_url":"https://api.github.com/users/realeyes-media/following{/other_user}","gists_url":"https://api.github.com/users/realeyes-media/gists{/gist_id}","starred_url":"https://api.github.com/users/realeyes-media/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realeyes-media/subscriptions","organizations_url":"https://api.github.com/users/realeyes-media/orgs","repos_url":"https://api.github.com/users/realeyes-media/repos","events_url":"https://api.github.com/users/realeyes-media/events{/privacy}","received_events_url":"https://api.github.com/users/realeyes-media/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/realeyes-media/ios-vast-client","description":null,"fork":false,"url":"https://api.github.com/repos/realeyes-media/ios-vast-client","forks_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/forks","keys_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/teams","hooks_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/hooks","issue_events_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/events{/number}","events_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/events","assignees_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/assignees{/user}","branches_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/branches{/branch}","tags_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/tags","blobs_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/statuses/{sha}","languages_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/languages","stargazers_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/stargazers","contributors_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/contributors","subscribers_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/subscribers","subscription_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/subscription","commits_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/contents/{+path}","compare_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/merges","archive_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/downloads","issues_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues{/number}","pulls_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls{/number}","milestones_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/milestones{/number}","notifications_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/labels{/name}","releases_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/releases{/id}","deployments_url":"https://api.github.com/repos/realeyes-media/ios-vast-client/deployments","created_at":"2018-04-06T15:27:51Z","updated_at":"2018-11-15T21:32:17Z","pushed_at":"2018-11-16T14:21:47Z","git_url":"git://github.com/realeyes-media/ios-vast-client.git","ssh_url":"git@github.com:realeyes-media/ios-vast-client.git","clone_url":"https://github.com/realeyes-media/ios-vast-client.git","svn_url":"https://github.com/realeyes-media/ios-vast-client","homepage":null,"size":79,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5"},"html":{"href":"https://github.com/realeyes-media/ios-vast-client/pull/5"},"issue":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/5"},"comments":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/realeyes-media/ios-vast-client/statuses/3cae51bd31a7041addc14554bfc9fdbce9acdb60"}},"author_association":"NONE"}}
{"actor":{"display_login":"jgainfort"}}