{"action":"closed","number":21528,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/21528","id":182793606,"html_url":"https://github.com/ceph/ceph/pull/21528","diff_url":"https://github.com/ceph/ceph/pull/21528.diff","patch_url":"https://github.com/ceph/ceph/pull/21528.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/21528","number":21528,"state":"closed","locked":false,"title":"rbd: fix snapshot unprotect hang","user":{"login":"dragonylffly","id":4452507,"avatar_url":"https://avatars2.githubusercontent.com/u/4452507?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonylffly","html_url":"https://github.com/dragonylffly","followers_url":"https://api.github.com/users/dragonylffly/followers","following_url":"https://api.github.com/users/dragonylffly/following{/other_user}","gists_url":"https://api.github.com/users/dragonylffly/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonylffly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonylffly/subscriptions","organizations_url":"https://api.github.com/users/dragonylffly/orgs","repos_url":"https://api.github.com/users/dragonylffly/repos","events_url":"https://api.github.com/users/dragonylffly/events{/privacy}","received_events_url":"https://api.github.com/users/dragonylffly/received_events","type":"User","site_admin":false},"body":"Currently, when do snapshot unprotect, it will query all the other pools to check if there are some clones dependent on this snapshot. If for some reason, for example, pg inactive, the rbd_children object in some pool could not be accessed, the unprotect operation will hang. That is not elegant, since the snapshot could not be unprotected, and as a result, the volume could not be deleted, even the snapshot is independent on the inaccessible pool. This patch adds an option to allow skip querying other pools when unprotecting snapshot","created_at":"2018-04-19T14:24:17Z","updated_at":"2018-04-24T07:45:51Z","closed_at":"2018-04-24T07:45:51Z","merged_at":null,"merge_commit_sha":"a8c2928b4117b093464b310d02c6d20e51e53fe1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":134774049,"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329703,"url":"https://api.github.com/repos/ceph/ceph/labels/rbd","name":"rbd","color":"40bfb2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/21528/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/21528/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/21528/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/ea4752cfde9f8d22f70e56015e355d1ad234c92a","head":{"label":"dragonylffly:wip-rbd-fix-snapshot-unprotect-hang","ref":"wip-rbd-fix-snapshot-unprotect-hang","sha":"ea4752cfde9f8d22f70e56015e355d1ad234c92a","user":{"login":"dragonylffly","id":4452507,"avatar_url":"https://avatars2.githubusercontent.com/u/4452507?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonylffly","html_url":"https://github.com/dragonylffly","followers_url":"https://api.github.com/users/dragonylffly/followers","following_url":"https://api.github.com/users/dragonylffly/following{/other_user}","gists_url":"https://api.github.com/users/dragonylffly/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonylffly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonylffly/subscriptions","organizations_url":"https://api.github.com/users/dragonylffly/orgs","repos_url":"https://api.github.com/users/dragonylffly/repos","events_url":"https://api.github.com/users/dragonylffly/events{/privacy}","received_events_url":"https://api.github.com/users/dragonylffly/received_events","type":"User","site_admin":false},"repo":{"id":14710443,"name":"ceph","full_name":"dragonylffly/ceph","owner":{"login":"dragonylffly","id":4452507,"avatar_url":"https://avatars2.githubusercontent.com/u/4452507?v=4","gravatar_id":"","url":"https://api.github.com/users/dragonylffly","html_url":"https://github.com/dragonylffly","followers_url":"https://api.github.com/users/dragonylffly/followers","following_url":"https://api.github.com/users/dragonylffly/following{/other_user}","gists_url":"https://api.github.com/users/dragonylffly/gists{/gist_id}","starred_url":"https://api.github.com/users/dragonylffly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragonylffly/subscriptions","organizations_url":"https://api.github.com/users/dragonylffly/orgs","repos_url":"https://api.github.com/users/dragonylffly/repos","events_url":"https://api.github.com/users/dragonylffly/events{/privacy}","received_events_url":"https://api.github.com/users/dragonylffly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dragonylffly/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/dragonylffly/ceph","forks_url":"https://api.github.com/repos/dragonylffly/ceph/forks","keys_url":"https://api.github.com/repos/dragonylffly/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragonylffly/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragonylffly/ceph/teams","hooks_url":"https://api.github.com/repos/dragonylffly/ceph/hooks","issue_events_url":"https://api.github.com/repos/dragonylffly/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/dragonylffly/ceph/events","assignees_url":"https://api.github.com/repos/dragonylffly/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/dragonylffly/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/dragonylffly/ceph/tags","blobs_url":"https://api.github.com/repos/dragonylffly/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragonylffly/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragonylffly/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragonylffly/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragonylffly/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/dragonylffly/ceph/languages","stargazers_url":"https://api.github.com/repos/dragonylffly/ceph/stargazers","contributors_url":"https://api.github.com/repos/dragonylffly/ceph/contributors","subscribers_url":"https://api.github.com/repos/dragonylffly/ceph/subscribers","subscription_url":"https://api.github.com/repos/dragonylffly/ceph/subscription","commits_url":"https://api.github.com/repos/dragonylffly/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragonylffly/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragonylffly/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragonylffly/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragonylffly/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/dragonylffly/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragonylffly/ceph/merges","archive_url":"https://api.github.com/repos/dragonylffly/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragonylffly/ceph/downloads","issues_url":"https://api.github.com/repos/dragonylffly/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/dragonylffly/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/dragonylffly/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/dragonylffly/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragonylffly/ceph/labels{/name}","releases_url":"https://api.github.com/repos/dragonylffly/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/dragonylffly/ceph/deployments","created_at":"2013-11-26T07:58:18Z","updated_at":"2013-11-26T13:36:17Z","pushed_at":"2018-04-24T04:33:27Z","git_url":"git://github.com/dragonylffly/ceph.git","ssh_url":"git@github.com:dragonylffly/ceph.git","clone_url":"https://github.com/dragonylffly/ceph.git","svn_url":"https://github.com/dragonylffly/ceph","homepage":"http://ceph.com","size":250962,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"47a55cf52e806da8095f2f593aad4ac84d9a7c15","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-04-24T04:46:43Z","pushed_at":"2018-04-24T06:57:15Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":280331,"stargazers_count":4388,"watchers_count":4388,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2407,"mirror_url":null,"archived":false,"open_issues_count":643,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2407,"open_issues":643,"watchers":4388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21528"},"html":{"href":"https://github.com/ceph/ceph/pull/21528"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/21528"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/21528/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21528/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/21528/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/ea4752cfde9f8d22f70e56015e355d1ad234c92a"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":50,"deletions":29,"changed_files":13}}
{"actor":{"display_login":"dragonylffly"}}