{"action":"created","comment":{"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments/179579824","pull_request_review_id":109851302,"id":179579824,"diff_hunk":"@@ -947,4 +947,8 @@ def self.new(\n     end\n   end\n \n+  specify 'read returns enumerator' do\n+    specification = RubyEventStore::Specification.new(repository)\n+    expect(repository.read(specification.result)).to be_kind_of(Enumerator)","path":"ruby_event_store/lib/ruby_event_store/spec/event_repository_lint.rb","position":6,"original_position":6,"commit_id":"284f5a1d34962ec1dce5b8241f2c7fc5cfa901eb","original_commit_id":"64112fe1f52beddee6268d3171b33177b2b026e4","user":{"login":"paneq","id":65587,"avatar_url":"https://avatars2.githubusercontent.com/u/65587?v=4","gravatar_id":"","url":"https://api.github.com/users/paneq","html_url":"https://github.com/paneq","followers_url":"https://api.github.com/users/paneq/followers","following_url":"https://api.github.com/users/paneq/following{/other_user}","gists_url":"https://api.github.com/users/paneq/gists{/gist_id}","starred_url":"https://api.github.com/users/paneq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paneq/subscriptions","organizations_url":"https://api.github.com/users/paneq/orgs","repos_url":"https://api.github.com/users/paneq/repos","events_url":"https://api.github.com/users/paneq/events{/privacy}","received_events_url":"https://api.github.com/users/paneq/received_events","type":"User","site_admin":false},"body":"Seprate topic: Should we include Enumerable to Specification?","created_at":"2018-04-05T19:44:06Z","updated_at":"2018-04-05T19:44:06Z","html_url":"https://github.com/RailsEventStore/rails_event_store/pull/258#discussion_r179579824","pull_request_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments/179579824"},"html":{"href":"https://github.com/RailsEventStore/rails_event_store/pull/258#discussion_r179579824"},"pull_request":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258"}},"in_reply_to_id":179527825},"pull_request":{"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258","id":178671915,"html_url":"https://github.com/RailsEventStore/rails_event_store/pull/258","diff_url":"https://github.com/RailsEventStore/rails_event_store/pull/258.diff","patch_url":"https://github.com/RailsEventStore/rails_event_store/pull/258.patch","issue_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/258","number":258,"state":"open","locked":false,"title":"Fluent read API","user":{"login":"pawelpacana","id":116740,"avatar_url":"https://avatars1.githubusercontent.com/u/116740?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelpacana","html_url":"https://github.com/pawelpacana","followers_url":"https://api.github.com/users/pawelpacana/followers","following_url":"https://api.github.com/users/pawelpacana/following{/other_user}","gists_url":"https://api.github.com/users/pawelpacana/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelpacana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelpacana/subscriptions","organizations_url":"https://api.github.com/users/pawelpacana/orgs","repos_url":"https://api.github.com/users/pawelpacana/repos","events_url":"https://api.github.com/users/pawelpacana/events{/privacy}","received_events_url":"https://api.github.com/users/pawelpacana/received_events","type":"User","site_admin":false},"body":"Work-in-progress to have a collaborative checklist.\r\n\r\n# Phase 1\r\n\r\n- [x] event_repository using #read on facade methods\r\n- [x] legacy_event_repository using #read on facade methods\r\n- [x] extract #261 \r\n- [x] extract #262 \r\n- [x] extract #267  \r\n\r\n\r\n# Phase 2\r\n\r\n- [ ] `Client#read` public\r\n- [ ] rewrite old API usage in specs, would be lovely to have a migrator tool that can be then used by end-users to migrate codebases as well\r\n- [ ] deprecate old read methods on client, don't remove yet\r\n- [ ] document migration strategy from old to current reader API\r\n- [ ] what to do with `read_event`?\r\n- [ ] what to do with `get_all_streams` (related: #212)","created_at":"2018-03-31T08:04:19Z","updated_at":"2018-04-05T19:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"294ddb8b5a16ab0cb6a447f3015e94b8a9760227","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258/commits","review_comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258/comments","review_comment_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/258/comments","statuses_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/284f5a1d34962ec1dce5b8241f2c7fc5cfa901eb","head":{"label":"RailsEventStore:fluent-api","ref":"fluent-api","sha":"284f5a1d34962ec1dce5b8241f2c7fc5cfa901eb","user":{"login":"RailsEventStore","id":29432749,"avatar_url":"https://avatars1.githubusercontent.com/u/29432749?v=4","gravatar_id":"","url":"https://api.github.com/users/RailsEventStore","html_url":"https://github.com/RailsEventStore","followers_url":"https://api.github.com/users/RailsEventStore/followers","following_url":"https://api.github.com/users/RailsEventStore/following{/other_user}","gists_url":"https://api.github.com/users/RailsEventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/RailsEventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RailsEventStore/subscriptions","organizations_url":"https://api.github.com/users/RailsEventStore/orgs","repos_url":"https://api.github.com/users/RailsEventStore/repos","events_url":"https://api.github.com/users/RailsEventStore/events{/privacy}","received_events_url":"https://api.github.com/users/RailsEventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":33212527,"name":"rails_event_store","full_name":"RailsEventStore/rails_event_store","owner":{"login":"RailsEventStore","id":29432749,"avatar_url":"https://avatars1.githubusercontent.com/u/29432749?v=4","gravatar_id":"","url":"https://api.github.com/users/RailsEventStore","html_url":"https://github.com/RailsEventStore","followers_url":"https://api.github.com/users/RailsEventStore/followers","following_url":"https://api.github.com/users/RailsEventStore/following{/other_user}","gists_url":"https://api.github.com/users/RailsEventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/RailsEventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RailsEventStore/subscriptions","organizations_url":"https://api.github.com/users/RailsEventStore/orgs","repos_url":"https://api.github.com/users/RailsEventStore/repos","events_url":"https://api.github.com/users/RailsEventStore/events{/privacy}","received_events_url":"https://api.github.com/users/RailsEventStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RailsEventStore/rails_event_store","description":"A Ruby implementation of an Event Store based on Active Record.","fork":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store","forks_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/forks","keys_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/teams","hooks_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/hooks","issue_events_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/events{/number}","events_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/events","assignees_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/assignees{/user}","branches_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/branches{/branch}","tags_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/tags","blobs_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/{sha}","languages_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/languages","stargazers_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/stargazers","contributors_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/contributors","subscribers_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/subscribers","subscription_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/subscription","commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/contents/{+path}","compare_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/merges","archive_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/downloads","issues_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues{/number}","pulls_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls{/number}","milestones_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/milestones{/number}","notifications_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/labels{/name}","releases_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/releases{/id}","deployments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/deployments","created_at":"2015-03-31T22:02:32Z","updated_at":"2018-04-05T19:24:42Z","pushed_at":"2018-04-05T19:05:28Z","git_url":"git://github.com/RailsEventStore/rails_event_store.git","ssh_url":"git@github.com:RailsEventStore/rails_event_store.git","clone_url":"https://github.com/RailsEventStore/rails_event_store.git","svn_url":"https://github.com/RailsEventStore/rails_event_store","homepage":"http://railseventstore.org","size":2704,"stargazers_count":431,"watchers_count":431,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":38,"open_issues":70,"watchers":431,"default_branch":"master"}},"base":{"label":"RailsEventStore:master","ref":"master","sha":"bc33ddf097ede99438f71f625fbca62ba1b33a33","user":{"login":"RailsEventStore","id":29432749,"avatar_url":"https://avatars1.githubusercontent.com/u/29432749?v=4","gravatar_id":"","url":"https://api.github.com/users/RailsEventStore","html_url":"https://github.com/RailsEventStore","followers_url":"https://api.github.com/users/RailsEventStore/followers","following_url":"https://api.github.com/users/RailsEventStore/following{/other_user}","gists_url":"https://api.github.com/users/RailsEventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/RailsEventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RailsEventStore/subscriptions","organizations_url":"https://api.github.com/users/RailsEventStore/orgs","repos_url":"https://api.github.com/users/RailsEventStore/repos","events_url":"https://api.github.com/users/RailsEventStore/events{/privacy}","received_events_url":"https://api.github.com/users/RailsEventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":33212527,"name":"rails_event_store","full_name":"RailsEventStore/rails_event_store","owner":{"login":"RailsEventStore","id":29432749,"avatar_url":"https://avatars1.githubusercontent.com/u/29432749?v=4","gravatar_id":"","url":"https://api.github.com/users/RailsEventStore","html_url":"https://github.com/RailsEventStore","followers_url":"https://api.github.com/users/RailsEventStore/followers","following_url":"https://api.github.com/users/RailsEventStore/following{/other_user}","gists_url":"https://api.github.com/users/RailsEventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/RailsEventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RailsEventStore/subscriptions","organizations_url":"https://api.github.com/users/RailsEventStore/orgs","repos_url":"https://api.github.com/users/RailsEventStore/repos","events_url":"https://api.github.com/users/RailsEventStore/events{/privacy}","received_events_url":"https://api.github.com/users/RailsEventStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RailsEventStore/rails_event_store","description":"A Ruby implementation of an Event Store based on Active Record.","fork":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store","forks_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/forks","keys_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/teams","hooks_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/hooks","issue_events_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/events{/number}","events_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/events","assignees_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/assignees{/user}","branches_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/branches{/branch}","tags_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/tags","blobs_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/{sha}","languages_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/languages","stargazers_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/stargazers","contributors_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/contributors","subscribers_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/subscribers","subscription_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/subscription","commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/contents/{+path}","compare_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/merges","archive_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/downloads","issues_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues{/number}","pulls_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls{/number}","milestones_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/milestones{/number}","notifications_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/labels{/name}","releases_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/releases{/id}","deployments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/deployments","created_at":"2015-03-31T22:02:32Z","updated_at":"2018-04-05T19:24:42Z","pushed_at":"2018-04-05T19:05:28Z","git_url":"git://github.com/RailsEventStore/rails_event_store.git","ssh_url":"git@github.com:RailsEventStore/rails_event_store.git","clone_url":"https://github.com/RailsEventStore/rails_event_store.git","svn_url":"https://github.com/RailsEventStore/rails_event_store","homepage":"http://railseventstore.org","size":2704,"stargazers_count":431,"watchers_count":431,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":38,"open_issues":70,"watchers":431,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258"},"html":{"href":"https://github.com/RailsEventStore/rails_event_store/pull/258"},"issue":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/258"},"comments":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/284f5a1d34962ec1dce5b8241f2c7fc5cfa901eb"}},"author_association":"OWNER"}}
{"actor":{"display_login":"paneq"}}