{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/214470994","pull_request_review_id":151543345,"id":214470994,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ3MDk5NA==","diff_hunk":"@@ -45,7 +45,7 @@ The following table lists the configurable parameters of the Datadog chart and t\n | `image.tag`                 | The image tag to pull              | `6.3.2`                                   |\n | `image.pullPolicy`          | Image pull policy                  | `IfNotPresent`                            |\n | `rbac.create`               | If true, create & use RBAC resources | `true`                                  |\n-| `rbac.serviceAccount`       | existing ServiceAccount to use (ignored if rbac.create=true) | `default`       |\n+| `rbac.serviceAccountName`   | existing ServiceAccount to use (ignored if rbac.create=true) | `default`       |","path":"stable/datadog/README.md","position":5,"original_position":5,"commit_id":"70624d9c24b5d350ec48a723d59eb28091aeeb1a","original_commit_id":"70624d9c24b5d350ec48a723d59eb28091aeeb1a","user":{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},"body":"What I suggest is that everywhere where the service account is referenced the same template function from the helper should be used.","created_at":"2018-08-31T20:43:02Z","updated_at":"2018-08-31T20:43:02Z","html_url":"https://github.com/helm/charts/pull/7384#discussion_r214470994","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/7384","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/214470994"},"html":{"href":"https://github.com/helm/charts/pull/7384#discussion_r214470994"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/7384"}},"in_reply_to_id":213421564},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/7384","id":211292751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjkyNzUx","html_url":"https://github.com/helm/charts/pull/7384","diff_url":"https://github.com/helm/charts/pull/7384.diff","patch_url":"https://github.com/helm/charts/pull/7384.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/7384","number":7384,"state":"open","locked":false,"title":"Add proper `serviceAccountName` variables to the documentation","user":{"login":"timfallmk","id":5316117,"node_id":"MDQ6VXNlcjUzMTYxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5316117?v=4","gravatar_id":"","url":"https://api.github.com/users/timfallmk","html_url":"https://github.com/timfallmk","followers_url":"https://api.github.com/users/timfallmk/followers","following_url":"https://api.github.com/users/timfallmk/following{/other_user}","gists_url":"https://api.github.com/users/timfallmk/gists{/gist_id}","starred_url":"https://api.github.com/users/timfallmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timfallmk/subscriptions","organizations_url":"https://api.github.com/users/timfallmk/orgs","repos_url":"https://api.github.com/users/timfallmk/repos","events_url":"https://api.github.com/users/timfallmk/events{/privacy}","received_events_url":"https://api.github.com/users/timfallmk/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n`serviceAccount` is not the correct variable name.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #6254 \r\n\r\n**Special notes for your reviewer**:\r\n`serviceAccountName` is the variable used in both sections of `values.yaml`\r\n","created_at":"2018-08-28T03:43:44Z","updated_at":"2018-08-31T20:43:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a22c7578b904279c71db17d5c6df00fbe8385116","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hkaj","id":5287287,"node_id":"MDQ6VXNlcjUyODcyODc=","avatar_url":"https://avatars1.githubusercontent.com/u/5287287?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaj","html_url":"https://github.com/hkaj","followers_url":"https://api.github.com/users/hkaj/followers","following_url":"https://api.github.com/users/hkaj/following{/other_user}","gists_url":"https://api.github.com/users/hkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaj/subscriptions","organizations_url":"https://api.github.com/users/hkaj/orgs","repos_url":"https://api.github.com/users/hkaj/repos","events_url":"https://api.github.com/users/hkaj/events{/privacy}","received_events_url":"https://api.github.com/users/hkaj/received_events","type":"User","site_admin":false},{"login":"xvello","id":6241083,"node_id":"MDQ6VXNlcjYyNDEwODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6241083?v=4","gravatar_id":"","url":"https://api.github.com/users/xvello","html_url":"https://github.com/xvello","followers_url":"https://api.github.com/users/xvello/followers","following_url":"https://api.github.com/users/xvello/following{/other_user}","gists_url":"https://api.github.com/users/xvello/gists{/gist_id}","starred_url":"https://api.github.com/users/xvello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xvello/subscriptions","organizations_url":"https://api.github.com/users/xvello/orgs","repos_url":"https://api.github.com/users/xvello/repos","events_url":"https://api.github.com/users/xvello/events{/privacy}","received_events_url":"https://api.github.com/users/xvello/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/7384/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/7384/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/7384/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/70624d9c24b5d350ec48a723d59eb28091aeeb1a","head":{"label":"timfallmk:patch-1","ref":"patch-1","sha":"70624d9c24b5d350ec48a723d59eb28091aeeb1a","user":{"login":"timfallmk","id":5316117,"node_id":"MDQ6VXNlcjUzMTYxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5316117?v=4","gravatar_id":"","url":"https://api.github.com/users/timfallmk","html_url":"https://github.com/timfallmk","followers_url":"https://api.github.com/users/timfallmk/followers","following_url":"https://api.github.com/users/timfallmk/following{/other_user}","gists_url":"https://api.github.com/users/timfallmk/gists{/gist_id}","starred_url":"https://api.github.com/users/timfallmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timfallmk/subscriptions","organizations_url":"https://api.github.com/users/timfallmk/orgs","repos_url":"https://api.github.com/users/timfallmk/repos","events_url":"https://api.github.com/users/timfallmk/events{/privacy}","received_events_url":"https://api.github.com/users/timfallmk/received_events","type":"User","site_admin":false},"repo":{"id":146388120,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzODgxMjA=","name":"charts","full_name":"timfallmk/charts","owner":{"login":"timfallmk","id":5316117,"node_id":"MDQ6VXNlcjUzMTYxMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5316117?v=4","gravatar_id":"","url":"https://api.github.com/users/timfallmk","html_url":"https://github.com/timfallmk","followers_url":"https://api.github.com/users/timfallmk/followers","following_url":"https://api.github.com/users/timfallmk/following{/other_user}","gists_url":"https://api.github.com/users/timfallmk/gists{/gist_id}","starred_url":"https://api.github.com/users/timfallmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timfallmk/subscriptions","organizations_url":"https://api.github.com/users/timfallmk/orgs","repos_url":"https://api.github.com/users/timfallmk/repos","events_url":"https://api.github.com/users/timfallmk/events{/privacy}","received_events_url":"https://api.github.com/users/timfallmk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timfallmk/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/timfallmk/charts","forks_url":"https://api.github.com/repos/timfallmk/charts/forks","keys_url":"https://api.github.com/repos/timfallmk/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timfallmk/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timfallmk/charts/teams","hooks_url":"https://api.github.com/repos/timfallmk/charts/hooks","issue_events_url":"https://api.github.com/repos/timfallmk/charts/issues/events{/number}","events_url":"https://api.github.com/repos/timfallmk/charts/events","assignees_url":"https://api.github.com/repos/timfallmk/charts/assignees{/user}","branches_url":"https://api.github.com/repos/timfallmk/charts/branches{/branch}","tags_url":"https://api.github.com/repos/timfallmk/charts/tags","blobs_url":"https://api.github.com/repos/timfallmk/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timfallmk/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timfallmk/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/timfallmk/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timfallmk/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/timfallmk/charts/languages","stargazers_url":"https://api.github.com/repos/timfallmk/charts/stargazers","contributors_url":"https://api.github.com/repos/timfallmk/charts/contributors","subscribers_url":"https://api.github.com/repos/timfallmk/charts/subscribers","subscription_url":"https://api.github.com/repos/timfallmk/charts/subscription","commits_url":"https://api.github.com/repos/timfallmk/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/timfallmk/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/timfallmk/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/timfallmk/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/timfallmk/charts/contents/{+path}","compare_url":"https://api.github.com/repos/timfallmk/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timfallmk/charts/merges","archive_url":"https://api.github.com/repos/timfallmk/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timfallmk/charts/downloads","issues_url":"https://api.github.com/repos/timfallmk/charts/issues{/number}","pulls_url":"https://api.github.com/repos/timfallmk/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/timfallmk/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/timfallmk/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timfallmk/charts/labels{/name}","releases_url":"https://api.github.com/repos/timfallmk/charts/releases{/id}","deployments_url":"https://api.github.com/repos/timfallmk/charts/deployments","created_at":"2018-08-28T03:40:21Z","updated_at":"2018-08-28T03:40:27Z","pushed_at":"2018-08-28T03:42:32Z","git_url":"git://github.com/timfallmk/charts.git","ssh_url":"git@github.com:timfallmk/charts.git","clone_url":"https://github.com/timfallmk/charts.git","svn_url":"https://github.com/timfallmk/charts","homepage":"","size":9901,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"b88bc5fdd7230b3ee2cbc7cf023b8f0a50f991e4","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-08-31T20:40:54Z","pushed_at":"2018-08-31T20:35:44Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":10088,"stargazers_count":4435,"watchers_count":4435,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3916,"mirror_url":null,"archived":false,"open_issues_count":843,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3916,"open_issues":843,"watchers":4435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/7384"},"html":{"href":"https://github.com/helm/charts/pull/7384"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/7384"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/7384/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/7384/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/7384/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/70624d9c24b5d350ec48a723d59eb28091aeeb1a"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidkarlsen"}}