{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/7559","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/7559/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/7559/comments","events_url":"https://api.github.com/repos/python/cpython/issues/7559/events","html_url":"https://github.com/python/cpython/pull/7559","id":330889625,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzc5MjEz","number":7559,"title":"bpo-31711: Fix for calling SSLSocket.send with empty input.","user":{"login":"rkondratenko","id":13419095,"node_id":"MDQ6VXNlcjEzNDE5MDk1","avatar_url":"https://avatars0.githubusercontent.com/u/13419095?v=4","gravatar_id":"","url":"https://api.github.com/users/rkondratenko","html_url":"https://github.com/rkondratenko","followers_url":"https://api.github.com/users/rkondratenko/followers","following_url":"https://api.github.com/users/rkondratenko/following{/other_user}","gists_url":"https://api.github.com/users/rkondratenko/gists{/gist_id}","starred_url":"https://api.github.com/users/rkondratenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkondratenko/subscriptions","organizations_url":"https://api.github.com/users/rkondratenko/orgs","repos_url":"https://api.github.com/users/rkondratenko/repos","events_url":"https://api.github.com/users/rkondratenko/events{/privacy}","received_events_url":"https://api.github.com/users/rkondratenko/received_events","type":"User","site_admin":false},"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666979922,"node_id":"MDU6TGFiZWw2NjY5Nzk5MjI=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20changes","name":"awaiting changes","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-09T14:03:21Z","updated_at":"2018-08-01T08:39:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/7559","html_url":"https://github.com/python/cpython/pull/7559","diff_url":"https://github.com/python/cpython/pull/7559.diff","patch_url":"https://github.com/python/cpython/pull/7559.patch"},"body":"SSLSocket in Python wraps ordinary sockets and provides SSLSocket.send with same behaviour (except for nonblocking differences mentiond in the documentation). Internally cPython uses OpenSSL as SSL library.\r\nSSLSocket.send() calls to SSL_write() with data to send. However calling SSL_write() with zero-length buffer is undefined behaviour. To emulate ordinary socket behaviour in this case and not to trigger \r\n undefined behaviour from OpenSSL we explicitly check for zero-length buffer before calling SSL_write().\r\n\n\n<!-- issue-number: bpo-31711 -->\nhttps://bugs.python.org/issue31711\n<!-- /issue-number -->\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/409497897","html_url":"https://github.com/python/cpython/pull/7559#issuecomment-409497897","issue_url":"https://api.github.com/repos/python/cpython/issues/7559","id":409497897,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTQ5Nzg5Nw==","user":{"login":"bedevere-bot","id":28579281,"node_id":"MDQ6VXNlcjI4NTc5Mjgx","avatar_url":"https://avatars0.githubusercontent.com/u/28579281?v=4","gravatar_id":"","url":"https://api.github.com/users/bedevere-bot","html_url":"https://github.com/bedevere-bot","followers_url":"https://api.github.com/users/bedevere-bot/followers","following_url":"https://api.github.com/users/bedevere-bot/following{/other_user}","gists_url":"https://api.github.com/users/bedevere-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/bedevere-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedevere-bot/subscriptions","organizations_url":"https://api.github.com/users/bedevere-bot/orgs","repos_url":"https://api.github.com/users/bedevere-bot/repos","events_url":"https://api.github.com/users/bedevere-bot/events{/privacy}","received_events_url":"https://api.github.com/users/bedevere-bot/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T08:39:35Z","updated_at":"2018-08-01T08:39:35Z","author_association":"NONE","body":"<!-- changes-requested -->\nA Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.\n\nOnce you have made the requested changes, please leave a comment on this pull request containing the phrase `I have made the requested changes; please review again`. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.\n<!-- /changes-requested -->\n\n\n"}}
{"actor":{"display_login":"bedevere-bot"}}