{"action":"created","comment":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/comments/228685240","pull_request_review_id":169024586,"id":228685240,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODY4NTI0MA==","diff_hunk":"@@ -271,13 +272,13 @@ func (c *tchannelOutboundCall) finish(ctx context.Context, err error) {\n \t\terrCause := tchannel.GetSystemErrorCode(errors.Cause(err))\n \t\tscopeTags := map[string]string{scopeTagError: errCause.MetricsKey()}\n \t\tctx = WithScopeTags(ctx, scopeTags)\n-\t\tc.metrics.IncCounter(ctx, outboundCallsSystemErrors, 1)\n+\t\tc.metrics.IncCounter(ctx, clientErrors, 1)","path":"runtime/tchannel_client.go","position":null,"original_position":13,"commit_id":"41f5c5ac6df4af1a7e286e46a896970fb5cb3603","original_commit_id":"a89637d1ff3cd8a14506ceb65b7c9b04c2435d01","user":{"login":"herainman","id":1441215,"node_id":"MDQ6VXNlcjE0NDEyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1441215?v=4","gravatar_id":"","url":"https://api.github.com/users/herainman","html_url":"https://github.com/herainman","followers_url":"https://api.github.com/users/herainman/followers","following_url":"https://api.github.com/users/herainman/following{/other_user}","gists_url":"https://api.github.com/users/herainman/gists{/gist_id}","starred_url":"https://api.github.com/users/herainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herainman/subscriptions","organizations_url":"https://api.github.com/users/herainman/orgs","repos_url":"https://api.github.com/users/herainman/repos","events_url":"https://api.github.com/users/herainman/events{/privacy}","received_events_url":"https://api.github.com/users/herainman/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-10-26T22:56:50Z","updated_at":"2018-10-26T22:56:50Z","html_url":"https://github.com/uber/zanzibar/pull/499#discussion_r228685240","pull_request_url":"https://api.github.com/repos/uber/zanzibar/pulls/499","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments/228685240"},"html":{"href":"https://github.com/uber/zanzibar/pull/499#discussion_r228685240"},"pull_request":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/499"}},"in_reply_to_id":228678002},"pull_request":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/499","id":225192934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTkyOTM0","html_url":"https://github.com/uber/zanzibar/pull/499","diff_url":"https://github.com/uber/zanzibar/pull/499.diff","patch_url":"https://github.com/uber/zanzibar/pull/499.patch","issue_url":"https://api.github.com/repos/uber/zanzibar/issues/499","number":499,"state":"open","locked":false,"title":"Metrics namespace change","user":{"login":"herainman","id":1441215,"node_id":"MDQ6VXNlcjE0NDEyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1441215?v=4","gravatar_id":"","url":"https://api.github.com/users/herainman","html_url":"https://github.com/herainman","followers_url":"https://api.github.com/users/herainman/followers","following_url":"https://api.github.com/users/herainman/following{/other_user}","gists_url":"https://api.github.com/users/herainman/gists{/gist_id}","starred_url":"https://api.github.com/users/herainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herainman/subscriptions","organizations_url":"https://api.github.com/users/herainman/orgs","repos_url":"https://api.github.com/users/herainman/repos","events_url":"https://api.github.com/users/herainman/events{/privacy}","received_events_url":"https://api.github.com/users/herainman/received_events","type":"User","site_admin":false},"body":"This commits:\r\n\r\n- Use RootScope instead of PerHostScope\r\n- Rename counter and timer\r\n- Add protocol tag for HTTP and TChannel","created_at":"2018-10-23T21:27:02Z","updated_at":"2018-10-26T22:56:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13d11cb2840d24bc5e40417dac49b842168ebe88","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jacobgreenleaf","id":2646558,"node_id":"MDQ6VXNlcjI2NDY1NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/2646558?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobgreenleaf","html_url":"https://github.com/jacobgreenleaf","followers_url":"https://api.github.com/users/jacobgreenleaf/followers","following_url":"https://api.github.com/users/jacobgreenleaf/following{/other_user}","gists_url":"https://api.github.com/users/jacobgreenleaf/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobgreenleaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobgreenleaf/subscriptions","organizations_url":"https://api.github.com/users/jacobgreenleaf/orgs","repos_url":"https://api.github.com/users/jacobgreenleaf/repos","events_url":"https://api.github.com/users/jacobgreenleaf/events{/privacy}","received_events_url":"https://api.github.com/users/jacobgreenleaf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/zanzibar/pulls/499/commits","review_comments_url":"https://api.github.com/repos/uber/zanzibar/pulls/499/comments","review_comment_url":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/zanzibar/issues/499/comments","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/41f5c5ac6df4af1a7e286e46a896970fb5cb3603","head":{"label":"uber:alignnamespace","ref":"alignnamespace","sha":"41f5c5ac6df4af1a7e286e46a896970fb5cb3603","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYyODY1NQ==","name":"zanzibar","full_name":"uber/zanzibar","private":false,"owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versioned API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2018-10-26T20:08:32Z","pushed_at":"2018-10-26T22:56:45Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":14674,"stargazers_count":90,"watchers_count":90,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":31,"watchers":90,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"2f9c950e11133107a7a0ac909e7b10b08971e168","user":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"node_id":"MDEwOlJlcG9zaXRvcnk4NTYyODY1NQ==","name":"zanzibar","full_name":"uber/zanzibar","private":false,"owner":{"login":"uber","id":538264,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzODI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versioned API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2018-10-26T20:08:32Z","pushed_at":"2018-10-26T22:56:45Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":14674,"stargazers_count":90,"watchers_count":90,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":31,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/499"},"html":{"href":"https://github.com/uber/zanzibar/pull/499"},"issue":{"href":"https://api.github.com/repos/uber/zanzibar/issues/499"},"comments":{"href":"https://api.github.com/repos/uber/zanzibar/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/uber/zanzibar/statuses/41f5c5ac6df4af1a7e286e46a896970fb5cb3603"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"herainman"}}