{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/comments/196602790","pull_request_review_id":130188287,"id":196602790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjYwMjc5MA==","diff_hunk":"@@ -0,0 +1,25 @@\n+---\n+Name: cwpoembedconfig\n+After: coreoembed\n+Except:\n+  environment: dev\n+Only:\n+  EnvVarSet: SS_OUTBOUND_PROXY\n+---\n+SilverStripe\\Core\\Injector\\Injector:\n+  # Configure the CWP proxy if defined\n+  Embed\\Http\\DispatcherInterface:\n+    class: Embed\\Http\\CurlDispatcher\n+    constructor:\n+      config:\n+        # CURLOPT_PROXY = 10004\n+        10004: '`SS_OUTBOUND_PROXY`'\n+        # CURLOPT_PROXYPORT = 59\n+        59: '`SS_OUTBOUND_PROXY_PORT`'\n+\n+  # Provide dispatcher to Embeddable implementations\n+  SilverStripe\\View\\Embed\\Embeddable:\n+    properties:\n+      foo: bar","path":"app/_config/oembed.yml","position":23,"original_position":23,"commit_id":"b2a116ce3ecd19bc327da2d001c23057e25eabaf","original_commit_id":"b2a116ce3ecd19bc327da2d001c23057e25eabaf","user":{"login":"robbieaverill","id":5170590,"node_id":"MDQ6VXNlcjUxNzA1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false},"body":"Correct! Thanks 😆 ","created_at":"2018-06-19T22:50:50Z","updated_at":"2018-06-19T22:50:51Z","html_url":"https://github.com/silverstripe/cwp-recipe-cms/pull/9#discussion_r196602790","pull_request_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/comments/196602790"},"html":{"href":"https://github.com/silverstripe/cwp-recipe-cms/pull/9#discussion_r196602790"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9"}},"in_reply_to_id":196602555},"pull_request":{"url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9","id":195443225,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDQzMjI1","html_url":"https://github.com/silverstripe/cwp-recipe-cms/pull/9","diff_url":"https://github.com/silverstripe/cwp-recipe-cms/pull/9.diff","patch_url":"https://github.com/silverstripe/cwp-recipe-cms/pull/9.patch","issue_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues/9","number":9,"state":"open","locked":false,"title":"FIX Add proxy configuration for embedded cURL requests","user":{"login":"robbieaverill","id":5170590,"node_id":"MDQ6VXNlcjUxNzA1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false},"body":"Issue: https://github.com/silverstripe/silverstripe-cms/issues/2168\n\nRequires https://github.com/silverstripe/silverstripe-framework/pull/8194 and requires https://github.com/silverstripe/silverstripe-asset-admin/pull/795","created_at":"2018-06-18T07:39:17Z","updated_at":"2018-06-19T22:50:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3d0acd0d8aec79b5602770ced212716e076c452","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":824394477,"node_id":"MDU6TGFiZWw4MjQzOTQ0Nzc=","url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/labels/affects/v4","name":"affects/v4","color":"5319e7","default":false},{"id":824394503,"node_id":"MDU6TGFiZWw4MjQzOTQ1MDM=","url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/labels/change/patch","name":"change/patch","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9/commits","review_comments_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9/comments","review_comment_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues/9/comments","statuses_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/statuses/b2a116ce3ecd19bc327da2d001c23057e25eabaf","head":{"label":"creative-commoners:pulls/2.1/embed-proxy","ref":"pulls/2.1/embed-proxy","sha":"b2a116ce3ecd19bc327da2d001c23057e25eabaf","user":{"login":"creative-commoners","id":28884460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODg0NDYw","avatar_url":"https://avatars2.githubusercontent.com/u/28884460?v=4","gravatar_id":"","url":"https://api.github.com/users/creative-commoners","html_url":"https://github.com/creative-commoners","followers_url":"https://api.github.com/users/creative-commoners/followers","following_url":"https://api.github.com/users/creative-commoners/following{/other_user}","gists_url":"https://api.github.com/users/creative-commoners/gists{/gist_id}","starred_url":"https://api.github.com/users/creative-commoners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creative-commoners/subscriptions","organizations_url":"https://api.github.com/users/creative-commoners/orgs","repos_url":"https://api.github.com/users/creative-commoners/repos","events_url":"https://api.github.com/users/creative-commoners/events{/privacy}","received_events_url":"https://api.github.com/users/creative-commoners/received_events","type":"Organization","site_admin":false},"repo":{"id":119917547,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5MTc1NDc=","name":"cwp-recipe-cms","full_name":"creative-commoners/cwp-recipe-cms","owner":{"login":"creative-commoners","id":28884460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODg0NDYw","avatar_url":"https://avatars2.githubusercontent.com/u/28884460?v=4","gravatar_id":"","url":"https://api.github.com/users/creative-commoners","html_url":"https://github.com/creative-commoners","followers_url":"https://api.github.com/users/creative-commoners/followers","following_url":"https://api.github.com/users/creative-commoners/following{/other_user}","gists_url":"https://api.github.com/users/creative-commoners/gists{/gist_id}","starred_url":"https://api.github.com/users/creative-commoners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creative-commoners/subscriptions","organizations_url":"https://api.github.com/users/creative-commoners/orgs","repos_url":"https://api.github.com/users/creative-commoners/repos","events_url":"https://api.github.com/users/creative-commoners/events{/privacy}","received_events_url":"https://api.github.com/users/creative-commoners/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/creative-commoners/cwp-recipe-cms","description":"CWP CMS requirements recipe","fork":true,"url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms","forks_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/forks","keys_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/teams","hooks_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/hooks","issue_events_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/issues/events{/number}","events_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/events","assignees_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/assignees{/user}","branches_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/branches{/branch}","tags_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/tags","blobs_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/languages","stargazers_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/stargazers","contributors_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/contributors","subscribers_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/subscribers","subscription_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/subscription","commits_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/contents/{+path}","compare_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/merges","archive_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/downloads","issues_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/issues{/number}","pulls_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/labels{/name}","releases_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/releases{/id}","deployments_url":"https://api.github.com/repos/creative-commoners/cwp-recipe-cms/deployments","created_at":"2018-02-02T01:56:39Z","updated_at":"2018-02-02T01:55:44Z","pushed_at":"2018-06-18T07:38:38Z","git_url":"git://github.com/creative-commoners/cwp-recipe-cms.git","ssh_url":"git@github.com:creative-commoners/cwp-recipe-cms.git","clone_url":"https://github.com/creative-commoners/cwp-recipe-cms.git","svn_url":"https://github.com/creative-commoners/cwp-recipe-cms","homepage":null,"size":13,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:2.1","ref":"2.1","sha":"7f8f26a7d54eeac0bced2d597b9a8ce805195ecf","user":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":119917369,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk5MTczNjk=","name":"cwp-recipe-cms","full_name":"silverstripe/cwp-recipe-cms","owner":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/cwp-recipe-cms","description":"CWP CMS requirements recipe","fork":false,"url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms","forks_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/forks","keys_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/teams","hooks_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/events","assignees_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/tags","blobs_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/languages","stargazers_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/subscription","commits_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/merges","archive_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/downloads","issues_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/deployments","created_at":"2018-02-02T01:55:01Z","updated_at":"2018-06-17T23:10:04Z","pushed_at":"2018-06-18T07:39:17Z","git_url":"git://github.com/silverstripe/cwp-recipe-cms.git","ssh_url":"git@github.com:silverstripe/cwp-recipe-cms.git","clone_url":"https://github.com/silverstripe/cwp-recipe-cms.git","svn_url":"https://github.com/silverstripe/cwp-recipe-cms","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9"},"html":{"href":"https://github.com/silverstripe/cwp-recipe-cms/pull/9"},"issue":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues/9"},"comments":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/cwp-recipe-cms/statuses/b2a116ce3ecd19bc327da2d001c23057e25eabaf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"robbieaverill"}}