{"action":"created","comment":{"url":"https://api.github.com/repos/theislab/scanpy/pulls/comments/223229090","pull_request_review_id":162305873,"id":223229090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIyOTA5MA==","diff_hunk":"@@ -591,34 +593,36 @@ def pca(data, n_comps=None, zero_center=True, svd_solver='auto', random_state=0,\n         logg.msg('reducing number of computed PCs to',\n                n_comps, 'as dim of data is only', adata.n_vars, v=4)\n \n+    adata_hvg = adata[:, adata.var['highly_variable']] if use_hvg and 'highly_variable' in adata.var.keys() else adata","path":"scanpy/preprocessing/simple.py","position":52,"original_position":54,"commit_id":"d8f674ffa8955970601d5d2d8076c7d4a9ce72f2","original_commit_id":"ea74babb18d605f4a1d3c7c366a5b3c24c189396","user":{"login":"gokceneraslan","id":1140359,"node_id":"MDQ6VXNlcjExNDAzNTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1140359?v=4","gravatar_id":"","url":"https://api.github.com/users/gokceneraslan","html_url":"https://github.com/gokceneraslan","followers_url":"https://api.github.com/users/gokceneraslan/followers","following_url":"https://api.github.com/users/gokceneraslan/following{/other_user}","gists_url":"https://api.github.com/users/gokceneraslan/gists{/gist_id}","starred_url":"https://api.github.com/users/gokceneraslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gokceneraslan/subscriptions","organizations_url":"https://api.github.com/users/gokceneraslan/orgs","repos_url":"https://api.github.com/users/gokceneraslan/repos","events_url":"https://api.github.com/users/gokceneraslan/events{/privacy}","received_events_url":"https://api.github.com/users/gokceneraslan/received_events","type":"User","site_admin":false},"body":"If use_hvg is False, this naming doesn't make sense. I would keep it as adata even if use_hvg is True.","created_at":"2018-10-07T21:41:34Z","updated_at":"2018-10-07T21:41:35Z","html_url":"https://github.com/theislab/scanpy/pull/284#discussion_r223229090","pull_request_url":"https://api.github.com/repos/theislab/scanpy/pulls/284","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/theislab/scanpy/pulls/comments/223229090"},"html":{"href":"https://github.com/theislab/scanpy/pull/284#discussion_r223229090"},"pull_request":{"href":"https://api.github.com/repos/theislab/scanpy/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/theislab/scanpy/pulls/284","id":220961826,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTYxODI2","html_url":"https://github.com/theislab/scanpy/pull/284","diff_url":"https://github.com/theislab/scanpy/pull/284.diff","patch_url":"https://github.com/theislab/scanpy/pull/284.patch","issue_url":"https://api.github.com/repos/theislab/scanpy/issues/284","number":284,"state":"open","locked":false,"title":"add key_added to store bool array of hvg","user":{"login":"VolkerBergen","id":31883718,"node_id":"MDQ6VXNlcjMxODgzNzE4","avatar_url":"https://avatars1.githubusercontent.com/u/31883718?v=4","gravatar_id":"","url":"https://api.github.com/users/VolkerBergen","html_url":"https://github.com/VolkerBergen","followers_url":"https://api.github.com/users/VolkerBergen/followers","following_url":"https://api.github.com/users/VolkerBergen/following{/other_user}","gists_url":"https://api.github.com/users/VolkerBergen/gists{/gist_id}","starred_url":"https://api.github.com/users/VolkerBergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolkerBergen/subscriptions","organizations_url":"https://api.github.com/users/VolkerBergen/orgs","repos_url":"https://api.github.com/users/VolkerBergen/repos","events_url":"https://api.github.com/users/VolkerBergen/events{/privacy}","received_events_url":"https://api.github.com/users/VolkerBergen/received_events","type":"User","site_admin":false},"body":"add option to keep genes and store bool array of highly variable genes","created_at":"2018-10-07T17:37:28Z","updated_at":"2018-10-07T21:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1761f43052edee5cdb290f1ea2e65ca4aaceb0c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theislab/scanpy/pulls/284/commits","review_comments_url":"https://api.github.com/repos/theislab/scanpy/pulls/284/comments","review_comment_url":"https://api.github.com/repos/theislab/scanpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theislab/scanpy/issues/284/comments","statuses_url":"https://api.github.com/repos/theislab/scanpy/statuses/d8f674ffa8955970601d5d2d8076c7d4a9ce72f2","head":{"label":"theislab:VolkerBergen-patch-1","ref":"VolkerBergen-patch-1","sha":"d8f674ffa8955970601d5d2d8076c7d4a9ce72f2","user":{"login":"theislab","id":22319415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE5NDE1","avatar_url":"https://avatars3.githubusercontent.com/u/22319415?v=4","gravatar_id":"","url":"https://api.github.com/users/theislab","html_url":"https://github.com/theislab","followers_url":"https://api.github.com/users/theislab/followers","following_url":"https://api.github.com/users/theislab/following{/other_user}","gists_url":"https://api.github.com/users/theislab/gists{/gist_id}","starred_url":"https://api.github.com/users/theislab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theislab/subscriptions","organizations_url":"https://api.github.com/users/theislab/orgs","repos_url":"https://api.github.com/users/theislab/repos","events_url":"https://api.github.com/users/theislab/events{/privacy}","received_events_url":"https://api.github.com/users/theislab/received_events","type":"Organization","site_admin":false},"repo":{"id":80342493,"node_id":"MDEwOlJlcG9zaXRvcnk4MDM0MjQ5Mw==","name":"scanpy","full_name":"theislab/scanpy","private":false,"owner":{"login":"theislab","id":22319415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE5NDE1","avatar_url":"https://avatars3.githubusercontent.com/u/22319415?v=4","gravatar_id":"","url":"https://api.github.com/users/theislab","html_url":"https://github.com/theislab","followers_url":"https://api.github.com/users/theislab/followers","following_url":"https://api.github.com/users/theislab/following{/other_user}","gists_url":"https://api.github.com/users/theislab/gists{/gist_id}","starred_url":"https://api.github.com/users/theislab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theislab/subscriptions","organizations_url":"https://api.github.com/users/theislab/orgs","repos_url":"https://api.github.com/users/theislab/repos","events_url":"https://api.github.com/users/theislab/events{/privacy}","received_events_url":"https://api.github.com/users/theislab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theislab/scanpy","description":"Single-Cell Analysis in Python. Scales to >1M cells.","fork":false,"url":"https://api.github.com/repos/theislab/scanpy","forks_url":"https://api.github.com/repos/theislab/scanpy/forks","keys_url":"https://api.github.com/repos/theislab/scanpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theislab/scanpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theislab/scanpy/teams","hooks_url":"https://api.github.com/repos/theislab/scanpy/hooks","issue_events_url":"https://api.github.com/repos/theislab/scanpy/issues/events{/number}","events_url":"https://api.github.com/repos/theislab/scanpy/events","assignees_url":"https://api.github.com/repos/theislab/scanpy/assignees{/user}","branches_url":"https://api.github.com/repos/theislab/scanpy/branches{/branch}","tags_url":"https://api.github.com/repos/theislab/scanpy/tags","blobs_url":"https://api.github.com/repos/theislab/scanpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theislab/scanpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theislab/scanpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theislab/scanpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theislab/scanpy/statuses/{sha}","languages_url":"https://api.github.com/repos/theislab/scanpy/languages","stargazers_url":"https://api.github.com/repos/theislab/scanpy/stargazers","contributors_url":"https://api.github.com/repos/theislab/scanpy/contributors","subscribers_url":"https://api.github.com/repos/theislab/scanpy/subscribers","subscription_url":"https://api.github.com/repos/theislab/scanpy/subscription","commits_url":"https://api.github.com/repos/theislab/scanpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theislab/scanpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theislab/scanpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theislab/scanpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theislab/scanpy/contents/{+path}","compare_url":"https://api.github.com/repos/theislab/scanpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theislab/scanpy/merges","archive_url":"https://api.github.com/repos/theislab/scanpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theislab/scanpy/downloads","issues_url":"https://api.github.com/repos/theislab/scanpy/issues{/number}","pulls_url":"https://api.github.com/repos/theislab/scanpy/pulls{/number}","milestones_url":"https://api.github.com/repos/theislab/scanpy/milestones{/number}","notifications_url":"https://api.github.com/repos/theislab/scanpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theislab/scanpy/labels{/name}","releases_url":"https://api.github.com/repos/theislab/scanpy/releases{/id}","deployments_url":"https://api.github.com/repos/theislab/scanpy/deployments","created_at":"2017-01-29T11:31:11Z","updated_at":"2018-10-07T16:52:37Z","pushed_at":"2018-10-07T20:28:23Z","git_url":"git://github.com/theislab/scanpy.git","ssh_url":"git@github.com:theislab/scanpy.git","clone_url":"https://github.com/theislab/scanpy.git","svn_url":"https://github.com/theislab/scanpy","homepage":"http://scanpy.rtfd.io","size":13277,"stargazers_count":206,"watchers_count":206,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":78,"open_issues":50,"watchers":206,"default_branch":"master"}},"base":{"label":"theislab:master","ref":"master","sha":"7c9fb1a5f2293956adda0673d47e7dec1b32ddfb","user":{"login":"theislab","id":22319415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE5NDE1","avatar_url":"https://avatars3.githubusercontent.com/u/22319415?v=4","gravatar_id":"","url":"https://api.github.com/users/theislab","html_url":"https://github.com/theislab","followers_url":"https://api.github.com/users/theislab/followers","following_url":"https://api.github.com/users/theislab/following{/other_user}","gists_url":"https://api.github.com/users/theislab/gists{/gist_id}","starred_url":"https://api.github.com/users/theislab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theislab/subscriptions","organizations_url":"https://api.github.com/users/theislab/orgs","repos_url":"https://api.github.com/users/theislab/repos","events_url":"https://api.github.com/users/theislab/events{/privacy}","received_events_url":"https://api.github.com/users/theislab/received_events","type":"Organization","site_admin":false},"repo":{"id":80342493,"node_id":"MDEwOlJlcG9zaXRvcnk4MDM0MjQ5Mw==","name":"scanpy","full_name":"theislab/scanpy","private":false,"owner":{"login":"theislab","id":22319415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzE5NDE1","avatar_url":"https://avatars3.githubusercontent.com/u/22319415?v=4","gravatar_id":"","url":"https://api.github.com/users/theislab","html_url":"https://github.com/theislab","followers_url":"https://api.github.com/users/theislab/followers","following_url":"https://api.github.com/users/theislab/following{/other_user}","gists_url":"https://api.github.com/users/theislab/gists{/gist_id}","starred_url":"https://api.github.com/users/theislab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theislab/subscriptions","organizations_url":"https://api.github.com/users/theislab/orgs","repos_url":"https://api.github.com/users/theislab/repos","events_url":"https://api.github.com/users/theislab/events{/privacy}","received_events_url":"https://api.github.com/users/theislab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theislab/scanpy","description":"Single-Cell Analysis in Python. Scales to >1M cells.","fork":false,"url":"https://api.github.com/repos/theislab/scanpy","forks_url":"https://api.github.com/repos/theislab/scanpy/forks","keys_url":"https://api.github.com/repos/theislab/scanpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theislab/scanpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theislab/scanpy/teams","hooks_url":"https://api.github.com/repos/theislab/scanpy/hooks","issue_events_url":"https://api.github.com/repos/theislab/scanpy/issues/events{/number}","events_url":"https://api.github.com/repos/theislab/scanpy/events","assignees_url":"https://api.github.com/repos/theislab/scanpy/assignees{/user}","branches_url":"https://api.github.com/repos/theislab/scanpy/branches{/branch}","tags_url":"https://api.github.com/repos/theislab/scanpy/tags","blobs_url":"https://api.github.com/repos/theislab/scanpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theislab/scanpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theislab/scanpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/theislab/scanpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theislab/scanpy/statuses/{sha}","languages_url":"https://api.github.com/repos/theislab/scanpy/languages","stargazers_url":"https://api.github.com/repos/theislab/scanpy/stargazers","contributors_url":"https://api.github.com/repos/theislab/scanpy/contributors","subscribers_url":"https://api.github.com/repos/theislab/scanpy/subscribers","subscription_url":"https://api.github.com/repos/theislab/scanpy/subscription","commits_url":"https://api.github.com/repos/theislab/scanpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/theislab/scanpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/theislab/scanpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/theislab/scanpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/theislab/scanpy/contents/{+path}","compare_url":"https://api.github.com/repos/theislab/scanpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theislab/scanpy/merges","archive_url":"https://api.github.com/repos/theislab/scanpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theislab/scanpy/downloads","issues_url":"https://api.github.com/repos/theislab/scanpy/issues{/number}","pulls_url":"https://api.github.com/repos/theislab/scanpy/pulls{/number}","milestones_url":"https://api.github.com/repos/theislab/scanpy/milestones{/number}","notifications_url":"https://api.github.com/repos/theislab/scanpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theislab/scanpy/labels{/name}","releases_url":"https://api.github.com/repos/theislab/scanpy/releases{/id}","deployments_url":"https://api.github.com/repos/theislab/scanpy/deployments","created_at":"2017-01-29T11:31:11Z","updated_at":"2018-10-07T16:52:37Z","pushed_at":"2018-10-07T20:28:23Z","git_url":"git://github.com/theislab/scanpy.git","ssh_url":"git@github.com:theislab/scanpy.git","clone_url":"https://github.com/theislab/scanpy.git","svn_url":"https://github.com/theislab/scanpy","homepage":"http://scanpy.rtfd.io","size":13277,"stargazers_count":206,"watchers_count":206,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":78,"open_issues":50,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theislab/scanpy/pulls/284"},"html":{"href":"https://github.com/theislab/scanpy/pull/284"},"issue":{"href":"https://api.github.com/repos/theislab/scanpy/issues/284"},"comments":{"href":"https://api.github.com/repos/theislab/scanpy/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/theislab/scanpy/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/theislab/scanpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theislab/scanpy/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/theislab/scanpy/statuses/d8f674ffa8955970601d5d2d8076c7d4a9ce72f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gokceneraslan"}}