{"action":"created","comment":{"url":"https://api.github.com/repos/warriorframework/warriorframework/pulls/comments/182651489","pull_request_review_id":113488183,"id":182651489,"diff_hunk":"@@ -508,22 +508,29 @@ def append_result_files(self, dst_resultfile, kw_resultfile_list, dst_root='Test\n     @staticmethod\n     def compute_status_using_impact(input_status_list, input_impact_list, status=True):\n         \"\"\"Computes the status from the list of input status and input impact \"\"\"\n-        status = True\n+        value = True\n+        result = []\n         for i in range(0, len(input_status_list)):\n             input_status = input_status_list[i]\n             input_impact = input_impact_list[i]\n             if str(input_impact).upper() == 'IMPACT' and input_status != None:\n                 if str(input_status).upper() == 'ERROR' or str(input_status).upper() == 'EXCEPTION':\n-                    #input_status_list[i] = False\n-                    status = 'ERROR'\n-                    break\n+                    value = 'ERROR'\n                 elif str(input_status).upper() == 'RAN':\n-                    status = 'RAN'\n-                elif input_status == False:\n-                    status = False \n-                    break\n+                    value = 'RAN'\n+                elif input_status is False:\n+                    value = False\n                 elif input_status is True:\n-                    status = True \n+                    value = True\n+            result.append(value)\n+        if 'ERROR' in result:\n+            status = 'ERROR'\n+        elif 'ERROR' not in result and False in result:","path":"warrior/WarriorCore/Classes/testcase_utils_class.py","position":null,"original_position":30,"commit_id":"1a307b830e2427dab938eabe7e11f64da0694bd9","original_commit_id":"b3670e8bddb009b2b70054a4f01fa3e5eb7acd0e","user":{"login":"ReshmaManohar","id":36954976,"avatar_url":"https://avatars3.githubusercontent.com/u/36954976?v=4","gravatar_id":"","url":"https://api.github.com/users/ReshmaManohar","html_url":"https://github.com/ReshmaManohar","followers_url":"https://api.github.com/users/ReshmaManohar/followers","following_url":"https://api.github.com/users/ReshmaManohar/following{/other_user}","gists_url":"https://api.github.com/users/ReshmaManohar/gists{/gist_id}","starred_url":"https://api.github.com/users/ReshmaManohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReshmaManohar/subscriptions","organizations_url":"https://api.github.com/users/ReshmaManohar/orgs","repos_url":"https://api.github.com/users/ReshmaManohar/repos","events_url":"https://api.github.com/users/ReshmaManohar/events{/privacy}","received_events_url":"https://api.github.com/users/ReshmaManohar/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-04-19T07:11:09Z","updated_at":"2018-04-19T07:11:09Z","html_url":"https://github.com/warriorframework/warriorframework/pull/410#discussion_r182651489","pull_request_url":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/warriorframework/warriorframework/pulls/comments/182651489"},"html":{"href":"https://github.com/warriorframework/warriorframework/pull/410#discussion_r182651489"},"pull_request":{"href":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410"}},"in_reply_to_id":182648704},"pull_request":{"url":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410","id":175852205,"html_url":"https://github.com/warriorframework/warriorframework/pull/410","diff_url":"https://github.com/warriorframework/warriorframework/pull/410.diff","patch_url":"https://github.com/warriorframework/warriorframework/pull/410.patch","issue_url":"https://api.github.com/repos/warriorframework/warriorframework/issues/410","number":410,"state":"open","locked":false,"title":"WAR-1716 : Project execution mail subject reflected as NONE even though the project is passed","user":{"login":"ReshmaManohar","id":36954976,"avatar_url":"https://avatars3.githubusercontent.com/u/36954976?v=4","gravatar_id":"","url":"https://api.github.com/users/ReshmaManohar","html_url":"https://github.com/ReshmaManohar","followers_url":"https://api.github.com/users/ReshmaManohar/followers","following_url":"https://api.github.com/users/ReshmaManohar/following{/other_user}","gists_url":"https://api.github.com/users/ReshmaManohar/gists{/gist_id}","starred_url":"https://api.github.com/users/ReshmaManohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReshmaManohar/subscriptions","organizations_url":"https://api.github.com/users/ReshmaManohar/orgs","repos_url":"https://api.github.com/users/ReshmaManohar/repos","events_url":"https://api.github.com/users/ReshmaManohar/events{/privacy}","received_events_url":"https://api.github.com/users/ReshmaManohar/received_events","type":"User","site_admin":false},"body":"Requirement:\r\nSubject line of the email sent by Warrior will have the execution status, now it is always 'None' for project execution but it has to reflect the correct execution status.\r\n\r\nFix explanation: \r\nProject status is computed in sequential/parallel suite(s) execution, possible status values are:\r\n\r\n\t(i) ERROR(string) - for both error and exception\r\n\t(ii) True(boolean)\r\n\t(iii) False(boolean)\r\n\t(iv) RAN(string)\r\n\r\nIn Suite/Case, the execution status values thus obtained are converted to corresponding strings (PASS/FAIL/ERROR) using dictionary and gets printed without being stored in a variable\r\nin respective methods. But in project, the values after conversion are stored in a variable named project_status which results in reflection of project execution status as 'None' in\r\nemail subject. Therefore, removing the assignment which is not used.\r\n\r\nAttached the regression logs and instructions for testing in Jira.\r\n\r\nEdit - 04.06.2018 by ReshmaManohar\r\n\r\nIncluded the below modifications,\r\n1. Earlier, mockrun status 'RAN' was reflected as 'None' in mail for Case/Suite/Project. Resolved the same \r\n    by adding a key 'RAN' to resultconverted dict in email_utils.\r\n2. Also mockrun execution result was 'None' for Suite/Project. Resolved it by adding  a key 'RAN' to dict \r\n    in  report_project_result method (project_driver.py) and report_testsuite_result \r\n    method (testsuite_utils.py) respectively.\r\n\r\nAttached the logs in Jira.","created_at":"2018-03-19T10:05:31Z","updated_at":"2018-04-19T07:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0099d342ca076b352ae6cf37efb6cfa5a7968277","assignee":{"login":"ReshmaManohar","id":36954976,"avatar_url":"https://avatars3.githubusercontent.com/u/36954976?v=4","gravatar_id":"","url":"https://api.github.com/users/ReshmaManohar","html_url":"https://github.com/ReshmaManohar","followers_url":"https://api.github.com/users/ReshmaManohar/followers","following_url":"https://api.github.com/users/ReshmaManohar/following{/other_user}","gists_url":"https://api.github.com/users/ReshmaManohar/gists{/gist_id}","starred_url":"https://api.github.com/users/ReshmaManohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReshmaManohar/subscriptions","organizations_url":"https://api.github.com/users/ReshmaManohar/orgs","repos_url":"https://api.github.com/users/ReshmaManohar/repos","events_url":"https://api.github.com/users/ReshmaManohar/events{/privacy}","received_events_url":"https://api.github.com/users/ReshmaManohar/received_events","type":"User","site_admin":false},"assignees":[{"login":"ReshmaManohar","id":36954976,"avatar_url":"https://avatars3.githubusercontent.com/u/36954976?v=4","gravatar_id":"","url":"https://api.github.com/users/ReshmaManohar","html_url":"https://github.com/ReshmaManohar","followers_url":"https://api.github.com/users/ReshmaManohar/followers","following_url":"https://api.github.com/users/ReshmaManohar/following{/other_user}","gists_url":"https://api.github.com/users/ReshmaManohar/gists{/gist_id}","starred_url":"https://api.github.com/users/ReshmaManohar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReshmaManohar/subscriptions","organizations_url":"https://api.github.com/users/ReshmaManohar/orgs","repos_url":"https://api.github.com/users/ReshmaManohar/repos","events_url":"https://api.github.com/users/ReshmaManohar/events{/privacy}","received_events_url":"https://api.github.com/users/ReshmaManohar/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bjrr","id":8376685,"avatar_url":"https://avatars0.githubusercontent.com/u/8376685?v=4","gravatar_id":"","url":"https://api.github.com/users/bjrr","html_url":"https://github.com/bjrr","followers_url":"https://api.github.com/users/bjrr/followers","following_url":"https://api.github.com/users/bjrr/following{/other_user}","gists_url":"https://api.github.com/users/bjrr/gists{/gist_id}","starred_url":"https://api.github.com/users/bjrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjrr/subscriptions","organizations_url":"https://api.github.com/users/bjrr/orgs","repos_url":"https://api.github.com/users/bjrr/repos","events_url":"https://api.github.com/users/bjrr/events{/privacy}","received_events_url":"https://api.github.com/users/bjrr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":563406358,"url":"https://api.github.com/repos/warriorframework/warriorframework/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410/commits","review_comments_url":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410/comments","review_comment_url":"https://api.github.com/repos/warriorframework/warriorframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/warriorframework/warriorframework/issues/410/comments","statuses_url":"https://api.github.com/repos/warriorframework/warriorframework/statuses/1a307b830e2427dab938eabe7e11f64da0694bd9","head":{"label":"warriorframework:bugfix/WAR-1716","ref":"bugfix/WAR-1716","sha":"1a307b830e2427dab938eabe7e11f64da0694bd9","user":{"login":"warriorframework","id":19936037,"avatar_url":"https://avatars0.githubusercontent.com/u/19936037?v=4","gravatar_id":"","url":"https://api.github.com/users/warriorframework","html_url":"https://github.com/warriorframework","followers_url":"https://api.github.com/users/warriorframework/followers","following_url":"https://api.github.com/users/warriorframework/following{/other_user}","gists_url":"https://api.github.com/users/warriorframework/gists{/gist_id}","starred_url":"https://api.github.com/users/warriorframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warriorframework/subscriptions","organizations_url":"https://api.github.com/users/warriorframework/orgs","repos_url":"https://api.github.com/users/warriorframework/repos","events_url":"https://api.github.com/users/warriorframework/events{/privacy}","received_events_url":"https://api.github.com/users/warriorframework/received_events","type":"Organization","site_admin":false},"repo":{"id":85365941,"name":"warriorframework","full_name":"warriorframework/warriorframework","owner":{"login":"warriorframework","id":19936037,"avatar_url":"https://avatars0.githubusercontent.com/u/19936037?v=4","gravatar_id":"","url":"https://api.github.com/users/warriorframework","html_url":"https://github.com/warriorframework","followers_url":"https://api.github.com/users/warriorframework/followers","following_url":"https://api.github.com/users/warriorframework/following{/other_user}","gists_url":"https://api.github.com/users/warriorframework/gists{/gist_id}","starred_url":"https://api.github.com/users/warriorframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warriorframework/subscriptions","organizations_url":"https://api.github.com/users/warriorframework/orgs","repos_url":"https://api.github.com/users/warriorframework/repos","events_url":"https://api.github.com/users/warriorframework/events{/privacy}","received_events_url":"https://api.github.com/users/warriorframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/warriorframework/warriorframework","description":"Warrior Framework is an open source automation framework designed to enable anyone to automate their testing, processes, and repetitive tasks by simplifying the complex process of building an automation infrastructure.","fork":false,"url":"https://api.github.com/repos/warriorframework/warriorframework","forks_url":"https://api.github.com/repos/warriorframework/warriorframework/forks","keys_url":"https://api.github.com/repos/warriorframework/warriorframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warriorframework/warriorframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warriorframework/warriorframework/teams","hooks_url":"https://api.github.com/repos/warriorframework/warriorframework/hooks","issue_events_url":"https://api.github.com/repos/warriorframework/warriorframework/issues/events{/number}","events_url":"https://api.github.com/repos/warriorframework/warriorframework/events","assignees_url":"https://api.github.com/repos/warriorframework/warriorframework/assignees{/user}","branches_url":"https://api.github.com/repos/warriorframework/warriorframework/branches{/branch}","tags_url":"https://api.github.com/repos/warriorframework/warriorframework/tags","blobs_url":"https://api.github.com/repos/warriorframework/warriorframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warriorframework/warriorframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warriorframework/warriorframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/warriorframework/warriorframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warriorframework/warriorframework/statuses/{sha}","languages_url":"https://api.github.com/repos/warriorframework/warriorframework/languages","stargazers_url":"https://api.github.com/repos/warriorframework/warriorframework/stargazers","contributors_url":"https://api.github.com/repos/warriorframework/warriorframework/contributors","subscribers_url":"https://api.github.com/repos/warriorframework/warriorframework/subscribers","subscription_url":"https://api.github.com/repos/warriorframework/warriorframework/subscription","commits_url":"https://api.github.com/repos/warriorframework/warriorframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/warriorframework/warriorframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/warriorframework/warriorframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/warriorframework/warriorframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/warriorframework/warriorframework/contents/{+path}","compare_url":"https://api.github.com/repos/warriorframework/warriorframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warriorframework/warriorframework/merges","archive_url":"https://api.github.com/repos/warriorframework/warriorframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warriorframework/warriorframework/downloads","issues_url":"https://api.github.com/repos/warriorframework/warriorframework/issues{/number}","pulls_url":"https://api.github.com/repos/warriorframework/warriorframework/pulls{/number}","milestones_url":"https://api.github.com/repos/warriorframework/warriorframework/milestones{/number}","notifications_url":"https://api.github.com/repos/warriorframework/warriorframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warriorframework/warriorframework/labels{/name}","releases_url":"https://api.github.com/repos/warriorframework/warriorframework/releases{/id}","deployments_url":"https://api.github.com/repos/warriorframework/warriorframework/deployments","created_at":"2017-03-18T00:43:58Z","updated_at":"2018-04-12T20:33:57Z","pushed_at":"2018-04-19T07:09:15Z","git_url":"git://github.com/warriorframework/warriorframework.git","ssh_url":"git@github.com:warriorframework/warriorframework.git","clone_url":"https://github.com/warriorframework/warriorframework.git","svn_url":"https://github.com/warriorframework/warriorframework","homepage":"http://warriorframework.org","size":32652,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":30,"watchers":15,"default_branch":"master"}},"base":{"label":"warriorframework:develop","ref":"develop","sha":"fd16de73fddfc3e630244b090e21088a8dff188c","user":{"login":"warriorframework","id":19936037,"avatar_url":"https://avatars0.githubusercontent.com/u/19936037?v=4","gravatar_id":"","url":"https://api.github.com/users/warriorframework","html_url":"https://github.com/warriorframework","followers_url":"https://api.github.com/users/warriorframework/followers","following_url":"https://api.github.com/users/warriorframework/following{/other_user}","gists_url":"https://api.github.com/users/warriorframework/gists{/gist_id}","starred_url":"https://api.github.com/users/warriorframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warriorframework/subscriptions","organizations_url":"https://api.github.com/users/warriorframework/orgs","repos_url":"https://api.github.com/users/warriorframework/repos","events_url":"https://api.github.com/users/warriorframework/events{/privacy}","received_events_url":"https://api.github.com/users/warriorframework/received_events","type":"Organization","site_admin":false},"repo":{"id":85365941,"name":"warriorframework","full_name":"warriorframework/warriorframework","owner":{"login":"warriorframework","id":19936037,"avatar_url":"https://avatars0.githubusercontent.com/u/19936037?v=4","gravatar_id":"","url":"https://api.github.com/users/warriorframework","html_url":"https://github.com/warriorframework","followers_url":"https://api.github.com/users/warriorframework/followers","following_url":"https://api.github.com/users/warriorframework/following{/other_user}","gists_url":"https://api.github.com/users/warriorframework/gists{/gist_id}","starred_url":"https://api.github.com/users/warriorframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warriorframework/subscriptions","organizations_url":"https://api.github.com/users/warriorframework/orgs","repos_url":"https://api.github.com/users/warriorframework/repos","events_url":"https://api.github.com/users/warriorframework/events{/privacy}","received_events_url":"https://api.github.com/users/warriorframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/warriorframework/warriorframework","description":"Warrior Framework is an open source automation framework designed to enable anyone to automate their testing, processes, and repetitive tasks by simplifying the complex process of building an automation infrastructure.","fork":false,"url":"https://api.github.com/repos/warriorframework/warriorframework","forks_url":"https://api.github.com/repos/warriorframework/warriorframework/forks","keys_url":"https://api.github.com/repos/warriorframework/warriorframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/warriorframework/warriorframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/warriorframework/warriorframework/teams","hooks_url":"https://api.github.com/repos/warriorframework/warriorframework/hooks","issue_events_url":"https://api.github.com/repos/warriorframework/warriorframework/issues/events{/number}","events_url":"https://api.github.com/repos/warriorframework/warriorframework/events","assignees_url":"https://api.github.com/repos/warriorframework/warriorframework/assignees{/user}","branches_url":"https://api.github.com/repos/warriorframework/warriorframework/branches{/branch}","tags_url":"https://api.github.com/repos/warriorframework/warriorframework/tags","blobs_url":"https://api.github.com/repos/warriorframework/warriorframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/warriorframework/warriorframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/warriorframework/warriorframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/warriorframework/warriorframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/warriorframework/warriorframework/statuses/{sha}","languages_url":"https://api.github.com/repos/warriorframework/warriorframework/languages","stargazers_url":"https://api.github.com/repos/warriorframework/warriorframework/stargazers","contributors_url":"https://api.github.com/repos/warriorframework/warriorframework/contributors","subscribers_url":"https://api.github.com/repos/warriorframework/warriorframework/subscribers","subscription_url":"https://api.github.com/repos/warriorframework/warriorframework/subscription","commits_url":"https://api.github.com/repos/warriorframework/warriorframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/warriorframework/warriorframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/warriorframework/warriorframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/warriorframework/warriorframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/warriorframework/warriorframework/contents/{+path}","compare_url":"https://api.github.com/repos/warriorframework/warriorframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/warriorframework/warriorframework/merges","archive_url":"https://api.github.com/repos/warriorframework/warriorframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/warriorframework/warriorframework/downloads","issues_url":"https://api.github.com/repos/warriorframework/warriorframework/issues{/number}","pulls_url":"https://api.github.com/repos/warriorframework/warriorframework/pulls{/number}","milestones_url":"https://api.github.com/repos/warriorframework/warriorframework/milestones{/number}","notifications_url":"https://api.github.com/repos/warriorframework/warriorframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/warriorframework/warriorframework/labels{/name}","releases_url":"https://api.github.com/repos/warriorframework/warriorframework/releases{/id}","deployments_url":"https://api.github.com/repos/warriorframework/warriorframework/deployments","created_at":"2017-03-18T00:43:58Z","updated_at":"2018-04-12T20:33:57Z","pushed_at":"2018-04-19T07:09:15Z","git_url":"git://github.com/warriorframework/warriorframework.git","ssh_url":"git@github.com:warriorframework/warriorframework.git","clone_url":"https://github.com/warriorframework/warriorframework.git","svn_url":"https://github.com/warriorframework/warriorframework","homepage":"http://warriorframework.org","size":32652,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":30,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410"},"html":{"href":"https://github.com/warriorframework/warriorframework/pull/410"},"issue":{"href":"https://api.github.com/repos/warriorframework/warriorframework/issues/410"},"comments":{"href":"https://api.github.com/repos/warriorframework/warriorframework/issues/410/comments"},"review_comments":{"href":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410/comments"},"review_comment":{"href":"https://api.github.com/repos/warriorframework/warriorframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/warriorframework/warriorframework/pulls/410/commits"},"statuses":{"href":"https://api.github.com/repos/warriorframework/warriorframework/statuses/1a307b830e2427dab938eabe7e11f64da0694bd9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ReshmaManohar"}}