{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc-java/issues/4095","repository_url":"https://api.github.com/repos/grpc/grpc-java","labels_url":"https://api.github.com/repos/grpc/grpc-java/issues/4095/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/4095/comments","events_url":"https://api.github.com/repos/grpc/grpc-java/issues/4095/events","html_url":"https://github.com/grpc/grpc-java/issues/4095","id":298025290,"number":4095,"title":"Replace workspace(\"grpc_java\") with workspace(com_github_grpc_grpc_java)","user":{"login":"cgrushko","id":1998689,"avatar_url":"https://avatars1.githubusercontent.com/u/1998689?v=4","gravatar_id":"","url":"https://api.github.com/users/cgrushko","html_url":"https://github.com/cgrushko","followers_url":"https://api.github.com/users/cgrushko/followers","following_url":"https://api.github.com/users/cgrushko/following{/other_user}","gists_url":"https://api.github.com/users/cgrushko/gists{/gist_id}","starred_url":"https://api.github.com/users/cgrushko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgrushko/subscriptions","organizations_url":"https://api.github.com/users/cgrushko/orgs","repos_url":"https://api.github.com/users/cgrushko/repos","events_url":"https://api.github.com/users/cgrushko/events{/privacy}","received_events_url":"https://api.github.com/users/cgrushko/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/grpc/grpc-java/milestones/24","html_url":"https://github.com/grpc/grpc-java/milestone/24","labels_url":"https://api.github.com/repos/grpc/grpc-java/milestones/24/labels","id":3076566,"number":24,"title":"1.11","description":"v1.11.0 release. Feature window closes March 12th 2018.","creator":{"login":"ericgribkoff","id":5067076,"avatar_url":"https://avatars2.githubusercontent.com/u/5067076?v=4","gravatar_id":"","url":"https://api.github.com/users/ericgribkoff","html_url":"https://github.com/ericgribkoff","followers_url":"https://api.github.com/users/ericgribkoff/followers","following_url":"https://api.github.com/users/ericgribkoff/following{/other_user}","gists_url":"https://api.github.com/users/ericgribkoff/gists{/gist_id}","starred_url":"https://api.github.com/users/ericgribkoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericgribkoff/subscriptions","organizations_url":"https://api.github.com/users/ericgribkoff/orgs","repos_url":"https://api.github.com/users/ericgribkoff/repos","events_url":"https://api.github.com/users/ericgribkoff/events{/privacy}","received_events_url":"https://api.github.com/users/ericgribkoff/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":8,"state":"open","created_at":"2018-01-31T00:11:17Z","updated_at":"2018-03-07T14:30:13Z","due_on":"2018-03-26T07:00:00Z","closed_at":null},"comments":3,"created_at":"2018-02-17T18:24:30Z","updated_at":"2018-03-07T14:31:22Z","closed_at":"2018-02-22T21:59:46Z","author_association":"CONTRIBUTOR","body":"... or something else more authoritative.\r\n\r\nThe workspace statement in the `WORKSPACE` file should match the name users are giving the external repositories that import this repo, e.g. \r\n\r\n```\r\nhttp_archive(\r\n    name = \"grpc_java\",\r\n    sha256 = \"b4c9839b672213686ee9633a6089a913e50b1040d9f7486bd09d17032a2a90d3\",\r\n    strip_prefix = \"grpc-java-1.10.0\",\r\n    urls = [\r\n        \"https://github.com/grpc/grpc-java/archive/v1.10.0.zip\",\r\n    ],\r\n)\r\n```\r\n\r\nHowever, there's a convention to name a repository by reverse DNS, so something like `com_github_grpc_grpc_java` is more common.\r\n\r\nShould we change the statement in the `WORKSPACE` file to `com_github_grpc_grpc_java`?"},"comment":{"url":"https://api.github.com/repos/grpc/grpc-java/issues/comments/371156058","html_url":"https://github.com/grpc/grpc-java/issues/4095#issuecomment-371156058","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/4095","id":371156058,"user":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T14:31:22Z","updated_at":"2018-03-07T14:31:22Z","author_association":"MEMBER","body":":-/ it seems `io_grpc_java` is now \"the thing to do.\" We've not done a release yet with `io_grpc_grpc_java` and `io_grpc_java` is cleaner. So I've opened #4181 for tracking."}}
{"actor":{"display_login":"ejona86"}}