{"action":"created","comment":{"url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/comments/229448158","pull_request_review_id":169952146,"id":229448158,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQ0ODE1OA==","diff_hunk":"@@ -0,0 +1,48 @@\n+using System;\n+using UnityEngine;\n+using System.Collections.Generic;\n+\n+namespace JamCityID.ScriptableData\n+{\n+    [CreateAssetMenuAttribute(menuName = \"JamCityID/ScriptableData/Variable/String Evaluation\")]\n+    public class StringEvaluation : BoolVariable\n+    {\n+        public enum Condition { Same, NotSame }\n+\n+        private static Dictionary<Condition, Func<StringVariable, StringVariable, bool>> evaluateLookup;\n+\n+        static StringEvaluation()\n+        {\n+            evaluateLookup = new Dictionary<Condition, Func<StringVariable, StringVariable, bool>>();\n+            evaluateLookup[Condition.Same] = (left, right) => left.Value == right.Value;\n+            evaluateLookup[Condition.NotSame] = (left, right) => left.Value != right.Value;\n+        }\n+\n+        [SerializeField]\n+        private Condition condition;\n+\n+        [SerializeField]\n+        [Tooltip(\"Will force FALSE if any variables have a value of Null or Empty\")]\n+        private bool forceFalseOnEmpty;\n+\n+        [Header(\"Note: You must link Refresh() into OnChangedEvent in both variables\")]\n+        [SerializeField]\n+        private StringVariable leftVariable;\n+\n+        [SerializeField]\n+        private StringVariable rightVariable;\n+\n+        public void Refresh()\n+        {\n+            if(forceFalseOnEmpty &&\n+               (string.IsNullOrEmpty(leftVariable.Value) || string.IsNullOrEmpty(rightVariable.Value)))","path":"Assets/Plugins/Jamcity/JamCityID/Scripts/ScriptableData/LogicalObjects/StringEvaluation.cs","position":38,"original_position":38,"commit_id":"acc7d13d20a118785d5f69e4b2cbd10748a12900","original_commit_id":"b9c2c508bd326f69410e6568f7af0db6e67b51e2","user":{"login":"chrissJC","id":24231131,"node_id":"MDQ6VXNlcjI0MjMxMTMx","avatar_url":"https://avatars1.githubusercontent.com/u/24231131?v=4","gravatar_id":"","url":"https://api.github.com/users/chrissJC","html_url":"https://github.com/chrissJC","followers_url":"https://api.github.com/users/chrissJC/followers","following_url":"https://api.github.com/users/chrissJC/following{/other_user}","gists_url":"https://api.github.com/users/chrissJC/gists{/gist_id}","starred_url":"https://api.github.com/users/chrissJC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrissJC/subscriptions","organizations_url":"https://api.github.com/users/chrissJC/orgs","repos_url":"https://api.github.com/users/chrissJC/repos","events_url":"https://api.github.com/users/chrissJC/events{/privacy}","received_events_url":"https://api.github.com/users/chrissJC/received_events","type":"User","site_admin":false},"body":"Well, if they are null then it should explode, because that means serialization messed up somewhere, right?\r\n\r\nI guess my question was more \"why are we not considering `string.Empty == string.Empty` to be valid?\"","created_at":"2018-10-30T19:12:30Z","updated_at":"2018-10-30T19:12:30Z","html_url":"https://github.com/mindjolt/UnityJamCityID/pull/6#discussion_r229448158","pull_request_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/comments/229448158"},"html":{"href":"https://github.com/mindjolt/UnityJamCityID/pull/6#discussion_r229448158"},"pull_request":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6"}},"in_reply_to_id":229382081},"pull_request":{"url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6","id":226605444,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjA1NDQ0","html_url":"https://github.com/mindjolt/UnityJamCityID/pull/6","diff_url":"https://github.com/mindjolt/UnityJamCityID/pull/6.diff","patch_url":"https://github.com/mindjolt/UnityJamCityID/pull/6.patch","issue_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues/6","number":6,"state":"open","locked":false,"title":"Further Translation Support and other UI Work","user":{"login":"okariJC","id":26775391,"node_id":"MDQ6VXNlcjI2Nzc1Mzkx","avatar_url":"https://avatars1.githubusercontent.com/u/26775391?v=4","gravatar_id":"","url":"https://api.github.com/users/okariJC","html_url":"https://github.com/okariJC","followers_url":"https://api.github.com/users/okariJC/followers","following_url":"https://api.github.com/users/okariJC/following{/other_user}","gists_url":"https://api.github.com/users/okariJC/gists{/gist_id}","starred_url":"https://api.github.com/users/okariJC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okariJC/subscriptions","organizations_url":"https://api.github.com/users/okariJC/orgs","repos_url":"https://api.github.com/users/okariJC/repos","events_url":"https://api.github.com/users/okariJC/events{/privacy}","received_events_url":"https://api.github.com/users/okariJC/received_events","type":"User","site_admin":false},"body":"Some Classes not Completed, but wanted a current snap shot\r\n\r\nDepends on https://github.com/okariJC/UnityJamCityID/pull/1\r\nMerge above before merging this","created_at":"2018-10-29T15:29:49Z","updated_at":"2018-10-30T19:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6b02652ccceb55fa1d5f8325f01445b5292c6c3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danielcashsgn","id":18404394,"node_id":"MDQ6VXNlcjE4NDA0Mzk0","avatar_url":"https://avatars3.githubusercontent.com/u/18404394?v=4","gravatar_id":"","url":"https://api.github.com/users/danielcashsgn","html_url":"https://github.com/danielcashsgn","followers_url":"https://api.github.com/users/danielcashsgn/followers","following_url":"https://api.github.com/users/danielcashsgn/following{/other_user}","gists_url":"https://api.github.com/users/danielcashsgn/gists{/gist_id}","starred_url":"https://api.github.com/users/danielcashsgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielcashsgn/subscriptions","organizations_url":"https://api.github.com/users/danielcashsgn/orgs","repos_url":"https://api.github.com/users/danielcashsgn/repos","events_url":"https://api.github.com/users/danielcashsgn/events{/privacy}","received_events_url":"https://api.github.com/users/danielcashsgn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6/commits","review_comments_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6/comments","review_comment_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues/6/comments","statuses_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/statuses/acc7d13d20a118785d5f69e4b2cbd10748a12900","head":{"label":"okariJC:DevStyleUserInterface","ref":"DevStyleUserInterface","sha":"acc7d13d20a118785d5f69e4b2cbd10748a12900","user":{"login":"okariJC","id":26775391,"node_id":"MDQ6VXNlcjI2Nzc1Mzkx","avatar_url":"https://avatars1.githubusercontent.com/u/26775391?v=4","gravatar_id":"","url":"https://api.github.com/users/okariJC","html_url":"https://github.com/okariJC","followers_url":"https://api.github.com/users/okariJC/followers","following_url":"https://api.github.com/users/okariJC/following{/other_user}","gists_url":"https://api.github.com/users/okariJC/gists{/gist_id}","starred_url":"https://api.github.com/users/okariJC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okariJC/subscriptions","organizations_url":"https://api.github.com/users/okariJC/orgs","repos_url":"https://api.github.com/users/okariJC/repos","events_url":"https://api.github.com/users/okariJC/events{/privacy}","received_events_url":"https://api.github.com/users/okariJC/received_events","type":"User","site_admin":false},"repo":{"id":151140876,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExNDA4NzY=","name":"UnityJamCityID","full_name":"okariJC/UnityJamCityID","private":false,"owner":{"login":"okariJC","id":26775391,"node_id":"MDQ6VXNlcjI2Nzc1Mzkx","avatar_url":"https://avatars1.githubusercontent.com/u/26775391?v=4","gravatar_id":"","url":"https://api.github.com/users/okariJC","html_url":"https://github.com/okariJC","followers_url":"https://api.github.com/users/okariJC/followers","following_url":"https://api.github.com/users/okariJC/following{/other_user}","gists_url":"https://api.github.com/users/okariJC/gists{/gist_id}","starred_url":"https://api.github.com/users/okariJC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okariJC/subscriptions","organizations_url":"https://api.github.com/users/okariJC/orgs","repos_url":"https://api.github.com/users/okariJC/repos","events_url":"https://api.github.com/users/okariJC/events{/privacy}","received_events_url":"https://api.github.com/users/okariJC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/okariJC/UnityJamCityID","description":"Unity Integration of the Jam City ID. Will Export Packages","fork":true,"url":"https://api.github.com/repos/okariJC/UnityJamCityID","forks_url":"https://api.github.com/repos/okariJC/UnityJamCityID/forks","keys_url":"https://api.github.com/repos/okariJC/UnityJamCityID/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okariJC/UnityJamCityID/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okariJC/UnityJamCityID/teams","hooks_url":"https://api.github.com/repos/okariJC/UnityJamCityID/hooks","issue_events_url":"https://api.github.com/repos/okariJC/UnityJamCityID/issues/events{/number}","events_url":"https://api.github.com/repos/okariJC/UnityJamCityID/events","assignees_url":"https://api.github.com/repos/okariJC/UnityJamCityID/assignees{/user}","branches_url":"https://api.github.com/repos/okariJC/UnityJamCityID/branches{/branch}","tags_url":"https://api.github.com/repos/okariJC/UnityJamCityID/tags","blobs_url":"https://api.github.com/repos/okariJC/UnityJamCityID/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okariJC/UnityJamCityID/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okariJC/UnityJamCityID/git/refs{/sha}","trees_url":"https://api.github.com/repos/okariJC/UnityJamCityID/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okariJC/UnityJamCityID/statuses/{sha}","languages_url":"https://api.github.com/repos/okariJC/UnityJamCityID/languages","stargazers_url":"https://api.github.com/repos/okariJC/UnityJamCityID/stargazers","contributors_url":"https://api.github.com/repos/okariJC/UnityJamCityID/contributors","subscribers_url":"https://api.github.com/repos/okariJC/UnityJamCityID/subscribers","subscription_url":"https://api.github.com/repos/okariJC/UnityJamCityID/subscription","commits_url":"https://api.github.com/repos/okariJC/UnityJamCityID/commits{/sha}","git_commits_url":"https://api.github.com/repos/okariJC/UnityJamCityID/git/commits{/sha}","comments_url":"https://api.github.com/repos/okariJC/UnityJamCityID/comments{/number}","issue_comment_url":"https://api.github.com/repos/okariJC/UnityJamCityID/issues/comments{/number}","contents_url":"https://api.github.com/repos/okariJC/UnityJamCityID/contents/{+path}","compare_url":"https://api.github.com/repos/okariJC/UnityJamCityID/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okariJC/UnityJamCityID/merges","archive_url":"https://api.github.com/repos/okariJC/UnityJamCityID/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okariJC/UnityJamCityID/downloads","issues_url":"https://api.github.com/repos/okariJC/UnityJamCityID/issues{/number}","pulls_url":"https://api.github.com/repos/okariJC/UnityJamCityID/pulls{/number}","milestones_url":"https://api.github.com/repos/okariJC/UnityJamCityID/milestones{/number}","notifications_url":"https://api.github.com/repos/okariJC/UnityJamCityID/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okariJC/UnityJamCityID/labels{/name}","releases_url":"https://api.github.com/repos/okariJC/UnityJamCityID/releases{/id}","deployments_url":"https://api.github.com/repos/okariJC/UnityJamCityID/deployments","created_at":"2018-10-01T18:48:11Z","updated_at":"2018-10-02T16:30:34Z","pushed_at":"2018-10-30T18:40:01Z","git_url":"git://github.com/okariJC/UnityJamCityID.git","ssh_url":"git@github.com:okariJC/UnityJamCityID.git","clone_url":"https://github.com/okariJC/UnityJamCityID.git","svn_url":"https://github.com/okariJC/UnityJamCityID","homepage":null,"size":5949,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mindjolt:master","ref":"master","sha":"35833af0f7b240ca7a29854e018670b8ef3d551d","user":{"login":"mindjolt","id":838699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzODY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/838699?v=4","gravatar_id":"","url":"https://api.github.com/users/mindjolt","html_url":"https://github.com/mindjolt","followers_url":"https://api.github.com/users/mindjolt/followers","following_url":"https://api.github.com/users/mindjolt/following{/other_user}","gists_url":"https://api.github.com/users/mindjolt/gists{/gist_id}","starred_url":"https://api.github.com/users/mindjolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindjolt/subscriptions","organizations_url":"https://api.github.com/users/mindjolt/orgs","repos_url":"https://api.github.com/users/mindjolt/repos","events_url":"https://api.github.com/users/mindjolt/events{/privacy}","received_events_url":"https://api.github.com/users/mindjolt/received_events","type":"Organization","site_admin":false},"repo":{"id":151139671,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMzk2NzE=","name":"UnityJamCityID","full_name":"mindjolt/UnityJamCityID","private":false,"owner":{"login":"mindjolt","id":838699,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzODY5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/838699?v=4","gravatar_id":"","url":"https://api.github.com/users/mindjolt","html_url":"https://github.com/mindjolt","followers_url":"https://api.github.com/users/mindjolt/followers","following_url":"https://api.github.com/users/mindjolt/following{/other_user}","gists_url":"https://api.github.com/users/mindjolt/gists{/gist_id}","starred_url":"https://api.github.com/users/mindjolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindjolt/subscriptions","organizations_url":"https://api.github.com/users/mindjolt/orgs","repos_url":"https://api.github.com/users/mindjolt/repos","events_url":"https://api.github.com/users/mindjolt/events{/privacy}","received_events_url":"https://api.github.com/users/mindjolt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mindjolt/UnityJamCityID","description":"Unity Integration of the Jam City ID. Will Export Packages","fork":false,"url":"https://api.github.com/repos/mindjolt/UnityJamCityID","forks_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/forks","keys_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/teams","hooks_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/hooks","issue_events_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues/events{/number}","events_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/events","assignees_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/assignees{/user}","branches_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/branches{/branch}","tags_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/tags","blobs_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/git/refs{/sha}","trees_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/statuses/{sha}","languages_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/languages","stargazers_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/stargazers","contributors_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/contributors","subscribers_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/subscribers","subscription_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/subscription","commits_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/commits{/sha}","git_commits_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/git/commits{/sha}","comments_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/comments{/number}","issue_comment_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues/comments{/number}","contents_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/contents/{+path}","compare_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/merges","archive_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/downloads","issues_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues{/number}","pulls_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls{/number}","milestones_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/milestones{/number}","notifications_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/labels{/name}","releases_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/releases{/id}","deployments_url":"https://api.github.com/repos/mindjolt/UnityJamCityID/deployments","created_at":"2018-10-01T18:39:37Z","updated_at":"2018-10-24T14:16:33Z","pushed_at":"2018-10-30T18:40:04Z","git_url":"git://github.com/mindjolt/UnityJamCityID.git","ssh_url":"git@github.com:mindjolt/UnityJamCityID.git","clone_url":"https://github.com/mindjolt/UnityJamCityID.git","svn_url":"https://github.com/mindjolt/UnityJamCityID","homepage":null,"size":5879,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6"},"html":{"href":"https://github.com/mindjolt/UnityJamCityID/pull/6"},"issue":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues/6"},"comments":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/mindjolt/UnityJamCityID/statuses/acc7d13d20a118785d5f69e4b2cbd10748a12900"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chrissJC"}}