{"action":"created","issue":{"url":"https://api.github.com/repos/mono/mono/issues/7352","repository_url":"https://api.github.com/repos/mono/mono","labels_url":"https://api.github.com/repos/mono/mono/issues/7352/labels{/name}","comments_url":"https://api.github.com/repos/mono/mono/issues/7352/comments","events_url":"https://api.github.com/repos/mono/mono/issues/7352/events","html_url":"https://github.com/mono/mono/pull/7352","id":301216402,"number":7352,"title":"[sre] Use MonoClass getters in sre-save.c","user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars0.githubusercontent.com/u/480437?v=4","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-28T22:58:03Z","updated_at":"2018-03-01T22:40:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/7352","html_url":"https://github.com/mono/mono/pull/7352","diff_url":"https://github.com/mono/mono/pull/7352.diff","patch_url":"https://github.com/mono/mono/pull/7352.patch"},"body":"Mostly mechanical.\r\n\r\nThere was **ONE ISSUE**:\r\n\r\nIn `mono_image_fill_export_table` there's an assignment to `type_token`:\r\n```c\r\nklass->type_token = mono_metadata_make_token (MONO_TABLE_TYPEDEF, tb->table_idx);\r\n```\r\nhttps://github.com/mono/mono/blob/ddf4e7be31bf884cfe11cabbfcaff4ca839d0277/mono/metadata/sre-save.c#L1260-L1274\r\n\r\nI don't understand why that's there - Wouldn't the type token already be computed for every type builder by now? Why is it okay to change it?\r\n\r\n/attn @vargaz "},"comment":{"url":"https://api.github.com/repos/mono/mono/issues/comments/369756222","html_url":"https://github.com/mono/mono/pull/7352#issuecomment-369756222","issue_url":"https://api.github.com/repos/mono/mono/issues/7352","id":369756222,"user":{"login":"lambdageek","id":480437,"avatar_url":"https://avatars0.githubusercontent.com/u/480437?v=4","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T22:40:09Z","updated_at":"2018-03-01T22:40:09Z","author_association":"MEMBER","body":"Changed the `g_warning` to a `g_error`, let's see what happens."}}
{"actor":{"display_login":"lambdageek"}}