{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70848","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70848/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70848/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70848/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70848","id":379011290,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTc5NzA1","number":70848,"title":"Improve usability of CSI plugin metrics","user":{"login":"cofyc","id":91730,"node_id":"MDQ6VXNlcjkxNzMw","avatar_url":"https://avatars3.githubusercontent.com/u/91730?v=4","gravatar_id":"","url":"https://api.github.com/users/cofyc","html_url":"https://github.com/cofyc","followers_url":"https://api.github.com/users/cofyc/followers","following_url":"https://api.github.com/users/cofyc/following{/other_user}","gists_url":"https://api.github.com/users/cofyc/gists{/gist_id}","starred_url":"https://api.github.com/users/cofyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cofyc/subscriptions","organizations_url":"https://api.github.com/users/cofyc/orgs","repos_url":"https://api.github.com/users/cofyc/repos","events_url":"https://api.github.com/users/cofyc/events{/privacy}","received_events_url":"https://api.github.com/users/cofyc/received_events","type":"User","site_admin":false},"labels":[{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":267761362,"node_id":"MDU6TGFiZWwyNjc3NjEzNjI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-09T03:42:54Z","updated_at":"2018-11-09T03:57:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70848","html_url":"https://github.com/kubernetes/kubernetes/pull/70848","diff_url":"https://github.com/kubernetes/kubernetes/pull/70848.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70848.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\nhttps://git.k8s.io/community/contributors/devel/release.md#issue-kind-label\r\n3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/testing.md\r\n4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n5. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one, leave it on its own line:\r\n>\r\n> /kind api-change\r\n> /kind bug\r\n> /kind cleanup\r\n> /kind design\r\n> /kind documentation\r\n> /kind failing-test\r\n/kind feature\r\n> /kind flake\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAppend volume's driver at the end of plugin name to help distinguish different between metrics emitted for CSI volumes.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #64590\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/437242268","html_url":"https://github.com/kubernetes/kubernetes/pull/70848#issuecomment-437242268","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70848","id":437242268,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzI0MjI2OA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T03:57:22Z","updated_at":"2018-11-09T03:57:22Z","author_association":"CONTRIBUTOR","body":"@cofyc: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-build | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-bazel-build/64217/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-e2e-kops-aws | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-e2e-kops-aws/113050/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-bazel-test | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-bazel-test/66858/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-gce-device-plugin-gpu | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-e2e-gce-device-plugin-gpu/52795/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-gce | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-e2e-gce/59170/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-local-e2e-containerized | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-local-e2e-containerized/3358/) | `/test pull-kubernetes-local-e2e-containerized`\npull-kubernetes-kubemark-e2e-gce-big | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-kubemark-e2e-gce-big/28625/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-e2e-gce-100-performance | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-e2e-gce-100-performance/26220/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-typecheck | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-typecheck/31089/) | `/test pull-kubernetes-typecheck`\npull-kubernetes-integration | 72af6efed74a56c5b8b7814c4af62f518046b461 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70848/pull-kubernetes-integration/34680/) | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://gubernator.k8s.io/pr/70848). [Your PR dashboard](https://gubernator.k8s.io/pr/cofyc). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}