{"action":"created","issue":{"url":"https://api.github.com/repos/pennsignals/aptos/issues/17","repository_url":"https://api.github.com/repos/pennsignals/aptos","labels_url":"https://api.github.com/repos/pennsignals/aptos/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/pennsignals/aptos/issues/17/comments","events_url":"https://api.github.com/repos/pennsignals/aptos/issues/17/events","html_url":"https://github.com/pennsignals/aptos/pull/17","id":305197198,"number":17,"title":"additional schema keywords","user":{"login":"misja","id":36168,"avatar_url":"https://avatars0.githubusercontent.com/u/36168?v=4","gravatar_id":"","url":"https://api.github.com/users/misja","html_url":"https://github.com/misja","followers_url":"https://api.github.com/users/misja/followers","following_url":"https://api.github.com/users/misja/following{/other_user}","gists_url":"https://api.github.com/users/misja/gists{/gist_id}","starred_url":"https://api.github.com/users/misja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misja/subscriptions","organizations_url":"https://api.github.com/users/misja/orgs","repos_url":"https://api.github.com/users/misja/repos","events_url":"https://api.github.com/users/misja/events{/privacy}","received_events_url":"https://api.github.com/users/misja/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-14T15:02:37Z","updated_at":"2018-03-19T22:29:19Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pennsignals/aptos/pulls/17","html_url":"https://github.com/pennsignals/aptos/pull/17","diff_url":"https://github.com/pennsignals/aptos/pull/17.diff","patch_url":"https://github.com/pennsignals/aptos/pull/17.patch"},"body":"I really like the parsing approach this projects takes and whilst trying things I was missing some keywords. This pull adds the `format` keyword to primitives plus two additional string type keywords `contentEncoding` and `contentMediaType` which were recently [added](http://json-schema.org/latest/json-schema-validation.html#rfc.section.8). As for the `format` keyword, this doesn't require an implementation, I've added it in a way that it can be implemented by subclassing the validator."},"comment":{"url":"https://api.github.com/repos/pennsignals/aptos/issues/comments/374405378","html_url":"https://github.com/pennsignals/aptos/pull/17#issuecomment-374405378","issue_url":"https://api.github.com/repos/pennsignals/aptos/issues/17","id":374405378,"user":{"login":"jasonwalsh","id":2184329,"avatar_url":"https://avatars1.githubusercontent.com/u/2184329?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonwalsh","html_url":"https://github.com/jasonwalsh","followers_url":"https://api.github.com/users/jasonwalsh/followers","following_url":"https://api.github.com/users/jasonwalsh/following{/other_user}","gists_url":"https://api.github.com/users/jasonwalsh/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonwalsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonwalsh/subscriptions","organizations_url":"https://api.github.com/users/jasonwalsh/orgs","repos_url":"https://api.github.com/users/jasonwalsh/repos","events_url":"https://api.github.com/users/jasonwalsh/events{/privacy}","received_events_url":"https://api.github.com/users/jasonwalsh/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T22:29:19Z","updated_at":"2018-03-19T22:29:19Z","author_association":"OWNER","body":"Hey @misja \r\n\r\nThanks for your comment, that makes sense to me. I like the idea of implementing a mixin class for `Format` validation. I too agree that keyword arguments can lead to a messy solution and that it does not necessarily make sense to have a `validate` attribute for the `Format` class if the `ValidationVisitor` only uses it.\r\n\r\n> Another reason to keep the configuration limited to the validating visitor is because it would make no sense in a transforming visitor e.g. when creating Avro or Thrift schemas where the format keyword would be more useful as a type hint.\r\n\r\nYes, I totally agree with this.\r\n\r\nThanks again!"}}
{"actor":{"display_login":"jasonwalsh"}}