{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/215618099","pull_request_review_id":152920515,"id":215618099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTYxODA5OQ==","diff_hunk":"@@ -541,7 +541,19 @@ func (c *Controller) GetIstioServiceAccounts(hostname model.Hostname, ports []in\n // AppendServiceHandler implements a service catalog operation\n func (c *Controller) AppendServiceHandler(f func(*model.Service, model.Event)) error {\n \tc.services.handler.Append(func(obj interface{}, event model.Event) error {\n-\t\tsvc := *obj.(*v1.Service)\n+\t\tsvc, ok := obj.(*v1.Service)\n+\t\tif !ok {\n+\t\t\ttombstone, ok := obj.(cache.DeletedFinalStateUnknown)\n+\t\t\tif !ok {\n+\t\t\t\tlog.Errorf(\"Couldn't get object from tombstone %#v\", obj)\n+\t\t\t\treturn nil","path":"pilot/pkg/serviceregistry/kube/controller.go","position":10,"original_position":10,"commit_id":"a38d4026508f54e1976d622113b3cee6f9ac5732","original_commit_id":"a38d4026508f54e1976d622113b3cee6f9ac5732","user":{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"Do we need to log this? Too much noise ?","created_at":"2018-09-06T13:09:17Z","updated_at":"2018-09-06T13:10:06Z","html_url":"https://github.com/istio/istio/pull/8517#discussion_r215618099","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/8517","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/215618099"},"html":{"href":"https://github.com/istio/istio/pull/8517#discussion_r215618099"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/8517"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8517","id":213514841,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTE0ODQx","html_url":"https://github.com/istio/istio/pull/8517","diff_url":"https://github.com/istio/istio/pull/8517.diff","patch_url":"https://github.com/istio/istio/pull/8517.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/8517","number":8517,"state":"open","locked":false,"title":"pilot: clusterregistry cleanup and fix","user":{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"body":"1. remove RemoteCluster.client\r\n\r\n1. handle DeletedFinalStateUnknown type to prevent type cast panic in kubernetes service registry.","created_at":"2018-09-06T07:04:59Z","updated_at":"2018-09-06T13:10:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d93d87955d5e607998f0c8f11e1daa22e559f63","assignee":{"login":"baodongli","id":3081257,"node_id":"MDQ6VXNlcjMwODEyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3081257?v=4","gravatar_id":"","url":"https://api.github.com/users/baodongli","html_url":"https://github.com/baodongli","followers_url":"https://api.github.com/users/baodongli/followers","following_url":"https://api.github.com/users/baodongli/following{/other_user}","gists_url":"https://api.github.com/users/baodongli/gists{/gist_id}","starred_url":"https://api.github.com/users/baodongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baodongli/subscriptions","organizations_url":"https://api.github.com/users/baodongli/orgs","repos_url":"https://api.github.com/users/baodongli/repos","events_url":"https://api.github.com/users/baodongli/events{/privacy}","received_events_url":"https://api.github.com/users/baodongli/received_events","type":"User","site_admin":false},"assignees":[{"login":"baodongli","id":3081257,"node_id":"MDQ6VXNlcjMwODEyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3081257?v=4","gravatar_id":"","url":"https://api.github.com/users/baodongli","html_url":"https://github.com/baodongli","followers_url":"https://api.github.com/users/baodongli/followers","following_url":"https://api.github.com/users/baodongli/following{/other_user}","gists_url":"https://api.github.com/users/baodongli/gists{/gist_id}","starred_url":"https://api.github.com/users/baodongli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baodongli/subscriptions","organizations_url":"https://api.github.com/users/baodongli/orgs","repos_url":"https://api.github.com/users/baodongli/repos","events_url":"https://api.github.com/users/baodongli/events{/privacy}","received_events_url":"https://api.github.com/users/baodongli/received_events","type":"User","site_admin":false},{"login":"rshriram","id":8202871,"node_id":"MDQ6VXNlcjgyMDI4NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nmittler","id":6493296,"node_id":"MDQ6VXNlcjY0OTMyOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},{"login":"kyessenov","id":9537734,"node_id":"MDQ6VXNlcjk1Mzc3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/8517/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/8517/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/8517/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/a38d4026508f54e1976d622113b3cee6f9ac5732","head":{"label":"hzxuzhonghu:secret-ctrl-cleanup","ref":"secret-ctrl-cleanup","sha":"a38d4026508f54e1976d622113b3cee6f9ac5732","user":{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"repo":{"id":139953100,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5NTMxMDA=","name":"istio","full_name":"hzxuzhonghu/istio","owner":{"login":"hzxuzhonghu","id":13374016,"node_id":"MDQ6VXNlcjEzMzc0MDE2","avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzxuzhonghu/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/hzxuzhonghu/istio","forks_url":"https://api.github.com/repos/hzxuzhonghu/istio/forks","keys_url":"https://api.github.com/repos/hzxuzhonghu/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzxuzhonghu/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzxuzhonghu/istio/teams","hooks_url":"https://api.github.com/repos/hzxuzhonghu/istio/hooks","issue_events_url":"https://api.github.com/repos/hzxuzhonghu/istio/issues/events{/number}","events_url":"https://api.github.com/repos/hzxuzhonghu/istio/events","assignees_url":"https://api.github.com/repos/hzxuzhonghu/istio/assignees{/user}","branches_url":"https://api.github.com/repos/hzxuzhonghu/istio/branches{/branch}","tags_url":"https://api.github.com/repos/hzxuzhonghu/istio/tags","blobs_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzxuzhonghu/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/hzxuzhonghu/istio/languages","stargazers_url":"https://api.github.com/repos/hzxuzhonghu/istio/stargazers","contributors_url":"https://api.github.com/repos/hzxuzhonghu/istio/contributors","subscribers_url":"https://api.github.com/repos/hzxuzhonghu/istio/subscribers","subscription_url":"https://api.github.com/repos/hzxuzhonghu/istio/subscription","commits_url":"https://api.github.com/repos/hzxuzhonghu/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzxuzhonghu/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzxuzhonghu/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzxuzhonghu/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/hzxuzhonghu/istio/contents/{+path}","compare_url":"https://api.github.com/repos/hzxuzhonghu/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzxuzhonghu/istio/merges","archive_url":"https://api.github.com/repos/hzxuzhonghu/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzxuzhonghu/istio/downloads","issues_url":"https://api.github.com/repos/hzxuzhonghu/istio/issues{/number}","pulls_url":"https://api.github.com/repos/hzxuzhonghu/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/hzxuzhonghu/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/hzxuzhonghu/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzxuzhonghu/istio/labels{/name}","releases_url":"https://api.github.com/repos/hzxuzhonghu/istio/releases{/id}","deployments_url":"https://api.github.com/repos/hzxuzhonghu/istio/deployments","created_at":"2018-07-06T08:03:09Z","updated_at":"2018-09-06T01:50:52Z","pushed_at":"2018-09-06T12:11:47Z","git_url":"git://github.com/hzxuzhonghu/istio.git","ssh_url":"git@github.com:hzxuzhonghu/istio.git","clone_url":"https://github.com/hzxuzhonghu/istio.git","svn_url":"https://github.com/hzxuzhonghu/istio","homepage":"https://istio.io","size":47064,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"82f632c242f8b247392e990d662f6300edb99ef4","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-09-06T12:57:51Z","pushed_at":"2018-09-06T12:13:52Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":47838,"stargazers_count":11448,"watchers_count":11448,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1666,"mirror_url":null,"archived":false,"open_issues_count":888,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1666,"open_issues":888,"watchers":11448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/8517"},"html":{"href":"https://github.com/istio/istio/pull/8517"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/8517"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/8517/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/8517/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/8517/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/a38d4026508f54e1976d622113b3cee6f9ac5732"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rshriram"}}