{"action":"created","comment":{"url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/comments/190832304","pull_request_review_id":123293525,"id":190832304,"diff_hunk":"@@ -9,6 +9,7 @@\n # ------------------------------------------------------------------------------\n \n SPACESHIP_NODE_SHOW=\"${SPACESHIP_NODE_SHOW=true}\"\n+SPACESHIP_NODE_SHOW_IN_HOME=\"${SPACESHIP_NODE_SHOW_IN_HOME=true}\"","path":"sections/node.zsh","position":4,"original_position":4,"commit_id":"44c2c2ab5a0e9fba96434c5f9afbc8a483d9bc92","original_commit_id":"44c2c2ab5a0e9fba96434c5f9afbc8a483d9bc92","user":{"login":"maximbaz","id":1177900,"avatar_url":"https://avatars2.githubusercontent.com/u/1177900?v=4","gravatar_id":"","url":"https://api.github.com/users/maximbaz","html_url":"https://github.com/maximbaz","followers_url":"https://api.github.com/users/maximbaz/followers","following_url":"https://api.github.com/users/maximbaz/following{/other_user}","gists_url":"https://api.github.com/users/maximbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/maximbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximbaz/subscriptions","organizations_url":"https://api.github.com/users/maximbaz/orgs","repos_url":"https://api.github.com/users/maximbaz/repos","events_url":"https://api.github.com/users/maximbaz/events{/privacy}","received_events_url":"https://api.github.com/users/maximbaz/received_events","type":"User","site_admin":false},"body":"Looking at the discussion in the referenced bug I wonder if this option should be `false` by default, or should it even exist - can you think of an example where someone would _want_ to see the version in $HOME dir?","created_at":"2018-05-25T08:59:46Z","updated_at":"2018-05-25T08:59:47Z","html_url":"https://github.com/denysdovhan/spaceship-prompt/pull/453#discussion_r190832304","pull_request_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/comments/190832304"},"html":{"href":"https://github.com/denysdovhan/spaceship-prompt/pull/453#discussion_r190832304"},"pull_request":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453"}}},"pull_request":{"url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453","id":190497375,"html_url":"https://github.com/denysdovhan/spaceship-prompt/pull/453","diff_url":"https://github.com/denysdovhan/spaceship-prompt/pull/453.diff","patch_url":"https://github.com/denysdovhan/spaceship-prompt/pull/453.patch","issue_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues/453","number":453,"state":"open","locked":false,"title":"Added option to hide NodeJS status on HOME dir","user":{"login":"clasick","id":13066221,"avatar_url":"https://avatars1.githubusercontent.com/u/13066221?v=4","gravatar_id":"","url":"https://api.github.com/users/clasick","html_url":"https://github.com/clasick","followers_url":"https://api.github.com/users/clasick/followers","following_url":"https://api.github.com/users/clasick/following{/other_user}","gists_url":"https://api.github.com/users/clasick/gists{/gist_id}","starred_url":"https://api.github.com/users/clasick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clasick/subscriptions","organizations_url":"https://api.github.com/users/clasick/orgs","repos_url":"https://api.github.com/users/clasick/repos","events_url":"https://api.github.com/users/clasick/events{/privacy}","received_events_url":"https://api.github.com/users/clasick/received_events","type":"User","site_admin":false},"body":"#### Description\r\n\r\nNodeJS automatically keeps `node_modules` directory in `$HOME`. This ends up with the terminal showing NodeJS status similar to `via ⬢ v6.10.3` on a default prompt (see #167).\r\n\r\nI added an option to check if the current directory is `$HOME` and if it is, hide the node status. Then an option toggle variable was added which is usable from `~/.zshrc` user configs.\r\n\r\nThe relevant config option is now `SPACESHIP_NODE_SHOW_IN_HOME` which is `true` by default.\r\n#### Screenshot\r\n\r\nBefore (default)\r\n![screenshot](https://i.imgur.com/NCZyJMj.png)\r\n\r\nAfter (`SPACESHIP_NODE_SHOW_IN_HOME=false`)\r\n![screenshot](https://i.imgur.com/ib6gHcc.png)","created_at":"2018-05-25T06:57:32Z","updated_at":"2018-05-25T08:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f900ae7608e5b1cc7b54753d3e818f31a504c2cb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453/commits","review_comments_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453/comments","review_comment_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues/453/comments","statuses_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/statuses/44c2c2ab5a0e9fba96434c5f9afbc8a483d9bc92","head":{"label":"clasick:nodejs-on-home","ref":"nodejs-on-home","sha":"44c2c2ab5a0e9fba96434c5f9afbc8a483d9bc92","user":{"login":"clasick","id":13066221,"avatar_url":"https://avatars1.githubusercontent.com/u/13066221?v=4","gravatar_id":"","url":"https://api.github.com/users/clasick","html_url":"https://github.com/clasick","followers_url":"https://api.github.com/users/clasick/followers","following_url":"https://api.github.com/users/clasick/following{/other_user}","gists_url":"https://api.github.com/users/clasick/gists{/gist_id}","starred_url":"https://api.github.com/users/clasick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clasick/subscriptions","organizations_url":"https://api.github.com/users/clasick/orgs","repos_url":"https://api.github.com/users/clasick/repos","events_url":"https://api.github.com/users/clasick/events{/privacy}","received_events_url":"https://api.github.com/users/clasick/received_events","type":"User","site_admin":false},"repo":{"id":134814388,"name":"spaceship-prompt","full_name":"clasick/spaceship-prompt","owner":{"login":"clasick","id":13066221,"avatar_url":"https://avatars1.githubusercontent.com/u/13066221?v=4","gravatar_id":"","url":"https://api.github.com/users/clasick","html_url":"https://github.com/clasick","followers_url":"https://api.github.com/users/clasick/followers","following_url":"https://api.github.com/users/clasick/following{/other_user}","gists_url":"https://api.github.com/users/clasick/gists{/gist_id}","starred_url":"https://api.github.com/users/clasick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clasick/subscriptions","organizations_url":"https://api.github.com/users/clasick/orgs","repos_url":"https://api.github.com/users/clasick/repos","events_url":"https://api.github.com/users/clasick/events{/privacy}","received_events_url":"https://api.github.com/users/clasick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clasick/spaceship-prompt","description":":rocket::star: A Zsh prompt for Astronauts","fork":true,"url":"https://api.github.com/repos/clasick/spaceship-prompt","forks_url":"https://api.github.com/repos/clasick/spaceship-prompt/forks","keys_url":"https://api.github.com/repos/clasick/spaceship-prompt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clasick/spaceship-prompt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clasick/spaceship-prompt/teams","hooks_url":"https://api.github.com/repos/clasick/spaceship-prompt/hooks","issue_events_url":"https://api.github.com/repos/clasick/spaceship-prompt/issues/events{/number}","events_url":"https://api.github.com/repos/clasick/spaceship-prompt/events","assignees_url":"https://api.github.com/repos/clasick/spaceship-prompt/assignees{/user}","branches_url":"https://api.github.com/repos/clasick/spaceship-prompt/branches{/branch}","tags_url":"https://api.github.com/repos/clasick/spaceship-prompt/tags","blobs_url":"https://api.github.com/repos/clasick/spaceship-prompt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clasick/spaceship-prompt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clasick/spaceship-prompt/git/refs{/sha}","trees_url":"https://api.github.com/repos/clasick/spaceship-prompt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clasick/spaceship-prompt/statuses/{sha}","languages_url":"https://api.github.com/repos/clasick/spaceship-prompt/languages","stargazers_url":"https://api.github.com/repos/clasick/spaceship-prompt/stargazers","contributors_url":"https://api.github.com/repos/clasick/spaceship-prompt/contributors","subscribers_url":"https://api.github.com/repos/clasick/spaceship-prompt/subscribers","subscription_url":"https://api.github.com/repos/clasick/spaceship-prompt/subscription","commits_url":"https://api.github.com/repos/clasick/spaceship-prompt/commits{/sha}","git_commits_url":"https://api.github.com/repos/clasick/spaceship-prompt/git/commits{/sha}","comments_url":"https://api.github.com/repos/clasick/spaceship-prompt/comments{/number}","issue_comment_url":"https://api.github.com/repos/clasick/spaceship-prompt/issues/comments{/number}","contents_url":"https://api.github.com/repos/clasick/spaceship-prompt/contents/{+path}","compare_url":"https://api.github.com/repos/clasick/spaceship-prompt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clasick/spaceship-prompt/merges","archive_url":"https://api.github.com/repos/clasick/spaceship-prompt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clasick/spaceship-prompt/downloads","issues_url":"https://api.github.com/repos/clasick/spaceship-prompt/issues{/number}","pulls_url":"https://api.github.com/repos/clasick/spaceship-prompt/pulls{/number}","milestones_url":"https://api.github.com/repos/clasick/spaceship-prompt/milestones{/number}","notifications_url":"https://api.github.com/repos/clasick/spaceship-prompt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clasick/spaceship-prompt/labels{/name}","releases_url":"https://api.github.com/repos/clasick/spaceship-prompt/releases{/id}","deployments_url":"https://api.github.com/repos/clasick/spaceship-prompt/deployments","created_at":"2018-05-25T06:41:06Z","updated_at":"2018-05-25T06:41:08Z","pushed_at":"2018-05-25T06:56:15Z","git_url":"git://github.com/clasick/spaceship-prompt.git","ssh_url":"git@github.com:clasick/spaceship-prompt.git","clone_url":"https://github.com/clasick/spaceship-prompt.git","svn_url":"https://github.com/clasick/spaceship-prompt","homepage":"https://denysdovhan.com/spaceship-prompt/","size":6946,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"denysdovhan:master","ref":"master","sha":"4b5d69e7c7e3cb9ebd2353e68689732331c056cc","user":{"login":"denysdovhan","id":3459374,"avatar_url":"https://avatars1.githubusercontent.com/u/3459374?v=4","gravatar_id":"","url":"https://api.github.com/users/denysdovhan","html_url":"https://github.com/denysdovhan","followers_url":"https://api.github.com/users/denysdovhan/followers","following_url":"https://api.github.com/users/denysdovhan/following{/other_user}","gists_url":"https://api.github.com/users/denysdovhan/gists{/gist_id}","starred_url":"https://api.github.com/users/denysdovhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denysdovhan/subscriptions","organizations_url":"https://api.github.com/users/denysdovhan/orgs","repos_url":"https://api.github.com/users/denysdovhan/repos","events_url":"https://api.github.com/users/denysdovhan/events{/privacy}","received_events_url":"https://api.github.com/users/denysdovhan/received_events","type":"User","site_admin":false},"repo":{"id":50726688,"name":"spaceship-prompt","full_name":"denysdovhan/spaceship-prompt","owner":{"login":"denysdovhan","id":3459374,"avatar_url":"https://avatars1.githubusercontent.com/u/3459374?v=4","gravatar_id":"","url":"https://api.github.com/users/denysdovhan","html_url":"https://github.com/denysdovhan","followers_url":"https://api.github.com/users/denysdovhan/followers","following_url":"https://api.github.com/users/denysdovhan/following{/other_user}","gists_url":"https://api.github.com/users/denysdovhan/gists{/gist_id}","starred_url":"https://api.github.com/users/denysdovhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denysdovhan/subscriptions","organizations_url":"https://api.github.com/users/denysdovhan/orgs","repos_url":"https://api.github.com/users/denysdovhan/repos","events_url":"https://api.github.com/users/denysdovhan/events{/privacy}","received_events_url":"https://api.github.com/users/denysdovhan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/denysdovhan/spaceship-prompt","description":":rocket::star: A Zsh prompt for Astronauts","fork":false,"url":"https://api.github.com/repos/denysdovhan/spaceship-prompt","forks_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/forks","keys_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/teams","hooks_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/hooks","issue_events_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues/events{/number}","events_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/events","assignees_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/assignees{/user}","branches_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/branches{/branch}","tags_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/tags","blobs_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/git/refs{/sha}","trees_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/statuses/{sha}","languages_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/languages","stargazers_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/stargazers","contributors_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/contributors","subscribers_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/subscribers","subscription_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/subscription","commits_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/commits{/sha}","git_commits_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/git/commits{/sha}","comments_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/comments{/number}","issue_comment_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues/comments{/number}","contents_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/contents/{+path}","compare_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/merges","archive_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/downloads","issues_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues{/number}","pulls_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls{/number}","milestones_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/milestones{/number}","notifications_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/labels{/name}","releases_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/releases{/id}","deployments_url":"https://api.github.com/repos/denysdovhan/spaceship-prompt/deployments","created_at":"2016-01-30T13:50:02Z","updated_at":"2018-05-25T08:14:51Z","pushed_at":"2018-05-25T08:52:34Z","git_url":"git://github.com/denysdovhan/spaceship-prompt.git","ssh_url":"git@github.com:denysdovhan/spaceship-prompt.git","clone_url":"https://github.com/denysdovhan/spaceship-prompt.git","svn_url":"https://github.com/denysdovhan/spaceship-prompt","homepage":"https://denysdovhan.com/spaceship-prompt/","size":6946,"stargazers_count":3689,"watchers_count":3689,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":276,"open_issues":67,"watchers":3689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453"},"html":{"href":"https://github.com/denysdovhan/spaceship-prompt/pull/453"},"issue":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues/453"},"comments":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/denysdovhan/spaceship-prompt/statuses/44c2c2ab5a0e9fba96434c5f9afbc8a483d9bc92"}},"author_association":"NONE"}}
{"actor":{"display_login":"maximbaz"}}