{"action":"created","issue":{"url":"https://api.github.com/repos/material-components/material-components-web-react/issues/592","repository_url":"https://api.github.com/repos/material-components/material-components-web-react","labels_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/592/labels{/name}","comments_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/592/comments","events_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/592/events","html_url":"https://github.com/material-components/material-components-web-react/pull/592","id":395796721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTY1OTkz","number":592,"title":"fix(ripple): Adds HTMLElement shim to fix regression for SSR projects","user":{"login":"4cm4k1","id":15058720,"node_id":"MDQ6VXNlcjE1MDU4NzIw","avatar_url":"https://avatars2.githubusercontent.com/u/15058720?v=4","gravatar_id":"","url":"https://api.github.com/users/4cm4k1","html_url":"https://github.com/4cm4k1","followers_url":"https://api.github.com/users/4cm4k1/followers","following_url":"https://api.github.com/users/4cm4k1/following{/other_user}","gists_url":"https://api.github.com/users/4cm4k1/gists{/gist_id}","starred_url":"https://api.github.com/users/4cm4k1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4cm4k1/subscriptions","organizations_url":"https://api.github.com/users/4cm4k1/orgs","repos_url":"https://api.github.com/users/4cm4k1/repos","events_url":"https://api.github.com/users/4cm4k1/events{/privacy}","received_events_url":"https://api.github.com/users/4cm4k1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2019-01-04T03:16:33Z","updated_at":"2019-01-04T19:19:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web-react/pulls/592","html_url":"https://github.com/material-components/material-components-web-react/pull/592","diff_url":"https://github.com/material-components/material-components-web-react/pull/592.diff","patch_url":"https://github.com/material-components/material-components-web-react/pull/592.patch"},"body":"This PR fixes #581.\r\n\r\nI did not write any tests, as writing tests for SSR use cases is under consideration at #588.\r\n\r\nThe compiled result of the changed code is as follows, which should fix the regression seen in SSR projects:\r\n```js\r\nvar HTMLElementShim = typeof HTMLElement === 'undefined' ? { } : HTMLElement;\r\nvar MATCHES = mdc_ripple_1.util.getMatchesProperty(HTMLElementShim.prototype);\r\n```\r\n\r\nI’m relatively new to writing TypeScript, so please let me know if `any` as a type should be changed.\r\n\r\nWarm regards,\r\nAnthony"},"comment":{"url":"https://api.github.com/repos/material-components/material-components-web-react/issues/comments/451541157","html_url":"https://github.com/material-components/material-components-web-react/pull/592#issuecomment-451541157","issue_url":"https://api.github.com/repos/material-components/material-components-web-react/issues/592","id":451541157,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTU0MTE1Nw==","user":{"login":"moog16","id":579873,"node_id":"MDQ6VXNlcjU3OTg3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/579873?v=4","gravatar_id":"","url":"https://api.github.com/users/moog16","html_url":"https://github.com/moog16","followers_url":"https://api.github.com/users/moog16/followers","following_url":"https://api.github.com/users/moog16/following{/other_user}","gists_url":"https://api.github.com/users/moog16/gists{/gist_id}","starred_url":"https://api.github.com/users/moog16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moog16/subscriptions","organizations_url":"https://api.github.com/users/moog16/orgs","repos_url":"https://api.github.com/users/moog16/repos","events_url":"https://api.github.com/users/moog16/events{/privacy}","received_events_url":"https://api.github.com/users/moog16/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T19:19:10Z","updated_at":"2019-01-04T19:19:10Z","author_association":"CONTRIBUTOR","body":"Thanks! merging :)"}}
{"actor":{"display_login":"moog16"}}