{"action":"created","issue":{"url":"https://api.github.com/repos/ory/fosite/issues/336","repository_url":"https://api.github.com/repos/ory/fosite","labels_url":"https://api.github.com/repos/ory/fosite/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/ory/fosite/issues/336/comments","events_url":"https://api.github.com/repos/ory/fosite/issues/336/events","html_url":"https://github.com/ory/fosite/pull/336","id":380967051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDQzOTcx","number":336,"title":"should grant scope for client credentials grant","user":{"login":"nerocrux","id":452535,"node_id":"MDQ6VXNlcjQ1MjUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/452535?v=4","gravatar_id":"","url":"https://api.github.com/users/nerocrux","html_url":"https://github.com/nerocrux","followers_url":"https://api.github.com/users/nerocrux/followers","following_url":"https://api.github.com/users/nerocrux/following{/other_user}","gists_url":"https://api.github.com/users/nerocrux/gists{/gist_id}","starred_url":"https://api.github.com/users/nerocrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerocrux/subscriptions","organizations_url":"https://api.github.com/users/nerocrux/orgs","repos_url":"https://api.github.com/users/nerocrux/repos","events_url":"https://api.github.com/users/nerocrux/events{/privacy}","received_events_url":"https://api.github.com/users/nerocrux/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-15T02:02:39Z","updated_at":"2018-11-16T02:33:45Z","closed_at":"2018-11-15T17:50:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ory/fosite/pulls/336","html_url":"https://github.com/ory/fosite/pull/336","diff_url":"https://github.com/ory/fosite/pull/336.diff","patch_url":"https://github.com/ory/fosite/pull/336.patch"},"body":"Signed-off-by: nerocrux <nerocrux@gmail.com>\r\n\r\n## Related issue\r\n\r\n<!--\r\nPlease link the GitHub issue this pull request resolves in the format of `#1234`. If you discussed this change\r\nwith a maintainer, please mention her/him using the `@` syntax (e.g. `@aeneasr`).\r\n\r\nIf this change neither resolves an existing issue nor has sign-off from one of the maintainers, there is a\r\nchance substantial changes will be requested or that the changes will be rejected.\r\n\r\nYou can discuss changes with maintainers either in the [ORY Community Forums](https://community.ory.sh/) or\r\njoin the [ORY Chat](https://www.ory.sh/chat).\r\n-->\r\n\r\nNone.\r\n\r\n## Proposed changes\r\n\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.\r\n-->\r\n\r\nI found out that when using client credentials grant, `scope` field in response is always empty.\r\nI think we should set `scope` for this grant too.\r\nYou can check the sample before/after requests below.\r\n\r\n### before\r\n\r\n![2018-11-15 11 00 49](https://user-images.githubusercontent.com/452535/48524985-bbb1e780-e8c5-11e8-960f-8c287f9e095c.png)\r\n\r\n### after\r\n\r\n![2018-11-15 10 59 42](https://user-images.githubusercontent.com/452535/48524943-94f3b100-e8c5-11e8-8489-c4419a5d2495.png)\r\n\r\n## Checklist\r\n\r\n<!--\r\nPut an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of\r\nthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.\r\n-->\r\n\r\n- [x] I have read the [contributing guidelines](CONTRIBUTING.md)\r\n- [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security\r\nvulnerability, I confirm that I got green light (please contact [hi@ory.sh](mailto:hi@ory.sh)) from the maintainers to push the changes.\r\n- [x] I signed the [Developer's Certificate of Origin](https://github.com/ory/keto/blob/master/CONTRIBUTING.md#developers-certificate-of-origin)\r\nby signing my commit(s). You can amend your signature to the most recent commit by using `git commit --amend -s`. If you\r\namend the commit, you might need to force push using `git push --force HEAD:<branch>`. Please be very careful when using\r\nforce push.\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation within the code base (if appropriate)\r\n\r\n## Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution\r\nyou did and what alternatives you considered, etc...\r\n-->\r\n\r\nNone."},"comment":{"url":"https://api.github.com/repos/ory/fosite/issues/comments/439261572","html_url":"https://github.com/ory/fosite/pull/336#issuecomment-439261572","issue_url":"https://api.github.com/repos/ory/fosite/issues/336","id":439261572,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTI2MTU3Mg==","user":{"login":"nerocrux","id":452535,"node_id":"MDQ6VXNlcjQ1MjUzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/452535?v=4","gravatar_id":"","url":"https://api.github.com/users/nerocrux","html_url":"https://github.com/nerocrux","followers_url":"https://api.github.com/users/nerocrux/followers","following_url":"https://api.github.com/users/nerocrux/following{/other_user}","gists_url":"https://api.github.com/users/nerocrux/gists{/gist_id}","starred_url":"https://api.github.com/users/nerocrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerocrux/subscriptions","organizations_url":"https://api.github.com/users/nerocrux/orgs","repos_url":"https://api.github.com/users/nerocrux/repos","events_url":"https://api.github.com/users/nerocrux/events{/privacy}","received_events_url":"https://api.github.com/users/nerocrux/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T02:33:45Z","updated_at":"2018-11-16T02:33:45Z","author_association":"CONTRIBUTOR","body":"@aeneasr Thank you for explaining!"}}
{"actor":{"display_login":"nerocrux"}}