{"action":"created","issue":{"url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection/issues/24","repository_url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection","labels_url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection/issues/24/comments","events_url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection/issues/24/events","html_url":"https://github.com/sandeepmistry/node-xpc-connection/issues/24","id":319656213,"node_id":"MDU6SXNzdWUzMTk2NTYyMTM=","number":24,"title":"Module installation fails on Mac (macOS 10.13.4) after upgrade to node v10.0.0 and npm v6.0.0","user":{"login":"mailgpa","id":1557268,"node_id":"MDQ6VXNlcjE1NTcyNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1557268?v=4","gravatar_id":"","url":"https://api.github.com/users/mailgpa","html_url":"https://github.com/mailgpa","followers_url":"https://api.github.com/users/mailgpa/followers","following_url":"https://api.github.com/users/mailgpa/following{/other_user}","gists_url":"https://api.github.com/users/mailgpa/gists{/gist_id}","starred_url":"https://api.github.com/users/mailgpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mailgpa/subscriptions","organizations_url":"https://api.github.com/users/mailgpa/orgs","repos_url":"https://api.github.com/users/mailgpa/repos","events_url":"https://api.github.com/users/mailgpa/events{/privacy}","received_events_url":"https://api.github.com/users/mailgpa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-05-02T18:07:23Z","updated_at":"2018-09-06T23:40:09Z","closed_at":null,"author_association":"NONE","body":"Module installation fails on Mac (macOS 10.13.4) after upgrade to node v10.0.0 and npm v6.0.0\r\n\r\n```\r\n$ echo $PATH\r\n/usr/local/opt/llvm/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/opt/X11/bin:/Applications/Server.app/Contents/ServerRoot/usr/bin:/Applications/Server.app/Contents/ServerRoot/usr/sbin\r\n```\r\n\r\nManipulations with PATH (as mentioned in #2) do not help\r\n\r\n```\r\n$ npm i -g xpc-connection\r\n\r\n> xpc-connection@0.1.4 install /usr/local/lib/node_modules/xpc-connection\r\n> node-gyp rebuild\r\n\r\n  CXX(target) Release/obj.target/binding/src/XpcConnection.o\r\n../src/XpcConnection.cpp:143:89: error: too few arguments to function call, expected 2, have 1\r\n      Local<Value> propertyValue = object->GetRealNamedProperty(propertyName->ToString());\r\n                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~                         ^\r\n/Users/gpa/.node-gyp/10.0.0/include/node/v8.h:3428:3: note: 'GetRealNamedProperty' declared here\r\n  V8_WARN_UNUSED_RESULT MaybeLocal<Value> GetRealNamedProperty(\r\n  ^\r\n/Users/gpa/.node-gyp/10.0.0/include/node/v8config.h:410:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'\r\n#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))\r\n                              ^\r\n../src/XpcConnection.cpp:254:12: warning: 'MakeCallback' is deprecated [-Wdeprecated-declarations]\r\n      Nan::MakeCallback(Nan::New<Object>(this->This), Nan::New(\"emit\").ToLocalChecked(), 2, argv);\r\n           ^\r\n../node_modules/nan/nan.h:950:3: note: 'MakeCallback' has been explicitly marked deprecated here\r\n  NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(\r\n  ^\r\n../node_modules/nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'\r\n# define NAN_DEPRECATED __attribute__((deprecated))\r\n                                       ^\r\n../src/XpcConnection.cpp:263:12: warning: 'MakeCallback' is deprecated [-Wdeprecated-declarations]\r\n      Nan::MakeCallback(Nan::New<Object>(this->This), Nan::New(\"emit\").ToLocalChecked(), 2, argv);\r\n           ^\r\n../node_modules/nan/nan.h:950:3: note: 'MakeCallback' has been explicitly marked deprecated here\r\n  NAN_DEPRECATED inline v8::Local<v8::Value> MakeCallback(\r\n  ^\r\n../node_modules/nan/nan.h:98:40: note: expanded from macro 'NAN_DEPRECATED'\r\n# define NAN_DEPRECATED __attribute__((deprecated))\r\n                                       ^\r\n2 warnings and 1 error generated.\r\nmake: *** [Release/obj.target/binding/src/XpcConnection.o] Error 1\r\ngyp ERR! build error \r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:258:23)\r\ngyp ERR! stack     at ChildProcess.emit (events.js:182:13)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:225:12)\r\ngyp ERR! System Darwin 16.7.0\r\ngyp ERR! command \"/usr/local/Cellar/node/10.0.0/bin/node\" \"/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /usr/local/lib/node_modules/xpc-connection\r\ngyp ERR! node -v v10.0.0\r\ngyp ERR! node-gyp -v v3.6.2\r\ngyp ERR! not ok \r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! xpc-connection@0.1.4 install: `node-gyp rebuild`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the xpc-connection@0.1.4 install script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\n```"},"comment":{"url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection/issues/comments/419275411","html_url":"https://github.com/sandeepmistry/node-xpc-connection/issues/24#issuecomment-419275411","issue_url":"https://api.github.com/repos/sandeepmistry/node-xpc-connection/issues/24","id":419275411,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTI3NTQxMQ==","user":{"login":"halfnhalf","id":1940001,"node_id":"MDQ6VXNlcjE5NDAwMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/1940001?v=4","gravatar_id":"","url":"https://api.github.com/users/halfnhalf","html_url":"https://github.com/halfnhalf","followers_url":"https://api.github.com/users/halfnhalf/followers","following_url":"https://api.github.com/users/halfnhalf/following{/other_user}","gists_url":"https://api.github.com/users/halfnhalf/gists{/gist_id}","starred_url":"https://api.github.com/users/halfnhalf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfnhalf/subscriptions","organizations_url":"https://api.github.com/users/halfnhalf/orgs","repos_url":"https://api.github.com/users/halfnhalf/repos","events_url":"https://api.github.com/users/halfnhalf/events{/privacy}","received_events_url":"https://api.github.com/users/halfnhalf/received_events","type":"User","site_admin":false},"created_at":"2018-09-06T23:40:09Z","updated_at":"2018-09-06T23:40:09Z","author_association":"NONE","body":"Still hitting this on 10"}}
{"actor":{"display_login":"halfnhalf"}}