{"action":"created","comment":{"url":"https://api.github.com/repos/code-squad/javascript-json/pulls/comments/183586896","pull_request_review_id":114611834,"id":183586896,"diff_hunk":"@@ -1,79 +1,84 @@\n /* \n-    요구사항\n-    1. ArrayParser 함수\n-    \n-    2. 배열안에는 숫자데이터만 존재\n-    \n-    3. 배열형태의 문자열을 token 단위로 해석\n-       이를 분석한 자료구조를 만든다\n-    \n-    4. 정규표현식 사용은 최소한으로 한다 (token 타입체크에 한해 사용가능)\n-*/\n-\n-function arrayParser(str) {\n-\n-    // 0. variable\n-    let resultObject = new Object();\n-    resultObject.type = null;\n-    resultObject.child = new Array();\n-\n-    let dividedCharacterDatas = [];\n+    1차 피드백\n+    todo의 리뷰를 보면서, 그 렉쳐의 코드를 class로 잘 정리해두시고요.\n+    그 다음에 여기까지의 array parser 코드를 class로 수정하고 더 진행해보시죠.\n \n-    const strDataLength = parseInt(str.length);    \n+    todo의 리뷰를 보면서, 그 렉쳐의 코드를 class로 잘 정리하고나서 여기 렉처를 이어나가세요.\n+    todo렉처가 정리되면, 여기 array parser 코드를 class로 수정하고 더 진행해보시죠.\n+    arrayParser 함수는 좀 하위함수로 나누면서 하면 좋겠고요.\n \n-    // 1. String 찢기\n-    for (let i=0; i<strDataLength; i++) {\n-        dividedCharacterDatas.push(str[i]);\n-     }\n+    class arrayParser\n+    1. spliter\n+    2. checkType \n+*/\n \n-     // 1-1. type check\n-     // 입력받은 데이터(str)의 맨 앞,뒤 문자를 구분하여\n-     // type을 결정합니다\n-     let firstCharacter = str[0];\n-     let lastCharacter = str[strDataLength-1];\n-     resultObject.type = checkType(str);\n+class ArrayParser {\n+    \n+    constructor(stringData) {\n+        this.resultObject = {\n+            type: null,\n+            child: [],\n+        }\n+        this.dividedCharacterDatas = [];\n+        this.inputString = stringData;\n+    }\n \n-    let mergeData = \"\";\n+    spliter() {","path":"arrayParser.js","position":null,"original_position":57,"commit_id":"dd6948851150c98295e939f30adf858c01de7b53","original_commit_id":"d0e5c771b9f20b3f3824e7c31549a31e6dc47889","user":{"login":"nigayo","id":1456761,"avatar_url":"https://avatars2.githubusercontent.com/u/1456761?v=4","gravatar_id":"","url":"https://api.github.com/users/nigayo","html_url":"https://github.com/nigayo","followers_url":"https://api.github.com/users/nigayo/followers","following_url":"https://api.github.com/users/nigayo/following{/other_user}","gists_url":"https://api.github.com/users/nigayo/gists{/gist_id}","starred_url":"https://api.github.com/users/nigayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigayo/subscriptions","organizations_url":"https://api.github.com/users/nigayo/orgs","repos_url":"https://api.github.com/users/nigayo/repos","events_url":"https://api.github.com/users/nigayo/events{/privacy}","received_events_url":"https://api.github.com/users/nigayo/received_events","type":"User","site_admin":false},"body":"함수(메서드)는 동사+명사로.","created_at":"2018-04-24T02:02:22Z","updated_at":"2018-04-24T02:03:09Z","html_url":"https://github.com/code-squad/javascript-json/pull/28#discussion_r183586896","pull_request_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/28","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/comments/183586896"},"html":{"href":"https://github.com/code-squad/javascript-json/pull/28#discussion_r183586896"},"pull_request":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/code-squad/javascript-json/pulls/28","id":182665260,"html_url":"https://github.com/code-squad/javascript-json/pull/28","diff_url":"https://github.com/code-squad/javascript-json/pull/28.diff","patch_url":"https://github.com/code-squad/javascript-json/pull/28.patch","issue_url":"https://api.github.com/repos/code-squad/javascript-json/issues/28","number":28,"state":"open","locked":false,"title":"PR: ArrayParser 중 첫번 째 Array Data 분석","user":{"login":"antaehyeon","id":18719042,"avatar_url":"https://avatars1.githubusercontent.com/u/18719042?v=4","gravatar_id":"","url":"https://api.github.com/users/antaehyeon","html_url":"https://github.com/antaehyeon","followers_url":"https://api.github.com/users/antaehyeon/followers","following_url":"https://api.github.com/users/antaehyeon/following{/other_user}","gists_url":"https://api.github.com/users/antaehyeon/gists{/gist_id}","starred_url":"https://api.github.com/users/antaehyeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antaehyeon/subscriptions","organizations_url":"https://api.github.com/users/antaehyeon/orgs","repos_url":"https://api.github.com/users/antaehyeon/repos","events_url":"https://api.github.com/users/antaehyeon/events{/privacy}","received_events_url":"https://api.github.com/users/antaehyeon/received_events","type":"User","site_admin":false},"body":"ArrayParser 중 #1 Array Data에 대한 설계와 코드를 추가하였습니다.","created_at":"2018-04-19T04:48:40Z","updated_at":"2018-04-24T02:03:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db84350606d8098f826c339eb480f66080670d9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/28/commits","review_comments_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/28/comments","review_comment_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/javascript-json/issues/28/comments","statuses_url":"https://api.github.com/repos/code-squad/javascript-json/statuses/dd6948851150c98295e939f30adf858c01de7b53","head":{"label":"antaehyeon:antaehyeon","ref":"antaehyeon","sha":"dd6948851150c98295e939f30adf858c01de7b53","user":{"login":"antaehyeon","id":18719042,"avatar_url":"https://avatars1.githubusercontent.com/u/18719042?v=4","gravatar_id":"","url":"https://api.github.com/users/antaehyeon","html_url":"https://github.com/antaehyeon","followers_url":"https://api.github.com/users/antaehyeon/followers","following_url":"https://api.github.com/users/antaehyeon/following{/other_user}","gists_url":"https://api.github.com/users/antaehyeon/gists{/gist_id}","starred_url":"https://api.github.com/users/antaehyeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antaehyeon/subscriptions","organizations_url":"https://api.github.com/users/antaehyeon/orgs","repos_url":"https://api.github.com/users/antaehyeon/repos","events_url":"https://api.github.com/users/antaehyeon/events{/privacy}","received_events_url":"https://api.github.com/users/antaehyeon/received_events","type":"User","site_admin":false},"repo":{"id":129863204,"name":"javascript-json","full_name":"antaehyeon/javascript-json","owner":{"login":"antaehyeon","id":18719042,"avatar_url":"https://avatars1.githubusercontent.com/u/18719042?v=4","gravatar_id":"","url":"https://api.github.com/users/antaehyeon","html_url":"https://github.com/antaehyeon","followers_url":"https://api.github.com/users/antaehyeon/followers","following_url":"https://api.github.com/users/antaehyeon/following{/other_user}","gists_url":"https://api.github.com/users/antaehyeon/gists{/gist_id}","starred_url":"https://api.github.com/users/antaehyeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antaehyeon/subscriptions","organizations_url":"https://api.github.com/users/antaehyeon/orgs","repos_url":"https://api.github.com/users/antaehyeon/repos","events_url":"https://api.github.com/users/antaehyeon/events{/privacy}","received_events_url":"https://api.github.com/users/antaehyeon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antaehyeon/javascript-json","description":"레벨2","fork":true,"url":"https://api.github.com/repos/antaehyeon/javascript-json","forks_url":"https://api.github.com/repos/antaehyeon/javascript-json/forks","keys_url":"https://api.github.com/repos/antaehyeon/javascript-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antaehyeon/javascript-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antaehyeon/javascript-json/teams","hooks_url":"https://api.github.com/repos/antaehyeon/javascript-json/hooks","issue_events_url":"https://api.github.com/repos/antaehyeon/javascript-json/issues/events{/number}","events_url":"https://api.github.com/repos/antaehyeon/javascript-json/events","assignees_url":"https://api.github.com/repos/antaehyeon/javascript-json/assignees{/user}","branches_url":"https://api.github.com/repos/antaehyeon/javascript-json/branches{/branch}","tags_url":"https://api.github.com/repos/antaehyeon/javascript-json/tags","blobs_url":"https://api.github.com/repos/antaehyeon/javascript-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antaehyeon/javascript-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antaehyeon/javascript-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/antaehyeon/javascript-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antaehyeon/javascript-json/statuses/{sha}","languages_url":"https://api.github.com/repos/antaehyeon/javascript-json/languages","stargazers_url":"https://api.github.com/repos/antaehyeon/javascript-json/stargazers","contributors_url":"https://api.github.com/repos/antaehyeon/javascript-json/contributors","subscribers_url":"https://api.github.com/repos/antaehyeon/javascript-json/subscribers","subscription_url":"https://api.github.com/repos/antaehyeon/javascript-json/subscription","commits_url":"https://api.github.com/repos/antaehyeon/javascript-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/antaehyeon/javascript-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/antaehyeon/javascript-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/antaehyeon/javascript-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/antaehyeon/javascript-json/contents/{+path}","compare_url":"https://api.github.com/repos/antaehyeon/javascript-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antaehyeon/javascript-json/merges","archive_url":"https://api.github.com/repos/antaehyeon/javascript-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antaehyeon/javascript-json/downloads","issues_url":"https://api.github.com/repos/antaehyeon/javascript-json/issues{/number}","pulls_url":"https://api.github.com/repos/antaehyeon/javascript-json/pulls{/number}","milestones_url":"https://api.github.com/repos/antaehyeon/javascript-json/milestones{/number}","notifications_url":"https://api.github.com/repos/antaehyeon/javascript-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antaehyeon/javascript-json/labels{/name}","releases_url":"https://api.github.com/repos/antaehyeon/javascript-json/releases{/id}","deployments_url":"https://api.github.com/repos/antaehyeon/javascript-json/deployments","created_at":"2018-04-17T07:21:29Z","updated_at":"2018-04-17T07:21:31Z","pushed_at":"2018-04-24T00:47:26Z","git_url":"git://github.com/antaehyeon/javascript-json.git","ssh_url":"git@github.com:antaehyeon/javascript-json.git","clone_url":"https://github.com/antaehyeon/javascript-json.git","svn_url":"https://github.com/antaehyeon/javascript-json","homepage":null,"size":4866,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-squad:antaehyeon","ref":"antaehyeon","sha":"fa232bb698eb6f67dd79a77421147332364223b7","user":{"login":"code-squad","id":22832280,"avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":107010155,"name":"javascript-json","full_name":"code-squad/javascript-json","owner":{"login":"code-squad","id":22832280,"avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-squad/javascript-json","description":"레벨2","fork":false,"url":"https://api.github.com/repos/code-squad/javascript-json","forks_url":"https://api.github.com/repos/code-squad/javascript-json/forks","keys_url":"https://api.github.com/repos/code-squad/javascript-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/javascript-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/javascript-json/teams","hooks_url":"https://api.github.com/repos/code-squad/javascript-json/hooks","issue_events_url":"https://api.github.com/repos/code-squad/javascript-json/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/javascript-json/events","assignees_url":"https://api.github.com/repos/code-squad/javascript-json/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/javascript-json/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/javascript-json/tags","blobs_url":"https://api.github.com/repos/code-squad/javascript-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/javascript-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/javascript-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/javascript-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/javascript-json/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/javascript-json/languages","stargazers_url":"https://api.github.com/repos/code-squad/javascript-json/stargazers","contributors_url":"https://api.github.com/repos/code-squad/javascript-json/contributors","subscribers_url":"https://api.github.com/repos/code-squad/javascript-json/subscribers","subscription_url":"https://api.github.com/repos/code-squad/javascript-json/subscription","commits_url":"https://api.github.com/repos/code-squad/javascript-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/javascript-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/javascript-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/javascript-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/javascript-json/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/javascript-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/javascript-json/merges","archive_url":"https://api.github.com/repos/code-squad/javascript-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/javascript-json/downloads","issues_url":"https://api.github.com/repos/code-squad/javascript-json/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/javascript-json/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/javascript-json/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/javascript-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/javascript-json/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/javascript-json/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/javascript-json/deployments","created_at":"2017-10-15T12:28:38Z","updated_at":"2018-03-13T05:43:41Z","pushed_at":"2018-04-24T01:44:17Z","git_url":"git://github.com/code-squad/javascript-json.git","ssh_url":"git@github.com:code-squad/javascript-json.git","clone_url":"https://github.com/code-squad/javascript-json.git","svn_url":"https://github.com/code-squad/javascript-json","homepage":null,"size":4286,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":12,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/28"},"html":{"href":"https://github.com/code-squad/javascript-json/pull/28"},"issue":{"href":"https://api.github.com/repos/code-squad/javascript-json/issues/28"},"comments":{"href":"https://api.github.com/repos/code-squad/javascript-json/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/javascript-json/statuses/dd6948851150c98295e939f30adf858c01de7b53"}},"author_association":"NONE"}}
{"actor":{"display_login":"nigayo"}}