{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2609","repository_url":"https://api.github.com/repos/kubernetes/ingress-nginx","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2609/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2609/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2609/events","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2609","id":329600643,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODE3NTUy","number":2609,"title":"Disable access_log when using vts status","user":{"login":"Firehed","id":354842,"node_id":"MDQ6VXNlcjM1NDg0Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/354842?v=4","gravatar_id":"","url":"https://api.github.com/users/Firehed","html_url":"https://github.com/Firehed","followers_url":"https://api.github.com/users/Firehed/followers","following_url":"https://api.github.com/users/Firehed/following{/other_user}","gists_url":"https://api.github.com/users/Firehed/gists{/gist_id}","starred_url":"https://api.github.com/users/Firehed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Firehed/subscriptions","organizations_url":"https://api.github.com/users/Firehed/orgs","repos_url":"https://api.github.com/users/Firehed/repos","events_url":"https://api.github.com/users/Firehed/events{/privacy}","received_events_url":"https://api.github.com/users/Firehed/received_events","type":"User","site_admin":false},"labels":[{"id":496816953,"node_id":"MDU6TGFiZWw0OTY4MTY5NTM=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false},{"id":677769656,"node_id":"MDU6TGFiZWw2Nzc3Njk2NTY=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-05T19:50:44Z","updated_at":"2018-06-05T19:50:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2609","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2609","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/2609.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/2609.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nCurrently, log messages like `127.0.0.1 - [127.0.0.1] - - [05/Jun/2018:19:41:18 +0000] \"GET /nginx_status/format/json HTTP/1.1\" 200 2069 \"-\" \"Go-http-client/1.1\" 118 0.000 [internal] - - - - ` will be constantly emitted to the logs when scraping Prometheus metrics and `enable-vts-status` is set to `true`. This change ensures that `access_log off;` is always set for the `/nginx_status` block.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments/394838019","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2609#issuecomment-394838019","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2609","id":394838019,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDgzODAxOQ==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T19:50:52Z","updated_at":"2018-06-05T19:50:52Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/ingress-nginx/pull/2609#\" title=\"Author self-approved\">Firehed</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **dcbw**\n\nAssign the PR to them by writing `/assign @dcbw` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/ingress-nginx/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dcbw\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}