{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/186306339","pull_request_review_id":117858391,"id":186306339,"diff_hunk":"@@ -0,0 +1,235 @@\n+#!/usr/bin/python","path":"lib/ansible/modules/cloud/vmware/vmware_guest_attribute.py","position":1,"original_position":1,"commit_id":"43a1442bfda7432ca863a72d545d3caf590ac715","original_commit_id":"43a1442bfda7432ca863a72d545d3caf590ac715","user":{"login":"pdellaert","id":942391,"avatar_url":"https://avatars1.githubusercontent.com/u/942391?v=4","gravatar_id":"","url":"https://api.github.com/users/pdellaert","html_url":"https://github.com/pdellaert","followers_url":"https://api.github.com/users/pdellaert/followers","following_url":"https://api.github.com/users/pdellaert/following{/other_user}","gists_url":"https://api.github.com/users/pdellaert/gists{/gist_id}","starred_url":"https://api.github.com/users/pdellaert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdellaert/subscriptions","organizations_url":"https://api.github.com/users/pdellaert/orgs","repos_url":"https://api.github.com/users/pdellaert/repos","events_url":"https://api.github.com/users/pdellaert/events{/privacy}","received_events_url":"https://api.github.com/users/pdellaert/received_events","type":"User","site_admin":false},"body":"i'd rename it to `vmware_guest_custom_attribute` (or `vmware_guest_custom_attributes`, see further). It better reflects what attributes it is about (there are a lot of attributes, someone with less experience in VMware might see 'attributes' as the normal name or even hw configuration...","created_at":"2018-05-06T23:12:25Z","updated_at":"2018-05-06T23:16:07Z","html_url":"https://github.com/ansible/ansible/pull/38114#discussion_r186306339","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/38114","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/186306339"},"html":{"href":"https://github.com/ansible/ansible/pull/38114#discussion_r186306339"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/38114"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/38114","id":178387008,"html_url":"https://github.com/ansible/ansible/pull/38114","diff_url":"https://github.com/ansible/ansible/pull/38114.diff","patch_url":"https://github.com/ansible/ansible/pull/38114.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/38114","number":38114,"state":"open","locked":false,"title":"VMware: new module : vmware_guest_attribute","user":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nSigned-off-by: Abhijeet Kasurde <akasurde@redhat.com>\r\n\r\n##### ISSUE TYPE\r\n - New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\ntest/integration/targets/vmware_guest_attribute/aliases\r\ntest/integration/targets/vmware_guest_attribute/tasks/main.yml\r\nlib/ansible/modules/cloud/vmware/vmware_guest_attribute.py\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\n2.6devel\r\n```","created_at":"2018-03-29T17:03:22Z","updated_at":"2018-05-06T23:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82cdff3d51ad6b3a558067c3e55119c4e7fd98a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":501518759,"url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":473225334,"url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"ededed","default":false},{"id":153577825,"url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":581543918,"url":"https://api.github.com/repos/ansible/ansible/labels/stale_ci","name":"stale_ci","color":"fef2c0","default":false},{"id":636327968,"url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false},{"id":468273802,"url":"https://api.github.com/repos/ansible/ansible/labels/test","name":"test","color":"0e8a16","default":false},{"id":427121291,"url":"https://api.github.com/repos/ansible/ansible/labels/vmware","name":"vmware","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/38114/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/38114/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/38114/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/43a1442bfda7432ca863a72d545d3caf590ac715","head":{"label":"Akasurde:vm_attributes","ref":"vm_attributes","sha":"43a1442bfda7432ca863a72d545d3caf590ac715","user":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"repo":{"id":87410645,"name":"ansible","full_name":"Akasurde/ansible","owner":{"login":"Akasurde","id":633765,"avatar_url":"https://avatars1.githubusercontent.com/u/633765?v=4","gravatar_id":"","url":"https://api.github.com/users/Akasurde","html_url":"https://github.com/Akasurde","followers_url":"https://api.github.com/users/Akasurde/followers","following_url":"https://api.github.com/users/Akasurde/following{/other_user}","gists_url":"https://api.github.com/users/Akasurde/gists{/gist_id}","starred_url":"https://api.github.com/users/Akasurde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akasurde/subscriptions","organizations_url":"https://api.github.com/users/Akasurde/orgs","repos_url":"https://api.github.com/users/Akasurde/repos","events_url":"https://api.github.com/users/Akasurde/events{/privacy}","received_events_url":"https://api.github.com/users/Akasurde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Akasurde/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/Akasurde/ansible","forks_url":"https://api.github.com/repos/Akasurde/ansible/forks","keys_url":"https://api.github.com/repos/Akasurde/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akasurde/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akasurde/ansible/teams","hooks_url":"https://api.github.com/repos/Akasurde/ansible/hooks","issue_events_url":"https://api.github.com/repos/Akasurde/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/Akasurde/ansible/events","assignees_url":"https://api.github.com/repos/Akasurde/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/Akasurde/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/Akasurde/ansible/tags","blobs_url":"https://api.github.com/repos/Akasurde/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akasurde/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akasurde/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akasurde/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akasurde/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/Akasurde/ansible/languages","stargazers_url":"https://api.github.com/repos/Akasurde/ansible/stargazers","contributors_url":"https://api.github.com/repos/Akasurde/ansible/contributors","subscribers_url":"https://api.github.com/repos/Akasurde/ansible/subscribers","subscription_url":"https://api.github.com/repos/Akasurde/ansible/subscription","commits_url":"https://api.github.com/repos/Akasurde/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akasurde/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akasurde/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akasurde/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akasurde/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/Akasurde/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akasurde/ansible/merges","archive_url":"https://api.github.com/repos/Akasurde/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akasurde/ansible/downloads","issues_url":"https://api.github.com/repos/Akasurde/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/Akasurde/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/Akasurde/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/Akasurde/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akasurde/ansible/labels{/name}","releases_url":"https://api.github.com/repos/Akasurde/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/Akasurde/ansible/deployments","created_at":"2017-04-06T09:20:07Z","updated_at":"2018-05-03T04:16:42Z","pushed_at":"2018-05-03T07:17:09Z","git_url":"git://github.com/Akasurde/ansible.git","ssh_url":"git@github.com:Akasurde/ansible.git","clone_url":"https://github.com/Akasurde/ansible.git","svn_url":"https://github.com/Akasurde/ansible","homepage":"http://ansible.com/","size":119547,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"e10724fadb137274fc3df85b270c6c1749caa1a7","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-05-06T21:19:41Z","pushed_at":"2018-05-06T22:53:14Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":120138,"stargazers_count":30058,"watchers_count":30058,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11128,"mirror_url":null,"archived":false,"open_issues_count":5044,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":11128,"open_issues":5044,"watchers":30058,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/38114"},"html":{"href":"https://github.com/ansible/ansible/pull/38114"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/38114"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/38114/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/38114/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/38114/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/43a1442bfda7432ca863a72d545d3caf590ac715"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pdellaert"}}