{"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/211797319","pull_request_review_id":148295592,"id":211797319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTc5NzMxOQ==","diff_hunk":"@@ -170,7 +187,9 @@ async function applyStoredRulesets(rulesets_obj){\n   const rulesets_jsons = await Promise.all(rulesets_promises);\n   if(rulesets_jsons.join(\"\").length > 0){\n     for(let rulesets_json of rulesets_jsons){","path":"chromium/background-scripts/update.js","position":162,"original_position":162,"commit_id":"13f200af0f6191c64dacc9d67d6806f8225c8635","original_commit_id":"13f200af0f6191c64dacc9d67d6806f8225c8635","user":{"login":"Hainish","id":156137,"node_id":"MDQ6VXNlcjE1NjEzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/156137?v=4","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"body":"Yes I think prioritization of update channels makes sense, but this will require some re-engineering.  This would be a good task for a future PR.","created_at":"2018-08-22T00:10:29Z","updated_at":"2018-08-22T00:10:29Z","html_url":"https://github.com/EFForg/https-everywhere/pull/16306#discussion_r211797319","pull_request_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/211797319"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/16306#discussion_r211797319"},"pull_request":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306"}},"in_reply_to_id":210928315},"pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306","id":208934551,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTM0NTUx","html_url":"https://github.com/EFForg/https-everywhere/pull/16306","diff_url":"https://github.com/EFForg/https-everywhere/pull/16306.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/16306.patch","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/16306","number":16306,"state":"closed","locked":false,"title":"Update channels ux","user":{"login":"Hainish","id":156137,"node_id":"MDQ6VXNlcjE1NjEzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/156137?v=4","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"body":"Adding a UX to update channels, as well as functionality to add, remove, or edit update channels.","created_at":"2018-08-16T17:44:55Z","updated_at":"2018-08-22T00:10:29Z","closed_at":"2018-08-16T20:19:19Z","merged_at":"2018-08-16T20:19:19Z","merge_commit_sha":"53c18b6774ecef6648fbeaffb662030c87b211c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306/commits","review_comments_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306/comments","review_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/16306/comments","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/13f200af0f6191c64dacc9d67d6806f8225c8635","head":{"label":"Hainish:update-channels-ux","ref":"update-channels-ux","sha":"13f200af0f6191c64dacc9d67d6806f8225c8635","user":{"login":"Hainish","id":156137,"node_id":"MDQ6VXNlcjE1NjEzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/156137?v=4","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"repo":{"id":50887253,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg4NzI1Mw==","name":"https-everywhere","full_name":"Hainish/https-everywhere","owner":{"login":"Hainish","id":156137,"node_id":"MDQ6VXNlcjE1NjEzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/156137?v=4","gravatar_id":"","url":"https://api.github.com/users/Hainish","html_url":"https://github.com/Hainish","followers_url":"https://api.github.com/users/Hainish/followers","following_url":"https://api.github.com/users/Hainish/following{/other_user}","gists_url":"https://api.github.com/users/Hainish/gists{/gist_id}","starred_url":"https://api.github.com/users/Hainish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hainish/subscriptions","organizations_url":"https://api.github.com/users/Hainish/orgs","repos_url":"https://api.github.com/users/Hainish/repos","events_url":"https://api.github.com/users/Hainish/events{/privacy}","received_events_url":"https://api.github.com/users/Hainish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hainish/https-everywhere","description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","fork":true,"url":"https://api.github.com/repos/Hainish/https-everywhere","forks_url":"https://api.github.com/repos/Hainish/https-everywhere/forks","keys_url":"https://api.github.com/repos/Hainish/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hainish/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hainish/https-everywhere/teams","hooks_url":"https://api.github.com/repos/Hainish/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/Hainish/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/Hainish/https-everywhere/events","assignees_url":"https://api.github.com/repos/Hainish/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/Hainish/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/Hainish/https-everywhere/tags","blobs_url":"https://api.github.com/repos/Hainish/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hainish/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hainish/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hainish/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hainish/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/Hainish/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/Hainish/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/Hainish/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/Hainish/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/Hainish/https-everywhere/subscription","commits_url":"https://api.github.com/repos/Hainish/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hainish/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hainish/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hainish/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hainish/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/Hainish/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hainish/https-everywhere/merges","archive_url":"https://api.github.com/repos/Hainish/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hainish/https-everywhere/downloads","issues_url":"https://api.github.com/repos/Hainish/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/Hainish/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/Hainish/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/Hainish/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hainish/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/Hainish/https-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/Hainish/https-everywhere/deployments","created_at":"2016-02-02T02:12:43Z","updated_at":"2017-09-28T19:54:29Z","pushed_at":"2018-08-16T20:19:27Z","git_url":"git://github.com/Hainish/https-everywhere.git","ssh_url":"git@github.com:Hainish/https-everywhere.git","clone_url":"https://github.com/Hainish/https-everywhere.git","svn_url":"https://github.com/Hainish/https-everywhere","homepage":"https://eff.org/https-everywhere","size":253013,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"6d1c05d7b5a260f7e8b0b6cfda871420cac62827","user":{"login":"EFForg","id":2120271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":14939303,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzOTMwMw==","name":"https-everywhere","full_name":"EFForg/https-everywhere","owner":{"login":"EFForg","id":2120271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/https-everywhere","description":"A browser extension that encrypts your communications with many websites that offer HTTPS but still allow unencrypted connections.","fork":false,"url":"https://api.github.com/repos/EFForg/https-everywhere","forks_url":"https://api.github.com/repos/EFForg/https-everywhere/forks","keys_url":"https://api.github.com/repos/EFForg/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/https-everywhere/teams","hooks_url":"https://api.github.com/repos/EFForg/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/https-everywhere/events","assignees_url":"https://api.github.com/repos/EFForg/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/https-everywhere/tags","blobs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/EFForg/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/EFForg/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/EFForg/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/EFForg/https-everywhere/subscription","commits_url":"https://api.github.com/repos/EFForg/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/https-everywhere/merges","archive_url":"https://api.github.com/repos/EFForg/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/https-everywhere/downloads","issues_url":"https://api.github.com/repos/EFForg/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/https-everywhere/releases{/id}","deployments_url":"https://api.github.com/repos/EFForg/https-everywhere/deployments","created_at":"2013-12-04T23:53:07Z","updated_at":"2018-08-21T22:16:53Z","pushed_at":"2018-08-21T16:20:05Z","git_url":"git://github.com/EFForg/https-everywhere.git","ssh_url":"git@github.com:EFForg/https-everywhere.git","clone_url":"https://github.com/EFForg/https-everywhere.git","svn_url":"https://github.com/EFForg/https-everywhere","homepage":"https://eff.org/https-everywhere","size":273345,"stargazers_count":2283,"watchers_count":2283,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1013,"mirror_url":null,"archived":false,"open_issues_count":1014,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1013,"open_issues":1014,"watchers":2283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/16306"},"issue":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/16306"},"comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/16306/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/16306/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/https-everywhere/statuses/13f200af0f6191c64dacc9d67d6806f8225c8635"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Hainish"}}