{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/6974","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/6974/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/6974/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/6974/events","html_url":"https://github.com/kubernetes/test-infra/pull/6974","id":299795026,"number":6974,"title":"Make clonerefs best-effort on $JOB_SPEC, ignore periodics","user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"labels":[{"id":705940018,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":412127043,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":484580953,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":682002555,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":522887185,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":366393439,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":671132825,"url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"assignees":[{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars2.githubusercontent.com/u/917931?v=4","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-02-23T17:47:00Z","updated_at":"2018-02-23T19:33:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/6974","html_url":"https://github.com/kubernetes/test-infra/pull/6974","diff_url":"https://github.com/kubernetes/test-infra/pull/6974.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/6974.patch"},"body":"The `clonerefs` utility can be used outside of a Prow context as long as\r\nit is best-effort at honoring `$JOB_SPEC`. Furthermore, in periodic jobs\r\nProw is not delcarative as far as what Git refs are to be tested in the\r\njob, so we should not attempt to clone anything from those types of job\r\nconfigurations.\r\n\r\nSigned-off-by: Steve Kuznetsov <skuznets@redhat.com>\r\n\r\n/cc @cjwagner @kargakis \r\n/assign @BenTheElder \r\n/kind bug\r\n/area prow"},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/368115861","html_url":"https://github.com/kubernetes/test-infra/pull/6974#issuecomment-368115861","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/6974","id":368115861,"user":{"login":"stevekuznetsov","id":7328370,"avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T19:33:23Z","updated_at":"2018-02-23T19:33:23Z","author_association":"CONTRIBUTOR","body":"> We should probably allow them to do this in the future though?\r\n\r\nI was throwing around the idea earlier last year of having two types of periodic jobs -- ones that just ran in time and ones that would be triggered in time and then resolve refs in Prow at that time. So run once every day, but when the job is actually triggered determine the refs to clone and launch it that way. In any case, if we ever add that to the spec of periodic jobs, easy to remove the `if`. Today, it would be incorrect not to have it.\r\n\r\n/hold cancel"}}
{"actor":{"display_login":"stevekuznetsov"}}