{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/190172421","pull_request_review_id":122492235,"id":190172421,"diff_hunk":"@@ -0,0 +1,3 @@\n+cflags-lib-$(CFG_CRYPTO_SIZE_OPTIMIZATION) += -Os\n+\n+subdirs-y += src","path":"core/lib/libmbedtls/sub.mk","position":null,"original_position":3,"commit_id":"207b928bb8143df75abb9f9f76bc8ba5d7f22cee","original_commit_id":"24ec9086edfd1318cbcb8450f7be1792ad319253","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars0.githubusercontent.com/u/6150306?v=4","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"I'd prefer if we put everything below `lib/libmbedtls` instead, having two different `libmbedtls` directories will be confusing.\r\n\r\nThe `src` directory will be `core` only we, so we could rename it to `core` and make this line:\r\n```\r\nsubdirs-$(sm-core) += core\r\n```","created_at":"2018-05-23T09:02:14Z","updated_at":"2018-05-23T09:06:52Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2345#discussion_r190172421","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/190172421"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2345#discussion_r190172421"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345","id":189892204,"html_url":"https://github.com/OP-TEE/optee_os/pull/2345","diff_url":"https://github.com/OP-TEE/optee_os/pull/2345.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2345.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2345","number":2345,"state":"open","locked":false,"title":"Support mbedtls crypto library","user":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"body":"<!--\r\n    If you are new to submitting pull requests to OP-TEE, then please have a\r\n    look at the list below and tick them off before submitting the pull request.\r\n\r\n    1. Read our contribution guidelines:\r\n         documentation/github.md.\r\n\r\n    2. Read the contribution section in Notice.md and pay extra attention to the\r\n       \"Developer Certificate of Origin\" part:\r\n         https://github.com/OP-TEE/optee_os/blob/master/Notice.md#contributions.\r\n\r\n    3. You should run checkpatch preferably before submitting the pull request.\r\n\r\n    4. When everything has been reviewed, you will need to squash, rebase and\r\n       add tags like `Reviewed-by`, `Acked-by`, `Tested-by` etc.\r\n\r\n    NOTE: This comment will not be shown in the pull request, so no harm keeping\r\n    it, but feel free to remove it if you like.\r\n-->\r\n\r\nPull request for mbedtls crypto supporting again here.\r\nThe mbedtls source path is \"lib/libmebdtls\" which is same as TA's.\r\n","created_at":"2018-05-23T08:22:43Z","updated_at":"2018-05-23T09:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7d34833f98c16ab7e36a0a028a1857e5346a1ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2345/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/207b928bb8143df75abb9f9f76bc8ba5d7f22cee","head":{"label":"edison-ai:support-mbedtls","ref":"support-mbedtls","sha":"207b928bb8143df75abb9f9f76bc8ba5d7f22cee","user":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"repo":{"id":107204158,"name":"optee_os","full_name":"edison-ai/optee_os","owner":{"login":"edison-ai","id":27393575,"avatar_url":"https://avatars0.githubusercontent.com/u/27393575?v=4","gravatar_id":"","url":"https://api.github.com/users/edison-ai","html_url":"https://github.com/edison-ai","followers_url":"https://api.github.com/users/edison-ai/followers","following_url":"https://api.github.com/users/edison-ai/following{/other_user}","gists_url":"https://api.github.com/users/edison-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/edison-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edison-ai/subscriptions","organizations_url":"https://api.github.com/users/edison-ai/orgs","repos_url":"https://api.github.com/users/edison-ai/repos","events_url":"https://api.github.com/users/edison-ai/events{/privacy}","received_events_url":"https://api.github.com/users/edison-ai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edison-ai/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/edison-ai/optee_os","forks_url":"https://api.github.com/repos/edison-ai/optee_os/forks","keys_url":"https://api.github.com/repos/edison-ai/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edison-ai/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edison-ai/optee_os/teams","hooks_url":"https://api.github.com/repos/edison-ai/optee_os/hooks","issue_events_url":"https://api.github.com/repos/edison-ai/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/edison-ai/optee_os/events","assignees_url":"https://api.github.com/repos/edison-ai/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/edison-ai/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/edison-ai/optee_os/tags","blobs_url":"https://api.github.com/repos/edison-ai/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edison-ai/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edison-ai/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/edison-ai/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edison-ai/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/edison-ai/optee_os/languages","stargazers_url":"https://api.github.com/repos/edison-ai/optee_os/stargazers","contributors_url":"https://api.github.com/repos/edison-ai/optee_os/contributors","subscribers_url":"https://api.github.com/repos/edison-ai/optee_os/subscribers","subscription_url":"https://api.github.com/repos/edison-ai/optee_os/subscription","commits_url":"https://api.github.com/repos/edison-ai/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/edison-ai/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/edison-ai/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/edison-ai/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/edison-ai/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/edison-ai/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edison-ai/optee_os/merges","archive_url":"https://api.github.com/repos/edison-ai/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edison-ai/optee_os/downloads","issues_url":"https://api.github.com/repos/edison-ai/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/edison-ai/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/edison-ai/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/edison-ai/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edison-ai/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/edison-ai/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/edison-ai/optee_os/deployments","created_at":"2017-10-17T01:49:41Z","updated_at":"2018-05-23T06:07:29Z","pushed_at":"2018-05-23T07:18:33Z","git_url":"git://github.com/edison-ai/optee_os.git","ssh_url":"git@github.com:edison-ai/optee_os.git","clone_url":"https://github.com/edison-ai/optee_os.git","svn_url":"https://github.com/edison-ai/optee_os","homepage":null,"size":15979,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"a97bc4a084f1292c3a2cfd0c4593183b2f873e67","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-05-22T13:23:16Z","pushed_at":"2018-05-23T08:22:43Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":13765,"stargazers_count":390,"watchers_count":390,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":345,"mirror_url":null,"archived":false,"open_issues_count":189,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":345,"open_issues":189,"watchers":390,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2345"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2345"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2345/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2345/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/207b928bb8143df75abb9f9f76bc8ba5d7f22cee"}},"author_association":"NONE"}}
{"actor":{"display_login":"jenswi-linaro"}}