{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/17291","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/17291/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/17291/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/17291/events","html_url":"https://github.com/magento/magento2/pull/17291","id":346147383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MDgxMzYx","number":17291,"title":"fix: remove unused ID","user":{"login":"DanielRuf","id":827205,"node_id":"MDQ6VXNlcjgyNzIwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"labels":[{"id":394366531,"node_id":"MDU6TGFiZWwzOTQzNjY1MzE=","url":"https://api.github.com/repos/magento/magento2/labels/Area:%20Frontend","name":"Area: Frontend","color":"1d76db","default":false},{"id":374023124,"node_id":"MDU6TGFiZWwzNzQwMjMxMjQ=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20Checkout","name":"Component: Checkout","color":"7fb703","default":false},{"id":703232382,"node_id":"MDU6TGFiZWw3MDMyMzIzODI=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.2","name":"Release Line: 2.2","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"assignees":[{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-07-31T11:30:54Z","updated_at":"2018-07-31T17:08:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/17291","html_url":"https://github.com/magento/magento2/pull/17291","diff_url":"https://github.com/magento/magento2/pull/17291.diff","patch_url":"https://github.com/magento/magento2/pull/17291.patch"},"body":"<!---\r\n    Thank you for contributing to Magento.\r\n    To help us process this pull request we recommend that you add the following information:\r\n     - Summary of the pull request,\r\n     - Issue(s) related to the changes made,\r\n     - Manual testing scenarios,\r\n-->\r\n\r\n<!--- Please provide a general summary of the Pull Request in the Title above -->\r\n\r\n### Description\r\n<!---\r\n    Please provide a description of the changes proposed in the pull request.\r\n    Letting us know what has changed and why it needed changing will help us validate this pull request.\r\n-->\r\n\r\nThe ID is totally unused so we do not have to use Knockout here and do not even need this ID.\r\n\r\n### Fixed Issues (if relevant)\r\n<!---\r\n    If relevant, please provide a list of fixed issues in the format magento/magento2#<issue_number>.\r\n    There could be 1 or more issues linked here and it will help us find some more information about the reasoning behind this change.\r\n-->\r\n1. \r\n\r\n### Manual testing scenarios\r\n<!---\r\n    Please provide a set of unambiguous steps to test the proposed code change.\r\n    Giving us manual testing scenarios will help with the processing and validation process.\r\n-->\r\n1. ...\r\n2. ...\r\n\r\n### Contribution checklist\r\n - [x] Pull request has a meaningful description of its purpose\r\n - [x] All commits are accompanied by meaningful commit messages\r\n - [ ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ ] All automated tests passed successfully (all builds on Travis CI are green)\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/409296567","html_url":"https://github.com/magento/magento2/pull/17291#issuecomment-409296567","issue_url":"https://api.github.com/repos/magento/magento2/issues/17291","id":409296567,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI5NjU2Nw==","user":{"login":"orlangur","id":642698,"node_id":"MDQ6VXNlcjY0MjY5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/642698?v=4","gravatar_id":"","url":"https://api.github.com/users/orlangur","html_url":"https://github.com/orlangur","followers_url":"https://api.github.com/users/orlangur/followers","following_url":"https://api.github.com/users/orlangur/following{/other_user}","gists_url":"https://api.github.com/users/orlangur/gists{/gist_id}","starred_url":"https://api.github.com/users/orlangur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orlangur/subscriptions","organizations_url":"https://api.github.com/users/orlangur/orgs","repos_url":"https://api.github.com/users/orlangur/repos","events_url":"https://api.github.com/users/orlangur/events{/privacy}","received_events_url":"https://api.github.com/users/orlangur/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T17:08:57Z","updated_at":"2018-07-31T17:08:57Z","author_association":"CONTRIBUTOR","body":"@DanielRuf this is pretty new\r\n\r\n> hey `@here`, yesterday we updated Code contribution docs (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html),\r\n\r\n> The main changes made in “Accepted pull requests and ported code” section, we defined few new rules for different submission types"}}
{"actor":{"display_login":"orlangur"}}