{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/10105","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/10105/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/10105/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/10105/events","html_url":"https://github.com/Automattic/jetpack/pull/10105","id":357546259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTMzMDkx","number":10105,"title":"Shortcodes: update MailChimp shortcode to match new format.","user":{"login":"jeherve","id":426388,"node_id":"MDQ6VXNlcjQyNjM4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/426388?v=4","gravatar_id":"","url":"https://api.github.com/users/jeherve","html_url":"https://github.com/jeherve","followers_url":"https://api.github.com/users/jeherve/followers","following_url":"https://api.github.com/users/jeherve/following{/other_user}","gists_url":"https://api.github.com/users/jeherve/gists{/gist_id}","starred_url":"https://api.github.com/users/jeherve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeherve/subscriptions","organizations_url":"https://api.github.com/users/jeherve/orgs","repos_url":"https://api.github.com/users/jeherve/repos","events_url":"https://api.github.com/users/jeherve/events{/privacy}","received_events_url":"https://api.github.com/users/jeherve/received_events","type":"User","site_admin":false},"labels":[{"id":70993243,"node_id":"MDU6TGFiZWw3MDk5MzI0Mw==","url":"https://api.github.com/repos/Automattic/jetpack/labels/Shortcodes","name":"Shortcodes","color":"006b75","default":false},{"id":470168693,"node_id":"MDU6TGFiZWw0NzAxNjg2OTM=","url":"https://api.github.com/repos/Automattic/jetpack/labels/[Pri]%20High","name":"[Pri] High","color":"ec9a71","default":false},{"id":199076921,"node_id":"MDU6TGFiZWwxOTkwNzY5MjE=","url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":70896532,"node_id":"MDU6TGFiZWw3MDg5NjUzMg==","url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Bug","name":"[Type] Bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":{"login":"jeherve","id":426388,"node_id":"MDQ6VXNlcjQyNjM4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/426388?v=4","gravatar_id":"","url":"https://api.github.com/users/jeherve","html_url":"https://github.com/jeherve","followers_url":"https://api.github.com/users/jeherve/followers","following_url":"https://api.github.com/users/jeherve/following{/other_user}","gists_url":"https://api.github.com/users/jeherve/gists{/gist_id}","starred_url":"https://api.github.com/users/jeherve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeherve/subscriptions","organizations_url":"https://api.github.com/users/jeherve/orgs","repos_url":"https://api.github.com/users/jeherve/repos","events_url":"https://api.github.com/users/jeherve/events{/privacy}","received_events_url":"https://api.github.com/users/jeherve/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeherve","id":426388,"node_id":"MDQ6VXNlcjQyNjM4OA==","avatar_url":"https://avatars1.githubusercontent.com/u/426388?v=4","gravatar_id":"","url":"https://api.github.com/users/jeherve","html_url":"https://github.com/jeherve","followers_url":"https://api.github.com/users/jeherve/followers","following_url":"https://api.github.com/users/jeherve/following{/other_user}","gists_url":"https://api.github.com/users/jeherve/gists{/gist_id}","starred_url":"https://api.github.com/users/jeherve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeherve/subscriptions","organizations_url":"https://api.github.com/users/jeherve/orgs","repos_url":"https://api.github.com/users/jeherve/repos","events_url":"https://api.github.com/users/jeherve/events{/privacy}","received_events_url":"https://api.github.com/users/jeherve/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/111","html_url":"https://github.com/Automattic/jetpack/milestone/111","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/111/labels","id":3600712,"node_id":"MDk6TWlsZXN0b25lMzYwMDcxMg==","number":111,"title":"6.6","description":"","creator":{"login":"oskosk","id":746152,"node_id":"MDQ6VXNlcjc0NjE1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/746152?v=4","gravatar_id":"","url":"https://api.github.com/users/oskosk","html_url":"https://github.com/oskosk","followers_url":"https://api.github.com/users/oskosk/followers","following_url":"https://api.github.com/users/oskosk/following{/other_user}","gists_url":"https://api.github.com/users/oskosk/gists{/gist_id}","starred_url":"https://api.github.com/users/oskosk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskosk/subscriptions","organizations_url":"https://api.github.com/users/oskosk/orgs","repos_url":"https://api.github.com/users/oskosk/repos","events_url":"https://api.github.com/users/oskosk/events{/privacy}","received_events_url":"https://api.github.com/users/oskosk/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":28,"state":"open","created_at":"2018-08-27T13:08:20Z","updated_at":"2018-09-14T18:46:34Z","due_on":"2018-09-25T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-09-06T08:21:26Z","updated_at":"2018-09-14T19:05:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/10105","html_url":"https://github.com/Automattic/jetpack/pull/10105","diff_url":"https://github.com/Automattic/jetpack/pull/10105.diff","patch_url":"https://github.com/Automattic/jetpack/pull/10105.patch"},"body":"Fixes #10104\r\n\r\n#### Changes proposed in this Pull Request:\r\n\r\nMailchimp updated their newsletter embed code, and the old one does not work anymore.\r\nThis change matches the new format, and updates our test accordingly.\r\n\r\nNote that this also reverts the changes introduced in #8547, since they do not appear necessary anymore. Mailchimp fixed that issue on their end.\r\n\r\n#### Testing instructions:\r\n \r\nTry adding Maichimp shortcodes to your site in different ways:\r\n- As an admin, add the new embed code to a new post. \r\n- As a contributor, add the new embed code to a new post and save your draft. Watch the code convert into a shortcode. \r\n- Make sure the newsletter pop up appears on your site when you view the post. \r\n- Make sure no JavaScript errors appear in your browser console.\r\n\r\nHere is an example embed code you can add to your post:\r\n\r\n```html\r\n<script type=\"text/javascript\" src=\"//downloads.mailchimp.com/js/signup-forms/popup/unique-methods/embed.js\" data-dojo-config=\"usePlainJson: true, isDebug: false\"></script><script type=\"text/javascript\">window.dojoRequire([\"mojo/signup-forms/Loader\"], function(L) { L.start({\"baseUrl\":\"mc.us8.list-manage.com\",\"uuid\":\"be06c2a596db91bfe4099fde8\",\"lid\":\"08cf5fa008\",\"uniqueMethods\":true}) })</script>\r\n```\r\n\r\n<!-- Add the following only if this is meant to be in changelog -->\r\n#### Proposed changelog entry for your changes:\r\n\r\n- Shortcodes: update Mailchimp shortcode to match the new format offered by Mailchimp."},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/421455447","html_url":"https://github.com/Automattic/jetpack/pull/10105#issuecomment-421455447","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/10105","id":421455447,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQ1NTQ0Nw==","user":{"login":"brbrr","id":5654161,"node_id":"MDQ6VXNlcjU2NTQxNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5654161?v=4","gravatar_id":"","url":"https://api.github.com/users/brbrr","html_url":"https://github.com/brbrr","followers_url":"https://api.github.com/users/brbrr/followers","following_url":"https://api.github.com/users/brbrr/following{/other_user}","gists_url":"https://api.github.com/users/brbrr/gists{/gist_id}","starred_url":"https://api.github.com/users/brbrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brbrr/subscriptions","organizations_url":"https://api.github.com/users/brbrr/orgs","repos_url":"https://api.github.com/users/brbrr/repos","events_url":"https://api.github.com/users/brbrr/events{/privacy}","received_events_url":"https://api.github.com/users/brbrr/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T19:05:45Z","updated_at":"2018-09-14T19:05:45Z","author_association":"CONTRIBUTOR","body":"I've tested with few shortcodes and different user roles. LFTM 🐑 "}}
{"actor":{"display_login":"brbrr"}}