{"action":"created","issue":{"url":"https://api.github.com/repos/ni/nimi-python/issues/950","repository_url":"https://api.github.com/repos/ni/nimi-python","labels_url":"https://api.github.com/repos/ni/nimi-python/issues/950/labels{/name}","comments_url":"https://api.github.com/repos/ni/nimi-python/issues/950/comments","events_url":"https://api.github.com/repos/ni/nimi-python/issues/950/events","html_url":"https://github.com/ni/nimi-python/pull/950","id":375574387,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTg4MzIz","number":950,"title":"Fix #900 and add some tests","user":{"login":"texasaggie97","id":11483903,"node_id":"MDQ6VXNlcjExNDgzOTAz","avatar_url":"https://avatars1.githubusercontent.com/u/11483903?v=4","gravatar_id":"","url":"https://api.github.com/users/texasaggie97","html_url":"https://github.com/texasaggie97","followers_url":"https://api.github.com/users/texasaggie97/followers","following_url":"https://api.github.com/users/texasaggie97/following{/other_user}","gists_url":"https://api.github.com/users/texasaggie97/gists{/gist_id}","starred_url":"https://api.github.com/users/texasaggie97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texasaggie97/subscriptions","organizations_url":"https://api.github.com/users/texasaggie97/orgs","repos_url":"https://api.github.com/users/texasaggie97/repos","events_url":"https://api.github.com/users/texasaggie97/events{/privacy}","received_events_url":"https://api.github.com/users/texasaggie97/received_events","type":"User","site_admin":false},"labels":[{"id":698315449,"node_id":"MDU6TGFiZWw2OTgzMTU0NDk=","url":"https://api.github.com/repos/ni/nimi-python/labels/codegen","name":"codegen","color":"5319e7","default":false},{"id":656403855,"node_id":"MDU6TGFiZWw2NTY0MDM4NTU=","url":"https://api.github.com/repos/ni/nimi-python/labels/test","name":"test","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/ni/nimi-python/milestones/15","html_url":"https://github.com/ni/nimi-python/milestone/15","labels_url":"https://api.github.com/repos/ni/nimi-python/milestones/15/labels","id":3274971,"node_id":"MDk6TWlsZXN0b25lMzI3NDk3MQ==","number":15,"title":"nimi-python 1.2 release","description":"Support for other high priority features and bug fixes.","creator":{"login":"Fladolcetta","id":28631682,"node_id":"MDQ6VXNlcjI4NjMxNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/28631682?v=4","gravatar_id":"","url":"https://api.github.com/users/Fladolcetta","html_url":"https://github.com/Fladolcetta","followers_url":"https://api.github.com/users/Fladolcetta/followers","following_url":"https://api.github.com/users/Fladolcetta/following{/other_user}","gists_url":"https://api.github.com/users/Fladolcetta/gists{/gist_id}","starred_url":"https://api.github.com/users/Fladolcetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fladolcetta/subscriptions","organizations_url":"https://api.github.com/users/Fladolcetta/orgs","repos_url":"https://api.github.com/users/Fladolcetta/repos","events_url":"https://api.github.com/users/Fladolcetta/events{/privacy}","received_events_url":"https://api.github.com/users/Fladolcetta/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2018-04-17T18:56:06Z","updated_at":"2018-10-30T16:16:03Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-10-30T16:16:03Z","updated_at":"2018-10-30T16:30:18Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ni/nimi-python/pulls/950","html_url":"https://github.com/ni/nimi-python/pull/950","diff_url":"https://github.com/ni/nimi-python/pull/950.diff","patch_url":"https://github.com/ni/nimi-python/pull/950.patch"},"body":"- [X] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md).\r\n- [X] ~~I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.~~\r\n- [X] I've added tests applicable for this pull request\r\n### What does this Pull Request accomplish?\r\n* Add tests for mechanisms not already tested\r\n* Remove metadata we have not needed\r\n* Be explicit about where the flake8 configuration is\r\n    * For some reason, after re-installing Windows, flake8 (of any version) would not look in tox.ini without telling it that that was the config file. I don't believe this will hurt and may keep this from happening to others.\r\n### List issues fixed by this Pull Request below, if any.\r\n* Fix #900 \r\n\r\n### What testing has been done?\r\n* Unit\r\n* System\r\n"},"comment":{"url":"https://api.github.com/repos/ni/nimi-python/issues/comments/434373172","html_url":"https://github.com/ni/nimi-python/pull/950#issuecomment-434373172","issue_url":"https://api.github.com/repos/ni/nimi-python/issues/950","id":434373172,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDM3MzE3Mg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-10-30T16:30:18Z","updated_at":"2018-10-30T16:30:18Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=h1) Report\n> Merging [#950](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=desc) into [master](https://codecov.io/gh/ni/nimi-python/commit/69dbc11527ebbc29f509a927b9725d80dfb91065?src=pr&el=desc) will **increase** coverage by `0.18%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/ni/nimi-python/pull/950/graphs/tree.svg?width=650&token=utyPsqwNz1&height=150&src=pr)](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master    #950      +/-   ##\n=========================================\n+ Coverage   80.22%   80.4%   +0.18%     \n=========================================\n  Files          27      27              \n  Lines        3954    3960       +6     \n=========================================\n+ Hits         3172    3184      +12     \n+ Misses        782     776       -6\n```\n\n\n| [Impacted Files](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [build/helper/codegen\\_helper.py](https://codecov.io/gh/ni/nimi-python/pull/950/diff?src=pr&el=tree#diff-YnVpbGQvaGVscGVyL2NvZGVnZW5faGVscGVyLnB5) | `88.18% <100%> (+1.96%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=footer). Last update [69dbc11...98a4a39](https://codecov.io/gh/ni/nimi-python/pull/950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}