{"action":"created","comment":{"url":"https://api.github.com/repos/mlr-org/mlr/pulls/comments/234042218","pull_request_review_id":175586399,"id":234042218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA0MjIxOA==","diff_hunk":"@@ -45,17 +44,17 @@ getResamplingIndices = function(object, inner = FALSE) {\n \n     # now translate the inner inds back to the outer inds so we have the correct indices https://github.com/mlr-org/mlr/issues/2409\n \n-    inner_inds_translated = map(1:length(inner_inds), function(z) # map over number of outer folds\n+    inner_inds_translated = lapply(1:length(inner_inds), function(z) # map over number of outer folds\n \n-      set_names(\n-        map(c(\"train.inds\", \"test.inds\"), function(u) # map over train/test level\n+      setNames(\n+        lapply(c(\"train.inds\", \"test.inds\"), function(u) # map over train/test level\n \n           # list() -> create list for \"train.inds\" and \"test.inds\"\n-          # flatten() -> reduce by one level\n+          # unlist() -> reduce by one level\n           # set_names(c(\"train.inds\", \"test.inds\")) -> now set list names\n-          flatten(\n-            map(inner_inds[[z]][[u]], ~ # map over number of inner folds\n-                  list(outer_inds[[\"train.inds\"]][[z]][.x]) # the inner test.inds are a subset of the outer train.inds! That's why \"train.inds\" is hardcoded here\n+          unlist(","path":"R/getResamplingIndices.R","position":27,"original_position":27,"commit_id":"d131842eef769b7ee0d8584f7c1f7b09f8617fa2","original_commit_id":"d131842eef769b7ee0d8584f7c1f7b09f8617fa2","user":{"login":"mb706","id":15801081,"node_id":"MDQ6VXNlcjE1ODAxMDgx","avatar_url":"https://avatars2.githubusercontent.com/u/15801081?v=4","gravatar_id":"","url":"https://api.github.com/users/mb706","html_url":"https://github.com/mb706","followers_url":"https://api.github.com/users/mb706/followers","following_url":"https://api.github.com/users/mb706/following{/other_user}","gists_url":"https://api.github.com/users/mb706/gists{/gist_id}","starred_url":"https://api.github.com/users/mb706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mb706/subscriptions","organizations_url":"https://api.github.com/users/mb706/orgs","repos_url":"https://api.github.com/users/mb706/repos","events_url":"https://api.github.com/users/mb706/events{/privacy}","received_events_url":"https://api.github.com/users/mb706/received_events","type":"User","site_admin":false},"body":"probably should use `recursive = FALSE`, but as I say below I dont really understand what you are trying to do here.","created_at":"2018-11-15T23:09:39Z","updated_at":"2018-11-15T23:14:01Z","html_url":"https://github.com/mlr-org/mlr/pull/2491#discussion_r234042218","pull_request_url":"https://api.github.com/repos/mlr-org/mlr/pulls/2491","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/comments/234042218"},"html":{"href":"https://github.com/mlr-org/mlr/pull/2491#discussion_r234042218"},"pull_request":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/2491"}}},"pull_request":{"url":"https://api.github.com/repos/mlr-org/mlr/pulls/2491","id":231327280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzI3Mjgw","html_url":"https://github.com/mlr-org/mlr/pull/2491","diff_url":"https://github.com/mlr-org/mlr/pull/2491.diff","patch_url":"https://github.com/mlr-org/mlr/pull/2491.patch","issue_url":"https://api.github.com/repos/mlr-org/mlr/issues/2491","number":2491,"state":"open","locked":false,"title":"Replace purrr functions with base/BBmisc","user":{"login":"pat-s","id":8430564,"node_id":"MDQ6VXNlcjg0MzA1NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8430564?v=4","gravatar_id":"","url":"https://api.github.com/users/pat-s","html_url":"https://github.com/pat-s","followers_url":"https://api.github.com/users/pat-s/followers","following_url":"https://api.github.com/users/pat-s/following{/other_user}","gists_url":"https://api.github.com/users/pat-s/gists{/gist_id}","starred_url":"https://api.github.com/users/pat-s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pat-s/subscriptions","organizations_url":"https://api.github.com/users/pat-s/orgs","repos_url":"https://api.github.com/users/pat-s/repos","events_url":"https://api.github.com/users/pat-s/events{/privacy}","received_events_url":"https://api.github.com/users/pat-s/received_events","type":"User","site_admin":false},"body":"fixes #2489 ","created_at":"2018-11-15T20:40:57Z","updated_at":"2018-11-15T23:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b26edcde1531fd0aaffbe59a41f2f98c59843071","assignee":null,"assignees":[],"requested_reviewers":[{"login":"berndbischl","id":1225974,"node_id":"MDQ6VXNlcjEyMjU5NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1225974?v=4","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":556929614,"node_id":"MDU6TGFiZWw1NTY5Mjk2MTQ=","url":"https://api.github.com/repos/mlr-org/mlr/labels/project%20-%20base","name":"project - base","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mlr-org/mlr/pulls/2491/commits","review_comments_url":"https://api.github.com/repos/mlr-org/mlr/pulls/2491/comments","review_comment_url":"https://api.github.com/repos/mlr-org/mlr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlr-org/mlr/issues/2491/comments","statuses_url":"https://api.github.com/repos/mlr-org/mlr/statuses/d131842eef769b7ee0d8584f7c1f7b09f8617fa2","head":{"label":"mlr-org:remove-purrr","ref":"remove-purrr","sha":"d131842eef769b7ee0d8584f7c1f7b09f8617fa2","user":{"login":"mlr-org","id":12941794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTQxNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/12941794?v=4","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"repo":{"id":12465340,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ2NTM0MA==","name":"mlr","full_name":"mlr-org/mlr","private":false,"owner":{"login":"mlr-org","id":12941794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTQxNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/12941794?v=4","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mlr-org/mlr","description":"mlr: Machine Learning in R ","fork":false,"url":"https://api.github.com/repos/mlr-org/mlr","forks_url":"https://api.github.com/repos/mlr-org/mlr/forks","keys_url":"https://api.github.com/repos/mlr-org/mlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlr-org/mlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlr-org/mlr/teams","hooks_url":"https://api.github.com/repos/mlr-org/mlr/hooks","issue_events_url":"https://api.github.com/repos/mlr-org/mlr/issues/events{/number}","events_url":"https://api.github.com/repos/mlr-org/mlr/events","assignees_url":"https://api.github.com/repos/mlr-org/mlr/assignees{/user}","branches_url":"https://api.github.com/repos/mlr-org/mlr/branches{/branch}","tags_url":"https://api.github.com/repos/mlr-org/mlr/tags","blobs_url":"https://api.github.com/repos/mlr-org/mlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlr-org/mlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlr-org/mlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlr-org/mlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlr-org/mlr/statuses/{sha}","languages_url":"https://api.github.com/repos/mlr-org/mlr/languages","stargazers_url":"https://api.github.com/repos/mlr-org/mlr/stargazers","contributors_url":"https://api.github.com/repos/mlr-org/mlr/contributors","subscribers_url":"https://api.github.com/repos/mlr-org/mlr/subscribers","subscription_url":"https://api.github.com/repos/mlr-org/mlr/subscription","commits_url":"https://api.github.com/repos/mlr-org/mlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlr-org/mlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlr-org/mlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlr-org/mlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlr-org/mlr/contents/{+path}","compare_url":"https://api.github.com/repos/mlr-org/mlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlr-org/mlr/merges","archive_url":"https://api.github.com/repos/mlr-org/mlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlr-org/mlr/downloads","issues_url":"https://api.github.com/repos/mlr-org/mlr/issues{/number}","pulls_url":"https://api.github.com/repos/mlr-org/mlr/pulls{/number}","milestones_url":"https://api.github.com/repos/mlr-org/mlr/milestones{/number}","notifications_url":"https://api.github.com/repos/mlr-org/mlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlr-org/mlr/labels{/name}","releases_url":"https://api.github.com/repos/mlr-org/mlr/releases{/id}","deployments_url":"https://api.github.com/repos/mlr-org/mlr/deployments","created_at":"2013-08-29T16:26:13Z","updated_at":"2018-11-15T15:26:21Z","pushed_at":"2018-11-15T20:50:56Z","git_url":"git://github.com/mlr-org/mlr.git","ssh_url":"git@github.com:mlr-org/mlr.git","clone_url":"https://github.com/mlr-org/mlr.git","svn_url":"https://github.com/mlr-org/mlr","homepage":"https://mlr.mlr-org.com","size":349297,"stargazers_count":1112,"watchers_count":1112,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":310,"open_issues":443,"watchers":1112,"default_branch":"master"}},"base":{"label":"mlr-org:master","ref":"master","sha":"395c9e2ff0255a8abc03c1daf6bc2a9eb0a4a409","user":{"login":"mlr-org","id":12941794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTQxNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/12941794?v=4","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"repo":{"id":12465340,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ2NTM0MA==","name":"mlr","full_name":"mlr-org/mlr","private":false,"owner":{"login":"mlr-org","id":12941794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTQxNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/12941794?v=4","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mlr-org/mlr","description":"mlr: Machine Learning in R ","fork":false,"url":"https://api.github.com/repos/mlr-org/mlr","forks_url":"https://api.github.com/repos/mlr-org/mlr/forks","keys_url":"https://api.github.com/repos/mlr-org/mlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlr-org/mlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlr-org/mlr/teams","hooks_url":"https://api.github.com/repos/mlr-org/mlr/hooks","issue_events_url":"https://api.github.com/repos/mlr-org/mlr/issues/events{/number}","events_url":"https://api.github.com/repos/mlr-org/mlr/events","assignees_url":"https://api.github.com/repos/mlr-org/mlr/assignees{/user}","branches_url":"https://api.github.com/repos/mlr-org/mlr/branches{/branch}","tags_url":"https://api.github.com/repos/mlr-org/mlr/tags","blobs_url":"https://api.github.com/repos/mlr-org/mlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlr-org/mlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlr-org/mlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlr-org/mlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlr-org/mlr/statuses/{sha}","languages_url":"https://api.github.com/repos/mlr-org/mlr/languages","stargazers_url":"https://api.github.com/repos/mlr-org/mlr/stargazers","contributors_url":"https://api.github.com/repos/mlr-org/mlr/contributors","subscribers_url":"https://api.github.com/repos/mlr-org/mlr/subscribers","subscription_url":"https://api.github.com/repos/mlr-org/mlr/subscription","commits_url":"https://api.github.com/repos/mlr-org/mlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlr-org/mlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlr-org/mlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlr-org/mlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlr-org/mlr/contents/{+path}","compare_url":"https://api.github.com/repos/mlr-org/mlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlr-org/mlr/merges","archive_url":"https://api.github.com/repos/mlr-org/mlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlr-org/mlr/downloads","issues_url":"https://api.github.com/repos/mlr-org/mlr/issues{/number}","pulls_url":"https://api.github.com/repos/mlr-org/mlr/pulls{/number}","milestones_url":"https://api.github.com/repos/mlr-org/mlr/milestones{/number}","notifications_url":"https://api.github.com/repos/mlr-org/mlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlr-org/mlr/labels{/name}","releases_url":"https://api.github.com/repos/mlr-org/mlr/releases{/id}","deployments_url":"https://api.github.com/repos/mlr-org/mlr/deployments","created_at":"2013-08-29T16:26:13Z","updated_at":"2018-11-15T15:26:21Z","pushed_at":"2018-11-15T20:50:56Z","git_url":"git://github.com/mlr-org/mlr.git","ssh_url":"git@github.com:mlr-org/mlr.git","clone_url":"https://github.com/mlr-org/mlr.git","svn_url":"https://github.com/mlr-org/mlr","homepage":"https://mlr.mlr-org.com","size":349297,"stargazers_count":1112,"watchers_count":1112,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":310,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":310,"open_issues":443,"watchers":1112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/2491"},"html":{"href":"https://github.com/mlr-org/mlr/pull/2491"},"issue":{"href":"https://api.github.com/repos/mlr-org/mlr/issues/2491"},"comments":{"href":"https://api.github.com/repos/mlr-org/mlr/issues/2491/comments"},"review_comments":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/2491/comments"},"review_comment":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/2491/commits"},"statuses":{"href":"https://api.github.com/repos/mlr-org/mlr/statuses/d131842eef769b7ee0d8584f7c1f7b09f8617fa2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mb706"}}