{"action":"opened","number":1255,"pull_request":{"url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/1255","id":166636961,"html_url":"https://github.com/rmosolgo/graphql-ruby/pull/1255","diff_url":"https://github.com/rmosolgo/graphql-ruby/pull/1255.diff","patch_url":"https://github.com/rmosolgo/graphql-ruby/pull/1255.patch","issue_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/1255","number":1255,"state":"open","locked":false,"title":"Fix printing object type definitions","user":{"login":"swalkinshaw","id":295605,"avatar_url":"https://avatars3.githubusercontent.com/u/295605?v=4","gravatar_id":"","url":"https://api.github.com/users/swalkinshaw","html_url":"https://github.com/swalkinshaw","followers_url":"https://api.github.com/users/swalkinshaw/followers","following_url":"https://api.github.com/users/swalkinshaw/following{/other_user}","gists_url":"https://api.github.com/users/swalkinshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/swalkinshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalkinshaw/subscriptions","organizations_url":"https://api.github.com/users/swalkinshaw/orgs","repos_url":"https://api.github.com/users/swalkinshaw/repos","events_url":"https://api.github.com/users/swalkinshaw/events{/privacy}","received_events_url":"https://api.github.com/users/swalkinshaw/received_events","type":"User","site_admin":false},"body":"Directives come after the implemented interfaces.\r\n\r\nSee\r\nhttps://github.com/graphql/graphql-js/blob/360fa06e43fed32b63fba99b353515e7b56eee20/src/language/printer.js#L117-L129\r\nfor the canonical printer.\r\n\r\nThis is pretty difficult to add a test for (I think?) and likely why there wasn't any to begin with.\r\n\r\n@xuorig any suggestions for how to test this? Since right now we're building a document by parsing it but I don't think it supports directives like this?","created_at":"2018-02-01T19:59:47Z","updated_at":"2018-02-01T19:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/1255/commits","review_comments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/1255/comments","review_comment_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/1255/comments","statuses_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/statuses/c4f178c52a3edec81517827fda149da67602db3c","head":{"label":"swalkinshaw:fix-printing-object-type-definition-directives","ref":"fix-printing-object-type-definition-directives","sha":"c4f178c52a3edec81517827fda149da67602db3c","user":{"login":"swalkinshaw","id":295605,"avatar_url":"https://avatars3.githubusercontent.com/u/295605?v=4","gravatar_id":"","url":"https://api.github.com/users/swalkinshaw","html_url":"https://github.com/swalkinshaw","followers_url":"https://api.github.com/users/swalkinshaw/followers","following_url":"https://api.github.com/users/swalkinshaw/following{/other_user}","gists_url":"https://api.github.com/users/swalkinshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/swalkinshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalkinshaw/subscriptions","organizations_url":"https://api.github.com/users/swalkinshaw/orgs","repos_url":"https://api.github.com/users/swalkinshaw/repos","events_url":"https://api.github.com/users/swalkinshaw/events{/privacy}","received_events_url":"https://api.github.com/users/swalkinshaw/received_events","type":"User","site_admin":false},"repo":{"id":66653998,"name":"graphql-ruby","full_name":"swalkinshaw/graphql-ruby","owner":{"login":"swalkinshaw","id":295605,"avatar_url":"https://avatars3.githubusercontent.com/u/295605?v=4","gravatar_id":"","url":"https://api.github.com/users/swalkinshaw","html_url":"https://github.com/swalkinshaw","followers_url":"https://api.github.com/users/swalkinshaw/followers","following_url":"https://api.github.com/users/swalkinshaw/following{/other_user}","gists_url":"https://api.github.com/users/swalkinshaw/gists{/gist_id}","starred_url":"https://api.github.com/users/swalkinshaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalkinshaw/subscriptions","organizations_url":"https://api.github.com/users/swalkinshaw/orgs","repos_url":"https://api.github.com/users/swalkinshaw/repos","events_url":"https://api.github.com/users/swalkinshaw/events{/privacy}","received_events_url":"https://api.github.com/users/swalkinshaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swalkinshaw/graphql-ruby","description":"Ruby implementation of Facebook's GraphQL ","fork":true,"url":"https://api.github.com/repos/swalkinshaw/graphql-ruby","forks_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/forks","keys_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/teams","hooks_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/hooks","issue_events_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/events","assignees_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/tags","blobs_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/languages","stargazers_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/stargazers","contributors_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/contributors","subscribers_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/subscribers","subscription_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/subscription","commits_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/merges","archive_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/downloads","issues_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/labels{/name}","releases_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/swalkinshaw/graphql-ruby/deployments","created_at":"2016-08-26T14:29:00Z","updated_at":"2016-08-26T14:29:01Z","pushed_at":"2018-02-01T19:58:26Z","git_url":"git://github.com/swalkinshaw/graphql-ruby.git","ssh_url":"git@github.com:swalkinshaw/graphql-ruby.git","clone_url":"https://github.com/swalkinshaw/graphql-ruby.git","svn_url":"https://github.com/swalkinshaw/graphql-ruby","homepage":"","size":6546,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rmosolgo:master","ref":"master","sha":"401845b2ff6a10e6f1d354942502ef80600df0af","user":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars3.githubusercontent.com/u/2231765?v=4","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":true},"repo":{"id":30337170,"name":"graphql-ruby","full_name":"rmosolgo/graphql-ruby","owner":{"login":"rmosolgo","id":2231765,"avatar_url":"https://avatars3.githubusercontent.com/u/2231765?v=4","gravatar_id":"","url":"https://api.github.com/users/rmosolgo","html_url":"https://github.com/rmosolgo","followers_url":"https://api.github.com/users/rmosolgo/followers","following_url":"https://api.github.com/users/rmosolgo/following{/other_user}","gists_url":"https://api.github.com/users/rmosolgo/gists{/gist_id}","starred_url":"https://api.github.com/users/rmosolgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmosolgo/subscriptions","organizations_url":"https://api.github.com/users/rmosolgo/orgs","repos_url":"https://api.github.com/users/rmosolgo/repos","events_url":"https://api.github.com/users/rmosolgo/events{/privacy}","received_events_url":"https://api.github.com/users/rmosolgo/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/rmosolgo/graphql-ruby","description":"Ruby implementation of GraphQL ","fork":false,"url":"https://api.github.com/repos/rmosolgo/graphql-ruby","forks_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/forks","keys_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/teams","hooks_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/hooks","issue_events_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/events","assignees_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/tags","blobs_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/languages","stargazers_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/stargazers","contributors_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/contributors","subscribers_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/subscribers","subscription_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/subscription","commits_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/merges","archive_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/downloads","issues_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rmosolgo/graphql-ruby/deployments","created_at":"2015-02-05T04:11:22Z","updated_at":"2018-02-01T05:01:50Z","pushed_at":"2018-02-01T19:42:44Z","git_url":"git://github.com/rmosolgo/graphql-ruby.git","ssh_url":"git@github.com:rmosolgo/graphql-ruby.git","clone_url":"https://github.com/rmosolgo/graphql-ruby.git","svn_url":"https://github.com/rmosolgo/graphql-ruby","homepage":"http://graphql-ruby.org","size":10485,"stargazers_count":2445,"watchers_count":2445,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":105,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":316,"open_issues":105,"watchers":2445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/1255"},"html":{"href":"https://github.com/rmosolgo/graphql-ruby/pull/1255"},"issue":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/1255"},"comments":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/issues/1255/comments"},"review_comments":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/1255/comments"},"review_comment":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/pulls/1255/commits"},"statuses":{"href":"https://api.github.com/repos/rmosolgo/graphql-ruby/statuses/c4f178c52a3edec81517827fda149da67602db3c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"swalkinshaw"}}