{"action":"created","issue":{"url":"https://api.github.com/repos/ktowen/django_partial_date/issues/2","repository_url":"https://api.github.com/repos/ktowen/django_partial_date","labels_url":"https://api.github.com/repos/ktowen/django_partial_date/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ktowen/django_partial_date/issues/2/comments","events_url":"https://api.github.com/repos/ktowen/django_partial_date/issues/2/events","html_url":"https://github.com/ktowen/django_partial_date/pull/2","id":299166382,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcwNjE2Mzk3","number":2,"title":"get_prep_value now handles empty strings","user":{"login":"howieweiner","id":955237,"node_id":"MDQ6VXNlcjk1NTIzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/955237?v=4","gravatar_id":"","url":"https://api.github.com/users/howieweiner","html_url":"https://github.com/howieweiner","followers_url":"https://api.github.com/users/howieweiner/followers","following_url":"https://api.github.com/users/howieweiner/following{/other_user}","gists_url":"https://api.github.com/users/howieweiner/gists{/gist_id}","starred_url":"https://api.github.com/users/howieweiner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howieweiner/subscriptions","organizations_url":"https://api.github.com/users/howieweiner/orgs","repos_url":"https://api.github.com/users/howieweiner/repos","events_url":"https://api.github.com/users/howieweiner/events{/privacy}","received_events_url":"https://api.github.com/users/howieweiner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-21T23:20:06Z","updated_at":"2018-07-04T22:03:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ktowen/django_partial_date/pulls/2","html_url":"https://github.com/ktowen/django_partial_date/pull/2","diff_url":"https://github.com/ktowen/django_partial_date/pull/2.diff","patch_url":"https://github.com/ktowen/django_partial_date/pull/2.patch"},"body":"**What is this PR?**\r\nEmpty string date values were throwing Exceptions when attempting to parseDate in the constructor of the PartialDate class. This issue arises when the Model has a nullable (blank=True, null=True) PartialDateField. Managing this Model through Django Admin is an easy way to re-create this issue.\r\n\r\n**What has changed?**\r\nThe check for None in get_prep_value() now also checks for an empty string and does not attempt to construct a new PartialDate object\r\n\r\n**Testing**\r\nOnly tested manually, as it has not been possible to run the existing tests\r\n\r\n**Improvements**\r\nIt is still possible to construct a PartialDate class with an empty string and throw an Exception. A guard could be added"},"comment":{"url":"https://api.github.com/repos/ktowen/django_partial_date/issues/comments/402565034","html_url":"https://github.com/ktowen/django_partial_date/pull/2#issuecomment-402565034","issue_url":"https://api.github.com/repos/ktowen/django_partial_date/issues/2","id":402565034,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjU2NTAzNA==","user":{"login":"ktowen","id":17689932,"node_id":"MDQ6VXNlcjE3Njg5OTMy","avatar_url":"https://avatars1.githubusercontent.com/u/17689932?v=4","gravatar_id":"","url":"https://api.github.com/users/ktowen","html_url":"https://github.com/ktowen","followers_url":"https://api.github.com/users/ktowen/followers","following_url":"https://api.github.com/users/ktowen/following{/other_user}","gists_url":"https://api.github.com/users/ktowen/gists{/gist_id}","starred_url":"https://api.github.com/users/ktowen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktowen/subscriptions","organizations_url":"https://api.github.com/users/ktowen/orgs","repos_url":"https://api.github.com/users/ktowen/repos","events_url":"https://api.github.com/users/ktowen/events{/privacy}","received_events_url":"https://api.github.com/users/ktowen/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T22:03:09Z","updated_at":"2018-07-04T22:03:09Z","author_association":"OWNER","body":"Hello @howieweiner. Forgive me, I have not seen this, thank you very much for your collaboration"}}
{"actor":{"display_login":"ktowen"}}