{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/242328693","pull_request_review_id":185814301,"id":242328693,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMyODY5Mw==","diff_hunk":"@@ -18,23 +18,58 @@ package credentials\n \n import (\n \t\"encoding/base64\"\n+\t\"errors\"\n \t\"fmt\"\n+\t\"net/http\"\n \t\"strings\"\n \t\"time\"\n \n \t\"github.com/aws/aws-sdk-go/aws\"\n+\t\"github.com/aws/aws-sdk-go/aws/ec2metadata\"\n+\t\"github.com/aws/aws-sdk-go/aws/endpoints\"\n \t\"github.com/aws/aws-sdk-go/aws/request\"\n \t\"github.com/aws/aws-sdk-go/aws/session\"\n \t\"github.com/aws/aws-sdk-go/service/ecr\"\n \t\"k8s.io/klog\"\n \n+\t\"k8s.io/apimachinery/pkg/util/sets\"\n \t\"k8s.io/kubernetes/pkg/credentialprovider\"\n )\n \n-const awsChinaRegionPrefix = \"cn-\"\n-const awsStandardDNSSuffix = \"amazonaws.com\"\n-const awsChinaDNSSuffix = \"amazonaws.com.cn\"\n-const registryURLTemplate = \"*.dkr.ecr.%s.%s\"\n+const (\n+\tawsChinaRegionPrefix        = \"cn-\"\n+\tawsStandardDNSSuffix        = \"amazonaws.com\"\n+\tawsChinaDNSSuffix           = \"amazonaws.com.cn\"\n+\tregistryURLTemplate         = \"*.dkr.ecr.%s.%s\"\n+\tawsOsakaLocalRegion         = \"ap-northeast-3\"\n+\tawsAvailabilityZoneEndpoint = \"placement/availability-zone\"\n+)\n+\n+func init() {\n+\tseen := sets.NewString()\n+\n+\tfor _, p := range endpoints.DefaultPartitions() {","path":"pkg/credentialprovider/aws/aws_credentials.go","position":38,"original_position":38,"commit_id":"1e95384946ea285c9994aa11aae2d8cf325c7fb3","original_commit_id":"1e95384946ea285c9994aa11aae2d8cf325c7fb3","user":{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"body":"this results in registering aws credential providers in non-aws and in non-cloud invocations. don't do this directly in an init block","created_at":"2018-12-17T21:48:58Z","updated_at":"2018-12-17T21:48:59Z","html_url":"https://github.com/kubernetes/kubernetes/pull/70675#discussion_r242328693","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/242328693"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/70675#discussion_r242328693"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675","id":228530724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTMwNzI0","html_url":"https://github.com/kubernetes/kubernetes/pull/70675","diff_url":"https://github.com/kubernetes/kubernetes/pull/70675.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70675.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70675","number":70675,"state":"open","locked":false,"title":"Split AWS cloud and credential providers","user":{"login":"mcrute","id":108204,"node_id":"MDQ6VXNlcjEwODIwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/108204?v=4","gravatar_id":"","url":"https://api.github.com/users/mcrute","html_url":"https://github.com/mcrute","followers_url":"https://api.github.com/users/mcrute/followers","following_url":"https://api.github.com/users/mcrute/following{/other_user}","gists_url":"https://api.github.com/users/mcrute/gists{/gist_id}","starred_url":"https://api.github.com/users/mcrute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcrute/subscriptions","organizations_url":"https://api.github.com/users/mcrute/orgs","repos_url":"https://api.github.com/users/mcrute/repos","events_url":"https://api.github.com/users/mcrute/events{/privacy}","received_events_url":"https://api.github.com/users/mcrute/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nBreak the dependency between AWS cloud provider and AWS credential provider and at the same time use the region list provided by the AWS SDK instead of the hard-coded list here.\r\n\r\nThe credential provider will register providers for all known region when it's initialized instead of during the cloud provider initialization. This matches the behaviour of the GCP and Azure credential providers.\r\n\r\n**Which issue(s) this PR fixes**:\r\nRelated to #69585\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n```release-note\r\nNONE\r\n```\r\n\r\n/sig aws\r\n/kind cleanup\r\n/cc @yastij @andrewsykim\r\n/assign @liggitt @justinsb\r\n/priority important-soon\r\n/milestone v1.13","created_at":"2018-11-05T23:53:15Z","updated_at":"2018-12-17T21:48:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8ff66c18d58e1d838d482422f39957f46f815f1","assignee":{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"assignees":[{"login":"justinsb","id":100893,"node_id":"MDQ6VXNlcjEwMDg5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},{"login":"liggitt","id":980082,"node_id":"MDQ6VXNlcjk4MDA4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"yastij","id":7813699,"node_id":"MDQ6VXNlcjc4MTM2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7813699?v=4","gravatar_id":"","url":"https://api.github.com/users/yastij","html_url":"https://github.com/yastij","followers_url":"https://api.github.com/users/yastij/followers","following_url":"https://api.github.com/users/yastij/following{/other_user}","gists_url":"https://api.github.com/users/yastij/gists{/gist_id}","starred_url":"https://api.github.com/users/yastij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yastij/subscriptions","organizations_url":"https://api.github.com/users/yastij/orgs","repos_url":"https://api.github.com/users/yastij/repos","events_url":"https://api.github.com/users/yastij/events{/privacy}","received_events_url":"https://api.github.com/users/yastij/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andrewsykim","id":12699319,"node_id":"MDQ6VXNlcjEyNjk5MzE5","avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":114528223,"node_id":"MDU6TGFiZWwxMTQ1MjgyMjM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/important-soon","name":"priority/important-soon","color":"eb6420","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":328487998,"node_id":"MDU6TGFiZWwzMjg0ODc5OTg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/aws","name":"sig/aws","color":"d2b48c","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70675/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1e95384946ea285c9994aa11aae2d8cf325c7fb3","head":{"label":"mcrute:credentialprovider","ref":"credentialprovider","sha":"1e95384946ea285c9994aa11aae2d8cf325c7fb3","user":{"login":"mcrute","id":108204,"node_id":"MDQ6VXNlcjEwODIwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/108204?v=4","gravatar_id":"","url":"https://api.github.com/users/mcrute","html_url":"https://github.com/mcrute","followers_url":"https://api.github.com/users/mcrute/followers","following_url":"https://api.github.com/users/mcrute/following{/other_user}","gists_url":"https://api.github.com/users/mcrute/gists{/gist_id}","starred_url":"https://api.github.com/users/mcrute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcrute/subscriptions","organizations_url":"https://api.github.com/users/mcrute/orgs","repos_url":"https://api.github.com/users/mcrute/repos","events_url":"https://api.github.com/users/mcrute/events{/privacy}","received_events_url":"https://api.github.com/users/mcrute/received_events","type":"User","site_admin":false},"repo":{"id":151455291,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0NTUyOTE=","name":"kubernetes","full_name":"mcrute/kubernetes","private":false,"owner":{"login":"mcrute","id":108204,"node_id":"MDQ6VXNlcjEwODIwNA==","avatar_url":"https://avatars1.githubusercontent.com/u/108204?v=4","gravatar_id":"","url":"https://api.github.com/users/mcrute","html_url":"https://github.com/mcrute","followers_url":"https://api.github.com/users/mcrute/followers","following_url":"https://api.github.com/users/mcrute/following{/other_user}","gists_url":"https://api.github.com/users/mcrute/gists{/gist_id}","starred_url":"https://api.github.com/users/mcrute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcrute/subscriptions","organizations_url":"https://api.github.com/users/mcrute/orgs","repos_url":"https://api.github.com/users/mcrute/repos","events_url":"https://api.github.com/users/mcrute/events{/privacy}","received_events_url":"https://api.github.com/users/mcrute/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mcrute/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mcrute/kubernetes","forks_url":"https://api.github.com/repos/mcrute/kubernetes/forks","keys_url":"https://api.github.com/repos/mcrute/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcrute/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcrute/kubernetes/teams","hooks_url":"https://api.github.com/repos/mcrute/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mcrute/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mcrute/kubernetes/events","assignees_url":"https://api.github.com/repos/mcrute/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mcrute/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mcrute/kubernetes/tags","blobs_url":"https://api.github.com/repos/mcrute/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcrute/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcrute/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcrute/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcrute/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mcrute/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mcrute/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mcrute/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mcrute/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mcrute/kubernetes/subscription","commits_url":"https://api.github.com/repos/mcrute/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcrute/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcrute/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcrute/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcrute/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mcrute/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcrute/kubernetes/merges","archive_url":"https://api.github.com/repos/mcrute/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcrute/kubernetes/downloads","issues_url":"https://api.github.com/repos/mcrute/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mcrute/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mcrute/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mcrute/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcrute/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mcrute/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mcrute/kubernetes/deployments","created_at":"2018-10-03T17:48:28Z","updated_at":"2018-12-03T18:19:39Z","pushed_at":"2018-12-10T18:31:16Z","git_url":"git://github.com/mcrute/kubernetes.git","ssh_url":"git@github.com:mcrute/kubernetes.git","clone_url":"https://github.com/mcrute/kubernetes.git","svn_url":"https://github.com/mcrute/kubernetes","homepage":"https://kubernetes.io","size":600027,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0914272a42bddfce24d77403aee7c6ef714f6b3a","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-12-17T21:40:42Z","pushed_at":"2018-12-17T21:39:40Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"https://kubernetes.io","size":818253,"stargazers_count":45497,"watchers_count":45497,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15888,"mirror_url":null,"archived":false,"open_issues_count":3220,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15888,"open_issues":3220,"watchers":45497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/70675"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/70675"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/70675/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70675/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/1e95384946ea285c9994aa11aae2d8cf325c7fb3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"liggitt"}}