{"action":"closed","number":2242,"pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/2242","id":213987587,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTg3NTg3","html_url":"https://github.com/batfish/batfish/pull/2242","diff_url":"https://github.com/batfish/batfish/pull/2242.diff","patch_url":"https://github.com/batfish/batfish/pull/2242.patch","issue_url":"https://api.github.com/repos/batfish/batfish/issues/2242","number":2242,"state":"closed","locked":false,"title":"negate AclMatchExprs","user":{"login":"anothermattbrown","id":15133240,"node_id":"MDQ6VXNlcjE1MTMzMjQw","avatar_url":"https://avatars2.githubusercontent.com/u/15133240?v=4","gravatar_id":"","url":"https://api.github.com/users/anothermattbrown","html_url":"https://github.com/anothermattbrown","followers_url":"https://api.github.com/users/anothermattbrown/followers","following_url":"https://api.github.com/users/anothermattbrown/following{/other_user}","gists_url":"https://api.github.com/users/anothermattbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/anothermattbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anothermattbrown/subscriptions","organizations_url":"https://api.github.com/users/anothermattbrown/orgs","repos_url":"https://api.github.com/users/anothermattbrown/repos","events_url":"https://api.github.com/users/anothermattbrown/events{/privacy}","received_events_url":"https://api.github.com/users/anothermattbrown/received_events","type":"User","site_admin":false},"body":"Negate an AclLineMatchExpr, applying deMorgan to AndMatchExpr and OrMatchExpr (at most once -- uses NotMatchExpr instead of recursion to negate when applying deMorgan). Everything else is wrapped in a NotMatchExpr (including MatchHeaderSpace, which could also be negated using the flag in HeaderSpace), and double-negation is eliminated.","created_at":"2018-09-07T17:04:11Z","updated_at":"2018-09-07T21:17:12Z","closed_at":"2018-09-07T21:17:12Z","merged_at":"2018-09-07T21:17:11Z","merge_commit_sha":"fe664e7d75cb7af9a9dfec9c8e7c6ff30adf03fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/batfish/batfish/pulls/2242/commits","review_comments_url":"https://api.github.com/repos/batfish/batfish/pulls/2242/comments","review_comment_url":"https://api.github.com/repos/batfish/batfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/2242/comments","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/93178705acab45b81a814f41428ce493d5dba7e0","head":{"label":"batfish:matt-negate-AclLineMatchExpr","ref":"matt-negate-AclLineMatchExpr","sha":"93178705acab45b81a814f41428ce493d5dba7e0","user":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"repo":{"id":27507850,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUwNzg1MA==","name":"batfish","full_name":"batfish/batfish","owner":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/batfish/batfish","description":"Batfish is a network configuration analysis tool that can find bugs and guarantee the correctness of (planned or current) network configurations. It enables network engineers to rapidly and safely evolve their network, without fear of outages or security breaches.","fork":false,"url":"https://api.github.com/repos/batfish/batfish","forks_url":"https://api.github.com/repos/batfish/batfish/forks","keys_url":"https://api.github.com/repos/batfish/batfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batfish/batfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batfish/batfish/teams","hooks_url":"https://api.github.com/repos/batfish/batfish/hooks","issue_events_url":"https://api.github.com/repos/batfish/batfish/issues/events{/number}","events_url":"https://api.github.com/repos/batfish/batfish/events","assignees_url":"https://api.github.com/repos/batfish/batfish/assignees{/user}","branches_url":"https://api.github.com/repos/batfish/batfish/branches{/branch}","tags_url":"https://api.github.com/repos/batfish/batfish/tags","blobs_url":"https://api.github.com/repos/batfish/batfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batfish/batfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batfish/batfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/batfish/batfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/{sha}","languages_url":"https://api.github.com/repos/batfish/batfish/languages","stargazers_url":"https://api.github.com/repos/batfish/batfish/stargazers","contributors_url":"https://api.github.com/repos/batfish/batfish/contributors","subscribers_url":"https://api.github.com/repos/batfish/batfish/subscribers","subscription_url":"https://api.github.com/repos/batfish/batfish/subscription","commits_url":"https://api.github.com/repos/batfish/batfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/batfish/batfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/batfish/batfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/batfish/batfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/batfish/batfish/contents/{+path}","compare_url":"https://api.github.com/repos/batfish/batfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batfish/batfish/merges","archive_url":"https://api.github.com/repos/batfish/batfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batfish/batfish/downloads","issues_url":"https://api.github.com/repos/batfish/batfish/issues{/number}","pulls_url":"https://api.github.com/repos/batfish/batfish/pulls{/number}","milestones_url":"https://api.github.com/repos/batfish/batfish/milestones{/number}","notifications_url":"https://api.github.com/repos/batfish/batfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batfish/batfish/labels{/name}","releases_url":"https://api.github.com/repos/batfish/batfish/releases{/id}","deployments_url":"https://api.github.com/repos/batfish/batfish/deployments","created_at":"2014-12-03T21:10:18Z","updated_at":"2018-09-07T17:25:42Z","pushed_at":"2018-09-07T21:17:11Z","git_url":"git://github.com/batfish/batfish.git","ssh_url":"git@github.com:batfish/batfish.git","clone_url":"https://github.com/batfish/batfish.git","svn_url":"https://github.com/batfish/batfish","homepage":"http://www.batfish.org","size":169196,"stargazers_count":105,"watchers_count":105,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":56,"open_issues":121,"watchers":105,"default_branch":"master"}},"base":{"label":"batfish:master","ref":"master","sha":"75f70cb504fdddd47cee9b64900310789a820557","user":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"repo":{"id":27507850,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUwNzg1MA==","name":"batfish","full_name":"batfish/batfish","owner":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/batfish/batfish","description":"Batfish is a network configuration analysis tool that can find bugs and guarantee the correctness of (planned or current) network configurations. It enables network engineers to rapidly and safely evolve their network, without fear of outages or security breaches.","fork":false,"url":"https://api.github.com/repos/batfish/batfish","forks_url":"https://api.github.com/repos/batfish/batfish/forks","keys_url":"https://api.github.com/repos/batfish/batfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batfish/batfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batfish/batfish/teams","hooks_url":"https://api.github.com/repos/batfish/batfish/hooks","issue_events_url":"https://api.github.com/repos/batfish/batfish/issues/events{/number}","events_url":"https://api.github.com/repos/batfish/batfish/events","assignees_url":"https://api.github.com/repos/batfish/batfish/assignees{/user}","branches_url":"https://api.github.com/repos/batfish/batfish/branches{/branch}","tags_url":"https://api.github.com/repos/batfish/batfish/tags","blobs_url":"https://api.github.com/repos/batfish/batfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batfish/batfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batfish/batfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/batfish/batfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/{sha}","languages_url":"https://api.github.com/repos/batfish/batfish/languages","stargazers_url":"https://api.github.com/repos/batfish/batfish/stargazers","contributors_url":"https://api.github.com/repos/batfish/batfish/contributors","subscribers_url":"https://api.github.com/repos/batfish/batfish/subscribers","subscription_url":"https://api.github.com/repos/batfish/batfish/subscription","commits_url":"https://api.github.com/repos/batfish/batfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/batfish/batfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/batfish/batfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/batfish/batfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/batfish/batfish/contents/{+path}","compare_url":"https://api.github.com/repos/batfish/batfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batfish/batfish/merges","archive_url":"https://api.github.com/repos/batfish/batfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batfish/batfish/downloads","issues_url":"https://api.github.com/repos/batfish/batfish/issues{/number}","pulls_url":"https://api.github.com/repos/batfish/batfish/pulls{/number}","milestones_url":"https://api.github.com/repos/batfish/batfish/milestones{/number}","notifications_url":"https://api.github.com/repos/batfish/batfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batfish/batfish/labels{/name}","releases_url":"https://api.github.com/repos/batfish/batfish/releases{/id}","deployments_url":"https://api.github.com/repos/batfish/batfish/deployments","created_at":"2014-12-03T21:10:18Z","updated_at":"2018-09-07T17:25:42Z","pushed_at":"2018-09-07T21:17:11Z","git_url":"git://github.com/batfish/batfish.git","ssh_url":"git@github.com:batfish/batfish.git","clone_url":"https://github.com/batfish/batfish.git","svn_url":"https://github.com/batfish/batfish","homepage":"http://www.batfish.org","size":169196,"stargazers_count":105,"watchers_count":105,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":56,"open_issues":121,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/batfish/batfish/pulls/2242"},"html":{"href":"https://github.com/batfish/batfish/pull/2242"},"issue":{"href":"https://api.github.com/repos/batfish/batfish/issues/2242"},"comments":{"href":"https://api.github.com/repos/batfish/batfish/issues/2242/comments"},"review_comments":{"href":"https://api.github.com/repos/batfish/batfish/pulls/2242/comments"},"review_comment":{"href":"https://api.github.com/repos/batfish/batfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/batfish/batfish/pulls/2242/commits"},"statuses":{"href":"https://api.github.com/repos/batfish/batfish/statuses/93178705acab45b81a814f41428ce493d5dba7e0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"anothermattbrown","id":15133240,"node_id":"MDQ6VXNlcjE1MTMzMjQw","avatar_url":"https://avatars2.githubusercontent.com/u/15133240?v=4","gravatar_id":"","url":"https://api.github.com/users/anothermattbrown","html_url":"https://github.com/anothermattbrown","followers_url":"https://api.github.com/users/anothermattbrown/followers","following_url":"https://api.github.com/users/anothermattbrown/following{/other_user}","gists_url":"https://api.github.com/users/anothermattbrown/gists{/gist_id}","starred_url":"https://api.github.com/users/anothermattbrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anothermattbrown/subscriptions","organizations_url":"https://api.github.com/users/anothermattbrown/orgs","repos_url":"https://api.github.com/users/anothermattbrown/repos","events_url":"https://api.github.com/users/anothermattbrown/events{/privacy}","received_events_url":"https://api.github.com/users/anothermattbrown/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":176,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"anothermattbrown"}}