{"action":"created","issue":{"url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2934","repository_url":"https://api.github.com/repos/jwplayer/jwplayer","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2934/labels{/name}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2934/comments","events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2934/events","html_url":"https://github.com/jwplayer/jwplayer/pull/2934","id":327825133,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTI0NDcx","number":2934,"title":"Focus on first menu icon on enter","user":{"login":"DanFerrer","id":6787010,"node_id":"MDQ6VXNlcjY3ODcwMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6787010?v=4","gravatar_id":"","url":"https://api.github.com/users/DanFerrer","html_url":"https://github.com/DanFerrer","followers_url":"https://api.github.com/users/DanFerrer/followers","following_url":"https://api.github.com/users/DanFerrer/following{/other_user}","gists_url":"https://api.github.com/users/DanFerrer/gists{/gist_id}","starred_url":"https://api.github.com/users/DanFerrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanFerrer/subscriptions","organizations_url":"https://api.github.com/users/DanFerrer/orgs","repos_url":"https://api.github.com/users/DanFerrer/repos","events_url":"https://api.github.com/users/DanFerrer/events{/privacy}","received_events_url":"https://api.github.com/users/DanFerrer/received_events","type":"User","site_admin":false},"labels":[{"id":89434456,"node_id":"MDU6TGFiZWw4OTQzNDQ1Ng==","url":"https://api.github.com/repos/jwplayer/jwplayer/labels/bug","name":"bug","color":"f7c6c7","default":true}],"state":"open","locked":false,"assignee":{"login":"cesarrecio-enroute","id":32112126,"node_id":"MDQ6VXNlcjMyMTEyMTI2","avatar_url":"https://avatars2.githubusercontent.com/u/32112126?v=4","gravatar_id":"","url":"https://api.github.com/users/cesarrecio-enroute","html_url":"https://github.com/cesarrecio-enroute","followers_url":"https://api.github.com/users/cesarrecio-enroute/followers","following_url":"https://api.github.com/users/cesarrecio-enroute/following{/other_user}","gists_url":"https://api.github.com/users/cesarrecio-enroute/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarrecio-enroute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarrecio-enroute/subscriptions","organizations_url":"https://api.github.com/users/cesarrecio-enroute/orgs","repos_url":"https://api.github.com/users/cesarrecio-enroute/repos","events_url":"https://api.github.com/users/cesarrecio-enroute/events{/privacy}","received_events_url":"https://api.github.com/users/cesarrecio-enroute/received_events","type":"User","site_admin":false},"assignees":[{"login":"cesarrecio-enroute","id":32112126,"node_id":"MDQ6VXNlcjMyMTEyMTI2","avatar_url":"https://avatars2.githubusercontent.com/u/32112126?v=4","gravatar_id":"","url":"https://api.github.com/users/cesarrecio-enroute","html_url":"https://github.com/cesarrecio-enroute","followers_url":"https://api.github.com/users/cesarrecio-enroute/followers","following_url":"https://api.github.com/users/cesarrecio-enroute/following{/other_user}","gists_url":"https://api.github.com/users/cesarrecio-enroute/gists{/gist_id}","starred_url":"https://api.github.com/users/cesarrecio-enroute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesarrecio-enroute/subscriptions","organizations_url":"https://api.github.com/users/cesarrecio-enroute/orgs","repos_url":"https://api.github.com/users/cesarrecio-enroute/repos","events_url":"https://api.github.com/users/cesarrecio-enroute/events{/privacy}","received_events_url":"https://api.github.com/users/cesarrecio-enroute/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/92","html_url":"https://github.com/jwplayer/jwplayer/milestone/92","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/92/labels","id":3291183,"node_id":"MDk6TWlsZXN0b25lMzI5MTE4Mw==","number":92,"title":"v8.4.0","description":"","creator":{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":35,"state":"open","created_at":"2018-04-23T22:20:21Z","updated_at":"2018-06-04T15:24:24Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-05-30T17:21:17Z","updated_at":"2018-06-04T20:30:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2934","html_url":"https://github.com/jwplayer/jwplayer/pull/2934","diff_url":"https://github.com/jwplayer/jwplayer/pull/2934.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/2934.patch"},"body":"### This PR will...\r\n\r\n- Focus on first menu icon when enter is pressed on the settings menu\r\n- Allow the first or last submenu to be focused on arrow up or down regardless if the submenu is active or not\r\n\r\n### Why is this Pull Request needed?\r\n\r\nSubmenu items were being focused instead of the menu item. And if the submenu was already active on arrow up or down, the \"activateSubmenu\" function would return early so you couldn't focus on the quality submenu on arrow up or down\r\n\r\n### Are there any points in the code the reviewer needs to double check?\r\n\r\n### Are there any Pull Requests open in other repos which need to be merged with this?\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-1612\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments/394488614","html_url":"https://github.com/jwplayer/jwplayer/pull/2934#issuecomment-394488614","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2934","id":394488614,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDQ4ODYxNA==","user":{"login":"jwplayer-robot","id":5805482,"node_id":"MDQ6VXNlcjU4MDU0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/5805482?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer-robot","html_url":"https://github.com/jwplayer-robot","followers_url":"https://api.github.com/users/jwplayer-robot/followers","following_url":"https://api.github.com/users/jwplayer-robot/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer-robot/subscriptions","organizations_url":"https://api.github.com/users/jwplayer-robot/orgs","repos_url":"https://api.github.com/users/jwplayer-robot/repos","events_url":"https://api.github.com/users/jwplayer-robot/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer-robot/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T20:30:18Z","updated_at":"2018-06-04T20:30:18Z","author_association":"NONE","body":"[:x:](http://jenkins.jwplayer.com/job/jw7-pr-builder-opensource/3947/) Build for commit 47e8c6d3a23ec5c871ec7cf22fad57191f8e411f failed.\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-opensource/6184/) jwplayer build SUCCESS\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-opensource-unit-tests/3937/) jwplayer browserstack tests SUCCESS\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial/15524/) jwplayer-commercial build SUCCESS\n[:building_construction:](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial-unit-tests/15193/) jwplayer-commercial browserstack tests SUCCESS\n[:cucumber:](https://jenkins.jwplayer.com/view/JW7/job/jw7-commercial-cucumber/12764/allure/) Automated Tests UNSTABLE\n[:eggplant:](http://player-pr-test-jenkins.longtailvideo.com/builds/15524/archive/test/squash/) Manual Tests\n[:tv:](http://player-pr-test-jenkins.longtailvideo.com/builds/15524/archive/test/view/) Views\n"}}
{"actor":{"display_login":"jwplayer-robot"}}