{"action":"created","issue":{"url":"https://api.github.com/repos/coq/coq/issues/7924","repository_url":"https://api.github.com/repos/coq/coq","labels_url":"https://api.github.com/repos/coq/coq/issues/7924/labels{/name}","comments_url":"https://api.github.com/repos/coq/coq/issues/7924/comments","events_url":"https://api.github.com/repos/coq/coq/issues/7924/events","html_url":"https://github.com/coq/coq/pull/7924","id":335750543,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzcwODUz","number":7924,"title":"Ad hoc fix for #5696, #7903 (ltac subterms and open subterms in notations).","user":{"login":"herbelin","id":460771,"node_id":"MDQ6VXNlcjQ2MDc3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"labels":[{"id":485985650,"node_id":"MDU6TGFiZWw0ODU5ODU2NTA=","url":"https://api.github.com/repos/coq/coq/labels/kind:%20fix","name":"kind: fix","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":{"login":"ejgallego","id":7192257,"node_id":"MDQ6VXNlcjcxOTIyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false},"assignees":[{"login":"ejgallego","id":7192257,"node_id":"MDQ6VXNlcjcxOTIyNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/7192257?v=4","gravatar_id":"","url":"https://api.github.com/users/ejgallego","html_url":"https://github.com/ejgallego","followers_url":"https://api.github.com/users/ejgallego/followers","following_url":"https://api.github.com/users/ejgallego/following{/other_user}","gists_url":"https://api.github.com/users/ejgallego/gists{/gist_id}","starred_url":"https://api.github.com/users/ejgallego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejgallego/subscriptions","organizations_url":"https://api.github.com/users/ejgallego/orgs","repos_url":"https://api.github.com/users/ejgallego/repos","events_url":"https://api.github.com/users/ejgallego/events{/privacy}","received_events_url":"https://api.github.com/users/ejgallego/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/coq/coq/milestones/7","html_url":"https://github.com/coq/coq/milestone/7","labels_url":"https://api.github.com/repos/coq/coq/milestones/7/labels","id":2647743,"node_id":"MDk6TWlsZXN0b25lMjY0Nzc0Mw==","number":7,"title":"8.9+beta1","description":"The date of the feature freeze has not been announced yet.","creator":{"login":"Zimmi48","id":1108325,"node_id":"MDQ6VXNlcjExMDgzMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1108325?v=4","gravatar_id":"","url":"https://api.github.com/users/Zimmi48","html_url":"https://github.com/Zimmi48","followers_url":"https://api.github.com/users/Zimmi48/followers","following_url":"https://api.github.com/users/Zimmi48/following{/other_user}","gists_url":"https://api.github.com/users/Zimmi48/gists{/gist_id}","starred_url":"https://api.github.com/users/Zimmi48/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zimmi48/subscriptions","organizations_url":"https://api.github.com/users/Zimmi48/orgs","repos_url":"https://api.github.com/users/Zimmi48/repos","events_url":"https://api.github.com/users/Zimmi48/events{/privacy}","received_events_url":"https://api.github.com/users/Zimmi48/received_events","type":"User","site_admin":false},"open_issues":135,"closed_issues":262,"state":"open","created_at":"2017-07-18T15:03:25Z","updated_at":"2018-06-26T17:17:29Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-06-26T10:14:16Z","updated_at":"2018-06-26T20:31:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/coq/coq/pulls/7924","html_url":"https://github.com/coq/coq/pull/7924","diff_url":"https://github.com/coq/coq/pull/7924.diff","patch_url":"https://github.com/coq/coq/pull/7924.patch"},"body":"We fix the issue by removing terms of the substitutions which have free variables and are thus not interpretable in the context of the `ltac:` subterm.\r\n\r\nThis remains rather ad hoc, since, in an expression `Notation f x := ltac:(foo)`, we interpret `x` at calling time of `foo` rather than at use time of `x` in `foo`, even if `x` is not necessary.\r\n\r\nIndependently, we could also imagine that binders in the ltac expressions are then interpreted but that would start to be (very) complicated.\r\n\r\nNote that this will presumably \"fix\" ltac2 quotations at the same time.\r\n\r\n**Kind:** bug fix\r\n\r\n<!-- If this is a bug fix, make sure the bug was reported beforehand. -->\r\nCloses #5696. Closes #7903.\r\n\r\n- [x] Added / updated test-suite\r\n"},"comment":{"url":"https://api.github.com/repos/coq/coq/issues/comments/400451927","html_url":"https://github.com/coq/coq/pull/7924#issuecomment-400451927","issue_url":"https://api.github.com/repos/coq/coq/issues/7924","id":400451927,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQ1MTkyNw==","user":{"login":"herbelin","id":460771,"node_id":"MDQ6VXNlcjQ2MDc3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/460771?v=4","gravatar_id":"","url":"https://api.github.com/users/herbelin","html_url":"https://github.com/herbelin","followers_url":"https://api.github.com/users/herbelin/followers","following_url":"https://api.github.com/users/herbelin/following{/other_user}","gists_url":"https://api.github.com/users/herbelin/gists{/gist_id}","starred_url":"https://api.github.com/users/herbelin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/herbelin/subscriptions","organizations_url":"https://api.github.com/users/herbelin/orgs","repos_url":"https://api.github.com/users/herbelin/repos","events_url":"https://api.github.com/users/herbelin/events{/privacy}","received_events_url":"https://api.github.com/users/herbelin/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T20:31:56Z","updated_at":"2018-06-26T20:31:56Z","author_association":"MEMBER","body":"Linter fixed."}}
{"actor":{"display_login":"herbelin"}}