{"action":"closed","number":215,"pull_request":{"url":"https://api.github.com/repos/trezor/connect/pulls/215","id":215466094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDY2MDk0","html_url":"https://github.com/trezor/connect/pull/215","diff_url":"https://github.com/trezor/connect/pull/215.diff","patch_url":"https://github.com/trezor/connect/pull/215.patch","issue_url":"https://api.github.com/repos/trezor/connect/issues/215","number":215,"state":"closed","locked":false,"title":"ethereumSignMessage - Skip hex conversion if message is already hex","user":{"login":"cavanmflynn","id":20102664,"node_id":"MDQ6VXNlcjIwMTAyNjY0","avatar_url":"https://avatars3.githubusercontent.com/u/20102664?v=4","gravatar_id":"","url":"https://api.github.com/users/cavanmflynn","html_url":"https://github.com/cavanmflynn","followers_url":"https://api.github.com/users/cavanmflynn/followers","following_url":"https://api.github.com/users/cavanmflynn/following{/other_user}","gists_url":"https://api.github.com/users/cavanmflynn/gists{/gist_id}","starred_url":"https://api.github.com/users/cavanmflynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cavanmflynn/subscriptions","organizations_url":"https://api.github.com/users/cavanmflynn/orgs","repos_url":"https://api.github.com/users/cavanmflynn/repos","events_url":"https://api.github.com/users/cavanmflynn/events{/privacy}","received_events_url":"https://api.github.com/users/cavanmflynn/received_events","type":"User","site_admin":false},"body":"To prevent the data loss issue explained in https://github.com/trezor/connect/issues/216, Trezor Connect should check if the data passed into `ethereumSignMessage` is already hex and only convert if necessary.","created_at":"2018-09-14T02:38:42Z","updated_at":"2018-09-18T11:52:09Z","closed_at":"2018-09-18T11:52:09Z","merged_at":null,"merge_commit_sha":"f6aea4427345cf11867159e29861c1d13c96a585","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trezor/connect/pulls/215/commits","review_comments_url":"https://api.github.com/repos/trezor/connect/pulls/215/comments","review_comment_url":"https://api.github.com/repos/trezor/connect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trezor/connect/issues/215/comments","statuses_url":"https://api.github.com/repos/trezor/connect/statuses/3c8b015b3c42e0d7a1237e20bb6df2f58a900c97","head":{"label":"RadarRelay:v5","ref":"v5","sha":"3c8b015b3c42e0d7a1237e20bb6df2f58a900c97","user":{"login":"RadarRelay","id":30643433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjQzNDMz","avatar_url":"https://avatars1.githubusercontent.com/u/30643433?v=4","gravatar_id":"","url":"https://api.github.com/users/RadarRelay","html_url":"https://github.com/RadarRelay","followers_url":"https://api.github.com/users/RadarRelay/followers","following_url":"https://api.github.com/users/RadarRelay/following{/other_user}","gists_url":"https://api.github.com/users/RadarRelay/gists{/gist_id}","starred_url":"https://api.github.com/users/RadarRelay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadarRelay/subscriptions","organizations_url":"https://api.github.com/users/RadarRelay/orgs","repos_url":"https://api.github.com/users/RadarRelay/repos","events_url":"https://api.github.com/users/RadarRelay/events{/privacy}","received_events_url":"https://api.github.com/users/RadarRelay/received_events","type":"Organization","site_admin":false},"repo":{"id":148508098,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MDgwOTg=","name":"connect","full_name":"RadarRelay/connect","private":false,"owner":{"login":"RadarRelay","id":30643433,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjQzNDMz","avatar_url":"https://avatars1.githubusercontent.com/u/30643433?v=4","gravatar_id":"","url":"https://api.github.com/users/RadarRelay","html_url":"https://github.com/RadarRelay","followers_url":"https://api.github.com/users/RadarRelay/followers","following_url":"https://api.github.com/users/RadarRelay/following{/other_user}","gists_url":"https://api.github.com/users/RadarRelay/gists{/gist_id}","starred_url":"https://api.github.com/users/RadarRelay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RadarRelay/subscriptions","organizations_url":"https://api.github.com/users/RadarRelay/orgs","repos_url":"https://api.github.com/users/RadarRelay/repos","events_url":"https://api.github.com/users/RadarRelay/events{/privacy}","received_events_url":"https://api.github.com/users/RadarRelay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RadarRelay/connect","description":":link: A platform for easy integration of TREZOR into 3rd party services","fork":true,"url":"https://api.github.com/repos/RadarRelay/connect","forks_url":"https://api.github.com/repos/RadarRelay/connect/forks","keys_url":"https://api.github.com/repos/RadarRelay/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RadarRelay/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RadarRelay/connect/teams","hooks_url":"https://api.github.com/repos/RadarRelay/connect/hooks","issue_events_url":"https://api.github.com/repos/RadarRelay/connect/issues/events{/number}","events_url":"https://api.github.com/repos/RadarRelay/connect/events","assignees_url":"https://api.github.com/repos/RadarRelay/connect/assignees{/user}","branches_url":"https://api.github.com/repos/RadarRelay/connect/branches{/branch}","tags_url":"https://api.github.com/repos/RadarRelay/connect/tags","blobs_url":"https://api.github.com/repos/RadarRelay/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RadarRelay/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RadarRelay/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/RadarRelay/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RadarRelay/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/RadarRelay/connect/languages","stargazers_url":"https://api.github.com/repos/RadarRelay/connect/stargazers","contributors_url":"https://api.github.com/repos/RadarRelay/connect/contributors","subscribers_url":"https://api.github.com/repos/RadarRelay/connect/subscribers","subscription_url":"https://api.github.com/repos/RadarRelay/connect/subscription","commits_url":"https://api.github.com/repos/RadarRelay/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/RadarRelay/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/RadarRelay/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/RadarRelay/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/RadarRelay/connect/contents/{+path}","compare_url":"https://api.github.com/repos/RadarRelay/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RadarRelay/connect/merges","archive_url":"https://api.github.com/repos/RadarRelay/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RadarRelay/connect/downloads","issues_url":"https://api.github.com/repos/RadarRelay/connect/issues{/number}","pulls_url":"https://api.github.com/repos/RadarRelay/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/RadarRelay/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/RadarRelay/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RadarRelay/connect/labels{/name}","releases_url":"https://api.github.com/repos/RadarRelay/connect/releases{/id}","deployments_url":"https://api.github.com/repos/RadarRelay/connect/deployments","created_at":"2018-09-12T16:16:33Z","updated_at":"2018-09-12T16:16:35Z","pushed_at":"2018-09-12T20:01:59Z","git_url":"git://github.com/RadarRelay/connect.git","ssh_url":"git@github.com:RadarRelay/connect.git","clone_url":"https://github.com/RadarRelay/connect.git","svn_url":"https://github.com/RadarRelay/connect","homepage":"","size":14708,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"trezor:v5","ref":"v5","sha":"a2df74f686afff5213e773f559f6b0b564e5160c","user":{"login":"trezor","id":4146447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNDY0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4146447?v=4","gravatar_id":"","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"repo":{"id":31175016,"node_id":"MDEwOlJlcG9zaXRvcnkzMTE3NTAxNg==","name":"connect","full_name":"trezor/connect","private":false,"owner":{"login":"trezor","id":4146447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNDY0NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4146447?v=4","gravatar_id":"","url":"https://api.github.com/users/trezor","html_url":"https://github.com/trezor","followers_url":"https://api.github.com/users/trezor/followers","following_url":"https://api.github.com/users/trezor/following{/other_user}","gists_url":"https://api.github.com/users/trezor/gists{/gist_id}","starred_url":"https://api.github.com/users/trezor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trezor/subscriptions","organizations_url":"https://api.github.com/users/trezor/orgs","repos_url":"https://api.github.com/users/trezor/repos","events_url":"https://api.github.com/users/trezor/events{/privacy}","received_events_url":"https://api.github.com/users/trezor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trezor/connect","description":":link: A platform for easy integration of TREZOR into 3rd party services","fork":false,"url":"https://api.github.com/repos/trezor/connect","forks_url":"https://api.github.com/repos/trezor/connect/forks","keys_url":"https://api.github.com/repos/trezor/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trezor/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trezor/connect/teams","hooks_url":"https://api.github.com/repos/trezor/connect/hooks","issue_events_url":"https://api.github.com/repos/trezor/connect/issues/events{/number}","events_url":"https://api.github.com/repos/trezor/connect/events","assignees_url":"https://api.github.com/repos/trezor/connect/assignees{/user}","branches_url":"https://api.github.com/repos/trezor/connect/branches{/branch}","tags_url":"https://api.github.com/repos/trezor/connect/tags","blobs_url":"https://api.github.com/repos/trezor/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trezor/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trezor/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/trezor/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trezor/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/trezor/connect/languages","stargazers_url":"https://api.github.com/repos/trezor/connect/stargazers","contributors_url":"https://api.github.com/repos/trezor/connect/contributors","subscribers_url":"https://api.github.com/repos/trezor/connect/subscribers","subscription_url":"https://api.github.com/repos/trezor/connect/subscription","commits_url":"https://api.github.com/repos/trezor/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/trezor/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/trezor/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/trezor/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/trezor/connect/contents/{+path}","compare_url":"https://api.github.com/repos/trezor/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trezor/connect/merges","archive_url":"https://api.github.com/repos/trezor/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trezor/connect/downloads","issues_url":"https://api.github.com/repos/trezor/connect/issues{/number}","pulls_url":"https://api.github.com/repos/trezor/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/trezor/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/trezor/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trezor/connect/labels{/name}","releases_url":"https://api.github.com/repos/trezor/connect/releases{/id}","deployments_url":"https://api.github.com/repos/trezor/connect/deployments","created_at":"2015-02-22T18:57:43Z","updated_at":"2018-09-17T17:51:04Z","pushed_at":"2018-09-18T11:49:36Z","git_url":"git://github.com/trezor/connect.git","ssh_url":"git@github.com:trezor/connect.git","clone_url":"https://github.com/trezor/connect.git","svn_url":"https://github.com/trezor/connect","homepage":"","size":14732,"stargazers_count":154,"watchers_count":154,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":97,"open_issues":8,"watchers":154,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/trezor/connect/pulls/215"},"html":{"href":"https://github.com/trezor/connect/pull/215"},"issue":{"href":"https://api.github.com/repos/trezor/connect/issues/215"},"comments":{"href":"https://api.github.com/repos/trezor/connect/issues/215/comments"},"review_comments":{"href":"https://api.github.com/repos/trezor/connect/pulls/215/comments"},"review_comment":{"href":"https://api.github.com/repos/trezor/connect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trezor/connect/pulls/215/commits"},"statuses":{"href":"https://api.github.com/repos/trezor/connect/statuses/3c8b015b3c42e0d7a1237e20bb6df2f58a900c97"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"szymonlesisz"}}