{"action":"created","issue":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2180","repository_url":"https://api.github.com/repos/hibernate/hibernate-orm","labels_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2180/labels{/name}","comments_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2180/comments","events_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2180/events","html_url":"https://github.com/hibernate/hibernate-orm/pull/2180","id":302406718,"number":2180,"title":"HHH-12332 Fix for NPE in AbstractPropertyMapping.getSuperCollection","user":{"login":"beikov","id":358916,"avatar_url":"https://avatars0.githubusercontent.com/u/358916?v=4","gravatar_id":"","url":"https://api.github.com/users/beikov","html_url":"https://github.com/beikov","followers_url":"https://api.github.com/users/beikov/followers","following_url":"https://api.github.com/users/beikov/following{/other_user}","gists_url":"https://api.github.com/users/beikov/gists{/gist_id}","starred_url":"https://api.github.com/users/beikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beikov/subscriptions","organizations_url":"https://api.github.com/users/beikov/orgs","repos_url":"https://api.github.com/users/beikov/repos","events_url":"https://api.github.com/users/beikov/events{/privacy}","received_events_url":"https://api.github.com/users/beikov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-05T18:16:27Z","updated_at":"2018-03-07T14:55:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/pulls/2180","html_url":"https://github.com/hibernate/hibernate-orm/pull/2180","diff_url":"https://github.com/hibernate/hibernate-orm/pull/2180.diff","patch_url":"https://github.com/hibernate/hibernate-orm/pull/2180.patch"},"body":"https://hibernate.atlassian.net/browse/HHH-12332\r\n\r\nStill running tests locally, but this should do it. Essentially, I compare the element types for \"equality\" to determine whether a collection was defined with a type variable on an abstract entity base type and if it is, I bail out. I was sketching a proper fix for type variable use with collections as well here: https://github.com/beikov/hibernate-orm/tree/HHH-12332-2\r\n\r\nbut it's not so easy since there is no `CollectionBinding` for type variable defined collections on abstract entity types."},"comment":{"url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/comments/371164148","html_url":"https://github.com/hibernate/hibernate-orm/pull/2180#issuecomment-371164148","issue_url":"https://api.github.com/repos/hibernate/hibernate-orm/issues/2180","id":371164148,"user":{"login":"toughpheeckouse","id":16102607,"avatar_url":"https://avatars1.githubusercontent.com/u/16102607?v=4","gravatar_id":"","url":"https://api.github.com/users/toughpheeckouse","html_url":"https://github.com/toughpheeckouse","followers_url":"https://api.github.com/users/toughpheeckouse/followers","following_url":"https://api.github.com/users/toughpheeckouse/following{/other_user}","gists_url":"https://api.github.com/users/toughpheeckouse/gists{/gist_id}","starred_url":"https://api.github.com/users/toughpheeckouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toughpheeckouse/subscriptions","organizations_url":"https://api.github.com/users/toughpheeckouse/orgs","repos_url":"https://api.github.com/users/toughpheeckouse/repos","events_url":"https://api.github.com/users/toughpheeckouse/events{/privacy}","received_events_url":"https://api.github.com/users/toughpheeckouse/received_events","type":"User","site_admin":false},"created_at":"2018-03-07T14:55:24Z","updated_at":"2018-03-07T14:55:24Z","author_association":"NONE","body":"Hi @beikov \r\n\r\nI get this NPE for attached sample\r\n[hibernate-sandbox.zip](https://github.com/hibernate/hibernate-orm/files/1789512/hibernate-sandbox.zip)\r\nCould you test it for your PR?\r\n\r\nAbount sample - this is Spring Boot Application with sample model that emulate real model\r\n\r\nif you run it like this\r\nmvn clean install\r\njava -jar target/hibernate-sandbox-0.0.1-SNAPSHOT.jar\r\n\r\nthen you'll get NPE\r\n\r\nBut if you run it this way\r\nmvn clean install -P hibernate-12\r\njava -jar -Dspring.profiles.active=hibernate-12 target/hibernate-sandbox-0.0.1-SNAPSHOT.jar\r\n\r\nthen everething will ok because it will use hibernate 5.2.12.Final\r\n"}}
{"actor":{"display_login":"toughpheeckouse"}}