{"action":"created","issue":{"url":"https://api.github.com/repos/vc1492a/PyNomaly/issues/20","repository_url":"https://api.github.com/repos/vc1492a/PyNomaly","labels_url":"https://api.github.com/repos/vc1492a/PyNomaly/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/vc1492a/PyNomaly/issues/20/comments","events_url":"https://api.github.com/repos/vc1492a/PyNomaly/issues/20/events","html_url":"https://github.com/vc1492a/PyNomaly/issues/20","id":381371111,"node_id":"MDU6SXNzdWUzODEzNzExMTE=","number":20,"title":"Algorithm Discrepancies","user":{"login":"blakeBam","id":26078206,"node_id":"MDQ6VXNlcjI2MDc4MjA2","avatar_url":"https://avatars1.githubusercontent.com/u/26078206?v=4","gravatar_id":"","url":"https://api.github.com/users/blakeBam","html_url":"https://github.com/blakeBam","followers_url":"https://api.github.com/users/blakeBam/followers","following_url":"https://api.github.com/users/blakeBam/following{/other_user}","gists_url":"https://api.github.com/users/blakeBam/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeBam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeBam/subscriptions","organizations_url":"https://api.github.com/users/blakeBam/orgs","repos_url":"https://api.github.com/users/blakeBam/repos","events_url":"https://api.github.com/users/blakeBam/events{/privacy}","received_events_url":"https://api.github.com/users/blakeBam/received_events","type":"User","site_admin":false},"labels":[{"id":609048697,"node_id":"MDU6TGFiZWw2MDkwNDg2OTc=","url":"https://api.github.com/repos/vc1492a/PyNomaly/labels/bug","name":"bug","color":"fbca04","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-15T22:42:47Z","updated_at":"2018-11-16T15:55:04Z","closed_at":null,"author_association":"NONE","body":"Recently I've had to do outlier analysis for work and came across your package which neatly implements LoOP. When I was reading through the source code, I noticed two spots where the calculations don't seem to line up with what was described in the [paper](http://www.dbs.ifi.lmu.de/Publikationen/Papers/LoOP1649.pdf). There may be good reasons why it differs from the original algorithm (or I'm misreading it entirely).\r\n\r\n1. When calculating the PLOF for an object O, the expected value used in this package is the expected value of every pdist value, where the paper says to just use the expected value for the pdist of objects that are in O's neighborhood\r\n\r\n2. In the calculation of the nPLOF, first _prob_local_outlier_factors_ev calculates the expected value for PLOF squared just fine, but followed up after in _norm_prob_outlier_factor the value is again squared and sqaure rooted. The paper just specifies a square root and not another square.\r\n\r\nI was just wondering if there was a reason for the deviation from the paper in these regards.\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/vc1492a/PyNomaly/issues/comments/439437568","html_url":"https://github.com/vc1492a/PyNomaly/issues/20#issuecomment-439437568","issue_url":"https://api.github.com/repos/vc1492a/PyNomaly/issues/20","id":439437568,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTQzNzU2OA==","user":{"login":"blakeBam","id":26078206,"node_id":"MDQ6VXNlcjI2MDc4MjA2","avatar_url":"https://avatars1.githubusercontent.com/u/26078206?v=4","gravatar_id":"","url":"https://api.github.com/users/blakeBam","html_url":"https://github.com/blakeBam","followers_url":"https://api.github.com/users/blakeBam/followers","following_url":"https://api.github.com/users/blakeBam/following{/other_user}","gists_url":"https://api.github.com/users/blakeBam/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeBam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeBam/subscriptions","organizations_url":"https://api.github.com/users/blakeBam/orgs","repos_url":"https://api.github.com/users/blakeBam/repos","events_url":"https://api.github.com/users/blakeBam/events{/privacy}","received_events_url":"https://api.github.com/users/blakeBam/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T15:55:04Z","updated_at":"2018-11-16T15:55:04Z","author_association":"NONE","body":"@vc1492a I'll get to work on that. One issue I can see with relations to my problem, is how to handle the case where the points in a neighborhood of a point are the point itself. This would make the expected value 0 and the PLOF value infinite as well as the nPLOF value infinite. Do you know of a way to properly handle this situation?"}}
{"actor":{"display_login":"blakeBam"}}