{"action":"created","comment":{"url":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments/224270351","pull_request_review_id":163596827,"id":224270351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI3MDM1MQ==","diff_hunk":"@@ -42,62 +46,77 @@ def find_existing_status\n   end\n \n   def process_status_params\n-    {\n-      uri: @object['id'],\n-      url: object_url || @object['id'],\n-      account: @account,\n-      text: text_from_content || '',\n-      language: detected_language,\n-      spoiler_text: text_from_summary || '',\n-      created_at: @object['published'],\n-      override_timestamps: @options[:override_timestamps],\n-      reply: @object['inReplyTo'].present?,\n-      sensitive: @object['sensitive'] || false,\n-      visibility: visibility_from_audience,\n-      thread: replied_to_status,\n-      conversation: conversation_from_uri(@object['conversation']),\n-      media_attachment_ids: process_attachments.take(4).map(&:id),\n-    }\n-  end\n-\n-  def process_tags(status)\n+    @params = begin","path":"app/lib/activitypub/activity/create.rb","position":44,"original_position":43,"commit_id":"16a884c37bb0218b62aa2093663970dcaeee16b8","original_commit_id":"542154ab6a71043697d39b2f7a294760bb19c77c","user":{"login":"nightpool","id":233815,"node_id":"MDQ6VXNlcjIzMzgxNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/233815?v=4","gravatar_id":"","url":"https://api.github.com/users/nightpool","html_url":"https://github.com/nightpool","followers_url":"https://api.github.com/users/nightpool/followers","following_url":"https://api.github.com/users/nightpool/following{/other_user}","gists_url":"https://api.github.com/users/nightpool/gists{/gist_id}","starred_url":"https://api.github.com/users/nightpool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightpool/subscriptions","organizations_url":"https://api.github.com/users/nightpool/orgs","repos_url":"https://api.github.com/users/nightpool/repos","events_url":"https://api.github.com/users/nightpool/events{/privacy}","received_events_url":"https://api.github.com/users/nightpool/received_events","type":"User","site_admin":false},"body":"My understanding is that the default Layout/AlignHash and [Layout/IndentHash](https://www.rubydoc.info/github/bbatsov/RuboCop/RuboCop/Cop/Layout/IndentHash) rule should pass with this code:\r\n\r\n    hash = {\r\n      foo: bar,\r\n      baz: boo,\r\n    }","created_at":"2018-10-10T23:10:30Z","updated_at":"2018-10-10T23:10:30Z","html_url":"https://github.com/tootsuite/mastodon/pull/8951#discussion_r224270351","pull_request_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments/224270351"},"html":{"href":"https://github.com/tootsuite/mastodon/pull/8951#discussion_r224270351"},"pull_request":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951"}},"in_reply_to_id":224264943},"pull_request":{"url":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951","id":221954568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTU0NTY4","html_url":"https://github.com/tootsuite/mastodon/pull/8951","diff_url":"https://github.com/tootsuite/mastodon/pull/8951.diff","patch_url":"https://github.com/tootsuite/mastodon/pull/8951.patch","issue_url":"https://api.github.com/repos/tootsuite/mastodon/issues/8951","number":8951,"state":"closed","locked":false,"title":"Move network calls out of transaction in ActivityPub handler","user":{"login":"Gargron","id":184731,"node_id":"MDQ6VXNlcjE4NDczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/184731?v=4","gravatar_id":"","url":"https://api.github.com/users/Gargron","html_url":"https://github.com/Gargron","followers_url":"https://api.github.com/users/Gargron/followers","following_url":"https://api.github.com/users/Gargron/following{/other_user}","gists_url":"https://api.github.com/users/Gargron/gists{/gist_id}","starred_url":"https://api.github.com/users/Gargron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gargron/subscriptions","organizations_url":"https://api.github.com/users/Gargron/orgs","repos_url":"https://api.github.com/users/Gargron/repos","events_url":"https://api.github.com/users/Gargron/events{/privacy}","received_events_url":"https://api.github.com/users/Gargron/received_events","type":"User","site_admin":false},"body":"Mention and emoji code may perform network calls, but does not need\r\nto do that inside the database transaction. This may improve availability\r\nof database connections when using pgBouncer in transaction mode.","created_at":"2018-10-10T22:37:01Z","updated_at":"2018-10-10T23:10:30Z","closed_at":"2018-10-10T22:50:19Z","merged_at":"2018-10-10T22:50:19Z","merge_commit_sha":"790d3bc6370f1baf0d00ccf89e81387204c65194","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":628235234,"node_id":"MDU6TGFiZWw2MjgyMzUyMzQ=","url":"https://api.github.com/repos/tootsuite/mastodon/labels/performance","name":"performance","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951/commits","review_comments_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951/comments","review_comment_url":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tootsuite/mastodon/issues/8951/comments","statuses_url":"https://api.github.com/repos/tootsuite/mastodon/statuses/16a884c37bb0218b62aa2093663970dcaeee16b8","head":{"label":"tootsuite:fix-network-in-transaction","ref":"fix-network-in-transaction","sha":"16a884c37bb0218b62aa2093663970dcaeee16b8","user":{"login":"tootsuite","id":24979032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTc5MDMy","avatar_url":"https://avatars3.githubusercontent.com/u/24979032?v=4","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":52281283,"node_id":"MDEwOlJlcG9zaXRvcnk1MjI4MTI4Mw==","name":"mastodon","full_name":"tootsuite/mastodon","private":false,"owner":{"login":"tootsuite","id":24979032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTc5MDMy","avatar_url":"https://avatars3.githubusercontent.com/u/24979032?v=4","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tootsuite/mastodon","description":"Your self-hosted, globally interconnected microblogging community","fork":false,"url":"https://api.github.com/repos/tootsuite/mastodon","forks_url":"https://api.github.com/repos/tootsuite/mastodon/forks","keys_url":"https://api.github.com/repos/tootsuite/mastodon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tootsuite/mastodon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tootsuite/mastodon/teams","hooks_url":"https://api.github.com/repos/tootsuite/mastodon/hooks","issue_events_url":"https://api.github.com/repos/tootsuite/mastodon/issues/events{/number}","events_url":"https://api.github.com/repos/tootsuite/mastodon/events","assignees_url":"https://api.github.com/repos/tootsuite/mastodon/assignees{/user}","branches_url":"https://api.github.com/repos/tootsuite/mastodon/branches{/branch}","tags_url":"https://api.github.com/repos/tootsuite/mastodon/tags","blobs_url":"https://api.github.com/repos/tootsuite/mastodon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tootsuite/mastodon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tootsuite/mastodon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tootsuite/mastodon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tootsuite/mastodon/statuses/{sha}","languages_url":"https://api.github.com/repos/tootsuite/mastodon/languages","stargazers_url":"https://api.github.com/repos/tootsuite/mastodon/stargazers","contributors_url":"https://api.github.com/repos/tootsuite/mastodon/contributors","subscribers_url":"https://api.github.com/repos/tootsuite/mastodon/subscribers","subscription_url":"https://api.github.com/repos/tootsuite/mastodon/subscription","commits_url":"https://api.github.com/repos/tootsuite/mastodon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tootsuite/mastodon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tootsuite/mastodon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tootsuite/mastodon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tootsuite/mastodon/contents/{+path}","compare_url":"https://api.github.com/repos/tootsuite/mastodon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tootsuite/mastodon/merges","archive_url":"https://api.github.com/repos/tootsuite/mastodon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tootsuite/mastodon/downloads","issues_url":"https://api.github.com/repos/tootsuite/mastodon/issues{/number}","pulls_url":"https://api.github.com/repos/tootsuite/mastodon/pulls{/number}","milestones_url":"https://api.github.com/repos/tootsuite/mastodon/milestones{/number}","notifications_url":"https://api.github.com/repos/tootsuite/mastodon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tootsuite/mastodon/labels{/name}","releases_url":"https://api.github.com/repos/tootsuite/mastodon/releases{/id}","deployments_url":"https://api.github.com/repos/tootsuite/mastodon/deployments","created_at":"2016-02-22T15:01:25Z","updated_at":"2018-10-10T22:50:31Z","pushed_at":"2018-10-10T23:00:54Z","git_url":"git://github.com/tootsuite/mastodon.git","ssh_url":"git@github.com:tootsuite/mastodon.git","clone_url":"https://github.com/tootsuite/mastodon.git","svn_url":"https://github.com/tootsuite/mastodon","homepage":"https://joinmastodon.org","size":64200,"stargazers_count":15481,"watchers_count":15481,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2743,"mirror_url":null,"archived":false,"open_issues_count":1096,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2743,"open_issues":1096,"watchers":15481,"default_branch":"master"}},"base":{"label":"tootsuite:master","ref":"master","sha":"ac7df62a0441b95ec04fd9111a9394795dd53ff2","user":{"login":"tootsuite","id":24979032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTc5MDMy","avatar_url":"https://avatars3.githubusercontent.com/u/24979032?v=4","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":52281283,"node_id":"MDEwOlJlcG9zaXRvcnk1MjI4MTI4Mw==","name":"mastodon","full_name":"tootsuite/mastodon","private":false,"owner":{"login":"tootsuite","id":24979032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTc5MDMy","avatar_url":"https://avatars3.githubusercontent.com/u/24979032?v=4","gravatar_id":"","url":"https://api.github.com/users/tootsuite","html_url":"https://github.com/tootsuite","followers_url":"https://api.github.com/users/tootsuite/followers","following_url":"https://api.github.com/users/tootsuite/following{/other_user}","gists_url":"https://api.github.com/users/tootsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/tootsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tootsuite/subscriptions","organizations_url":"https://api.github.com/users/tootsuite/orgs","repos_url":"https://api.github.com/users/tootsuite/repos","events_url":"https://api.github.com/users/tootsuite/events{/privacy}","received_events_url":"https://api.github.com/users/tootsuite/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tootsuite/mastodon","description":"Your self-hosted, globally interconnected microblogging community","fork":false,"url":"https://api.github.com/repos/tootsuite/mastodon","forks_url":"https://api.github.com/repos/tootsuite/mastodon/forks","keys_url":"https://api.github.com/repos/tootsuite/mastodon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tootsuite/mastodon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tootsuite/mastodon/teams","hooks_url":"https://api.github.com/repos/tootsuite/mastodon/hooks","issue_events_url":"https://api.github.com/repos/tootsuite/mastodon/issues/events{/number}","events_url":"https://api.github.com/repos/tootsuite/mastodon/events","assignees_url":"https://api.github.com/repos/tootsuite/mastodon/assignees{/user}","branches_url":"https://api.github.com/repos/tootsuite/mastodon/branches{/branch}","tags_url":"https://api.github.com/repos/tootsuite/mastodon/tags","blobs_url":"https://api.github.com/repos/tootsuite/mastodon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tootsuite/mastodon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tootsuite/mastodon/git/refs{/sha}","trees_url":"https://api.github.com/repos/tootsuite/mastodon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tootsuite/mastodon/statuses/{sha}","languages_url":"https://api.github.com/repos/tootsuite/mastodon/languages","stargazers_url":"https://api.github.com/repos/tootsuite/mastodon/stargazers","contributors_url":"https://api.github.com/repos/tootsuite/mastodon/contributors","subscribers_url":"https://api.github.com/repos/tootsuite/mastodon/subscribers","subscription_url":"https://api.github.com/repos/tootsuite/mastodon/subscription","commits_url":"https://api.github.com/repos/tootsuite/mastodon/commits{/sha}","git_commits_url":"https://api.github.com/repos/tootsuite/mastodon/git/commits{/sha}","comments_url":"https://api.github.com/repos/tootsuite/mastodon/comments{/number}","issue_comment_url":"https://api.github.com/repos/tootsuite/mastodon/issues/comments{/number}","contents_url":"https://api.github.com/repos/tootsuite/mastodon/contents/{+path}","compare_url":"https://api.github.com/repos/tootsuite/mastodon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tootsuite/mastodon/merges","archive_url":"https://api.github.com/repos/tootsuite/mastodon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tootsuite/mastodon/downloads","issues_url":"https://api.github.com/repos/tootsuite/mastodon/issues{/number}","pulls_url":"https://api.github.com/repos/tootsuite/mastodon/pulls{/number}","milestones_url":"https://api.github.com/repos/tootsuite/mastodon/milestones{/number}","notifications_url":"https://api.github.com/repos/tootsuite/mastodon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tootsuite/mastodon/labels{/name}","releases_url":"https://api.github.com/repos/tootsuite/mastodon/releases{/id}","deployments_url":"https://api.github.com/repos/tootsuite/mastodon/deployments","created_at":"2016-02-22T15:01:25Z","updated_at":"2018-10-10T22:50:31Z","pushed_at":"2018-10-10T23:00:54Z","git_url":"git://github.com/tootsuite/mastodon.git","ssh_url":"git@github.com:tootsuite/mastodon.git","clone_url":"https://github.com/tootsuite/mastodon.git","svn_url":"https://github.com/tootsuite/mastodon","homepage":"https://joinmastodon.org","size":64200,"stargazers_count":15481,"watchers_count":15481,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2743,"mirror_url":null,"archived":false,"open_issues_count":1096,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2743,"open_issues":1096,"watchers":15481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951"},"html":{"href":"https://github.com/tootsuite/mastodon/pull/8951"},"issue":{"href":"https://api.github.com/repos/tootsuite/mastodon/issues/8951"},"comments":{"href":"https://api.github.com/repos/tootsuite/mastodon/issues/8951/comments"},"review_comments":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951/comments"},"review_comment":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tootsuite/mastodon/pulls/8951/commits"},"statuses":{"href":"https://api.github.com/repos/tootsuite/mastodon/statuses/16a884c37bb0218b62aa2093663970dcaeee16b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nightpool"}}