{"action":"created","comment":{"url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments/169331639","pull_request_review_id":97839638,"id":169331639,"diff_hunk":"@@ -81,6 +81,21 @@ public GameResultViewModel()\n         /// </summary>\n         public byte GameNumber { get; set; }\n \n+        /// <summary>\n+        /// Gets or sets the number of the game in the tournament\n+        /// </summary>\n+        public string FormatedGameNumber\n+        {\n+            get\n+            {\n+                return \"G\" + ((int)GameNumber).ToString();\n+            }\n+            set\n+            { ","path":"src/VolleyManagement.Backend/VolleyManagement.UI/Areas/Mvc/ViewModels/GameResults/GameResultViewModel.cs","position":14,"original_position":14,"commit_id":"afbdd531900bb9586e88949a85d76f40c1f09fd1","original_commit_id":"afbdd531900bb9586e88949a85d76f40c1f09fd1","user":{"login":"volleymanagement-sonarqube","id":36261038,"avatar_url":"https://avatars1.githubusercontent.com/u/36261038?v=4","gravatar_id":"","url":"https://api.github.com/users/volleymanagement-sonarqube","html_url":"https://github.com/volleymanagement-sonarqube","followers_url":"https://api.github.com/users/volleymanagement-sonarqube/followers","following_url":"https://api.github.com/users/volleymanagement-sonarqube/following{/other_user}","gists_url":"https://api.github.com/users/volleymanagement-sonarqube/gists{/gist_id}","starred_url":"https://api.github.com/users/volleymanagement-sonarqube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volleymanagement-sonarqube/subscriptions","organizations_url":"https://api.github.com/users/volleymanagement-sonarqube/orgs","repos_url":"https://api.github.com/users/volleymanagement-sonarqube/repos","events_url":"https://api.github.com/users/volleymanagement-sonarqube/events{/privacy}","received_events_url":"https://api.github.com/users/volleymanagement-sonarqube/received_events","type":"User","site_admin":false},"body":"![MAJOR](https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR') Either remove or fill this block of code. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=csharpsquid%3AS108)\n","created_at":"2018-02-20T14:19:42Z","updated_at":"2018-02-20T14:19:43Z","html_url":"https://github.com/VolleyManagement/volley-management/pull/170#discussion_r169331639","pull_request_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments/169331639"},"html":{"href":"https://github.com/VolleyManagement/volley-management/pull/170#discussion_r169331639"},"pull_request":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170","id":169996852,"html_url":"https://github.com/VolleyManagement/volley-management/pull/170","diff_url":"https://github.com/VolleyManagement/volley-management/pull/170.diff","patch_url":"https://github.com/VolleyManagement/volley-management/pull/170.patch","issue_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/170","number":170,"state":"open","locked":false,"title":"Show game number in schedule view","user":{"login":"ViznyakS","id":11724508,"avatar_url":"https://avatars0.githubusercontent.com/u/11724508?v=4","gravatar_id":"","url":"https://api.github.com/users/ViznyakS","html_url":"https://github.com/ViznyakS","followers_url":"https://api.github.com/users/ViznyakS/followers","following_url":"https://api.github.com/users/ViznyakS/following{/other_user}","gists_url":"https://api.github.com/users/ViznyakS/gists{/gist_id}","starred_url":"https://api.github.com/users/ViznyakS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViznyakS/subscriptions","organizations_url":"https://api.github.com/users/ViznyakS/orgs","repos_url":"https://api.github.com/users/ViznyakS/repos","events_url":"https://api.github.com/users/ViznyakS/events{/privacy}","received_events_url":"https://api.github.com/users/ViznyakS/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nEach game has a number. Display  number along with game on Schedule page, on the left side in the midel of teams name.\r\n\r\nModify view:\r\n- _PlayoffGameResult\r\n- _ScheduleGameResult\r\n\r\n### Areas Of Interest\r\n\r\nShould I create partial view to display number in PlayOff, because thare is a duplicated code.\r\n\r\n### Checklist\r\n\r\n#### Design\r\n\r\n- [ ] Web API layer contains as little logic as possible\r\n- [ ] Domain objects use semantic names\r\n\r\n#### Perfromance\r\n\r\n- [ ] In case of any DB query was changed: attach generated SQL for review\r\n- [ ] Number of DB roundtrips should be as low as possible\r\n\r\n#### Unit Tests\r\n\r\n- [ ] Naming: Initial state and expected result are properly stated\r\n- [ ] Test follows [AAA](https://medium.com/@pjbgf/title-testing-code-ocd-and-the-aaa-pattern-df453975ab80) pattern.\r\n- [ ] Test is Isolated\r\n- [ ] Mock instances and expected instances do not share references","created_at":"2018-02-19T15:56:20Z","updated_at":"2018-02-20T14:19:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57ef519764d4547dcd7fc8150d0d70d20c24be46","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170/commits","review_comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170/comments","review_comment_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/170/comments","statuses_url":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/afbdd531900bb9586e88949a85d76f40c1f09fd1","head":{"label":"VolleyManagement:issue_#132_show_game_number_in_Schedule","ref":"issue_#132_show_game_number_in_Schedule","sha":"afbdd531900bb9586e88949a85d76f40c1f09fd1","user":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"repo":{"id":117831469,"name":"volley-management","full_name":"VolleyManagement/volley-management","owner":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VolleyManagement/volley-management","description":null,"fork":false,"url":"https://api.github.com/repos/VolleyManagement/volley-management","forks_url":"https://api.github.com/repos/VolleyManagement/volley-management/forks","keys_url":"https://api.github.com/repos/VolleyManagement/volley-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VolleyManagement/volley-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VolleyManagement/volley-management/teams","hooks_url":"https://api.github.com/repos/VolleyManagement/volley-management/hooks","issue_events_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/events{/number}","events_url":"https://api.github.com/repos/VolleyManagement/volley-management/events","assignees_url":"https://api.github.com/repos/VolleyManagement/volley-management/assignees{/user}","branches_url":"https://api.github.com/repos/VolleyManagement/volley-management/branches{/branch}","tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/tags","blobs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/{sha}","languages_url":"https://api.github.com/repos/VolleyManagement/volley-management/languages","stargazers_url":"https://api.github.com/repos/VolleyManagement/volley-management/stargazers","contributors_url":"https://api.github.com/repos/VolleyManagement/volley-management/contributors","subscribers_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscribers","subscription_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscription","commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/VolleyManagement/volley-management/contents/{+path}","compare_url":"https://api.github.com/repos/VolleyManagement/volley-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VolleyManagement/volley-management/merges","archive_url":"https://api.github.com/repos/VolleyManagement/volley-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VolleyManagement/volley-management/downloads","issues_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues{/number}","pulls_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls{/number}","milestones_url":"https://api.github.com/repos/VolleyManagement/volley-management/milestones{/number}","notifications_url":"https://api.github.com/repos/VolleyManagement/volley-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VolleyManagement/volley-management/labels{/name}","releases_url":"https://api.github.com/repos/VolleyManagement/volley-management/releases{/id}","deployments_url":"https://api.github.com/repos/VolleyManagement/volley-management/deployments","created_at":"2018-01-17T12:12:11Z","updated_at":"2018-02-07T13:31:46Z","pushed_at":"2018-02-20T14:10:32Z","git_url":"git://github.com/VolleyManagement/volley-management.git","ssh_url":"git@github.com:VolleyManagement/volley-management.git","clone_url":"https://github.com/VolleyManagement/volley-management.git","svn_url":"https://github.com/VolleyManagement/volley-management","homepage":null,"size":7708,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":88,"watchers":0,"default_branch":"master"}},"base":{"label":"VolleyManagement:master","ref":"master","sha":"11572d7cfc7fbb6cac5c70b968efefab2428800c","user":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"repo":{"id":117831469,"name":"volley-management","full_name":"VolleyManagement/volley-management","owner":{"login":"VolleyManagement","id":35527584,"avatar_url":"https://avatars3.githubusercontent.com/u/35527584?v=4","gravatar_id":"","url":"https://api.github.com/users/VolleyManagement","html_url":"https://github.com/VolleyManagement","followers_url":"https://api.github.com/users/VolleyManagement/followers","following_url":"https://api.github.com/users/VolleyManagement/following{/other_user}","gists_url":"https://api.github.com/users/VolleyManagement/gists{/gist_id}","starred_url":"https://api.github.com/users/VolleyManagement/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VolleyManagement/subscriptions","organizations_url":"https://api.github.com/users/VolleyManagement/orgs","repos_url":"https://api.github.com/users/VolleyManagement/repos","events_url":"https://api.github.com/users/VolleyManagement/events{/privacy}","received_events_url":"https://api.github.com/users/VolleyManagement/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VolleyManagement/volley-management","description":null,"fork":false,"url":"https://api.github.com/repos/VolleyManagement/volley-management","forks_url":"https://api.github.com/repos/VolleyManagement/volley-management/forks","keys_url":"https://api.github.com/repos/VolleyManagement/volley-management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VolleyManagement/volley-management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VolleyManagement/volley-management/teams","hooks_url":"https://api.github.com/repos/VolleyManagement/volley-management/hooks","issue_events_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/events{/number}","events_url":"https://api.github.com/repos/VolleyManagement/volley-management/events","assignees_url":"https://api.github.com/repos/VolleyManagement/volley-management/assignees{/user}","branches_url":"https://api.github.com/repos/VolleyManagement/volley-management/branches{/branch}","tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/tags","blobs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/refs{/sha}","trees_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/{sha}","languages_url":"https://api.github.com/repos/VolleyManagement/volley-management/languages","stargazers_url":"https://api.github.com/repos/VolleyManagement/volley-management/stargazers","contributors_url":"https://api.github.com/repos/VolleyManagement/volley-management/contributors","subscribers_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscribers","subscription_url":"https://api.github.com/repos/VolleyManagement/volley-management/subscription","commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/commits{/sha}","git_commits_url":"https://api.github.com/repos/VolleyManagement/volley-management/git/commits{/sha}","comments_url":"https://api.github.com/repos/VolleyManagement/volley-management/comments{/number}","issue_comment_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues/comments{/number}","contents_url":"https://api.github.com/repos/VolleyManagement/volley-management/contents/{+path}","compare_url":"https://api.github.com/repos/VolleyManagement/volley-management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VolleyManagement/volley-management/merges","archive_url":"https://api.github.com/repos/VolleyManagement/volley-management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VolleyManagement/volley-management/downloads","issues_url":"https://api.github.com/repos/VolleyManagement/volley-management/issues{/number}","pulls_url":"https://api.github.com/repos/VolleyManagement/volley-management/pulls{/number}","milestones_url":"https://api.github.com/repos/VolleyManagement/volley-management/milestones{/number}","notifications_url":"https://api.github.com/repos/VolleyManagement/volley-management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VolleyManagement/volley-management/labels{/name}","releases_url":"https://api.github.com/repos/VolleyManagement/volley-management/releases{/id}","deployments_url":"https://api.github.com/repos/VolleyManagement/volley-management/deployments","created_at":"2018-01-17T12:12:11Z","updated_at":"2018-02-07T13:31:46Z","pushed_at":"2018-02-20T14:10:32Z","git_url":"git://github.com/VolleyManagement/volley-management.git","ssh_url":"git@github.com:VolleyManagement/volley-management.git","clone_url":"https://github.com/VolleyManagement/volley-management.git","svn_url":"https://github.com/VolleyManagement/volley-management","homepage":null,"size":7708,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":88,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170"},"html":{"href":"https://github.com/VolleyManagement/volley-management/pull/170"},"issue":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/issues/170"},"comments":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/VolleyManagement/volley-management/statuses/afbdd531900bb9586e88949a85d76f40c1f09fd1"}},"author_association":"NONE"}}
{"actor":{"display_login":"volleymanagement-sonarqube"}}