{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/225696650","pull_request_review_id":165353430,"id":225696650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTY5NjY1MA==","diff_hunk":"@@ -1312,46 +1296,155 @@ void CConnman::SocketHandler()\n             if (pnode->hSocket == INVALID_SOCKET)\n                 continue;\n \n-            FD_SET(pnode->hSocket, &fdsetError);\n-            hSocketMax = std::max(hSocketMax, pnode->hSocket);\n-            have_fds = true;\n-\n+            error_set.insert(pnode->hSocket);\n             if (select_send) {\n-                FD_SET(pnode->hSocket, &fdsetSend);\n+                send_set.insert(pnode->hSocket);\n                 continue;\n             }\n             if (select_recv) {\n-                FD_SET(pnode->hSocket, &fdsetRecv);\n+                recv_set.insert(pnode->hSocket);\n             }\n         }\n     }\n+}\n+\n+#ifndef HAVE_POLL","path":"src/net.cpp","position":62,"original_position":62,"commit_id":"84fae8d4cc6a6d9f81644cef706629263e84d353","original_commit_id":"84fae8d4cc6a6d9f81644cef706629263e84d353","user":{"login":"jamesob","id":73197,"node_id":"MDQ6VXNlcjczMTk3","avatar_url":"https://avatars0.githubusercontent.com/u/73197?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesob","html_url":"https://github.com/jamesob","followers_url":"https://api.github.com/users/jamesob/followers","following_url":"https://api.github.com/users/jamesob/following{/other_user}","gists_url":"https://api.github.com/users/jamesob/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesob/subscriptions","organizations_url":"https://api.github.com/users/jamesob/orgs","repos_url":"https://api.github.com/users/jamesob/repos","events_url":"https://api.github.com/users/jamesob/events{/privacy}","received_events_url":"https://api.github.com/users/jamesob/received_events","type":"User","site_admin":false},"body":"(from a previous comment on the outdated `#ifdef WIN32`) Apparently poll has been flaky on previous versions of MacOS. Do we want to fall back to select on Darwin systems just to be safe?","created_at":"2018-10-16T20:29:34Z","updated_at":"2018-10-16T20:29:34Z","html_url":"https://github.com/bitcoin/bitcoin/pull/14336#discussion_r225696650","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/225696650"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14336#discussion_r225696650"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336","id":218475154,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDc1MTU0","html_url":"https://github.com/bitcoin/bitcoin/pull/14336","diff_url":"https://github.com/bitcoin/bitcoin/pull/14336.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/14336.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14336","number":14336,"state":"open","locked":false,"title":"net: implement poll","user":{"login":"pstratem","id":620611,"node_id":"MDQ6VXNlcjYyMDYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/620611?v=4","gravatar_id":"","url":"https://api.github.com/users/pstratem","html_url":"https://github.com/pstratem","followers_url":"https://api.github.com/users/pstratem/followers","following_url":"https://api.github.com/users/pstratem/following{/other_user}","gists_url":"https://api.github.com/users/pstratem/gists{/gist_id}","starred_url":"https://api.github.com/users/pstratem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstratem/subscriptions","organizations_url":"https://api.github.com/users/pstratem/orgs","repos_url":"https://api.github.com/users/pstratem/repos","events_url":"https://api.github.com/users/pstratem/events{/privacy}","received_events_url":"https://api.github.com/users/pstratem/received_events","type":"User","site_admin":false},"body":"This supercedes #14221 and builds on #14335","created_at":"2018-09-26T22:37:06Z","updated_at":"2018-10-16T20:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f500fd84fd7f605d5a3ffde911e2661ba03ecf30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98298007,"node_id":"MDU6TGFiZWw5ODI5ODAwNw==","url":"https://api.github.com/repos/bitcoin/bitcoin/labels/P2P","name":"P2P","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/14336/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/84fae8d4cc6a6d9f81644cef706629263e84d353","head":{"label":"pstratem:2018-09-24-socket-handler-poll","ref":"2018-09-24-socket-handler-poll","sha":"84fae8d4cc6a6d9f81644cef706629263e84d353","user":{"login":"pstratem","id":620611,"node_id":"MDQ6VXNlcjYyMDYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/620611?v=4","gravatar_id":"","url":"https://api.github.com/users/pstratem","html_url":"https://github.com/pstratem","followers_url":"https://api.github.com/users/pstratem/followers","following_url":"https://api.github.com/users/pstratem/following{/other_user}","gists_url":"https://api.github.com/users/pstratem/gists{/gist_id}","starred_url":"https://api.github.com/users/pstratem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstratem/subscriptions","organizations_url":"https://api.github.com/users/pstratem/orgs","repos_url":"https://api.github.com/users/pstratem/repos","events_url":"https://api.github.com/users/pstratem/events{/privacy}","received_events_url":"https://api.github.com/users/pstratem/received_events","type":"User","site_admin":false},"repo":{"id":51982177,"node_id":"MDEwOlJlcG9zaXRvcnk1MTk4MjE3Nw==","name":"bitcoin","full_name":"pstratem/bitcoin","private":false,"owner":{"login":"pstratem","id":620611,"node_id":"MDQ6VXNlcjYyMDYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/620611?v=4","gravatar_id":"","url":"https://api.github.com/users/pstratem","html_url":"https://github.com/pstratem","followers_url":"https://api.github.com/users/pstratem/followers","following_url":"https://api.github.com/users/pstratem/following{/other_user}","gists_url":"https://api.github.com/users/pstratem/gists{/gist_id}","starred_url":"https://api.github.com/users/pstratem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pstratem/subscriptions","organizations_url":"https://api.github.com/users/pstratem/orgs","repos_url":"https://api.github.com/users/pstratem/repos","events_url":"https://api.github.com/users/pstratem/events{/privacy}","received_events_url":"https://api.github.com/users/pstratem/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pstratem/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/pstratem/bitcoin","forks_url":"https://api.github.com/repos/pstratem/bitcoin/forks","keys_url":"https://api.github.com/repos/pstratem/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pstratem/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pstratem/bitcoin/teams","hooks_url":"https://api.github.com/repos/pstratem/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/pstratem/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/pstratem/bitcoin/events","assignees_url":"https://api.github.com/repos/pstratem/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/pstratem/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/pstratem/bitcoin/tags","blobs_url":"https://api.github.com/repos/pstratem/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pstratem/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pstratem/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/pstratem/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pstratem/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/pstratem/bitcoin/languages","stargazers_url":"https://api.github.com/repos/pstratem/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/pstratem/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/pstratem/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/pstratem/bitcoin/subscription","commits_url":"https://api.github.com/repos/pstratem/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/pstratem/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/pstratem/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/pstratem/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/pstratem/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/pstratem/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pstratem/bitcoin/merges","archive_url":"https://api.github.com/repos/pstratem/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pstratem/bitcoin/downloads","issues_url":"https://api.github.com/repos/pstratem/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/pstratem/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/pstratem/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/pstratem/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pstratem/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/pstratem/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/pstratem/bitcoin/deployments","created_at":"2016-02-18T05:39:22Z","updated_at":"2018-09-07T01:25:16Z","pushed_at":"2018-10-16T15:34:28Z","git_url":"git://github.com/pstratem/bitcoin.git","ssh_url":"git@github.com:pstratem/bitcoin.git","clone_url":"https://github.com/pstratem/bitcoin.git","svn_url":"https://github.com/pstratem/bitcoin","homepage":"https://bitcoin.org/en/download","size":106200,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"23419e4c4939fe557e37ec9d17c15c6eb73febc6","user":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgxOTI3","name":"bitcoin","full_name":"bitcoin/bitcoin","private":false,"owner":{"login":"bitcoin","id":528860,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyODg2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-10-16T20:09:10Z","pushed_at":"2018-10-16T18:16:49Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoincore.org/en/download","size":114331,"stargazers_count":35386,"watchers_count":35386,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":21368,"mirror_url":null,"archived":false,"open_issues_count":899,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21368,"open_issues":899,"watchers":35386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/14336"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14336"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/14336/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/14336/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/84fae8d4cc6a6d9f81644cef706629263e84d353"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jamesob"}}