{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/19536","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19536/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19536/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19536/events","html_url":"https://github.com/joomla/joomla-cms/pull/19536","id":293835740,"number":19536,"title":"[4.0] Restores the possibility to show rule descriptions in rules formfield.","user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars2.githubusercontent.com/u/1018684?v=4","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"labels":[{"id":444033883,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-02T10:09:09Z","updated_at":"2018-02-02T17:50:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/19536","html_url":"https://github.com/joomla/joomla-cms/pull/19536","diff_url":"https://github.com/joomla/joomla-cms/pull/19536.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/19536.patch"},"body":"With https://github.com/joomla/joomla-cms/pull/19285, the possibility to add a description to a custom rule was removed.\r\n@wilsonge reverted part of the change so it should still be possible to set a description, ~but he made a typo in his revert~ :smile: \r\n\r\n### Summary of Changes\r\nThis PR fully restores the possibility to set and display a description in the rules field.\r\nIt incorporates a check for the presence of the description so the rules that no longer have a description don't show a tooltip.\r\n\r\n### Testing Instructions\r\n* Make sure the rules in core extensions don't show any description. They should all be removed with the original PR and still don't show any description.\r\n* Test with a 3rd party extension (eg https://github.com/Bakual/SermonSpeaker/releases/download/6.0.0-alpha1/com_sermonspeaker.zip) that rules with a description still show a tooltip OR add a description to the rules in access.xml file of com_content and test if it shows up.\r\n\r\n### Expected result\r\nA description is shown\r\nPlease note that the tooltip itself is broken due to Bootstrap tooltips not being loaded on that page. The method used in core is `JHtml::tooltipText()` which doesn't load Bootstrap by itself. Same issue exists in other places (eg extension manager) as well and needs to be fixed independant of this PR.\r\nThe description will show as a native \"title\".\r\n\r\n### Actual result\r\nNothing is shown\r\n\r\n\r\n### Documentation Changes Required\r\nNone"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/362656116","html_url":"https://github.com/joomla/joomla-cms/pull/19536#issuecomment-362656116","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19536","id":362656116,"user":{"login":"Bakual","id":1018684,"avatar_url":"https://avatars2.githubusercontent.com/u/1018684?v=4","gravatar_id":"","url":"https://api.github.com/users/Bakual","html_url":"https://github.com/Bakual","followers_url":"https://api.github.com/users/Bakual/followers","following_url":"https://api.github.com/users/Bakual/following{/other_user}","gists_url":"https://api.github.com/users/Bakual/gists{/gist_id}","starred_url":"https://api.github.com/users/Bakual/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bakual/subscriptions","organizations_url":"https://api.github.com/users/Bakual/orgs","repos_url":"https://api.github.com/users/Bakual/repos","events_url":"https://api.github.com/users/Bakual/events{/privacy}","received_events_url":"https://api.github.com/users/Bakual/received_events","type":"User","site_admin":false},"created_at":"2018-02-02T17:50:54Z","updated_at":"2018-02-02T17:50:54Z","author_association":"CONTRIBUTOR","body":"> So one way or another this layout (with or without the description) will not be B/C to 3.x ones.\r\n\r\nOf course. Along with a lot of other layouts that need to be adjusted to the new way once that work is done."}}
{"actor":{"display_login":"Bakual"}}