{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/comments/216496531","pull_request_review_id":153991753,"id":216496531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ5NjUzMQ==","diff_hunk":"@@ -2038,8 +2044,12 @@ def concatenate(tensors, axis=-1):\n         else:\n             axis = 0\n \n-    tensors = [t.symbol for t in tensors]\n-    return KerasSymbol(mx.sym.concat(*tensors, dim=axis))\n+    symbols = [t.symbol for t in tensors]\n+\n+    if axis == 0 and py_all([is_sparse(t) for t in tensors]):\n+        return KerasSymbol(mx.sym.sparse.concat(*symbols, dim=axis))\n+\n+    return KerasSymbol(mx.sym.concat(*symbols, dim=axis))","path":"keras/backend/mxnet_backend.py","position":31,"original_position":31,"commit_id":"7d704f4a30fef6d4e99484ee28a92594a59a27fa","original_commit_id":"7d704f4a30fef6d4e99484ee28a92594a59a27fa","user":{"login":"kalyc","id":8603626,"node_id":"MDQ6VXNlcjg2MDM2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8603626?v=4","gravatar_id":"","url":"https://api.github.com/users/kalyc","html_url":"https://github.com/kalyc","followers_url":"https://api.github.com/users/kalyc/followers","following_url":"https://api.github.com/users/kalyc/following{/other_user}","gists_url":"https://api.github.com/users/kalyc/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyc/subscriptions","organizations_url":"https://api.github.com/users/kalyc/orgs","repos_url":"https://api.github.com/users/kalyc/repos","events_url":"https://api.github.com/users/kalyc/events{/privacy}","received_events_url":"https://api.github.com/users/kalyc/received_events","type":"User","site_admin":false},"body":"this is replicating the behavior for sparse concat in mxnet - http://mxnet.apache.org/api/python/symbol/symbol.html#mxnet.symbol.concat - do we still want to add a warning there? ","created_at":"2018-09-10T22:37:28Z","updated_at":"2018-09-10T22:37:28Z","html_url":"https://github.com/awslabs/keras-apache-mxnet/pull/167#discussion_r216496531","pull_request_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/comments/216496531"},"html":{"href":"https://github.com/awslabs/keras-apache-mxnet/pull/167#discussion_r216496531"},"pull_request":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167"}},"in_reply_to_id":216495517},"pull_request":{"url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167","id":214043954,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDQzOTU0","html_url":"https://github.com/awslabs/keras-apache-mxnet/pull/167","diff_url":"https://github.com/awslabs/keras-apache-mxnet/pull/167.diff","patch_url":"https://github.com/awslabs/keras-apache-mxnet/pull/167.patch","issue_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/167","number":167,"state":"open","locked":false,"title":"Add sparse concat operator support","user":{"login":"kalyc","id":8603626,"node_id":"MDQ6VXNlcjg2MDM2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8603626?v=4","gravatar_id":"","url":"https://api.github.com/users/kalyc","html_url":"https://github.com/kalyc","followers_url":"https://api.github.com/users/kalyc/followers","following_url":"https://api.github.com/users/kalyc/following{/other_user}","gists_url":"https://api.github.com/users/kalyc/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyc/subscriptions","organizations_url":"https://api.github.com/users/kalyc/orgs","repos_url":"https://api.github.com/users/kalyc/repos","events_url":"https://api.github.com/users/kalyc/events{/privacy}","received_events_url":"https://api.github.com/users/kalyc/received_events","type":"User","site_admin":false},"body":"### Summary\r\nAdd sparse support for `concat` operator\r\n\r\n### Related Issues\r\n[Missing sparse operators](https://github.com/awslabs/keras-apache-mxnet/issues/18)\r\n\r\n### PR Overview\r\n\r\n- [x] This PR requires new unit tests [y/n] (make sure tests are included)\r\n- [ ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)\r\n- [x] This PR is backwards compatible [y/n]\r\n- [ ] This PR changes the current API [y/n]\r\n","created_at":"2018-09-07T21:28:20Z","updated_at":"2018-09-10T22:37:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a644ed6ffa7df7dbc1c9cf05230c68769f91b9f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167/commits","review_comments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167/comments","review_comment_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/167/comments","statuses_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/statuses/7d704f4a30fef6d4e99484ee28a92594a59a27fa","head":{"label":"kalyc:sparse_concat","ref":"sparse_concat","sha":"7d704f4a30fef6d4e99484ee28a92594a59a27fa","user":{"login":"kalyc","id":8603626,"node_id":"MDQ6VXNlcjg2MDM2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8603626?v=4","gravatar_id":"","url":"https://api.github.com/users/kalyc","html_url":"https://github.com/kalyc","followers_url":"https://api.github.com/users/kalyc/followers","following_url":"https://api.github.com/users/kalyc/following{/other_user}","gists_url":"https://api.github.com/users/kalyc/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyc/subscriptions","organizations_url":"https://api.github.com/users/kalyc/orgs","repos_url":"https://api.github.com/users/kalyc/repos","events_url":"https://api.github.com/users/kalyc/events{/privacy}","received_events_url":"https://api.github.com/users/kalyc/received_events","type":"User","site_admin":false},"repo":{"id":136516955,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MTY5NTU=","name":"keras-apache-mxnet","full_name":"kalyc/keras-apache-mxnet","owner":{"login":"kalyc","id":8603626,"node_id":"MDQ6VXNlcjg2MDM2MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8603626?v=4","gravatar_id":"","url":"https://api.github.com/users/kalyc","html_url":"https://github.com/kalyc","followers_url":"https://api.github.com/users/kalyc/followers","following_url":"https://api.github.com/users/kalyc/following{/other_user}","gists_url":"https://api.github.com/users/kalyc/gists{/gist_id}","starred_url":"https://api.github.com/users/kalyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalyc/subscriptions","organizations_url":"https://api.github.com/users/kalyc/orgs","repos_url":"https://api.github.com/users/kalyc/repos","events_url":"https://api.github.com/users/kalyc/events{/privacy}","received_events_url":"https://api.github.com/users/kalyc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalyc/keras-apache-mxnet","description":"Amazon Deep Learning's Keras with Apache MXNet support","fork":true,"url":"https://api.github.com/repos/kalyc/keras-apache-mxnet","forks_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/forks","keys_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/teams","hooks_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/hooks","issue_events_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/events","assignees_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/tags","blobs_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/languages","stargazers_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/stargazers","contributors_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/contributors","subscribers_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/subscribers","subscription_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/subscription","commits_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/merges","archive_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/downloads","issues_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/kalyc/keras-apache-mxnet/deployments","created_at":"2018-06-07T18:35:31Z","updated_at":"2018-06-07T18:35:35Z","pushed_at":"2018-09-08T00:12:56Z","git_url":"git://github.com/kalyc/keras-apache-mxnet.git","ssh_url":"git@github.com:kalyc/keras-apache-mxnet.git","clone_url":"https://github.com/kalyc/keras-apache-mxnet.git","svn_url":"https://github.com/kalyc/keras-apache-mxnet","homepage":"https://github.com/awslabs/keras-apache-mxnet/wiki","size":12442,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:dev","ref":"dev","sha":"d961bf303a0d61810cdf9782b211ac8fc874481d","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":109059493,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkwNTk0OTM=","name":"keras-apache-mxnet","full_name":"awslabs/keras-apache-mxnet","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/keras-apache-mxnet","description":"Amazon Deep Learning's Keras with Apache MXNet support","fork":true,"url":"https://api.github.com/repos/awslabs/keras-apache-mxnet","forks_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/forks","keys_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/teams","hooks_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/hooks","issue_events_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/events","assignees_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/tags","blobs_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/languages","stargazers_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/stargazers","contributors_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/contributors","subscribers_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/subscribers","subscription_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/subscription","commits_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/merges","archive_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/downloads","issues_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/keras-apache-mxnet/deployments","created_at":"2017-10-31T22:36:43Z","updated_at":"2018-09-06T18:39:31Z","pushed_at":"2018-09-08T03:31:51Z","git_url":"git://github.com/awslabs/keras-apache-mxnet.git","ssh_url":"git@github.com:awslabs/keras-apache-mxnet.git","clone_url":"https://github.com/awslabs/keras-apache-mxnet.git","svn_url":"https://github.com/awslabs/keras-apache-mxnet","homepage":"https://github.com/awslabs/keras-apache-mxnet/wiki","size":12364,"stargazers_count":158,"watchers_count":158,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":27,"open_issues":38,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167"},"html":{"href":"https://github.com/awslabs/keras-apache-mxnet/pull/167"},"issue":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/167"},"comments":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/keras-apache-mxnet/statuses/7d704f4a30fef6d4e99484ee28a92594a59a27fa"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kalyc"}}