{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-client/csharp/issues/123","repository_url":"https://api.github.com/repos/kubernetes-client/csharp","labels_url":"https://api.github.com/repos/kubernetes-client/csharp/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-client/csharp/issues/123/comments","events_url":"https://api.github.com/repos/kubernetes-client/csharp/issues/123/events","html_url":"https://github.com/kubernetes-client/csharp/pull/123","id":308956237,"number":123,"title":"WebSocketNamespacedPodExecAsync: Support specifying command arguments","user":{"login":"qmfrederik","id":9918129,"avatar_url":"https://avatars0.githubusercontent.com/u/9918129?v=4","gravatar_id":"","url":"https://api.github.com/users/qmfrederik","html_url":"https://github.com/qmfrederik","followers_url":"https://api.github.com/users/qmfrederik/followers","following_url":"https://api.github.com/users/qmfrederik/following{/other_user}","gists_url":"https://api.github.com/users/qmfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/qmfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmfrederik/subscriptions","organizations_url":"https://api.github.com/users/qmfrederik/orgs","repos_url":"https://api.github.com/users/qmfrederik/repos","events_url":"https://api.github.com/users/qmfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/qmfrederik/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-27T12:53:57Z","updated_at":"2018-03-28T08:24:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes-client/csharp/pulls/123","html_url":"https://github.com/kubernetes-client/csharp/pull/123","diff_url":"https://github.com/kubernetes-client/csharp/pull/123.diff","patch_url":"https://github.com/kubernetes-client/csharp/pull/123.patch"},"body":"In the current implementation, `WebSocketNamespacedPodExecAsync` only allows a single command (`command` is a single string). \r\n\r\nThe Kubernetes API allows you to pass a command with arguments, such as `/bin/bash -c \"echo Hello, World!\\nexit 0\\n\"`.\r\n\r\nThis PR changes the `command` argument to be an `IEnumerable<string>`, allowing you to pass parameters."},"comment":{"url":"https://api.github.com/repos/kubernetes-client/csharp/issues/comments/376803627","html_url":"https://github.com/kubernetes-client/csharp/pull/123#issuecomment-376803627","issue_url":"https://api.github.com/repos/kubernetes-client/csharp/issues/123","id":376803627,"user":{"login":"qmfrederik","id":9918129,"avatar_url":"https://avatars0.githubusercontent.com/u/9918129?v=4","gravatar_id":"","url":"https://api.github.com/users/qmfrederik","html_url":"https://github.com/qmfrederik","followers_url":"https://api.github.com/users/qmfrederik/followers","following_url":"https://api.github.com/users/qmfrederik/following{/other_user}","gists_url":"https://api.github.com/users/qmfrederik/gists{/gist_id}","starred_url":"https://api.github.com/users/qmfrederik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmfrederik/subscriptions","organizations_url":"https://api.github.com/users/qmfrederik/orgs","repos_url":"https://api.github.com/users/qmfrederik/repos","events_url":"https://api.github.com/users/qmfrederik/events{/privacy}","received_events_url":"https://api.github.com/users/qmfrederik/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T08:24:58Z","updated_at":"2018-03-28T08:24:58Z","author_association":"CONTRIBUTOR","body":"OK - I added overloads that take a `string` and `IEnumerable<string>`, so we keep the API stable. Also addressed the other feedback.\r\n\r\nThere's a unit test for `WebSocketNamespacedPodExecAsync`, not sure if you run unit tests on `net451`, though. (You can set up a CI build for `net451` using AppVeyor)\r\n\r\nLet me know if you need anything else."}}
{"actor":{"display_login":"qmfrederik"}}