{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments/211151962","pull_request_review_id":147514018,"id":211151962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTE1MTk2Mg==","diff_hunk":"@@ -1,28 +1,34 @@\n package io.fabric8.maven.docker.access.chunked;\n \n+import org.apache.commons.io.IOUtils;\n+import org.json.JSONException;\n+import org.json.JSONObject;\n+import org.json.JSONTokener;\n+\n import java.io.IOException;\n import java.io.InputStream;\n+import java.nio.charset.Charset;\n \n import io.fabric8.maven.docker.access.DockerAccessException;\n-import org.json.JSONObject;\n-import org.json.JSONTokener;\n+\n+import static io.fabric8.maven.docker.util.JsonUtils.toJSONObject;\n \n public class EntityStreamReaderUtil {\n \n     private EntityStreamReaderUtil() {}\n \n-    public static void processJsonStream(JsonEntityResponseHandler handler, InputStream stream) throws IOException {\n+    public static void processJsonStream(JsonEntityResponseHandler handler, InputStream stream) throws IOException, JSONException {\n         handler.start();\n         try {\n-            JSONTokener tokener = new JSONTokener(stream);\n+            JSONTokener tokener = new JSONTokener(IOUtils.toString(stream, Charset.defaultCharset()));","path":"src/main/java/io/fabric8/maven/docker/access/chunked/EntityStreamReaderUtil.java","position":27,"original_position":27,"commit_id":"6418cdbfea7fb339101e9c200aa41cfdea4e0fe2","original_commit_id":"6418cdbfea7fb339101e9c200aa41cfdea4e0fe2","user":{"login":"rhuss","id":99080,"node_id":"MDQ6VXNlcjk5MDgw","avatar_url":"https://avatars3.githubusercontent.com/u/99080?v=4","gravatar_id":"","url":"https://api.github.com/users/rhuss","html_url":"https://github.com/rhuss","followers_url":"https://api.github.com/users/rhuss/followers","following_url":"https://api.github.com/users/rhuss/following{/other_user}","gists_url":"https://api.github.com/users/rhuss/gists{/gist_id}","starred_url":"https://api.github.com/users/rhuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhuss/subscriptions","organizations_url":"https://api.github.com/users/rhuss/orgs","repos_url":"https://api.github.com/users/rhuss/repos","events_url":"https://api.github.com/users/rhuss/events{/privacy}","received_events_url":"https://api.github.com/users/rhuss/received_events","type":"User","site_admin":false},"body":"BTW, just verified that with this PR all progress streams (pulling images, building images) are first shown when all has been finished (i.e. after the JSON response stream has been closed).","created_at":"2018-08-20T06:33:15Z","updated_at":"2018-08-20T06:33:16Z","html_url":"https://github.com/fabric8io/docker-maven-plugin/pull/1067#discussion_r211151962","pull_request_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments/211151962"},"html":{"href":"https://github.com/fabric8io/docker-maven-plugin/pull/1067#discussion_r211151962"},"pull_request":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067"}},"in_reply_to_id":210713596},"pull_request":{"url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067","id":208636951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjM2OTUx","html_url":"https://github.com/fabric8io/docker-maven-plugin/pull/1067","diff_url":"https://github.com/fabric8io/docker-maven-plugin/pull/1067.diff","patch_url":"https://github.com/fabric8io/docker-maven-plugin/pull/1067.patch","issue_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/1067","number":1067,"state":"open","locked":false,"title":"This replaces org.json with a more license friendly variety from the Android community.","user":{"login":"rdifrango","id":5819790,"node_id":"MDQ6VXNlcjU4MTk3OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5819790?v=4","gravatar_id":"","url":"https://api.github.com/users/rdifrango","html_url":"https://github.com/rdifrango","followers_url":"https://api.github.com/users/rdifrango/followers","following_url":"https://api.github.com/users/rdifrango/following{/other_user}","gists_url":"https://api.github.com/users/rdifrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rdifrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdifrango/subscriptions","organizations_url":"https://api.github.com/users/rdifrango/orgs","repos_url":"https://api.github.com/users/rdifrango/repos","events_url":"https://api.github.com/users/rdifrango/events{/privacy}","received_events_url":"https://api.github.com/users/rdifrango/received_events","type":"User","site_admin":false},"body":"This replaces org.json with a more license friendly variety from the Android community.\r\n\r\nI choose this as it was the closest direct port and was used already in the jsonassert.\r\n\r\nResolves #1016\r\nResolves #1064\r\n\r\nSigned-off-by: Ronald DiFrango ronald.difrango@capitalone.com","created_at":"2018-08-15T18:07:04Z","updated_at":"2018-08-20T06:33:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6865766737bd1f79dfb3fd3e80f0a790df863f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067/commits","review_comments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067/comments","review_comment_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/1067/comments","statuses_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/statuses/6418cdbfea7fb339101e9c200aa41cfdea4e0fe2","head":{"label":"rdifrango:rdifrango-json-changes","ref":"rdifrango-json-changes","sha":"6418cdbfea7fb339101e9c200aa41cfdea4e0fe2","user":{"login":"rdifrango","id":5819790,"node_id":"MDQ6VXNlcjU4MTk3OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5819790?v=4","gravatar_id":"","url":"https://api.github.com/users/rdifrango","html_url":"https://github.com/rdifrango","followers_url":"https://api.github.com/users/rdifrango/followers","following_url":"https://api.github.com/users/rdifrango/following{/other_user}","gists_url":"https://api.github.com/users/rdifrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rdifrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdifrango/subscriptions","organizations_url":"https://api.github.com/users/rdifrango/orgs","repos_url":"https://api.github.com/users/rdifrango/repos","events_url":"https://api.github.com/users/rdifrango/events{/privacy}","received_events_url":"https://api.github.com/users/rdifrango/received_events","type":"User","site_admin":false},"repo":{"id":144085485,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwODU0ODU=","name":"docker-maven-plugin","full_name":"rdifrango/docker-maven-plugin","owner":{"login":"rdifrango","id":5819790,"node_id":"MDQ6VXNlcjU4MTk3OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/5819790?v=4","gravatar_id":"","url":"https://api.github.com/users/rdifrango","html_url":"https://github.com/rdifrango","followers_url":"https://api.github.com/users/rdifrango/followers","following_url":"https://api.github.com/users/rdifrango/following{/other_user}","gists_url":"https://api.github.com/users/rdifrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rdifrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdifrango/subscriptions","organizations_url":"https://api.github.com/users/rdifrango/orgs","repos_url":"https://api.github.com/users/rdifrango/repos","events_url":"https://api.github.com/users/rdifrango/events{/privacy}","received_events_url":"https://api.github.com/users/rdifrango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdifrango/docker-maven-plugin","description":"Maven plugin for running and creating Docker images","fork":true,"url":"https://api.github.com/repos/rdifrango/docker-maven-plugin","forks_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/forks","keys_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/teams","hooks_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/events","assignees_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/tags","blobs_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/subscription","commits_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/merges","archive_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/downloads","issues_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/rdifrango/docker-maven-plugin/deployments","created_at":"2018-08-09T01:21:37Z","updated_at":"2018-08-09T01:21:41Z","pushed_at":"2018-08-15T19:09:48Z","git_url":"git://github.com/rdifrango/docker-maven-plugin.git","ssh_url":"git@github.com:rdifrango/docker-maven-plugin.git","clone_url":"https://github.com/rdifrango/docker-maven-plugin.git","svn_url":"https://github.com/rdifrango/docker-maven-plugin","homepage":"https://dmp.fabric8.io","size":15189,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8io:master","ref":"master","sha":"1fe5d4b042afabc9ce626a7eebccad6c74faf3aa","user":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"repo":{"id":18128548,"node_id":"MDEwOlJlcG9zaXRvcnkxODEyODU0OA==","name":"docker-maven-plugin","full_name":"fabric8io/docker-maven-plugin","owner":{"login":"fabric8io","id":6074349,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYwNzQzNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6074349?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8io","html_url":"https://github.com/fabric8io","followers_url":"https://api.github.com/users/fabric8io/followers","following_url":"https://api.github.com/users/fabric8io/following{/other_user}","gists_url":"https://api.github.com/users/fabric8io/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8io/subscriptions","organizations_url":"https://api.github.com/users/fabric8io/orgs","repos_url":"https://api.github.com/users/fabric8io/repos","events_url":"https://api.github.com/users/fabric8io/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8io/docker-maven-plugin","description":"Maven plugin for running and creating Docker images","fork":false,"url":"https://api.github.com/repos/fabric8io/docker-maven-plugin","forks_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/forks","keys_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/teams","hooks_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/hooks","issue_events_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/events","assignees_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/tags","blobs_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/languages","stargazers_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/stargazers","contributors_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/contributors","subscribers_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/subscribers","subscription_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/subscription","commits_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/merges","archive_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/downloads","issues_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8io/docker-maven-plugin/deployments","created_at":"2014-03-26T06:10:05Z","updated_at":"2018-08-17T14:13:53Z","pushed_at":"2018-08-15T19:09:49Z","git_url":"git://github.com/fabric8io/docker-maven-plugin.git","ssh_url":"git@github.com:fabric8io/docker-maven-plugin.git","clone_url":"https://github.com/fabric8io/docker-maven-plugin.git","svn_url":"https://github.com/fabric8io/docker-maven-plugin","homepage":"https://dmp.fabric8.io","size":15155,"stargazers_count":933,"watchers_count":933,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":374,"mirror_url":null,"archived":false,"open_issues_count":284,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":374,"open_issues":284,"watchers":933,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067"},"html":{"href":"https://github.com/fabric8io/docker-maven-plugin/pull/1067"},"issue":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/1067"},"comments":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/issues/1067/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/pulls/1067/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8io/docker-maven-plugin/statuses/6418cdbfea7fb339101e9c200aa41cfdea4e0fe2"}},"author_association":"NONE"}}
{"actor":{"display_login":"rhuss"}}