{"action":"created","issue":{"url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/issues/67","repository_url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox","labels_url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/issues/67/labels{/name}","comments_url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/issues/67/comments","events_url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/issues/67/events","html_url":"https://github.com/javadelight/delight-nashorn-sandbox/issues/67","id":358608847,"node_id":"MDU6SXNzdWUzNTg2MDg4NDc=","number":67,"title":"Eval with bindings ignoring allowExitFunctions(false) settings","user":{"login":"everestbt","id":10600197,"node_id":"MDQ6VXNlcjEwNjAwMTk3","avatar_url":"https://avatars0.githubusercontent.com/u/10600197?v=4","gravatar_id":"","url":"https://api.github.com/users/everestbt","html_url":"https://github.com/everestbt","followers_url":"https://api.github.com/users/everestbt/followers","following_url":"https://api.github.com/users/everestbt/following{/other_user}","gists_url":"https://api.github.com/users/everestbt/gists{/gist_id}","starred_url":"https://api.github.com/users/everestbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everestbt/subscriptions","organizations_url":"https://api.github.com/users/everestbt/orgs","repos_url":"https://api.github.com/users/everestbt/repos","events_url":"https://api.github.com/users/everestbt/events{/privacy}","received_events_url":"https://api.github.com/users/everestbt/received_events","type":"User","site_admin":false},"labels":[{"id":928617356,"node_id":"MDU6TGFiZWw5Mjg2MTczNTY=","url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/labels/solved","name":"solved","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-10T12:52:16Z","updated_at":"2018-11-05T16:51:54Z","closed_at":null,"author_association":"NONE","body":"While trying to wire this up I found an issue with `allowExitFunctions(false)`. When this is set and then `eval(String js,Bindings bindings)` is called, for example for the script \"quit()\" it will exit the JVM, counterposed to the intent of the setting. \r\n\r\nThis appears to be due to the bindings overwriting the original settings. I am not very familiar with Nashorn so my assumptions of the impact of `Bindings` and the persistence of these methods could be false. For usability I believe it would be helpful that, regardless of `Bindings` the settings are applied."},"comment":{"url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/issues/comments/435948268","html_url":"https://github.com/javadelight/delight-nashorn-sandbox/issues/67#issuecomment-435948268","issue_url":"https://api.github.com/repos/javadelight/delight-nashorn-sandbox/issues/67","id":435948268,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTk0ODI2OA==","user":{"login":"everestbt","id":10600197,"node_id":"MDQ6VXNlcjEwNjAwMTk3","avatar_url":"https://avatars0.githubusercontent.com/u/10600197?v=4","gravatar_id":"","url":"https://api.github.com/users/everestbt","html_url":"https://github.com/everestbt","followers_url":"https://api.github.com/users/everestbt/followers","following_url":"https://api.github.com/users/everestbt/following{/other_user}","gists_url":"https://api.github.com/users/everestbt/gists{/gist_id}","starred_url":"https://api.github.com/users/everestbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/everestbt/subscriptions","organizations_url":"https://api.github.com/users/everestbt/orgs","repos_url":"https://api.github.com/users/everestbt/repos","events_url":"https://api.github.com/users/everestbt/events{/privacy}","received_events_url":"https://api.github.com/users/everestbt/received_events","type":"User","site_admin":false},"created_at":"2018-11-05T16:51:54Z","updated_at":"2018-11-05T16:51:54Z","author_association":"NONE","body":"@mxro I have introduced a pull request #69 which I think improves things, by removing the extra evaluations by instead caching a set of secured bindings. Take a look and let me know your thoughts, happy to address any comments."}}
{"actor":{"display_login":"everestbt"}}