{"action":"closed","issue":{"url":"https://api.github.com/repos/DevExpress/testcafe/issues/2582","repository_url":"https://api.github.com/repos/DevExpress/testcafe","labels_url":"https://api.github.com/repos/DevExpress/testcafe/issues/2582/labels{/name}","comments_url":"https://api.github.com/repos/DevExpress/testcafe/issues/2582/comments","events_url":"https://api.github.com/repos/DevExpress/testcafe/issues/2582/events","html_url":"https://github.com/DevExpress/testcafe/issues/2582","id":337964701,"node_id":"MDU6SXNzdWUzMzc5NjQ3MDE=","number":2582,"title":"RequestLogger issue with Typescript Compilation","user":{"login":"ZayanNadeem","id":39530145,"node_id":"MDQ6VXNlcjM5NTMwMTQ1","avatar_url":"https://avatars2.githubusercontent.com/u/39530145?v=4","gravatar_id":"","url":"https://api.github.com/users/ZayanNadeem","html_url":"https://github.com/ZayanNadeem","followers_url":"https://api.github.com/users/ZayanNadeem/followers","following_url":"https://api.github.com/users/ZayanNadeem/following{/other_user}","gists_url":"https://api.github.com/users/ZayanNadeem/gists{/gist_id}","starred_url":"https://api.github.com/users/ZayanNadeem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZayanNadeem/subscriptions","organizations_url":"https://api.github.com/users/ZayanNadeem/orgs","repos_url":"https://api.github.com/users/ZayanNadeem/repos","events_url":"https://api.github.com/users/ZayanNadeem/events{/privacy}","received_events_url":"https://api.github.com/users/ZayanNadeem/received_events","type":"User","site_admin":false},"labels":[{"id":201866364,"node_id":"MDU6TGFiZWwyMDE4NjYzNjQ=","url":"https://api.github.com/repos/DevExpress/testcafe/labels/TYPE:%20question","name":"TYPE: question","color":"f7c6c7","default":false}],"state":"closed","locked":false,"assignee":{"login":"miherlosev","id":4133518,"node_id":"MDQ6VXNlcjQxMzM1MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4133518?v=4","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},"assignees":[{"login":"miherlosev","id":4133518,"node_id":"MDQ6VXNlcjQxMzM1MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4133518?v=4","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-07-03T16:08:24Z","updated_at":"2018-07-04T07:57:35Z","closed_at":"2018-07-04T07:57:34Z","author_association":"NONE","body":"### Are you requesting a feature or reporting a bug?\r\nBug\r\n\r\n\r\n### What is the current behavior?\r\nI recently decided to move all my testcafe files which I had written in JS to TS and:\r\n\r\n```\r\nconst logger =  RequestLogger({'myfiledownloadlink', method: 'GET'}) or\r\nconst logger =  RequestLogger({url: 'myfiledownloadlink', method: 'GET'}) *This also fails my tests*\r\n```\r\ngives me the following error:  Argument of type '{ pageUrl: string; method: string; }' is not assignable to parameter of type 'string | object | RegExp | ((req: any, res: any) => boolean)'.\r\n Object literal may only specify known properties, and 'pageUrl' does not exist in type 'string | object | RegExp | ((req: any, res: any) => boolean)'.\r\n\r\nbut when I do\r\n\r\n```\r\nconst options = {'www.example.com', method: 'GET'}\r\nconst logger = RequestLogger(options)\r\n```\r\nit compiles.\r\n\r\n### What is the expected behavior?\r\nShouldn't it work in both cases nonetheless? Am I doing something wrong?\r\nI also looked at the PR#[2423](https://github.com/DevExpress/testcafe/pull/2423) which explains the error. I tried the \"skipLibCheck\" as well - didn't do anything.\r\n\r\n### My test\r\n\r\n```\r\n test\r\n  .requestHooks(logger)\r\n  ('should be able to download', async t => {\r\n    const downloadButton = Selector('#button_download');\r\n    await t\r\n      .click(downloadButton)\r\n      .expect(logger.contains(r=>r.response.statusCode === 200)).ok();\r\n  });\r\n```\r\n\r\n### Specify your\r\n\r\n* operating system: linux\r\n* testcafe version: 0.20.4\r\n* node.js version: 10.3.3"}}
{"actor":{"display_login":"miherlosev"}}