{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/217231567","pull_request_review_id":154894477,"id":217231567,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzIzMTU2Nw==","diff_hunk":"@@ -315,12 +315,16 @@ class CloudInfraCatalogItem(BaseCatalogItem):\n \n     @property\n     def fill_dict(self):\n+        # In 5.10 catalog name is appended with 'My Company'","path":"cfme/services/catalogs/catalog_items/__init__.py","position":4,"original_position":4,"commit_id":"a3fc72c476f49b6b38a98581e335479e12388139","original_commit_id":"a3fc72c476f49b6b38a98581e335479e12388139","user":{"login":"mshriver","id":21315076,"node_id":"MDQ6VXNlcjIxMzE1MDc2","avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false},"body":"This looks like the same implementations and dict returns in both classes, and they both inherit `BaseCatalogItem`. Please double check me on this, and move this method to `BaseCatalogItem` if that's the case.","created_at":"2018-09-13T00:42:00Z","updated_at":"2018-09-13T00:42:00Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/7774#discussion_r217231567","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/217231567"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/7774#discussion_r217231567"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774"}},"in_reply_to_id":217231281},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774","id":213725011,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzI1MDEx","html_url":"https://github.com/ManageIQ/integration_tests/pull/7774","diff_url":"https://github.com/ManageIQ/integration_tests/pull/7774.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/7774.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/7774","number":7774,"state":"open","locked":false,"title":"[1LP][RFR]Catalog name appended by My_Company in 5.10","user":{"login":"sshveta","id":3866976,"node_id":"MDQ6VXNlcjM4NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3866976?v=4","gravatar_id":"","url":"https://api.github.com/users/sshveta","html_url":"https://github.com/sshveta","followers_url":"https://api.github.com/users/sshveta/followers","following_url":"https://api.github.com/users/sshveta/following{/other_user}","gists_url":"https://api.github.com/users/sshveta/gists{/gist_id}","starred_url":"https://api.github.com/users/sshveta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshveta/subscriptions","organizations_url":"https://api.github.com/users/sshveta/orgs","repos_url":"https://api.github.com/users/sshveta/repos","events_url":"https://api.github.com/users/sshveta/events{/privacy}","received_events_url":"https://api.github.com/users/sshveta/received_events","type":"User","site_admin":false},"body":"{{pytest: cfme/tests/services/test_myservice.py -v --use-provider vsphere55}}\r\n\r\nIn 5.10 catalog name is displayed with My Company/catalog_name.\r\nIt affects some tests but tests cannot be run since 5.10 tests are failing because of issue \r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1626232.\r\n\r\nBlocking tests with this BZ in another upcoming PR","created_at":"2018-09-06T19:28:05Z","updated_at":"2018-09-13T00:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ea0ce564fc5160dc5ca7bf88cf529db955e69a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":455422374,"node_id":"MDU6TGFiZWw0NTU0MjIzNzQ=","url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/fix-test","name":"fix-test","color":"0e8a16","default":false},{"id":118710104,"node_id":"MDU6TGFiZWwxMTg3MTAxMDQ=","url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/lint-ok","name":"lint-ok","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/7774/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/a3fc72c476f49b6b38a98581e335479e12388139","head":{"label":"sshveta:service_5.10_fix","ref":"service_5.10_fix","sha":"a3fc72c476f49b6b38a98581e335479e12388139","user":{"login":"sshveta","id":3866976,"node_id":"MDQ6VXNlcjM4NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3866976?v=4","gravatar_id":"","url":"https://api.github.com/users/sshveta","html_url":"https://github.com/sshveta","followers_url":"https://api.github.com/users/sshveta/followers","following_url":"https://api.github.com/users/sshveta/following{/other_user}","gists_url":"https://api.github.com/users/sshveta/gists{/gist_id}","starred_url":"https://api.github.com/users/sshveta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshveta/subscriptions","organizations_url":"https://api.github.com/users/sshveta/orgs","repos_url":"https://api.github.com/users/sshveta/repos","events_url":"https://api.github.com/users/sshveta/events{/privacy}","received_events_url":"https://api.github.com/users/sshveta/received_events","type":"User","site_admin":false},"repo":{"id":17754019,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc1NDAxOQ==","name":"cfme_tests","full_name":"sshveta/cfme_tests","owner":{"login":"sshveta","id":3866976,"node_id":"MDQ6VXNlcjM4NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3866976?v=4","gravatar_id":"","url":"https://api.github.com/users/sshveta","html_url":"https://github.com/sshveta","followers_url":"https://api.github.com/users/sshveta/followers","following_url":"https://api.github.com/users/sshveta/following{/other_user}","gists_url":"https://api.github.com/users/sshveta/gists{/gist_id}","starred_url":"https://api.github.com/users/sshveta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sshveta/subscriptions","organizations_url":"https://api.github.com/users/sshveta/orgs","repos_url":"https://api.github.com/users/sshveta/repos","events_url":"https://api.github.com/users/sshveta/events{/privacy}","received_events_url":"https://api.github.com/users/sshveta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sshveta/cfme_tests","description":"CloudForms Management Engine - Functional tests","fork":true,"url":"https://api.github.com/repos/sshveta/cfme_tests","forks_url":"https://api.github.com/repos/sshveta/cfme_tests/forks","keys_url":"https://api.github.com/repos/sshveta/cfme_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sshveta/cfme_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sshveta/cfme_tests/teams","hooks_url":"https://api.github.com/repos/sshveta/cfme_tests/hooks","issue_events_url":"https://api.github.com/repos/sshveta/cfme_tests/issues/events{/number}","events_url":"https://api.github.com/repos/sshveta/cfme_tests/events","assignees_url":"https://api.github.com/repos/sshveta/cfme_tests/assignees{/user}","branches_url":"https://api.github.com/repos/sshveta/cfme_tests/branches{/branch}","tags_url":"https://api.github.com/repos/sshveta/cfme_tests/tags","blobs_url":"https://api.github.com/repos/sshveta/cfme_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sshveta/cfme_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sshveta/cfme_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sshveta/cfme_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sshveta/cfme_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/sshveta/cfme_tests/languages","stargazers_url":"https://api.github.com/repos/sshveta/cfme_tests/stargazers","contributors_url":"https://api.github.com/repos/sshveta/cfme_tests/contributors","subscribers_url":"https://api.github.com/repos/sshveta/cfme_tests/subscribers","subscription_url":"https://api.github.com/repos/sshveta/cfme_tests/subscription","commits_url":"https://api.github.com/repos/sshveta/cfme_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sshveta/cfme_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sshveta/cfme_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sshveta/cfme_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sshveta/cfme_tests/contents/{+path}","compare_url":"https://api.github.com/repos/sshveta/cfme_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sshveta/cfme_tests/merges","archive_url":"https://api.github.com/repos/sshveta/cfme_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sshveta/cfme_tests/downloads","issues_url":"https://api.github.com/repos/sshveta/cfme_tests/issues{/number}","pulls_url":"https://api.github.com/repos/sshveta/cfme_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/sshveta/cfme_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/sshveta/cfme_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sshveta/cfme_tests/labels{/name}","releases_url":"https://api.github.com/repos/sshveta/cfme_tests/releases{/id}","deployments_url":"https://api.github.com/repos/sshveta/cfme_tests/deployments","created_at":"2014-03-14T17:19:55Z","updated_at":"2016-06-10T01:35:16Z","pushed_at":"2018-09-07T16:26:40Z","git_url":"git://github.com/sshveta/cfme_tests.git","ssh_url":"git@github.com:sshveta/cfme_tests.git","clone_url":"https://github.com/sshveta/cfme_tests.git","svn_url":"https://github.com/sshveta/cfme_tests","homepage":"","size":28278,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"401acc6d20e8860710799ae95bd57eb6eeb5ada9","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYxMDg2","name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2018-09-12T16:26:04Z","pushed_at":"2018-09-12T20:45:31Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":28479,"stargazers_count":62,"watchers_count":62,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":143,"mirror_url":null,"archived":false,"open_issues_count":183,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":143,"open_issues":183,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/7774"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/7774"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/7774/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/7774/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/a3fc72c476f49b6b38a98581e335479e12388139"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mshriver"}}