{"action":"created","issue":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9657","repository_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9657/labels{/name}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9657/comments","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9657/events","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9657","id":354254894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMDYwNzM2","number":9657,"title":"net: ipv6: Drop packet with multiple HBHO","user":{"login":"rmstoi","id":9799150,"node_id":"MDQ6VXNlcjk3OTkxNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/9799150?v=4","gravatar_id":"","url":"https://api.github.com/users/rmstoi","html_url":"https://github.com/rmstoi","followers_url":"https://api.github.com/users/rmstoi/followers","following_url":"https://api.github.com/users/rmstoi/following{/other_user}","gists_url":"https://api.github.com/users/rmstoi/gists{/gist_id}","starred_url":"https://api.github.com/users/rmstoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmstoi/subscriptions","organizations_url":"https://api.github.com/users/rmstoi/orgs","repos_url":"https://api.github.com/users/rmstoi/repos","events_url":"https://api.github.com/users/rmstoi/events{/privacy}","received_events_url":"https://api.github.com/users/rmstoi/received_events","type":"User","site_admin":false},"labels":[{"id":700751655,"node_id":"MDU6TGFiZWw3MDA3NTE2NTU=","url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels/area:%20Networking","name":"area: Networking","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-27T09:54:38Z","updated_at":"2018-08-27T13:03:48Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/9657","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9657","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9657.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9657.patch"},"body":"If a malformed packet with multiple HBHO is received echo server\r\nreplies with ICMPv6 type 4 code 1: \"Parameter problem unrecognized Next\r\nHeader type encountered\". This ICMPv6 message has wrong IPv6 payload\r\nlength and ICMPv6 checksum. RFC 8200 in chapter 4.1 states:\r\n\r\n   Each extension header should occur at most once, except for the\r\n   Destination Options header, which should occur at most twice (once\r\n   before a Routing header and once before the upper-layer header).\r\n\r\nHence, this patch changes the code to drop the packet instead of\r\nsending ICMPv6 type 4 code 1.\r\n\r\nSigned-off-by: Ruslan Mstoi <ruslan.mstoi@intel.com>"},"comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments/416219375","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/9657#issuecomment-416219375","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/9657","id":416219375,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjIxOTM3NQ==","user":{"login":"jukkar","id":1098415,"node_id":"MDQ6VXNlcjEwOTg0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T13:03:48Z","updated_at":"2018-08-27T13:03:48Z","author_association":"MEMBER","body":"> So, that one of the issue which bothers me - is this problem echo server specific? If not, then I'd write in the commit message as \"currently, Zephyr IP stack replies with ... (as tested with echo_server)\". And stuff about echo_server probably can be dropped altogether.\r\n\r\nThis has nothing to do with echo-server, so there is no need to mention it in commit msg. We can receive the packet when using any program, not just with echo-server.\r\n"}}
{"actor":{"display_login":"jukkar"}}