{"action":"created","comment":{"url":"https://api.github.com/repos/palantirnet/the-build/pulls/comments/223793265","pull_request_review_id":163007585,"id":223793265,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzc5MzI2NQ==","diff_hunk":"@@ -1,25 +1,78 @@\n-<project name=\"@projectname@\" default=\"build\">\n-    <!-- Run with: vendor/bin/phing -Dbuild.env=vagrant -->\n-    <!-- For a list of commands, try: vendor/bin/phing -Dbuild.env=vagrant -l -->\n+<?xml version=\"1.0\"?>\n+\n+<!--\n+  @file build.xml\n+  Build targets for this project. This file should be customized for your project.\n+\n+  For a full list of targets, try:\n+    phing -l\n \n+  @see https://github.com/palantirnet/the-build\n+  -->\n+\n+<project name=\"@projectname@\" default=\"build\">\n \n+    <!-- Add property loading and tasks from palantirnet/the-build. -->\n     <import file=\"vendor/palantirnet/the-build/tasks/the-build.xml\" />\n \n \n-    <!-- Make these commands available by default. -->\n+    <!-- Make these additional targets available by default. -->\n     <import file=\"vendor/palantirnet/the-build/tasks/drupal.xml\" />\n+\n+\n+    <!-- Additional optional targets. -->\n     <import file=\"vendor/palantirnet/the-build/tasks/artifact.xml\" />\n+    <import file=\"vendor/palantirnet/the-build/tasks/acquia.xml\" />\n \n \n     <!-- Default target: build -->\n     <target name=\"build\" description=\"Build the application.\">\n-        <phingcall target=\"drupal-build\" />\n+        <!-- Create the Drupal custom code directories. -->\n+        <foreach list=\"${drupal.create_dirs}\" param=\"dir\" target=\"mkdir\" />\n+\n+        <!-- Set permissions on the sites subdirectory. -->\n+        <mkdir dir=\"${drupal.root}/sites/${drupal.sites_subdir}\" />\n+        <chmod file=\"${drupal.root}/sites/${drupal.sites_subdir}\" mode=\"750\" />\n+\n+        <!-- Create the public files directory and make it world writable. -->\n+        <mkdir dir=\"${drupal.root}/${drupal.settings.file_public_path}\" />\n+        <chmod file=\"${drupal.root}/${drupal.settings.file_public_path}\" mode=\"744\" />\n+\n+        <!-- Create the private files directory and make it private. -->\n+        <mkdir dir=\"${drupal.root}/${drupal.settings.file_private_path}\" />\n+        <chmod file=\"${drupal.root}/${drupal.settings.file_private_path}\" mode=\"640\" />\n+\n+        <!-- Copy the settings.build.php and services.build.php templates into place. -->","path":"defaults/templates/the-build/build.xml","position":50,"original_position":50,"commit_id":"b143b934897b6fc65c5a5bfff23e484b4d3c6644","original_commit_id":"b143b934897b6fc65c5a5bfff23e484b4d3c6644","user":{"login":"becw","id":207974,"node_id":"MDQ6VXNlcjIwNzk3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/207974?v=4","gravatar_id":"","url":"https://api.github.com/users/becw","html_url":"https://github.com/becw","followers_url":"https://api.github.com/users/becw/followers","following_url":"https://api.github.com/users/becw/following{/other_user}","gists_url":"https://api.github.com/users/becw/gists{/gist_id}","starred_url":"https://api.github.com/users/becw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becw/subscriptions","organizations_url":"https://api.github.com/users/becw/orgs","repos_url":"https://api.github.com/users/becw/repos","events_url":"https://api.github.com/users/becw/events{/privacy}","received_events_url":"https://api.github.com/users/becw/received_events","type":"User","site_admin":false},"body":"Can you give me more details on this issue? What I find is that when I run `phing build -Dbuild.env=pantheon`, the-build does create a `settings.build.php` file, but it's a limited version of the settings, customized for Pantheon:\r\n\r\n```php\r\n<?php\r\n\r\n/**\r\n * @file\r\n * Drupal settings file template for use on Pantheon environments.\r\n */\r\n\r\n$config_directories = [];\r\n$config_directories[CONFIG_SYNC_DIRECTORY] = '../config/sites/default';\r\n```\r\n\r\nIs it this file that causes issues? What issues does it cause?","created_at":"2018-10-09T17:28:01Z","updated_at":"2018-10-09T17:28:01Z","html_url":"https://github.com/palantirnet/the-build/pull/99#discussion_r223793265","pull_request_url":"https://api.github.com/repos/palantirnet/the-build/pulls/99","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/palantirnet/the-build/pulls/comments/223793265"},"html":{"href":"https://github.com/palantirnet/the-build/pull/99#discussion_r223793265"},"pull_request":{"href":"https://api.github.com/repos/palantirnet/the-build/pulls/99"}},"in_reply_to_id":223139960},"pull_request":{"url":"https://api.github.com/repos/palantirnet/the-build/pulls/99","id":218493697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDkzNjk3","html_url":"https://github.com/palantirnet/the-build/pull/99","diff_url":"https://github.com/palantirnet/the-build/pull/99.diff","patch_url":"https://github.com/palantirnet/the-build/pull/99.patch","issue_url":"https://api.github.com/repos/palantirnet/the-build/issues/99","number":99,"state":"open","locked":false,"title":"Flatten the Drupal build tasks","user":{"login":"becw","id":207974,"node_id":"MDQ6VXNlcjIwNzk3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/207974?v=4","gravatar_id":"","url":"https://api.github.com/users/becw","html_url":"https://github.com/becw","followers_url":"https://api.github.com/users/becw/followers","following_url":"https://api.github.com/users/becw/following{/other_user}","gists_url":"https://api.github.com/users/becw/gists{/gist_id}","starred_url":"https://api.github.com/users/becw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becw/subscriptions","organizations_url":"https://api.github.com/users/becw/orgs","repos_url":"https://api.github.com/users/becw/repos","events_url":"https://api.github.com/users/becw/events{/privacy}","received_events_url":"https://api.github.com/users/becw/received_events","type":"User","site_admin":false},"body":"* Moves the `drupal-build` and `drupal-install` targets into the template `build.xml` where developers can see and modify them\r\n* Moves the db loading target into `drupal.xml`, and makes it available in the template `build.xml` file\r\n* Makes the Acquia targets available in the template `build.xml` file by default\r\n* Updates properties used in the `drupal.xml` file so that they are all namespaced with `drupal.`\r\n\r\nThis PR follows #98.","created_at":"2018-09-27T00:44:43Z","updated_at":"2018-10-09T17:28:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2702d5ac0ecc6d11aa74450174c83610731833b0","assignee":{"login":"becw","id":207974,"node_id":"MDQ6VXNlcjIwNzk3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/207974?v=4","gravatar_id":"","url":"https://api.github.com/users/becw","html_url":"https://github.com/becw","followers_url":"https://api.github.com/users/becw/followers","following_url":"https://api.github.com/users/becw/following{/other_user}","gists_url":"https://api.github.com/users/becw/gists{/gist_id}","starred_url":"https://api.github.com/users/becw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becw/subscriptions","organizations_url":"https://api.github.com/users/becw/orgs","repos_url":"https://api.github.com/users/becw/repos","events_url":"https://api.github.com/users/becw/events{/privacy}","received_events_url":"https://api.github.com/users/becw/received_events","type":"User","site_admin":false},"assignees":[{"login":"becw","id":207974,"node_id":"MDQ6VXNlcjIwNzk3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/207974?v=4","gravatar_id":"","url":"https://api.github.com/users/becw","html_url":"https://github.com/becw","followers_url":"https://api.github.com/users/becw/followers","following_url":"https://api.github.com/users/becw/following{/other_user}","gists_url":"https://api.github.com/users/becw/gists{/gist_id}","starred_url":"https://api.github.com/users/becw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/becw/subscriptions","organizations_url":"https://api.github.com/users/becw/orgs","repos_url":"https://api.github.com/users/becw/repos","events_url":"https://api.github.com/users/becw/events{/privacy}","received_events_url":"https://api.github.com/users/becw/received_events","type":"User","site_admin":false},{"login":"byrond","id":767994,"node_id":"MDQ6VXNlcjc2Nzk5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/767994?v=4","gravatar_id":"","url":"https://api.github.com/users/byrond","html_url":"https://github.com/byrond","followers_url":"https://api.github.com/users/byrond/followers","following_url":"https://api.github.com/users/byrond/following{/other_user}","gists_url":"https://api.github.com/users/byrond/gists{/gist_id}","starred_url":"https://api.github.com/users/byrond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byrond/subscriptions","organizations_url":"https://api.github.com/users/byrond/orgs","repos_url":"https://api.github.com/users/byrond/repos","events_url":"https://api.github.com/users/byrond/events{/privacy}","received_events_url":"https://api.github.com/users/byrond/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":447750532,"node_id":"MDU6TGFiZWw0NDc3NTA1MzI=","url":"https://api.github.com/repos/palantirnet/the-build/labels/Ready%20for%20Review","name":"Ready for Review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantirnet/the-build/pulls/99/commits","review_comments_url":"https://api.github.com/repos/palantirnet/the-build/pulls/99/comments","review_comment_url":"https://api.github.com/repos/palantirnet/the-build/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantirnet/the-build/issues/99/comments","statuses_url":"https://api.github.com/repos/palantirnet/the-build/statuses/b143b934897b6fc65c5a5bfff23e484b4d3c6644","head":{"label":"palantirnet:clarify-drupal-build","ref":"clarify-drupal-build","sha":"b143b934897b6fc65c5a5bfff23e484b4d3c6644","user":{"login":"palantirnet","id":347233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/347233?v=4","gravatar_id":"","url":"https://api.github.com/users/palantirnet","html_url":"https://github.com/palantirnet","followers_url":"https://api.github.com/users/palantirnet/followers","following_url":"https://api.github.com/users/palantirnet/following{/other_user}","gists_url":"https://api.github.com/users/palantirnet/gists{/gist_id}","starred_url":"https://api.github.com/users/palantirnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantirnet/subscriptions","organizations_url":"https://api.github.com/users/palantirnet/orgs","repos_url":"https://api.github.com/users/palantirnet/repos","events_url":"https://api.github.com/users/palantirnet/events{/privacy}","received_events_url":"https://api.github.com/users/palantirnet/received_events","type":"Organization","site_admin":false},"repo":{"id":53622102,"node_id":"MDEwOlJlcG9zaXRvcnk1MzYyMjEwMg==","name":"the-build","full_name":"palantirnet/the-build","private":false,"owner":{"login":"palantirnet","id":347233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/347233?v=4","gravatar_id":"","url":"https://api.github.com/users/palantirnet","html_url":"https://github.com/palantirnet","followers_url":"https://api.github.com/users/palantirnet/followers","following_url":"https://api.github.com/users/palantirnet/following{/other_user}","gists_url":"https://api.github.com/users/palantirnet/gists{/gist_id}","starred_url":"https://api.github.com/users/palantirnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantirnet/subscriptions","organizations_url":"https://api.github.com/users/palantirnet/orgs","repos_url":"https://api.github.com/users/palantirnet/repos","events_url":"https://api.github.com/users/palantirnet/events{/privacy}","received_events_url":"https://api.github.com/users/palantirnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/palantirnet/the-build","description":"Phing build tasks for Drupal projects.","fork":false,"url":"https://api.github.com/repos/palantirnet/the-build","forks_url":"https://api.github.com/repos/palantirnet/the-build/forks","keys_url":"https://api.github.com/repos/palantirnet/the-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantirnet/the-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantirnet/the-build/teams","hooks_url":"https://api.github.com/repos/palantirnet/the-build/hooks","issue_events_url":"https://api.github.com/repos/palantirnet/the-build/issues/events{/number}","events_url":"https://api.github.com/repos/palantirnet/the-build/events","assignees_url":"https://api.github.com/repos/palantirnet/the-build/assignees{/user}","branches_url":"https://api.github.com/repos/palantirnet/the-build/branches{/branch}","tags_url":"https://api.github.com/repos/palantirnet/the-build/tags","blobs_url":"https://api.github.com/repos/palantirnet/the-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantirnet/the-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantirnet/the-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantirnet/the-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantirnet/the-build/statuses/{sha}","languages_url":"https://api.github.com/repos/palantirnet/the-build/languages","stargazers_url":"https://api.github.com/repos/palantirnet/the-build/stargazers","contributors_url":"https://api.github.com/repos/palantirnet/the-build/contributors","subscribers_url":"https://api.github.com/repos/palantirnet/the-build/subscribers","subscription_url":"https://api.github.com/repos/palantirnet/the-build/subscription","commits_url":"https://api.github.com/repos/palantirnet/the-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantirnet/the-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantirnet/the-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantirnet/the-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantirnet/the-build/contents/{+path}","compare_url":"https://api.github.com/repos/palantirnet/the-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantirnet/the-build/merges","archive_url":"https://api.github.com/repos/palantirnet/the-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantirnet/the-build/downloads","issues_url":"https://api.github.com/repos/palantirnet/the-build/issues{/number}","pulls_url":"https://api.github.com/repos/palantirnet/the-build/pulls{/number}","milestones_url":"https://api.github.com/repos/palantirnet/the-build/milestones{/number}","notifications_url":"https://api.github.com/repos/palantirnet/the-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantirnet/the-build/labels{/name}","releases_url":"https://api.github.com/repos/palantirnet/the-build/releases{/id}","deployments_url":"https://api.github.com/repos/palantirnet/the-build/deployments","created_at":"2016-03-10T22:37:10Z","updated_at":"2018-09-19T22:41:52Z","pushed_at":"2018-10-09T00:26:51Z","git_url":"git://github.com/palantirnet/the-build.git","ssh_url":"git@github.com:palantirnet/the-build.git","clone_url":"https://github.com/palantirnet/the-build.git","svn_url":"https://github.com/palantirnet/the-build","homepage":"","size":372,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":0,"open_issues":28,"watchers":2,"default_branch":"release-1.0"}},"base":{"label":"palantirnet:release-2.0","ref":"release-2.0","sha":"0d7499d221efed7ce2f646e5bfd6ab706a31b028","user":{"login":"palantirnet","id":347233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/347233?v=4","gravatar_id":"","url":"https://api.github.com/users/palantirnet","html_url":"https://github.com/palantirnet","followers_url":"https://api.github.com/users/palantirnet/followers","following_url":"https://api.github.com/users/palantirnet/following{/other_user}","gists_url":"https://api.github.com/users/palantirnet/gists{/gist_id}","starred_url":"https://api.github.com/users/palantirnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantirnet/subscriptions","organizations_url":"https://api.github.com/users/palantirnet/orgs","repos_url":"https://api.github.com/users/palantirnet/repos","events_url":"https://api.github.com/users/palantirnet/events{/privacy}","received_events_url":"https://api.github.com/users/palantirnet/received_events","type":"Organization","site_admin":false},"repo":{"id":53622102,"node_id":"MDEwOlJlcG9zaXRvcnk1MzYyMjEwMg==","name":"the-build","full_name":"palantirnet/the-build","private":false,"owner":{"login":"palantirnet","id":347233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzIzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/347233?v=4","gravatar_id":"","url":"https://api.github.com/users/palantirnet","html_url":"https://github.com/palantirnet","followers_url":"https://api.github.com/users/palantirnet/followers","following_url":"https://api.github.com/users/palantirnet/following{/other_user}","gists_url":"https://api.github.com/users/palantirnet/gists{/gist_id}","starred_url":"https://api.github.com/users/palantirnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantirnet/subscriptions","organizations_url":"https://api.github.com/users/palantirnet/orgs","repos_url":"https://api.github.com/users/palantirnet/repos","events_url":"https://api.github.com/users/palantirnet/events{/privacy}","received_events_url":"https://api.github.com/users/palantirnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/palantirnet/the-build","description":"Phing build tasks for Drupal projects.","fork":false,"url":"https://api.github.com/repos/palantirnet/the-build","forks_url":"https://api.github.com/repos/palantirnet/the-build/forks","keys_url":"https://api.github.com/repos/palantirnet/the-build/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantirnet/the-build/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantirnet/the-build/teams","hooks_url":"https://api.github.com/repos/palantirnet/the-build/hooks","issue_events_url":"https://api.github.com/repos/palantirnet/the-build/issues/events{/number}","events_url":"https://api.github.com/repos/palantirnet/the-build/events","assignees_url":"https://api.github.com/repos/palantirnet/the-build/assignees{/user}","branches_url":"https://api.github.com/repos/palantirnet/the-build/branches{/branch}","tags_url":"https://api.github.com/repos/palantirnet/the-build/tags","blobs_url":"https://api.github.com/repos/palantirnet/the-build/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantirnet/the-build/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantirnet/the-build/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantirnet/the-build/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantirnet/the-build/statuses/{sha}","languages_url":"https://api.github.com/repos/palantirnet/the-build/languages","stargazers_url":"https://api.github.com/repos/palantirnet/the-build/stargazers","contributors_url":"https://api.github.com/repos/palantirnet/the-build/contributors","subscribers_url":"https://api.github.com/repos/palantirnet/the-build/subscribers","subscription_url":"https://api.github.com/repos/palantirnet/the-build/subscription","commits_url":"https://api.github.com/repos/palantirnet/the-build/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantirnet/the-build/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantirnet/the-build/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantirnet/the-build/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantirnet/the-build/contents/{+path}","compare_url":"https://api.github.com/repos/palantirnet/the-build/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantirnet/the-build/merges","archive_url":"https://api.github.com/repos/palantirnet/the-build/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantirnet/the-build/downloads","issues_url":"https://api.github.com/repos/palantirnet/the-build/issues{/number}","pulls_url":"https://api.github.com/repos/palantirnet/the-build/pulls{/number}","milestones_url":"https://api.github.com/repos/palantirnet/the-build/milestones{/number}","notifications_url":"https://api.github.com/repos/palantirnet/the-build/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantirnet/the-build/labels{/name}","releases_url":"https://api.github.com/repos/palantirnet/the-build/releases{/id}","deployments_url":"https://api.github.com/repos/palantirnet/the-build/deployments","created_at":"2016-03-10T22:37:10Z","updated_at":"2018-09-19T22:41:52Z","pushed_at":"2018-10-09T00:26:51Z","git_url":"git://github.com/palantirnet/the-build.git","ssh_url":"git@github.com:palantirnet/the-build.git","clone_url":"https://github.com/palantirnet/the-build.git","svn_url":"https://github.com/palantirnet/the-build","homepage":"","size":372,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":0,"open_issues":28,"watchers":2,"default_branch":"release-1.0"}},"_links":{"self":{"href":"https://api.github.com/repos/palantirnet/the-build/pulls/99"},"html":{"href":"https://github.com/palantirnet/the-build/pull/99"},"issue":{"href":"https://api.github.com/repos/palantirnet/the-build/issues/99"},"comments":{"href":"https://api.github.com/repos/palantirnet/the-build/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/palantirnet/the-build/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/palantirnet/the-build/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantirnet/the-build/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/palantirnet/the-build/statuses/b143b934897b6fc65c5a5bfff23e484b4d3c6644"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"becw"}}