{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/10226","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/10226/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/10226/comments","events_url":"https://api.github.com/repos/helm/charts/issues/10226/events","html_url":"https://github.com/helm/charts/pull/10226","id":393714691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjYwNDAw","number":10226,"title":"[incubator/schema-registry] improve/fix secrets to allow JKS","user":{"login":"bluebenno","id":960889,"node_id":"MDQ6VXNlcjk2MDg4OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/960889?v=4","gravatar_id":"","url":"https://api.github.com/users/bluebenno","html_url":"https://github.com/bluebenno","followers_url":"https://api.github.com/users/bluebenno/followers","following_url":"https://api.github.com/users/bluebenno/following{/other_user}","gists_url":"https://api.github.com/users/bluebenno/gists{/gist_id}","starred_url":"https://api.github.com/users/bluebenno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluebenno/subscriptions","organizations_url":"https://api.github.com/users/bluebenno/orgs","repos_url":"https://api.github.com/users/bluebenno/repos","events_url":"https://api.github.com/users/bluebenno/events{/privacy}","received_events_url":"https://api.github.com/users/bluebenno/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":676477477,"node_id":"MDU6TGFiZWw2NzY0Nzc0Nzc=","url":"https://api.github.com/repos/helm/charts/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"benjigoldberg","id":6841489,"node_id":"MDQ6VXNlcjY4NDE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6841489?v=4","gravatar_id":"","url":"https://api.github.com/users/benjigoldberg","html_url":"https://github.com/benjigoldberg","followers_url":"https://api.github.com/users/benjigoldberg/followers","following_url":"https://api.github.com/users/benjigoldberg/following{/other_user}","gists_url":"https://api.github.com/users/benjigoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/benjigoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjigoldberg/subscriptions","organizations_url":"https://api.github.com/users/benjigoldberg/orgs","repos_url":"https://api.github.com/users/benjigoldberg/repos","events_url":"https://api.github.com/users/benjigoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/benjigoldberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"benjigoldberg","id":6841489,"node_id":"MDQ6VXNlcjY4NDE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6841489?v=4","gravatar_id":"","url":"https://api.github.com/users/benjigoldberg","html_url":"https://github.com/benjigoldberg","followers_url":"https://api.github.com/users/benjigoldberg/followers","following_url":"https://api.github.com/users/benjigoldberg/following{/other_user}","gists_url":"https://api.github.com/users/benjigoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/benjigoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjigoldberg/subscriptions","organizations_url":"https://api.github.com/users/benjigoldberg/orgs","repos_url":"https://api.github.com/users/benjigoldberg/repos","events_url":"https://api.github.com/users/benjigoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/benjigoldberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-23T01:16:39Z","updated_at":"2018-12-24T16:19:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/10226","html_url":"https://github.com/helm/charts/pull/10226","diff_url":"https://github.com/helm/charts/pull/10226.diff","patch_url":"https://github.com/helm/charts/pull/10226.patch"},"body":"Signed-off-by: Ben Tucker <ben_tucker@hotmail.com>\r\n\r\n#### What this PR does / why we need it:\r\nThis PR is to allow secrets to be presented to the container as mounts OR environment variables, specifically for Java Trust and Java Keystores + their passwords.  I tried to match the pattern of similar charts, such as the Kafka one. \r\n\r\n#### Special notes for your reviewer:\r\nPresenting a (binary) JKS file as an environmental variable won't work, it has to be a file.  \r\nAre you happy with the updated version, should I have gone a minor one? \r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x ] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x ] Chart Version bumped\r\n- [x ] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/449751518","html_url":"https://github.com/helm/charts/pull/10226#issuecomment-449751518","issue_url":"https://api.github.com/repos/helm/charts/issues/10226","id":449751518,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTc1MTUxOA==","user":{"login":"benjigoldberg","id":6841489,"node_id":"MDQ6VXNlcjY4NDE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6841489?v=4","gravatar_id":"","url":"https://api.github.com/users/benjigoldberg","html_url":"https://github.com/benjigoldberg","followers_url":"https://api.github.com/users/benjigoldberg/followers","following_url":"https://api.github.com/users/benjigoldberg/following{/other_user}","gists_url":"https://api.github.com/users/benjigoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/benjigoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjigoldberg/subscriptions","organizations_url":"https://api.github.com/users/benjigoldberg/orgs","repos_url":"https://api.github.com/users/benjigoldberg/repos","events_url":"https://api.github.com/users/benjigoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/benjigoldberg/received_events","type":"User","site_admin":false},"created_at":"2018-12-24T16:19:38Z","updated_at":"2018-12-24T16:19:38Z","author_association":"COLLABORATOR","body":"/ok-to-test"}}
{"actor":{"display_login":"benjigoldberg"}}