{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/205063860","pull_request_review_id":140253903,"id":205063860,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTA2Mzg2MA==","diff_hunk":"@@ -5,13 +5,28 @@\n \n package utils\n \n+/*\n+#include <linux/vhost.h>","path":"virtcontainers/utils/utils.go","position":5,"original_position":5,"commit_id":"f97b0212d1d137b0cad871bfac4f3ce4fcf78aa5","original_commit_id":"f97b0212d1d137b0cad871bfac4f3ce4fcf78aa5","user":{"login":"jodh-intel","id":20315601,"node_id":"MDQ6VXNlcjIwMzE1NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/20315601?v=4","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"body":"Linux-specific file so this probably should be moved to `virtcontainers/utils/utils_linux.go`.\r\n\r\nSee #379.\r\n\r\n/cc @raravena80.","created_at":"2018-07-25T10:49:07Z","updated_at":"2018-07-25T10:51:59Z","html_url":"https://github.com/kata-containers/runtime/pull/497#discussion_r205063860","pull_request_url":"https://api.github.com/repos/kata-containers/runtime/pulls/497","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/205063860"},"html":{"href":"https://github.com/kata-containers/runtime/pull/497#discussion_r205063860"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/497"}}},"pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/497","id":202310862,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzEwODYy","html_url":"https://github.com/kata-containers/runtime/pull/497","diff_url":"https://github.com/kata-containers/runtime/pull/497.diff","patch_url":"https://github.com/kata-containers/runtime/pull/497.patch","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/497","number":497,"state":"open","locked":false,"title":"Use VSOCK when is available in the host.","user":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"body":"This PR completes the support to use vsock and no proxy configuration.\r\n\r\nIn order to create add VSOCK support we added:\r\n\r\n- hotplug support for VSOCK socket device.\r\n- Implemented a way to find a context ID based in a random search.\r\n A random  number  is generated between 3 and max `uint32` (4'294,967,295)\r\nand uses it as context ID. The range is large enough to have a low collision probability. Using `ioctl` checks if the context ID is free, else find the immediate next free context ID.\r\n\r\n- When the hypervisor option `use_vsock` is true the runtime will check for vsock support . It vsock is supported, not proxy will be used and the shims will connect to the VM using VSOCKS. This flag is true by default, so will use VSOCK when possible.\r\n\r\n- The `kata-env` subcommand now shows information about if VSOCK will be used or not. \r\n\r\nfixes #383\r\n\r\nSigned-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>\r\nSigned-off-by: Julio Montes <julio.montes@intel.com>\r\n\r\n\r\n","created_at":"2018-07-18T16:28:27Z","updated_at":"2018-07-25T10:51:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ade31dadea3ed78bf7dbd00db36e7ea771c9283","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":764364758,"node_id":"MDU6TGFiZWw3NjQzNjQ3NTg=","url":"https://api.github.com/repos/kata-containers/runtime/labels/do-not-merge","name":"do-not-merge","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/runtime/pulls/497/commits","review_comments_url":"https://api.github.com/repos/kata-containers/runtime/pulls/497/comments","review_comment_url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/497/comments","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/f97b0212d1d137b0cad871bfac4f3ce4fcf78aa5","head":{"label":"jcvenegas:vsock-runtime5","ref":"vsock-runtime5","sha":"f97b0212d1d137b0cad871bfac4f3ce4fcf78aa5","user":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"repo":{"id":125081671,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwODE2NzE=","name":"runtime-1","full_name":"jcvenegas/runtime-1","owner":{"login":"jcvenegas","id":20407785,"node_id":"MDQ6VXNlcjIwNDA3Nzg1","avatar_url":"https://avatars3.githubusercontent.com/u/20407785?v=4","gravatar_id":"","url":"https://api.github.com/users/jcvenegas","html_url":"https://github.com/jcvenegas","followers_url":"https://api.github.com/users/jcvenegas/followers","following_url":"https://api.github.com/users/jcvenegas/following{/other_user}","gists_url":"https://api.github.com/users/jcvenegas/gists{/gist_id}","starred_url":"https://api.github.com/users/jcvenegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcvenegas/subscriptions","organizations_url":"https://api.github.com/users/jcvenegas/orgs","repos_url":"https://api.github.com/users/jcvenegas/repos","events_url":"https://api.github.com/users/jcvenegas/events{/privacy}","received_events_url":"https://api.github.com/users/jcvenegas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcvenegas/runtime-1","description":"Kata Containers runtimes","fork":true,"url":"https://api.github.com/repos/jcvenegas/runtime-1","forks_url":"https://api.github.com/repos/jcvenegas/runtime-1/forks","keys_url":"https://api.github.com/repos/jcvenegas/runtime-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcvenegas/runtime-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcvenegas/runtime-1/teams","hooks_url":"https://api.github.com/repos/jcvenegas/runtime-1/hooks","issue_events_url":"https://api.github.com/repos/jcvenegas/runtime-1/issues/events{/number}","events_url":"https://api.github.com/repos/jcvenegas/runtime-1/events","assignees_url":"https://api.github.com/repos/jcvenegas/runtime-1/assignees{/user}","branches_url":"https://api.github.com/repos/jcvenegas/runtime-1/branches{/branch}","tags_url":"https://api.github.com/repos/jcvenegas/runtime-1/tags","blobs_url":"https://api.github.com/repos/jcvenegas/runtime-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcvenegas/runtime-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcvenegas/runtime-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcvenegas/runtime-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcvenegas/runtime-1/statuses/{sha}","languages_url":"https://api.github.com/repos/jcvenegas/runtime-1/languages","stargazers_url":"https://api.github.com/repos/jcvenegas/runtime-1/stargazers","contributors_url":"https://api.github.com/repos/jcvenegas/runtime-1/contributors","subscribers_url":"https://api.github.com/repos/jcvenegas/runtime-1/subscribers","subscription_url":"https://api.github.com/repos/jcvenegas/runtime-1/subscription","commits_url":"https://api.github.com/repos/jcvenegas/runtime-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcvenegas/runtime-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcvenegas/runtime-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcvenegas/runtime-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcvenegas/runtime-1/contents/{+path}","compare_url":"https://api.github.com/repos/jcvenegas/runtime-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcvenegas/runtime-1/merges","archive_url":"https://api.github.com/repos/jcvenegas/runtime-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcvenegas/runtime-1/downloads","issues_url":"https://api.github.com/repos/jcvenegas/runtime-1/issues{/number}","pulls_url":"https://api.github.com/repos/jcvenegas/runtime-1/pulls{/number}","milestones_url":"https://api.github.com/repos/jcvenegas/runtime-1/milestones{/number}","notifications_url":"https://api.github.com/repos/jcvenegas/runtime-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcvenegas/runtime-1/labels{/name}","releases_url":"https://api.github.com/repos/jcvenegas/runtime-1/releases{/id}","deployments_url":"https://api.github.com/repos/jcvenegas/runtime-1/deployments","created_at":"2018-03-13T16:27:41Z","updated_at":"2018-03-15T18:17:06Z","pushed_at":"2018-07-24T19:07:53Z","git_url":"git://github.com/jcvenegas/runtime-1.git","ssh_url":"git@github.com:jcvenegas/runtime-1.git","clone_url":"https://github.com/jcvenegas/runtime-1.git","svn_url":"https://github.com/jcvenegas/runtime-1","homepage":"","size":4447,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"cli-runtime"}},"base":{"label":"kata-containers:master","ref":"master","sha":"cd133dc9cbf31989979bc1824813693f9f9dfbdf","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539997,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk5OTc=","name":"runtime","full_name":"kata-containers/runtime","owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kata-containers/runtime","description":"Kata Containers runtime","fork":false,"url":"https://api.github.com/repos/kata-containers/runtime","forks_url":"https://api.github.com/repos/kata-containers/runtime/forks","keys_url":"https://api.github.com/repos/kata-containers/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/runtime/teams","hooks_url":"https://api.github.com/repos/kata-containers/runtime/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/runtime/events","assignees_url":"https://api.github.com/repos/kata-containers/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/runtime/tags","blobs_url":"https://api.github.com/repos/kata-containers/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/runtime/languages","stargazers_url":"https://api.github.com/repos/kata-containers/runtime/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/runtime/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/runtime/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/runtime/subscription","commits_url":"https://api.github.com/repos/kata-containers/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/runtime/merges","archive_url":"https://api.github.com/repos/kata-containers/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/runtime/downloads","issues_url":"https://api.github.com/repos/kata-containers/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/runtime/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/runtime/deployments","created_at":"2017-11-13T11:29:03Z","updated_at":"2018-07-25T10:13:01Z","pushed_at":"2018-07-25T10:12:58Z","git_url":"git://github.com/kata-containers/runtime.git","ssh_url":"git@github.com:kata-containers/runtime.git","clone_url":"https://github.com/kata-containers/runtime.git","svn_url":"https://github.com/kata-containers/runtime","homepage":"","size":4389,"stargazers_count":395,"watchers_count":395,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":89,"open_issues":120,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/497"},"html":{"href":"https://github.com/kata-containers/runtime/pull/497"},"issue":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/497"},"comments":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/runtime/statuses/f97b0212d1d137b0cad871bfac4f3ce4fcf78aa5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jodh-intel"}}