{"action":"created","issue":{"url":"https://api.github.com/repos/mhartington/oceanic-next/issues/68","repository_url":"https://api.github.com/repos/mhartington/oceanic-next","labels_url":"https://api.github.com/repos/mhartington/oceanic-next/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/mhartington/oceanic-next/issues/68/comments","events_url":"https://api.github.com/repos/mhartington/oceanic-next/issues/68/events","html_url":"https://github.com/mhartington/oceanic-next/pull/68","id":316408356,"number":68,"title":"added option for end-of-buffer","user":{"login":"fobbyal","id":7818365,"avatar_url":"https://avatars2.githubusercontent.com/u/7818365?v=4","gravatar_id":"","url":"https://api.github.com/users/fobbyal","html_url":"https://github.com/fobbyal","followers_url":"https://api.github.com/users/fobbyal/followers","following_url":"https://api.github.com/users/fobbyal/following{/other_user}","gists_url":"https://api.github.com/users/fobbyal/gists{/gist_id}","starred_url":"https://api.github.com/users/fobbyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fobbyal/subscriptions","organizations_url":"https://api.github.com/users/fobbyal/orgs","repos_url":"https://api.github.com/users/fobbyal/repos","events_url":"https://api.github.com/users/fobbyal/events{/privacy}","received_events_url":"https://api.github.com/users/fobbyal/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-20T20:53:43Z","updated_at":"2018-05-18T13:39:30Z","closed_at":"2018-05-18T13:39:30Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mhartington/oceanic-next/pulls/68","html_url":"https://github.com/mhartington/oceanic-next/pull/68","diff_url":"https://github.com/mhartington/oceanic-next/pull/68.diff","patch_url":"https://github.com/mhartington/oceanic-next/pull/68.patch"},"body":"First, thank you so much for all the hard work you have put into this. \r\n\r\n\r\nWith a recent update of oceanic next I ran into a problem with my setup. I configure my terminal with a level of transparency (the desktop background is some what visible). It has worked well with oceanic-next in the past. However when i upgraded the plugin last week the behavior of the plugin changed and it now painted an opaque background. I was able to find the `EndOfBuffer` commit and added an option to not paint the opaque color. I tried to follow the same style of code please let me know if this can be me merged.\r\n\r\n## Default Behavior\r\n![screenshot 1524256824](https://user-images.githubusercontent.com/7818365/39073175-df3bde0e-44ba-11e8-81d2-807e1ee14896.jpg)\r\n## Behavior with option\r\n`let g:oceanic_next_disable_end_of_buffer = 1`\r\n![screenshot 1524256954](https://user-images.githubusercontent.com/7818365/39073174-df3007dc-44ba-11e8-8907-14316abe8b5f.jpg)\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mhartington/oceanic-next/issues/comments/390210121","html_url":"https://github.com/mhartington/oceanic-next/pull/68#issuecomment-390210121","issue_url":"https://api.github.com/repos/mhartington/oceanic-next/issues/68","id":390210121,"user":{"login":"mhartington","id":2835826,"avatar_url":"https://avatars3.githubusercontent.com/u/2835826?v=4","gravatar_id":"","url":"https://api.github.com/users/mhartington","html_url":"https://github.com/mhartington","followers_url":"https://api.github.com/users/mhartington/followers","following_url":"https://api.github.com/users/mhartington/following{/other_user}","gists_url":"https://api.github.com/users/mhartington/gists{/gist_id}","starred_url":"https://api.github.com/users/mhartington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhartington/subscriptions","organizations_url":"https://api.github.com/users/mhartington/orgs","repos_url":"https://api.github.com/users/mhartington/repos","events_url":"https://api.github.com/users/mhartington/events{/privacy}","received_events_url":"https://api.github.com/users/mhartington/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T13:39:30Z","updated_at":"2018-05-18T13:39:30Z","author_association":"OWNER","body":"I dont think this is something I'll merge. While I appreciate the PR, I think this kind of customization should belong in the users RC file. You could get this with a combo of\r\n\r\n```\r\nhi Normal guibg=NONE ctermbg=NONE\r\nhi EndOfBuffer guibg=NONE ctermbg=NONE\r\n```\r\n\r\nThanks!"}}
{"actor":{"display_login":"mhartington"}}