{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/172961714","pull_request_review_id":102068527,"id":172961714,"diff_hunk":"@@ -80,9 +80,21 @@\n   {\n     \"name\": \"noop$2\"\n   },\n+  {","path":"packages/core/test/bundling/hello_world/bundle.golden_symbols.json","position":24,"original_position":24,"commit_id":"75e966f74e76456891e24bae398cd8407172f400","original_commit_id":"75e966f74e76456891e24bae398cd8407172f400","user":{"login":"mhevery","id":111951,"avatar_url":"https://avatars0.githubusercontent.com/u/111951?v=4","gravatar_id":"","url":"https://api.github.com/users/mhevery","html_url":"https://github.com/mhevery","followers_url":"https://api.github.com/users/mhevery/followers","following_url":"https://api.github.com/users/mhevery/following{/other_user}","gists_url":"https://api.github.com/users/mhevery/gists{/gist_id}","starred_url":"https://api.github.com/users/mhevery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhevery/subscriptions","organizations_url":"https://api.github.com/users/mhevery/orgs","repos_url":"https://api.github.com/users/mhevery/repos","events_url":"https://api.github.com/users/mhevery/events{/privacy}","received_events_url":"https://api.github.com/users/mhevery/received_events","type":"User","site_admin":false},"body":"we are pulling in new methods into the system. Not sure I like this. Can we somehow hide these behind a feature. Let's discuss offline.","created_at":"2018-03-07T19:41:35Z","updated_at":"2018-03-07T19:43:14Z","html_url":"https://github.com/angular/angular/pull/22614#discussion_r172961714","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/22614","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/172961714"},"html":{"href":"https://github.com/angular/angular/pull/22614#discussion_r172961714"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/22614"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/22614","id":173284095,"html_url":"https://github.com/angular/angular/pull/22614","diff_url":"https://github.com/angular/angular/pull/22614.diff","patch_url":"https://github.com/angular/angular/pull/22614.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/22614","number":22614,"state":"open","locked":false,"title":" feat(ivy): support ChangeDetectorRef.detectChanges","user":{"login":"kara","id":3871688,"avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false},"body":"This PR adds support for `ChangeDetectorRef.detectChanges` calls in components and directives.\r\n\r\nNotes:\r\n- `detectChanges` as it was implemented before was re-named to `detectChangesOnRoot`. This was necessary because its implementation did not match the behavior of the historical `detectChanges` (which does not call lifecycle hooks or care about dirtiness), but it still needed to be retained for when change detection is queued. There is now a new `detectChanges` method that simply checks the view for manual calls.\r\n- Moved `markDirty` tests from `component_spec.ts` to `change_detection_spec.ts`. The only new tests are in the `detectChanges()` describe block.\r\n\r\nWaiting on #22610 for a bug fix. Review only last commit.\r\n\r\nTODO in follow-up PRs:\r\n- Support detectChanges calls in dynamically created views \r\n- Attach/detach from change detection\r\n- `markForCheck`, etc","created_at":"2018-03-06T21:19:21Z","updated_at":"2018-03-07T19:43:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f16d9a81f166f33e0cc4d5b4951f2cc6d228461","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":217969169,"url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false},{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":799860804,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20ivy","name":"comp: ivy","color":"c5def5","default":false},{"id":130606845,"url":"https://api.github.com/repos/angular/angular/labels/type:%20feature","name":"type: feature","color":"EEEEEE","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/22614/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/22614/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/22614/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/75e966f74e76456891e24bae398cd8407172f400","head":{"label":"kara:detectChanges","ref":"detectChanges","sha":"75e966f74e76456891e24bae398cd8407172f400","user":{"login":"kara","id":3871688,"avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false},"repo":{"id":30559627,"name":"angular","full_name":"kara/angular","owner":{"login":"kara","id":3871688,"avatar_url":"https://avatars3.githubusercontent.com/u/3871688?v=4","gravatar_id":"","url":"https://api.github.com/users/kara","html_url":"https://github.com/kara","followers_url":"https://api.github.com/users/kara/followers","following_url":"https://api.github.com/users/kara/following{/other_user}","gists_url":"https://api.github.com/users/kara/gists{/gist_id}","starred_url":"https://api.github.com/users/kara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kara/subscriptions","organizations_url":"https://api.github.com/users/kara/orgs","repos_url":"https://api.github.com/users/kara/repos","events_url":"https://api.github.com/users/kara/events{/privacy}","received_events_url":"https://api.github.com/users/kara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kara/angular","description":null,"fork":true,"url":"https://api.github.com/repos/kara/angular","forks_url":"https://api.github.com/repos/kara/angular/forks","keys_url":"https://api.github.com/repos/kara/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kara/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kara/angular/teams","hooks_url":"https://api.github.com/repos/kara/angular/hooks","issue_events_url":"https://api.github.com/repos/kara/angular/issues/events{/number}","events_url":"https://api.github.com/repos/kara/angular/events","assignees_url":"https://api.github.com/repos/kara/angular/assignees{/user}","branches_url":"https://api.github.com/repos/kara/angular/branches{/branch}","tags_url":"https://api.github.com/repos/kara/angular/tags","blobs_url":"https://api.github.com/repos/kara/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kara/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kara/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/kara/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kara/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/kara/angular/languages","stargazers_url":"https://api.github.com/repos/kara/angular/stargazers","contributors_url":"https://api.github.com/repos/kara/angular/contributors","subscribers_url":"https://api.github.com/repos/kara/angular/subscribers","subscription_url":"https://api.github.com/repos/kara/angular/subscription","commits_url":"https://api.github.com/repos/kara/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/kara/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/kara/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/kara/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/kara/angular/contents/{+path}","compare_url":"https://api.github.com/repos/kara/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kara/angular/merges","archive_url":"https://api.github.com/repos/kara/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kara/angular/downloads","issues_url":"https://api.github.com/repos/kara/angular/issues{/number}","pulls_url":"https://api.github.com/repos/kara/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/kara/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/kara/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kara/angular/labels{/name}","releases_url":"https://api.github.com/repos/kara/angular/releases{/id}","deployments_url":"https://api.github.com/repos/kara/angular/deployments","created_at":"2015-02-09T21:32:22Z","updated_at":"2016-01-24T16:23:07Z","pushed_at":"2018-03-07T19:30:18Z","git_url":"git://github.com/kara/angular.git","ssh_url":"git@github.com:kara/angular.git","clone_url":"https://github.com/kara/angular.git","svn_url":"https://github.com/kara/angular","homepage":null,"size":73080,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"505ae752b61a44ca41396838a49f83cfe7badb3b","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-03-07T18:47:41Z","pushed_at":"2018-03-07T19:30:30Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":75415,"stargazers_count":33784,"watchers_count":33784,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8305,"mirror_url":null,"archived":false,"open_issues_count":2171,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8305,"open_issues":2171,"watchers":33784,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/22614"},"html":{"href":"https://github.com/angular/angular/pull/22614"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/22614"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/22614/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/22614/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/22614/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/75e966f74e76456891e24bae398cd8407172f400"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mhevery"}}