{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/202489304","pull_request_review_id":137210026,"id":202489304,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjQ4OTMwNA==","diff_hunk":"@@ -286,12 +306,22 @@ class MDCMenuSurfaceFoundation extends MDCFoundation {\n    */\n   getHorizontalOriginOffset_(corner) {\n     const {anchorWidth} = this.measures_;\n+    // isRightAligned corresponds to using the 'right' property on the surface.\n     const isRightAligned = Boolean(corner & MenuSurfaceCornerBit.RIGHT);\n     const avoidHorizontalOverlap = Boolean(this.anchorCorner_ & MenuSurfaceCornerBit.RIGHT);\n+\n     if (isRightAligned) {\n-      const rightOffset = avoidHorizontalOverlap ? anchorWidth - this.anchorMargin_.left : this.anchorMargin_.right;\n+      let rightOffset = avoidHorizontalOverlap ? anchorWidth - this.anchorMargin_.left : this.anchorMargin_.right;\n+\n+      // Hoisted elements positioning doesn't account for the scrollbar, so the right property needs to be reduced by\n+      // the difference between the window and body width.\n+      if (this.hoistedElement_) {","path":"packages/mdc-menu-surface/foundation.js","position":null,"original_position":89,"commit_id":"2dce2531379d9dfd46cd84ce4ceb59df909cdaa6","original_commit_id":"f4f48ca3b15856451cf52a74ad4bffe33d022269","user":{"login":"williamernest","id":34519388,"node_id":"MDQ6VXNlcjM0NTE5Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/34519388?v=4","gravatar_id":"","url":"https://api.github.com/users/williamernest","html_url":"https://github.com/williamernest","followers_url":"https://api.github.com/users/williamernest/followers","following_url":"https://api.github.com/users/williamernest/following{/other_user}","gists_url":"https://api.github.com/users/williamernest/gists{/gist_id}","starred_url":"https://api.github.com/users/williamernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamernest/subscriptions","organizations_url":"https://api.github.com/users/williamernest/orgs","repos_url":"https://api.github.com/users/williamernest/repos","events_url":"https://api.github.com/users/williamernest/events{/privacy}","received_events_url":"https://api.github.com/users/williamernest/received_events","type":"User","site_admin":false},"body":"The nested line uses the `rightOffset` variable. ","created_at":"2018-07-13T22:43:18Z","updated_at":"2018-07-13T22:43:18Z","html_url":"https://github.com/material-components/material-components-web/pull/3067#discussion_r202489304","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3067","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/202489304"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3067#discussion_r202489304"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3067"}},"in_reply_to_id":202471825},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/3067","id":201347409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzQ3NDA5","html_url":"https://github.com/material-components/material-components-web/pull/3067","diff_url":"https://github.com/material-components/material-components-web/pull/3067.diff","patch_url":"https://github.com/material-components/material-components-web/pull/3067.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/3067","number":3067,"state":"open","locked":false,"title":"feat(menu-surface): Change anchor element","user":{"login":"williamernest","id":34519388,"node_id":"MDQ6VXNlcjM0NTE5Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/34519388?v=4","gravatar_id":"","url":"https://api.github.com/users/williamernest","html_url":"https://github.com/williamernest","followers_url":"https://api.github.com/users/williamernest/followers","following_url":"https://api.github.com/users/williamernest/following{/other_user}","gists_url":"https://api.github.com/users/williamernest/gists{/gist_id}","starred_url":"https://api.github.com/users/williamernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamernest/subscriptions","organizations_url":"https://api.github.com/users/williamernest/orgs","repos_url":"https://api.github.com/users/williamernest/repos","events_url":"https://api.github.com/users/williamernest/events{/privacy}","received_events_url":"https://api.github.com/users/williamernest/received_events","type":"User","site_admin":false},"body":"fixes: #2770 ","created_at":"2018-07-13T17:00:05Z","updated_at":"2018-07-13T22:43:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c166a06bd83ff5d18c69fafc47dd780b12dd3b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3067/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3067/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/3067/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/2dce2531379d9dfd46cd84ce4ceb59df909cdaa6","head":{"label":"material-components:feat/menu-surface/change-anchor-element","ref":"feat/menu-surface/change-anchor-element","sha":"2dce2531379d9dfd46cd84ce4ceb59df909cdaa6","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-07-13T21:00:10Z","pushed_at":"2018-07-13T22:43:02Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":66735,"stargazers_count":9662,"watchers_count":9662,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1120,"mirror_url":null,"archived":false,"open_issues_count":340,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1120,"open_issues":340,"watchers":9662,"default_branch":"master"}},"base":{"label":"material-components:feat/menu-2","ref":"feat/menu-2","sha":"e093afe020d5685d85dbf57cbc90ad3262e4dbfa","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-07-13T21:00:10Z","pushed_at":"2018-07-13T22:43:02Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/components/","size":66735,"stargazers_count":9662,"watchers_count":9662,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1120,"mirror_url":null,"archived":false,"open_issues_count":340,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1120,"open_issues":340,"watchers":9662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3067"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3067"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3067"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3067/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3067/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3067/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/2dce2531379d9dfd46cd84ce4ceb59df909cdaa6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"williamernest"}}