{"action":"created","comment":{"url":"https://api.github.com/repos/apache/systemml/pulls/comments/189164272","pull_request_review_id":121289235,"id":189164272,"diff_hunk":"@@ -364,9 +369,9 @@ else if (sb instanceof FunctionStatementBlock) {\n \t\t\t\t\t\t&& ((ExternalFunctionStatement)fsb.getStatement(0)).isSecondOrder() ) {\n \t\t\t\t\t\tret = true;\n \t\t\t\t\t}\n-\t\t\t\t}\n-\t\t\t\telse if( HopRewriteUtils.isData(h, DataOpTypes.TRANSIENTWRITE)\n-\t\t\t\t\t&& HopRewriteUtils.isNary(h.getInput().get(0), OpOpN.EVAL) ) {\n+\t\t\t\t} else if (HopRewriteUtils.isData(h, DataOpTypes.TRANSIENTWRITE)\n+\t\t\t\t\t\t&& (HopRewriteUtils.isNary(h.getInput().get(0), OpOpN.EVAL)\n+\t\t\t\t\t\t|| HopRewriteUtils.isParameterBuiltinOp(h.getInput().get(0), Hop.ParamBuiltinOp.PARAMSERV))) {","path":"src/main/java/org/apache/sysml/hops/ipa/FunctionCallGraph.java","position":78,"original_position":78,"commit_id":"7f4309c3fe43167cb3fe0a4c10be7da04e3ef15c","original_commit_id":"7f4309c3fe43167cb3fe0a4c10be7da04e3ef15c","user":{"login":"mboehm7","id":13721609,"avatar_url":"https://avatars0.githubusercontent.com/u/13721609?v=4","gravatar_id":"","url":"https://api.github.com/users/mboehm7","html_url":"https://github.com/mboehm7","followers_url":"https://api.github.com/users/mboehm7/followers","following_url":"https://api.github.com/users/mboehm7/following{/other_user}","gists_url":"https://api.github.com/users/mboehm7/gists{/gist_id}","starred_url":"https://api.github.com/users/mboehm7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mboehm7/subscriptions","organizations_url":"https://api.github.com/users/mboehm7/orgs","repos_url":"https://api.github.com/users/mboehm7/repos","events_url":"https://api.github.com/users/mboehm7/events{/privacy}","received_events_url":"https://api.github.com/users/mboehm7/received_events","type":"User","site_admin":false},"body":"Since ParameterizedBuiltinOps can appear anyway in the DAG (not just under the root node) we need a to a DAG traversal to ensure that we catch it in the general case. Please move the probe outside the for loop though to ensure each DAG is traversed just once here. ","created_at":"2018-05-18T05:07:03Z","updated_at":"2018-05-18T05:31:06Z","html_url":"https://github.com/apache/systemml/pull/764#discussion_r189164272","pull_request_url":"https://api.github.com/repos/apache/systemml/pulls/764","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/systemml/pulls/comments/189164272"},"html":{"href":"https://github.com/apache/systemml/pull/764#discussion_r189164272"},"pull_request":{"href":"https://api.github.com/repos/apache/systemml/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/apache/systemml/pulls/764","id":188880795,"html_url":"https://github.com/apache/systemml/pull/764","diff_url":"https://github.com/apache/systemml/pull/764.diff","patch_url":"https://github.com/apache/systemml/pull/764.patch","issue_url":"https://api.github.com/repos/apache/systemml/issues/764","number":764,"state":"open","locked":false,"title":"[Systemml 2084] Implementation of language and compiler extension for paramserv function","user":{"login":"EdgarLGB","id":15153347,"avatar_url":"https://avatars0.githubusercontent.com/u/15153347?v=4","gravatar_id":"","url":"https://api.github.com/users/EdgarLGB","html_url":"https://github.com/EdgarLGB","followers_url":"https://api.github.com/users/EdgarLGB/followers","following_url":"https://api.github.com/users/EdgarLGB/following{/other_user}","gists_url":"https://api.github.com/users/EdgarLGB/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarLGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarLGB/subscriptions","organizations_url":"https://api.github.com/users/EdgarLGB/orgs","repos_url":"https://api.github.com/users/EdgarLGB/repos","events_url":"https://api.github.com/users/EdgarLGB/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarLGB/received_events","type":"User","site_admin":false},"body":"Hi @mboehm7 ,\r\n\r\nHere is the extension of language and compiler for the new paramserv builtin function. And I also added some basic tests and then will add another test that the paramserv function is included inside parfor after the support of list type for parfor.\r\n\r\nThanks for review,\r\nGuobao","created_at":"2018-05-17T22:46:12Z","updated_at":"2018-05-18T05:31:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8d75d331af3bc48316dba34a6a0f602e29d68d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/systemml/pulls/764/commits","review_comments_url":"https://api.github.com/repos/apache/systemml/pulls/764/comments","review_comment_url":"https://api.github.com/repos/apache/systemml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/systemml/issues/764/comments","statuses_url":"https://api.github.com/repos/apache/systemml/statuses/7f4309c3fe43167cb3fe0a4c10be7da04e3ef15c","head":{"label":"EdgarLGB:systemml-2084","ref":"systemml-2084","sha":"7f4309c3fe43167cb3fe0a4c10be7da04e3ef15c","user":{"login":"EdgarLGB","id":15153347,"avatar_url":"https://avatars0.githubusercontent.com/u/15153347?v=4","gravatar_id":"","url":"https://api.github.com/users/EdgarLGB","html_url":"https://github.com/EdgarLGB","followers_url":"https://api.github.com/users/EdgarLGB/followers","following_url":"https://api.github.com/users/EdgarLGB/following{/other_user}","gists_url":"https://api.github.com/users/EdgarLGB/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarLGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarLGB/subscriptions","organizations_url":"https://api.github.com/users/EdgarLGB/orgs","repos_url":"https://api.github.com/users/EdgarLGB/repos","events_url":"https://api.github.com/users/EdgarLGB/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarLGB/received_events","type":"User","site_admin":false},"repo":{"id":123602502,"name":"systemml","full_name":"EdgarLGB/systemml","owner":{"login":"EdgarLGB","id":15153347,"avatar_url":"https://avatars0.githubusercontent.com/u/15153347?v=4","gravatar_id":"","url":"https://api.github.com/users/EdgarLGB","html_url":"https://github.com/EdgarLGB","followers_url":"https://api.github.com/users/EdgarLGB/followers","following_url":"https://api.github.com/users/EdgarLGB/following{/other_user}","gists_url":"https://api.github.com/users/EdgarLGB/gists{/gist_id}","starred_url":"https://api.github.com/users/EdgarLGB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EdgarLGB/subscriptions","organizations_url":"https://api.github.com/users/EdgarLGB/orgs","repos_url":"https://api.github.com/users/EdgarLGB/repos","events_url":"https://api.github.com/users/EdgarLGB/events{/privacy}","received_events_url":"https://api.github.com/users/EdgarLGB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EdgarLGB/systemml","description":"Mirror of Apache SystemML","fork":true,"url":"https://api.github.com/repos/EdgarLGB/systemml","forks_url":"https://api.github.com/repos/EdgarLGB/systemml/forks","keys_url":"https://api.github.com/repos/EdgarLGB/systemml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EdgarLGB/systemml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EdgarLGB/systemml/teams","hooks_url":"https://api.github.com/repos/EdgarLGB/systemml/hooks","issue_events_url":"https://api.github.com/repos/EdgarLGB/systemml/issues/events{/number}","events_url":"https://api.github.com/repos/EdgarLGB/systemml/events","assignees_url":"https://api.github.com/repos/EdgarLGB/systemml/assignees{/user}","branches_url":"https://api.github.com/repos/EdgarLGB/systemml/branches{/branch}","tags_url":"https://api.github.com/repos/EdgarLGB/systemml/tags","blobs_url":"https://api.github.com/repos/EdgarLGB/systemml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EdgarLGB/systemml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EdgarLGB/systemml/git/refs{/sha}","trees_url":"https://api.github.com/repos/EdgarLGB/systemml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EdgarLGB/systemml/statuses/{sha}","languages_url":"https://api.github.com/repos/EdgarLGB/systemml/languages","stargazers_url":"https://api.github.com/repos/EdgarLGB/systemml/stargazers","contributors_url":"https://api.github.com/repos/EdgarLGB/systemml/contributors","subscribers_url":"https://api.github.com/repos/EdgarLGB/systemml/subscribers","subscription_url":"https://api.github.com/repos/EdgarLGB/systemml/subscription","commits_url":"https://api.github.com/repos/EdgarLGB/systemml/commits{/sha}","git_commits_url":"https://api.github.com/repos/EdgarLGB/systemml/git/commits{/sha}","comments_url":"https://api.github.com/repos/EdgarLGB/systemml/comments{/number}","issue_comment_url":"https://api.github.com/repos/EdgarLGB/systemml/issues/comments{/number}","contents_url":"https://api.github.com/repos/EdgarLGB/systemml/contents/{+path}","compare_url":"https://api.github.com/repos/EdgarLGB/systemml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EdgarLGB/systemml/merges","archive_url":"https://api.github.com/repos/EdgarLGB/systemml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EdgarLGB/systemml/downloads","issues_url":"https://api.github.com/repos/EdgarLGB/systemml/issues{/number}","pulls_url":"https://api.github.com/repos/EdgarLGB/systemml/pulls{/number}","milestones_url":"https://api.github.com/repos/EdgarLGB/systemml/milestones{/number}","notifications_url":"https://api.github.com/repos/EdgarLGB/systemml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EdgarLGB/systemml/labels{/name}","releases_url":"https://api.github.com/repos/EdgarLGB/systemml/releases{/id}","deployments_url":"https://api.github.com/repos/EdgarLGB/systemml/deployments","created_at":"2018-03-02T16:23:19Z","updated_at":"2018-03-29T12:53:12Z","pushed_at":"2018-05-17T22:44:07Z","git_url":"git://github.com/EdgarLGB/systemml.git","ssh_url":"git@github.com:EdgarLGB/systemml.git","clone_url":"https://github.com/EdgarLGB/systemml.git","svn_url":"https://github.com/EdgarLGB/systemml","homepage":"","size":207405,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c93d806020fc865bd1d41c52a4bfdba3863d96db","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45896813,"name":"systemml","full_name":"apache/systemml","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/systemml","description":"Mirror of Apache SystemML","fork":false,"url":"https://api.github.com/repos/apache/systemml","forks_url":"https://api.github.com/repos/apache/systemml/forks","keys_url":"https://api.github.com/repos/apache/systemml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/systemml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/systemml/teams","hooks_url":"https://api.github.com/repos/apache/systemml/hooks","issue_events_url":"https://api.github.com/repos/apache/systemml/issues/events{/number}","events_url":"https://api.github.com/repos/apache/systemml/events","assignees_url":"https://api.github.com/repos/apache/systemml/assignees{/user}","branches_url":"https://api.github.com/repos/apache/systemml/branches{/branch}","tags_url":"https://api.github.com/repos/apache/systemml/tags","blobs_url":"https://api.github.com/repos/apache/systemml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/systemml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/systemml/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/systemml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/systemml/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/systemml/languages","stargazers_url":"https://api.github.com/repos/apache/systemml/stargazers","contributors_url":"https://api.github.com/repos/apache/systemml/contributors","subscribers_url":"https://api.github.com/repos/apache/systemml/subscribers","subscription_url":"https://api.github.com/repos/apache/systemml/subscription","commits_url":"https://api.github.com/repos/apache/systemml/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/systemml/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/systemml/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/systemml/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/systemml/contents/{+path}","compare_url":"https://api.github.com/repos/apache/systemml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/systemml/merges","archive_url":"https://api.github.com/repos/apache/systemml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/systemml/downloads","issues_url":"https://api.github.com/repos/apache/systemml/issues{/number}","pulls_url":"https://api.github.com/repos/apache/systemml/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/systemml/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/systemml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/systemml/labels{/name}","releases_url":"https://api.github.com/repos/apache/systemml/releases{/id}","deployments_url":"https://api.github.com/repos/apache/systemml/deployments","created_at":"2015-11-10T08:00:06Z","updated_at":"2018-05-18T03:38:12Z","pushed_at":"2018-05-18T03:38:06Z","git_url":"git://github.com/apache/systemml.git","ssh_url":"git@github.com:apache/systemml.git","clone_url":"https://github.com/apache/systemml.git","svn_url":"https://github.com/apache/systemml","homepage":"","size":207326,"stargazers_count":677,"watchers_count":677,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":264,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":264,"open_issues":23,"watchers":677,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/systemml/pulls/764"},"html":{"href":"https://github.com/apache/systemml/pull/764"},"issue":{"href":"https://api.github.com/repos/apache/systemml/issues/764"},"comments":{"href":"https://api.github.com/repos/apache/systemml/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/systemml/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/systemml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/systemml/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/apache/systemml/statuses/7f4309c3fe43167cb3fe0a4c10be7da04e3ef15c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mboehm7"}}