{"action":"created","comment":{"url":"https://api.github.com/repos/telstra/openapi-platform/pulls/comments/225030318","pull_request_review_id":164540300,"id":225030318,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTAzMDMxOA==","diff_hunk":"@@ -48,14 +48,23 @@ export class SdkConfigItem extends Component<SdkConfigItemProps> {\n   @observable\n   private latestSdkUrl?: string;\n \n+  /**\n+   * TODO: Not really sure when this got approved but this method really shouldn't be inside of a\n+   * basic component.\n+   */\n   @action\n   public createSdk = async () => {\n-    const sdk: HasId<Sdk> = await client\n+    this.latestSdkUrl = undefined;\n+    // TODO: Little hacky changing modifying one's own props\n+    this.props.sdkConfig.buildStatus = BuildStatus.Building;\n+    client\n       .service('sdks')\n-      .create({ sdkConfigId: this.props.sdkConfig.id });\n-    // TODO: Need to get this from the actual backend\n-    this.props.sdkConfig.buildStatus = BuildStatus.Success;\n-    this.latestSdkUrl = sdk.path;\n+      .create({ sdkConfigId: this.props.sdkConfig.id })\n+      .then(","path":"packages/frontend-dist/src/view/basic/SdkConfigItem.tsx","position":30,"original_position":30,"commit_id":"2a58fd123a8b1c3f0a9f41020a9e16f4331f471b","original_commit_id":"2a58fd123a8b1c3f0a9f41020a9e16f4331f471b","user":{"login":"calebj0seph","id":936267,"node_id":"MDQ6VXNlcjkzNjI2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/936267?v=4","gravatar_id":"","url":"https://api.github.com/users/calebj0seph","html_url":"https://github.com/calebj0seph","followers_url":"https://api.github.com/users/calebj0seph/followers","following_url":"https://api.github.com/users/calebj0seph/following{/other_user}","gists_url":"https://api.github.com/users/calebj0seph/gists{/gist_id}","starred_url":"https://api.github.com/users/calebj0seph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebj0seph/subscriptions","organizations_url":"https://api.github.com/users/calebj0seph/orgs","repos_url":"https://api.github.com/users/calebj0seph/repos","events_url":"https://api.github.com/users/calebj0seph/events{/privacy}","received_events_url":"https://api.github.com/users/calebj0seph/received_events","type":"User","site_admin":false},"body":"This is an async function, why not sue await here?","created_at":"2018-10-15T03:27:57Z","updated_at":"2018-10-15T03:27:57Z","html_url":"https://github.com/telstra/openapi-platform/pull/89#discussion_r225030318","pull_request_url":"https://api.github.com/repos/telstra/openapi-platform/pulls/89","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/telstra/openapi-platform/pulls/comments/225030318"},"html":{"href":"https://github.com/telstra/openapi-platform/pull/89#discussion_r225030318"},"pull_request":{"href":"https://api.github.com/repos/telstra/openapi-platform/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/telstra/openapi-platform/pulls/89","id":220954796,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTU0Nzk2","html_url":"https://github.com/telstra/openapi-platform/pull/89","diff_url":"https://github.com/telstra/openapi-platform/pull/89.diff","patch_url":"https://github.com/telstra/openapi-platform/pull/89.patch","issue_url":"https://api.github.com/repos/telstra/openapi-platform/issues/89","number":89,"state":"open","locked":false,"title":"Better git integration + Real time updates!","user":{"login":"PatrickShaw","id":5153619,"node_id":"MDQ6VXNlcjUxNTM2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5153619?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickShaw","html_url":"https://github.com/PatrickShaw","followers_url":"https://api.github.com/users/PatrickShaw/followers","following_url":"https://api.github.com/users/PatrickShaw/following{/other_user}","gists_url":"https://api.github.com/users/PatrickShaw/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickShaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickShaw/subscriptions","organizations_url":"https://api.github.com/users/PatrickShaw/orgs","repos_url":"https://api.github.com/users/PatrickShaw/repos","events_url":"https://api.github.com/users/PatrickShaw/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickShaw/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n- Pushing wasn't working with GitHub since shallow fetches weren't working so that's been disabled.\r\n- OpenAPI Platform wasn't actually staging deleted files so that's been fixed.\r\n- The build status updates in real time. First time we're actually making use of the real-time API that featherjs provides which is pretty cool.\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce to OpenAPI Platform?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [x] I have read the [CONTRIBUTING](../CONTRIBUTING.md) doc\r\n- [x] I have signed and submitted the appropriate [CLA](../docs/contrib)\r\n- [x] Lint and unit tests pass locally with my changes\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation (if appropriate)\r\n- [x] Any dependent changes have been merged and published in downstream modules\r\n\r\n## Further comments\r\n\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...","created_at":"2018-10-07T15:25:46Z","updated_at":"2018-10-15T03:27:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7118199c791c5e4208b6de1ed7440eeda4272fab","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TimGebert","id":5628249,"node_id":"MDQ6VXNlcjU2MjgyNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/5628249?v=4","gravatar_id":"","url":"https://api.github.com/users/TimGebert","html_url":"https://github.com/TimGebert","followers_url":"https://api.github.com/users/TimGebert/followers","following_url":"https://api.github.com/users/TimGebert/following{/other_user}","gists_url":"https://api.github.com/users/TimGebert/gists{/gist_id}","starred_url":"https://api.github.com/users/TimGebert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimGebert/subscriptions","organizations_url":"https://api.github.com/users/TimGebert/orgs","repos_url":"https://api.github.com/users/TimGebert/repos","events_url":"https://api.github.com/users/TimGebert/events{/privacy}","received_events_url":"https://api.github.com/users/TimGebert/received_events","type":"User","site_admin":false},{"login":"hferrier","id":26944064,"node_id":"MDQ6VXNlcjI2OTQ0MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/26944064?v=4","gravatar_id":"","url":"https://api.github.com/users/hferrier","html_url":"https://github.com/hferrier","followers_url":"https://api.github.com/users/hferrier/followers","following_url":"https://api.github.com/users/hferrier/following{/other_user}","gists_url":"https://api.github.com/users/hferrier/gists{/gist_id}","starred_url":"https://api.github.com/users/hferrier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferrier/subscriptions","organizations_url":"https://api.github.com/users/hferrier/orgs","repos_url":"https://api.github.com/users/hferrier/repos","events_url":"https://api.github.com/users/hferrier/events{/privacy}","received_events_url":"https://api.github.com/users/hferrier/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/telstra/openapi-platform/pulls/89/commits","review_comments_url":"https://api.github.com/repos/telstra/openapi-platform/pulls/89/comments","review_comment_url":"https://api.github.com/repos/telstra/openapi-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telstra/openapi-platform/issues/89/comments","statuses_url":"https://api.github.com/repos/telstra/openapi-platform/statuses/2a58fd123a8b1c3f0a9f41020a9e16f4331f471b","head":{"label":"PatrickShaw:better-git-integration","ref":"better-git-integration","sha":"2a58fd123a8b1c3f0a9f41020a9e16f4331f471b","user":{"login":"PatrickShaw","id":5153619,"node_id":"MDQ6VXNlcjUxNTM2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5153619?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickShaw","html_url":"https://github.com/PatrickShaw","followers_url":"https://api.github.com/users/PatrickShaw/followers","following_url":"https://api.github.com/users/PatrickShaw/following{/other_user}","gists_url":"https://api.github.com/users/PatrickShaw/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickShaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickShaw/subscriptions","organizations_url":"https://api.github.com/users/PatrickShaw/orgs","repos_url":"https://api.github.com/users/PatrickShaw/repos","events_url":"https://api.github.com/users/PatrickShaw/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickShaw/received_events","type":"User","site_admin":false},"repo":{"id":125690986,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU2OTA5ODY=","name":"openapi-platform","full_name":"PatrickShaw/openapi-platform","private":false,"owner":{"login":"PatrickShaw","id":5153619,"node_id":"MDQ6VXNlcjUxNTM2MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5153619?v=4","gravatar_id":"","url":"https://api.github.com/users/PatrickShaw","html_url":"https://github.com/PatrickShaw","followers_url":"https://api.github.com/users/PatrickShaw/followers","following_url":"https://api.github.com/users/PatrickShaw/following{/other_user}","gists_url":"https://api.github.com/users/PatrickShaw/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrickShaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrickShaw/subscriptions","organizations_url":"https://api.github.com/users/PatrickShaw/orgs","repos_url":"https://api.github.com/users/PatrickShaw/repos","events_url":"https://api.github.com/users/PatrickShaw/events{/privacy}","received_events_url":"https://api.github.com/users/PatrickShaw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PatrickShaw/openapi-platform","description":null,"fork":true,"url":"https://api.github.com/repos/PatrickShaw/openapi-platform","forks_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/forks","keys_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/teams","hooks_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/hooks","issue_events_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/issues/events{/number}","events_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/events","assignees_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/assignees{/user}","branches_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/branches{/branch}","tags_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/tags","blobs_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/languages","stargazers_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/stargazers","contributors_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/contributors","subscribers_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/subscribers","subscription_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/subscription","commits_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/contents/{+path}","compare_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/merges","archive_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/downloads","issues_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/issues{/number}","pulls_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/labels{/name}","releases_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/releases{/id}","deployments_url":"https://api.github.com/repos/PatrickShaw/openapi-platform/deployments","created_at":"2018-03-18T03:59:28Z","updated_at":"2018-08-12T15:17:52Z","pushed_at":"2018-10-14T17:35:57Z","git_url":"git://github.com/PatrickShaw/openapi-platform.git","ssh_url":"git@github.com:PatrickShaw/openapi-platform.git","clone_url":"https://github.com/PatrickShaw/openapi-platform.git","svn_url":"https://github.com/PatrickShaw/openapi-platform","homepage":null,"size":1327,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"telstra:development","ref":"development","sha":"a89f64b422081058a162267181a455e19bf39fea","user":{"login":"telstra","id":3914896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3914896?v=4","gravatar_id":"","url":"https://api.github.com/users/telstra","html_url":"https://github.com/telstra","followers_url":"https://api.github.com/users/telstra/followers","following_url":"https://api.github.com/users/telstra/following{/other_user}","gists_url":"https://api.github.com/users/telstra/gists{/gist_id}","starred_url":"https://api.github.com/users/telstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telstra/subscriptions","organizations_url":"https://api.github.com/users/telstra/orgs","repos_url":"https://api.github.com/users/telstra/repos","events_url":"https://api.github.com/users/telstra/events{/privacy}","received_events_url":"https://api.github.com/users/telstra/received_events","type":"Organization","site_admin":false},"repo":{"id":125442118,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU0NDIxMTg=","name":"openapi-platform","full_name":"telstra/openapi-platform","private":false,"owner":{"login":"telstra","id":3914896,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ4OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3914896?v=4","gravatar_id":"","url":"https://api.github.com/users/telstra","html_url":"https://github.com/telstra","followers_url":"https://api.github.com/users/telstra/followers","following_url":"https://api.github.com/users/telstra/following{/other_user}","gists_url":"https://api.github.com/users/telstra/gists{/gist_id}","starred_url":"https://api.github.com/users/telstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telstra/subscriptions","organizations_url":"https://api.github.com/users/telstra/orgs","repos_url":"https://api.github.com/users/telstra/repos","events_url":"https://api.github.com/users/telstra/events{/privacy}","received_events_url":"https://api.github.com/users/telstra/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telstra/openapi-platform","description":"Project in development - Open sourced service overlay for SDK management using swagger-codegen","fork":false,"url":"https://api.github.com/repos/telstra/openapi-platform","forks_url":"https://api.github.com/repos/telstra/openapi-platform/forks","keys_url":"https://api.github.com/repos/telstra/openapi-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telstra/openapi-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telstra/openapi-platform/teams","hooks_url":"https://api.github.com/repos/telstra/openapi-platform/hooks","issue_events_url":"https://api.github.com/repos/telstra/openapi-platform/issues/events{/number}","events_url":"https://api.github.com/repos/telstra/openapi-platform/events","assignees_url":"https://api.github.com/repos/telstra/openapi-platform/assignees{/user}","branches_url":"https://api.github.com/repos/telstra/openapi-platform/branches{/branch}","tags_url":"https://api.github.com/repos/telstra/openapi-platform/tags","blobs_url":"https://api.github.com/repos/telstra/openapi-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telstra/openapi-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telstra/openapi-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/telstra/openapi-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telstra/openapi-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/telstra/openapi-platform/languages","stargazers_url":"https://api.github.com/repos/telstra/openapi-platform/stargazers","contributors_url":"https://api.github.com/repos/telstra/openapi-platform/contributors","subscribers_url":"https://api.github.com/repos/telstra/openapi-platform/subscribers","subscription_url":"https://api.github.com/repos/telstra/openapi-platform/subscription","commits_url":"https://api.github.com/repos/telstra/openapi-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/telstra/openapi-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/telstra/openapi-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/telstra/openapi-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/telstra/openapi-platform/contents/{+path}","compare_url":"https://api.github.com/repos/telstra/openapi-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telstra/openapi-platform/merges","archive_url":"https://api.github.com/repos/telstra/openapi-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telstra/openapi-platform/downloads","issues_url":"https://api.github.com/repos/telstra/openapi-platform/issues{/number}","pulls_url":"https://api.github.com/repos/telstra/openapi-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/telstra/openapi-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/telstra/openapi-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telstra/openapi-platform/labels{/name}","releases_url":"https://api.github.com/repos/telstra/openapi-platform/releases{/id}","deployments_url":"https://api.github.com/repos/telstra/openapi-platform/deployments","created_at":"2018-03-16T00:27:29Z","updated_at":"2018-10-14T15:53:27Z","pushed_at":"2018-10-14T17:35:58Z","git_url":"git://github.com/telstra/openapi-platform.git","ssh_url":"git@github.com:telstra/openapi-platform.git","clone_url":"https://github.com/telstra/openapi-platform.git","svn_url":"https://github.com/telstra/openapi-platform","homepage":"","size":1340,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":7,"watchers":5,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/telstra/openapi-platform/pulls/89"},"html":{"href":"https://github.com/telstra/openapi-platform/pull/89"},"issue":{"href":"https://api.github.com/repos/telstra/openapi-platform/issues/89"},"comments":{"href":"https://api.github.com/repos/telstra/openapi-platform/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/telstra/openapi-platform/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/telstra/openapi-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telstra/openapi-platform/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/telstra/openapi-platform/statuses/2a58fd123a8b1c3f0a9f41020a9e16f4331f471b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"calebj0seph"}}