{"action":"created","comment":{"url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/comments/217251790","pull_request_review_id":154918854,"id":217251790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzI1MTc5MA==","diff_hunk":"@@ -0,0 +1,65 @@\n+pub struct ParityEthereum {\n+    arguments: ParityArgs,\n+}\n+\n+#[derive(Clone)]\n+pub struct ParityArgs {\n+    pub unsafe_expose: bool,\n+    pub jsonrpc_apis: String,\n+    pub config: String,","path":"images/parity_parity/src/image.rs","position":null,"original_position":9,"commit_id":"c5c5f9f807719a4fc71d6b71bb0ca3f233c5fe49","original_commit_id":"e9fed47b4e38a2d5517b09fc6000171eb535a09d","user":{"login":"D4nte","id":300805,"node_id":"MDQ6VXNlcjMwMDgwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/300805?v=4","gravatar_id":"","url":"https://api.github.com/users/D4nte","html_url":"https://github.com/D4nte","followers_url":"https://api.github.com/users/D4nte/followers","following_url":"https://api.github.com/users/D4nte/following{/other_user}","gists_url":"https://api.github.com/users/D4nte/gists{/gist_id}","starred_url":"https://api.github.com/users/D4nte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D4nte/subscriptions","organizations_url":"https://api.github.com/users/D4nte/orgs","repos_url":"https://api.github.com/users/D4nte/repos","events_url":"https://api.github.com/users/D4nte/events{/privacy}","received_events_url":"https://api.github.com/users/D4nte/received_events","type":"User","site_admin":false},"body":"We don't want to make it an enum because it's too brittle. If they add a new config type a user of this will be able to use that new config value. It's better to just leave it as a stirng. \r\n\r\nOn the other hand we made jsonrpc_apis a Vec<String> since it is a list of strings separated by `,`.","created_at":"2018-09-13T03:37:02Z","updated_at":"2018-09-13T03:37:02Z","html_url":"https://github.com/coblox/testcontainers-rs/pull/7#discussion_r217251790","pull_request_url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/comments/217251790"},"html":{"href":"https://github.com/coblox/testcontainers-rs/pull/7#discussion_r217251790"},"pull_request":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7"}},"in_reply_to_id":217240219},"pull_request":{"url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7","id":215136817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTM2ODE3","html_url":"https://github.com/coblox/testcontainers-rs/pull/7","diff_url":"https://github.com/coblox/testcontainers-rs/pull/7.diff","patch_url":"https://github.com/coblox/testcontainers-rs/pull/7.patch","issue_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues/7","number":7,"state":"open","locked":false,"title":"Add parity/parity image","user":{"login":"LLFourn","id":3734083,"node_id":"MDQ6VXNlcjM3MzQwODM=","avatar_url":"https://avatars1.githubusercontent.com/u/3734083?v=4","gravatar_id":"","url":"https://api.github.com/users/LLFourn","html_url":"https://github.com/LLFourn","followers_url":"https://api.github.com/users/LLFourn/followers","following_url":"https://api.github.com/users/LLFourn/following{/other_user}","gists_url":"https://api.github.com/users/LLFourn/gists{/gist_id}","starred_url":"https://api.github.com/users/LLFourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLFourn/subscriptions","organizations_url":"https://api.github.com/users/LLFourn/orgs","repos_url":"https://api.github.com/users/LLFourn/repos","events_url":"https://api.github.com/users/LLFourn/events{/privacy}","received_events_url":"https://api.github.com/users/LLFourn/received_events","type":"User","site_admin":false},"body":"This PR: \r\n- adds the parity/parity ethereum node container image\r\n- Changes the `.logs` method to return a struct containing both stderr and stdout so the caller can wait on a message in stderr\r\n- Changes Ganache to depend on the rust-web3's github repo directly because of a dependency issue (https://github.com/tomusdrw/rust-web3/pull/154)","created_at":"2018-09-13T01:04:18Z","updated_at":"2018-09-13T03:37:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bd328456c3082278ebacfab57a5045b1586da78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7/commits","review_comments_url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7/comments","review_comment_url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues/7/comments","statuses_url":"https://api.github.com/repos/coblox/testcontainers-rs/statuses/c5c5f9f807719a4fc71d6b71bb0ca3f233c5fe49","head":{"label":"coblox:add_parity","ref":"add_parity","sha":"c5c5f9f807719a4fc71d6b71bb0ca3f233c5fe49","user":{"login":"coblox","id":38543647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQzNjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/38543647?v=4","gravatar_id":"","url":"https://api.github.com/users/coblox","html_url":"https://github.com/coblox","followers_url":"https://api.github.com/users/coblox/followers","following_url":"https://api.github.com/users/coblox/following{/other_user}","gists_url":"https://api.github.com/users/coblox/gists{/gist_id}","starred_url":"https://api.github.com/users/coblox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coblox/subscriptions","organizations_url":"https://api.github.com/users/coblox/orgs","repos_url":"https://api.github.com/users/coblox/repos","events_url":"https://api.github.com/users/coblox/events{/privacy}","received_events_url":"https://api.github.com/users/coblox/received_events","type":"Organization","site_admin":false},"repo":{"id":145490026,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0OTAwMjY=","name":"testcontainers-rs","full_name":"coblox/testcontainers-rs","owner":{"login":"coblox","id":38543647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQzNjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/38543647?v=4","gravatar_id":"","url":"https://api.github.com/users/coblox","html_url":"https://github.com/coblox","followers_url":"https://api.github.com/users/coblox/followers","following_url":"https://api.github.com/users/coblox/following{/other_user}","gists_url":"https://api.github.com/users/coblox/gists{/gist_id}","starred_url":"https://api.github.com/users/coblox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coblox/subscriptions","organizations_url":"https://api.github.com/users/coblox/orgs","repos_url":"https://api.github.com/users/coblox/repos","events_url":"https://api.github.com/users/coblox/events{/privacy}","received_events_url":"https://api.github.com/users/coblox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coblox/testcontainers-rs","description":"A library for integration-testing against docker containers from within Rust.","fork":false,"url":"https://api.github.com/repos/coblox/testcontainers-rs","forks_url":"https://api.github.com/repos/coblox/testcontainers-rs/forks","keys_url":"https://api.github.com/repos/coblox/testcontainers-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coblox/testcontainers-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coblox/testcontainers-rs/teams","hooks_url":"https://api.github.com/repos/coblox/testcontainers-rs/hooks","issue_events_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues/events{/number}","events_url":"https://api.github.com/repos/coblox/testcontainers-rs/events","assignees_url":"https://api.github.com/repos/coblox/testcontainers-rs/assignees{/user}","branches_url":"https://api.github.com/repos/coblox/testcontainers-rs/branches{/branch}","tags_url":"https://api.github.com/repos/coblox/testcontainers-rs/tags","blobs_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coblox/testcontainers-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/coblox/testcontainers-rs/languages","stargazers_url":"https://api.github.com/repos/coblox/testcontainers-rs/stargazers","contributors_url":"https://api.github.com/repos/coblox/testcontainers-rs/contributors","subscribers_url":"https://api.github.com/repos/coblox/testcontainers-rs/subscribers","subscription_url":"https://api.github.com/repos/coblox/testcontainers-rs/subscription","commits_url":"https://api.github.com/repos/coblox/testcontainers-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/coblox/testcontainers-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/coblox/testcontainers-rs/contents/{+path}","compare_url":"https://api.github.com/repos/coblox/testcontainers-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coblox/testcontainers-rs/merges","archive_url":"https://api.github.com/repos/coblox/testcontainers-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coblox/testcontainers-rs/downloads","issues_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues{/number}","pulls_url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/coblox/testcontainers-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/coblox/testcontainers-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coblox/testcontainers-rs/labels{/name}","releases_url":"https://api.github.com/repos/coblox/testcontainers-rs/releases{/id}","deployments_url":"https://api.github.com/repos/coblox/testcontainers-rs/deployments","created_at":"2018-08-21T01:35:53Z","updated_at":"2018-09-06T07:19:51Z","pushed_at":"2018-09-13T03:35:13Z","git_url":"git://github.com/coblox/testcontainers-rs.git","ssh_url":"git@github.com:coblox/testcontainers-rs.git","clone_url":"https://github.com/coblox/testcontainers-rs.git","svn_url":"https://github.com/coblox/testcontainers-rs","homepage":null,"size":37,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"coblox:master","ref":"master","sha":"75575fd256423730135d22d070e239384a8586d7","user":{"login":"coblox","id":38543647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQzNjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/38543647?v=4","gravatar_id":"","url":"https://api.github.com/users/coblox","html_url":"https://github.com/coblox","followers_url":"https://api.github.com/users/coblox/followers","following_url":"https://api.github.com/users/coblox/following{/other_user}","gists_url":"https://api.github.com/users/coblox/gists{/gist_id}","starred_url":"https://api.github.com/users/coblox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coblox/subscriptions","organizations_url":"https://api.github.com/users/coblox/orgs","repos_url":"https://api.github.com/users/coblox/repos","events_url":"https://api.github.com/users/coblox/events{/privacy}","received_events_url":"https://api.github.com/users/coblox/received_events","type":"Organization","site_admin":false},"repo":{"id":145490026,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0OTAwMjY=","name":"testcontainers-rs","full_name":"coblox/testcontainers-rs","owner":{"login":"coblox","id":38543647,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTQzNjQ3","avatar_url":"https://avatars2.githubusercontent.com/u/38543647?v=4","gravatar_id":"","url":"https://api.github.com/users/coblox","html_url":"https://github.com/coblox","followers_url":"https://api.github.com/users/coblox/followers","following_url":"https://api.github.com/users/coblox/following{/other_user}","gists_url":"https://api.github.com/users/coblox/gists{/gist_id}","starred_url":"https://api.github.com/users/coblox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coblox/subscriptions","organizations_url":"https://api.github.com/users/coblox/orgs","repos_url":"https://api.github.com/users/coblox/repos","events_url":"https://api.github.com/users/coblox/events{/privacy}","received_events_url":"https://api.github.com/users/coblox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coblox/testcontainers-rs","description":"A library for integration-testing against docker containers from within Rust.","fork":false,"url":"https://api.github.com/repos/coblox/testcontainers-rs","forks_url":"https://api.github.com/repos/coblox/testcontainers-rs/forks","keys_url":"https://api.github.com/repos/coblox/testcontainers-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coblox/testcontainers-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coblox/testcontainers-rs/teams","hooks_url":"https://api.github.com/repos/coblox/testcontainers-rs/hooks","issue_events_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues/events{/number}","events_url":"https://api.github.com/repos/coblox/testcontainers-rs/events","assignees_url":"https://api.github.com/repos/coblox/testcontainers-rs/assignees{/user}","branches_url":"https://api.github.com/repos/coblox/testcontainers-rs/branches{/branch}","tags_url":"https://api.github.com/repos/coblox/testcontainers-rs/tags","blobs_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coblox/testcontainers-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/coblox/testcontainers-rs/languages","stargazers_url":"https://api.github.com/repos/coblox/testcontainers-rs/stargazers","contributors_url":"https://api.github.com/repos/coblox/testcontainers-rs/contributors","subscribers_url":"https://api.github.com/repos/coblox/testcontainers-rs/subscribers","subscription_url":"https://api.github.com/repos/coblox/testcontainers-rs/subscription","commits_url":"https://api.github.com/repos/coblox/testcontainers-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/coblox/testcontainers-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/coblox/testcontainers-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/coblox/testcontainers-rs/contents/{+path}","compare_url":"https://api.github.com/repos/coblox/testcontainers-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coblox/testcontainers-rs/merges","archive_url":"https://api.github.com/repos/coblox/testcontainers-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coblox/testcontainers-rs/downloads","issues_url":"https://api.github.com/repos/coblox/testcontainers-rs/issues{/number}","pulls_url":"https://api.github.com/repos/coblox/testcontainers-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/coblox/testcontainers-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/coblox/testcontainers-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coblox/testcontainers-rs/labels{/name}","releases_url":"https://api.github.com/repos/coblox/testcontainers-rs/releases{/id}","deployments_url":"https://api.github.com/repos/coblox/testcontainers-rs/deployments","created_at":"2018-08-21T01:35:53Z","updated_at":"2018-09-06T07:19:51Z","pushed_at":"2018-09-13T03:35:13Z","git_url":"git://github.com/coblox/testcontainers-rs.git","ssh_url":"git@github.com:coblox/testcontainers-rs.git","clone_url":"https://github.com/coblox/testcontainers-rs.git","svn_url":"https://github.com/coblox/testcontainers-rs","homepage":null,"size":37,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7"},"html":{"href":"https://github.com/coblox/testcontainers-rs/pull/7"},"issue":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/issues/7"},"comments":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/coblox/testcontainers-rs/statuses/c5c5f9f807719a4fc71d6b71bb0ca3f233c5fe49"}},"author_association":"NONE"}}
{"actor":{"display_login":"D4nte"}}