{"action":"created","issue":{"url":"https://api.github.com/repos/jcupitt/libvips/issues/839","repository_url":"https://api.github.com/repos/jcupitt/libvips","labels_url":"https://api.github.com/repos/jcupitt/libvips/issues/839/labels{/name}","comments_url":"https://api.github.com/repos/jcupitt/libvips/issues/839/comments","events_url":"https://api.github.com/repos/jcupitt/libvips/issues/839/events","html_url":"https://github.com/jcupitt/libvips/issues/839","id":284305302,"node_id":"MDU6SXNzdWUyODQzMDUzMDI=","number":839,"title":"Things that still need fixing in magicksave","user":{"login":"jcupitt","id":580843,"node_id":"MDQ6VXNlcjU4MDg0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/580843?v=4","gravatar_id":"","url":"https://api.github.com/users/jcupitt","html_url":"https://github.com/jcupitt","followers_url":"https://api.github.com/users/jcupitt/followers","following_url":"https://api.github.com/users/jcupitt/following{/other_user}","gists_url":"https://api.github.com/users/jcupitt/gists{/gist_id}","starred_url":"https://api.github.com/users/jcupitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcupitt/subscriptions","organizations_url":"https://api.github.com/users/jcupitt/orgs","repos_url":"https://api.github.com/users/jcupitt/repos","events_url":"https://api.github.com/users/jcupitt/events{/privacy}","received_events_url":"https://api.github.com/users/jcupitt/received_events","type":"User","site_admin":false},"labels":[{"id":15569135,"node_id":"MDU6TGFiZWwxNTU2OTEzNQ==","url":"https://api.github.com/repos/jcupitt/libvips/labels/enhancement","name":"enhancement","color":"0b02e1","default":true},{"id":110039376,"node_id":"MDU6TGFiZWwxMTAwMzkzNzY=","url":"https://api.github.com/repos/jcupitt/libvips/labels/in%20development","name":"in development","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2017-12-23T12:56:34Z","updated_at":"2018-08-01T14:17:44Z","closed_at":null,"author_association":"OWNER","body":"git master 8.7 has a new magicksave operation which can write GIF images, among other things. It works, but has a few remaining issues that need fixing up:\r\n\r\n- [x] Add configure options to control magick load and save.\r\n- [x] Fix up error handling -- perhaps the `magick.c` wrappers should all add to the vips error log.\r\n- [x] At least some monochrome animated GIFs still come out as red, perplexingly.\r\n- [ ] More metadata (properties) need supporting, eg. ICC profiles etc.\r\n- [x] `magicksave` should register as a handler for any supported write formats.\r\n- [x] Add tests to the test suite (in pyvips) and `make check`.\r\n- [x] `magickload` could use the `magick.c` wrappers too.\r\n- [x] Test with graphicsmagick.\r\n- [x] Needs a C API wrapper, and the C++ interface needs regenerating.\r\n- [x] Docs.\r\n- [x] Test with at least short and float images. \r\n- [x] Test alpha handling.\r\n- [ ] `vipsthumbnail` will need to check for `page_height` rather than image height for many-page images.\r\n- [ ] Fix DICOM save\r\n- [ ] We need something like Q or rate for JP2 save\r\n\r\nPlease add any more tasks you think of. \r\n  "},"comment":{"url":"https://api.github.com/repos/jcupitt/libvips/issues/comments/409590951","html_url":"https://github.com/jcupitt/libvips/issues/839#issuecomment-409590951","issue_url":"https://api.github.com/repos/jcupitt/libvips/issues/839","id":409590951,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTU5MDk1MQ==","user":{"login":"gertcuykens","id":863731,"node_id":"MDQ6VXNlcjg2MzczMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/863731?v=4","gravatar_id":"","url":"https://api.github.com/users/gertcuykens","html_url":"https://github.com/gertcuykens","followers_url":"https://api.github.com/users/gertcuykens/followers","following_url":"https://api.github.com/users/gertcuykens/following{/other_user}","gists_url":"https://api.github.com/users/gertcuykens/gists{/gist_id}","starred_url":"https://api.github.com/users/gertcuykens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gertcuykens/subscriptions","organizations_url":"https://api.github.com/users/gertcuykens/orgs","repos_url":"https://api.github.com/users/gertcuykens/repos","events_url":"https://api.github.com/users/gertcuykens/events{/privacy}","received_events_url":"https://api.github.com/users/gertcuykens/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T14:17:44Z","updated_at":"2018-08-01T14:17:44Z","author_association":"NONE","body":"Hi, I am trying to test magicksave but doesn't seem to be available in 8.7.0-rc1?\r\nMaybe something wrong with my docker build?\r\n\r\n```\r\nbash-4.4# vips --version\r\nvips-8.7.0-Wed Jul 25 12:06:44 UTC 2018\r\nbash-4.4# vips magicksave original.jpg test.gif\r\nvips: unknown action \"magicksave\"\r\nbash-4.4#\r\n```\r\n```\r\nFROM golang:alpine as base\r\nENV LIBVIPS_VERSION=8.7.0\r\n\r\n# Here are only the packages for the release image!\r\nRUN apk add --no-cache \\\r\n    zlib \\\r\n    libxml2 \\\r\n    libxslt \\\r\n    glib \\\r\n    libexif \\\r\n    lcms2 \\\r\n    fftw \\\r\n    ca-certificates \\\r\n    giflib \\\r\n    libpng \\\r\n    libwebp \\\r\n    orc \\\r\n    tiff \\\r\n    poppler-glib \\\r\n    librsvg \\\r\n    libmagic \\\r\n    exiftool\r\n\r\n# These packages will be stripped from the release image!\r\nRUN apk add --no-cache --virtual .build-dependencies \\\r\n    autoconf \\\r\n    automake \\\r\n    build-base \\\r\n    libtool \\\r\n    nasm \\\r\n    zlib-dev \\\r\n    libxml2-dev \\\r\n    libxslt-dev \\\r\n    glib-dev \\\r\n    libexif-dev \\\r\n    lcms2-dev \\\r\n    fftw-dev \\\r\n    giflib-dev \\\r\n    libpng-dev \\\r\n    libwebp-dev \\\r\n    orc-dev \\\r\n    tiff-dev \\\r\n    poppler-dev \\\r\n    librsvg-dev \\\r\n    git\r\n\r\n# Install mozjpeg\r\nRUN cd /tmp && \\\r\n    git clone git://github.com/mozilla/mozjpeg.git && \\\r\n    cd /tmp/mozjpeg && \\\r\n    git checkout ${MOZJPEG_VERSION} && \\\r\n    autoreconf -fiv && ./configure --prefix=/usr && make install -j$(nproc)\r\n\r\n# Install libvips\r\nRUN wget -O- https://github.com/jcupitt/libvips/releases/download/v${LIBVIPS_VERSION}-rc1/vips-${LIBVIPS_VERSION}.tar.gz | tar xzC /tmp && \\\r\n    cd /tmp/vips-${LIBVIPS_VERSION} && \\\r\n    ./configure --prefix=/usr \\\r\n                --without-python \\\r\n                --without-gsf \\\r\n                --enable-debug=no \\\r\n                --disable-dependency-tracking \\\r\n                --disable-static \\\r\n                --enable-silent-rules && \\\r\n    make -s install-strip -j$(nproc)\r\n\r\nRUN rm -rf /tmp/vips-${LIBVIPS_VERSION} \\\r\n    && rm -rf /tmp/mozjpeg  \\\r\n    && rm -rf /var/cache/apk/*\r\n```"}}
{"actor":{"display_login":"gertcuykens"}}