{"action":"closed","number":11939,"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11939","id":210944778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTQ0Nzc4","html_url":"https://github.com/matplotlib/matplotlib/pull/11939","diff_url":"https://github.com/matplotlib/matplotlib/pull/11939.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/11939.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/11939","number":11939,"state":"closed","locked":false,"title":"Improve alias signatures","user":{"login":"timhoffm","id":2836374,"node_id":"MDQ6VXNlcjI4MzYzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2836374?v=4","gravatar_id":"","url":"https://api.github.com/users/timhoffm","html_url":"https://github.com/timhoffm","followers_url":"https://api.github.com/users/timhoffm/followers","following_url":"https://api.github.com/users/timhoffm/following{/other_user}","gists_url":"https://api.github.com/users/timhoffm/gists{/gist_id}","starred_url":"https://api.github.com/users/timhoffm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhoffm/subscriptions","organizations_url":"https://api.github.com/users/timhoffm/orgs","repos_url":"https://api.github.com/users/timhoffm/repos","events_url":"https://api.github.com/users/timhoffm/events{/privacy}","received_events_url":"https://api.github.com/users/timhoffm/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nUntil now, all alias methods had the signature `*args, **kwargs`. This is not very helpful as it's unclear which arguments are expected (well, usually none for getters and one for setters, but the alias method does not tell).\r\n\r\nThis PR uses inspect to copy the signatures of the original functions to the alias.\r\n\r\n### Example setter\r\nbefore:\r\n![grafik](https://user-images.githubusercontent.com/2836374/44627292-aca54400-a92b-11e8-9319-d29b973512d5.png)\r\n\r\nnow:\r\n![grafik](https://user-images.githubusercontent.com/2836374/44627288-8b445800-a92b-11e8-99a7-5148378674f2.png)\r\n\r\n### Example getter\r\nbefore:\r\n![grafik](https://user-images.githubusercontent.com/2836374/44627307-d2324d80-a92b-11e8-9022-cf164a36d5b4.png)\r\n\r\nnow:\r\n![grafik](https://user-images.githubusercontent.com/2836374/44627312-e24a2d00-a92b-11e8-8f2f-4e530c44856b.png)\r\n\r\n","created_at":"2018-08-26T10:31:49Z","updated_at":"2018-08-26T18:09:29Z","closed_at":"2018-08-26T18:09:29Z","merged_at":"2018-08-26T18:09:29Z","merge_commit_sha":"d5433f67245fda2b3d23f1d133999bd29f4037de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":75442560,"node_id":"MDU6TGFiZWw3NTQ0MjU2MA==","url":"https://api.github.com/repos/matplotlib/matplotlib/labels/API%20consistency","name":"API consistency","color":"000000","default":false}],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/35","html_url":"https://github.com/matplotlib/matplotlib/milestone/35","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/35/labels","id":3382328,"node_id":"MDk6TWlsZXN0b25lMzM4MjMyOA==","number":35,"title":"v3.1","description":"","creator":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":236,"closed_issues":29,"state":"open","created_at":"2018-05-29T02:12:40Z","updated_at":"2018-08-26T18:09:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11939/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11939/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/11939/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/1093f98defb2e403da464536aa3e5ea0dda4e321","head":{"label":"timhoffm:alias-signature","ref":"alias-signature","sha":"1093f98defb2e403da464536aa3e5ea0dda4e321","user":{"login":"timhoffm","id":2836374,"node_id":"MDQ6VXNlcjI4MzYzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2836374?v=4","gravatar_id":"","url":"https://api.github.com/users/timhoffm","html_url":"https://github.com/timhoffm","followers_url":"https://api.github.com/users/timhoffm/followers","following_url":"https://api.github.com/users/timhoffm/following{/other_user}","gists_url":"https://api.github.com/users/timhoffm/gists{/gist_id}","starred_url":"https://api.github.com/users/timhoffm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhoffm/subscriptions","organizations_url":"https://api.github.com/users/timhoffm/orgs","repos_url":"https://api.github.com/users/timhoffm/repos","events_url":"https://api.github.com/users/timhoffm/events{/privacy}","received_events_url":"https://api.github.com/users/timhoffm/received_events","type":"User","site_admin":false},"repo":{"id":110003219,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMDMyMTk=","name":"matplotlib","full_name":"timhoffm/matplotlib","owner":{"login":"timhoffm","id":2836374,"node_id":"MDQ6VXNlcjI4MzYzNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2836374?v=4","gravatar_id":"","url":"https://api.github.com/users/timhoffm","html_url":"https://github.com/timhoffm","followers_url":"https://api.github.com/users/timhoffm/followers","following_url":"https://api.github.com/users/timhoffm/following{/other_user}","gists_url":"https://api.github.com/users/timhoffm/gists{/gist_id}","starred_url":"https://api.github.com/users/timhoffm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timhoffm/subscriptions","organizations_url":"https://api.github.com/users/timhoffm/orgs","repos_url":"https://api.github.com/users/timhoffm/repos","events_url":"https://api.github.com/users/timhoffm/events{/privacy}","received_events_url":"https://api.github.com/users/timhoffm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timhoffm/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/timhoffm/matplotlib","forks_url":"https://api.github.com/repos/timhoffm/matplotlib/forks","keys_url":"https://api.github.com/repos/timhoffm/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timhoffm/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timhoffm/matplotlib/teams","hooks_url":"https://api.github.com/repos/timhoffm/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/timhoffm/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/timhoffm/matplotlib/events","assignees_url":"https://api.github.com/repos/timhoffm/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/timhoffm/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/timhoffm/matplotlib/tags","blobs_url":"https://api.github.com/repos/timhoffm/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timhoffm/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timhoffm/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/timhoffm/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timhoffm/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/timhoffm/matplotlib/languages","stargazers_url":"https://api.github.com/repos/timhoffm/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/timhoffm/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/timhoffm/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/timhoffm/matplotlib/subscription","commits_url":"https://api.github.com/repos/timhoffm/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/timhoffm/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/timhoffm/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/timhoffm/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/timhoffm/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/timhoffm/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timhoffm/matplotlib/merges","archive_url":"https://api.github.com/repos/timhoffm/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timhoffm/matplotlib/downloads","issues_url":"https://api.github.com/repos/timhoffm/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/timhoffm/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/timhoffm/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/timhoffm/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timhoffm/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/timhoffm/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/timhoffm/matplotlib/deployments","created_at":"2017-11-08T16:44:57Z","updated_at":"2018-08-26T07:24:00Z","pushed_at":"2018-08-26T18:03:24Z","git_url":"git://github.com/timhoffm/matplotlib.git","ssh_url":"git@github.com:timhoffm/matplotlib.git","clone_url":"https://github.com/timhoffm/matplotlib.git","svn_url":"https://github.com/timhoffm/matplotlib","homepage":"http://matplotlib.org/","size":333221,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"76fe3ab64045f1e5cacae0a181c9c0054c8c60be","user":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MTIy","name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-08-26T17:48:35Z","pushed_at":"2018-08-26T18:09:29Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":333163,"stargazers_count":7797,"watchers_count":7797,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3595,"mirror_url":null,"archived":false,"open_issues_count":1380,"license":null,"forks":3595,"open_issues":1380,"watchers":7797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11939"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/11939"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/11939"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/11939/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11939/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11939/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/1093f98defb2e403da464536aa3e5ea0dda4e321"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"NelleV","id":184798,"node_id":"MDQ6VXNlcjE4NDc5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/184798?v=4","gravatar_id":"","url":"https://api.github.com/users/NelleV","html_url":"https://github.com/NelleV","followers_url":"https://api.github.com/users/NelleV/followers","following_url":"https://api.github.com/users/NelleV/following{/other_user}","gists_url":"https://api.github.com/users/NelleV/gists{/gist_id}","starred_url":"https://api.github.com/users/NelleV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NelleV/subscriptions","organizations_url":"https://api.github.com/users/NelleV/orgs","repos_url":"https://api.github.com/users/NelleV/repos","events_url":"https://api.github.com/users/NelleV/events{/privacy}","received_events_url":"https://api.github.com/users/NelleV/received_events","type":"User","site_admin":false},"comments":1,"review_comments":5,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"NelleV"}}