{"action":"created","comment":{"url":"https://api.github.com/repos/carp-lang/Carp/pulls/comments/175300893","pull_request_review_id":104808644,"id":175300893,"diff_hunk":"@@ -4,6 +4,7 @@ module Parsing (parse, validCharacters, balance) where\n \n import Text.Parsec ((<|>))\n import qualified Text.Parsec as Parsec\n+import qualified Data.Char as Char","path":"src/Parsing.hs","position":4,"original_position":4,"commit_id":"a55eeb98a592552c48fe6535db395792e422bf96","original_commit_id":"a55eeb98a592552c48fe6535db395792e422bf96","user":{"login":"hellerve","id":7725188,"avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"body":"No, I added it when trying to patch the parser for non-capitalized names (did not work out, though, for obvious reasons).","created_at":"2018-03-18T19:37:09Z","updated_at":"2018-03-18T19:37:09Z","html_url":"https://github.com/carp-lang/Carp/pull/200#discussion_r175300893","pull_request_url":"https://api.github.com/repos/carp-lang/Carp/pulls/200","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/comments/175300893"},"html":{"href":"https://github.com/carp-lang/Carp/pull/200#discussion_r175300893"},"pull_request":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/200"}},"in_reply_to_id":175300197},"pull_request":{"url":"https://api.github.com/repos/carp-lang/Carp/pulls/200","id":175752494,"html_url":"https://github.com/carp-lang/Carp/pull/200","diff_url":"https://github.com/carp-lang/Carp/pull/200.diff","patch_url":"https://github.com/carp-lang/Carp/pull/200.patch","issue_url":"https://api.github.com/repos/carp-lang/Carp/issues/200","number":200,"state":"closed","locked":false,"title":"Rename string and pattern types","user":{"login":"hellerve","id":7725188,"avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"body":"This PR addresses #195 by renaming `string` to `String` in C land and `pattern` to `Pattern`.\r\n\r\nWe should probably still change the parsing to require a lower-case character at the start, but I’m not totally sure how to best do that.\r\n\r\nCheers","created_at":"2018-03-18T13:58:08Z","updated_at":"2018-03-18T19:37:09Z","closed_at":"2018-03-18T14:23:50Z","merged_at":"2018-03-18T14:23:50Z","merge_commit_sha":"a55eeb98a592552c48fe6535db395792e422bf96","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/carp-lang/Carp/pulls/200/commits","review_comments_url":"https://api.github.com/repos/carp-lang/Carp/pulls/200/comments","review_comment_url":"https://api.github.com/repos/carp-lang/Carp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/carp-lang/Carp/issues/200/comments","statuses_url":"https://api.github.com/repos/carp-lang/Carp/statuses/a55eeb98a592552c48fe6535db395792e422bf96","head":{"label":"hellerve:rename-c-types","ref":"rename-c-types","sha":"a55eeb98a592552c48fe6535db395792e422bf96","user":{"login":"hellerve","id":7725188,"avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"repo":{"id":107543659,"name":"Carp","full_name":"hellerve/Carp","owner":{"login":"hellerve","id":7725188,"avatar_url":"https://avatars3.githubusercontent.com/u/7725188?v=4","gravatar_id":"","url":"https://api.github.com/users/hellerve","html_url":"https://github.com/hellerve","followers_url":"https://api.github.com/users/hellerve/followers","following_url":"https://api.github.com/users/hellerve/following{/other_user}","gists_url":"https://api.github.com/users/hellerve/gists{/gist_id}","starred_url":"https://api.github.com/users/hellerve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellerve/subscriptions","organizations_url":"https://api.github.com/users/hellerve/orgs","repos_url":"https://api.github.com/users/hellerve/repos","events_url":"https://api.github.com/users/hellerve/events{/privacy}","received_events_url":"https://api.github.com/users/hellerve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hellerve/Carp","description":"A statically typed lisp, without a GC, for high performance applications","fork":true,"url":"https://api.github.com/repos/hellerve/Carp","forks_url":"https://api.github.com/repos/hellerve/Carp/forks","keys_url":"https://api.github.com/repos/hellerve/Carp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hellerve/Carp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hellerve/Carp/teams","hooks_url":"https://api.github.com/repos/hellerve/Carp/hooks","issue_events_url":"https://api.github.com/repos/hellerve/Carp/issues/events{/number}","events_url":"https://api.github.com/repos/hellerve/Carp/events","assignees_url":"https://api.github.com/repos/hellerve/Carp/assignees{/user}","branches_url":"https://api.github.com/repos/hellerve/Carp/branches{/branch}","tags_url":"https://api.github.com/repos/hellerve/Carp/tags","blobs_url":"https://api.github.com/repos/hellerve/Carp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hellerve/Carp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hellerve/Carp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hellerve/Carp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hellerve/Carp/statuses/{sha}","languages_url":"https://api.github.com/repos/hellerve/Carp/languages","stargazers_url":"https://api.github.com/repos/hellerve/Carp/stargazers","contributors_url":"https://api.github.com/repos/hellerve/Carp/contributors","subscribers_url":"https://api.github.com/repos/hellerve/Carp/subscribers","subscription_url":"https://api.github.com/repos/hellerve/Carp/subscription","commits_url":"https://api.github.com/repos/hellerve/Carp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hellerve/Carp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hellerve/Carp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hellerve/Carp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hellerve/Carp/contents/{+path}","compare_url":"https://api.github.com/repos/hellerve/Carp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hellerve/Carp/merges","archive_url":"https://api.github.com/repos/hellerve/Carp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hellerve/Carp/downloads","issues_url":"https://api.github.com/repos/hellerve/Carp/issues{/number}","pulls_url":"https://api.github.com/repos/hellerve/Carp/pulls{/number}","milestones_url":"https://api.github.com/repos/hellerve/Carp/milestones{/number}","notifications_url":"https://api.github.com/repos/hellerve/Carp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hellerve/Carp/labels{/name}","releases_url":"https://api.github.com/repos/hellerve/Carp/releases{/id}","deployments_url":"https://api.github.com/repos/hellerve/Carp/deployments","created_at":"2017-10-19T12:32:47Z","updated_at":"2018-03-13T16:42:33Z","pushed_at":"2018-03-18T19:11:28Z","git_url":"git://github.com/hellerve/Carp.git","ssh_url":"git@github.com:hellerve/Carp.git","clone_url":"https://github.com/hellerve/Carp.git","svn_url":"https://github.com/hellerve/Carp","homepage":"","size":5396,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"carp-lang:master","ref":"master","sha":"00105618a44312ceeb064cef0caf37020303dfed","user":{"login":"carp-lang","id":20434801,"avatar_url":"https://avatars1.githubusercontent.com/u/20434801?v=4","gravatar_id":"","url":"https://api.github.com/users/carp-lang","html_url":"https://github.com/carp-lang","followers_url":"https://api.github.com/users/carp-lang/followers","following_url":"https://api.github.com/users/carp-lang/following{/other_user}","gists_url":"https://api.github.com/users/carp-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/carp-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carp-lang/subscriptions","organizations_url":"https://api.github.com/users/carp-lang/orgs","repos_url":"https://api.github.com/users/carp-lang/repos","events_url":"https://api.github.com/users/carp-lang/events{/privacy}","received_events_url":"https://api.github.com/users/carp-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":49426320,"name":"Carp","full_name":"carp-lang/Carp","owner":{"login":"carp-lang","id":20434801,"avatar_url":"https://avatars1.githubusercontent.com/u/20434801?v=4","gravatar_id":"","url":"https://api.github.com/users/carp-lang","html_url":"https://github.com/carp-lang","followers_url":"https://api.github.com/users/carp-lang/followers","following_url":"https://api.github.com/users/carp-lang/following{/other_user}","gists_url":"https://api.github.com/users/carp-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/carp-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carp-lang/subscriptions","organizations_url":"https://api.github.com/users/carp-lang/orgs","repos_url":"https://api.github.com/users/carp-lang/repos","events_url":"https://api.github.com/users/carp-lang/events{/privacy}","received_events_url":"https://api.github.com/users/carp-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/carp-lang/Carp","description":"A statically typed lisp, without a GC, for high performance applications.","fork":false,"url":"https://api.github.com/repos/carp-lang/Carp","forks_url":"https://api.github.com/repos/carp-lang/Carp/forks","keys_url":"https://api.github.com/repos/carp-lang/Carp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carp-lang/Carp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carp-lang/Carp/teams","hooks_url":"https://api.github.com/repos/carp-lang/Carp/hooks","issue_events_url":"https://api.github.com/repos/carp-lang/Carp/issues/events{/number}","events_url":"https://api.github.com/repos/carp-lang/Carp/events","assignees_url":"https://api.github.com/repos/carp-lang/Carp/assignees{/user}","branches_url":"https://api.github.com/repos/carp-lang/Carp/branches{/branch}","tags_url":"https://api.github.com/repos/carp-lang/Carp/tags","blobs_url":"https://api.github.com/repos/carp-lang/Carp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carp-lang/Carp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carp-lang/Carp/git/refs{/sha}","trees_url":"https://api.github.com/repos/carp-lang/Carp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carp-lang/Carp/statuses/{sha}","languages_url":"https://api.github.com/repos/carp-lang/Carp/languages","stargazers_url":"https://api.github.com/repos/carp-lang/Carp/stargazers","contributors_url":"https://api.github.com/repos/carp-lang/Carp/contributors","subscribers_url":"https://api.github.com/repos/carp-lang/Carp/subscribers","subscription_url":"https://api.github.com/repos/carp-lang/Carp/subscription","commits_url":"https://api.github.com/repos/carp-lang/Carp/commits{/sha}","git_commits_url":"https://api.github.com/repos/carp-lang/Carp/git/commits{/sha}","comments_url":"https://api.github.com/repos/carp-lang/Carp/comments{/number}","issue_comment_url":"https://api.github.com/repos/carp-lang/Carp/issues/comments{/number}","contents_url":"https://api.github.com/repos/carp-lang/Carp/contents/{+path}","compare_url":"https://api.github.com/repos/carp-lang/Carp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carp-lang/Carp/merges","archive_url":"https://api.github.com/repos/carp-lang/Carp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carp-lang/Carp/downloads","issues_url":"https://api.github.com/repos/carp-lang/Carp/issues{/number}","pulls_url":"https://api.github.com/repos/carp-lang/Carp/pulls{/number}","milestones_url":"https://api.github.com/repos/carp-lang/Carp/milestones{/number}","notifications_url":"https://api.github.com/repos/carp-lang/Carp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carp-lang/Carp/labels{/name}","releases_url":"https://api.github.com/repos/carp-lang/Carp/releases{/id}","deployments_url":"https://api.github.com/repos/carp-lang/Carp/deployments","created_at":"2016-01-11T12:54:09Z","updated_at":"2018-03-18T16:51:34Z","pushed_at":"2018-03-18T16:51:33Z","git_url":"git://github.com/carp-lang/Carp.git","ssh_url":"git@github.com:carp-lang/Carp.git","clone_url":"https://github.com/carp-lang/Carp.git","svn_url":"https://github.com/carp-lang/Carp","homepage":"","size":5397,"stargazers_count":1741,"watchers_count":1741,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":66,"open_issues":10,"watchers":1741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/200"},"html":{"href":"https://github.com/carp-lang/Carp/pull/200"},"issue":{"href":"https://api.github.com/repos/carp-lang/Carp/issues/200"},"comments":{"href":"https://api.github.com/repos/carp-lang/Carp/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/carp-lang/Carp/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/carp-lang/Carp/statuses/a55eeb98a592552c48fe6535db395792e422bf96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hellerve"}}