{"action":"created","comment":{"url":"https://api.github.com/repos/vast-io/vast/pulls/comments/182534633","pull_request_review_id":113349360,"id":182534633,"diff_hunk":"@@ -42,6 +42,9 @@ class command {\n   /// Maps names of config parameters to their value.\n   using option_map = std::map<std::string, caf::config_value>;\n \n+  /// Iterates over CLI arguments.\n+  using const_iterator = std::vector<std::string>::const_iterator;","path":"libvast/vast/command.hpp","position":5,"original_position":5,"commit_id":"e0fcce15aa90f700efdd980b8f883f38ce31bd5b","original_commit_id":"e0fcce15aa90f700efdd980b8f883f38ce31bd5b","user":{"login":"mavam","id":53797,"avatar_url":"https://avatars0.githubusercontent.com/u/53797?v=4","gravatar_id":"","url":"https://api.github.com/users/mavam","html_url":"https://github.com/mavam","followers_url":"https://api.github.com/users/mavam/followers","following_url":"https://api.github.com/users/mavam/following{/other_user}","gists_url":"https://api.github.com/users/mavam/gists{/gist_id}","starred_url":"https://api.github.com/users/mavam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavam/subscriptions","organizations_url":"https://api.github.com/users/mavam/orgs","repos_url":"https://api.github.com/users/mavam/repos","events_url":"https://api.github.com/users/mavam/events{/privacy}","received_events_url":"https://api.github.com/users/mavam/received_events","type":"User","site_admin":false},"body":"Perhaps `argument_iterator` is a more meaningful name for the iterator type. Then you can also use more idiomatic variable names (`begin` instead of `args_begin`) because the types have more semantics.\r\n\r\nWhen someone reads `command::const_iterator`, they have to read the documentation to figure out what's being iterated over, whereas `command::argument_iterator` is more self-explanatory.","created_at":"2018-04-18T18:56:53Z","updated_at":"2018-04-18T18:57:08Z","html_url":"https://github.com/vast-io/vast/pull/177#discussion_r182534633","pull_request_url":"https://api.github.com/repos/vast-io/vast/pulls/177","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vast-io/vast/pulls/comments/182534633"},"html":{"href":"https://github.com/vast-io/vast/pull/177#discussion_r182534633"},"pull_request":{"href":"https://api.github.com/repos/vast-io/vast/pulls/177"}}},"pull_request":{"url":"https://api.github.com/repos/vast-io/vast/pulls/177","id":182187043,"html_url":"https://github.com/vast-io/vast/pull/177","diff_url":"https://github.com/vast-io/vast/pull/177.diff","patch_url":"https://github.com/vast-io/vast/pull/177.patch","issue_url":"https://api.github.com/repos/vast-io/vast/issues/177","number":177,"state":"open","locked":false,"title":"Replace caf::message in command by a range over args of strings","user":{"login":"woelke","id":7466955,"avatar_url":"https://avatars3.githubusercontent.com/u/7466955?v=4","gravatar_id":"","url":"https://api.github.com/users/woelke","html_url":"https://github.com/woelke","followers_url":"https://api.github.com/users/woelke/followers","following_url":"https://api.github.com/users/woelke/following{/other_user}","gists_url":"https://api.github.com/users/woelke/gists{/gist_id}","starred_url":"https://api.github.com/users/woelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woelke/subscriptions","organizations_url":"https://api.github.com/users/woelke/orgs","repos_url":"https://api.github.com/users/woelke/repos","events_url":"https://api.github.com/users/woelke/events{/privacy}","received_events_url":"https://api.github.com/users/woelke/received_events","type":"User","site_admin":false},"body":"This is the first of a series of commits to redesign command.\r\n\r\nIn this step, we replace the caf::message in the command API by light weight iterators.","created_at":"2018-04-17T14:33:39Z","updated_at":"2018-04-18T18:57:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d4f35752ec8fc2bcb25fea29185d82874e226f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":97610992,"url":"https://api.github.com/repos/vast-io/vast/labels/refactoring","name":"refactoring","color":"02d7e1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vast-io/vast/pulls/177/commits","review_comments_url":"https://api.github.com/repos/vast-io/vast/pulls/177/comments","review_comment_url":"https://api.github.com/repos/vast-io/vast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vast-io/vast/issues/177/comments","statuses_url":"https://api.github.com/repos/vast-io/vast/statuses/e0fcce15aa90f700efdd980b8f883f38ce31bd5b","head":{"label":"vast-io:story/ch2390","ref":"story/ch2390","sha":"e0fcce15aa90f700efdd980b8f883f38ce31bd5b","user":{"login":"vast-io","id":18351410,"avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"repo":{"id":932314,"name":"vast","full_name":"vast-io/vast","owner":{"login":"vast-io","id":18351410,"avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vast-io/vast","description":":crystal_ball: Visibility Across Space and Time","fork":false,"url":"https://api.github.com/repos/vast-io/vast","forks_url":"https://api.github.com/repos/vast-io/vast/forks","keys_url":"https://api.github.com/repos/vast-io/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vast-io/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vast-io/vast/teams","hooks_url":"https://api.github.com/repos/vast-io/vast/hooks","issue_events_url":"https://api.github.com/repos/vast-io/vast/issues/events{/number}","events_url":"https://api.github.com/repos/vast-io/vast/events","assignees_url":"https://api.github.com/repos/vast-io/vast/assignees{/user}","branches_url":"https://api.github.com/repos/vast-io/vast/branches{/branch}","tags_url":"https://api.github.com/repos/vast-io/vast/tags","blobs_url":"https://api.github.com/repos/vast-io/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vast-io/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vast-io/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/vast-io/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vast-io/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/vast-io/vast/languages","stargazers_url":"https://api.github.com/repos/vast-io/vast/stargazers","contributors_url":"https://api.github.com/repos/vast-io/vast/contributors","subscribers_url":"https://api.github.com/repos/vast-io/vast/subscribers","subscription_url":"https://api.github.com/repos/vast-io/vast/subscription","commits_url":"https://api.github.com/repos/vast-io/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/vast-io/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/vast-io/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/vast-io/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/vast-io/vast/contents/{+path}","compare_url":"https://api.github.com/repos/vast-io/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vast-io/vast/merges","archive_url":"https://api.github.com/repos/vast-io/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vast-io/vast/downloads","issues_url":"https://api.github.com/repos/vast-io/vast/issues{/number}","pulls_url":"https://api.github.com/repos/vast-io/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/vast-io/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/vast-io/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vast-io/vast/labels{/name}","releases_url":"https://api.github.com/repos/vast-io/vast/releases{/id}","deployments_url":"https://api.github.com/repos/vast-io/vast/deployments","created_at":"2010-09-23T01:19:19Z","updated_at":"2018-04-18T14:31:39Z","pushed_at":"2018-04-18T14:33:32Z","git_url":"git://github.com/vast-io/vast.git","ssh_url":"git@github.com:vast-io/vast.git","clone_url":"https://github.com/vast-io/vast.git","svn_url":"https://github.com/vast-io/vast","homepage":"http://vast.io","size":10654,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":28,"open_issues":3,"watchers":84,"default_branch":"master"}},"base":{"label":"vast-io:master","ref":"master","sha":"f58da1f62e77d70d579d688193e79c33434cc1e5","user":{"login":"vast-io","id":18351410,"avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"repo":{"id":932314,"name":"vast","full_name":"vast-io/vast","owner":{"login":"vast-io","id":18351410,"avatar_url":"https://avatars2.githubusercontent.com/u/18351410?v=4","gravatar_id":"","url":"https://api.github.com/users/vast-io","html_url":"https://github.com/vast-io","followers_url":"https://api.github.com/users/vast-io/followers","following_url":"https://api.github.com/users/vast-io/following{/other_user}","gists_url":"https://api.github.com/users/vast-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vast-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vast-io/subscriptions","organizations_url":"https://api.github.com/users/vast-io/orgs","repos_url":"https://api.github.com/users/vast-io/repos","events_url":"https://api.github.com/users/vast-io/events{/privacy}","received_events_url":"https://api.github.com/users/vast-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vast-io/vast","description":":crystal_ball: Visibility Across Space and Time","fork":false,"url":"https://api.github.com/repos/vast-io/vast","forks_url":"https://api.github.com/repos/vast-io/vast/forks","keys_url":"https://api.github.com/repos/vast-io/vast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vast-io/vast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vast-io/vast/teams","hooks_url":"https://api.github.com/repos/vast-io/vast/hooks","issue_events_url":"https://api.github.com/repos/vast-io/vast/issues/events{/number}","events_url":"https://api.github.com/repos/vast-io/vast/events","assignees_url":"https://api.github.com/repos/vast-io/vast/assignees{/user}","branches_url":"https://api.github.com/repos/vast-io/vast/branches{/branch}","tags_url":"https://api.github.com/repos/vast-io/vast/tags","blobs_url":"https://api.github.com/repos/vast-io/vast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vast-io/vast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vast-io/vast/git/refs{/sha}","trees_url":"https://api.github.com/repos/vast-io/vast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vast-io/vast/statuses/{sha}","languages_url":"https://api.github.com/repos/vast-io/vast/languages","stargazers_url":"https://api.github.com/repos/vast-io/vast/stargazers","contributors_url":"https://api.github.com/repos/vast-io/vast/contributors","subscribers_url":"https://api.github.com/repos/vast-io/vast/subscribers","subscription_url":"https://api.github.com/repos/vast-io/vast/subscription","commits_url":"https://api.github.com/repos/vast-io/vast/commits{/sha}","git_commits_url":"https://api.github.com/repos/vast-io/vast/git/commits{/sha}","comments_url":"https://api.github.com/repos/vast-io/vast/comments{/number}","issue_comment_url":"https://api.github.com/repos/vast-io/vast/issues/comments{/number}","contents_url":"https://api.github.com/repos/vast-io/vast/contents/{+path}","compare_url":"https://api.github.com/repos/vast-io/vast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vast-io/vast/merges","archive_url":"https://api.github.com/repos/vast-io/vast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vast-io/vast/downloads","issues_url":"https://api.github.com/repos/vast-io/vast/issues{/number}","pulls_url":"https://api.github.com/repos/vast-io/vast/pulls{/number}","milestones_url":"https://api.github.com/repos/vast-io/vast/milestones{/number}","notifications_url":"https://api.github.com/repos/vast-io/vast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vast-io/vast/labels{/name}","releases_url":"https://api.github.com/repos/vast-io/vast/releases{/id}","deployments_url":"https://api.github.com/repos/vast-io/vast/deployments","created_at":"2010-09-23T01:19:19Z","updated_at":"2018-04-18T14:31:39Z","pushed_at":"2018-04-18T14:33:32Z","git_url":"git://github.com/vast-io/vast.git","ssh_url":"git@github.com:vast-io/vast.git","clone_url":"https://github.com/vast-io/vast.git","svn_url":"https://github.com/vast-io/vast","homepage":"http://vast.io","size":10654,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":28,"open_issues":3,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vast-io/vast/pulls/177"},"html":{"href":"https://github.com/vast-io/vast/pull/177"},"issue":{"href":"https://api.github.com/repos/vast-io/vast/issues/177"},"comments":{"href":"https://api.github.com/repos/vast-io/vast/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/vast-io/vast/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/vast-io/vast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vast-io/vast/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/vast-io/vast/statuses/e0fcce15aa90f700efdd980b8f883f38ce31bd5b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mavam"}}