{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/druntime/pulls/comments/192007865","pull_request_review_id":124692937,"id":192007865,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjAwNzg2NQ==","diff_hunk":"@@ -50,6 +50,13 @@ else\n     static assert(false, \"Platform not supported\");\n }\n \n+/// Aliases the operating system-specific semaphore type.\n+version(Windows)        alias SemaphoreHandle =  HANDLE;\n+/// ditto\n+else version(Darwin)    alias SemaphoreHandle = semaphore_t;\n+/// ditto\n+else version(Posix)     alias SemaphoreHandle = sem_t;","path":"src/core/sync/semaphore.d","position":9,"original_position":9,"commit_id":"b1b28b5c104342f9008586e1ac05112703960ec4","original_commit_id":"b1b28b5c104342f9008586e1ac05112703960ec4","user":{"login":"Geod24","id":2180215,"node_id":"MDQ6VXNlcjIxODAyMTU=","avatar_url":"https://avatars0.githubusercontent.com/u/2180215?v=4","gravatar_id":"","url":"https://api.github.com/users/Geod24","html_url":"https://github.com/Geod24","followers_url":"https://api.github.com/users/Geod24/followers","following_url":"https://api.github.com/users/Geod24/following{/other_user}","gists_url":"https://api.github.com/users/Geod24/gists{/gist_id}","starred_url":"https://api.github.com/users/Geod24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Geod24/subscriptions","organizations_url":"https://api.github.com/users/Geod24/orgs","repos_url":"https://api.github.com/users/Geod24/repos","events_url":"https://api.github.com/users/Geod24/events{/privacy}","received_events_url":"https://api.github.com/users/Geod24/received_events","type":"User","site_admin":false},"body":"I'll move this `alias` within the scope of the class, instead of prefixing it with the class name.","created_at":"2018-05-31T07:17:08Z","updated_at":"2018-05-31T07:17:09Z","html_url":"https://github.com/dlang/druntime/pull/2196#discussion_r192007865","pull_request_url":"https://api.github.com/repos/dlang/druntime/pulls/2196","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/druntime/pulls/comments/192007865"},"html":{"href":"https://github.com/dlang/druntime/pull/2196#discussion_r192007865"},"pull_request":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2196"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/druntime/pulls/2196","id":191575420,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTc1NDIw","html_url":"https://github.com/dlang/druntime/pull/2196","diff_url":"https://github.com/dlang/druntime/pull/2196.diff","patch_url":"https://github.com/dlang/druntime/pull/2196.patch","issue_url":"https://api.github.com/repos/dlang/druntime/issues/2196","number":2196,"state":"open","locked":false,"title":"Set the semaphore handle `protected` instead of `private`","user":{"login":"BBasile","id":16154339,"node_id":"MDQ6VXNlcjE2MTU0MzM5","avatar_url":"https://avatars1.githubusercontent.com/u/16154339?v=4","gravatar_id":"","url":"https://api.github.com/users/BBasile","html_url":"https://github.com/BBasile","followers_url":"https://api.github.com/users/BBasile/followers","following_url":"https://api.github.com/users/BBasile/following{/other_user}","gists_url":"https://api.github.com/users/BBasile/gists{/gist_id}","starred_url":"https://api.github.com/users/BBasile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBasile/subscriptions","organizations_url":"https://api.github.com/users/BBasile/orgs","repos_url":"https://api.github.com/users/BBasile/repos","events_url":"https://api.github.com/users/BBasile/events{/privacy}","received_events_url":"https://api.github.com/users/BBasile/received_events","type":"User","site_admin":false},"body":"For example now, if i want to create a `NamedSemaphore` class, i have to copy and paste most of the code while i would only need to write a custom `this()` after the change proposed in this PR.","created_at":"2018-05-30T20:45:02Z","updated_at":"2018-05-31T07:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea33fae8328bf5077199643810107b4401d385ca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"MartinNowak","id":288976,"node_id":"MDQ6VXNlcjI4ODk3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/288976?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinNowak","html_url":"https://github.com/MartinNowak","followers_url":"https://api.github.com/users/MartinNowak/followers","following_url":"https://api.github.com/users/MartinNowak/following{/other_user}","gists_url":"https://api.github.com/users/MartinNowak/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinNowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinNowak/subscriptions","organizations_url":"https://api.github.com/users/MartinNowak/orgs","repos_url":"https://api.github.com/users/MartinNowak/repos","events_url":"https://api.github.com/users/MartinNowak/events{/privacy}","received_events_url":"https://api.github.com/users/MartinNowak/received_events","type":"User","site_admin":false},{"login":"WalterBright","id":568298,"node_id":"MDQ6VXNlcjU2ODI5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},{"login":"ZombineDev","id":3475150,"node_id":"MDQ6VXNlcjM0NzUxNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/3475150?v=4","gravatar_id":"","url":"https://api.github.com/users/ZombineDev","html_url":"https://github.com/ZombineDev","followers_url":"https://api.github.com/users/ZombineDev/followers","following_url":"https://api.github.com/users/ZombineDev/following{/other_user}","gists_url":"https://api.github.com/users/ZombineDev/gists{/gist_id}","starred_url":"https://api.github.com/users/ZombineDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZombineDev/subscriptions","organizations_url":"https://api.github.com/users/ZombineDev/orgs","repos_url":"https://api.github.com/users/ZombineDev/repos","events_url":"https://api.github.com/users/ZombineDev/events{/privacy}","received_events_url":"https://api.github.com/users/ZombineDev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":673792738,"node_id":"MDU6TGFiZWw2NzM3OTI3Mzg=","url":"https://api.github.com/repos/dlang/druntime/labels/@andralex","name":"@andralex","color":"bfdadc","default":false},{"id":638910588,"node_id":"MDU6TGFiZWw2Mzg5MTA1ODg=","url":"https://api.github.com/repos/dlang/druntime/labels/Enhancement","name":"Enhancement","color":"0052cc","default":false},{"id":244335791,"node_id":"MDU6TGFiZWwyNDQzMzU3OTE=","url":"https://api.github.com/repos/dlang/druntime/labels/Pending%20Changelog","name":"Pending Changelog","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/druntime/pulls/2196/commits","review_comments_url":"https://api.github.com/repos/dlang/druntime/pulls/2196/comments","review_comment_url":"https://api.github.com/repos/dlang/druntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/druntime/issues/2196/comments","statuses_url":"https://api.github.com/repos/dlang/druntime/statuses/b1b28b5c104342f9008586e1ac05112703960ec4","head":{"label":"BBasile:sem-prot","ref":"sem-prot","sha":"b1b28b5c104342f9008586e1ac05112703960ec4","user":{"login":"BBasile","id":16154339,"node_id":"MDQ6VXNlcjE2MTU0MzM5","avatar_url":"https://avatars1.githubusercontent.com/u/16154339?v=4","gravatar_id":"","url":"https://api.github.com/users/BBasile","html_url":"https://github.com/BBasile","followers_url":"https://api.github.com/users/BBasile/followers","following_url":"https://api.github.com/users/BBasile/following{/other_user}","gists_url":"https://api.github.com/users/BBasile/gists{/gist_id}","starred_url":"https://api.github.com/users/BBasile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBasile/subscriptions","organizations_url":"https://api.github.com/users/BBasile/orgs","repos_url":"https://api.github.com/users/BBasile/repos","events_url":"https://api.github.com/users/BBasile/events{/privacy}","received_events_url":"https://api.github.com/users/BBasile/received_events","type":"User","site_admin":false},"repo":{"id":108135293,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxMzUyOTM=","name":"druntime","full_name":"BBasile/druntime","owner":{"login":"BBasile","id":16154339,"node_id":"MDQ6VXNlcjE2MTU0MzM5","avatar_url":"https://avatars1.githubusercontent.com/u/16154339?v=4","gravatar_id":"","url":"https://api.github.com/users/BBasile","html_url":"https://github.com/BBasile","followers_url":"https://api.github.com/users/BBasile/followers","following_url":"https://api.github.com/users/BBasile/following{/other_user}","gists_url":"https://api.github.com/users/BBasile/gists{/gist_id}","starred_url":"https://api.github.com/users/BBasile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBasile/subscriptions","organizations_url":"https://api.github.com/users/BBasile/orgs","repos_url":"https://api.github.com/users/BBasile/repos","events_url":"https://api.github.com/users/BBasile/events{/privacy}","received_events_url":"https://api.github.com/users/BBasile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BBasile/druntime","description":"Low level runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/BBasile/druntime","forks_url":"https://api.github.com/repos/BBasile/druntime/forks","keys_url":"https://api.github.com/repos/BBasile/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBasile/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBasile/druntime/teams","hooks_url":"https://api.github.com/repos/BBasile/druntime/hooks","issue_events_url":"https://api.github.com/repos/BBasile/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/BBasile/druntime/events","assignees_url":"https://api.github.com/repos/BBasile/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/BBasile/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/BBasile/druntime/tags","blobs_url":"https://api.github.com/repos/BBasile/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBasile/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBasile/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBasile/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBasile/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/BBasile/druntime/languages","stargazers_url":"https://api.github.com/repos/BBasile/druntime/stargazers","contributors_url":"https://api.github.com/repos/BBasile/druntime/contributors","subscribers_url":"https://api.github.com/repos/BBasile/druntime/subscribers","subscription_url":"https://api.github.com/repos/BBasile/druntime/subscription","commits_url":"https://api.github.com/repos/BBasile/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBasile/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBasile/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBasile/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBasile/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/BBasile/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBasile/druntime/merges","archive_url":"https://api.github.com/repos/BBasile/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBasile/druntime/downloads","issues_url":"https://api.github.com/repos/BBasile/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/BBasile/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/BBasile/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/BBasile/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBasile/druntime/labels{/name}","releases_url":"https://api.github.com/repos/BBasile/druntime/releases{/id}","deployments_url":"https://api.github.com/repos/BBasile/druntime/deployments","created_at":"2017-10-24T14:03:54Z","updated_at":"2018-04-23T13:45:40Z","pushed_at":"2018-05-31T07:11:31Z","git_url":"git://github.com/BBasile/druntime.git","ssh_url":"git@github.com:BBasile/druntime.git","clone_url":"https://github.com/BBasile/druntime.git","svn_url":"https://github.com/BBasile/druntime","homepage":"dlang.org","size":14969,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"335cd2e44c230a170394cbebb5269beba0eb4964","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257087,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDg3","name":"druntime","full_name":"dlang/druntime","owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/druntime","description":"Low level runtime library for the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/druntime","forks_url":"https://api.github.com/repos/dlang/druntime/forks","keys_url":"https://api.github.com/repos/dlang/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/druntime/teams","hooks_url":"https://api.github.com/repos/dlang/druntime/hooks","issue_events_url":"https://api.github.com/repos/dlang/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/druntime/events","assignees_url":"https://api.github.com/repos/dlang/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/druntime/tags","blobs_url":"https://api.github.com/repos/dlang/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/druntime/languages","stargazers_url":"https://api.github.com/repos/dlang/druntime/stargazers","contributors_url":"https://api.github.com/repos/dlang/druntime/contributors","subscribers_url":"https://api.github.com/repos/dlang/druntime/subscribers","subscription_url":"https://api.github.com/repos/dlang/druntime/subscription","commits_url":"https://api.github.com/repos/dlang/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/druntime/merges","archive_url":"https://api.github.com/repos/dlang/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/druntime/downloads","issues_url":"https://api.github.com/repos/dlang/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/druntime/labels{/name}","releases_url":"https://api.github.com/repos/dlang/druntime/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/druntime/deployments","created_at":"2011-01-15T07:01:38Z","updated_at":"2018-05-31T05:11:49Z","pushed_at":"2018-05-31T07:11:33Z","git_url":"git://github.com/dlang/druntime.git","ssh_url":"git@github.com:dlang/druntime.git","clone_url":"https://github.com/dlang/druntime.git","svn_url":"https://github.com/dlang/druntime","homepage":"dlang.org","size":15060,"stargazers_count":481,"watchers_count":481,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":332,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":332,"open_issues":72,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2196"},"html":{"href":"https://github.com/dlang/druntime/pull/2196"},"issue":{"href":"https://api.github.com/repos/dlang/druntime/issues/2196"},"comments":{"href":"https://api.github.com/repos/dlang/druntime/issues/2196/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2196/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/druntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2196/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/druntime/statuses/b1b28b5c104342f9008586e1ac05112703960ec4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Geod24"}}