{"action":"closed","number":239,"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-common/pulls/239","id":216447564,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDQ3NTY0","html_url":"https://github.com/googleapis/nodejs-common/pull/239","diff_url":"https://github.com/googleapis/nodejs-common/pull/239.diff","patch_url":"https://github.com/googleapis/nodejs-common/pull/239.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-common/issues/239","number":239,"state":"closed","locked":false,"title":"Enhance typing of ServiceObject.prototype.get","user":{"login":"carnesen","id":5756743,"node_id":"MDQ6VXNlcjU3NTY3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5756743?v=4","gravatar_id":"","url":"https://api.github.com/users/carnesen","html_url":"https://github.com/carnesen","followers_url":"https://api.github.com/users/carnesen/followers","following_url":"https://api.github.com/users/carnesen/following{/other_user}","gists_url":"https://api.github.com/users/carnesen/gists{/gist_id}","starred_url":"https://api.github.com/users/carnesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carnesen/subscriptions","organizations_url":"https://api.github.com/users/carnesen/orgs","repos_url":"https://api.github.com/users/carnesen/repos","events_url":"https://api.github.com/users/carnesen/events{/privacy}","received_events_url":"https://api.github.com/users/carnesen/received_events","type":"User","site_admin":false},"body":"Previously the type declarations for ServiceObject.prototype.get did not include signatures for the \"promisified\" version of the method. This PR adds suitable Promise-returning signatures. This also simplifies (`any`s) some of the `serviceObject.get` types in the unit tests, which are primarily designed to test run-time behavior rather than type design. \r\n\r\n- [x] Tests and linter pass\r\n- [x] Code coverage does not decrease (if any source code was changed)\r\n- [x] Appropriate docs were updated (if necessary)\r\n","created_at":"2018-09-18T21:19:08Z","updated_at":"2018-09-19T21:49:21Z","closed_at":"2018-09-19T21:49:21Z","merged_at":"2018-09-19T21:49:21Z","merge_commit_sha":"6312fbbf27437b2574a685df425d57791f807247","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872488627,"node_id":"MDU6TGFiZWw4NzI0ODg2Mjc=","url":"https://api.github.com/repos/googleapis/nodejs-common/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-common/pulls/239/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-common/pulls/239/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-common/issues/239/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-common/statuses/1051d9692992963af3da481a54058c9d23ec81c9","head":{"label":"carnesen:improve-get-types","ref":"improve-get-types","sha":"1051d9692992963af3da481a54058c9d23ec81c9","user":{"login":"carnesen","id":5756743,"node_id":"MDQ6VXNlcjU3NTY3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5756743?v=4","gravatar_id":"","url":"https://api.github.com/users/carnesen","html_url":"https://github.com/carnesen","followers_url":"https://api.github.com/users/carnesen/followers","following_url":"https://api.github.com/users/carnesen/following{/other_user}","gists_url":"https://api.github.com/users/carnesen/gists{/gist_id}","starred_url":"https://api.github.com/users/carnesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carnesen/subscriptions","organizations_url":"https://api.github.com/users/carnesen/orgs","repos_url":"https://api.github.com/users/carnesen/repos","events_url":"https://api.github.com/users/carnesen/events{/privacy}","received_events_url":"https://api.github.com/users/carnesen/received_events","type":"User","site_admin":false},"repo":{"id":149331546,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkzMzE1NDY=","name":"nodejs-common","full_name":"carnesen/nodejs-common","private":false,"owner":{"login":"carnesen","id":5756743,"node_id":"MDQ6VXNlcjU3NTY3NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5756743?v=4","gravatar_id":"","url":"https://api.github.com/users/carnesen","html_url":"https://github.com/carnesen","followers_url":"https://api.github.com/users/carnesen/followers","following_url":"https://api.github.com/users/carnesen/following{/other_user}","gists_url":"https://api.github.com/users/carnesen/gists{/gist_id}","starred_url":"https://api.github.com/users/carnesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carnesen/subscriptions","organizations_url":"https://api.github.com/users/carnesen/orgs","repos_url":"https://api.github.com/users/carnesen/repos","events_url":"https://api.github.com/users/carnesen/events{/privacy}","received_events_url":"https://api.github.com/users/carnesen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carnesen/nodejs-common","description":"🚀🐢 A set of classes and utilities used in Google npm modules.  ","fork":true,"url":"https://api.github.com/repos/carnesen/nodejs-common","forks_url":"https://api.github.com/repos/carnesen/nodejs-common/forks","keys_url":"https://api.github.com/repos/carnesen/nodejs-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carnesen/nodejs-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carnesen/nodejs-common/teams","hooks_url":"https://api.github.com/repos/carnesen/nodejs-common/hooks","issue_events_url":"https://api.github.com/repos/carnesen/nodejs-common/issues/events{/number}","events_url":"https://api.github.com/repos/carnesen/nodejs-common/events","assignees_url":"https://api.github.com/repos/carnesen/nodejs-common/assignees{/user}","branches_url":"https://api.github.com/repos/carnesen/nodejs-common/branches{/branch}","tags_url":"https://api.github.com/repos/carnesen/nodejs-common/tags","blobs_url":"https://api.github.com/repos/carnesen/nodejs-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carnesen/nodejs-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carnesen/nodejs-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/carnesen/nodejs-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carnesen/nodejs-common/statuses/{sha}","languages_url":"https://api.github.com/repos/carnesen/nodejs-common/languages","stargazers_url":"https://api.github.com/repos/carnesen/nodejs-common/stargazers","contributors_url":"https://api.github.com/repos/carnesen/nodejs-common/contributors","subscribers_url":"https://api.github.com/repos/carnesen/nodejs-common/subscribers","subscription_url":"https://api.github.com/repos/carnesen/nodejs-common/subscription","commits_url":"https://api.github.com/repos/carnesen/nodejs-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/carnesen/nodejs-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/carnesen/nodejs-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/carnesen/nodejs-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/carnesen/nodejs-common/contents/{+path}","compare_url":"https://api.github.com/repos/carnesen/nodejs-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carnesen/nodejs-common/merges","archive_url":"https://api.github.com/repos/carnesen/nodejs-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carnesen/nodejs-common/downloads","issues_url":"https://api.github.com/repos/carnesen/nodejs-common/issues{/number}","pulls_url":"https://api.github.com/repos/carnesen/nodejs-common/pulls{/number}","milestones_url":"https://api.github.com/repos/carnesen/nodejs-common/milestones{/number}","notifications_url":"https://api.github.com/repos/carnesen/nodejs-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carnesen/nodejs-common/labels{/name}","releases_url":"https://api.github.com/repos/carnesen/nodejs-common/releases{/id}","deployments_url":"https://api.github.com/repos/carnesen/nodejs-common/deployments","created_at":"2018-09-18T18:04:41Z","updated_at":"2018-09-18T18:04:43Z","pushed_at":"2018-09-19T21:43:33Z","git_url":"git://github.com/carnesen/nodejs-common.git","ssh_url":"git@github.com:carnesen/nodejs-common.git","clone_url":"https://github.com/carnesen/nodejs-common.git","svn_url":"https://github.com/carnesen/nodejs-common","homepage":"","size":553,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"24b3efeb29dd38689169c823321c3a254624cd16","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463389,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzM4OQ==","name":"nodejs-common","full_name":"googleapis/nodejs-common","private":false,"owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googleapis/nodejs-common","description":"🚀🐢 A set of classes and utilities used in Google npm modules.  ","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-common","forks_url":"https://api.github.com/repos/googleapis/nodejs-common/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-common/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-common/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-common/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-common/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-common/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-common/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-common/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-common/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-common/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-common/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-common/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-common/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-common/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-common/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-common/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-common/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-common/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-common/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-common/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-common/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-common/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-common/deployments","created_at":"2017-07-26T20:30:43Z","updated_at":"2018-09-19T19:59:39Z","pushed_at":"2018-09-19T21:49:21Z","git_url":"git://github.com/googleapis/nodejs-common.git","ssh_url":"git@github.com:googleapis/nodejs-common.git","clone_url":"https://github.com/googleapis/nodejs-common.git","svn_url":"https://github.com/googleapis/nodejs-common","homepage":"","size":542,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":9,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-common/pulls/239"},"html":{"href":"https://github.com/googleapis/nodejs-common/pull/239"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-common/issues/239"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-common/issues/239/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-common/pulls/239/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-common/pulls/239/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-common/statuses/1051d9692992963af3da481a54058c9d23ec81c9"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"JustinBeckwith","id":534619,"node_id":"MDQ6VXNlcjUzNDYxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/534619?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinBeckwith","html_url":"https://github.com/JustinBeckwith","followers_url":"https://api.github.com/users/JustinBeckwith/followers","following_url":"https://api.github.com/users/JustinBeckwith/following{/other_user}","gists_url":"https://api.github.com/users/JustinBeckwith/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinBeckwith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinBeckwith/subscriptions","organizations_url":"https://api.github.com/users/JustinBeckwith/orgs","repos_url":"https://api.github.com/users/JustinBeckwith/repos","events_url":"https://api.github.com/users/JustinBeckwith/events{/privacy}","received_events_url":"https://api.github.com/users/JustinBeckwith/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":5,"additions":25,"deletions":32,"changed_files":2}}
{"actor":{"display_login":"JustinBeckwith"}}