{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27841","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27841/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27841/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27841/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/issues/27841","id":347389046,"node_id":"MDU6SXNzdWUzNDczODkwNDY=","number":27841,"title":"@types/node does not declare padding option for sign.sign in the crypto module","user":{"login":"MrManny","id":683528,"node_id":"MDQ6VXNlcjY4MzUyOA==","avatar_url":"https://avatars2.githubusercontent.com/u/683528?v=4","gravatar_id":"","url":"https://api.github.com/users/MrManny","html_url":"https://github.com/MrManny","followers_url":"https://api.github.com/users/MrManny/followers","following_url":"https://api.github.com/users/MrManny/following{/other_user}","gists_url":"https://api.github.com/users/MrManny/gists{/gist_id}","starred_url":"https://api.github.com/users/MrManny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrManny/subscriptions","organizations_url":"https://api.github.com/users/MrManny/orgs","repos_url":"https://api.github.com/users/MrManny/repos","events_url":"https://api.github.com/users/MrManny/events{/privacy}","received_events_url":"https://api.github.com/users/MrManny/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-03T13:06:23Z","updated_at":"2018-08-06T19:58:14Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi all,\r\n\r\nI've recently been made aware that the type definitions for Node are lacking the `padding` and `saltLength` properties of the `privateKey` options argument of sign.sign(privateKey, [outputFormat]) in the crypto library.\r\n\r\nThe current declarations in DefinitelyTyped look like this (excerpt):\r\n\r\n```typescript\r\nsign(private_key: string | { key: string; passphrase: string }, output_format: HexBase64Latin1Encoding): string;\r\n```\r\n\r\nCompare this to the original Node API docs: https://nodejs.org/docs/v10.8.0/api/crypto.html#crypto_sign_sign_privatekey_outputformat\r\n\r\nWhat is missing:\r\n* `privateKey.padding` of type number (`crypto.constants.RSA_PKCS1_PADDING` or `crypto.constants.RSA_PKCS1_PSS_PADDING`),\r\n* `privateKey.saltLength` of type number.\r\n\r\n\r\n- [x] I tried using the `@types/node` package and had problems.\r\n- [x] I tried using the latest stable version of tsc. https://www.npmjs.com/package/typescript\r\n- [x] [Mention](https://github.com/blog/821-mention-somebody-they-re-notified) the authors (see `Definitions by:` in `index.d.ts`) so they can respond.\r\n  - Authors: @DefinitelyTyped, et al. Don't really know who else to ping, the list of contributors is huge and half of them aren't even here. So I'll just ping whoever git blame comes up with: @plantain-00 \r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/410834105","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/issues/27841#issuecomment-410834105","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/27841","id":410834105,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDgzNDEwNQ==","user":{"login":"Flarna","id":18708370,"node_id":"MDQ6VXNlcjE4NzA4Mzcw","avatar_url":"https://avatars3.githubusercontent.com/u/18708370?v=4","gravatar_id":"","url":"https://api.github.com/users/Flarna","html_url":"https://github.com/Flarna","followers_url":"https://api.github.com/users/Flarna/followers","following_url":"https://api.github.com/users/Flarna/following{/other_user}","gists_url":"https://api.github.com/users/Flarna/gists{/gist_id}","starred_url":"https://api.github.com/users/Flarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Flarna/subscriptions","organizations_url":"https://api.github.com/users/Flarna/orgs","repos_url":"https://api.github.com/users/Flarna/repos","events_url":"https://api.github.com/users/Flarna/events{/privacy}","received_events_url":"https://api.github.com/users/Flarna/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T19:58:14Z","updated_at":"2018-08-06T19:58:14Z","author_association":"CONTRIBUTOR","body":"Should be fixed via #27866."}}
{"actor":{"display_login":"Flarna"}}