{"action":"created","comment":{"url":"https://api.github.com/repos/danmar/cppcheck/pulls/comments/220444027","pull_request_review_id":158852211,"id":220444027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDQ0NDAyNw==","diff_hunk":"@@ -984,9 +984,9 @@ void CheckCondition::checkIncorrectLogicOperator()\n             if (!parseable)\n                 continue;\n \n-            if (isSameExpression(mTokenizer->isCPP(), true, comp1, comp2, mSettings->library, true))\n+            if (isSameExpression(mTokenizer->isCPP(), true, comp1, comp2, mSettings->library, false, true))\n                 continue; // same expressions => only report that there are same expressions\n-            if (!isSameExpression(mTokenizer->isCPP(), true, expr1, expr2, mSettings->library, true))\n+            if (!isSameExpression(mTokenizer->isCPP(), true, expr1, expr2, mSettings->library, false, true))","path":"lib/checkcondition.cpp","position":66,"original_position":66,"commit_id":"259bc258afa845d026a9a7ff943193c03d6cd5b9","original_commit_id":"259bc258afa845d026a9a7ff943193c03d6cd5b9","user":{"login":"danmar","id":60195,"node_id":"MDQ6VXNlcjYwMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/60195?v=4","gravatar_id":"","url":"https://api.github.com/users/danmar","html_url":"https://github.com/danmar","followers_url":"https://api.github.com/users/danmar/followers","following_url":"https://api.github.com/users/danmar/following{/other_user}","gists_url":"https://api.github.com/users/danmar/gists{/gist_id}","starred_url":"https://api.github.com/users/danmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmar/subscriptions","organizations_url":"https://api.github.com/users/danmar/orgs","repos_url":"https://api.github.com/users/danmar/repos","events_url":"https://api.github.com/users/danmar/events{/privacy}","received_events_url":"https://api.github.com/users/danmar/received_events","type":"User","site_admin":false},"body":"I think \"false, true\" should be \"true,false\"","created_at":"2018-09-26T06:55:40Z","updated_at":"2018-09-26T06:55:53Z","html_url":"https://github.com/danmar/cppcheck/pull/1391#discussion_r220444027","pull_request_url":"https://api.github.com/repos/danmar/cppcheck/pulls/1391","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/danmar/cppcheck/pulls/comments/220444027"},"html":{"href":"https://github.com/danmar/cppcheck/pull/1391#discussion_r220444027"},"pull_request":{"href":"https://api.github.com/repos/danmar/cppcheck/pulls/1391"}}},"pull_request":{"url":"https://api.github.com/repos/danmar/cppcheck/pulls/1391","id":217518474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTE4NDc0","html_url":"https://github.com/danmar/cppcheck/pull/1391","diff_url":"https://github.com/danmar/cppcheck/pull/1391.diff","patch_url":"https://github.com/danmar/cppcheck/pull/1391.patch","issue_url":"https://api.github.com/repos/danmar/cppcheck/issues/1391","number":1391,"state":"open","locked":false,"title":"Fix false positives in unknownEvaluationOrder when using followVar","user":{"login":"pfultz2","id":1306044,"node_id":"MDQ6VXNlcjEzMDYwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1306044?v=4","gravatar_id":"","url":"https://api.github.com/users/pfultz2","html_url":"https://github.com/pfultz2","followers_url":"https://api.github.com/users/pfultz2/followers","following_url":"https://api.github.com/users/pfultz2/following{/other_user}","gists_url":"https://api.github.com/users/pfultz2/gists{/gist_id}","starred_url":"https://api.github.com/users/pfultz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfultz2/subscriptions","organizations_url":"https://api.github.com/users/pfultz2/orgs","repos_url":"https://api.github.com/users/pfultz2/repos","events_url":"https://api.github.com/users/pfultz2/events{/privacy}","received_events_url":"https://api.github.com/users/pfultz2/received_events","type":"User","site_admin":false},"body":"This should fix the FP in issues like [8744](https://trac.cppcheck.net/ticket/8744).","created_at":"2018-09-23T16:37:24Z","updated_at":"2018-09-26T06:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2779faaa4fb76302f1f85ec2a1f827a6110e228c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danmar/cppcheck/pulls/1391/commits","review_comments_url":"https://api.github.com/repos/danmar/cppcheck/pulls/1391/comments","review_comment_url":"https://api.github.com/repos/danmar/cppcheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danmar/cppcheck/issues/1391/comments","statuses_url":"https://api.github.com/repos/danmar/cppcheck/statuses/259bc258afa845d026a9a7ff943193c03d6cd5b9","head":{"label":"pfultz2:followVar-unknownEvaluationOrder2","ref":"followVar-unknownEvaluationOrder2","sha":"259bc258afa845d026a9a7ff943193c03d6cd5b9","user":{"login":"pfultz2","id":1306044,"node_id":"MDQ6VXNlcjEzMDYwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1306044?v=4","gravatar_id":"","url":"https://api.github.com/users/pfultz2","html_url":"https://github.com/pfultz2","followers_url":"https://api.github.com/users/pfultz2/followers","following_url":"https://api.github.com/users/pfultz2/following{/other_user}","gists_url":"https://api.github.com/users/pfultz2/gists{/gist_id}","starred_url":"https://api.github.com/users/pfultz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfultz2/subscriptions","organizations_url":"https://api.github.com/users/pfultz2/orgs","repos_url":"https://api.github.com/users/pfultz2/repos","events_url":"https://api.github.com/users/pfultz2/events{/privacy}","received_events_url":"https://api.github.com/users/pfultz2/received_events","type":"User","site_admin":false},"repo":{"id":124576106,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ1NzYxMDY=","name":"cppcheck","full_name":"pfultz2/cppcheck","private":false,"owner":{"login":"pfultz2","id":1306044,"node_id":"MDQ6VXNlcjEzMDYwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1306044?v=4","gravatar_id":"","url":"https://api.github.com/users/pfultz2","html_url":"https://github.com/pfultz2","followers_url":"https://api.github.com/users/pfultz2/followers","following_url":"https://api.github.com/users/pfultz2/following{/other_user}","gists_url":"https://api.github.com/users/pfultz2/gists{/gist_id}","starred_url":"https://api.github.com/users/pfultz2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfultz2/subscriptions","organizations_url":"https://api.github.com/users/pfultz2/orgs","repos_url":"https://api.github.com/users/pfultz2/repos","events_url":"https://api.github.com/users/pfultz2/events{/privacy}","received_events_url":"https://api.github.com/users/pfultz2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pfultz2/cppcheck","description":"static analysis of C/C++ code","fork":true,"url":"https://api.github.com/repos/pfultz2/cppcheck","forks_url":"https://api.github.com/repos/pfultz2/cppcheck/forks","keys_url":"https://api.github.com/repos/pfultz2/cppcheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfultz2/cppcheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfultz2/cppcheck/teams","hooks_url":"https://api.github.com/repos/pfultz2/cppcheck/hooks","issue_events_url":"https://api.github.com/repos/pfultz2/cppcheck/issues/events{/number}","events_url":"https://api.github.com/repos/pfultz2/cppcheck/events","assignees_url":"https://api.github.com/repos/pfultz2/cppcheck/assignees{/user}","branches_url":"https://api.github.com/repos/pfultz2/cppcheck/branches{/branch}","tags_url":"https://api.github.com/repos/pfultz2/cppcheck/tags","blobs_url":"https://api.github.com/repos/pfultz2/cppcheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfultz2/cppcheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfultz2/cppcheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfultz2/cppcheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfultz2/cppcheck/statuses/{sha}","languages_url":"https://api.github.com/repos/pfultz2/cppcheck/languages","stargazers_url":"https://api.github.com/repos/pfultz2/cppcheck/stargazers","contributors_url":"https://api.github.com/repos/pfultz2/cppcheck/contributors","subscribers_url":"https://api.github.com/repos/pfultz2/cppcheck/subscribers","subscription_url":"https://api.github.com/repos/pfultz2/cppcheck/subscription","commits_url":"https://api.github.com/repos/pfultz2/cppcheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfultz2/cppcheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfultz2/cppcheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfultz2/cppcheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfultz2/cppcheck/contents/{+path}","compare_url":"https://api.github.com/repos/pfultz2/cppcheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfultz2/cppcheck/merges","archive_url":"https://api.github.com/repos/pfultz2/cppcheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfultz2/cppcheck/downloads","issues_url":"https://api.github.com/repos/pfultz2/cppcheck/issues{/number}","pulls_url":"https://api.github.com/repos/pfultz2/cppcheck/pulls{/number}","milestones_url":"https://api.github.com/repos/pfultz2/cppcheck/milestones{/number}","notifications_url":"https://api.github.com/repos/pfultz2/cppcheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfultz2/cppcheck/labels{/name}","releases_url":"https://api.github.com/repos/pfultz2/cppcheck/releases{/id}","deployments_url":"https://api.github.com/repos/pfultz2/cppcheck/deployments","created_at":"2018-03-09T18:06:05Z","updated_at":"2018-07-03T23:04:20Z","pushed_at":"2018-09-26T05:41:45Z","git_url":"git://github.com/pfultz2/cppcheck.git","ssh_url":"git@github.com:pfultz2/cppcheck.git","clone_url":"https://github.com/pfultz2/cppcheck.git","svn_url":"https://github.com/pfultz2/cppcheck","homepage":"http://cppcheck.sourceforge.net/","size":69956,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"danmar:master","ref":"master","sha":"33b74a04ab9cca6001249d5f48de9f08a7f15621","user":{"login":"danmar","id":60195,"node_id":"MDQ6VXNlcjYwMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/60195?v=4","gravatar_id":"","url":"https://api.github.com/users/danmar","html_url":"https://github.com/danmar","followers_url":"https://api.github.com/users/danmar/followers","following_url":"https://api.github.com/users/danmar/following{/other_user}","gists_url":"https://api.github.com/users/danmar/gists{/gist_id}","starred_url":"https://api.github.com/users/danmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmar/subscriptions","organizations_url":"https://api.github.com/users/danmar/orgs","repos_url":"https://api.github.com/users/danmar/repos","events_url":"https://api.github.com/users/danmar/events{/privacy}","received_events_url":"https://api.github.com/users/danmar/received_events","type":"User","site_admin":false},"repo":{"id":143131,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxMzE=","name":"cppcheck","full_name":"danmar/cppcheck","private":false,"owner":{"login":"danmar","id":60195,"node_id":"MDQ6VXNlcjYwMTk1","avatar_url":"https://avatars0.githubusercontent.com/u/60195?v=4","gravatar_id":"","url":"https://api.github.com/users/danmar","html_url":"https://github.com/danmar","followers_url":"https://api.github.com/users/danmar/followers","following_url":"https://api.github.com/users/danmar/following{/other_user}","gists_url":"https://api.github.com/users/danmar/gists{/gist_id}","starred_url":"https://api.github.com/users/danmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmar/subscriptions","organizations_url":"https://api.github.com/users/danmar/orgs","repos_url":"https://api.github.com/users/danmar/repos","events_url":"https://api.github.com/users/danmar/events{/privacy}","received_events_url":"https://api.github.com/users/danmar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danmar/cppcheck","description":"static analysis of C/C++ code","fork":false,"url":"https://api.github.com/repos/danmar/cppcheck","forks_url":"https://api.github.com/repos/danmar/cppcheck/forks","keys_url":"https://api.github.com/repos/danmar/cppcheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danmar/cppcheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danmar/cppcheck/teams","hooks_url":"https://api.github.com/repos/danmar/cppcheck/hooks","issue_events_url":"https://api.github.com/repos/danmar/cppcheck/issues/events{/number}","events_url":"https://api.github.com/repos/danmar/cppcheck/events","assignees_url":"https://api.github.com/repos/danmar/cppcheck/assignees{/user}","branches_url":"https://api.github.com/repos/danmar/cppcheck/branches{/branch}","tags_url":"https://api.github.com/repos/danmar/cppcheck/tags","blobs_url":"https://api.github.com/repos/danmar/cppcheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danmar/cppcheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danmar/cppcheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/danmar/cppcheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danmar/cppcheck/statuses/{sha}","languages_url":"https://api.github.com/repos/danmar/cppcheck/languages","stargazers_url":"https://api.github.com/repos/danmar/cppcheck/stargazers","contributors_url":"https://api.github.com/repos/danmar/cppcheck/contributors","subscribers_url":"https://api.github.com/repos/danmar/cppcheck/subscribers","subscription_url":"https://api.github.com/repos/danmar/cppcheck/subscription","commits_url":"https://api.github.com/repos/danmar/cppcheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/danmar/cppcheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/danmar/cppcheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/danmar/cppcheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/danmar/cppcheck/contents/{+path}","compare_url":"https://api.github.com/repos/danmar/cppcheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danmar/cppcheck/merges","archive_url":"https://api.github.com/repos/danmar/cppcheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danmar/cppcheck/downloads","issues_url":"https://api.github.com/repos/danmar/cppcheck/issues{/number}","pulls_url":"https://api.github.com/repos/danmar/cppcheck/pulls{/number}","milestones_url":"https://api.github.com/repos/danmar/cppcheck/milestones{/number}","notifications_url":"https://api.github.com/repos/danmar/cppcheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danmar/cppcheck/labels{/name}","releases_url":"https://api.github.com/repos/danmar/cppcheck/releases{/id}","deployments_url":"https://api.github.com/repos/danmar/cppcheck/deployments","created_at":"2009-03-04T20:16:45Z","updated_at":"2018-09-26T06:07:49Z","pushed_at":"2018-09-26T06:07:46Z","git_url":"git://github.com/danmar/cppcheck.git","ssh_url":"git@github.com:danmar/cppcheck.git","clone_url":"https://github.com/danmar/cppcheck.git","svn_url":"https://github.com/danmar/cppcheck","homepage":"http://cppcheck.sourceforge.net/","size":69329,"stargazers_count":1858,"watchers_count":1858,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":577,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":577,"open_issues":11,"watchers":1858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danmar/cppcheck/pulls/1391"},"html":{"href":"https://github.com/danmar/cppcheck/pull/1391"},"issue":{"href":"https://api.github.com/repos/danmar/cppcheck/issues/1391"},"comments":{"href":"https://api.github.com/repos/danmar/cppcheck/issues/1391/comments"},"review_comments":{"href":"https://api.github.com/repos/danmar/cppcheck/pulls/1391/comments"},"review_comment":{"href":"https://api.github.com/repos/danmar/cppcheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danmar/cppcheck/pulls/1391/commits"},"statuses":{"href":"https://api.github.com/repos/danmar/cppcheck/statuses/259bc258afa845d026a9a7ff943193c03d6cd5b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danmar"}}