{"action":"closed","number":658,"pull_request":{"url":"https://api.github.com/repos/json-ld/json-ld.org/pulls/658","id":196020612,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDIwNjEy","html_url":"https://github.com/json-ld/json-ld.org/pull/658","diff_url":"https://github.com/json-ld/json-ld.org/pull/658.diff","patch_url":"https://github.com/json-ld/json-ld.org/pull/658.patch","issue_url":"https://api.github.com/repos/json-ld/json-ld.org/issues/658","number":658,"state":"closed","locked":false,"title":"Remote Context Tests","user":{"login":"jcdickinson","id":522465,"node_id":"MDQ6VXNlcjUyMjQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522465?v=4","gravatar_id":"","url":"https://api.github.com/users/jcdickinson","html_url":"https://github.com/jcdickinson","followers_url":"https://api.github.com/users/jcdickinson/followers","following_url":"https://api.github.com/users/jcdickinson/following{/other_user}","gists_url":"https://api.github.com/users/jcdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdickinson/subscriptions","organizations_url":"https://api.github.com/users/jcdickinson/orgs","repos_url":"https://api.github.com/users/jcdickinson/repos","events_url":"https://api.github.com/users/jcdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/jcdickinson/received_events","type":"User","site_admin":false},"body":"I ran into an issue with my JSON-LD implementation whereby remote contexts were discarding all previous contexts. Remote contexts have no tests in the conformance suite.\r\n\r\n## Details\r\n\r\nThe `context.jsonld` now contains a `remoteContexts` parameter for test cases. This is a list of the remote contexts that should be expected to be seen, e.g.\r\n\r\n```json\r\n\"remoteContexts\": [ \"expand-ctx001-context1.jsonld\", \"expand-ctx001-context2.jsonld\" ]\r\n```\r\n\r\nThe test execution harness can either hit the website (`https://json-ld.org/test-suite/tests/`) directly, or provide a loadDocument callback that grabs the files locally (which is what I did for my fixes in my implementation).\r\n\r\nI did my best to hit all impacted areas in the repository, but I'm not sure what the change to `context.jsonld` will do the generation of `test_suite/index.html` (nor do I know ruby well enough to fix any problems that might arise).\r\n\r\n## Changes\r\n\r\n* Adding remoteContexts to context.jsonld.\r\n* Adding remoteContexts documentation to vocab.ttl.\r\n* Adding expand#ctx001 test. This test checks that remote contexts are handled correctly.\r\n* Adding supporting files for expand#ctx001 test.\r\n\r\nHave a great Wednesday!","created_at":"2018-06-20T04:43:23Z","updated_at":"2018-08-16T18:48:26Z","closed_at":"2018-08-16T18:48:25Z","merged_at":null,"merge_commit_sha":"ad6b6f200ad8b219aac190e9327329f9a4b67b80","assignee":null,"assignees":[],"requested_reviewers":[{"login":"iherman","id":520723,"node_id":"MDQ6VXNlcjUyMDcyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/520723?v=4","gravatar_id":"","url":"https://api.github.com/users/iherman","html_url":"https://github.com/iherman","followers_url":"https://api.github.com/users/iherman/followers","following_url":"https://api.github.com/users/iherman/following{/other_user}","gists_url":"https://api.github.com/users/iherman/gists{/gist_id}","starred_url":"https://api.github.com/users/iherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iherman/subscriptions","organizations_url":"https://api.github.com/users/iherman/orgs","repos_url":"https://api.github.com/users/iherman/repos","events_url":"https://api.github.com/users/iherman/events{/privacy}","received_events_url":"https://api.github.com/users/iherman/received_events","type":"User","site_admin":false},{"login":"azaroth42","id":871868,"node_id":"MDQ6VXNlcjg3MTg2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/871868?v=4","gravatar_id":"","url":"https://api.github.com/users/azaroth42","html_url":"https://github.com/azaroth42","followers_url":"https://api.github.com/users/azaroth42/followers","following_url":"https://api.github.com/users/azaroth42/following{/other_user}","gists_url":"https://api.github.com/users/azaroth42/gists{/gist_id}","starred_url":"https://api.github.com/users/azaroth42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azaroth42/subscriptions","organizations_url":"https://api.github.com/users/azaroth42/orgs","repos_url":"https://api.github.com/users/azaroth42/repos","events_url":"https://api.github.com/users/azaroth42/events{/privacy}","received_events_url":"https://api.github.com/users/azaroth42/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/json-ld/json-ld.org/pulls/658/commits","review_comments_url":"https://api.github.com/repos/json-ld/json-ld.org/pulls/658/comments","review_comment_url":"https://api.github.com/repos/json-ld/json-ld.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/json-ld/json-ld.org/issues/658/comments","statuses_url":"https://api.github.com/repos/json-ld/json-ld.org/statuses/91af7427e4b35ba883ec5c9b34d0216475b71ce8","head":{"label":"jcdickinson:master","ref":"master","sha":"91af7427e4b35ba883ec5c9b34d0216475b71ce8","user":{"login":"jcdickinson","id":522465,"node_id":"MDQ6VXNlcjUyMjQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522465?v=4","gravatar_id":"","url":"https://api.github.com/users/jcdickinson","html_url":"https://github.com/jcdickinson","followers_url":"https://api.github.com/users/jcdickinson/followers","following_url":"https://api.github.com/users/jcdickinson/following{/other_user}","gists_url":"https://api.github.com/users/jcdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdickinson/subscriptions","organizations_url":"https://api.github.com/users/jcdickinson/orgs","repos_url":"https://api.github.com/users/jcdickinson/repos","events_url":"https://api.github.com/users/jcdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/jcdickinson/received_events","type":"User","site_admin":false},"repo":{"id":137975978,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5NzU5Nzg=","name":"json-ld.org","full_name":"jcdickinson/json-ld.org","owner":{"login":"jcdickinson","id":522465,"node_id":"MDQ6VXNlcjUyMjQ2NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/522465?v=4","gravatar_id":"","url":"https://api.github.com/users/jcdickinson","html_url":"https://github.com/jcdickinson","followers_url":"https://api.github.com/users/jcdickinson/followers","following_url":"https://api.github.com/users/jcdickinson/following{/other_user}","gists_url":"https://api.github.com/users/jcdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jcdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcdickinson/subscriptions","organizations_url":"https://api.github.com/users/jcdickinson/orgs","repos_url":"https://api.github.com/users/jcdickinson/repos","events_url":"https://api.github.com/users/jcdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/jcdickinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcdickinson/json-ld.org","description":"JSON for Linked Data","fork":true,"url":"https://api.github.com/repos/jcdickinson/json-ld.org","forks_url":"https://api.github.com/repos/jcdickinson/json-ld.org/forks","keys_url":"https://api.github.com/repos/jcdickinson/json-ld.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcdickinson/json-ld.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcdickinson/json-ld.org/teams","hooks_url":"https://api.github.com/repos/jcdickinson/json-ld.org/hooks","issue_events_url":"https://api.github.com/repos/jcdickinson/json-ld.org/issues/events{/number}","events_url":"https://api.github.com/repos/jcdickinson/json-ld.org/events","assignees_url":"https://api.github.com/repos/jcdickinson/json-ld.org/assignees{/user}","branches_url":"https://api.github.com/repos/jcdickinson/json-ld.org/branches{/branch}","tags_url":"https://api.github.com/repos/jcdickinson/json-ld.org/tags","blobs_url":"https://api.github.com/repos/jcdickinson/json-ld.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcdickinson/json-ld.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcdickinson/json-ld.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcdickinson/json-ld.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcdickinson/json-ld.org/statuses/{sha}","languages_url":"https://api.github.com/repos/jcdickinson/json-ld.org/languages","stargazers_url":"https://api.github.com/repos/jcdickinson/json-ld.org/stargazers","contributors_url":"https://api.github.com/repos/jcdickinson/json-ld.org/contributors","subscribers_url":"https://api.github.com/repos/jcdickinson/json-ld.org/subscribers","subscription_url":"https://api.github.com/repos/jcdickinson/json-ld.org/subscription","commits_url":"https://api.github.com/repos/jcdickinson/json-ld.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcdickinson/json-ld.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcdickinson/json-ld.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcdickinson/json-ld.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcdickinson/json-ld.org/contents/{+path}","compare_url":"https://api.github.com/repos/jcdickinson/json-ld.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcdickinson/json-ld.org/merges","archive_url":"https://api.github.com/repos/jcdickinson/json-ld.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcdickinson/json-ld.org/downloads","issues_url":"https://api.github.com/repos/jcdickinson/json-ld.org/issues{/number}","pulls_url":"https://api.github.com/repos/jcdickinson/json-ld.org/pulls{/number}","milestones_url":"https://api.github.com/repos/jcdickinson/json-ld.org/milestones{/number}","notifications_url":"https://api.github.com/repos/jcdickinson/json-ld.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcdickinson/json-ld.org/labels{/name}","releases_url":"https://api.github.com/repos/jcdickinson/json-ld.org/releases{/id}","deployments_url":"https://api.github.com/repos/jcdickinson/json-ld.org/deployments","created_at":"2018-06-20T03:34:45Z","updated_at":"2018-06-20T04:35:36Z","pushed_at":"2018-06-20T04:35:35Z","git_url":"git://github.com/jcdickinson/json-ld.org.git","ssh_url":"git@github.com:jcdickinson/json-ld.org.git","clone_url":"https://github.com/jcdickinson/json-ld.org.git","svn_url":"https://github.com/jcdickinson/json-ld.org","homepage":"https://json-ld.org/","size":21011,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"json-ld:master","ref":"master","sha":"247c74728ecc7b14caa319656d6d7072bc61d7f6","user":{"login":"json-ld","id":806476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNjQ3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/806476?v=4","gravatar_id":"","url":"https://api.github.com/users/json-ld","html_url":"https://github.com/json-ld","followers_url":"https://api.github.com/users/json-ld/followers","following_url":"https://api.github.com/users/json-ld/following{/other_user}","gists_url":"https://api.github.com/users/json-ld/gists{/gist_id}","starred_url":"https://api.github.com/users/json-ld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-ld/subscriptions","organizations_url":"https://api.github.com/users/json-ld/orgs","repos_url":"https://api.github.com/users/json-ld/repos","events_url":"https://api.github.com/users/json-ld/events{/privacy}","received_events_url":"https://api.github.com/users/json-ld/received_events","type":"Organization","site_admin":false},"repo":{"id":1807659,"node_id":"MDEwOlJlcG9zaXRvcnkxODA3NjU5","name":"json-ld.org","full_name":"json-ld/json-ld.org","owner":{"login":"json-ld","id":806476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwNjQ3Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/806476?v=4","gravatar_id":"","url":"https://api.github.com/users/json-ld","html_url":"https://github.com/json-ld","followers_url":"https://api.github.com/users/json-ld/followers","following_url":"https://api.github.com/users/json-ld/following{/other_user}","gists_url":"https://api.github.com/users/json-ld/gists{/gist_id}","starred_url":"https://api.github.com/users/json-ld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-ld/subscriptions","organizations_url":"https://api.github.com/users/json-ld/orgs","repos_url":"https://api.github.com/users/json-ld/repos","events_url":"https://api.github.com/users/json-ld/events{/privacy}","received_events_url":"https://api.github.com/users/json-ld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/json-ld/json-ld.org","description":"JSON for Linked Data","fork":false,"url":"https://api.github.com/repos/json-ld/json-ld.org","forks_url":"https://api.github.com/repos/json-ld/json-ld.org/forks","keys_url":"https://api.github.com/repos/json-ld/json-ld.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/json-ld/json-ld.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/json-ld/json-ld.org/teams","hooks_url":"https://api.github.com/repos/json-ld/json-ld.org/hooks","issue_events_url":"https://api.github.com/repos/json-ld/json-ld.org/issues/events{/number}","events_url":"https://api.github.com/repos/json-ld/json-ld.org/events","assignees_url":"https://api.github.com/repos/json-ld/json-ld.org/assignees{/user}","branches_url":"https://api.github.com/repos/json-ld/json-ld.org/branches{/branch}","tags_url":"https://api.github.com/repos/json-ld/json-ld.org/tags","blobs_url":"https://api.github.com/repos/json-ld/json-ld.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/json-ld/json-ld.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/json-ld/json-ld.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/json-ld/json-ld.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/json-ld/json-ld.org/statuses/{sha}","languages_url":"https://api.github.com/repos/json-ld/json-ld.org/languages","stargazers_url":"https://api.github.com/repos/json-ld/json-ld.org/stargazers","contributors_url":"https://api.github.com/repos/json-ld/json-ld.org/contributors","subscribers_url":"https://api.github.com/repos/json-ld/json-ld.org/subscribers","subscription_url":"https://api.github.com/repos/json-ld/json-ld.org/subscription","commits_url":"https://api.github.com/repos/json-ld/json-ld.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/json-ld/json-ld.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/json-ld/json-ld.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/json-ld/json-ld.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/json-ld/json-ld.org/contents/{+path}","compare_url":"https://api.github.com/repos/json-ld/json-ld.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/json-ld/json-ld.org/merges","archive_url":"https://api.github.com/repos/json-ld/json-ld.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/json-ld/json-ld.org/downloads","issues_url":"https://api.github.com/repos/json-ld/json-ld.org/issues{/number}","pulls_url":"https://api.github.com/repos/json-ld/json-ld.org/pulls{/number}","milestones_url":"https://api.github.com/repos/json-ld/json-ld.org/milestones{/number}","notifications_url":"https://api.github.com/repos/json-ld/json-ld.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/json-ld/json-ld.org/labels{/name}","releases_url":"https://api.github.com/repos/json-ld/json-ld.org/releases{/id}","deployments_url":"https://api.github.com/repos/json-ld/json-ld.org/deployments","created_at":"2011-05-27T01:36:23Z","updated_at":"2018-08-14T13:12:32Z","pushed_at":"2018-08-10T23:16:26Z","git_url":"git://github.com/json-ld/json-ld.org.git","ssh_url":"git@github.com:json-ld/json-ld.org.git","clone_url":"https://github.com/json-ld/json-ld.org.git","svn_url":"https://github.com/json-ld/json-ld.org","homepage":"https://json-ld.org/","size":20647,"stargazers_count":588,"watchers_count":588,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":108,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":108,"open_issues":50,"watchers":588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/json-ld/json-ld.org/pulls/658"},"html":{"href":"https://github.com/json-ld/json-ld.org/pull/658"},"issue":{"href":"https://api.github.com/repos/json-ld/json-ld.org/issues/658"},"comments":{"href":"https://api.github.com/repos/json-ld/json-ld.org/issues/658/comments"},"review_comments":{"href":"https://api.github.com/repos/json-ld/json-ld.org/pulls/658/comments"},"review_comment":{"href":"https://api.github.com/repos/json-ld/json-ld.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/json-ld/json-ld.org/pulls/658/commits"},"statuses":{"href":"https://api.github.com/repos/json-ld/json-ld.org/statuses/91af7427e4b35ba883ec5c9b34d0216475b71ce8"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":108,"deletions":64,"changed_files":9}}
{"actor":{"display_login":"jcdickinson"}}