{"action":"created","issue":{"url":"https://api.github.com/repos/buddhi1980/mandelbulber2/issues/527","repository_url":"https://api.github.com/repos/buddhi1980/mandelbulber2","labels_url":"https://api.github.com/repos/buddhi1980/mandelbulber2/issues/527/labels{/name}","comments_url":"https://api.github.com/repos/buddhi1980/mandelbulber2/issues/527/comments","events_url":"https://api.github.com/repos/buddhi1980/mandelbulber2/issues/527/events","html_url":"https://github.com/buddhi1980/mandelbulber2/issues/527","id":352041833,"node_id":"MDU6SXNzdWUzNTIwNDE4MzM=","number":527,"title":"Re-evaluate Hybrid Mode coloring in respect to recent changes","user":{"login":"mclarekin","id":12769564,"node_id":"MDQ6VXNlcjEyNzY5NTY0","avatar_url":"https://avatars0.githubusercontent.com/u/12769564?v=4","gravatar_id":"","url":"https://api.github.com/users/mclarekin","html_url":"https://github.com/mclarekin","followers_url":"https://api.github.com/users/mclarekin/followers","following_url":"https://api.github.com/users/mclarekin/following{/other_user}","gists_url":"https://api.github.com/users/mclarekin/gists{/gist_id}","starred_url":"https://api.github.com/users/mclarekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclarekin/subscriptions","organizations_url":"https://api.github.com/users/mclarekin/orgs","repos_url":"https://api.github.com/users/mclarekin/repos","events_url":"https://api.github.com/users/mclarekin/events{/privacy}","received_events_url":"https://api.github.com/users/mclarekin/received_events","type":"User","site_admin":false},"labels":[{"id":193127431,"node_id":"MDU6TGFiZWwxOTMxMjc0MzE=","url":"https://api.github.com/repos/buddhi1980/mandelbulber2/labels/ENHANCEMENT","name":"ENHANCEMENT","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"mclarekin","id":12769564,"node_id":"MDQ6VXNlcjEyNzY5NTY0","avatar_url":"https://avatars0.githubusercontent.com/u/12769564?v=4","gravatar_id":"","url":"https://api.github.com/users/mclarekin","html_url":"https://github.com/mclarekin","followers_url":"https://api.github.com/users/mclarekin/followers","following_url":"https://api.github.com/users/mclarekin/following{/other_user}","gists_url":"https://api.github.com/users/mclarekin/gists{/gist_id}","starred_url":"https://api.github.com/users/mclarekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclarekin/subscriptions","organizations_url":"https://api.github.com/users/mclarekin/orgs","repos_url":"https://api.github.com/users/mclarekin/repos","events_url":"https://api.github.com/users/mclarekin/events{/privacy}","received_events_url":"https://api.github.com/users/mclarekin/received_events","type":"User","site_admin":false},"assignees":[{"login":"mclarekin","id":12769564,"node_id":"MDQ6VXNlcjEyNzY5NTY0","avatar_url":"https://avatars0.githubusercontent.com/u/12769564?v=4","gravatar_id":"","url":"https://api.github.com/users/mclarekin","html_url":"https://github.com/mclarekin","followers_url":"https://api.github.com/users/mclarekin/followers","following_url":"https://api.github.com/users/mclarekin/following{/other_user}","gists_url":"https://api.github.com/users/mclarekin/gists{/gist_id}","starred_url":"https://api.github.com/users/mclarekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclarekin/subscriptions","organizations_url":"https://api.github.com/users/mclarekin/orgs","repos_url":"https://api.github.com/users/mclarekin/repos","events_url":"https://api.github.com/users/mclarekin/events{/privacy}","received_events_url":"https://api.github.com/users/mclarekin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2018-08-20T08:54:31Z","updated_at":"2018-09-05T05:50:58Z","closed_at":null,"author_association":"COLLABORATOR","body":"Hybrid Mode coloring is effected, to varying degrees, by recent changes to aux.DE and r. \r\n\r\nbaisc hybrid color function is the addition of three parts\r\n\r\n      outColor =  orbit trap + aux.color + r / aux.DE\r\n\r\n**Before** when aux.r_dz was used, (log formulas) , \"+ r / aux.DE\" part had little effect.\r\n The orbitTrap created the color pattern and the other two parts often having very little effect.\r\n\r\n**Now** with log formulas,   the third part has influence.\r\n\r\nfor backwards compatability we could control over the three parts, this would enhance Hybrid Mode color control,  (avoiding having to use the slower Color_By_Numbers)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/buddhi1980/mandelbulber2/issues/comments/418607402","html_url":"https://github.com/buddhi1980/mandelbulber2/issues/527#issuecomment-418607402","issue_url":"https://api.github.com/repos/buddhi1980/mandelbulber2/issues/527","id":418607402,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODYwNzQwMg==","user":{"login":"mclarekin","id":12769564,"node_id":"MDQ6VXNlcjEyNzY5NTY0","avatar_url":"https://avatars0.githubusercontent.com/u/12769564?v=4","gravatar_id":"","url":"https://api.github.com/users/mclarekin","html_url":"https://github.com/mclarekin","followers_url":"https://api.github.com/users/mclarekin/followers","following_url":"https://api.github.com/users/mclarekin/following{/other_user}","gists_url":"https://api.github.com/users/mclarekin/gists{/gist_id}","starred_url":"https://api.github.com/users/mclarekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclarekin/subscriptions","organizations_url":"https://api.github.com/users/mclarekin/orgs","repos_url":"https://api.github.com/users/mclarekin/repos","events_url":"https://api.github.com/users/mclarekin/events{/privacy}","received_events_url":"https://api.github.com/users/mclarekin/received_events","type":"User","site_admin":false},"created_at":"2018-09-05T05:50:58Z","updated_at":"2018-09-05T05:50:58Z","author_association":"COLLABORATOR","body":"I see i am still not understanding exactly how this all works,  somewhere\nin the program it says  color calc  goes to 5 * N.\n\nIn fragmentarium, max color iterations works as expected, hmmm??\n\nHowever this is not required to work for backwards compatibility.\n\nOn Wed, Sep 5, 2018 at 3:12 PM carbuncle grim <mclarekin@gmail.com> wrote:\n\n> Next\n>  f)  Orbit trap calculation can be stopped before termination in a lot of\n> formulas. Running the calculation to 250 is unnecessary. So\n> max_orbit_trap_iterations parameter is being trialed.\n>\n> g) We are missing the most common orbit trap,    which is    case\n> fractalColoring_Standard:  but with  minimum condition added;\n>          len = colorZ.Length();  if (len < colorMin) colorMin = len;\n>\n>\n> On Wed, Sep 5, 2018 at 1:11 PM carbuncle grim <mclarekin@gmail.com> wrote:\n>\n>> e)   depending on answers to  questions a) and d), this is how I think\n>> the code should be????\n>>\n>>\n>> *remembering also that in Normal Color mode, that mandelbox using\n>> fractalColoring_Standard,     colorMin = 0.0*\n>> *((fractalColoring.coloringAlgorithm != fractalColoring_Standard) ?\n>> colorMin * 1000.0 : 0.0);*\n>>\n>> if (fractal->formula != mandelbox\n>>         || in.material->fractalColoring.coloringAlgorithm !=\n>> fractalColoring_Standard)\n>> {\n>>     if (len < colorMin) colorMin = len;\n>> }\n>> else\n>> {\n>>     colorMin = len;  //  In normal color mode, mandelbox uses abox color\n>> }\n>>\n>> if (!in.material->fractalColoring.colorPreV215False)\n>>     {\n>>         if (r > fractals.GetBailout(sequence) || (z - lastZ).Length() / r\n>> < 1e-15) break;\n>>     }\n>>     else\n>>     {\n>>         if (r > 1e15 || (z - lastZ).Length() / r < 1e-15) break; // old,\n>> is updated v2.15\n>>     }\n>> }\n>>\n>> On Wed, Sep 5, 2018 at 12:42 PM carbuncle grim <mclarekin@gmail.com>\n>> wrote:\n>>\n>>> d)  in v2.14 case fractalColoring_Standard:\n>>> we give len a value\n>>> but I cannot see where it is used after that???\n>>>\n>>> colorMin = len; is what i have assumed was required in v2.14,\n>>>\n>>>                 if (fractal->formula != mandelbox\n>>>                         ||\n>>> in.material->fractalColoring.coloringAlgorithm != fractalColoring_Standard)\n>>>                 {\n>>>                     if (len < colorMin) colorMin = len;\n>>>                     if (r > 1e15 || (z - lastZ).Length() / r < 1e-15)\n>>> break; // old, is updated v2.15\n>>>                     }\n>>>                 }\n>>>                 else\n>>>                 {\n>>>                     // colorMin = len;\n>>>                     if (r > 1e15 || (z - lastZ).Length() / r < 1e-15)\n>>> break;\n>>>                 }\n>>>\n>>> On Wed, Sep 5, 2018 at 12:04 PM carbuncle grim <mclarekin@gmail.com>\n>>> wrote:\n>>>\n>>>> b) can (Mode == calcModeColouring) be the first escape condition ??\n>>>>\n>>>> c) (Mode == calcModeCubeOrbitTrap) has no  bailout, is this correct  ??\n>>>>\n>>>> On Wed, Sep 5, 2018 at 11:36 AM carbuncle grim <mclarekin@gmail.com>\n>>>> wrote:\n>>>>\n>>>>> I will start my questions\n>>>>>\n>>>>> a)  compute_fractal.cpp 360\n>>>>>\n>>>>> if mandelbox or standard                     if (r > 1e15 || (z -\n>>>>> lastZ).Length() / r < 1e-15) break;\n>>>>> why not bailout sequence??\n>>>>>\n>>>>>\n>>>>>\n>>>>>\n>>>>> On Wed, Sep 5, 2018 at 10:43 AM carbuncle grim <mclarekin@gmail.com>\n>>>>> wrote:\n>>>>>\n>>>>>> Still a work in progress. A lot of spaghetti code was temporary.\n>>>>>> I will look at what you have done\n>>>>>>\n>>>>>> four color things I am working on, the first three are almost finished\n>>>>>>\n>>>>>> - backwards compatibility, bailout sequence change\n>>>>>>  - fix existing difference between C++ and openCL code\n>>>>>>  -add enhancements\n>>>>>> - backwards compatibility, aux.DE change\n>>>>>>\n>>>>>>\n>>>>>>\n>>>>>> On Wed, Sep 5, 2018 at 3:56 AM Krzysztof Marczak <\n>>>>>> notifications@github.com> wrote:\n>>>>>>\n>>>>>>> I have simplified code in compute_fractal.cpp. There was unnecessary\n>>>>>>> spaghetti code.\n>>>>>>>\n>>>>>>> —\n>>>>>>> You are receiving this because you were assigned.\n>>>>>>> Reply to this email directly, view it on GitHub\n>>>>>>> <https://github.com/buddhi1980/mandelbulber2/issues/527#issuecomment-418421842>,\n>>>>>>> or mute the thread\n>>>>>>> <https://github.com/notifications/unsubscribe-auth/AMLZHDvhUkUIWNk7OU-ROiNvkXZPWoAIks5uXqKhgaJpZM4WDl-_>\n>>>>>>> .\n>>>>>>>\n>>>>>>\n"}}
{"actor":{"display_login":"mclarekin"}}