{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/polydawn/stellar/pulls/4","id":239591571,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NTkxNTcx","html_url":"https://github.com/polydawn/stellar/pull/4","diff_url":"https://github.com/polydawn/stellar/pull/4.diff","patch_url":"https://github.com/polydawn/stellar/pull/4.patch","issue_url":"https://api.github.com/repos/polydawn/stellar/issues/4","number":4,"state":"open","locked":false,"title":"Workspace rework!","user":{"login":"warpfork","id":627638,"node_id":"MDQ6VXNlcjYyNzYzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/627638?v=4","gravatar_id":"","url":"https://api.github.com/users/warpfork","html_url":"https://github.com/warpfork","followers_url":"https://api.github.com/users/warpfork/followers","following_url":"https://api.github.com/users/warpfork/following{/other_user}","gists_url":"https://api.github.com/users/warpfork/gists{/gist_id}","starred_url":"https://api.github.com/users/warpfork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpfork/subscriptions","organizations_url":"https://api.github.com/users/warpfork/orgs","repos_url":"https://api.github.com/users/warpfork/repos","events_url":"https://api.github.com/users/warpfork/events{/privacy}","received_events_url":"https://api.github.com/users/warpfork/received_events","type":"User","site_admin":false},"body":"A series of changes to make things simpler and unify several flows\r\nthat had become divergent in the previous draft of workspaces:\r\n\r\n- A workspace is now **required** for a module to be evaluable.\r\n\r\n- To find a Workspace, we iterate up dirs until finding `.timeless`.\r\n(This is similar to before, but now is even more unconditional.)\r\n\r\n- The workspace closest to the cwd will always be preferred.\r\nCombined with the ability to specify a module to evaluate by path,\r\nthis means it's possible to evaluate a module at great depth using\r\nthe cwd workspace, even if there are other workspace in between.\r\nThis is critical to our future stories for multi-project coordination,\r\nwhile simultaneously being able to maintain full local catalog\r\nvendoring in a workspace per project.\r\n\r\n- Modules are now always marked by the 'module.tl' file.\r\nSupport for keeping this file inside the '.timeless' dir as a special\r\ncase has been dropped; there's just not enough call for it.\r\n\r\n- The idea of multiple catalogs per workspace has been *dropped*.\r\nIt was a bad idea full of complexity and little utility.\r\nThe catalog is now *always* at `.timeless/catalog`.\r\nThis fixes a massive UX surprise wherein previously you might have\r\ncatalogs at that path (for anon modules with no workspace) or instead\r\nin `.timeless/catalogs/upstream` (note the 's'!); nobody liked that,\r\nand every single person who discovered it was negatively surprised.\r\nSo, now we have simplified that problem out of existence.\r\n\r\nIn smaller details of implementation:\r\n\r\n- PathInsideWorkspace was never actually used (and indeed, good lord,\r\nhow would have ever have made sense?); dropped it.\r\n\r\n- layout.Workspace and layout.Module now both exist separately.\r\n(It's planned to be possible to have one process handle multiple\r\nmodules; so we should be able to look up workspace only once.)\r\n\r\n- I waffled for a while about whether it's a good idea to let\r\nEvalModule require a workspace.Workspace (i.e., config fully loaded),\r\nbecause if it's an anonymous module or no candidate is to be saved,\r\nthen we don't really *need* it per se.  But, I think worrying about\r\nmaking it possible for anonymous modules to be executable even if the\r\nworkspace config file raises parse errors is kind of... well, silly.\r\nIf there are errors, let them error; not conditionally error.\r\n\r\nMany test fixtures needed moderate rearrangement.\r\n(Quite a few used the '.timeless/module.tl' file placement, which we\r\ndropped support of... since these tests were approximately the only\r\nactual user of that path.)\r\n\r\nOh, a 'gadget/workspace' package has been introduced.  This contains\r\nthe abstraction for mapping module paths on the filesystem into\r\nmodule names (currently *still* a quite rigid implementation), and\r\nis the future home for any more workspace configuration logic.\r\n\r\nI think that's about it.  Whew.","created_at":"2018-12-18T18:42:21Z","updated_at":"2018-12-18T18:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/polydawn/stellar/pulls/4/commits","review_comments_url":"https://api.github.com/repos/polydawn/stellar/pulls/4/comments","review_comment_url":"https://api.github.com/repos/polydawn/stellar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/polydawn/stellar/issues/4/comments","statuses_url":"https://api.github.com/repos/polydawn/stellar/statuses/e437e8f009c82d975c8b03b29b536009eb1ddfc6","head":{"label":"polydawn:workspace-rework","ref":"workspace-rework","sha":"e437e8f009c82d975c8b03b29b536009eb1ddfc6","user":{"login":"polydawn","id":5307883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDc4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5307883?v=4","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"repo":{"id":138233961,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMzM5NjE=","name":"stellar","full_name":"polydawn/stellar","private":false,"owner":{"login":"polydawn","id":5307883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDc4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5307883?v=4","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/polydawn/stellar","description":"the stellar foundry for unfolding Timeless Stack builds","fork":false,"url":"https://api.github.com/repos/polydawn/stellar","forks_url":"https://api.github.com/repos/polydawn/stellar/forks","keys_url":"https://api.github.com/repos/polydawn/stellar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polydawn/stellar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polydawn/stellar/teams","hooks_url":"https://api.github.com/repos/polydawn/stellar/hooks","issue_events_url":"https://api.github.com/repos/polydawn/stellar/issues/events{/number}","events_url":"https://api.github.com/repos/polydawn/stellar/events","assignees_url":"https://api.github.com/repos/polydawn/stellar/assignees{/user}","branches_url":"https://api.github.com/repos/polydawn/stellar/branches{/branch}","tags_url":"https://api.github.com/repos/polydawn/stellar/tags","blobs_url":"https://api.github.com/repos/polydawn/stellar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polydawn/stellar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polydawn/stellar/git/refs{/sha}","trees_url":"https://api.github.com/repos/polydawn/stellar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polydawn/stellar/statuses/{sha}","languages_url":"https://api.github.com/repos/polydawn/stellar/languages","stargazers_url":"https://api.github.com/repos/polydawn/stellar/stargazers","contributors_url":"https://api.github.com/repos/polydawn/stellar/contributors","subscribers_url":"https://api.github.com/repos/polydawn/stellar/subscribers","subscription_url":"https://api.github.com/repos/polydawn/stellar/subscription","commits_url":"https://api.github.com/repos/polydawn/stellar/commits{/sha}","git_commits_url":"https://api.github.com/repos/polydawn/stellar/git/commits{/sha}","comments_url":"https://api.github.com/repos/polydawn/stellar/comments{/number}","issue_comment_url":"https://api.github.com/repos/polydawn/stellar/issues/comments{/number}","contents_url":"https://api.github.com/repos/polydawn/stellar/contents/{+path}","compare_url":"https://api.github.com/repos/polydawn/stellar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polydawn/stellar/merges","archive_url":"https://api.github.com/repos/polydawn/stellar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polydawn/stellar/downloads","issues_url":"https://api.github.com/repos/polydawn/stellar/issues{/number}","pulls_url":"https://api.github.com/repos/polydawn/stellar/pulls{/number}","milestones_url":"https://api.github.com/repos/polydawn/stellar/milestones{/number}","notifications_url":"https://api.github.com/repos/polydawn/stellar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polydawn/stellar/labels{/name}","releases_url":"https://api.github.com/repos/polydawn/stellar/releases{/id}","deployments_url":"https://api.github.com/repos/polydawn/stellar/deployments","created_at":"2018-06-22T00:02:17Z","updated_at":"2018-11-26T03:13:17Z","pushed_at":"2018-12-18T18:42:02Z","git_url":"git://github.com/polydawn/stellar.git","ssh_url":"git@github.com:polydawn/stellar.git","clone_url":"https://github.com/polydawn/stellar.git","svn_url":"https://github.com/polydawn/stellar","homepage":null,"size":111,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"polydawn:master","ref":"master","sha":"248a2864d6a14ad72455e326df343856a95250cf","user":{"login":"polydawn","id":5307883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDc4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5307883?v=4","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"repo":{"id":138233961,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyMzM5NjE=","name":"stellar","full_name":"polydawn/stellar","private":false,"owner":{"login":"polydawn","id":5307883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMDc4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/5307883?v=4","gravatar_id":"","url":"https://api.github.com/users/polydawn","html_url":"https://github.com/polydawn","followers_url":"https://api.github.com/users/polydawn/followers","following_url":"https://api.github.com/users/polydawn/following{/other_user}","gists_url":"https://api.github.com/users/polydawn/gists{/gist_id}","starred_url":"https://api.github.com/users/polydawn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polydawn/subscriptions","organizations_url":"https://api.github.com/users/polydawn/orgs","repos_url":"https://api.github.com/users/polydawn/repos","events_url":"https://api.github.com/users/polydawn/events{/privacy}","received_events_url":"https://api.github.com/users/polydawn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/polydawn/stellar","description":"the stellar foundry for unfolding Timeless Stack builds","fork":false,"url":"https://api.github.com/repos/polydawn/stellar","forks_url":"https://api.github.com/repos/polydawn/stellar/forks","keys_url":"https://api.github.com/repos/polydawn/stellar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polydawn/stellar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polydawn/stellar/teams","hooks_url":"https://api.github.com/repos/polydawn/stellar/hooks","issue_events_url":"https://api.github.com/repos/polydawn/stellar/issues/events{/number}","events_url":"https://api.github.com/repos/polydawn/stellar/events","assignees_url":"https://api.github.com/repos/polydawn/stellar/assignees{/user}","branches_url":"https://api.github.com/repos/polydawn/stellar/branches{/branch}","tags_url":"https://api.github.com/repos/polydawn/stellar/tags","blobs_url":"https://api.github.com/repos/polydawn/stellar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polydawn/stellar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polydawn/stellar/git/refs{/sha}","trees_url":"https://api.github.com/repos/polydawn/stellar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polydawn/stellar/statuses/{sha}","languages_url":"https://api.github.com/repos/polydawn/stellar/languages","stargazers_url":"https://api.github.com/repos/polydawn/stellar/stargazers","contributors_url":"https://api.github.com/repos/polydawn/stellar/contributors","subscribers_url":"https://api.github.com/repos/polydawn/stellar/subscribers","subscription_url":"https://api.github.com/repos/polydawn/stellar/subscription","commits_url":"https://api.github.com/repos/polydawn/stellar/commits{/sha}","git_commits_url":"https://api.github.com/repos/polydawn/stellar/git/commits{/sha}","comments_url":"https://api.github.com/repos/polydawn/stellar/comments{/number}","issue_comment_url":"https://api.github.com/repos/polydawn/stellar/issues/comments{/number}","contents_url":"https://api.github.com/repos/polydawn/stellar/contents/{+path}","compare_url":"https://api.github.com/repos/polydawn/stellar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polydawn/stellar/merges","archive_url":"https://api.github.com/repos/polydawn/stellar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polydawn/stellar/downloads","issues_url":"https://api.github.com/repos/polydawn/stellar/issues{/number}","pulls_url":"https://api.github.com/repos/polydawn/stellar/pulls{/number}","milestones_url":"https://api.github.com/repos/polydawn/stellar/milestones{/number}","notifications_url":"https://api.github.com/repos/polydawn/stellar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polydawn/stellar/labels{/name}","releases_url":"https://api.github.com/repos/polydawn/stellar/releases{/id}","deployments_url":"https://api.github.com/repos/polydawn/stellar/deployments","created_at":"2018-06-22T00:02:17Z","updated_at":"2018-11-26T03:13:17Z","pushed_at":"2018-12-18T18:42:02Z","git_url":"git://github.com/polydawn/stellar.git","ssh_url":"git@github.com:polydawn/stellar.git","clone_url":"https://github.com/polydawn/stellar.git","svn_url":"https://github.com/polydawn/stellar","homepage":null,"size":111,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/polydawn/stellar/pulls/4"},"html":{"href":"https://github.com/polydawn/stellar/pull/4"},"issue":{"href":"https://api.github.com/repos/polydawn/stellar/issues/4"},"comments":{"href":"https://api.github.com/repos/polydawn/stellar/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/polydawn/stellar/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/polydawn/stellar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/polydawn/stellar/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/polydawn/stellar/statuses/e437e8f009c82d975c8b03b29b536009eb1ddfc6"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":473,"deletions":199,"changed_files":13}}
{"actor":{"display_login":"warpfork"}}