{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/216405707","pull_request_review_id":153878322,"id":216405707,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQwNTcwNw==","diff_hunk":"@@ -97,7 +97,7 @@\n DEFAULT_SYNAPSE_HAPROXY_URL_FORMAT = \"http://{host:s}:{port:d}/;csv;norefresh\"\n \n DEFAULT_CPU_PERIOD = 100000\n-DEFAULT_CPU_BURST_PCT = 900\n+DEFAULT_CPU_BURST_ADD = 1","path":"paasta_tools/utils.py","position":5,"original_position":5,"commit_id":"931a9f636be618ff5477d02411201d09bcf5564c","original_commit_id":"931a9f636be618ff5477d02411201d09bcf5564c","user":{"login":"EvanKrall","id":233961,"node_id":"MDQ6VXNlcjIzMzk2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/233961?v=4","gravatar_id":"","url":"https://api.github.com/users/EvanKrall","html_url":"https://github.com/EvanKrall","followers_url":"https://api.github.com/users/EvanKrall/followers","following_url":"https://api.github.com/users/EvanKrall/following{/other_user}","gists_url":"https://api.github.com/users/EvanKrall/gists{/gist_id}","starred_url":"https://api.github.com/users/EvanKrall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvanKrall/subscriptions","organizations_url":"https://api.github.com/users/EvanKrall/orgs","repos_url":"https://api.github.com/users/EvanKrall/repos","events_url":"https://api.github.com/users/EvanKrall/events{/privacy}","received_events_url":"https://api.github.com/users/EvanKrall/received_events","type":"User","site_admin":false},"body":"This will cause a big bounce - you'll probably want to work with someone in Europe to ship this off-hours.","created_at":"2018-09-10T17:23:27Z","updated_at":"2018-09-10T17:47:27Z","html_url":"https://github.com/Yelp/paasta/pull/1975#discussion_r216405707","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/1975","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/216405707"},"html":{"href":"https://github.com/Yelp/paasta/pull/1975#discussion_r216405707"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1975"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/1975","id":214059655,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDU5NjU1","html_url":"https://github.com/Yelp/paasta/pull/1975","diff_url":"https://github.com/Yelp/paasta/pull/1975.diff","patch_url":"https://github.com/Yelp/paasta/pull/1975.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/1975","number":1975,"state":"open","locked":false,"title":"Change cpu_burst_pct to cpu_burst_add ","user":{"login":"kawaiwanyelp","id":42983305,"node_id":"MDQ6VXNlcjQyOTgzMzA1","avatar_url":"https://avatars2.githubusercontent.com/u/42983305?v=4","gravatar_id":"","url":"https://api.github.com/users/kawaiwanyelp","html_url":"https://github.com/kawaiwanyelp","followers_url":"https://api.github.com/users/kawaiwanyelp/followers","following_url":"https://api.github.com/users/kawaiwanyelp/following{/other_user}","gists_url":"https://api.github.com/users/kawaiwanyelp/gists{/gist_id}","starred_url":"https://api.github.com/users/kawaiwanyelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawaiwanyelp/subscriptions","organizations_url":"https://api.github.com/users/kawaiwanyelp/orgs","repos_url":"https://api.github.com/users/kawaiwanyelp/repos","events_url":"https://api.github.com/users/kawaiwanyelp/events{/privacy}","received_events_url":"https://api.github.com/users/kawaiwanyelp/received_events","type":"User","site_admin":false},"body":"### Description\r\n- Currently, we enforce a 10x burst on cpu usage via the cpu_burst_pct parameter in PaaSTA configs, but this has led to jobs using too many cpus.\r\n- I changed cpu_burst_pct (i.e. multiplicative) to cpu_burst_add (i.e. additive), which provides a lower and much safer cpu limit.\r\n- Instead of a 10x default, we default to 1 additional cpu.\r\n- I also changed related code in kubernetes and chronos tools, as well as the autoscaling lib (i.e. marathon) to use the new parameter instead.\r\n- Relevant tests were changed as well.\r\n\r\n### Testing done\r\n- make test\r\n\r\n### Note to reviewers\r\n- In the tests, I had to change some of the numbers around to reflect the lower cpu limit.\r\n- We initially considered changing from 10x to 2x, but even 2x is too much for jobs that request more cpus. A +1 is more than enough for smaller jobs, and will not adversely affect larger jobs. If they need more, they can supply their own cpu_burst_add.","created_at":"2018-09-07T23:14:59Z","updated_at":"2018-09-10T17:47:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9dc786002733a352a901c204091dd9279bc37e6","assignee":{"login":"kawaiwanyelp","id":42983305,"node_id":"MDQ6VXNlcjQyOTgzMzA1","avatar_url":"https://avatars2.githubusercontent.com/u/42983305?v=4","gravatar_id":"","url":"https://api.github.com/users/kawaiwanyelp","html_url":"https://github.com/kawaiwanyelp","followers_url":"https://api.github.com/users/kawaiwanyelp/followers","following_url":"https://api.github.com/users/kawaiwanyelp/following{/other_user}","gists_url":"https://api.github.com/users/kawaiwanyelp/gists{/gist_id}","starred_url":"https://api.github.com/users/kawaiwanyelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawaiwanyelp/subscriptions","organizations_url":"https://api.github.com/users/kawaiwanyelp/orgs","repos_url":"https://api.github.com/users/kawaiwanyelp/repos","events_url":"https://api.github.com/users/kawaiwanyelp/events{/privacy}","received_events_url":"https://api.github.com/users/kawaiwanyelp/received_events","type":"User","site_admin":false},"assignees":[{"login":"kawaiwanyelp","id":42983305,"node_id":"MDQ6VXNlcjQyOTgzMzA1","avatar_url":"https://avatars2.githubusercontent.com/u/42983305?v=4","gravatar_id":"","url":"https://api.github.com/users/kawaiwanyelp","html_url":"https://github.com/kawaiwanyelp","followers_url":"https://api.github.com/users/kawaiwanyelp/followers","following_url":"https://api.github.com/users/kawaiwanyelp/following{/other_user}","gists_url":"https://api.github.com/users/kawaiwanyelp/gists{/gist_id}","starred_url":"https://api.github.com/users/kawaiwanyelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kawaiwanyelp/subscriptions","organizations_url":"https://api.github.com/users/kawaiwanyelp/orgs","repos_url":"https://api.github.com/users/kawaiwanyelp/repos","events_url":"https://api.github.com/users/kawaiwanyelp/events{/privacy}","received_events_url":"https://api.github.com/users/kawaiwanyelp/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"qui","id":1322636,"node_id":"MDQ6VXNlcjEzMjI2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1322636?v=4","gravatar_id":"","url":"https://api.github.com/users/qui","html_url":"https://github.com/qui","followers_url":"https://api.github.com/users/qui/followers","following_url":"https://api.github.com/users/qui/following{/other_user}","gists_url":"https://api.github.com/users/qui/gists{/gist_id}","starred_url":"https://api.github.com/users/qui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qui/subscriptions","organizations_url":"https://api.github.com/users/qui/orgs","repos_url":"https://api.github.com/users/qui/repos","events_url":"https://api.github.com/users/qui/events{/privacy}","received_events_url":"https://api.github.com/users/qui/received_events","type":"User","site_admin":false},{"login":"matfra","id":4550821,"node_id":"MDQ6VXNlcjQ1NTA4MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/4550821?v=4","gravatar_id":"","url":"https://api.github.com/users/matfra","html_url":"https://github.com/matfra","followers_url":"https://api.github.com/users/matfra/followers","following_url":"https://api.github.com/users/matfra/following{/other_user}","gists_url":"https://api.github.com/users/matfra/gists{/gist_id}","starred_url":"https://api.github.com/users/matfra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matfra/subscriptions","organizations_url":"https://api.github.com/users/matfra/orgs","repos_url":"https://api.github.com/users/matfra/repos","events_url":"https://api.github.com/users/matfra/events{/privacy}","received_events_url":"https://api.github.com/users/matfra/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":295506239,"node_id":"MDU6TGFiZWwyOTU1MDYyMzk=","url":"https://api.github.com/repos/Yelp/paasta/labels/in%20review","name":"in review","color":"eac04b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/1975/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/1975/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/1975/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/931a9f636be618ff5477d02411201d09bcf5564c","head":{"label":"Yelp:u/kawaiwan/change-cpu-burst-from-pct-to-add","ref":"u/kawaiwan/change-cpu-burst-from-pct-to-add","sha":"931a9f636be618ff5477d02411201d09bcf5564c","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODgyNA==","name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-09-10T16:56:05Z","pushed_at":"2018-09-10T16:56:02Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":61146,"stargazers_count":1273,"watchers_count":1273,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":153,"open_issues":98,"watchers":1273,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"d67a3adb7b54642be700fc35f6870e27aefc2798","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODgyNA==","name":"paasta","full_name":"Yelp/paasta","owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2018-09-10T16:56:05Z","pushed_at":"2018-09-10T16:56:02Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":61146,"stargazers_count":1273,"watchers_count":1273,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":153,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":153,"open_issues":98,"watchers":1273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1975"},"html":{"href":"https://github.com/Yelp/paasta/pull/1975"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1975"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/1975/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1975/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/1975/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/931a9f636be618ff5477d02411201d09bcf5564c"}},"author_association":"NONE"}}
{"actor":{"display_login":"EvanKrall"}}