{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/tests/pulls/comments/236327852","pull_request_review_id":178380984,"id":236327852,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMyNzg1Mg==","diff_hunk":"@@ -196,8 +196,9 @@ kill_stale_process()\n \textract_kata_env\n \tstale_process_union=( \"${stale_process_union[@]}\" \"${PROXY_PATH}\" \"${HYPERVISOR_PATH}\" \"${SHIM_PATH}\" )\n \tfor stale_process in \"${stale_process_union[@]}\"; do\n-\t\tif pgrep -f \"${stale_process}\"; then\n-\t\t\tsudo killall -9 \"${stale_process}\" || true\n+\t\tlocal pids=$(pgrep -f \"${stale_process}\")\n+\t\tif [ -n \"$pids\" ]; then\n+\t\t\tsudo kill -9 \"${pids}\" || true","path":".ci/lib.sh","position":8,"original_position":8,"commit_id":"1a0958b21953e85e5498f0833b7a33e93d1b3bbf","original_commit_id":"1a0958b21953e85e5498f0833b7a33e93d1b3bbf","user":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"body":"I considered `pkill`, but I have some memories we had some trouble in the past with paths and fully qualified paths (but, that may not have been with `pkill`), and this note in the man page put me off...\r\n\r\n```\r\nNOTES\r\n       The process name used for matching is limited to the 15 characters present  in  the  output  of\r\n       /proc/pid/stat.   Use  the -f option to match against the complete command line, /proc/pid/cmd‐\r\n       line.\r\n```\r\n\r\nwhereas I was fairly sure the `pgrep` and `kill` were going to do the right thing...","created_at":"2018-11-26T16:31:01Z","updated_at":"2018-11-26T16:31:02Z","html_url":"https://github.com/kata-containers/tests/pull/936#discussion_r236327852","pull_request_url":"https://api.github.com/repos/kata-containers/tests/pulls/936","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/comments/236327852"},"html":{"href":"https://github.com/kata-containers/tests/pull/936#discussion_r236327852"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/936"}},"in_reply_to_id":236325682},"pull_request":{"url":"https://api.github.com/repos/kata-containers/tests/pulls/936","id":233585239,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTg1MjM5","html_url":"https://github.com/kata-containers/tests/pull/936","diff_url":"https://github.com/kata-containers/tests/pull/936.diff","patch_url":"https://github.com/kata-containers/tests/pull/936.patch","issue_url":"https://api.github.com/repos/kata-containers/tests/issues/936","number":936,"state":"open","locked":false,"title":"cleanup: don't use killall, replace with kill","user":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"body":"killall will only kill processes using the specified (exact)\r\nbinary. It will not kill off any processess running off a previously\r\nunlinked binary (of the same name/path).\r\nReplace the killall with a kill to clean up all processess of the\r\nspecified name.\r\n\r\nFixes: #92\r\n\r\nSigned-off-by: Graham Whaley <graham.whaley@intel.com>","created_at":"2018-11-26T14:53:41Z","updated_at":"2018-11-26T16:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37235f589619ec547c957a7601aa700b74b94871","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/tests/pulls/936/commits","review_comments_url":"https://api.github.com/repos/kata-containers/tests/pulls/936/comments","review_comment_url":"https://api.github.com/repos/kata-containers/tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/tests/issues/936/comments","statuses_url":"https://api.github.com/repos/kata-containers/tests/statuses/1a0958b21953e85e5498f0833b7a33e93d1b3bbf","head":{"label":"grahamwhaley:20181126_no_killall","ref":"20181126_no_killall","sha":"1a0958b21953e85e5498f0833b7a33e93d1b3bbf","user":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"repo":{"id":125889433,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4ODk0MzM=","name":"kata-containers-tests","full_name":"grahamwhaley/kata-containers-tests","private":false,"owner":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/grahamwhaley/kata-containers-tests","description":"Kata Containers tests, CI, and metrics","fork":true,"url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests","forks_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/forks","keys_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/teams","hooks_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/hooks","issue_events_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/issues/events{/number}","events_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/events","assignees_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/assignees{/user}","branches_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/branches{/branch}","tags_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/tags","blobs_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/languages","stargazers_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/stargazers","contributors_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/contributors","subscribers_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/subscribers","subscription_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/subscription","commits_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/contents/{+path}","compare_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/merges","archive_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/downloads","issues_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/issues{/number}","pulls_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/labels{/name}","releases_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/releases{/id}","deployments_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/deployments","created_at":"2018-03-19T16:38:59Z","updated_at":"2018-03-19T16:39:36Z","pushed_at":"2018-11-26T14:53:26Z","git_url":"git://github.com/grahamwhaley/kata-containers-tests.git","ssh_url":"git@github.com:grahamwhaley/kata-containers-tests.git","clone_url":"https://github.com/grahamwhaley/kata-containers-tests.git","svn_url":"https://github.com/grahamwhaley/kata-containers-tests","homepage":"","size":2516,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"8a80ea6ae6d6f9f0f876e321eb5805bbf319a584","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539912,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk5MTI=","name":"tests","full_name":"kata-containers/tests","private":false,"owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kata-containers/tests","description":"Kata Containers tests, CI, and metrics","fork":false,"url":"https://api.github.com/repos/kata-containers/tests","forks_url":"https://api.github.com/repos/kata-containers/tests/forks","keys_url":"https://api.github.com/repos/kata-containers/tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/tests/teams","hooks_url":"https://api.github.com/repos/kata-containers/tests/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/tests/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/tests/events","assignees_url":"https://api.github.com/repos/kata-containers/tests/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/tests/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/tests/tags","blobs_url":"https://api.github.com/repos/kata-containers/tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/tests/languages","stargazers_url":"https://api.github.com/repos/kata-containers/tests/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/tests/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/tests/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/tests/subscription","commits_url":"https://api.github.com/repos/kata-containers/tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/tests/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/tests/merges","archive_url":"https://api.github.com/repos/kata-containers/tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/tests/downloads","issues_url":"https://api.github.com/repos/kata-containers/tests/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/tests/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/tests/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/tests/deployments","created_at":"2017-11-13T11:28:08Z","updated_at":"2018-11-23T09:07:02Z","pushed_at":"2018-11-26T14:53:42Z","git_url":"git://github.com/kata-containers/tests.git","ssh_url":"git@github.com:kata-containers/tests.git","clone_url":"https://github.com/kata-containers/tests.git","svn_url":"https://github.com/kata-containers/tests","homepage":"","size":2509,"stargazers_count":70,"watchers_count":70,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":82,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/936"},"html":{"href":"https://github.com/kata-containers/tests/pull/936"},"issue":{"href":"https://api.github.com/repos/kata-containers/tests/issues/936"},"comments":{"href":"https://api.github.com/repos/kata-containers/tests/issues/936/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/936/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/936/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/tests/statuses/1a0958b21953e85e5498f0833b7a33e93d1b3bbf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"grahamwhaley"}}