{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/183232368","pull_request_review_id":114196706,"id":183232368,"diff_hunk":"@@ -0,0 +1,228 @@\n+\"\"\"\n+Support for Phicomm air sensor.\n+\n+For more details about this platform, please refer to the documentation at\n+https://home-assistant.io/components/sensor.phicomm/\n+\"\"\"\n+\n+import asyncio\n+import logging\n+\n+from datetime import timedelta\n+\n+import requests\n+import voluptuous as vol\n+\n+from homeassistant.components.sensor import PLATFORM_SCHEMA\n+from homeassistant.const import (\n+    CONF_NAME, CONF_USERNAME, CONF_PASSWORD,\n+    CONF_SENSORS, CONF_SCAN_INTERVAL, TEMP_CELSIUS)\n+from homeassistant.helpers.entity import Entity\n+from homeassistant.helpers.event import async_track_time_interval\n+import homeassistant.helpers.config_validation as cv\n+\n+_LOGGER = logging.getLogger(__name__)\n+\n+AUTH_CODE = 'feixun.SH_1'\n+TOKEN_FILE = '.phicomm.token.'\n+USER_AGENT = 'zhilian/5.7.0 (iPhone; iOS 10.0.2; Scale/3.00)'\n+\n+TOKEN_URL = 'https://accountsym.phicomm.com/v1/login'\n+DATA_URL = 'https://aircleaner.phicomm.com/aircleaner/getIndexData'\n+\n+SENSOR_PM25 = 'pm25'\n+SENSOR_HCHO = 'hcho'\n+SENSOR_TEMPERATURE = 'temperature'\n+SENSOR_HUMIDITY = 'humidity'\n+\n+DEFAULT_NAME = 'Phicomm'\n+DEFAULT_SENSORS = [SENSOR_PM25, SENSOR_HCHO,\n+                   SENSOR_TEMPERATURE, SENSOR_HUMIDITY]\n+\n+SENSOR_MAP = {\n+    SENSOR_PM25: ('PM2.5', 'μg/m³', 'blur'),\n+    SENSOR_HCHO: ('HCHO', 'mg/m³', 'biohazard'),\n+    SENSOR_TEMPERATURE: ('Temperature', TEMP_CELSIUS, 'thermometer'),\n+    SENSOR_HUMIDITY: ('Humidity', '%', 'water-percent')\n+}\n+\n+PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({\n+    vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,\n+    vol.Required(CONF_USERNAME): cv.string,\n+    vol.Required(CONF_PASSWORD): cv.string,\n+    vol.Optional(CONF_SENSORS, default=DEFAULT_SENSORS):\n+        vol.All(cv.ensure_list, vol.Length(min=1), [vol.In(SENSOR_MAP)]),\n+    vol.Optional(CONF_SCAN_INTERVAL, default=timedelta(seconds=120)): (\n+        vol.All(cv.time_period, cv.positive_timedelta)),\n+})\n+\n+\n+@asyncio.coroutine\n+def async_setup_platform(hass, config, async_add_devices, discovery_info=None):\n+    \"\"\"Set up the Phicomm sensor.\"\"\"\n+    name = config.get(CONF_NAME)\n+    username = config.get(CONF_USERNAME)\n+    password = config.get(CONF_PASSWORD)\n+    sensors = config.get(CONF_SENSORS)\n+    scan_interval = config.get(CONF_SCAN_INTERVAL)\n+\n+    phicomm = PhicommData(hass, username, password)\n+    devices = yield from phicomm.make_sensors(name, sensors)\n+    if devices:\n+        async_add_devices(devices)","path":"homeassistant/components/sensor/phicomm.py","position":72,"original_position":72,"commit_id":"cf47c88cbce58a9002ed634180536b1711805274","original_commit_id":"cf47c88cbce58a9002ed634180536b1711805274","user":{"login":"Kane610","id":24575746,"avatar_url":"https://avatars0.githubusercontent.com/u/24575746?v=4","gravatar_id":"","url":"https://api.github.com/users/Kane610","html_url":"https://github.com/Kane610","followers_url":"https://api.github.com/users/Kane610/followers","following_url":"https://api.github.com/users/Kane610/following{/other_user}","gists_url":"https://api.github.com/users/Kane610/gists{/gist_id}","starred_url":"https://api.github.com/users/Kane610/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kane610/subscriptions","organizations_url":"https://api.github.com/users/Kane610/orgs","repos_url":"https://api.github.com/users/Kane610/repos","events_url":"https://api.github.com/users/Kane610/events{/privacy}","received_events_url":"https://api.github.com/users/Kane610/received_events","type":"User","site_admin":false},"body":"If this is async you should be await/yield from right?","created_at":"2018-04-22T10:50:57Z","updated_at":"2018-04-22T10:50:57Z","html_url":"https://github.com/home-assistant/home-assistant/pull/13781#discussion_r183232368","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/183232368"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/13781#discussion_r183232368"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781","id":180304729,"html_url":"https://github.com/home-assistant/home-assistant/pull/13781","diff_url":"https://github.com/home-assistant/home-assistant/pull/13781.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/13781.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13781","number":13781,"state":"open","locked":false,"title":"Phicomm M1 air sensor","user":{"login":"Yonsm","id":1648076,"avatar_url":"https://avatars1.githubusercontent.com/u/1648076?v=4","gravatar_id":"","url":"https://api.github.com/users/Yonsm","html_url":"https://github.com/Yonsm","followers_url":"https://api.github.com/users/Yonsm/followers","following_url":"https://api.github.com/users/Yonsm/following{/other_user}","gists_url":"https://api.github.com/users/Yonsm/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonsm/subscriptions","organizations_url":"https://api.github.com/users/Yonsm/orgs","repos_url":"https://api.github.com/users/Yonsm/repos","events_url":"https://api.github.com/users/Yonsm/events{/privacy}","received_events_url":"https://api.github.com/users/Yonsm/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#5142\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nsensors:\r\n  - platform: phicomm\r\n    name: Phicomm\r\n    username: ********\r\n    password: ********\r\n    sensors: [pm25, hcho, temperature, humidity]\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-04-09T13:05:40Z","updated_at":"2018-04-22T10:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18a3a7c79fe31390496a0e136328e52965243e4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":526146744,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"ededed","default":false},{"id":895633069,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.phicomm","name":"platform: sensor.phicomm","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13781/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/cf47c88cbce58a9002ed634180536b1711805274","head":{"label":"Yonsm:phicomm_aircat_sensor","ref":"phicomm_aircat_sensor","sha":"cf47c88cbce58a9002ed634180536b1711805274","user":{"login":"Yonsm","id":1648076,"avatar_url":"https://avatars1.githubusercontent.com/u/1648076?v=4","gravatar_id":"","url":"https://api.github.com/users/Yonsm","html_url":"https://github.com/Yonsm","followers_url":"https://api.github.com/users/Yonsm/followers","following_url":"https://api.github.com/users/Yonsm/following{/other_user}","gists_url":"https://api.github.com/users/Yonsm/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonsm/subscriptions","organizations_url":"https://api.github.com/users/Yonsm/orgs","repos_url":"https://api.github.com/users/Yonsm/repos","events_url":"https://api.github.com/users/Yonsm/events{/privacy}","received_events_url":"https://api.github.com/users/Yonsm/received_events","type":"User","site_admin":false},"repo":{"id":128159844,"name":"home-assistant","full_name":"Yonsm/home-assistant","owner":{"login":"Yonsm","id":1648076,"avatar_url":"https://avatars1.githubusercontent.com/u/1648076?v=4","gravatar_id":"","url":"https://api.github.com/users/Yonsm","html_url":"https://github.com/Yonsm","followers_url":"https://api.github.com/users/Yonsm/followers","following_url":"https://api.github.com/users/Yonsm/following{/other_user}","gists_url":"https://api.github.com/users/Yonsm/gists{/gist_id}","starred_url":"https://api.github.com/users/Yonsm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yonsm/subscriptions","organizations_url":"https://api.github.com/users/Yonsm/orgs","repos_url":"https://api.github.com/users/Yonsm/repos","events_url":"https://api.github.com/users/Yonsm/events{/privacy}","received_events_url":"https://api.github.com/users/Yonsm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yonsm/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/Yonsm/home-assistant","forks_url":"https://api.github.com/repos/Yonsm/home-assistant/forks","keys_url":"https://api.github.com/repos/Yonsm/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yonsm/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yonsm/home-assistant/teams","hooks_url":"https://api.github.com/repos/Yonsm/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/Yonsm/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/Yonsm/home-assistant/events","assignees_url":"https://api.github.com/repos/Yonsm/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/Yonsm/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/Yonsm/home-assistant/tags","blobs_url":"https://api.github.com/repos/Yonsm/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yonsm/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yonsm/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yonsm/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yonsm/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/Yonsm/home-assistant/languages","stargazers_url":"https://api.github.com/repos/Yonsm/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/Yonsm/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/Yonsm/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/Yonsm/home-assistant/subscription","commits_url":"https://api.github.com/repos/Yonsm/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yonsm/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yonsm/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yonsm/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yonsm/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/Yonsm/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yonsm/home-assistant/merges","archive_url":"https://api.github.com/repos/Yonsm/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yonsm/home-assistant/downloads","issues_url":"https://api.github.com/repos/Yonsm/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/Yonsm/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/Yonsm/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/Yonsm/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yonsm/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/Yonsm/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/Yonsm/home-assistant/deployments","created_at":"2018-04-05T04:41:18Z","updated_at":"2018-04-20T06:34:13Z","pushed_at":"2018-04-22T09:47:03Z","git_url":"git://github.com/Yonsm/home-assistant.git","ssh_url":"git@github.com:Yonsm/home-assistant.git","clone_url":"https://github.com/Yonsm/home-assistant.git","svn_url":"https://github.com/Yonsm/home-assistant","homepage":"https://home-assistant.io","size":81380,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"c2bee496e2a83a05116c5e4c637f00aeec2109b6","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-04-22T10:16:04Z","pushed_at":"2018-04-22T10:44:18Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":81395,"stargazers_count":13856,"watchers_count":13856,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4102,"mirror_url":null,"archived":false,"open_issues_count":758,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4102,"open_issues":758,"watchers":13856,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/13781"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/13781"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/13781/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13781/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/cf47c88cbce58a9002ed634180536b1711805274"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Kane610"}}