{"action":"created","issue":{"url":"https://api.github.com/repos/glitch-soc/mastodon/issues/558","repository_url":"https://api.github.com/repos/glitch-soc/mastodon","labels_url":"https://api.github.com/repos/glitch-soc/mastodon/issues/558/labels{/name}","comments_url":"https://api.github.com/repos/glitch-soc/mastodon/issues/558/comments","events_url":"https://api.github.com/repos/glitch-soc/mastodon/issues/558/events","html_url":"https://github.com/glitch-soc/mastodon/pull/558","id":339282412,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTc1OTEw","number":558,"title":"add option to enable auto visibility on secondary toot button","user":{"login":"ashkitten","id":9281956,"node_id":"MDQ6VXNlcjkyODE5NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/9281956?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkitten","html_url":"https://github.com/ashkitten","followers_url":"https://api.github.com/users/ashkitten/followers","following_url":"https://api.github.com/users/ashkitten/following{/other_user}","gists_url":"https://api.github.com/users/ashkitten/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkitten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkitten/subscriptions","organizations_url":"https://api.github.com/users/ashkitten/orgs","repos_url":"https://api.github.com/users/ashkitten/repos","events_url":"https://api.github.com/users/ashkitten/events{/privacy}","received_events_url":"https://api.github.com/users/ashkitten/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-07-09T02:09:21Z","updated_at":"2018-07-09T13:44:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/glitch-soc/mastodon/pulls/558","html_url":"https://github.com/glitch-soc/mastodon/pull/558","diff_url":"https://github.com/glitch-soc/mastodon/pull/558.diff","patch_url":"https://github.com/glitch-soc/mastodon/pull/558.patch"},"body":"this adds an option which makes the secondary toot button automatically change to the visibility of the status you're replying to, regardless of the static setting for it."},"comment":{"url":"https://api.github.com/repos/glitch-soc/mastodon/issues/comments/403483916","html_url":"https://github.com/glitch-soc/mastodon/pull/558#issuecomment-403483916","issue_url":"https://api.github.com/repos/glitch-soc/mastodon/issues/558","id":403483916,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzQ4MzkxNg==","user":{"login":"ThibG","id":384364,"node_id":"MDQ6VXNlcjM4NDM2NA==","avatar_url":"https://avatars2.githubusercontent.com/u/384364?v=4","gravatar_id":"","url":"https://api.github.com/users/ThibG","html_url":"https://github.com/ThibG","followers_url":"https://api.github.com/users/ThibG/followers","following_url":"https://api.github.com/users/ThibG/following{/other_user}","gists_url":"https://api.github.com/users/ThibG/gists{/gist_id}","starred_url":"https://api.github.com/users/ThibG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThibG/subscriptions","organizations_url":"https://api.github.com/users/ThibG/orgs","repos_url":"https://api.github.com/users/ThibG/repos","events_url":"https://api.github.com/users/ThibG/events{/privacy}","received_events_url":"https://api.github.com/users/ThibG/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T13:44:12Z","updated_at":"2018-07-09T13:44:12Z","author_association":"NONE","body":"@hoodiek first, that may not have been your intent, but I have to say your message reads very rude.\r\n\r\nNow that's out of the way: the second button allows you to have quick access to a different privacy setting than your default. That might be higher or lower than your default privacy setting, that's up to you. Its current behavior is also different from that of the main button as it is fixed and does not depend on what you are replying to. There isn't anything more to it as far as I can tell.\r\n\r\nYour message also suggests it is currently impossible to reply with a less restrictive privacy than your default or the toot you're replying to. This is false, you can adjust the privacy before posting, although it's an extra step compared to what's proposed here.\r\n\r\nNow, the current PR didn't include rationale behind the change, so I could only infer what I thought it was for. I haven't rejected this PR or stated that there was anything inherently wrong with it either.\r\n\r\nBack to the change itself, it introduces an option to change the behavior of the secondary toot button to match the privacy of the post being replied to. My suggestion was to have that button to take the most restrictive privacy between that set to it and that of the toot being replied to. Indeed, there are currently two main use cases for the secondary button: having a default privacy more restrictive or less restrictive than your default privacy.\r\n1. In case the secondary button has stricter privacy than the default setting (that's how I use it, so I was biased in understanding this PR initially), this option seems counter-intuitive as it will always result in posts with at most as strict privacy as the default button. This may potentially lead to accidentally posting with less restrictive privacy than intended.\r\n2. The other case, with default privacy being stricter than the secondary button, the change I suggested would in most case not change the behavior of this PR."}}
{"actor":{"display_login":"ThibG"}}