{"action":"created","comment":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/237296858","pull_request_review_id":179557393,"id":237296858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzI5Njg1OA==","diff_hunk":"@@ -70,7 +71,8 @@\n       ],\n       \"logs\": [],\n       \"processID\": \"p1\",\n-      \"warnings\": null\n+      \"warnings\": null,\n+      \"incomplete\": false","path":"model/converter/json/fixtures/ui_01.json","position":16,"original_position":16,"commit_id":"61332ddebe48ee70e0224efe91edf2fa50c8167b","original_commit_id":"61332ddebe48ee70e0224efe91edf2fa50c8167b","user":{"login":"yurishkuro","id":3523016,"node_id":"MDQ6VXNlcjM1MjMwMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"why do we need to add this? Isn't false going to be the default value anyway?","created_at":"2018-11-28T23:04:40Z","updated_at":"2018-11-28T23:12:02Z","html_url":"https://github.com/jaegertracing/jaeger/pull/979#discussion_r237296858","pull_request_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments/237296858"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/979#discussion_r237296858"},"pull_request":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979","id":207332680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzMyNjgw","html_url":"https://github.com/jaegertracing/jaeger/pull/979","diff_url":"https://github.com/jaegertracing/jaeger/pull/979.diff","patch_url":"https://github.com/jaegertracing/jaeger/pull/979.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/979","number":979,"state":"open","locked":false,"title":"Incomplete span support","user":{"login":"phal0r","id":3658211,"node_id":"MDQ6VXNlcjM2NTgyMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3658211?v=4","gravatar_id":"","url":"https://api.github.com/users/phal0r","html_url":"https://github.com/phal0r","followers_url":"https://api.github.com/users/phal0r/followers","following_url":"https://api.github.com/users/phal0r/following{/other_user}","gists_url":"https://api.github.com/users/phal0r/gists{/gist_id}","starred_url":"https://api.github.com/users/phal0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phal0r/subscriptions","organizations_url":"https://api.github.com/users/phal0r/orgs","repos_url":"https://api.github.com/users/phal0r/repos","events_url":"https://api.github.com/users/phal0r/events{/privacy}","received_events_url":"https://api.github.com/users/phal0r/received_events","type":"User","site_admin":false},"body":"## Which problem is this PR solving?\r\n- This PR supports sending intermediate spans as suggested in #729 \r\n- this PR is build upon PR #728 \r\n\r\n## Short description of the changes\r\n- changed all jaeger models to accept a new key `incomplete`\r\n- generated new thrift types\r\n- zipkin spans are always converted incomplete: false\r\n- backwards compatible with client, that do not support this feature (incomplete will be false)\r\n- changed elasticsearch mapping to support inomplete attribute\r\n- changed cassandra schema and reader/writer to support incomplete attribute\r\n","created_at":"2018-08-09T14:18:45Z","updated_at":"2018-11-28T23:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c55c05ff29d61ab6751074587a73460e4b7fc354","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jpkrohling","id":13387,"node_id":"MDQ6VXNlcjEzMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/13387?v=4","gravatar_id":"","url":"https://api.github.com/users/jpkrohling","html_url":"https://github.com/jpkrohling","followers_url":"https://api.github.com/users/jpkrohling/followers","following_url":"https://api.github.com/users/jpkrohling/following{/other_user}","gists_url":"https://api.github.com/users/jpkrohling/gists{/gist_id}","starred_url":"https://api.github.com/users/jpkrohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpkrohling/subscriptions","organizations_url":"https://api.github.com/users/jpkrohling/orgs","repos_url":"https://api.github.com/users/jpkrohling/repos","events_url":"https://api.github.com/users/jpkrohling/events{/privacy}","received_events_url":"https://api.github.com/users/jpkrohling/received_events","type":"User","site_admin":false},{"login":"objectiser","id":164562,"node_id":"MDQ6VXNlcjE2NDU2Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},{"login":"black-adder","id":791791,"node_id":"MDQ6VXNlcjc5MTc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/791791?v=4","gravatar_id":"","url":"https://api.github.com/users/black-adder","html_url":"https://github.com/black-adder","followers_url":"https://api.github.com/users/black-adder/followers","following_url":"https://api.github.com/users/black-adder/following{/other_user}","gists_url":"https://api.github.com/users/black-adder/gists{/gist_id}","starred_url":"https://api.github.com/users/black-adder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/black-adder/subscriptions","organizations_url":"https://api.github.com/users/black-adder/orgs","repos_url":"https://api.github.com/users/black-adder/repos","events_url":"https://api.github.com/users/black-adder/events{/privacy}","received_events_url":"https://api.github.com/users/black-adder/received_events","type":"User","site_admin":false},{"login":"tiffon","id":2304337,"node_id":"MDQ6VXNlcjIzMDQzMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2304337?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffon","html_url":"https://github.com/tiffon","followers_url":"https://api.github.com/users/tiffon/followers","following_url":"https://api.github.com/users/tiffon/following{/other_user}","gists_url":"https://api.github.com/users/tiffon/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffon/subscriptions","organizations_url":"https://api.github.com/users/tiffon/orgs","repos_url":"https://api.github.com/users/tiffon/repos","events_url":"https://api.github.com/users/tiffon/events{/privacy}","received_events_url":"https://api.github.com/users/tiffon/received_events","type":"User","site_admin":false},{"login":"pavolloffay","id":5618424,"node_id":"MDQ6VXNlcjU2MTg0MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5618424?v=4","gravatar_id":"","url":"https://api.github.com/users/pavolloffay","html_url":"https://github.com/pavolloffay","followers_url":"https://api.github.com/users/pavolloffay/followers","following_url":"https://api.github.com/users/pavolloffay/following{/other_user}","gists_url":"https://api.github.com/users/pavolloffay/gists{/gist_id}","starred_url":"https://api.github.com/users/pavolloffay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavolloffay/subscriptions","organizations_url":"https://api.github.com/users/pavolloffay/orgs","repos_url":"https://api.github.com/users/pavolloffay/repos","events_url":"https://api.github.com/users/pavolloffay/events{/privacy}","received_events_url":"https://api.github.com/users/pavolloffay/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/979/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/61332ddebe48ee70e0224efe91edf2fa50c8167b","head":{"label":"phal0r:incomplete_span_support","ref":"incomplete_span_support","sha":"61332ddebe48ee70e0224efe91edf2fa50c8167b","user":{"login":"phal0r","id":3658211,"node_id":"MDQ6VXNlcjM2NTgyMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3658211?v=4","gravatar_id":"","url":"https://api.github.com/users/phal0r","html_url":"https://github.com/phal0r","followers_url":"https://api.github.com/users/phal0r/followers","following_url":"https://api.github.com/users/phal0r/following{/other_user}","gists_url":"https://api.github.com/users/phal0r/gists{/gist_id}","starred_url":"https://api.github.com/users/phal0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phal0r/subscriptions","organizations_url":"https://api.github.com/users/phal0r/orgs","repos_url":"https://api.github.com/users/phal0r/repos","events_url":"https://api.github.com/users/phal0r/events{/privacy}","received_events_url":"https://api.github.com/users/phal0r/received_events","type":"User","site_admin":false},"repo":{"id":124373258,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzNzMyNTg=","name":"jaeger","full_name":"phal0r/jaeger","private":false,"owner":{"login":"phal0r","id":3658211,"node_id":"MDQ6VXNlcjM2NTgyMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/3658211?v=4","gravatar_id":"","url":"https://api.github.com/users/phal0r","html_url":"https://github.com/phal0r","followers_url":"https://api.github.com/users/phal0r/followers","following_url":"https://api.github.com/users/phal0r/following{/other_user}","gists_url":"https://api.github.com/users/phal0r/gists{/gist_id}","starred_url":"https://api.github.com/users/phal0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phal0r/subscriptions","organizations_url":"https://api.github.com/users/phal0r/orgs","repos_url":"https://api.github.com/users/phal0r/repos","events_url":"https://api.github.com/users/phal0r/events{/privacy}","received_events_url":"https://api.github.com/users/phal0r/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phal0r/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":true,"url":"https://api.github.com/repos/phal0r/jaeger","forks_url":"https://api.github.com/repos/phal0r/jaeger/forks","keys_url":"https://api.github.com/repos/phal0r/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phal0r/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phal0r/jaeger/teams","hooks_url":"https://api.github.com/repos/phal0r/jaeger/hooks","issue_events_url":"https://api.github.com/repos/phal0r/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/phal0r/jaeger/events","assignees_url":"https://api.github.com/repos/phal0r/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/phal0r/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/phal0r/jaeger/tags","blobs_url":"https://api.github.com/repos/phal0r/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phal0r/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phal0r/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/phal0r/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phal0r/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/phal0r/jaeger/languages","stargazers_url":"https://api.github.com/repos/phal0r/jaeger/stargazers","contributors_url":"https://api.github.com/repos/phal0r/jaeger/contributors","subscribers_url":"https://api.github.com/repos/phal0r/jaeger/subscribers","subscription_url":"https://api.github.com/repos/phal0r/jaeger/subscription","commits_url":"https://api.github.com/repos/phal0r/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/phal0r/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/phal0r/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/phal0r/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/phal0r/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/phal0r/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phal0r/jaeger/merges","archive_url":"https://api.github.com/repos/phal0r/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phal0r/jaeger/downloads","issues_url":"https://api.github.com/repos/phal0r/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/phal0r/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/phal0r/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/phal0r/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phal0r/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/phal0r/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/phal0r/jaeger/deployments","created_at":"2018-03-08T10:07:20Z","updated_at":"2018-10-10T09:23:03Z","pushed_at":"2018-11-16T23:35:07Z","git_url":"git://github.com/phal0r/jaeger.git","ssh_url":"git@github.com:phal0r/jaeger.git","clone_url":"https://github.com/phal0r/jaeger.git","svn_url":"https://github.com/phal0r/jaeger","homepage":"http://jaegertracing.io/","size":24435,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"9f8d32404b2ad01fd7efcd010a8f65af8a0713cf","user":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":56342508,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM0MjUwOA==","name":"jaeger","full_name":"jaegertracing/jaeger","private":false,"owner":{"login":"jaegertracing","id":28545596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTQ1NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jaegertracing/jaeger","description":"CNCF Jaeger, a Distributed Tracing System","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger","forks_url":"https://api.github.com/repos/jaegertracing/jaeger/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger/deployments","created_at":"2016-04-15T18:49:02Z","updated_at":"2018-11-28T22:56:52Z","pushed_at":"2018-11-28T22:40:07Z","git_url":"git://github.com/jaegertracing/jaeger.git","ssh_url":"git@github.com:jaegertracing/jaeger.git","clone_url":"https://github.com/jaegertracing/jaeger.git","svn_url":"https://github.com/jaegertracing/jaeger","homepage":"https://jaegertracing.io/","size":17294,"stargazers_count":6504,"watchers_count":6504,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":581,"mirror_url":null,"archived":false,"open_issues_count":250,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":581,"open_issues":250,"watchers":6504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979"},"html":{"href":"https://github.com/jaegertracing/jaeger/pull/979"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/979"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger/statuses/61332ddebe48ee70e0224efe91edf2fa50c8167b"}},"author_association":"NONE"}}
{"actor":{"display_login":"yurishkuro"}}