{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/204593189","pull_request_review_id":139699815,"id":204593189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU5MzE4OQ==","diff_hunk":"@@ -140,7 +140,22 @@ int EVP_DigestInit_ex(EVP_MD_CTX *ctx, const EVP_MD *type, ENGINE *impl)\n     }\n     if (ctx->flags & EVP_MD_CTX_FLAG_NO_INIT)\n         return 1;\n-    return ctx->digest->init(ctx);\n+    if (ctx->digest->init(ctx) == 0)\n+        return 0;\n+\n+    if (ctx->pctx) {\n+        int r;\n+        r = EVP_PKEY_CTX_ctrl(ctx->pctx, -1, EVP_PKEY_OP_TYPE_SIG,\n+                              EVP_PKEY_CTRL_DIGESTSETUP, 0, ctx);\n+\n+        if (r == -2) {\n+            ERR_clear_error();","path":"crypto/evp/digest.c","position":15,"original_position":14,"commit_id":"35ad78f07b4af2b4b902bd2245c49c2cd9f25bb0","original_commit_id":"87990a11e1b83d67983b5783c68ef0bf6cc5fa80","user":{"login":"randombit","id":469092,"node_id":"MDQ6VXNlcjQ2OTA5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/469092?v=4","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"body":"Seems so since that avoids wiping out the entire error stack. Thanks, didn't know about these.","created_at":"2018-07-24T00:31:14Z","updated_at":"2018-07-24T00:31:14Z","html_url":"https://github.com/openssl/openssl/pull/6757#discussion_r204593189","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/6757","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/204593189"},"html":{"href":"https://github.com/openssl/openssl/pull/6757#discussion_r204593189"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6757"}},"in_reply_to_id":204333153},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6757","id":202979191,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTc5MTkx","html_url":"https://github.com/openssl/openssl/pull/6757","diff_url":"https://github.com/openssl/openssl/pull/6757.diff","patch_url":"https://github.com/openssl/openssl/pull/6757.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6757","number":6757,"state":"open","locked":false,"title":"Add support for setting SM2 id field","user":{"login":"randombit","id":469092,"node_id":"MDQ6VXNlcjQ2OTA5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/469092?v=4","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"body":"Fixing #6534 \r\n\r\n- [x] documentation is added or updated\r\n- [x] tests are added or updated\r\n\r\nThis is a contribution from Ribose Inc (@riboseinc)","created_at":"2018-07-20T23:54:53Z","updated_at":"2018-07-24T00:31:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd5052522ba9330a19d5eb74f350535356120a10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/openssl/openssl/milestones/11","html_url":"https://github.com/openssl/openssl/milestone/11","labels_url":"https://api.github.com/repos/openssl/openssl/milestones/11/labels","id":3024154,"node_id":"MDk6TWlsZXN0b25lMzAyNDE1NA==","number":11,"title":"Post 1.1.1","description":"","creator":{"login":"kaduk","id":1894506,"node_id":"MDQ6VXNlcjE4OTQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1894506?v=4","gravatar_id":"","url":"https://api.github.com/users/kaduk","html_url":"https://github.com/kaduk","followers_url":"https://api.github.com/users/kaduk/followers","following_url":"https://api.github.com/users/kaduk/following{/other_user}","gists_url":"https://api.github.com/users/kaduk/gists{/gist_id}","starred_url":"https://api.github.com/users/kaduk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaduk/subscriptions","organizations_url":"https://api.github.com/users/kaduk/orgs","repos_url":"https://api.github.com/users/kaduk/repos","events_url":"https://api.github.com/users/kaduk/events{/privacy}","received_events_url":"https://api.github.com/users/kaduk/received_events","type":"User","site_admin":false},"open_issues":212,"closed_issues":42,"state":"open","created_at":"2018-01-09T21:08:23Z","updated_at":"2018-07-23T09:51:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/6757/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/6757/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6757/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/35ad78f07b4af2b4b902bd2245c49c2cd9f25bb0","head":{"label":"riboseinc:sm2-set-id","ref":"sm2-set-id","sha":"35ad78f07b4af2b4b902bd2245c49c2cd9f25bb0","user":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"repo":{"id":104009680,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQwMDk2ODA=","name":"openssl","full_name":"riboseinc/openssl","owner":{"login":"riboseinc","id":24904375,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTA0Mzc1","avatar_url":"https://avatars0.githubusercontent.com/u/24904375?v=4","gravatar_id":"","url":"https://api.github.com/users/riboseinc","html_url":"https://github.com/riboseinc","followers_url":"https://api.github.com/users/riboseinc/followers","following_url":"https://api.github.com/users/riboseinc/following{/other_user}","gists_url":"https://api.github.com/users/riboseinc/gists{/gist_id}","starred_url":"https://api.github.com/users/riboseinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riboseinc/subscriptions","organizations_url":"https://api.github.com/users/riboseinc/orgs","repos_url":"https://api.github.com/users/riboseinc/repos","events_url":"https://api.github.com/users/riboseinc/events{/privacy}","received_events_url":"https://api.github.com/users/riboseinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riboseinc/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/riboseinc/openssl","forks_url":"https://api.github.com/repos/riboseinc/openssl/forks","keys_url":"https://api.github.com/repos/riboseinc/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riboseinc/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riboseinc/openssl/teams","hooks_url":"https://api.github.com/repos/riboseinc/openssl/hooks","issue_events_url":"https://api.github.com/repos/riboseinc/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/riboseinc/openssl/events","assignees_url":"https://api.github.com/repos/riboseinc/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/riboseinc/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/riboseinc/openssl/tags","blobs_url":"https://api.github.com/repos/riboseinc/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riboseinc/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riboseinc/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/riboseinc/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riboseinc/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/riboseinc/openssl/languages","stargazers_url":"https://api.github.com/repos/riboseinc/openssl/stargazers","contributors_url":"https://api.github.com/repos/riboseinc/openssl/contributors","subscribers_url":"https://api.github.com/repos/riboseinc/openssl/subscribers","subscription_url":"https://api.github.com/repos/riboseinc/openssl/subscription","commits_url":"https://api.github.com/repos/riboseinc/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/riboseinc/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/riboseinc/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/riboseinc/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/riboseinc/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/riboseinc/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riboseinc/openssl/merges","archive_url":"https://api.github.com/repos/riboseinc/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riboseinc/openssl/downloads","issues_url":"https://api.github.com/repos/riboseinc/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/riboseinc/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/riboseinc/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/riboseinc/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riboseinc/openssl/labels{/name}","releases_url":"https://api.github.com/repos/riboseinc/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/riboseinc/openssl/deployments","created_at":"2017-09-19T01:18:56Z","updated_at":"2018-05-17T20:11:49Z","pushed_at":"2018-07-23T21:47:46Z","git_url":"git://github.com/riboseinc/openssl.git","ssh_url":"git@github.com:riboseinc/openssl.git","clone_url":"https://github.com/riboseinc/openssl.git","svn_url":"https://github.com/riboseinc/openssl","homepage":"https://www.openssl.org","size":147653,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"c5d1fb78fd0fdbe1f1e61211bd56192a0f95bc91","user":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"node_id":"MDEwOlJlcG9zaXRvcnk3NjM0Njc3","name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzkxMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-07-23T19:46:06Z","pushed_at":"2018-07-23T22:07:23Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":150984,"stargazers_count":7640,"watchers_count":7640,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3624,"mirror_url":null,"archived":false,"open_issues_count":412,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3624,"open_issues":412,"watchers":7640,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6757"},"html":{"href":"https://github.com/openssl/openssl/pull/6757"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/6757"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/6757/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6757/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6757/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/35ad78f07b4af2b4b902bd2245c49c2cd9f25bb0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"randombit"}}