{"action":"created","issue":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/issues/118","repository_url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx","labels_url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/issues/118/comments","events_url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/issues/118/events","html_url":"https://github.com/ethereumjs/ethereumjs-tx/pull/118","id":344176189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjMzNDI1","number":118,"title":"Fix #113 (signed FakeTransaction)","user":{"login":"ajhodges","id":856738,"node_id":"MDQ6VXNlcjg1NjczOA==","avatar_url":"https://avatars2.githubusercontent.com/u/856738?v=4","gravatar_id":"","url":"https://api.github.com/users/ajhodges","html_url":"https://github.com/ajhodges","followers_url":"https://api.github.com/users/ajhodges/followers","following_url":"https://api.github.com/users/ajhodges/following{/other_user}","gists_url":"https://api.github.com/users/ajhodges/gists{/gist_id}","starred_url":"https://api.github.com/users/ajhodges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajhodges/subscriptions","organizations_url":"https://api.github.com/users/ajhodges/orgs","repos_url":"https://api.github.com/users/ajhodges/repos","events_url":"https://api.github.com/users/ajhodges/events{/privacy}","received_events_url":"https://api.github.com/users/ajhodges/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-24T19:41:01Z","updated_at":"2018-07-25T09:10:06Z","closed_at":"2018-07-25T08:45:58Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/pulls/118","html_url":"https://github.com/ethereumjs/ethereumjs-tx/pull/118","diff_url":"https://github.com/ethereumjs/ethereumjs-tx/pull/118.diff","patch_url":"https://github.com/ethereumjs/ethereumjs-tx/pull/118.patch"},"body":"Also serves as a contribution towards #114 .\r\n\r\nThis issue, discussed in #113, has a simple fix; a null check on the `from` setter. The bug is that if `self._from` is initialized to `ethereumjs-util.toBuffer(null)`, it will contain a buffer object that represents '0'. Then if you call `FakeTransaction.from`, the getter will return that empty buffer object here (in `getSenderAddress()`):\r\n```\r\nif (this._from) {\r\n  return this._from\r\n}\r\n```\r\n\r\nThis issue is currently preventing self-signed transactions from being submitted to ganache."},"comment":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/issues/comments/407687964","html_url":"https://github.com/ethereumjs/ethereumjs-tx/pull/118#issuecomment-407687964","issue_url":"https://api.github.com/repos/ethereumjs/ethereumjs-tx/issues/118","id":407687964,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzY4Nzk2NA==","user":{"login":"holgerd77","id":931137,"node_id":"MDQ6VXNlcjkzMTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/931137?v=4","gravatar_id":"","url":"https://api.github.com/users/holgerd77","html_url":"https://github.com/holgerd77","followers_url":"https://api.github.com/users/holgerd77/followers","following_url":"https://api.github.com/users/holgerd77/following{/other_user}","gists_url":"https://api.github.com/users/holgerd77/gists{/gist_id}","starred_url":"https://api.github.com/users/holgerd77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holgerd77/subscriptions","organizations_url":"https://api.github.com/users/holgerd77/orgs","repos_url":"https://api.github.com/users/holgerd77/repos","events_url":"https://api.github.com/users/holgerd77/events{/privacy}","received_events_url":"https://api.github.com/users/holgerd77/received_events","type":"User","site_admin":false},"created_at":"2018-07-25T09:10:06Z","updated_at":"2018-07-25T09:10:06Z","author_association":"MEMBER","body":"Released this as [v1.3.7](https://github.com/ethereumjs/ethereumjs-tx/releases/tag/v1.3.7)."}}
{"actor":{"display_login":"holgerd77"}}