{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments/202156173","pull_request_review_id":136800413,"id":202156173,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjE1NjE3Mw==","diff_hunk":"@@ -33,6 +33,35 @@ public override Property Add(Property item)\n             return result;\n         }\n \n+        private List<CompositeTypeTS> polymorphicUnionCases;","path":"src/vanilla/Model/CompositeTypeTS.cs","position":4,"original_position":4,"commit_id":"c74b9098b8b461a8bf3dff06376f7cbe471ba5b5","original_commit_id":"c74b9098b8b461a8bf3dff06376f7cbe471ba5b5","user":{"login":"RikkiGibson","id":5833655,"node_id":"MDQ6VXNlcjU4MzM2NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"body":"It can be an array. We can convey even more that you're not meant to overwrite values in the array by using `IReadOnlyList`. I just want to avoid repeated execution of the query through multiple usages of `ReferenceName`.","created_at":"2018-07-12T19:43:30Z","updated_at":"2018-07-12T19:43:30Z","html_url":"https://github.com/Azure/autorest.typescript/pull/204#discussion_r202156173","pull_request_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments/202156173"},"html":{"href":"https://github.com/Azure/autorest.typescript/pull/204#discussion_r202156173"},"pull_request":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204"}},"in_reply_to_id":202149387},"pull_request":{"url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204","id":201092489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDkyNDg5","html_url":"https://github.com/Azure/autorest.typescript/pull/204","diff_url":"https://github.com/Azure/autorest.typescript/pull/204.diff","patch_url":"https://github.com/Azure/autorest.typescript/pull/204.patch","issue_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/204","number":204,"state":"open","locked":false,"title":"Polymorphic interfaces","user":{"login":"RikkiGibson","id":5833655,"node_id":"MDQ6VXNlcjU4MzM2NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"body":"Fixes Azure/azure-sdk-for-node#2960\r\n\r\nWe're not 100% sure this is the approach we want, but we have played with a bunch of different possible representations and this so far seems to have the best editor experience.","created_at":"2018-07-12T18:48:02Z","updated_at":"2018-07-12T19:43:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3140404941a76474dac5c5319d24084838f8131","assignee":null,"assignees":[],"requested_reviewers":[{"login":"amarzavery","id":4521223,"node_id":"MDQ6VXNlcjQ1MjEyMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4521223?v=4","gravatar_id":"","url":"https://api.github.com/users/amarzavery","html_url":"https://github.com/amarzavery","followers_url":"https://api.github.com/users/amarzavery/followers","following_url":"https://api.github.com/users/amarzavery/following{/other_user}","gists_url":"https://api.github.com/users/amarzavery/gists{/gist_id}","starred_url":"https://api.github.com/users/amarzavery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarzavery/subscriptions","organizations_url":"https://api.github.com/users/amarzavery/orgs","repos_url":"https://api.github.com/users/amarzavery/repos","events_url":"https://api.github.com/users/amarzavery/events{/privacy}","received_events_url":"https://api.github.com/users/amarzavery/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":874065322,"node_id":"MDU6TGFiZWw4NzQwNjUzMjI=","url":"https://api.github.com/repos/Azure/autorest.typescript/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204/commits","review_comments_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204/comments","review_comment_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/204/comments","statuses_url":"https://api.github.com/repos/Azure/autorest.typescript/statuses/c74b9098b8b461a8bf3dff06376f7cbe471ba5b5","head":{"label":"Azure:PolymorphicInterfaces","ref":"PolymorphicInterfaces","sha":"c74b9098b8b461a8bf3dff06376f7cbe471ba5b5","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":101261687,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjE2ODc=","name":"autorest.typescript","full_name":"Azure/autorest.typescript","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest.typescript","description":"Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.","fork":false,"url":"https://api.github.com/repos/Azure/autorest.typescript","forks_url":"https://api.github.com/repos/Azure/autorest.typescript/forks","keys_url":"https://api.github.com/repos/Azure/autorest.typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest.typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest.typescript/teams","hooks_url":"https://api.github.com/repos/Azure/autorest.typescript/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest.typescript/events","assignees_url":"https://api.github.com/repos/Azure/autorest.typescript/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest.typescript/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest.typescript/tags","blobs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest.typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest.typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest.typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest.typescript/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest.typescript/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest.typescript/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest.typescript/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest.typescript/subscription","commits_url":"https://api.github.com/repos/Azure/autorest.typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest.typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest.typescript/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest.typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest.typescript/merges","archive_url":"https://api.github.com/repos/Azure/autorest.typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest.typescript/downloads","issues_url":"https://api.github.com/repos/Azure/autorest.typescript/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest.typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest.typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest.typescript/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest.typescript/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest.typescript/deployments","created_at":"2017-08-24T06:29:08Z","updated_at":"2018-07-12T19:39:03Z","pushed_at":"2018-07-12T19:39:06Z","git_url":"git://github.com/Azure/autorest.typescript.git","ssh_url":"git@github.com:Azure/autorest.typescript.git","clone_url":"https://github.com/Azure/autorest.typescript.git","svn_url":"https://github.com/Azure/autorest.typescript","homepage":"","size":4316,"stargazers_count":18,"watchers_count":18,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":25,"watchers":18,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"125e600cd2850bca6a181fb97953be869ce2612c","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":101261687,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjE2ODc=","name":"autorest.typescript","full_name":"Azure/autorest.typescript","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest.typescript","description":"Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.","fork":false,"url":"https://api.github.com/repos/Azure/autorest.typescript","forks_url":"https://api.github.com/repos/Azure/autorest.typescript/forks","keys_url":"https://api.github.com/repos/Azure/autorest.typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest.typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest.typescript/teams","hooks_url":"https://api.github.com/repos/Azure/autorest.typescript/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest.typescript/events","assignees_url":"https://api.github.com/repos/Azure/autorest.typescript/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest.typescript/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest.typescript/tags","blobs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest.typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest.typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest.typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest.typescript/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest.typescript/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest.typescript/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest.typescript/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest.typescript/subscription","commits_url":"https://api.github.com/repos/Azure/autorest.typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest.typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest.typescript/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest.typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest.typescript/merges","archive_url":"https://api.github.com/repos/Azure/autorest.typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest.typescript/downloads","issues_url":"https://api.github.com/repos/Azure/autorest.typescript/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest.typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest.typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest.typescript/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest.typescript/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest.typescript/deployments","created_at":"2017-08-24T06:29:08Z","updated_at":"2018-07-12T19:39:03Z","pushed_at":"2018-07-12T19:39:06Z","git_url":"git://github.com/Azure/autorest.typescript.git","ssh_url":"git@github.com:Azure/autorest.typescript.git","clone_url":"https://github.com/Azure/autorest.typescript.git","svn_url":"https://github.com/Azure/autorest.typescript","homepage":"","size":4316,"stargazers_count":18,"watchers_count":18,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":9,"open_issues":25,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204"},"html":{"href":"https://github.com/Azure/autorest.typescript/pull/204"},"issue":{"href":"https://api.github.com/repos/Azure/autorest.typescript/issues/204"},"comments":{"href":"https://api.github.com/repos/Azure/autorest.typescript/issues/204/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/204/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/autorest.typescript/statuses/c74b9098b8b461a8bf3dff06376f7cbe471ba5b5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RikkiGibson"}}