{"action":"created","issue":{"url":"https://api.github.com/repos/unee-t/frontend/issues/637","repository_url":"https://api.github.com/repos/unee-t/frontend","labels_url":"https://api.github.com/repos/unee-t/frontend/issues/637/labels{/name}","comments_url":"https://api.github.com/repos/unee-t/frontend/issues/637/comments","events_url":"https://api.github.com/repos/unee-t/frontend/issues/637/events","html_url":"https://github.com/unee-t/frontend/pull/637","id":379610328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDEwNDIw","number":637,"title":"Change IR logo","user":{"login":"nbiton","id":2662819,"node_id":"MDQ6VXNlcjI2NjI4MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2662819?v=4","gravatar_id":"","url":"https://api.github.com/users/nbiton","html_url":"https://github.com/nbiton","followers_url":"https://api.github.com/users/nbiton/followers","following_url":"https://api.github.com/users/nbiton/following{/other_user}","gists_url":"https://api.github.com/users/nbiton/gists{/gist_id}","starred_url":"https://api.github.com/users/nbiton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbiton/subscriptions","organizations_url":"https://api.github.com/users/nbiton/orgs","repos_url":"https://api.github.com/users/nbiton/repos","events_url":"https://api.github.com/users/nbiton/events{/privacy}","received_events_url":"https://api.github.com/users/nbiton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2018-11-12T03:50:26Z","updated_at":"2018-11-23T05:53:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/unee-t/frontend/pulls/637","html_url":"https://github.com/unee-t/frontend/pull/637","diff_url":"https://github.com/unee-t/frontend/pull/637.diff","patch_url":"https://github.com/unee-t/frontend/pull/637.patch"},"body":"Stuff that already works:\r\n* Marking appears over default logo\r\n* Clicking the marking makes the \"add logo\" button appear.\r\n* The dialog to change the logo appears when clicking that button\r\n* The dialog allows for logo selection and preview.\r\n\r\nActually changing the logo on the report is still WIP.\r\n\r\nThis PR is based off #636 and shouldn't be merged until it's merged"},"comment":{"url":"https://api.github.com/repos/unee-t/frontend/issues/comments/441160777","html_url":"https://github.com/unee-t/frontend/pull/637#issuecomment-441160777","issue_url":"https://api.github.com/repos/unee-t/frontend/issues/637","id":441160777,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTE2MDc3Nw==","user":{"login":"yvonnechia","id":43780040,"node_id":"MDQ6VXNlcjQzNzgwMDQw","avatar_url":"https://avatars1.githubusercontent.com/u/43780040?v=4","gravatar_id":"","url":"https://api.github.com/users/yvonnechia","html_url":"https://github.com/yvonnechia","followers_url":"https://api.github.com/users/yvonnechia/followers","following_url":"https://api.github.com/users/yvonnechia/following{/other_user}","gists_url":"https://api.github.com/users/yvonnechia/gists{/gist_id}","starred_url":"https://api.github.com/users/yvonnechia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvonnechia/subscriptions","organizations_url":"https://api.github.com/users/yvonnechia/orgs","repos_url":"https://api.github.com/users/yvonnechia/repos","events_url":"https://api.github.com/users/yvonnechia/events{/privacy}","received_events_url":"https://api.github.com/users/yvonnechia/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T05:53:59Z","updated_at":"2018-11-23T05:53:59Z","author_association":"NONE","body":"\r\n\r\n\r\n> I think the \"Reset to default\" that's in the 3rd screen is misplaced, as it doesn't really serve the same function you see in the 4th screen.\r\n> The 3rd screen is only showing a preview of the custom logo **before** it was confirmed and saved. There's no need to \"Reset to default\" a preview.\r\n> \r\n> Also, I suggest rewording \"Upload another\" to \"Replace\", as \"Upload another\" suggests you can upload multiple files to be used simultaneously.\r\n\r\nYes that makes sense. Thanks! Made some tweaks accordingly. \r\n\r\n![add logo flow with reset 2](https://user-images.githubusercontent.com/43780040/48929844-319dfa80-ef27-11e8-9284-27432eb04c06.png)\r\n"}}
{"actor":{"display_login":"yvonnechia"}}