{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/14237","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/14237/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/14237/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/14237/events","html_url":"https://github.com/xbmc/xbmc/pull/14237","id":345456768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTk3ODE3","number":14237,"title":"[addons] Update XSD schemas","user":{"login":"enen92","id":7375276,"node_id":"MDQ6VXNlcjczNzUyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7375276?v=4","gravatar_id":"","url":"https://api.github.com/users/enen92","html_url":"https://github.com/enen92","followers_url":"https://api.github.com/users/enen92/followers","following_url":"https://api.github.com/users/enen92/following{/other_user}","gists_url":"https://api.github.com/users/enen92/gists{/gist_id}","starred_url":"https://api.github.com/users/enen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enen92/subscriptions","organizations_url":"https://api.github.com/users/enen92/orgs","repos_url":"https://api.github.com/users/enen92/repos","events_url":"https://api.github.com/users/enen92/events{/privacy}","received_events_url":"https://api.github.com/users/enen92/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-28T15:27:59Z","updated_at":"2018-07-28T20:30:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/14237","html_url":"https://github.com/xbmc/xbmc/pull/14237","diff_url":"https://github.com/xbmc/xbmc/pull/14237.diff","patch_url":"https://github.com/xbmc/xbmc/pull/14237.patch"},"body":"## Description\r\nKodi has evolved and new elements such as `<reuselanguageinvoker>`, `<news>` and `<assets>` are now available for addon authors to use. However, XSD schemas have not follow the new additions and are sort of incomplete. This PR attempts to add those missing elements and attributes and tries to restrict values whenever possible.\r\n\r\n## Motivation and Context\r\nAs part of GSOC addon-check project (https://github.com/xbmc/addon-check/pull/35) we plan to use those schemas to validate addon.xml files for addons submitted to the repository. It would be awesome if those schemas could also be maintained when things change. \r\n\r\n## How Has This Been Tested?\r\nCompiled (just for the sake of it). Validated a few addons in our repo using the addon-check tool.\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] **Bug fix** (non-breaking change which fixes an issue)\r\n- [ ] **Clean up** (non-breaking change which removes non-working, unmaintained functionality)\r\n- [X] **Improvement** (non-breaking change which improves existing functionality)\r\n- [ ] **New feature** (non-breaking change which adds functionality)\r\n- [ ] **Breaking change** (fix or feature that will cause existing functionality to change)\r\n- [X] **Cosmetic change** (non-breaking change that doesn't touch code)\r\n- [ ] **None of the above** (please explain below)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `X` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the **[Code Guidelines](https://github.com/xbmc/xbmc/blob/master/docs/CODE_GUIDELINES.md)** of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [ ] I have read the **[Contributing](https://github.com/xbmc/xbmc/blob/master/docs/CONTRIBUTING.md)** document\r\n- [ ] I have added tests to cover my change\r\n- [X] All new and existing tests passed\r\n\r\n@Rechi, @tamland, @Razzeee for review\r\n@garbear: can you confirm the controller.xsd change?\r\n@ronie: can you take a look at the resource.images addon changes?"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/408633058","html_url":"https://github.com/xbmc/xbmc/pull/14237#issuecomment-408633058","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/14237","id":408633058,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODYzMzA1OA==","user":{"login":"enen92","id":7375276,"node_id":"MDQ6VXNlcjczNzUyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7375276?v=4","gravatar_id":"","url":"https://api.github.com/users/enen92","html_url":"https://github.com/enen92","followers_url":"https://api.github.com/users/enen92/followers","following_url":"https://api.github.com/users/enen92/following{/other_user}","gists_url":"https://api.github.com/users/enen92/gists{/gist_id}","starred_url":"https://api.github.com/users/enen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enen92/subscriptions","organizations_url":"https://api.github.com/users/enen92/orgs","repos_url":"https://api.github.com/users/enen92/repos","events_url":"https://api.github.com/users/enen92/events{/privacy}","received_events_url":"https://api.github.com/users/enen92/received_events","type":"User","site_admin":false},"created_at":"2018-07-28T20:30:00Z","updated_at":"2018-07-28T20:30:00Z","author_association":"CONTRIBUTOR","body":"yeah that's what I assumed. Dropped that change, thanks for looking."}}
{"actor":{"display_login":"enen92"}}