{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24851","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24851/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24851/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24851/events","html_url":"https://github.com/cockroachdb/cockroach/pull/24851","id":314837587,"number":24851,"title":"opt: Fix various name resolution bugs in optimizer","user":{"login":"rytaft","id":3288732,"avatar_url":"https://avatars2.githubusercontent.com/u/3288732?v=4","gravatar_id":"","url":"https://api.github.com/users/rytaft","html_url":"https://github.com/rytaft","followers_url":"https://api.github.com/users/rytaft/followers","following_url":"https://api.github.com/users/rytaft/following{/other_user}","gists_url":"https://api.github.com/users/rytaft/gists{/gist_id}","starred_url":"https://api.github.com/users/rytaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rytaft/subscriptions","organizations_url":"https://api.github.com/users/rytaft/orgs","repos_url":"https://api.github.com/users/rytaft/repos","events_url":"https://api.github.com/users/rytaft/events{/privacy}","received_events_url":"https://api.github.com/users/rytaft/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-04-16T22:15:47Z","updated_at":"2018-04-25T17:33:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24851","html_url":"https://github.com/cockroachdb/cockroach/pull/24851","diff_url":"https://github.com/cockroachdb/cockroach/pull/24851.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/24851.patch"},"body":"This commit fixes a couple of bugs in the optbuilder:\r\n\r\n(1) The optbuilder was incorrectly allowing queries such\r\n    as `SELECT * from a, a`. This query now throws the error:\r\n    `cannot join columns from the same source name \"a\"`\r\n    `(missing AS clause)`.\r\n\r\n(2) The optbuilder was incorrectly causing an error for\r\n    queries such as `SELECT t.kv.k FROM kv` when the current\r\n    database was set to t. This is now fixed.\r\n\r\nIn order to test the fix to these bugs and add other test cases,\r\nthis commit also improves the optimizer test infrastructure to\r\nqualify table names with the schema and catalog.\r\n\r\nThis commit also adds additional test cases identified by\r\n@knz in a document he created describing tricky semantic\r\nanalysis functionality in CockroachDB.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/384370305","html_url":"https://github.com/cockroachdb/cockroach/pull/24851#issuecomment-384370305","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24851","id":384370305,"user":{"login":"rytaft","id":3288732,"avatar_url":"https://avatars2.githubusercontent.com/u/3288732?v=4","gravatar_id":"","url":"https://api.github.com/users/rytaft","html_url":"https://github.com/rytaft","followers_url":"https://api.github.com/users/rytaft/followers","following_url":"https://api.github.com/users/rytaft/following{/other_user}","gists_url":"https://api.github.com/users/rytaft/gists{/gist_id}","starred_url":"https://api.github.com/users/rytaft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rytaft/subscriptions","organizations_url":"https://api.github.com/users/rytaft/orgs","repos_url":"https://api.github.com/users/rytaft/repos","events_url":"https://api.github.com/users/rytaft/events{/privacy}","received_events_url":"https://api.github.com/users/rytaft/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T17:33:50Z","updated_at":"2018-04-25T17:33:50Z","author_association":"CONTRIBUTOR","body":"bors r+\n\n---\n\nReview status: 11 of 31 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/cockroachdb/cockroach/24851#-:-LAxrWcq7gV3TzILSoxi:b-ydi9ay)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"rytaft"}}