{"action":"created","issue":{"url":"https://api.github.com/repos/alexfernandez/elyxer/issues/10","repository_url":"https://api.github.com/repos/alexfernandez/elyxer","labels_url":"https://api.github.com/repos/alexfernandez/elyxer/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/alexfernandez/elyxer/issues/10/comments","events_url":"https://api.github.com/repos/alexfernandez/elyxer/issues/10/events","html_url":"https://github.com/alexfernandez/elyxer/pull/10","id":389160916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjEyODkz","number":10,"title":"Makes tables embedded in columns display better","user":{"login":"paeony","id":4705381,"node_id":"MDQ6VXNlcjQ3MDUzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4705381?v=4","gravatar_id":"","url":"https://api.github.com/users/paeony","html_url":"https://github.com/paeony","followers_url":"https://api.github.com/users/paeony/followers","following_url":"https://api.github.com/users/paeony/following{/other_user}","gists_url":"https://api.github.com/users/paeony/gists{/gist_id}","starred_url":"https://api.github.com/users/paeony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paeony/subscriptions","organizations_url":"https://api.github.com/users/paeony/orgs","repos_url":"https://api.github.com/users/paeony/repos","events_url":"https://api.github.com/users/paeony/events{/privacy}","received_events_url":"https://api.github.com/users/paeony/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-10T06:41:15Z","updated_at":"2018-12-11T22:46:45Z","closed_at":"2018-12-11T22:42:33Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alexfernandez/elyxer/pulls/10","html_url":"https://github.com/alexfernandez/elyxer/pull/10","diff_url":"https://github.com/alexfernandez/elyxer/pull/10.diff","patch_url":"https://github.com/alexfernandez/elyxer/pull/10.patch"},"body":"I promised to submit this PR almost two years ago and finally got around to it. I left out overflows-x because I don't have the time to test it to my satisfaction. Details below:\r\nIn elyxer's css that table display value is set to inline-table. The browser then creates a new rendering box within the parent box and render the table inside of the inner box.\r\n\r\nThe reason I care is because wordpress themes like to display content inside of a column whose width is flexible up to a maximum. So the column is the outer box and then a new inner box is created for the table. It makes the table look almost quoted.\r\n\r\nThe problem is that for some reason the browsers get stupid when set to inline table. They don't at all consider the size of the outer box (the column). So the table gets rendered in the inline table \"inner box\" without any kind of adaptive logic. Inevitably the table is too big to fit in the column (the outer box) and gets cut off.\r\n\r\nBut if I switch the display.table to block instead of inline-table then the table is rendered within the column and is aware of the column's width and adaptively renders the table to fit in that width if reasonably possible.\r\n\r\nI actually throw in overflow-x set to auto to handle cases where the table is just way too big to fit in the column, in that case it will create a horizontal scroll bar.\r\n\r\nI'm wondering if given how modern HTML rendering systems work if it wouldn't make more sense to change elyxer's table.display to block? I realize this isn't exactly how LYX would render it since tables tend to be indented.\r\n\r\nIt's not a big deal for me as I have my own copy of elyxer's css and just edited it. But I bet this would save a lot of frustration for other people."},"comment":{"url":"https://api.github.com/repos/alexfernandez/elyxer/issues/comments/446391956","html_url":"https://github.com/alexfernandez/elyxer/pull/10#issuecomment-446391956","issue_url":"https://api.github.com/repos/alexfernandez/elyxer/issues/10","id":446391956,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjM5MTk1Ng==","user":{"login":"alexfernandez","id":876570,"node_id":"MDQ6VXNlcjg3NjU3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/876570?v=4","gravatar_id":"","url":"https://api.github.com/users/alexfernandez","html_url":"https://github.com/alexfernandez","followers_url":"https://api.github.com/users/alexfernandez/followers","following_url":"https://api.github.com/users/alexfernandez/following{/other_user}","gists_url":"https://api.github.com/users/alexfernandez/gists{/gist_id}","starred_url":"https://api.github.com/users/alexfernandez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexfernandez/subscriptions","organizations_url":"https://api.github.com/users/alexfernandez/orgs","repos_url":"https://api.github.com/users/alexfernandez/repos","events_url":"https://api.github.com/users/alexfernandez/events{/privacy}","received_events_url":"https://api.github.com/users/alexfernandez/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T22:46:45Z","updated_at":"2018-12-11T22:46:45Z","author_association":"OWNER","body":"It is too hard to publish a new version since the changelog would require an old version of eLyXer, sorry."}}
{"actor":{"display_login":"alexfernandez"}}