{"action":"created","issue":{"url":"https://api.github.com/repos/singularityware/singularity/issues/1598","repository_url":"https://api.github.com/repos/singularityware/singularity","labels_url":"https://api.github.com/repos/singularityware/singularity/issues/1598/labels{/name}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/1598/comments","events_url":"https://api.github.com/repos/singularityware/singularity/issues/1598/events","html_url":"https://github.com/singularityware/singularity/pull/1598","id":326322810,"number":1598,"title":"Remove environment.tar","user":{"login":"tri-adam","id":9903835,"avatar_url":"https://avatars2.githubusercontent.com/u/9903835?v=4","gravatar_id":"","url":"https://api.github.com/users/tri-adam","html_url":"https://github.com/tri-adam","followers_url":"https://api.github.com/users/tri-adam/followers","following_url":"https://api.github.com/users/tri-adam/following{/other_user}","gists_url":"https://api.github.com/users/tri-adam/gists{/gist_id}","starred_url":"https://api.github.com/users/tri-adam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tri-adam/subscriptions","organizations_url":"https://api.github.com/users/tri-adam/orgs","repos_url":"https://api.github.com/users/tri-adam/repos","events_url":"https://api.github.com/users/tri-adam/events{/privacy}","received_events_url":"https://api.github.com/users/tri-adam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tri-adam","id":9903835,"avatar_url":"https://avatars2.githubusercontent.com/u/9903835?v=4","gravatar_id":"","url":"https://api.github.com/users/tri-adam","html_url":"https://github.com/tri-adam","followers_url":"https://api.github.com/users/tri-adam/followers","following_url":"https://api.github.com/users/tri-adam/following{/other_user}","gists_url":"https://api.github.com/users/tri-adam/gists{/gist_id}","starred_url":"https://api.github.com/users/tri-adam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tri-adam/subscriptions","organizations_url":"https://api.github.com/users/tri-adam/orgs","repos_url":"https://api.github.com/users/tri-adam/repos","events_url":"https://api.github.com/users/tri-adam/events{/privacy}","received_events_url":"https://api.github.com/users/tri-adam/received_events","type":"User","site_admin":false},"assignees":[{"login":"tri-adam","id":9903835,"avatar_url":"https://avatars2.githubusercontent.com/u/9903835?v=4","gravatar_id":"","url":"https://api.github.com/users/tri-adam","html_url":"https://github.com/tri-adam","followers_url":"https://api.github.com/users/tri-adam/followers","following_url":"https://api.github.com/users/tri-adam/following{/other_user}","gists_url":"https://api.github.com/users/tri-adam/gists{/gist_id}","starred_url":"https://api.github.com/users/tri-adam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tri-adam/subscriptions","organizations_url":"https://api.github.com/users/tri-adam/orgs","repos_url":"https://api.github.com/users/tri-adam/repos","events_url":"https://api.github.com/users/tri-adam/events{/privacy}","received_events_url":"https://api.github.com/users/tri-adam/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-24T22:46:31Z","updated_at":"2018-05-25T15:57:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/1598","html_url":"https://github.com/singularityware/singularity/pull/1598","diff_url":"https://github.com/singularityware/singularity/pull/1598.diff","patch_url":"https://github.com/singularityware/singularity/pull/1598.patch"},"body":"**Description of the Pull Request (PR):**\r\n\r\nRemove `environment.tar` and instead generate the equivalent files programatically.\r\n\r\nTests have been added for the new environment generation code. I have manually `diff -r`'dd the contents of `environment.tar` against the structure generated by `makeBaseEnv` and verified them to be to be identical.\r\n\r\n**Checkoff for all PRs:**\r\n\r\n- [x] I have read the [Guidelines for Contributing](https://github.com/singularityware/singularity/blob/master/CONTRIBUTING.md), and this PR conforms to the stated requirements.\r\n- [ ] I have added changes to the [CHANGELOG](https://github.com/singularityware/singularity/blob/development/CHANGELOG.md) and and documentation updates to the [singularityware](https://www.github.com/singularityware/singularityware.github.io) documentation base.\r\n- [x] I have tested this PR locally with a `make test`\r\n- [x] This PR is NOT against the project's master branch\r\n- [x] I have added myself as a contributor to the [contributors's file](https://github.com/singularityware/singularity/blob/master/CONTRIBUTORS.md)\r\n- [x] This PR is ready for review and/or merge\r\n\r\nAttn: @singularityware-admin"},"comment":{"url":"https://api.github.com/repos/singularityware/singularity/issues/comments/392103059","html_url":"https://github.com/singularityware/singularity/pull/1598#issuecomment-392103059","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/1598","id":392103059,"user":{"login":"bauerm97","id":14863407,"avatar_url":"https://avatars3.githubusercontent.com/u/14863407?v=4","gravatar_id":"","url":"https://api.github.com/users/bauerm97","html_url":"https://github.com/bauerm97","followers_url":"https://api.github.com/users/bauerm97/followers","following_url":"https://api.github.com/users/bauerm97/following{/other_user}","gists_url":"https://api.github.com/users/bauerm97/gists{/gist_id}","starred_url":"https://api.github.com/users/bauerm97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bauerm97/subscriptions","organizations_url":"https://api.github.com/users/bauerm97/orgs","repos_url":"https://api.github.com/users/bauerm97/repos","events_url":"https://api.github.com/users/bauerm97/events{/privacy}","received_events_url":"https://api.github.com/users/bauerm97/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T15:57:23Z","updated_at":"2018-05-25T15:57:23Z","author_association":"MEMBER","body":"@dctrud We are going to merge this PR now, and @tri-adam will make a note for us to circle back to your comments a bit further down the line. For now this is a good starting point and will solve some headaches for external projects."}}
{"actor":{"display_login":"bauerm97"}}