{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/217144699","pull_request_review_id":154787303,"id":217144699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE0NDY5OQ==","diff_hunk":"@@ -9,6 +9,24 @@\n       group: \"ceph\"\n       mode: \"0755\"\n \n+  - name: count number of osds for non-lvm scenario\n+    set_fact:\n+      num_osds: \"{{ devices | length }}\"\n+    when:\n+      - devices|length > 0 and (osd_scenario == 'collocated' or osd_scenario == 'non-collocated')\n+\n+  - name: count number of osds for lvm scenario\n+    set_fact:\n+      num_osds: \"{{ lvm_volumes | length }}\"\n+    when:\n+      - lvm_volumes|length > 0 and osd_scenario == 'lvm'\n+\n+  - name: count number of osds for lvm-batch scenario\n+    set_fact:\n+      num_osds: \"{{ (ceph-volume lvm batch --report devices | from_json()).osds | length }}\"","path":"roles/ceph-config/tasks/main.yml","position":18,"original_position":18,"commit_id":"3ad9c0716271ee0bf9f53db419fbff1dc42e9b9a","original_commit_id":"3ad9c0716271ee0bf9f53db419fbff1dc42e9b9a","user":{"login":"andrewschoen","id":20618,"node_id":"MDQ6VXNlcjIwNjE4","avatar_url":"https://avatars2.githubusercontent.com/u/20618?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewschoen","html_url":"https://github.com/andrewschoen","followers_url":"https://api.github.com/users/andrewschoen/followers","following_url":"https://api.github.com/users/andrewschoen/following{/other_user}","gists_url":"https://api.github.com/users/andrewschoen/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewschoen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewschoen/subscriptions","organizations_url":"https://api.github.com/users/andrewschoen/orgs","repos_url":"https://api.github.com/users/andrewschoen/repos","events_url":"https://api.github.com/users/andrewschoen/events{/privacy}","received_events_url":"https://api.github.com/users/andrewschoen/received_events","type":"User","site_admin":false},"body":"the ``ceph-volume lvm batch --report`` will need to be run in a separate task using the command module, with the output from the command being registered into a variable. Then that variable can be used here to set the ``num_osds`` fact.","created_at":"2018-09-12T18:39:02Z","updated_at":"2018-09-12T18:39:24Z","html_url":"https://github.com/ceph/ceph-ansible/pull/3113#discussion_r217144699","pull_request_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments/217144699"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/3113#discussion_r217144699"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113","id":215045806,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDQ1ODA2","html_url":"https://github.com/ceph/ceph-ansible/pull/3113","diff_url":"https://github.com/ceph/ceph-ansible/pull/3113.diff","patch_url":"https://github.com/ceph/ceph-ansible/pull/3113.patch","issue_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/3113","number":3113,"state":"open","locked":false,"title":"set osd max memory based on host memory","user":{"login":"neha-ojha","id":15874529,"node_id":"MDQ6VXNlcjE1ODc0NTI5","avatar_url":"https://avatars3.githubusercontent.com/u/15874529?v=4","gravatar_id":"","url":"https://api.github.com/users/neha-ojha","html_url":"https://github.com/neha-ojha","followers_url":"https://api.github.com/users/neha-ojha/followers","following_url":"https://api.github.com/users/neha-ojha/following{/other_user}","gists_url":"https://api.github.com/users/neha-ojha/gists{/gist_id}","starred_url":"https://api.github.com/users/neha-ojha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neha-ojha/subscriptions","organizations_url":"https://api.github.com/users/neha-ojha/orgs","repos_url":"https://api.github.com/users/neha-ojha/repos","events_url":"https://api.github.com/users/neha-ojha/events{/privacy}","received_events_url":"https://api.github.com/users/neha-ojha/received_events","type":"User","site_admin":false},"body":"This PR addresses https://bugzilla.redhat.com/show_bug.cgi?id=1595003 by adding an `osd_memory_target` option to ceph-ansible.\r\n\r\n\r\nSigned-off-by: Neha Ojha <nojha@redhat.com>","created_at":"2018-09-12T17:54:06Z","updated_at":"2018-09-12T18:39:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a11c95442cfa3d6770d5f0a98ebba8afcf13281a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alfredodeza","id":317847,"node_id":"MDQ6VXNlcjMxNzg0Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/317847?v=4","gravatar_id":"","url":"https://api.github.com/users/alfredodeza","html_url":"https://github.com/alfredodeza","followers_url":"https://api.github.com/users/alfredodeza/followers","following_url":"https://api.github.com/users/alfredodeza/following{/other_user}","gists_url":"https://api.github.com/users/alfredodeza/gists{/gist_id}","starred_url":"https://api.github.com/users/alfredodeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfredodeza/subscriptions","organizations_url":"https://api.github.com/users/alfredodeza/orgs","repos_url":"https://api.github.com/users/alfredodeza/repos","events_url":"https://api.github.com/users/alfredodeza/events{/privacy}","received_events_url":"https://api.github.com/users/alfredodeza/received_events","type":"User","site_admin":false},{"login":"guits","id":3717838,"node_id":"MDQ6VXNlcjM3MTc4Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/3717838?v=4","gravatar_id":"","url":"https://api.github.com/users/guits","html_url":"https://github.com/guits","followers_url":"https://api.github.com/users/guits/followers","following_url":"https://api.github.com/users/guits/following{/other_user}","gists_url":"https://api.github.com/users/guits/gists{/gist_id}","starred_url":"https://api.github.com/users/guits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guits/subscriptions","organizations_url":"https://api.github.com/users/guits/orgs","repos_url":"https://api.github.com/users/guits/repos","events_url":"https://api.github.com/users/guits/events{/privacy}","received_events_url":"https://api.github.com/users/guits/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/3113/comments","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/3ad9c0716271ee0bf9f53db419fbff1dc42e9b9a","head":{"label":"neha-ojha:wip-trial","ref":"wip-trial","sha":"3ad9c0716271ee0bf9f53db419fbff1dc42e9b9a","user":{"login":"neha-ojha","id":15874529,"node_id":"MDQ6VXNlcjE1ODc0NTI5","avatar_url":"https://avatars3.githubusercontent.com/u/15874529?v=4","gravatar_id":"","url":"https://api.github.com/users/neha-ojha","html_url":"https://github.com/neha-ojha","followers_url":"https://api.github.com/users/neha-ojha/followers","following_url":"https://api.github.com/users/neha-ojha/following{/other_user}","gists_url":"https://api.github.com/users/neha-ojha/gists{/gist_id}","starred_url":"https://api.github.com/users/neha-ojha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neha-ojha/subscriptions","organizations_url":"https://api.github.com/users/neha-ojha/orgs","repos_url":"https://api.github.com/users/neha-ojha/repos","events_url":"https://api.github.com/users/neha-ojha/events{/privacy}","received_events_url":"https://api.github.com/users/neha-ojha/received_events","type":"User","site_admin":false},"repo":{"id":143351888,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzNTE4ODg=","name":"ceph-ansible","full_name":"neha-ojha/ceph-ansible","owner":{"login":"neha-ojha","id":15874529,"node_id":"MDQ6VXNlcjE1ODc0NTI5","avatar_url":"https://avatars3.githubusercontent.com/u/15874529?v=4","gravatar_id":"","url":"https://api.github.com/users/neha-ojha","html_url":"https://github.com/neha-ojha","followers_url":"https://api.github.com/users/neha-ojha/followers","following_url":"https://api.github.com/users/neha-ojha/following{/other_user}","gists_url":"https://api.github.com/users/neha-ojha/gists{/gist_id}","starred_url":"https://api.github.com/users/neha-ojha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neha-ojha/subscriptions","organizations_url":"https://api.github.com/users/neha-ojha/orgs","repos_url":"https://api.github.com/users/neha-ojha/repos","events_url":"https://api.github.com/users/neha-ojha/events{/privacy}","received_events_url":"https://api.github.com/users/neha-ojha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neha-ojha/ceph-ansible","description":"Ansible playbooks to deploy Ceph, the distributed filesystem.","fork":true,"url":"https://api.github.com/repos/neha-ojha/ceph-ansible","forks_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/forks","keys_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/events","assignees_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/merges","archive_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/neha-ojha/ceph-ansible/deployments","created_at":"2018-08-02T22:47:27Z","updated_at":"2018-08-02T22:47:30Z","pushed_at":"2018-09-12T17:20:30Z","git_url":"git://github.com/neha-ojha/ceph-ansible.git","ssh_url":"git@github.com:neha-ojha/ceph-ansible.git","clone_url":"https://github.com/neha-ojha/ceph-ansible.git","svn_url":"https://github.com/neha-ojha/ceph-ansible","homepage":"","size":5175,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"1c88c444a30570dfeacc03a9424a10b088e7b344","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":17373313,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3MzMxMw==","name":"ceph-ansible","full_name":"ceph/ceph-ansible","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph-ansible","description":"Ansible playbooks to deploy Ceph, the distributed filesystem.","fork":false,"url":"https://api.github.com/repos/ceph/ceph-ansible","forks_url":"https://api.github.com/repos/ceph/ceph-ansible/forks","keys_url":"https://api.github.com/repos/ceph/ceph-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph-ansible/teams","hooks_url":"https://api.github.com/repos/ceph/ceph-ansible/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph-ansible/events","assignees_url":"https://api.github.com/repos/ceph/ceph-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph-ansible/tags","blobs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph-ansible/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph-ansible/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph-ansible/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph-ansible/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph-ansible/subscription","commits_url":"https://api.github.com/repos/ceph/ceph-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph-ansible/merges","archive_url":"https://api.github.com/repos/ceph/ceph-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph-ansible/downloads","issues_url":"https://api.github.com/repos/ceph/ceph-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph-ansible/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph-ansible/deployments","created_at":"2014-03-03T17:12:09Z","updated_at":"2018-09-12T04:40:14Z","pushed_at":"2018-09-12T17:54:06Z","git_url":"git://github.com/ceph/ceph-ansible.git","ssh_url":"git@github.com:ceph/ceph-ansible.git","clone_url":"https://github.com/ceph/ceph-ansible.git","svn_url":"https://github.com/ceph/ceph-ansible","homepage":"","size":5292,"stargazers_count":730,"watchers_count":730,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":489,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":489,"open_issues":171,"watchers":730,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113"},"html":{"href":"https://github.com/ceph/ceph-ansible/pull/3113"},"issue":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/3113"},"comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/issues/3113/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph-ansible/pulls/3113/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph-ansible/statuses/3ad9c0716271ee0bf9f53db419fbff1dc42e9b9a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andrewschoen"}}