{"action":"created","issue":{"url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA/issues/567","repository_url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA","labels_url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA/issues/567/labels{/name}","comments_url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA/issues/567/comments","events_url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA/issues/567/events","html_url":"https://github.com/KhronosGroup/OpenCOLLADA/issues/567","id":305605369,"number":567,"title":"Clarification of \"fx_common_color_or_texture_type\" type","user":{"login":"recp","id":1264894,"avatar_url":"https://avatars1.githubusercontent.com/u/1264894?v=4","gravatar_id":"","url":"https://api.github.com/users/recp","html_url":"https://github.com/recp","followers_url":"https://api.github.com/users/recp/followers","following_url":"https://api.github.com/users/recp/following{/other_user}","gists_url":"https://api.github.com/users/recp/gists{/gist_id}","starred_url":"https://api.github.com/users/recp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recp/subscriptions","organizations_url":"https://api.github.com/users/recp/orgs","repos_url":"https://api.github.com/users/recp/repos","events_url":"https://api.github.com/users/recp/events{/privacy}","received_events_url":"https://api.github.com/users/recp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-15T15:37:58Z","updated_at":"2018-03-16T06:56:25Z","closed_at":"2018-03-16T06:56:25Z","author_association":"NONE","body":"Until now, I was assumed that **fx_common_color_or_texture_type** object can only contain COLOR or TEXTURE not both. Is it valid to have both color and texture  in **fx_common_color_or_texture_type** object e.g. **diffuse**, **emission**, **specular**... ?\r\n\r\nIf it is valid to have both then what should render engines do? Should I multiply color with texture like this:\r\n```glsl\r\ndiffuse = diffuse.tex * diffuse.color\r\n``` \r\n\r\nif only one of them can exists then I don't need to do anything because in shader there is something like this:\r\n\r\n```glsl\r\n\\n#ifdef DIFFUSE_TEX\\n\r\nuniform sampler2D uDiffuseTex;\r\n\\n#elif defined(DIFFUSE_COLOR)\\n\r\nuniform vec4      uDiffuse;\r\n\\n#endif\\n\r\n\r\n/* ... */\r\n\r\n\\n#ifdef DIFFUSE_TEX\\n\r\n  diffuse = lightc * texture(uDiffuseTex, DIFFUSE_TEXCOORD) * Ld\r\n\\n#elif defined(DIFFUSE_COLOR)\\n\r\n  diffuse = lightc * uDiffuse * Ld\r\n\\n#else\\n\r\n  diffuse = lightc * vec4(1, 1, 1, 1) * Ld /* default diffuse */\r\n\\n#endif\\n\r\n```\r\n\r\notherwise I need minor changes \r\n\r\nI'm asking this because in glTF both baseColor and baseColorTexture can exists, they are multiplied in shader... \r\n\r\nthanks for clarification"},"comment":{"url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA/issues/comments/373620088","html_url":"https://github.com/KhronosGroup/OpenCOLLADA/issues/567#issuecomment-373620088","issue_url":"https://api.github.com/repos/KhronosGroup/OpenCOLLADA/issues/567","id":373620088,"user":{"login":"recp","id":1264894,"avatar_url":"https://avatars1.githubusercontent.com/u/1264894?v=4","gravatar_id":"","url":"https://api.github.com/users/recp","html_url":"https://github.com/recp","followers_url":"https://api.github.com/users/recp/followers","following_url":"https://api.github.com/users/recp/following{/other_user}","gists_url":"https://api.github.com/users/recp/gists{/gist_id}","starred_url":"https://api.github.com/users/recp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/recp/subscriptions","organizations_url":"https://api.github.com/users/recp/orgs","repos_url":"https://api.github.com/users/recp/repos","events_url":"https://api.github.com/users/recp/events{/privacy}","received_events_url":"https://api.github.com/users/recp/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T06:56:25Z","updated_at":"2018-03-16T06:56:25Z","author_association":"NONE","body":"@mbarnes-sb  thank you"}}
{"actor":{"display_login":"recp"}}