{"action":"created","comment":{"url":"https://api.github.com/repos/electron/electron/pulls/comments/190956251","pull_request_review_id":123444727,"id":190956251,"diff_hunk":"@@ -780,14 +727,15 @@ bool OffScreenRenderWidgetHostView::TransformPointToLocalCoordSpace(\n     gfx::Point* transformed_point) {\n   // Transformations use physical pixels rather than DIP, so conversion\n   // is necessary.\n-  gfx::Point point_in_pixels = gfx::ConvertPointToPixel(scale_factor_, point);\n+  gfx::Point point_in_pixels =\n+      gfx::ConvertPointToPixel(current_device_scale_factor_, point);","path":"atom/browser/osr/osr_render_widget_host_view.cc","position":292,"original_position":292,"commit_id":"317fd9104a496d9a6fc7766304e05cdde624acf4","original_commit_id":"317fd9104a496d9a6fc7766304e05cdde624acf4","user":{"login":"nornagon","id":172800,"avatar_url":"https://avatars2.githubusercontent.com/u/172800?v=4","gravatar_id":"","url":"https://api.github.com/users/nornagon","html_url":"https://github.com/nornagon","followers_url":"https://api.github.com/users/nornagon/followers","following_url":"https://api.github.com/users/nornagon/following{/other_user}","gists_url":"https://api.github.com/users/nornagon/gists{/gist_id}","starred_url":"https://api.github.com/users/nornagon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nornagon/subscriptions","organizations_url":"https://api.github.com/users/nornagon/orgs","repos_url":"https://api.github.com/users/nornagon/repos","events_url":"https://api.github.com/users/nornagon/events{/privacy}","received_events_url":"https://api.github.com/users/nornagon/received_events","type":"User","site_admin":false},"body":"I'm confused about when to use `scale_factor_` vs `current_device_scale_factor_`, could you explain the structure to me? Thanks! 😅 ","created_at":"2018-05-25T17:09:52Z","updated_at":"2018-05-25T17:47:05Z","html_url":"https://github.com/electron/electron/pull/13069#discussion_r190956251","pull_request_url":"https://api.github.com/repos/electron/electron/pulls/13069","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/comments/190956251"},"html":{"href":"https://github.com/electron/electron/pull/13069#discussion_r190956251"},"pull_request":{"href":"https://api.github.com/repos/electron/electron/pulls/13069"}}},"pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/13069","id":190464377,"html_url":"https://github.com/electron/electron/pull/13069","diff_url":"https://github.com/electron/electron/pull/13069.diff","patch_url":"https://github.com/electron/electron/pull/13069.patch","issue_url":"https://api.github.com/repos/electron/electron/issues/13069","number":13069,"state":"open","locked":false,"title":"feat: Add method to get/set offscreen window's scale factor","user":{"login":"brenca","id":1690458,"avatar_url":"https://avatars2.githubusercontent.com/u/1690458?v=4","gravatar_id":"","url":"https://api.github.com/users/brenca","html_url":"https://github.com/brenca","followers_url":"https://api.github.com/users/brenca/followers","following_url":"https://api.github.com/users/brenca/following{/other_user}","gists_url":"https://api.github.com/users/brenca/gists{/gist_id}","starred_url":"https://api.github.com/users/brenca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brenca/subscriptions","organizations_url":"https://api.github.com/users/brenca/orgs","repos_url":"https://api.github.com/users/brenca/repos","events_url":"https://api.github.com/users/brenca/events{/privacy}","received_events_url":"https://api.github.com/users/brenca/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your Pull Request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/electron/electron/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nThis PR adds a `scaleFactor` field to `webPreferences`, and a `get/setScaleFactor` method to `browserWindow/webContents`. These allow you to control the scale factor, which was previously locked to `1.0`. ","created_at":"2018-05-25T02:08:05Z","updated_at":"2018-05-25T17:47:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9bdaef88b96ffb45a4eb530a67ce446e34e2368","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/electron/electron/pulls/13069/commits","review_comments_url":"https://api.github.com/repos/electron/electron/pulls/13069/comments","review_comment_url":"https://api.github.com/repos/electron/electron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/electron/electron/issues/13069/comments","statuses_url":"https://api.github.com/repos/electron/electron/statuses/317fd9104a496d9a6fc7766304e05cdde624acf4","head":{"label":"electron:osr-scale-factor","ref":"osr-scale-factor","sha":"317fd9104a496d9a6fc7766304e05cdde624acf4","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"electron/electron","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/electron","description":"Build cross platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2018-05-25T15:17:06Z","pushed_at":"2018-05-25T17:41:51Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":38240,"stargazers_count":60512,"watchers_count":60512,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7910,"mirror_url":null,"archived":false,"open_issues_count":1062,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7910,"open_issues":1062,"watchers":60512,"default_branch":"master"}},"base":{"label":"electron:master","ref":"master","sha":"fd25f594cd4ce6121b339f9553fec3dde6562178","user":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"repo":{"id":9384267,"name":"electron","full_name":"electron/electron","owner":{"login":"electron","id":13409222,"avatar_url":"https://avatars1.githubusercontent.com/u/13409222?v=4","gravatar_id":"","url":"https://api.github.com/users/electron","html_url":"https://github.com/electron","followers_url":"https://api.github.com/users/electron/followers","following_url":"https://api.github.com/users/electron/following{/other_user}","gists_url":"https://api.github.com/users/electron/gists{/gist_id}","starred_url":"https://api.github.com/users/electron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electron/subscriptions","organizations_url":"https://api.github.com/users/electron/orgs","repos_url":"https://api.github.com/users/electron/repos","events_url":"https://api.github.com/users/electron/events{/privacy}","received_events_url":"https://api.github.com/users/electron/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/electron/electron","description":"Build cross platform desktop apps with JavaScript, HTML, and CSS","fork":false,"url":"https://api.github.com/repos/electron/electron","forks_url":"https://api.github.com/repos/electron/electron/forks","keys_url":"https://api.github.com/repos/electron/electron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electron/electron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electron/electron/teams","hooks_url":"https://api.github.com/repos/electron/electron/hooks","issue_events_url":"https://api.github.com/repos/electron/electron/issues/events{/number}","events_url":"https://api.github.com/repos/electron/electron/events","assignees_url":"https://api.github.com/repos/electron/electron/assignees{/user}","branches_url":"https://api.github.com/repos/electron/electron/branches{/branch}","tags_url":"https://api.github.com/repos/electron/electron/tags","blobs_url":"https://api.github.com/repos/electron/electron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electron/electron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electron/electron/git/refs{/sha}","trees_url":"https://api.github.com/repos/electron/electron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electron/electron/statuses/{sha}","languages_url":"https://api.github.com/repos/electron/electron/languages","stargazers_url":"https://api.github.com/repos/electron/electron/stargazers","contributors_url":"https://api.github.com/repos/electron/electron/contributors","subscribers_url":"https://api.github.com/repos/electron/electron/subscribers","subscription_url":"https://api.github.com/repos/electron/electron/subscription","commits_url":"https://api.github.com/repos/electron/electron/commits{/sha}","git_commits_url":"https://api.github.com/repos/electron/electron/git/commits{/sha}","comments_url":"https://api.github.com/repos/electron/electron/comments{/number}","issue_comment_url":"https://api.github.com/repos/electron/electron/issues/comments{/number}","contents_url":"https://api.github.com/repos/electron/electron/contents/{+path}","compare_url":"https://api.github.com/repos/electron/electron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electron/electron/merges","archive_url":"https://api.github.com/repos/electron/electron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electron/electron/downloads","issues_url":"https://api.github.com/repos/electron/electron/issues{/number}","pulls_url":"https://api.github.com/repos/electron/electron/pulls{/number}","milestones_url":"https://api.github.com/repos/electron/electron/milestones{/number}","notifications_url":"https://api.github.com/repos/electron/electron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electron/electron/labels{/name}","releases_url":"https://api.github.com/repos/electron/electron/releases{/id}","deployments_url":"https://api.github.com/repos/electron/electron/deployments","created_at":"2013-04-12T01:47:36Z","updated_at":"2018-05-25T15:17:06Z","pushed_at":"2018-05-25T17:41:51Z","git_url":"git://github.com/electron/electron.git","ssh_url":"git@github.com:electron/electron.git","clone_url":"https://github.com/electron/electron.git","svn_url":"https://github.com/electron/electron","homepage":"https://electronjs.org","size":38240,"stargazers_count":60512,"watchers_count":60512,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7910,"mirror_url":null,"archived":false,"open_issues_count":1062,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7910,"open_issues":1062,"watchers":60512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/electron/electron/pulls/13069"},"html":{"href":"https://github.com/electron/electron/pull/13069"},"issue":{"href":"https://api.github.com/repos/electron/electron/issues/13069"},"comments":{"href":"https://api.github.com/repos/electron/electron/issues/13069/comments"},"review_comments":{"href":"https://api.github.com/repos/electron/electron/pulls/13069/comments"},"review_comment":{"href":"https://api.github.com/repos/electron/electron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/electron/electron/pulls/13069/commits"},"statuses":{"href":"https://api.github.com/repos/electron/electron/statuses/317fd9104a496d9a6fc7766304e05cdde624acf4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nornagon"}}