{"action":"closed","issue":{"url":"https://api.github.com/repos/EDCD/EDDI/issues/628","repository_url":"https://api.github.com/repos/EDCD/EDDI","labels_url":"https://api.github.com/repos/EDCD/EDDI/issues/628/labels{/name}","comments_url":"https://api.github.com/repos/EDCD/EDDI/issues/628/comments","events_url":"https://api.github.com/repos/EDCD/EDDI/issues/628/events","html_url":"https://github.com/EDCD/EDDI/issues/628","id":329940550,"node_id":"MDU6SXNzdWUzMjk5NDA1NTA=","number":628,"title":"Cargo not updated when delivering for a wing mission","user":{"login":"richardbuckle","id":227024,"node_id":"MDQ6VXNlcjIyNzAyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/227024?v=4","gravatar_id":"","url":"https://api.github.com/users/richardbuckle","html_url":"https://github.com/richardbuckle","followers_url":"https://api.github.com/users/richardbuckle/followers","following_url":"https://api.github.com/users/richardbuckle/following{/other_user}","gists_url":"https://api.github.com/users/richardbuckle/gists{/gist_id}","starred_url":"https://api.github.com/users/richardbuckle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardbuckle/subscriptions","organizations_url":"https://api.github.com/users/richardbuckle/orgs","repos_url":"https://api.github.com/users/richardbuckle/repos","events_url":"https://api.github.com/users/richardbuckle/events{/privacy}","received_events_url":"https://api.github.com/users/richardbuckle/received_events","type":"User","site_admin":false},"labels":[{"id":662128029,"node_id":"MDU6TGFiZWw2NjIxMjgwMjk=","url":"https://api.github.com/repos/EDCD/EDDI/labels/6.%20bug%20/%20not%20up%20to%20spec","name":"6. bug / not up to spec","color":"d93f0b","default":false},{"id":868759703,"node_id":"MDU6TGFiZWw4Njg3NTk3MDM=","url":"https://api.github.com/repos/EDCD/EDDI/labels/PR%20submitted","name":"PR submitted","color":"0052cc","default":false},{"id":952553185,"node_id":"MDU6TGFiZWw5NTI1NTMxODU=","url":"https://api.github.com/repos/EDCD/EDDI/labels/please%20test","name":"please test","color":"ea9a6b","default":false}],"state":"closed","locked":false,"assignee":{"login":"Hoodathunk","id":22770885,"node_id":"MDQ6VXNlcjIyNzcwODg1","avatar_url":"https://avatars0.githubusercontent.com/u/22770885?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoodathunk","html_url":"https://github.com/Hoodathunk","followers_url":"https://api.github.com/users/Hoodathunk/followers","following_url":"https://api.github.com/users/Hoodathunk/following{/other_user}","gists_url":"https://api.github.com/users/Hoodathunk/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoodathunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoodathunk/subscriptions","organizations_url":"https://api.github.com/users/Hoodathunk/orgs","repos_url":"https://api.github.com/users/Hoodathunk/repos","events_url":"https://api.github.com/users/Hoodathunk/events{/privacy}","received_events_url":"https://api.github.com/users/Hoodathunk/received_events","type":"User","site_admin":false},"assignees":[{"login":"Hoodathunk","id":22770885,"node_id":"MDQ6VXNlcjIyNzcwODg1","avatar_url":"https://avatars0.githubusercontent.com/u/22770885?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoodathunk","html_url":"https://github.com/Hoodathunk","followers_url":"https://api.github.com/users/Hoodathunk/followers","following_url":"https://api.github.com/users/Hoodathunk/following{/other_user}","gists_url":"https://api.github.com/users/Hoodathunk/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoodathunk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoodathunk/subscriptions","organizations_url":"https://api.github.com/users/Hoodathunk/orgs","repos_url":"https://api.github.com/users/Hoodathunk/repos","events_url":"https://api.github.com/users/Hoodathunk/events{/privacy}","received_events_url":"https://api.github.com/users/Hoodathunk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-06-06T16:21:46Z","updated_at":"2018-06-25T22:21:59Z","closed_at":"2018-06-25T22:21:59Z","author_association":"COLLABORATOR","body":"## EDDI version in which issue found\r\n3.0.1-b4\r\n\r\n## Steps to reproduce\r\n\r\n1. Accept a wing mission to source and return cargo. (You don't actually need to be in a wing.)\r\n2. Buy some of the required cargo.\r\n3. See it in the cargo monitor.\r\n4. Return to the mission giver and deliver the cargo through the mission board.\r\n\r\n## Expected\r\nThe delivered amount is deducted from the cargo monitor.\r\n\r\n## Observed\r\nThe cargo monitor is unchanged.\r\n\r\n## Investigation\r\nHere are journal events as I delivered the cargo. These in fact complete the mission, so the zero progress numbers appear to be an FD bug.\r\n\r\n```\r\n{\"timestamp\":\"2018-06-03T23:33:11Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":47,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":47,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-03T23:36:52Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":2,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":49,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T18:48:18Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":41,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":90,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T19:17:39Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":22,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":112,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T19:41:23Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":61,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":173,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T20:13:51Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":31,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":204,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T20:46:45Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":22,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":226,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T21:28:53Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":36,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":262,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T22:29:35Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":49,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":311,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T23:20:21Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":77,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":388,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-04T23:43:59Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":77,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":465,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n{\"timestamp\":\"2018-06-05T00:14:58Z\",\"event\":\"CargoDepot\",\"MissionID\":387470749,\"UpdateType\":\"Deliver\",\"CargoType\":\"PersonalWeapons\",\"CargoType_Localised\":\"Personal Weapons\",\"Count\":3,\"StartMarketID\":0,\"EndMarketID\":128822164,\"ItemsCollected\":0,\"ItemsDelivered\":468,\"TotalItemsToDeliver\":468,\"Progress\":0.0}\r\n```\r\n"}}
{"actor":{"display_login":"Hoodathunk"}}