{"action":"created","comment":{"url":"https://api.github.com/repos/xapian/xapian/pulls/comments/197882982","pull_request_review_id":131714033,"id":197882982,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg4Mjk4Mg==","diff_hunk":"@@ -1066,6 +1066,20 @@ class XAPIAN_VISIBILITY_DEFAULT QueryParser {\n \t\t      unsigned flags = FLAG_DEFAULT,\n \t\t      const std::string &default_prefix = std::string());\n \n+    /** Parse a math formula query.\n+     *\n+     * @param query_string\tMath expression as std::string.\n+     * @param flags\t\tZero or more QueryParser::feature_flag\n+     * \t\tspecifying what features the QueryParser should support.\n+     * \t\tCombine multiple values with bitwise-or (|)\n+     * \t\t(default FLAG_DEFAULT).\n+     *\t@param default_prefix\tThe default term prefix to use (default none.\n+     *\t\tFor example, you can pass \"A\" when parsing an \"Author\" field.\n+     */\n+    Query parse_math_query(const std::string & query_string,\n+\t\t\t   unsigned flags = FLAG_DEFAULT,\n+\t\t\t   const std::string &default_prefix = std::string());","path":"xapian-core/include/xapian/queryparser.h","position":16,"original_position":16,"commit_id":"ef3b1ff4923f043a57d0ab125579685bd9f7ea7d","original_commit_id":"ef3b1ff4923f043a57d0ab125579685bd9f7ea7d","user":{"login":"guruhegde","id":4284506,"node_id":"MDQ6VXNlcjQyODQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4284506?v=4","gravatar_id":"","url":"https://api.github.com/users/guruhegde","html_url":"https://github.com/guruhegde","followers_url":"https://api.github.com/users/guruhegde/followers","following_url":"https://api.github.com/users/guruhegde/following{/other_user}","gists_url":"https://api.github.com/users/guruhegde/gists{/gist_id}","starred_url":"https://api.github.com/users/guruhegde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruhegde/subscriptions","organizations_url":"https://api.github.com/users/guruhegde/orgs","repos_url":"https://api.github.com/users/guruhegde/repos","events_url":"https://api.github.com/users/guruhegde/events{/privacy}","received_events_url":"https://api.github.com/users/guruhegde/received_events","type":"User","site_admin":false},"body":"Right, `flags` parameter is not needed. I removed the usage. Please check another comment for a possible use case for flags.","created_at":"2018-06-25T17:45:44Z","updated_at":"2018-06-25T17:45:44Z","html_url":"https://github.com/xapian/xapian/pull/201#discussion_r197882982","pull_request_url":"https://api.github.com/repos/xapian/xapian/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments/197882982"},"html":{"href":"https://github.com/xapian/xapian/pull/201#discussion_r197882982"},"pull_request":{"href":"https://api.github.com/repos/xapian/xapian/pulls/201"}},"in_reply_to_id":197257026},"pull_request":{"url":"https://api.github.com/repos/xapian/xapian/pulls/201","id":189046398,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MDQ2Mzk4","html_url":"https://github.com/xapian/xapian/pull/201","diff_url":"https://github.com/xapian/xapian/pull/201.diff","patch_url":"https://github.com/xapian/xapian/pull/201.patch","issue_url":"https://api.github.com/repos/xapian/xapian/issues/201","number":201,"state":"open","locked":false,"title":"Generate symbol pair tuple from presenation mathml expression","user":{"login":"guruhegde","id":4284506,"node_id":"MDQ6VXNlcjQyODQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4284506?v=4","gravatar_id":"","url":"https://api.github.com/users/guruhegde","html_url":"https://github.com/guruhegde","followers_url":"https://api.github.com/users/guruhegde/followers","following_url":"https://api.github.com/users/guruhegde/following{/other_user}","gists_url":"https://api.github.com/users/guruhegde/gists{/gist_id}","starred_url":"https://api.github.com/users/guruhegde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruhegde/subscriptions","organizations_url":"https://api.github.com/users/guruhegde/orgs","repos_url":"https://api.github.com/users/guruhegde/repos","events_url":"https://api.github.com/users/guruhegde/events{/privacy}","received_events_url":"https://api.github.com/users/guruhegde/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nAs part of the ticket, #761 implemented basic parsing functionality. This PR is still work in progress. \r\n\r\nPlease have a look when you have time and give your feedback.\r\n\r\nTODO:\r\nParsing:\r\n- [x] Implement layout schemes such as superscript, subscript, root etc.\r\n- [ ] Add matrix and vector support.\r\n- [ ]  Sub-expression.\r\n- [x] Handle `<mrow>` element.\r\n- [x] Handle namespace prefix if present.\r\n\r\nIn the current implementation, I used `std::vector` to store symbols. Please suggest if there is a better way. ","created_at":"2018-05-18T14:37:57Z","updated_at":"2018-06-25T17:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"166232080db786947c70038988e5b54679709235","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapian/xapian/pulls/201/commits","review_comments_url":"https://api.github.com/repos/xapian/xapian/pulls/201/comments","review_comment_url":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapian/xapian/issues/201/comments","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/ef3b1ff4923f043a57d0ab125579685bd9f7ea7d","head":{"label":"guruhegde:fix-#761","ref":"fix-#761","sha":"ef3b1ff4923f043a57d0ab125579685bd9f7ea7d","user":{"login":"guruhegde","id":4284506,"node_id":"MDQ6VXNlcjQyODQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4284506?v=4","gravatar_id":"","url":"https://api.github.com/users/guruhegde","html_url":"https://github.com/guruhegde","followers_url":"https://api.github.com/users/guruhegde/followers","following_url":"https://api.github.com/users/guruhegde/following{/other_user}","gists_url":"https://api.github.com/users/guruhegde/gists{/gist_id}","starred_url":"https://api.github.com/users/guruhegde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruhegde/subscriptions","organizations_url":"https://api.github.com/users/guruhegde/orgs","repos_url":"https://api.github.com/users/guruhegde/repos","events_url":"https://api.github.com/users/guruhegde/events{/privacy}","received_events_url":"https://api.github.com/users/guruhegde/received_events","type":"User","site_admin":false},"repo":{"id":124200515,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyMDA1MTU=","name":"xapian","full_name":"guruhegde/xapian","owner":{"login":"guruhegde","id":4284506,"node_id":"MDQ6VXNlcjQyODQ1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4284506?v=4","gravatar_id":"","url":"https://api.github.com/users/guruhegde","html_url":"https://github.com/guruhegde","followers_url":"https://api.github.com/users/guruhegde/followers","following_url":"https://api.github.com/users/guruhegde/following{/other_user}","gists_url":"https://api.github.com/users/guruhegde/gists{/gist_id}","starred_url":"https://api.github.com/users/guruhegde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guruhegde/subscriptions","organizations_url":"https://api.github.com/users/guruhegde/orgs","repos_url":"https://api.github.com/users/guruhegde/repos","events_url":"https://api.github.com/users/guruhegde/events{/privacy}","received_events_url":"https://api.github.com/users/guruhegde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/guruhegde/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":true,"url":"https://api.github.com/repos/guruhegde/xapian","forks_url":"https://api.github.com/repos/guruhegde/xapian/forks","keys_url":"https://api.github.com/repos/guruhegde/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guruhegde/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guruhegde/xapian/teams","hooks_url":"https://api.github.com/repos/guruhegde/xapian/hooks","issue_events_url":"https://api.github.com/repos/guruhegde/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/guruhegde/xapian/events","assignees_url":"https://api.github.com/repos/guruhegde/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/guruhegde/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/guruhegde/xapian/tags","blobs_url":"https://api.github.com/repos/guruhegde/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guruhegde/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guruhegde/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/guruhegde/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guruhegde/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/guruhegde/xapian/languages","stargazers_url":"https://api.github.com/repos/guruhegde/xapian/stargazers","contributors_url":"https://api.github.com/repos/guruhegde/xapian/contributors","subscribers_url":"https://api.github.com/repos/guruhegde/xapian/subscribers","subscription_url":"https://api.github.com/repos/guruhegde/xapian/subscription","commits_url":"https://api.github.com/repos/guruhegde/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/guruhegde/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/guruhegde/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/guruhegde/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/guruhegde/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/guruhegde/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guruhegde/xapian/merges","archive_url":"https://api.github.com/repos/guruhegde/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guruhegde/xapian/downloads","issues_url":"https://api.github.com/repos/guruhegde/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/guruhegde/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/guruhegde/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/guruhegde/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guruhegde/xapian/labels{/name}","releases_url":"https://api.github.com/repos/guruhegde/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/guruhegde/xapian/deployments","created_at":"2018-03-07T08:01:14Z","updated_at":"2018-04-02T10:22:53Z","pushed_at":"2018-06-09T20:30:37Z","git_url":"git://github.com/guruhegde/xapian.git","ssh_url":"git@github.com:guruhegde/xapian.git","clone_url":"https://github.com/guruhegde/xapian.git","svn_url":"https://github.com/guruhegde/xapian","homepage":"https://xapian.org/","size":81803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gp-master"}},"base":{"label":"xapian:master","ref":"master","sha":"4a9003e439b55c29275ed247118abf49bc7b3682","user":{"login":"xapian","id":312861,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjg2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/312861?v=4","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"repo":{"id":735981,"node_id":"MDEwOlJlcG9zaXRvcnk3MzU5ODE=","name":"xapian","full_name":"xapian/xapian","owner":{"login":"xapian","id":312861,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjg2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/312861?v=4","gravatar_id":"","url":"https://api.github.com/users/xapian","html_url":"https://github.com/xapian","followers_url":"https://api.github.com/users/xapian/followers","following_url":"https://api.github.com/users/xapian/following{/other_user}","gists_url":"https://api.github.com/users/xapian/gists{/gist_id}","starred_url":"https://api.github.com/users/xapian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapian/subscriptions","organizations_url":"https://api.github.com/users/xapian/orgs","repos_url":"https://api.github.com/users/xapian/repos","events_url":"https://api.github.com/users/xapian/events{/privacy}","received_events_url":"https://api.github.com/users/xapian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapian/xapian","description":"Mirror of the Xapian repository.  You're welcome to open pull requests on github (they'll just get merged indirectly).","fork":false,"url":"https://api.github.com/repos/xapian/xapian","forks_url":"https://api.github.com/repos/xapian/xapian/forks","keys_url":"https://api.github.com/repos/xapian/xapian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapian/xapian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapian/xapian/teams","hooks_url":"https://api.github.com/repos/xapian/xapian/hooks","issue_events_url":"https://api.github.com/repos/xapian/xapian/issues/events{/number}","events_url":"https://api.github.com/repos/xapian/xapian/events","assignees_url":"https://api.github.com/repos/xapian/xapian/assignees{/user}","branches_url":"https://api.github.com/repos/xapian/xapian/branches{/branch}","tags_url":"https://api.github.com/repos/xapian/xapian/tags","blobs_url":"https://api.github.com/repos/xapian/xapian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapian/xapian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapian/xapian/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapian/xapian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapian/xapian/statuses/{sha}","languages_url":"https://api.github.com/repos/xapian/xapian/languages","stargazers_url":"https://api.github.com/repos/xapian/xapian/stargazers","contributors_url":"https://api.github.com/repos/xapian/xapian/contributors","subscribers_url":"https://api.github.com/repos/xapian/xapian/subscribers","subscription_url":"https://api.github.com/repos/xapian/xapian/subscription","commits_url":"https://api.github.com/repos/xapian/xapian/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapian/xapian/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapian/xapian/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapian/xapian/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapian/xapian/contents/{+path}","compare_url":"https://api.github.com/repos/xapian/xapian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapian/xapian/merges","archive_url":"https://api.github.com/repos/xapian/xapian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapian/xapian/downloads","issues_url":"https://api.github.com/repos/xapian/xapian/issues{/number}","pulls_url":"https://api.github.com/repos/xapian/xapian/pulls{/number}","milestones_url":"https://api.github.com/repos/xapian/xapian/milestones{/number}","notifications_url":"https://api.github.com/repos/xapian/xapian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapian/xapian/labels{/name}","releases_url":"https://api.github.com/repos/xapian/xapian/releases{/id}","deployments_url":"https://api.github.com/repos/xapian/xapian/deployments","created_at":"2010-06-23T15:51:03Z","updated_at":"2018-06-23T04:33:56Z","pushed_at":"2018-06-25T03:26:08Z","git_url":"git://github.com/xapian/xapian.git","ssh_url":"git@github.com:xapian/xapian.git","clone_url":"https://github.com/xapian/xapian.git","svn_url":"https://github.com/xapian/xapian","homepage":"https://xapian.org/","size":81839,"stargazers_count":420,"watchers_count":420,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":202,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":202,"open_issues":10,"watchers":420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapian/xapian/pulls/201"},"html":{"href":"https://github.com/xapian/xapian/pull/201"},"issue":{"href":"https://api.github.com/repos/xapian/xapian/issues/201"},"comments":{"href":"https://api.github.com/repos/xapian/xapian/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/xapian/xapian/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/xapian/xapian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapian/xapian/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/xapian/xapian/statuses/ef3b1ff4923f043a57d0ab125579685bd9f7ea7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"guruhegde"}}