{"action":"created","issue":{"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449","repository_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd","labels_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449/labels{/name}","comments_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449/comments","events_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449/events","html_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449","id":394161515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTc1ODg2","number":449,"title":"Issue #389: Update self message router and feeback","user":{"login":"rschnekenbu","id":3964263,"node_id":"MDQ6VXNlcjM5NjQyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3964263?v=4","gravatar_id":"","url":"https://api.github.com/users/rschnekenbu","html_url":"https://github.com/rschnekenbu","followers_url":"https://api.github.com/users/rschnekenbu/followers","following_url":"https://api.github.com/users/rschnekenbu/following{/other_user}","gists_url":"https://api.github.com/users/rschnekenbu/gists{/gist_id}","starred_url":"https://api.github.com/users/rschnekenbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rschnekenbu/subscriptions","organizations_url":"https://api.github.com/users/rschnekenbu/orgs","repos_url":"https://api.github.com/users/rschnekenbu/repos","events_url":"https://api.github.com/users/rschnekenbu/events{/privacy}","received_events_url":"https://api.github.com/users/rschnekenbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-26T12:49:52Z","updated_at":"2018-12-26T19:31:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/pulls/449","html_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449","diff_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449.diff","patch_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449.patch"},"body":"- update the self router to not use bendpoints\r\n- update feedback to switch from self to oblique and vice versa\r\n- update management of start/end messages for execution specifications\r\n- add some tests for self messages corner cases\r\n- add some (weird) refresh method for tests, to get them green on remote\r\nbuild. working fine locally PDE and maven, but not on remote build\r\nserver\r\n- update anchors on executions to manage automatically the sides.\r\n\r\nChange-Id: Ieb479d5b1109c4f4b4a76c0df5e45b48c73192d2\r\nSigned-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>"},"comment":{"url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/comments/450013716","html_url":"https://github.com/eclipsesource/papyrus-seqd/pull/449#issuecomment-450013716","issue_url":"https://api.github.com/repos/eclipsesource/papyrus-seqd/issues/449","id":450013716,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDAxMzcxNg==","user":{"login":"cdamus","id":1615558,"node_id":"MDQ6VXNlcjE2MTU1NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1615558?v=4","gravatar_id":"","url":"https://api.github.com/users/cdamus","html_url":"https://github.com/cdamus","followers_url":"https://api.github.com/users/cdamus/followers","following_url":"https://api.github.com/users/cdamus/following{/other_user}","gists_url":"https://api.github.com/users/cdamus/gists{/gist_id}","starred_url":"https://api.github.com/users/cdamus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdamus/subscriptions","organizations_url":"https://api.github.com/users/cdamus/orgs","repos_url":"https://api.github.com/users/cdamus/repos","events_url":"https://api.github.com/users/cdamus/events{/privacy}","received_events_url":"https://api.github.com/users/cdamus/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T19:31:45Z","updated_at":"2018-12-26T19:31:45Z","author_association":"COLLABORATOR","body":"Actually, there's also a test failure that is currently hidden by one of the assumption violations, that indicates a real regression.  In test `LifelineSwitchingUITest::ExecutionSpanningOccurrences::switchLifeline`, it used to be that when a message becomes a self-message by virtue of the execution specification moving from one lifeline to another when re-targeting a synchronous message, that self-message was shaped properly with the minimal vertical span.  However, with the changes in this pull request, that message now has no vertical size.  It's this scenario:\r\n\r\n![Retarget sync message with execution](https://user-images.githubusercontent.com/1615558/50455213-9c719580-091a-11e9-9da0-29982041a166.gif)\r\n\r\nBut worse than this is what happens when attempting the same edit but by moving the execution specification directly (not re-targeting the request message):\r\n\r\n![Move execution directly](https://user-images.githubusercontent.com/1615558/50455258-d5116f00-091a-11e9-8eb4-4aa898ef7803.gif)\r\n\r\nThis really breaks the diagram, including an error dialog with cycle in the dependency graph."}}
{"actor":{"display_login":"cdamus"}}