{"action":"created","comment":{"url":"https://api.github.com/repos/exhuma/puresnmp/pulls/comments/167394098","pull_request_review_id":95617805,"id":167394098,"diff_hunk":"@@ -74,4 +95,4 @@ def readbytes(filename):\n             line = line.split(':')[1]\n         str_bytes.extend(line.split())\n     values = [int(char, 16) for char in str_bytes]\n-    return bytes(values)\n+    return bytearray(values)","path":"puresnmp/test/__init__.py","position":95,"original_position":95,"commit_id":"7c6d4bf7563495f49018b798a17a7f221e4403e4","original_commit_id":"7c6d4bf7563495f49018b798a17a7f221e4403e4","user":{"login":"exhuma","id":65717,"avatar_url":"https://avatars3.githubusercontent.com/u/65717?v=4","gravatar_id":"","url":"https://api.github.com/users/exhuma","html_url":"https://github.com/exhuma","followers_url":"https://api.github.com/users/exhuma/followers","following_url":"https://api.github.com/users/exhuma/following{/other_user}","gists_url":"https://api.github.com/users/exhuma/gists{/gist_id}","starred_url":"https://api.github.com/users/exhuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhuma/subscriptions","organizations_url":"https://api.github.com/users/exhuma/orgs","repos_url":"https://api.github.com/users/exhuma/repos","events_url":"https://api.github.com/users/exhuma/events{/privacy}","received_events_url":"https://api.github.com/users/exhuma/received_events","type":"User","site_admin":false},"body":"Why did you replace `bytes` with `bytearray` here? `bytes` also exists in Python2.","created_at":"2018-02-10T09:29:09Z","updated_at":"2018-02-10T09:54:09Z","html_url":"https://github.com/exhuma/puresnmp/pull/32#discussion_r167394098","pull_request_url":"https://api.github.com/repos/exhuma/puresnmp/pulls/32","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/exhuma/puresnmp/pulls/comments/167394098"},"html":{"href":"https://github.com/exhuma/puresnmp/pull/32#discussion_r167394098"},"pull_request":{"href":"https://api.github.com/repos/exhuma/puresnmp/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/exhuma/puresnmp/pulls/32","id":168305761,"html_url":"https://github.com/exhuma/puresnmp/pull/32","diff_url":"https://github.com/exhuma/puresnmp/pull/32.diff","patch_url":"https://github.com/exhuma/puresnmp/pull/32.patch","issue_url":"https://api.github.com/repos/exhuma/puresnmp/issues/32","number":32,"state":"open","locked":false,"title":"puresnmp/__init__.py: py2","user":{"login":"remdragon","id":3742423,"avatar_url":"https://avatars2.githubusercontent.com/u/3742423?v=4","gravatar_id":"","url":"https://api.github.com/users/remdragon","html_url":"https://github.com/remdragon","followers_url":"https://api.github.com/users/remdragon/followers","following_url":"https://api.github.com/users/remdragon/following{/other_user}","gists_url":"https://api.github.com/users/remdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/remdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remdragon/subscriptions","organizations_url":"https://api.github.com/users/remdragon/orgs","repos_url":"https://api.github.com/users/remdragon/repos","events_url":"https://api.github.com/users/remdragon/events{/privacy}","received_events_url":"https://api.github.com/users/remdragon/received_events","type":"User","site_admin":false},"body":"I have implemented py2 compatibility while making sure that all tests still work in py3\r\n\r\nI noticed while going through it that you wanted NonASN1Type renamed to UnknownType so I took care of that, too.\r\n\r\nWhile I was troubleshooting my changes, I had a desire to see the ascii representation of each byte in ByteTester.assertBytesEqual so I added an extra column with that information.\r\n\r\npuresnmp/exc.py: py2\r\npuresnmp/pdu.py: py2\r\npuresnmp/test/__init__.py: py2, add repr() of each char to comparison output\r\npuresnmp/tests/test_non_standard_types.py: py2\r\npuresnmp/test/test_package_root.py: py2, switch some base classes to ByteTester b/c I implemented py2 unittest compatibility there\r\npuresnmp/test/test_pdus.py: py2\r\npuresnmp/test/x690/test_types.py: py2, rename NonASN1Type to UnknownType\r\npuresnmp/test/x690/test_util.py: py2\r\npuresnmp/transport.py: py2\r\npuresnmp/types.py: py2\r\npuresnmp/x690/types.py: py2\r\npuresnmp/x690/util.py: py2","created_at":"2018-02-09T18:03:25Z","updated_at":"2018-02-10T09:54:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82b0dbc301626bb8915d766833c185367fb05392","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/exhuma/puresnmp/pulls/32/commits","review_comments_url":"https://api.github.com/repos/exhuma/puresnmp/pulls/32/comments","review_comment_url":"https://api.github.com/repos/exhuma/puresnmp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exhuma/puresnmp/issues/32/comments","statuses_url":"https://api.github.com/repos/exhuma/puresnmp/statuses/7c6d4bf7563495f49018b798a17a7f221e4403e4","head":{"label":"remdragon:develop","ref":"develop","sha":"7c6d4bf7563495f49018b798a17a7f221e4403e4","user":{"login":"remdragon","id":3742423,"avatar_url":"https://avatars2.githubusercontent.com/u/3742423?v=4","gravatar_id":"","url":"https://api.github.com/users/remdragon","html_url":"https://github.com/remdragon","followers_url":"https://api.github.com/users/remdragon/followers","following_url":"https://api.github.com/users/remdragon/following{/other_user}","gists_url":"https://api.github.com/users/remdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/remdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remdragon/subscriptions","organizations_url":"https://api.github.com/users/remdragon/orgs","repos_url":"https://api.github.com/users/remdragon/repos","events_url":"https://api.github.com/users/remdragon/events{/privacy}","received_events_url":"https://api.github.com/users/remdragon/received_events","type":"User","site_admin":false},"repo":{"id":120936026,"name":"puresnmp","full_name":"remdragon/puresnmp","owner":{"login":"remdragon","id":3742423,"avatar_url":"https://avatars2.githubusercontent.com/u/3742423?v=4","gravatar_id":"","url":"https://api.github.com/users/remdragon","html_url":"https://github.com/remdragon","followers_url":"https://api.github.com/users/remdragon/followers","following_url":"https://api.github.com/users/remdragon/following{/other_user}","gists_url":"https://api.github.com/users/remdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/remdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remdragon/subscriptions","organizations_url":"https://api.github.com/users/remdragon/orgs","repos_url":"https://api.github.com/users/remdragon/repos","events_url":"https://api.github.com/users/remdragon/events{/privacy}","received_events_url":"https://api.github.com/users/remdragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remdragon/puresnmp","description":"Pure Python SNMP Library","fork":true,"url":"https://api.github.com/repos/remdragon/puresnmp","forks_url":"https://api.github.com/repos/remdragon/puresnmp/forks","keys_url":"https://api.github.com/repos/remdragon/puresnmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remdragon/puresnmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remdragon/puresnmp/teams","hooks_url":"https://api.github.com/repos/remdragon/puresnmp/hooks","issue_events_url":"https://api.github.com/repos/remdragon/puresnmp/issues/events{/number}","events_url":"https://api.github.com/repos/remdragon/puresnmp/events","assignees_url":"https://api.github.com/repos/remdragon/puresnmp/assignees{/user}","branches_url":"https://api.github.com/repos/remdragon/puresnmp/branches{/branch}","tags_url":"https://api.github.com/repos/remdragon/puresnmp/tags","blobs_url":"https://api.github.com/repos/remdragon/puresnmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remdragon/puresnmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remdragon/puresnmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/remdragon/puresnmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remdragon/puresnmp/statuses/{sha}","languages_url":"https://api.github.com/repos/remdragon/puresnmp/languages","stargazers_url":"https://api.github.com/repos/remdragon/puresnmp/stargazers","contributors_url":"https://api.github.com/repos/remdragon/puresnmp/contributors","subscribers_url":"https://api.github.com/repos/remdragon/puresnmp/subscribers","subscription_url":"https://api.github.com/repos/remdragon/puresnmp/subscription","commits_url":"https://api.github.com/repos/remdragon/puresnmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/remdragon/puresnmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/remdragon/puresnmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/remdragon/puresnmp/issues/comments{/number}","contents_url":"https://api.github.com/repos/remdragon/puresnmp/contents/{+path}","compare_url":"https://api.github.com/repos/remdragon/puresnmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remdragon/puresnmp/merges","archive_url":"https://api.github.com/repos/remdragon/puresnmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remdragon/puresnmp/downloads","issues_url":"https://api.github.com/repos/remdragon/puresnmp/issues{/number}","pulls_url":"https://api.github.com/repos/remdragon/puresnmp/pulls{/number}","milestones_url":"https://api.github.com/repos/remdragon/puresnmp/milestones{/number}","notifications_url":"https://api.github.com/repos/remdragon/puresnmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remdragon/puresnmp/labels{/name}","releases_url":"https://api.github.com/repos/remdragon/puresnmp/releases{/id}","deployments_url":"https://api.github.com/repos/remdragon/puresnmp/deployments","created_at":"2018-02-09T17:36:31Z","updated_at":"2018-02-09T17:36:33Z","pushed_at":"2018-02-09T17:59:00Z","git_url":"git://github.com/remdragon/puresnmp.git","ssh_url":"git@github.com:remdragon/puresnmp.git","clone_url":"https://github.com/remdragon/puresnmp.git","svn_url":"https://github.com/remdragon/puresnmp","homepage":"","size":254,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"exhuma:develop","ref":"develop","sha":"a4ff9aa087d06ae4372c9671c1bfa5ccab576086","user":{"login":"exhuma","id":65717,"avatar_url":"https://avatars3.githubusercontent.com/u/65717?v=4","gravatar_id":"","url":"https://api.github.com/users/exhuma","html_url":"https://github.com/exhuma","followers_url":"https://api.github.com/users/exhuma/followers","following_url":"https://api.github.com/users/exhuma/following{/other_user}","gists_url":"https://api.github.com/users/exhuma/gists{/gist_id}","starred_url":"https://api.github.com/users/exhuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhuma/subscriptions","organizations_url":"https://api.github.com/users/exhuma/orgs","repos_url":"https://api.github.com/users/exhuma/repos","events_url":"https://api.github.com/users/exhuma/events{/privacy}","received_events_url":"https://api.github.com/users/exhuma/received_events","type":"User","site_admin":false},"repo":{"id":67870999,"name":"puresnmp","full_name":"exhuma/puresnmp","owner":{"login":"exhuma","id":65717,"avatar_url":"https://avatars3.githubusercontent.com/u/65717?v=4","gravatar_id":"","url":"https://api.github.com/users/exhuma","html_url":"https://github.com/exhuma","followers_url":"https://api.github.com/users/exhuma/followers","following_url":"https://api.github.com/users/exhuma/following{/other_user}","gists_url":"https://api.github.com/users/exhuma/gists{/gist_id}","starred_url":"https://api.github.com/users/exhuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exhuma/subscriptions","organizations_url":"https://api.github.com/users/exhuma/orgs","repos_url":"https://api.github.com/users/exhuma/repos","events_url":"https://api.github.com/users/exhuma/events{/privacy}","received_events_url":"https://api.github.com/users/exhuma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/exhuma/puresnmp","description":"Pure Python SNMP Library","fork":false,"url":"https://api.github.com/repos/exhuma/puresnmp","forks_url":"https://api.github.com/repos/exhuma/puresnmp/forks","keys_url":"https://api.github.com/repos/exhuma/puresnmp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exhuma/puresnmp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exhuma/puresnmp/teams","hooks_url":"https://api.github.com/repos/exhuma/puresnmp/hooks","issue_events_url":"https://api.github.com/repos/exhuma/puresnmp/issues/events{/number}","events_url":"https://api.github.com/repos/exhuma/puresnmp/events","assignees_url":"https://api.github.com/repos/exhuma/puresnmp/assignees{/user}","branches_url":"https://api.github.com/repos/exhuma/puresnmp/branches{/branch}","tags_url":"https://api.github.com/repos/exhuma/puresnmp/tags","blobs_url":"https://api.github.com/repos/exhuma/puresnmp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exhuma/puresnmp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exhuma/puresnmp/git/refs{/sha}","trees_url":"https://api.github.com/repos/exhuma/puresnmp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exhuma/puresnmp/statuses/{sha}","languages_url":"https://api.github.com/repos/exhuma/puresnmp/languages","stargazers_url":"https://api.github.com/repos/exhuma/puresnmp/stargazers","contributors_url":"https://api.github.com/repos/exhuma/puresnmp/contributors","subscribers_url":"https://api.github.com/repos/exhuma/puresnmp/subscribers","subscription_url":"https://api.github.com/repos/exhuma/puresnmp/subscription","commits_url":"https://api.github.com/repos/exhuma/puresnmp/commits{/sha}","git_commits_url":"https://api.github.com/repos/exhuma/puresnmp/git/commits{/sha}","comments_url":"https://api.github.com/repos/exhuma/puresnmp/comments{/number}","issue_comment_url":"https://api.github.com/repos/exhuma/puresnmp/issues/comments{/number}","contents_url":"https://api.github.com/repos/exhuma/puresnmp/contents/{+path}","compare_url":"https://api.github.com/repos/exhuma/puresnmp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exhuma/puresnmp/merges","archive_url":"https://api.github.com/repos/exhuma/puresnmp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exhuma/puresnmp/downloads","issues_url":"https://api.github.com/repos/exhuma/puresnmp/issues{/number}","pulls_url":"https://api.github.com/repos/exhuma/puresnmp/pulls{/number}","milestones_url":"https://api.github.com/repos/exhuma/puresnmp/milestones{/number}","notifications_url":"https://api.github.com/repos/exhuma/puresnmp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exhuma/puresnmp/labels{/name}","releases_url":"https://api.github.com/repos/exhuma/puresnmp/releases{/id}","deployments_url":"https://api.github.com/repos/exhuma/puresnmp/deployments","created_at":"2016-09-10T12:53:29Z","updated_at":"2018-02-05T20:27:18Z","pushed_at":"2018-02-09T18:03:26Z","git_url":"git://github.com/exhuma/puresnmp.git","ssh_url":"git@github.com:exhuma/puresnmp.git","clone_url":"https://github.com/exhuma/puresnmp.git","svn_url":"https://github.com/exhuma/puresnmp","homepage":"","size":250,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":12,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/exhuma/puresnmp/pulls/32"},"html":{"href":"https://github.com/exhuma/puresnmp/pull/32"},"issue":{"href":"https://api.github.com/repos/exhuma/puresnmp/issues/32"},"comments":{"href":"https://api.github.com/repos/exhuma/puresnmp/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/exhuma/puresnmp/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/exhuma/puresnmp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exhuma/puresnmp/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/exhuma/puresnmp/statuses/7c6d4bf7563495f49018b798a17a7f221e4403e4"}},"author_association":"NONE"}}
{"actor":{"display_login":"exhuma"}}