{"action":"created","issue":{"url":"https://api.github.com/repos/openwrt/openwrt/issues/1429","repository_url":"https://api.github.com/repos/openwrt/openwrt","labels_url":"https://api.github.com/repos/openwrt/openwrt/issues/1429/labels{/name}","comments_url":"https://api.github.com/repos/openwrt/openwrt/issues/1429/comments","events_url":"https://api.github.com/repos/openwrt/openwrt/issues/1429/events","html_url":"https://github.com/openwrt/openwrt/pull/1429","id":366319699,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDIxODMy","number":1429,"title":"ipq40xx: uboot envtools fix for GL.iNet GL-B1300 board","user":{"login":"barhom","id":1337696,"node_id":"MDQ6VXNlcjEzMzc2OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1337696?v=4","gravatar_id":"","url":"https://api.github.com/users/barhom","html_url":"https://github.com/barhom","followers_url":"https://api.github.com/users/barhom/followers","following_url":"https://api.github.com/users/barhom/following{/other_user}","gists_url":"https://api.github.com/users/barhom/gists{/gist_id}","starred_url":"https://api.github.com/users/barhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barhom/subscriptions","organizations_url":"https://api.github.com/users/barhom/orgs","repos_url":"https://api.github.com/users/barhom/repos","events_url":"https://api.github.com/users/barhom/events{/privacy}","received_events_url":"https://api.github.com/users/barhom/received_events","type":"User","site_admin":false},"labels":[{"id":868176984,"node_id":"MDU6TGFiZWw4NjgxNzY5ODQ=","url":"https://api.github.com/repos/openwrt/openwrt/labels/ipq40xx","name":"ipq40xx","color":"0043e4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-10-03T12:40:20Z","updated_at":"2018-10-11T05:44:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openwrt/openwrt/pulls/1429","html_url":"https://github.com/openwrt/openwrt/pull/1429","diff_url":"https://github.com/openwrt/openwrt/pull/1429.diff","patch_url":"https://github.com/openwrt/openwrt/pull/1429.patch"},"body":"This pull request makes the uboot env partition readable on the GL.iNet GL-B1300 board."},"comment":{"url":"https://api.github.com/repos/openwrt/openwrt/issues/comments/428828019","html_url":"https://github.com/openwrt/openwrt/pull/1429#issuecomment-428828019","issue_url":"https://api.github.com/repos/openwrt/openwrt/issues/1429","id":428828019,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODgyODAxOQ==","user":{"login":"mkresin","id":4547948,"node_id":"MDQ6VXNlcjQ1NDc5NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4547948?v=4","gravatar_id":"","url":"https://api.github.com/users/mkresin","html_url":"https://github.com/mkresin","followers_url":"https://api.github.com/users/mkresin/followers","following_url":"https://api.github.com/users/mkresin/following{/other_user}","gists_url":"https://api.github.com/users/mkresin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkresin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkresin/subscriptions","organizations_url":"https://api.github.com/users/mkresin/orgs","repos_url":"https://api.github.com/users/mkresin/repos","events_url":"https://api.github.com/users/mkresin/events{/privacy}","received_events_url":"https://api.github.com/users/mkresin/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T05:44:08Z","updated_at":"2018-10-11T05:44:08Z","author_association":"MEMBER","body":"> This was discussed yesterday on the #openwrt channel and we came to the conclusion that there is no reason not to include the part that can read the uboot environment. We did however agree that uboot should stay read-only which is why I removed one commit.\r\n\r\nConsidering your use case, the full blown u-boot-envtools package doesn't make much sense. It only makes sense if you need to write to the u-boot env partition. During write the checksum of the env need to be updated.\r\n\r\nYou might want to do the same as [mtd_get_mac_ascii](https://github.com/openwrt/openwrt/blob/master/package/base-files/files/lib/functions/system.sh#L23) does:\r\n\r\n```\r\n$(strings \"/dev/mtd5\" | sed -n 's/^'\"bootcmd\"'=//p')\r\n```"}}
{"actor":{"display_login":"mkresin"}}