{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/2756","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/2756/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2756/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/2756/events","html_url":"https://github.com/apache/cloudstack/pull/2756","id":342669262,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTEyOTc2","number":2756,"title":"fix provisionCertificate api returns NPE when 'reconnect' parameter is true","user":{"login":"dhlaluku","id":19572501,"node_id":"MDQ6VXNlcjE5NTcyNTAx","avatar_url":"https://avatars1.githubusercontent.com/u/19572501?v=4","gravatar_id":"","url":"https://api.github.com/users/dhlaluku","html_url":"https://github.com/dhlaluku","followers_url":"https://api.github.com/users/dhlaluku/followers","following_url":"https://api.github.com/users/dhlaluku/following{/other_user}","gists_url":"https://api.github.com/users/dhlaluku/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlaluku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlaluku/subscriptions","organizations_url":"https://api.github.com/users/dhlaluku/orgs","repos_url":"https://api.github.com/users/dhlaluku/repos","events_url":"https://api.github.com/users/dhlaluku/events{/privacy}","received_events_url":"https://api.github.com/users/dhlaluku/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-07-19T10:23:04Z","updated_at":"2018-07-20T13:17:19Z","closed_at":"2018-07-20T07:05:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/2756","html_url":"https://github.com/apache/cloudstack/pull/2756","diff_url":"https://github.com/apache/cloudstack/pull/2756.diff","patch_url":"https://github.com/apache/cloudstack/pull/2756.patch"},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\nThis PR fixes NPE with the provisionCertificateCmd when reconnect is set to True.\r\n\r\nAlso fixes the following Marvin test failures:\r\n- test_certauthority_root.py\r\n\r\n<!-- For new features, provide link to FS, dev ML discussion etc. -->\r\n<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Enhancement (improves an existing feature and functionality)\r\n- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)\r\n\r\n## GitHub Issue/PRs\r\n<!-- If this PR is to fix an issue or another PR on GH, uncomment the section and provide the id of issue/PR -->\r\n<!-- When \"Fixes: #<id>\" is specified, the issue/PR will automatically be closed when this PR gets merged -->\r\n<!-- For addressing multiple issues/PRs, use multiple \"Fixes: #<id>\" -->\r\n\r\nFixes: #2753 \r\n\r\n## Screenshots (if appropriate):\r\n![image](https://user-images.githubusercontent.com/19572501/42936866-a69a5b0a-8b4d-11e8-9984-e74fdc0e3cff.png)\r\n\r\n## How Has This Been Tested?\r\nWith cloudmonkey, see screenshot\r\n\r\nDev environment components:\r\n\r\n- Platform: ACS-4.12\r\n- Management OS: Ubuntu 18.04 LTS\r\n- Hypervisor: 1 Host running KVM with CentOS 7\r\n\r\n<!-- Please describe in detail how you tested your changes. -->\r\n<!-- Include details of your testing environment, and the tests you ran to -->\r\n<!-- see how your change affects other areas of the code, etc. -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\nTesting\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All relevant new and existing integration tests have passed.\r\n- [ ] A full integration testsuite with all test that can run on my environment has passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/406597822","html_url":"https://github.com/apache/cloudstack/pull/2756#issuecomment-406597822","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2756","id":406597822,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjU5NzgyMg==","user":{"login":"blueorangutan","id":16489489,"node_id":"MDQ6VXNlcjE2NDg5NDg5","avatar_url":"https://avatars2.githubusercontent.com/u/16489489?v=4","gravatar_id":"","url":"https://api.github.com/users/blueorangutan","html_url":"https://github.com/blueorangutan","followers_url":"https://api.github.com/users/blueorangutan/followers","following_url":"https://api.github.com/users/blueorangutan/following{/other_user}","gists_url":"https://api.github.com/users/blueorangutan/gists{/gist_id}","starred_url":"https://api.github.com/users/blueorangutan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueorangutan/subscriptions","organizations_url":"https://api.github.com/users/blueorangutan/orgs","repos_url":"https://api.github.com/users/blueorangutan/repos","events_url":"https://api.github.com/users/blueorangutan/events{/privacy}","received_events_url":"https://api.github.com/users/blueorangutan/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T13:17:19Z","updated_at":"2018-07-20T13:17:19Z","author_association":"NONE","body":"<b>Trillian test result (tid-2869)</b>\nEnvironment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7\nTotal time taken: 27201 seconds\nMarvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2756-t2869-kvm-centos7.zip\nIntermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py\nIntermitten failure detected: /marvin/tests/smoke/test_primary_storage.py\nIntermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py\nIntermitten failure detected: /marvin/tests/smoke/test_snapshots.py\nIntermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py\nIntermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py\nIntermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py\nSmoke tests completed. 61 look OK, 7 have error(s)\nOnly failed tests results shown below:\n\n\nTest | Result | Time (s) | Test File\n--- | --- | --- | ---\nContextSuite context=TestDeployVirtioSCSIVM>:setup | `Error` | 0.00 | test_deploy_virtio_scsi_vm.py\ntest_01_add_primary_storage_disabled_host | `Error` | 0.60 | test_primary_storage.py\ntest_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py\nContextSuite context=TestStorageTags>:setup | `Error` | 0.22 | test_primary_storage.py\ntest_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 1126.37 | test_privategw_acl.py\ntest_02_list_snapshots_with_removed_data_store | `Error` | 1.15 | test_snapshots.py\ntest_01_secure_vm_migration | `Error` | 132.90 | test_vm_life_cycle.py\ntest_02_unsecure_vm_migration | `Error` | 132.90 | test_vm_life_cycle.py\ntest_03_secured_to_nonsecured_vm_migration | `Error` | 132.93 | test_vm_life_cycle.py\ntest_04_nonsecured_to_secured_vm_migration | `Error` | 132.91 | test_vm_life_cycle.py\ntest_08_migrate_vm | `Error` | 14.79 | test_vm_life_cycle.py\ntest_01_cancel_host_maintenace_with_no_migration_jobs | `Failure` | 0.11 | test_host_maintenance.py\ntest_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.37 | test_host_maintenance.py\ntest_hostha_enable_ha_when_host_in_maintenance | `Error` | 4.58 | test_hostha_kvm.py\ntest_hostha_kvm_host_fencing | `Failure` | 645.66 | test_hostha_kvm.py\ntest_hostha_kvm_host_recovering | `Failure` | 619.79 | test_hostha_kvm.py\n"}}
{"actor":{"display_login":"blueorangutan"}}