{"action":"created","issue":{"url":"https://api.github.com/repos/vurtun/nuklear/issues/765","repository_url":"https://api.github.com/repos/vurtun/nuklear","labels_url":"https://api.github.com/repos/vurtun/nuklear/issues/765/labels{/name}","comments_url":"https://api.github.com/repos/vurtun/nuklear/issues/765/comments","events_url":"https://api.github.com/repos/vurtun/nuklear/issues/765/events","html_url":"https://github.com/vurtun/nuklear/pull/765","id":375361510,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODIyNTIz","number":765,"title":"Fix issue 548","user":{"login":"rswinkle","id":575603,"node_id":"MDQ6VXNlcjU3NTYwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/575603?v=4","gravatar_id":"","url":"https://api.github.com/users/rswinkle","html_url":"https://github.com/rswinkle","followers_url":"https://api.github.com/users/rswinkle/followers","following_url":"https://api.github.com/users/rswinkle/following{/other_user}","gists_url":"https://api.github.com/users/rswinkle/gists{/gist_id}","starred_url":"https://api.github.com/users/rswinkle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rswinkle/subscriptions","organizations_url":"https://api.github.com/users/rswinkle/orgs","repos_url":"https://api.github.com/users/rswinkle/repos","events_url":"https://api.github.com/users/rswinkle/events{/privacy}","received_events_url":"https://api.github.com/users/rswinkle/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-30T07:54:30Z","updated_at":"2018-11-01T18:21:17Z","closed_at":"2018-11-01T18:20:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vurtun/nuklear/pulls/765","html_url":"https://github.com/vurtun/nuklear/pull/765","diff_url":"https://github.com/vurtun/nuklear/pull/765.diff","patch_url":"https://github.com/vurtun/nuklear/pull/765.patch"},"body":"The issue was introduced in the fix for 416 (commit 8559aeb).\r\n\r\nThe original problem was (backspace and arrows moving too fast) is not a\r\nnuklear problem but a GLFW problem.  Because of the way nuklear handles\r\ninput (it must be between input_begin and end), the key callback method\r\nGLFW offers is not an option.\r\n\r\nSo we have to use glfwGetKey() which returns the current state of a key\r\nnot whether it was just pressed or released, so nuklear acts like it\r\nwas pressed every single frame, hence the \"too fast\" problem.\r\n\r\nThe fix checks for state change and discards the event if there was\r\nno change.  This kills key repeat behavior (for named keys) on\r\n*all* platforms which makes deleting or arrowing inconvenient.\r\n\r\nSince there's no way to fix the shortcomings of a callback vs event\r\nbased input API, my \"fix\" just makes the original fix conditional\r\non a macro NK_KEYSTATE_BASED_INPUT"},"comment":{"url":"https://api.github.com/repos/vurtun/nuklear/issues/comments/435136834","html_url":"https://github.com/vurtun/nuklear/pull/765#issuecomment-435136834","issue_url":"https://api.github.com/repos/vurtun/nuklear/issues/765","id":435136834,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTEzNjgzNA==","user":{"login":"vurtun","id":8057201,"node_id":"MDQ6VXNlcjgwNTcyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8057201?v=4","gravatar_id":"","url":"https://api.github.com/users/vurtun","html_url":"https://github.com/vurtun","followers_url":"https://api.github.com/users/vurtun/followers","following_url":"https://api.github.com/users/vurtun/following{/other_user}","gists_url":"https://api.github.com/users/vurtun/gists{/gist_id}","starred_url":"https://api.github.com/users/vurtun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vurtun/subscriptions","organizations_url":"https://api.github.com/users/vurtun/orgs","repos_url":"https://api.github.com/users/vurtun/repos","events_url":"https://api.github.com/users/vurtun/events{/privacy}","received_events_url":"https://api.github.com/users/vurtun/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T18:21:17Z","updated_at":"2018-11-01T18:21:17Z","author_association":"OWNER","body":"Thanks @rswinkle for your work and this PR."}}
{"actor":{"display_login":"vurtun"}}