{"action":"created","comment":{"url":"https://api.github.com/repos/xamarin/Essentials/pulls/comments/236901541","pull_request_review_id":179076507,"id":236901541,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjkwMTU0MQ==","diff_hunk":"@@ -42,6 +42,10 @@ static async Task<PermissionStatus> PlatformRequestAsync(PermissionType permissi\n             switch (permission)\n             {\n                 case PermissionType.LocationWhenInUse:\n+\n+                    if (!MainThread.IsMainThread)\n+                        throw new PermissionException(\"Permission request must be invoked on main thread.\");","path":"Xamarin.Essentials/Permissions/Permissions.ios.cs","position":6,"original_position":6,"commit_id":"804d0408a642bcf3a121472aca06ac9f44fdee02","original_commit_id":"804d0408a642bcf3a121472aca06ac9f44fdee02","user":{"login":"Redth","id":271950,"node_id":"MDQ6VXNlcjI3MTk1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271950?v=4","gravatar_id":"","url":"https://api.github.com/users/Redth","html_url":"https://github.com/Redth","followers_url":"https://api.github.com/users/Redth/followers","following_url":"https://api.github.com/users/Redth/following{/other_user}","gists_url":"https://api.github.com/users/Redth/gists{/gist_id}","starred_url":"https://api.github.com/users/Redth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redth/subscriptions","organizations_url":"https://api.github.com/users/Redth/orgs","repos_url":"https://api.github.com/users/Redth/repos","events_url":"https://api.github.com/users/Redth/events{/privacy}","received_events_url":"https://api.github.com/users/Redth/received_events","type":"User","site_admin":false},"body":"We currently only actually invoke some api to request permission for Location.  In the future as more might be added we'll have to ask this question for those other permission requests.  I think with iOS yeah likely any other one will require this check.","created_at":"2018-11-28T00:33:09Z","updated_at":"2018-11-28T00:33:09Z","html_url":"https://github.com/xamarin/Essentials/pull/626#discussion_r236901541","pull_request_url":"https://api.github.com/repos/xamarin/Essentials/pulls/626","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xamarin/Essentials/pulls/comments/236901541"},"html":{"href":"https://github.com/xamarin/Essentials/pull/626#discussion_r236901541"},"pull_request":{"href":"https://api.github.com/repos/xamarin/Essentials/pulls/626"}},"in_reply_to_id":235820159},"pull_request":{"url":"https://api.github.com/repos/xamarin/Essentials/pulls/626","id":232089935,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDg5OTM1","html_url":"https://github.com/xamarin/Essentials/pull/626","diff_url":"https://github.com/xamarin/Essentials/pull/626.diff","patch_url":"https://github.com/xamarin/Essentials/pull/626.patch","issue_url":"https://api.github.com/repos/xamarin/Essentials/issues/626","number":626,"state":"open","locked":false,"title":"GH-621: Ensure we only check is main thread when prompting ","user":{"login":"jamesmontemagno","id":1676321,"node_id":"MDQ6VXNlcjE2NzYzMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1676321?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmontemagno","html_url":"https://github.com/jamesmontemagno","followers_url":"https://api.github.com/users/jamesmontemagno/followers","following_url":"https://api.github.com/users/jamesmontemagno/following{/other_user}","gists_url":"https://api.github.com/users/jamesmontemagno/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmontemagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmontemagno/subscriptions","organizations_url":"https://api.github.com/users/jamesmontemagno/orgs","repos_url":"https://api.github.com/users/jamesmontemagno/repos","events_url":"https://api.github.com/users/jamesmontemagno/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmontemagno/received_events","type":"User","site_admin":false},"body":"UWP needs it all the time :(\r\n\r\n### Description of Change ###\r\n\r\nDescribe your changes here. \r\n\r\n### Bugs Fixed ###\r\n\r\n- Related to issue #621\r\n\r\nProvide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.\r\n\r\n### API Changes ###\r\n\r\nList all API changes here (or just put None), example:\r\n\r\nAdded: \r\n \r\n- string - string Class.Property { get; set; } \r\n- void Class.Method();\r\n\r\nChanged:\r\n\r\n - object Cell.OldPropertyName => object Cell.NewPropertyName\r\n\r\n### Behavioral Changes ###\r\n\r\nDescribe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.\r\n\r\n### PR Checklist ###\r\n\r\n- [x] Has tests (if omitted, state reason in description)\r\n- [x] Has samples (if omitted, state reason in description)\r\n- [x] Rebased on top of master at time of PR\r\n- [x] Changes adhere to coding standard\r\n- [x] Updated documentation ([see walkthrough](https://github.com/xamarin/Essentials/wiki/Documenting-your-code-with-mdoc))\r\n","created_at":"2018-11-19T19:42:33Z","updated_at":"2018-11-28T00:33:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6927c9d8da739781cc12ffd5be1bd1428fdbe072","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":852078724,"node_id":"MDU6TGFiZWw4NTIwNzg3MjQ=","url":"https://api.github.com/repos/xamarin/Essentials/labels/awaiting%20review","name":"awaiting review","color":"d93f0b","default":false}],"milestone":{"url":"https://api.github.com/repos/xamarin/Essentials/milestones/10","html_url":"https://github.com/xamarin/Essentials/milestone/10","labels_url":"https://api.github.com/repos/xamarin/Essentials/milestones/10/labels","id":3789096,"node_id":"MDk6TWlsZXN0b25lMzc4OTA5Ng==","number":10,"title":"1.0.0","description":null,"creator":{"login":"Redth","id":271950,"node_id":"MDQ6VXNlcjI3MTk1MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271950?v=4","gravatar_id":"","url":"https://api.github.com/users/Redth","html_url":"https://github.com/Redth","followers_url":"https://api.github.com/users/Redth/followers","following_url":"https://api.github.com/users/Redth/following{/other_user}","gists_url":"https://api.github.com/users/Redth/gists{/gist_id}","starred_url":"https://api.github.com/users/Redth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Redth/subscriptions","organizations_url":"https://api.github.com/users/Redth/orgs","repos_url":"https://api.github.com/users/Redth/repos","events_url":"https://api.github.com/users/Redth/events{/privacy}","received_events_url":"https://api.github.com/users/Redth/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":44,"state":"open","created_at":"2018-11-01T20:43:47Z","updated_at":"2018-11-28T00:21:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/xamarin/Essentials/pulls/626/commits","review_comments_url":"https://api.github.com/repos/xamarin/Essentials/pulls/626/comments","review_comment_url":"https://api.github.com/repos/xamarin/Essentials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xamarin/Essentials/issues/626/comments","statuses_url":"https://api.github.com/repos/xamarin/Essentials/statuses/804d0408a642bcf3a121472aca06ac9f44fdee02","head":{"label":"xamarin:dev/api-fix-ui-thread-621","ref":"dev/api-fix-ui-thread-621","sha":"804d0408a642bcf3a121472aca06ac9f44fdee02","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":122229247,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMjkyNDc=","name":"Essentials","full_name":"xamarin/Essentials","private":false,"owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xamarin/Essentials","description":"Essential cross platform APIs for your mobile apps.","fork":false,"url":"https://api.github.com/repos/xamarin/Essentials","forks_url":"https://api.github.com/repos/xamarin/Essentials/forks","keys_url":"https://api.github.com/repos/xamarin/Essentials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Essentials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Essentials/teams","hooks_url":"https://api.github.com/repos/xamarin/Essentials/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Essentials/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Essentials/events","assignees_url":"https://api.github.com/repos/xamarin/Essentials/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Essentials/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Essentials/tags","blobs_url":"https://api.github.com/repos/xamarin/Essentials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Essentials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Essentials/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Essentials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Essentials/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Essentials/languages","stargazers_url":"https://api.github.com/repos/xamarin/Essentials/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Essentials/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Essentials/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Essentials/subscription","commits_url":"https://api.github.com/repos/xamarin/Essentials/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Essentials/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Essentials/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Essentials/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Essentials/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Essentials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Essentials/merges","archive_url":"https://api.github.com/repos/xamarin/Essentials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Essentials/downloads","issues_url":"https://api.github.com/repos/xamarin/Essentials/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Essentials/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Essentials/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Essentials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Essentials/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Essentials/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Essentials/deployments","created_at":"2018-02-20T17:11:53Z","updated_at":"2018-11-27T22:36:08Z","pushed_at":"2018-11-26T17:05:13Z","git_url":"git://github.com/xamarin/Essentials.git","ssh_url":"git@github.com:xamarin/Essentials.git","clone_url":"https://github.com/xamarin/Essentials.git","svn_url":"https://github.com/xamarin/Essentials","homepage":"","size":13323,"stargazers_count":679,"watchers_count":679,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":144,"open_issues":53,"watchers":679,"default_branch":"master"}},"base":{"label":"xamarin:dev/api-fix","ref":"dev/api-fix","sha":"e0b392ed9e75133c3a03d1a6e8376141d265a7f0","user":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"repo":{"id":122229247,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyMjkyNDc=","name":"Essentials","full_name":"xamarin/Essentials","private":false,"owner":{"login":"xamarin","id":790012,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MDAxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/790012?v=4","gravatar_id":"","url":"https://api.github.com/users/xamarin","html_url":"https://github.com/xamarin","followers_url":"https://api.github.com/users/xamarin/followers","following_url":"https://api.github.com/users/xamarin/following{/other_user}","gists_url":"https://api.github.com/users/xamarin/gists{/gist_id}","starred_url":"https://api.github.com/users/xamarin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xamarin/subscriptions","organizations_url":"https://api.github.com/users/xamarin/orgs","repos_url":"https://api.github.com/users/xamarin/repos","events_url":"https://api.github.com/users/xamarin/events{/privacy}","received_events_url":"https://api.github.com/users/xamarin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/xamarin/Essentials","description":"Essential cross platform APIs for your mobile apps.","fork":false,"url":"https://api.github.com/repos/xamarin/Essentials","forks_url":"https://api.github.com/repos/xamarin/Essentials/forks","keys_url":"https://api.github.com/repos/xamarin/Essentials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xamarin/Essentials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xamarin/Essentials/teams","hooks_url":"https://api.github.com/repos/xamarin/Essentials/hooks","issue_events_url":"https://api.github.com/repos/xamarin/Essentials/issues/events{/number}","events_url":"https://api.github.com/repos/xamarin/Essentials/events","assignees_url":"https://api.github.com/repos/xamarin/Essentials/assignees{/user}","branches_url":"https://api.github.com/repos/xamarin/Essentials/branches{/branch}","tags_url":"https://api.github.com/repos/xamarin/Essentials/tags","blobs_url":"https://api.github.com/repos/xamarin/Essentials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xamarin/Essentials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xamarin/Essentials/git/refs{/sha}","trees_url":"https://api.github.com/repos/xamarin/Essentials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xamarin/Essentials/statuses/{sha}","languages_url":"https://api.github.com/repos/xamarin/Essentials/languages","stargazers_url":"https://api.github.com/repos/xamarin/Essentials/stargazers","contributors_url":"https://api.github.com/repos/xamarin/Essentials/contributors","subscribers_url":"https://api.github.com/repos/xamarin/Essentials/subscribers","subscription_url":"https://api.github.com/repos/xamarin/Essentials/subscription","commits_url":"https://api.github.com/repos/xamarin/Essentials/commits{/sha}","git_commits_url":"https://api.github.com/repos/xamarin/Essentials/git/commits{/sha}","comments_url":"https://api.github.com/repos/xamarin/Essentials/comments{/number}","issue_comment_url":"https://api.github.com/repos/xamarin/Essentials/issues/comments{/number}","contents_url":"https://api.github.com/repos/xamarin/Essentials/contents/{+path}","compare_url":"https://api.github.com/repos/xamarin/Essentials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xamarin/Essentials/merges","archive_url":"https://api.github.com/repos/xamarin/Essentials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xamarin/Essentials/downloads","issues_url":"https://api.github.com/repos/xamarin/Essentials/issues{/number}","pulls_url":"https://api.github.com/repos/xamarin/Essentials/pulls{/number}","milestones_url":"https://api.github.com/repos/xamarin/Essentials/milestones{/number}","notifications_url":"https://api.github.com/repos/xamarin/Essentials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xamarin/Essentials/labels{/name}","releases_url":"https://api.github.com/repos/xamarin/Essentials/releases{/id}","deployments_url":"https://api.github.com/repos/xamarin/Essentials/deployments","created_at":"2018-02-20T17:11:53Z","updated_at":"2018-11-27T22:36:08Z","pushed_at":"2018-11-26T17:05:13Z","git_url":"git://github.com/xamarin/Essentials.git","ssh_url":"git@github.com:xamarin/Essentials.git","clone_url":"https://github.com/xamarin/Essentials.git","svn_url":"https://github.com/xamarin/Essentials","homepage":"","size":13323,"stargazers_count":679,"watchers_count":679,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":144,"open_issues":53,"watchers":679,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xamarin/Essentials/pulls/626"},"html":{"href":"https://github.com/xamarin/Essentials/pull/626"},"issue":{"href":"https://api.github.com/repos/xamarin/Essentials/issues/626"},"comments":{"href":"https://api.github.com/repos/xamarin/Essentials/issues/626/comments"},"review_comments":{"href":"https://api.github.com/repos/xamarin/Essentials/pulls/626/comments"},"review_comment":{"href":"https://api.github.com/repos/xamarin/Essentials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xamarin/Essentials/pulls/626/commits"},"statuses":{"href":"https://api.github.com/repos/xamarin/Essentials/statuses/804d0408a642bcf3a121472aca06ac9f44fdee02"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Redth"}}