{"action":"created","comment":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/222836331","pull_request_review_id":161812560,"id":222836331,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjgzNjMzMQ==","diff_hunk":"@@ -425,22 +424,70 @@ def test_pantsd_killed_run(self):\n       )\n \n       # Wait for the python run to be running.\n-      time.sleep(15)\n+      time.sleep(5)\n       checker.assert_started()\n \n       # Locate the single \"parent\" pantsd-runner process, and kill it.\n       pantsd_runner_processes = [p for p in checker.runner_process_context.current_processes()\n                                  if p.ppid() == 1]\n       self.assertEquals(1, len(pantsd_runner_processes))\n-      pantsd_runner_processes[0].terminate()\n+      parent_runner_process = pantsd_runner_processes[0]\n+      parent_runner_pid = parent_runner_process.pid\n+      # Send SIGTERM\n+      parent_runner_process.terminate()\n       waiter_run = waiter_handle.join()\n \n       # Ensure that we saw the failure in the client's stdout, and that we got a remote exception.\n       self.assert_failure(waiter_run)\n-      self.assertIn('abruptly lost active connection to pantsd runner', waiter_run.stderr_data)\n+      self.assertRegexpMatches(waiter_run.stderr_data, \"\"\"\\\n+Signal {signum} was raised\\\\. Exiting with failure\\\\.\n+\\\\(backtrace omitted\\\\)\n+\"\"\".format(pid=parent_runner_pid, signum=signal.SIGTERM))","path":"tests/python/pants_test/pantsd/test_pantsd_integration.py","position":47,"original_position":47,"commit_id":"f70e7c0b7d55a389d31b9b3b706d0901bc9f655e","original_commit_id":"f70e7c0b7d55a389d31b9b3b706d0901bc9f655e","user":{"login":"stuhood","id":46740,"node_id":"MDQ6VXNlcjQ2NzQw","avatar_url":"https://avatars1.githubusercontent.com/u/46740?v=4","gravatar_id":"","url":"https://api.github.com/users/stuhood","html_url":"https://github.com/stuhood","followers_url":"https://api.github.com/users/stuhood/followers","following_url":"https://api.github.com/users/stuhood/following{/other_user}","gists_url":"https://api.github.com/users/stuhood/gists{/gist_id}","starred_url":"https://api.github.com/users/stuhood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuhood/subscriptions","organizations_url":"https://api.github.com/users/stuhood/orgs","repos_url":"https://api.github.com/users/stuhood/repos","events_url":"https://api.github.com/users/stuhood/events{/privacy}","received_events_url":"https://api.github.com/users/stuhood/received_events","type":"User","site_admin":false},"body":"The `pid` isn't used here, but that's probably fine: telling someone the dead pid is less necessary than rendering the error.","created_at":"2018-10-04T21:41:43Z","updated_at":"2018-10-04T21:43:40Z","html_url":"https://github.com/pantsbuild/pants/pull/6552#discussion_r222836331","pull_request_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6552","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments/222836331"},"html":{"href":"https://github.com/pantsbuild/pants/pull/6552#discussion_r222836331"},"pull_request":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6552"}}},"pull_request":{"url":"https://api.github.com/repos/pantsbuild/pants/pulls/6552","id":217806745,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODA2NzQ1","html_url":"https://github.com/pantsbuild/pants/pull/6552","diff_url":"https://github.com/pantsbuild/pants/pull/6552.diff","patch_url":"https://github.com/pantsbuild/pants/pull/6552.patch","issue_url":"https://api.github.com/repos/pantsbuild/pants/issues/6552","number":6552,"state":"open","locked":false,"title":"[WIP] first attempt at centralizing more global error logging state in ExceptionSink","user":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"body":"*still marked WIP because I need to update the OP*\r\n\r\n### Problem\r\n\r\n*a first attempt at centralizing more global error logging state in ExceptionSink*\r\n\r\n(_explain the context of the problem and why you're making this change. include\r\nreferences to all relevant github issues._)\r\n\r\n### Solution\r\n\r\n- *make it handle SIGUSR2 and unhandled exceptions so we can move that logic out of Exiter*\r\n\r\n(_describe the modifications you've made._)\r\n\r\n### Result\r\n\r\n(_describe how your changes affect the end-user behavior of the system. this section is\r\noptional, and should generally be summarized in the title of the pull request._)","created_at":"2018-09-24T22:29:13Z","updated_at":"2018-10-04T21:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c59bee89170fd4ca8d28a1b599c7582887a33e36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6552/commits","review_comments_url":"https://api.github.com/repos/pantsbuild/pants/pulls/6552/comments","review_comment_url":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pantsbuild/pants/issues/6552/comments","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/f70e7c0b7d55a389d31b9b3b706d0901bc9f655e","head":{"label":"cosmicexplorer:catch-everything","ref":"catch-everything","sha":"f70e7c0b7d55a389d31b9b3b706d0901bc9f655e","user":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"repo":{"id":59165183,"node_id":"MDEwOlJlcG9zaXRvcnk1OTE2NTE4Mw==","name":"pants","full_name":"cosmicexplorer/pants","private":false,"owner":{"login":"cosmicexplorer","id":1305167,"node_id":"MDQ6VXNlcjEzMDUxNjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1305167?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmicexplorer","html_url":"https://github.com/cosmicexplorer","followers_url":"https://api.github.com/users/cosmicexplorer/followers","following_url":"https://api.github.com/users/cosmicexplorer/following{/other_user}","gists_url":"https://api.github.com/users/cosmicexplorer/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmicexplorer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmicexplorer/subscriptions","organizations_url":"https://api.github.com/users/cosmicexplorer/orgs","repos_url":"https://api.github.com/users/cosmicexplorer/repos","events_url":"https://api.github.com/users/cosmicexplorer/events{/privacy}","received_events_url":"https://api.github.com/users/cosmicexplorer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cosmicexplorer/pants","description":"Pants Build System","fork":true,"url":"https://api.github.com/repos/cosmicexplorer/pants","forks_url":"https://api.github.com/repos/cosmicexplorer/pants/forks","keys_url":"https://api.github.com/repos/cosmicexplorer/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmicexplorer/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmicexplorer/pants/teams","hooks_url":"https://api.github.com/repos/cosmicexplorer/pants/hooks","issue_events_url":"https://api.github.com/repos/cosmicexplorer/pants/issues/events{/number}","events_url":"https://api.github.com/repos/cosmicexplorer/pants/events","assignees_url":"https://api.github.com/repos/cosmicexplorer/pants/assignees{/user}","branches_url":"https://api.github.com/repos/cosmicexplorer/pants/branches{/branch}","tags_url":"https://api.github.com/repos/cosmicexplorer/pants/tags","blobs_url":"https://api.github.com/repos/cosmicexplorer/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmicexplorer/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmicexplorer/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmicexplorer/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmicexplorer/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmicexplorer/pants/languages","stargazers_url":"https://api.github.com/repos/cosmicexplorer/pants/stargazers","contributors_url":"https://api.github.com/repos/cosmicexplorer/pants/contributors","subscribers_url":"https://api.github.com/repos/cosmicexplorer/pants/subscribers","subscription_url":"https://api.github.com/repos/cosmicexplorer/pants/subscription","commits_url":"https://api.github.com/repos/cosmicexplorer/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmicexplorer/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmicexplorer/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmicexplorer/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmicexplorer/pants/contents/{+path}","compare_url":"https://api.github.com/repos/cosmicexplorer/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmicexplorer/pants/merges","archive_url":"https://api.github.com/repos/cosmicexplorer/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmicexplorer/pants/downloads","issues_url":"https://api.github.com/repos/cosmicexplorer/pants/issues{/number}","pulls_url":"https://api.github.com/repos/cosmicexplorer/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmicexplorer/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmicexplorer/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmicexplorer/pants/labels{/name}","releases_url":"https://api.github.com/repos/cosmicexplorer/pants/releases{/id}","deployments_url":"https://api.github.com/repos/cosmicexplorer/pants/deployments","created_at":"2016-05-19T01:53:21Z","updated_at":"2018-10-02T22:02:50Z","pushed_at":"2018-10-04T20:20:18Z","git_url":"git://github.com/cosmicexplorer/pants.git","ssh_url":"git@github.com:cosmicexplorer/pants.git","clone_url":"https://github.com/cosmicexplorer/pants.git","svn_url":"https://github.com/cosmicexplorer/pants","homepage":"http://pantsbuild.github.io/","size":90185,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pantsbuild:master","ref":"master","sha":"24d20e75838d3cb2b44de5e312fa6abe5b0c9413","user":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":7209075,"node_id":"MDEwOlJlcG9zaXRvcnk3MjA5MDc1","name":"pants","full_name":"pantsbuild/pants","private":false,"owner":{"login":"pantsbuild","id":3065172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjUxNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3065172?v=4","gravatar_id":"","url":"https://api.github.com/users/pantsbuild","html_url":"https://github.com/pantsbuild","followers_url":"https://api.github.com/users/pantsbuild/followers","following_url":"https://api.github.com/users/pantsbuild/following{/other_user}","gists_url":"https://api.github.com/users/pantsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/pantsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantsbuild/subscriptions","organizations_url":"https://api.github.com/users/pantsbuild/orgs","repos_url":"https://api.github.com/users/pantsbuild/repos","events_url":"https://api.github.com/users/pantsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/pantsbuild/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pantsbuild/pants","description":"The Pants Build System","fork":false,"url":"https://api.github.com/repos/pantsbuild/pants","forks_url":"https://api.github.com/repos/pantsbuild/pants/forks","keys_url":"https://api.github.com/repos/pantsbuild/pants/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pantsbuild/pants/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pantsbuild/pants/teams","hooks_url":"https://api.github.com/repos/pantsbuild/pants/hooks","issue_events_url":"https://api.github.com/repos/pantsbuild/pants/issues/events{/number}","events_url":"https://api.github.com/repos/pantsbuild/pants/events","assignees_url":"https://api.github.com/repos/pantsbuild/pants/assignees{/user}","branches_url":"https://api.github.com/repos/pantsbuild/pants/branches{/branch}","tags_url":"https://api.github.com/repos/pantsbuild/pants/tags","blobs_url":"https://api.github.com/repos/pantsbuild/pants/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pantsbuild/pants/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pantsbuild/pants/git/refs{/sha}","trees_url":"https://api.github.com/repos/pantsbuild/pants/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pantsbuild/pants/statuses/{sha}","languages_url":"https://api.github.com/repos/pantsbuild/pants/languages","stargazers_url":"https://api.github.com/repos/pantsbuild/pants/stargazers","contributors_url":"https://api.github.com/repos/pantsbuild/pants/contributors","subscribers_url":"https://api.github.com/repos/pantsbuild/pants/subscribers","subscription_url":"https://api.github.com/repos/pantsbuild/pants/subscription","commits_url":"https://api.github.com/repos/pantsbuild/pants/commits{/sha}","git_commits_url":"https://api.github.com/repos/pantsbuild/pants/git/commits{/sha}","comments_url":"https://api.github.com/repos/pantsbuild/pants/comments{/number}","issue_comment_url":"https://api.github.com/repos/pantsbuild/pants/issues/comments{/number}","contents_url":"https://api.github.com/repos/pantsbuild/pants/contents/{+path}","compare_url":"https://api.github.com/repos/pantsbuild/pants/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pantsbuild/pants/merges","archive_url":"https://api.github.com/repos/pantsbuild/pants/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pantsbuild/pants/downloads","issues_url":"https://api.github.com/repos/pantsbuild/pants/issues{/number}","pulls_url":"https://api.github.com/repos/pantsbuild/pants/pulls{/number}","milestones_url":"https://api.github.com/repos/pantsbuild/pants/milestones{/number}","notifications_url":"https://api.github.com/repos/pantsbuild/pants/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pantsbuild/pants/labels{/name}","releases_url":"https://api.github.com/repos/pantsbuild/pants/releases{/id}","deployments_url":"https://api.github.com/repos/pantsbuild/pants/deployments","created_at":"2012-12-17T17:39:04Z","updated_at":"2018-10-04T20:22:26Z","pushed_at":"2018-10-04T21:01:12Z","git_url":"git://github.com/pantsbuild/pants.git","ssh_url":"git@github.com:pantsbuild/pants.git","clone_url":"https://github.com/pantsbuild/pants.git","svn_url":"https://github.com/pantsbuild/pants","homepage":"http://pantsbuild.org/","size":88194,"stargazers_count":1027,"watchers_count":1027,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":298,"mirror_url":null,"archived":false,"open_issues_count":727,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":298,"open_issues":727,"watchers":1027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6552"},"html":{"href":"https://github.com/pantsbuild/pants/pull/6552"},"issue":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/6552"},"comments":{"href":"https://api.github.com/repos/pantsbuild/pants/issues/6552/comments"},"review_comments":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6552/comments"},"review_comment":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pantsbuild/pants/pulls/6552/commits"},"statuses":{"href":"https://api.github.com/repos/pantsbuild/pants/statuses/f70e7c0b7d55a389d31b9b3b706d0901bc9f655e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stuhood"}}