{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/241","repository_url":"https://api.github.com/repos/sillsdev/web-languageforge","labels_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/241/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/241/comments","events_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/241/events","html_url":"https://github.com/sillsdev/web-languageforge/pull/241","id":319368363,"number":241,"title":"New LF Header Layout","user":{"login":"nigel-wells","id":17464863,"avatar_url":"https://avatars0.githubusercontent.com/u/17464863?v=4","gravatar_id":"","url":"https://api.github.com/users/nigel-wells","html_url":"https://github.com/nigel-wells","followers_url":"https://api.github.com/users/nigel-wells/followers","following_url":"https://api.github.com/users/nigel-wells/following{/other_user}","gists_url":"https://api.github.com/users/nigel-wells/gists{/gist_id}","starred_url":"https://api.github.com/users/nigel-wells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigel-wells/subscriptions","organizations_url":"https://api.github.com/users/nigel-wells/orgs","repos_url":"https://api.github.com/users/nigel-wells/repos","events_url":"https://api.github.com/users/nigel-wells/events{/privacy}","received_events_url":"https://api.github.com/users/nigel-wells/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-05-02T00:03:42Z","updated_at":"2018-05-02T21:06:52Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/pulls/241","html_url":"https://github.com/sillsdev/web-languageforge/pull/241","diff_url":"https://github.com/sillsdev/web-languageforge/pull/241.diff","patch_url":"https://github.com/sillsdev/web-languageforge/pull/241.patch"},"body":"Relates to https://trello.com/c/E0WVx3WN\r\n\r\nCovers a new layout to the header area for desktop and mobile.\r\n\r\nMost apps have been updated for setting the breadcrumbs and new page name\r\n\r\nSettings can now be set per app or view\r\n\r\n![image](https://user-images.githubusercontent.com/17464863/39499210-ac2d2758-4e00-11e8-9314-ea1485f04a85.png)\r\n\r\n![image](https://user-images.githubusercontent.com/17464863/39499226-ba79f8ae-4e00-11e8-8b98-06629dbf5661.png)\r\n\r\nThere are a couple of E2E tests failing but they also fail for me in `master` so I assume this is ok.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/sillsdev/web-languageforge/241)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/comments/386121398","html_url":"https://github.com/sillsdev/web-languageforge/pull/241#issuecomment-386121398","issue_url":"https://api.github.com/repos/sillsdev/web-languageforge/issues/241","id":386121398,"user":{"login":"nigel-wells","id":17464863,"avatar_url":"https://avatars0.githubusercontent.com/u/17464863?v=4","gravatar_id":"","url":"https://api.github.com/users/nigel-wells","html_url":"https://github.com/nigel-wells","followers_url":"https://api.github.com/users/nigel-wells/followers","following_url":"https://api.github.com/users/nigel-wells/following{/other_user}","gists_url":"https://api.github.com/users/nigel-wells/gists{/gist_id}","starred_url":"https://api.github.com/users/nigel-wells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigel-wells/subscriptions","organizations_url":"https://api.github.com/users/nigel-wells/orgs","repos_url":"https://api.github.com/users/nigel-wells/repos","events_url":"https://api.github.com/users/nigel-wells/events{/privacy}","received_events_url":"https://api.github.com/users/nigel-wells/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T21:06:52Z","updated_at":"2018-05-02T21:06:52Z","author_association":"COLLABORATOR","body":"Chris, yes that will work for the language selector to place it in the hamburger menu for mobile and always visible for other devices.\n\nI've pushed through style change for the typeahead component. Now just the 3 failed E2E which I get in master as well.\n\n---\n\nReview status: 41 of 42 files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/sillsdev/web-languageforge/241#-:-LBXZ0Zm3BRSeQyraWey:b-9chm3w)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"nigel-wells"}}