{"action":"created","comment":{"url":"https://api.github.com/repos/ericmj/xhttp/pulls/comments/239152606","pull_request_review_id":181866516,"id":239152606,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTE1MjYwNg==","diff_hunk":"@@ -20,13 +20,10 @@ defmodule XHTTP.TunnelProxyConn do\n   end\n \n   defp upgrade_connection(conn, {scheme, hostname, port, opts}) do\n-    old_transport = conn_to_transport(conn)\n-    XHTTPN.Conn.upgrade(old_transport, conn, scheme, hostname, port, opts)\n+    {transport, transport_state} = XHTTP1.Conn.get_transport(conn)","path":"lib/xhttp/tunnel_proxy_conn.ex","position":17,"original_position":17,"commit_id":"db9725b586ea88ec22d724cf5f52df84df360765","original_commit_id":"0c7cf77a41860388e81d4c7f1ecb15a678199e27","user":{"login":"josevalim","id":9582,"node_id":"MDQ6VXNlcjk1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9582?v=4","gravatar_id":"","url":"https://api.github.com/users/josevalim","html_url":"https://github.com/josevalim","followers_url":"https://api.github.com/users/josevalim/followers","following_url":"https://api.github.com/users/josevalim/following{/other_user}","gists_url":"https://api.github.com/users/josevalim/gists{/gist_id}","starred_url":"https://api.github.com/users/josevalim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josevalim/subscriptions","organizations_url":"https://api.github.com/users/josevalim/orgs","repos_url":"https://api.github.com/users/josevalim/repos","events_url":"https://api.github.com/users/josevalim/events{/privacy}","received_events_url":"https://api.github.com/users/josevalim/received_events","type":"User","site_admin":false},"body":"@ericmj We would still need a `get_socket` then, no?","created_at":"2018-12-05T17:00:27Z","updated_at":"2018-12-05T17:00:27Z","html_url":"https://github.com/ericmj/xhttp/pull/52#discussion_r239152606","pull_request_url":"https://api.github.com/repos/ericmj/xhttp/pulls/52","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ericmj/xhttp/pulls/comments/239152606"},"html":{"href":"https://github.com/ericmj/xhttp/pull/52#discussion_r239152606"},"pull_request":{"href":"https://api.github.com/repos/ericmj/xhttp/pulls/52"}},"in_reply_to_id":239143723},"pull_request":{"url":"https://api.github.com/repos/ericmj/xhttp/pulls/52","id":236242522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjQyNTIy","html_url":"https://github.com/ericmj/xhttp/pull/52","diff_url":"https://github.com/ericmj/xhttp/pull/52.diff","patch_url":"https://github.com/ericmj/xhttp/pull/52.patch","issue_url":"https://api.github.com/repos/ericmj/xhttp/issues/52","number":52,"state":"open","locked":false,"title":"Remove HTTP1 transport","user":{"login":"ericmj","id":316890,"node_id":"MDQ6VXNlcjMxNjg5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/316890?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-05T16:37:36Z","updated_at":"2018-12-05T17:00:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a560adc9378b31e07f316707693b49a89ae60a59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ericmj/xhttp/pulls/52/commits","review_comments_url":"https://api.github.com/repos/ericmj/xhttp/pulls/52/comments","review_comment_url":"https://api.github.com/repos/ericmj/xhttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericmj/xhttp/issues/52/comments","statuses_url":"https://api.github.com/repos/ericmj/xhttp/statuses/db9725b586ea88ec22d724cf5f52df84df360765","head":{"label":"ericmj:emj/remove-http1-transport","ref":"emj/remove-http1-transport","sha":"db9725b586ea88ec22d724cf5f52df84df360765","user":{"login":"ericmj","id":316890,"node_id":"MDQ6VXNlcjMxNjg5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/316890?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"repo":{"id":108273415,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzM0MTU=","name":"xhttp","full_name":"ericmj/xhttp","private":false,"owner":{"login":"ericmj","id":316890,"node_id":"MDQ6VXNlcjMxNjg5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/316890?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ericmj/xhttp","description":"Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2","fork":false,"url":"https://api.github.com/repos/ericmj/xhttp","forks_url":"https://api.github.com/repos/ericmj/xhttp/forks","keys_url":"https://api.github.com/repos/ericmj/xhttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericmj/xhttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericmj/xhttp/teams","hooks_url":"https://api.github.com/repos/ericmj/xhttp/hooks","issue_events_url":"https://api.github.com/repos/ericmj/xhttp/issues/events{/number}","events_url":"https://api.github.com/repos/ericmj/xhttp/events","assignees_url":"https://api.github.com/repos/ericmj/xhttp/assignees{/user}","branches_url":"https://api.github.com/repos/ericmj/xhttp/branches{/branch}","tags_url":"https://api.github.com/repos/ericmj/xhttp/tags","blobs_url":"https://api.github.com/repos/ericmj/xhttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericmj/xhttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericmj/xhttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericmj/xhttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericmj/xhttp/statuses/{sha}","languages_url":"https://api.github.com/repos/ericmj/xhttp/languages","stargazers_url":"https://api.github.com/repos/ericmj/xhttp/stargazers","contributors_url":"https://api.github.com/repos/ericmj/xhttp/contributors","subscribers_url":"https://api.github.com/repos/ericmj/xhttp/subscribers","subscription_url":"https://api.github.com/repos/ericmj/xhttp/subscription","commits_url":"https://api.github.com/repos/ericmj/xhttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericmj/xhttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericmj/xhttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericmj/xhttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericmj/xhttp/contents/{+path}","compare_url":"https://api.github.com/repos/ericmj/xhttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericmj/xhttp/merges","archive_url":"https://api.github.com/repos/ericmj/xhttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericmj/xhttp/downloads","issues_url":"https://api.github.com/repos/ericmj/xhttp/issues{/number}","pulls_url":"https://api.github.com/repos/ericmj/xhttp/pulls{/number}","milestones_url":"https://api.github.com/repos/ericmj/xhttp/milestones{/number}","notifications_url":"https://api.github.com/repos/ericmj/xhttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericmj/xhttp/labels{/name}","releases_url":"https://api.github.com/repos/ericmj/xhttp/releases{/id}","deployments_url":"https://api.github.com/repos/ericmj/xhttp/deployments","created_at":"2017-10-25T13:22:12Z","updated_at":"2018-12-05T14:41:53Z","pushed_at":"2018-12-05T16:53:55Z","git_url":"git://github.com/ericmj/xhttp.git","ssh_url":"git@github.com:ericmj/xhttp.git","clone_url":"https://github.com/ericmj/xhttp.git","svn_url":"https://github.com/ericmj/xhttp","homepage":"","size":243,"stargazers_count":181,"watchers_count":181,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":11,"open_issues":9,"watchers":181,"default_branch":"master"}},"base":{"label":"ericmj:master","ref":"master","sha":"08392bdb9673750999a10d8132a89a3fd0a824eb","user":{"login":"ericmj","id":316890,"node_id":"MDQ6VXNlcjMxNjg5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/316890?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"repo":{"id":108273415,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzM0MTU=","name":"xhttp","full_name":"ericmj/xhttp","private":false,"owner":{"login":"ericmj","id":316890,"node_id":"MDQ6VXNlcjMxNjg5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/316890?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ericmj/xhttp","description":"Functional HTTP client for Elixir with support for HTTP/1 and HTTP/2","fork":false,"url":"https://api.github.com/repos/ericmj/xhttp","forks_url":"https://api.github.com/repos/ericmj/xhttp/forks","keys_url":"https://api.github.com/repos/ericmj/xhttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericmj/xhttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericmj/xhttp/teams","hooks_url":"https://api.github.com/repos/ericmj/xhttp/hooks","issue_events_url":"https://api.github.com/repos/ericmj/xhttp/issues/events{/number}","events_url":"https://api.github.com/repos/ericmj/xhttp/events","assignees_url":"https://api.github.com/repos/ericmj/xhttp/assignees{/user}","branches_url":"https://api.github.com/repos/ericmj/xhttp/branches{/branch}","tags_url":"https://api.github.com/repos/ericmj/xhttp/tags","blobs_url":"https://api.github.com/repos/ericmj/xhttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericmj/xhttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericmj/xhttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericmj/xhttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericmj/xhttp/statuses/{sha}","languages_url":"https://api.github.com/repos/ericmj/xhttp/languages","stargazers_url":"https://api.github.com/repos/ericmj/xhttp/stargazers","contributors_url":"https://api.github.com/repos/ericmj/xhttp/contributors","subscribers_url":"https://api.github.com/repos/ericmj/xhttp/subscribers","subscription_url":"https://api.github.com/repos/ericmj/xhttp/subscription","commits_url":"https://api.github.com/repos/ericmj/xhttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericmj/xhttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericmj/xhttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericmj/xhttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericmj/xhttp/contents/{+path}","compare_url":"https://api.github.com/repos/ericmj/xhttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericmj/xhttp/merges","archive_url":"https://api.github.com/repos/ericmj/xhttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericmj/xhttp/downloads","issues_url":"https://api.github.com/repos/ericmj/xhttp/issues{/number}","pulls_url":"https://api.github.com/repos/ericmj/xhttp/pulls{/number}","milestones_url":"https://api.github.com/repos/ericmj/xhttp/milestones{/number}","notifications_url":"https://api.github.com/repos/ericmj/xhttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericmj/xhttp/labels{/name}","releases_url":"https://api.github.com/repos/ericmj/xhttp/releases{/id}","deployments_url":"https://api.github.com/repos/ericmj/xhttp/deployments","created_at":"2017-10-25T13:22:12Z","updated_at":"2018-12-05T14:41:53Z","pushed_at":"2018-12-05T16:53:55Z","git_url":"git://github.com/ericmj/xhttp.git","ssh_url":"git@github.com:ericmj/xhttp.git","clone_url":"https://github.com/ericmj/xhttp.git","svn_url":"https://github.com/ericmj/xhttp","homepage":"","size":243,"stargazers_count":181,"watchers_count":181,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":11,"open_issues":9,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ericmj/xhttp/pulls/52"},"html":{"href":"https://github.com/ericmj/xhttp/pull/52"},"issue":{"href":"https://api.github.com/repos/ericmj/xhttp/issues/52"},"comments":{"href":"https://api.github.com/repos/ericmj/xhttp/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/ericmj/xhttp/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/ericmj/xhttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericmj/xhttp/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/ericmj/xhttp/statuses/db9725b586ea88ec22d724cf5f52df84df360765"}},"author_association":"OWNER"}}
{"actor":{"display_login":"josevalim"}}