{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/237799002","pull_request_review_id":180185785,"id":237799002,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzc5OTAwMg==","diff_hunk":"@@ -65,16 +65,20 @@ struct FunctionSort: public Sort\n {\n \tFunctionSort(std::vector<SortPointer> _domain, SortPointer _codomain):\n \t\tSort(Kind::Function), domain(std::move(_domain)), codomain(std::move(_codomain)) {}\n-\tbool operator==(FunctionSort const& _other) const\n+\tbool operator==(Sort const& _other) const override\n \t{\n+\t\tif (!Sort::operator==(_other))\n+\t\t\treturn false;\n+\t\tauto _otherFunction = dynamic_cast<FunctionSort const*>(&_other);\n+\t\tsolAssert(_otherFunction, \"\");\n \t\tif (!std::equal(","path":"libsolidity/formal/SolverInterface.h","position":22,"original_position":20,"commit_id":"2f6de12e8ca98c92ee708081c3a3be05c2c30c6c","original_commit_id":"ada64fa3bddf474789d9878374563c42c304efcb","user":{"login":"leonardoalt","id":504195,"node_id":"MDQ6VXNlcjUwNDE5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/504195?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardoalt","html_url":"https://github.com/leonardoalt","followers_url":"https://api.github.com/users/leonardoalt/followers","following_url":"https://api.github.com/users/leonardoalt/following{/other_user}","gists_url":"https://api.github.com/users/leonardoalt/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardoalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardoalt/subscriptions","organizations_url":"https://api.github.com/users/leonardoalt/orgs","repos_url":"https://api.github.com/users/leonardoalt/repos","events_url":"https://api.github.com/users/leonardoalt/events{/privacy}","received_events_url":"https://api.github.com/users/leonardoalt/received_events","type":"User","site_admin":false},"body":"I'd rather check it explicitly if that's also fine. Updated.","created_at":"2018-11-30T09:41:34Z","updated_at":"2018-11-30T09:41:34Z","html_url":"https://github.com/ethereum/solidity/pull/5528#discussion_r237799002","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/5528","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/237799002"},"html":{"href":"https://github.com/ethereum/solidity/pull/5528#discussion_r237799002"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5528"}},"in_reply_to_id":237464741},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/5528","id":234255542,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MjU1NTQy","html_url":"https://github.com/ethereum/solidity/pull/5528","diff_url":"https://github.com/ethereum/solidity/pull/5528.diff","patch_url":"https://github.com/ethereum/solidity/pull/5528.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/5528","number":5528,"state":"open","locked":false,"title":"[SMTChecker] Make smt::Sort::operator== virtual","user":{"login":"leonardoalt","id":504195,"node_id":"MDQ6VXNlcjUwNDE5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/504195?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardoalt","html_url":"https://github.com/leonardoalt","followers_url":"https://api.github.com/users/leonardoalt/followers","following_url":"https://api.github.com/users/leonardoalt/following{/other_user}","gists_url":"https://api.github.com/users/leonardoalt/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardoalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardoalt/subscriptions","organizations_url":"https://api.github.com/users/leonardoalt/orgs","repos_url":"https://api.github.com/users/leonardoalt/repos","events_url":"https://api.github.com/users/leonardoalt/events{/privacy}","received_events_url":"https://api.github.com/users/leonardoalt/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-28T12:17:42Z","updated_at":"2018-11-30T09:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffee5a7fecbf3dcedef655effd5eb94684c50549","assignee":null,"assignees":[],"requested_reviewers":[{"login":"christianparpart","id":56763,"node_id":"MDQ6VXNlcjU2NzYz","avatar_url":"https://avatars1.githubusercontent.com/u/56763?v=4","gravatar_id":"","url":"https://api.github.com/users/christianparpart","html_url":"https://github.com/christianparpart","followers_url":"https://api.github.com/users/christianparpart/followers","following_url":"https://api.github.com/users/christianparpart/following{/other_user}","gists_url":"https://api.github.com/users/christianparpart/gists{/gist_id}","starred_url":"https://api.github.com/users/christianparpart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianparpart/subscriptions","organizations_url":"https://api.github.com/users/christianparpart/orgs","repos_url":"https://api.github.com/users/christianparpart/repos","events_url":"https://api.github.com/users/christianparpart/events{/privacy}","received_events_url":"https://api.github.com/users/christianparpart/received_events","type":"User","site_admin":false},{"login":"bit-shift","id":20012009,"node_id":"MDQ6VXNlcjIwMDEyMDA5","avatar_url":"https://avatars0.githubusercontent.com/u/20012009?v=4","gravatar_id":"","url":"https://api.github.com/users/bit-shift","html_url":"https://github.com/bit-shift","followers_url":"https://api.github.com/users/bit-shift/followers","following_url":"https://api.github.com/users/bit-shift/following{/other_user}","gists_url":"https://api.github.com/users/bit-shift/gists{/gist_id}","starred_url":"https://api.github.com/users/bit-shift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bit-shift/subscriptions","organizations_url":"https://api.github.com/users/bit-shift/orgs","repos_url":"https://api.github.com/users/bit-shift/repos","events_url":"https://api.github.com/users/bit-shift/events{/privacy}","received_events_url":"https://api.github.com/users/bit-shift/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/5528/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/5528/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/5528/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/2f6de12e8ca98c92ee708081c3a3be05c2c30c6c","head":{"label":"ethereum:smt_sorts_virtual","ref":"smt_sorts_virtual","sha":"2f6de12e8ca98c92ee708081c3a3be05c2c30c6c","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-11-30T09:37:05Z","pushed_at":"2018-11-30T09:41:23Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":25150,"stargazers_count":6380,"watchers_count":6380,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":633,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1722,"open_issues":633,"watchers":6380,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"6aa9ce2d4348aa5ee0d64854942db4adb0c8b9d2","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-11-30T09:37:05Z","pushed_at":"2018-11-30T09:41:23Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":25150,"stargazers_count":6380,"watchers_count":6380,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":633,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1722,"open_issues":633,"watchers":6380,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5528"},"html":{"href":"https://github.com/ethereum/solidity/pull/5528"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/5528"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/5528/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5528/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/5528/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/2f6de12e8ca98c92ee708081c3a3be05c2c30c6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"leonardoalt"}}