{"action":"closed","issue":{"url":"https://api.github.com/repos/linuxserver/docker-snipe-it/issues/1","repository_url":"https://api.github.com/repos/linuxserver/docker-snipe-it","labels_url":"https://api.github.com/repos/linuxserver/docker-snipe-it/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/linuxserver/docker-snipe-it/issues/1/comments","events_url":"https://api.github.com/repos/linuxserver/docker-snipe-it/issues/1/events","html_url":"https://github.com/linuxserver/docker-snipe-it/issues/1","id":331768780,"node_id":"MDU6SXNzdWUzMzE3Njg3ODA=","number":1,"title":"stuff, lol","user":{"login":"sparklyballs","id":4343808,"node_id":"MDQ6VXNlcjQzNDM4MDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4343808?v=4","gravatar_id":"","url":"https://api.github.com/users/sparklyballs","html_url":"https://github.com/sparklyballs","followers_url":"https://api.github.com/users/sparklyballs/followers","following_url":"https://api.github.com/users/sparklyballs/following{/other_user}","gists_url":"https://api.github.com/users/sparklyballs/gists{/gist_id}","starred_url":"https://api.github.com/users/sparklyballs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparklyballs/subscriptions","organizations_url":"https://api.github.com/users/sparklyballs/orgs","repos_url":"https://api.github.com/users/sparklyballs/repos","events_url":"https://api.github.com/users/sparklyballs/events{/privacy}","received_events_url":"https://api.github.com/users/sparklyballs/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-12T21:57:33Z","updated_at":"2018-06-15T21:11:03Z","closed_at":"2018-06-15T21:11:03Z","author_association":"MEMBER","body":"<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n[linuxserverurl]: https://linuxserver.io\r\n[![linuxserver.io](https://raw.githubusercontent.com/linuxserver/docker-templates/master/linuxserver.io/img/linuxserver_medium.png)][linuxserverurl]\r\n\t\r\n\r\n<!--- If you have an issue with the project, please provide us with the following information -->\r\n\r\n<!---  Host OS -->\r\n<!--- Command line users, your run/create command, GUI/Unraid users, a screenshot of your template settings. -->\r\n<!--- Docker log output, docker log <container-name>      -->\r\n<!--- Mention if you're using symlinks on any of the volume mounts. -->\r\n\r\n\r\n<!--- If you have a suggestion or fix for the project, please provide us with the following information -->\r\n\r\n<!--- What you think your suggestion brings to the project, or fixes with the project -->\r\n<!--- If it's a fix, would it be better suited as a Pull request to the repo ? -->\r\n\r\n##  Thanks, team linuxserver.io\r\n\r\nstuff i've seen so far\r\n+ stylistic changes (tabs, spaces etc) \r\n+ don't make folders or links etc to /config in the Dockerfile\r\n+ the loop for making the folders in the init file would be better served with \r\nmkdir -p /blah/{folder1,folder2,folder2} etc.........\r\n+ symlinks are the bastard son of a pestilent donkey, linking internal to volume mounts, if you must use them i can't see why you wouldn't just link the storage folder to the volume mount with one of the evil things, rather than multiple symlinks like that.\r\n+ need to give docker and core group admin status to the repo "}}
{"actor":{"display_login":"thelamer"}}