{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/228979987","pull_request_review_id":169368082,"id":228979987,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk3OTk4Nw==","diff_hunk":"@@ -53,6 +53,21 @@ func Procedure(name string, handler interface{}) []yarpc.TransportProcedure {\n \t}\n }\n \n+func procedure(name string, handler interface{}) []yarpc.EncodingProcedure {\n+\treturn []yarpc.EncodingProcedure{\n+\t\t{\n+\t\t\tName: name,\n+\t\t\tHandlerSpec: yarpc.NewUnaryEncodingHandlerSpec(\n+\t\t\t\tjsonHandler2{","path":"v2/yarpcjson/register.go","position":18,"original_position":18,"commit_id":"60ac2f507ce8a90031c256daa8f3479732e42c83","original_commit_id":"60ac2f507ce8a90031c256daa8f3479732e42c83","user":{"login":"kriskowal","id":60294,"node_id":"MDQ6VXNlcjYwMjk0","avatar_url":"https://avatars1.githubusercontent.com/u/60294?v=4","gravatar_id":"","url":"https://api.github.com/users/kriskowal","html_url":"https://github.com/kriskowal","followers_url":"https://api.github.com/users/kriskowal/followers","following_url":"https://api.github.com/users/kriskowal/following{/other_user}","gists_url":"https://api.github.com/users/kriskowal/gists{/gist_id}","starred_url":"https://api.github.com/users/kriskowal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kriskowal/subscriptions","organizations_url":"https://api.github.com/users/kriskowal/orgs","repos_url":"https://api.github.com/users/kriskowal/repos","events_url":"https://api.github.com/users/kriskowal/events{/privacy}","received_events_url":"https://api.github.com/users/kriskowal/received_events","type":"User","site_admin":false},"body":"Perhaps jsonEncodingHandler as opposed to the existing jsonTransportHandler, though that one goes away and this one simplifies back regardless. We’re not picky about temporary names, so whatever you like.","created_at":"2018-10-29T15:38:32Z","updated_at":"2018-10-29T15:41:15Z","html_url":"https://github.com/yarpc/yarpc-go/pull/1615#discussion_r228979987","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/228979987"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/1615#discussion_r228979987"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615","id":226466242,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NDY2MjQy","html_url":"https://github.com/yarpc/yarpc-go/pull/1615","diff_url":"https://github.com/yarpc/yarpc-go/pull/1615.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/1615.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/1615","number":1615,"state":"open","locked":false,"title":"[WIP][spring] Use JSON codec to construct EncodingProcedure","user":{"login":"vyshah","id":8011601,"node_id":"MDQ6VXNlcjgwMTE2MDE=","avatar_url":"https://avatars1.githubusercontent.com/u/8011601?v=4","gravatar_id":"","url":"https://api.github.com/users/vyshah","html_url":"https://github.com/vyshah","followers_url":"https://api.github.com/users/vyshah/followers","following_url":"https://api.github.com/users/vyshah/following{/other_user}","gists_url":"https://api.github.com/users/vyshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vyshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyshah/subscriptions","organizations_url":"https://api.github.com/users/vyshah/orgs","repos_url":"https://api.github.com/users/vyshah/repos","events_url":"https://api.github.com/users/vyshah/events{/privacy}","received_events_url":"https://api.github.com/users/vyshah/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-29T07:53:25Z","updated_at":"2018-10-29T15:41:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e43a237a333e38ed796fd7d5dc6bc0eb6ca41327","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/1615/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/60ac2f507ce8a90031c256daa8f3479732e42c83","head":{"label":"yarpc:vs-encoding-procedure","ref":"vs-encoding-procedure","sha":"60ac2f507ce8a90031c256daa8f3479732e42c83","user":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"node_id":"MDEwOlJlcG9zaXRvcnk1MDM5MDExMQ==","name":"yarpc-go","full_name":"yarpc/yarpc-go","private":false,"owner":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarpc/yarpc-go","description":"A message passing platform for Go","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2018-10-29T15:07:47Z","pushed_at":"2018-10-29T15:07:42Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":12029,"stargazers_count":165,"watchers_count":165,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":15,"watchers":165,"default_branch":"dev"}},"base":{"label":"yarpc:vs-json-codec","ref":"vs-json-codec","sha":"dd361a4900f6779b244f45d6f61625531867368f","user":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"node_id":"MDEwOlJlcG9zaXRvcnk1MDM5MDExMQ==","name":"yarpc-go","full_name":"yarpc/yarpc-go","private":false,"owner":{"login":"yarpc","id":16569504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NTY5NTA0","avatar_url":"https://avatars2.githubusercontent.com/u/16569504?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yarpc/yarpc-go","description":"A message passing platform for Go","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2018-10-29T15:07:47Z","pushed_at":"2018-10-29T15:07:42Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":12029,"stargazers_count":165,"watchers_count":165,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":15,"watchers":165,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/1615"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/1615"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/1615/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/1615/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-go/statuses/60ac2f507ce8a90031c256daa8f3479732e42c83"}},"author_association":"NONE"}}
{"actor":{"display_login":"kriskowal"}}