{"action":"created","comment":{"url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/comments/203916194","pull_request_review_id":138902720,"id":203916194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzkxNjE5NA==","diff_hunk":"@@ -0,0 +1,380 @@\n+// VolEsti\n+\n+// Copyright (c) 2012-2017 Vissarion Fisikopoulos\n+\n+// VolEsti is free software: you can redistribute it and/or modify it\n+// under the terms of the GNU Lesser General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or (at\n+// your option) any later version.\n+//\n+// VolEsti is distributed in the hope that it will be useful, but WITHOUT\n+// ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+// FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License\n+// for more details.\n+//\n+// See the file COPYING.LESSER for the text of the GNU Lesser General\n+// Public License.  If you did not receive this file along with HeaDDaCHe,\n+// see <http://www.gnu.org/licenses/>.\n+\n+\n+//#include <CGAL/point_generators_d.h>","path":"include/comp_vol.h","position":null,"original_position":20,"commit_id":"df160bd567f6d029966cb1126bbe8f417cf9f34d","original_commit_id":"47b6acf5c1483ddb62cd1d99cdfd8c46e51a458f","user":{"login":"TolisChal","id":29889291,"node_id":"MDQ6VXNlcjI5ODg5Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/29889291?v=4","gravatar_id":"","url":"https://api.github.com/users/TolisChal","html_url":"https://github.com/TolisChal","followers_url":"https://api.github.com/users/TolisChal/followers","following_url":"https://api.github.com/users/TolisChal/following{/other_user}","gists_url":"https://api.github.com/users/TolisChal/gists{/gist_id}","starred_url":"https://api.github.com/users/TolisChal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TolisChal/subscriptions","organizations_url":"https://api.github.com/users/TolisChal/orgs","repos_url":"https://api.github.com/users/TolisChal/repos","events_url":"https://api.github.com/users/TolisChal/events{/privacy}","received_events_url":"https://api.github.com/users/TolisChal/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-07-20T01:12:38Z","updated_at":"2018-07-20T01:12:38Z","html_url":"https://github.com/TolisChal/volume_approximation/pull/2#discussion_r203916194","pull_request_url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/comments/203916194"},"html":{"href":"https://github.com/TolisChal/volume_approximation/pull/2#discussion_r203916194"},"pull_request":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2"}},"in_reply_to_id":198496392},"pull_request":{"url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2","id":197690241,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjkwMjQx","html_url":"https://github.com/TolisChal/volume_approximation/pull/2","diff_url":"https://github.com/TolisChal/volume_approximation/pull/2.diff","patch_url":"https://github.com/TolisChal/volume_approximation/pull/2.patch","issue_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues/2","number":2,"state":"open","locked":false,"title":"Rcpp package for VolEsti without CGAL dependencies.","user":{"login":"TolisChal","id":29889291,"node_id":"MDQ6VXNlcjI5ODg5Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/29889291?v=4","gravatar_id":"","url":"https://api.github.com/users/TolisChal","html_url":"https://github.com/TolisChal","followers_url":"https://api.github.com/users/TolisChal/followers","following_url":"https://api.github.com/users/TolisChal/following{/other_user}","gists_url":"https://api.github.com/users/TolisChal/gists{/gist_id}","starred_url":"https://api.github.com/users/TolisChal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TolisChal/subscriptions","organizations_url":"https://api.github.com/users/TolisChal/orgs","repos_url":"https://api.github.com/users/TolisChal/repos","events_url":"https://api.github.com/users/TolisChal/events{/privacy}","received_events_url":"https://api.github.com/users/TolisChal/received_events","type":"User","site_admin":false},"body":"This is an Rcpp package for the VolEsti algorithm:\r\n\r\n1) We exclude CGAL dependencies.\r\n2) We use BH Rcpp package for Boost library and RcppEigen for Eigen library.\r\n3) We provide new implementations for geometrical objects like points and a new implementation for the computation of the Chebychev ball of a polytope using lpSolve library and Rcpp package lpSolveAPI.\r\n4) We made some improvements in the implementation of CDHnR exploiting the new implementation of the point.\r\n5) We provide new classes for ellipsoids and the intersection of an ellipsoid with a polytope and a sphere.\r\n6) We provide a new implementation for rounding function based on a different algorithm than previous version of VolEsti has been using.\r\n7) Our new implementation seems to be two times faster than the previous implementation based on CGAL library.","created_at":"2018-06-27T10:44:07Z","updated_at":"2018-07-20T01:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eac74ac263b2693ab58994aea65c506f40acfa24","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2/commits","review_comments_url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2/comments","review_comment_url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues/2/comments","statuses_url":"https://api.github.com/repos/TolisChal/volume_approximation/statuses/df160bd567f6d029966cb1126bbe8f417cf9f34d","head":{"label":"TolisChal:cgal_remove","ref":"cgal_remove","sha":"df160bd567f6d029966cb1126bbe8f417cf9f34d","user":{"login":"TolisChal","id":29889291,"node_id":"MDQ6VXNlcjI5ODg5Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/29889291?v=4","gravatar_id":"","url":"https://api.github.com/users/TolisChal","html_url":"https://github.com/TolisChal","followers_url":"https://api.github.com/users/TolisChal/followers","following_url":"https://api.github.com/users/TolisChal/following{/other_user}","gists_url":"https://api.github.com/users/TolisChal/gists{/gist_id}","starred_url":"https://api.github.com/users/TolisChal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TolisChal/subscriptions","organizations_url":"https://api.github.com/users/TolisChal/orgs","repos_url":"https://api.github.com/users/TolisChal/repos","events_url":"https://api.github.com/users/TolisChal/events{/privacy}","received_events_url":"https://api.github.com/users/TolisChal/received_events","type":"User","site_admin":false},"repo":{"id":96208436,"node_id":"MDEwOlJlcG9zaXRvcnk5NjIwODQzNg==","name":"volume_approximation","full_name":"TolisChal/volume_approximation","owner":{"login":"TolisChal","id":29889291,"node_id":"MDQ6VXNlcjI5ODg5Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/29889291?v=4","gravatar_id":"","url":"https://api.github.com/users/TolisChal","html_url":"https://github.com/TolisChal","followers_url":"https://api.github.com/users/TolisChal/followers","following_url":"https://api.github.com/users/TolisChal/following{/other_user}","gists_url":"https://api.github.com/users/TolisChal/gists{/gist_id}","starred_url":"https://api.github.com/users/TolisChal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TolisChal/subscriptions","organizations_url":"https://api.github.com/users/TolisChal/orgs","repos_url":"https://api.github.com/users/TolisChal/repos","events_url":"https://api.github.com/users/TolisChal/events{/privacy}","received_events_url":"https://api.github.com/users/TolisChal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TolisChal/volume_approximation","description":"Practical volume computation in high dimensions","fork":true,"url":"https://api.github.com/repos/TolisChal/volume_approximation","forks_url":"https://api.github.com/repos/TolisChal/volume_approximation/forks","keys_url":"https://api.github.com/repos/TolisChal/volume_approximation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TolisChal/volume_approximation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TolisChal/volume_approximation/teams","hooks_url":"https://api.github.com/repos/TolisChal/volume_approximation/hooks","issue_events_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues/events{/number}","events_url":"https://api.github.com/repos/TolisChal/volume_approximation/events","assignees_url":"https://api.github.com/repos/TolisChal/volume_approximation/assignees{/user}","branches_url":"https://api.github.com/repos/TolisChal/volume_approximation/branches{/branch}","tags_url":"https://api.github.com/repos/TolisChal/volume_approximation/tags","blobs_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/refs{/sha}","trees_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TolisChal/volume_approximation/statuses/{sha}","languages_url":"https://api.github.com/repos/TolisChal/volume_approximation/languages","stargazers_url":"https://api.github.com/repos/TolisChal/volume_approximation/stargazers","contributors_url":"https://api.github.com/repos/TolisChal/volume_approximation/contributors","subscribers_url":"https://api.github.com/repos/TolisChal/volume_approximation/subscribers","subscription_url":"https://api.github.com/repos/TolisChal/volume_approximation/subscription","commits_url":"https://api.github.com/repos/TolisChal/volume_approximation/commits{/sha}","git_commits_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/commits{/sha}","comments_url":"https://api.github.com/repos/TolisChal/volume_approximation/comments{/number}","issue_comment_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues/comments{/number}","contents_url":"https://api.github.com/repos/TolisChal/volume_approximation/contents/{+path}","compare_url":"https://api.github.com/repos/TolisChal/volume_approximation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TolisChal/volume_approximation/merges","archive_url":"https://api.github.com/repos/TolisChal/volume_approximation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TolisChal/volume_approximation/downloads","issues_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues{/number}","pulls_url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls{/number}","milestones_url":"https://api.github.com/repos/TolisChal/volume_approximation/milestones{/number}","notifications_url":"https://api.github.com/repos/TolisChal/volume_approximation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TolisChal/volume_approximation/labels{/name}","releases_url":"https://api.github.com/repos/TolisChal/volume_approximation/releases{/id}","deployments_url":"https://api.github.com/repos/TolisChal/volume_approximation/deployments","created_at":"2017-07-04T10:57:03Z","updated_at":"2018-07-18T11:04:29Z","pushed_at":"2018-07-19T15:16:40Z","git_url":"git://github.com/TolisChal/volume_approximation.git","ssh_url":"git@github.com:TolisChal/volume_approximation.git","clone_url":"https://github.com/TolisChal/volume_approximation.git","svn_url":"https://github.com/TolisChal/volume_approximation","homepage":"","size":61531,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"TolisChal:develop","ref":"develop","sha":"bc4d649ea04c122f9e6a7d7a83c5e6dbced1d2b7","user":{"login":"TolisChal","id":29889291,"node_id":"MDQ6VXNlcjI5ODg5Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/29889291?v=4","gravatar_id":"","url":"https://api.github.com/users/TolisChal","html_url":"https://github.com/TolisChal","followers_url":"https://api.github.com/users/TolisChal/followers","following_url":"https://api.github.com/users/TolisChal/following{/other_user}","gists_url":"https://api.github.com/users/TolisChal/gists{/gist_id}","starred_url":"https://api.github.com/users/TolisChal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TolisChal/subscriptions","organizations_url":"https://api.github.com/users/TolisChal/orgs","repos_url":"https://api.github.com/users/TolisChal/repos","events_url":"https://api.github.com/users/TolisChal/events{/privacy}","received_events_url":"https://api.github.com/users/TolisChal/received_events","type":"User","site_admin":false},"repo":{"id":96208436,"node_id":"MDEwOlJlcG9zaXRvcnk5NjIwODQzNg==","name":"volume_approximation","full_name":"TolisChal/volume_approximation","owner":{"login":"TolisChal","id":29889291,"node_id":"MDQ6VXNlcjI5ODg5Mjkx","avatar_url":"https://avatars0.githubusercontent.com/u/29889291?v=4","gravatar_id":"","url":"https://api.github.com/users/TolisChal","html_url":"https://github.com/TolisChal","followers_url":"https://api.github.com/users/TolisChal/followers","following_url":"https://api.github.com/users/TolisChal/following{/other_user}","gists_url":"https://api.github.com/users/TolisChal/gists{/gist_id}","starred_url":"https://api.github.com/users/TolisChal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TolisChal/subscriptions","organizations_url":"https://api.github.com/users/TolisChal/orgs","repos_url":"https://api.github.com/users/TolisChal/repos","events_url":"https://api.github.com/users/TolisChal/events{/privacy}","received_events_url":"https://api.github.com/users/TolisChal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TolisChal/volume_approximation","description":"Practical volume computation in high dimensions","fork":true,"url":"https://api.github.com/repos/TolisChal/volume_approximation","forks_url":"https://api.github.com/repos/TolisChal/volume_approximation/forks","keys_url":"https://api.github.com/repos/TolisChal/volume_approximation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TolisChal/volume_approximation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TolisChal/volume_approximation/teams","hooks_url":"https://api.github.com/repos/TolisChal/volume_approximation/hooks","issue_events_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues/events{/number}","events_url":"https://api.github.com/repos/TolisChal/volume_approximation/events","assignees_url":"https://api.github.com/repos/TolisChal/volume_approximation/assignees{/user}","branches_url":"https://api.github.com/repos/TolisChal/volume_approximation/branches{/branch}","tags_url":"https://api.github.com/repos/TolisChal/volume_approximation/tags","blobs_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/refs{/sha}","trees_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TolisChal/volume_approximation/statuses/{sha}","languages_url":"https://api.github.com/repos/TolisChal/volume_approximation/languages","stargazers_url":"https://api.github.com/repos/TolisChal/volume_approximation/stargazers","contributors_url":"https://api.github.com/repos/TolisChal/volume_approximation/contributors","subscribers_url":"https://api.github.com/repos/TolisChal/volume_approximation/subscribers","subscription_url":"https://api.github.com/repos/TolisChal/volume_approximation/subscription","commits_url":"https://api.github.com/repos/TolisChal/volume_approximation/commits{/sha}","git_commits_url":"https://api.github.com/repos/TolisChal/volume_approximation/git/commits{/sha}","comments_url":"https://api.github.com/repos/TolisChal/volume_approximation/comments{/number}","issue_comment_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues/comments{/number}","contents_url":"https://api.github.com/repos/TolisChal/volume_approximation/contents/{+path}","compare_url":"https://api.github.com/repos/TolisChal/volume_approximation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TolisChal/volume_approximation/merges","archive_url":"https://api.github.com/repos/TolisChal/volume_approximation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TolisChal/volume_approximation/downloads","issues_url":"https://api.github.com/repos/TolisChal/volume_approximation/issues{/number}","pulls_url":"https://api.github.com/repos/TolisChal/volume_approximation/pulls{/number}","milestones_url":"https://api.github.com/repos/TolisChal/volume_approximation/milestones{/number}","notifications_url":"https://api.github.com/repos/TolisChal/volume_approximation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TolisChal/volume_approximation/labels{/name}","releases_url":"https://api.github.com/repos/TolisChal/volume_approximation/releases{/id}","deployments_url":"https://api.github.com/repos/TolisChal/volume_approximation/deployments","created_at":"2017-07-04T10:57:03Z","updated_at":"2018-07-18T11:04:29Z","pushed_at":"2018-07-19T15:16:40Z","git_url":"git://github.com/TolisChal/volume_approximation.git","ssh_url":"git@github.com:TolisChal/volume_approximation.git","clone_url":"https://github.com/TolisChal/volume_approximation.git","svn_url":"https://github.com/TolisChal/volume_approximation","homepage":"","size":61531,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2"},"html":{"href":"https://github.com/TolisChal/volume_approximation/pull/2"},"issue":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/issues/2"},"comments":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/TolisChal/volume_approximation/statuses/df160bd567f6d029966cb1126bbe8f417cf9f34d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"TolisChal"}}