{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/244752447","pull_request_review_id":188698714,"id":244752447,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc1MjQ0Nw==","diff_hunk":"@@ -538,6 +538,18 @@ class Gap {\n      */\n     virtual uint16_t getMaxAdvertisingDataLength();\n \n+    /** Return maximum advertising data length supported for connectable advertising.\n+     *\n+     * @return Maximum advertising data length supported for connectable advertising.\n+     */\n+    virtual uint16_t getMaxConnectableAdvertisingDataLength();\n+\n+    /** Return maximum advertising data length you may set if advertising set is active.\n+     *\n+     * @return Maximum advertising data length you may set if advertising set is active.\n+     */\n+    virtual uint8_t getMaxActiveSetAdvertisingDataLength();","path":"features/FEATURE_BLE/ble/gap/Gap.h","position":14,"original_position":14,"commit_id":"67db3215007602db813c7d272a888f94162bcc14","original_commit_id":"67db3215007602db813c7d272a888f94162bcc14","user":{"login":"kjbracey-arm","id":11025917,"node_id":"MDQ6VXNlcjExMDI1OTE3","avatar_url":"https://avatars3.githubusercontent.com/u/11025917?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"body":"On ARM, any narrow types are normally more expensive than 32-bit types, if they're automatic variables, arguments or return values. The compiler needs to add extra narrowing instructions.\r\n\r\nUnless the narrow width is semantically important, it's best to stick with `int`, `int32_t` or `size_t` most of the time. (I used to avoid `size_t` when still dealing with 8-bit CPUs where that forced 32-bit rather than 16-bit arithmetic, but no longer.)  \r\n\r\nIIRC, standalone static variables are also normally word-aligned anyway, so I don't think narrow types buy you anything there either. Automatic variables are are also word-aligned on the stack.\r\n\r\nSo narrow types are only really useful in structures and arrays, unless you require narrow unsigned modulo arithmetic.\r\n\r\n","created_at":"2019-01-02T14:41:47Z","updated_at":"2019-01-02T14:41:47Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/9096#discussion_r244752447","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/244752447"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/9096#discussion_r244752447"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096"}},"in_reply_to_id":244739395},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096","id":238479862,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDc5ODYy","html_url":"https://github.com/ARMmbed/mbed-os/pull/9096","diff_url":"https://github.com/ARMmbed/mbed-os/pull/9096.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/9096.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9096","number":9096,"state":"open","locked":false,"title":"BLE: Enforce advertising data payload limits","user":{"login":"paul-szczepanek-arm","id":33840200,"node_id":"MDQ6VXNlcjMzODQwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/33840200?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-szczepanek-arm","html_url":"https://github.com/paul-szczepanek-arm","followers_url":"https://api.github.com/users/paul-szczepanek-arm/followers","following_url":"https://api.github.com/users/paul-szczepanek-arm/following{/other_user}","gists_url":"https://api.github.com/users/paul-szczepanek-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-szczepanek-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-szczepanek-arm/subscriptions","organizations_url":"https://api.github.com/users/paul-szczepanek-arm/orgs","repos_url":"https://api.github.com/users/paul-szczepanek-arm/repos","events_url":"https://api.github.com/users/paul-szczepanek-arm/events{/privacy}","received_events_url":"https://api.github.com/users/paul-szczepanek-arm/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThe complete advertising data length may be different based on whether it's connectable advertising. A new call has been added to the API.\r\nData set when advertising is active is also limited. New function added to advise of the limit.\r\nThere is an illegal adv parameters combinations that is now checked.\r\n\r\nOn Pal side:\r\nThe HCI length of packets may be variable and dependent on the controller. This fix queries the PAL to use the correct fragmentation of set data.\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [x] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-12-13T17:57:02Z","updated_at":"2019-01-02T14:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfd44d37ac7cca2a16001d67ee16ea1c70a9494d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"donatieng","id":4488374,"node_id":"MDQ6VXNlcjQ0ODgzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4488374?v=4","gravatar_id":"","url":"https://api.github.com/users/donatieng","html_url":"https://github.com/donatieng","followers_url":"https://api.github.com/users/donatieng/followers","following_url":"https://api.github.com/users/donatieng/following{/other_user}","gists_url":"https://api.github.com/users/donatieng/gists{/gist_id}","starred_url":"https://api.github.com/users/donatieng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donatieng/subscriptions","organizations_url":"https://api.github.com/users/donatieng/orgs","repos_url":"https://api.github.com/users/donatieng/repos","events_url":"https://api.github.com/users/donatieng/events{/privacy}","received_events_url":"https://api.github.com/users/donatieng/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false},{"id":1132645798,"node_id":"MDU6TGFiZWwxMTMyNjQ1Nzk4","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/release-version:%205.12.0-rc1","name":"release-version: 5.12.0-rc1","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9096/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/67db3215007602db813c7d272a888f94162bcc14","head":{"label":"pan-:fix-enforce-size-limits","ref":"fix-enforce-size-limits","sha":"67db3215007602db813c7d272a888f94162bcc14","user":{"login":"pan-","id":409941,"node_id":"MDQ6VXNlcjQwOTk0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"repo":{"id":59667574,"node_id":"MDEwOlJlcG9zaXRvcnk1OTY2NzU3NA==","name":"mbed","full_name":"pan-/mbed","private":false,"owner":{"login":"pan-","id":409941,"node_id":"MDQ6VXNlcjQwOTk0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pan-/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/pan-/mbed","forks_url":"https://api.github.com/repos/pan-/mbed/forks","keys_url":"https://api.github.com/repos/pan-/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pan-/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pan-/mbed/teams","hooks_url":"https://api.github.com/repos/pan-/mbed/hooks","issue_events_url":"https://api.github.com/repos/pan-/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/pan-/mbed/events","assignees_url":"https://api.github.com/repos/pan-/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/pan-/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/pan-/mbed/tags","blobs_url":"https://api.github.com/repos/pan-/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pan-/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pan-/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/pan-/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pan-/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/pan-/mbed/languages","stargazers_url":"https://api.github.com/repos/pan-/mbed/stargazers","contributors_url":"https://api.github.com/repos/pan-/mbed/contributors","subscribers_url":"https://api.github.com/repos/pan-/mbed/subscribers","subscription_url":"https://api.github.com/repos/pan-/mbed/subscription","commits_url":"https://api.github.com/repos/pan-/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/pan-/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/pan-/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/pan-/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/pan-/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/pan-/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pan-/mbed/merges","archive_url":"https://api.github.com/repos/pan-/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pan-/mbed/downloads","issues_url":"https://api.github.com/repos/pan-/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/pan-/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/pan-/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/pan-/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pan-/mbed/labels{/name}","releases_url":"https://api.github.com/repos/pan-/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/pan-/mbed/deployments","created_at":"2016-05-25T13:56:37Z","updated_at":"2018-12-04T14:05:55Z","pushed_at":"2018-12-13T17:53:26Z","git_url":"git://github.com/pan-/mbed.git","ssh_url":"git@github.com:pan-/mbed.git","clone_url":"https://github.com/pan-/mbed.git","svn_url":"https://github.com/pan-/mbed","homepage":"","size":245517,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"a91dccd9010ac4a72c0e58147aa15fdeb9f7bc7e","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2019-01-02T10:26:17Z","pushed_at":"2019-01-02T14:16:59Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":252817,"stargazers_count":2147,"watchers_count":2147,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1723,"mirror_url":null,"archived":false,"open_issues_count":442,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1723,"open_issues":442,"watchers":2147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/9096"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9096"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9096/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9096/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/67db3215007602db813c7d272a888f94162bcc14"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kjbracey-arm"}}