{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/179914125","pull_request_review_id":110252628,"id":179914125,"diff_hunk":"@@ -462,6 +468,9 @@ namespace ts.textChanges {\n             else if (isVariableDeclaration(node)) {\r\n                 return { prefix: \", \" };\r\n             }\r\n+            else if (isPropertyAssignment(node)) {\r\n+                return { suffix: \",\" + this.newLineCharacter }\r","path":"src/services/textChanges.ts","position":18,"original_position":18,"commit_id":"e5daa8c46ea5b0ed3619c95ffd27f97893ccb87b","original_commit_id":"e5daa8c46ea5b0ed3619c95ffd27f97893ccb87b","user":{"login":"Kingwl","id":6831019,"avatar_url":"https://avatars3.githubusercontent.com/u/6831019?v=4","gravatar_id":"","url":"https://api.github.com/users/Kingwl","html_url":"https://github.com/Kingwl","followers_url":"https://api.github.com/users/Kingwl/followers","following_url":"https://api.github.com/users/Kingwl/following{/other_user}","gists_url":"https://api.github.com/users/Kingwl/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingwl/subscriptions","organizations_url":"https://api.github.com/users/Kingwl/orgs","repos_url":"https://api.github.com/users/Kingwl/repos","events_url":"https://api.github.com/users/Kingwl/events{/privacy}","received_events_url":"https://api.github.com/users/Kingwl/received_events","type":"User","site_admin":false},"body":"@mhegazy some thing need help\r\nin this case \r\nhow should i add the `,` after every props  \r\nif i update the `ObjectLiteralExpression`, the original `PropertyAssignment` will overship with this change","created_at":"2018-04-07T10:50:39Z","updated_at":"2018-04-07T10:50:39Z","html_url":"https://github.com/Microsoft/TypeScript/pull/22143#discussion_r179914125","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/179914125"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/22143#discussion_r179914125"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143","id":170970740,"html_url":"https://github.com/Microsoft/TypeScript/pull/22143","diff_url":"https://github.com/Microsoft/TypeScript/pull/22143.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/22143.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/22143","number":22143,"state":"open","locked":false,"title":"add refactor of convert private field to getter and setter","user":{"login":"Kingwl","id":6831019,"avatar_url":"https://avatars3.githubusercontent.com/u/6831019?v=4","gravatar_id":"","url":"https://api.github.com/users/Kingwl","html_url":"https://github.com/Kingwl","followers_url":"https://api.github.com/users/Kingwl/followers","following_url":"https://api.github.com/users/Kingwl/following{/other_user}","gists_url":"https://api.github.com/users/Kingwl/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingwl/subscriptions","organizations_url":"https://api.github.com/users/Kingwl/orgs","repos_url":"https://api.github.com/users/Kingwl/repos","events_url":"https://api.github.com/users/Kingwl/events{/privacy}","received_events_url":"https://api.github.com/users/Kingwl/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting a pull request!\r\n\r\nHere's a checklist you might find useful.\r\n[ ] There is an associated issue that is labeled\r\n  'Bug' or 'help wanted' or is in the Community milestone\r\n[ ] Code is up-to-date with the `master` branch\r\n[ ] You've successfully run `jake runtests` locally\r\n[ ] You've signed the CLA\r\n[ ] There are new or updated unit tests validating the change\r\n\r\nRefer to CONTRIBUTING.MD for more details.\r\n  https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nFixes #12417 \r\n","created_at":"2018-02-23T09:43:24Z","updated_at":"2018-04-07T10:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec9279c778ccbfb0d06bdd3c43c6fd3fa527de5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/22143/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/e5daa8c46ea5b0ed3619c95ffd27f97893ccb87b","head":{"label":"Kingwl:add-getter-and-setter","ref":"add-getter-and-setter","sha":"e5daa8c46ea5b0ed3619c95ffd27f97893ccb87b","user":{"login":"Kingwl","id":6831019,"avatar_url":"https://avatars3.githubusercontent.com/u/6831019?v=4","gravatar_id":"","url":"https://api.github.com/users/Kingwl","html_url":"https://github.com/Kingwl","followers_url":"https://api.github.com/users/Kingwl/followers","following_url":"https://api.github.com/users/Kingwl/following{/other_user}","gists_url":"https://api.github.com/users/Kingwl/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingwl/subscriptions","organizations_url":"https://api.github.com/users/Kingwl/orgs","repos_url":"https://api.github.com/users/Kingwl/repos","events_url":"https://api.github.com/users/Kingwl/events{/privacy}","received_events_url":"https://api.github.com/users/Kingwl/received_events","type":"User","site_admin":false},"repo":{"id":106490728,"name":"TypeScript","full_name":"Kingwl/TypeScript","owner":{"login":"Kingwl","id":6831019,"avatar_url":"https://avatars3.githubusercontent.com/u/6831019?v=4","gravatar_id":"","url":"https://api.github.com/users/Kingwl","html_url":"https://github.com/Kingwl","followers_url":"https://api.github.com/users/Kingwl/followers","following_url":"https://api.github.com/users/Kingwl/following{/other_user}","gists_url":"https://api.github.com/users/Kingwl/gists{/gist_id}","starred_url":"https://api.github.com/users/Kingwl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kingwl/subscriptions","organizations_url":"https://api.github.com/users/Kingwl/orgs","repos_url":"https://api.github.com/users/Kingwl/repos","events_url":"https://api.github.com/users/Kingwl/events{/privacy}","received_events_url":"https://api.github.com/users/Kingwl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kingwl/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/Kingwl/TypeScript","forks_url":"https://api.github.com/repos/Kingwl/TypeScript/forks","keys_url":"https://api.github.com/repos/Kingwl/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kingwl/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kingwl/TypeScript/teams","hooks_url":"https://api.github.com/repos/Kingwl/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Kingwl/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Kingwl/TypeScript/events","assignees_url":"https://api.github.com/repos/Kingwl/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Kingwl/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Kingwl/TypeScript/tags","blobs_url":"https://api.github.com/repos/Kingwl/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kingwl/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kingwl/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kingwl/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kingwl/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Kingwl/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Kingwl/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Kingwl/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Kingwl/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Kingwl/TypeScript/subscription","commits_url":"https://api.github.com/repos/Kingwl/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kingwl/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kingwl/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kingwl/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kingwl/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Kingwl/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kingwl/TypeScript/merges","archive_url":"https://api.github.com/repos/Kingwl/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kingwl/TypeScript/downloads","issues_url":"https://api.github.com/repos/Kingwl/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Kingwl/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Kingwl/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Kingwl/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kingwl/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Kingwl/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Kingwl/TypeScript/deployments","created_at":"2017-10-11T01:35:06Z","updated_at":"2018-04-03T02:34:57Z","pushed_at":"2018-04-07T10:47:08Z","git_url":"git://github.com/Kingwl/TypeScript.git","ssh_url":"git@github.com:Kingwl/TypeScript.git","clone_url":"https://github.com/Kingwl/TypeScript.git","svn_url":"https://github.com/Kingwl/TypeScript","homepage":"http://www.typescriptlang.org","size":597854,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0fd8fb8697ed88d66cea117e165f68a9ac010e8d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2018-04-07T10:39:33Z","pushed_at":"2018-04-07T10:47:21Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":626917,"stargazers_count":32762,"watchers_count":32762,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4767,"mirror_url":null,"archived":false,"open_issues_count":2706,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4767,"open_issues":2706,"watchers":32762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/22143"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/22143"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/22143/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/22143/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/e5daa8c46ea5b0ed3619c95ffd27f97893ccb87b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Kingwl"}}