{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/244994892","pull_request_review_id":189004908,"id":244994892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDk5NDg5Mg==","diff_hunk":"@@ -328,12 +328,19 @@ static int hda_dma_host_preload(struct dma *dma, struct hda_chan_data *chan)\n \tint i;\n \tint period_cnt;\n \n+\tuint64_t deadline = platform_timer_get(platform_timer) +\n+\t\t\t    clock_ms_to_ticks(PLATFORM_DEFAULT_CLOCK, 1) *\n+\t\t\t\t\t      PLATFORM_HOST_DMA_TIMEOUT / 1000;\n+\n \t/* waiting for buffer full after start\n \t * first try is unblocking, then blocking\n \t */\n \twhile (!(host_dma_reg_read(dma, chan->index, DGCS) & DGCS_BF) &&\n-\t       (chan->state & HDA_STATE_BF_WAIT))\n-\t\t; /* TODO: this should timeout and not wait forever */\n+\t       (chan->state & HDA_STATE_BF_WAIT)) {\n+\t\tif (deadline < platform_timer_get(platform_timer)) {\n+\t\t\treturn -ETIME;\n+\t\t}","path":"src/drivers/intel/cavs/hda-dma.c","position":17,"original_position":17,"commit_id":"ce7d357bf0dd18406d140e6249270c5dc93dea19","original_commit_id":"ce7d357bf0dd18406d140e6249270c5dc93dea19","user":{"login":"mmaka1","id":40028148,"node_id":"MDQ6VXNlcjQwMDI4MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/40028148?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaka1","html_url":"https://github.com/mmaka1","followers_url":"https://api.github.com/users/mmaka1/followers","following_url":"https://api.github.com/users/mmaka1/following{/other_user}","gists_url":"https://api.github.com/users/mmaka1/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaka1/subscriptions","organizations_url":"https://api.github.com/users/mmaka1/orgs","repos_url":"https://api.github.com/users/mmaka1/repos","events_url":"https://api.github.com/users/mmaka1/events{/privacy}","received_events_url":"https://api.github.com/users/mmaka1/received_events","type":"User","site_admin":false},"body":"@keyonjie BF at the startup is the only way to control the flow and align the state of HW ptrs and sw ptrs. Could you re-test with the DMI L0 forced all the time? Do you hit the t/o again?","created_at":"2019-01-03T13:12:49Z","updated_at":"2019-01-03T13:12:49Z","html_url":"https://github.com/thesofproject/sof/pull/783#discussion_r244994892","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/783","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/244994892"},"html":{"href":"https://github.com/thesofproject/sof/pull/783#discussion_r244994892"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/783"}},"in_reply_to_id":244463815},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/783","id":241142625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTQyNjI1","html_url":"https://github.com/thesofproject/sof/pull/783","diff_url":"https://github.com/thesofproject/sof/pull/783.diff","patch_url":"https://github.com/thesofproject/sof/pull/783.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/783","number":783,"state":"open","locked":false,"title":"hda: dma preload timeout","user":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"body":"Implementation for #723 \r\n\r\nI used `PLATFORM_HOST_DMA_TIMEOUT` that looks to be defined for all platforms, but is unused - name looks good for this purpose, so I guess someone could even declare it for that use.\r\nIt's 50 microseconds for all platforms for now.\r\n\r\nSigned-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>","created_at":"2018-12-27T12:24:25Z","updated_at":"2019-01-03T13:12:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0ff523bb2857fffd066b19aaf76f0e625f151e9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},{"login":"mmaka1","id":40028148,"node_id":"MDQ6VXNlcjQwMDI4MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/40028148?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaka1","html_url":"https://github.com/mmaka1","followers_url":"https://api.github.com/users/mmaka1/followers","following_url":"https://api.github.com/users/mmaka1/following{/other_user}","gists_url":"https://api.github.com/users/mmaka1/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaka1/subscriptions","organizations_url":"https://api.github.com/users/mmaka1/orgs","repos_url":"https://api.github.com/users/mmaka1/repos","events_url":"https://api.github.com/users/mmaka1/events{/privacy}","received_events_url":"https://api.github.com/users/mmaka1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/783/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/783/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/783/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/ce7d357bf0dd18406d140e6249270c5dc93dea19","head":{"label":"jajanusz:hda-dma-preload-timeout","ref":"hda-dma-preload-timeout","sha":"ce7d357bf0dd18406d140e6249270c5dc93dea19","user":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"repo":{"id":139576789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NzY3ODk=","name":"sof","full_name":"jajanusz/sof","private":false,"owner":{"login":"jajanusz","id":40290934,"node_id":"MDQ6VXNlcjQwMjkwOTM0","avatar_url":"https://avatars0.githubusercontent.com/u/40290934?v=4","gravatar_id":"","url":"https://api.github.com/users/jajanusz","html_url":"https://github.com/jajanusz","followers_url":"https://api.github.com/users/jajanusz/followers","following_url":"https://api.github.com/users/jajanusz/following{/other_user}","gists_url":"https://api.github.com/users/jajanusz/gists{/gist_id}","starred_url":"https://api.github.com/users/jajanusz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jajanusz/subscriptions","organizations_url":"https://api.github.com/users/jajanusz/orgs","repos_url":"https://api.github.com/users/jajanusz/repos","events_url":"https://api.github.com/users/jajanusz/events{/privacy}","received_events_url":"https://api.github.com/users/jajanusz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jajanusz/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/jajanusz/sof","forks_url":"https://api.github.com/repos/jajanusz/sof/forks","keys_url":"https://api.github.com/repos/jajanusz/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jajanusz/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jajanusz/sof/teams","hooks_url":"https://api.github.com/repos/jajanusz/sof/hooks","issue_events_url":"https://api.github.com/repos/jajanusz/sof/issues/events{/number}","events_url":"https://api.github.com/repos/jajanusz/sof/events","assignees_url":"https://api.github.com/repos/jajanusz/sof/assignees{/user}","branches_url":"https://api.github.com/repos/jajanusz/sof/branches{/branch}","tags_url":"https://api.github.com/repos/jajanusz/sof/tags","blobs_url":"https://api.github.com/repos/jajanusz/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jajanusz/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jajanusz/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/jajanusz/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jajanusz/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/jajanusz/sof/languages","stargazers_url":"https://api.github.com/repos/jajanusz/sof/stargazers","contributors_url":"https://api.github.com/repos/jajanusz/sof/contributors","subscribers_url":"https://api.github.com/repos/jajanusz/sof/subscribers","subscription_url":"https://api.github.com/repos/jajanusz/sof/subscription","commits_url":"https://api.github.com/repos/jajanusz/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/jajanusz/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/jajanusz/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/jajanusz/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/jajanusz/sof/contents/{+path}","compare_url":"https://api.github.com/repos/jajanusz/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jajanusz/sof/merges","archive_url":"https://api.github.com/repos/jajanusz/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jajanusz/sof/downloads","issues_url":"https://api.github.com/repos/jajanusz/sof/issues{/number}","pulls_url":"https://api.github.com/repos/jajanusz/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/jajanusz/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/jajanusz/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jajanusz/sof/labels{/name}","releases_url":"https://api.github.com/repos/jajanusz/sof/releases{/id}","deployments_url":"https://api.github.com/repos/jajanusz/sof/deployments","created_at":"2018-07-03T11:58:39Z","updated_at":"2019-01-02T19:44:11Z","pushed_at":"2019-01-02T19:44:10Z","git_url":"git://github.com/jajanusz/sof.git","ssh_url":"git@github.com:jajanusz/sof.git","clone_url":"https://github.com/jajanusz/sof.git","svn_url":"https://github.com/jajanusz/sof","homepage":null,"size":5258,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"43a75f4b405b6d922b2a42cebe2101398d3e3084","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2018-12-28T07:14:32Z","pushed_at":"2019-01-03T09:20:15Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"git@github.com:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":5143,"stargazers_count":29,"watchers_count":29,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":52,"open_issues":70,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/783"},"html":{"href":"https://github.com/thesofproject/sof/pull/783"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/783"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/783/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/783/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/783/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/ce7d357bf0dd18406d140e6249270c5dc93dea19"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mmaka1"}}