{"action":"created","issue":{"url":"https://api.github.com/repos/video-dev/hls.js/issues/1684","repository_url":"https://api.github.com/repos/video-dev/hls.js","labels_url":"https://api.github.com/repos/video-dev/hls.js/issues/1684/labels{/name}","comments_url":"https://api.github.com/repos/video-dev/hls.js/issues/1684/comments","events_url":"https://api.github.com/repos/video-dev/hls.js/issues/1684/events","html_url":"https://github.com/video-dev/hls.js/pull/1684","id":318029487,"number":1684,"title":"Fixed chrome not autoplaying when performing functional tests","user":{"login":"bwallberg","id":4589630,"avatar_url":"https://avatars2.githubusercontent.com/u/4589630?v=4","gravatar_id":"","url":"https://api.github.com/users/bwallberg","html_url":"https://github.com/bwallberg","followers_url":"https://api.github.com/users/bwallberg/followers","following_url":"https://api.github.com/users/bwallberg/following{/other_user}","gists_url":"https://api.github.com/users/bwallberg/gists{/gist_id}","starred_url":"https://api.github.com/users/bwallberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwallberg/subscriptions","organizations_url":"https://api.github.com/users/bwallberg/orgs","repos_url":"https://api.github.com/users/bwallberg/repos","events_url":"https://api.github.com/users/bwallberg/events{/privacy}","received_events_url":"https://api.github.com/users/bwallberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-26T13:27:14Z","updated_at":"2018-05-02T23:47:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/video-dev/hls.js/pulls/1684","html_url":"https://github.com/video-dev/hls.js/pull/1684","diff_url":"https://github.com/video-dev/hls.js/pull/1684.diff","patch_url":"https://github.com/video-dev/hls.js/pull/1684.patch"},"body":"### This PR will...\r\nFix functional test failing on chrome 66+\r\n### Why is this Pull Request needed?\r\nBecause functional tests fail and I want to ✅ on my PRs\r\n### Are there any points in the code the reviewer needs to double check?\r\nNo\r\n### Checklist\r\n\r\n- [x] changes have been done against master branch, and PR does not conflict\r\n- [x] no commits have been done in dist folder (we will take care of updating it)\r\n- [x] new unit / functional tests have been added (whenever applicable)\r\n- [x] API or design changes are documented in API.md\r\n"},"comment":{"url":"https://api.github.com/repos/video-dev/hls.js/issues/comments/386155096","html_url":"https://github.com/video-dev/hls.js/pull/1684#issuecomment-386155096","issue_url":"https://api.github.com/repos/video-dev/hls.js/issues/1684","id":386155096,"user":{"login":"tchakabam","id":1480052,"avatar_url":"https://avatars2.githubusercontent.com/u/1480052?v=4","gravatar_id":"","url":"https://api.github.com/users/tchakabam","html_url":"https://github.com/tchakabam","followers_url":"https://api.github.com/users/tchakabam/followers","following_url":"https://api.github.com/users/tchakabam/following{/other_user}","gists_url":"https://api.github.com/users/tchakabam/gists{/gist_id}","starred_url":"https://api.github.com/users/tchakabam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchakabam/subscriptions","organizations_url":"https://api.github.com/users/tchakabam/orgs","repos_url":"https://api.github.com/users/tchakabam/repos","events_url":"https://api.github.com/users/tchakabam/events{/privacy}","received_events_url":"https://api.github.com/users/tchakabam/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T23:47:42Z","updated_at":"2018-05-02T23:47:42Z","author_association":"COLLABORATOR","body":"So now we have one test failing:\r\n\r\n```\r\n\u001B[92m \u001B[0m\u001B[32m 1 passing\u001B[0m\u001B[90m (54s)\u001B[0m\r\n\u001B[31m  1 failing\u001B[0m\r\n\r\n\u001B[0m  1) testing hls.js playback in the browser on \"chrome (latest), Windows 10\" \"after each\" hook for \"should receive video loadeddata event for Big Buck Bunny - adaptive qualities\":\r\n\u001B[0m\u001B[31m     Error: Timeout of 40000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\u001B[0m\u001B[90m\r\n  \r\n\u001B[0m\r\n```\r\n\r\nI wonder how good of an idea it is to test for this loadeddata event in general. I think it's probably flaky, and also this is a browser behavior. We're not supposed to test if the browser sends the events by the HTML5 spec. We should just test if stuff plays? :)\r\n\r\nAlso, someone knows if there is a way to get rid of the color-chars in the logs?"}}
{"actor":{"display_login":"tchakabam"}}