{"action":"created","comment":{"url":"https://api.github.com/repos/nfour/event-framework/pulls/comments/177928065","pull_request_review_id":107895738,"id":177928065,"diff_hunk":"@@ -96,6 +103,14 @@ export class Emitter {\n    */\n   _playback: Map<Event['key'], any[][]> = new Map();\n \n+  /**\n+   * Apply debug and playback options that are passed into the constructor\n+   */\n+  constructor ({ debug, playback }: IEmitterConstructor = {}) {","path":"src/Emitter.ts","position":39,"original_position":39,"commit_id":"df7c3e4ffa3ae0c96ce8ee6fab396c5cb30342a0","original_commit_id":"df7c3e4ffa3ae0c96ce8ee6fab396c5cb30342a0","user":{"login":"nfour","id":2108452,"avatar_url":"https://avatars1.githubusercontent.com/u/2108452?v=4","gravatar_id":"","url":"https://api.github.com/users/nfour","html_url":"https://github.com/nfour","followers_url":"https://api.github.com/users/nfour/followers","following_url":"https://api.github.com/users/nfour/following{/other_user}","gists_url":"https://api.github.com/users/nfour/gists{/gist_id}","starred_url":"https://api.github.com/users/nfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfour/subscriptions","organizations_url":"https://api.github.com/users/nfour/orgs","repos_url":"https://api.github.com/users/nfour/repos","events_url":"https://api.github.com/users/nfour/events{/privacy}","received_events_url":"https://api.github.com/users/nfour/received_events","type":"User","site_admin":false},"body":"This is not how components are supposed to work.\r\n\r\nThe constructor is relegated to the whims of component lifecycles and not emitters. Because components extend the Emitter it is unfeasible to supply constructor params.\r\n\r\nThis has to be configured via instance properties, such as when extending a class eg.\r\n\r\n```ts\r\nclass MyFancyThing extends Component<any> {\r\n  playback = 100\r\n}\r\n\r\n```","created_at":"2018-03-29T00:39:12Z","updated_at":"2018-03-29T00:40:14Z","html_url":"https://github.com/nfour/event-framework/pull/2#discussion_r177928065","pull_request_url":"https://api.github.com/repos/nfour/event-framework/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nfour/event-framework/pulls/comments/177928065"},"html":{"href":"https://github.com/nfour/event-framework/pull/2#discussion_r177928065"},"pull_request":{"href":"https://api.github.com/repos/nfour/event-framework/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/nfour/event-framework/pulls/2","id":177906621,"html_url":"https://github.com/nfour/event-framework/pull/2","diff_url":"https://github.com/nfour/event-framework/pull/2.diff","patch_url":"https://github.com/nfour/event-framework/pull/2.patch","issue_url":"https://api.github.com/repos/nfour/event-framework/issues/2","number":2,"state":"open","locked":false,"title":"Move emitter options to the constructor","user":{"login":"MrBlenny","id":9685048,"avatar_url":"https://avatars2.githubusercontent.com/u/9685048?v=4","gravatar_id":"","url":"https://api.github.com/users/MrBlenny","html_url":"https://github.com/MrBlenny","followers_url":"https://api.github.com/users/MrBlenny/followers","following_url":"https://api.github.com/users/MrBlenny/following{/other_user}","gists_url":"https://api.github.com/users/MrBlenny/gists{/gist_id}","starred_url":"https://api.github.com/users/MrBlenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrBlenny/subscriptions","organizations_url":"https://api.github.com/users/MrBlenny/orgs","repos_url":"https://api.github.com/users/MrBlenny/repos","events_url":"https://api.github.com/users/MrBlenny/events{/privacy}","received_events_url":"https://api.github.com/users/MrBlenny/received_events","type":"User","site_admin":false},"body":"Mainly so I feel like I am doing something","created_at":"2018-03-28T01:23:08Z","updated_at":"2018-03-29T00:40:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ca8c8d3e1046a0caa4f893bbcb3130ff7c10ad2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nfour/event-framework/pulls/2/commits","review_comments_url":"https://api.github.com/repos/nfour/event-framework/pulls/2/comments","review_comment_url":"https://api.github.com/repos/nfour/event-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nfour/event-framework/issues/2/comments","statuses_url":"https://api.github.com/repos/nfour/event-framework/statuses/df7c3e4ffa3ae0c96ce8ee6fab396c5cb30342a0","head":{"label":"MrBlenny:master","ref":"master","sha":"df7c3e4ffa3ae0c96ce8ee6fab396c5cb30342a0","user":{"login":"MrBlenny","id":9685048,"avatar_url":"https://avatars2.githubusercontent.com/u/9685048?v=4","gravatar_id":"","url":"https://api.github.com/users/MrBlenny","html_url":"https://github.com/MrBlenny","followers_url":"https://api.github.com/users/MrBlenny/followers","following_url":"https://api.github.com/users/MrBlenny/following{/other_user}","gists_url":"https://api.github.com/users/MrBlenny/gists{/gist_id}","starred_url":"https://api.github.com/users/MrBlenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrBlenny/subscriptions","organizations_url":"https://api.github.com/users/MrBlenny/orgs","repos_url":"https://api.github.com/users/MrBlenny/repos","events_url":"https://api.github.com/users/MrBlenny/events{/privacy}","received_events_url":"https://api.github.com/users/MrBlenny/received_events","type":"User","site_admin":false},"repo":{"id":127060576,"name":"event-framework","full_name":"MrBlenny/event-framework","owner":{"login":"MrBlenny","id":9685048,"avatar_url":"https://avatars2.githubusercontent.com/u/9685048?v=4","gravatar_id":"","url":"https://api.github.com/users/MrBlenny","html_url":"https://github.com/MrBlenny","followers_url":"https://api.github.com/users/MrBlenny/followers","following_url":"https://api.github.com/users/MrBlenny/following{/other_user}","gists_url":"https://api.github.com/users/MrBlenny/gists{/gist_id}","starred_url":"https://api.github.com/users/MrBlenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrBlenny/subscriptions","organizations_url":"https://api.github.com/users/MrBlenny/orgs","repos_url":"https://api.github.com/users/MrBlenny/repos","events_url":"https://api.github.com/users/MrBlenny/events{/privacy}","received_events_url":"https://api.github.com/users/MrBlenny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrBlenny/event-framework","description":null,"fork":true,"url":"https://api.github.com/repos/MrBlenny/event-framework","forks_url":"https://api.github.com/repos/MrBlenny/event-framework/forks","keys_url":"https://api.github.com/repos/MrBlenny/event-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrBlenny/event-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrBlenny/event-framework/teams","hooks_url":"https://api.github.com/repos/MrBlenny/event-framework/hooks","issue_events_url":"https://api.github.com/repos/MrBlenny/event-framework/issues/events{/number}","events_url":"https://api.github.com/repos/MrBlenny/event-framework/events","assignees_url":"https://api.github.com/repos/MrBlenny/event-framework/assignees{/user}","branches_url":"https://api.github.com/repos/MrBlenny/event-framework/branches{/branch}","tags_url":"https://api.github.com/repos/MrBlenny/event-framework/tags","blobs_url":"https://api.github.com/repos/MrBlenny/event-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrBlenny/event-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrBlenny/event-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrBlenny/event-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrBlenny/event-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/MrBlenny/event-framework/languages","stargazers_url":"https://api.github.com/repos/MrBlenny/event-framework/stargazers","contributors_url":"https://api.github.com/repos/MrBlenny/event-framework/contributors","subscribers_url":"https://api.github.com/repos/MrBlenny/event-framework/subscribers","subscription_url":"https://api.github.com/repos/MrBlenny/event-framework/subscription","commits_url":"https://api.github.com/repos/MrBlenny/event-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrBlenny/event-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrBlenny/event-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrBlenny/event-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrBlenny/event-framework/contents/{+path}","compare_url":"https://api.github.com/repos/MrBlenny/event-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrBlenny/event-framework/merges","archive_url":"https://api.github.com/repos/MrBlenny/event-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrBlenny/event-framework/downloads","issues_url":"https://api.github.com/repos/MrBlenny/event-framework/issues{/number}","pulls_url":"https://api.github.com/repos/MrBlenny/event-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/MrBlenny/event-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/MrBlenny/event-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrBlenny/event-framework/labels{/name}","releases_url":"https://api.github.com/repos/MrBlenny/event-framework/releases{/id}","deployments_url":"https://api.github.com/repos/MrBlenny/event-framework/deployments","created_at":"2018-03-28T00:16:04Z","updated_at":"2018-03-28T01:13:17Z","pushed_at":"2018-03-28T01:19:21Z","git_url":"git://github.com/MrBlenny/event-framework.git","ssh_url":"git@github.com:MrBlenny/event-framework.git","clone_url":"https://github.com/MrBlenny/event-framework.git","svn_url":"https://github.com/MrBlenny/event-framework","homepage":null,"size":180,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nfour:master","ref":"master","sha":"00101e1500f6f9c17cdbb01857f6d14c82525d69","user":{"login":"nfour","id":2108452,"avatar_url":"https://avatars1.githubusercontent.com/u/2108452?v=4","gravatar_id":"","url":"https://api.github.com/users/nfour","html_url":"https://github.com/nfour","followers_url":"https://api.github.com/users/nfour/followers","following_url":"https://api.github.com/users/nfour/following{/other_user}","gists_url":"https://api.github.com/users/nfour/gists{/gist_id}","starred_url":"https://api.github.com/users/nfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfour/subscriptions","organizations_url":"https://api.github.com/users/nfour/orgs","repos_url":"https://api.github.com/users/nfour/repos","events_url":"https://api.github.com/users/nfour/events{/privacy}","received_events_url":"https://api.github.com/users/nfour/received_events","type":"User","site_admin":false},"repo":{"id":116434596,"name":"event-framework","full_name":"nfour/event-framework","owner":{"login":"nfour","id":2108452,"avatar_url":"https://avatars1.githubusercontent.com/u/2108452?v=4","gravatar_id":"","url":"https://api.github.com/users/nfour","html_url":"https://github.com/nfour","followers_url":"https://api.github.com/users/nfour/followers","following_url":"https://api.github.com/users/nfour/following{/other_user}","gists_url":"https://api.github.com/users/nfour/gists{/gist_id}","starred_url":"https://api.github.com/users/nfour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfour/subscriptions","organizations_url":"https://api.github.com/users/nfour/orgs","repos_url":"https://api.github.com/users/nfour/repos","events_url":"https://api.github.com/users/nfour/events{/privacy}","received_events_url":"https://api.github.com/users/nfour/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nfour/event-framework","description":null,"fork":false,"url":"https://api.github.com/repos/nfour/event-framework","forks_url":"https://api.github.com/repos/nfour/event-framework/forks","keys_url":"https://api.github.com/repos/nfour/event-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfour/event-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfour/event-framework/teams","hooks_url":"https://api.github.com/repos/nfour/event-framework/hooks","issue_events_url":"https://api.github.com/repos/nfour/event-framework/issues/events{/number}","events_url":"https://api.github.com/repos/nfour/event-framework/events","assignees_url":"https://api.github.com/repos/nfour/event-framework/assignees{/user}","branches_url":"https://api.github.com/repos/nfour/event-framework/branches{/branch}","tags_url":"https://api.github.com/repos/nfour/event-framework/tags","blobs_url":"https://api.github.com/repos/nfour/event-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfour/event-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfour/event-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfour/event-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfour/event-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/nfour/event-framework/languages","stargazers_url":"https://api.github.com/repos/nfour/event-framework/stargazers","contributors_url":"https://api.github.com/repos/nfour/event-framework/contributors","subscribers_url":"https://api.github.com/repos/nfour/event-framework/subscribers","subscription_url":"https://api.github.com/repos/nfour/event-framework/subscription","commits_url":"https://api.github.com/repos/nfour/event-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfour/event-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfour/event-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfour/event-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/nfour/event-framework/contents/{+path}","compare_url":"https://api.github.com/repos/nfour/event-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfour/event-framework/merges","archive_url":"https://api.github.com/repos/nfour/event-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfour/event-framework/downloads","issues_url":"https://api.github.com/repos/nfour/event-framework/issues{/number}","pulls_url":"https://api.github.com/repos/nfour/event-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/nfour/event-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/nfour/event-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfour/event-framework/labels{/name}","releases_url":"https://api.github.com/repos/nfour/event-framework/releases{/id}","deployments_url":"https://api.github.com/repos/nfour/event-framework/deployments","created_at":"2018-01-05T22:47:44Z","updated_at":"2018-03-28T10:06:52Z","pushed_at":"2018-03-28T10:06:50Z","git_url":"git://github.com/nfour/event-framework.git","ssh_url":"git@github.com:nfour/event-framework.git","clone_url":"https://github.com/nfour/event-framework.git","svn_url":"https://github.com/nfour/event-framework","homepage":null,"size":195,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nfour/event-framework/pulls/2"},"html":{"href":"https://github.com/nfour/event-framework/pull/2"},"issue":{"href":"https://api.github.com/repos/nfour/event-framework/issues/2"},"comments":{"href":"https://api.github.com/repos/nfour/event-framework/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/nfour/event-framework/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/nfour/event-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nfour/event-framework/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/nfour/event-framework/statuses/df7c3e4ffa3ae0c96ce8ee6fab396c5cb30342a0"}},"author_association":"NONE"}}
{"actor":{"display_login":"nfour"}}