{"action":"closed","number":5811,"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5811","id":206206122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjA2MTIy","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5811","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5811.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5811.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5811","number":5811,"state":"closed","locked":false,"title":"Fix DetailsHeader rendering more than one root","user":{"login":"ThomasMichon","id":6828233,"node_id":"MDQ6VXNlcjY4MjgyMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6828233?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasMichon","html_url":"https://github.com/ThomasMichon","followers_url":"https://api.github.com/users/ThomasMichon/followers","following_url":"https://api.github.com/users/ThomasMichon/following{/other_user}","gists_url":"https://api.github.com/users/ThomasMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasMichon/subscriptions","organizations_url":"https://api.github.com/users/ThomasMichon/orgs","repos_url":"https://api.github.com/users/ThomasMichon/repos","events_url":"https://api.github.com/users/ThomasMichon/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasMichon/received_events","type":"User","site_admin":false},"body":"# Overview\r\n\r\nThe `5.0` branch promises to still support React 15. But the refactor to `DetailsHeader` violates that by returning more than one root element.\r\nThis change pushes the `<label>` elements from `DetailsColumn` into `Layer` elements, so they don't show up as accessible children of the column headers, while still allowing it to be a React child and preserve the layout.\n###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/OfficeDev/office-ui-fabric-react/pull/5811)\n\n","created_at":"2018-08-04T19:18:32Z","updated_at":"2018-08-06T17:55:37Z","closed_at":"2018-08-06T17:55:37Z","merged_at":"2018-08-06T17:55:37Z","merge_commit_sha":"4a67e6dcad6433af963a9126fccaa62e7ef2e7dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5811/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5811/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5811/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/42f2bd017d17ca4cc3eaf278250f5f7c9ab63c77","head":{"label":"ThomasMichon:header-label","ref":"header-label","sha":"42f2bd017d17ca4cc3eaf278250f5f7c9ab63c77","user":{"login":"ThomasMichon","id":6828233,"node_id":"MDQ6VXNlcjY4MjgyMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6828233?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasMichon","html_url":"https://github.com/ThomasMichon","followers_url":"https://api.github.com/users/ThomasMichon/followers","following_url":"https://api.github.com/users/ThomasMichon/following{/other_user}","gists_url":"https://api.github.com/users/ThomasMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasMichon/subscriptions","organizations_url":"https://api.github.com/users/ThomasMichon/orgs","repos_url":"https://api.github.com/users/ThomasMichon/repos","events_url":"https://api.github.com/users/ThomasMichon/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasMichon/received_events","type":"User","site_admin":false},"repo":{"id":63994992,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzk5NDk5Mg==","name":"office-ui-fabric-react","full_name":"ThomasMichon/office-ui-fabric-react","owner":{"login":"ThomasMichon","id":6828233,"node_id":"MDQ6VXNlcjY4MjgyMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6828233?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasMichon","html_url":"https://github.com/ThomasMichon","followers_url":"https://api.github.com/users/ThomasMichon/followers","following_url":"https://api.github.com/users/ThomasMichon/following{/other_user}","gists_url":"https://api.github.com/users/ThomasMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasMichon/subscriptions","organizations_url":"https://api.github.com/users/ThomasMichon/orgs","repos_url":"https://api.github.com/users/ThomasMichon/repos","events_url":"https://api.github.com/users/ThomasMichon/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasMichon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThomasMichon/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react","forks_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/ThomasMichon/office-ui-fabric-react/deployments","created_at":"2016-07-23T02:26:36Z","updated_at":"2016-07-23T02:26:38Z","pushed_at":"2018-08-04T19:15:26Z","git_url":"git://github.com/ThomasMichon/office-ui-fabric-react.git","ssh_url":"git@github.com:ThomasMichon/office-ui-fabric-react.git","clone_url":"https://github.com/ThomasMichon/office-ui-fabric-react.git","svn_url":"https://github.com/ThomasMichon/office-ui-fabric-react","homepage":"http://dev.office.com/fabric","size":37314,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:5.0","ref":"5.0","sha":"879a388fc1c643000f8b537485086beb49b610fe","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNzE0NA==","name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-08-06T17:46:28Z","pushed_at":"2018-08-06T17:55:37Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":37981,"stargazers_count":3064,"watchers_count":3064,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":690,"mirror_url":null,"archived":false,"open_issues_count":338,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":690,"open_issues":338,"watchers":3064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5811"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/5811"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5811"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/5811/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5811/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/5811/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/42f2bd017d17ca4cc3eaf278250f5f7c9ab63c77"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ThomasMichon","id":6828233,"node_id":"MDQ6VXNlcjY4MjgyMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6828233?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasMichon","html_url":"https://github.com/ThomasMichon","followers_url":"https://api.github.com/users/ThomasMichon/followers","following_url":"https://api.github.com/users/ThomasMichon/following{/other_user}","gists_url":"https://api.github.com/users/ThomasMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasMichon/subscriptions","organizations_url":"https://api.github.com/users/ThomasMichon/orgs","repos_url":"https://api.github.com/users/ThomasMichon/repos","events_url":"https://api.github.com/users/ThomasMichon/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasMichon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":109,"deletions":98,"changed_files":2}}
{"actor":{"display_login":"ThomasMichon"}}