{"push_id":2473647175,"size":11,"distinct_size":11,"ref":"refs/heads/v6.x-backport-n-api","head":"1d124e4f050e6ec6635d1192b82e8b7d3f70ed3d","before":"fd3c189e6ab7302b8d7348613bcf9a805e628f6f","commits":[{"sha":"c015009fa5398db5d5f2cdc89ccde6611e498264","author":{"name":"Michael Dawson","email":"241bf52ebd97cc4ec83d57b04d1f9e9053df032e@ca.ibm.com"},"message":"n-api: take n-api out of experimental\n\nTake n-api out of experimental as per:\nhttps://github.com/nodejs/TSC/issues/501\n\nPR-URL: https://github.com/nodejs/node/pull/19262\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Gus Caplan <me@gus.host>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/c015009fa5398db5d5f2cdc89ccde6611e498264"},{"sha":"67db38bdd9fafef0d6cc244a205917530b1dea35","author":{"name":"Kyle Farnung","email":"88e6c356250197158ea31d0fb200ae850d7c3085@microsoft.com"},"message":"n-api,test: add int64 bounds tests\n\nAdded some simple tests to verify that the int64 API is correctly\nhandling numbers greater than 32-bits. This is a basic test, but\nverifies that an implementer hasn't truncated back to 32-bits.\n\nRefs: https://github.com/nodejs/node-chakracore/pull/496\n\nPR-URL: https://github.com/nodejs/node/pull/19309\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/67db38bdd9fafef0d6cc244a205917530b1dea35"},{"sha":"fc490b146f6f9cbc1e9af3c0013ebc4fef73740b","author":{"name":"Kyle Robinson Young","email":"3c25b01657254677d3e1a8fd1f0742c5d489bd39@dontkry.com"},"message":"doc: fix typos on n-api\n\nPR-URL: https://github.com/nodejs/node/pull/19385\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/fc490b146f6f9cbc1e9af3c0013ebc4fef73740b"},{"sha":"3cdb4206296b565a427eb17c6cba4f1973fbe45a","author":{"name":"Michael Dawson","email":"241bf52ebd97cc4ec83d57b04d1f9e9053df032e@ca.ibm.com"},"message":"n-api: add missing exception checking\n\nAdd checks for a pending exception in napi_make_callback\nafter the callback has been invoked.  If there is a pending\nexception then we need to avoid checking the result as that\nwill not be able to complete properly.\n\nAdd additional checks to the unit test for napi_make_callback\nto catch this case.\n\nPR-URL: https://github.com/nodejs/node/pull/19362\nFixes: https://github.com/nodejs/node-addon-api/issues/235\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/3cdb4206296b565a427eb17c6cba4f1973fbe45a"},{"sha":"f4adec5f26eafe3994abaaefdfc75be597ad78e5","author":{"name":"Mathias Buus","email":"3e6f04e2728426b968d0677989cd60116e13f865@gmail.com"},"message":"n-api: add napi_fatal_exception\n\nAdd function to trigger and uncaught exception.\nUseful if an async callback throws an exception with\nno way to recover.\n\nPR-URL: https://github.com/nodejs/node/pull/19337\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/f4adec5f26eafe3994abaaefdfc75be597ad78e5"},{"sha":"6b6d620d50ecbebca286ad0894f3703aeef4cdc8","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"n-api: re-write test_make_callback\n\nThis re-writes the test in C by dropping std::vector<napi_value> in\nfavour of a C99 variable length array, and by dropping the anonymous\nnamespace in favour of static function declarations.\n\nPR-URL: https://github.com/nodejs/node/pull/19448\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/6b6d620d50ecbebca286ad0894f3703aeef4cdc8"},{"sha":"d4724ef870e3a2a995dd3626c902b70cad9054ed","author":{"name":"jiangq","email":"051b9bcade506979f6a4ed0b5dd2ae06ff910be1@gmail.com"},"message":"doc: Add a missing comma\n\nPR-URL: https://github.com/nodejs/node/pull/19555\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/d4724ef870e3a2a995dd3626c902b70cad9054ed"},{"sha":"481d065281875af40a9bb8d256c3649d2b21ce73","author":{"name":"Michael Dawson","email":"697f19bdc6386e09c0d34238f49474ef87a73bae@devrus.com"},"message":"n-api: bump version of n-api supported\n\nBump the version due to additions to the api.\n\nPR-URL: https://github.com/nodejs/node/pull/19497\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/481d065281875af40a9bb8d256c3649d2b21ce73"},{"sha":"5ce9b733fc138b44fa621dddc1678ae73291ee70","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"n-api: ensure in-module exceptions are propagated\n\nWhenever we call into an addon, whether it is for a callback, for\nmodule init, or for async work-related reasons, we should make sure\nthat\n\n* the last error is cleared,\n* the scopes before the call are the same as after, and\n* if an exception was thrown and captured inside the module, then it is\n  re-thrown after the call.\n\nTherefore we should call into the module in a unified fashion. This\nchange introduces the macro NAPI_CALL_INTO_MODULE() which should be\nused whenever invoking a callback provided by the module.\n\nFixes: https://github.com/nodejs/node/issues/19437\nPR-URL: https://github.com/nodejs/node/pull/19537\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/5ce9b733fc138b44fa621dddc1678ae73291ee70"},{"sha":"bfda5b7ecae8a365612a416510e96b9c8e48d27f","author":{"name":"Gabriel Schulhof","email":"48f782b795f0aaf1d96fa1a041257d381b059e00@intel.com"},"message":"n-api: back up env before finalize\n\nHeed the comment to not use fields of a Reference after calling its\nfinalize callback, because such a call may destroy the Reference.\n\nFixes: https://github.com/nodejs/node/issues/19673\nPR-URL: https://github.com/nodejs/node/pull/19718\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/bfda5b7ecae8a365612a416510e96b9c8e48d27f"},{"sha":"1d124e4f050e6ec6635d1192b82e8b7d3f70ed3d","author":{"name":"Kyle Farnung","email":"88e6c356250197158ea31d0fb200ae850d7c3085@microsoft.com"},"message":"n-api: add more `int64_t` tests\n\n* Updated tests for `Number` and `int32_t`\n* Added new tests for `int64_t`\n* Updated N-API `int64_t` behavior to return zero for all non-finite\n  numbers\n* Clarified the documentation for these calls.\n\nPR-URL: https://github.com/nodejs/node/pull/19402\nRefs: https://github.com/nodejs/node-chakracore/pull/500\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":true,"url":"https://api.github.com/repos/gabrielschulhof/node/commits/1d124e4f050e6ec6635d1192b82e8b7d3f70ed3d"}]}
{"actor":{"display_login":"gabrielschulhof"}}