{"action":"created","comment":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/224281124","pull_request_review_id":163608667,"id":224281124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDI4MTEyNA==","diff_hunk":"@@ -1,9 +1,11 @@\n // Copyright 2018 yuzu emulator team\n // Licensed under GPLv2 or any later version\n // Refer to the license.txt file included.\n-\n #include <memory>\n \n+#include \"core/core.h\"","path":"src/core/hle/service/ldr/ldr.cpp","position":7,"original_position":7,"commit_id":"d356a8ecebb6fd0b3e81b2e77078b312d9c674ae","original_commit_id":"d356a8ecebb6fd0b3e81b2e77078b312d9c674ae","user":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"`<array>` and `common/common_funcs.h` need to be included.","created_at":"2018-10-11T00:19:44Z","updated_at":"2018-10-11T00:19:56Z","html_url":"https://github.com/yuzu-emu/yuzu/pull/1471#discussion_r224281124","pull_request_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments/224281124"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/1471#discussion_r224281124"},"pull_request":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471"}}},"pull_request":{"url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471","id":221969584,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTY5NTg0","html_url":"https://github.com/yuzu-emu/yuzu/pull/1471","diff_url":"https://github.com/yuzu-emu/yuzu/pull/1471.diff","patch_url":"https://github.com/yuzu-emu/yuzu/pull/1471.patch","issue_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1471","number":1471,"state":"open","locked":false,"title":"[WIP] Implemented the LoadNrr and LoadNro functions from the ldr:ro service.","user":{"login":"Subv","id":357072,"node_id":"MDQ6VXNlcjM1NzA3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/357072?v=4","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"The implementation here was based on Atmosphere's implementation of the ldr:ro service. The error condition checks and error codes are still missing, and there's no unloading code at all.","created_at":"2018-10-11T00:08:40Z","updated_at":"2018-10-11T00:19:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8a297cacab36e6a27ffe9dd66f9282ef30a79e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471/commits","review_comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471/comments","review_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1471/comments","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/d356a8ecebb6fd0b3e81b2e77078b312d9c674ae","head":{"label":"Subv:ldr_ro","ref":"ldr_ro","sha":"d356a8ecebb6fd0b3e81b2e77078b312d9c674ae","user":{"login":"Subv","id":357072,"node_id":"MDQ6VXNlcjM1NzA3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/357072?v=4","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"repo":{"id":117480983,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc0ODA5ODM=","name":"yuzu","full_name":"Subv/yuzu","private":false,"owner":{"login":"Subv","id":357072,"node_id":"MDQ6VXNlcjM1NzA3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/357072?v=4","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Subv/yuzu","description":"Nintendo Switch Emulator","fork":true,"url":"https://api.github.com/repos/Subv/yuzu","forks_url":"https://api.github.com/repos/Subv/yuzu/forks","keys_url":"https://api.github.com/repos/Subv/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subv/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subv/yuzu/teams","hooks_url":"https://api.github.com/repos/Subv/yuzu/hooks","issue_events_url":"https://api.github.com/repos/Subv/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/Subv/yuzu/events","assignees_url":"https://api.github.com/repos/Subv/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/Subv/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/Subv/yuzu/tags","blobs_url":"https://api.github.com/repos/Subv/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subv/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subv/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subv/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subv/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/Subv/yuzu/languages","stargazers_url":"https://api.github.com/repos/Subv/yuzu/stargazers","contributors_url":"https://api.github.com/repos/Subv/yuzu/contributors","subscribers_url":"https://api.github.com/repos/Subv/yuzu/subscribers","subscription_url":"https://api.github.com/repos/Subv/yuzu/subscription","commits_url":"https://api.github.com/repos/Subv/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subv/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subv/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subv/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subv/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/Subv/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subv/yuzu/merges","archive_url":"https://api.github.com/repos/Subv/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subv/yuzu/downloads","issues_url":"https://api.github.com/repos/Subv/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/Subv/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/Subv/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/Subv/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subv/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/Subv/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/Subv/yuzu/deployments","created_at":"2018-01-15T01:08:02Z","updated_at":"2018-06-19T00:25:10Z","pushed_at":"2018-10-11T00:10:23Z","git_url":"git://github.com/Subv/yuzu.git","ssh_url":"git@github.com:Subv/yuzu.git","clone_url":"https://github.com/Subv/yuzu.git","svn_url":"https://github.com/Subv/yuzu","homepage":"","size":23735,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"yuzu-emu:master","ref":"master","sha":"03ec936ca007364e2c287f78dbbe8c5551dc2234","user":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":116167731,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYxNjc3MzE=","name":"yuzu","full_name":"yuzu-emu/yuzu","private":false,"owner":{"login":"yuzu-emu","id":35075882,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDc1ODgy","avatar_url":"https://avatars1.githubusercontent.com/u/35075882?v=4","gravatar_id":"","url":"https://api.github.com/users/yuzu-emu","html_url":"https://github.com/yuzu-emu","followers_url":"https://api.github.com/users/yuzu-emu/followers","following_url":"https://api.github.com/users/yuzu-emu/following{/other_user}","gists_url":"https://api.github.com/users/yuzu-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuzu-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuzu-emu/subscriptions","organizations_url":"https://api.github.com/users/yuzu-emu/orgs","repos_url":"https://api.github.com/users/yuzu-emu/repos","events_url":"https://api.github.com/users/yuzu-emu/events{/privacy}","received_events_url":"https://api.github.com/users/yuzu-emu/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yuzu-emu/yuzu","description":"Nintendo Switch Emulator","fork":false,"url":"https://api.github.com/repos/yuzu-emu/yuzu","forks_url":"https://api.github.com/repos/yuzu-emu/yuzu/forks","keys_url":"https://api.github.com/repos/yuzu-emu/yuzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuzu-emu/yuzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuzu-emu/yuzu/teams","hooks_url":"https://api.github.com/repos/yuzu-emu/yuzu/hooks","issue_events_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/events{/number}","events_url":"https://api.github.com/repos/yuzu-emu/yuzu/events","assignees_url":"https://api.github.com/repos/yuzu-emu/yuzu/assignees{/user}","branches_url":"https://api.github.com/repos/yuzu-emu/yuzu/branches{/branch}","tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/tags","blobs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/{sha}","languages_url":"https://api.github.com/repos/yuzu-emu/yuzu/languages","stargazers_url":"https://api.github.com/repos/yuzu-emu/yuzu/stargazers","contributors_url":"https://api.github.com/repos/yuzu-emu/yuzu/contributors","subscribers_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscribers","subscription_url":"https://api.github.com/repos/yuzu-emu/yuzu/subscription","commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuzu-emu/yuzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuzu-emu/yuzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuzu-emu/yuzu/contents/{+path}","compare_url":"https://api.github.com/repos/yuzu-emu/yuzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuzu-emu/yuzu/merges","archive_url":"https://api.github.com/repos/yuzu-emu/yuzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuzu-emu/yuzu/downloads","issues_url":"https://api.github.com/repos/yuzu-emu/yuzu/issues{/number}","pulls_url":"https://api.github.com/repos/yuzu-emu/yuzu/pulls{/number}","milestones_url":"https://api.github.com/repos/yuzu-emu/yuzu/milestones{/number}","notifications_url":"https://api.github.com/repos/yuzu-emu/yuzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuzu-emu/yuzu/labels{/name}","releases_url":"https://api.github.com/repos/yuzu-emu/yuzu/releases{/id}","deployments_url":"https://api.github.com/repos/yuzu-emu/yuzu/deployments","created_at":"2018-01-03T18:13:57Z","updated_at":"2018-10-10T22:14:35Z","pushed_at":"2018-10-11T00:10:25Z","git_url":"git://github.com/yuzu-emu/yuzu.git","ssh_url":"git@github.com:yuzu-emu/yuzu.git","clone_url":"https://github.com/yuzu-emu/yuzu.git","svn_url":"https://github.com/yuzu-emu/yuzu","homepage":"","size":24287,"stargazers_count":5236,"watchers_count":5236,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":302,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":302,"open_issues":54,"watchers":5236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471"},"html":{"href":"https://github.com/yuzu-emu/yuzu/pull/1471"},"issue":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1471"},"comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/issues/1471/comments"},"review_comments":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471/comments"},"review_comment":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/pulls/1471/commits"},"statuses":{"href":"https://api.github.com/repos/yuzu-emu/yuzu/statuses/d356a8ecebb6fd0b3e81b2e77078b312d9c674ae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lioncash"}}