{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/7","id":178122544,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4MTIyNTQ0","html_url":"https://github.com/drupalcommerce/commerce_shipping/pull/7","diff_url":"https://github.com/drupalcommerce/commerce_shipping/pull/7.diff","patch_url":"https://github.com/drupalcommerce/commerce_shipping/pull/7.patch","issue_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues/7","number":7,"state":"closed","locked":false,"title":"Update readme.md removing reference to conditions in shipping methods","user":{"login":"calbasi","id":17086589,"node_id":"MDQ6VXNlcjE3MDg2NTg5","avatar_url":"https://avatars0.githubusercontent.com/u/17086589?v=4","gravatar_id":"","url":"https://api.github.com/users/calbasi","html_url":"https://github.com/calbasi","followers_url":"https://api.github.com/users/calbasi/followers","following_url":"https://api.github.com/users/calbasi/following{/other_user}","gists_url":"https://api.github.com/users/calbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/calbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbasi/subscriptions","organizations_url":"https://api.github.com/users/calbasi/orgs","repos_url":"https://api.github.com/users/calbasi/repos","events_url":"https://api.github.com/users/calbasi/events{/privacy}","received_events_url":"https://api.github.com/users/calbasi/received_events","type":"User","site_admin":false},"body":"Hi,\r\nI think all the section of readme.md related to:\r\n\r\n> Shipping methods currently don't have conditions that would allow them to be conditionally shown at checkout based on total weight, order total, or other factors. Site builders can temporarily replicate this functionality by implementing hook_commerce_shipping_methods_alter(&$shipping_methods, $shipment).\r\n\r\nis outdated and now conditions are shown at UI, probably after this commit:\r\nhttps://github.com/drupalcommerce/commerce_shipping/commit/7e9755f470f44bb2fed98e37d6a2d5b3e60445a9","created_at":"2018-03-28T18:22:07Z","updated_at":"2018-07-18T10:33:14Z","closed_at":"2018-07-18T10:33:14Z","merged_at":"2018-07-18T10:33:14Z","merge_commit_sha":"25179dac5896c5ebb4c611bb9436e40441b17345","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/7/commits","review_comments_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/7/comments","review_comment_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues/7/comments","statuses_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/statuses/2febd796ec38220de662410a4a8d383e89fb52f2","head":{"label":"calbasipuntnet:8.x-2.x","ref":"8.x-2.x","sha":"2febd796ec38220de662410a4a8d383e89fb52f2","user":{"login":"calbasipuntnet","id":17086608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDg2NjA4","avatar_url":"https://avatars0.githubusercontent.com/u/17086608?v=4","gravatar_id":"","url":"https://api.github.com/users/calbasipuntnet","html_url":"https://github.com/calbasipuntnet","followers_url":"https://api.github.com/users/calbasipuntnet/followers","following_url":"https://api.github.com/users/calbasipuntnet/following{/other_user}","gists_url":"https://api.github.com/users/calbasipuntnet/gists{/gist_id}","starred_url":"https://api.github.com/users/calbasipuntnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbasipuntnet/subscriptions","organizations_url":"https://api.github.com/users/calbasipuntnet/orgs","repos_url":"https://api.github.com/users/calbasipuntnet/repos","events_url":"https://api.github.com/users/calbasipuntnet/events{/privacy}","received_events_url":"https://api.github.com/users/calbasipuntnet/received_events","type":"Organization","site_admin":false},"repo":{"id":127180774,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcxODA3NzQ=","name":"commerce_shipping","full_name":"calbasipuntnet/commerce_shipping","owner":{"login":"calbasipuntnet","id":17086608,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDg2NjA4","avatar_url":"https://avatars0.githubusercontent.com/u/17086608?v=4","gravatar_id":"","url":"https://api.github.com/users/calbasipuntnet","html_url":"https://github.com/calbasipuntnet","followers_url":"https://api.github.com/users/calbasipuntnet/followers","following_url":"https://api.github.com/users/calbasipuntnet/following{/other_user}","gists_url":"https://api.github.com/users/calbasipuntnet/gists{/gist_id}","starred_url":"https://api.github.com/users/calbasipuntnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbasipuntnet/subscriptions","organizations_url":"https://api.github.com/users/calbasipuntnet/orgs","repos_url":"https://api.github.com/users/calbasipuntnet/repos","events_url":"https://api.github.com/users/calbasipuntnet/events{/privacy}","received_events_url":"https://api.github.com/users/calbasipuntnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calbasipuntnet/commerce_shipping","description":"The official mirror of Commerce Shipping","fork":true,"url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping","forks_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/forks","keys_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/teams","hooks_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/hooks","issue_events_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/events","assignees_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/tags","blobs_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/languages","stargazers_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/stargazers","contributors_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/contributors","subscribers_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/subscribers","subscription_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/subscription","commits_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/merges","archive_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/downloads","issues_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/labels{/name}","releases_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/calbasipuntnet/commerce_shipping/deployments","created_at":"2018-03-28T18:18:55Z","updated_at":"2018-03-28T18:21:15Z","pushed_at":"2018-03-28T18:21:14Z","git_url":"git://github.com/calbasipuntnet/commerce_shipping.git","ssh_url":"git@github.com:calbasipuntnet/commerce_shipping.git","clone_url":"https://github.com/calbasipuntnet/commerce_shipping.git","svn_url":"https://github.com/calbasipuntnet/commerce_shipping","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-2.x"}},"base":{"label":"drupalcommerce:8.x-2.x","ref":"8.x-2.x","sha":"5406a8d780850f4e9e19a304145cc9a936d24094","user":{"login":"drupalcommerce","id":183176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzE3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/183176?v=4","gravatar_id":"","url":"https://api.github.com/users/drupalcommerce","html_url":"https://github.com/drupalcommerce","followers_url":"https://api.github.com/users/drupalcommerce/followers","following_url":"https://api.github.com/users/drupalcommerce/following{/other_user}","gists_url":"https://api.github.com/users/drupalcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/drupalcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupalcommerce/subscriptions","organizations_url":"https://api.github.com/users/drupalcommerce/orgs","repos_url":"https://api.github.com/users/drupalcommerce/repos","events_url":"https://api.github.com/users/drupalcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/drupalcommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":88050711,"node_id":"MDEwOlJlcG9zaXRvcnk4ODA1MDcxMQ==","name":"commerce_shipping","full_name":"drupalcommerce/commerce_shipping","owner":{"login":"drupalcommerce","id":183176,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MzE3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/183176?v=4","gravatar_id":"","url":"https://api.github.com/users/drupalcommerce","html_url":"https://github.com/drupalcommerce","followers_url":"https://api.github.com/users/drupalcommerce/followers","following_url":"https://api.github.com/users/drupalcommerce/following{/other_user}","gists_url":"https://api.github.com/users/drupalcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/drupalcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupalcommerce/subscriptions","organizations_url":"https://api.github.com/users/drupalcommerce/orgs","repos_url":"https://api.github.com/users/drupalcommerce/repos","events_url":"https://api.github.com/users/drupalcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/drupalcommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupalcommerce/commerce_shipping","description":"The official mirror of Commerce Shipping","fork":false,"url":"https://api.github.com/repos/drupalcommerce/commerce_shipping","forks_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/forks","keys_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/teams","hooks_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/hooks","issue_events_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/events","assignees_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/tags","blobs_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/languages","stargazers_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/stargazers","contributors_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/contributors","subscribers_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/subscribers","subscription_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/subscription","commits_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/merges","archive_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/downloads","issues_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/labels{/name}","releases_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/drupalcommerce/commerce_shipping/deployments","created_at":"2017-04-12T12:45:08Z","updated_at":"2018-07-18T10:30:25Z","pushed_at":"2018-07-18T10:33:14Z","git_url":"git://github.com/drupalcommerce/commerce_shipping.git","ssh_url":"git@github.com:drupalcommerce/commerce_shipping.git","clone_url":"https://github.com/drupalcommerce/commerce_shipping.git","svn_url":"https://github.com/drupalcommerce/commerce_shipping","homepage":null,"size":321,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":9,"open_issues":4,"watchers":1,"default_branch":"8.x-2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/7"},"html":{"href":"https://github.com/drupalcommerce/commerce_shipping/pull/7"},"issue":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues/7"},"comments":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/drupalcommerce/commerce_shipping/statuses/2febd796ec38220de662410a4a8d383e89fb52f2"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bojanz","id":330162,"node_id":"MDQ6VXNlcjMzMDE2Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/330162?v=4","gravatar_id":"","url":"https://api.github.com/users/bojanz","html_url":"https://github.com/bojanz","followers_url":"https://api.github.com/users/bojanz/followers","following_url":"https://api.github.com/users/bojanz/following{/other_user}","gists_url":"https://api.github.com/users/bojanz/gists{/gist_id}","starred_url":"https://api.github.com/users/bojanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bojanz/subscriptions","organizations_url":"https://api.github.com/users/bojanz/orgs","repos_url":"https://api.github.com/users/bojanz/repos","events_url":"https://api.github.com/users/bojanz/events{/privacy}","received_events_url":"https://api.github.com/users/bojanz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":23,"changed_files":1}}
{"actor":{"display_login":"bojanz"}}