{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/49333","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/49333/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49333/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/49333/events","html_url":"https://github.com/ansible/ansible/pull/49333","id":385927575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0Nzg3Mjg3","number":49333,"title":"Fix idempotency issues 2","user":{"login":"jose-delarosa","id":3810747,"node_id":"MDQ6VXNlcjM4MTA3NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3810747?v=4","gravatar_id":"","url":"https://api.github.com/users/jose-delarosa","html_url":"https://github.com/jose-delarosa","followers_url":"https://api.github.com/users/jose-delarosa/followers","following_url":"https://api.github.com/users/jose-delarosa/following{/other_user}","gists_url":"https://api.github.com/users/jose-delarosa/gists{/gist_id}","starred_url":"https://api.github.com/users/jose-delarosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jose-delarosa/subscriptions","organizations_url":"https://api.github.com/users/jose-delarosa/orgs","repos_url":"https://api.github.com/users/jose-delarosa/repos","events_url":"https://api.github.com/users/jose-delarosa/events{/privacy}","received_events_url":"https://api.github.com/users/jose-delarosa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-29T21:10:54Z","updated_at":"2018-11-29T21:30:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49333","html_url":"https://github.com/ansible/ansible/pull/49333","diff_url":"https://github.com/ansible/ansible/pull/49333.diff","patch_url":"https://github.com/ansible/ansible/pull/49333.patch"},"body":"##### SUMMARY\r\nFixes idempotency issues in `set_manager_attributes` and `set_bios_default_settings`. In `set_manager_attributes`, checks first if the desired manager attribute is already set to the desired value.\r\n\r\nFixes https://github.com/ansible/ansible/issues/49209\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n- Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nredfish_utils\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here -->\r\n<!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->\r\nBefore this patch, a manager attribute setting would always update regardless whether it was already set or not.\r\n\r\nWith this patch, it only updates if the attribute is not already set to what is specified.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/443000349","html_url":"https://github.com/ansible/ansible/pull/49333#issuecomment-443000349","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49333","id":443000349,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzAwMDM0OQ==","user":{"login":"ansibot","id":6585283,"node_id":"MDQ6VXNlcjY1ODUyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T21:30:57Z","updated_at":"2018-11-29T21:30:57Z","author_association":"CONTRIBUTOR","body":"Hi @jose-delarosa, thank you for submitting this pull-request!\n\n[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)\n<!--- boilerplate: thank_submitter --->"}}
{"actor":{"display_login":"ansibot"}}