{"action":"opened","number":4308,"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4308","id":175396545,"html_url":"https://github.com/istio/istio/pull/4308","diff_url":"https://github.com/istio/istio/pull/4308.diff","patch_url":"https://github.com/istio/istio/pull/4308.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/4308","number":4308,"state":"open","locked":false,"title":"V1alpha3 converter tool","user":{"login":"ijsnellf","id":19473346,"avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"body":"From the command description:\r\n> Converts sets of v1alpha1 configs to v1alpha3 equivalents on a best effort basis. The output should be considered a starting point for your v1alpha3 configs and probably require some minor modification.  Warnings will (hopefully) be generated where configs cannot be converted perfectly, or in certain edge cases.  The input must be the set of configs that would be in place in an environment at a given time.  This allows the command to attempt to create and merge output configs intelligently. Output configs are given the namespace and domain of the first input config so it is recommended that input configs be part of the same namespace and domain.\r\n\r\nI had to recreate this PR after recreating my Istio fork. There are only minor differences between this and the old PR: config metadata grabbed from the first config and a couple small fixes were made.\r\n\r\nNote the following potential TODOs that may be handled in a future PR:\r\n```\r\n\t// TODO: k8s ingress -> gateway?\r\n\t// TODO: create missing destination rules/subsets?\r\n```\r\n\r\nContributes to https://github.com/istio/istio/issues/3621.","created_at":"2018-03-15T22:33:34Z","updated_at":"2018-03-15T22:33:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/4308/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/4308/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/4308/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/7c0ee1d6728e0df87a5bc831e49a3dcf2e65e156","head":{"label":"ijsnellf:v1alpha3-converter-tool","ref":"v1alpha3-converter-tool","sha":"7c0ee1d6728e0df87a5bc831e49a3dcf2e65e156","user":{"login":"ijsnellf","id":19473346,"avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"repo":{"id":123497648,"name":"istio","full_name":"ijsnellf/istio","owner":{"login":"ijsnellf","id":19473346,"avatar_url":"https://avatars1.githubusercontent.com/u/19473346?v=4","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijsnellf/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/ijsnellf/istio","forks_url":"https://api.github.com/repos/ijsnellf/istio/forks","keys_url":"https://api.github.com/repos/ijsnellf/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijsnellf/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijsnellf/istio/teams","hooks_url":"https://api.github.com/repos/ijsnellf/istio/hooks","issue_events_url":"https://api.github.com/repos/ijsnellf/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ijsnellf/istio/events","assignees_url":"https://api.github.com/repos/ijsnellf/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ijsnellf/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ijsnellf/istio/tags","blobs_url":"https://api.github.com/repos/ijsnellf/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijsnellf/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijsnellf/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijsnellf/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijsnellf/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ijsnellf/istio/languages","stargazers_url":"https://api.github.com/repos/ijsnellf/istio/stargazers","contributors_url":"https://api.github.com/repos/ijsnellf/istio/contributors","subscribers_url":"https://api.github.com/repos/ijsnellf/istio/subscribers","subscription_url":"https://api.github.com/repos/ijsnellf/istio/subscription","commits_url":"https://api.github.com/repos/ijsnellf/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijsnellf/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijsnellf/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijsnellf/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijsnellf/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ijsnellf/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijsnellf/istio/merges","archive_url":"https://api.github.com/repos/ijsnellf/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijsnellf/istio/downloads","issues_url":"https://api.github.com/repos/ijsnellf/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ijsnellf/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ijsnellf/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ijsnellf/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijsnellf/istio/labels{/name}","releases_url":"https://api.github.com/repos/ijsnellf/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ijsnellf/istio/deployments","created_at":"2018-03-01T22:03:57Z","updated_at":"2018-03-01T22:04:02Z","pushed_at":"2018-03-15T22:19:51Z","git_url":"git://github.com/ijsnellf/istio.git","ssh_url":"git@github.com:ijsnellf/istio.git","clone_url":"https://github.com/ijsnellf/istio.git","svn_url":"https://github.com/ijsnellf/istio","homepage":"https://istio.io","size":16960,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"c9162997a07ec188e0d3fddddee4b582b407801d","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-03-15T22:10:27Z","pushed_at":"2018-03-15T22:23:58Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":17625,"stargazers_count":6538,"watchers_count":6538,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":852,"mirror_url":null,"archived":false,"open_issues_count":739,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":852,"open_issues":739,"watchers":6538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/4308"},"html":{"href":"https://github.com/istio/istio/pull/4308"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/4308"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/4308/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/4308/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/4308/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/7c0ee1d6728e0df87a5bc831e49a3dcf2e65e156"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":1497,"deletions":17,"changed_files":37}}
{"actor":{"display_login":"ijsnellf"}}