{"action":"created","comment":{"url":"https://api.github.com/repos/EventStore/EventStore/pulls/comments/241498819","pull_request_review_id":184787598,"id":241498819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ5ODgxOQ==","diff_hunk":"@@ -262,6 +262,13 @@ public void Handle(ReaderSubscriptionMessage.Faulted message)\n             if (!_eventReaderSubscriptions.TryGetValue(message.CorrelationId, out projectionId))\n                 return; // unsubscribed\n \n+            if (message.Reason.Contains(\"was expected in the stream\"))\n+            {\n+                // Log without fault the projection\n+                _logger.Debug(message.Reason);","path":"src/EventStore.Projections.Core/Services/Processing/EventReaderCoreService.cs","position":null,"original_position":7,"commit_id":"9ea7ee3a5fc918a2a44a5c6bf35cf057f21f9992","original_commit_id":"d22da7fea50eecd85bf9450d68849f017859be17","user":{"login":"riccardone","id":5390480,"node_id":"MDQ6VXNlcjUzOTA0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5390480?v=4","gravatar_id":"","url":"https://api.github.com/users/riccardone","html_url":"https://github.com/riccardone","followers_url":"https://api.github.com/users/riccardone/followers","following_url":"https://api.github.com/users/riccardone/following{/other_user}","gists_url":"https://api.github.com/users/riccardone/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardone/subscriptions","organizations_url":"https://api.github.com/users/riccardone/orgs","repos_url":"https://api.github.com/users/riccardone/repos","events_url":"https://api.github.com/users/riccardone/events{/privacy}","received_events_url":"https://api.github.com/users/riccardone/received_events","type":"User","site_admin":false},"body":"set to Trace now","created_at":"2018-12-13T17:46:57Z","updated_at":"2018-12-13T17:46:57Z","html_url":"https://github.com/EventStore/EventStore/pull/1774#discussion_r241498819","pull_request_url":"https://api.github.com/repos/EventStore/EventStore/pulls/1774","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/comments/241498819"},"html":{"href":"https://github.com/EventStore/EventStore/pull/1774#discussion_r241498819"},"pull_request":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1774"}},"in_reply_to_id":240998039},"pull_request":{"url":"https://api.github.com/repos/EventStore/EventStore/pulls/1774","id":232584768,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTg0NzY4","html_url":"https://github.com/EventStore/EventStore/pull/1774","diff_url":"https://github.com/EventStore/EventStore/pull/1774.diff","patch_url":"https://github.com/EventStore/EventStore/pull/1774.patch","issue_url":"https://api.github.com/repos/EventStore/EventStore/issues/1774","number":1774,"state":"open","locked":false,"title":"StreamEventReader Fix (no InvalidOperationException)","user":{"login":"riccardone","id":5390480,"node_id":"MDQ6VXNlcjUzOTA0ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5390480?v=4","gravatar_id":"","url":"https://api.github.com/users/riccardone","html_url":"https://github.com/riccardone","followers_url":"https://api.github.com/users/riccardone/followers","following_url":"https://api.github.com/users/riccardone/following{/other_user}","gists_url":"https://api.github.com/users/riccardone/gists{/gist_id}","starred_url":"https://api.github.com/users/riccardone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riccardone/subscriptions","organizations_url":"https://api.github.com/users/riccardone/orgs","repos_url":"https://api.github.com/users/riccardone/repos","events_url":"https://api.github.com/users/riccardone/events{/privacy}","received_events_url":"https://api.github.com/users/riccardone/received_events","type":"User","site_admin":false},"body":"Fix scenario when $maxAge/$MaxCount are set on the original stream and events are written while the projection is stopped. \r\nTo manually reproduce:\r\n1. stop the projection\r\n2. write events on the original stream\r\n3. start the projection\r\n4. write other events on the original stream\r\n5 (original code) the projection goes in Fault state + thrown an InvalidOperationException \r\n5 (with this fix) the projection keep working and log the error \r\n\r\nFixes https://github.com/EventStore/EventStore/issues/1468","created_at":"2018-11-21T09:03:33Z","updated_at":"2018-12-13T17:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"636a68d386a3e3a0157fbbbb88fcc77d95be1ff6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EventStore/EventStore/pulls/1774/commits","review_comments_url":"https://api.github.com/repos/EventStore/EventStore/pulls/1774/comments","review_comment_url":"https://api.github.com/repos/EventStore/EventStore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EventStore/EventStore/issues/1774/comments","statuses_url":"https://api.github.com/repos/EventStore/EventStore/statuses/9ea7ee3a5fc918a2a44a5c6bf35cf057f21f9992","head":{"label":"EventStore:StreamEventReaderFix2","ref":"StreamEventReaderFix2","sha":"9ea7ee3a5fc918a2a44a5c6bf35cf057f21f9992","user":{"login":"EventStore","id":1628864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":5844474,"node_id":"MDEwOlJlcG9zaXRvcnk1ODQ0NDc0","name":"EventStore","full_name":"EventStore/EventStore","private":false,"owner":{"login":"EventStore","id":1628864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EventStore/EventStore","description":"The open-source, functional database with Complex Event Processing in JavaScript.","fork":false,"url":"https://api.github.com/repos/EventStore/EventStore","forks_url":"https://api.github.com/repos/EventStore/EventStore/forks","keys_url":"https://api.github.com/repos/EventStore/EventStore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EventStore/EventStore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EventStore/EventStore/teams","hooks_url":"https://api.github.com/repos/EventStore/EventStore/hooks","issue_events_url":"https://api.github.com/repos/EventStore/EventStore/issues/events{/number}","events_url":"https://api.github.com/repos/EventStore/EventStore/events","assignees_url":"https://api.github.com/repos/EventStore/EventStore/assignees{/user}","branches_url":"https://api.github.com/repos/EventStore/EventStore/branches{/branch}","tags_url":"https://api.github.com/repos/EventStore/EventStore/tags","blobs_url":"https://api.github.com/repos/EventStore/EventStore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EventStore/EventStore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EventStore/EventStore/git/refs{/sha}","trees_url":"https://api.github.com/repos/EventStore/EventStore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EventStore/EventStore/statuses/{sha}","languages_url":"https://api.github.com/repos/EventStore/EventStore/languages","stargazers_url":"https://api.github.com/repos/EventStore/EventStore/stargazers","contributors_url":"https://api.github.com/repos/EventStore/EventStore/contributors","subscribers_url":"https://api.github.com/repos/EventStore/EventStore/subscribers","subscription_url":"https://api.github.com/repos/EventStore/EventStore/subscription","commits_url":"https://api.github.com/repos/EventStore/EventStore/commits{/sha}","git_commits_url":"https://api.github.com/repos/EventStore/EventStore/git/commits{/sha}","comments_url":"https://api.github.com/repos/EventStore/EventStore/comments{/number}","issue_comment_url":"https://api.github.com/repos/EventStore/EventStore/issues/comments{/number}","contents_url":"https://api.github.com/repos/EventStore/EventStore/contents/{+path}","compare_url":"https://api.github.com/repos/EventStore/EventStore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EventStore/EventStore/merges","archive_url":"https://api.github.com/repos/EventStore/EventStore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EventStore/EventStore/downloads","issues_url":"https://api.github.com/repos/EventStore/EventStore/issues{/number}","pulls_url":"https://api.github.com/repos/EventStore/EventStore/pulls{/number}","milestones_url":"https://api.github.com/repos/EventStore/EventStore/milestones{/number}","notifications_url":"https://api.github.com/repos/EventStore/EventStore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EventStore/EventStore/labels{/name}","releases_url":"https://api.github.com/repos/EventStore/EventStore/releases{/id}","deployments_url":"https://api.github.com/repos/EventStore/EventStore/deployments","created_at":"2012-09-17T17:22:49Z","updated_at":"2018-12-12T03:18:56Z","pushed_at":"2018-12-13T17:46:19Z","git_url":"git://github.com/EventStore/EventStore.git","ssh_url":"git@github.com:EventStore/EventStore.git","clone_url":"https://github.com/EventStore/EventStore.git","svn_url":"https://github.com/EventStore/EventStore","homepage":"https://eventstore.org","size":300532,"stargazers_count":3027,"watchers_count":3027,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":482,"open_issues":226,"watchers":3027,"default_branch":"master"}},"base":{"label":"EventStore:master","ref":"master","sha":"b8d210fc710b9d521c867a916c052ec817d87a3b","user":{"login":"EventStore","id":1628864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":5844474,"node_id":"MDEwOlJlcG9zaXRvcnk1ODQ0NDc0","name":"EventStore","full_name":"EventStore/EventStore","private":false,"owner":{"login":"EventStore","id":1628864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1628864?v=4","gravatar_id":"","url":"https://api.github.com/users/EventStore","html_url":"https://github.com/EventStore","followers_url":"https://api.github.com/users/EventStore/followers","following_url":"https://api.github.com/users/EventStore/following{/other_user}","gists_url":"https://api.github.com/users/EventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/EventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EventStore/subscriptions","organizations_url":"https://api.github.com/users/EventStore/orgs","repos_url":"https://api.github.com/users/EventStore/repos","events_url":"https://api.github.com/users/EventStore/events{/privacy}","received_events_url":"https://api.github.com/users/EventStore/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EventStore/EventStore","description":"The open-source, functional database with Complex Event Processing in JavaScript.","fork":false,"url":"https://api.github.com/repos/EventStore/EventStore","forks_url":"https://api.github.com/repos/EventStore/EventStore/forks","keys_url":"https://api.github.com/repos/EventStore/EventStore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EventStore/EventStore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EventStore/EventStore/teams","hooks_url":"https://api.github.com/repos/EventStore/EventStore/hooks","issue_events_url":"https://api.github.com/repos/EventStore/EventStore/issues/events{/number}","events_url":"https://api.github.com/repos/EventStore/EventStore/events","assignees_url":"https://api.github.com/repos/EventStore/EventStore/assignees{/user}","branches_url":"https://api.github.com/repos/EventStore/EventStore/branches{/branch}","tags_url":"https://api.github.com/repos/EventStore/EventStore/tags","blobs_url":"https://api.github.com/repos/EventStore/EventStore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EventStore/EventStore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EventStore/EventStore/git/refs{/sha}","trees_url":"https://api.github.com/repos/EventStore/EventStore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EventStore/EventStore/statuses/{sha}","languages_url":"https://api.github.com/repos/EventStore/EventStore/languages","stargazers_url":"https://api.github.com/repos/EventStore/EventStore/stargazers","contributors_url":"https://api.github.com/repos/EventStore/EventStore/contributors","subscribers_url":"https://api.github.com/repos/EventStore/EventStore/subscribers","subscription_url":"https://api.github.com/repos/EventStore/EventStore/subscription","commits_url":"https://api.github.com/repos/EventStore/EventStore/commits{/sha}","git_commits_url":"https://api.github.com/repos/EventStore/EventStore/git/commits{/sha}","comments_url":"https://api.github.com/repos/EventStore/EventStore/comments{/number}","issue_comment_url":"https://api.github.com/repos/EventStore/EventStore/issues/comments{/number}","contents_url":"https://api.github.com/repos/EventStore/EventStore/contents/{+path}","compare_url":"https://api.github.com/repos/EventStore/EventStore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EventStore/EventStore/merges","archive_url":"https://api.github.com/repos/EventStore/EventStore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EventStore/EventStore/downloads","issues_url":"https://api.github.com/repos/EventStore/EventStore/issues{/number}","pulls_url":"https://api.github.com/repos/EventStore/EventStore/pulls{/number}","milestones_url":"https://api.github.com/repos/EventStore/EventStore/milestones{/number}","notifications_url":"https://api.github.com/repos/EventStore/EventStore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EventStore/EventStore/labels{/name}","releases_url":"https://api.github.com/repos/EventStore/EventStore/releases{/id}","deployments_url":"https://api.github.com/repos/EventStore/EventStore/deployments","created_at":"2012-09-17T17:22:49Z","updated_at":"2018-12-12T03:18:56Z","pushed_at":"2018-12-13T17:46:19Z","git_url":"git://github.com/EventStore/EventStore.git","ssh_url":"git@github.com:EventStore/EventStore.git","clone_url":"https://github.com/EventStore/EventStore.git","svn_url":"https://github.com/EventStore/EventStore","homepage":"https://eventstore.org","size":300532,"stargazers_count":3027,"watchers_count":3027,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":482,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":482,"open_issues":226,"watchers":3027,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1774"},"html":{"href":"https://github.com/EventStore/EventStore/pull/1774"},"issue":{"href":"https://api.github.com/repos/EventStore/EventStore/issues/1774"},"comments":{"href":"https://api.github.com/repos/EventStore/EventStore/issues/1774/comments"},"review_comments":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1774/comments"},"review_comment":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EventStore/EventStore/pulls/1774/commits"},"statuses":{"href":"https://api.github.com/repos/EventStore/EventStore/statuses/9ea7ee3a5fc918a2a44a5c6bf35cf057f21f9992"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"riccardone"}}