{"action":"created","comment":{"url":"https://api.github.com/repos/kiwicom/graphql/pulls/comments/205036513","pull_request_review_id":140224379,"id":205036513,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTAzNjUxMw==","diff_hunk":"@@ -42,26 +50,24 @@ export default {\n     section: {\n       type: FAQSection,\n       description:\n+        'DEPRECATED: Subsection of FAQ is handled automatically now, this has no effect.' +\n         'Fetch only subsection of FAQ based on the current situation of customer.',\n     },\n   },\n   resolve: async (\n     ancestor: mixed,\n-    { id, section }: Object,\n+    { id }: Object,\n     { dataLoader }: GraphqlContextType,\n   ) => {\n     const categoryId = Number(fromGlobalId(id).id);\n-    const categories = await dataLoader.FAQCategories.load({\n-      // dataloader needs to be called with value => null can't be used as default\n-      section: section || 'all',\n-    });\n+    const categories = await dataLoader.FAQCategories.load({});","path":"src/FAQ/queries/FAQCategory.js","position":41,"original_position":41,"commit_id":"35c8f60b5ffd7290d7e9ae0c3fe7a30906d5318d","original_commit_id":"35c8f60b5ffd7290d7e9ae0c3fe7a30906d5318d","user":{"login":"michalsanger","id":2528846,"node_id":"MDQ6VXNlcjI1Mjg4NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/2528846?v=4","gravatar_id":"","url":"https://api.github.com/users/michalsanger","html_url":"https://github.com/michalsanger","followers_url":"https://api.github.com/users/michalsanger/followers","following_url":"https://api.github.com/users/michalsanger/following{/other_user}","gists_url":"https://api.github.com/users/michalsanger/gists{/gist_id}","starred_url":"https://api.github.com/users/michalsanger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalsanger/subscriptions","organizations_url":"https://api.github.com/users/michalsanger/orgs","repos_url":"https://api.github.com/users/michalsanger/repos","events_url":"https://api.github.com/users/michalsanger/events{/privacy}","received_events_url":"https://api.github.com/users/michalsanger/received_events","type":"User","site_admin":false},"body":"Looks hacky, could only `dataLoader.FAQCategories.load()` be used?","created_at":"2018-07-25T09:13:52Z","updated_at":"2018-07-25T09:14:11Z","html_url":"https://github.com/kiwicom/graphql/pull/286#discussion_r205036513","pull_request_url":"https://api.github.com/repos/kiwicom/graphql/pulls/286","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kiwicom/graphql/pulls/comments/205036513"},"html":{"href":"https://github.com/kiwicom/graphql/pull/286#discussion_r205036513"},"pull_request":{"href":"https://api.github.com/repos/kiwicom/graphql/pulls/286"}}},"pull_request":{"url":"https://api.github.com/repos/kiwicom/graphql/pulls/286","id":203642054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNjQyMDU0","html_url":"https://github.com/kiwicom/graphql/pull/286","diff_url":"https://github.com/kiwicom/graphql/pull/286.diff","patch_url":"https://github.com/kiwicom/graphql/pull/286.patch","issue_url":"https://api.github.com/repos/kiwicom/graphql/issues/286","number":286,"state":"open","locked":false,"title":"Deprecate section parameter for \"FAQCategory\" query","user":{"login":"jaroslav-kubicek","id":2174629,"node_id":"MDQ6VXNlcjIxNzQ2Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/2174629?v=4","gravatar_id":"","url":"https://api.github.com/users/jaroslav-kubicek","html_url":"https://github.com/jaroslav-kubicek","followers_url":"https://api.github.com/users/jaroslav-kubicek/followers","following_url":"https://api.github.com/users/jaroslav-kubicek/following{/other_user}","gists_url":"https://api.github.com/users/jaroslav-kubicek/gists{/gist_id}","starred_url":"https://api.github.com/users/jaroslav-kubicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaroslav-kubicek/subscriptions","organizations_url":"https://api.github.com/users/jaroslav-kubicek/orgs","repos_url":"https://api.github.com/users/jaroslav-kubicek/repos","events_url":"https://api.github.com/users/jaroslav-kubicek/events{/privacy}","received_events_url":"https://api.github.com/users/jaroslav-kubicek/received_events","type":"User","site_admin":false},"body":"Closes #276 \r\n\r\nIt was stupid.\r\n\r\nIstead, I made root \"section\" categories (e.g. \"After booking\") invisible in subcategories.","created_at":"2018-07-24T20:15:52Z","updated_at":"2018-07-25T09:14:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e056036769362d8db34340ed3ec66d5feaa7ddf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jalbertsr","id":9289219,"node_id":"MDQ6VXNlcjkyODkyMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/9289219?v=4","gravatar_id":"","url":"https://api.github.com/users/jalbertsr","html_url":"https://github.com/jalbertsr","followers_url":"https://api.github.com/users/jalbertsr/followers","following_url":"https://api.github.com/users/jalbertsr/following{/other_user}","gists_url":"https://api.github.com/users/jalbertsr/gists{/gist_id}","starred_url":"https://api.github.com/users/jalbertsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalbertsr/subscriptions","organizations_url":"https://api.github.com/users/jalbertsr/orgs","repos_url":"https://api.github.com/users/jalbertsr/repos","events_url":"https://api.github.com/users/jalbertsr/events{/privacy}","received_events_url":"https://api.github.com/users/jalbertsr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwicom/graphql/pulls/286/commits","review_comments_url":"https://api.github.com/repos/kiwicom/graphql/pulls/286/comments","review_comment_url":"https://api.github.com/repos/kiwicom/graphql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwicom/graphql/issues/286/comments","statuses_url":"https://api.github.com/repos/kiwicom/graphql/statuses/35c8f60b5ffd7290d7e9ae0c3fe7a30906d5318d","head":{"label":"kiwicom:deprecate-section-argument","ref":"deprecate-section-argument","sha":"35c8f60b5ffd7290d7e9ae0c3fe7a30906d5318d","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":120301139,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDExMzk=","name":"graphql","full_name":"kiwicom/graphql","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/graphql","description":":grapes: Public GraphQL proxy for Kiwi.com frontend and mobile devices","fork":false,"url":"https://api.github.com/repos/kiwicom/graphql","forks_url":"https://api.github.com/repos/kiwicom/graphql/forks","keys_url":"https://api.github.com/repos/kiwicom/graphql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/graphql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/graphql/teams","hooks_url":"https://api.github.com/repos/kiwicom/graphql/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/graphql/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/graphql/events","assignees_url":"https://api.github.com/repos/kiwicom/graphql/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/graphql/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/graphql/tags","blobs_url":"https://api.github.com/repos/kiwicom/graphql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/graphql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/graphql/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/graphql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/graphql/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/graphql/languages","stargazers_url":"https://api.github.com/repos/kiwicom/graphql/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/graphql/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/graphql/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/graphql/subscription","commits_url":"https://api.github.com/repos/kiwicom/graphql/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/graphql/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/graphql/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/graphql/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/graphql/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/graphql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/graphql/merges","archive_url":"https://api.github.com/repos/kiwicom/graphql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/graphql/downloads","issues_url":"https://api.github.com/repos/kiwicom/graphql/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/graphql/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/graphql/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/graphql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/graphql/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/graphql/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/graphql/deployments","created_at":"2018-02-05T12:22:34Z","updated_at":"2018-07-24T16:22:58Z","pushed_at":"2018-07-24T20:56:54Z","git_url":"git://github.com/kiwicom/graphql.git","ssh_url":"git@github.com:kiwicom/graphql.git","clone_url":"https://github.com/kiwicom/graphql.git","svn_url":"https://github.com/kiwicom/graphql","homepage":"https://kiwi-graphiql.now.sh/","size":1810,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":4,"open_issues":14,"watchers":19,"default_branch":"master"}},"base":{"label":"kiwicom:master","ref":"master","sha":"b20331914cb457018d11e9b47f46c6a3c2a83ac2","user":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"repo":{"id":120301139,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDExMzk=","name":"graphql","full_name":"kiwicom/graphql","owner":{"login":"kiwicom","id":25227300,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MjI3MzAw","avatar_url":"https://avatars2.githubusercontent.com/u/25227300?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwicom","html_url":"https://github.com/kiwicom","followers_url":"https://api.github.com/users/kiwicom/followers","following_url":"https://api.github.com/users/kiwicom/following{/other_user}","gists_url":"https://api.github.com/users/kiwicom/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwicom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwicom/subscriptions","organizations_url":"https://api.github.com/users/kiwicom/orgs","repos_url":"https://api.github.com/users/kiwicom/repos","events_url":"https://api.github.com/users/kiwicom/events{/privacy}","received_events_url":"https://api.github.com/users/kiwicom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwicom/graphql","description":":grapes: Public GraphQL proxy for Kiwi.com frontend and mobile devices","fork":false,"url":"https://api.github.com/repos/kiwicom/graphql","forks_url":"https://api.github.com/repos/kiwicom/graphql/forks","keys_url":"https://api.github.com/repos/kiwicom/graphql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwicom/graphql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwicom/graphql/teams","hooks_url":"https://api.github.com/repos/kiwicom/graphql/hooks","issue_events_url":"https://api.github.com/repos/kiwicom/graphql/issues/events{/number}","events_url":"https://api.github.com/repos/kiwicom/graphql/events","assignees_url":"https://api.github.com/repos/kiwicom/graphql/assignees{/user}","branches_url":"https://api.github.com/repos/kiwicom/graphql/branches{/branch}","tags_url":"https://api.github.com/repos/kiwicom/graphql/tags","blobs_url":"https://api.github.com/repos/kiwicom/graphql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwicom/graphql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwicom/graphql/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwicom/graphql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwicom/graphql/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwicom/graphql/languages","stargazers_url":"https://api.github.com/repos/kiwicom/graphql/stargazers","contributors_url":"https://api.github.com/repos/kiwicom/graphql/contributors","subscribers_url":"https://api.github.com/repos/kiwicom/graphql/subscribers","subscription_url":"https://api.github.com/repos/kiwicom/graphql/subscription","commits_url":"https://api.github.com/repos/kiwicom/graphql/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwicom/graphql/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwicom/graphql/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwicom/graphql/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwicom/graphql/contents/{+path}","compare_url":"https://api.github.com/repos/kiwicom/graphql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwicom/graphql/merges","archive_url":"https://api.github.com/repos/kiwicom/graphql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwicom/graphql/downloads","issues_url":"https://api.github.com/repos/kiwicom/graphql/issues{/number}","pulls_url":"https://api.github.com/repos/kiwicom/graphql/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwicom/graphql/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwicom/graphql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwicom/graphql/labels{/name}","releases_url":"https://api.github.com/repos/kiwicom/graphql/releases{/id}","deployments_url":"https://api.github.com/repos/kiwicom/graphql/deployments","created_at":"2018-02-05T12:22:34Z","updated_at":"2018-07-24T16:22:58Z","pushed_at":"2018-07-24T20:56:54Z","git_url":"git://github.com/kiwicom/graphql.git","ssh_url":"git@github.com:kiwicom/graphql.git","clone_url":"https://github.com/kiwicom/graphql.git","svn_url":"https://github.com/kiwicom/graphql","homepage":"https://kiwi-graphiql.now.sh/","size":1810,"stargazers_count":19,"watchers_count":19,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":4,"open_issues":14,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwicom/graphql/pulls/286"},"html":{"href":"https://github.com/kiwicom/graphql/pull/286"},"issue":{"href":"https://api.github.com/repos/kiwicom/graphql/issues/286"},"comments":{"href":"https://api.github.com/repos/kiwicom/graphql/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwicom/graphql/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwicom/graphql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwicom/graphql/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/kiwicom/graphql/statuses/35c8f60b5ffd7290d7e9ae0c3fe7a30906d5318d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michalsanger"}}