{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/241636252","pull_request_review_id":184959168,"id":241636252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTYzNjI1Mg==","diff_hunk":"@@ -8,9 +8,9 @@\n  * @jest-environment node\n  */\n \n-runPlaceholderTests('ReactSuspensePlaceholder (mutation)', () =>\n-  require('react-noop-renderer'),\n-);\n+// runPlaceholderTests('ReactSuspensePlaceholder (mutation)', () =>\n+//   require('react-noop-renderer'),\n+// );","path":"packages/react-reconciler/src/__tests__/ReactSuspensePlaceholder-test.internal.js","position":9,"original_position":9,"commit_id":"79eb26e34d4b70a4ca2f1b25be72e526b19c0747","original_commit_id":"79eb26e34d4b70a4ca2f1b25be72e526b19c0747","user":{"login":"sebmarkbage","id":63648,"node_id":"MDQ6VXNlcjYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/63648?v=4","gravatar_id":"","url":"https://api.github.com/users/sebmarkbage","html_url":"https://github.com/sebmarkbage","followers_url":"https://api.github.com/users/sebmarkbage/followers","following_url":"https://api.github.com/users/sebmarkbage/following{/other_user}","gists_url":"https://api.github.com/users/sebmarkbage/gists{/gist_id}","starred_url":"https://api.github.com/users/sebmarkbage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebmarkbage/subscriptions","organizations_url":"https://api.github.com/users/sebmarkbage/orgs","repos_url":"https://api.github.com/users/sebmarkbage/repos","events_url":"https://api.github.com/users/sebmarkbage/events{/privacy}","received_events_url":"https://api.github.com/users/sebmarkbage/received_events","type":"User","site_admin":false},"body":"Why disable these?","created_at":"2018-12-14T03:35:46Z","updated_at":"2018-12-14T03:36:06Z","html_url":"https://github.com/facebook/react/pull/14429#discussion_r241636252","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/14429","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/241636252"},"html":{"href":"https://github.com/facebook/react/pull/14429#discussion_r241636252"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/14429"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/14429","id":238256235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjU2MjM1","html_url":"https://github.com/facebook/react/pull/14429","diff_url":"https://github.com/facebook/react/pull/14429.diff","patch_url":"https://github.com/facebook/react/pull/14429.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/14429","number":14429,"state":"open","locked":false,"title":"Memoize promise listeners to prevent exponential growth","user":{"login":"acdlite","id":3624098,"node_id":"MDQ6VXNlcjM2MjQwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"body":"Previously, React would attach a new listener every time a promise is thrown, regardless of whether the same listener was already attached during a previous render. Because React attempts to render every time a promise resolves, the number of listeners grows quickly.\r\n\r\nThis was especially bad in synchronous mode because the renders that happen when the promise pings are not batched together. So if a single promise has multiple listeners for the same root, there will be multiple renders, which in turn results in more listeners being added to the remaining unresolved promises. This results in exponential growth in the number of listeners with respect to the number of IO-bound components in a single render.\r\n\r\nFixes #14220","created_at":"2018-12-13T03:47:05Z","updated_at":"2018-12-14T03:36:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cbea2bd6669aea832709ecbef4f9fa064d9f383","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/14429/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/14429/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/14429/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/79eb26e34d4b70a4ca2f1b25be72e526b19c0747","head":{"label":"acdlite:memoize-promise-listeners","ref":"memoize-promise-listeners","sha":"79eb26e34d4b70a4ca2f1b25be72e526b19c0747","user":{"login":"acdlite","id":3624098,"node_id":"MDQ6VXNlcjM2MjQwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"repo":{"id":45281256,"node_id":"MDEwOlJlcG9zaXRvcnk0NTI4MTI1Ng==","name":"react","full_name":"acdlite/react","private":false,"owner":{"login":"acdlite","id":3624098,"node_id":"MDQ6VXNlcjM2MjQwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"html_url":"https://github.com/acdlite/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/acdlite/react","forks_url":"https://api.github.com/repos/acdlite/react/forks","keys_url":"https://api.github.com/repos/acdlite/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acdlite/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acdlite/react/teams","hooks_url":"https://api.github.com/repos/acdlite/react/hooks","issue_events_url":"https://api.github.com/repos/acdlite/react/issues/events{/number}","events_url":"https://api.github.com/repos/acdlite/react/events","assignees_url":"https://api.github.com/repos/acdlite/react/assignees{/user}","branches_url":"https://api.github.com/repos/acdlite/react/branches{/branch}","tags_url":"https://api.github.com/repos/acdlite/react/tags","blobs_url":"https://api.github.com/repos/acdlite/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acdlite/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acdlite/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/acdlite/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acdlite/react/statuses/{sha}","languages_url":"https://api.github.com/repos/acdlite/react/languages","stargazers_url":"https://api.github.com/repos/acdlite/react/stargazers","contributors_url":"https://api.github.com/repos/acdlite/react/contributors","subscribers_url":"https://api.github.com/repos/acdlite/react/subscribers","subscription_url":"https://api.github.com/repos/acdlite/react/subscription","commits_url":"https://api.github.com/repos/acdlite/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/acdlite/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/acdlite/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/acdlite/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/acdlite/react/contents/{+path}","compare_url":"https://api.github.com/repos/acdlite/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acdlite/react/merges","archive_url":"https://api.github.com/repos/acdlite/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acdlite/react/downloads","issues_url":"https://api.github.com/repos/acdlite/react/issues{/number}","pulls_url":"https://api.github.com/repos/acdlite/react/pulls{/number}","milestones_url":"https://api.github.com/repos/acdlite/react/milestones{/number}","notifications_url":"https://api.github.com/repos/acdlite/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acdlite/react/labels{/name}","releases_url":"https://api.github.com/repos/acdlite/react/releases{/id}","deployments_url":"https://api.github.com/repos/acdlite/react/deployments","created_at":"2015-10-30T23:18:48Z","updated_at":"2018-12-06T03:00:40Z","pushed_at":"2018-12-14T03:35:00Z","git_url":"git://github.com/acdlite/react.git","ssh_url":"git@github.com:acdlite/react.git","clone_url":"https://github.com/acdlite/react.git","svn_url":"https://github.com/acdlite/react","homepage":"https://facebook.github.io/react/","size":118667,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2743fb7b23a5af42059a9b07c5f6048f941709d9","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDI1MA==","name":"react","full_name":"facebook/react","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2018-12-14T03:28:55Z","pushed_at":"2018-12-14T03:35:07Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":139901,"stargazers_count":117559,"watchers_count":117559,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21326,"mirror_url":null,"archived":false,"open_issues_count":503,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21326,"open_issues":503,"watchers":117559,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/14429"},"html":{"href":"https://github.com/facebook/react/pull/14429"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/14429"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/14429/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/14429/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/14429/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/79eb26e34d4b70a4ca2f1b25be72e526b19c0747"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sebmarkbage"}}