{"action":"created","issue":{"url":"https://api.github.com/repos/ofiwg/libfabric/issues/3965","repository_url":"https://api.github.com/repos/ofiwg/libfabric","labels_url":"https://api.github.com/repos/ofiwg/libfabric/issues/3965/labels{/name}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/3965/comments","events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/3965/events","html_url":"https://github.com/ofiwg/libfabric/pull/3965","id":308934387,"number":3965,"title":" common/osd, prov/verbs: Move getters/setters of Memory hooks to common code","user":{"login":"gladkovdmitry17","id":11650339,"avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/gladkovdmitry17","html_url":"https://github.com/gladkovdmitry17","followers_url":"https://api.github.com/users/gladkovdmitry17/followers","following_url":"https://api.github.com/users/gladkovdmitry17/following{/other_user}","gists_url":"https://api.github.com/users/gladkovdmitry17/gists{/gist_id}","starred_url":"https://api.github.com/users/gladkovdmitry17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladkovdmitry17/subscriptions","organizations_url":"https://api.github.com/users/gladkovdmitry17/orgs","repos_url":"https://api.github.com/users/gladkovdmitry17/repos","events_url":"https://api.github.com/users/gladkovdmitry17/events{/privacy}","received_events_url":"https://api.github.com/users/gladkovdmitry17/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-27T11:46:19Z","updated_at":"2018-03-27T18:56:18Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/3965","html_url":"https://github.com/ofiwg/libfabric/pull/3965","diff_url":"https://github.com/ofiwg/libfabric/pull/3965.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/3965.patch"},"body":"This patch moves functions for memory hooks to OS dependency code for Unix and Windows from verbs provider code.\r\nThis allows for other providers re-use this common code."},"comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments/376636493","html_url":"https://github.com/ofiwg/libfabric/pull/3965#issuecomment-376636493","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/3965","id":376636493,"user":{"login":"gladkovdmitry17","id":11650339,"avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/gladkovdmitry17","html_url":"https://github.com/gladkovdmitry17","followers_url":"https://api.github.com/users/gladkovdmitry17/followers","following_url":"https://api.github.com/users/gladkovdmitry17/following{/other_user}","gists_url":"https://api.github.com/users/gladkovdmitry17/gists{/gist_id}","starred_url":"https://api.github.com/users/gladkovdmitry17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladkovdmitry17/subscriptions","organizations_url":"https://api.github.com/users/gladkovdmitry17/orgs","repos_url":"https://api.github.com/users/gladkovdmitry17/repos","events_url":"https://api.github.com/users/gladkovdmitry17/events{/privacy}","received_events_url":"https://api.github.com/users/gladkovdmitry17/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T18:56:18Z","updated_at":"2018-03-27T18:56:18Z","author_association":"MEMBER","body":"> How are these hooks used with the registration cache?\r\n\r\nThe hooks add events into the list and then we read this events through monitor [here](https://github.com/ofiwg/libfabric/blob/58d0dc870e5a31cce8531790d619bd9f8541ff14/prov/verbs/src/verbs_mr.c#L444)\r\n\r\n> Where are the events added to the memory monitor?\r\n\r\nThe events are added from the hooks:\r\n- [free events](https://github.com/ofiwg/libfabric/blob/58d0dc870e5a31cce8531790d619bd9f8541ff14/prov/verbs/src/verbs_domain.c#L135)\r\n- [realloc events](https://github.com/ofiwg/libfabric/blob/58d0dc870e5a31cce8531790d619bd9f8541ff14/prov/verbs/src/verbs_domain.c#L161)\r\n"}}
{"actor":{"display_login":"gladkovdmitry17"}}