{"action":"created","comment":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments/238040969","pull_request_review_id":180498452,"id":238040969,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODA0MDk2OQ==","diff_hunk":"@@ -74,13 +75,13 @@ public async Task<IHtmlContent> ExecuteAsync(DisplayContext context)\n                 var shapeTable = _shapeTableManager.GetShapeTable(theme?.Id);\n \n                 // Use the same prefix as the shape\n-                //var originalHtmlFieldPrefix = context.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix;\n-                //context.ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix = shapeMetadata.Prefix ?? \"\";\n+                var viewContext = context.ServiceProvider.GetService<ViewContextAccessor>().ViewContext;","path":"src/OrchardCore/OrchardCore.DisplayManagement/Implementation/DefaultHtmlDisplay.cs","position":14,"original_position":14,"commit_id":"77f2c6e128e822baba23ea85033549fa79da2356","original_commit_id":"2e01ed617345d7398925b04f8e9fcabda19774e1","user":{"login":"jtkech","id":8586360,"node_id":"MDQ6VXNlcjg1ODYzNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/8586360?v=4","gravatar_id":"","url":"https://api.github.com/users/jtkech","html_url":"https://github.com/jtkech","followers_url":"https://api.github.com/users/jtkech/followers","following_url":"https://api.github.com/users/jtkech/following{/other_user}","gists_url":"https://api.github.com/users/jtkech/gists{/gist_id}","starred_url":"https://api.github.com/users/jtkech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtkech/subscriptions","organizations_url":"https://api.github.com/users/jtkech/orgs","repos_url":"https://api.github.com/users/jtkech/repos","events_url":"https://api.github.com/users/jtkech/events{/privacy}","received_events_url":"https://api.github.com/users/jtkech/received_events","type":"User","site_admin":false},"body":"@sebastienros \r\n\r\nI will try to redo exactly as we did but when creating a new viewContext i will try to also pass a new viewData based on the previous one. Looking at the code, this way it seems that we keep the same model state but we don't share the same data.","created_at":"2018-12-01T00:33:43Z","updated_at":"2018-12-01T00:33:43Z","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/2772#discussion_r238040969","pull_request_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments/238040969"},"html":{"href":"https://github.com/OrchardCMS/OrchardCore/pull/2772#discussion_r238040969"},"pull_request":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772"}},"in_reply_to_id":238034094},"pull_request":{"url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772","id":234865635,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODY1NjM1","html_url":"https://github.com/OrchardCMS/OrchardCore/pull/2772","diff_url":"https://github.com/OrchardCMS/OrchardCore/pull/2772.diff","patch_url":"https://github.com/OrchardCMS/OrchardCore/pull/2772.patch","issue_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/2772","number":2772,"state":"open","locked":false,"title":"Add render property on ContentItemType","user":{"login":"sebastienros","id":1165805,"node_id":"MDQ6VXNlcjExNjU4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1165805?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastienros","html_url":"https://github.com/sebastienros","followers_url":"https://api.github.com/users/sebastienros/followers","following_url":"https://api.github.com/users/sebastienros/following{/other_user}","gists_url":"https://api.github.com/users/sebastienros/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastienros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastienros/subscriptions","organizations_url":"https://api.github.com/users/sebastienros/orgs","repos_url":"https://api.github.com/users/sebastienros/repos","events_url":"https://api.github.com/users/sebastienros/events{/privacy}","received_events_url":"https://api.github.com/users/sebastienros/received_events","type":"User","site_admin":false},"body":"Allow GraphQL to render a content item\r\n\r\n\r\n\r\n","created_at":"2018-11-30T04:05:44Z","updated_at":"2018-12-01T00:33:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"869b2488aedd6103a38ed4dcfd206f55d199f251","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":862148282,"node_id":"MDU6TGFiZWw4NjIxNDgyODI=","url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels/notready","name":"notready","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772/commits","review_comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772/comments","review_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/2772/comments","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/77f2c6e128e822baba23ea85033549fa79da2356","head":{"label":"OrchardCMS:sebros/render","ref":"sebros/render","sha":"77f2c6e128e822baba23ea85033549fa79da2356","user":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDcyNQ==","name":"OrchardCore","full_name":"OrchardCMS/OrchardCore","private":false,"owner":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OrchardCMS/OrchardCore","description":"Orchard Core is an open-source modular and extensible application framework built with ASP.NET Core, and a content management system (CMS) built on top of that application framework.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/OrchardCore","forks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/forks","keys_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/events","assignees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/merges","archive_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2018-11-30T23:38:24Z","pushed_at":"2018-11-30T23:38:29Z","git_url":"git://github.com/OrchardCMS/OrchardCore.git","ssh_url":"git@github.com:OrchardCMS/OrchardCore.git","clone_url":"https://github.com/OrchardCMS/OrchardCore.git","svn_url":"https://github.com/OrchardCMS/OrchardCore","homepage":"http://www.orchardproject.net/","size":52733,"stargazers_count":2246,"watchers_count":2246,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":778,"mirror_url":null,"archived":false,"open_issues_count":431,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":778,"open_issues":431,"watchers":2246,"default_branch":"dev"}},"base":{"label":"OrchardCMS:dev","ref":"dev","sha":"e5a23b91ef965db482b9a5b869eb6fd0ddbaa948","user":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":26884725,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4NDcyNQ==","name":"OrchardCore","full_name":"OrchardCMS/OrchardCore","private":false,"owner":{"login":"OrchardCMS","id":1159247,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTkyNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1159247?v=4","gravatar_id":"","url":"https://api.github.com/users/OrchardCMS","html_url":"https://github.com/OrchardCMS","followers_url":"https://api.github.com/users/OrchardCMS/followers","following_url":"https://api.github.com/users/OrchardCMS/following{/other_user}","gists_url":"https://api.github.com/users/OrchardCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OrchardCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OrchardCMS/subscriptions","organizations_url":"https://api.github.com/users/OrchardCMS/orgs","repos_url":"https://api.github.com/users/OrchardCMS/repos","events_url":"https://api.github.com/users/OrchardCMS/events{/privacy}","received_events_url":"https://api.github.com/users/OrchardCMS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OrchardCMS/OrchardCore","description":"Orchard Core is an open-source modular and extensible application framework built with ASP.NET Core, and a content management system (CMS) built on top of that application framework.","fork":false,"url":"https://api.github.com/repos/OrchardCMS/OrchardCore","forks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/forks","keys_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/teams","hooks_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/hooks","issue_events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/events{/number}","events_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/events","assignees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/assignees{/user}","branches_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/branches{/branch}","tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/tags","blobs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/{sha}","languages_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/languages","stargazers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/stargazers","contributors_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contributors","subscribers_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscribers","subscription_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/subscription","commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/contents/{+path}","compare_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/merges","archive_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/downloads","issues_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues{/number}","pulls_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls{/number}","milestones_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/milestones{/number}","notifications_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/labels{/name}","releases_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/releases{/id}","deployments_url":"https://api.github.com/repos/OrchardCMS/OrchardCore/deployments","created_at":"2014-11-19T22:29:26Z","updated_at":"2018-11-30T23:38:24Z","pushed_at":"2018-11-30T23:38:29Z","git_url":"git://github.com/OrchardCMS/OrchardCore.git","ssh_url":"git@github.com:OrchardCMS/OrchardCore.git","clone_url":"https://github.com/OrchardCMS/OrchardCore.git","svn_url":"https://github.com/OrchardCMS/OrchardCore","homepage":"http://www.orchardproject.net/","size":52733,"stargazers_count":2246,"watchers_count":2246,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":778,"mirror_url":null,"archived":false,"open_issues_count":431,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":778,"open_issues":431,"watchers":2246,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772"},"html":{"href":"https://github.com/OrchardCMS/OrchardCore/pull/2772"},"issue":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/2772"},"comments":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/issues/2772/comments"},"review_comments":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772/comments"},"review_comment":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/pulls/2772/commits"},"statuses":{"href":"https://api.github.com/repos/OrchardCMS/OrchardCore/statuses/77f2c6e128e822baba23ea85033549fa79da2356"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jtkech"}}