{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/27819","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/27819/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/27819/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/27819/events","html_url":"https://github.com/dotnet/roslyn/issues/27819","id":332247711,"node_id":"MDU6SXNzdWUzMzIyNDc3MTE=","number":27819,"title":"[Regression] \"Simplify name\" has started enforcing var usage","user":{"login":"davkean","id":1103906,"node_id":"MDQ6VXNlcjExMDM5MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1103906?v=4","gravatar_id":"","url":"https://api.github.com/users/davkean","html_url":"https://github.com/davkean","followers_url":"https://api.github.com/users/davkean/followers","following_url":"https://api.github.com/users/davkean/following{/other_user}","gists_url":"https://api.github.com/users/davkean/gists{/gist_id}","starred_url":"https://api.github.com/users/davkean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkean/subscriptions","organizations_url":"https://api.github.com/users/davkean/orgs","repos_url":"https://api.github.com/users/davkean/repos","events_url":"https://api.github.com/users/davkean/events{/privacy}","received_events_url":"https://api.github.com/users/davkean/received_events","type":"User","site_admin":false},"labels":[{"id":166377917,"node_id":"MDU6TGFiZWwxNjYzNzc5MTc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":165001069,"node_id":"MDU6TGFiZWwxNjUwMDEwNjk=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Bug","name":"Bug","color":"e52727","default":false},{"id":912763567,"node_id":"MDU6TGFiZWw5MTI3NjM1Njc=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Need%20Design%20Review","name":"Need Design Review","color":"fbca04","default":false},{"id":982995252,"node_id":"MDU6TGFiZWw5ODI5OTUyNTI=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Regression","name":"Regression","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"assignees":[{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/33","html_url":"https://github.com/dotnet/roslyn/milestone/33","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/33/labels","id":3020805,"node_id":"MDk6TWlsZXN0b25lMzAyMDgwNQ==","number":33,"title":"15.8","description":null,"creator":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":77,"closed_issues":570,"state":"open","created_at":"2018-01-08T19:35:57Z","updated_at":"2018-07-12T00:20:02Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2018-06-14T04:27:30Z","updated_at":"2018-07-12T03:40:20Z","closed_at":null,"author_association":"MEMBER","body":"**Version Used**: \r\nVersion 15.8.0 Preview 3.0 [27807.3004.d15.8stg]\r\n\r\nThis is a regression from 15.7. \"Simplify name\" (IDE0001) has started enforcing var usage, despite \"use 'var' instead of explicit type\" (IDE0007) already enforcing this.\r\n\r\nIt also isn't respecting var settings:\r\n\r\n```\r\ncsharp_style_var_for_built_in_types = true:none\r\ncsharp_style_var_elsewhere = true:none\r\n```\r\n\r\n**Steps to Reproduce**:\r\n\r\n``` C#\r\n    class Program\r\n    {\r\n        static void Main(string[] args)\r\n        {\r\n            FileData curData = CreateData();\r\n        }\r\n\r\n        private static FileData CreateData()\r\n        {\r\n            throw new NotImplementedException();\r\n        }\r\n    }\r\n``` \r\n\r\n**Expected Behavior**:\r\n![image](https://user-images.githubusercontent.com/1103906/41391585-dad1c028-6fde-11e8-91cf-de496bd9d347.png)\r\n\r\n\r\n**Actual Behavior**:\r\n![image](https://user-images.githubusercontent.com/1103906/41391576-d27b4124-6fde-11e8-9e38-212dcab32913.png)\r\n\r\nIn my tree, this actually causing it to show up as error:\r\n\r\n![image](https://user-images.githubusercontent.com/1103906/41391619-fb0d3282-6fde-11e8-99ed-2fcd14924127.png)\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/404379557","html_url":"https://github.com/dotnet/roslyn/issues/27819#issuecomment-404379557","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/27819","id":404379557,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDM3OTU1Nw==","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T03:40:20Z","updated_at":"2018-07-12T03:40:20Z","author_association":"CONTRIBUTOR","body":"Note: i actually think both ConfigureAwait and Task<task> are hte problems.  `ConfigureAwait` is a problem due to:\r\n\r\nhttps://github.com/dotnet/roslyn/blob/fe0fe4096f4109652a981f7577a1bf5f5e565d52/src/Workspaces/CSharp/Portable/CodeStyle/TypeStyle/TypeStyleHelper.cs#L132\r\n\r\nHere we get the rightmost invocation (i.e. ```ConfigureAwait(false)```).\r\n\r\nHowever, even if we fixed that, we woudl still be blocked here:\r\n\r\nhttps://github.com/dotnet/roslyn/blob/fe0fe4096f4109652a981f7577a1bf5f5e565d52/src/Workspaces/CSharp/Portable/CodeStyle/TypeStyle/TypeStyleHelper.cs#L210-L212\r\n\r\nHere we would not consider a generic type 'apperant' when being created from a non-generic starting type.\r\n\r\nCan you file a bug on this @davkean ?  I think it would be valuable to have the IDE improve here."}}
{"actor":{"display_login":"CyrusNajmabadi"}}