{"comment":{"url":"https://api.github.com/repos/yunity/karrot-frontend/comments/28065303","html_url":"https://github.com/yunity/karrot-frontend/commit/6fd91c340f8585fe4305d5933564794853ff19e3#commitcomment-28065303","id":28065303,"user":{"login":"mr-kojo","id":16634824,"avatar_url":"https://avatars0.githubusercontent.com/u/16634824?v=4","gravatar_id":"","url":"https://api.github.com/users/mr-kojo","html_url":"https://github.com/mr-kojo","followers_url":"https://api.github.com/users/mr-kojo/followers","following_url":"https://api.github.com/users/mr-kojo/following{/other_user}","gists_url":"https://api.github.com/users/mr-kojo/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-kojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-kojo/subscriptions","organizations_url":"https://api.github.com/users/mr-kojo/orgs","repos_url":"https://api.github.com/users/mr-kojo/repos","events_url":"https://api.github.com/users/mr-kojo/events{/privacy}","received_events_url":"https://api.github.com/users/mr-kojo/received_events","type":"User","site_admin":false},"position":7,"line":65,"path":"src/pages/Settings.vue","commit_id":"6fd91c340f8585fe4305d5933564794853ff19e3","created_at":"2018-03-13T11:03:19Z","updated_at":"2018-03-13T11:03:19Z","author_association":"CONTRIBUTOR","body":"> I would call it callback, as you don't know what it will do :)\r\nHmm, I think that's debatable. If I call it `clearPasswordFields`, I _document_ that the caller is supposed to pass a callback that clears the password fields. \r\n\r\n> ... also, remove the success result value (as I mentioned elsewhere), if it reaches the line after the await bit, then it was successful.\r\nNo, the `await` doesn't throw any error if validation fails. I think the reason is that validation errors are caught by the `withMeta` function. \r\nThat's why I didn't remove the `success` variable and the `return true` statement."}}
{"actor":{"display_login":"mr-kojo"}}