{"action":"created","comment":{"url":"https://api.github.com/repos/desktop/desktop/pulls/comments/192866584","pull_request_review_id":125725827,"id":192866584,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjg2NjU4NA==","diff_hunk":"@@ -0,0 +1,54 @@\n+import * as React from 'react'\n+import { ButtonGroup } from '../lib/button-group'\n+import { Button } from '../lib/button'\n+import { Ref } from '../lib/ref'\n+import { Octicon, OcticonSymbol } from '../octicons'\n+import { Branch } from '../../models/branch'\n+\n+interface INewCommitsBannerProps {\n+  /**\n+   * The number of commits behind `branch`\n+   */\n+  readonly commitsBehind: number\n+\n+  /**\n+   * The base branch that is ahead\n+   */\n+  readonly branch: Branch","path":"app/src/ui/notification/new-commits-banner.tsx","position":17,"original_position":17,"commit_id":"05657416f715bb8fb33de95ff6fdc2a2c35089e5","original_commit_id":"05657416f715bb8fb33de95ff6fdc2a2c35089e5","user":{"login":"iAmWillShepherd","id":1715082,"node_id":"MDQ6VXNlcjE3MTUwODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1715082?v=4","gravatar_id":"","url":"https://api.github.com/users/iAmWillShepherd","html_url":"https://github.com/iAmWillShepherd","followers_url":"https://api.github.com/users/iAmWillShepherd/followers","following_url":"https://api.github.com/users/iAmWillShepherd/following{/other_user}","gists_url":"https://api.github.com/users/iAmWillShepherd/gists{/gist_id}","starred_url":"https://api.github.com/users/iAmWillShepherd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iAmWillShepherd/subscriptions","organizations_url":"https://api.github.com/users/iAmWillShepherd/orgs","repos_url":"https://api.github.com/users/iAmWillShepherd/repos","events_url":"https://api.github.com/users/iAmWillShepherd/events{/privacy}","received_events_url":"https://api.github.com/users/iAmWillShepherd/received_events","type":"User","site_admin":true},"body":"This name is a bit generic, but I'm open to suggestions for a better name","created_at":"2018-06-04T20:15:32Z","updated_at":"2018-06-04T20:15:33Z","html_url":"https://github.com/desktop/desktop/pull/4794#discussion_r192866584","pull_request_url":"https://api.github.com/repos/desktop/desktop/pulls/4794","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/desktop/desktop/pulls/comments/192866584"},"html":{"href":"https://github.com/desktop/desktop/pull/4794#discussion_r192866584"},"pull_request":{"href":"https://api.github.com/repos/desktop/desktop/pulls/4794"}}},"pull_request":{"url":"https://api.github.com/repos/desktop/desktop/pulls/4794","id":190797766,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzk3NzY2","html_url":"https://github.com/desktop/desktop/pull/4794","diff_url":"https://github.com/desktop/desktop/pull/4794.diff","patch_url":"https://github.com/desktop/desktop/pull/4794.patch","issue_url":"https://api.github.com/repos/desktop/desktop/issues/4794","number":4794,"state":"open","locked":false,"title":"Adds new component for displaying banner notifications (NDDB)","user":{"login":"iAmWillShepherd","id":1715082,"node_id":"MDQ6VXNlcjE3MTUwODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1715082?v=4","gravatar_id":"","url":"https://api.github.com/users/iAmWillShepherd","html_url":"https://github.com/iAmWillShepherd","followers_url":"https://api.github.com/users/iAmWillShepherd/followers","following_url":"https://api.github.com/users/iAmWillShepherd/following{/other_user}","gists_url":"https://api.github.com/users/iAmWillShepherd/gists{/gist_id}","starred_url":"https://api.github.com/users/iAmWillShepherd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iAmWillShepherd/subscriptions","organizations_url":"https://api.github.com/users/iAmWillShepherd/orgs","repos_url":"https://api.github.com/users/iAmWillShepherd/repos","events_url":"https://api.github.com/users/iAmWillShepherd/events{/privacy}","received_events_url":"https://api.github.com/users/iAmWillShepherd/received_events","type":"User","site_admin":true},"body":"Fixes #4768 \r\n\r\n@donokuda and I paired on this while prepping a prototype for user interviews. Note that the CTA buttons will be wired up in separate PRs as that work may require other components to be refactored.\r\n\r\n~At the moment, I'm unsure if we should pass a `ref` or the `remote.name` **and** `branch.name`. Since this component is not actually being used at the moment, I just used `ref` and passed the string `origin/master` to produce the screenshot below.~\r\n☝️ Just passed the branch instead.\r\n\r\nAccording to the design, the _Compare_ button should be the primary button, but the order of the buttons differ from the design due to how the `ButtonGroup` component works. @desktop/design does that mean the mockup is incorrect?\r\n\r\n**Before**\r\n![before](https://user-images.githubusercontent.com/1715082/40588825-20218e04-61a9-11e8-84fa-170465268033.png)\r\n\r\n**After**\r\n![screen shot 2018-05-27 at 12 48 44 pm](https://user-images.githubusercontent.com/1715082/40589032-6a526662-61ac-11e8-86bd-3f73bb1d34bd.png)\r\n\r\nTodo:\r\n- [x] Add a blurb of the form \"Your branch is `x` commits behind `ref`\"\r\n- [x] Add _Compare_ button (primary)\r\n- [x] Add Merge button\r\n- [x] Add an _x_ octicon for dismissing\r\n- [ ] ~Refine styles~","created_at":"2018-05-27T17:17:51Z","updated_at":"2018-06-04T20:15:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d7494fe86b22ba93ada14a5e3ed8ee40ee0eaae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/desktop/desktop/pulls/4794/commits","review_comments_url":"https://api.github.com/repos/desktop/desktop/pulls/4794/comments","review_comment_url":"https://api.github.com/repos/desktop/desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/desktop/desktop/issues/4794/comments","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/05657416f715bb8fb33de95ff6fdc2a2c35089e5","head":{"label":"desktop:b-b-b-banner","ref":"b-b-b-banner","sha":"05657416f715bb8fb33de95ff6fdc2a2c35089e5","user":{"login":"desktop","id":13171334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTcxMzM0","avatar_url":"https://avatars0.githubusercontent.com/u/13171334?v=4","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"repo":{"id":58559694,"node_id":"MDEwOlJlcG9zaXRvcnk1ODU1OTY5NA==","name":"desktop","full_name":"desktop/desktop","owner":{"login":"desktop","id":13171334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTcxMzM0","avatar_url":"https://avatars0.githubusercontent.com/u/13171334?v=4","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/desktop/desktop","description":"Simple collaboration from your desktop","fork":false,"url":"https://api.github.com/repos/desktop/desktop","forks_url":"https://api.github.com/repos/desktop/desktop/forks","keys_url":"https://api.github.com/repos/desktop/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desktop/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desktop/desktop/teams","hooks_url":"https://api.github.com/repos/desktop/desktop/hooks","issue_events_url":"https://api.github.com/repos/desktop/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/desktop/desktop/events","assignees_url":"https://api.github.com/repos/desktop/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/desktop/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/desktop/desktop/tags","blobs_url":"https://api.github.com/repos/desktop/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desktop/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desktop/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/desktop/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/desktop/desktop/languages","stargazers_url":"https://api.github.com/repos/desktop/desktop/stargazers","contributors_url":"https://api.github.com/repos/desktop/desktop/contributors","subscribers_url":"https://api.github.com/repos/desktop/desktop/subscribers","subscription_url":"https://api.github.com/repos/desktop/desktop/subscription","commits_url":"https://api.github.com/repos/desktop/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/desktop/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/desktop/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/desktop/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/desktop/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/desktop/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desktop/desktop/merges","archive_url":"https://api.github.com/repos/desktop/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desktop/desktop/downloads","issues_url":"https://api.github.com/repos/desktop/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/desktop/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/desktop/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/desktop/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desktop/desktop/labels{/name}","releases_url":"https://api.github.com/repos/desktop/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/desktop/desktop/deployments","created_at":"2016-05-11T15:59:00Z","updated_at":"2018-06-04T18:36:34Z","pushed_at":"2018-06-04T20:13:10Z","git_url":"git://github.com/desktop/desktop.git","ssh_url":"git@github.com:desktop/desktop.git","clone_url":"https://github.com/desktop/desktop.git","svn_url":"https://github.com/desktop/desktop","homepage":"https://desktop.github.com","size":23613,"stargazers_count":5230,"watchers_count":5230,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2011,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2011,"open_issues":370,"watchers":5230,"default_branch":"master"}},"base":{"label":"desktop:master","ref":"master","sha":"56ebf9016c36e6f22cc0111bdf2c562bfa01ab80","user":{"login":"desktop","id":13171334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTcxMzM0","avatar_url":"https://avatars0.githubusercontent.com/u/13171334?v=4","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"repo":{"id":58559694,"node_id":"MDEwOlJlcG9zaXRvcnk1ODU1OTY5NA==","name":"desktop","full_name":"desktop/desktop","owner":{"login":"desktop","id":13171334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTcxMzM0","avatar_url":"https://avatars0.githubusercontent.com/u/13171334?v=4","gravatar_id":"","url":"https://api.github.com/users/desktop","html_url":"https://github.com/desktop","followers_url":"https://api.github.com/users/desktop/followers","following_url":"https://api.github.com/users/desktop/following{/other_user}","gists_url":"https://api.github.com/users/desktop/gists{/gist_id}","starred_url":"https://api.github.com/users/desktop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/desktop/subscriptions","organizations_url":"https://api.github.com/users/desktop/orgs","repos_url":"https://api.github.com/users/desktop/repos","events_url":"https://api.github.com/users/desktop/events{/privacy}","received_events_url":"https://api.github.com/users/desktop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/desktop/desktop","description":"Simple collaboration from your desktop","fork":false,"url":"https://api.github.com/repos/desktop/desktop","forks_url":"https://api.github.com/repos/desktop/desktop/forks","keys_url":"https://api.github.com/repos/desktop/desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/desktop/desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/desktop/desktop/teams","hooks_url":"https://api.github.com/repos/desktop/desktop/hooks","issue_events_url":"https://api.github.com/repos/desktop/desktop/issues/events{/number}","events_url":"https://api.github.com/repos/desktop/desktop/events","assignees_url":"https://api.github.com/repos/desktop/desktop/assignees{/user}","branches_url":"https://api.github.com/repos/desktop/desktop/branches{/branch}","tags_url":"https://api.github.com/repos/desktop/desktop/tags","blobs_url":"https://api.github.com/repos/desktop/desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/desktop/desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/desktop/desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/desktop/desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/desktop/desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/desktop/desktop/languages","stargazers_url":"https://api.github.com/repos/desktop/desktop/stargazers","contributors_url":"https://api.github.com/repos/desktop/desktop/contributors","subscribers_url":"https://api.github.com/repos/desktop/desktop/subscribers","subscription_url":"https://api.github.com/repos/desktop/desktop/subscription","commits_url":"https://api.github.com/repos/desktop/desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/desktop/desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/desktop/desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/desktop/desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/desktop/desktop/contents/{+path}","compare_url":"https://api.github.com/repos/desktop/desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/desktop/desktop/merges","archive_url":"https://api.github.com/repos/desktop/desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/desktop/desktop/downloads","issues_url":"https://api.github.com/repos/desktop/desktop/issues{/number}","pulls_url":"https://api.github.com/repos/desktop/desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/desktop/desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/desktop/desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/desktop/desktop/labels{/name}","releases_url":"https://api.github.com/repos/desktop/desktop/releases{/id}","deployments_url":"https://api.github.com/repos/desktop/desktop/deployments","created_at":"2016-05-11T15:59:00Z","updated_at":"2018-06-04T18:36:34Z","pushed_at":"2018-06-04T20:13:10Z","git_url":"git://github.com/desktop/desktop.git","ssh_url":"git@github.com:desktop/desktop.git","clone_url":"https://github.com/desktop/desktop.git","svn_url":"https://github.com/desktop/desktop","homepage":"https://desktop.github.com","size":23613,"stargazers_count":5230,"watchers_count":5230,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2011,"mirror_url":null,"archived":false,"open_issues_count":370,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2011,"open_issues":370,"watchers":5230,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/desktop/desktop/pulls/4794"},"html":{"href":"https://github.com/desktop/desktop/pull/4794"},"issue":{"href":"https://api.github.com/repos/desktop/desktop/issues/4794"},"comments":{"href":"https://api.github.com/repos/desktop/desktop/issues/4794/comments"},"review_comments":{"href":"https://api.github.com/repos/desktop/desktop/pulls/4794/comments"},"review_comment":{"href":"https://api.github.com/repos/desktop/desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/desktop/desktop/pulls/4794/commits"},"statuses":{"href":"https://api.github.com/repos/desktop/desktop/statuses/05657416f715bb8fb33de95ff6fdc2a2c35089e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"iAmWillShepherd"}}