{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/comments/216673627","pull_request_review_id":154206299,"id":216673627,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjY3MzYyNw==","diff_hunk":"@@ -99,6 +99,15 @@ Address\n -------\n \n ``address``: Holds a 20 byte value (size of an Ethereum address). Address types also have members and serve as a base for all contracts.\n+``address payable``: Same as ``address``, but with the additional member ``transfer``.\n+\n+Implicit conversions from ``address payable`` to ``address`` are allowed, whereas conversions from ``address`` to ``address payable`` are\n+not possible (the only way to perform such a conversion is by using an intermediate conversion to ``uint160``).","path":"docs/types.rst","position":7,"original_position":7,"commit_id":"6cefeec4d21908803ee964aa906ce11978290efc","original_commit_id":"6cefeec4d21908803ee964aa906ce11978290efc","user":{"login":"chriseth","id":9073706,"node_id":"MDQ6VXNlcjkwNzM3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"This would look like `address x = ...; address payable y = address(uint160(x))`, right? This doesn't make the \"payable\" too visible, especially if it is used like `f(address(uint160(x)))`...","created_at":"2018-09-11T13:42:02Z","updated_at":"2018-09-11T13:47:33Z","html_url":"https://github.com/ethereum/solidity/pull/4911#discussion_r216673627","pull_request_url":"https://api.github.com/repos/ethereum/solidity/pulls/4911","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments/216673627"},"html":{"href":"https://github.com/ethereum/solidity/pull/4911#discussion_r216673627"},"pull_request":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4911"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/solidity/pulls/4911","id":213351356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMzUxMzU2","html_url":"https://github.com/ethereum/solidity/pull/4911","diff_url":"https://github.com/ethereum/solidity/pull/4911.diff","patch_url":"https://github.com/ethereum/solidity/pull/4911.patch","issue_url":"https://api.github.com/repos/ethereum/solidity/issues/4911","number":4911,"state":"open","locked":false,"title":"[WIP] Payable and non-payable address type.","user":{"login":"ekpyron","id":1347491,"node_id":"MDQ6VXNlcjEzNDc0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1347491?v=4","gravatar_id":"","url":"https://api.github.com/users/ekpyron","html_url":"https://github.com/ekpyron","followers_url":"https://api.github.com/users/ekpyron/followers","following_url":"https://api.github.com/users/ekpyron/following{/other_user}","gists_url":"https://api.github.com/users/ekpyron/gists{/gist_id}","starred_url":"https://api.github.com/users/ekpyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekpyron/subscriptions","organizations_url":"https://api.github.com/users/ekpyron/orgs","repos_url":"https://api.github.com/users/ekpyron/repos","events_url":"https://api.github.com/users/ekpyron/events{/privacy}","received_events_url":"https://api.github.com/users/ekpyron/received_events","type":"User","site_admin":false},"body":"~Depends on #4887.~ (merged; rebased)\r\nImplements #4552.\r\n~Depends on #4926.~ (merged; rebased)\r\nDepends on ethereum/solc-js#250.\r\nDepends on axic/openzeppelin-solidity#15\r\n\r\n- [ ]  Probably still needs documentation updates. Update: Now there are some documentation updates => recheck.\r\n- [x] ~``grammar.txt`` needs to be changed.~ (Moved to #4926)\r\n- [x] Should probably add fields to the JSON AST.\r\n- [x] Needs more test cases (tuple declarations, return parameters, etc.).\r\n- [ ] External tests need to be fixed. (Already there on separate branches).\r\n- [x] Compilation tests need to be fixed.\r\n- [x] ~``abi.decode(data, (address payable))`` probably doesn't work yet. Should it or should it always return payable addresses with ``(address)``?~ Always returns ``address payable`` now.\r\n- [x] Check behavior of mappings + address.\r\n- [x] Have a look at arrays of address.\r\n- [ ] Have a look at inheritance and overloading with ``address`` and ``address payable`` (overloading has test cases; to be discussed)\r\n- [x] More tests for ``address payable constant`` and ``address constant``\r\n- [x] Semantics tests for conversions and cleanup.\r\n- [ ] Think about the return type for ``ecrecover``.\r\n- [ ] ~Should ``<address>.send`` only be present in ``address payable`` as well?~ Decision: move ``send`` to ``address payable`` as well.","created_at":"2018-09-05T16:13:42Z","updated_at":"2018-09-11T13:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a4e0a45c3b5ed5af2f5fed0aa6fb52ac9d37146","assignee":{"login":"ekpyron","id":1347491,"node_id":"MDQ6VXNlcjEzNDc0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1347491?v=4","gravatar_id":"","url":"https://api.github.com/users/ekpyron","html_url":"https://github.com/ekpyron","followers_url":"https://api.github.com/users/ekpyron/followers","following_url":"https://api.github.com/users/ekpyron/following{/other_user}","gists_url":"https://api.github.com/users/ekpyron/gists{/gist_id}","starred_url":"https://api.github.com/users/ekpyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekpyron/subscriptions","organizations_url":"https://api.github.com/users/ekpyron/orgs","repos_url":"https://api.github.com/users/ekpyron/repos","events_url":"https://api.github.com/users/ekpyron/events{/privacy}","received_events_url":"https://api.github.com/users/ekpyron/received_events","type":"User","site_admin":false},"assignees":[{"login":"ekpyron","id":1347491,"node_id":"MDQ6VXNlcjEzNDc0OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1347491?v=4","gravatar_id":"","url":"https://api.github.com/users/ekpyron","html_url":"https://github.com/ekpyron","followers_url":"https://api.github.com/users/ekpyron/followers","following_url":"https://api.github.com/users/ekpyron/following{/other_user}","gists_url":"https://api.github.com/users/ekpyron/gists{/gist_id}","starred_url":"https://api.github.com/users/ekpyron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekpyron/subscriptions","organizations_url":"https://api.github.com/users/ekpyron/orgs","repos_url":"https://api.github.com/users/ekpyron/repos","events_url":"https://api.github.com/users/ekpyron/events{/privacy}","received_events_url":"https://api.github.com/users/ekpyron/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/solidity/pulls/4911/commits","review_comments_url":"https://api.github.com/repos/ethereum/solidity/pulls/4911/comments","review_comment_url":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/4911/comments","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/6cefeec4d21908803ee964aa906ce11978290efc","head":{"label":"ethereum:addressPayable","ref":"addressPayable","sha":"6cefeec4d21908803ee964aa906ce11978290efc","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-09-11T13:30:06Z","pushed_at":"2018-09-11T13:37:34Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":23005,"stargazers_count":5899,"watchers_count":5899,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1571,"mirror_url":null,"archived":false,"open_issues_count":585,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1571,"open_issues":585,"watchers":5899,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"1994b51ef3eb8de3617efec9747979c9fb5ed453","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":40892817,"node_id":"MDEwOlJlcG9zaXRvcnk0MDg5MjgxNw==","name":"solidity","full_name":"ethereum/solidity","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/solidity","description":"Solidity, the Contract-Oriented Programming Language","fork":false,"url":"https://api.github.com/repos/ethereum/solidity","forks_url":"https://api.github.com/repos/ethereum/solidity/forks","keys_url":"https://api.github.com/repos/ethereum/solidity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/solidity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/solidity/teams","hooks_url":"https://api.github.com/repos/ethereum/solidity/hooks","issue_events_url":"https://api.github.com/repos/ethereum/solidity/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/solidity/events","assignees_url":"https://api.github.com/repos/ethereum/solidity/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/solidity/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/solidity/tags","blobs_url":"https://api.github.com/repos/ethereum/solidity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/solidity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/solidity/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/solidity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/solidity/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/solidity/languages","stargazers_url":"https://api.github.com/repos/ethereum/solidity/stargazers","contributors_url":"https://api.github.com/repos/ethereum/solidity/contributors","subscribers_url":"https://api.github.com/repos/ethereum/solidity/subscribers","subscription_url":"https://api.github.com/repos/ethereum/solidity/subscription","commits_url":"https://api.github.com/repos/ethereum/solidity/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/solidity/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/solidity/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/solidity/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/solidity/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/solidity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/solidity/merges","archive_url":"https://api.github.com/repos/ethereum/solidity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/solidity/downloads","issues_url":"https://api.github.com/repos/ethereum/solidity/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/solidity/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/solidity/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/solidity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/solidity/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/solidity/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/solidity/deployments","created_at":"2015-08-17T12:27:26Z","updated_at":"2018-09-11T13:30:06Z","pushed_at":"2018-09-11T13:37:34Z","git_url":"git://github.com/ethereum/solidity.git","ssh_url":"git@github.com:ethereum/solidity.git","clone_url":"https://github.com/ethereum/solidity.git","svn_url":"https://github.com/ethereum/solidity","homepage":"https://solidity.readthedocs.io","size":23005,"stargazers_count":5899,"watchers_count":5899,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1571,"mirror_url":null,"archived":false,"open_issues_count":585,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1571,"open_issues":585,"watchers":5899,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4911"},"html":{"href":"https://github.com/ethereum/solidity/pull/4911"},"issue":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4911"},"comments":{"href":"https://api.github.com/repos/ethereum/solidity/issues/4911/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4911/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/solidity/pulls/4911/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/solidity/statuses/6cefeec4d21908803ee964aa906ce11978290efc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chriseth"}}