{"action":"closed","issue":{"url":"https://api.github.com/repos/ethereum/solidity/issues/3606","repository_url":"https://api.github.com/repos/ethereum/solidity","labels_url":"https://api.github.com/repos/ethereum/solidity/issues/3606/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/solidity/issues/3606/comments","events_url":"https://api.github.com/repos/ethereum/solidity/issues/3606/events","html_url":"https://github.com/ethereum/solidity/issues/3606","id":300472573,"node_id":"MDU6SXNzdWUzMDA0NzI1NzM=","number":3606,"title":"Deprecate `years` suffix","user":{"login":"Gustav-Simonsson","id":293096,"node_id":"MDQ6VXNlcjI5MzA5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/293096?v=4","gravatar_id":"","url":"https://api.github.com/users/Gustav-Simonsson","html_url":"https://github.com/Gustav-Simonsson","followers_url":"https://api.github.com/users/Gustav-Simonsson/followers","following_url":"https://api.github.com/users/Gustav-Simonsson/following{/other_user}","gists_url":"https://api.github.com/users/Gustav-Simonsson/gists{/gist_id}","starred_url":"https://api.github.com/users/Gustav-Simonsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gustav-Simonsson/subscriptions","organizations_url":"https://api.github.com/users/Gustav-Simonsson/orgs","repos_url":"https://api.github.com/users/Gustav-Simonsson/repos","events_url":"https://api.github.com/users/Gustav-Simonsson/events{/privacy}","received_events_url":"https://api.github.com/users/Gustav-Simonsson/received_events","type":"User","site_admin":false},"labels":[{"id":467898404,"node_id":"MDU6TGFiZWw0Njc4OTg0MDQ=","url":"https://api.github.com/repos/ethereum/solidity/labels/Breaking%20Change","name":"Breaking Change","color":"b60205","default":false},{"id":552509610,"node_id":"MDU6TGFiZWw1NTI1MDk2MTA=","url":"https://api.github.com/repos/ethereum/solidity/labels/breaking%20for%200.5.0","name":"breaking for 0.5.0","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},"assignees":[{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-02-27T02:37:35Z","updated_at":"2018-06-20T21:55:11Z","closed_at":"2018-06-20T21:55:11Z","author_association":"MEMBER","body":"The `years` literal number suffix is defined as 31536000 seconds at https://github.com/ethereum/solidity/blob/develop/libsolidity/ast/Types.cpp#L747\r\n\r\nThis is incorrect - the correct value is 31557600 seconds.\r\n\r\nA true Earth year is closer to [365.256363004 days](https://en.wikipedia.org/wiki/Earth) which is standardized as 365.25 days of 86400 SI seconds each in the [Julian Year](https://en.wikipedia.org/wiki/Year), as used in astronomy and other sciences.\r\n\r\nHowever, as civilians and the Gregorian calendar uses [common](https://en.wikipedia.org/wiki/Common_year) and [leap years](https://en.wikipedia.org/wiki/Leap_year), it may be worthwhile to consider deprecating `years` to avoid potential confusion altogether."}}
{"actor":{"display_login":"axic"}}