{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/3294","repository_url":"https://api.github.com/repos/apache/incubator-airflow","labels_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3294/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3294/comments","events_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3294/events","html_url":"https://github.com/apache/incubator-airflow/pull/3294","id":319553824,"number":3294,"title":"[AIRFLOW-2407] import logging for line 68 of kerberos_auth.py","user":{"login":"cclauss","id":3709715,"avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-02T13:32:31Z","updated_at":"2018-05-02T21:53:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/incubator-airflow/pulls/3294","html_url":"https://github.com/apache/incubator-airflow/pull/3294","diff_url":"https://github.com/apache/incubator-airflow/pull/3294.diff","patch_url":"https://github.com/apache/incubator-airflow/pull/3294.patch"},"body":"flake8 testing of https://github.com/apache/incubator-airflow on Python 3.6.3\r\n\r\n$ __flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics__\r\n```\r\n./airflow/contrib/auth/backends/kerberos_auth.py:67:13: F821 undefined name 'logging'\r\n            logging.error('Password validation for principal %s failed %s', user_principal, e)\r\n            ^\r\n```\r\n\r\nMake sure you have checked _all_ steps below.\r\n\r\n### JIRA\r\n- [x] My PR addresses the following [Airflow JIRA](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n    - https://issues.apache.org/jira/browse/AIRFLOW-2407\r\n    - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a JIRA issue.\r\n\r\n\r\n### Description\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\nSee above.\r\n\r\n### Tests\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\nThis PR fixes flake8 tests which are currently failing.\r\n\r\n### Commits\r\n- [X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n    1. Subject is separated from body by a blank line\r\n    2. Subject is limited to 50 characters\r\n    3. Subject does not end with a period\r\n    4. Subject uses the imperative mood (\"add\", not \"adding\")\r\n    5. Body wraps at 72 characters\r\n    6. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n\r\n### Documentation\r\n- [X] In case of new functionality, my PR adds documentation that describes how to use it.\r\n    - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n\r\n\r\n### Code Quality\r\n- [X] Passes git diff upstream/master -u -- \"*.py\" | __python3 -m__ flake8 --diff\r\n"},"comment":{"url":"https://api.github.com/repos/apache/incubator-airflow/issues/comments/386133395","html_url":"https://github.com/apache/incubator-airflow/pull/3294#issuecomment-386133395","issue_url":"https://api.github.com/repos/apache/incubator-airflow/issues/3294","id":386133395,"user":{"login":"kaxil","id":8811558,"avatar_url":"https://avatars2.githubusercontent.com/u/8811558?v=4","gravatar_id":"","url":"https://api.github.com/users/kaxil","html_url":"https://github.com/kaxil","followers_url":"https://api.github.com/users/kaxil/followers","following_url":"https://api.github.com/users/kaxil/following{/other_user}","gists_url":"https://api.github.com/users/kaxil/gists{/gist_id}","starred_url":"https://api.github.com/users/kaxil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaxil/subscriptions","organizations_url":"https://api.github.com/users/kaxil/orgs","repos_url":"https://api.github.com/users/kaxil/repos","events_url":"https://api.github.com/users/kaxil/events{/privacy}","received_events_url":"https://api.github.com/users/kaxil/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T21:53:28Z","updated_at":"2018-05-02T21:53:28Z","author_association":"CONTRIBUTOR","body":"I suggest closing all separate PRs https://github.com/apache/incubator-airflow/pull/3293 https://github.com/apache/incubator-airflow/pull/3294 https://github.com/apache/incubator-airflow/pull/3296 https://github.com/apache/incubator-airflow/pull/3297 https://github.com/apache/incubator-airflow/pull/3298 https://github.com/apache/incubator-airflow/pull/3299 and submit a single PR that resolves this issue [AIRFLOW-2407](https://issues.apache.org/jira/browse/AIRFLOW-2407)\r\n?"}}
{"actor":{"display_login":"kaxil"}}