{"action":"created","comment":{"url":"https://api.github.com/repos/RH-FMK/skt/pulls/comments/212380864","pull_request_review_id":149000396,"id":212380864,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM4MDg2NA==","diff_hunk":"@@ -180,7 +190,12 @@ def cmd_merge(cfg):\n         cfg:    A dictionary of skt configuration.\n     \"\"\"\n     global retcode\n-    idx = 0\n+    # Counter merge patch following:\n+    # id[0]:  counter of merge-ref option.\n+    # idx[1]: counter of patch option.\n+    # idx[2]: counter of pw option.\n+    idx = [0, 0, 0]\n+    previous_merge = ['', '']","path":"skt/executable.py","position":27,"original_position":27,"commit_id":"4cf9ee683e43c1a77455089fd71f7798a177b2df","original_commit_id":"4cf9ee683e43c1a77455089fd71f7798a177b2df","user":{"login":"veruu","id":8031381,"node_id":"MDQ6VXNlcjgwMzEzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/8031381?v=4","gravatar_id":"","url":"https://api.github.com/users/veruu","html_url":"https://github.com/veruu","followers_url":"https://api.github.com/users/veruu/followers","following_url":"https://api.github.com/users/veruu/following{/other_user}","gists_url":"https://api.github.com/users/veruu/gists{/gist_id}","starred_url":"https://api.github.com/users/veruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veruu/subscriptions","organizations_url":"https://api.github.com/users/veruu/orgs","repos_url":"https://api.github.com/users/veruu/repos","events_url":"https://api.github.com/users/veruu/events{/privacy}","received_events_url":"https://api.github.com/users/veruu/received_events","type":"User","site_admin":false},"body":"Why use a list of two strings here when only the first one (the name of the option) is used in the comparisons and the second one is never touched? Wouldn't it be easier to use a single string, to which the name of the applied option is assigned instead?","created_at":"2018-08-23T16:48:52Z","updated_at":"2018-08-23T16:58:27Z","html_url":"https://github.com/RH-FMK/skt/pull/308#discussion_r212380864","pull_request_url":"https://api.github.com/repos/RH-FMK/skt/pulls/308","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/comments/212380864"},"html":{"href":"https://github.com/RH-FMK/skt/pull/308#discussion_r212380864"},"pull_request":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/RH-FMK/skt/pulls/308","id":206011956,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDExOTU2","html_url":"https://github.com/RH-FMK/skt/pull/308","diff_url":"https://github.com/RH-FMK/skt/pull/308.diff","patch_url":"https://github.com/RH-FMK/skt/pull/308.patch","issue_url":"https://api.github.com/repos/RH-FMK/skt/issues/308","number":308,"state":"open","locked":false,"title":"Support ordered mixture of merge arguments","user":{"login":"danghai","id":10912671,"node_id":"MDQ6VXNlcjEwOTEyNjcx","avatar_url":"https://avatars1.githubusercontent.com/u/10912671?v=4","gravatar_id":"","url":"https://api.github.com/users/danghai","html_url":"https://github.com/danghai","followers_url":"https://api.github.com/users/danghai/followers","following_url":"https://api.github.com/users/danghai/following{/other_user}","gists_url":"https://api.github.com/users/danghai/gists{/gist_id}","starred_url":"https://api.github.com/users/danghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danghai/subscriptions","organizations_url":"https://api.github.com/users/danghai/orgs","repos_url":"https://api.github.com/users/danghai/repos","events_url":"https://api.github.com/users/danghai/events{/privacy}","received_events_url":"https://api.github.com/users/danghai/received_events","type":"User","site_admin":false},"body":"I make PR to support ordered mixture of merge arguments. It is my idea and first draft. \r\nBecause the optional argument for merge is not positional, so I introduce the `CustomAction` to get the order of merge option ( `--merge-ref`, `--patch` and `--pw`) . \r\nFor example:  \r\nif we use `--pw <PATCH1> --patch <PATCH2> --merge-ref <PATCH3> --pw <PATCH4>`\r\nThe `order_merge` stores the merge arguments by order. \r\n```\r\n[('pw', 'PATCH1'), ('patch', 'PATCH2'), ('merge-ref', 'PATCH3'), ('pw', 'PATCH4')]\r\n\r\n```\r\nI declare the `task` in `cmd_merge` following:\r\n```\r\ntask[0]: merge argument\r\ntask[1]: merge patch\r\nThe tasks will store: \r\n('pw', 'PATCH1')\r\n('patch', 'PATCH2')\r\n('merge-ref', 'PATCH3')\r\n('pw', 'PATCH4')\r\n```\r\nIt still needs to be enhanced by changing the `report_string` in order to get all information all patch. It also needs to fix the value `idx`. What do you think about this idea? Thanks","created_at":"2018-08-03T12:12:03Z","updated_at":"2018-08-23T16:58:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ce408f251dbc4d81f9aadeb4e8c35f20570baf6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RH-FMK/skt/pulls/308/commits","review_comments_url":"https://api.github.com/repos/RH-FMK/skt/pulls/308/comments","review_comment_url":"https://api.github.com/repos/RH-FMK/skt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RH-FMK/skt/issues/308/comments","statuses_url":"https://api.github.com/repos/RH-FMK/skt/statuses/4cf9ee683e43c1a77455089fd71f7798a177b2df","head":{"label":"danghai:skt_merge","ref":"skt_merge","sha":"4cf9ee683e43c1a77455089fd71f7798a177b2df","user":{"login":"danghai","id":10912671,"node_id":"MDQ6VXNlcjEwOTEyNjcx","avatar_url":"https://avatars1.githubusercontent.com/u/10912671?v=4","gravatar_id":"","url":"https://api.github.com/users/danghai","html_url":"https://github.com/danghai","followers_url":"https://api.github.com/users/danghai/followers","following_url":"https://api.github.com/users/danghai/following{/other_user}","gists_url":"https://api.github.com/users/danghai/gists{/gist_id}","starred_url":"https://api.github.com/users/danghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danghai/subscriptions","organizations_url":"https://api.github.com/users/danghai/orgs","repos_url":"https://api.github.com/users/danghai/repos","events_url":"https://api.github.com/users/danghai/events{/privacy}","received_events_url":"https://api.github.com/users/danghai/received_events","type":"User","site_admin":false},"repo":{"id":126534577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY1MzQ1Nzc=","name":"skt","full_name":"danghai/skt","owner":{"login":"danghai","id":10912671,"node_id":"MDQ6VXNlcjEwOTEyNjcx","avatar_url":"https://avatars1.githubusercontent.com/u/10912671?v=4","gravatar_id":"","url":"https://api.github.com/users/danghai","html_url":"https://github.com/danghai","followers_url":"https://api.github.com/users/danghai/followers","following_url":"https://api.github.com/users/danghai/following{/other_user}","gists_url":"https://api.github.com/users/danghai/gists{/gist_id}","starred_url":"https://api.github.com/users/danghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danghai/subscriptions","organizations_url":"https://api.github.com/users/danghai/orgs","repos_url":"https://api.github.com/users/danghai/repos","events_url":"https://api.github.com/users/danghai/events{/privacy}","received_events_url":"https://api.github.com/users/danghai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danghai/skt","description":"\"Sonic Kernel Testing\" - a Linux Kernel testing tool","fork":true,"url":"https://api.github.com/repos/danghai/skt","forks_url":"https://api.github.com/repos/danghai/skt/forks","keys_url":"https://api.github.com/repos/danghai/skt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danghai/skt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danghai/skt/teams","hooks_url":"https://api.github.com/repos/danghai/skt/hooks","issue_events_url":"https://api.github.com/repos/danghai/skt/issues/events{/number}","events_url":"https://api.github.com/repos/danghai/skt/events","assignees_url":"https://api.github.com/repos/danghai/skt/assignees{/user}","branches_url":"https://api.github.com/repos/danghai/skt/branches{/branch}","tags_url":"https://api.github.com/repos/danghai/skt/tags","blobs_url":"https://api.github.com/repos/danghai/skt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danghai/skt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danghai/skt/git/refs{/sha}","trees_url":"https://api.github.com/repos/danghai/skt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danghai/skt/statuses/{sha}","languages_url":"https://api.github.com/repos/danghai/skt/languages","stargazers_url":"https://api.github.com/repos/danghai/skt/stargazers","contributors_url":"https://api.github.com/repos/danghai/skt/contributors","subscribers_url":"https://api.github.com/repos/danghai/skt/subscribers","subscription_url":"https://api.github.com/repos/danghai/skt/subscription","commits_url":"https://api.github.com/repos/danghai/skt/commits{/sha}","git_commits_url":"https://api.github.com/repos/danghai/skt/git/commits{/sha}","comments_url":"https://api.github.com/repos/danghai/skt/comments{/number}","issue_comment_url":"https://api.github.com/repos/danghai/skt/issues/comments{/number}","contents_url":"https://api.github.com/repos/danghai/skt/contents/{+path}","compare_url":"https://api.github.com/repos/danghai/skt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danghai/skt/merges","archive_url":"https://api.github.com/repos/danghai/skt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danghai/skt/downloads","issues_url":"https://api.github.com/repos/danghai/skt/issues{/number}","pulls_url":"https://api.github.com/repos/danghai/skt/pulls{/number}","milestones_url":"https://api.github.com/repos/danghai/skt/milestones{/number}","notifications_url":"https://api.github.com/repos/danghai/skt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danghai/skt/labels{/name}","releases_url":"https://api.github.com/repos/danghai/skt/releases{/id}","deployments_url":"https://api.github.com/repos/danghai/skt/deployments","created_at":"2018-03-23T20:14:57Z","updated_at":"2018-08-20T14:35:17Z","pushed_at":"2018-08-20T14:53:23Z","git_url":"git://github.com/danghai/skt.git","ssh_url":"git@github.com:danghai/skt.git","clone_url":"https://github.com/danghai/skt.git","svn_url":"https://github.com/danghai/skt","homepage":null,"size":630,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RH-FMK:master","ref":"master","sha":"9bf36d15531fa53dfed162fd92e564407a5b1149","user":{"login":"RH-FMK","id":36988735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTg4NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/36988735?v=4","gravatar_id":"","url":"https://api.github.com/users/RH-FMK","html_url":"https://github.com/RH-FMK","followers_url":"https://api.github.com/users/RH-FMK/followers","following_url":"https://api.github.com/users/RH-FMK/following{/other_user}","gists_url":"https://api.github.com/users/RH-FMK/gists{/gist_id}","starred_url":"https://api.github.com/users/RH-FMK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RH-FMK/subscriptions","organizations_url":"https://api.github.com/users/RH-FMK/orgs","repos_url":"https://api.github.com/users/RH-FMK/repos","events_url":"https://api.github.com/users/RH-FMK/events{/privacy}","received_events_url":"https://api.github.com/users/RH-FMK/received_events","type":"Organization","site_admin":false},"repo":{"id":123569786,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1Njk3ODY=","name":"skt","full_name":"RH-FMK/skt","owner":{"login":"RH-FMK","id":36988735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTg4NzM1","avatar_url":"https://avatars0.githubusercontent.com/u/36988735?v=4","gravatar_id":"","url":"https://api.github.com/users/RH-FMK","html_url":"https://github.com/RH-FMK","followers_url":"https://api.github.com/users/RH-FMK/followers","following_url":"https://api.github.com/users/RH-FMK/following{/other_user}","gists_url":"https://api.github.com/users/RH-FMK/gists{/gist_id}","starred_url":"https://api.github.com/users/RH-FMK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RH-FMK/subscriptions","organizations_url":"https://api.github.com/users/RH-FMK/orgs","repos_url":"https://api.github.com/users/RH-FMK/repos","events_url":"https://api.github.com/users/RH-FMK/events{/privacy}","received_events_url":"https://api.github.com/users/RH-FMK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RH-FMK/skt","description":"\"Sonic Kernel Testing\" - a Linux Kernel testing tool","fork":false,"url":"https://api.github.com/repos/RH-FMK/skt","forks_url":"https://api.github.com/repos/RH-FMK/skt/forks","keys_url":"https://api.github.com/repos/RH-FMK/skt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RH-FMK/skt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RH-FMK/skt/teams","hooks_url":"https://api.github.com/repos/RH-FMK/skt/hooks","issue_events_url":"https://api.github.com/repos/RH-FMK/skt/issues/events{/number}","events_url":"https://api.github.com/repos/RH-FMK/skt/events","assignees_url":"https://api.github.com/repos/RH-FMK/skt/assignees{/user}","branches_url":"https://api.github.com/repos/RH-FMK/skt/branches{/branch}","tags_url":"https://api.github.com/repos/RH-FMK/skt/tags","blobs_url":"https://api.github.com/repos/RH-FMK/skt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RH-FMK/skt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RH-FMK/skt/git/refs{/sha}","trees_url":"https://api.github.com/repos/RH-FMK/skt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RH-FMK/skt/statuses/{sha}","languages_url":"https://api.github.com/repos/RH-FMK/skt/languages","stargazers_url":"https://api.github.com/repos/RH-FMK/skt/stargazers","contributors_url":"https://api.github.com/repos/RH-FMK/skt/contributors","subscribers_url":"https://api.github.com/repos/RH-FMK/skt/subscribers","subscription_url":"https://api.github.com/repos/RH-FMK/skt/subscription","commits_url":"https://api.github.com/repos/RH-FMK/skt/commits{/sha}","git_commits_url":"https://api.github.com/repos/RH-FMK/skt/git/commits{/sha}","comments_url":"https://api.github.com/repos/RH-FMK/skt/comments{/number}","issue_comment_url":"https://api.github.com/repos/RH-FMK/skt/issues/comments{/number}","contents_url":"https://api.github.com/repos/RH-FMK/skt/contents/{+path}","compare_url":"https://api.github.com/repos/RH-FMK/skt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RH-FMK/skt/merges","archive_url":"https://api.github.com/repos/RH-FMK/skt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RH-FMK/skt/downloads","issues_url":"https://api.github.com/repos/RH-FMK/skt/issues{/number}","pulls_url":"https://api.github.com/repos/RH-FMK/skt/pulls{/number}","milestones_url":"https://api.github.com/repos/RH-FMK/skt/milestones{/number}","notifications_url":"https://api.github.com/repos/RH-FMK/skt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RH-FMK/skt/labels{/name}","releases_url":"https://api.github.com/repos/RH-FMK/skt/releases{/id}","deployments_url":"https://api.github.com/repos/RH-FMK/skt/deployments","created_at":"2018-03-02T11:09:58Z","updated_at":"2018-08-23T12:04:52Z","pushed_at":"2018-08-23T12:04:49Z","git_url":"git://github.com/RH-FMK/skt.git","ssh_url":"git@github.com:RH-FMK/skt.git","clone_url":"https://github.com/RH-FMK/skt.git","svn_url":"https://github.com/RH-FMK/skt","homepage":null,"size":596,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":10,"open_issues":30,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/308"},"html":{"href":"https://github.com/RH-FMK/skt/pull/308"},"issue":{"href":"https://api.github.com/repos/RH-FMK/skt/issues/308"},"comments":{"href":"https://api.github.com/repos/RH-FMK/skt/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RH-FMK/skt/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/RH-FMK/skt/statuses/4cf9ee683e43c1a77455089fd71f7798a177b2df"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"veruu"}}