{"action":"created","issue":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/221","repository_url":"https://api.github.com/repos/sakura-editor/sakura","labels_url":"https://api.github.com/repos/sakura-editor/sakura/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/221/comments","events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/221/events","html_url":"https://github.com/sakura-editor/sakura/pull/221","id":338820407,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjU2Mjk3","number":221,"title":"githash.h の末尾の空白を削除する","user":{"login":"m-tmatma","id":5567450,"node_id":"MDQ6VXNlcjU1Njc0NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/5567450?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tmatma","html_url":"https://github.com/m-tmatma","followers_url":"https://api.github.com/users/m-tmatma/followers","following_url":"https://api.github.com/users/m-tmatma/following{/other_user}","gists_url":"https://api.github.com/users/m-tmatma/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tmatma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tmatma/subscriptions","organizations_url":"https://api.github.com/users/m-tmatma/orgs","repos_url":"https://api.github.com/users/m-tmatma/repos","events_url":"https://api.github.com/users/m-tmatma/events{/privacy}","received_events_url":"https://api.github.com/users/m-tmatma/received_events","type":"User","site_admin":false},"labels":[{"id":961778227,"node_id":"MDU6TGFiZWw5NjE3NzgyMjc=","url":"https://api.github.com/repos/sakura-editor/sakura/labels/CI","name":"CI","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1","html_url":"https://github.com/sakura-editor/sakura/milestone/1","labels_url":"https://api.github.com/repos/sakura-editor/sakura/milestones/1/labels","id":3390252,"node_id":"MDk6TWlsZXN0b25lMzM5MDI1Mg==","number":1,"title":"next release","description":"バージョン番号が確定したらマイルストーン名を変えます","creator":{"login":"kobake","id":2929454,"node_id":"MDQ6VXNlcjI5Mjk0NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2929454?v=4","gravatar_id":"","url":"https://api.github.com/users/kobake","html_url":"https://github.com/kobake","followers_url":"https://api.github.com/users/kobake/followers","following_url":"https://api.github.com/users/kobake/following{/other_user}","gists_url":"https://api.github.com/users/kobake/gists{/gist_id}","starred_url":"https://api.github.com/users/kobake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobake/subscriptions","organizations_url":"https://api.github.com/users/kobake/orgs","repos_url":"https://api.github.com/users/kobake/repos","events_url":"https://api.github.com/users/kobake/events{/privacy}","received_events_url":"https://api.github.com/users/kobake/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":116,"state":"open","created_at":"2018-05-31T12:48:23Z","updated_at":"2018-07-06T06:28:39Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-07-06T06:28:39Z","updated_at":"2018-07-06T06:43:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/221","html_url":"https://github.com/sakura-editor/sakura/pull/221","diff_url":"https://github.com/sakura-editor/sakura/pull/221.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/221.patch"},"body":"githash.h の末尾の空白を削除する\r\n\r\n- sed で正規表現を使って末尾の空白を取り除く\r\n- unix2dos で改行コードを UNIX 形式から DOS 形式に変換する\r\n- 変換処理を行うバッチファイルは preBuild.bat などに合わせて lower camel Case にする。\r\n (https://ja.wikipedia.org/wiki/キャメルケース)\r\n"},"comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments/402942221","html_url":"https://github.com/sakura-editor/sakura/pull/221#issuecomment-402942221","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/221","id":402942221,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjk0MjIyMQ==","user":{"login":"kobake","id":2929454,"node_id":"MDQ6VXNlcjI5Mjk0NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2929454?v=4","gravatar_id":"","url":"https://api.github.com/users/kobake","html_url":"https://github.com/kobake","followers_url":"https://api.github.com/users/kobake/followers","following_url":"https://api.github.com/users/kobake/following{/other_user}","gists_url":"https://api.github.com/users/kobake/gists{/gist_id}","starred_url":"https://api.github.com/users/kobake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobake/subscriptions","organizations_url":"https://api.github.com/users/kobake/orgs","repos_url":"https://api.github.com/users/kobake/repos","events_url":"https://api.github.com/users/kobake/events{/privacy}","received_events_url":"https://api.github.com/users/kobake/received_events","type":"User","site_admin":false},"created_at":"2018-07-06T06:43:49Z","updated_at":"2018-07-06T06:43:49Z","author_association":"MEMBER","body":"ご対応ありがとうございます。問題なさそうです。\r\n\r\n## AppVeyor ビルド結果\r\n```\r\n#pragma once\r\n#define GIT_COMMIT_HASH \"0161cd0629c5b66af5d14750b40bb7110b374192\"\r\n#define GIT_SHORT_COMMIT_HASH \"0161cd06\"\r\n#define GIT_URL \"https://github.com/sakura-editor/sakura.git\"\r\n#define APPVEYOR_URL \"https://ci.appveyor.com\"\r\n#define APPVEYOR_REPO_NAME \"sakura-editor/sakura\"\r\n#define APPVEYOR_ACCOUNT_NAME \"sakuraeditor\"\r\n#define APPVEYOR_PROJECT_SLUG \"sakura\"\r\n#define APPVEYOR_BUILD_VERSION \"1.0.341\"\r\n#define APPVEYOR_BUILD_NUMBER     \"341\"\r\n#define APPVEYOR_BUILD_NUMBER_INT  341\r\n#define APPVEYOR_PULL_REQUEST_NUMBER     \"221\"\r\n#define APPVEYOR_PULL_REQUEST_NUMBER_INT  221\r\n#define GITHUB_COMMIT_URL             \"https://github.com/sakura-editor/sakura/commit/8368603677e1abc77228ff48b1a6644d593f288b\"\r\n#define GITHUB_COMMIT_URL_PR_HEAD     \"https://github.com/sakura-editor/sakura/pull/221/commits/80048ae62bb388e4ffb991e9db60182bd7b8f3eb\"\r\n#define APPVEYOR_SHORTHASH             \"83686036\"\r\n#define APPVEYOR_SHORTHASH_PR_HEAD     \"80048ae6\"\r\n```\r\n\r\n## ローカルビルド結果：Git環境有り\r\n```\r\n#pragma once\r\n#define GIT_COMMIT_HASH \"80048ae62bb388e4ffb991e9db60182bd7b8f3eb\"\r\n#define GIT_SHORT_COMMIT_HASH \"80048ae6\"\r\n// GIT_URL is not defined\r\n// APPVEYOR_URL is not defined\r\n// APPVEYOR_REPO_NAME is not defined\r\n// APPVEYOR_ACCOUNT_NAME is not defined\r\n// APPVEYOR_PROJECT_SLUG is not defined\r\n// APPVEYOR_BUILD_VERSION is not defined\r\n// APPVEYOR_BUILD_NUMBER     is not defined\r\n// APPVEYOR_BUILD_NUMBER_INT is not defined\r\n// APPVEYOR_PULL_REQUEST_NUMBER     is not defined\r\n// APPVEYOR_PULL_REQUEST_NUMBER_INT is not defined\r\n// GITHUB_COMMIT_URL is not defined\r\n// GITHUB_COMMIT_URL_PR_HEAD is not defined\r\n// APPVEYOR_SHORTHASH is not defined\r\n// APPVEYOR_SHORTHASH_PR_HEAD is not defined\r\n```\r\n\r\n## ローカルビルド結果：Git環境無し（sed等も無し）\r\nexist チェックがあるためエラーも起きていないです。\r\n\r\n```\r\n#pragma once                        \r\n// GIT_COMMIT_HASH is not defined    \r\n// GIT_SHORT_COMMIT_HASH is not defined          \r\n// GIT_URL is not defined                        \r\n// APPVEYOR_URL is not defined                   \r\n// APPVEYOR_REPO_NAME is not defined                         \r\n// APPVEYOR_ACCOUNT_NAME is not defined                      \r\n// APPVEYOR_PROJECT_SLUG is not defined                      \r\n// APPVEYOR_BUILD_VERSION is not defined                     \r\n// APPVEYOR_BUILD_NUMBER     is not defined                      \r\n// APPVEYOR_BUILD_NUMBER_INT is not defined                      \r\n// APPVEYOR_PULL_REQUEST_NUMBER     is not defined                             \r\n// APPVEYOR_PULL_REQUEST_NUMBER_INT is not defined                             \r\n// GITHUB_COMMIT_URL is not defined                          \r\n// GITHUB_COMMIT_URL_PR_HEAD is not defined                            \r\n// APPVEYOR_SHORTHASH is not defined                                   \r\n// APPVEYOR_SHORTHASH_PR_HEAD is not defined                           \r\n```"}}
{"actor":{"display_login":"kobake"}}