{"action":"created","issue":{"url":"https://api.github.com/repos/jnunemaker/flipper/issues/330","repository_url":"https://api.github.com/repos/jnunemaker/flipper","labels_url":"https://api.github.com/repos/jnunemaker/flipper/issues/330/labels{/name}","comments_url":"https://api.github.com/repos/jnunemaker/flipper/issues/330/comments","events_url":"https://api.github.com/repos/jnunemaker/flipper/issues/330/events","html_url":"https://github.com/jnunemaker/flipper/pull/330","id":287670898,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYyMjk3ODk3","number":330,"title":"Moneta adapter","user":{"login":"AlexWheeler","id":3260042,"node_id":"MDQ6VXNlcjMyNjAwNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/3260042?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexWheeler","html_url":"https://github.com/AlexWheeler","followers_url":"https://api.github.com/users/AlexWheeler/followers","following_url":"https://api.github.com/users/AlexWheeler/following{/other_user}","gists_url":"https://api.github.com/users/AlexWheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexWheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexWheeler/subscriptions","organizations_url":"https://api.github.com/users/AlexWheeler/orgs","repos_url":"https://api.github.com/users/AlexWheeler/repos","events_url":"https://api.github.com/users/AlexWheeler/events{/privacy}","received_events_url":"https://api.github.com/users/AlexWheeler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-01-11T05:47:00Z","updated_at":"2018-06-02T14:13:15Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jnunemaker/flipper/pulls/330","html_url":"https://github.com/jnunemaker/flipper/pull/330","diff_url":"https://github.com/jnunemaker/flipper/pull/330.diff","patch_url":"https://github.com/jnunemaker/flipper/pull/330.patch"},"body":"#307 \r\n\r\nI almost thought we could pass in a Moneta instance to the memory adapter as its source and it would work because the Moneta api is very similar to Hash, but it turns out Moneta returns copies of objects, which is why [set_add](https://github.com/jnunemaker/flipper/compare/moneta-adapter?expand=1#diff-975176d71feb497dd53ac5b6311196eaR145) and set_delete need to be implemented a little different than the memory adapter.  This is pretty much the memory adapter with a few tweaks.\r\n\r\n* The earliest version that passes *flipper/adapters/moneta_spec.rb* is Moneta [0.7.19](https://github.com/jnunemaker/flipper/compare/moneta-adapter?expand=1#diff-f66ab524b960774a9c36616b5c0a9187R23). Not sure if we should require that dependency or 1.0? Would be cool to hear ya thoughts!\r\n\r\n* moneta is very cool and this opens the door to so many data stores"},"comment":{"url":"https://api.github.com/repos/jnunemaker/flipper/issues/comments/394090421","html_url":"https://github.com/jnunemaker/flipper/pull/330#issuecomment-394090421","issue_url":"https://api.github.com/repos/jnunemaker/flipper/issues/330","id":394090421,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDA5MDQyMQ==","user":{"login":"AlexWheeler","id":3260042,"node_id":"MDQ6VXNlcjMyNjAwNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/3260042?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexWheeler","html_url":"https://github.com/AlexWheeler","followers_url":"https://api.github.com/users/AlexWheeler/followers","following_url":"https://api.github.com/users/AlexWheeler/following{/other_user}","gists_url":"https://api.github.com/users/AlexWheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexWheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexWheeler/subscriptions","organizations_url":"https://api.github.com/users/AlexWheeler/orgs","repos_url":"https://api.github.com/users/AlexWheeler/repos","events_url":"https://api.github.com/users/AlexWheeler/events{/privacy}","received_events_url":"https://api.github.com/users/AlexWheeler/received_events","type":"User","site_admin":false},"created_at":"2018-06-02T14:13:15Z","updated_at":"2018-06-02T14:13:15Z","author_association":"COLLABORATOR","body":"Thanks for the great comments, closing in favor of #361 as I finally got around to jamming on this again on my flight to nyc last night"}}
{"actor":{"display_login":"AlexWheeler"}}