{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/comments/167068063","pull_request_review_id":95233582,"id":167068063,"diff_hunk":"@@ -159,7 +159,10 @@ async function extractApkInfoWithApkanalyzer (localApk) {\n  */\n manifestMethods.packageAndLaunchActivityFromManifest = async function (localApk) {\n   const apkInfoGetters = [\n-    async () => await extractApkInfoWithApkanalyzer(localApk),\n+    async () => {\n+      const apkanalyzerPath = await getApkanalyzerForOs(this);","path":"lib/tools/android-manifest.js","position":30,"original_position":30,"commit_id":"3c51bac6483f8764e7c3f6b886b12fe0e6457cbc","original_commit_id":"3c51bac6483f8764e7c3f6b886b12fe0e6457cbc","user":{"login":"imurchie","id":2614354,"avatar_url":"https://avatars2.githubusercontent.com/u/2614354?v=4","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false},"body":"Ah! Makes sense.","created_at":"2018-02-08T21:09:28Z","updated_at":"2018-02-08T21:09:28Z","html_url":"https://github.com/appium/appium-adb/pull/297#discussion_r167068063","pull_request_url":"https://api.github.com/repos/appium/appium-adb/pulls/297","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments/167068063"},"html":{"href":"https://github.com/appium/appium-adb/pull/297#discussion_r167068063"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/297"}},"in_reply_to_id":167065255},"pull_request":{"url":"https://api.github.com/repos/appium/appium-adb/pulls/297","id":168072139,"html_url":"https://github.com/appium/appium-adb/pull/297","diff_url":"https://github.com/appium/appium-adb/pull/297.diff","patch_url":"https://github.com/appium/appium-adb/pull/297.patch","issue_url":"https://api.github.com/repos/appium/appium-adb/issues/297","number":297,"state":"open","locked":false,"title":"Fix getting path to apkanalyzer","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"body":"Addresses https://github.com/appium/appium/issues/10120#issuecomment-364227397","created_at":"2018-02-08T19:59:36Z","updated_at":"2018-02-08T21:09:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89b2df586936763f206660d4c16a5f182aa86e2d","assignee":{"login":"imurchie","id":2614354,"avatar_url":"https://avatars2.githubusercontent.com/u/2614354?v=4","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false},"assignees":[{"login":"imurchie","id":2614354,"avatar_url":"https://avatars2.githubusercontent.com/u/2614354?v=4","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-adb/pulls/297/commits","review_comments_url":"https://api.github.com/repos/appium/appium-adb/pulls/297/comments","review_comment_url":"https://api.github.com/repos/appium/appium-adb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-adb/issues/297/comments","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/3c51bac6483f8764e7c3f6b886b12fe0e6457cbc","head":{"label":"mykola-mokhnach:get_binary_fix","ref":"get_binary_fix","sha":"3c51bac6483f8764e7c3f6b886b12fe0e6457cbc","user":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"repo":{"id":84554947,"name":"appium-adb","full_name":"mykola-mokhnach/appium-adb","owner":{"login":"mykola-mokhnach","id":7767781,"avatar_url":"https://avatars1.githubusercontent.com/u/7767781?v=4","gravatar_id":"","url":"https://api.github.com/users/mykola-mokhnach","html_url":"https://github.com/mykola-mokhnach","followers_url":"https://api.github.com/users/mykola-mokhnach/followers","following_url":"https://api.github.com/users/mykola-mokhnach/following{/other_user}","gists_url":"https://api.github.com/users/mykola-mokhnach/gists{/gist_id}","starred_url":"https://api.github.com/users/mykola-mokhnach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykola-mokhnach/subscriptions","organizations_url":"https://api.github.com/users/mykola-mokhnach/orgs","repos_url":"https://api.github.com/users/mykola-mokhnach/repos","events_url":"https://api.github.com/users/mykola-mokhnach/events{/privacy}","received_events_url":"https://api.github.com/users/mykola-mokhnach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mykola-mokhnach/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":true,"url":"https://api.github.com/repos/mykola-mokhnach/appium-adb","forks_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/forks","keys_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/teams","hooks_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/events","assignees_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/tags","blobs_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/languages","stargazers_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/subscription","commits_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/merges","archive_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/downloads","issues_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/releases{/id}","deployments_url":"https://api.github.com/repos/mykola-mokhnach/appium-adb/deployments","created_at":"2017-03-10T11:51:45Z","updated_at":"2017-03-10T11:51:47Z","pushed_at":"2018-02-08T20:02:33Z","git_url":"git://github.com/mykola-mokhnach/appium-adb.git","ssh_url":"git@github.com:mykola-mokhnach/appium-adb.git","clone_url":"https://github.com/mykola-mokhnach/appium-adb.git","svn_url":"https://github.com/mykola-mokhnach/appium-adb","homepage":null,"size":30457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"db2b737cb7d497da6d23da88d45d60169b7a566e","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":17339088,"name":"appium-adb","full_name":"appium/appium-adb","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars2.githubusercontent.com/u/3221291?v=4","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-adb","description":"Wrapper around adb used by appium + helper libs","fork":false,"url":"https://api.github.com/repos/appium/appium-adb","forks_url":"https://api.github.com/repos/appium/appium-adb/forks","keys_url":"https://api.github.com/repos/appium/appium-adb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-adb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-adb/teams","hooks_url":"https://api.github.com/repos/appium/appium-adb/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-adb/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-adb/events","assignees_url":"https://api.github.com/repos/appium/appium-adb/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-adb/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-adb/tags","blobs_url":"https://api.github.com/repos/appium/appium-adb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-adb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-adb/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-adb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-adb/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-adb/languages","stargazers_url":"https://api.github.com/repos/appium/appium-adb/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-adb/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-adb/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-adb/subscription","commits_url":"https://api.github.com/repos/appium/appium-adb/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-adb/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-adb/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-adb/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-adb/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-adb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-adb/merges","archive_url":"https://api.github.com/repos/appium/appium-adb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-adb/downloads","issues_url":"https://api.github.com/repos/appium/appium-adb/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-adb/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-adb/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-adb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-adb/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-adb/releases{/id}","deployments_url":"https://api.github.com/repos/appium/appium-adb/deployments","created_at":"2014-03-02T14:20:10Z","updated_at":"2018-01-25T02:25:12Z","pushed_at":"2018-02-08T20:02:34Z","git_url":"git://github.com/appium/appium-adb.git","ssh_url":"git@github.com:appium/appium-adb.git","clone_url":"https://github.com/appium/appium-adb.git","svn_url":"https://github.com/appium/appium-adb","homepage":null,"size":30446,"stargazers_count":85,"watchers_count":85,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":106,"open_issues":1,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/297"},"html":{"href":"https://github.com/appium/appium-adb/pull/297"},"issue":{"href":"https://api.github.com/repos/appium/appium-adb/issues/297"},"comments":{"href":"https://api.github.com/repos/appium/appium-adb/issues/297/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/297/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-adb/pulls/297/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-adb/statuses/3c51bac6483f8764e7c3f6b886b12fe0e6457cbc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"imurchie"}}