{"action":"created","issue":{"url":"https://api.github.com/repos/kiali/kiali/issues/252","repository_url":"https://api.github.com/repos/kiali/kiali","labels_url":"https://api.github.com/repos/kiali/kiali/issues/252/labels{/name}","comments_url":"https://api.github.com/repos/kiali/kiali/issues/252/comments","events_url":"https://api.github.com/repos/kiali/kiali/issues/252/events","html_url":"https://github.com/kiali/kiali/pull/252","id":330426810,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDQwNTQy","number":252,"title":"KIALI-817 Change shape of nodes on different namespaces","user":{"login":"cfcosta","id":14752,"node_id":"MDQ6VXNlcjE0NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/14752?v=4","gravatar_id":"","url":"https://api.github.com/users/cfcosta","html_url":"https://github.com/cfcosta","followers_url":"https://api.github.com/users/cfcosta/followers","following_url":"https://api.github.com/users/cfcosta/following{/other_user}","gists_url":"https://api.github.com/users/cfcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/cfcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfcosta/subscriptions","organizations_url":"https://api.github.com/users/cfcosta/orgs","repos_url":"https://api.github.com/users/cfcosta/repos","events_url":"https://api.github.com/users/cfcosta/events{/privacy}","received_events_url":"https://api.github.com/users/cfcosta/received_events","type":"User","site_admin":false},"labels":[{"id":828917230,"node_id":"MDU6TGFiZWw4Mjg5MTcyMzA=","url":"https://api.github.com/repos/kiali/kiali/labels/do%20not%20merge","name":"do not merge","color":"fc9492","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-07T20:38:09Z","updated_at":"2018-06-12T14:47:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kiali/kiali/pulls/252","html_url":"https://github.com/kiali/kiali/pull/252","diff_url":"https://github.com/kiali/kiali/pull/252.diff","patch_url":"https://github.com/kiali/kiali/pull/252.patch"},"body":"This is a two-part PR, the other one being on the ui repo. The idea here is to\nshow the services on a different namespace with a different color and shape.\n\nHere's how it looks right now:\n\n![](https://i.imgur.com/fTPEOqz.png)\n\nThings that are missing:\n\n- [X] On the `all` namespaces page, the nodes are still being marked as from other namespaces.\n- [ ] Discuss on how to group the namespaces on the `all` page.\n- [ ] There are two bugs on some configurations of connections, and both can be\n  shown on the image below. I'm not sure exactly what happens on that, what I do\n  have in mind right now is that those bugs appear when there's a graph on the\n  connection that comes and goes to a different namespace, like this:\n\n![](https://i.imgur.com/LvVWsjE.png)\n\nThe configuration on this one is pingpong, which is `a d a e a f`, meaning that\nit goes from one namespace to the other and then back.\n\nOn the other namespace page, the weird behaviour also happens:\n\n![](https://i.imgur.com/MHhIJbE.png)\n\nThat means that ingress traffic that comes from another namespace is not being shown.\n\n\n---\n\nIf you want to test these configurations, you can use this script on the gist: [https://gist.github.com/cfcosta/75620f9e82ee0eb05b68953f33e45949]().\n\nJust run `generate-mesh.sh` to generate the mesh, and `ruby generate_traffic.rb` to add some traffic to those nodes."},"comment":{"url":"https://api.github.com/repos/kiali/kiali/issues/comments/396616875","html_url":"https://github.com/kiali/kiali/pull/252#issuecomment-396616875","issue_url":"https://api.github.com/repos/kiali/kiali/issues/252","id":396616875,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjYxNjg3NQ==","user":{"login":"cfcosta","id":14752,"node_id":"MDQ6VXNlcjE0NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/14752?v=4","gravatar_id":"","url":"https://api.github.com/users/cfcosta","html_url":"https://github.com/cfcosta","followers_url":"https://api.github.com/users/cfcosta/followers","following_url":"https://api.github.com/users/cfcosta/following{/other_user}","gists_url":"https://api.github.com/users/cfcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/cfcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfcosta/subscriptions","organizations_url":"https://api.github.com/users/cfcosta/orgs","repos_url":"https://api.github.com/users/cfcosta/repos","events_url":"https://api.github.com/users/cfcosta/events{/privacy}","received_events_url":"https://api.github.com/users/cfcosta/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T14:47:51Z","updated_at":"2018-06-12T14:47:51Z","author_association":"CONTRIBUTOR","body":"@serenamarie125 can we get some UX feedback on here?\r\n@abonas also, here's a listing of shapes that we can use: http://js.cytoscape.org/#style/node-body"}}
{"actor":{"display_login":"cfcosta"}}