{"action":"created","issue":{"url":"https://api.github.com/repos/FormidableLabs/formidable-landers/issues/234","repository_url":"https://api.github.com/repos/FormidableLabs/formidable-landers","labels_url":"https://api.github.com/repos/FormidableLabs/formidable-landers/issues/234/labels{/name}","comments_url":"https://api.github.com/repos/FormidableLabs/formidable-landers/issues/234/comments","events_url":"https://api.github.com/repos/FormidableLabs/formidable-landers/issues/234/events","html_url":"https://github.com/FormidableLabs/formidable-landers/pull/234","id":262380970,"number":234,"title":"Update mocha to the latest version 🚀","user":{"login":"greenkeeper[bot]","id":23040076,"avatar_url":"https://avatars3.githubusercontent.com/in/505?v=4","gravatar_id":"","url":"https://api.github.com/users/greenkeeper%5Bbot%5D","html_url":"https://github.com/apps/greenkeeper","followers_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/followers","following_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/repos","events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/received_events","type":"Bot","site_admin":false},"labels":[{"id":477222955,"url":"https://api.github.com/repos/FormidableLabs/formidable-landers/labels/greenkeeper","name":"greenkeeper","color":"00c775","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-10-03T10:41:50Z","updated_at":"2018-03-06T04:54:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/FormidableLabs/formidable-landers/pulls/234","html_url":"https://github.com/FormidableLabs/formidable-landers/pull/234","diff_url":"https://github.com/FormidableLabs/formidable-landers/pull/234.diff","patch_url":"https://github.com/FormidableLabs/formidable-landers/pull/234.patch"},"body":"\n## Version **4.0.0** of [mocha](https://github.com/mochajs/mocha) just got published.\n\n<table>\n  <tr>\n    <th align=left>\n      Dependency\n    </td>\n    <td>\n      mocha\n    </td>\n  </tr>\n  <tr>\n    <th align=left>\n      Current Version\n    </td>\n    <td>\n      3.5.3\n    </td>\n  </tr>\n  <tr>\n    <th align=left>\n      Type\n    </td>\n    <td>\n      devDependency\n    </td>\n  </tr>\n</table>\n\nThe version **4.0.0** is **not covered** by your **current version range**.\n\nWithout accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.\n\nI recommend you look into these changes and try to get onto the latest version of mocha.\nGiven that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.\n\n\n---\n\n\n<details>\n<summary>Release Notes</summary>\n<strong>v4.0.0</strong>\n\n<h1>4.0.0 / 2017-10-02</h1>\n<p>You might want to read this before filing a new bug!  <g-emoji alias=\"stuck_out_tongue_closed_eyes\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f61d.png\" ios-version=\"6.0\">😝</g-emoji></p>\n<h2><g-emoji alias=\"boom\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f4a5.png\" ios-version=\"6.0\">💥</g-emoji> Breaking Changes</h2>\n<p>For more info, please <a href=\"https://boneskull.com/mocha-v4-nears-release/\">read this article</a>.</p>\n<h3>Compatibility</h3>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/3016\">#3016</a>: Drop support for unmaintained versions of Node.js (<a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>):\n<ul>\n<li>0.10.x</li>\n<li>0.11.x</li>\n<li>0.12.x</li>\n<li>iojs (any)</li>\n<li>5.x.x</li>\n</ul>\n</li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2979\">#2979</a>: Drop support for non-ES5-compliant browsers (<a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>):\n<ul>\n<li>IE7</li>\n<li>IE8</li>\n<li>PhantomJS 1.x</li>\n</ul>\n</li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2615\">#2615</a>: Drop Bower support; old versions (3.x, etc.) will remain available (<a href=\"https://urls.greenkeeper.io/ScottFreeCode\">@ScottFreeCode</a>, <a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>)</li>\n</ul>\n<h3>Default Behavior</h3>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2879\">#2879</a>: By default, Mocha will no longer force the process to exit once all tests complete.  This means any test code (or code under test) which would normally prevent <code>node</code> from exiting will do so when run in Mocha.  Supply the <code>--exit</code> flag to revert to pre-v4.0.0 behavior (<a href=\"https://urls.greenkeeper.io/ScottFreeCode\">@ScottFreeCode</a>, <a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>)</li>\n</ul>\n<h3>Reporter Output</h3>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2095\">#2095</a>: Remove <code>stdout:</code> prefix from browser reporter logs (<a href=\"https://urls.greenkeeper.io/skeggse\">@skeggse</a>)</li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2295\">#2295</a>: Add separator in \"unified diff\" output (<a href=\"https://urls.greenkeeper.io/olsonpm\">@olsonpm</a>)</li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2686\">#2686</a>: Print failure message when <code>--forbid-pending</code> or <code>--forbid-only</code> is specified (<a href=\"https://urls.greenkeeper.io/ScottFreeCode\">@ScottFreeCode</a>)</li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/pull/2814\">#2814</a>: Indent contexts for better readability when reporting failures (<a href=\"https://urls.greenkeeper.io/charlierudolph\">@charlierudolph</a>)</li>\n</ul>\n<h2><g-emoji alias=\"-1\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f44e.png\" ios-version=\"6.0\">👎</g-emoji> Deprecations</h2>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2493\">#2493</a>: The <code>--compilers</code> command-line option is now soft-deprecated and will emit a warning on <code>STDERR</code>.  Read <a href=\"https://urls.greenkeeper.io/mochajs/mocha/wiki/compilers-deprecation\">this</a> for more info and workarounds (<a href=\"https://urls.greenkeeper.io/ScottFreeCode\">@ScottFreeCode</a>, <a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>)</li>\n</ul>\n<h2><g-emoji alias=\"tada\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f389.png\" ios-version=\"6.0\">🎉</g-emoji> Enhancements</h2>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2628\">#2628</a>: Allow override of default test suite name in XUnit reporter (<a href=\"https://urls.greenkeeper.io/ngeor\">@ngeor</a>)</li>\n</ul>\n<h2><g-emoji alias=\"book\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f4d6.png\" ios-version=\"6.0\">📖</g-emoji> Documentation</h2>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/pull/3020\">#3020</a>: Link to CLA in <code>README.md</code> and <code>CONTRIBUTING.md</code> (<a href=\"https://urls.greenkeeper.io/skeggse\">@skeggse</a>)</li>\n</ul>\n<h2><g-emoji alias=\"nut_and_bolt\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f529.png\" ios-version=\"6.0\">🔩</g-emoji> Other</h2>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/issues/2890\">#2890</a>: Speed up build by (re-)consolidating SauceLabs tests (<a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>)</li>\n</ul>\n</details>\n\n<details>\n<summary>Commits</summary>\n<p>The new version differs by 48 commits.</p>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/d69bf14a860235e7ceb50a50c2072dddd1ef8520\"><code>d69bf14</code></a> <code>Release v4.0.0</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/171b9f92cdb8873ab2d1b779b9585e548abd49db\"><code>171b9f9</code></a> <code>pfix \"prepublishOnly\" potential portability problem</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/60e39d9890fa7aa83afb8cd9deb62c1a2dd6bce0\"><code>60e39d9</code></a> <code>Update link to wiki (GitHub at the leading <code>--</code>)</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/804f9d5b02321419a0775cb725133f7ea818a034\"><code>804f9d5</code></a> <code>Update link because GitHub ate the leading <code>--</code></code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/3326c23bc1a324dfd19cea21b3e9d964b0cd1d9a\"><code>3326c23</code></a> <code>update CHANGELOG for v4.0.0 [ci skip]</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/6dd92528528aac46788ce3e586679acef9749e8a\"><code>6dd9252</code></a> <code>add link to wiki on --compilers deprecation</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/96318e1e2a3459bbdb516cddcf268d5c24156fed\"><code>96318e1</code></a> <code>Deprecate --compilers</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/92beda983f0cfa98541a816b6a1beaf0b64f260e\"><code>92beda9</code></a> <code>drop bower support</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/58a4c6a0e3452df4aeb4c39c50ec44401c874e9f\"><code>58a4c6a</code></a> <code>remove unused .npmignore</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/7af6611d3e99823f8bef2f8682a9d4ac9f7f35a3\"><code>7af6611</code></a> <code>kill Date#toISOString shim</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/43501a24ab4e273d9588ede11c630cc71c324ef2\"><code>43501a2</code></a> <code>reduce noise about slow tests; make a few tests faster, etc.</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/fa228e99d53eb65fa6e1dafb2e5f68723a8b9884\"><code>fa228e9</code></a> <code>update --exit / --no-exit integration test for new default behavior</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/3fdd3ff165170c5b3c4da4edc3edc8270261c62d\"><code>3fdd3ff</code></a> <code>Switch default from forced exit to no-exit</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/c5d69e0d9cdb494198e1c65a85ef5d58c0687aa3\"><code>c5d69e0</code></a> <code>add integration tests for --exit/--no-exit</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/3a7f8dc1beb921e00e953b27fc6b04cf242823a9\"><code>3a7f8dc</code></a> <code>enhance runMochaJSON() helper by returning the subprocess instance</code></li>\n</ul>\n<p>There are 48 commits in total.</p>\n<p>See the <a href=\"https://urls.greenkeeper.io/mochajs/mocha/compare/e838a774ac238c7e5556838dafb6163aad49cf9e...d69bf14a860235e7ceb50a50c2072dddd1ef8520\">full diff</a></p>\n</details>\n\n<details>\n  <summary>Not sure how things should work exactly?</summary>\n\n  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).\n</details>\n\n\n---\n\n\nYour [Greenkeeper](https://greenkeeper.io) Bot :palm_tree:\n\n"},"comment":{"url":"https://api.github.com/repos/FormidableLabs/formidable-landers/issues/comments/370662375","html_url":"https://github.com/FormidableLabs/formidable-landers/pull/234#issuecomment-370662375","issue_url":"https://api.github.com/repos/FormidableLabs/formidable-landers/issues/234","id":370662375,"user":{"login":"greenkeeper[bot]","id":23040076,"avatar_url":"https://avatars3.githubusercontent.com/in/505?v=4","gravatar_id":"","url":"https://api.github.com/users/greenkeeper%5Bbot%5D","html_url":"https://github.com/apps/greenkeeper","followers_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/followers","following_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/repos","events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/greenkeeper%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-06T04:54:58Z","updated_at":"2018-03-06T04:54:58Z","author_association":"NONE","body":"## Version **5.0.2** just got published. \n[Update to this version instead 🚀](https://github.com/FormidableLabs/formidable-landers/compare/greenkeeper%2Fmocha-5.0.2?expand=1) \n\n<details>\n<summary>Release Notes</summary>\n<strong>v5.0.2</strong>\n\n<h1>5.0.2 / 2018-03-05</h1>\n<p>This release fixes a class of tests which report as <em>false positives</em>.  <strong>Certain tests will now break</strong>, though they would have previously been reported as passing.  Details below.  Sorry for the inconvenience!</p>\n<h2><g-emoji class=\"g-emoji\" alias=\"bug\" fallback-src=\"https://assets-cdn.github.com/images/icons/emoji/unicode/1f41b.png\">🐛</g-emoji> Fixes</h2>\n<ul>\n<li>\n<p><a href=\"https://urls.greenkeeper.io/mochajs/mocha/issues/3226\">#3226</a>: Do not swallow errors that are thrown asynchronously from passing tests (<a href=\"https://urls.greenkeeper.io/boneskull\">@boneskull</a>).  Example:</p>\n<div class=\"highlight highlight-source-js\"><pre><span class=\"pl-en\">it</span>(<span class=\"pl-s\"><span class=\"pl-pds\">'</span>should actually fail, sorry!<span class=\"pl-pds\">'</span></span>, <span class=\"pl-k\">function</span> (<span class=\"pl-smi\">done</span>) {\n  <span class=\"pl-c\"><span class=\"pl-c\">//</span> passing assertion</span>\n  <span class=\"pl-en\">assert</span>(<span class=\"pl-c1\">true</span> <span class=\"pl-k\">===</span> <span class=\"pl-c1\">true</span>);\n\n  <span class=\"pl-c\"><span class=\"pl-c\">//</span> test complete &amp; is marked as passing</span>\n  <span class=\"pl-en\">done</span>();\n\n  <span class=\"pl-c\"><span class=\"pl-c\">//</span> ...but something evil lurks within</span>\n  <span class=\"pl-c1\">setTimeout</span>(() <span class=\"pl-k\">=&gt;</span> {\n    <span class=\"pl-k\">throw</span> <span class=\"pl-k\">new</span> <span class=\"pl-en\">Error</span>(<span class=\"pl-s\"><span class=\"pl-pds\">'</span>chaos!<span class=\"pl-pds\">'</span></span>);\n  }, <span class=\"pl-c1\">100</span>);\n});</pre></div>\n<p>Previously to this version, Mocha would have <em>silently swallowed</em> the <code>chaos!</code> exception, and you wouldn't know.  Well, <em>now you know</em>.  Mocha cannot recover from this gracefully, so it will exit with a nonzero code.</p>\n<p><strong>Maintainers of external reporters</strong>: <em>If</em> a test of this class is encountered, the <code>Runner</code> instance will emit the <code>end</code> event <em>twice</em>; you <em>may</em> need to change your reporter to use <code>runner.once('end')</code> intead of <code>runner.on('end')</code>.</p>\n</li>\n<li>\n<p><a href=\"https://urls.greenkeeper.io/mochajs/mocha/issues/3093\">#3093</a>: Fix stack trace reformatting problem (<a href=\"https://urls.greenkeeper.io/outsideris\">@outsideris</a>)</p>\n</li>\n</ul>\n<h2>:nut_and_bolt Other</h2>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/issues/3248\">#3248</a>: Update <code>browser-stdout</code> to v1.3.1 (<a href=\"https://urls.greenkeeper.io/honzajavorek\">@honzajavorek</a>)</li>\n</ul>\n</details>\n\n<details>\n<summary>Commits</summary>\n<p>The new version differs by 13 commits.</p>\n<ul>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/f2ee53c5ae4583b8117b842ffdbce6ed7387bcaf\"><code>f2ee53c</code></a> <code>Release v5.0.2</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/ff1bd9eaa491a29d67fa6742766464efeb82ac29\"><code>ff1bd9e</code></a> <code>update package-lock.json</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/6a796cbbcd6c9f805e482c424327c82ed0398dbf\"><code>6a796cb</code></a> <code>prepare CHANGELOG for v5.0.2 [ci skip]</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/0542c407fcc08be3a3e293d5df943f22d292e304\"><code>0542c40</code></a> <code>update README.md; closes #3191 [ci skip]</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/afcd08f1fb6782d7d4f7d4d935250279f94d728a\"><code>afcd08f</code></a> <code>add MAINTAINERS.md to .fossaignore [ci skip]</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/3792bef67b59add3b6d188e53f4d324e1488f159\"><code>3792bef</code></a> <code>add opencollective header image to assets/</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/5078fc5325bf7bd02b6cf448792cd1584e052b73\"><code>5078fc5</code></a> <code>persist paths in stack trace which have cwd as infix</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/2c720a35000da0fecf11ef65c20ca4292c226ad7\"><code>2c720a3</code></a> <code>do not eat exceptions thrown asynchronously from passed tests; closes #3226</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/3537061613886f9d37c0889d16f64dbdaf1583db\"><code>3537061</code></a> <code>Update to correctly licensed browser-stdout version</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/ec8901a23c5194b6f7e6eee9c2568e5020c944ce\"><code>ec8901a</code></a> <code>remove unused functionality in utils module</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/f71f3472d1049737ce0e2d2131753b468d45c66a\"><code>f71f347</code></a> <code>rename wallaby.js -&gt; .wallaby.js</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/c4ef5687fa67ab97642a66ec25e05139e2d333ce\"><code>c4ef568</code></a> <code>fix PR url</code></li>\n<li><a href=\"https://urls.greenkeeper.io/mochajs/mocha/commit/73d55ac4bc2d1f10121e6d37e62f2bff7520f166\"><code>73d55ac</code></a> <code>fix typos in changelog [ci skip]</code></li>\n</ul>\n<p>See the <a href=\"https://urls.greenkeeper.io/mochajs/mocha/compare/09ce746aa925d35317f2624fd36c77a31bb68e24...f2ee53c5ae4583b8117b842ffdbce6ed7387bcaf\">full diff</a></p>\n</details>"}}
{"actor":{"display_login":"greenkeeper"}}