{"action":"created","comment":{"url":"https://api.github.com/repos/racer-rust/racer/pulls/comments/192357725","pull_request_review_id":125120025,"id":192357725,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM1NzcyNQ==","diff_hunk":"@@ -36,10 +36,14 @@ As mentioned in the command output, don't forget to add the installation directo\n \n     2. manually from git, or download from https://www.rust-lang.org/install.html (the 'rustc' source download behind the 'source' link is the right one).\n \n-2. Set the ```RUST_SRC_PATH``` environment variable to point to the 'src' dir in the Rust source installation\n+    Ensure to download sources for any rust version you have installed (e.g. a common configuration is to have the `stable` and many `nightly` installed).","path":"README.md","position":5,"original_position":5,"commit_id":"1e64839cf2e8d4c417628cb42a4a90096946e513","original_commit_id":"1e64839cf2e8d4c417628cb42a4a90096946e513","user":{"login":"kngwyu","id":16046705,"node_id":"MDQ6VXNlcjE2MDQ2NzA1","avatar_url":"https://avatars1.githubusercontent.com/u/16046705?v=4","gravatar_id":"","url":"https://api.github.com/users/kngwyu","html_url":"https://github.com/kngwyu","followers_url":"https://api.github.com/users/kngwyu/followers","following_url":"https://api.github.com/users/kngwyu/following{/other_user}","gists_url":"https://api.github.com/users/kngwyu/gists{/gist_id}","starred_url":"https://api.github.com/users/kngwyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kngwyu/subscriptions","organizations_url":"https://api.github.com/users/kngwyu/orgs","repos_url":"https://api.github.com/users/kngwyu/repos","events_url":"https://api.github.com/users/kngwyu/events{/privacy}","received_events_url":"https://api.github.com/users/kngwyu/received_events","type":"User","site_admin":false},"body":"Ah I understand, thanks.\r\nThen my suggestion is:\r\n**Note** \r\nIf you want to use racer with multiple release channels(we can use 3 release channels, stable, beta and nightly), you have to download Rust sourcecode for each relase channels.\r\ne.g.(rustup case)\r\nYou have to run `rustup component add rust-src` after `rustup toolchain add nightly`.","created_at":"2018-06-01T10:32:12Z","updated_at":"2018-06-01T10:32:12Z","html_url":"https://github.com/racer-rust/racer/pull/863#discussion_r192357725","pull_request_url":"https://api.github.com/repos/racer-rust/racer/pulls/863","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/racer-rust/racer/pulls/comments/192357725"},"html":{"href":"https://github.com/racer-rust/racer/pull/863#discussion_r192357725"},"pull_request":{"href":"https://api.github.com/repos/racer-rust/racer/pulls/863"}},"in_reply_to_id":192346773},"pull_request":{"url":"https://api.github.com/repos/racer-rust/racer/pulls/863","id":191976722,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxOTc2NzIy","html_url":"https://github.com/racer-rust/racer/pull/863","diff_url":"https://github.com/racer-rust/racer/pull/863.diff","patch_url":"https://github.com/racer-rust/racer/pull/863.patch","issue_url":"https://api.github.com/repos/racer-rust/racer/issues/863","number":863,"state":"open","locked":false,"title":"Readme update: RUST_SRC_PATH not mandatory anymore","user":{"login":"apiraino","id":6098822,"node_id":"MDQ6VXNlcjYwOTg4MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6098822?v=4","gravatar_id":"","url":"https://api.github.com/users/apiraino","html_url":"https://github.com/apiraino","followers_url":"https://api.github.com/users/apiraino/followers","following_url":"https://api.github.com/users/apiraino/following{/other_user}","gists_url":"https://api.github.com/users/apiraino/gists{/gist_id}","starred_url":"https://api.github.com/users/apiraino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiraino/subscriptions","organizations_url":"https://api.github.com/users/apiraino/orgs","repos_url":"https://api.github.com/users/apiraino/repos","events_url":"https://api.github.com/users/apiraino/events{/privacy}","received_events_url":"https://api.github.com/users/apiraino/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nas briefly discussed [here](https://github.com/racer-rust/emacs-racer/issues/93#issuecomment-393747999) the env var `RUST_SRC_PATH` is to not mandatory anymore.\r\n\r\nIf this env var is actually not really needed, could it be useful to relax the configuration requirements for `racer`? Possibly this may lead to a couple of `racer` issue disappearing (not really sure about this, haven't investigated really closely).\r\n\r\nAnd how about removing mentioning this env var altogether to simplify the config process?\r\n\r\nFeel free to suggest on how to improve this little doc update or OTOH is not really needed and can be yanked.\r\n\r\nThanks!","created_at":"2018-06-01T09:12:45Z","updated_at":"2018-06-01T10:32:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49b333a4f669795f3938d439334acc018a445557","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/racer-rust/racer/pulls/863/commits","review_comments_url":"https://api.github.com/repos/racer-rust/racer/pulls/863/comments","review_comment_url":"https://api.github.com/repos/racer-rust/racer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/racer-rust/racer/issues/863/comments","statuses_url":"https://api.github.com/repos/racer-rust/racer/statuses/1e64839cf2e8d4c417628cb42a4a90096946e513","head":{"label":"apiraino:readme_update","ref":"readme_update","sha":"1e64839cf2e8d4c417628cb42a4a90096946e513","user":{"login":"apiraino","id":6098822,"node_id":"MDQ6VXNlcjYwOTg4MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6098822?v=4","gravatar_id":"","url":"https://api.github.com/users/apiraino","html_url":"https://github.com/apiraino","followers_url":"https://api.github.com/users/apiraino/followers","following_url":"https://api.github.com/users/apiraino/following{/other_user}","gists_url":"https://api.github.com/users/apiraino/gists{/gist_id}","starred_url":"https://api.github.com/users/apiraino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiraino/subscriptions","organizations_url":"https://api.github.com/users/apiraino/orgs","repos_url":"https://api.github.com/users/apiraino/repos","events_url":"https://api.github.com/users/apiraino/events{/privacy}","received_events_url":"https://api.github.com/users/apiraino/received_events","type":"User","site_admin":false},"repo":{"id":135693523,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2OTM1MjM=","name":"racer","full_name":"apiraino/racer","owner":{"login":"apiraino","id":6098822,"node_id":"MDQ6VXNlcjYwOTg4MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6098822?v=4","gravatar_id":"","url":"https://api.github.com/users/apiraino","html_url":"https://github.com/apiraino","followers_url":"https://api.github.com/users/apiraino/followers","following_url":"https://api.github.com/users/apiraino/following{/other_user}","gists_url":"https://api.github.com/users/apiraino/gists{/gist_id}","starred_url":"https://api.github.com/users/apiraino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apiraino/subscriptions","organizations_url":"https://api.github.com/users/apiraino/orgs","repos_url":"https://api.github.com/users/apiraino/repos","events_url":"https://api.github.com/users/apiraino/events{/privacy}","received_events_url":"https://api.github.com/users/apiraino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apiraino/racer","description":"Rust Code Completion utility","fork":true,"url":"https://api.github.com/repos/apiraino/racer","forks_url":"https://api.github.com/repos/apiraino/racer/forks","keys_url":"https://api.github.com/repos/apiraino/racer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apiraino/racer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apiraino/racer/teams","hooks_url":"https://api.github.com/repos/apiraino/racer/hooks","issue_events_url":"https://api.github.com/repos/apiraino/racer/issues/events{/number}","events_url":"https://api.github.com/repos/apiraino/racer/events","assignees_url":"https://api.github.com/repos/apiraino/racer/assignees{/user}","branches_url":"https://api.github.com/repos/apiraino/racer/branches{/branch}","tags_url":"https://api.github.com/repos/apiraino/racer/tags","blobs_url":"https://api.github.com/repos/apiraino/racer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apiraino/racer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apiraino/racer/git/refs{/sha}","trees_url":"https://api.github.com/repos/apiraino/racer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apiraino/racer/statuses/{sha}","languages_url":"https://api.github.com/repos/apiraino/racer/languages","stargazers_url":"https://api.github.com/repos/apiraino/racer/stargazers","contributors_url":"https://api.github.com/repos/apiraino/racer/contributors","subscribers_url":"https://api.github.com/repos/apiraino/racer/subscribers","subscription_url":"https://api.github.com/repos/apiraino/racer/subscription","commits_url":"https://api.github.com/repos/apiraino/racer/commits{/sha}","git_commits_url":"https://api.github.com/repos/apiraino/racer/git/commits{/sha}","comments_url":"https://api.github.com/repos/apiraino/racer/comments{/number}","issue_comment_url":"https://api.github.com/repos/apiraino/racer/issues/comments{/number}","contents_url":"https://api.github.com/repos/apiraino/racer/contents/{+path}","compare_url":"https://api.github.com/repos/apiraino/racer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apiraino/racer/merges","archive_url":"https://api.github.com/repos/apiraino/racer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apiraino/racer/downloads","issues_url":"https://api.github.com/repos/apiraino/racer/issues{/number}","pulls_url":"https://api.github.com/repos/apiraino/racer/pulls{/number}","milestones_url":"https://api.github.com/repos/apiraino/racer/milestones{/number}","notifications_url":"https://api.github.com/repos/apiraino/racer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apiraino/racer/labels{/name}","releases_url":"https://api.github.com/repos/apiraino/racer/releases{/id}","deployments_url":"https://api.github.com/repos/apiraino/racer/deployments","created_at":"2018-06-01T08:54:16Z","updated_at":"2018-06-01T08:54:18Z","pushed_at":"2018-06-01T09:06:42Z","git_url":"git://github.com/apiraino/racer.git","ssh_url":"git@github.com:apiraino/racer.git","clone_url":"https://github.com/apiraino/racer.git","svn_url":"https://github.com/apiraino/racer","homepage":null,"size":5607,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"racer-rust:master","ref":"master","sha":"d7d30bf01546742651dcc292edb0c314ba156d57","user":{"login":"racer-rust","id":13939360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTM5MzYw","avatar_url":"https://avatars2.githubusercontent.com/u/13939360?v=4","gravatar_id":"","url":"https://api.github.com/users/racer-rust","html_url":"https://github.com/racer-rust","followers_url":"https://api.github.com/users/racer-rust/followers","following_url":"https://api.github.com/users/racer-rust/following{/other_user}","gists_url":"https://api.github.com/users/racer-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/racer-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racer-rust/subscriptions","organizations_url":"https://api.github.com/users/racer-rust/orgs","repos_url":"https://api.github.com/users/racer-rust/repos","events_url":"https://api.github.com/users/racer-rust/events{/privacy}","received_events_url":"https://api.github.com/users/racer-rust/received_events","type":"Organization","site_admin":false},"repo":{"id":17378050,"node_id":"MDEwOlJlcG9zaXRvcnkxNzM3ODA1MA==","name":"racer","full_name":"racer-rust/racer","owner":{"login":"racer-rust","id":13939360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTM5MzYw","avatar_url":"https://avatars2.githubusercontent.com/u/13939360?v=4","gravatar_id":"","url":"https://api.github.com/users/racer-rust","html_url":"https://github.com/racer-rust","followers_url":"https://api.github.com/users/racer-rust/followers","following_url":"https://api.github.com/users/racer-rust/following{/other_user}","gists_url":"https://api.github.com/users/racer-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/racer-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/racer-rust/subscriptions","organizations_url":"https://api.github.com/users/racer-rust/orgs","repos_url":"https://api.github.com/users/racer-rust/repos","events_url":"https://api.github.com/users/racer-rust/events{/privacy}","received_events_url":"https://api.github.com/users/racer-rust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/racer-rust/racer","description":"Rust Code Completion utility","fork":false,"url":"https://api.github.com/repos/racer-rust/racer","forks_url":"https://api.github.com/repos/racer-rust/racer/forks","keys_url":"https://api.github.com/repos/racer-rust/racer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/racer-rust/racer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/racer-rust/racer/teams","hooks_url":"https://api.github.com/repos/racer-rust/racer/hooks","issue_events_url":"https://api.github.com/repos/racer-rust/racer/issues/events{/number}","events_url":"https://api.github.com/repos/racer-rust/racer/events","assignees_url":"https://api.github.com/repos/racer-rust/racer/assignees{/user}","branches_url":"https://api.github.com/repos/racer-rust/racer/branches{/branch}","tags_url":"https://api.github.com/repos/racer-rust/racer/tags","blobs_url":"https://api.github.com/repos/racer-rust/racer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/racer-rust/racer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/racer-rust/racer/git/refs{/sha}","trees_url":"https://api.github.com/repos/racer-rust/racer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/racer-rust/racer/statuses/{sha}","languages_url":"https://api.github.com/repos/racer-rust/racer/languages","stargazers_url":"https://api.github.com/repos/racer-rust/racer/stargazers","contributors_url":"https://api.github.com/repos/racer-rust/racer/contributors","subscribers_url":"https://api.github.com/repos/racer-rust/racer/subscribers","subscription_url":"https://api.github.com/repos/racer-rust/racer/subscription","commits_url":"https://api.github.com/repos/racer-rust/racer/commits{/sha}","git_commits_url":"https://api.github.com/repos/racer-rust/racer/git/commits{/sha}","comments_url":"https://api.github.com/repos/racer-rust/racer/comments{/number}","issue_comment_url":"https://api.github.com/repos/racer-rust/racer/issues/comments{/number}","contents_url":"https://api.github.com/repos/racer-rust/racer/contents/{+path}","compare_url":"https://api.github.com/repos/racer-rust/racer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/racer-rust/racer/merges","archive_url":"https://api.github.com/repos/racer-rust/racer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/racer-rust/racer/downloads","issues_url":"https://api.github.com/repos/racer-rust/racer/issues{/number}","pulls_url":"https://api.github.com/repos/racer-rust/racer/pulls{/number}","milestones_url":"https://api.github.com/repos/racer-rust/racer/milestones{/number}","notifications_url":"https://api.github.com/repos/racer-rust/racer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/racer-rust/racer/labels{/name}","releases_url":"https://api.github.com/repos/racer-rust/racer/releases{/id}","deployments_url":"https://api.github.com/repos/racer-rust/racer/deployments","created_at":"2014-03-03T19:57:29Z","updated_at":"2018-06-01T06:00:02Z","pushed_at":"2018-06-01T09:12:46Z","git_url":"git://github.com/racer-rust/racer.git","ssh_url":"git@github.com:racer-rust/racer.git","clone_url":"https://github.com/racer-rust/racer.git","svn_url":"https://github.com/racer-rust/racer","homepage":null,"size":5605,"stargazers_count":2462,"watchers_count":2462,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":126,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":229,"open_issues":126,"watchers":2462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/racer-rust/racer/pulls/863"},"html":{"href":"https://github.com/racer-rust/racer/pull/863"},"issue":{"href":"https://api.github.com/repos/racer-rust/racer/issues/863"},"comments":{"href":"https://api.github.com/repos/racer-rust/racer/issues/863/comments"},"review_comments":{"href":"https://api.github.com/repos/racer-rust/racer/pulls/863/comments"},"review_comment":{"href":"https://api.github.com/repos/racer-rust/racer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/racer-rust/racer/pulls/863/commits"},"statuses":{"href":"https://api.github.com/repos/racer-rust/racer/statuses/1e64839cf2e8d4c417628cb42a4a90096946e513"}},"author_association":"NONE"}}
{"actor":{"display_login":"kngwyu"}}