{"action":"created","issue":{"url":"https://api.github.com/repos/linkerd/linkerd2/issues/1720","repository_url":"https://api.github.com/repos/linkerd/linkerd2","labels_url":"https://api.github.com/repos/linkerd/linkerd2/issues/1720/labels{/name}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/issues/1720/comments","events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/1720/events","html_url":"https://github.com/linkerd/linkerd2/issues/1720","id":364402507,"node_id":"MDU6SXNzdWUzNjQ0MDI1MDc=","number":1720,"title":"Allow configuration of cluster base domain","user":{"login":"icedream","id":807772,"node_id":"MDQ6VXNlcjgwNzc3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/807772?v=4","gravatar_id":"","url":"https://api.github.com/users/icedream","html_url":"https://github.com/icedream","followers_url":"https://api.github.com/users/icedream/followers","following_url":"https://api.github.com/users/icedream/following{/other_user}","gists_url":"https://api.github.com/users/icedream/gists{/gist_id}","starred_url":"https://api.github.com/users/icedream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icedream/subscriptions","organizations_url":"https://api.github.com/users/icedream/orgs","repos_url":"https://api.github.com/users/icedream/repos","events_url":"https://api.github.com/users/icedream/events{/privacy}","received_events_url":"https://api.github.com/users/icedream/received_events","type":"User","site_admin":false},"labels":[{"id":773710190,"node_id":"MDU6TGFiZWw3NzM3MTAxOTA=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/area/controller","name":"area/controller","color":"0052CC","default":false},{"id":961555725,"node_id":"MDU6TGFiZWw5NjE1NTU3MjU=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/bug","name":"bug","color":"cc0e1a","default":true},{"id":769531529,"node_id":"MDU6TGFiZWw3Njk1MzE1Mjk=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/help%20wanted","name":"help wanted","color":"dddddd","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-27T10:16:52Z","updated_at":"2018-12-03T22:43:41Z","closed_at":null,"author_association":"NONE","body":"Currently linkerd expects the cluster to use `cluster.local` as its base domain name, however more often than not a Kubernetes admin will decide to change that base domain to something else. This shouldn't break deployments, however in the case of linkerd2 it does as every generated configuration, from `linkerd install` to `linkerd inject`, assumes connection to happen via `cluster.local`-based domain names.\r\n\r\nA workaround for this issue is to pipe generated configurations into `sed 's/cluster\\.local/custom\\.domain/g`. [This has been documented shortly in this pull request for the website](https://github.com/linkerd/website/pull/36) but I think it would be good for usage sanity to introduce a CLI option like `--cluster-domain=…` or a similar way to configure the base domain and inject it into the [respective template](https://github.com/linkerd/linkerd2/blob/b5ff29c8aa26a92e8e3a348fdc24b610e278e7e8/cli/install/template.go).\r\n\r\nNot sure about this but this may also affect linkerd CLI functionality outside of generating templates. (Checks? Proxies?)"},"comment":{"url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments/443899080","html_url":"https://github.com/linkerd/linkerd2/issues/1720#issuecomment-443899080","issue_url":"https://api.github.com/repos/linkerd/linkerd2/issues/1720","id":443899080,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mzg5OTA4MA==","user":{"login":"grampelberg","id":47992,"node_id":"MDQ6VXNlcjQ3OTky","avatar_url":"https://avatars0.githubusercontent.com/u/47992?v=4","gravatar_id":"","url":"https://api.github.com/users/grampelberg","html_url":"https://github.com/grampelberg","followers_url":"https://api.github.com/users/grampelberg/followers","following_url":"https://api.github.com/users/grampelberg/following{/other_user}","gists_url":"https://api.github.com/users/grampelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/grampelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grampelberg/subscriptions","organizations_url":"https://api.github.com/users/grampelberg/orgs","repos_url":"https://api.github.com/users/grampelberg/repos","events_url":"https://api.github.com/users/grampelberg/events{/privacy}","received_events_url":"https://api.github.com/users/grampelberg/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T22:43:41Z","updated_at":"2018-12-03T22:43:41Z","author_association":"CONTRIBUTOR","body":"To pull this all the way through, the domain should be made configurable and be passed to both `install`, `inject` and `profile` (a global CLI flag that will end up being used in multiple places). "}}
{"actor":{"display_login":"grampelberg"}}