{"action":"created","issue":{"url":"https://api.github.com/repos/iTowns/itowns/issues/649","repository_url":"https://api.github.com/repos/iTowns/itowns","labels_url":"https://api.github.com/repos/iTowns/itowns/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/iTowns/itowns/issues/649/comments","events_url":"https://api.github.com/repos/iTowns/itowns/issues/649/events","html_url":"https://github.com/iTowns/itowns/pull/649","id":295576345,"number":649,"title":"fix(core): disable logdepthbuffer if EXT_frag_depth is missing","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars3.githubusercontent.com/u/2198295?v=4","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-08T16:24:26Z","updated_at":"2018-02-09T08:49:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/iTowns/itowns/pulls/649","html_url":"https://github.com/iTowns/itowns/pull/649","diff_url":"https://github.com/iTowns/itowns/pull/649.diff","patch_url":"https://github.com/iTowns/itowns/pull/649.patch"},"body":"Since r88 threejs allows enabling logdepthbuffer if EXT_frag_depth is missing,\r\nsee https://github.com/mrdoob/three.js/pull/11995.\r\n\r\niTowns doesn't handle this case correctly: so for now we recreate the renderer\r\nif we realize that EXT_frag_depth isn't supported.\r\n\r\nBefore this PR:\r\n\r\n![capture d ecran de 2018-02-08 17-21-13](https://user-images.githubusercontent.com/2198295/35984417-afe819d6-0cf4-11e8-8ae7-d1dad33ca3c4.png)\r\n\r\nAfter:\r\n![capture d ecran de 2018-02-08 17-21-47](https://user-images.githubusercontent.com/2198295/35984416-afc110e8-0cf4-11e8-8ccf-9c3b2406d82e.png)\r\n\r\nNote: the rendering is broken, but I have another PR that fixes this by setting correct values to camera.near/far (this PR depends on: #635, #637 and a last one not yet submitted).\r\n"},"comment":{"url":"https://api.github.com/repos/iTowns/itowns/issues/comments/364372387","html_url":"https://github.com/iTowns/itowns/pull/649#issuecomment-364372387","issue_url":"https://api.github.com/repos/iTowns/itowns/issues/649","id":364372387,"user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars3.githubusercontent.com/u/2198295?v=4","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T08:49:39Z","updated_at":"2018-02-09T08:49:39Z","author_association":"CONTRIBUTOR","body":"The last commit is a test for @nosy-b. If this commit doesn't fix the crash on his phone => we need to look for the real cause.\r\n\r\nIf it fixes the crash, either:\r\n- we realize the issue only happen on one mobile GPU config (say Qualcomm). Then we can adapt the last commit to limit max_texture_unit to 8 on such GPUs\r\n- or it happen ons various combination of GPU/iOS/Android/other param => in which case there's nothing to do about it - except implementing a more elaborate fix to limit our texture sampler usage (e.g: #309)"}}
{"actor":{"display_login":"peppsac"}}