{"action":"created","issue":{"url":"https://api.github.com/repos/nozzlegear/ShopifySharp/issues/244","repository_url":"https://api.github.com/repos/nozzlegear/ShopifySharp","labels_url":"https://api.github.com/repos/nozzlegear/ShopifySharp/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/nozzlegear/ShopifySharp/issues/244/comments","events_url":"https://api.github.com/repos/nozzlegear/ShopifySharp/issues/244/events","html_url":"https://github.com/nozzlegear/ShopifySharp/issues/244","id":322363092,"number":244,"title":"Create a ShopifySharp.Strings package","user":{"login":"nozzlegear","id":2417276,"avatar_url":"https://avatars3.githubusercontent.com/u/2417276?v=4","gravatar_id":"","url":"https://api.github.com/users/nozzlegear","html_url":"https://github.com/nozzlegear","followers_url":"https://api.github.com/users/nozzlegear/followers","following_url":"https://api.github.com/users/nozzlegear/following{/other_user}","gists_url":"https://api.github.com/users/nozzlegear/gists{/gist_id}","starred_url":"https://api.github.com/users/nozzlegear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nozzlegear/subscriptions","organizations_url":"https://api.github.com/users/nozzlegear/orgs","repos_url":"https://api.github.com/users/nozzlegear/repos","events_url":"https://api.github.com/users/nozzlegear/events{/privacy}","received_events_url":"https://api.github.com/users/nozzlegear/received_events","type":"User","site_admin":false},"labels":[{"id":241689435,"url":"https://api.github.com/repos/nozzlegear/ShopifySharp/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-11T16:45:11Z","updated_at":"2018-05-12T01:30:55Z","closed_at":null,"author_association":"OWNER","body":"I'd like to get the functionality we used to have with enums back, but I don't want it tied to this package and require an update each time they change. Somebody had suggested using constant strings, which I think is a great solution. This way the functions in ShopifySharp itself can continue accepting strings, and developers can easily update their own app when something changes, but we can also have a set of \"known\" values that can be updated separately. \r\n\r\n```cs\r\npublic static class WebhookTopics \r\n{\r\n  public static const whatever string AppUninstalled = \"app/uninstalled\";\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/nozzlegear/ShopifySharp/issues/comments/388520920","html_url":"https://github.com/nozzlegear/ShopifySharp/issues/244#issuecomment-388520920","issue_url":"https://api.github.com/repos/nozzlegear/ShopifySharp/issues/244","id":388520920,"user":{"login":"nozzlegear","id":2417276,"avatar_url":"https://avatars3.githubusercontent.com/u/2417276?v=4","gravatar_id":"","url":"https://api.github.com/users/nozzlegear","html_url":"https://github.com/nozzlegear","followers_url":"https://api.github.com/users/nozzlegear/followers","following_url":"https://api.github.com/users/nozzlegear/following{/other_user}","gists_url":"https://api.github.com/users/nozzlegear/gists{/gist_id}","starred_url":"https://api.github.com/users/nozzlegear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nozzlegear/subscriptions","organizations_url":"https://api.github.com/users/nozzlegear/orgs","repos_url":"https://api.github.com/users/nozzlegear/repos","events_url":"https://api.github.com/users/nozzlegear/events{/privacy}","received_events_url":"https://api.github.com/users/nozzlegear/received_events","type":"User","site_admin":false},"created_at":"2018-05-12T01:30:55Z","updated_at":"2018-05-12T01:30:55Z","author_association":"OWNER","body":"Oh yes, sorry, I meant it would let people stay on 4.x for example and they wouldn't have to upgrade to 5.x just because strings change.\n\n\n\n\n--\n\n\nJosh Harms\n\n\n\n\n\n\n\nOn Fri, May 11, 2018 at 8:29 PM -0500, \"Clement Gutel\" <notifications@github.com> wrote:\n\n\n\n\n\n\n\n\n\n\n\n\nRight. I thought it was something along those lines, but in theory if the strings were in the same packages, adding strings should not be breaking change..\n\n\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly, view it on GitHub, or mute the thread.\n\n\n  \n  \n\n\n\n\n\n\n\n\n\n\n"}}
{"actor":{"display_login":"nozzlegear"}}