{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/176494502","pull_request_review_id":106208697,"id":176494502,"diff_hunk":"@@ -25,6 +25,12 @@ export interface IBreadcrumbProps extends React.Props<Breadcrumb> {\n    */\n   className?: string;\n \n+  /**\n+   * Render a custom divider in place of the default chevron '>'\n+   * as a custom JSX element\n+   */\n+  dividerAs?: JSX.Element;","path":"packages/office-ui-fabric-react/src/components/Breadcrumb/Breadcrumb.types.ts","position":8,"original_position":8,"commit_id":"ae755b4e6bac902ca24bf713bb78776d0929cbfe","original_commit_id":"ae755b4e6bac902ca24bf713bb78776d0929cbfe","user":{"login":"dzearing","id":1110944,"avatar_url":"https://avatars3.githubusercontent.com/u/1110944?v=4","gravatar_id":"","url":"https://api.github.com/users/dzearing","html_url":"https://github.com/dzearing","followers_url":"https://api.github.com/users/dzearing/followers","following_url":"https://api.github.com/users/dzearing/following{/other_user}","gists_url":"https://api.github.com/users/dzearing/gists{/gist_id}","starred_url":"https://api.github.com/users/dzearing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzearing/subscriptions","organizations_url":"https://api.github.com/users/dzearing/orgs","repos_url":"https://api.github.com/users/dzearing/repos","events_url":"https://api.github.com/users/dzearing/events{/privacy}","received_events_url":"https://api.github.com/users/dzearing/received_events","type":"User","site_admin":false},"body":"The props we pass in are important. But it doesn't mean that they can't use something else.\r\n\r\nFor example, your span case doesn't need the props:\r\n\r\n```\r\nconst divider = () => <span>*</span>;\r\n\r\n<Breadcrumb dividerAs={ divider } />\r\n```\r\nor\r\n```\r\n<Breadcrumb dividerAs=\"*\" />\r\n```\r\nor\r\n```\r\n<Breadcrumb dividerAs={ iconProps => <div>{ iconProps.iconName }</div> } />\r\n```\r\n","created_at":"2018-03-22T16:53:39Z","updated_at":"2018-03-22T16:53:39Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4317#discussion_r176494502","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/176494502"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4317#discussion_r176494502"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317"}},"in_reply_to_id":175653957},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317","id":176033987,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4317","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4317.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4317.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4317","number":4317,"state":"open","locked":false,"title":"Addressing Issue #1145 - Breadcrumb: Customize icon used","user":{"login":"oengusmacinog","id":3977969,"avatar_url":"https://avatars3.githubusercontent.com/u/3977969?v=4","gravatar_id":"","url":"https://api.github.com/users/oengusmacinog","html_url":"https://github.com/oengusmacinog","followers_url":"https://api.github.com/users/oengusmacinog/followers","following_url":"https://api.github.com/users/oengusmacinog/following{/other_user}","gists_url":"https://api.github.com/users/oengusmacinog/gists{/gist_id}","starred_url":"https://api.github.com/users/oengusmacinog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oengusmacinog/subscriptions","organizations_url":"https://api.github.com/users/oengusmacinog/orgs","repos_url":"https://api.github.com/users/oengusmacinog/repos","events_url":"https://api.github.com/users/oengusmacinog/events{/privacy}","received_events_url":"https://api.github.com/users/oengusmacinog/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [x] Addresses an existing issue: Fixes #1145 \r\n- [x] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\n\r\nAdded dividerAs prop to Breadcrumb component allowing the user to pass a custom JSX element to be used as the trail divider icon.\r\n","created_at":"2018-03-19T21:43:37Z","updated_at":"2018-03-22T16:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"175b32a3ce54909b0f6c4bb3e343b7789177cdcc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"micahgodbolt","id":1434956,"avatar_url":"https://avatars2.githubusercontent.com/u/1434956?v=4","gravatar_id":"","url":"https://api.github.com/users/micahgodbolt","html_url":"https://github.com/micahgodbolt","followers_url":"https://api.github.com/users/micahgodbolt/followers","following_url":"https://api.github.com/users/micahgodbolt/following{/other_user}","gists_url":"https://api.github.com/users/micahgodbolt/gists{/gist_id}","starred_url":"https://api.github.com/users/micahgodbolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahgodbolt/subscriptions","organizations_url":"https://api.github.com/users/micahgodbolt/orgs","repos_url":"https://api.github.com/users/micahgodbolt/repos","events_url":"https://api.github.com/users/micahgodbolt/events{/privacy}","received_events_url":"https://api.github.com/users/micahgodbolt/received_events","type":"User","site_admin":false},{"login":"erichdev","id":15041132,"avatar_url":"https://avatars1.githubusercontent.com/u/15041132?v=4","gravatar_id":"","url":"https://api.github.com/users/erichdev","html_url":"https://github.com/erichdev","followers_url":"https://api.github.com/users/erichdev/followers","following_url":"https://api.github.com/users/erichdev/following{/other_user}","gists_url":"https://api.github.com/users/erichdev/gists{/gist_id}","starred_url":"https://api.github.com/users/erichdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erichdev/subscriptions","organizations_url":"https://api.github.com/users/erichdev/orgs","repos_url":"https://api.github.com/users/erichdev/repos","events_url":"https://api.github.com/users/erichdev/events{/privacy}","received_events_url":"https://api.github.com/users/erichdev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4317/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/ae755b4e6bac902ca24bf713bb78776d0929cbfe","head":{"label":"oengusmacinog:breadcrumb-iconas-1145","ref":"breadcrumb-iconas-1145","sha":"ae755b4e6bac902ca24bf713bb78776d0929cbfe","user":{"login":"oengusmacinog","id":3977969,"avatar_url":"https://avatars3.githubusercontent.com/u/3977969?v=4","gravatar_id":"","url":"https://api.github.com/users/oengusmacinog","html_url":"https://github.com/oengusmacinog","followers_url":"https://api.github.com/users/oengusmacinog/followers","following_url":"https://api.github.com/users/oengusmacinog/following{/other_user}","gists_url":"https://api.github.com/users/oengusmacinog/gists{/gist_id}","starred_url":"https://api.github.com/users/oengusmacinog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oengusmacinog/subscriptions","organizations_url":"https://api.github.com/users/oengusmacinog/orgs","repos_url":"https://api.github.com/users/oengusmacinog/repos","events_url":"https://api.github.com/users/oengusmacinog/events{/privacy}","received_events_url":"https://api.github.com/users/oengusmacinog/received_events","type":"User","site_admin":false},"repo":{"id":117886046,"name":"office-ui-fabric-react","full_name":"oengusmacinog/office-ui-fabric-react","owner":{"login":"oengusmacinog","id":3977969,"avatar_url":"https://avatars3.githubusercontent.com/u/3977969?v=4","gravatar_id":"","url":"https://api.github.com/users/oengusmacinog","html_url":"https://github.com/oengusmacinog","followers_url":"https://api.github.com/users/oengusmacinog/followers","following_url":"https://api.github.com/users/oengusmacinog/following{/other_user}","gists_url":"https://api.github.com/users/oengusmacinog/gists{/gist_id}","starred_url":"https://api.github.com/users/oengusmacinog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oengusmacinog/subscriptions","organizations_url":"https://api.github.com/users/oengusmacinog/orgs","repos_url":"https://api.github.com/users/oengusmacinog/repos","events_url":"https://api.github.com/users/oengusmacinog/events{/privacy}","received_events_url":"https://api.github.com/users/oengusmacinog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oengusmacinog/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":true,"url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react","forks_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/oengusmacinog/office-ui-fabric-react/deployments","created_at":"2018-01-17T19:59:50Z","updated_at":"2018-03-19T22:15:17Z","pushed_at":"2018-03-20T19:56:28Z","git_url":"git://github.com/oengusmacinog/office-ui-fabric-react.git","ssh_url":"git@github.com:oengusmacinog/office-ui-fabric-react.git","clone_url":"https://github.com/oengusmacinog/office-ui-fabric-react.git","svn_url":"https://github.com/oengusmacinog/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":25029,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"ff76e427cc92a203779d6c227f002ef18fce720a","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2018-03-22T16:49:09Z","pushed_at":"2018-03-22T16:49:01Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"git@github.com:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric#/components","size":25370,"stargazers_count":2405,"watchers_count":2405,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":500,"mirror_url":null,"archived":false,"open_issues_count":489,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":500,"open_issues":489,"watchers":2405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/4317"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4317"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/4317/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/4317/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/ae755b4e6bac902ca24bf713bb78776d0929cbfe"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dzearing"}}