{"action":"created","issue":{"url":"https://api.github.com/repos/justanr/flask-allows/issues/42","repository_url":"https://api.github.com/repos/justanr/flask-allows","labels_url":"https://api.github.com/repos/justanr/flask-allows/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/justanr/flask-allows/issues/42/comments","events_url":"https://api.github.com/repos/justanr/flask-allows/issues/42/events","html_url":"https://github.com/justanr/flask-allows/issues/42","id":360570349,"node_id":"MDU6SXNzdWUzNjA1NzAzNDk=","number":42,"title":"Allows.fulfill always passes request as an arg","user":{"login":"cerealcable","id":573027,"node_id":"MDQ6VXNlcjU3MzAyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/573027?v=4","gravatar_id":"","url":"https://api.github.com/users/cerealcable","html_url":"https://github.com/cerealcable","followers_url":"https://api.github.com/users/cerealcable/followers","following_url":"https://api.github.com/users/cerealcable/following{/other_user}","gists_url":"https://api.github.com/users/cerealcable/gists{/gist_id}","starred_url":"https://api.github.com/users/cerealcable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerealcable/subscriptions","organizations_url":"https://api.github.com/users/cerealcable/orgs","repos_url":"https://api.github.com/users/cerealcable/repos","events_url":"https://api.github.com/users/cerealcable/events{/privacy}","received_events_url":"https://api.github.com/users/cerealcable/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-15T19:48:33Z","updated_at":"2018-09-25T06:50:51Z","closed_at":null,"author_association":"NONE","body":"My tests are enjoying a _few_ logs, which was rather confusing since I have never passed request in so...sure enough, [Allows.fulfill](https://github.com/justanr/flask-allows/blob/master/src/flask_allows/allows.py#L152) injects it and causes a DeprecationWarning.\r\n\r\n```\r\n/usr/local/lib/python3.6/site-packages/flask_allows/allows.py:156: DeprecationWarning: Passing request to requirements is now deprecated and will be removed in 1.0                                                                           \r\n  _call_requirement(r, identity, request) for r in all_requirements\r\n```\r\n\r\nMy class based Requirements is:\r\n```python\r\nclass HasPermission(Requirement):\r\n    def __init__(self, permission):\r\n        self.permission = permission\r\n\r\n    def fulfill(self, user):\r\n        return user.has_permission(self.permission)\r\n```"},"comment":{"url":"https://api.github.com/repos/justanr/flask-allows/issues/comments/424227154","html_url":"https://github.com/justanr/flask-allows/issues/42#issuecomment-424227154","issue_url":"https://api.github.com/repos/justanr/flask-allows/issues/42","id":424227154,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDIyNzE1NA==","user":{"login":"cerealcable","id":573027,"node_id":"MDQ6VXNlcjU3MzAyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/573027?v=4","gravatar_id":"","url":"https://api.github.com/users/cerealcable","html_url":"https://github.com/cerealcable","followers_url":"https://api.github.com/users/cerealcable/followers","following_url":"https://api.github.com/users/cerealcable/following{/other_user}","gists_url":"https://api.github.com/users/cerealcable/gists{/gist_id}","starred_url":"https://api.github.com/users/cerealcable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerealcable/subscriptions","organizations_url":"https://api.github.com/users/cerealcable/orgs","repos_url":"https://api.github.com/users/cerealcable/repos","events_url":"https://api.github.com/users/cerealcable/events{/privacy}","received_events_url":"https://api.github.com/users/cerealcable/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T06:50:51Z","updated_at":"2018-09-25T06:50:51Z","author_association":"NONE","body":"So I'm only seeing this in pytest, and when I run with `PYTHONWARNINGS=error::AllowsDeprecation` they disappear instead of raising exceptions like I was expecting which doesn't make a whole lot of sense. I've yet to see these messages outside of pytest however which is interesting."}}
{"actor":{"display_login":"cerealcable"}}