{"action":"created","issue":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/issues/199","repository_url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/issues/199/comments","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/issues/199/events","html_url":"https://github.com/terraform-providers/terraform-provider-kubernetes/pull/199","id":375610276,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MDE2Mjg4","number":199,"title":"Revert \"meta: Treat internal k8s annotations as invalid\"","user":{"login":"mbarrien","id":1753192,"node_id":"MDQ6VXNlcjE3NTMxOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1753192?v=4","gravatar_id":"","url":"https://api.github.com/users/mbarrien","html_url":"https://github.com/mbarrien","followers_url":"https://api.github.com/users/mbarrien/followers","following_url":"https://api.github.com/users/mbarrien/following{/other_user}","gists_url":"https://api.github.com/users/mbarrien/gists{/gist_id}","starred_url":"https://api.github.com/users/mbarrien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbarrien/subscriptions","organizations_url":"https://api.github.com/users/mbarrien/orgs","repos_url":"https://api.github.com/users/mbarrien/repos","events_url":"https://api.github.com/users/mbarrien/events{/privacy}","received_events_url":"https://api.github.com/users/mbarrien/received_events","type":"User","site_admin":false},"labels":[{"id":737832129,"node_id":"MDU6TGFiZWw3Mzc4MzIxMjk=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/labels/size/XS","name":"size/XS","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-30T17:34:15Z","updated_at":"2018-11-07T14:55:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/pulls/199","html_url":"https://github.com/terraform-providers/terraform-provider-kubernetes/pull/199","diff_url":"https://github.com/terraform-providers/terraform-provider-kubernetes/pull/199.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-kubernetes/pull/199.patch"},"body":"This reverts #50 and closes #60 by allowing \"internal\" annotations that have \"kubernetes.io\" in the domain name.\r\n\r\nExamples abound for which this \"feature\" breaks basic usage, such as with:\r\n\r\nhttps://kubernetes.io/docs/concepts/services-networking/service/#ssl-support-on-aws\r\nhttps://docs.microsoft.com/en-us/azure/aks/internal-lb\r\nhttps://kubernetes.io/docs/tasks/administer-cluster/change-default-storage-class/\r\nhttps://github.com/kubernetes-sigs/aws-alb-ingress-controller/blob/master/docs/ingress-resources.md#annotations\r\n\r\nFor 3rd party Kubernetes plugins, Kubernetes has no control over what annotation names they use, and many others have created custom annotations for their tools that end with kubernetes.io in the part before the slash, and for which the annotation is absolutely essential to get it working.\r\n\r\nThere was an argument made that this plugin is not meant to support alpha or beta features. The problem is these \"alpha\" or \"beta\" feature are heavily relied on in production by many users because of the long beta cycles and the the usefulness of those \"beta\" but in practice stable features. This provider should not be in the business of saying \"this annotation should not be supported because it's beta\"; let the developer/ops person decide.\r\n\r\nWith this over-protectiveness, people will start using direct calls to kubectl via null_resource local-execs; that's even more of a nightmare that lets people shoot themselves in the foot more than having the potential for a few broken annotations here and there (for which a good developer will notice the false changes in the plan, and eventually realize how to fix it).\r\n\r\nLet the engineers make their mistakes and trust them to figure it out; don't be so over-protective as to cripple core functionality. If necessary, put a big warning up saying \"you better know what you're doing\", but don't stop the innovation."},"comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/issues/comments/436650112","html_url":"https://github.com/terraform-providers/terraform-provider-kubernetes/pull/199#issuecomment-436650112","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-kubernetes/issues/199","id":436650112,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjY1MDExMg==","user":{"login":"willscripted","id":1069495,"node_id":"MDQ6VXNlcjEwNjk0OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1069495?v=4","gravatar_id":"","url":"https://api.github.com/users/willscripted","html_url":"https://github.com/willscripted","followers_url":"https://api.github.com/users/willscripted/followers","following_url":"https://api.github.com/users/willscripted/following{/other_user}","gists_url":"https://api.github.com/users/willscripted/gists{/gist_id}","starred_url":"https://api.github.com/users/willscripted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willscripted/subscriptions","organizations_url":"https://api.github.com/users/willscripted/orgs","repos_url":"https://api.github.com/users/willscripted/repos","events_url":"https://api.github.com/users/willscripted/events{/privacy}","received_events_url":"https://api.github.com/users/willscripted/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T14:55:36Z","updated_at":"2018-11-07T14:55:36Z","author_association":"NONE","body":":clap: :clap: thank you @mbarrien \r\n\r\nThis PR unblocks our transition to terraform-defined kubernetes load balancers in eks.\r\n\r\nIs the gist of #50 this: Terraform is not the only actor annotating kubernetes resources. Since there are others, reality drifts away from terraform state in acceptable way? But terraform sees diffs and trys to \"correct\" them by resetting the annotations set by other actors. To avoid this overwrite of legitimate drifted state, #50 flat-out prohibits use of any \"risky\" annotations.\r\n\r\nDid I get that right @mbarrien / @radeksimko ?"}}
{"actor":{"display_login":"willscripted"}}