{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/2432","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/2432/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/2432/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/2432/events","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/2432","id":393111933,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjIyODE2","number":2432,"title":"Merge 2.9.0 changes back to dev","user":{"login":"ahoying","id":4105300,"node_id":"MDQ6VXNlcjQxMDUzMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/4105300?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoying","html_url":"https://github.com/ahoying","followers_url":"https://api.github.com/users/ahoying/followers","following_url":"https://api.github.com/users/ahoying/following{/other_user}","gists_url":"https://api.github.com/users/ahoying/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoying/subscriptions","organizations_url":"https://api.github.com/users/ahoying/orgs","repos_url":"https://api.github.com/users/ahoying/repos","events_url":"https://api.github.com/users/ahoying/events{/privacy}","received_events_url":"https://api.github.com/users/ahoying/received_events","type":"User","site_admin":false},"labels":[{"id":769538991,"node_id":"MDU6TGFiZWw3Njk1Mzg5OTE=","url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/labels/status:%20in-progress","name":"status: in-progress","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/milestones/19","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/milestone/19","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/milestones/19/labels","id":3814832,"node_id":"MDk6TWlsZXN0b25lMzgxNDgzMg==","number":19,"title":"v2.10.0","description":"","creator":{"login":"jjawad-google","id":38964959,"node_id":"MDQ6VXNlcjM4OTY0OTU5","avatar_url":"https://avatars2.githubusercontent.com/u/38964959?v=4","gravatar_id":"","url":"https://api.github.com/users/jjawad-google","html_url":"https://github.com/jjawad-google","followers_url":"https://api.github.com/users/jjawad-google/followers","following_url":"https://api.github.com/users/jjawad-google/following{/other_user}","gists_url":"https://api.github.com/users/jjawad-google/gists{/gist_id}","starred_url":"https://api.github.com/users/jjawad-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjawad-google/subscriptions","organizations_url":"https://api.github.com/users/jjawad-google/orgs","repos_url":"https://api.github.com/users/jjawad-google/repos","events_url":"https://api.github.com/users/jjawad-google/events{/privacy}","received_events_url":"https://api.github.com/users/jjawad-google/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2018-11-12T16:16:18Z","updated_at":"2018-12-20T16:09:31Z","due_on":"2019-01-15T08:00:00Z","closed_at":null},"comments":0,"created_at":"2018-12-20T16:09:31Z","updated_at":"2018-12-20T16:09:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/pulls/2432","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/2432","diff_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/2432.diff","patch_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/2432.patch"},"body":"Thanks for opening a Pull Request!\r\n\r\nHere's a handy checklist to ensure your PR goes smoothly.\r\n\r\n- [x] I signed Google's [Contributor License Agreement](https://opensource.google.com/docs/cla/)\r\n- [x] My code conforms to Google's [python style](https://google.github.io/styleguide/pyguide.html).\r\n- [x] My PR at a minimum doesn't decrease unit-test coverage (if applicable).\r\n- [x] My PR has been functionally tested.\r\n- [x] All of the [unit-tests](https://forsetisecurity.org/docs/latest/develop/dev/testing.html) still pass.\r\n- [x] Running `pylint --rcfile=pylintrc` passes.\r\n\r\nThese guidelines and more can be found in our [contributing guidelines](https://github.com/GoogleCloudPlatform/forseti-security/blob/master/.github/CONTRIBUTING.md).\r\n"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/comments/449049575","html_url":"https://github.com/GoogleCloudPlatform/forseti-security/pull/2432#issuecomment-449049575","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/forseti-security/issues/2432","id":449049575,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTA0OTU3NQ==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-20T16:09:36Z","updated_at":"2018-12-20T16:09:36Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432?src=pr&el=h1) Report\n> Merging [#2432](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432?src=pr&el=desc) into [dev](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/commit/c205b6a8f5d96240aacbe9f99aeecbf3b2d398ed?src=pr&el=desc) will **decrease** coverage by `0.02%`.\n> The diff coverage is `84.61%`.\n\n\n```diff\n@@            Coverage Diff             @@\n##              dev    #2432      +/-   ##\n==========================================\n- Coverage   88.57%   88.54%   -0.03%     \n==========================================\n  Files         180      180              \n  Lines       14103    14087      -16     \n==========================================\n- Hits        12492    12474      -18     \n- Misses       1611     1613       +2\n```\n\n| [Impacted Files](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [.../cloud/forseti/scanner/scanners/ke\\_base\\_scanner.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2Nhbm5lci9zY2FubmVycy9rZV9iYXNlX3NjYW5uZXIucHk=) | `96.72% <ø> (ø)` | :arrow_up: |\n| [...d/forseti/scanner/audit/ke\\_version\\_rules\\_engine.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2Nhbm5lci9hdWRpdC9rZV92ZXJzaW9uX3J1bGVzX2VuZ2luZS5weQ==) | `88.35% <ø> (ø)` | :arrow_up: |\n| [...gle/cloud/forseti/scanner/audit/ke\\_rules\\_engine.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2Nhbm5lci9hdWRpdC9rZV9ydWxlc19lbmdpbmUucHk=) | `85.82% <ø> (ø)` | :arrow_up: |\n| [...cloud/forseti/services/inventory/base/resources.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2VydmljZXMvaW52ZW50b3J5L2Jhc2UvcmVzb3VyY2VzLnB5) | `85.77% <100%> (ø)` | :arrow_up: |\n| [google/cloud/forseti/common/gcp\\_type/ke\\_cluster.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvY29tbW9uL2djcF90eXBlL2tlX2NsdXN0ZXIucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [google/cloud/forseti/\\_\\_init\\_\\_.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvX19pbml0X18ucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [.../forseti/services/inventory/base/cai\\_gcp\\_client.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2VydmljZXMvaW52ZW50b3J5L2Jhc2UvY2FpX2djcF9jbGllbnQucHk=) | `91.56% <50%> (-0.54%)` | :arrow_down: |\n| [...e/cloud/forseti/scanner/audit/lien\\_rules\\_engine.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2Nhbm5lci9hdWRpdC9saWVuX3J1bGVzX2VuZ2luZS5weQ==) | `89.74% <0%> (-0.26%)` | :arrow_down: |\n| [google/cloud/forseti/common/util/file\\_loader.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvY29tbW9uL3V0aWwvZmlsZV9sb2FkZXIucHk=) | `91.07% <0%> (-0.16%)` | :arrow_down: |\n| [...oogle/cloud/forseti/services/inventory/base/gcp.py](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree#diff-Z29vZ2xlL2Nsb3VkL2ZvcnNldGkvc2VydmljZXMvaW52ZW50b3J5L2Jhc2UvZ2NwLnB5) | `96.48% <0%> (-0.04%)` | :arrow_down: |\n| ... and [4 more](https://codecov.io/gh/GoogleCloudPlatform/forseti-security/pull/2432/diff?src=pr&el=tree-more) | |\n\n"}}
{"actor":{"display_login":"codecov"}}