{"action":"created","issue":{"url":"https://api.github.com/repos/web-platform-tests/wpt/issues/9424","repository_url":"https://api.github.com/repos/web-platform-tests/wpt","labels_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/9424/labels{/name}","comments_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/9424/comments","events_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/9424/events","html_url":"https://github.com/web-platform-tests/wpt/pull/9424","id":295076576,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3NjQ3NDk3","number":9424,"title":" Rewrite RTC ICE and DTLS transport tests with alternative dependencies ","user":{"login":"soareschen","id":97665,"node_id":"MDQ6VXNlcjk3NjY1","avatar_url":"https://avatars3.githubusercontent.com/u/97665?v=4","gravatar_id":"","url":"https://api.github.com/users/soareschen","html_url":"https://github.com/soareschen","followers_url":"https://api.github.com/users/soareschen/followers","following_url":"https://api.github.com/users/soareschen/following{/other_user}","gists_url":"https://api.github.com/users/soareschen/gists{/gist_id}","starred_url":"https://api.github.com/users/soareschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soareschen/subscriptions","organizations_url":"https://api.github.com/users/soareschen/orgs","repos_url":"https://api.github.com/users/soareschen/repos","events_url":"https://api.github.com/users/soareschen/events{/privacy}","received_events_url":"https://api.github.com/users/soareschen/received_events","type":"User","site_admin":false},"labels":[{"id":80134264,"node_id":"MDU6TGFiZWw4MDEzNDI2NA==","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/webrtc","name":"webrtc","color":"ededed","default":false},{"id":79824268,"node_id":"MDU6TGFiZWw3OTgyNDI2OA==","url":"https://api.github.com/repos/web-platform-tests/wpt/labels/wg-webrtc","name":"wg-webrtc","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-07T10:07:50Z","updated_at":"2018-11-03T07:13:47Z","closed_at":"2018-11-03T07:13:47Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/web-platform-tests/wpt/pulls/9424","html_url":"https://github.com/web-platform-tests/wpt/pull/9424","diff_url":"https://github.com/web-platform-tests/wpt/pull/9424.diff","patch_url":"https://github.com/web-platform-tests/wpt/pull/9424.patch"},"body":"Fixes #9110 and #9111.\r\n\r\nThis PR rewrites the tests for RTCDtlsTransport and RTCIceTransport to have separate tests for getting the transports from both RTP sender/receiver and SCTP transport. The common parts of the assertions are factored out into separate functions so that they can be tested in multiple test cases.\r\n\r\nI have tried to write the tests as dependency-neutral as possible, and test this specifically on Microsoft Edge 42.17083. However there are still some issues that cause the tests to still fail on Edge:\r\n\r\n- The RTCPeerConnection() constructor on Edge is non compliant and require minimally `new RTCPeerConnection({ iceServers: [] })` to work. On my Windows machine none of the WPT WebRTC tests that use `new RTCPeerConnection()` would pass. I made local modification to all constructors so that the tests can at least run on Edge locally.\r\n\r\n- Edge only supports the legacy `addStream()` method and not `addTrack()` and `addTransceiver()`. I have specifically added a `addTrackOrTransceiver()` helper function that calls either `addTransceiver()`, `addTrack()`, or even `addStream()` so that we can continue testing the higher level features.\r\n\r\n- Edge does not implement `getSenders()` and `getReceivers()`. This makes it impossible to retrieve the `RTCRtpSender` and `RTCRtpReceiver` instances so that we can get the DTLS and ICE transport objects. The workaround of getting hold of an `RTCRtpSender` using `addTrack()` also does not work, because Edge only implements `addStream()` which returns only `undefined`.\r\n\r\nSo despite my best effort I am unable to tweak the tests to pass on any of the current browsers. :( (perhaps the methodology also doesn't feel right)\r\n\r\nIf there are internal builds of browsers that have implemented the new features, please do run the tests and feedback on the test result is appreciated.\n\n<!-- Reviewable:start -->\n\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/web-platform-tests/wpt/issues/comments/435566494","html_url":"https://github.com/web-platform-tests/wpt/pull/9424#issuecomment-435566494","issue_url":"https://api.github.com/repos/web-platform-tests/wpt/issues/9424","id":435566494,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTU2NjQ5NA==","user":{"login":"soareschen","id":97665,"node_id":"MDQ6VXNlcjk3NjY1","avatar_url":"https://avatars3.githubusercontent.com/u/97665?v=4","gravatar_id":"","url":"https://api.github.com/users/soareschen","html_url":"https://github.com/soareschen","followers_url":"https://api.github.com/users/soareschen/followers","following_url":"https://api.github.com/users/soareschen/following{/other_user}","gists_url":"https://api.github.com/users/soareschen/gists{/gist_id}","starred_url":"https://api.github.com/users/soareschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soareschen/subscriptions","organizations_url":"https://api.github.com/users/soareschen/orgs","repos_url":"https://api.github.com/users/soareschen/repos","events_url":"https://api.github.com/users/soareschen/events{/privacy}","received_events_url":"https://api.github.com/users/soareschen/received_events","type":"User","site_admin":false},"created_at":"2018-11-03T07:13:47Z","updated_at":"2018-11-03T07:13:47Z","author_association":"CONTRIBUTOR","body":"Closing this with #13886 as continuation."}}
{"actor":{"display_login":"soareschen"}}