{"action":"closed","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/632","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/632/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/632/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/632/events","html_url":"https://github.com/StrikeNP/trac_test/issues/632","id":334661510,"node_id":"MDU6SXNzdWUzMzQ2NjE1MTA=","number":632,"title":"Create subroutine to calculate thlp2_rad (Trac #632)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":971577014,"node_id":"MDU6TGFiZWw5NzE1NzcwMTQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":971577274,"node_id":"MDU6TGFiZWw5NzE1NzcyNzQ=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":971576851,"node_id":"MDU6TGFiZWw5NzE1NzY4NTE=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":971588502,"node_id":"MDU6TGFiZWw5NzE1ODg1MDI=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/schemena@uwm.edu","name":"schemena@uwm.edu","color":"FFFFFF","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":48,"created_at":"2018-06-21T21:18:28Z","updated_at":"2018-06-23T15:46:06Z","closed_at":"2018-06-23T15:46:06Z","author_association":"OWNER","body":"\n**Introduction**\n\nI notice that the contribution of [http://www.larson-group.com/internal/COAMPS_LES_BUDGET_PLOTS/ radiative cooling to thlp2 is large in some cases].  We should try to model this term in CLUBB.\n\n**Technical spec**\n\nWe need to calculate thlp2_rad and then add it to thlp2_forcing.  I've written some code given in attachment:thlp2_rad_code.diff.  But we need to do the following:\n\n * Refactor into a subroutine called calculate_thlp2_rad.\n\n * Surround the call to the subroutine with a flag l_calc_thlp2_rad.\n\n * Replace \"1.0\" with a variable called thlp2_rad_coef and add it to tunable_parameters.F90 and tunable_parameters.in.  \n\n * Replace \"0.05\" with a variable called thlp2_rad_cloud_frac_thresh and add it to tunable_parameters.F90 and tunable_parameters.in.\n\n * Whatever else is needed to improve the software engineering.\n\n**Tests**\n\nSome example plots are in ticket:622.  I think we want bit-for-bit identical results from before and after the code has been turned into a subroutine.\n\nAttachments:\n\n[plot_explicit_ta_configs.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_explicit_ta_configs.maff)\n[plot_new_pdf_config_1_plot_2.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_config_1_plot_2.maff)\n[plot_combo_pdf_run_3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_combo_pdf_run_3.maff)\n[plot_input_fields_rtp3_thlp3_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_input_fields_rtp3_thlp3_1.maff)\n[plot_new_pdf_20180522_test_1.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_new_pdf_20180522_test_1.maff)\n[plot_attempts_8_10.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempts_8_10.maff)\n[plot_attempt_8_only.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_attempt_8_only.maff)\n[plot_beta_1p3.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3.maff)\n[plot_beta_1p3_all.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/trac_test/822/plot_beta_1p3_all.maff)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/632\n```json\n{\n    \"status\": \"closed\", \n    \"changetime\": \"2014-06-19T13:36:09\", \n    \"description\": \"\\n'''Introduction'''\\n\\nI notice that the contribution of [http://www.larson-group.com/internal/COAMPS_LES_BUDGET_PLOTS/ radiative cooling to thlp2 is large in some cases].  We should try to model this term in CLUBB.\\n\\n'''Technical spec'''\\n\\nWe need to calculate thlp2_rad and then add it to thlp2_forcing.  I've written some code given in attachment:thlp2_rad_code.diff.  But we need to do the following:\\n\\n * Refactor into a subroutine called calculate_thlp2_rad.\\n\\n * Surround the call to the subroutine with a flag l_calc_thlp2_rad.\\n\\n * Replace \\\"1.0\\\" with a variable called thlp2_rad_coef and add it to tunable_parameters.F90 and tunable_parameters.in.  \\n\\n * Replace \\\"0.05\\\" with a variable called thlp2_rad_cloud_frac_thresh and add it to tunable_parameters.F90 and tunable_parameters.in.\\n\\n * Whatever else is needed to improve the software engineering.\\n\\n'''Tests'''\\n\\nSome example plots are in ticket:622.  I think we want bit-for-bit identical results from before and after the code has been turned into a subroutine.\", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu\", \n    \"resolution\": \"fixed\", \n    \"_ts\": \"1403184969264016\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Create subroutine to calculate thlp2_rad\", \n    \"priority\": \"minor\", \n    \"keywords\": \"\", \n    \"time\": \"2013-11-14T19:10:25\", \n    \"milestone\": \"\", \n    \"owner\": \"schemena@uwm.edu\", \n    \"type\": \"enhancement\"\n}\n```\n"}}
{"actor":{"display_login":"StrikeNP"}}