{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/240120601","pull_request_review_id":183075125,"id":240120601,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDEyMDYwMQ==","diff_hunk":"@@ -18,12 +18,14 @@\n #if defined(COMPONENT_SPM_MAILBOX)\n \n #include \"ipc_queue.h\"\n+#include \"sleep_api.h\"\n extern ipc_consumer_queue_t *cons_queue;\n // this is the dispatcher thread for dual-chip systems\n int main(void)\n {\n     while (true) {\n         ipc_queue_drain(cons_queue);\n+        hal_deepsleep();","path":"components/TARGET_PSA/spm/COMPONENT_SPE/spm_main.c","position":11,"original_position":11,"commit_id":"d10667c74990b421844ff3655e6c7ddd9ca0c7fb","original_commit_id":"d10667c74990b421844ff3655e6c7ddd9ca0c7fb","user":{"login":"kjbracey-arm","id":11025917,"node_id":"MDQ6VXNlcjExMDI1OTE3","avatar_url":"https://avatars3.githubusercontent.com/u/11025917?v=4","gravatar_id":"","url":"https://api.github.com/users/kjbracey-arm","html_url":"https://github.com/kjbracey-arm","followers_url":"https://api.github.com/users/kjbracey-arm/followers","following_url":"https://api.github.com/users/kjbracey-arm/following{/other_user}","gists_url":"https://api.github.com/users/kjbracey-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbracey-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbracey-arm/subscriptions","organizations_url":"https://api.github.com/users/kjbracey-arm/orgs","repos_url":"https://api.github.com/users/kjbracey-arm/repos","events_url":"https://api.github.com/users/kjbracey-arm/events{/privacy}","received_events_url":"https://api.github.com/users/kjbracey-arm/received_events","type":"User","site_admin":false},"body":"Whatever the problem is, that isn't the solution.\r\n\r\nWhen RTX is idle, deep sleep should occur as long as no-one is holding the deep sleep lock, and MBED_TICKLESS and DEVICE_LPTICKER are enabled. Check those factors first.\r\n\r\nNo normal code should ever be calling `hal_sleep` or `hal_deepsleep` manually - it interferes with the RTOS.","created_at":"2018-12-10T08:41:41Z","updated_at":"2018-12-10T08:42:52Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/9023#discussion_r240120601","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/240120601"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/9023#discussion_r240120601"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023"}},"in_reply_to_id":240050918},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023","id":237142973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTQyOTcz","html_url":"https://github.com/ARMmbed/mbed-os/pull/9023","diff_url":"https://github.com/ARMmbed/mbed-os/pull/9023.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/9023.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9023","number":9023,"state":"open","locked":false,"title":"PSA - Add deepsleep call to secure dispatcher","user":{"login":"orenc17","id":17570086,"node_id":"MDQ6VXNlcjE3NTcwMDg2","avatar_url":"https://avatars0.githubusercontent.com/u/17570086?v=4","gravatar_id":"","url":"https://api.github.com/users/orenc17","html_url":"https://github.com/orenc17","followers_url":"https://api.github.com/users/orenc17/followers","following_url":"https://api.github.com/users/orenc17/following{/other_user}","gists_url":"https://api.github.com/users/orenc17/gists{/gist_id}","starred_url":"https://api.github.com/users/orenc17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orenc17/subscriptions","organizations_url":"https://api.github.com/users/orenc17/orgs","repos_url":"https://api.github.com/users/orenc17/repos","events_url":"https://api.github.com/users/orenc17/events{/privacy}","received_events_url":"https://api.github.com/users/orenc17/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n* Make the secure chip sleep between calls\r\n* Regenerate all the prebuilt binaries\r\n* Sleep tests pass (on release)\r\n<!-- \r\n    Required\r\n    Add here detailed changes summary, testing results, dependencies \r\n    Good example: https://os.mbed.com/docs/latest/reference/workflow.html (Pull request template)\r\n-->\r\n\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [X] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n@alzix ","created_at":"2018-12-09T17:00:37Z","updated_at":"2018-12-10T08:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c62f092d60762bd31a195fd70bdbb8cd56a0365b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9023/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/d10667c74990b421844ff3655e6c7ddd9ca0c7fb","head":{"label":"kfnta:sleep_fix","ref":"sleep_fix","sha":"d10667c74990b421844ff3655e6c7ddd9ca0c7fb","user":{"login":"kfnta","id":23094717,"node_id":"MDQ6VXNlcjIzMDk0NzE3","avatar_url":"https://avatars0.githubusercontent.com/u/23094717?v=4","gravatar_id":"","url":"https://api.github.com/users/kfnta","html_url":"https://github.com/kfnta","followers_url":"https://api.github.com/users/kfnta/followers","following_url":"https://api.github.com/users/kfnta/following{/other_user}","gists_url":"https://api.github.com/users/kfnta/gists{/gist_id}","starred_url":"https://api.github.com/users/kfnta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfnta/subscriptions","organizations_url":"https://api.github.com/users/kfnta/orgs","repos_url":"https://api.github.com/users/kfnta/repos","events_url":"https://api.github.com/users/kfnta/events{/privacy}","received_events_url":"https://api.github.com/users/kfnta/received_events","type":"User","site_admin":false},"repo":{"id":126805067,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4MDUwNjc=","name":"mbed-os","full_name":"kfnta/mbed-os","private":false,"owner":{"login":"kfnta","id":23094717,"node_id":"MDQ6VXNlcjIzMDk0NzE3","avatar_url":"https://avatars0.githubusercontent.com/u/23094717?v=4","gravatar_id":"","url":"https://api.github.com/users/kfnta","html_url":"https://github.com/kfnta","followers_url":"https://api.github.com/users/kfnta/followers","following_url":"https://api.github.com/users/kfnta/following{/other_user}","gists_url":"https://api.github.com/users/kfnta/gists{/gist_id}","starred_url":"https://api.github.com/users/kfnta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfnta/subscriptions","organizations_url":"https://api.github.com/users/kfnta/orgs","repos_url":"https://api.github.com/users/kfnta/repos","events_url":"https://api.github.com/users/kfnta/events{/privacy}","received_events_url":"https://api.github.com/users/kfnta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kfnta/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/kfnta/mbed-os","forks_url":"https://api.github.com/repos/kfnta/mbed-os/forks","keys_url":"https://api.github.com/repos/kfnta/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kfnta/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kfnta/mbed-os/teams","hooks_url":"https://api.github.com/repos/kfnta/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/kfnta/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/kfnta/mbed-os/events","assignees_url":"https://api.github.com/repos/kfnta/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/kfnta/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/kfnta/mbed-os/tags","blobs_url":"https://api.github.com/repos/kfnta/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kfnta/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kfnta/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/kfnta/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kfnta/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/kfnta/mbed-os/languages","stargazers_url":"https://api.github.com/repos/kfnta/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/kfnta/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/kfnta/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/kfnta/mbed-os/subscription","commits_url":"https://api.github.com/repos/kfnta/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/kfnta/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/kfnta/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/kfnta/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/kfnta/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/kfnta/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kfnta/mbed-os/merges","archive_url":"https://api.github.com/repos/kfnta/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kfnta/mbed-os/downloads","issues_url":"https://api.github.com/repos/kfnta/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/kfnta/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/kfnta/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/kfnta/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kfnta/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/kfnta/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/kfnta/mbed-os/deployments","created_at":"2018-03-26T09:26:00Z","updated_at":"2018-11-28T12:37:10Z","pushed_at":"2018-12-09T16:57:57Z","git_url":"git://github.com/kfnta/mbed-os.git","ssh_url":"git@github.com:kfnta/mbed-os.git","clone_url":"https://github.com/kfnta/mbed-os.git","svn_url":"https://github.com/kfnta/mbed-os","homepage":"https://mbed.com","size":252417,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":4,"watchers":1,"default_branch":"dev-spm"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"9d28c3f767113b83f5066278b30b375ac554300a","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-12-10T08:08:43Z","pushed_at":"2018-12-10T08:15:44Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":248600,"stargazers_count":2101,"watchers_count":2101,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1701,"mirror_url":null,"archived":false,"open_issues_count":427,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1701,"open_issues":427,"watchers":2101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/9023"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9023"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/9023/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/9023/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/d10667c74990b421844ff3655e6c7ddd9ca0c7fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kjbracey-arm"}}