{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/comments/188796638","pull_request_review_id":120847191,"id":188796638,"diff_hunk":"@@ -545,19 +584,42 @@ var CloudDownloadsView = {\n         // Prepare for future downloads move to Download Folder by checking\n         // if Download folder exists in cloud provider folder, if not create one\n         CloudDownloadsInternal.checkProviderDownloadFolder();\n+\n+        // Once opted-in, set observers to send subsequent download pref changes to telemetry\n+        Services.prefs.addObserver(\"browser.download.folderList\", CloudDownloadsInternal.downloadPrefObserve);\n+        Services.prefs.addObserver(\"browser.download.useDownloadDir\", CloudDownloadsInternal.downloadPrefObserve);","path":"webextension/privileged/ui/CloudDownloadsView.jsm","position":123,"original_position":123,"commit_id":"623af74a032c05432dc970808a80c0a3cbd1d631","original_commit_id":"623af74a032c05432dc970808a80c0a3cbd1d631","user":{"login":"gijsk","id":375983,"avatar_url":"https://avatars3.githubusercontent.com/u/375983?v=4","gravatar_id":"","url":"https://api.github.com/users/gijsk","html_url":"https://github.com/gijsk","followers_url":"https://api.github.com/users/gijsk/followers","following_url":"https://api.github.com/users/gijsk/following{/other_user}","gists_url":"https://api.github.com/users/gijsk/gists{/gist_id}","starred_url":"https://api.github.com/users/gijsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gijsk/subscriptions","organizations_url":"https://api.github.com/users/gijsk/orgs","repos_url":"https://api.github.com/users/gijsk/repos","events_url":"https://api.github.com/users/gijsk/events{/privacy}","received_events_url":"https://api.github.com/users/gijsk/received_events","type":"User","site_admin":false},"body":"You never remove these preference observers.\r\n\r\nIt's probably easier to just piggyback on the existing lazy preference getter we have for this, and check in the pref update callback whether the user has opted in (ie whether we've saved a prompt response). You'd need to add another lazy pref getter for the other pref though.","created_at":"2018-05-16T22:58:47Z","updated_at":"2018-05-16T23:00:45Z","html_url":"https://github.com/mozilla/shield-cloudstorage/pull/28#discussion_r188796638","pull_request_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/comments/188796638"},"html":{"href":"https://github.com/mozilla/shield-cloudstorage/pull/28#discussion_r188796638"},"pull_request":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28","id":185340301,"html_url":"https://github.com/mozilla/shield-cloudstorage/pull/28","diff_url":"https://github.com/mozilla/shield-cloudstorage/pull/28.diff","patch_url":"https://github.com/mozilla/shield-cloudstorage/pull/28.patch","issue_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues/28","number":28,"state":"open","locked":false,"title":"Integrate Cloud storage web extension with shield utils","user":{"login":"punamdahiya","id":597734,"avatar_url":"https://avatars1.githubusercontent.com/u/597734?v=4","gravatar_id":"","url":"https://api.github.com/users/punamdahiya","html_url":"https://github.com/punamdahiya","followers_url":"https://api.github.com/users/punamdahiya/followers","following_url":"https://api.github.com/users/punamdahiya/following{/other_user}","gists_url":"https://api.github.com/users/punamdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/punamdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punamdahiya/subscriptions","organizations_url":"https://api.github.com/users/punamdahiya/orgs","repos_url":"https://api.github.com/users/punamdahiya/repos","events_url":"https://api.github.com/users/punamdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/punamdahiya/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-02T05:42:09Z","updated_at":"2018-05-16T23:00:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5bfaa1d3659067739b9c9fd55d187355cf22e38","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gregglind","id":163983,"avatar_url":"https://avatars2.githubusercontent.com/u/163983?v=4","gravatar_id":"","url":"https://api.github.com/users/gregglind","html_url":"https://github.com/gregglind","followers_url":"https://api.github.com/users/gregglind/followers","following_url":"https://api.github.com/users/gregglind/following{/other_user}","gists_url":"https://api.github.com/users/gregglind/gists{/gist_id}","starred_url":"https://api.github.com/users/gregglind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregglind/subscriptions","organizations_url":"https://api.github.com/users/gregglind/orgs","repos_url":"https://api.github.com/users/gregglind/repos","events_url":"https://api.github.com/users/gregglind/events{/privacy}","received_events_url":"https://api.github.com/users/gregglind/received_events","type":"User","site_admin":false},{"login":"motin","id":793037,"avatar_url":"https://avatars0.githubusercontent.com/u/793037?v=4","gravatar_id":"","url":"https://api.github.com/users/motin","html_url":"https://github.com/motin","followers_url":"https://api.github.com/users/motin/followers","following_url":"https://api.github.com/users/motin/following{/other_user}","gists_url":"https://api.github.com/users/motin/gists{/gist_id}","starred_url":"https://api.github.com/users/motin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/motin/subscriptions","organizations_url":"https://api.github.com/users/motin/orgs","repos_url":"https://api.github.com/users/motin/repos","events_url":"https://api.github.com/users/motin/events{/privacy}","received_events_url":"https://api.github.com/users/motin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28/commits","review_comments_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28/comments","review_comment_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues/28/comments","statuses_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/statuses/623af74a032c05432dc970808a80c0a3cbd1d631","head":{"label":"punamdahiya:cloud-storage-web-ext-shield-utils","ref":"cloud-storage-web-ext-shield-utils","sha":"623af74a032c05432dc970808a80c0a3cbd1d631","user":{"login":"punamdahiya","id":597734,"avatar_url":"https://avatars1.githubusercontent.com/u/597734?v=4","gravatar_id":"","url":"https://api.github.com/users/punamdahiya","html_url":"https://github.com/punamdahiya","followers_url":"https://api.github.com/users/punamdahiya/followers","following_url":"https://api.github.com/users/punamdahiya/following{/other_user}","gists_url":"https://api.github.com/users/punamdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/punamdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punamdahiya/subscriptions","organizations_url":"https://api.github.com/users/punamdahiya/orgs","repos_url":"https://api.github.com/users/punamdahiya/repos","events_url":"https://api.github.com/users/punamdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/punamdahiya/received_events","type":"User","site_admin":false},"repo":{"id":131802973,"name":"shield-cloudstorage","full_name":"punamdahiya/shield-cloudstorage","owner":{"login":"punamdahiya","id":597734,"avatar_url":"https://avatars1.githubusercontent.com/u/597734?v=4","gravatar_id":"","url":"https://api.github.com/users/punamdahiya","html_url":"https://github.com/punamdahiya","followers_url":"https://api.github.com/users/punamdahiya/followers","following_url":"https://api.github.com/users/punamdahiya/following{/other_user}","gists_url":"https://api.github.com/users/punamdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/punamdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punamdahiya/subscriptions","organizations_url":"https://api.github.com/users/punamdahiya/orgs","repos_url":"https://api.github.com/users/punamdahiya/repos","events_url":"https://api.github.com/users/punamdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/punamdahiya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/punamdahiya/shield-cloudstorage","description":"Add-on for cloud storage shield experiment","fork":true,"url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage","forks_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/forks","keys_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/teams","hooks_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/hooks","issue_events_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/issues/events{/number}","events_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/events","assignees_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/assignees{/user}","branches_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/branches{/branch}","tags_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/tags","blobs_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/languages","stargazers_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/stargazers","contributors_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/contributors","subscribers_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/subscribers","subscription_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/subscription","commits_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/contents/{+path}","compare_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/merges","archive_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/downloads","issues_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/issues{/number}","pulls_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/labels{/name}","releases_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/releases{/id}","deployments_url":"https://api.github.com/repos/punamdahiya/shield-cloudstorage/deployments","created_at":"2018-05-02T05:35:55Z","updated_at":"2018-05-02T05:35:57Z","pushed_at":"2018-05-16T21:14:01Z","git_url":"git://github.com/punamdahiya/shield-cloudstorage.git","ssh_url":"git@github.com:punamdahiya/shield-cloudstorage.git","clone_url":"https://github.com/punamdahiya/shield-cloudstorage.git","svn_url":"https://github.com/punamdahiya/shield-cloudstorage","homepage":"","size":177,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"9f801d74a28d87f05cae53a771d19e96109f0dd1","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":103305192,"name":"shield-cloudstorage","full_name":"mozilla/shield-cloudstorage","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/shield-cloudstorage","description":"Add-on for cloud storage shield experiment","fork":false,"url":"https://api.github.com/repos/mozilla/shield-cloudstorage","forks_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/forks","keys_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/teams","hooks_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/hooks","issue_events_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/events","assignees_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/tags","blobs_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/languages","stargazers_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/stargazers","contributors_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/contributors","subscribers_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/subscribers","subscription_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/subscription","commits_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/merges","archive_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/downloads","issues_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/shield-cloudstorage/deployments","created_at":"2017-09-12T18:09:46Z","updated_at":"2018-05-11T00:54:04Z","pushed_at":"2018-05-16T21:14:03Z","git_url":"git://github.com/mozilla/shield-cloudstorage.git","ssh_url":"git@github.com:mozilla/shield-cloudstorage.git","clone_url":"https://github.com/mozilla/shield-cloudstorage.git","svn_url":"https://github.com/mozilla/shield-cloudstorage","homepage":"","size":110,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28"},"html":{"href":"https://github.com/mozilla/shield-cloudstorage/pull/28"},"issue":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues/28"},"comments":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/shield-cloudstorage/statuses/623af74a032c05432dc970808a80c0a3cbd1d631"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gijsk"}}