{"push_id":2686707820,"size":1,"distinct_size":1,"ref":"refs/heads/zcm/class_for_object_quoting","head":"dcc202c98e6f8db4538eed50aacc861a92600133","before":"dfd6de10dbeb2a2fbb3eda55aba1bd5edf2a124d","commits":[{"sha":"dcc202c98e6f8db4538eed50aacc861a92600133","author":{"name":"Zach Marine","email":"6d87d148500711b983de3e472dea4665edae012a@gmail.com"},"message":"Create way to convert spec strings to ObjectNames\n\nAll lists within the owns and privileges subdicts will be converted to\nObjectNames. If there are any empty entries, e.g.:\n\n    roleA:\n        owns:\n            tables:\n\n    ...\n\nThen these empty entries get converted to None by PyYAML. Rather than\noverride this, I'm leaving this behavior as:\n    1) It adds a some complexity to try to guard against Nones in a\n    bunch of spots.\n    2) More than the complexity, it makes the code less readable\n    3) And most importantly, the point of pgbedrock is to make a spec\n    simply to read and follow. Those empty entries are unnecessary\n    cruft.\n\nAs a result, it is both easier on our end and more correct based on this\ntool's philosophical purpose to not try to convert entries from None to\nan empty list.\n\nOriginally, I had tried to use a customer PyYAML constructor to\nautomatically convert these sublists from strings to ObjectName\ninstances, but I found PyYAML confusing and complicated enough that\nwhoever would have to maintain this code if it breaks would probably end\nup quite confused. Because of that it seemed wiser to just let PyYAML do\nits thing and then we come in with regular Python and convert the\nrelevant parts of the loaded spec into ObjectName instances.","distinct":true,"url":"https://api.github.com/repos/zcmarine/pgbedrock/commits/dcc202c98e6f8db4538eed50aacc861a92600133"}]}
{"actor":{"display_login":"zcmarine"}}