{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/22003","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/22003/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/22003/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/22003/events","html_url":"https://github.com/elastic/kibana/pull/22003","id":350839030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTg1MjM2","number":22003,"title":"Removing extraneous whitespace characters between attributions in attribution string in map visualization (Fixes #21612)","user":{"login":"scottis","id":12020099,"node_id":"MDQ6VXNlcjEyMDIwMDk5","avatar_url":"https://avatars1.githubusercontent.com/u/12020099?v=4","gravatar_id":"","url":"https://api.github.com/users/scottis","html_url":"https://github.com/scottis","followers_url":"https://api.github.com/users/scottis/followers","following_url":"https://api.github.com/users/scottis/following{/other_user}","gists_url":"https://api.github.com/users/scottis/gists{/gist_id}","starred_url":"https://api.github.com/users/scottis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottis/subscriptions","organizations_url":"https://api.github.com/users/scottis/orgs","repos_url":"https://api.github.com/users/scottis/repos","events_url":"https://api.github.com/users/scottis/events{/privacy}","received_events_url":"https://api.github.com/users/scottis/received_events","type":"User","site_admin":false},"labels":[{"id":829133627,"node_id":"MDU6TGFiZWw4MjkxMzM2Mjc=","url":"https://api.github.com/repos/elastic/kibana/labels/:Geo","name":":Geo","color":"fef2c0","default":false},{"id":462161355,"node_id":"MDU6TGFiZWw0NjIxNjEzNTU=","url":"https://api.github.com/repos/elastic/kibana/labels/:Visualizations","name":":Visualizations","color":"fef2c0","default":false},{"id":601657399,"node_id":"MDU6TGFiZWw2MDE2NTczOTk=","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:fix","name":"release_note:fix","color":"c2e0c6","default":false},{"id":912973198,"node_id":"MDU6TGFiZWw5MTI5NzMxOTg=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.5.0","name":"v6.5.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-08-15T14:50:07Z","updated_at":"2018-09-10T15:12:34Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/22003","html_url":"https://github.com/elastic/kibana/pull/22003","diff_url":"https://github.com/elastic/kibana/pull/22003.diff","patch_url":"https://github.com/elastic/kibana/pull/22003.patch"},"body":"Before:\r\n\r\n![before](https://user-images.githubusercontent.com/12020099/44154500-dececc46-a078-11e8-847b-043f3ae706a9.png)\r\n\r\nAfter:\r\n\r\n![after](https://user-images.githubusercontent.com/12020099/44154511-e41ac164-a078-11e8-8632-60faface3d35.png)\r\n\r\nHere is an example of the `visState` of a map:\r\n\r\n```json\r\n{\r\n   \"title\":\"[Flights] Destination Airport\",\r\n   \"type\":\"tile_map\",\r\n   \"params\":{\r\n      \"colorSchema\":\"Yellow to Red\",\r\n      \"mapType\":\"Scaled Circle Markers\",\r\n      \"isDesaturated\":true,\r\n      \"addTooltip\":true,\r\n      \"heatClusterSize\":1.5,\r\n      \"legendPosition\":\"bottomright\",\r\n      \"mapZoom\":2,\r\n      \"mapCenter\":[\r\n         0,\r\n         0\r\n      ],\r\n      \"wms\":{\r\n         \"enabled\":false,\r\n         \"options\":{\r\n            \"format\":\"image/png\",\r\n            \"transparent\":true\r\n         },\r\n         \"baseLayersAreLoaded\":{\r\n\r\n         },\r\n         \"tmsLayers\":[\r\n            {\r\n               \"id\":\"road_map\",\r\n               \"url\":\"https://tiles.maps.elastic.co/v2/default/{z}/{x}/{y}.png?elastic_tile_service_tos=agree&my_app_name=kibana&my_app_version=6.3.0&license=686f9ec6-d775-44f0-b334-38caf85da617\",\r\n               \"minZoom\":0,\r\n               \"maxZoom\":18,\r\n               \"attribution\":\"<p>&#169; <a href=\\\"http://www.openstreetmap.org/copyright\\\">OpenStreetMap</a> contributors | <a href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a></p>&#10;\",\r\n               \"subdomains\":[\r\n\r\n               ]\r\n            }\r\n         ],\r\n         \"selectedTmsLayer\":{\r\n            \"id\":\"road_map\",\r\n            \"url\":\"https://tiles.maps.elastic.co/v2/default/{z}/{x}/{y}.png?elastic_tile_service_tos=agree&my_app_name=kibana&my_app_version=6.3.0&license=686f9ec6-d775-44f0-b334-38caf85da617\",\r\n            \"minZoom\":0,\r\n            \"maxZoom\":18,\r\n            \"attribution\":\"<p>&#169; <a href=\\\"http://www.openstreetmap.org/copyright\\\">OpenStreetMap</a> contributors | <a href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a></p>&#10;\",\r\n            \"subdomains\":[\r\n\r\n            ]\r\n         }\r\n      }\r\n   },\r\n   \"aggs\":[\r\n      {\r\n         \"id\":\"1\",\r\n         \"enabled\":true,\r\n         \"type\":\"count\",\r\n         \"schema\":\"metric\",\r\n         \"params\":{\r\n\r\n         }\r\n      },\r\n      {\r\n         \"id\":\"2\",\r\n         \"enabled\":true,\r\n         \"type\":\"geohash_grid\",\r\n         \"schema\":\"segment\",\r\n         \"params\":{\r\n            \"field\":\"DestLocation\",\r\n            \"autoPrecision\":true,\r\n            \"isFilteredByCollar\":true,\r\n            \"useGeocentroid\":true,\r\n            \"precision\":2\r\n         }\r\n      }\r\n   ]\r\n}\r\n```\r\n\r\nYou can see that the `attribution` used in the map is `<p>&#169; <a href=\\\"http://www.openstreetmap.org/copyright\\\">OpenStreetMap</a> contributors | <a href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a></p>&#10;`.\r\n\r\nPreviously, we were splitting on `|`, causing extraneous space characters to remain in the attribution. With this change, we are splitting on `/\\s*\\|\\s*/`.\r\n\r\nAn alternative solution would be to prevent extraneous spaces from ever becoming part of the `attribution` in the first place.\r\n\r\n@tsullivan @thomasneirynck "},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/419949105","html_url":"https://github.com/elastic/kibana/pull/22003#issuecomment-419949105","issue_url":"https://api.github.com/repos/elastic/kibana/issues/22003","id":419949105,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTk0OTEwNQ==","user":{"login":"thomasneirynck","id":1833023,"node_id":"MDQ6VXNlcjE4MzMwMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1833023?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasneirynck","html_url":"https://github.com/thomasneirynck","followers_url":"https://api.github.com/users/thomasneirynck/followers","following_url":"https://api.github.com/users/thomasneirynck/following{/other_user}","gists_url":"https://api.github.com/users/thomasneirynck/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasneirynck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasneirynck/subscriptions","organizations_url":"https://api.github.com/users/thomasneirynck/orgs","repos_url":"https://api.github.com/users/thomasneirynck/repos","events_url":"https://api.github.com/users/thomasneirynck/events{/privacy}","received_events_url":"https://api.github.com/users/thomasneirynck/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T15:12:34Z","updated_at":"2018-09-10T15:12:34Z","author_association":"CONTRIBUTOR","body":"jenkins, test this"}}
{"actor":{"display_login":"thomasneirynck"}}