{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/cf-deployment/issues/677","repository_url":"https://api.github.com/repos/cloudfoundry/cf-deployment","labels_url":"https://api.github.com/repos/cloudfoundry/cf-deployment/issues/677/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/cf-deployment/issues/677/comments","events_url":"https://api.github.com/repos/cloudfoundry/cf-deployment/issues/677/events","html_url":"https://github.com/cloudfoundry/cf-deployment/pull/677","id":389969908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODQwMDMy","number":677,"title":"Make TLS parameter configurable for syslog OPS file","user":{"login":"axelaris","id":2487285,"node_id":"MDQ6VXNlcjI0ODcyODU=","avatar_url":"https://avatars1.githubusercontent.com/u/2487285?v=4","gravatar_id":"","url":"https://api.github.com/users/axelaris","html_url":"https://github.com/axelaris","followers_url":"https://api.github.com/users/axelaris/followers","following_url":"https://api.github.com/users/axelaris/following{/other_user}","gists_url":"https://api.github.com/users/axelaris/gists{/gist_id}","starred_url":"https://api.github.com/users/axelaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelaris/subscriptions","organizations_url":"https://api.github.com/users/axelaris/orgs","repos_url":"https://api.github.com/users/axelaris/repos","events_url":"https://api.github.com/users/axelaris/events{/privacy}","received_events_url":"https://api.github.com/users/axelaris/received_events","type":"User","site_admin":false},"labels":[{"id":370416080,"node_id":"MDU6TGFiZWwzNzA0MTYwODA=","url":"https://api.github.com/repos/cloudfoundry/cf-deployment/labels/scheduled","name":"scheduled","color":"BFD4F2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-11T21:53:44Z","updated_at":"2018-12-17T20:17:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cloudfoundry/cf-deployment/pulls/677","html_url":"https://github.com/cloudfoundry/cf-deployment/pull/677","diff_url":"https://github.com/cloudfoundry/cf-deployment/pull/677.diff","patch_url":"https://github.com/cloudfoundry/cf-deployment/pull/677.patch"},"body":"### WHAT is this change about?\r\n\r\n`tls_enabled` configuration parameter was hardcoded to `true`. I made it configurable by setting variable. \r\n\r\n### WHY is this change being made (What problem is being addressed)?\r\n\r\nI used `enable-component-syslog.yml` OPS file when deploying CF by Concourse (using cf-concourse-tasks) repo. It was not easy to overwrite hardcoded value, so I decided to make it configurable.\r\n\r\n### Has a cf-deployment including this change passed our [cf-acceptance-tests](https://github.com/cloudfoundry/cf-acceptance-tests)?\r\n\r\nDid not run acceptance tests because it was just change in an OPS file.\r\n\r\n\r\n\r\n### How should this change be described in cf-deployment release notes?\r\n\r\nI added that variable to example var file so we can treat it as a kind of documentation.\r\n\r\n\r\n### Does this PR introduce a breaking change? \r\n\r\nNO\r\n\r\n\r\n### Will this change increase the VM footprint of cf-deployment?\r\n\r\n- [ ] NO\r\n\r\n\r\n\r\n### Does this PR make a change to an experimental or GA'd feature/component?\r\n\r\n- [ ] GA'd feature/component\r\n\r\n\r\n\r\n### What is the level of urgency for publishing this change?\r\n\r\n- [ ] **Slightly Less than Urgent**\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/cf-deployment/issues/comments/447984040","html_url":"https://github.com/cloudfoundry/cf-deployment/pull/677#issuecomment-447984040","issue_url":"https://api.github.com/repos/cloudfoundry/cf-deployment/issues/677","id":447984040,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzk4NDA0MA==","user":{"login":"ishustava","id":10640505,"node_id":"MDQ6VXNlcjEwNjQwNTA1","avatar_url":"https://avatars3.githubusercontent.com/u/10640505?v=4","gravatar_id":"","url":"https://api.github.com/users/ishustava","html_url":"https://github.com/ishustava","followers_url":"https://api.github.com/users/ishustava/followers","following_url":"https://api.github.com/users/ishustava/following{/other_user}","gists_url":"https://api.github.com/users/ishustava/gists{/gist_id}","starred_url":"https://api.github.com/users/ishustava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishustava/subscriptions","organizations_url":"https://api.github.com/users/ishustava/orgs","repos_url":"https://api.github.com/users/ishustava/repos","events_url":"https://api.github.com/users/ishustava/events{/privacy}","received_events_url":"https://api.github.com/users/ishustava/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T20:17:26Z","updated_at":"2018-12-17T20:17:26Z","author_association":"MEMBER","body":"Hey @axelaris,\r\n\r\nNot being able to turn off TLS for component syslog was intentional in cf-deployment. See #477 for more details.\r\n\r\nYou can disable it by removing the `tls_enabled` property with your own ops file like so:\r\n\r\n```\r\n- type: remove\r\n  path: /addons/name=syslog_forwarder/jobs/name=syslog_forwarder/properties/syslog/tls_enabled\r\n```"}}
{"actor":{"display_login":"ishustava"}}