{"action":"created","issue":{"url":"https://api.github.com/repos/ESCOMP/ctsm/issues/285","repository_url":"https://api.github.com/repos/ESCOMP/ctsm","labels_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/285/comments","events_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/285/events","html_url":"https://github.com/ESCOMP/ctsm/issues/285","id":296913637,"node_id":"MDU6SXNzdWUyOTY5MTM2Mzc=","number":285,"title":"Remove unnecessary restart variables","user":{"login":"billsacks","id":6266741,"node_id":"MDQ6VXNlcjYyNjY3NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6266741?v=4","gravatar_id":"","url":"https://api.github.com/users/billsacks","html_url":"https://github.com/billsacks","followers_url":"https://api.github.com/users/billsacks/followers","following_url":"https://api.github.com/users/billsacks/following{/other_user}","gists_url":"https://api.github.com/users/billsacks/gists{/gist_id}","starred_url":"https://api.github.com/users/billsacks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billsacks/subscriptions","organizations_url":"https://api.github.com/users/billsacks/orgs","repos_url":"https://api.github.com/users/billsacks/repos","events_url":"https://api.github.com/users/billsacks/events{/privacy}","received_events_url":"https://api.github.com/users/billsacks/received_events","type":"User","site_admin":false},"labels":[{"id":780653963,"node_id":"MDU6TGFiZWw3ODA2NTM5NjM=","url":"https://api.github.com/repos/ESCOMP/ctsm/labels/type:%20enhance%20-%20software","name":"type: enhance - software","color":"edc49a","default":false}],"state":"open","locked":false,"assignee":{"login":"slevisconsulting","id":35322900,"node_id":"MDQ6VXNlcjM1MzIyOTAw","avatar_url":"https://avatars1.githubusercontent.com/u/35322900?v=4","gravatar_id":"","url":"https://api.github.com/users/slevisconsulting","html_url":"https://github.com/slevisconsulting","followers_url":"https://api.github.com/users/slevisconsulting/followers","following_url":"https://api.github.com/users/slevisconsulting/following{/other_user}","gists_url":"https://api.github.com/users/slevisconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/slevisconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slevisconsulting/subscriptions","organizations_url":"https://api.github.com/users/slevisconsulting/orgs","repos_url":"https://api.github.com/users/slevisconsulting/repos","events_url":"https://api.github.com/users/slevisconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/slevisconsulting/received_events","type":"User","site_admin":false},"assignees":[{"login":"slevisconsulting","id":35322900,"node_id":"MDQ6VXNlcjM1MzIyOTAw","avatar_url":"https://avatars1.githubusercontent.com/u/35322900?v=4","gravatar_id":"","url":"https://api.github.com/users/slevisconsulting","html_url":"https://github.com/slevisconsulting","followers_url":"https://api.github.com/users/slevisconsulting/followers","following_url":"https://api.github.com/users/slevisconsulting/following{/other_user}","gists_url":"https://api.github.com/users/slevisconsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/slevisconsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slevisconsulting/subscriptions","organizations_url":"https://api.github.com/users/slevisconsulting/orgs","repos_url":"https://api.github.com/users/slevisconsulting/repos","events_url":"https://api.github.com/users/slevisconsulting/events{/privacy}","received_events_url":"https://api.github.com/users/slevisconsulting/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-02-13T22:46:11Z","updated_at":"2018-11-27T18:58:02Z","closed_at":null,"author_association":"MEMBER","body":"**I originally made this comment 2015-10-29. I'm moving this over as is, though some of the original comment may no longer be correct.**\r\n\r\nI have noticed that there are some variables on the restart file that are unnecessary. This adds confusion if you try to use the restart file as an indicator of the CLM state. This is particularly relevant for data assimilation.\r\n\r\nVariables I have noticed are:\r\n\r\n- [ ] plant_nalloc: seems to be set before it is used\r\n\r\n- [ ] pot_f_nit_vr_vr and f_nit_vr_vr: I *think* they are set before they are used\r\n\r\n- [ ] root_depth: I *think* it is set before it is used\r\n\r\n- [x] AnnET: Should be unnecessary because accumulators are automatically saved to restart (fixed in ctsm1.0.dev009)\r\n\r\n- [ ] qflx_floodg?: I haven't looked closely, but since this is set in lnd_import_export, it's hard to imagine why it's needed on the restart file. But more analysis or testing should be done before removing this. Note that it has interpinic_flag='skip'... if it is truly needed as a restart variable, then its flag should probably be 'interp'.\r\n\r\n- [ ] tws (see http://bugs.cgd.ucar.edu/show_bug.cgi?id=1731, now closed because I have moved this here)\r\n\r\n- [ ] O2_DECOMP_DEPTH_SAT and O2_DECOMP_DEPTH_UNSAT?? (2016-05-19: I haven't looked closely, but at a glance it looks like they're not needed on restart; the same may be true of other variables in the methane model)\r\n\r\n- [ ] SNOUNLOAD (2018-05-24: set before it's used each time step)\r\n\r\nThere are probably others, too\r\n"},"comment":{"url":"https://api.github.com/repos/ESCOMP/ctsm/issues/comments/442175863","html_url":"https://github.com/ESCOMP/ctsm/issues/285#issuecomment-442175863","issue_url":"https://api.github.com/repos/ESCOMP/ctsm/issues/285","id":442175863,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjE3NTg2Mw==","user":{"login":"ekluzek","id":11545792,"node_id":"MDQ6VXNlcjExNTQ1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/11545792?v=4","gravatar_id":"","url":"https://api.github.com/users/ekluzek","html_url":"https://github.com/ekluzek","followers_url":"https://api.github.com/users/ekluzek/followers","following_url":"https://api.github.com/users/ekluzek/following{/other_user}","gists_url":"https://api.github.com/users/ekluzek/gists{/gist_id}","starred_url":"https://api.github.com/users/ekluzek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekluzek/subscriptions","organizations_url":"https://api.github.com/users/ekluzek/orgs","repos_url":"https://api.github.com/users/ekluzek/repos","events_url":"https://api.github.com/users/ekluzek/events{/privacy}","received_events_url":"https://api.github.com/users/ekluzek/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T18:58:02Z","updated_at":"2018-11-27T18:58:02Z","author_association":"CONTRIBUTOR","body":"Good point @billsacks, thanks for giving the scoop on that."}}
{"actor":{"display_login":"ekluzek"}}