{"action":"closed","issue":{"url":"https://api.github.com/repos/tdf/libcmis/issues/12","repository_url":"https://api.github.com/repos/tdf/libcmis","labels_url":"https://api.github.com/repos/tdf/libcmis/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/tdf/libcmis/issues/12/comments","events_url":"https://api.github.com/repos/tdf/libcmis/issues/12/events","html_url":"https://github.com/tdf/libcmis/issues/12","id":198691396,"node_id":"MDU6SXNzdWUxOTg2OTEzOTY=","number":12,"title":"Libcmis fails cppcheck-test","user":{"login":"PPed72","id":871023,"node_id":"MDQ6VXNlcjg3MTAyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/871023?v=4","gravatar_id":"","url":"https://api.github.com/users/PPed72","html_url":"https://github.com/PPed72","followers_url":"https://api.github.com/users/PPed72/followers","following_url":"https://api.github.com/users/PPed72/following{/other_user}","gists_url":"https://api.github.com/users/PPed72/gists{/gist_id}","starred_url":"https://api.github.com/users/PPed72/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PPed72/subscriptions","organizations_url":"https://api.github.com/users/PPed72/orgs","repos_url":"https://api.github.com/users/PPed72/repos","events_url":"https://api.github.com/users/PPed72/events{/privacy}","received_events_url":"https://api.github.com/users/PPed72/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-04T11:56:00Z","updated_at":"2018-12-22T08:58:01Z","closed_at":"2018-12-22T08:58:01Z","author_association":"NONE","body":"Since upgrading to version 1.72 of cppcheck, the cppcheck test fails:\r\n\r\nFAIL: cppcheck-test.sh\r\n======================\r\n\r\n[src/libcmis/oauth2-providers.cxx:163]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.\r\n[src/libcmis/oauth2-providers.cxx:167]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.\r\n[src/libcmis/oauth2-providers.cxx:169]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.\r\n[src/libcmis/ws-relatedmultipart.cxx:125]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.\r\n[src/libcmis/ws-relatedmultipart.cxx:146]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.\r\n[src/libcmis/ws-relatedmultipart.cxx:203]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.\r\n[*]: (information) Unmatched suppression: noExplicitCopyMoveConstructor\r\n(information) Cppcheck cannot find all the include files (use --check-config for details)\r\nFAIL cppcheck-test.sh (exit status: 1)\r\n\r\nLast known working cppcheck version was 1.69. I've tried with all versions of cppcheck from 1.72 to 1.75 and with git master and they do not work.\r\n\r\nSee relevant Gentoo bug: https://bugs.gentoo.org/show_bug.cgi?id=577926"}}
{"actor":{"display_login":"dtardon"}}