{"action":"created","comment":{"url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/comments/241350879","pull_request_review_id":184598308,"id":241350879,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTM1MDg3OQ==","diff_hunk":"@@ -20,11 +20,19 @@ def retrieve_observation(ctx, dossier:, data:, **)\n       end\n \n       def update_observation(ctx, observation:, data:, **)\n-        observation.update_attributes(data)\n+        etat_obs = data[:etat]\n+\n+        unless etat_obs == 'Suppression'","path":"app/concepts/observation/operation/update_or_create.rb","position":7,"original_position":7,"commit_id":"649152669cdcde1b6efd3a4d705c6a0e51acc87e","original_commit_id":"748da46f2f7cfb76fdc9cb504194009e36b9fc0a","user":{"login":"Haelle","id":5159985,"node_id":"MDQ6VXNlcjUxNTk5ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/5159985?v=4","gravatar_id":"","url":"https://api.github.com/users/Haelle","html_url":"https://github.com/Haelle","followers_url":"https://api.github.com/users/Haelle/followers","following_url":"https://api.github.com/users/Haelle/following{/other_user}","gists_url":"https://api.github.com/users/Haelle/gists{/gist_id}","starred_url":"https://api.github.com/users/Haelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haelle/subscriptions","organizations_url":"https://api.github.com/users/Haelle/orgs","repos_url":"https://api.github.com/users/Haelle/repos","events_url":"https://api.github.com/users/Haelle/events{/privacy}","received_events_url":"https://api.github.com/users/Haelle/received_events","type":"User","site_admin":false},"body":"quand il y a deux branches au test je préfère utiliser `if` que `unless` c'est plus simple","created_at":"2018-12-13T10:39:51Z","updated_at":"2018-12-13T10:50:25Z","html_url":"https://github.com/etalab/rncs_worker_api_entreprise/pull/46#discussion_r241350879","pull_request_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/comments/241350879"},"html":{"href":"https://github.com/etalab/rncs_worker_api_entreprise/pull/46#discussion_r241350879"},"pull_request":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46","id":238051171,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDUxMTcx","html_url":"https://github.com/etalab/rncs_worker_api_entreprise/pull/46","diff_url":"https://github.com/etalab/rncs_worker_api_entreprise/pull/46.diff","patch_url":"https://github.com/etalab/rncs_worker_api_entreprise/pull/46.patch","issue_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/46","number":46,"state":"open","locked":false,"title":"Running daily updates part 2","user":{"login":"brindu","id":4283958,"node_id":"MDQ6VXNlcjQyODM5NTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4283958?v=4","gravatar_id":"","url":"https://api.github.com/users/brindu","html_url":"https://github.com/brindu","followers_url":"https://api.github.com/users/brindu/followers","following_url":"https://api.github.com/users/brindu/following{/other_user}","gists_url":"https://api.github.com/users/brindu/gists{/gist_id}","starred_url":"https://api.github.com/users/brindu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brindu/subscriptions","organizations_url":"https://api.github.com/users/brindu/orgs","repos_url":"https://api.github.com/users/brindu/repos","events_url":"https://api.github.com/users/brindu/events{/privacy}","received_events_url":"https://api.github.com/users/brindu/received_events","type":"User","site_admin":false},"body":"### Contenu de la PR \r\nEvolutions nécessaires à l'import des mises à jour quotidiennes\r\n\r\n### Comment faire la review \r\nCommits par commits","created_at":"2018-12-12T14:12:05Z","updated_at":"2018-12-13T10:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00bdfd6b6ca671d32e4fba4adc284147487ecbe9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"giglemad","id":2211142,"node_id":"MDQ6VXNlcjIyMTExNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2211142?v=4","gravatar_id":"","url":"https://api.github.com/users/giglemad","html_url":"https://github.com/giglemad","followers_url":"https://api.github.com/users/giglemad/followers","following_url":"https://api.github.com/users/giglemad/following{/other_user}","gists_url":"https://api.github.com/users/giglemad/gists{/gist_id}","starred_url":"https://api.github.com/users/giglemad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giglemad/subscriptions","organizations_url":"https://api.github.com/users/giglemad/orgs","repos_url":"https://api.github.com/users/giglemad/repos","events_url":"https://api.github.com/users/giglemad/events{/privacy}","received_events_url":"https://api.github.com/users/giglemad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46/commits","review_comments_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46/comments","review_comment_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/46/comments","statuses_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/statuses/649152669cdcde1b6efd3a4d705c6a0e51acc87e","head":{"label":"etalab:running_daily_updates_2","ref":"running_daily_updates_2","sha":"649152669cdcde1b6efd3a4d705c6a0e51acc87e","user":{"login":"etalab","id":5313610,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5313610?v=4","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"repo":{"id":140752187,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3NTIxODc=","name":"rncs_worker_api_entreprise","full_name":"etalab/rncs_worker_api_entreprise","private":false,"owner":{"login":"etalab","id":5313610,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5313610?v=4","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/etalab/rncs_worker_api_entreprise","description":null,"fork":false,"url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise","forks_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/forks","keys_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/teams","hooks_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/hooks","issue_events_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/events{/number}","events_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/events","assignees_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/assignees{/user}","branches_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/branches{/branch}","tags_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/tags","blobs_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/statuses/{sha}","languages_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/languages","stargazers_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/stargazers","contributors_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/contributors","subscribers_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/subscribers","subscription_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/subscription","commits_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/contents/{+path}","compare_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/merges","archive_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/downloads","issues_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues{/number}","pulls_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls{/number}","milestones_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/milestones{/number}","notifications_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/labels{/name}","releases_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/releases{/id}","deployments_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/deployments","created_at":"2018-07-12T18:45:02Z","updated_at":"2018-12-10T14:09:53Z","pushed_at":"2018-12-13T10:28:01Z","git_url":"git://github.com/etalab/rncs_worker_api_entreprise.git","ssh_url":"git@github.com:etalab/rncs_worker_api_entreprise.git","clone_url":"https://github.com/etalab/rncs_worker_api_entreprise.git","svn_url":"https://github.com/etalab/rncs_worker_api_entreprise","homepage":null,"size":703,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":3,"default_branch":"master"}},"base":{"label":"etalab:master","ref":"master","sha":"7f4ed73114d301c14dde0004acb861b87987f673","user":{"login":"etalab","id":5313610,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5313610?v=4","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"repo":{"id":140752187,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA3NTIxODc=","name":"rncs_worker_api_entreprise","full_name":"etalab/rncs_worker_api_entreprise","private":false,"owner":{"login":"etalab","id":5313610,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMTM2MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5313610?v=4","gravatar_id":"","url":"https://api.github.com/users/etalab","html_url":"https://github.com/etalab","followers_url":"https://api.github.com/users/etalab/followers","following_url":"https://api.github.com/users/etalab/following{/other_user}","gists_url":"https://api.github.com/users/etalab/gists{/gist_id}","starred_url":"https://api.github.com/users/etalab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etalab/subscriptions","organizations_url":"https://api.github.com/users/etalab/orgs","repos_url":"https://api.github.com/users/etalab/repos","events_url":"https://api.github.com/users/etalab/events{/privacy}","received_events_url":"https://api.github.com/users/etalab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/etalab/rncs_worker_api_entreprise","description":null,"fork":false,"url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise","forks_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/forks","keys_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/teams","hooks_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/hooks","issue_events_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/events{/number}","events_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/events","assignees_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/assignees{/user}","branches_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/branches{/branch}","tags_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/tags","blobs_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/refs{/sha}","trees_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/statuses/{sha}","languages_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/languages","stargazers_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/stargazers","contributors_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/contributors","subscribers_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/subscribers","subscription_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/subscription","commits_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/commits{/sha}","git_commits_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/git/commits{/sha}","comments_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/comments{/number}","issue_comment_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/comments{/number}","contents_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/contents/{+path}","compare_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/merges","archive_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/downloads","issues_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues{/number}","pulls_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls{/number}","milestones_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/milestones{/number}","notifications_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/labels{/name}","releases_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/releases{/id}","deployments_url":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/deployments","created_at":"2018-07-12T18:45:02Z","updated_at":"2018-12-10T14:09:53Z","pushed_at":"2018-12-13T10:28:01Z","git_url":"git://github.com/etalab/rncs_worker_api_entreprise.git","ssh_url":"git@github.com:etalab/rncs_worker_api_entreprise.git","clone_url":"https://github.com/etalab/rncs_worker_api_entreprise.git","svn_url":"https://github.com/etalab/rncs_worker_api_entreprise","homepage":null,"size":703,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":0,"open_issues":15,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46"},"html":{"href":"https://github.com/etalab/rncs_worker_api_entreprise/pull/46"},"issue":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/46"},"comments":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/etalab/rncs_worker_api_entreprise/statuses/649152669cdcde1b6efd3a4d705c6a0e51acc87e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Haelle"}}