{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments/214442051","pull_request_review_id":151508414,"id":214442051,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ0MjA1MQ==","diff_hunk":"@@ -133,27 +133,27 @@ function remove() {\n > [!NOTE]\n > This feature is currently available only in public preview (beta). To use it, you must reference the beta library of the Office.js CDN: https://appsforoffice.microsoft.com/lib/beta/hosted/office.js.\n \n-Events are turned on and off at the [runtime](https://docs.microsoft.com/en-us/javascript/api/excel/excel.runtime?view=office-js) level. \n+Some scenarios benefit from the performance boost given by turning off events. \n+Your app might never need to receive events, or it could ignore events while performing batch-edits of multiple entities. \n+\n+Events are turned on and off at the [runtime](https://docs.microsoft.com/javascript/api/excel/excel.runtime) level. \n The `enableEvents` property determines if events are fired and their handlers are activated. \n-Turning events off is useful when performance is critical or when editing multiple entities and want to avoid firing events until you have finished.\n \n The following code sample shows how to toggle events on and off.\n \n-```typescript\n-async function toggleEvents() {\n-    await Excel.run(async (context) => {\n-        context.runtime.load(\"enableEvents\");\n-        await context.sync();\n-        const eventBoolean = !context.runtime.enableEvents\n-        context.runtime.enableEvents = eventBoolean;\n-        if (eventBoolean) {\n-            console.log(\"Events are currently on.\");\n-        } else {\n-            console.log(\"Events are currently off.\");\n-        }\n-        await context.sync();\n-    });\n-}\n+```js","path":"docs/excel/excel-add-ins-events.md","position":52,"original_position":52,"commit_id":"2dcffa2be64bb3f9e700e8c88f14f275efd0510f","original_commit_id":"41b277f5066cff3ae83917a87dbb96259ae9f941","user":{"login":"kbrandl","id":3019529,"node_id":"MDQ6VXNlcjMwMTk1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/3019529?v=4","gravatar_id":"","url":"https://api.github.com/users/kbrandl","html_url":"https://github.com/kbrandl","followers_url":"https://api.github.com/users/kbrandl/followers","following_url":"https://api.github.com/users/kbrandl/following{/other_user}","gists_url":"https://api.github.com/users/kbrandl/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrandl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrandl/subscriptions","organizations_url":"https://api.github.com/users/kbrandl/orgs","repos_url":"https://api.github.com/users/kbrandl/repos","events_url":"https://api.github.com/users/kbrandl/events{/privacy}","received_events_url":"https://api.github.com/users/kbrandl/received_events","type":"User","site_admin":false},"body":"ES7 supports `async` / `await` but I believe it requires transpile. Can you clarify this with Michael (and share your learnings with the team via email)?  i.e., what are the requirements for using `async` / `await` in vanilla JavaScript (e.g., does E7 and higher support it, but only with transpile)? This is something we should all understand and be on the same page about. Thanks!","created_at":"2018-08-31T18:37:58Z","updated_at":"2018-08-31T18:37:58Z","html_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/349#discussion_r214442051","pull_request_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments/214442051"},"html":{"href":"https://github.com/OfficeDev/office-js-docs-pr/pull/349#discussion_r214442051"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349"}},"in_reply_to_id":214220760},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349","id":212210352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjEwMzUy","html_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/349","diff_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/349.diff","patch_url":"https://github.com/OfficeDev/office-js-docs-pr/pull/349.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/349","number":349,"state":"open","locked":false,"title":"Referencing event toggling to performance page","user":{"login":"AlexJerabek","id":38896772,"node_id":"MDQ6VXNlcjM4ODk2Nzcy","avatar_url":"https://avatars3.githubusercontent.com/u/38896772?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexJerabek","html_url":"https://github.com/AlexJerabek","followers_url":"https://api.github.com/users/AlexJerabek/followers","following_url":"https://api.github.com/users/AlexJerabek/following{/other_user}","gists_url":"https://api.github.com/users/AlexJerabek/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexJerabek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexJerabek/subscriptions","organizations_url":"https://api.github.com/users/AlexJerabek/orgs","repos_url":"https://api.github.com/users/AlexJerabek/repos","events_url":"https://api.github.com/users/AlexJerabek/events{/privacy}","received_events_url":"https://api.github.com/users/AlexJerabek/received_events","type":"User","site_admin":false},"body":"The preview section on event toggling seems like a better fit for the advanced concept page on performance, rather than the basic page about events.\r\n\r\nAlso reworded the text to better match the new context.","created_at":"2018-08-30T21:03:01Z","updated_at":"2018-08-31T18:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75fbae3cff5218b34877a5256bc85faaa928f16c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Rick-Kirkham","id":9088056,"node_id":"MDQ6VXNlcjkwODgwNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9088056?v=4","gravatar_id":"","url":"https://api.github.com/users/Rick-Kirkham","html_url":"https://github.com/Rick-Kirkham","followers_url":"https://api.github.com/users/Rick-Kirkham/followers","following_url":"https://api.github.com/users/Rick-Kirkham/following{/other_user}","gists_url":"https://api.github.com/users/Rick-Kirkham/gists{/gist_id}","starred_url":"https://api.github.com/users/Rick-Kirkham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rick-Kirkham/subscriptions","organizations_url":"https://api.github.com/users/Rick-Kirkham/orgs","repos_url":"https://api.github.com/users/Rick-Kirkham/repos","events_url":"https://api.github.com/users/Rick-Kirkham/events{/privacy}","received_events_url":"https://api.github.com/users/Rick-Kirkham/received_events","type":"User","site_admin":false},{"login":"ElizabethSamuel-MSFT","id":28541963,"node_id":"MDQ6VXNlcjI4NTQxOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/28541963?v=4","gravatar_id":"","url":"https://api.github.com/users/ElizabethSamuel-MSFT","html_url":"https://github.com/ElizabethSamuel-MSFT","followers_url":"https://api.github.com/users/ElizabethSamuel-MSFT/followers","following_url":"https://api.github.com/users/ElizabethSamuel-MSFT/following{/other_user}","gists_url":"https://api.github.com/users/ElizabethSamuel-MSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/ElizabethSamuel-MSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElizabethSamuel-MSFT/subscriptions","organizations_url":"https://api.github.com/users/ElizabethSamuel-MSFT/orgs","repos_url":"https://api.github.com/users/ElizabethSamuel-MSFT/repos","events_url":"https://api.github.com/users/ElizabethSamuel-MSFT/events{/privacy}","received_events_url":"https://api.github.com/users/ElizabethSamuel-MSFT/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/349/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/2dcffa2be64bb3f9e700e8c88f14f275efd0510f","head":{"label":"OfficeDev:AlexJ-EventPerf","ref":"AlexJ-EventPerf","sha":"2dcffa2be64bb3f9e700e8c88f14f275efd0510f","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":109723362,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MjMzNjI=","name":"office-js-docs-pr","full_name":"OfficeDev/office-js-docs-pr","owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-js-docs-pr","description":"Microsoft Office Add-ins Documentation","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr","forks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/deployments","created_at":"2017-11-06T16:53:41Z","updated_at":"2018-08-31T18:25:53Z","pushed_at":"2018-08-31T18:25:50Z","git_url":"git://github.com/OfficeDev/office-js-docs-pr.git","ssh_url":"git@github.com:OfficeDev/office-js-docs-pr.git","clone_url":"https://github.com/OfficeDev/office-js-docs-pr.git","svn_url":"https://github.com/OfficeDev/office-js-docs-pr","homepage":"https://docs.microsoft.com/en-us/office/dev/add-ins","size":37668,"stargazers_count":78,"watchers_count":78,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":31,"watchers":78,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"ee4b8ff3d08acb0ffdffa1f20093e5e1701e505d","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":109723362,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3MjMzNjI=","name":"office-js-docs-pr","full_name":"OfficeDev/office-js-docs-pr","owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/office-js-docs-pr","description":"Microsoft Office Add-ins Documentation","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr","forks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/deployments","created_at":"2017-11-06T16:53:41Z","updated_at":"2018-08-31T18:25:53Z","pushed_at":"2018-08-31T18:25:50Z","git_url":"git://github.com/OfficeDev/office-js-docs-pr.git","ssh_url":"git@github.com:OfficeDev/office-js-docs-pr.git","clone_url":"https://github.com/OfficeDev/office-js-docs-pr.git","svn_url":"https://github.com/OfficeDev/office-js-docs-pr","homepage":"https://docs.microsoft.com/en-us/office/dev/add-ins","size":37668,"stargazers_count":78,"watchers_count":78,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":31,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349"},"html":{"href":"https://github.com/OfficeDev/office-js-docs-pr/pull/349"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/349"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-js-docs-pr/statuses/2dcffa2be64bb3f9e700e8c88f14f275efd0510f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kbrandl"}}