{"action":"created","comment":{"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/comments/184533544","pull_request_review_id":115752146,"id":184533544,"diff_hunk":"@@ -44,8 +44,8 @@ help() {\n \n # check for GPU and store string\n check_gpu() {\n-  if lspci | grep -i vga | grep -i -q intel ; then\n-    gpu=\"intel\"\n+  if lspci | grep -i vga | grep -i -q 'intel\\|amd' ; then","path":"packages/sysutils/busybox/scripts/getedid","position":15,"original_position":15,"commit_id":"b4422a69297e095ddab7ca30fbf2f6b28ebafcb4","original_commit_id":"b4422a69297e095ddab7ca30fbf2f6b28ebafcb4","user":{"login":"MilhouseVH","id":805038,"avatar_url":"https://avatars0.githubusercontent.com/u/805038?v=4","gravatar_id":"","url":"https://api.github.com/users/MilhouseVH","html_url":"https://github.com/MilhouseVH","followers_url":"https://api.github.com/users/MilhouseVH/followers","following_url":"https://api.github.com/users/MilhouseVH/following{/other_user}","gists_url":"https://api.github.com/users/MilhouseVH/gists{/gist_id}","starred_url":"https://api.github.com/users/MilhouseVH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MilhouseVH/subscriptions","organizations_url":"https://api.github.com/users/MilhouseVH/orgs","repos_url":"https://api.github.com/users/MilhouseVH/repos","events_url":"https://api.github.com/users/MilhouseVH/events{/privacy}","received_events_url":"https://api.github.com/users/MilhouseVH/received_events","type":"User","site_admin":false},"body":"`grep -i -q -E 'intel|amd'` might be better?","created_at":"2018-04-26T21:17:39Z","updated_at":"2018-04-26T21:17:40Z","html_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/2449#discussion_r184533544","pull_request_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/comments/184533544"},"html":{"href":"https://github.com/LibreELEC/LibreELEC.tv/pull/2449#discussion_r184533544"},"pull_request":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449"}}},"pull_request":{"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449","id":165520580,"html_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/2449","diff_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/2449.diff","patch_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/2449.patch","issue_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/2449","number":2449,"state":"open","locked":false,"title":"Adding support for AMD GPUs","user":{"login":"DaVukovic","id":7235787,"avatar_url":"https://avatars3.githubusercontent.com/u/7235787?v=4","gravatar_id":"","url":"https://api.github.com/users/DaVukovic","html_url":"https://github.com/DaVukovic","followers_url":"https://api.github.com/users/DaVukovic/followers","following_url":"https://api.github.com/users/DaVukovic/following{/other_user}","gists_url":"https://api.github.com/users/DaVukovic/gists{/gist_id}","starred_url":"https://api.github.com/users/DaVukovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaVukovic/subscriptions","organizations_url":"https://api.github.com/users/DaVukovic/orgs","repos_url":"https://api.github.com/users/DaVukovic/repos","events_url":"https://api.github.com/users/DaVukovic/events{/privacy}","received_events_url":"https://api.github.com/users/DaVukovic/received_events","type":"User","site_admin":false},"body":"Please do not merge yet. \r\n\r\nThis has to be tested before and for the reason I don't have some AMD GPU, I can't be sure. So please understand this PR as a request for a review.\r\n\r\nThere's also some issue with kernel 4.14 and kabylake hardware which either should be resolved or we should do changes for not supporting > kabylake. Only if newer hardware has the same problem ofc.\r\n","created_at":"2018-01-27T14:42:37Z","updated_at":"2018-04-26T21:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4db525f8f70390f891a12a1ae6263307e125951","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":429479367,"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels/LE%209.0","name":"LE 9.0","color":"b60205","default":false},{"id":343716825,"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels/WORK%20IN%20PROGRESS","name":"WORK IN PROGRESS","color":"ff9933","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449/commits","review_comments_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449/comments","review_comment_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/2449/comments","statuses_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/statuses/b4422a69297e095ddab7ca30fbf2f6b28ebafcb4","head":{"label":"DaVukovic:getedid-amd","ref":"getedid-amd","sha":"b4422a69297e095ddab7ca30fbf2f6b28ebafcb4","user":{"login":"DaVukovic","id":7235787,"avatar_url":"https://avatars3.githubusercontent.com/u/7235787?v=4","gravatar_id":"","url":"https://api.github.com/users/DaVukovic","html_url":"https://github.com/DaVukovic","followers_url":"https://api.github.com/users/DaVukovic/followers","following_url":"https://api.github.com/users/DaVukovic/following{/other_user}","gists_url":"https://api.github.com/users/DaVukovic/gists{/gist_id}","starred_url":"https://api.github.com/users/DaVukovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaVukovic/subscriptions","organizations_url":"https://api.github.com/users/DaVukovic/orgs","repos_url":"https://api.github.com/users/DaVukovic/repos","events_url":"https://api.github.com/users/DaVukovic/events{/privacy}","received_events_url":"https://api.github.com/users/DaVukovic/received_events","type":"User","site_admin":false},"repo":{"id":87316303,"name":"LibreELEC.tv","full_name":"DaVukovic/LibreELEC.tv","owner":{"login":"DaVukovic","id":7235787,"avatar_url":"https://avatars3.githubusercontent.com/u/7235787?v=4","gravatar_id":"","url":"https://api.github.com/users/DaVukovic","html_url":"https://github.com/DaVukovic","followers_url":"https://api.github.com/users/DaVukovic/followers","following_url":"https://api.github.com/users/DaVukovic/following{/other_user}","gists_url":"https://api.github.com/users/DaVukovic/gists{/gist_id}","starred_url":"https://api.github.com/users/DaVukovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaVukovic/subscriptions","organizations_url":"https://api.github.com/users/DaVukovic/orgs","repos_url":"https://api.github.com/users/DaVukovic/repos","events_url":"https://api.github.com/users/DaVukovic/events{/privacy}","received_events_url":"https://api.github.com/users/DaVukovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaVukovic/LibreELEC.tv","description":"Just enough OS for KODI","fork":true,"url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv","forks_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/forks","keys_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/teams","hooks_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/hooks","issue_events_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/issues/events{/number}","events_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/events","assignees_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/assignees{/user}","branches_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/branches{/branch}","tags_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/tags","blobs_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/statuses/{sha}","languages_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/languages","stargazers_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/stargazers","contributors_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/contributors","subscribers_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/subscribers","subscription_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/subscription","commits_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/contents/{+path}","compare_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/merges","archive_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/downloads","issues_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/issues{/number}","pulls_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/pulls{/number}","milestones_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/milestones{/number}","notifications_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/labels{/name}","releases_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/releases{/id}","deployments_url":"https://api.github.com/repos/DaVukovic/LibreELEC.tv/deployments","created_at":"2017-04-05T14:02:40Z","updated_at":"2017-04-05T14:02:46Z","pushed_at":"2018-01-27T14:37:46Z","git_url":"git://github.com/DaVukovic/LibreELEC.tv.git","ssh_url":"git@github.com:DaVukovic/LibreELEC.tv.git","clone_url":"https://github.com/DaVukovic/LibreELEC.tv.git","svn_url":"https://github.com/DaVukovic/LibreELEC.tv","homepage":"http://libreelec.tv","size":282850,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LibreELEC:master","ref":"master","sha":"95908d81cfe019143b8e16b30fff8708bef0697b","user":{"login":"LibreELEC","id":17335241,"avatar_url":"https://avatars1.githubusercontent.com/u/17335241?v=4","gravatar_id":"","url":"https://api.github.com/users/LibreELEC","html_url":"https://github.com/LibreELEC","followers_url":"https://api.github.com/users/LibreELEC/followers","following_url":"https://api.github.com/users/LibreELEC/following{/other_user}","gists_url":"https://api.github.com/users/LibreELEC/gists{/gist_id}","starred_url":"https://api.github.com/users/LibreELEC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibreELEC/subscriptions","organizations_url":"https://api.github.com/users/LibreELEC/orgs","repos_url":"https://api.github.com/users/LibreELEC/repos","events_url":"https://api.github.com/users/LibreELEC/events{/privacy}","received_events_url":"https://api.github.com/users/LibreELEC/received_events","type":"Organization","site_admin":false},"repo":{"id":53762444,"name":"LibreELEC.tv","full_name":"LibreELEC/LibreELEC.tv","owner":{"login":"LibreELEC","id":17335241,"avatar_url":"https://avatars1.githubusercontent.com/u/17335241?v=4","gravatar_id":"","url":"https://api.github.com/users/LibreELEC","html_url":"https://github.com/LibreELEC","followers_url":"https://api.github.com/users/LibreELEC/followers","following_url":"https://api.github.com/users/LibreELEC/following{/other_user}","gists_url":"https://api.github.com/users/LibreELEC/gists{/gist_id}","starred_url":"https://api.github.com/users/LibreELEC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LibreELEC/subscriptions","organizations_url":"https://api.github.com/users/LibreELEC/orgs","repos_url":"https://api.github.com/users/LibreELEC/repos","events_url":"https://api.github.com/users/LibreELEC/events{/privacy}","received_events_url":"https://api.github.com/users/LibreELEC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LibreELEC/LibreELEC.tv","description":"Just enough OS for KODI","fork":false,"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv","forks_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/forks","keys_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/teams","hooks_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/hooks","issue_events_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/events{/number}","events_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/events","assignees_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/assignees{/user}","branches_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/branches{/branch}","tags_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/tags","blobs_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/git/refs{/sha}","trees_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/statuses/{sha}","languages_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/languages","stargazers_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/stargazers","contributors_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/contributors","subscribers_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/subscribers","subscription_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/subscription","commits_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/commits{/sha}","git_commits_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/git/commits{/sha}","comments_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/comments{/number}","issue_comment_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/comments{/number}","contents_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/contents/{+path}","compare_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/merges","archive_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/downloads","issues_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues{/number}","pulls_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls{/number}","milestones_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/milestones{/number}","notifications_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels{/name}","releases_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/releases{/id}","deployments_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/deployments","created_at":"2016-03-13T01:46:18Z","updated_at":"2018-04-26T14:59:30Z","pushed_at":"2018-04-26T19:36:31Z","git_url":"git://github.com/LibreELEC/LibreELEC.tv.git","ssh_url":"git@github.com:LibreELEC/LibreELEC.tv.git","clone_url":"https://github.com/LibreELEC/LibreELEC.tv.git","svn_url":"https://github.com/LibreELEC/LibreELEC.tv","homepage":"http://libreelec.tv","size":288598,"stargazers_count":665,"watchers_count":665,"language":"Makefile","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":537,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":537,"open_issues":38,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449"},"html":{"href":"https://github.com/LibreELEC/LibreELEC.tv/pull/2449"},"issue":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/2449"},"comments":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/2449/comments"},"review_comments":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449/comments"},"review_comment":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/2449/commits"},"statuses":{"href":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/statuses/b4422a69297e095ddab7ca30fbf2f6b28ebafcb4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MilhouseVH"}}