{"action":"created","comment":{"url":"https://api.github.com/repos/enactjs/enact/pulls/comments/202238861","pull_request_review_id":136900221,"id":202238861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjIzODg2MQ==","diff_hunk":"@@ -533,7 +541,6 @@ class ScrollableBase extends Component {\n \t\t\ttargetX = (direction === 'vertical') ? 0 : this.dragStartX - this.getRtlX(ev.x), // 'horizontal' or 'both'\n \t\t\ttargetY = (direction === 'horizontal') ? 0 : this.dragStartY - ev.y; // 'vertical' or 'both'\n \n-\t\tthis.updateOverscrollEffectOnPosition(targetX, targetY, overscrollTypes.sticking);\n \t\tthis.start({targetX, targetY, animate: false});","path":"packages/ui/Scrollable/Scrollable.js","position":59,"original_position":59,"commit_id":"5ef7bc180f07b176166937296c23b3e2d9e6c3d1","original_commit_id":"5ef7bc180f07b176166937296c23b3e2d9e6c3d1","user":{"login":"0x64","id":5037955,"node_id":"MDQ6VXNlcjUwMzc5NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5037955?v=4","gravatar_id":"","url":"https://api.github.com/users/0x64","html_url":"https://github.com/0x64","followers_url":"https://api.github.com/users/0x64/followers","following_url":"https://api.github.com/users/0x64/following{/other_user}","gists_url":"https://api.github.com/users/0x64/gists{/gist_id}","starred_url":"https://api.github.com/users/0x64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0x64/subscriptions","organizations_url":"https://api.github.com/users/0x64/orgs","repos_url":"https://api.github.com/users/0x64/repos","events_url":"https://api.github.com/users/0x64/events{/privacy}","received_events_url":"https://api.github.com/users/0x64/received_events","type":"User","site_admin":false},"body":"✔️","created_at":"2018-07-13T04:06:11Z","updated_at":"2018-07-13T04:06:11Z","html_url":"https://github.com/enactjs/enact/pull/1769#discussion_r202238861","pull_request_url":"https://api.github.com/repos/enactjs/enact/pulls/1769","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments/202238861"},"html":{"href":"https://github.com/enactjs/enact/pull/1769#discussion_r202238861"},"pull_request":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1769"}},"in_reply_to_id":202238243},"pull_request":{"url":"https://api.github.com/repos/enactjs/enact/pulls/1769","id":198868555,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODY4NTU1","html_url":"https://github.com/enactjs/enact/pull/1769","diff_url":"https://github.com/enactjs/enact/pull/1769.diff","patch_url":"https://github.com/enactjs/enact/pull/1769.patch","issue_url":"https://api.github.com/repos/enactjs/enact/issues/1769","number":1769,"state":"open","locked":false,"title":"ENYO-5365: Fixed overscroll effects on improper timing","user":{"login":"0x64","id":5037955,"node_id":"MDQ6VXNlcjUwMzc5NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5037955?v=4","gravatar_id":"","url":"https://api.github.com/users/0x64","html_url":"https://github.com/0x64","followers_url":"https://api.github.com/users/0x64/followers","following_url":"https://api.github.com/users/0x64/following{/other_user}","gists_url":"https://api.github.com/users/0x64/gists{/gist_id}","starred_url":"https://api.github.com/users/0x64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0x64/subscriptions","organizations_url":"https://api.github.com/users/0x64/orgs","repos_url":"https://api.github.com/users/0x64/repos","events_url":"https://api.github.com/users/0x64/events{/privacy}","received_events_url":"https://api.github.com/users/0x64/received_events","type":"User","site_admin":false},"body":"### Issue Resolved / Feature Added\r\n[//]: # (Describe the issue resolved or feature added by this pull request)\r\n- Fixed not to show an overscroll effect when a focus moves between paging control buttons right after a list reached to the edge.\r\n- Fixed to show an overscroll effect by the first wheeling on native lists.\r\n\r\n### Resolution\r\n[//]: # (Does the code work as intended?)\r\n[//]: # (What is the impact of this change and *why* was it made?)\r\nThe internal status variable is shared for effects on both edges (beginning and ending), so updating the variable by reaching one edge affected an effect for the other edge. In this PR, effects for both edges have their own status variable.\r\n\r\n### Links\r\n[//]: # (Related issues, references)\r\nENYO-5365\r\n\r\n### Comments\r\nEnact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)\r\n","created_at":"2018-07-03T07:09:28Z","updated_at":"2018-07-13T04:06:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98e12913046b7d439674a282245248f265b08733","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enactjs/enact/pulls/1769/commits","review_comments_url":"https://api.github.com/repos/enactjs/enact/pulls/1769/comments","review_comment_url":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enactjs/enact/issues/1769/comments","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/5ef7bc180f07b176166937296c23b3e2d9e6c3d1","head":{"label":"enactjs:feature/ENYO-5365","ref":"feature/ENYO-5365","sha":"5ef7bc180f07b176166937296c23b3e2d9e6c3d1","user":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"node_id":"MDEwOlJlcG9zaXRvcnk2NzY1MzA2NQ==","name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-07-09T09:02:15Z","pushed_at":"2018-07-13T03:33:41Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":15137,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":58,"watchers":67,"default_branch":"master"}},"base":{"label":"enactjs:develop","ref":"develop","sha":"a762ae19518836d564b543f6616db99f57d2459b","user":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"node_id":"MDEwOlJlcG9zaXRvcnk2NzY1MzA2NQ==","name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDg2MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-07-09T09:02:15Z","pushed_at":"2018-07-13T03:33:41Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":15137,"stargazers_count":67,"watchers_count":67,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":58,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1769"},"html":{"href":"https://github.com/enactjs/enact/pull/1769"},"issue":{"href":"https://api.github.com/repos/enactjs/enact/issues/1769"},"comments":{"href":"https://api.github.com/repos/enactjs/enact/issues/1769/comments"},"review_comments":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1769/comments"},"review_comment":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1769/commits"},"statuses":{"href":"https://api.github.com/repos/enactjs/enact/statuses/5ef7bc180f07b176166937296c23b3e2d9e6c3d1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"0x64"}}