{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/217140547","pull_request_review_id":154782197,"id":217140547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE0MDU0Nw==","diff_hunk":"@@ -0,0 +1,212 @@\n+admin:\n+  email: \"a@b.c\"\n+  password: \"verysecure\"\n+  sshKey: \"ssh-ed25519 AAAA...\"\n+openstack:\n+  credentials:\n+    insecure: false\n+\n+    cloud:\n+\n+  baseImage:","path":"examples/tectonic.openstack.yaml","position":11,"original_position":11,"commit_id":"fc2c5399461c1708654874092d419321715f2946","original_commit_id":"fc2c5399461c1708654874092d419321715f2946","user":{"login":"crawford","id":368848,"node_id":"MDQ6VXNlcjM2ODg0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/368848?v=4","gravatar_id":"","url":"https://api.github.com/users/crawford","html_url":"https://github.com/crawford","followers_url":"https://api.github.com/users/crawford/followers","following_url":"https://api.github.com/users/crawford/following{/other_user}","gists_url":"https://api.github.com/users/crawford/gists{/gist_id}","starred_url":"https://api.github.com/users/crawford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crawford/subscriptions","organizations_url":"https://api.github.com/users/crawford/orgs","repos_url":"https://api.github.com/users/crawford/repos","events_url":"https://api.github.com/users/crawford/events{/privacy}","received_events_url":"https://api.github.com/users/crawford/received_events","type":"User","site_admin":false},"body":"Is this a local path or a reference in Glance?","created_at":"2018-09-12T18:25:48Z","updated_at":"2018-09-12T18:36:21Z","html_url":"https://github.com/openshift/installer/pull/144#discussion_r217140547","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/144","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/217140547"},"html":{"href":"https://github.com/openshift/installer/pull/144#discussion_r217140547"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/144"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/144","id":209046950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MDQ2OTUw","html_url":"https://github.com/openshift/installer/pull/144","diff_url":"https://github.com/openshift/installer/pull/144.diff","patch_url":"https://github.com/openshift/installer/pull/144.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/144","number":144,"state":"open","locked":false,"title":"WIP: OpenStack provider support","user":{"login":"flaper87","id":13816,"node_id":"MDQ6VXNlcjEzODE2","avatar_url":"https://avatars0.githubusercontent.com/u/13816?v=4","gravatar_id":"","url":"https://api.github.com/users/flaper87","html_url":"https://github.com/flaper87","followers_url":"https://api.github.com/users/flaper87/followers","following_url":"https://api.github.com/users/flaper87/following{/other_user}","gists_url":"https://api.github.com/users/flaper87/gists{/gist_id}","starred_url":"https://api.github.com/users/flaper87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaper87/subscriptions","organizations_url":"https://api.github.com/users/flaper87/orgs","repos_url":"https://api.github.com/users/flaper87/repos","events_url":"https://api.github.com/users/flaper87/events{/privacy}","received_events_url":"https://api.github.com/users/flaper87/received_events","type":"User","site_admin":false},"body":"This PR adds an OpenStack module and the respective steps to run tectonic against an OpenStack cloud.\r\n\r\n\r\nFully implemented steps\r\n\r\n- [x] Assets creation\r\n- [ ] Topology creation (missing some features LB/DNS)\r\n- [x] Masters\r\n- [x] workers\r\n\r\nFeatures implementation:\r\n\r\n- [x] Networks creation\r\n- [x] Subnets creation\r\n- [x] IPs allocation and assignment\r\n- [x] Security groups management\r\n- [x] Ignition config upload/download from the object store (swift)\r\n- [x] Instance creation\r\n- [ ] Installation/Configuration of the OpenStack provider (currently disabled)\r\n- [x] LB creation\r\n- [ ] DNS Records creation\r\n\r\nWe're currently working on implementing the remaining features but we thought that it'd be better to send this PR out and start the review process. The current implementation shouldn't have any impact on the AWS provider or other areas of the installer. It's isolated and touches only new bits related to OpenStack. \r\n\r\nThe ignition steps run in the nodes but we're currently seeing some failures with the certificates that we're going to solve as soon as the LB implementation is done.\r\n\r\nNotes:\r\n\r\n- As far as the PR goes, we're good with waiting until it's fully implemented or merging it as WIP and keep sending (smaller) PRs that will complete the implementation. I slightly prefer the latter as that will make the review process easier.\r\n\r\n- I didn't squash the commits to avoid taking credits from other folks that have contributed to this provider.\r\n\r\n- This PR currently depends on unreleased features in terraform-provider openstack:\r\n  - https://github.com/terraform-providers/terraform-provider-openstack/pull/377\r\n  - https://github.com/terraform-providers/terraform-provider-openstack/pull/379 \r\n\r\n@yifan-gu r? \r\n","created_at":"2018-08-17T05:11:08Z","updated_at":"2018-09-12T18:36:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d541decc7bda47c936d8ec210bc83a77890ae39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959731323,"node_id":"MDU6TGFiZWw5NTk3MzEzMjM=","url":"https://api.github.com/repos/openshift/installer/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":959730581,"node_id":"MDU6TGFiZWw5NTk3MzA1ODE=","url":"https://api.github.com/repos/openshift/installer/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/144/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/144/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/144/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/fc2c5399461c1708654874092d419321715f2946","head":{"label":"flaper87:openstack","ref":"openstack","sha":"fc2c5399461c1708654874092d419321715f2946","user":{"login":"flaper87","id":13816,"node_id":"MDQ6VXNlcjEzODE2","avatar_url":"https://avatars0.githubusercontent.com/u/13816?v=4","gravatar_id":"","url":"https://api.github.com/users/flaper87","html_url":"https://github.com/flaper87","followers_url":"https://api.github.com/users/flaper87/followers","following_url":"https://api.github.com/users/flaper87/following{/other_user}","gists_url":"https://api.github.com/users/flaper87/gists{/gist_id}","starred_url":"https://api.github.com/users/flaper87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaper87/subscriptions","organizations_url":"https://api.github.com/users/flaper87/orgs","repos_url":"https://api.github.com/users/flaper87/repos","events_url":"https://api.github.com/users/flaper87/events{/privacy}","received_events_url":"https://api.github.com/users/flaper87/received_events","type":"User","site_admin":false},"repo":{"id":141444197,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NDQxOTc=","name":"installer","full_name":"flaper87/installer","owner":{"login":"flaper87","id":13816,"node_id":"MDQ6VXNlcjEzODE2","avatar_url":"https://avatars0.githubusercontent.com/u/13816?v=4","gravatar_id":"","url":"https://api.github.com/users/flaper87","html_url":"https://github.com/flaper87","followers_url":"https://api.github.com/users/flaper87/followers","following_url":"https://api.github.com/users/flaper87/following{/other_user}","gists_url":"https://api.github.com/users/flaper87/gists{/gist_id}","starred_url":"https://api.github.com/users/flaper87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaper87/subscriptions","organizations_url":"https://api.github.com/users/flaper87/orgs","repos_url":"https://api.github.com/users/flaper87/repos","events_url":"https://api.github.com/users/flaper87/events{/privacy}","received_events_url":"https://api.github.com/users/flaper87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flaper87/installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/flaper87/installer","forks_url":"https://api.github.com/repos/flaper87/installer/forks","keys_url":"https://api.github.com/repos/flaper87/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flaper87/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flaper87/installer/teams","hooks_url":"https://api.github.com/repos/flaper87/installer/hooks","issue_events_url":"https://api.github.com/repos/flaper87/installer/issues/events{/number}","events_url":"https://api.github.com/repos/flaper87/installer/events","assignees_url":"https://api.github.com/repos/flaper87/installer/assignees{/user}","branches_url":"https://api.github.com/repos/flaper87/installer/branches{/branch}","tags_url":"https://api.github.com/repos/flaper87/installer/tags","blobs_url":"https://api.github.com/repos/flaper87/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flaper87/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flaper87/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/flaper87/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flaper87/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/flaper87/installer/languages","stargazers_url":"https://api.github.com/repos/flaper87/installer/stargazers","contributors_url":"https://api.github.com/repos/flaper87/installer/contributors","subscribers_url":"https://api.github.com/repos/flaper87/installer/subscribers","subscription_url":"https://api.github.com/repos/flaper87/installer/subscription","commits_url":"https://api.github.com/repos/flaper87/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/flaper87/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/flaper87/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/flaper87/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/flaper87/installer/contents/{+path}","compare_url":"https://api.github.com/repos/flaper87/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flaper87/installer/merges","archive_url":"https://api.github.com/repos/flaper87/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flaper87/installer/downloads","issues_url":"https://api.github.com/repos/flaper87/installer/issues{/number}","pulls_url":"https://api.github.com/repos/flaper87/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/flaper87/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/flaper87/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flaper87/installer/labels{/name}","releases_url":"https://api.github.com/repos/flaper87/installer/releases{/id}","deployments_url":"https://api.github.com/repos/flaper87/installer/deployments","created_at":"2018-07-18T14:14:26Z","updated_at":"2018-07-18T14:14:29Z","pushed_at":"2018-09-12T18:06:09Z","git_url":"git://github.com/flaper87/installer.git","ssh_url":"git@github.com:flaper87/installer.git","clone_url":"https://github.com/flaper87/installer.git","svn_url":"https://github.com/flaper87/installer","homepage":"","size":36539,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"84ab99e316a3f4f768b2ff145b8094c2779597c1","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-09-12T16:06:13Z","pushed_at":"2018-09-12T18:06:11Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":36461,"stargazers_count":37,"watchers_count":37,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":29,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/144"},"html":{"href":"https://github.com/openshift/installer/pull/144"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/144"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/fc2c5399461c1708654874092d419321715f2946"}},"author_association":"NONE"}}
{"actor":{"display_login":"crawford"}}