{"action":"opened","number":5090,"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5090","id":214676974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0Njc2OTc0","html_url":"https://github.com/material-components/material-components-ios/pull/5090","diff_url":"https://github.com/material-components/material-components-ios/pull/5090.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/5090.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5090","number":5090,"state":"open","locked":false,"title":"[Shapes] merge MDCShapeCorner and MDCCornerTreatment into one","user":{"login":"yarneo","id":4066863,"node_id":"MDQ6VXNlcjQwNjY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4066863?v=4","gravatar_id":"","url":"https://api.github.com/users/yarneo","html_url":"https://github.com/yarneo","followers_url":"https://api.github.com/users/yarneo/followers","following_url":"https://api.github.com/users/yarneo/following{/other_user}","gists_url":"https://api.github.com/users/yarneo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarneo/subscriptions","organizations_url":"https://api.github.com/users/yarneo/orgs","repos_url":"https://api.github.com/users/yarneo/repos","events_url":"https://api.github.com/users/yarneo/events{/privacy}","received_events_url":"https://api.github.com/users/yarneo/received_events","type":"User","site_admin":false},"body":"This will allow us to set percentage support for a corner treatment as a follow up PR. Reason being is that the MDCCornerTreatment is part of the shape of the component itself, and hence has control to set the value of the corner when it is right in the lifecycle and the frame has been set. If we keep the percentage value setting in the Shape Themer, then the themer could be applied too early in the lifecycle and thus take a percentage off a 0 value (frame height).\r\n\r\nOverall this simplifies the API and causes less duplication.\r\n\r\nThe other approach would be to *also* add percentage support to MDCCornerTreatment and leave MDCShapeCorner as is, but that would just make it too cumbersome and redundant. ","created_at":"2018-09-11T15:39:59Z","updated_at":"2018-09-11T15:39:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5090/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5090/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5090/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/927b8730f750da412acbd339b868778f3b498016","head":{"label":"yarneo:changeshapeapi","ref":"changeshapeapi","sha":"927b8730f750da412acbd339b868778f3b498016","user":{"login":"yarneo","id":4066863,"node_id":"MDQ6VXNlcjQwNjY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4066863?v=4","gravatar_id":"","url":"https://api.github.com/users/yarneo","html_url":"https://github.com/yarneo","followers_url":"https://api.github.com/users/yarneo/followers","following_url":"https://api.github.com/users/yarneo/following{/other_user}","gists_url":"https://api.github.com/users/yarneo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarneo/subscriptions","organizations_url":"https://api.github.com/users/yarneo/orgs","repos_url":"https://api.github.com/users/yarneo/repos","events_url":"https://api.github.com/users/yarneo/events{/privacy}","received_events_url":"https://api.github.com/users/yarneo/received_events","type":"User","site_admin":false},"repo":{"id":110606484,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MDY0ODQ=","name":"material-components-ios","full_name":"yarneo/material-components-ios","owner":{"login":"yarneo","id":4066863,"node_id":"MDQ6VXNlcjQwNjY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/4066863?v=4","gravatar_id":"","url":"https://api.github.com/users/yarneo","html_url":"https://github.com/yarneo","followers_url":"https://api.github.com/users/yarneo/followers","following_url":"https://api.github.com/users/yarneo/following{/other_user}","gists_url":"https://api.github.com/users/yarneo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarneo/subscriptions","organizations_url":"https://api.github.com/users/yarneo/orgs","repos_url":"https://api.github.com/users/yarneo/repos","events_url":"https://api.github.com/users/yarneo/events{/privacy}","received_events_url":"https://api.github.com/users/yarneo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yarneo/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/yarneo/material-components-ios","forks_url":"https://api.github.com/repos/yarneo/material-components-ios/forks","keys_url":"https://api.github.com/repos/yarneo/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarneo/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarneo/material-components-ios/teams","hooks_url":"https://api.github.com/repos/yarneo/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/yarneo/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/yarneo/material-components-ios/events","assignees_url":"https://api.github.com/repos/yarneo/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/yarneo/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/yarneo/material-components-ios/tags","blobs_url":"https://api.github.com/repos/yarneo/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarneo/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarneo/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarneo/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarneo/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/yarneo/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/yarneo/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/yarneo/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/yarneo/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/yarneo/material-components-ios/subscription","commits_url":"https://api.github.com/repos/yarneo/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarneo/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarneo/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarneo/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarneo/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/yarneo/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarneo/material-components-ios/merges","archive_url":"https://api.github.com/repos/yarneo/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarneo/material-components-ios/downloads","issues_url":"https://api.github.com/repos/yarneo/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/yarneo/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/yarneo/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/yarneo/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarneo/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/yarneo/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/yarneo/material-components-ios/deployments","created_at":"2017-11-13T21:50:04Z","updated_at":"2018-09-11T03:20:21Z","pushed_at":"2018-09-11T15:35:37Z","git_url":"git://github.com/yarneo/material-components-ios.git","ssh_url":"git@github.com:yarneo/material-components-ios.git","clone_url":"https://github.com/yarneo/material-components-ios.git","svn_url":"https://github.com/yarneo/material-components-ios","homepage":"","size":121382,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"741d375605eb149453dda94208f378241ab75ff6","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-09-11T15:24:20Z","pushed_at":"2018-09-11T15:33:43Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":120924,"stargazers_count":2737,"watchers_count":2737,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":410,"mirror_url":null,"archived":false,"open_issues_count":727,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":410,"open_issues":727,"watchers":2737,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5090"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/5090"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/5090"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/5090/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5090/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5090/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/927b8730f750da412acbd339b868778f3b498016"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":44,"deletions":189,"changed_files":9}}
{"actor":{"display_login":"yarneo"}}