{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-analytics/pulls/comments/242474681","pull_request_review_id":185990649,"id":242474681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQ3NDY4MQ==","diff_hunk":"@@ -48,11 +49,14 @@ public TriggerConfigGenerator(String siddhiAppString, Map<String, StreamDefiniti\n      */\n     public TriggerConfig generateTriggerConfig(TriggerDefinition triggerDefinition) throws DesignGenerationException {\n         String at = \"\";","path":"components/org.wso2.carbon.siddhi.editor.core/src/main/java/org/wso2/carbon/siddhi/editor/core/util/designview/designgenerator/generators/TriggerConfigGenerator.java","position":null,"original_position":11,"commit_id":"97aff2523a4468759c33ce94e34dd1c88ea092af","original_commit_id":"bc09f65c5dd2fd16568742894f92e75661defb56","user":{"login":"PradeepaJey1","id":32606884,"node_id":"MDQ6VXNlcjMyNjA2ODg0","avatar_url":"https://avatars3.githubusercontent.com/u/32606884?v=4","gravatar_id":"","url":"https://api.github.com/users/PradeepaJey1","html_url":"https://github.com/PradeepaJey1","followers_url":"https://api.github.com/users/PradeepaJey1/followers","following_url":"https://api.github.com/users/PradeepaJey1/following{/other_user}","gists_url":"https://api.github.com/users/PradeepaJey1/gists{/gist_id}","starred_url":"https://api.github.com/users/PradeepaJey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradeepaJey1/subscriptions","organizations_url":"https://api.github.com/users/PradeepaJey1/orgs","repos_url":"https://api.github.com/users/PradeepaJey1/repos","events_url":"https://api.github.com/users/PradeepaJey1/events{/privacy}","received_events_url":"https://api.github.com/users/PradeepaJey1/received_events","type":"User","site_admin":false},"body":"Fixed in eceb77b51dbb904e257a9b9b5f72d8e14560d910","created_at":"2018-12-18T10:08:42Z","updated_at":"2018-12-18T10:08:42Z","html_url":"https://github.com/wso2/carbon-analytics/pull/1533#discussion_r242474681","pull_request_url":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-analytics/pulls/comments/242474681"},"html":{"href":"https://github.com/wso2/carbon-analytics/pull/1533#discussion_r242474681"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533"}},"in_reply_to_id":242418405},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533","id":238633256,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjMzMjU2","html_url":"https://github.com/wso2/carbon-analytics/pull/1533","diff_url":"https://github.com/wso2/carbon-analytics/pull/1533.diff","patch_url":"https://github.com/wso2/carbon-analytics/pull/1533.patch","issue_url":"https://api.github.com/repos/wso2/carbon-analytics/issues/1533","number":1533,"state":"open","locked":false,"title":"Siddhi editor design-view's form changes","user":{"login":"PradeepaJey1","id":32606884,"node_id":"MDQ6VXNlcjMyNjA2ODg0","avatar_url":"https://avatars3.githubusercontent.com/u/32606884?v=4","gravatar_id":"","url":"https://api.github.com/users/PradeepaJey1","html_url":"https://github.com/PradeepaJey1","followers_url":"https://api.github.com/users/PradeepaJey1/followers","following_url":"https://api.github.com/users/PradeepaJey1/following{/other_user}","gists_url":"https://api.github.com/users/PradeepaJey1/gists{/gist_id}","starred_url":"https://api.github.com/users/PradeepaJey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradeepaJey1/subscriptions","organizations_url":"https://api.github.com/users/PradeepaJey1/orgs","repos_url":"https://api.github.com/users/PradeepaJey1/repos","events_url":"https://api.github.com/users/PradeepaJey1/events{/privacy}","received_events_url":"https://api.github.com/users/PradeepaJey1/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n> 1. Implement the forms [trigger, partition, window, function] using java-script.\r\n> 2. In the sink form allow only payload mapping and allow user to add multiple key-value pairs.\r\n> 3. Introduce constant class for design-view.\r\n> 4. Refactor code for forms [sink, source,table,stream].\r\n\r\n## Goals\r\n> 1. Remove JSONEditor library and implement the forms using java-script and handlebar templates.\r\n> 2. Remove attribute mapping from sink form and add a button to add payload key-value pairs. ","created_at":"2018-12-14T07:30:26Z","updated_at":"2018-12-18T10:08:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c0cf71f5655eedcde6b65b84d45eb73ab5900c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-analytics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-analytics/issues/1533/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-analytics/statuses/97aff2523a4468759c33ce94e34dd1c88ea092af","head":{"label":"PradeepaJey1:Forms","ref":"Forms","sha":"97aff2523a4468759c33ce94e34dd1c88ea092af","user":{"login":"PradeepaJey1","id":32606884,"node_id":"MDQ6VXNlcjMyNjA2ODg0","avatar_url":"https://avatars3.githubusercontent.com/u/32606884?v=4","gravatar_id":"","url":"https://api.github.com/users/PradeepaJey1","html_url":"https://github.com/PradeepaJey1","followers_url":"https://api.github.com/users/PradeepaJey1/followers","following_url":"https://api.github.com/users/PradeepaJey1/following{/other_user}","gists_url":"https://api.github.com/users/PradeepaJey1/gists{/gist_id}","starred_url":"https://api.github.com/users/PradeepaJey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradeepaJey1/subscriptions","organizations_url":"https://api.github.com/users/PradeepaJey1/orgs","repos_url":"https://api.github.com/users/PradeepaJey1/repos","events_url":"https://api.github.com/users/PradeepaJey1/events{/privacy}","received_events_url":"https://api.github.com/users/PradeepaJey1/received_events","type":"User","site_admin":false},"repo":{"id":143963246,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5NjMyNDY=","name":"carbon-analytics","full_name":"PradeepaJey1/carbon-analytics","private":false,"owner":{"login":"PradeepaJey1","id":32606884,"node_id":"MDQ6VXNlcjMyNjA2ODg0","avatar_url":"https://avatars3.githubusercontent.com/u/32606884?v=4","gravatar_id":"","url":"https://api.github.com/users/PradeepaJey1","html_url":"https://github.com/PradeepaJey1","followers_url":"https://api.github.com/users/PradeepaJey1/followers","following_url":"https://api.github.com/users/PradeepaJey1/following{/other_user}","gists_url":"https://api.github.com/users/PradeepaJey1/gists{/gist_id}","starred_url":"https://api.github.com/users/PradeepaJey1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PradeepaJey1/subscriptions","organizations_url":"https://api.github.com/users/PradeepaJey1/orgs","repos_url":"https://api.github.com/users/PradeepaJey1/repos","events_url":"https://api.github.com/users/PradeepaJey1/events{/privacy}","received_events_url":"https://api.github.com/users/PradeepaJey1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PradeepaJey1/carbon-analytics","description":null,"fork":true,"url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics","forks_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/forks","keys_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/teams","hooks_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/hooks","issue_events_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/issues/events{/number}","events_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/events","assignees_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/assignees{/user}","branches_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/branches{/branch}","tags_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/tags","blobs_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/statuses/{sha}","languages_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/languages","stargazers_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/stargazers","contributors_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/contributors","subscribers_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/subscribers","subscription_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/subscription","commits_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/contents/{+path}","compare_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/merges","archive_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/downloads","issues_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/issues{/number}","pulls_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/pulls{/number}","milestones_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/milestones{/number}","notifications_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/labels{/name}","releases_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/releases{/id}","deployments_url":"https://api.github.com/repos/PradeepaJey1/carbon-analytics/deployments","created_at":"2018-08-08T05:02:16Z","updated_at":"2018-10-11T10:15:37Z","pushed_at":"2018-12-18T10:07:17Z","git_url":"git://github.com/PradeepaJey1/carbon-analytics.git","ssh_url":"git@github.com:PradeepaJey1/carbon-analytics.git","clone_url":"https://github.com/PradeepaJey1/carbon-analytics.git","svn_url":"https://github.com/PradeepaJey1/carbon-analytics","homepage":null,"size":103649,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"a1299902c0e03ae9c2960627c315f31ad553e2bd","user":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":16543113,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU0MzExMw==","name":"carbon-analytics","full_name":"wso2/carbon-analytics","private":false,"owner":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wso2/carbon-analytics","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-analytics","forks_url":"https://api.github.com/repos/wso2/carbon-analytics/forks","keys_url":"https://api.github.com/repos/wso2/carbon-analytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-analytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-analytics/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-analytics/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-analytics/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-analytics/events","assignees_url":"https://api.github.com/repos/wso2/carbon-analytics/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-analytics/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-analytics/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-analytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-analytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-analytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-analytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-analytics/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-analytics/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-analytics/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-analytics/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-analytics/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-analytics/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-analytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-analytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-analytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-analytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-analytics/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-analytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-analytics/merges","archive_url":"https://api.github.com/repos/wso2/carbon-analytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-analytics/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-analytics/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-analytics/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-analytics/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-analytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-analytics/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-analytics/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-analytics/deployments","created_at":"2014-02-05T11:40:58Z","updated_at":"2018-12-17T19:37:59Z","pushed_at":"2018-12-18T10:07:18Z","git_url":"git://github.com/wso2/carbon-analytics.git","ssh_url":"git@github.com:wso2/carbon-analytics.git","clone_url":"https://github.com/wso2/carbon-analytics.git","svn_url":"https://github.com/wso2/carbon-analytics","homepage":null,"size":103591,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":151,"open_issues":49,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533"},"html":{"href":"https://github.com/wso2/carbon-analytics/pull/1533"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-analytics/issues/1533"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-analytics/issues/1533/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-analytics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-analytics/pulls/1533/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-analytics/statuses/97aff2523a4468759c33ce94e34dd1c88ea092af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PradeepaJey1"}}