{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68582","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68582/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68582/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68582/events","html_url":"https://github.com/kubernetes/kubernetes/pull/68582","id":359661547,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTAzMTUx","number":68582,"title":"Fixes golint for pkg/probe","user":{"login":"jonfriesen","id":2105302,"node_id":"MDQ6VXNlcjIxMDUzMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2105302?v=4","gravatar_id":"","url":"https://api.github.com/users/jonfriesen","html_url":"https://github.com/jonfriesen","followers_url":"https://api.github.com/users/jonfriesen/followers","following_url":"https://api.github.com/users/jonfriesen/following{/other_user}","gists_url":"https://api.github.com/users/jonfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonfriesen/subscriptions","organizations_url":"https://api.github.com/users/jonfriesen/orgs","repos_url":"https://api.github.com/users/jonfriesen/repos","events_url":"https://api.github.com/users/jonfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/jonfriesen/received_events","type":"User","site_admin":false},"labels":[{"id":116719829,"node_id":"MDU6TGFiZWwxMTY3MTk4Mjk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubelet","name":"area/kubelet","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493665,"node_id":"MDU6TGFiZWwxNzM0OTM2NjU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false},{"id":253450934,"node_id":"MDU6TGFiZWwyNTM0NTA5MzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-09-12T21:35:21Z","updated_at":"2018-10-09T22:04:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68582","html_url":"https://github.com/kubernetes/kubernetes/pull/68582","diff_url":"https://github.com/kubernetes/kubernetes/pull/68582.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68582.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR removes golint errors in the pkg/probe package. Part of this is that it renamed the Prober interfaces in the following to fix the golint stutter warning:\r\n\r\n- http.HTTPProber -> http.Prober\r\n- http.HTTPGetInterface -> http.GetHTTPInterface\r\n- tcp.TCPProber -> tcp.Prober\r\n- exec.ExecProber -> exec.Prober\r\n\r\n\r\n**Which issue(s) this PR fixes**:\r\nrefer #68026\r\n\r\n**Special notes for your reviewer**:\r\nThis is my first contribution. I did a project wide search for the exported interfaces and functions that I changed and updated all of them. I'm concerned these might break external code and I'm not immediately sure on how to ensure that I do not.\r\n\r\nI left the internal variables with the type defined for contextual reference within the package on purpose, as it provided a bit of context. \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/428369114","html_url":"https://github.com/kubernetes/kubernetes/pull/68582#issuecomment-428369114","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68582","id":428369114,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODM2OTExNA==","user":{"login":"jonfriesen","id":2105302,"node_id":"MDQ6VXNlcjIxMDUzMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2105302?v=4","gravatar_id":"","url":"https://api.github.com/users/jonfriesen","html_url":"https://github.com/jonfriesen","followers_url":"https://api.github.com/users/jonfriesen/followers","following_url":"https://api.github.com/users/jonfriesen/following{/other_user}","gists_url":"https://api.github.com/users/jonfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonfriesen/subscriptions","organizations_url":"https://api.github.com/users/jonfriesen/orgs","repos_url":"https://api.github.com/users/jonfriesen/repos","events_url":"https://api.github.com/users/jonfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/jonfriesen/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T22:04:48Z","updated_at":"2018-10-09T22:04:48Z","author_association":"NONE","body":"/assign @neolit123 "}}
{"actor":{"display_login":"jonfriesen"}}