{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/211553198","pull_request_review_id":147994605,"id":211553198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU1MzE5OA==","diff_hunk":"@@ -253,19 +337,44 @@ def async_create_access_token(self,\n         \"\"\"Create a login flow.\"\"\"\n         auth_provider = self._providers[handler]\n \n-        return await auth_provider.async_credential_flow(context)\n+        return await auth_provider.async_login_flow(context)\n \n     async def _async_finish_login_flow(\n-            self, context: Optional[Dict], result: Dict[str, Any]) \\\n-            -> Optional[models.Credentials]:\n-        \"\"\"Result of a credential login flow.\"\"\"\n+            self, flow: LoginFlow, result: Dict[str, Any]) \\\n+            -> Dict[str, Any]:\n+        \"\"\"Return a user as result of login flow.\"\"\"","path":"homeassistant/auth/__init__.py","position":182,"original_position":182,"commit_id":"a6f19b6049937f7408aea33b5061046f568aafc6","original_commit_id":"a6f19b6049937f7408aea33b5061046f568aafc6","user":{"login":"balloob","id":1444314,"node_id":"MDQ6VXNlcjE0NDQzMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"body":"So I am slightly confused why we are even making changes for this method?\r\n\r\nAll auth provider login flows will create `async_start_mfa(flow_result)`. The MFA flow will show more forms if necessary and eventually will pass the original flow result on if MFA has passed. That means that this method will not see any new data?","created_at":"2018-08-21T10:19:18Z","updated_at":"2018-08-21T10:19:18Z","html_url":"https://github.com/home-assistant/home-assistant/pull/15489#discussion_r211553198","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/211553198"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/15489#discussion_r211553198"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489"}},"in_reply_to_id":211550517},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489","id":201639983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNjM5OTgz","html_url":"https://github.com/home-assistant/home-assistant/pull/15489","diff_url":"https://github.com/home-assistant/home-assistant/pull/15489.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/15489.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/15489","number":15489,"state":"open","locked":false,"title":"Add multi-factor authentication modules","user":{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false},"body":"## Description:\r\nAdd multi-factor authentication support for new auth system.\r\n\r\n### Auth module\r\nMulti-factor auth modules has been added to auth/modules folder. \r\n\r\n~~totp is Time-based One Time Password module which compatible with Google Authenticator and Authy (not test yet). ~~ will be included in separate PR\r\n\r\n`insecure_example` is a Example designed for demo and unit testing purpose, should not be used in any production system.\r\n\r\nMulti-facot auth module can be used mixed-match with auth providers. After normal auth provider validate, if there are auth modules enabled for the specific user, the login flow will direct to auth module input form. Auth module use separated storage, can be hardening it in future.\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [developers.home-assistant.io](https://github.com/home-assistant/developers.home-assistant) with documentation (if applicable):** home-assistant/developers.home-assistant#52\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n# configuration.yaml\r\nhomeassistant:\r\n  # Auth Provider\r\n  auth_providers:\r\n    - type: homeassistant\r\n  auth_mfa_modules:\r\n    - type: totp\r\n\r\n\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [developers.home-assistant.io](https://github.com/home-assistant/developers.home-assistant)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-07-16T13:36:44Z","updated_at":"2018-08-21T10:19:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f3e48a1d195c221a6b4b70b48da19c85e4ff8e9","assignee":{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false},"assignees":[{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":537677982,"node_id":"MDU6TGFiZWw1Mzc2Nzc5ODI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20config","name":"component: config","color":"ededed","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/15489/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a6f19b6049937f7408aea33b5061046f568aafc6","head":{"label":"awarecan:auth-2fa-v2","ref":"auth-2fa-v2","sha":"a6f19b6049937f7408aea33b5061046f568aafc6","user":{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false},"repo":{"id":131656182,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2NTYxODI=","name":"home-assistant","full_name":"awarecan/home-assistant","owner":{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awarecan/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/awarecan/home-assistant","forks_url":"https://api.github.com/repos/awarecan/home-assistant/forks","keys_url":"https://api.github.com/repos/awarecan/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awarecan/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awarecan/home-assistant/teams","hooks_url":"https://api.github.com/repos/awarecan/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/awarecan/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/awarecan/home-assistant/events","assignees_url":"https://api.github.com/repos/awarecan/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/awarecan/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/awarecan/home-assistant/tags","blobs_url":"https://api.github.com/repos/awarecan/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awarecan/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awarecan/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/awarecan/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awarecan/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/awarecan/home-assistant/languages","stargazers_url":"https://api.github.com/repos/awarecan/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/awarecan/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/awarecan/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/awarecan/home-assistant/subscription","commits_url":"https://api.github.com/repos/awarecan/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/awarecan/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/awarecan/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/awarecan/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/awarecan/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/awarecan/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awarecan/home-assistant/merges","archive_url":"https://api.github.com/repos/awarecan/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awarecan/home-assistant/downloads","issues_url":"https://api.github.com/repos/awarecan/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/awarecan/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/awarecan/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/awarecan/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awarecan/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/awarecan/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/awarecan/home-assistant/deployments","created_at":"2018-04-30T23:20:49Z","updated_at":"2018-08-17T02:32:14Z","pushed_at":"2018-08-21T07:49:36Z","git_url":"git://github.com/awarecan/home-assistant.git","ssh_url":"git@github.com:awarecan/home-assistant.git","clone_url":"https://github.com/awarecan/home-assistant.git","svn_url":"https://github.com/awarecan/home-assistant","homepage":"https://home-assistant.io","size":86565,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"dbd0763f83d0857fceb00e2c973a4ec91663ddcf","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-08-21T09:42:13Z","pushed_at":"2018-08-21T09:44:00Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":86431,"stargazers_count":15768,"watchers_count":15768,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4722,"mirror_url":null,"archived":false,"open_issues_count":812,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4722,"open_issues":812,"watchers":15768,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/15489"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/15489"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/15489/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15489/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/a6f19b6049937f7408aea33b5061046f568aafc6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"balloob"}}