{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/comments/183046692","pull_request_review_id":113966852,"id":183046692,"diff_hunk":"@@ -16,32 +16,33 @@\n \n package sdil.controllers.variation\n \n-import play.api.i18n.{I18nSupport, MessagesApi}\n+import play.api.i18n.MessagesApi\n import play.api.mvc.{Action, AnyContent}\n import sdil.actions.VariationAction\n import sdil.config.AppConfig\n import sdil.controllers.RadioFormController\n import uk.gov.hmrc.http.cache.client.SessionCache\n-import uk.gov.hmrc.play.bootstrap.controller.FrontendController\n import views.html.softdrinksindustrylevy.register.radio_button\n \n-import scala.concurrent.Future\n-\n class CopackForOthersController(val messagesApi: MessagesApi,\n-                                cache: SessionCache,\n+                                val cache: SessionCache,\n                                 variationAction: VariationAction)\n                                (implicit config: AppConfig)\n-  extends FrontendController with I18nSupport {\n+  extends Journey {\n \n-  def show: Action[AnyContent] = variationAction { implicit request =>\n+  def show: Action[AnyContent] = variationAction.async { implicit request =>\n     val filledForm = RadioFormController.form.fill(request.data.copackForOthers)\n-\n-    Ok(radio_button(filledForm, \"packageCopack\", backLink, submitAction))\n+    backLink(routes.CopackForOthersController.show()) map { link =>\n+      Ok(radio_button(filledForm, \"packageCopack\", link, submitAction))\n+    }\n   }\n \n   def submit: Action[AnyContent] = variationAction.async { implicit request =>\n     RadioFormController.form.bindFromRequest().fold(\n-      errors => Future.successful(BadRequest(radio_button(errors, \"packageCopack\", backLink, submitAction))),\n+      errors =>\n+        backLink(routes.CopackForOthersController.show()) map { link =>","path":"app/sdil/controllers/variation/CopackForOthersController.scala","position":38,"original_position":38,"commit_id":"bd381e9a41ab97d629ed50a923329c2091646007","original_commit_id":"bd381e9a41ab97d629ed50a923329c2091646007","user":{"login":"richard-dennehy","id":14271785,"avatar_url":"https://avatars0.githubusercontent.com/u/14271785?v=4","gravatar_id":"","url":"https://api.github.com/users/richard-dennehy","html_url":"https://github.com/richard-dennehy","followers_url":"https://api.github.com/users/richard-dennehy/followers","following_url":"https://api.github.com/users/richard-dennehy/following{/other_user}","gists_url":"https://api.github.com/users/richard-dennehy/gists{/gist_id}","starred_url":"https://api.github.com/users/richard-dennehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richard-dennehy/subscriptions","organizations_url":"https://api.github.com/users/richard-dennehy/orgs","repos_url":"https://api.github.com/users/richard-dennehy/repos","events_url":"https://api.github.com/users/richard-dennehy/events{/privacy}","received_events_url":"https://api.github.com/users/richard-dennehy/received_events","type":"User","site_admin":false},"body":"is it necessary to save the back link on every form POST?\r\n\r\nit looks to me like this will result in a lot of unnecessary calls to keystore","created_at":"2018-04-20T13:17:56Z","updated_at":"2018-04-20T13:26:02Z","html_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend/pull/216#discussion_r183046692","pull_request_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/comments/183046692"},"html":{"href":"https://github.com/hmrc/soft-drinks-industry-levy-frontend/pull/216#discussion_r183046692"},"pull_request":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216","id":183048855,"html_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend/pull/216","diff_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend/pull/216.diff","patch_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend/pull/216.patch","issue_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/216","number":216,"state":"open","locked":false,"title":"Sdil 1375 warehouses and packaging variations","user":{"login":"adamdye-hmrc","id":31273792,"avatar_url":"https://avatars1.githubusercontent.com/u/31273792?v=4","gravatar_id":"","url":"https://api.github.com/users/adamdye-hmrc","html_url":"https://github.com/adamdye-hmrc","followers_url":"https://api.github.com/users/adamdye-hmrc/followers","following_url":"https://api.github.com/users/adamdye-hmrc/following{/other_user}","gists_url":"https://api.github.com/users/adamdye-hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/adamdye-hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamdye-hmrc/subscriptions","organizations_url":"https://api.github.com/users/adamdye-hmrc/orgs","repos_url":"https://api.github.com/users/adamdye-hmrc/repos","events_url":"https://api.github.com/users/adamdye-hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/adamdye-hmrc/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-20T12:34:01Z","updated_at":"2018-04-20T13:26:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e97fbcfc16253dfd77abe236e2782e0d95a8c5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216/commits","review_comments_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216/comments","review_comment_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/216/comments","statuses_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/statuses/bd381e9a41ab97d629ed50a923329c2091646007","head":{"label":"hmrc:SDIL-1375-warehouses-and-packaging-variations","ref":"SDIL-1375-warehouses-and-packaging-variations","sha":"bd381e9a41ab97d629ed50a923329c2091646007","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":87920785,"name":"soft-drinks-industry-levy-frontend","full_name":"hmrc/soft-drinks-industry-levy-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend","forks_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/deployments","created_at":"2017-04-11T10:23:02Z","updated_at":"2018-04-17T10:54:49Z","pushed_at":"2018-04-20T12:34:01Z","git_url":"git://github.com/hmrc/soft-drinks-industry-levy-frontend.git","ssh_url":"git@github.com:hmrc/soft-drinks-industry-levy-frontend.git","clone_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend.git","svn_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend","homepage":"","size":7904,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"d4a9b4152ce3a0d63c62f88c423ac9d37f0fc100","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":87920785,"name":"soft-drinks-industry-levy-frontend","full_name":"hmrc/soft-drinks-industry-levy-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend","forks_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/deployments","created_at":"2017-04-11T10:23:02Z","updated_at":"2018-04-17T10:54:49Z","pushed_at":"2018-04-20T12:34:01Z","git_url":"git://github.com/hmrc/soft-drinks-industry-levy-frontend.git","ssh_url":"git@github.com:hmrc/soft-drinks-industry-levy-frontend.git","clone_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend.git","svn_url":"https://github.com/hmrc/soft-drinks-industry-levy-frontend","homepage":"","size":7904,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216"},"html":{"href":"https://github.com/hmrc/soft-drinks-industry-levy-frontend/pull/216"},"issue":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/216"},"comments":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/soft-drinks-industry-levy-frontend/statuses/bd381e9a41ab97d629ed50a923329c2091646007"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"richard-dennehy"}}