{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/6951","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/6951/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/6951/comments","events_url":"https://api.github.com/repos/helm/charts/issues/6951/events","html_url":"https://github.com/helm/charts/pull/6951","id":346805528,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTgwMzg0","number":6951,"title":"[stable/concourse] Upgrade to Concourse 4","user":{"login":"wendorf","id":407342,"node_id":"MDQ6VXNlcjQwNzM0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/407342?v=4","gravatar_id":"","url":"https://api.github.com/users/wendorf","html_url":"https://github.com/wendorf","followers_url":"https://api.github.com/users/wendorf/followers","following_url":"https://api.github.com/users/wendorf/following{/other_user}","gists_url":"https://api.github.com/users/wendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/wendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendorf/subscriptions","organizations_url":"https://api.github.com/users/wendorf/orgs","repos_url":"https://api.github.com/users/wendorf/repos","events_url":"https://api.github.com/users/wendorf/events{/privacy}","received_events_url":"https://api.github.com/users/wendorf/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":{"login":"william-tran","id":1084441,"node_id":"MDQ6VXNlcjEwODQ0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1084441?v=4","gravatar_id":"","url":"https://api.github.com/users/william-tran","html_url":"https://github.com/william-tran","followers_url":"https://api.github.com/users/william-tran/followers","following_url":"https://api.github.com/users/william-tran/following{/other_user}","gists_url":"https://api.github.com/users/william-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/william-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-tran/subscriptions","organizations_url":"https://api.github.com/users/william-tran/orgs","repos_url":"https://api.github.com/users/william-tran/repos","events_url":"https://api.github.com/users/william-tran/events{/privacy}","received_events_url":"https://api.github.com/users/william-tran/received_events","type":"User","site_admin":false},"assignees":[{"login":"william-tran","id":1084441,"node_id":"MDQ6VXNlcjEwODQ0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1084441?v=4","gravatar_id":"","url":"https://api.github.com/users/william-tran","html_url":"https://github.com/william-tran","followers_url":"https://api.github.com/users/william-tran/followers","following_url":"https://api.github.com/users/william-tran/following{/other_user}","gists_url":"https://api.github.com/users/william-tran/gists{/gist_id}","starred_url":"https://api.github.com/users/william-tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/william-tran/subscriptions","organizations_url":"https://api.github.com/users/william-tran/orgs","repos_url":"https://api.github.com/users/william-tran/repos","events_url":"https://api.github.com/users/william-tran/events{/privacy}","received_events_url":"https://api.github.com/users/william-tran/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-08-01T23:25:38Z","updated_at":"2018-08-31T20:35:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6951","html_url":"https://github.com/helm/charts/pull/6951","diff_url":"https://github.com/helm/charts/pull/6951.diff","patch_url":"https://github.com/helm/charts/pull/6951.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nSupports the recently-released Concourse 4, and drops support for versions earlier than 4.0.0\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #6873\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis is a big PR, potentially too big. I've split up the pieces of work into individual commits, so can easily remove pieces if needed. I've tried to capture all the desires in #6873, including removing old parameters not supported in 4.0. I have left one deprecated parameter, `CONCOURSE_POSTGRES_DATA_SOURCE`, because it's a little painful to change all of the documentation and usage to use the new split-up parameters, and this was already becoming a big PR. If that's something we would like, though, I can certainly do the work and update this PR."},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/417782258","html_url":"https://github.com/helm/charts/pull/6951#issuecomment-417782258","issue_url":"https://api.github.com/repos/helm/charts/issues/6951","id":417782258,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzc4MjI1OA==","user":{"login":"wendorf","id":407342,"node_id":"MDQ6VXNlcjQwNzM0Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/407342?v=4","gravatar_id":"","url":"https://api.github.com/users/wendorf","html_url":"https://github.com/wendorf","followers_url":"https://api.github.com/users/wendorf/followers","following_url":"https://api.github.com/users/wendorf/following{/other_user}","gists_url":"https://api.github.com/users/wendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/wendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendorf/subscriptions","organizations_url":"https://api.github.com/users/wendorf/orgs","repos_url":"https://api.github.com/users/wendorf/repos","events_url":"https://api.github.com/users/wendorf/events{/privacy}","received_events_url":"https://api.github.com/users/wendorf/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T20:35:37Z","updated_at":"2018-08-31T20:35:37Z","author_association":"CONTRIBUTOR","body":"Yeah, if I switch to setting `CONCOURSE_POSTGRES_HOST`, `CONCOURSE_POSTGRES_USER`, `CONCOURSE_POSTGRES_PASSWORD`, and `CONCOURSE_POSTGRES_DATABASE` it works. I'd submit that fix quickly, but I want to understand if `CONCOURSE_POSTGRES_DATA_SOURCE` is totally broken, especially since we suggest people do that when providing an external data source."}}
{"actor":{"display_login":"wendorf"}}