{"action":"created","comment":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/225609779","pull_request_review_id":165247272,"id":225609779,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTYwOTc3OQ==","diff_hunk":"@@ -23,7 +23,9 @@\n     \"clean\": \"rimraf target && rimraf dist && rimraf build2\",\n     \"lint:report\": \"grunt lint --checkstyle\",\n     \"lint\": \"grunt lint\",\n-    \"test\": \"grunt test\",\n+    \"test\": \"grunt generate-config && karma start\",","path":"package.json","position":5,"original_position":5,"commit_id":"82dd1ff29c146d78ce9d5fa5406648f2e77e6c5a","original_commit_id":"61b7e58cc2cc483483bc1859e13dac8b2f7e0e31","user":{"login":"jmelberg-okta","id":20212241,"node_id":"MDQ6VXNlcjIwMjEyMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/20212241?v=4","gravatar_id":"","url":"https://api.github.com/users/jmelberg-okta","html_url":"https://github.com/jmelberg-okta","followers_url":"https://api.github.com/users/jmelberg-okta/followers","following_url":"https://api.github.com/users/jmelberg-okta/following{/other_user}","gists_url":"https://api.github.com/users/jmelberg-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmelberg-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmelberg-okta/subscriptions","organizations_url":"https://api.github.com/users/jmelberg-okta/orgs","repos_url":"https://api.github.com/users/jmelberg-okta/repos","events_url":"https://api.github.com/users/jmelberg-okta/events{/privacy}","received_events_url":"https://api.github.com/users/jmelberg-okta/received_events","type":"User","site_admin":false},"body":"Gotcha. Just so I understand what you're thinking: we're going to push devs to run `yarn test` when they're developing locally and/or debugging tests. Keeping the karma-runner open should allow them to update tests in real time, where the `autoWatch` option will execute tests on file changes.\r\n\r\nThe idea of keeping the test-runner open after running `yarn test` seems strange to me, as I would expect a `test` script to exit with a `0` or `1` exit code. However, if this is common in other libraries I'm happy to add it.\r\n\r\nAs an alternative, I have seen this option as a \"debug\" mode in other libraries - maybe something like `test:dev` would be more clear for other developers?","created_at":"2018-10-16T16:13:20Z","updated_at":"2018-10-16T16:14:43Z","html_url":"https://github.com/okta/okta-signin-widget/pull/562#discussion_r225609779","pull_request_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments/225609779"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/562#discussion_r225609779"},"pull_request":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562"}},"in_reply_to_id":225259103},"pull_request":{"url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562","id":222623858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjIzODU4","html_url":"https://github.com/okta/okta-signin-widget/pull/562","diff_url":"https://github.com/okta/okta-signin-widget/pull/562.diff","patch_url":"https://github.com/okta/okta-signin-widget/pull/562.patch","issue_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/562","number":562,"state":"open","locked":false,"title":":art: Deprecates grunt-jasmine by Karma","user":{"login":"haishengwu-okta","id":13139863,"node_id":"MDQ6VXNlcjEzMTM5ODYz","avatar_url":"https://avatars0.githubusercontent.com/u/13139863?v=4","gravatar_id":"","url":"https://api.github.com/users/haishengwu-okta","html_url":"https://github.com/haishengwu-okta","followers_url":"https://api.github.com/users/haishengwu-okta/followers","following_url":"https://api.github.com/users/haishengwu-okta/following{/other_user}","gists_url":"https://api.github.com/users/haishengwu-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/haishengwu-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haishengwu-okta/subscriptions","organizations_url":"https://api.github.com/users/haishengwu-okta/orgs","repos_url":"https://api.github.com/users/haishengwu-okta/repos","events_url":"https://api.github.com/users/haishengwu-okta/events{/privacy}","received_events_url":"https://api.github.com/users/haishengwu-okta/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n- Deprecates grunt-jasmine by karma runner. \r\n  Only work in chrome but **NOT in FF/IE** due to flakiness. Will keep working on it in some follow up PRs.\r\n- Why not jest? probably in the future.\r\n  For now we're probably focusing on x-browser tests and easy migration.\r\n\r\n","created_at":"2018-10-13T03:12:36Z","updated_at":"2018-10-16T16:14:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad0fe6f3ef6b758be7a82467aa08e08f42bcbe35","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mauriciocastillosilva-okta","id":6979296,"node_id":"MDQ6VXNlcjY5NzkyOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6979296?v=4","gravatar_id":"","url":"https://api.github.com/users/mauriciocastillosilva-okta","html_url":"https://github.com/mauriciocastillosilva-okta","followers_url":"https://api.github.com/users/mauriciocastillosilva-okta/followers","following_url":"https://api.github.com/users/mauriciocastillosilva-okta/following{/other_user}","gists_url":"https://api.github.com/users/mauriciocastillosilva-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriciocastillosilva-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriciocastillosilva-okta/subscriptions","organizations_url":"https://api.github.com/users/mauriciocastillosilva-okta/orgs","repos_url":"https://api.github.com/users/mauriciocastillosilva-okta/repos","events_url":"https://api.github.com/users/mauriciocastillosilva-okta/events{/privacy}","received_events_url":"https://api.github.com/users/mauriciocastillosilva-okta/received_events","type":"User","site_admin":false},{"login":"nikhilvenkatraman-okta","id":23267876,"node_id":"MDQ6VXNlcjIzMjY3ODc2","avatar_url":"https://avatars3.githubusercontent.com/u/23267876?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhilvenkatraman-okta","html_url":"https://github.com/nikhilvenkatraman-okta","followers_url":"https://api.github.com/users/nikhilvenkatraman-okta/followers","following_url":"https://api.github.com/users/nikhilvenkatraman-okta/following{/other_user}","gists_url":"https://api.github.com/users/nikhilvenkatraman-okta/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilvenkatraman-okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilvenkatraman-okta/subscriptions","organizations_url":"https://api.github.com/users/nikhilvenkatraman-okta/orgs","repos_url":"https://api.github.com/users/nikhilvenkatraman-okta/repos","events_url":"https://api.github.com/users/nikhilvenkatraman-okta/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilvenkatraman-okta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562/commits","review_comments_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562/comments","review_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/562/comments","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/82dd1ff29c146d78ce9d5fa5406648f2e77e6c5a","head":{"label":"okta:hw-play-karma","ref":"hw-play-karma","sha":"82dd1ff29c146d78ce9d5fa5406648f2e77e6c5a","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","private":false,"owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-10-15T21:00:23Z","pushed_at":"2018-10-16T16:03:26Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":19967,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":94,"open_issues":48,"watchers":77,"default_branch":"master"}},"base":{"label":"okta:master","ref":"master","sha":"6a943ff66472afa76dbf8b459d9c45519126f2ee","user":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"repo":{"id":46365690,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM2NTY5MA==","name":"okta-signin-widget","full_name":"okta/okta-signin-widget","private":false,"owner":{"login":"okta","id":362460,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MjQ2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/362460?v=4","gravatar_id":"","url":"https://api.github.com/users/okta","html_url":"https://github.com/okta","followers_url":"https://api.github.com/users/okta/followers","following_url":"https://api.github.com/users/okta/following{/other_user}","gists_url":"https://api.github.com/users/okta/gists{/gist_id}","starred_url":"https://api.github.com/users/okta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okta/subscriptions","organizations_url":"https://api.github.com/users/okta/orgs","repos_url":"https://api.github.com/users/okta/repos","events_url":"https://api.github.com/users/okta/events{/privacy}","received_events_url":"https://api.github.com/users/okta/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/okta/okta-signin-widget","description":"Okta SignIn widget that renders the new login/auth/recovery flows","fork":false,"url":"https://api.github.com/repos/okta/okta-signin-widget","forks_url":"https://api.github.com/repos/okta/okta-signin-widget/forks","keys_url":"https://api.github.com/repos/okta/okta-signin-widget/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okta/okta-signin-widget/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okta/okta-signin-widget/teams","hooks_url":"https://api.github.com/repos/okta/okta-signin-widget/hooks","issue_events_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/events{/number}","events_url":"https://api.github.com/repos/okta/okta-signin-widget/events","assignees_url":"https://api.github.com/repos/okta/okta-signin-widget/assignees{/user}","branches_url":"https://api.github.com/repos/okta/okta-signin-widget/branches{/branch}","tags_url":"https://api.github.com/repos/okta/okta-signin-widget/tags","blobs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okta/okta-signin-widget/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okta/okta-signin-widget/git/refs{/sha}","trees_url":"https://api.github.com/repos/okta/okta-signin-widget/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okta/okta-signin-widget/statuses/{sha}","languages_url":"https://api.github.com/repos/okta/okta-signin-widget/languages","stargazers_url":"https://api.github.com/repos/okta/okta-signin-widget/stargazers","contributors_url":"https://api.github.com/repos/okta/okta-signin-widget/contributors","subscribers_url":"https://api.github.com/repos/okta/okta-signin-widget/subscribers","subscription_url":"https://api.github.com/repos/okta/okta-signin-widget/subscription","commits_url":"https://api.github.com/repos/okta/okta-signin-widget/commits{/sha}","git_commits_url":"https://api.github.com/repos/okta/okta-signin-widget/git/commits{/sha}","comments_url":"https://api.github.com/repos/okta/okta-signin-widget/comments{/number}","issue_comment_url":"https://api.github.com/repos/okta/okta-signin-widget/issues/comments{/number}","contents_url":"https://api.github.com/repos/okta/okta-signin-widget/contents/{+path}","compare_url":"https://api.github.com/repos/okta/okta-signin-widget/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okta/okta-signin-widget/merges","archive_url":"https://api.github.com/repos/okta/okta-signin-widget/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okta/okta-signin-widget/downloads","issues_url":"https://api.github.com/repos/okta/okta-signin-widget/issues{/number}","pulls_url":"https://api.github.com/repos/okta/okta-signin-widget/pulls{/number}","milestones_url":"https://api.github.com/repos/okta/okta-signin-widget/milestones{/number}","notifications_url":"https://api.github.com/repos/okta/okta-signin-widget/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okta/okta-signin-widget/labels{/name}","releases_url":"https://api.github.com/repos/okta/okta-signin-widget/releases{/id}","deployments_url":"https://api.github.com/repos/okta/okta-signin-widget/deployments","created_at":"2015-11-17T18:08:41Z","updated_at":"2018-10-15T21:00:23Z","pushed_at":"2018-10-16T16:03:26Z","git_url":"git://github.com/okta/okta-signin-widget.git","ssh_url":"git@github.com:okta/okta-signin-widget.git","clone_url":"https://github.com/okta/okta-signin-widget.git","svn_url":"https://github.com/okta/okta-signin-widget","homepage":null,"size":19967,"stargazers_count":77,"watchers_count":77,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":94,"open_issues":48,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562"},"html":{"href":"https://github.com/okta/okta-signin-widget/pull/562"},"issue":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/562"},"comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okta/okta-signin-widget/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/okta/okta-signin-widget/statuses/82dd1ff29c146d78ce9d5fa5406648f2e77e6c5a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmelberg-okta"}}