{"action":"closed","number":1323,"pull_request":{"url":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/1323","id":172476262,"html_url":"https://github.com/AyuntamientoMadrid/consul/pull/1323","diff_url":"https://github.com/AyuntamientoMadrid/consul/pull/1323.diff","patch_url":"https://github.com/AyuntamientoMadrid/consul/pull/1323.patch","issue_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues/1323","number":1323,"state":"closed","locked":false,"title":"Hunt the flaky - Tracking Tracking pages Codes","user":{"login":"iagirre","id":31625251,"avatar_url":"https://avatars3.githubusercontent.com/u/31625251?v=4","gravatar_id":"","url":"https://api.github.com/users/iagirre","html_url":"https://github.com/iagirre","followers_url":"https://api.github.com/users/iagirre/followers","following_url":"https://api.github.com/users/iagirre/following{/other_user}","gists_url":"https://api.github.com/users/iagirre/gists{/gist_id}","starred_url":"https://api.github.com/users/iagirre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iagirre/subscriptions","organizations_url":"https://api.github.com/users/iagirre/orgs","repos_url":"https://api.github.com/users/iagirre/repos","events_url":"https://api.github.com/users/iagirre/events{/privacy}","received_events_url":"https://api.github.com/users/iagirre/received_events","type":"User","site_admin":false},"body":"Where\r\n=====\r\n* **Related Issue:** #1175 (this PR closes #1175)\r\n\r\nWhat\r\n====\r\nFix the flaky that appeared in `spec/features/tracks_spec.rb:304`.\r\n\r\nHow\r\n===\r\n### Explain why the spec was flaky, or under which conditions/scenario it failed randomly\r\n\r\nThis flaky was related to JS files that are been loaded in the page.\r\nIn my opinion, the continuous visits to different pages don't let the JavaScript files load correctly, so, sometimes, the page need some code that has not been loaded yet. That caused some different errors, not only the ones related to CKEDITOR (I really think they all have the same origin).\r\n\r\n```\r\nTracking Tracking pages Codes\r\n     Failure/Error: visit \"proposals\"\r\n     \r\n     Capybara::Poltergeist::JavascriptError:\r\n       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).\r\n     \r\n       TypeError: undefined is not an object (evaluating 'c[a].dir=c.rtl[a]?\"rtl\":\"ltr\"')\r\n       TypeError: undefined is not an object (evaluating 'c[a].dir=c.rtl[a]?\"rtl\":\"ltr\"')\r\n           at http://127.0.0.1:37131/assets/application-b83f044ca54db32bceefe13374a0ea2b8a5eae440216a1304f66efa0181df814.js:32375 in d\r\n\t\t[...]\r\n```\r\n\r\n```\r\nTracking Tracking pages Codes\r\n     Failure/Error: visit \"proposals\"\r\n     \r\n     Capybara::Poltergeist::JavascriptError:\r\n       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).\r\n     \r\n       Error: [CKEDITOR.resourceManager.load] Resource name \"default\" was not found at \"http://127.0.0.1:43747/assets/ckeditor/styles.js?t=H5SC\".\r\n       Error: [CKEDITOR.resourceManager.load] Resource name \"default\" was not found at \"http://127.0.0.1:43747/assets/ckeditor/styles.js?t=H5SC\".\r\n           at http://127.0.0.1:43747/assets/application-b83f044ca54db32bceefe13374a0ea2b8a5eae440216a1304f66efa0181df814.js:32381\r\n           [...]\r\n```\r\n\r\n### Explain why your PR fixes it\r\n\r\nThis solution splits the large test in several small ones. This let each visit has its own scenario, where the JS files are not been mixed between calls and loaded correctly. \r\n\r\nScreenshots\r\n===========\r\nThere aren't, it's a flaky.\r\n\r\nTest\r\n====\r\nThe test has been splited in several smaller tests to minify the risk of overlapping one call with the next one.\r\n\r\nDeployment\r\n==========\r\nNothing to apply.\r\n\r\nWarnings\r\n========\r\nNothing to apply.\r\n","created_at":"2018-03-02T11:02:44Z","updated_at":"2018-03-06T15:18:51Z","closed_at":"2018-03-06T15:18:51Z","merged_at":"2018-03-06T15:18:51Z","merge_commit_sha":"45123cdd4f5c0a2a801c2c118d6146c1348892d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/1323/commits","review_comments_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/1323/comments","review_comment_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues/1323/comments","statuses_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/statuses/bd9b5dddcb4a3b7405f07708ef557d8a1a6c1add","head":{"label":"wairbut-m2c-aytomadrid:1175-flaky-tracking-tracking-pages-codes","ref":"1175-flaky-tracking-tracking-pages-codes","sha":"bd9b5dddcb4a3b7405f07708ef557d8a1a6c1add","user":{"login":"wairbut-m2c-aytomadrid","id":36006872,"avatar_url":"https://avatars3.githubusercontent.com/u/36006872?v=4","gravatar_id":"","url":"https://api.github.com/users/wairbut-m2c-aytomadrid","html_url":"https://github.com/wairbut-m2c-aytomadrid","followers_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/followers","following_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/following{/other_user}","gists_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/gists{/gist_id}","starred_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/subscriptions","organizations_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/orgs","repos_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/repos","events_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/events{/privacy}","received_events_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/received_events","type":"Organization","site_admin":false},"repo":{"id":119714863,"name":"consul","full_name":"wairbut-m2c-aytomadrid/consul","owner":{"login":"wairbut-m2c-aytomadrid","id":36006872,"avatar_url":"https://avatars3.githubusercontent.com/u/36006872?v=4","gravatar_id":"","url":"https://api.github.com/users/wairbut-m2c-aytomadrid","html_url":"https://github.com/wairbut-m2c-aytomadrid","followers_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/followers","following_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/following{/other_user}","gists_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/gists{/gist_id}","starred_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/subscriptions","organizations_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/orgs","repos_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/repos","events_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/events{/privacy}","received_events_url":"https://api.github.com/users/wairbut-m2c-aytomadrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wairbut-m2c-aytomadrid/consul","description":"Consul - Gobierno abierto del Ayuntamiento de Madrid","fork":true,"url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul","forks_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/forks","keys_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/teams","hooks_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/hooks","issue_events_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/issues/events{/number}","events_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/events","assignees_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/assignees{/user}","branches_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/branches{/branch}","tags_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/tags","blobs_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/languages","stargazers_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/stargazers","contributors_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/contributors","subscribers_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/subscribers","subscription_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/subscription","commits_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/contents/{+path}","compare_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/merges","archive_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/downloads","issues_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/issues{/number}","pulls_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/labels{/name}","releases_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/releases{/id}","deployments_url":"https://api.github.com/repos/wairbut-m2c-aytomadrid/consul/deployments","created_at":"2018-01-31T16:44:30Z","updated_at":"2018-02-01T08:13:07Z","pushed_at":"2018-03-06T14:46:57Z","git_url":"git://github.com/wairbut-m2c-aytomadrid/consul.git","ssh_url":"git@github.com:wairbut-m2c-aytomadrid/consul.git","clone_url":"https://github.com/wairbut-m2c-aytomadrid/consul.git","svn_url":"https://github.com/wairbut-m2c-aytomadrid/consul","homepage":"https://decide.madrid.es/","size":1905294,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AyuntamientoMadrid:master","ref":"master","sha":"832e057ffb9ccc0302727ffa4c8d737fcdb383e4","user":{"login":"AyuntamientoMadrid","id":13286342,"avatar_url":"https://avatars3.githubusercontent.com/u/13286342?v=4","gravatar_id":"","url":"https://api.github.com/users/AyuntamientoMadrid","html_url":"https://github.com/AyuntamientoMadrid","followers_url":"https://api.github.com/users/AyuntamientoMadrid/followers","following_url":"https://api.github.com/users/AyuntamientoMadrid/following{/other_user}","gists_url":"https://api.github.com/users/AyuntamientoMadrid/gists{/gist_id}","starred_url":"https://api.github.com/users/AyuntamientoMadrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AyuntamientoMadrid/subscriptions","organizations_url":"https://api.github.com/users/AyuntamientoMadrid/orgs","repos_url":"https://api.github.com/users/AyuntamientoMadrid/repos","events_url":"https://api.github.com/users/AyuntamientoMadrid/events{/privacy}","received_events_url":"https://api.github.com/users/AyuntamientoMadrid/received_events","type":"Organization","site_admin":false},"repo":{"id":46575779,"name":"consul","full_name":"AyuntamientoMadrid/consul","owner":{"login":"AyuntamientoMadrid","id":13286342,"avatar_url":"https://avatars3.githubusercontent.com/u/13286342?v=4","gravatar_id":"","url":"https://api.github.com/users/AyuntamientoMadrid","html_url":"https://github.com/AyuntamientoMadrid","followers_url":"https://api.github.com/users/AyuntamientoMadrid/followers","following_url":"https://api.github.com/users/AyuntamientoMadrid/following{/other_user}","gists_url":"https://api.github.com/users/AyuntamientoMadrid/gists{/gist_id}","starred_url":"https://api.github.com/users/AyuntamientoMadrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AyuntamientoMadrid/subscriptions","organizations_url":"https://api.github.com/users/AyuntamientoMadrid/orgs","repos_url":"https://api.github.com/users/AyuntamientoMadrid/repos","events_url":"https://api.github.com/users/AyuntamientoMadrid/events{/privacy}","received_events_url":"https://api.github.com/users/AyuntamientoMadrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AyuntamientoMadrid/consul","description":"Consul - Gobierno abierto del Ayuntamiento de Madrid","fork":true,"url":"https://api.github.com/repos/AyuntamientoMadrid/consul","forks_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/forks","keys_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/teams","hooks_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/hooks","issue_events_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues/events{/number}","events_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/events","assignees_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/assignees{/user}","branches_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/branches{/branch}","tags_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/tags","blobs_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/languages","stargazers_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/stargazers","contributors_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/contributors","subscribers_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/subscribers","subscription_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/subscription","commits_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/contents/{+path}","compare_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/merges","archive_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/downloads","issues_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues{/number}","pulls_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/labels{/name}","releases_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/releases{/id}","deployments_url":"https://api.github.com/repos/AyuntamientoMadrid/consul/deployments","created_at":"2015-11-20T17:10:12Z","updated_at":"2018-02-26T13:25:18Z","pushed_at":"2018-03-06T15:18:51Z","git_url":"git://github.com/AyuntamientoMadrid/consul.git","ssh_url":"git@github.com:AyuntamientoMadrid/consul.git","clone_url":"https://github.com/AyuntamientoMadrid/consul.git","svn_url":"https://github.com/AyuntamientoMadrid/consul","homepage":"https://decide.madrid.es/","size":1905290,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":15,"open_issues":96,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/1323"},"html":{"href":"https://github.com/AyuntamientoMadrid/consul/pull/1323"},"issue":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues/1323"},"comments":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/issues/1323/comments"},"review_comments":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/1323/comments"},"review_comment":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/pulls/1323/commits"},"statuses":{"href":"https://api.github.com/repos/AyuntamientoMadrid/consul/statuses/bd9b5dddcb4a3b7405f07708ef557d8a1a6c1add"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"voodoorai2000","id":4169,"avatar_url":"https://avatars3.githubusercontent.com/u/4169?v=4","gravatar_id":"","url":"https://api.github.com/users/voodoorai2000","html_url":"https://github.com/voodoorai2000","followers_url":"https://api.github.com/users/voodoorai2000/followers","following_url":"https://api.github.com/users/voodoorai2000/following{/other_user}","gists_url":"https://api.github.com/users/voodoorai2000/gists{/gist_id}","starred_url":"https://api.github.com/users/voodoorai2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voodoorai2000/subscriptions","organizations_url":"https://api.github.com/users/voodoorai2000/orgs","repos_url":"https://api.github.com/users/voodoorai2000/repos","events_url":"https://api.github.com/users/voodoorai2000/events{/privacy}","received_events_url":"https://api.github.com/users/voodoorai2000/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":49,"deletions":24,"changed_files":1}}
{"actor":{"display_login":"voodoorai2000"}}