{"action":"created","comment":{"url":"https://api.github.com/repos/u-root/u-root/pulls/comments/167638367","pull_request_review_id":95885940,"id":167638367,"diff_hunk":"@@ -41,3 +42,29 @@ func CompileInTempDir(t testing.TB) (tmpDir string, execPath string) {\n \t}\n \treturn\n }\n+\n+// ErrorExists is only used to increase readability of future tests","path":"pkg/testutil/testutil.go","position":null,"original_position":13,"commit_id":"e3c59a8f989844631fa8dfeec42553706b99025b","original_commit_id":"56ad4bd635c118e0b7c1bedeb0308e42af628e75","user":{"login":"thienhoang23","id":14992972,"avatar_url":"https://avatars2.githubusercontent.com/u/14992972?v=4","gravatar_id":"","url":"https://api.github.com/users/thienhoang23","html_url":"https://github.com/thienhoang23","followers_url":"https://api.github.com/users/thienhoang23/followers","following_url":"https://api.github.com/users/thienhoang23/following{/other_user}","gists_url":"https://api.github.com/users/thienhoang23/gists{/gist_id}","starred_url":"https://api.github.com/users/thienhoang23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thienhoang23/subscriptions","organizations_url":"https://api.github.com/users/thienhoang23/orgs","repos_url":"https://api.github.com/users/thienhoang23/repos","events_url":"https://api.github.com/users/thienhoang23/events{/privacy}","received_events_url":"https://api.github.com/users/thienhoang23/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-02-12T18:05:23Z","updated_at":"2018-02-12T18:05:23Z","html_url":"https://github.com/u-root/u-root/pull/594#discussion_r167638367","pull_request_url":"https://api.github.com/repos/u-root/u-root/pulls/594","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments/167638367"},"html":{"href":"https://github.com/u-root/u-root/pull/594#discussion_r167638367"},"pull_request":{"href":"https://api.github.com/repos/u-root/u-root/pulls/594"}},"in_reply_to_id":167388625},"pull_request":{"url":"https://api.github.com/repos/u-root/u-root/pulls/594","id":168367297,"html_url":"https://github.com/u-root/u-root/pull/594","diff_url":"https://github.com/u-root/u-root/pull/594.diff","patch_url":"https://github.com/u-root/u-root/pull/594.patch","issue_url":"https://api.github.com/repos/u-root/u-root/issues/594","number":594,"state":"open","locked":false,"title":"Write wpa/passphrase pkg in Go and use it inside wifi cmd","user":{"login":"thienhoang23","id":14992972,"avatar_url":"https://avatars2.githubusercontent.com/u/14992972?v=4","gravatar_id":"","url":"https://api.github.com/users/thienhoang23","html_url":"https://github.com/thienhoang23","followers_url":"https://api.github.com/users/thienhoang23/followers","following_url":"https://api.github.com/users/thienhoang23/following{/other_user}","gists_url":"https://api.github.com/users/thienhoang23/gists{/gist_id}","starred_url":"https://api.github.com/users/thienhoang23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thienhoang23/subscriptions","organizations_url":"https://api.github.com/users/thienhoang23/orgs","repos_url":"https://api.github.com/users/thienhoang23/repos","events_url":"https://api.github.com/users/thienhoang23/events{/privacy}","received_events_url":"https://api.github.com/users/thienhoang23/received_events","type":"User","site_admin":false},"body":"Also, refactor test helper functions in wifi_test.go into testutil pkg and reuse it in passphrase_test.go\r\n\r\nSigned-off-by: Thien Hoang <thienhoang@google.com>","created_at":"2018-02-09T23:37:10Z","updated_at":"2018-02-12T18:05:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9af52c2b383d755fb76b6149656a36294bb21212","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bkochendorfer","id":1072933,"avatar_url":"https://avatars2.githubusercontent.com/u/1072933?v=4","gravatar_id":"","url":"https://api.github.com/users/bkochendorfer","html_url":"https://github.com/bkochendorfer","followers_url":"https://api.github.com/users/bkochendorfer/followers","following_url":"https://api.github.com/users/bkochendorfer/following{/other_user}","gists_url":"https://api.github.com/users/bkochendorfer/gists{/gist_id}","starred_url":"https://api.github.com/users/bkochendorfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkochendorfer/subscriptions","organizations_url":"https://api.github.com/users/bkochendorfer/orgs","repos_url":"https://api.github.com/users/bkochendorfer/repos","events_url":"https://api.github.com/users/bkochendorfer/events{/privacy}","received_events_url":"https://api.github.com/users/bkochendorfer/received_events","type":"User","site_admin":false},{"login":"bensallen","id":1652762,"avatar_url":"https://avatars1.githubusercontent.com/u/1652762?v=4","gravatar_id":"","url":"https://api.github.com/users/bensallen","html_url":"https://github.com/bensallen","followers_url":"https://api.github.com/users/bensallen/followers","following_url":"https://api.github.com/users/bensallen/following{/other_user}","gists_url":"https://api.github.com/users/bensallen/gists{/gist_id}","starred_url":"https://api.github.com/users/bensallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensallen/subscriptions","organizations_url":"https://api.github.com/users/bensallen/orgs","repos_url":"https://api.github.com/users/bensallen/repos","events_url":"https://api.github.com/users/bensallen/events{/privacy}","received_events_url":"https://api.github.com/users/bensallen/received_events","type":"User","site_admin":false},{"login":"erfanian","id":1850896,"avatar_url":"https://avatars3.githubusercontent.com/u/1850896?v=4","gravatar_id":"","url":"https://api.github.com/users/erfanian","html_url":"https://github.com/erfanian","followers_url":"https://api.github.com/users/erfanian/followers","following_url":"https://api.github.com/users/erfanian/following{/other_user}","gists_url":"https://api.github.com/users/erfanian/gists{/gist_id}","starred_url":"https://api.github.com/users/erfanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erfanian/subscriptions","organizations_url":"https://api.github.com/users/erfanian/orgs","repos_url":"https://api.github.com/users/erfanian/repos","events_url":"https://api.github.com/users/erfanian/events{/privacy}","received_events_url":"https://api.github.com/users/erfanian/received_events","type":"User","site_admin":false},{"login":"hugelgupf","id":1994130,"avatar_url":"https://avatars2.githubusercontent.com/u/1994130?v=4","gravatar_id":"","url":"https://api.github.com/users/hugelgupf","html_url":"https://github.com/hugelgupf","followers_url":"https://api.github.com/users/hugelgupf/followers","following_url":"https://api.github.com/users/hugelgupf/following{/other_user}","gists_url":"https://api.github.com/users/hugelgupf/gists{/gist_id}","starred_url":"https://api.github.com/users/hugelgupf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hugelgupf/subscriptions","organizations_url":"https://api.github.com/users/hugelgupf/orgs","repos_url":"https://api.github.com/users/hugelgupf/repos","events_url":"https://api.github.com/users/hugelgupf/events{/privacy}","received_events_url":"https://api.github.com/users/hugelgupf/received_events","type":"User","site_admin":false},{"login":"rjoleary","id":2763535,"avatar_url":"https://avatars3.githubusercontent.com/u/2763535?v=4","gravatar_id":"","url":"https://api.github.com/users/rjoleary","html_url":"https://github.com/rjoleary","followers_url":"https://api.github.com/users/rjoleary/followers","following_url":"https://api.github.com/users/rjoleary/following{/other_user}","gists_url":"https://api.github.com/users/rjoleary/gists{/gist_id}","starred_url":"https://api.github.com/users/rjoleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjoleary/subscriptions","organizations_url":"https://api.github.com/users/rjoleary/orgs","repos_url":"https://api.github.com/users/rjoleary/repos","events_url":"https://api.github.com/users/rjoleary/events{/privacy}","received_events_url":"https://api.github.com/users/rjoleary/received_events","type":"User","site_admin":false},{"login":"GanShun","id":3449939,"avatar_url":"https://avatars3.githubusercontent.com/u/3449939?v=4","gravatar_id":"","url":"https://api.github.com/users/GanShun","html_url":"https://github.com/GanShun","followers_url":"https://api.github.com/users/GanShun/followers","following_url":"https://api.github.com/users/GanShun/following{/other_user}","gists_url":"https://api.github.com/users/GanShun/gists{/gist_id}","starred_url":"https://api.github.com/users/GanShun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GanShun/subscriptions","organizations_url":"https://api.github.com/users/GanShun/orgs","repos_url":"https://api.github.com/users/GanShun/repos","events_url":"https://api.github.com/users/GanShun/events{/privacy}","received_events_url":"https://api.github.com/users/GanShun/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/u-root/u-root/pulls/594/commits","review_comments_url":"https://api.github.com/repos/u-root/u-root/pulls/594/comments","review_comment_url":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/u-root/u-root/issues/594/comments","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/e3c59a8f989844631fa8dfeec42553706b99025b","head":{"label":"thienhoang23:wpa/passphrase","ref":"wpa/passphrase","sha":"e3c59a8f989844631fa8dfeec42553706b99025b","user":{"login":"thienhoang23","id":14992972,"avatar_url":"https://avatars2.githubusercontent.com/u/14992972?v=4","gravatar_id":"","url":"https://api.github.com/users/thienhoang23","html_url":"https://github.com/thienhoang23","followers_url":"https://api.github.com/users/thienhoang23/followers","following_url":"https://api.github.com/users/thienhoang23/following{/other_user}","gists_url":"https://api.github.com/users/thienhoang23/gists{/gist_id}","starred_url":"https://api.github.com/users/thienhoang23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thienhoang23/subscriptions","organizations_url":"https://api.github.com/users/thienhoang23/orgs","repos_url":"https://api.github.com/users/thienhoang23/repos","events_url":"https://api.github.com/users/thienhoang23/events{/privacy}","received_events_url":"https://api.github.com/users/thienhoang23/received_events","type":"User","site_admin":false},"repo":{"id":119456874,"name":"u-root","full_name":"thienhoang23/u-root","owner":{"login":"thienhoang23","id":14992972,"avatar_url":"https://avatars2.githubusercontent.com/u/14992972?v=4","gravatar_id":"","url":"https://api.github.com/users/thienhoang23","html_url":"https://github.com/thienhoang23","followers_url":"https://api.github.com/users/thienhoang23/followers","following_url":"https://api.github.com/users/thienhoang23/following{/other_user}","gists_url":"https://api.github.com/users/thienhoang23/gists{/gist_id}","starred_url":"https://api.github.com/users/thienhoang23/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thienhoang23/subscriptions","organizations_url":"https://api.github.com/users/thienhoang23/orgs","repos_url":"https://api.github.com/users/thienhoang23/repos","events_url":"https://api.github.com/users/thienhoang23/events{/privacy}","received_events_url":"https://api.github.com/users/thienhoang23/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thienhoang23/u-root","description":"A universal root: u-root creates a root file system (initramfs) containing a busybox-like set of tools in Go.","fork":true,"url":"https://api.github.com/repos/thienhoang23/u-root","forks_url":"https://api.github.com/repos/thienhoang23/u-root/forks","keys_url":"https://api.github.com/repos/thienhoang23/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thienhoang23/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thienhoang23/u-root/teams","hooks_url":"https://api.github.com/repos/thienhoang23/u-root/hooks","issue_events_url":"https://api.github.com/repos/thienhoang23/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/thienhoang23/u-root/events","assignees_url":"https://api.github.com/repos/thienhoang23/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/thienhoang23/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/thienhoang23/u-root/tags","blobs_url":"https://api.github.com/repos/thienhoang23/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thienhoang23/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thienhoang23/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/thienhoang23/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thienhoang23/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/thienhoang23/u-root/languages","stargazers_url":"https://api.github.com/repos/thienhoang23/u-root/stargazers","contributors_url":"https://api.github.com/repos/thienhoang23/u-root/contributors","subscribers_url":"https://api.github.com/repos/thienhoang23/u-root/subscribers","subscription_url":"https://api.github.com/repos/thienhoang23/u-root/subscription","commits_url":"https://api.github.com/repos/thienhoang23/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/thienhoang23/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/thienhoang23/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/thienhoang23/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/thienhoang23/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/thienhoang23/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thienhoang23/u-root/merges","archive_url":"https://api.github.com/repos/thienhoang23/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thienhoang23/u-root/downloads","issues_url":"https://api.github.com/repos/thienhoang23/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/thienhoang23/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/thienhoang23/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/thienhoang23/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thienhoang23/u-root/labels{/name}","releases_url":"https://api.github.com/repos/thienhoang23/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/thienhoang23/u-root/deployments","created_at":"2018-01-29T23:48:13Z","updated_at":"2018-01-29T23:48:15Z","pushed_at":"2018-02-12T18:03:09Z","git_url":"git://github.com/thienhoang23/u-root.git","ssh_url":"git@github.com:thienhoang23/u-root.git","clone_url":"https://github.com/thienhoang23/u-root.git","svn_url":"https://github.com/thienhoang23/u-root","homepage":"http://u-root.tk","size":31987,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"u-root:master","ref":"master","sha":"901297bd0a33b370211d22dd0b768438f7dba191","user":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"repo":{"id":46462030,"name":"u-root","full_name":"u-root/u-root","owner":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/u-root/u-root","description":"A universal root: u-root creates a root file system (initramfs) containing a busybox-like set of tools in Go.","fork":false,"url":"https://api.github.com/repos/u-root/u-root","forks_url":"https://api.github.com/repos/u-root/u-root/forks","keys_url":"https://api.github.com/repos/u-root/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u-root/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u-root/u-root/teams","hooks_url":"https://api.github.com/repos/u-root/u-root/hooks","issue_events_url":"https://api.github.com/repos/u-root/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/u-root/u-root/events","assignees_url":"https://api.github.com/repos/u-root/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/u-root/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/u-root/u-root/tags","blobs_url":"https://api.github.com/repos/u-root/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u-root/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u-root/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/u-root/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/u-root/u-root/languages","stargazers_url":"https://api.github.com/repos/u-root/u-root/stargazers","contributors_url":"https://api.github.com/repos/u-root/u-root/contributors","subscribers_url":"https://api.github.com/repos/u-root/u-root/subscribers","subscription_url":"https://api.github.com/repos/u-root/u-root/subscription","commits_url":"https://api.github.com/repos/u-root/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/u-root/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/u-root/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/u-root/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/u-root/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/u-root/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u-root/u-root/merges","archive_url":"https://api.github.com/repos/u-root/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u-root/u-root/downloads","issues_url":"https://api.github.com/repos/u-root/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/u-root/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/u-root/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/u-root/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u-root/u-root/labels{/name}","releases_url":"https://api.github.com/repos/u-root/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/u-root/u-root/deployments","created_at":"2015-11-19T02:28:59Z","updated_at":"2018-02-12T05:32:38Z","pushed_at":"2018-02-12T18:03:10Z","git_url":"git://github.com/u-root/u-root.git","ssh_url":"git@github.com:u-root/u-root.git","clone_url":"https://github.com/u-root/u-root.git","svn_url":"https://github.com/u-root/u-root","homepage":"http://u-root.tk","size":33221,"stargazers_count":497,"watchers_count":497,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":69,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":71,"open_issues":69,"watchers":497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/594"},"html":{"href":"https://github.com/u-root/u-root/pull/594"},"issue":{"href":"https://api.github.com/repos/u-root/u-root/issues/594"},"comments":{"href":"https://api.github.com/repos/u-root/u-root/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/u-root/u-root/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/u-root/u-root/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/u-root/u-root/statuses/e3c59a8f989844631fa8dfeec42553706b99025b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thienhoang23"}}