{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/vyper/issues/1084","repository_url":"https://api.github.com/repos/ethereum/vyper","labels_url":"https://api.github.com/repos/ethereum/vyper/issues/1084/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/vyper/issues/1084/comments","events_url":"https://api.github.com/repos/ethereum/vyper/issues/1084/events","html_url":"https://github.com/ethereum/vyper/issues/1084","id":381214502,"node_id":"MDU6SXNzdWUzODEyMTQ1MDI=","number":1084,"title":"Refactor conversion tests into one `test_type_conversions.py`","user":{"login":"jakerockland","id":8602661,"node_id":"MDQ6VXNlcjg2MDI2NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8602661?v=4","gravatar_id":"","url":"https://api.github.com/users/jakerockland","html_url":"https://github.com/jakerockland","followers_url":"https://api.github.com/users/jakerockland/followers","following_url":"https://api.github.com/users/jakerockland/following{/other_user}","gists_url":"https://api.github.com/users/jakerockland/gists{/gist_id}","starred_url":"https://api.github.com/users/jakerockland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakerockland/subscriptions","organizations_url":"https://api.github.com/users/jakerockland/orgs","repos_url":"https://api.github.com/users/jakerockland/repos","events_url":"https://api.github.com/users/jakerockland/events{/privacy}","received_events_url":"https://api.github.com/users/jakerockland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-15T15:32:58Z","updated_at":"2018-11-15T16:14:39Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Version Information\r\n\r\n* vyper Version: 0.1.0b4\r\n\r\n### What's your issue about?\r\n\r\nCurrently the tests for testing type conversion are spread across different files corresponding to either the type being converted from, or the type being converted to. This is a bit confusing for adding new functionality/reviewing the tests as it is unclear if the tests should be in the test file for the type being converted from or that being converted to.\r\n\r\n### How can it be fixed?\r\n\r\nWe create a new test file `test_type_conversions.py` in the `types` test directory and refactor all related type conversion tests to be located there.\r\n\r\n#### Cute Animal Picture\r\n\r\n![image](https://user-images.githubusercontent.com/8602661/48563210-083ef800-e8b1-11e8-8870-fad6746de9c0.png)\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/vyper/issues/comments/439096590","html_url":"https://github.com/ethereum/vyper/issues/1084#issuecomment-439096590","issue_url":"https://api.github.com/repos/ethereum/vyper/issues/1084","id":439096590,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTA5NjU5MA==","user":{"login":"jakerockland","id":8602661,"node_id":"MDQ6VXNlcjg2MDI2NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/8602661?v=4","gravatar_id":"","url":"https://api.github.com/users/jakerockland","html_url":"https://github.com/jakerockland","followers_url":"https://api.github.com/users/jakerockland/followers","following_url":"https://api.github.com/users/jakerockland/following{/other_user}","gists_url":"https://api.github.com/users/jakerockland/gists{/gist_id}","starred_url":"https://api.github.com/users/jakerockland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakerockland/subscriptions","organizations_url":"https://api.github.com/users/jakerockland/orgs","repos_url":"https://api.github.com/users/jakerockland/repos","events_url":"https://api.github.com/users/jakerockland/events{/privacy}","received_events_url":"https://api.github.com/users/jakerockland/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T16:14:39Z","updated_at":"2018-11-15T16:14:39Z","author_association":"CONTRIBUTOR","body":"Rad, I'll do this after #1077, #1082, and #1085 are all ready for merge to avoid merge conflicts haha."}}
{"actor":{"display_login":"jakerockland"}}