{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/14981","repository_url":"https://api.github.com/repos/sympy/sympy","labels_url":"https://api.github.com/repos/sympy/sympy/issues/14981/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/14981/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/14981/events","html_url":"https://github.com/sympy/sympy/pull/14981","id":345157468,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzc4Nzk0","number":14981,"title":"Add quotient methods","user":{"login":"RavicharanN","id":22046387,"node_id":"MDQ6VXNlcjIyMDQ2Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/22046387?v=4","gravatar_id":"","url":"https://api.github.com/users/RavicharanN","html_url":"https://github.com/RavicharanN","followers_url":"https://api.github.com/users/RavicharanN/followers","following_url":"https://api.github.com/users/RavicharanN/following{/other_user}","gists_url":"https://api.github.com/users/RavicharanN/gists{/gist_id}","starred_url":"https://api.github.com/users/RavicharanN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RavicharanN/subscriptions","organizations_url":"https://api.github.com/users/RavicharanN/orgs","repos_url":"https://api.github.com/users/RavicharanN/repos","events_url":"https://api.github.com/users/RavicharanN/events{/privacy}","received_events_url":"https://api.github.com/users/RavicharanN/received_events","type":"User","site_admin":false},"labels":[{"id":222449974,"node_id":"MDU6TGFiZWwyMjI0NDk5NzQ=","url":"https://api.github.com/repos/sympy/sympy/labels/PR:%20author's%20turn","name":"PR: author's turn","color":"ffff80","default":false},{"id":84627391,"node_id":"MDU6TGFiZWw4NDYyNzM5MQ==","url":"https://api.github.com/repos/sympy/sympy/labels/combinatorics","name":"combinatorics","color":"0000FF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-27T09:33:01Z","updated_at":"2018-08-05T11:35:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/14981","html_url":"https://github.com/sympy/sympy/pull/14981","diff_url":"https://github.com/sympy/sympy/pull/14981.diff","patch_url":"https://github.com/sympy/sympy/pull/14981.patch"},"body":"<!-- Your title above should be a short description of what\r\nwas changed. Do not include the issue number in the title. -->\r\n\r\n<!-- If this pull request fixes an issue, write \"Fixes #NNNN\" in that exact\r\nformat, e.g. \"Fixes #1234\". See\r\nhttps://github.com/blog/1506-closing-issues-via-pull-requests .-->\r\n\r\n\r\n#### Brief description of what is fixed or changed\r\nAdd quotient methods for `FpGroup`s. \r\n\r\n\r\n#### To-do\r\n* Add methods for epimorphism quotients. \r\n* Add tests. \r\n\r\n#### Release Notes\r\n\r\n<!-- Write the release notes for this release below. See\r\nhttps://github.com/sympy/sympy/wiki/Writing-Release-Notes for more information\r\non how to write release notes. If there is no release notes entry for this PR,\r\nwrite \"NO ENTRY\". The bot will check your release notes automatically to see\r\nif they are formatted correctly. -->\r\n\r\n<!-- BEGIN RELEASE NOTES -->\r\n* combinatorics\r\n   * It is now possible to compute subgroup quotient and the maximal abelian quotients of an `FpGroup`. \r\n<!-- END RELEASE NOTES -->\r\n"},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/410514140","html_url":"https://github.com/sympy/sympy/pull/14981#issuecomment-410514140","issue_url":"https://api.github.com/repos/sympy/sympy/issues/14981","id":410514140,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDUxNDE0MA==","user":{"login":"valglad","id":20492235,"node_id":"MDQ6VXNlcjIwNDkyMjM1","avatar_url":"https://avatars0.githubusercontent.com/u/20492235?v=4","gravatar_id":"","url":"https://api.github.com/users/valglad","html_url":"https://github.com/valglad","followers_url":"https://api.github.com/users/valglad/followers","following_url":"https://api.github.com/users/valglad/following{/other_user}","gists_url":"https://api.github.com/users/valglad/gists{/gist_id}","starred_url":"https://api.github.com/users/valglad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valglad/subscriptions","organizations_url":"https://api.github.com/users/valglad/orgs","repos_url":"https://api.github.com/users/valglad/repos","events_url":"https://api.github.com/users/valglad/events{/privacy}","received_events_url":"https://api.github.com/users/valglad/received_events","type":"User","site_admin":false},"created_at":"2018-08-05T11:35:49Z","updated_at":"2018-08-05T11:35:49Z","author_association":"CONTRIBUTOR","body":"The test coverage should be improved - for example, there are no tests for quotient methods that use `G` and `H` as lists and specify a parent group and test if the homomorphism works properly. `find_homomorphism` could do with a test on finding injections."}}
{"actor":{"display_login":"valglad"}}