{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/230564117","pull_request_review_id":171337416,"id":230564117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU2NDExNw==","diff_hunk":"@@ -318,11 +318,11 @@ export class WorkspaceService implements FrontendApplicationContribution {\n     /**\n      * Clears current workspace root.\n      */\n-    close(): void {\n+    async close(): Promise<void> {\n         this._workspace = undefined;\n         this._roots.length = 0;\n \n-        this.server.setMostRecentlyUsedWorkspace('');","path":"packages/workspace/src/browser/workspace-service.ts","position":9,"original_position":9,"commit_id":"3cdabbc8a8eb230963716b8c0be8948e4da8be57","original_commit_id":"3cdabbc8a8eb230963716b8c0be8948e4da8be57","user":{"login":"elaihau","id":37082801,"node_id":"MDQ6VXNlcjM3MDgyODAx","avatar_url":"https://avatars1.githubusercontent.com/u/37082801?v=4","gravatar_id":"","url":"https://api.github.com/users/elaihau","html_url":"https://github.com/elaihau","followers_url":"https://api.github.com/users/elaihau/followers","following_url":"https://api.github.com/users/elaihau/following{/other_user}","gists_url":"https://api.github.com/users/elaihau/gists{/gist_id}","starred_url":"https://api.github.com/users/elaihau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elaihau/subscriptions","organizations_url":"https://api.github.com/users/elaihau/orgs","repos_url":"https://api.github.com/users/elaihau/repos","events_url":"https://api.github.com/users/elaihau/events{/privacy}","received_events_url":"https://api.github.com/users/elaihau/received_events","type":"User","site_admin":false},"body":"Maybe we could talk on Monday in person. Like Simon, I don't really understand the difference.","created_at":"2018-11-03T18:44:39Z","updated_at":"2018-11-03T18:44:39Z","html_url":"https://github.com/theia-ide/theia/pull/3386#discussion_r230564117","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/3386","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/230564117"},"html":{"href":"https://github.com/theia-ide/theia/pull/3386#discussion_r230564117"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3386"}}},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/3386","id":228053950,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDUzOTUw","html_url":"https://github.com/theia-ide/theia/pull/3386","diff_url":"https://github.com/theia-ide/theia/pull/3386.diff","patch_url":"https://github.com/theia-ide/theia/pull/3386.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/3386","number":3386,"state":"open","locked":false,"title":"Fix 'Close Workspace'","user":{"login":"vince-fugnitto","id":40359487,"node_id":"MDQ6VXNlcjQwMzU5NDg3","avatar_url":"https://avatars2.githubusercontent.com/u/40359487?v=4","gravatar_id":"","url":"https://api.github.com/users/vince-fugnitto","html_url":"https://github.com/vince-fugnitto","followers_url":"https://api.github.com/users/vince-fugnitto/followers","following_url":"https://api.github.com/users/vince-fugnitto/following{/other_user}","gists_url":"https://api.github.com/users/vince-fugnitto/gists{/gist_id}","starred_url":"https://api.github.com/users/vince-fugnitto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vince-fugnitto/subscriptions","organizations_url":"https://api.github.com/users/vince-fugnitto/orgs","repos_url":"https://api.github.com/users/vince-fugnitto/repos","events_url":"https://api.github.com/users/vince-fugnitto/events{/privacy}","received_events_url":"https://api.github.com/users/vince-fugnitto/received_events","type":"User","site_admin":false},"body":"Fixes #2662\r\n\r\n- Fixed issue with the command `Close Workspace` which did not work on all browsers\r\n- Since the function `setMostRecentlyUsedWorkspace` returns a Promise, it was necessary to `await` until the data is saved in `recentWorkspace.json` before reloading Theia\r\n\r\nSigned-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>\r\n\r\n<!-- Please provide a clear and meaningful description to the CHANGELOG.md file if this PR contributes some significant changes -->\r\n","created_at":"2018-11-02T20:42:44Z","updated_at":"2018-11-03T18:44:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09f9d0b0b3375e135379098ab9c14d2f744aa793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":547099386,"node_id":"MDU6TGFiZWw1NDcwOTkzODY=","url":"https://api.github.com/repos/theia-ide/theia/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/3386/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/3386/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/3386/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/3cdabbc8a8eb230963716b8c0be8948e4da8be57","head":{"label":"theia-ide:fix-close-workspace","ref":"fix-close-workspace","sha":"3cdabbc8a8eb230963716b8c0be8948e4da8be57","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","private":false,"owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-11-03T18:23:31Z","pushed_at":"2018-11-03T14:07:50Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":111636,"stargazers_count":1792,"watchers_count":1792,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":704,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":260,"open_issues":704,"watchers":1792,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"e8dd128c25294b23741cc345067952ef7cd85864","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","private":false,"owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-11-03T18:23:31Z","pushed_at":"2018-11-03T14:07:50Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":111636,"stargazers_count":1792,"watchers_count":1792,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"archived":false,"open_issues_count":704,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":260,"open_issues":704,"watchers":1792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3386"},"html":{"href":"https://github.com/theia-ide/theia/pull/3386"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/3386"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/3386/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3386/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/3386/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/3cdabbc8a8eb230963716b8c0be8948e4da8be57"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"elaihau"}}