{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/21552","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/21552/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/21552/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/21552/events","html_url":"https://github.com/mantidproject/mantid/pull/21552","id":288562209,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYyOTI3ODM5","number":21552,"title":"RefineSatellitePeaks algorithm for WISH","user":{"login":"samueljackson92","id":2487781,"node_id":"MDQ6VXNlcjI0ODc3ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/2487781?v=4","gravatar_id":"","url":"https://api.github.com/users/samueljackson92","html_url":"https://github.com/samueljackson92","followers_url":"https://api.github.com/users/samueljackson92/followers","following_url":"https://api.github.com/users/samueljackson92/following{/other_user}","gists_url":"https://api.github.com/users/samueljackson92/gists{/gist_id}","starred_url":"https://api.github.com/users/samueljackson92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueljackson92/subscriptions","organizations_url":"https://api.github.com/users/samueljackson92/orgs","repos_url":"https://api.github.com/users/samueljackson92/repos","events_url":"https://api.github.com/users/samueljackson92/events{/privacy}","received_events_url":"https://api.github.com/users/samueljackson92/received_events","type":"User","site_admin":false},"labels":[{"id":40046181,"node_id":"MDU6TGFiZWw0MDA0NjE4MQ==","url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Diffraction","name":"Component: Diffraction","color":"009800","default":false},{"id":173163694,"node_id":"MDU6TGFiZWwxNzMxNjM2OTQ=","url":"https://api.github.com/repos/mantidproject/mantid/labels/Group:%20Single%20Crystal","name":"Group: Single Crystal","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/67","html_url":"https://github.com/mantidproject/mantid/milestone/67","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/67/labels","id":3113719,"node_id":"MDk6TWlsZXN0b25lMzExMzcxOQ==","number":67,"title":"Release 3.13","description":"Code Freeze: 29th June\r\nBeta Test: 3rd-17th July","creator":{"login":"NickDraper","id":1017173,"node_id":"MDQ6VXNlcjEwMTcxNzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":219,"closed_issues":446,"state":"open","created_at":"2018-02-13T15:37:12Z","updated_at":"2018-06-29T10:59:02Z","due_on":"2018-07-23T07:00:00Z","closed_at":null},"comments":5,"created_at":"2018-01-15T11:25:20Z","updated_at":"2018-06-29T11:13:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/21552","html_url":"https://github.com/mantidproject/mantid/pull/21552","diff_url":"https://github.com/mantidproject/mantid/pull/21552.diff","patch_url":"https://github.com/mantidproject/mantid/pull/21552.patch"},"body":"**~~This should not be merged before #21551 and #22550 and #22643~~**\r\n\r\nThis adds a new python algorithm `RefineSatellitePeaks` to Mantid. Given a list of peaks with integer HKL, a small subset of \"satellite\" peaks at fractional coordinates, an MD HKL workspace, this will calculate the q vectors for each satellite and find as many of the peaks in the MD workspace as possible.\r\n\r\n\r\n**To test:**\r\nHere's a script to get you started. The data files can be found in `Scratch/Sam`:\r\n\r\n```python\r\nimport os\r\n\r\npath = \"/Users/samueljackson/data/\"\r\n\r\nsample_file = os.path.join(path, '37828_hexaferrite_vana.nxs')\r\nnuclear_peaks_file = os.path.join(path, '37828_peak_table_nuclear.nxs')\r\nsatellite_peaks_file = os.path.join(path, 'satellites.nxs')\r\n\r\nws = Load(Filename=sample_file, OutputWorkspace='37828_hexaferrite_vana')\r\nnuclear = Load(Filename=nuclear_peaks_file, OutputWorkspace='37828_peak_table_nuclear')\r\nsatellites = Load(Filename=satellite_peaks_file, OutputWorkspace='satellites_seed')\r\nCopySample(nuclear, ws, CopyEnvironment=False)\r\n\r\nws = ConvertUnits(ws, \"TOF\")\r\nregion_radius = 0.2\r\npeaks_size = 0.1\r\nbkg_inner = 0.1\r\nbkg_outer = 0.2\r\nthreshold = 2\r\n\r\nmd = ConvertToDiffractionMDWorkspace(ws, OneEventPerBin=False, OutputDimensions=\"HKL\")\r\n\r\nsatellites_refined = RefineSatellitePeaks(MainPeaks=nuclear, SatellitePeaks=satellites, MDWorkspace=md, NumOfQs=2, PeakRadius=0.3, BackgroundInnerRadius=0.3, BackgroundOuterRadius=0.4)\r\n```\r\n\r\nFixes #20883 \r\n\r\n**Release Notes** \r\n[See here]()\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/401324451","html_url":"https://github.com/mantidproject/mantid/pull/21552#issuecomment-401324451","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/21552","id":401324451,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTMyNDQ1MQ==","user":{"login":"martyngigg","id":733773,"node_id":"MDQ6VXNlcjczMzc3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/733773?v=4","gravatar_id":"","url":"https://api.github.com/users/martyngigg","html_url":"https://github.com/martyngigg","followers_url":"https://api.github.com/users/martyngigg/followers","following_url":"https://api.github.com/users/martyngigg/following{/other_user}","gists_url":"https://api.github.com/users/martyngigg/gists{/gist_id}","starred_url":"https://api.github.com/users/martyngigg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyngigg/subscriptions","organizations_url":"https://api.github.com/users/martyngigg/orgs","repos_url":"https://api.github.com/users/martyngigg/repos","events_url":"https://api.github.com/users/martyngigg/events{/privacy}","received_events_url":"https://api.github.com/users/martyngigg/received_events","type":"User","site_admin":false},"created_at":"2018-06-29T11:13:40Z","updated_at":"2018-06-29T11:13:40Z","author_association":"MEMBER","body":"@samueljackson92 We seem to have a huge number of conflicts here now. Is this required for 3.14?"}}
{"actor":{"display_login":"martyngigg"}}