{"action":"created","comment":{"url":"https://api.github.com/repos/vitessio/vitess/pulls/comments/212366440","pull_request_review_id":148983564,"id":212366440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM2NjQ0MA==","diff_hunk":"@@ -0,0 +1,57 @@\n+/*\n+Copyright 2018 The Vitess Authors\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreedto in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package callinfo","path":"go/vt/callinfo/plugin_mysql.go","position":17,"original_position":17,"commit_id":"d0ff5a9a85d6cf69c50480fb54119ce5a37be5e6","original_commit_id":"d0ff5a9a85d6cf69c50480fb54119ce5a37be5e6","user":{"login":"demmer","id":3308504,"node_id":"MDQ6VXNlcjMzMDg1MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3308504?v=4","gravatar_id":"","url":"https://api.github.com/users/demmer","html_url":"https://github.com/demmer","followers_url":"https://api.github.com/users/demmer/followers","following_url":"https://api.github.com/users/demmer/following{/other_user}","gists_url":"https://api.github.com/users/demmer/gists{/gist_id}","starred_url":"https://api.github.com/users/demmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demmer/subscriptions","organizations_url":"https://api.github.com/users/demmer/orgs","repos_url":"https://api.github.com/users/demmer/repos","events_url":"https://api.github.com/users/demmer/events{/privacy}","received_events_url":"https://api.github.com/users/demmer/received_events","type":"User","site_admin":false},"body":"It's not a \"new\" package.\r\n\r\nThe model is that there's a common `callinfo` abstraction with plugins that implement handling support for the specific transport protocols. The only existing one is grpc (though I assume Google has a stubby one) so this adds mysql as a second implementation of the model.","created_at":"2018-08-23T16:02:23Z","updated_at":"2018-08-23T16:02:23Z","html_url":"https://github.com/vitessio/vitess/pull/4153#discussion_r212366440","pull_request_url":"https://api.github.com/repos/vitessio/vitess/pulls/4153","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/comments/212366440"},"html":{"href":"https://github.com/vitessio/vitess/pull/4153#discussion_r212366440"},"pull_request":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4153"}},"in_reply_to_id":212348344},"pull_request":{"url":"https://api.github.com/repos/vitessio/vitess/pulls/4153","id":210478023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDc4MDIz","html_url":"https://github.com/vitessio/vitess/pull/4153","diff_url":"https://github.com/vitessio/vitess/pull/4153.diff","patch_url":"https://github.com/vitessio/vitess/pull/4153.patch","issue_url":"https://api.github.com/repos/vitessio/vitess/issues/4153","number":4153,"state":"open","locked":false,"title":"add a callinfo implementation for the mysql server protocol","user":{"login":"demmer","id":3308504,"node_id":"MDQ6VXNlcjMzMDg1MDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3308504?v=4","gravatar_id":"","url":"https://api.github.com/users/demmer","html_url":"https://github.com/demmer","followers_url":"https://api.github.com/users/demmer/followers","following_url":"https://api.github.com/users/demmer/following{/other_user}","gists_url":"https://api.github.com/users/demmer/gists{/gist_id}","starred_url":"https://api.github.com/users/demmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demmer/subscriptions","organizations_url":"https://api.github.com/users/demmer/orgs","repos_url":"https://api.github.com/users/demmer/repos","events_url":"https://api.github.com/users/demmer/events{/privacy}","received_events_url":"https://api.github.com/users/demmer/received_events","type":"User","site_admin":false},"body":"Building off the analogous structure for GRPC, include a callinfo\r\nimplementation so that query logs and debug output in vtgate includes\r\ncontext about the caller.\r\n\r\n","created_at":"2018-08-23T14:57:52Z","updated_at":"2018-08-23T16:02:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e064b323ef040a1c9b8d9f4e471ded481512a60d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sougou","id":589370,"node_id":"MDQ6VXNlcjU4OTM3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/589370?v=4","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false},{"login":"alainjobart","id":4625714,"node_id":"MDQ6VXNlcjQ2MjU3MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4625714?v=4","gravatar_id":"","url":"https://api.github.com/users/alainjobart","html_url":"https://github.com/alainjobart","followers_url":"https://api.github.com/users/alainjobart/followers","following_url":"https://api.github.com/users/alainjobart/following{/other_user}","gists_url":"https://api.github.com/users/alainjobart/gists{/gist_id}","starred_url":"https://api.github.com/users/alainjobart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainjobart/subscriptions","organizations_url":"https://api.github.com/users/alainjobart/orgs","repos_url":"https://api.github.com/users/alainjobart/repos","events_url":"https://api.github.com/users/alainjobart/events{/privacy}","received_events_url":"https://api.github.com/users/alainjobart/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitessio/vitess/pulls/4153/commits","review_comments_url":"https://api.github.com/repos/vitessio/vitess/pulls/4153/comments","review_comment_url":"https://api.github.com/repos/vitessio/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitessio/vitess/issues/4153/comments","statuses_url":"https://api.github.com/repos/vitessio/vitess/statuses/d0ff5a9a85d6cf69c50480fb54119ce5a37be5e6","head":{"label":"tinyspeck:mysql-server-callinfo","ref":"mysql-server-callinfo","sha":"d0ff5a9a85d6cf69c50480fb54119ce5a37be5e6","user":{"login":"tinyspeck","id":371467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTQ2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/371467?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyspeck","html_url":"https://github.com/tinyspeck","followers_url":"https://api.github.com/users/tinyspeck/followers","following_url":"https://api.github.com/users/tinyspeck/following{/other_user}","gists_url":"https://api.github.com/users/tinyspeck/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyspeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyspeck/subscriptions","organizations_url":"https://api.github.com/users/tinyspeck/orgs","repos_url":"https://api.github.com/users/tinyspeck/repos","events_url":"https://api.github.com/users/tinyspeck/events{/privacy}","received_events_url":"https://api.github.com/users/tinyspeck/received_events","type":"Organization","site_admin":false},"repo":{"id":79269846,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTg0Ng==","name":"vitess","full_name":"tinyspeck/vitess","owner":{"login":"tinyspeck","id":371467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTQ2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/371467?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyspeck","html_url":"https://github.com/tinyspeck","followers_url":"https://api.github.com/users/tinyspeck/followers","following_url":"https://api.github.com/users/tinyspeck/following{/other_user}","gists_url":"https://api.github.com/users/tinyspeck/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyspeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyspeck/subscriptions","organizations_url":"https://api.github.com/users/tinyspeck/orgs","repos_url":"https://api.github.com/users/tinyspeck/repos","events_url":"https://api.github.com/users/tinyspeck/events{/privacy}","received_events_url":"https://api.github.com/users/tinyspeck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tinyspeck/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":true,"url":"https://api.github.com/repos/tinyspeck/vitess","forks_url":"https://api.github.com/repos/tinyspeck/vitess/forks","keys_url":"https://api.github.com/repos/tinyspeck/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinyspeck/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinyspeck/vitess/teams","hooks_url":"https://api.github.com/repos/tinyspeck/vitess/hooks","issue_events_url":"https://api.github.com/repos/tinyspeck/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/tinyspeck/vitess/events","assignees_url":"https://api.github.com/repos/tinyspeck/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/tinyspeck/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/tinyspeck/vitess/tags","blobs_url":"https://api.github.com/repos/tinyspeck/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinyspeck/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinyspeck/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinyspeck/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinyspeck/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/tinyspeck/vitess/languages","stargazers_url":"https://api.github.com/repos/tinyspeck/vitess/stargazers","contributors_url":"https://api.github.com/repos/tinyspeck/vitess/contributors","subscribers_url":"https://api.github.com/repos/tinyspeck/vitess/subscribers","subscription_url":"https://api.github.com/repos/tinyspeck/vitess/subscription","commits_url":"https://api.github.com/repos/tinyspeck/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinyspeck/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinyspeck/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinyspeck/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinyspeck/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/tinyspeck/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinyspeck/vitess/merges","archive_url":"https://api.github.com/repos/tinyspeck/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinyspeck/vitess/downloads","issues_url":"https://api.github.com/repos/tinyspeck/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/tinyspeck/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/tinyspeck/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/tinyspeck/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinyspeck/vitess/labels{/name}","releases_url":"https://api.github.com/repos/tinyspeck/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/tinyspeck/vitess/deployments","created_at":"2017-01-17T20:41:49Z","updated_at":"2018-08-13T17:02:55Z","pushed_at":"2018-08-23T14:57:40Z","git_url":"git://github.com/tinyspeck/vitess.git","ssh_url":"git@github.com:tinyspeck/vitess.git","clone_url":"https://github.com/tinyspeck/vitess.git","svn_url":"https://github.com/tinyspeck/vitess","homepage":"http://vitess.io","size":98893,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vitessio:master","ref":"master","sha":"620e05cc8d2596a30d86fdf4d1df463fd8b7e713","user":{"login":"vitessio","id":33043890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDQzODkw","avatar_url":"https://avatars1.githubusercontent.com/u/33043890?v=4","gravatar_id":"","url":"https://api.github.com/users/vitessio","html_url":"https://github.com/vitessio","followers_url":"https://api.github.com/users/vitessio/followers","following_url":"https://api.github.com/users/vitessio/following{/other_user}","gists_url":"https://api.github.com/users/vitessio/gists{/gist_id}","starred_url":"https://api.github.com/users/vitessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitessio/subscriptions","organizations_url":"https://api.github.com/users/vitessio/orgs","repos_url":"https://api.github.com/users/vitessio/repos","events_url":"https://api.github.com/users/vitessio/events{/privacy}","received_events_url":"https://api.github.com/users/vitessio/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwODIwNw==","name":"vitess","full_name":"vitessio/vitess","owner":{"login":"vitessio","id":33043890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDQzODkw","avatar_url":"https://avatars1.githubusercontent.com/u/33043890?v=4","gravatar_id":"","url":"https://api.github.com/users/vitessio","html_url":"https://github.com/vitessio","followers_url":"https://api.github.com/users/vitessio/followers","following_url":"https://api.github.com/users/vitessio/following{/other_user}","gists_url":"https://api.github.com/users/vitessio/gists{/gist_id}","starred_url":"https://api.github.com/users/vitessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitessio/subscriptions","organizations_url":"https://api.github.com/users/vitessio/orgs","repos_url":"https://api.github.com/users/vitessio/repos","events_url":"https://api.github.com/users/vitessio/events{/privacy}","received_events_url":"https://api.github.com/users/vitessio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vitessio/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":false,"url":"https://api.github.com/repos/vitessio/vitess","forks_url":"https://api.github.com/repos/vitessio/vitess/forks","keys_url":"https://api.github.com/repos/vitessio/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitessio/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitessio/vitess/teams","hooks_url":"https://api.github.com/repos/vitessio/vitess/hooks","issue_events_url":"https://api.github.com/repos/vitessio/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/vitessio/vitess/events","assignees_url":"https://api.github.com/repos/vitessio/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/vitessio/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/vitessio/vitess/tags","blobs_url":"https://api.github.com/repos/vitessio/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitessio/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitessio/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitessio/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitessio/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/vitessio/vitess/languages","stargazers_url":"https://api.github.com/repos/vitessio/vitess/stargazers","contributors_url":"https://api.github.com/repos/vitessio/vitess/contributors","subscribers_url":"https://api.github.com/repos/vitessio/vitess/subscribers","subscription_url":"https://api.github.com/repos/vitessio/vitess/subscription","commits_url":"https://api.github.com/repos/vitessio/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitessio/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitessio/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitessio/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitessio/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/vitessio/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitessio/vitess/merges","archive_url":"https://api.github.com/repos/vitessio/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitessio/vitess/downloads","issues_url":"https://api.github.com/repos/vitessio/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/vitessio/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/vitessio/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/vitessio/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitessio/vitess/labels{/name}","releases_url":"https://api.github.com/repos/vitessio/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/vitessio/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2018-08-23T10:10:26Z","pushed_at":"2018-08-23T14:57:53Z","git_url":"git://github.com/vitessio/vitess.git","ssh_url":"git@github.com:vitessio/vitess.git","clone_url":"https://github.com/vitessio/vitess.git","svn_url":"https://github.com/vitessio/vitess","homepage":"http://vitess.io","size":99068,"stargazers_count":6448,"watchers_count":6448,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":826,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":826,"open_issues":220,"watchers":6448,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4153"},"html":{"href":"https://github.com/vitessio/vitess/pull/4153"},"issue":{"href":"https://api.github.com/repos/vitessio/vitess/issues/4153"},"comments":{"href":"https://api.github.com/repos/vitessio/vitess/issues/4153/comments"},"review_comments":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4153/comments"},"review_comment":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/4153/commits"},"statuses":{"href":"https://api.github.com/repos/vitessio/vitess/statuses/d0ff5a9a85d6cf69c50480fb54119ce5a37be5e6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"demmer"}}