{"action":"created","comment":{"url":"https://api.github.com/repos/systemd/systemd/pulls/comments/165584843","pull_request_review_id":93549678,"id":165584843,"diff_hunk":"@@ -94,6 +94,12 @@\n         paths. </para></listitem>\n       </varlistentry>\n \n+      <varlistentry>\n+        <term><option>--direct</option></term>","path":"man/systemd-sysusers.xml","position":null,"original_position":5,"commit_id":"b5489b8df43423087d8b6e68a06c300edc76db1f","original_commit_id":"b057132b55a1c97cddc24c94037410b2c1f57f2b","user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"body":"I think we should still avoid any potential confusion there and just use a switch with an argument...","created_at":"2018-02-02T08:40:44Z","updated_at":"2018-02-02T08:40:44Z","html_url":"https://github.com/systemd/systemd/pull/8058#discussion_r165584843","pull_request_url":"https://api.github.com/repos/systemd/systemd/pulls/8058","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments/165584843"},"html":{"href":"https://github.com/systemd/systemd/pull/8058#discussion_r165584843"},"pull_request":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8058"}},"in_reply_to_id":165124363},"pull_request":{"url":"https://api.github.com/repos/systemd/systemd/pulls/8058","id":166290729,"html_url":"https://github.com/systemd/systemd/pull/8058","diff_url":"https://github.com/systemd/systemd/pull/8058.diff","patch_url":"https://github.com/systemd/systemd/pull/8058.patch","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8058","number":8058,"state":"open","locked":false,"title":"Extend sysusers a bit to be usable for package installation scripts","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"body":"This PR makes various small fixups to logging and documentation, and adds the following functionality:\r\n- the login shell can be specified\r\n- configuration items can be specified as positional arguments\r\n- admin/runtime configuration can override arguments specified on the command line.\r\n\r\nBike-shedding on the names is encouraged: `--direct` is not convincing, but I don't have a better idea. `--config-name` seems OK.\r\n\r\nThere is one more change that I have queued up — adding a new macro:\r\n```\r\n%sysusers_create_config() \\\r\necho \"%(cat '%2')\" | systemd-sysusers --config-name='%1' - >/dev/null 2>&1 || : \\\r\n%{nil}\r\n```\r\nbut I want to give it a test in Fedora first, so I'm not submitting that yet.","created_at":"2018-01-31T15:26:11Z","updated_at":"2018-02-02T08:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c1a1a2fc15b151fa1e0da563268ba86dac0d904","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/systemd/systemd/pulls/8058/commits","review_comments_url":"https://api.github.com/repos/systemd/systemd/pulls/8058/comments","review_comment_url":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8058/comments","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/b5489b8df43423087d8b6e68a06c300edc76db1f","head":{"label":"keszybz:sysusers-inline","ref":"sysusers-inline","sha":"b5489b8df43423087d8b6e68a06c300edc76db1f","user":{"login":"keszybz","id":349618,"avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"repo":{"id":37000824,"name":"systemd","full_name":"keszybz/systemd","owner":{"login":"keszybz","id":349618,"avatar_url":"https://avatars1.githubusercontent.com/u/349618?v=4","gravatar_id":"","url":"https://api.github.com/users/keszybz","html_url":"https://github.com/keszybz","followers_url":"https://api.github.com/users/keszybz/followers","following_url":"https://api.github.com/users/keszybz/following{/other_user}","gists_url":"https://api.github.com/users/keszybz/gists{/gist_id}","starred_url":"https://api.github.com/users/keszybz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keszybz/subscriptions","organizations_url":"https://api.github.com/users/keszybz/orgs","repos_url":"https://api.github.com/users/keszybz/repos","events_url":"https://api.github.com/users/keszybz/events{/privacy}","received_events_url":"https://api.github.com/users/keszybz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/keszybz/systemd","description":"systemd upstream","fork":true,"url":"https://api.github.com/repos/keszybz/systemd","forks_url":"https://api.github.com/repos/keszybz/systemd/forks","keys_url":"https://api.github.com/repos/keszybz/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keszybz/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keszybz/systemd/teams","hooks_url":"https://api.github.com/repos/keszybz/systemd/hooks","issue_events_url":"https://api.github.com/repos/keszybz/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/keszybz/systemd/events","assignees_url":"https://api.github.com/repos/keszybz/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/keszybz/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/keszybz/systemd/tags","blobs_url":"https://api.github.com/repos/keszybz/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keszybz/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keszybz/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/keszybz/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keszybz/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/keszybz/systemd/languages","stargazers_url":"https://api.github.com/repos/keszybz/systemd/stargazers","contributors_url":"https://api.github.com/repos/keszybz/systemd/contributors","subscribers_url":"https://api.github.com/repos/keszybz/systemd/subscribers","subscription_url":"https://api.github.com/repos/keszybz/systemd/subscription","commits_url":"https://api.github.com/repos/keszybz/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/keszybz/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/keszybz/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/keszybz/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/keszybz/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/keszybz/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keszybz/systemd/merges","archive_url":"https://api.github.com/repos/keszybz/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keszybz/systemd/downloads","issues_url":"https://api.github.com/repos/keszybz/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/keszybz/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/keszybz/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/keszybz/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keszybz/systemd/labels{/name}","releases_url":"https://api.github.com/repos/keszybz/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/keszybz/systemd/deployments","created_at":"2015-06-07T01:43:08Z","updated_at":"2016-01-20T00:02:11Z","pushed_at":"2018-02-02T07:55:18Z","git_url":"git://github.com/keszybz/systemd.git","ssh_url":"git@github.com:keszybz/systemd.git","clone_url":"https://github.com/keszybz/systemd.git","svn_url":"https://github.com/keszybz/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":84666,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"systemd:master","ref":"master","sha":"75aaade16b00ff519fbaedb4cc773b654c11a34a","user":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"repo":{"id":32873313,"name":"systemd","full_name":"systemd/systemd","owner":{"login":"systemd","id":1918868,"avatar_url":"https://avatars0.githubusercontent.com/u/1918868?v=4","gravatar_id":"","url":"https://api.github.com/users/systemd","html_url":"https://github.com/systemd","followers_url":"https://api.github.com/users/systemd/followers","following_url":"https://api.github.com/users/systemd/following{/other_user}","gists_url":"https://api.github.com/users/systemd/gists{/gist_id}","starred_url":"https://api.github.com/users/systemd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systemd/subscriptions","organizations_url":"https://api.github.com/users/systemd/orgs","repos_url":"https://api.github.com/users/systemd/repos","events_url":"https://api.github.com/users/systemd/events{/privacy}","received_events_url":"https://api.github.com/users/systemd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/systemd/systemd","description":"🐧 ⚙️ – systemd System and Service Manager ","fork":false,"url":"https://api.github.com/repos/systemd/systemd","forks_url":"https://api.github.com/repos/systemd/systemd/forks","keys_url":"https://api.github.com/repos/systemd/systemd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systemd/systemd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systemd/systemd/teams","hooks_url":"https://api.github.com/repos/systemd/systemd/hooks","issue_events_url":"https://api.github.com/repos/systemd/systemd/issues/events{/number}","events_url":"https://api.github.com/repos/systemd/systemd/events","assignees_url":"https://api.github.com/repos/systemd/systemd/assignees{/user}","branches_url":"https://api.github.com/repos/systemd/systemd/branches{/branch}","tags_url":"https://api.github.com/repos/systemd/systemd/tags","blobs_url":"https://api.github.com/repos/systemd/systemd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systemd/systemd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systemd/systemd/git/refs{/sha}","trees_url":"https://api.github.com/repos/systemd/systemd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systemd/systemd/statuses/{sha}","languages_url":"https://api.github.com/repos/systemd/systemd/languages","stargazers_url":"https://api.github.com/repos/systemd/systemd/stargazers","contributors_url":"https://api.github.com/repos/systemd/systemd/contributors","subscribers_url":"https://api.github.com/repos/systemd/systemd/subscribers","subscription_url":"https://api.github.com/repos/systemd/systemd/subscription","commits_url":"https://api.github.com/repos/systemd/systemd/commits{/sha}","git_commits_url":"https://api.github.com/repos/systemd/systemd/git/commits{/sha}","comments_url":"https://api.github.com/repos/systemd/systemd/comments{/number}","issue_comment_url":"https://api.github.com/repos/systemd/systemd/issues/comments{/number}","contents_url":"https://api.github.com/repos/systemd/systemd/contents/{+path}","compare_url":"https://api.github.com/repos/systemd/systemd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systemd/systemd/merges","archive_url":"https://api.github.com/repos/systemd/systemd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systemd/systemd/downloads","issues_url":"https://api.github.com/repos/systemd/systemd/issues{/number}","pulls_url":"https://api.github.com/repos/systemd/systemd/pulls{/number}","milestones_url":"https://api.github.com/repos/systemd/systemd/milestones{/number}","notifications_url":"https://api.github.com/repos/systemd/systemd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systemd/systemd/labels{/name}","releases_url":"https://api.github.com/repos/systemd/systemd/releases{/id}","deployments_url":"https://api.github.com/repos/systemd/systemd/deployments","created_at":"2015-03-25T15:27:27Z","updated_at":"2018-02-02T02:48:47Z","pushed_at":"2018-02-02T08:33:20Z","git_url":"git://github.com/systemd/systemd.git","ssh_url":"git@github.com:systemd/systemd.git","clone_url":"https://github.com/systemd/systemd.git","svn_url":"https://github.com/systemd/systemd","homepage":"http://www.freedesktop.org/wiki/Software/systemd/","size":84634,"stargazers_count":2756,"watchers_count":2756,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1120,"mirror_url":null,"archived":false,"open_issues_count":838,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1120,"open_issues":838,"watchers":2756,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8058"},"html":{"href":"https://github.com/systemd/systemd/pull/8058"},"issue":{"href":"https://api.github.com/repos/systemd/systemd/issues/8058"},"comments":{"href":"https://api.github.com/repos/systemd/systemd/issues/8058/comments"},"review_comments":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8058/comments"},"review_comment":{"href":"https://api.github.com/repos/systemd/systemd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systemd/systemd/pulls/8058/commits"},"statuses":{"href":"https://api.github.com/repos/systemd/systemd/statuses/b5489b8df43423087d8b6e68a06c300edc76db1f"}},"author_association":"OWNER"}}
{"actor":{"display_login":"poettering"}}