{"action":"created","comment":{"url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/comments/186815916","pull_request_review_id":118470604,"id":186815916,"diff_hunk":"@@ -328,7 +327,7 @@ update-build: upload-build upload-lambdas\n \t\t\t\"ParameterKey=GitHubBranch,ParameterValue=${REPO_BRANCH}\" \\\n \t\t\t\"ParameterKey=GitHubToken,ParameterValue=$(shell aws ssm get-parameter --name /${OWNER}/${PROJECT}/build/REPO_TOKEN --output json --with-decryption | jq -r '.Parameter.Value')\" \\\n \t\t\t\"ParameterKey=ApplicationName,ParameterValue=${REPO}\" \\\n-\t\t\t\"ParameterKey=Prefix,ParameterValue=${PREFIX}\" \\\n+\t\t\t\"ParameterKey=Subdomain,ParameterValue=${SUBDOMAIN:-`echo ${REPO}`}\" \\","path":"Makefile","position":22,"original_position":22,"commit_id":"09f3293675b00a76a644e65911ceea65cfe17a05","original_commit_id":"206be0ad6bbf7d44d89ea0ca8da2b1a0be608f0a","user":{"login":"aochsner","id":222713,"avatar_url":"https://avatars2.githubusercontent.com/u/222713?v=4","gravatar_id":"","url":"https://api.github.com/users/aochsner","html_url":"https://github.com/aochsner","followers_url":"https://api.github.com/users/aochsner/followers","following_url":"https://api.github.com/users/aochsner/following{/other_user}","gists_url":"https://api.github.com/users/aochsner/gists{/gist_id}","starred_url":"https://api.github.com/users/aochsner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aochsner/subscriptions","organizations_url":"https://api.github.com/users/aochsner/orgs","repos_url":"https://api.github.com/users/aochsner/repos","events_url":"https://api.github.com/users/aochsner/events{/privacy}","received_events_url":"https://api.github.com/users/aochsner/received_events","type":"User","site_admin":false},"body":"any value to this pattern vs above for PREFIX = default to OWNER?  ","created_at":"2018-05-08T18:00:51Z","updated_at":"2018-05-08T18:00:51Z","html_url":"https://github.com/buildit/bookit-infrastructure/pull/22#discussion_r186815916","pull_request_url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/comments/186815916"},"html":{"href":"https://github.com/buildit/bookit-infrastructure/pull/22#discussion_r186815916"},"pull_request":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22","id":186708461,"html_url":"https://github.com/buildit/bookit-infrastructure/pull/22","diff_url":"https://github.com/buildit/bookit-infrastructure/pull/22.diff","patch_url":"https://github.com/buildit/bookit-infrastructure/pull/22.patch","issue_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/22","number":22,"state":"open","locked":false,"title":"FOR DISCUSSION ONLY (NO MERGE) Resolves #21","user":{"login":"mathomas","id":1869011,"avatar_url":"https://avatars3.githubusercontent.com/u/1869011?v=4","gravatar_id":"","url":"https://api.github.com/users/mathomas","html_url":"https://github.com/mathomas","followers_url":"https://api.github.com/users/mathomas/followers","following_url":"https://api.github.com/users/mathomas/following{/other_user}","gists_url":"https://api.github.com/users/mathomas/gists{/gist_id}","starred_url":"https://api.github.com/users/mathomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathomas/subscriptions","organizations_url":"https://api.github.com/users/mathomas/orgs","repos_url":"https://api.github.com/users/mathomas/repos","events_url":"https://api.github.com/users/mathomas/events{/privacy}","received_events_url":"https://api.github.com/users/mathomas/received_events","type":"User","site_admin":false},"body":"Initial checkin for review to replace (more or less) the concept of PREFIX with an explicit SUBDOMAIN.  The SUBDOMAIN is used to create listener rules, etc for the \"preferred\" URL for the app/service.","created_at":"2018-05-08T17:50:51Z","updated_at":"2018-05-08T18:00:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a1d6ed3a392a875f4ba5b0ee7cec8c88beb56dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22/commits","review_comments_url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22/comments","review_comment_url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/22/comments","statuses_url":"https://api.github.com/repos/buildit/bookit-infrastructure/statuses/09f3293675b00a76a644e65911ceea65cfe17a05","head":{"label":"buildit:issue-21-blue-green-style-replacement","ref":"issue-21-blue-green-style-replacement","sha":"09f3293675b00a76a644e65911ceea65cfe17a05","user":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"repo":{"id":104967472,"name":"bookit-infrastructure","full_name":"buildit/bookit-infrastructure","owner":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildit/bookit-infrastructure","description":null,"fork":false,"url":"https://api.github.com/repos/buildit/bookit-infrastructure","forks_url":"https://api.github.com/repos/buildit/bookit-infrastructure/forks","keys_url":"https://api.github.com/repos/buildit/bookit-infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildit/bookit-infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildit/bookit-infrastructure/teams","hooks_url":"https://api.github.com/repos/buildit/bookit-infrastructure/hooks","issue_events_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/buildit/bookit-infrastructure/events","assignees_url":"https://api.github.com/repos/buildit/bookit-infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/buildit/bookit-infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/buildit/bookit-infrastructure/tags","blobs_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildit/bookit-infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/buildit/bookit-infrastructure/languages","stargazers_url":"https://api.github.com/repos/buildit/bookit-infrastructure/stargazers","contributors_url":"https://api.github.com/repos/buildit/bookit-infrastructure/contributors","subscribers_url":"https://api.github.com/repos/buildit/bookit-infrastructure/subscribers","subscription_url":"https://api.github.com/repos/buildit/bookit-infrastructure/subscription","commits_url":"https://api.github.com/repos/buildit/bookit-infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildit/bookit-infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildit/bookit-infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/buildit/bookit-infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildit/bookit-infrastructure/merges","archive_url":"https://api.github.com/repos/buildit/bookit-infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildit/bookit-infrastructure/downloads","issues_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/buildit/bookit-infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/buildit/bookit-infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildit/bookit-infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/buildit/bookit-infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/buildit/bookit-infrastructure/deployments","created_at":"2017-09-27T03:26:16Z","updated_at":"2018-05-07T22:18:57Z","pushed_at":"2018-05-08T17:59:59Z","git_url":"git://github.com/buildit/bookit-infrastructure.git","ssh_url":"git@github.com:buildit/bookit-infrastructure.git","clone_url":"https://github.com/buildit/bookit-infrastructure.git","svn_url":"https://github.com/buildit/bookit-infrastructure","homepage":null,"size":492,"stargazers_count":2,"watchers_count":2,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"buildit:master","ref":"master","sha":"69d581efe7a5895c6f9e8e12257c638a39d07ddf","user":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"repo":{"id":104967472,"name":"bookit-infrastructure","full_name":"buildit/bookit-infrastructure","owner":{"login":"buildit","id":17282100,"avatar_url":"https://avatars0.githubusercontent.com/u/17282100?v=4","gravatar_id":"","url":"https://api.github.com/users/buildit","html_url":"https://github.com/buildit","followers_url":"https://api.github.com/users/buildit/followers","following_url":"https://api.github.com/users/buildit/following{/other_user}","gists_url":"https://api.github.com/users/buildit/gists{/gist_id}","starred_url":"https://api.github.com/users/buildit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buildit/subscriptions","organizations_url":"https://api.github.com/users/buildit/orgs","repos_url":"https://api.github.com/users/buildit/repos","events_url":"https://api.github.com/users/buildit/events{/privacy}","received_events_url":"https://api.github.com/users/buildit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/buildit/bookit-infrastructure","description":null,"fork":false,"url":"https://api.github.com/repos/buildit/bookit-infrastructure","forks_url":"https://api.github.com/repos/buildit/bookit-infrastructure/forks","keys_url":"https://api.github.com/repos/buildit/bookit-infrastructure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buildit/bookit-infrastructure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buildit/bookit-infrastructure/teams","hooks_url":"https://api.github.com/repos/buildit/bookit-infrastructure/hooks","issue_events_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/events{/number}","events_url":"https://api.github.com/repos/buildit/bookit-infrastructure/events","assignees_url":"https://api.github.com/repos/buildit/bookit-infrastructure/assignees{/user}","branches_url":"https://api.github.com/repos/buildit/bookit-infrastructure/branches{/branch}","tags_url":"https://api.github.com/repos/buildit/bookit-infrastructure/tags","blobs_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/refs{/sha}","trees_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buildit/bookit-infrastructure/statuses/{sha}","languages_url":"https://api.github.com/repos/buildit/bookit-infrastructure/languages","stargazers_url":"https://api.github.com/repos/buildit/bookit-infrastructure/stargazers","contributors_url":"https://api.github.com/repos/buildit/bookit-infrastructure/contributors","subscribers_url":"https://api.github.com/repos/buildit/bookit-infrastructure/subscribers","subscription_url":"https://api.github.com/repos/buildit/bookit-infrastructure/subscription","commits_url":"https://api.github.com/repos/buildit/bookit-infrastructure/commits{/sha}","git_commits_url":"https://api.github.com/repos/buildit/bookit-infrastructure/git/commits{/sha}","comments_url":"https://api.github.com/repos/buildit/bookit-infrastructure/comments{/number}","issue_comment_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/comments{/number}","contents_url":"https://api.github.com/repos/buildit/bookit-infrastructure/contents/{+path}","compare_url":"https://api.github.com/repos/buildit/bookit-infrastructure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buildit/bookit-infrastructure/merges","archive_url":"https://api.github.com/repos/buildit/bookit-infrastructure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buildit/bookit-infrastructure/downloads","issues_url":"https://api.github.com/repos/buildit/bookit-infrastructure/issues{/number}","pulls_url":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls{/number}","milestones_url":"https://api.github.com/repos/buildit/bookit-infrastructure/milestones{/number}","notifications_url":"https://api.github.com/repos/buildit/bookit-infrastructure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buildit/bookit-infrastructure/labels{/name}","releases_url":"https://api.github.com/repos/buildit/bookit-infrastructure/releases{/id}","deployments_url":"https://api.github.com/repos/buildit/bookit-infrastructure/deployments","created_at":"2017-09-27T03:26:16Z","updated_at":"2018-05-07T22:18:57Z","pushed_at":"2018-05-08T17:59:59Z","git_url":"git://github.com/buildit/bookit-infrastructure.git","ssh_url":"git@github.com:buildit/bookit-infrastructure.git","clone_url":"https://github.com/buildit/bookit-infrastructure.git","svn_url":"https://github.com/buildit/bookit-infrastructure","homepage":null,"size":492,"stargazers_count":2,"watchers_count":2,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22"},"html":{"href":"https://github.com/buildit/bookit-infrastructure/pull/22"},"issue":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/22"},"comments":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/buildit/bookit-infrastructure/statuses/09f3293675b00a76a644e65911ceea65cfe17a05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aochsner"}}