{"action":"created","comment":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments/233640438","pull_request_review_id":175103293,"id":233640438,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzY0MDQzOA==","diff_hunk":"@@ -275,13 +318,13 @@ def _prepare_init_params_from_job_description(cls, job_details, model_channel_na\n                                                                                        model_channel_name)\n \n         # Move some of the tensorflow specific init params from hyperparameters into the main init params.\n-        for argument in ['checkpoint_path', 'training_steps', 'evaluation_steps']:\n+        for argument in ['checkpoint_path', 'training_steps', 'evaluation_steps', 'model_dir']:","path":"src/sagemaker/tensorflow/estimator.py","position":106,"original_position":106,"commit_id":"358a8117c542d947d7d1d57f37c9bf2cb433bcdc","original_commit_id":"358a8117c542d947d7d1d57f37c9bf2cb433bcdc","user":{"login":"laurenyu","id":6631887,"node_id":"MDQ6VXNlcjY2MzE4ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/6631887?v=4","gravatar_id":"","url":"https://api.github.com/users/laurenyu","html_url":"https://github.com/laurenyu","followers_url":"https://api.github.com/users/laurenyu/followers","following_url":"https://api.github.com/users/laurenyu/following{/other_user}","gists_url":"https://api.github.com/users/laurenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/laurenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurenyu/subscriptions","organizations_url":"https://api.github.com/users/laurenyu/orgs","repos_url":"https://api.github.com/users/laurenyu/repos","events_url":"https://api.github.com/users/laurenyu/events{/privacy}","received_events_url":"https://api.github.com/users/laurenyu/received_events","type":"User","site_admin":false},"body":"I know this wasn't your change here, but you could make this list into a tuple as well","created_at":"2018-11-14T22:11:14Z","updated_at":"2018-11-14T22:14:56Z","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/475#discussion_r233640438","pull_request_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments/233640438"},"html":{"href":"https://github.com/aws/sagemaker-python-sdk/pull/475#discussion_r233640438"},"pull_request":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475","id":230342947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzQyOTQ3","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/475","diff_url":"https://github.com/aws/sagemaker-python-sdk/pull/475.diff","patch_url":"https://github.com/aws/sagemaker-python-sdk/pull/475.patch","issue_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/475","number":475,"state":"open","locked":false,"title":"TF script mode support","user":{"login":"icywang86rui","id":24926915,"node_id":"MDQ6VXNlcjI0OTI2OTE1","avatar_url":"https://avatars0.githubusercontent.com/u/24926915?v=4","gravatar_id":"","url":"https://api.github.com/users/icywang86rui","html_url":"https://github.com/icywang86rui","followers_url":"https://api.github.com/users/icywang86rui/followers","following_url":"https://api.github.com/users/icywang86rui/following{/other_user}","gists_url":"https://api.github.com/users/icywang86rui/gists{/gist_id}","starred_url":"https://api.github.com/users/icywang86rui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icywang86rui/subscriptions","organizations_url":"https://api.github.com/users/icywang86rui/orgs","repos_url":"https://api.github.com/users/icywang86rui/repos","events_url":"https://api.github.com/users/icywang86rui/events{/privacy}","received_events_url":"https://api.github.com/users/icywang86rui/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n\r\n*Description of changes:*\r\n\r\n## Merge Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._\r\n\r\n- [ ] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc\r\n- [ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)\r\n- [ ] I have updated the [changelog](https://github.com/aws/sagemaker-python-sdk/blob/master/CHANGELOG.rst) with a description of my changes (if appropriate)\r\n- [ ] I have updated any necessary [documentation](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) (if appropriate)\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-13T04:15:57Z","updated_at":"2018-11-14T22:14:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3336a60be060ffb1e0077486081f2d467452067","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475/commits","review_comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475/comments","review_comment_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/475/comments","statuses_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/358a8117c542d947d7d1d57f37c9bf2cb433bcdc","head":{"label":"icywang86rui:tf-script-mode","ref":"tf-script-mode","sha":"358a8117c542d947d7d1d57f37c9bf2cb433bcdc","user":{"login":"icywang86rui","id":24926915,"node_id":"MDQ6VXNlcjI0OTI2OTE1","avatar_url":"https://avatars0.githubusercontent.com/u/24926915?v=4","gravatar_id":"","url":"https://api.github.com/users/icywang86rui","html_url":"https://github.com/icywang86rui","followers_url":"https://api.github.com/users/icywang86rui/followers","following_url":"https://api.github.com/users/icywang86rui/following{/other_user}","gists_url":"https://api.github.com/users/icywang86rui/gists{/gist_id}","starred_url":"https://api.github.com/users/icywang86rui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icywang86rui/subscriptions","organizations_url":"https://api.github.com/users/icywang86rui/orgs","repos_url":"https://api.github.com/users/icywang86rui/repos","events_url":"https://api.github.com/users/icywang86rui/events{/privacy}","received_events_url":"https://api.github.com/users/icywang86rui/received_events","type":"User","site_admin":false},"repo":{"id":138646237,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NDYyMzc=","name":"sagemaker-python-sdk","full_name":"icywang86rui/sagemaker-python-sdk","private":false,"owner":{"login":"icywang86rui","id":24926915,"node_id":"MDQ6VXNlcjI0OTI2OTE1","avatar_url":"https://avatars0.githubusercontent.com/u/24926915?v=4","gravatar_id":"","url":"https://api.github.com/users/icywang86rui","html_url":"https://github.com/icywang86rui","followers_url":"https://api.github.com/users/icywang86rui/followers","following_url":"https://api.github.com/users/icywang86rui/following{/other_user}","gists_url":"https://api.github.com/users/icywang86rui/gists{/gist_id}","starred_url":"https://api.github.com/users/icywang86rui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icywang86rui/subscriptions","organizations_url":"https://api.github.com/users/icywang86rui/orgs","repos_url":"https://api.github.com/users/icywang86rui/repos","events_url":"https://api.github.com/users/icywang86rui/events{/privacy}","received_events_url":"https://api.github.com/users/icywang86rui/received_events","type":"User","site_admin":false},"html_url":"https://github.com/icywang86rui/sagemaker-python-sdk","description":"A library for training and deploying machine learning models on Amazon SageMaker","fork":true,"url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk","forks_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/forks","keys_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/teams","hooks_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/hooks","issue_events_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/events","assignees_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/tags","blobs_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/languages","stargazers_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/stargazers","contributors_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/contributors","subscribers_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/subscribers","subscription_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/subscription","commits_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/merges","archive_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/downloads","issues_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/icywang86rui/sagemaker-python-sdk/deployments","created_at":"2018-06-25T20:26:08Z","updated_at":"2018-06-25T20:26:11Z","pushed_at":"2018-11-14T22:06:56Z","git_url":"git://github.com/icywang86rui/sagemaker-python-sdk.git","ssh_url":"git@github.com:icywang86rui/sagemaker-python-sdk.git","clone_url":"https://github.com/icywang86rui/sagemaker-python-sdk.git","svn_url":"https://github.com/icywang86rui/sagemaker-python-sdk","homepage":"","size":52820,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"a2fdf5bec61ae79343ec9ff6c4bff1d9dd95efc0","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":110621895,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MjE4OTU=","name":"sagemaker-python-sdk","full_name":"aws/sagemaker-python-sdk","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/sagemaker-python-sdk","description":"A library for training and deploying machine learning models on Amazon SageMaker","fork":false,"url":"https://api.github.com/repos/aws/sagemaker-python-sdk","forks_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/forks","keys_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/teams","hooks_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/hooks","issue_events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/events","assignees_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/tags","blobs_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/languages","stargazers_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/stargazers","contributors_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/contributors","subscribers_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/subscribers","subscription_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/subscription","commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/merges","archive_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/downloads","issues_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/deployments","created_at":"2017-11-14T01:03:33Z","updated_at":"2018-11-14T21:38:32Z","pushed_at":"2018-11-14T22:06:58Z","git_url":"git://github.com/aws/sagemaker-python-sdk.git","ssh_url":"git@github.com:aws/sagemaker-python-sdk.git","clone_url":"https://github.com/aws/sagemaker-python-sdk.git","svn_url":"https://github.com/aws/sagemaker-python-sdk","homepage":"","size":52253,"stargazers_count":376,"watchers_count":376,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":167,"open_issues":59,"watchers":376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475"},"html":{"href":"https://github.com/aws/sagemaker-python-sdk/pull/475"},"issue":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/475"},"comments":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/358a8117c542d947d7d1d57f37c9bf2cb433bcdc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laurenyu"}}