{"action":"created","comment":{"url":"https://api.github.com/repos/jim-minter/azure-helm/pulls/comments/198809086","pull_request_review_id":132803432,"id":198809086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODgwOTA4Ng==","diff_hunk":"@@ -1,8 +1,37 @@\n apiVersion: v1\n-data:\n-  config.yml: YXV0aDoKICBvcGVuc2hpZnQ6CiAgICByZWFsbTogb3BlbnNoaWZ0Cmh0dHA6CiAgYWRkcjogOjUwMDAKbG9nOgogIGxldmVsOiBkZWJ1ZwptaWRkbGV3YXJlOgogIHJlZ2lzdHJ5OgogIC0gbmFtZTogb3BlbnNoaWZ0CiAgcmVwb3NpdG9yeToKICAtIG5hbWU6IG9wZW5zaGlmdAogICAgb3B0aW9uczoKICAgICAgYWNjZXB0c2NoZW1hMjogdHJ1ZQogICAgICBlbmZvcmNlcXVvdGE6IGZhbHNlCiAgICAgIHB1bGx0aHJvdWdoOiB0cnVlCiAgc3RvcmFnZToKICAtIG5hbWU6IG9wZW5zaGlmdApzdG9yYWdlOgogIGF6dXJlOgogICAgYWNjb3VudGtleTogJyoqKiBHRU5FUkFURUQgKioqJwogICAgYWNjb3VudG5hbWU6ICcqKiogR0VORVJBVEVEICoqKicKICAgIGNvbnRhaW5lcjogcmVnaXN0cnkKICAgIHJlYWxtOiBjb3JlLndpbmRvd3MubmV0CiAgY2FjaGU6CiAgICBibG9iZGVzY3JpcHRvcjogaW5tZW1vcnkKICBkZWxldGU6CiAgICBlbmFibGVkOiB0cnVlCnZlcnNpb246IDAuMQo=\n kind: Secret\n metadata:\n   name: registry-config\n   namespace: default\n type: Opaque\n+stringData:","path":"pkg/addons/data/Secret/default/registry-config","position":9,"original_position":9,"commit_id":"df04ecb1c34dbc89eb248da8626d105994708063","original_commit_id":"df04ecb1c34dbc89eb248da8626d105994708063","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"moving data->stringData and adding the REGISTRY_STORAGE_ACCOUNT_KEY text is entirely pragmatic for now but implies a little technical debt around automatically syncing in updated yaml objects from a cluster.  Not a blocker, but just keep it in mind :)","created_at":"2018-06-28T11:36:53Z","updated_at":"2018-06-28T11:39:15Z","html_url":"https://github.com/jim-minter/azure-helm/pull/20#discussion_r198809086","pull_request_url":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jim-minter/azure-helm/pulls/comments/198809086"},"html":{"href":"https://github.com/jim-minter/azure-helm/pull/20#discussion_r198809086"},"pull_request":{"href":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20","id":197789284,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Nzg5Mjg0","html_url":"https://github.com/jim-minter/azure-helm/pull/20","diff_url":"https://github.com/jim-minter/azure-helm/pull/20.diff","patch_url":"https://github.com/jim-minter/azure-helm/pull/20.patch","issue_url":"https://api.github.com/repos/jim-minter/azure-helm/issues/20","number":20,"state":"open","locked":false,"title":"Add registry init container for storage setup","user":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/jim-minter/azure-helm/issues/9","created_at":"2018-06-27T16:36:04Z","updated_at":"2018-06-28T11:39:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3956f9d6aa7aba18b1971a803f582e17de1edc02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20/commits","review_comments_url":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20/comments","review_comment_url":"https://api.github.com/repos/jim-minter/azure-helm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jim-minter/azure-helm/issues/20/comments","statuses_url":"https://api.github.com/repos/jim-minter/azure-helm/statuses/df04ecb1c34dbc89eb248da8626d105994708063","head":{"label":"kargakis:registry-init-container","ref":"registry-init-container","sha":"df04ecb1c34dbc89eb248da8626d105994708063","user":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"repo":{"id":138734769,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MzQ3Njk=","name":"azure-helm","full_name":"kargakis/azure-helm","owner":{"login":"kargakis","id":3900799,"node_id":"MDQ6VXNlcjM5MDA3OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3900799?v=4","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kargakis/azure-helm","description":null,"fork":true,"url":"https://api.github.com/repos/kargakis/azure-helm","forks_url":"https://api.github.com/repos/kargakis/azure-helm/forks","keys_url":"https://api.github.com/repos/kargakis/azure-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kargakis/azure-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kargakis/azure-helm/teams","hooks_url":"https://api.github.com/repos/kargakis/azure-helm/hooks","issue_events_url":"https://api.github.com/repos/kargakis/azure-helm/issues/events{/number}","events_url":"https://api.github.com/repos/kargakis/azure-helm/events","assignees_url":"https://api.github.com/repos/kargakis/azure-helm/assignees{/user}","branches_url":"https://api.github.com/repos/kargakis/azure-helm/branches{/branch}","tags_url":"https://api.github.com/repos/kargakis/azure-helm/tags","blobs_url":"https://api.github.com/repos/kargakis/azure-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kargakis/azure-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kargakis/azure-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kargakis/azure-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kargakis/azure-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/kargakis/azure-helm/languages","stargazers_url":"https://api.github.com/repos/kargakis/azure-helm/stargazers","contributors_url":"https://api.github.com/repos/kargakis/azure-helm/contributors","subscribers_url":"https://api.github.com/repos/kargakis/azure-helm/subscribers","subscription_url":"https://api.github.com/repos/kargakis/azure-helm/subscription","commits_url":"https://api.github.com/repos/kargakis/azure-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kargakis/azure-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kargakis/azure-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kargakis/azure-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kargakis/azure-helm/contents/{+path}","compare_url":"https://api.github.com/repos/kargakis/azure-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kargakis/azure-helm/merges","archive_url":"https://api.github.com/repos/kargakis/azure-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kargakis/azure-helm/downloads","issues_url":"https://api.github.com/repos/kargakis/azure-helm/issues{/number}","pulls_url":"https://api.github.com/repos/kargakis/azure-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/kargakis/azure-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/kargakis/azure-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kargakis/azure-helm/labels{/name}","releases_url":"https://api.github.com/repos/kargakis/azure-helm/releases{/id}","deployments_url":"https://api.github.com/repos/kargakis/azure-helm/deployments","created_at":"2018-06-26T12:27:18Z","updated_at":"2018-06-27T15:24:18Z","pushed_at":"2018-06-28T10:29:26Z","git_url":"git://github.com/kargakis/azure-helm.git","ssh_url":"git@github.com:kargakis/azure-helm.git","clone_url":"https://github.com/kargakis/azure-helm.git","svn_url":"https://github.com/kargakis/azure-helm","homepage":null,"size":12373,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jim-minter:master","ref":"master","sha":"fd7b5b5cad96a913514ce9847737e26e889fa9eb","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":137828518,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4Mjg1MTg=","name":"azure-helm","full_name":"jim-minter/azure-helm","owner":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jim-minter/azure-helm","description":null,"fork":false,"url":"https://api.github.com/repos/jim-minter/azure-helm","forks_url":"https://api.github.com/repos/jim-minter/azure-helm/forks","keys_url":"https://api.github.com/repos/jim-minter/azure-helm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/azure-helm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/azure-helm/teams","hooks_url":"https://api.github.com/repos/jim-minter/azure-helm/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/azure-helm/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/azure-helm/events","assignees_url":"https://api.github.com/repos/jim-minter/azure-helm/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/azure-helm/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/azure-helm/tags","blobs_url":"https://api.github.com/repos/jim-minter/azure-helm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/azure-helm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/azure-helm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/azure-helm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/azure-helm/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/azure-helm/languages","stargazers_url":"https://api.github.com/repos/jim-minter/azure-helm/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/azure-helm/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/azure-helm/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/azure-helm/subscription","commits_url":"https://api.github.com/repos/jim-minter/azure-helm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/azure-helm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/azure-helm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/azure-helm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/azure-helm/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/azure-helm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/azure-helm/merges","archive_url":"https://api.github.com/repos/jim-minter/azure-helm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/azure-helm/downloads","issues_url":"https://api.github.com/repos/jim-minter/azure-helm/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/azure-helm/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/azure-helm/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/azure-helm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/azure-helm/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/azure-helm/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/azure-helm/deployments","created_at":"2018-06-19T02:11:07Z","updated_at":"2018-06-28T08:45:14Z","pushed_at":"2018-06-28T10:29:28Z","git_url":"git://github.com/jim-minter/azure-helm.git","ssh_url":"git@github.com:jim-minter/azure-helm.git","clone_url":"https://github.com/jim-minter/azure-helm.git","svn_url":"https://github.com/jim-minter/azure-helm","homepage":null,"size":12374,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":2,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20"},"html":{"href":"https://github.com/jim-minter/azure-helm/pull/20"},"issue":{"href":"https://api.github.com/repos/jim-minter/azure-helm/issues/20"},"comments":{"href":"https://api.github.com/repos/jim-minter/azure-helm/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/jim-minter/azure-helm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jim-minter/azure-helm/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/jim-minter/azure-helm/statuses/df04ecb1c34dbc89eb248da8626d105994708063"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jim-minter"}}