{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/comments/197882608","pull_request_review_id":131713477,"id":197882608,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg4MjYwOA==","diff_hunk":"@@ -0,0 +1,48 @@\n+# SDL shall not put RC applications to HMI level NONE when user disables RC in HMI\n+\n+* Proposal: [SDL-NNNN](NNNN-keep-rc-app-hmi-level-when-disable-rc.md)\n+* Author: [Zhimin Yang](https://github.com/smartdevicelink/yang1070)\n+* Status: **Awaiting review**\n+* Impacted Platforms: [ Core / Web]\n+\n+## Introduction\n+\n+SDL shall not put `REMOTE_CONTROL` `appHMIType` applications to HMI level `NONE` when user disables remote control in HMI.\n+\n+## Motivation\n+The asked behavior is in the same line with other existing features, like the permission of function groups. If a user disables the application's permission to access vehicle signals like gps, speed, etc. the application will keep its current HMI level and will not be put into HMI level `NONE` by SDL. Furthermore, SDl allows activating  an application using such signals. However, SDL rejects any RPC that relates to the disallowed signals. In this proposal, we propose the following changes. SDL shall keep a RC application's HMI status unchanged if the user disables RC. SDL can activate a RC application even if RC is disabled. \n+\n+\n+## Proposed solution\n+\n+We propose the changes as in the following tables:\n+\n+  | Current | Expected SDL core change\n+-- | -- | --\n+1 | HMI sends a notification to SDL that RC is disabled | No change\n+2 | SDL puts RC apps from `FULL`/`LIMITED` to `NONE` | SDL does not change apps' HMI level\n+3 | SDL sends `OnHMIStatus` (`NONE`) to all RC applications that put to `NONE` | SDL does not send `OnHMIStatus`\n+4 | SDL keeps RC apps registered | No change\n+5 | SDL unsubscribes all RC apps’ RC modules from HMI | No change\n+6 | SDL releases all RC modules allocated to RC apps and sends `OnRCStatus` notifications | No change\n+7 | SDL ignores `OnInteriorVehicleData` from HMI and SDL does not send `OnInteriorVehicleData` to apps | No change\n+8 | SDL disallows RC related RPC, such as `GetInteriorVehicleData`, `SetInteriorVehicleData` and `ButtonPress` requests from apps | No change\n+9 | HMILevel cannot change to other than `NONE` until RC functionality is enabled | HMI level can change like regular apps. In addtion, A RC app can be activated.\n+\n+  | Current | Expected HMI change\n+-- | -- | --\n+1 | HMI shows registered RC apps grey | HMI shows registered RC apps as regular apps (no grey out)","path":"proposals/NNNN-keep-rc-app-hmi-level-when-disable-rc.md","position":34,"original_position":34,"commit_id":"2b6f96db3df27682832e7ca334796c4c717e1a47","original_commit_id":"2b6f96db3df27682832e7ca334796c4c717e1a47","user":{"login":"theresalech","id":22600496,"node_id":"MDQ6VXNlcjIyNjAwNDk2","avatar_url":"https://avatars2.githubusercontent.com/u/22600496?v=4","gravatar_id":"","url":"https://api.github.com/users/theresalech","html_url":"https://github.com/theresalech","followers_url":"https://api.github.com/users/theresalech/followers","following_url":"https://api.github.com/users/theresalech/following{/other_user}","gists_url":"https://api.github.com/users/theresalech/gists{/gist_id}","starred_url":"https://api.github.com/users/theresalech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theresalech/subscriptions","organizations_url":"https://api.github.com/users/theresalech/orgs","repos_url":"https://api.github.com/users/theresalech/repos","events_url":"https://api.github.com/users/theresalech/events{/privacy}","received_events_url":"https://api.github.com/users/theresalech/received_events","type":"User","site_admin":false},"body":"Please update to \"(not greyed out)\"","created_at":"2018-06-25T17:44:36Z","updated_at":"2018-06-25T17:49:15Z","html_url":"https://github.com/smartdevicelink/sdl_evolution/pull/527#discussion_r197882608","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/comments/197882608"},"html":{"href":"https://github.com/smartdevicelink/sdl_evolution/pull/527#discussion_r197882608"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527","id":197177839,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTc3ODM5","html_url":"https://github.com/smartdevicelink/sdl_evolution/pull/527","diff_url":"https://github.com/smartdevicelink/sdl_evolution/pull/527.diff","patch_url":"https://github.com/smartdevicelink/sdl_evolution/pull/527.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/527","number":527,"state":"open","locked":false,"title":"SDL shall not put RC applications to HMI level NONE when user disables RC in HMI","user":{"login":"yang1070","id":12255391,"node_id":"MDQ6VXNlcjEyMjU1Mzkx","avatar_url":"https://avatars1.githubusercontent.com/u/12255391?v=4","gravatar_id":"","url":"https://api.github.com/users/yang1070","html_url":"https://github.com/yang1070","followers_url":"https://api.github.com/users/yang1070/followers","following_url":"https://api.github.com/users/yang1070/following{/other_user}","gists_url":"https://api.github.com/users/yang1070/gists{/gist_id}","starred_url":"https://api.github.com/users/yang1070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang1070/subscriptions","organizations_url":"https://api.github.com/users/yang1070/orgs","repos_url":"https://api.github.com/users/yang1070/repos","events_url":"https://api.github.com/users/yang1070/events{/privacy}","received_events_url":"https://api.github.com/users/yang1070/received_events","type":"User","site_admin":false},"body":"SDL shall not put `REMOTE_CONTROL` `appHMIType` applications to HMI level `NONE` when user disables remote control in HMI.","created_at":"2018-06-25T17:04:08Z","updated_at":"2018-06-25T17:49:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2938b78f4173e8b3a6afa905c72318fb10eb3d12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/527/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/statuses/2b6f96db3df27682832e7ca334796c4c717e1a47","head":{"label":"yang1070:keep_rc_app_hmi_level","ref":"keep_rc_app_hmi_level","sha":"2b6f96db3df27682832e7ca334796c4c717e1a47","user":{"login":"yang1070","id":12255391,"node_id":"MDQ6VXNlcjEyMjU1Mzkx","avatar_url":"https://avatars1.githubusercontent.com/u/12255391?v=4","gravatar_id":"","url":"https://api.github.com/users/yang1070","html_url":"https://github.com/yang1070","followers_url":"https://api.github.com/users/yang1070/followers","following_url":"https://api.github.com/users/yang1070/following{/other_user}","gists_url":"https://api.github.com/users/yang1070/gists{/gist_id}","starred_url":"https://api.github.com/users/yang1070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang1070/subscriptions","organizations_url":"https://api.github.com/users/yang1070/orgs","repos_url":"https://api.github.com/users/yang1070/repos","events_url":"https://api.github.com/users/yang1070/events{/privacy}","received_events_url":"https://api.github.com/users/yang1070/received_events","type":"User","site_admin":false},"repo":{"id":138624379,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2MjQzNzk=","name":"sdl_evolution","full_name":"yang1070/sdl_evolution","owner":{"login":"yang1070","id":12255391,"node_id":"MDQ6VXNlcjEyMjU1Mzkx","avatar_url":"https://avatars1.githubusercontent.com/u/12255391?v=4","gravatar_id":"","url":"https://api.github.com/users/yang1070","html_url":"https://github.com/yang1070","followers_url":"https://api.github.com/users/yang1070/followers","following_url":"https://api.github.com/users/yang1070/following{/other_user}","gists_url":"https://api.github.com/users/yang1070/gists{/gist_id}","starred_url":"https://api.github.com/users/yang1070/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yang1070/subscriptions","organizations_url":"https://api.github.com/users/yang1070/orgs","repos_url":"https://api.github.com/users/yang1070/repos","events_url":"https://api.github.com/users/yang1070/events{/privacy}","received_events_url":"https://api.github.com/users/yang1070/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yang1070/sdl_evolution","description":"Tracking and proposing changes to SDL's public APIs.","fork":true,"url":"https://api.github.com/repos/yang1070/sdl_evolution","forks_url":"https://api.github.com/repos/yang1070/sdl_evolution/forks","keys_url":"https://api.github.com/repos/yang1070/sdl_evolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yang1070/sdl_evolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yang1070/sdl_evolution/teams","hooks_url":"https://api.github.com/repos/yang1070/sdl_evolution/hooks","issue_events_url":"https://api.github.com/repos/yang1070/sdl_evolution/issues/events{/number}","events_url":"https://api.github.com/repos/yang1070/sdl_evolution/events","assignees_url":"https://api.github.com/repos/yang1070/sdl_evolution/assignees{/user}","branches_url":"https://api.github.com/repos/yang1070/sdl_evolution/branches{/branch}","tags_url":"https://api.github.com/repos/yang1070/sdl_evolution/tags","blobs_url":"https://api.github.com/repos/yang1070/sdl_evolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yang1070/sdl_evolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yang1070/sdl_evolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/yang1070/sdl_evolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yang1070/sdl_evolution/statuses/{sha}","languages_url":"https://api.github.com/repos/yang1070/sdl_evolution/languages","stargazers_url":"https://api.github.com/repos/yang1070/sdl_evolution/stargazers","contributors_url":"https://api.github.com/repos/yang1070/sdl_evolution/contributors","subscribers_url":"https://api.github.com/repos/yang1070/sdl_evolution/subscribers","subscription_url":"https://api.github.com/repos/yang1070/sdl_evolution/subscription","commits_url":"https://api.github.com/repos/yang1070/sdl_evolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/yang1070/sdl_evolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/yang1070/sdl_evolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/yang1070/sdl_evolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/yang1070/sdl_evolution/contents/{+path}","compare_url":"https://api.github.com/repos/yang1070/sdl_evolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yang1070/sdl_evolution/merges","archive_url":"https://api.github.com/repos/yang1070/sdl_evolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yang1070/sdl_evolution/downloads","issues_url":"https://api.github.com/repos/yang1070/sdl_evolution/issues{/number}","pulls_url":"https://api.github.com/repos/yang1070/sdl_evolution/pulls{/number}","milestones_url":"https://api.github.com/repos/yang1070/sdl_evolution/milestones{/number}","notifications_url":"https://api.github.com/repos/yang1070/sdl_evolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yang1070/sdl_evolution/labels{/name}","releases_url":"https://api.github.com/repos/yang1070/sdl_evolution/releases{/id}","deployments_url":"https://api.github.com/repos/yang1070/sdl_evolution/deployments","created_at":"2018-06-25T16:54:07Z","updated_at":"2018-06-25T16:54:10Z","pushed_at":"2018-06-25T17:13:26Z","git_url":"git://github.com/yang1070/sdl_evolution.git","ssh_url":"git@github.com:yang1070/sdl_evolution.git","clone_url":"https://github.com/yang1070/sdl_evolution.git","svn_url":"https://github.com/yang1070/sdl_evolution","homepage":"https://smartdevicelink.github.io/sdl_evolution/","size":9777,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:master","ref":"master","sha":"a5d728da20afeb37be6d9d37192df37e50424d73","user":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":63362559,"node_id":"MDEwOlJlcG9zaXRvcnk2MzM2MjU1OQ==","name":"sdl_evolution","full_name":"smartdevicelink/sdl_evolution","owner":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_evolution","description":"Tracking and proposing changes to SDL's public APIs.","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_evolution","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_evolution/deployments","created_at":"2016-07-14T19:08:19Z","updated_at":"2018-06-21T14:51:26Z","pushed_at":"2018-06-25T17:13:27Z","git_url":"git://github.com/smartdevicelink/sdl_evolution.git","ssh_url":"git@github.com:smartdevicelink/sdl_evolution.git","clone_url":"https://github.com/smartdevicelink/sdl_evolution.git","svn_url":"https://github.com/smartdevicelink/sdl_evolution","homepage":"https://smartdevicelink.github.io/sdl_evolution/","size":9777,"stargazers_count":19,"watchers_count":19,"language":"XSLT","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":74,"open_issues":24,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527"},"html":{"href":"https://github.com/smartdevicelink/sdl_evolution/pull/527"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/527"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/issues/527/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/pulls/527/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_evolution/statuses/2b6f96db3df27682832e7ca334796c4c717e1a47"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"theresalech"}}