{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/10024","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/10024/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/10024/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/10024/events","html_url":"https://github.com/kubernetes/test-infra/pull/10024","id":377174144,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTkwMDQx","number":10024,"title":"Don't exclude the `needs-ok-to-test` label for merge","user":{"login":"nikhita","id":16105680,"node_id":"MDQ6VXNlcjE2MTA1Njgw","avatar_url":"https://avatars1.githubusercontent.com/u/16105680?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhita","html_url":"https://github.com/nikhita","followers_url":"https://api.github.com/users/nikhita/followers","following_url":"https://api.github.com/users/nikhita/following{/other_user}","gists_url":"https://api.github.com/users/nikhita/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhita/subscriptions","organizations_url":"https://api.github.com/users/nikhita/orgs","repos_url":"https://api.github.com/users/nikhita/repos","events_url":"https://api.github.com/users/nikhita/events{/privacy}","received_events_url":"https://api.github.com/users/nikhita/received_events","type":"User","site_admin":false},"labels":[{"id":705940018,"node_id":"MDU6TGFiZWw3MDU5NDAwMTg=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":412127043,"node_id":"MDU6TGFiZWw0MTIxMjcwNDM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false},{"id":484580953,"node_id":"MDU6TGFiZWw0ODQ1ODA5NTM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":682002555,"node_id":"MDU6TGFiZWw2ODIwMDI1NTU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":671132825,"node_id":"MDU6TGFiZWw2NzExMzI4MjU=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"fejta","id":940341,"node_id":"MDQ6VXNlcjk0MDM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"assignees":[{"login":"fejta","id":940341,"node_id":"MDQ6VXNlcjk0MDM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-11-04T17:19:02Z","updated_at":"2018-11-04T19:07:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/10024","html_url":"https://github.com/kubernetes/test-infra/pull/10024","diff_url":"https://github.com/kubernetes/test-infra/pull/10024.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/10024.patch"},"body":"If the lgtm plugin is enabled and is required for merge, the query should not exclude the `needs-ok-to-test` label.\r\n\r\nThe lgtm plugin triggers one round of testing when applied to an untrusted PR and removes the lgtm label if the PR changes so it indicates to Tide that the current version of the PR is considered trusted and can be retested safely."},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/435696606","html_url":"https://github.com/kubernetes/test-infra/pull/10024#issuecomment-435696606","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/10024","id":435696606,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTY5NjYwNg==","user":{"login":"fejta","id":940341,"node_id":"MDQ6VXNlcjk0MDM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T19:07:46Z","updated_at":"2018-11-04T19:07:46Z","author_association":"CONTRIBUTOR","body":"`tide` and `trigger` are different components.\r\n\r\n`trigger` will trigger testing once if `/lgtm` is applied, but will not auto-retest on new commits, unless someone does an `/ok-to-test`\r\n\r\n`tide` is the piece which does auto-merges. It ensures that the test results are from the lastest master commit. If it isn't, it will retest the PR. It is probably ok to retest the PR if master changes (but the PR has the same code).\r\n\r\nBut should still be careful here. I suspect Cole/Steve have this check in place because this may result in tide either failing to retest untrusted PRs and/or retesting PRs we don't think should be retested."}}
{"actor":{"display_login":"fejta"}}