{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/218221913","pull_request_review_id":156111904,"id":218221913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODIyMTkxMw==","diff_hunk":"@@ -0,0 +1,98 @@\n+// Copyright 2018 The Chromium Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+import 'dart:collection';\n+\n+import 'package:flutter/foundation.dart';\n+import 'package:flutter/logging.dart';\n+\n+typedef void _RegisterServiceExtensionCallback(\n+    { @required String name, @required ServiceExtensionCallback callback });\n+\n+/// Manages [Logger] services.\n+class LoggingService {\n+  /// The shared service instance.\n+  static final LoggingService instance = new LoggingService._();\n+\n+  LoggingService._();\n+\n+  /// All the [Logger]s.\n+  final Map<String, Logger> loggers = <String, Logger>{};\n+\n+  _RegisterServiceExtensionCallback _registerServiceExtensionCallback;\n+\n+  final Set<Logger> _subscriptions = new HashSet<Logger>();\n+\n+  /// Return `true` if the given [logger] has subscriptions.\n+  bool hasSubscriptions(Logger logger) => _subscriptions.contains(logger);\n+\n+  /// Called to register service extensions.\n+  void initServiceExtensions(","path":"packages/flutter/lib/src/logging/logging.dart","position":31,"original_position":31,"commit_id":"5be720d73168e8af5edd7ec6ea50c6db8dd470e4","original_commit_id":"5be720d73168e8af5edd7ec6ea50c6db8dd470e4","user":{"login":"Hixie","id":551196,"node_id":"MDQ6VXNlcjU1MTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false},"body":"Don't follow what WidgetInspector does. It's a very special case with weird requirements and constraints.","created_at":"2018-09-17T20:47:56Z","updated_at":"2018-09-17T20:47:56Z","html_url":"https://github.com/flutter/flutter/pull/21505#discussion_r218221913","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/21505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/218221913"},"html":{"href":"https://github.com/flutter/flutter/pull/21505#discussion_r218221913"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21505"}},"in_reply_to_id":218203574},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/21505","id":213706699,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzA2Njk5","html_url":"https://github.com/flutter/flutter/pull/21505","diff_url":"https://github.com/flutter/flutter/pull/21505.diff","patch_url":"https://github.com/flutter/flutter/pull/21505.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/21505","number":21505,"state":"open","locked":false,"title":"Logger framework basics.","user":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"body":"Contributes a basic logging framework API.\r\n\r\nThe goal is for the framework to be unsurprising, performant and support opt-in monitoring of potentially noisy streams of logging events (e.g., platform channel communications, network activity, etc).\r\n\r\nSee: #21504 for discussion and further context.\r\n\r\nIf we feel good about this direction I'll start putting together some proper tests.  Needless to say, any feedback welcome!\r\n\r\n/cc @Hixie @jacob314 @devoncarew \r\n\r\n","created_at":"2018-09-06T18:18:29Z","updated_at":"2018-09-17T20:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65ef422c4793f7ccb5d7b7a8e7c2e3f35debdfb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/21505/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/21505/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/21505/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/5be720d73168e8af5edd7ec6ea50c6db8dd470e4","head":{"label":"pq:logger_api","ref":"logger_api","sha":"5be720d73168e8af5edd7ec6ea50c6db8dd470e4","user":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"repo":{"id":53366201,"node_id":"MDEwOlJlcG9zaXRvcnk1MzM2NjIwMQ==","name":"flutter","full_name":"pq/flutter","private":false,"owner":{"login":"pq","id":67586,"node_id":"MDQ6VXNlcjY3NTg2","avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pq/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps","fork":true,"url":"https://api.github.com/repos/pq/flutter","forks_url":"https://api.github.com/repos/pq/flutter/forks","keys_url":"https://api.github.com/repos/pq/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pq/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pq/flutter/teams","hooks_url":"https://api.github.com/repos/pq/flutter/hooks","issue_events_url":"https://api.github.com/repos/pq/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/pq/flutter/events","assignees_url":"https://api.github.com/repos/pq/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/pq/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/pq/flutter/tags","blobs_url":"https://api.github.com/repos/pq/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pq/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pq/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/pq/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pq/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/pq/flutter/languages","stargazers_url":"https://api.github.com/repos/pq/flutter/stargazers","contributors_url":"https://api.github.com/repos/pq/flutter/contributors","subscribers_url":"https://api.github.com/repos/pq/flutter/subscribers","subscription_url":"https://api.github.com/repos/pq/flutter/subscription","commits_url":"https://api.github.com/repos/pq/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/pq/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/pq/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/pq/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/pq/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/pq/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pq/flutter/merges","archive_url":"https://api.github.com/repos/pq/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pq/flutter/downloads","issues_url":"https://api.github.com/repos/pq/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/pq/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/pq/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/pq/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pq/flutter/labels{/name}","releases_url":"https://api.github.com/repos/pq/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/pq/flutter/deployments","created_at":"2016-03-07T23:17:48Z","updated_at":"2016-03-07T23:17:50Z","pushed_at":"2018-09-11T13:35:52Z","git_url":"git://github.com/pq/flutter.git","ssh_url":"git@github.com:pq/flutter.git","clone_url":"https://github.com/pq/flutter.git","svn_url":"https://github.com/pq/flutter","homepage":"http://flutter.io","size":45591,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"7c477b931180698549f096c6d82c89abe2b0306c","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-09-17T20:02:47Z","pushed_at":"2018-09-17T20:25:40Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":46972,"stargazers_count":37304,"watchers_count":37304,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3528,"mirror_url":null,"archived":false,"open_issues_count":3894,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3528,"open_issues":3894,"watchers":37304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21505"},"html":{"href":"https://github.com/flutter/flutter/pull/21505"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/21505"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/21505/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21505/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/21505/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/5be720d73168e8af5edd7ec6ea50c6db8dd470e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Hixie"}}