{"action":"created","comment":{"url":"https://api.github.com/repos/docker/cli/pulls/comments/198111750","pull_request_review_id":131980480,"id":198111750,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODExMTc1MA==","diff_hunk":"@@ -0,0 +1,32 @@\n+package stack\n+\n+import (\n+\t\"fmt\"\n+\t\"strings\"\n+\t\"unicode\"\n+)\n+\n+// validateStackName checks if the provided string is a valid stack name (namespace).\n+//\n+// It currently only does a rudimentary check if the string is empty, or consists\n+// of only whitespace and quoting characters.\n+func validateStackName(namespace string) error {\n+\tv := strings.TrimFunc(namespace, quotesOrWhitespace)\n+\tif len(v) == 0 {","path":"cli/command/stack/common.go","position":15,"original_position":15,"commit_id":"6459a0c79f38dee0bbefa8a4216aae6a5f46dc30","original_commit_id":"6459a0c79f38dee0bbefa8a4216aae6a5f46dc30","user":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"yes it is (same, copy/pasta, but I'll update :wink: )","created_at":"2018-06-26T11:44:05Z","updated_at":"2018-06-26T11:44:05Z","html_url":"https://github.com/docker/cli/pull/1147#discussion_r198111750","pull_request_url":"https://api.github.com/repos/docker/cli/pulls/1147","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/comments/198111750"},"html":{"href":"https://github.com/docker/cli/pull/1147#discussion_r198111750"},"pull_request":{"href":"https://api.github.com/repos/docker/cli/pulls/1147"}},"in_reply_to_id":198110030},"pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/1147","id":197379096,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3Mzc5MDk2","html_url":"https://github.com/docker/cli/pull/1147","diff_url":"https://github.com/docker/cli/pull/1147.diff","patch_url":"https://github.com/docker/cli/pull/1147.patch","issue_url":"https://api.github.com/repos/docker/cli/issues/1147","number":1147,"state":"open","locked":false,"title":"Refactor `stack` command/package","user":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"- Handle `bundlefile` directly in the `top-level`\r\n  command. `bundlefile` is still experimental and will be deprecated\r\n  in future version — this should make be easier to remove it.\r\n- Validate the `stack` name in all cases (i.e. whatever the\r\n  orchestrator is used)\r\n- Load the composefile ahead of choosing the orchestrator. This\r\n  removes some slight duplication.\r\n- Makes `RunDeploy` easier to use from outside packages (like\r\n  `docker/app`) with a preloaded configuration.\r\n\r\nThere is some *slight* benefits with this too, like `docker stack deploy` on k8s should support multiple files :wink: (which is not, *apparantly*, the case as of now)\r\n\r\nThis is a remake of #1146 :angel: \r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>\r\n","created_at":"2018-06-26T10:45:48Z","updated_at":"2018-06-26T11:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4871b77546e7c4aaec5c0c81bb84941e32adc068","assignee":null,"assignees":[],"requested_reviewers":[{"login":"silvin-lubecki","id":31478878,"node_id":"MDQ6VXNlcjMxNDc4ODc4","avatar_url":"https://avatars0.githubusercontent.com/u/31478878?v=4","gravatar_id":"","url":"https://api.github.com/users/silvin-lubecki","html_url":"https://github.com/silvin-lubecki","followers_url":"https://api.github.com/users/silvin-lubecki/followers","following_url":"https://api.github.com/users/silvin-lubecki/following{/other_user}","gists_url":"https://api.github.com/users/silvin-lubecki/gists{/gist_id}","starred_url":"https://api.github.com/users/silvin-lubecki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silvin-lubecki/subscriptions","organizations_url":"https://api.github.com/users/silvin-lubecki/orgs","repos_url":"https://api.github.com/users/silvin-lubecki/repos","events_url":"https://api.github.com/users/silvin-lubecki/events{/privacy}","received_events_url":"https://api.github.com/users/silvin-lubecki/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":585916071,"node_id":"MDU6TGFiZWw1ODU5MTYwNzE=","url":"https://api.github.com/repos/docker/cli/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/docker/cli/pulls/1147/commits","review_comments_url":"https://api.github.com/repos/docker/cli/pulls/1147/comments","review_comment_url":"https://api.github.com/repos/docker/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/cli/issues/1147/comments","statuses_url":"https://api.github.com/repos/docker/cli/statuses/6459a0c79f38dee0bbefa8a4216aae6a5f46dc30","head":{"label":"vdemeester:stack-refactoring","ref":"stack-refactoring","sha":"6459a0c79f38dee0bbefa8a4216aae6a5f46dc30","user":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":88662366,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY2MjM2Ng==","name":"cli","full_name":"vdemeester/cli","owner":{"login":"vdemeester","id":6508,"node_id":"MDQ6VXNlcjY1MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/cli","description":"The Docker CLI","fork":true,"url":"https://api.github.com/repos/vdemeester/cli","forks_url":"https://api.github.com/repos/vdemeester/cli/forks","keys_url":"https://api.github.com/repos/vdemeester/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/cli/teams","hooks_url":"https://api.github.com/repos/vdemeester/cli/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/cli/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/cli/events","assignees_url":"https://api.github.com/repos/vdemeester/cli/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/cli/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/cli/tags","blobs_url":"https://api.github.com/repos/vdemeester/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/cli/languages","stargazers_url":"https://api.github.com/repos/vdemeester/cli/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/cli/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/cli/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/cli/subscription","commits_url":"https://api.github.com/repos/vdemeester/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/cli/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/cli/merges","archive_url":"https://api.github.com/repos/vdemeester/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/cli/downloads","issues_url":"https://api.github.com/repos/vdemeester/cli/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/cli/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/cli/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/cli/deployments","created_at":"2017-04-18T19:26:23Z","updated_at":"2018-06-26T08:03:54Z","pushed_at":"2018-06-26T11:36:16Z","git_url":"git://github.com/vdemeester/cli.git","ssh_url":"git@github.com:vdemeester/cli.git","clone_url":"https://github.com/vdemeester/cli.git","svn_url":"https://github.com/vdemeester/cli","homepage":null,"size":18387,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"61e53fc88a79855b0b0d423e2a38eb57c5402c39","user":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":88013053,"node_id":"MDEwOlJlcG9zaXRvcnk4ODAxMzA1Mw==","name":"cli","full_name":"docker/cli","owner":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/cli","description":"The Docker CLI","fork":false,"url":"https://api.github.com/repos/docker/cli","forks_url":"https://api.github.com/repos/docker/cli/forks","keys_url":"https://api.github.com/repos/docker/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/cli/teams","hooks_url":"https://api.github.com/repos/docker/cli/hooks","issue_events_url":"https://api.github.com/repos/docker/cli/issues/events{/number}","events_url":"https://api.github.com/repos/docker/cli/events","assignees_url":"https://api.github.com/repos/docker/cli/assignees{/user}","branches_url":"https://api.github.com/repos/docker/cli/branches{/branch}","tags_url":"https://api.github.com/repos/docker/cli/tags","blobs_url":"https://api.github.com/repos/docker/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/cli/languages","stargazers_url":"https://api.github.com/repos/docker/cli/stargazers","contributors_url":"https://api.github.com/repos/docker/cli/contributors","subscribers_url":"https://api.github.com/repos/docker/cli/subscribers","subscription_url":"https://api.github.com/repos/docker/cli/subscription","commits_url":"https://api.github.com/repos/docker/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/cli/contents/{+path}","compare_url":"https://api.github.com/repos/docker/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/cli/merges","archive_url":"https://api.github.com/repos/docker/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/cli/downloads","issues_url":"https://api.github.com/repos/docker/cli/issues{/number}","pulls_url":"https://api.github.com/repos/docker/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/cli/labels{/name}","releases_url":"https://api.github.com/repos/docker/cli/releases{/id}","deployments_url":"https://api.github.com/repos/docker/cli/deployments","created_at":"2017-04-12T05:27:42Z","updated_at":"2018-06-25T21:18:19Z","pushed_at":"2018-06-26T11:09:47Z","git_url":"git://github.com/docker/cli.git","ssh_url":"git@github.com:docker/cli.git","clone_url":"https://github.com/docker/cli.git","svn_url":"https://github.com/docker/cli","homepage":null,"size":18241,"stargazers_count":707,"watchers_count":707,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":439,"mirror_url":null,"archived":false,"open_issues_count":230,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":439,"open_issues":230,"watchers":707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/1147"},"html":{"href":"https://github.com/docker/cli/pull/1147"},"issue":{"href":"https://api.github.com/repos/docker/cli/issues/1147"},"comments":{"href":"https://api.github.com/repos/docker/cli/issues/1147/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/cli/pulls/1147/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/cli/pulls/1147/commits"},"statuses":{"href":"https://api.github.com/repos/docker/cli/statuses/6459a0c79f38dee0bbefa8a4216aae6a5f46dc30"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vdemeester"}}