{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/171677028","pull_request_review_id":100573068,"id":171677028,"diff_hunk":"@@ -116,7 +116,10 @@ func (w *watcher) Reload() {\n // retrieveAZ will only run once and then exit because AZ won't change over a proxy's lifecycle\n // it has to use a reload due to limitations with envoy (az has to be passed in as a flag)\n func (w *watcher) retrieveAZ(ctx context.Context, delay time.Duration, retries int) {\n-\tif !model.IsApplicationNodeType(w.role.Type) {\n+\tif w.config.GetControlPlaneAuthPolicy() == meshconfig.AuthenticationPolicy_MUTUAL_TLS {\n+\t\tlog.Infof(\"Zone aware routing is not currently supported with mutual TLS enabled\")","path":"pilot/pkg/proxy/envoy/v1/watcher.go","position":6,"original_position":6,"commit_id":"56aa76091d218864b64ed89a815bbe14c6057293","original_commit_id":"56aa76091d218864b64ed89a815bbe14c6057293","user":{"login":"cmluciano","id":4790487,"avatar_url":"https://avatars1.githubusercontent.com/u/4790487?v=4","gravatar_id":"","url":"https://api.github.com/users/cmluciano","html_url":"https://github.com/cmluciano","followers_url":"https://api.github.com/users/cmluciano/followers","following_url":"https://api.github.com/users/cmluciano/following{/other_user}","gists_url":"https://api.github.com/users/cmluciano/gists{/gist_id}","starred_url":"https://api.github.com/users/cmluciano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmluciano/subscriptions","organizations_url":"https://api.github.com/users/cmluciano/orgs","repos_url":"https://api.github.com/users/cmluciano/repos","events_url":"https://api.github.com/users/cmluciano/events{/privacy}","received_events_url":"https://api.github.com/users/cmluciano/received_events","type":"User","site_admin":false},"body":"Would be great to have a small test case to capture this as well. ","created_at":"2018-03-01T20:00:53Z","updated_at":"2018-03-01T20:01:53Z","html_url":"https://github.com/istio/istio/pull/3873#discussion_r171677028","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/3873","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/171677028"},"html":{"href":"https://github.com/istio/istio/pull/3873#discussion_r171677028"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/3873"}},"in_reply_to_id":171676651},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/3873","id":172313969,"html_url":"https://github.com/istio/istio/pull/3873","diff_url":"https://github.com/istio/istio/pull/3873.diff","patch_url":"https://github.com/istio/istio/pull/3873.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/3873","number":3873,"state":"open","locked":false,"title":"Catch mtls zone aware routing failure, inform as currently unsupported","user":{"login":"liamawhite","id":14291598,"avatar_url":"https://avatars3.githubusercontent.com/u/14291598?v=4","gravatar_id":"","url":"https://api.github.com/users/liamawhite","html_url":"https://github.com/liamawhite","followers_url":"https://api.github.com/users/liamawhite/followers","following_url":"https://api.github.com/users/liamawhite/following{/other_user}","gists_url":"https://api.github.com/users/liamawhite/gists{/gist_id}","starred_url":"https://api.github.com/users/liamawhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamawhite/subscriptions","organizations_url":"https://api.github.com/users/liamawhite/orgs","repos_url":"https://api.github.com/users/liamawhite/repos","events_url":"https://api.github.com/users/liamawhite/events{/privacy}","received_events_url":"https://api.github.com/users/liamawhite/received_events","type":"User","site_admin":false},"body":"Currently, zone aware routing does not work for mTLS because pilot-agent can't talk to Pilot. An issue has been raised against Envoy to support zone aware routing as part of the xDS v2 APIs because our current approach will not work via mTLS.\r\n\r\nThis PR is to inform the user that it is not currently supported and to return gracefully, we currently throw an error due to a timeout.\r\n\r\nThe issue can be found [here](https://github.com/envoyproxy/envoy/issues/2541) and @cmluciano is looking into it.","created_at":"2018-03-01T18:17:26Z","updated_at":"2018-03-01T20:01:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6260e8b29d824525f4058d9b8bc4a555885573c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Reviewers - istio/pilot","id":2627630,"slug":"reviewers-istio-pilot","description":"Members that can review changes to files in istio/pilot","privacy":"closed","url":"https://api.github.com/teams/2627630","members_url":"https://api.github.com/teams/2627630/members{/member}","repositories_url":"https://api.github.com/teams/2627630/repos","permission":"pull"}],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/3873/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/3873/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/3873/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/56aa76091d218864b64ed89a815bbe14c6057293","head":{"label":"liamawhite:mtls","ref":"mtls","sha":"56aa76091d218864b64ed89a815bbe14c6057293","user":{"login":"liamawhite","id":14291598,"avatar_url":"https://avatars3.githubusercontent.com/u/14291598?v=4","gravatar_id":"","url":"https://api.github.com/users/liamawhite","html_url":"https://github.com/liamawhite","followers_url":"https://api.github.com/users/liamawhite/followers","following_url":"https://api.github.com/users/liamawhite/following{/other_user}","gists_url":"https://api.github.com/users/liamawhite/gists{/gist_id}","starred_url":"https://api.github.com/users/liamawhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamawhite/subscriptions","organizations_url":"https://api.github.com/users/liamawhite/orgs","repos_url":"https://api.github.com/users/liamawhite/repos","events_url":"https://api.github.com/users/liamawhite/events{/privacy}","received_events_url":"https://api.github.com/users/liamawhite/received_events","type":"User","site_admin":false},"repo":{"id":109746478,"name":"istio","full_name":"liamawhite/istio","owner":{"login":"liamawhite","id":14291598,"avatar_url":"https://avatars3.githubusercontent.com/u/14291598?v=4","gravatar_id":"","url":"https://api.github.com/users/liamawhite","html_url":"https://github.com/liamawhite","followers_url":"https://api.github.com/users/liamawhite/followers","following_url":"https://api.github.com/users/liamawhite/following{/other_user}","gists_url":"https://api.github.com/users/liamawhite/gists{/gist_id}","starred_url":"https://api.github.com/users/liamawhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liamawhite/subscriptions","organizations_url":"https://api.github.com/users/liamawhite/orgs","repos_url":"https://api.github.com/users/liamawhite/repos","events_url":"https://api.github.com/users/liamawhite/events{/privacy}","received_events_url":"https://api.github.com/users/liamawhite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liamawhite/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/liamawhite/istio","forks_url":"https://api.github.com/repos/liamawhite/istio/forks","keys_url":"https://api.github.com/repos/liamawhite/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liamawhite/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liamawhite/istio/teams","hooks_url":"https://api.github.com/repos/liamawhite/istio/hooks","issue_events_url":"https://api.github.com/repos/liamawhite/istio/issues/events{/number}","events_url":"https://api.github.com/repos/liamawhite/istio/events","assignees_url":"https://api.github.com/repos/liamawhite/istio/assignees{/user}","branches_url":"https://api.github.com/repos/liamawhite/istio/branches{/branch}","tags_url":"https://api.github.com/repos/liamawhite/istio/tags","blobs_url":"https://api.github.com/repos/liamawhite/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liamawhite/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liamawhite/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/liamawhite/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liamawhite/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/liamawhite/istio/languages","stargazers_url":"https://api.github.com/repos/liamawhite/istio/stargazers","contributors_url":"https://api.github.com/repos/liamawhite/istio/contributors","subscribers_url":"https://api.github.com/repos/liamawhite/istio/subscribers","subscription_url":"https://api.github.com/repos/liamawhite/istio/subscription","commits_url":"https://api.github.com/repos/liamawhite/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/liamawhite/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/liamawhite/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/liamawhite/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/liamawhite/istio/contents/{+path}","compare_url":"https://api.github.com/repos/liamawhite/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liamawhite/istio/merges","archive_url":"https://api.github.com/repos/liamawhite/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liamawhite/istio/downloads","issues_url":"https://api.github.com/repos/liamawhite/istio/issues{/number}","pulls_url":"https://api.github.com/repos/liamawhite/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/liamawhite/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/liamawhite/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liamawhite/istio/labels{/name}","releases_url":"https://api.github.com/repos/liamawhite/istio/releases{/id}","deployments_url":"https://api.github.com/repos/liamawhite/istio/deployments","created_at":"2017-11-06T20:32:49Z","updated_at":"2017-11-06T20:32:53Z","pushed_at":"2018-03-01T18:16:18Z","git_url":"git://github.com/liamawhite/istio.git","ssh_url":"git@github.com:liamawhite/istio.git","clone_url":"https://github.com/liamawhite/istio.git","svn_url":"https://github.com/liamawhite/istio","homepage":"https://istio.io","size":16608,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"11c79eeaeafb3b154e498f93835796ce1e3d8966","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-03-01T16:52:20Z","pushed_at":"2018-03-01T19:37:13Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":16823,"stargazers_count":6239,"watchers_count":6239,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":790,"mirror_url":null,"archived":false,"open_issues_count":606,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":790,"open_issues":606,"watchers":6239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/3873"},"html":{"href":"https://github.com/istio/istio/pull/3873"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/3873"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/3873/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/3873/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/3873/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/56aa76091d218864b64ed89a815bbe14c6057293"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cmluciano"}}