{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28314","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28314/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28314/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28314/events","html_url":"https://github.com/Automattic/wp-calypso/issues/28314","id":377930904,"node_id":"MDU6SXNzdWUzNzc5MzA5MDQ=","number":28314,"title":"Gutenberg: some embeds not working correctly in editor","user":{"login":"vindl","id":1182160,"node_id":"MDQ6VXNlcjExODIxNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/1182160?v=4","gravatar_id":"","url":"https://api.github.com/users/vindl","html_url":"https://github.com/vindl","followers_url":"https://api.github.com/users/vindl/followers","following_url":"https://api.github.com/users/vindl/following{/other_user}","gists_url":"https://api.github.com/users/vindl/gists{/gist_id}","starred_url":"https://api.github.com/users/vindl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vindl/subscriptions","organizations_url":"https://api.github.com/users/vindl/orgs","repos_url":"https://api.github.com/users/vindl/repos","events_url":"https://api.github.com/users/vindl/events{/privacy}","received_events_url":"https://api.github.com/users/vindl/received_events","type":"User","site_admin":false},"labels":[{"id":967391996,"node_id":"MDU6TGFiZWw5NjczOTE5OTY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Goal]%20Gutenberg","name":"[Goal] Gutenberg","color":"97f4d2","default":false},{"id":285009975,"node_id":"MDU6TGFiZWwyODUwMDk5NzU=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Bug","name":"[Type] Bug","color":"e11d21","default":false},{"id":1118311386,"node_id":"MDU6TGFiZWwxMTE4MzExMzg2","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/wp-admin","name":"wp-admin","color":"23282d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-06T16:34:47Z","updated_at":"2018-11-06T20:22:38Z","closed_at":null,"author_association":"MEMBER","body":"Previews for embeds from the following list are not working correctly in the editor, but are rendered as expected on the front end when the post is saved.\r\n\r\n- [ ] Facebook\r\n- [ ] Instagram\r\n\r\n(there might be others, I didn't perform the full audit)\r\n\r\n#### Steps to reproduce\r\n1. Use a test site that has opted in to Gutenberg.\r\n2. Navigate to editor in wp-admin.\r\n3. Insert one embed from the above list and try to embed some link.\r\n4. This results in `This block has encountered an error and cannot be previewed.`. or `Previews for this are unavailable in the editor, sorry!`.\r\n\r\nSomething similar is occurring in Calypso integration as a consequence too, although the error message is somewhat different: `Sorry, we could not embed that content.`. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/436395353","html_url":"https://github.com/Automattic/wp-calypso/issues/28314#issuecomment-436395353","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/28314","id":436395353,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjM5NTM1Mw==","user":{"login":"gwwar","id":1270189,"node_id":"MDQ6VXNlcjEyNzAxODk=","avatar_url":"https://avatars3.githubusercontent.com/u/1270189?v=4","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T20:22:38Z","updated_at":"2018-11-06T20:22:38Z","author_association":"MEMBER","body":"Thanks @notnownikki! What if we update the api middleware for wpcom to use the native core endpoint? This probably explains why the editor preview works for us\r\n\r\nhttps://github.com/Automattic/wp-calypso/blob/99bcee2323cd7a59a0594fdb544d0e0e1e29b5ec/client/gutenberg/editor/api-middleware/index.js#L68\r\n\r\nIf we're missing any expected wpcom oembed types, we can work with @mdawaffe to add these."}}
{"actor":{"display_login":"gwwar"}}