{"action":"opened","issue":{"url":"https://api.github.com/repos/OctopusDeploy/Issues/issues/4470","repository_url":"https://api.github.com/repos/OctopusDeploy/Issues","labels_url":"https://api.github.com/repos/OctopusDeploy/Issues/issues/4470/labels{/name}","comments_url":"https://api.github.com/repos/OctopusDeploy/Issues/issues/4470/comments","events_url":"https://api.github.com/repos/OctopusDeploy/Issues/issues/4470/events","html_url":"https://github.com/OctopusDeploy/Issues/issues/4470","id":313171590,"number":4470,"title":"S3 Upload upload behavior and FIPS","user":{"login":"shaunmarx","id":6700195,"avatar_url":"https://avatars1.githubusercontent.com/u/6700195?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunmarx","html_url":"https://github.com/shaunmarx","followers_url":"https://api.github.com/users/shaunmarx/followers","following_url":"https://api.github.com/users/shaunmarx/following{/other_user}","gists_url":"https://api.github.com/users/shaunmarx/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunmarx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunmarx/subscriptions","organizations_url":"https://api.github.com/users/shaunmarx/orgs","repos_url":"https://api.github.com/users/shaunmarx/repos","events_url":"https://api.github.com/users/shaunmarx/events{/privacy}","received_events_url":"https://api.github.com/users/shaunmarx/received_events","type":"User","site_admin":false},"labels":[{"id":809531983,"url":"https://api.github.com/repos/OctopusDeploy/Issues/labels/area/cloud","name":"area/cloud","color":"39ce55","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-11T04:42:16Z","updated_at":"2018-04-11T04:42:16Z","closed_at":null,"author_association":"NONE","body":"The S3 step currently checks the ETag provided by AWS against the MD5 content hash to determine whether it should upload a file. It also falls back to skipping these checks when FIPS mode is enabled resulting in files to be uploaded whether the file content has changed or not.\r\n\r\nIt is suggested that we make this behaviour a bit more flexible by providing the following options on the step:\r\n\r\n(o) Only upload files if they have changed\r\n( )  Always upload files\r\n\r\nIn order to make this behaviour to work with FIPS, we should also fallback to a FIPS supported algorithm such as SHA1 and use object metadata to set this value."}}
{"actor":{"display_login":"shaunmarx"}}