{"action":"created","issue":{"url":"https://api.github.com/repos/thirtybees/statsmodule/issues/7","repository_url":"https://api.github.com/repos/thirtybees/statsmodule","labels_url":"https://api.github.com/repos/thirtybees/statsmodule/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/thirtybees/statsmodule/issues/7/comments","events_url":"https://api.github.com/repos/thirtybees/statsmodule/issues/7/events","html_url":"https://github.com/thirtybees/statsmodule/issues/7","id":316599307,"number":7,"title":"Uses $_SERVER['REDIRECT_URL'], which Nginx doesn't provide.","user":{"login":"Traumflug","id":318581,"avatar_url":"https://avatars0.githubusercontent.com/u/318581?v=4","gravatar_id":"","url":"https://api.github.com/users/Traumflug","html_url":"https://github.com/Traumflug","followers_url":"https://api.github.com/users/Traumflug/followers","following_url":"https://api.github.com/users/Traumflug/following{/other_user}","gists_url":"https://api.github.com/users/Traumflug/gists{/gist_id}","starred_url":"https://api.github.com/users/Traumflug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Traumflug/subscriptions","organizations_url":"https://api.github.com/users/Traumflug/orgs","repos_url":"https://api.github.com/users/Traumflug/repos","events_url":"https://api.github.com/users/Traumflug/events{/privacy}","received_events_url":"https://api.github.com/users/Traumflug/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-22T17:56:23Z","updated_at":"2018-04-22T23:16:36Z","closed_at":null,"author_association":"NONE","body":"Follow up on https://github.com/thirtybees/thirtybees/issues/474\r\n\r\nUsage doesn't appear to be crucial, so simply removing it appears to be the right thing:\r\n\r\n```diff\r\ndiff --git a/stats/pagesnotfound.php b/stats/pagesnotfound.php\r\nindex 99f3481..ec5c966 100644\r\n--- a/stats/pagesnotfound.php\r\n+++ b/stats/pagesnotfound.php\r\n@@ -171,9 +171,7 @@ class PagesNotFound extends StatsModule\r\n \r\n     public function hookTop($params)\r\n     {\r\n-        if (strstr($_SERVER['REQUEST_URI'], '404.php') && isset($_SERVER['REDIRECT_URL']))\r\n-            $_SERVER['REQUEST_URI'] = $_SERVER['REDIRECT_URL'];\r\n-        if (!Validate::isUrl($request_uri = $_SERVER['REQUEST_URI']) || strstr($_SERVER['REQUEST_URI'], '-admin404'))\r\n+        if (!Validate::isUrl($request_uri = $_SERVER['REQUEST_URI']) || strpos($_SERVER['REQUEST_URI'], '-admin404') !== false)\r\n             return;\r\n \r\n         if (get_class(Context::getContext()->controller) == 'PageNotFoundController') {\r\n```\r\n\r\n(this also replaces *strstr()* with the faster *strpos()*)"},"comment":{"url":"https://api.github.com/repos/thirtybees/statsmodule/issues/comments/383420044","html_url":"https://github.com/thirtybees/statsmodule/issues/7#issuecomment-383420044","issue_url":"https://api.github.com/repos/thirtybees/statsmodule/issues/7","id":383420044,"user":{"login":"Traumflug","id":318581,"avatar_url":"https://avatars0.githubusercontent.com/u/318581?v=4","gravatar_id":"","url":"https://api.github.com/users/Traumflug","html_url":"https://github.com/Traumflug","followers_url":"https://api.github.com/users/Traumflug/followers","following_url":"https://api.github.com/users/Traumflug/following{/other_user}","gists_url":"https://api.github.com/users/Traumflug/gists{/gist_id}","starred_url":"https://api.github.com/users/Traumflug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Traumflug/subscriptions","organizations_url":"https://api.github.com/users/Traumflug/orgs","repos_url":"https://api.github.com/users/Traumflug/repos","events_url":"https://api.github.com/users/Traumflug/events{/privacy}","received_events_url":"https://api.github.com/users/Traumflug/received_events","type":"User","site_admin":false},"created_at":"2018-04-22T23:16:36Z","updated_at":"2018-04-22T23:16:36Z","author_association":"NONE","body":"> Pure nginx or in proxy mode?\r\n\r\n@dvershinin should be able to answer this."}}
{"actor":{"display_login":"Traumflug"}}