{"action":"created","issue":{"url":"https://api.github.com/repos/storaged-project/udisks/issues/574","repository_url":"https://api.github.com/repos/storaged-project/udisks","labels_url":"https://api.github.com/repos/storaged-project/udisks/issues/574/labels{/name}","comments_url":"https://api.github.com/repos/storaged-project/udisks/issues/574/comments","events_url":"https://api.github.com/repos/storaged-project/udisks/issues/574/events","html_url":"https://github.com/storaged-project/udisks/pull/574","id":359586707,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDQ0NDk3","number":574,"title":"Filesystem.Unmount waits for mount-points to be updated","user":{"login":"pothos","id":1189130,"node_id":"MDQ6VXNlcjExODkxMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1189130?v=4","gravatar_id":"","url":"https://api.github.com/users/pothos","html_url":"https://github.com/pothos","followers_url":"https://api.github.com/users/pothos/followers","following_url":"https://api.github.com/users/pothos/following{/other_user}","gists_url":"https://api.github.com/users/pothos/gists{/gist_id}","starred_url":"https://api.github.com/users/pothos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pothos/subscriptions","organizations_url":"https://api.github.com/users/pothos/orgs","repos_url":"https://api.github.com/users/pothos/repos","events_url":"https://api.github.com/users/pothos/events{/privacy}","received_events_url":"https://api.github.com/users/pothos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-09-12T17:48:59Z","updated_at":"2018-09-22T12:43:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/storaged-project/udisks/pulls/574","html_url":"https://github.com/storaged-project/udisks/pull/574","diff_url":"https://github.com/storaged-project/udisks/pull/574.diff","patch_url":"https://github.com/storaged-project/udisks/pull/574.patch"},"body":"Clients testing the mount-points property may get wrong\r\nresults due to a race when Filesystem.Unmount method\r\nwas completed but the property not yet updated.\r\n\r\nAdd a waiter to check whether the mount-points property\r\ngot changed before completing the method call.\r\n\r\nhttps://github.com/storaged-project/udisks/issues/573"},"comment":{"url":"https://api.github.com/repos/storaged-project/udisks/issues/comments/423741629","html_url":"https://github.com/storaged-project/udisks/pull/574#issuecomment-423741629","issue_url":"https://api.github.com/repos/storaged-project/udisks/issues/574","id":423741629,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzc0MTYyOQ==","user":{"login":"pothos","id":1189130,"node_id":"MDQ6VXNlcjExODkxMzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1189130?v=4","gravatar_id":"","url":"https://api.github.com/users/pothos","html_url":"https://github.com/pothos","followers_url":"https://api.github.com/users/pothos/followers","following_url":"https://api.github.com/users/pothos/following{/other_user}","gists_url":"https://api.github.com/users/pothos/gists{/gist_id}","starred_url":"https://api.github.com/users/pothos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pothos/subscriptions","organizations_url":"https://api.github.com/users/pothos/orgs","repos_url":"https://api.github.com/users/pothos/repos","events_url":"https://api.github.com/users/pothos/events{/privacy}","received_events_url":"https://api.github.com/users/pothos/received_events","type":"User","site_admin":false},"created_at":"2018-09-22T12:43:37Z","updated_at":"2018-09-22T12:43:37Z","author_association":"CONTRIBUTOR","body":"The wait Filesystem.Unmount currently works it is not clear which mount point is supposed to be unmounted because it does not use the property but the mounted-fs file to read it and otherwise unmounts `/dev/blockfile` which will pick any mountpoint. Therefore I would just let it check if there was a change in the property."}}
{"actor":{"display_login":"pothos"}}