{"action":"created","issue":{"url":"https://api.github.com/repos/CameraKit/camerakit-android/issues/318","repository_url":"https://api.github.com/repos/CameraKit/camerakit-android","labels_url":"https://api.github.com/repos/CameraKit/camerakit-android/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/CameraKit/camerakit-android/issues/318/comments","events_url":"https://api.github.com/repos/CameraKit/camerakit-android/issues/318/events","html_url":"https://github.com/CameraKit/camerakit-android/pull/318","id":295231403,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3NzYyODgx","number":318,"title":"Release v1.0.0","user":{"login":"dwillmc","id":4663457,"node_id":"MDQ6VXNlcjQ2NjM0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4663457?v=4","gravatar_id":"","url":"https://api.github.com/users/dwillmc","html_url":"https://github.com/dwillmc","followers_url":"https://api.github.com/users/dwillmc/followers","following_url":"https://api.github.com/users/dwillmc/following{/other_user}","gists_url":"https://api.github.com/users/dwillmc/gists{/gist_id}","starred_url":"https://api.github.com/users/dwillmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwillmc/subscriptions","organizations_url":"https://api.github.com/users/dwillmc/orgs","repos_url":"https://api.github.com/users/dwillmc/repos","events_url":"https://api.github.com/users/dwillmc/events{/privacy}","received_events_url":"https://api.github.com/users/dwillmc/received_events","type":"User","site_admin":false},"labels":[{"id":707226286,"node_id":"MDU6TGFiZWw3MDcyMjYyODY=","url":"https://api.github.com/repos/CameraKit/camerakit-android/labels/Priority:%20High","name":"Priority: High","color":"eb6420","default":false},{"id":707226298,"node_id":"MDU6TGFiZWw3MDcyMjYyOTg=","url":"https://api.github.com/repos/CameraKit/camerakit-android/labels/Status:%20In%20Progress","name":"Status: In Progress","color":"cccccc","default":false},{"id":707226294,"node_id":"MDU6TGFiZWw3MDcyMjYyOTQ=","url":"https://api.github.com/repos/CameraKit/camerakit-android/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"austinkettner","id":1452537,"node_id":"MDQ6VXNlcjE0NTI1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1452537?v=4","gravatar_id":"","url":"https://api.github.com/users/austinkettner","html_url":"https://github.com/austinkettner","followers_url":"https://api.github.com/users/austinkettner/followers","following_url":"https://api.github.com/users/austinkettner/following{/other_user}","gists_url":"https://api.github.com/users/austinkettner/gists{/gist_id}","starred_url":"https://api.github.com/users/austinkettner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinkettner/subscriptions","organizations_url":"https://api.github.com/users/austinkettner/orgs","repos_url":"https://api.github.com/users/austinkettner/repos","events_url":"https://api.github.com/users/austinkettner/events{/privacy}","received_events_url":"https://api.github.com/users/austinkettner/received_events","type":"User","site_admin":false},"assignees":[{"login":"austinkettner","id":1452537,"node_id":"MDQ6VXNlcjE0NTI1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1452537?v=4","gravatar_id":"","url":"https://api.github.com/users/austinkettner","html_url":"https://github.com/austinkettner","followers_url":"https://api.github.com/users/austinkettner/followers","following_url":"https://api.github.com/users/austinkettner/following{/other_user}","gists_url":"https://api.github.com/users/austinkettner/gists{/gist_id}","starred_url":"https://api.github.com/users/austinkettner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinkettner/subscriptions","organizations_url":"https://api.github.com/users/austinkettner/orgs","repos_url":"https://api.github.com/users/austinkettner/repos","events_url":"https://api.github.com/users/austinkettner/events{/privacy}","received_events_url":"https://api.github.com/users/austinkettner/received_events","type":"User","site_admin":false},{"login":"dwillmc","id":4663457,"node_id":"MDQ6VXNlcjQ2NjM0NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4663457?v=4","gravatar_id":"","url":"https://api.github.com/users/dwillmc","html_url":"https://github.com/dwillmc","followers_url":"https://api.github.com/users/dwillmc/followers","following_url":"https://api.github.com/users/dwillmc/following{/other_user}","gists_url":"https://api.github.com/users/dwillmc/gists{/gist_id}","starred_url":"https://api.github.com/users/dwillmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwillmc/subscriptions","organizations_url":"https://api.github.com/users/dwillmc/orgs","repos_url":"https://api.github.com/users/dwillmc/repos","events_url":"https://api.github.com/users/dwillmc/events{/privacy}","received_events_url":"https://api.github.com/users/dwillmc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CameraKit/camerakit-android/milestones/1","html_url":"https://github.com/CameraKit/camerakit-android/milestone/1","labels_url":"https://api.github.com/repos/CameraKit/camerakit-android/milestones/1/labels","id":2804395,"node_id":"MDk6TWlsZXN0b25lMjgwNDM5NQ==","number":1,"title":"1.0.0","description":"","creator":{"login":"austinkettner","id":1452537,"node_id":"MDQ6VXNlcjE0NTI1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1452537?v=4","gravatar_id":"","url":"https://api.github.com/users/austinkettner","html_url":"https://github.com/austinkettner","followers_url":"https://api.github.com/users/austinkettner/followers","following_url":"https://api.github.com/users/austinkettner/following{/other_user}","gists_url":"https://api.github.com/users/austinkettner/gists{/gist_id}","starred_url":"https://api.github.com/users/austinkettner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinkettner/subscriptions","organizations_url":"https://api.github.com/users/austinkettner/orgs","repos_url":"https://api.github.com/users/austinkettner/repos","events_url":"https://api.github.com/users/austinkettner/events{/privacy}","received_events_url":"https://api.github.com/users/austinkettner/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":35,"state":"open","created_at":"2017-09-30T13:43:04Z","updated_at":"2018-09-21T16:15:15Z","due_on":null,"closed_at":null},"comments":128,"created_at":"2018-02-07T17:46:32Z","updated_at":"2018-10-11T16:34:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CameraKit/camerakit-android/pulls/318","html_url":"https://github.com/CameraKit/camerakit-android/pull/318","diff_url":"https://github.com/CameraKit/camerakit-android/pull/318.diff","patch_url":"https://github.com/CameraKit/camerakit-android/pull/318.patch"},"body":"This is the v1.0.0 Release of CameraKit. This release embodies over 9 months of work, with massive refactors to all parts of the codebase. This PR and changelog are not complete, yet.\r\n---\r\n## Test the PR\r\nReady to test:\r\n- [x] Camera Preview\r\n- [x] Runtime permissions\r\n- [x] Photos\r\n\r\n## Still Coming\r\n- [ ] setMethod() function on cameraView\r\n\r\n### Dependency\r\n\r\n```groovy\r\n// Add our snapshot repository.\r\nrepositories {\r\n    maven { url 'https://dl.bintray.com/camerakit/camerakit-android-snapshots' }\r\n}\r\n\r\n// Make sure snapshots won't get cached.\r\nconfigurations.all {\r\n    resolutionStrategy.cacheChangingModulesFor 0, 'seconds'\r\n}\r\n\r\ndependencies {\r\n    implementation group: 'com.camerakit', name:'camerakit', version:'1.0.0-Snapshot', changing: true\r\n}\r\n```\r\n\r\n### Add a CameraKitView\r\n\r\nMake sure everything looks proper with any phone rotation, while screen orientation is on auto-rotate or locked.\r\nOpen and close the app drawer and dismiss the app to make sure the camera stops and starts properly.\r\n\r\nBasic fullscreen CameraKitView:\r\n```xml\r\n<com.camerakit.CameraKitView xmlns:app=\"http://schemas.android.com/apk/res-auto\"\r\n    android:id=\"@+id/camera\"\r\n    android:layout_width=\"match_parent\"\r\n    android:layout_height=\"match_parent\"\r\n    app:camera_facing=\"back\" />\r\n```\r\n\r\nCameraKitView that adjusts dimenions to perfectly match previews true aspect ratio - nothing cut-off:\r\n```xml\r\n<com.camerakit.CameraKitView xmlns:app=\"http://schemas.android.com/apk/res-auto\"\r\n    android:id=\"@+id/camera\"\r\n    android:layout_width=\"match_parent\"\r\n    android:layout_height=\"wrap_content\"\r\n    android:adjustViewBounds=\"true\"\r\n    app:camera_facing=\"back\" />\r\n```\r\n\r\nSquare CameraKitView using `app:camera_aspectRatio`:\r\n```xml\r\n<com.camerakit.CameraKitView xmlns:app=\"http://schemas.android.com/apk/res-auto\"\r\n    android:id=\"@+id/camera\"\r\n    android:layout_width=\"match_parent\"\r\n    android:layout_height=\"wrap_content\"\r\n    android:adjustViewBounds=\"true\"\r\n    app:camera_aspectRatio=\"1:1\"\r\n    app:camera_facing=\"back\" />\r\n```\r\n\r\n#### MainActivity\r\n\r\nBind the CameraKitView into your activity and implement pass-through methods for `onResume()`, `onPause()`, and if you want the CameraKitView to automatically handle runtime permissions, `onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults)`.\r\n\r\n```java\r\npublic class MainActivity extends AppCompatActivity {\r\n    \r\n    private CameraKitView cameraKitView;\r\n\r\n    @Override\r\n    protected void onCreate(Bundle savedInstanceState) {\r\n        super.onCreate(savedInstanceState);\r\n        setContentView(R.layout.activity_main);\r\n        cameraKitView = findViewById(R.id.camera);\r\n    }\r\n\r\n    @Override\r\n    protected void onResume() {\r\n        super.onResume();\r\n        cameraKitView.onResume();\r\n    }\r\n\r\n    @Override\r\n    protected void onPause() {\r\n        cameraKitView.onPause();\r\n        super.onPause();\r\n    }\r\n\r\n    @Override\r\n    public void onRequestPermissionsResult(int requestCode, @NonNull String[] permissions, @NonNull int[] grantResults) {\r\n        super.onRequestPermissionsResult(requestCode, permissions, grantResults);\r\n        cameraKitView.onRequestPermissionsResult(requestCode, permissions, grantResults);\r\n    }\r\n    \r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/CameraKit/camerakit-android/issues/comments/429026046","html_url":"https://github.com/CameraKit/camerakit-android/pull/318#issuecomment-429026046","issue_url":"https://api.github.com/repos/CameraKit/camerakit-android/issues/318","id":429026046,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAyNjA0Ng==","user":{"login":"ParmuSingh","id":22577208,"node_id":"MDQ6VXNlcjIyNTc3MjA4","avatar_url":"https://avatars2.githubusercontent.com/u/22577208?v=4","gravatar_id":"","url":"https://api.github.com/users/ParmuSingh","html_url":"https://github.com/ParmuSingh","followers_url":"https://api.github.com/users/ParmuSingh/followers","following_url":"https://api.github.com/users/ParmuSingh/following{/other_user}","gists_url":"https://api.github.com/users/ParmuSingh/gists{/gist_id}","starred_url":"https://api.github.com/users/ParmuSingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParmuSingh/subscriptions","organizations_url":"https://api.github.com/users/ParmuSingh/orgs","repos_url":"https://api.github.com/users/ParmuSingh/repos","events_url":"https://api.github.com/users/ParmuSingh/events{/privacy}","received_events_url":"https://api.github.com/users/ParmuSingh/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T16:34:53Z","updated_at":"2018-10-11T16:34:53Z","author_association":"NONE","body":"how long till this merges to master? The documentation is unavailable and this is getting really difficult to work with.\r\n\r\nMy question, How to take image?\r\n\r\nI tried:\r\n\r\n```\r\n cameraKitView.setCameraListener(new CameraKitView.CameraListener(){\r\n\r\n            @Override\r\n            public void onOpened() {\r\n                \r\n            }\r\n\r\n            @Override\r\n            public void onClosed() {\r\n\r\n            }\r\n        });\r\n```\r\n\r\nhow do I handle images?"}}
{"actor":{"display_login":"ParmuSingh"}}