{"action":"created","comment":{"url":"https://api.github.com/repos/Fourdee/DietPi/pulls/comments/236082846","pull_request_review_id":178090587,"id":236082846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA4Mjg0Ng==","diff_hunk":"@@ -165,75 +165,67 @@ _EOF_\n \n \t}\n \n-\tReset_NTPD(){\n+\tReset_Timesync(){\n \n \t\tkillall -w /DietPi/dietpi/func/run_ntpd &> /dev/null\n \n \t}\n \n \tCheck_Internet_and_NTPD(){\n \n-\t\t#Internet\n+\t\t# Internet\n \t\t# - Use /etc/apt/sources.list for connection test\n \t\tlocal internet_url_test=\"$(grep -m1 '^[[:blank:]]*deb ' /etc/apt/sources.list | awk '{print $2}')\"\n-\t\toptional_cmd_inputs='--no-check-certificate' G_CHECK_URL \"$internet_url_test\" #will exit on failure here then prompt user to configure network\n+\t\toptional_cmd_inputs='--no-check-certificate' G_CHECK_URL \"$internet_url_test\" # Will exit on failure here then prompt user to configure network\n \n-\t\t#NTPD\n-\t\twhile :\n+\t\t# Timesync\n+\t\tuntil /DietPi/dietpi/func/run_ntpd","path":"dietpi/dietpi-software","position":32,"original_position":32,"commit_id":"630d62b57dc5a529066594b17a64952878842cc9","original_commit_id":"630d62b57dc5a529066594b17a64952878842cc9","user":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"body":"@MichaIng \r\n\r\nNice 👍 ","created_at":"2018-11-25T17:41:17Z","updated_at":"2018-11-25T17:41:17Z","html_url":"https://github.com/Fourdee/DietPi/pull/2277#discussion_r236082846","pull_request_url":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Fourdee/DietPi/pulls/comments/236082846"},"html":{"href":"https://github.com/Fourdee/DietPi/pull/2277#discussion_r236082846"},"pull_request":{"href":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277"}}},"pull_request":{"url":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277","id":233330029,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzMwMDI5","html_url":"https://github.com/Fourdee/DietPi/pull/2277","diff_url":"https://github.com/Fourdee/DietPi/pull/2277.diff","patch_url":"https://github.com/Fourdee/DietPi/pull/2277.patch","issue_url":"https://api.github.com/repos/Fourdee/DietPi/issues/2277","number":2277,"state":"open","locked":false,"title":"DietPi-Software | Single missing white space and many minor code improvements","user":{"login":"MichaIng","id":28480705,"node_id":"MDQ6VXNlcjI4NDgwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/28480705?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaIng","html_url":"https://github.com/MichaIng","followers_url":"https://api.github.com/users/MichaIng/followers","following_url":"https://api.github.com/users/MichaIng/following{/other_user}","gists_url":"https://api.github.com/users/MichaIng/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaIng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaIng/subscriptions","organizations_url":"https://api.github.com/users/MichaIng/orgs","repos_url":"https://api.github.com/users/MichaIng/repos","events_url":"https://api.github.com/users/MichaIng/events{/privacy}","received_events_url":"https://api.github.com/users/MichaIng/received_events","type":"User","site_admin":false},"body":"**Status**: Ready\r\n- [x] Test NTP error handling\r\n- [x] Careful review 😉\r\n\r\n**Commit list/description**:\r\n+ DietPi-Software | Single missing white space and many minor code improvements\r\n","created_at":"2018-11-24T17:13:59Z","updated_at":"2018-11-25T17:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42c5cce7d55f91f53d2abbbcc8fb271dc06c20e2","assignee":{"login":"MichaIng","id":28480705,"node_id":"MDQ6VXNlcjI4NDgwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/28480705?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaIng","html_url":"https://github.com/MichaIng","followers_url":"https://api.github.com/users/MichaIng/followers","following_url":"https://api.github.com/users/MichaIng/following{/other_user}","gists_url":"https://api.github.com/users/MichaIng/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaIng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaIng/subscriptions","organizations_url":"https://api.github.com/users/MichaIng/orgs","repos_url":"https://api.github.com/users/MichaIng/repos","events_url":"https://api.github.com/users/MichaIng/events{/privacy}","received_events_url":"https://api.github.com/users/MichaIng/received_events","type":"User","site_admin":false},"assignees":[{"login":"MichaIng","id":28480705,"node_id":"MDQ6VXNlcjI4NDgwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/28480705?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaIng","html_url":"https://github.com/MichaIng","followers_url":"https://api.github.com/users/MichaIng/followers","following_url":"https://api.github.com/users/MichaIng/following{/other_user}","gists_url":"https://api.github.com/users/MichaIng/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaIng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaIng/subscriptions","organizations_url":"https://api.github.com/users/MichaIng/orgs","repos_url":"https://api.github.com/users/MichaIng/repos","events_url":"https://api.github.com/users/MichaIng/events{/privacy}","received_events_url":"https://api.github.com/users/MichaIng/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":187191723,"node_id":"MDU6TGFiZWwxODcxOTE3MjM=","url":"https://api.github.com/repos/Fourdee/DietPi/labels/Enhancement%20:dash:","name":"Enhancement :dash:","color":"84b6eb","default":false}],"milestone":{"url":"https://api.github.com/repos/Fourdee/DietPi/milestones/83","html_url":"https://github.com/Fourdee/DietPi/milestone/83","labels_url":"https://api.github.com/repos/Fourdee/DietPi/milestones/83/labels","id":3759186,"node_id":"MDk6TWlsZXN0b25lMzc1OTE4Ng==","number":83,"title":"v6.18","description":"","creator":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":61,"state":"open","created_at":"2018-10-22T23:54:40Z","updated_at":"2018-11-25T17:30:49Z","due_on":"2018-11-24T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277/commits","review_comments_url":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277/comments","review_comment_url":"https://api.github.com/repos/Fourdee/DietPi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fourdee/DietPi/issues/2277/comments","statuses_url":"https://api.github.com/repos/Fourdee/DietPi/statuses/630d62b57dc5a529066594b17a64952878842cc9","head":{"label":"Fourdee:dietpi-software","ref":"dietpi-software","sha":"630d62b57dc5a529066594b17a64952878842cc9","user":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"repo":{"id":32219677,"node_id":"MDEwOlJlcG9zaXRvcnkzMjIxOTY3Nw==","name":"DietPi","full_name":"Fourdee/DietPi","private":false,"owner":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Fourdee/DietPi","description":"Lightweight justice for your single-board computer.","fork":false,"url":"https://api.github.com/repos/Fourdee/DietPi","forks_url":"https://api.github.com/repos/Fourdee/DietPi/forks","keys_url":"https://api.github.com/repos/Fourdee/DietPi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fourdee/DietPi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fourdee/DietPi/teams","hooks_url":"https://api.github.com/repos/Fourdee/DietPi/hooks","issue_events_url":"https://api.github.com/repos/Fourdee/DietPi/issues/events{/number}","events_url":"https://api.github.com/repos/Fourdee/DietPi/events","assignees_url":"https://api.github.com/repos/Fourdee/DietPi/assignees{/user}","branches_url":"https://api.github.com/repos/Fourdee/DietPi/branches{/branch}","tags_url":"https://api.github.com/repos/Fourdee/DietPi/tags","blobs_url":"https://api.github.com/repos/Fourdee/DietPi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fourdee/DietPi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fourdee/DietPi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fourdee/DietPi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fourdee/DietPi/statuses/{sha}","languages_url":"https://api.github.com/repos/Fourdee/DietPi/languages","stargazers_url":"https://api.github.com/repos/Fourdee/DietPi/stargazers","contributors_url":"https://api.github.com/repos/Fourdee/DietPi/contributors","subscribers_url":"https://api.github.com/repos/Fourdee/DietPi/subscribers","subscription_url":"https://api.github.com/repos/Fourdee/DietPi/subscription","commits_url":"https://api.github.com/repos/Fourdee/DietPi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fourdee/DietPi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fourdee/DietPi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fourdee/DietPi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fourdee/DietPi/contents/{+path}","compare_url":"https://api.github.com/repos/Fourdee/DietPi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fourdee/DietPi/merges","archive_url":"https://api.github.com/repos/Fourdee/DietPi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fourdee/DietPi/downloads","issues_url":"https://api.github.com/repos/Fourdee/DietPi/issues{/number}","pulls_url":"https://api.github.com/repos/Fourdee/DietPi/pulls{/number}","milestones_url":"https://api.github.com/repos/Fourdee/DietPi/milestones{/number}","notifications_url":"https://api.github.com/repos/Fourdee/DietPi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fourdee/DietPi/labels{/name}","releases_url":"https://api.github.com/repos/Fourdee/DietPi/releases{/id}","deployments_url":"https://api.github.com/repos/Fourdee/DietPi/deployments","created_at":"2015-03-14T15:58:28Z","updated_at":"2018-11-24T15:32:43Z","pushed_at":"2018-11-25T17:24:11Z","git_url":"git://github.com/Fourdee/DietPi.git","ssh_url":"git@github.com:Fourdee/DietPi.git","clone_url":"https://github.com/Fourdee/DietPi.git","svn_url":"https://github.com/Fourdee/DietPi","homepage":"http://dietpi.com","size":121256,"stargazers_count":1068,"watchers_count":1068,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":159,"open_issues":115,"watchers":1068,"default_branch":"master"}},"base":{"label":"Fourdee:dev","ref":"dev","sha":"703d5e0cff4ef912c7fc7e1b220939b774a26e1b","user":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"repo":{"id":32219677,"node_id":"MDEwOlJlcG9zaXRvcnkzMjIxOTY3Nw==","name":"DietPi","full_name":"Fourdee/DietPi","private":false,"owner":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Fourdee/DietPi","description":"Lightweight justice for your single-board computer.","fork":false,"url":"https://api.github.com/repos/Fourdee/DietPi","forks_url":"https://api.github.com/repos/Fourdee/DietPi/forks","keys_url":"https://api.github.com/repos/Fourdee/DietPi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fourdee/DietPi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fourdee/DietPi/teams","hooks_url":"https://api.github.com/repos/Fourdee/DietPi/hooks","issue_events_url":"https://api.github.com/repos/Fourdee/DietPi/issues/events{/number}","events_url":"https://api.github.com/repos/Fourdee/DietPi/events","assignees_url":"https://api.github.com/repos/Fourdee/DietPi/assignees{/user}","branches_url":"https://api.github.com/repos/Fourdee/DietPi/branches{/branch}","tags_url":"https://api.github.com/repos/Fourdee/DietPi/tags","blobs_url":"https://api.github.com/repos/Fourdee/DietPi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fourdee/DietPi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fourdee/DietPi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fourdee/DietPi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fourdee/DietPi/statuses/{sha}","languages_url":"https://api.github.com/repos/Fourdee/DietPi/languages","stargazers_url":"https://api.github.com/repos/Fourdee/DietPi/stargazers","contributors_url":"https://api.github.com/repos/Fourdee/DietPi/contributors","subscribers_url":"https://api.github.com/repos/Fourdee/DietPi/subscribers","subscription_url":"https://api.github.com/repos/Fourdee/DietPi/subscription","commits_url":"https://api.github.com/repos/Fourdee/DietPi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fourdee/DietPi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fourdee/DietPi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fourdee/DietPi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fourdee/DietPi/contents/{+path}","compare_url":"https://api.github.com/repos/Fourdee/DietPi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fourdee/DietPi/merges","archive_url":"https://api.github.com/repos/Fourdee/DietPi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fourdee/DietPi/downloads","issues_url":"https://api.github.com/repos/Fourdee/DietPi/issues{/number}","pulls_url":"https://api.github.com/repos/Fourdee/DietPi/pulls{/number}","milestones_url":"https://api.github.com/repos/Fourdee/DietPi/milestones{/number}","notifications_url":"https://api.github.com/repos/Fourdee/DietPi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fourdee/DietPi/labels{/name}","releases_url":"https://api.github.com/repos/Fourdee/DietPi/releases{/id}","deployments_url":"https://api.github.com/repos/Fourdee/DietPi/deployments","created_at":"2015-03-14T15:58:28Z","updated_at":"2018-11-24T15:32:43Z","pushed_at":"2018-11-25T17:24:11Z","git_url":"git://github.com/Fourdee/DietPi.git","ssh_url":"git@github.com:Fourdee/DietPi.git","clone_url":"https://github.com/Fourdee/DietPi.git","svn_url":"https://github.com/Fourdee/DietPi","homepage":"http://dietpi.com","size":121256,"stargazers_count":1068,"watchers_count":1068,"language":"Shell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"open_issues_count":115,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":159,"open_issues":115,"watchers":1068,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277"},"html":{"href":"https://github.com/Fourdee/DietPi/pull/2277"},"issue":{"href":"https://api.github.com/repos/Fourdee/DietPi/issues/2277"},"comments":{"href":"https://api.github.com/repos/Fourdee/DietPi/issues/2277/comments"},"review_comments":{"href":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277/comments"},"review_comment":{"href":"https://api.github.com/repos/Fourdee/DietPi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fourdee/DietPi/pulls/2277/commits"},"statuses":{"href":"https://api.github.com/repos/Fourdee/DietPi/statuses/630d62b57dc5a529066594b17a64952878842cc9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Fourdee"}}