{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/185370423","pull_request_review_id":116744373,"id":185370423,"diff_hunk":"@@ -0,0 +1,72 @@\n+/**\n+ * @license\n+ * Copyright 2018 Palantir Technologies, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+import { isForStatement } from \"tsutils\";\n+import * as ts from \"typescript\";\n+import * as Lint from \"../index\";\n+\n+export class Rule extends Lint.Rules.AbstractRule {\n+    /* tslint:disable:object-literal-sort-keys */\n+    public static metadata: Lint.IRuleMetadata = {\n+        ruleName: \"prefer-while\",\n+        description: \"Prefer while loops when instead of a for loop without an initializer and incrementor.\",","path":"src/rules/preferWhileRule.ts","position":null,"original_position":26,"commit_id":"8fa8062fd68d2f5d7f32a85ea84325447728c5f3","original_commit_id":"180190d74dfc7520035bc80435edf0cbcc96b2b6","user":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"body":"Done in ec8b337","created_at":"2018-05-02T00:40:03Z","updated_at":"2018-05-02T00:40:03Z","html_url":"https://github.com/palantir/tslint/pull/3750#discussion_r185370423","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/3750","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/185370423"},"html":{"href":"https://github.com/palantir/tslint/pull/3750#discussion_r185370423"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3750"}},"in_reply_to_id":185343010},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/3750","id":172125818,"html_url":"https://github.com/palantir/tslint/pull/3750","diff_url":"https://github.com/palantir/tslint/pull/3750.diff","patch_url":"https://github.com/palantir/tslint/pull/3750.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/3750","number":3750,"state":"open","locked":false,"title":"[new-rule]prefer-while rule","user":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"body":"#### PR checklist\r\n\r\n- [X] Addresses an existing issue: #2040 \r\n- [X] New feature, bugfix, or enhancement\r\n  - [X] Includes tests\r\n- [X] Documentation update\r\n\r\n#### Overview of change:\r\n- Enforces new lines after file header via new configuration key to be provided in TSLint file\r\n- Based off of https://github.com/ajafff/tslint-consistent-codestyle/blob/master/rules/preferWhileRule.ts\r\n\r\n","created_at":"2018-03-01T02:11:13Z","updated_at":"2018-05-02T00:40:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4102fbb47482a95c19f32685d508dbc6f29a28fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/3750/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/3750/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/3750/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/8fa8062fd68d2f5d7f32a85ea84325447728c5f3","head":{"label":"rwaskiewicz:prefer-while","ref":"prefer-while","sha":"8fa8062fd68d2f5d7f32a85ea84325447728c5f3","user":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"repo":{"id":116753425,"name":"tslint","full_name":"rwaskiewicz/tslint","owner":{"login":"rwaskiewicz","id":1930213,"avatar_url":"https://avatars0.githubusercontent.com/u/1930213?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaskiewicz","html_url":"https://github.com/rwaskiewicz","followers_url":"https://api.github.com/users/rwaskiewicz/followers","following_url":"https://api.github.com/users/rwaskiewicz/following{/other_user}","gists_url":"https://api.github.com/users/rwaskiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaskiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaskiewicz/subscriptions","organizations_url":"https://api.github.com/users/rwaskiewicz/orgs","repos_url":"https://api.github.com/users/rwaskiewicz/repos","events_url":"https://api.github.com/users/rwaskiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/rwaskiewicz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaskiewicz/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":true,"url":"https://api.github.com/repos/rwaskiewicz/tslint","forks_url":"https://api.github.com/repos/rwaskiewicz/tslint/forks","keys_url":"https://api.github.com/repos/rwaskiewicz/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaskiewicz/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaskiewicz/tslint/teams","hooks_url":"https://api.github.com/repos/rwaskiewicz/tslint/hooks","issue_events_url":"https://api.github.com/repos/rwaskiewicz/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/rwaskiewicz/tslint/events","assignees_url":"https://api.github.com/repos/rwaskiewicz/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/rwaskiewicz/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/rwaskiewicz/tslint/tags","blobs_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaskiewicz/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaskiewicz/tslint/languages","stargazers_url":"https://api.github.com/repos/rwaskiewicz/tslint/stargazers","contributors_url":"https://api.github.com/repos/rwaskiewicz/tslint/contributors","subscribers_url":"https://api.github.com/repos/rwaskiewicz/tslint/subscribers","subscription_url":"https://api.github.com/repos/rwaskiewicz/tslint/subscription","commits_url":"https://api.github.com/repos/rwaskiewicz/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaskiewicz/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaskiewicz/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaskiewicz/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaskiewicz/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/rwaskiewicz/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaskiewicz/tslint/merges","archive_url":"https://api.github.com/repos/rwaskiewicz/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaskiewicz/tslint/downloads","issues_url":"https://api.github.com/repos/rwaskiewicz/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/rwaskiewicz/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaskiewicz/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaskiewicz/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaskiewicz/tslint/labels{/name}","releases_url":"https://api.github.com/repos/rwaskiewicz/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/rwaskiewicz/tslint/deployments","created_at":"2018-01-09T02:12:57Z","updated_at":"2018-01-09T02:13:00Z","pushed_at":"2018-05-02T00:39:34Z","git_url":"git://github.com/rwaskiewicz/tslint.git","ssh_url":"git@github.com:rwaskiewicz/tslint.git","clone_url":"https://github.com/rwaskiewicz/tslint.git","svn_url":"https://github.com/rwaskiewicz/tslint","homepage":"http://palantir.github.io/tslint/","size":13650,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"235561e411c58ecbd4d96844fae28e998f0ccbda","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2018-05-01T22:59:09Z","pushed_at":"2018-05-02T00:39:35Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":13758,"stargazers_count":3263,"watchers_count":3263,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":632,"mirror_url":null,"archived":false,"open_issues_count":588,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":632,"open_issues":588,"watchers":3263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3750"},"html":{"href":"https://github.com/palantir/tslint/pull/3750"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/3750"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/3750/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3750/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3750/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/8fa8062fd68d2f5d7f32a85ea84325447728c5f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rwaskiewicz"}}