{"action":"created","issue":{"url":"https://api.github.com/repos/adammurdoch/native-platform/issues/30","repository_url":"https://api.github.com/repos/adammurdoch/native-platform","labels_url":"https://api.github.com/repos/adammurdoch/native-platform/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/adammurdoch/native-platform/issues/30/comments","events_url":"https://api.github.com/repos/adammurdoch/native-platform/issues/30/events","html_url":"https://github.com/adammurdoch/native-platform/pull/30","id":392307606,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjA5Mzg2","number":30,"title":"Allow stat() to handle paths that happen to match an existing file ","user":{"login":"ghale","id":642656,"node_id":"MDQ6VXNlcjY0MjY1Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/642656?v=4","gravatar_id":"","url":"https://api.github.com/users/ghale","html_url":"https://github.com/ghale","followers_url":"https://api.github.com/users/ghale/followers","following_url":"https://api.github.com/users/ghale/following{/other_user}","gists_url":"https://api.github.com/users/ghale/gists{/gist_id}","starred_url":"https://api.github.com/users/ghale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghale/subscriptions","organizations_url":"https://api.github.com/users/ghale/orgs","repos_url":"https://api.github.com/users/ghale/repos","events_url":"https://api.github.com/users/ghale/events{/privacy}","received_events_url":"https://api.github.com/users/ghale/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-18T19:46:39Z","updated_at":"2018-12-18T20:33:08Z","closed_at":"2018-12-18T20:32:58Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/adammurdoch/native-platform/pulls/30","html_url":"https://github.com/adammurdoch/native-platform/pull/30","diff_url":"https://github.com/adammurdoch/native-platform/pull/30.diff","patch_url":"https://github.com/adammurdoch/native-platform/pull/30.patch"},"body":"There are a couple of things in this pull request:\r\n\r\n- Changes so that `stat()` does not return an exception when something in the path happens to match some existing file.  It now treats it like the path is not found rather than an error.\r\n- Changes to build with Xcode10 on OSX.  This also drops support for OSX 32-bit.\r\n- Some updates/refactors to tests to get them to pass on various platforms:\r\n  - Ignore the test for file names longer than the 260 character max on windows.\r\n  - Resolve the timestamp difference between `stat()` and java file methods on macOS.\r\n  - Fix an issue on OSX/jdk8 where closing the file watch was causing an EBADF instead of EINTR when polling for the next change.\r\n\r\nThe tests all pass for me now on both jdk7 and jdk8 on OSX, Linux and Windows.  I did not find any jvm-specific differences that seemed to require any special handling (at least on the OS/JVM combinations I tested with).\r\n"},"comment":{"url":"https://api.github.com/repos/adammurdoch/native-platform/issues/comments/448360282","html_url":"https://github.com/adammurdoch/native-platform/pull/30#issuecomment-448360282","issue_url":"https://api.github.com/repos/adammurdoch/native-platform/issues/30","id":448360282,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODM2MDI4Mg==","user":{"login":"adammurdoch","id":99316,"node_id":"MDQ6VXNlcjk5MzE2","avatar_url":"https://avatars2.githubusercontent.com/u/99316?v=4","gravatar_id":"","url":"https://api.github.com/users/adammurdoch","html_url":"https://github.com/adammurdoch","followers_url":"https://api.github.com/users/adammurdoch/followers","following_url":"https://api.github.com/users/adammurdoch/following{/other_user}","gists_url":"https://api.github.com/users/adammurdoch/gists{/gist_id}","starred_url":"https://api.github.com/users/adammurdoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adammurdoch/subscriptions","organizations_url":"https://api.github.com/users/adammurdoch/orgs","repos_url":"https://api.github.com/users/adammurdoch/repos","events_url":"https://api.github.com/users/adammurdoch/events{/privacy}","received_events_url":"https://api.github.com/users/adammurdoch/received_events","type":"User","site_admin":false},"created_at":"2018-12-18T20:33:08Z","updated_at":"2018-12-18T20:33:08Z","author_association":"OWNER","body":"Looks good, thanks."}}
{"actor":{"display_login":"adammurdoch"}}