{"action":"closed","number":29073,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29073","id":210950693,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTUwNjkz","html_url":"https://github.com/cockroachdb/cockroach/pull/29073","diff_url":"https://github.com/cockroachdb/cockroach/pull/29073.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/29073.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/29073","number":29073,"state":"closed","locked":false,"title":"sql: make sure lookup join closes its inputs","user":{"login":"jordanlewis","id":43821,"node_id":"MDQ6VXNlcjQzODIx","avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"body":"Previously, local lookup join wasn't programmed to close itself properly\r\n- if it wasn't running in local fallback mode, it would fail to\r\npropagate its close signal to its upstream planNodes. This could lead to\r\nmemory account errors if the upstream planNodes were retaining memory.\r\n\r\nNeeds a backport.\r\n\r\nRelease note: None","created_at":"2018-08-26T13:06:14Z","updated_at":"2018-08-26T14:34:43Z","closed_at":"2018-08-26T14:34:43Z","merged_at":"2018-08-26T14:34:43Z","merge_commit_sha":"7e47ac6ec9c53bed980f789506adbb2a93b2be79","assignee":null,"assignees":[],"requested_reviewers":[{"login":"asubiotto","id":10560359,"node_id":"MDQ6VXNlcjEwNTYwMzU5","avatar_url":"https://avatars2.githubusercontent.com/u/10560359?v=4","gravatar_id":"","url":"https://api.github.com/users/asubiotto","html_url":"https://github.com/asubiotto","followers_url":"https://api.github.com/users/asubiotto/followers","following_url":"https://api.github.com/users/asubiotto/following{/other_user}","gists_url":"https://api.github.com/users/asubiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/asubiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubiotto/subscriptions","organizations_url":"https://api.github.com/users/asubiotto/orgs","repos_url":"https://api.github.com/users/asubiotto/repos","events_url":"https://api.github.com/users/asubiotto/events{/privacy}","received_events_url":"https://api.github.com/users/asubiotto/received_events","type":"User","site_admin":false},{"login":"RaduBerinde","id":16544120,"node_id":"MDQ6VXNlcjE2NTQ0MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/16544120?v=4","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"sql-rest-prs","id":2437982,"node_id":"MDQ6VGVhbTI0Mzc5ODI=","slug":"sql-rest-prs","description":"Join this team for notifications about SQL PRs that do not fall in other buckets","privacy":"closed","url":"https://api.github.com/teams/2437982","members_url":"https://api.github.com/teams/2437982/members{/member}","repositories_url":"https://api.github.com/teams/2437982/repos","permission":"pull"},{"name":"sql-execution-prs","id":2437984,"node_id":"MDQ6VGVhbTI0Mzc5ODQ=","slug":"sql-execution-prs","description":"Join this team for notifications about SQL execution PRs","privacy":"closed","url":"https://api.github.com/teams/2437984","members_url":"https://api.github.com/teams/2437984/members{/member}","repositories_url":"https://api.github.com/teams/2437984/repos","permission":"pull"},{"name":"sql-planning-prs","id":2437986,"node_id":"MDQ6VGVhbTI0Mzc5ODY=","slug":"sql-planning-prs","description":"Join this team for notifications about SQL planning PRs","privacy":"closed","url":"https://api.github.com/teams/2437986","members_url":"https://api.github.com/teams/2437986/members{/member}","repositories_url":"https://api.github.com/teams/2437986/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29073/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29073/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/29073/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/7e47ac6ec9c53bed980f789506adbb2a93b2be79","head":{"label":"jordanlewis:fix-lookup-join-close","ref":"fix-lookup-join-close","sha":"7e47ac6ec9c53bed980f789506adbb2a93b2be79","user":{"login":"jordanlewis","id":43821,"node_id":"MDQ6VXNlcjQzODIx","avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"repo":{"id":60553554,"node_id":"MDEwOlJlcG9zaXRvcnk2MDU1MzU1NA==","name":"cockroach","full_name":"jordanlewis/cockroach","owner":{"login":"jordanlewis","id":43821,"node_id":"MDQ6VXNlcjQzODIx","avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jordanlewis/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/jordanlewis/cockroach","forks_url":"https://api.github.com/repos/jordanlewis/cockroach/forks","keys_url":"https://api.github.com/repos/jordanlewis/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jordanlewis/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jordanlewis/cockroach/teams","hooks_url":"https://api.github.com/repos/jordanlewis/cockroach/hooks","issue_events_url":"https://api.github.com/repos/jordanlewis/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/jordanlewis/cockroach/events","assignees_url":"https://api.github.com/repos/jordanlewis/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/jordanlewis/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/jordanlewis/cockroach/tags","blobs_url":"https://api.github.com/repos/jordanlewis/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jordanlewis/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jordanlewis/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/jordanlewis/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jordanlewis/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/jordanlewis/cockroach/languages","stargazers_url":"https://api.github.com/repos/jordanlewis/cockroach/stargazers","contributors_url":"https://api.github.com/repos/jordanlewis/cockroach/contributors","subscribers_url":"https://api.github.com/repos/jordanlewis/cockroach/subscribers","subscription_url":"https://api.github.com/repos/jordanlewis/cockroach/subscription","commits_url":"https://api.github.com/repos/jordanlewis/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/jordanlewis/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/jordanlewis/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/jordanlewis/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/jordanlewis/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/jordanlewis/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jordanlewis/cockroach/merges","archive_url":"https://api.github.com/repos/jordanlewis/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jordanlewis/cockroach/downloads","issues_url":"https://api.github.com/repos/jordanlewis/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/jordanlewis/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/jordanlewis/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/jordanlewis/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jordanlewis/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/jordanlewis/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/jordanlewis/cockroach/deployments","created_at":"2016-06-06T19:04:51Z","updated_at":"2016-06-06T19:04:56Z","pushed_at":"2018-08-26T13:05:38Z","git_url":"git://github.com/jordanlewis/cockroach.git","ssh_url":"git@github.com:jordanlewis/cockroach.git","clone_url":"https://github.com/jordanlewis/cockroach.git","svn_url":"https://github.com/jordanlewis/cockroach","homepage":"https://www.cockroachlabs.com","size":530493,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"9ee43b32c83db6418070f92d9d698c1890d80b9e","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-08-26T00:49:47Z","pushed_at":"2018-08-26T14:33:58Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1044545,"stargazers_count":14127,"watchers_count":14127,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1477,"mirror_url":null,"archived":false,"open_issues_count":1866,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1477,"open_issues":1866,"watchers":14127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29073"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/29073"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/29073"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/29073/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29073/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/29073/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/7e47ac6ec9c53bed980f789506adbb2a93b2be79"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"craig"}}