{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/184440280","pull_request_review_id":115638490,"id":184440280,"diff_hunk":"@@ -3135,6 +3135,72 @@ public void ResxValueNewlines(string newline)\n                 }\n             }\n         }\n+\n+        [Fact]\n+        [PlatformSpecific(TestPlatforms.AnyUnix)]\n+        public void RebuildsInPresenceOfFileRefWithWindowsPath()\n+        {\n+            // This WriteLine is a hack.  On a slow machine, the Tasks unittest fails because remoting\n+            // times out the object used for remoting console writes.  Adding a write in the middle of\n+            // keeps remoting from timing out the object.\n+            Console.WriteLine(\"Performing RebuildsInPresenceOfFileRefWithWindowsPath() test\");","path":"src/Tasks.UnitTests/GenerateResource_Tests.cs","position":12,"original_position":12,"commit_id":"a38218d49e95ef61b56bd61fc122bd7b02ac8327","original_commit_id":"a38218d49e95ef61b56bd61fc122bd7b02ac8327","user":{"login":"radical","id":1472,"avatar_url":"https://avatars0.githubusercontent.com/u/1472?v=4","gravatar_id":"","url":"https://api.github.com/users/radical","html_url":"https://github.com/radical","followers_url":"https://api.github.com/users/radical/followers","following_url":"https://api.github.com/users/radical/following{/other_user}","gists_url":"https://api.github.com/users/radical/gists{/gist_id}","starred_url":"https://api.github.com/users/radical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical/subscriptions","organizations_url":"https://api.github.com/users/radical/orgs","repos_url":"https://api.github.com/users/radical/repos","events_url":"https://api.github.com/users/radical/events{/privacy}","received_events_url":"https://api.github.com/users/radical/received_events","type":"User","site_admin":false},"body":"This part was a dumb copy/paste! I noticed it in most of the tests, and I don't know how to reproduce this. Not that I really tried! I will remove this.","created_at":"2018-04-26T15:51:13Z","updated_at":"2018-04-26T15:51:13Z","html_url":"https://github.com/Microsoft/msbuild/pull/3234#discussion_r184440280","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/184440280"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3234#discussion_r184440280"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234"}},"in_reply_to_id":184416452},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234","id":184185014,"html_url":"https://github.com/Microsoft/msbuild/pull/3234","diff_url":"https://github.com/Microsoft/msbuild/pull/3234.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/3234.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3234","number":3234,"state":"open","locked":false,"title":"[unix] Fix rebuilds caused by resx containing fileref with windows pa…","user":{"login":"radical","id":1472,"avatar_url":"https://avatars0.githubusercontent.com/u/1472?v=4","gravatar_id":"","url":"https://api.github.com/users/radical","html_url":"https://github.com/radical","followers_url":"https://api.github.com/users/radical/followers","following_url":"https://api.github.com/users/radical/following{/other_user}","gists_url":"https://api.github.com/users/radical/gists{/gist_id}","starred_url":"https://api.github.com/users/radical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical/subscriptions","organizations_url":"https://api.github.com/users/radical/orgs","repos_url":"https://api.github.com/users/radical/repos","events_url":"https://api.github.com/users/radical/events{/privacy}","received_events_url":"https://api.github.com/users/radical/received_events","type":"User","site_admin":false},"body":"…th (#44)\r\n\r\nWhen running on !windows, if a resx contains a fileRef like ..\r\n\r\n```\r\n  <data name=\"TextFile1\" type=\"System.Resources.ResXFileRef, System.Windows.Forms\">\r\n\t<value>..\\Resources\\TextFile1.txt;System.String, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089;Windows-1252</value>\r\n  </data>\r\n```\r\n\r\n.. with the path containing backslashes, then we end up treating the whole\r\nthing as filename and thus subsequent checks for file changes etc fail. This\r\ncauses the resx to be processed every time `GenerateResource` task is run, which\r\ncan cause costly rebuilds.\r\n\r\nIssue: https://github.com/mono/mono/issues/7184","created_at":"2018-04-25T22:54:40Z","updated_at":"2018-04-26T15:51:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71bdb0d1ce1e81fe2fb50ce91df217c5bc4f8a08","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars3.githubusercontent.com/u/145043?v=4","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/3234/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/a38218d49e95ef61b56bd61fc122bd7b02ac8327","head":{"label":"radical:fix-resx-rebuild","ref":"fix-resx-rebuild","sha":"a38218d49e95ef61b56bd61fc122bd7b02ac8327","user":{"login":"radical","id":1472,"avatar_url":"https://avatars0.githubusercontent.com/u/1472?v=4","gravatar_id":"","url":"https://api.github.com/users/radical","html_url":"https://github.com/radical","followers_url":"https://api.github.com/users/radical/followers","following_url":"https://api.github.com/users/radical/following{/other_user}","gists_url":"https://api.github.com/users/radical/gists{/gist_id}","starred_url":"https://api.github.com/users/radical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical/subscriptions","organizations_url":"https://api.github.com/users/radical/orgs","repos_url":"https://api.github.com/users/radical/repos","events_url":"https://api.github.com/users/radical/events{/privacy}","received_events_url":"https://api.github.com/users/radical/received_events","type":"User","site_admin":false},"repo":{"id":34790523,"name":"msbuild","full_name":"radical/msbuild","owner":{"login":"radical","id":1472,"avatar_url":"https://avatars0.githubusercontent.com/u/1472?v=4","gravatar_id":"","url":"https://api.github.com/users/radical","html_url":"https://github.com/radical","followers_url":"https://api.github.com/users/radical/followers","following_url":"https://api.github.com/users/radical/following{/other_user}","gists_url":"https://api.github.com/users/radical/gists{/gist_id}","starred_url":"https://api.github.com/users/radical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radical/subscriptions","organizations_url":"https://api.github.com/users/radical/orgs","repos_url":"https://api.github.com/users/radical/repos","events_url":"https://api.github.com/users/radical/events{/privacy}","received_events_url":"https://api.github.com/users/radical/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radical/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/radical/msbuild","forks_url":"https://api.github.com/repos/radical/msbuild/forks","keys_url":"https://api.github.com/repos/radical/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radical/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radical/msbuild/teams","hooks_url":"https://api.github.com/repos/radical/msbuild/hooks","issue_events_url":"https://api.github.com/repos/radical/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/radical/msbuild/events","assignees_url":"https://api.github.com/repos/radical/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/radical/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/radical/msbuild/tags","blobs_url":"https://api.github.com/repos/radical/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radical/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radical/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/radical/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radical/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/radical/msbuild/languages","stargazers_url":"https://api.github.com/repos/radical/msbuild/stargazers","contributors_url":"https://api.github.com/repos/radical/msbuild/contributors","subscribers_url":"https://api.github.com/repos/radical/msbuild/subscribers","subscription_url":"https://api.github.com/repos/radical/msbuild/subscription","commits_url":"https://api.github.com/repos/radical/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/radical/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/radical/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/radical/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/radical/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/radical/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radical/msbuild/merges","archive_url":"https://api.github.com/repos/radical/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radical/msbuild/downloads","issues_url":"https://api.github.com/repos/radical/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/radical/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/radical/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/radical/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radical/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/radical/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/radical/msbuild/deployments","created_at":"2015-04-29T11:40:15Z","updated_at":"2016-04-02T08:23:35Z","pushed_at":"2018-04-25T22:39:46Z","git_url":"git://github.com/radical/msbuild.git","ssh_url":"git@github.com:radical/msbuild.git","clone_url":"https://github.com/radical/msbuild.git","svn_url":"https://github.com/radical/msbuild","homepage":null,"size":48527,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"82b4192dc0eba67d54d7ce18b307625ec45557f4","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2018-04-26T07:12:08Z","pushed_at":"2018-04-26T15:51:10Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":25481,"stargazers_count":3437,"watchers_count":3437,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":771,"mirror_url":null,"archived":false,"open_issues_count":819,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":771,"open_issues":819,"watchers":3437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/3234"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3234"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/3234/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/3234/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/a38218d49e95ef61b56bd61fc122bd7b02ac8327"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"radical"}}