{"action":"created","comment":{"url":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments/205833640","pull_request_review_id":141187022,"id":205833640,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTgzMzY0MA==","diff_hunk":"@@ -26,7 +28,12 @@ export default class MyProfile extends Component {\n         showPerms: PropTypes.bool,\n         showHomeLink: PropTypes.bool,\n       }),\n+      okapi: PropTypes.object,\n     }).isRequired,\n+    modules: PropTypes.shape({\n+      app: PropTypes.array,","path":"src/components/MainNav/MyProfile/MyProfile.js","position":19,"original_position":19,"commit_id":"30fd42f6f08cb8f789fada0fd6a3f57c661498da","original_commit_id":"30fd42f6f08cb8f789fada0fd6a3f57c661498da","user":{"login":"MikeTaylor","id":212761,"node_id":"MDQ6VXNlcjIxMjc2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/212761?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeTaylor","html_url":"https://github.com/MikeTaylor","followers_url":"https://api.github.com/users/MikeTaylor/followers","following_url":"https://api.github.com/users/MikeTaylor/following{/other_user}","gists_url":"https://api.github.com/users/MikeTaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeTaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeTaylor/subscriptions","organizations_url":"https://api.github.com/users/MikeTaylor/orgs","repos_url":"https://api.github.com/users/MikeTaylor/repos","events_url":"https://api.github.com/users/MikeTaylor/events{/privacy}","received_events_url":"https://api.github.com/users/MikeTaylor/received_events","type":"User","site_admin":false},"body":"But ...\r\n\r\nA better question would be _why_ we don't use `props.modules.app`. I think we should be extracting links from modules of type `app` as well as those of type `settings`. That entails a change to line 60, below.","created_at":"2018-07-27T16:44:11Z","updated_at":"2018-07-27T16:44:11Z","html_url":"https://github.com/folio-org/stripes-core/pull/361#discussion_r205833640","pull_request_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/361","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments/205833640"},"html":{"href":"https://github.com/folio-org/stripes-core/pull/361#discussion_r205833640"},"pull_request":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/361"}},"in_reply_to_id":205831707},"pull_request":{"url":"https://api.github.com/repos/folio-org/stripes-core/pulls/361","id":203563916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTYzOTE2","html_url":"https://github.com/folio-org/stripes-core/pull/361","diff_url":"https://github.com/folio-org/stripes-core/pull/361.diff","patch_url":"https://github.com/folio-org/stripes-core/pull/361.patch","issue_url":"https://api.github.com/repos/folio-org/stripes-core/issues/361","number":361,"state":"open","locked":false,"title":"UIU-563 - Access Change my password from Folio Top Toolbar","user":{"login":"natali-zaitseva","id":37537790,"node_id":"MDQ6VXNlcjM3NTM3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/37537790?v=4","gravatar_id":"","url":"https://api.github.com/users/natali-zaitseva","html_url":"https://github.com/natali-zaitseva","followers_url":"https://api.github.com/users/natali-zaitseva/followers","following_url":"https://api.github.com/users/natali-zaitseva/following{/other_user}","gists_url":"https://api.github.com/users/natali-zaitseva/gists{/gist_id}","starred_url":"https://api.github.com/users/natali-zaitseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natali-zaitseva/subscriptions","organizations_url":"https://api.github.com/users/natali-zaitseva/orgs","repos_url":"https://api.github.com/users/natali-zaitseva/repos","events_url":"https://api.github.com/users/natali-zaitseva/events{/privacy}","received_events_url":"https://api.github.com/users/natali-zaitseva/received_events","type":"User","site_admin":false},"body":"* modified user profile pop-up to include \"Change Password\" item\r\n* added function to check user credentials exists in local storage\r\n\r\n### Need to be merged along with https://github.com/folio-org/ui-myprofile/pull/3","created_at":"2018-07-24T15:18:35Z","updated_at":"2018-07-27T16:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f84ec7bf3f466f178686c16fa4bc3a9239d13fd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/361/commits","review_comments_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/361/comments","review_comment_url":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/stripes-core/issues/361/comments","statuses_url":"https://api.github.com/repos/folio-org/stripes-core/statuses/30fd42f6f08cb8f789fada0fd6a3f57c661498da","head":{"label":"natali-zaitseva:UIU-563","ref":"UIU-563","sha":"30fd42f6f08cb8f789fada0fd6a3f57c661498da","user":{"login":"natali-zaitseva","id":37537790,"node_id":"MDQ6VXNlcjM3NTM3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/37537790?v=4","gravatar_id":"","url":"https://api.github.com/users/natali-zaitseva","html_url":"https://github.com/natali-zaitseva","followers_url":"https://api.github.com/users/natali-zaitseva/followers","following_url":"https://api.github.com/users/natali-zaitseva/following{/other_user}","gists_url":"https://api.github.com/users/natali-zaitseva/gists{/gist_id}","starred_url":"https://api.github.com/users/natali-zaitseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natali-zaitseva/subscriptions","organizations_url":"https://api.github.com/users/natali-zaitseva/orgs","repos_url":"https://api.github.com/users/natali-zaitseva/repos","events_url":"https://api.github.com/users/natali-zaitseva/events{/privacy}","received_events_url":"https://api.github.com/users/natali-zaitseva/received_events","type":"User","site_admin":false},"repo":{"id":142167315,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxNjczMTU=","name":"stripes-core","full_name":"natali-zaitseva/stripes-core","owner":{"login":"natali-zaitseva","id":37537790,"node_id":"MDQ6VXNlcjM3NTM3Nzkw","avatar_url":"https://avatars1.githubusercontent.com/u/37537790?v=4","gravatar_id":"","url":"https://api.github.com/users/natali-zaitseva","html_url":"https://github.com/natali-zaitseva","followers_url":"https://api.github.com/users/natali-zaitseva/followers","following_url":"https://api.github.com/users/natali-zaitseva/following{/other_user}","gists_url":"https://api.github.com/users/natali-zaitseva/gists{/gist_id}","starred_url":"https://api.github.com/users/natali-zaitseva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natali-zaitseva/subscriptions","organizations_url":"https://api.github.com/users/natali-zaitseva/orgs","repos_url":"https://api.github.com/users/natali-zaitseva/repos","events_url":"https://api.github.com/users/natali-zaitseva/events{/privacy}","received_events_url":"https://api.github.com/users/natali-zaitseva/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natali-zaitseva/stripes-core","description":"The core of Stripes, an opinionated and modular platform for React components consuming REST data and the UI framework for the FOLIO project","fork":true,"url":"https://api.github.com/repos/natali-zaitseva/stripes-core","forks_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/forks","keys_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/teams","hooks_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/hooks","issue_events_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/issues/events{/number}","events_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/events","assignees_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/assignees{/user}","branches_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/branches{/branch}","tags_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/tags","blobs_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/statuses/{sha}","languages_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/languages","stargazers_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/stargazers","contributors_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/contributors","subscribers_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/subscribers","subscription_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/subscription","commits_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/contents/{+path}","compare_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/merges","archive_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/downloads","issues_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/issues{/number}","pulls_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/pulls{/number}","milestones_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/milestones{/number}","notifications_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/labels{/name}","releases_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/releases{/id}","deployments_url":"https://api.github.com/repos/natali-zaitseva/stripes-core/deployments","created_at":"2018-07-24T14:07:25Z","updated_at":"2018-07-24T14:07:27Z","pushed_at":"2018-07-27T15:15:08Z","git_url":"git://github.com/natali-zaitseva/stripes-core.git","ssh_url":"git@github.com:natali-zaitseva/stripes-core.git","clone_url":"https://github.com/natali-zaitseva/stripes-core.git","svn_url":"https://github.com/natali-zaitseva/stripes-core","homepage":null,"size":2048,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"3d303912dd5f69b1b3e2b16d87a190c3309b2cf3","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":71846636,"node_id":"MDEwOlJlcG9zaXRvcnk3MTg0NjYzNg==","name":"stripes-core","full_name":"folio-org/stripes-core","owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/folio-org/stripes-core","description":"The core of Stripes, an opinionated and modular platform for React components consuming REST data and the UI framework for the FOLIO project","fork":false,"url":"https://api.github.com/repos/folio-org/stripes-core","forks_url":"https://api.github.com/repos/folio-org/stripes-core/forks","keys_url":"https://api.github.com/repos/folio-org/stripes-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/stripes-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/stripes-core/teams","hooks_url":"https://api.github.com/repos/folio-org/stripes-core/hooks","issue_events_url":"https://api.github.com/repos/folio-org/stripes-core/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/stripes-core/events","assignees_url":"https://api.github.com/repos/folio-org/stripes-core/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/stripes-core/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/stripes-core/tags","blobs_url":"https://api.github.com/repos/folio-org/stripes-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/stripes-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/stripes-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/stripes-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/stripes-core/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/stripes-core/languages","stargazers_url":"https://api.github.com/repos/folio-org/stripes-core/stargazers","contributors_url":"https://api.github.com/repos/folio-org/stripes-core/contributors","subscribers_url":"https://api.github.com/repos/folio-org/stripes-core/subscribers","subscription_url":"https://api.github.com/repos/folio-org/stripes-core/subscription","commits_url":"https://api.github.com/repos/folio-org/stripes-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/stripes-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/stripes-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/stripes-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/stripes-core/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/stripes-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/stripes-core/merges","archive_url":"https://api.github.com/repos/folio-org/stripes-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/stripes-core/downloads","issues_url":"https://api.github.com/repos/folio-org/stripes-core/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/stripes-core/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/stripes-core/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/stripes-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/stripes-core/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/stripes-core/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/stripes-core/deployments","created_at":"2016-10-25T01:15:59Z","updated_at":"2018-07-20T15:14:42Z","pushed_at":"2018-07-27T15:15:09Z","git_url":"git://github.com/folio-org/stripes-core.git","ssh_url":"git@github.com:folio-org/stripes-core.git","clone_url":"https://github.com/folio-org/stripes-core.git","svn_url":"https://github.com/folio-org/stripes-core","homepage":null,"size":2046,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/361"},"html":{"href":"https://github.com/folio-org/stripes-core/pull/361"},"issue":{"href":"https://api.github.com/repos/folio-org/stripes-core/issues/361"},"comments":{"href":"https://api.github.com/repos/folio-org/stripes-core/issues/361/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/361/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/stripes-core/pulls/361/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/stripes-core/statuses/30fd42f6f08cb8f789fada0fd6a3f57c661498da"}},"author_association":"NONE"}}
{"actor":{"display_login":"MikeTaylor"}}