{"action":"created","comment":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/167410972","pull_request_review_id":95633321,"id":167410972,"diff_hunk":"@@ -9,8 +10,8 @@\n            \"container_slug\": $(e.target).data(\"container-slug\"),\n            \"parent_container_slug\": $(e.target).data(\"parent-container-slug\") || \"\"\n        }, success: function () {\n-           $(e.target).attr(\"data-is-ready\", readiness?\"false\":\"true\")\n-               .text($(e.target).data(\"is-ready-\" + !readiness));\n+           var text = $(e.target).data(\"is-ready-\" + !readiness);\n+           $(e.target).data(\"is-ready\", Sting(readiness)).text(text);","path":"assets/js/content-publication-readiness.js","position":null,"original_position":15,"commit_id":"fe568a414cc0d4d5f0ea666a2a72b965683c7176","original_commit_id":"fe568a414cc0d4d5f0ea666a2a72b965683c7176","user":{"login":"vhf","id":2022803,"avatar_url":"https://avatars2.githubusercontent.com/u/2022803?v=4","gravatar_id":"","url":"https://api.github.com/users/vhf","html_url":"https://github.com/vhf","followers_url":"https://api.github.com/users/vhf/followers","following_url":"https://api.github.com/users/vhf/following{/other_user}","gists_url":"https://api.github.com/users/vhf/gists{/gist_id}","starred_url":"https://api.github.com/users/vhf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhf/subscriptions","organizations_url":"https://api.github.com/users/vhf/orgs","repos_url":"https://api.github.com/users/vhf/repos","events_url":"https://api.github.com/users/vhf/events{/privacy}","received_events_url":"https://api.github.com/users/vhf/received_events","type":"User","site_admin":false},"body":"Tu as soit oublié d'inverser `readiness` et d'enlever le `!` à la l.13, soit oublié de mettre `!` ici.\r\n\r\nJe crois pas que `String` (faut de frappe ici, tu as mis `Sting`) soit nécessaire. L.5 tu fais déjà `.toString()`.","created_at":"2018-02-10T21:01:50Z","updated_at":"2018-02-10T21:01:51Z","html_url":"https://github.com/zestedesavoir/zds-site/pull/4678#discussion_r167410972","pull_request_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments/167410972"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/4678#discussion_r167410972"},"pull_request":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678"}}},"pull_request":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678","id":143871139,"html_url":"https://github.com/zestedesavoir/zds-site/pull/4678","diff_url":"https://github.com/zestedesavoir/zds-site/pull/4678.diff","patch_url":"https://github.com/zestedesavoir/zds-site/pull/4678.patch","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4678","number":4678,"state":"open","locked":false,"title":"Publication partielle","user":{"login":"artragis","id":1523653,"avatar_url":"https://avatars3.githubusercontent.com/u/1523653?v=4","gravatar_id":"","url":"https://api.github.com/users/artragis","html_url":"https://github.com/artragis","followers_url":"https://api.github.com/users/artragis/followers","following_url":"https://api.github.com/users/artragis/following{/other_user}","gists_url":"https://api.github.com/users/artragis/gists{/gist_id}","starred_url":"https://api.github.com/users/artragis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artragis/subscriptions","organizations_url":"https://api.github.com/users/artragis/orgs","repos_url":"https://api.github.com/users/artragis/repos","events_url":"https://api.github.com/users/artragis/events{/privacy}","received_events_url":"https://api.github.com/users/artragis/received_events","type":"User","site_admin":false},"body":"fix #1334\r\n\r\nJ'y ajoute un léger refactoring car les utilitaires de publication sont trop longs et chargés.\r\n\r\nCela modifie la version du manifest. Je passe en 2.1 au lieu de 2.0 car ça fait longtemps qu'on n'a pas fait de chagement \r\nà ce propos alors que c'est nécessaire.\r\n\r\n# QA\r\n\r\nLorsque j'aurai développé la vue + le formulaire associé :\r\n\r\n- publier un tuto comme avant, vérifiez que le comportement n'a pas changé\r\n- importer un tuto avec au moins deux chapitres, mais dans le manifeste, mettez `\"ready_to_publish\": false` sur un des deux\r\n- faites valider puis publiez le tuto, vérifiez que seul le chapitre non marqué est apparant\r\n","created_at":"2017-09-29T12:01:43Z","updated_at":"2018-02-10T21:01:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"908b3e55ce02b7736266204ae4e923330466ff64","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678/commits","review_comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678/comments","review_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4678/comments","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/fe568a414cc0d4d5f0ea666a2a72b965683c7176","head":{"label":"artragis:implement_partial_publication","ref":"implement_partial_publication","sha":"fe568a414cc0d4d5f0ea666a2a72b965683c7176","user":{"login":"artragis","id":1523653,"avatar_url":"https://avatars3.githubusercontent.com/u/1523653?v=4","gravatar_id":"","url":"https://api.github.com/users/artragis","html_url":"https://github.com/artragis","followers_url":"https://api.github.com/users/artragis/followers","following_url":"https://api.github.com/users/artragis/following{/other_user}","gists_url":"https://api.github.com/users/artragis/gists{/gist_id}","starred_url":"https://api.github.com/users/artragis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artragis/subscriptions","organizations_url":"https://api.github.com/users/artragis/orgs","repos_url":"https://api.github.com/users/artragis/repos","events_url":"https://api.github.com/users/artragis/events{/privacy}","received_events_url":"https://api.github.com/users/artragis/received_events","type":"User","site_admin":false},"repo":{"id":20302770,"name":"zds-site","full_name":"artragis/zds-site","owner":{"login":"artragis","id":1523653,"avatar_url":"https://avatars3.githubusercontent.com/u/1523653?v=4","gravatar_id":"","url":"https://api.github.com/users/artragis","html_url":"https://github.com/artragis","followers_url":"https://api.github.com/users/artragis/followers","following_url":"https://api.github.com/users/artragis/following{/other_user}","gists_url":"https://api.github.com/users/artragis/gists{/gist_id}","starred_url":"https://api.github.com/users/artragis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artragis/subscriptions","organizations_url":"https://api.github.com/users/artragis/orgs","repos_url":"https://api.github.com/users/artragis/repos","events_url":"https://api.github.com/users/artragis/events{/privacy}","received_events_url":"https://api.github.com/users/artragis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artragis/zds-site","description":"Dépot ZDS","fork":true,"url":"https://api.github.com/repos/artragis/zds-site","forks_url":"https://api.github.com/repos/artragis/zds-site/forks","keys_url":"https://api.github.com/repos/artragis/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artragis/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artragis/zds-site/teams","hooks_url":"https://api.github.com/repos/artragis/zds-site/hooks","issue_events_url":"https://api.github.com/repos/artragis/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/artragis/zds-site/events","assignees_url":"https://api.github.com/repos/artragis/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/artragis/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/artragis/zds-site/tags","blobs_url":"https://api.github.com/repos/artragis/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artragis/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artragis/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/artragis/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artragis/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/artragis/zds-site/languages","stargazers_url":"https://api.github.com/repos/artragis/zds-site/stargazers","contributors_url":"https://api.github.com/repos/artragis/zds-site/contributors","subscribers_url":"https://api.github.com/repos/artragis/zds-site/subscribers","subscription_url":"https://api.github.com/repos/artragis/zds-site/subscription","commits_url":"https://api.github.com/repos/artragis/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/artragis/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/artragis/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/artragis/zds-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/artragis/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/artragis/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artragis/zds-site/merges","archive_url":"https://api.github.com/repos/artragis/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artragis/zds-site/downloads","issues_url":"https://api.github.com/repos/artragis/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/artragis/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/artragis/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/artragis/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artragis/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/artragis/zds-site/releases{/id}","deployments_url":"https://api.github.com/repos/artragis/zds-site/deployments","created_at":"2014-05-29T17:51:23Z","updated_at":"2017-02-04T10:15:47Z","pushed_at":"2018-02-10T17:33:37Z","git_url":"git://github.com/artragis/zds-site.git","ssh_url":"git@github.com:artragis/zds-site.git","clone_url":"https://github.com/artragis/zds-site.git","svn_url":"https://github.com/artragis/zds-site","homepage":null,"size":103671,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":5,"watchers":0,"default_branch":"dev"}},"base":{"label":"zestedesavoir:dev","ref":"dev","sha":"5eebddc22e86a8521076dbac8e64ed5e8b7c88e4","user":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars3.githubusercontent.com/u/7406239?v=4","gravatar_id":"","url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"repo":{"id":14778920,"name":"zds-site","full_name":"zestedesavoir/zds-site","owner":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars3.githubusercontent.com/u/7406239?v=4","gravatar_id":"","url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zestedesavoir/zds-site","description":"Dépôt de Zeste de Savoir","fork":false,"url":"https://api.github.com/repos/zestedesavoir/zds-site","forks_url":"https://api.github.com/repos/zestedesavoir/zds-site/forks","keys_url":"https://api.github.com/repos/zestedesavoir/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zestedesavoir/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zestedesavoir/zds-site/teams","hooks_url":"https://api.github.com/repos/zestedesavoir/zds-site/hooks","issue_events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/events","assignees_url":"https://api.github.com/repos/zestedesavoir/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/zestedesavoir/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/tags","blobs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/zestedesavoir/zds-site/languages","stargazers_url":"https://api.github.com/repos/zestedesavoir/zds-site/stargazers","contributors_url":"https://api.github.com/repos/zestedesavoir/zds-site/contributors","subscribers_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscribers","subscription_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscription","commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/zestedesavoir/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/zestedesavoir/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zestedesavoir/zds-site/merges","archive_url":"https://api.github.com/repos/zestedesavoir/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zestedesavoir/zds-site/downloads","issues_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/zestedesavoir/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/zestedesavoir/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/zestedesavoir/zds-site/releases{/id}","deployments_url":"https://api.github.com/repos/zestedesavoir/zds-site/deployments","created_at":"2013-11-28T14:23:48Z","updated_at":"2018-02-07T18:42:21Z","pushed_at":"2018-02-10T17:33:37Z","git_url":"git://github.com/zestedesavoir/zds-site.git","ssh_url":"git@github.com:zestedesavoir/zds-site.git","clone_url":"https://github.com/zestedesavoir/zds-site.git","svn_url":"https://github.com/zestedesavoir/zds-site","homepage":"https://zestedesavoir.com","size":112578,"stargazers_count":209,"watchers_count":209,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":235,"license":null,"forks":146,"open_issues":235,"watchers":209,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/4678"},"issue":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4678"},"comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4678/comments"},"review_comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678/comments"},"review_comment":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4678/commits"},"statuses":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/fe568a414cc0d4d5f0ea666a2a72b965683c7176"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vhf"}}