{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/178833185","pull_request_review_id":108957703,"id":178833185,"diff_hunk":"@@ -239,11 +258,8 @@ def simulate_raw(raw, stc, trans, src, bem, cov='simple',\n     src = _ensure_src(src, verbose=False)\n     if isinstance(bem, string_types):\n         bem = read_bem_solution(bem, verbose=False)\n-    if isinstance(cov, string_types):\n-        if cov == 'simple':\n-            cov = make_ad_hoc_cov(info, verbose=False)\n-        else:\n-            cov = read_cov(cov, verbose=False)\n+    if cov is not None:\n+        cov = _check_cov(info, cov)","path":"mne/simulation/raw.py","position":62,"original_position":62,"commit_id":"272121e7e8157ec150719887043eeddc12703319","original_commit_id":"272121e7e8157ec150719887043eeddc12703319","user":{"login":"larsoner","id":2365790,"avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"body":"don't nest this, instead handle the `if cov is None` case in `_check_cov` (keeps all checking logic in one place)","created_at":"2018-04-03T13:58:38Z","updated_at":"2018-04-03T14:00:33Z","html_url":"https://github.com/mne-tools/mne-python/pull/5065#discussion_r178833185","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/178833185"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5065#discussion_r178833185"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065","id":178582125,"html_url":"https://github.com/mne-tools/mne-python/pull/5065","diff_url":"https://github.com/mne-tools/mne-python/pull/5065.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/5065.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5065","number":5065,"state":"open","locked":false,"title":"Modify make_ad_hoc_cov to accept dict as input","user":{"login":"ngayraud","id":18072563,"avatar_url":"https://avatars0.githubusercontent.com/u/18072563?v=4","gravatar_id":"","url":"https://api.github.com/users/ngayraud","html_url":"https://github.com/ngayraud","followers_url":"https://api.github.com/users/ngayraud/followers","following_url":"https://api.github.com/users/ngayraud/following{/other_user}","gists_url":"https://api.github.com/users/ngayraud/gists{/gist_id}","starred_url":"https://api.github.com/users/ngayraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngayraud/subscriptions","organizations_url":"https://api.github.com/users/ngayraud/orgs","repos_url":"https://api.github.com/users/ngayraud/repos","events_url":"https://api.github.com/users/ngayraud/events{/privacy}","received_events_url":"https://api.github.com/users/ngayraud/received_events","type":"User","site_admin":false},"body":"Modified `make_ad_hoc_cov` so that it accepts a dictionary of standard deviations as input.\r\n\r\nRelated to issue #5058 ","created_at":"2018-03-30T15:34:15Z","updated_at":"2018-04-03T14:00:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd001082d30529ca7cad9abccec52e17d655496e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5065/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/272121e7e8157ec150719887043eeddc12703319","head":{"label":"ngayraud:modify-make-adhoc-cov","ref":"modify-make-adhoc-cov","sha":"272121e7e8157ec150719887043eeddc12703319","user":{"login":"ngayraud","id":18072563,"avatar_url":"https://avatars0.githubusercontent.com/u/18072563?v=4","gravatar_id":"","url":"https://api.github.com/users/ngayraud","html_url":"https://github.com/ngayraud","followers_url":"https://api.github.com/users/ngayraud/followers","following_url":"https://api.github.com/users/ngayraud/following{/other_user}","gists_url":"https://api.github.com/users/ngayraud/gists{/gist_id}","starred_url":"https://api.github.com/users/ngayraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngayraud/subscriptions","organizations_url":"https://api.github.com/users/ngayraud/orgs","repos_url":"https://api.github.com/users/ngayraud/repos","events_url":"https://api.github.com/users/ngayraud/events{/privacy}","received_events_url":"https://api.github.com/users/ngayraud/received_events","type":"User","site_admin":false},"repo":{"id":120645128,"name":"mne-python","full_name":"ngayraud/mne-python","owner":{"login":"ngayraud","id":18072563,"avatar_url":"https://avatars0.githubusercontent.com/u/18072563?v=4","gravatar_id":"","url":"https://api.github.com/users/ngayraud","html_url":"https://github.com/ngayraud","followers_url":"https://api.github.com/users/ngayraud/followers","following_url":"https://api.github.com/users/ngayraud/following{/other_user}","gists_url":"https://api.github.com/users/ngayraud/gists{/gist_id}","starred_url":"https://api.github.com/users/ngayraud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngayraud/subscriptions","organizations_url":"https://api.github.com/users/ngayraud/orgs","repos_url":"https://api.github.com/users/ngayraud/repos","events_url":"https://api.github.com/users/ngayraud/events{/privacy}","received_events_url":"https://api.github.com/users/ngayraud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ngayraud/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/ngayraud/mne-python","forks_url":"https://api.github.com/repos/ngayraud/mne-python/forks","keys_url":"https://api.github.com/repos/ngayraud/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngayraud/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngayraud/mne-python/teams","hooks_url":"https://api.github.com/repos/ngayraud/mne-python/hooks","issue_events_url":"https://api.github.com/repos/ngayraud/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/ngayraud/mne-python/events","assignees_url":"https://api.github.com/repos/ngayraud/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/ngayraud/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/ngayraud/mne-python/tags","blobs_url":"https://api.github.com/repos/ngayraud/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngayraud/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngayraud/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngayraud/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngayraud/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ngayraud/mne-python/languages","stargazers_url":"https://api.github.com/repos/ngayraud/mne-python/stargazers","contributors_url":"https://api.github.com/repos/ngayraud/mne-python/contributors","subscribers_url":"https://api.github.com/repos/ngayraud/mne-python/subscribers","subscription_url":"https://api.github.com/repos/ngayraud/mne-python/subscription","commits_url":"https://api.github.com/repos/ngayraud/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngayraud/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngayraud/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngayraud/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngayraud/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/ngayraud/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngayraud/mne-python/merges","archive_url":"https://api.github.com/repos/ngayraud/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngayraud/mne-python/downloads","issues_url":"https://api.github.com/repos/ngayraud/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/ngayraud/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ngayraud/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ngayraud/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngayraud/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/ngayraud/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/ngayraud/mne-python/deployments","created_at":"2018-02-07T17:05:02Z","updated_at":"2018-03-30T14:34:35Z","pushed_at":"2018-04-03T12:14:18Z","git_url":"git://github.com/ngayraud/mne-python.git","ssh_url":"git@github.com:ngayraud/mne-python.git","clone_url":"https://github.com/ngayraud/mne-python.git","svn_url":"https://github.com/ngayraud/mne-python","homepage":"http://martinos.org/mne/","size":98866,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"cdffbc0f437f185bd7fbb59a53f70e29419a500b","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2018-04-03T13:19:05Z","pushed_at":"2018-04-03T13:35:23Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":98985,"stargazers_count":432,"watchers_count":432,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":386,"mirror_url":null,"archived":false,"open_issues_count":269,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":386,"open_issues":269,"watchers":432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5065"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5065"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5065/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5065/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/272121e7e8157ec150719887043eeddc12703319"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"larsoner"}}