{"action":"created","comment":{"url":"https://api.github.com/repos/kittinunf/Fuel/pulls/comments/221448956","pull_request_review_id":160103748,"id":221448956,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQ0ODk1Ng==","diff_hunk":"@@ -10,7 +9,7 @@ import org.junit.Assert.*\n import org.junit.Before\n import org.junit.Test\n import java.net.HttpURLConnection\n-import java.util.UUID\n+import java.util.*","path":"fuel-coroutines/src/test/kotlin/com/github/kittinunf/fuel/coroutines/CoroutinesTest.kt","position":10,"original_position":10,"commit_id":"ecb15e29e4c01e09233f742ffa9729f51f586d00","original_commit_id":"ecb15e29e4c01e09233f742ffa9729f51f586d00","user":{"login":"kittinunf","id":4669517,"node_id":"MDQ6VXNlcjQ2Njk1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4669517?v=4","gravatar_id":"","url":"https://api.github.com/users/kittinunf","html_url":"https://github.com/kittinunf","followers_url":"https://api.github.com/users/kittinunf/followers","following_url":"https://api.github.com/users/kittinunf/following{/other_user}","gists_url":"https://api.github.com/users/kittinunf/gists{/gist_id}","starred_url":"https://api.github.com/users/kittinunf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittinunf/subscriptions","organizations_url":"https://api.github.com/users/kittinunf/orgs","repos_url":"https://api.github.com/users/kittinunf/repos","events_url":"https://api.github.com/users/kittinunf/events{/privacy}","received_events_url":"https://api.github.com/users/kittinunf/received_events","type":"User","site_admin":false},"body":"👮 ","created_at":"2018-09-30T06:28:30Z","updated_at":"2018-09-30T06:28:31Z","html_url":"https://github.com/kittinunf/Fuel/pull/438#discussion_r221448956","pull_request_url":"https://api.github.com/repos/kittinunf/Fuel/pulls/438","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kittinunf/Fuel/pulls/comments/221448956"},"html":{"href":"https://github.com/kittinunf/Fuel/pull/438#discussion_r221448956"},"pull_request":{"href":"https://api.github.com/repos/kittinunf/Fuel/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/kittinunf/Fuel/pulls/438","id":217275763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Mjc1NzYz","html_url":"https://github.com/kittinunf/Fuel/pull/438","diff_url":"https://github.com/kittinunf/Fuel/pull/438.diff","patch_url":"https://github.com/kittinunf/Fuel/pull/438.patch","issue_url":"https://api.github.com/repos/kittinunf/Fuel/issues/438","number":438,"state":"open","locked":false,"title":"Add suspending implenetation client","user":{"login":"markGilchrist","id":39841863,"node_id":"MDQ6VXNlcjM5ODQxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/39841863?v=4","gravatar_id":"","url":"https://api.github.com/users/markGilchrist","html_url":"https://github.com/markGilchrist","followers_url":"https://api.github.com/users/markGilchrist/followers","following_url":"https://api.github.com/users/markGilchrist/following{/other_user}","gists_url":"https://api.github.com/users/markGilchrist/gists{/gist_id}","starred_url":"https://api.github.com/users/markGilchrist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markGilchrist/subscriptions","organizations_url":"https://api.github.com/users/markGilchrist/orgs","repos_url":"https://api.github.com/users/markGilchrist/repos","events_url":"https://api.github.com/users/markGilchrist/events{/privacy}","received_events_url":"https://api.github.com/users/markGilchrist/received_events","type":"User","site_admin":false},"body":"Thank you for submitting your Pull Request. Please make sure you have\r\nfamiliarised yourself with the [Contributing Guidelines](https://github.com/kittunf/Fuel/CONTRIBUTING.md)\r\nbefore continuing.\r\n\r\n## Description\r\n\r\nIn this pr I am hoping to create a suspending implementation of the httpClient so that, should a user so wish they could avoid using threads. \r\n\r\nFixes #431 \r\n\r\nCheck all that apply\r\n\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Refactoring (change which changes the current internal or external interface)\r\n- [ ] This change requires a documentation update\r\n\r\n## How Has This Been Tested?\r\n\r\nIn case you did not include tests describe why you and how you have verified the\r\nchanges, with instructions so we can reproduce. If you have added comprehensive\r\ntests for your changes, you may ommit this section.\r\n\r\n## Checklist:\r\n\r\n- [x] I have performed a self-review of my own code\r\n- [ ] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] I have made corresponding changes to the documentation, if necessary\r\n- [ ] My changes generate no new compiler warnings\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] New and existing unit tests pass locally with my changes\r\n","created_at":"2018-09-21T12:58:39Z","updated_at":"2018-09-30T06:28:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b126dfa2dbe9dc32e41ab8031c7f5171d680f7fc","assignee":{"login":"markGilchrist","id":39841863,"node_id":"MDQ6VXNlcjM5ODQxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/39841863?v=4","gravatar_id":"","url":"https://api.github.com/users/markGilchrist","html_url":"https://github.com/markGilchrist","followers_url":"https://api.github.com/users/markGilchrist/followers","following_url":"https://api.github.com/users/markGilchrist/following{/other_user}","gists_url":"https://api.github.com/users/markGilchrist/gists{/gist_id}","starred_url":"https://api.github.com/users/markGilchrist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markGilchrist/subscriptions","organizations_url":"https://api.github.com/users/markGilchrist/orgs","repos_url":"https://api.github.com/users/markGilchrist/repos","events_url":"https://api.github.com/users/markGilchrist/events{/privacy}","received_events_url":"https://api.github.com/users/markGilchrist/received_events","type":"User","site_admin":false},"assignees":[{"login":"markGilchrist","id":39841863,"node_id":"MDQ6VXNlcjM5ODQxODYz","avatar_url":"https://avatars1.githubusercontent.com/u/39841863?v=4","gravatar_id":"","url":"https://api.github.com/users/markGilchrist","html_url":"https://github.com/markGilchrist","followers_url":"https://api.github.com/users/markGilchrist/followers","following_url":"https://api.github.com/users/markGilchrist/following{/other_user}","gists_url":"https://api.github.com/users/markGilchrist/gists{/gist_id}","starred_url":"https://api.github.com/users/markGilchrist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markGilchrist/subscriptions","organizations_url":"https://api.github.com/users/markGilchrist/orgs","repos_url":"https://api.github.com/users/markGilchrist/repos","events_url":"https://api.github.com/users/markGilchrist/events{/privacy}","received_events_url":"https://api.github.com/users/markGilchrist/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"SleeplessByte","id":1964376,"node_id":"MDQ6VXNlcjE5NjQzNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1964376?v=4","gravatar_id":"","url":"https://api.github.com/users/SleeplessByte","html_url":"https://github.com/SleeplessByte","followers_url":"https://api.github.com/users/SleeplessByte/followers","following_url":"https://api.github.com/users/SleeplessByte/following{/other_user}","gists_url":"https://api.github.com/users/SleeplessByte/gists{/gist_id}","starred_url":"https://api.github.com/users/SleeplessByte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SleeplessByte/subscriptions","organizations_url":"https://api.github.com/users/SleeplessByte/orgs","repos_url":"https://api.github.com/users/SleeplessByte/repos","events_url":"https://api.github.com/users/SleeplessByte/events{/privacy}","received_events_url":"https://api.github.com/users/SleeplessByte/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":220273332,"node_id":"MDU6TGFiZWwyMjAyNzMzMzI=","url":"https://api.github.com/repos/kittinunf/Fuel/labels/:bug:%20bug","name":":bug: bug","color":"d73a4a","default":false},{"id":1067157378,"node_id":"MDU6TGFiZWwxMDY3MTU3Mzc4","url":"https://api.github.com/repos/kittinunf/Fuel/labels/:exclamation:%20do%20not%20merge","name":":exclamation: do not merge","color":"a9dde8","default":false},{"id":1031707178,"node_id":"MDU6TGFiZWwxMDMxNzA3MTc4","url":"https://api.github.com/repos/kittinunf/Fuel/labels/:warning:%20work%20in%20progress","name":":warning: work in progress","color":"f9c720","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kittinunf/Fuel/pulls/438/commits","review_comments_url":"https://api.github.com/repos/kittinunf/Fuel/pulls/438/comments","review_comment_url":"https://api.github.com/repos/kittinunf/Fuel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kittinunf/Fuel/issues/438/comments","statuses_url":"https://api.github.com/repos/kittinunf/Fuel/statuses/ecb15e29e4c01e09233f742ffa9729f51f586d00","head":{"label":"kittinunf:Add_suspending_implenetation_client","ref":"Add_suspending_implenetation_client","sha":"ecb15e29e4c01e09233f742ffa9729f51f586d00","user":{"login":"kittinunf","id":4669517,"node_id":"MDQ6VXNlcjQ2Njk1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4669517?v=4","gravatar_id":"","url":"https://api.github.com/users/kittinunf","html_url":"https://github.com/kittinunf","followers_url":"https://api.github.com/users/kittinunf/followers","following_url":"https://api.github.com/users/kittinunf/following{/other_user}","gists_url":"https://api.github.com/users/kittinunf/gists{/gist_id}","starred_url":"https://api.github.com/users/kittinunf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittinunf/subscriptions","organizations_url":"https://api.github.com/users/kittinunf/orgs","repos_url":"https://api.github.com/users/kittinunf/repos","events_url":"https://api.github.com/users/kittinunf/events{/privacy}","received_events_url":"https://api.github.com/users/kittinunf/received_events","type":"User","site_admin":false},"repo":{"id":36847034,"node_id":"MDEwOlJlcG9zaXRvcnkzNjg0NzAzNA==","name":"Fuel","full_name":"kittinunf/Fuel","private":false,"owner":{"login":"kittinunf","id":4669517,"node_id":"MDQ6VXNlcjQ2Njk1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4669517?v=4","gravatar_id":"","url":"https://api.github.com/users/kittinunf","html_url":"https://github.com/kittinunf","followers_url":"https://api.github.com/users/kittinunf/followers","following_url":"https://api.github.com/users/kittinunf/following{/other_user}","gists_url":"https://api.github.com/users/kittinunf/gists{/gist_id}","starred_url":"https://api.github.com/users/kittinunf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittinunf/subscriptions","organizations_url":"https://api.github.com/users/kittinunf/orgs","repos_url":"https://api.github.com/users/kittinunf/repos","events_url":"https://api.github.com/users/kittinunf/events{/privacy}","received_events_url":"https://api.github.com/users/kittinunf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kittinunf/Fuel","description":"The easiest HTTP networking library for Kotlin/Android","fork":false,"url":"https://api.github.com/repos/kittinunf/Fuel","forks_url":"https://api.github.com/repos/kittinunf/Fuel/forks","keys_url":"https://api.github.com/repos/kittinunf/Fuel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kittinunf/Fuel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kittinunf/Fuel/teams","hooks_url":"https://api.github.com/repos/kittinunf/Fuel/hooks","issue_events_url":"https://api.github.com/repos/kittinunf/Fuel/issues/events{/number}","events_url":"https://api.github.com/repos/kittinunf/Fuel/events","assignees_url":"https://api.github.com/repos/kittinunf/Fuel/assignees{/user}","branches_url":"https://api.github.com/repos/kittinunf/Fuel/branches{/branch}","tags_url":"https://api.github.com/repos/kittinunf/Fuel/tags","blobs_url":"https://api.github.com/repos/kittinunf/Fuel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kittinunf/Fuel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kittinunf/Fuel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kittinunf/Fuel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kittinunf/Fuel/statuses/{sha}","languages_url":"https://api.github.com/repos/kittinunf/Fuel/languages","stargazers_url":"https://api.github.com/repos/kittinunf/Fuel/stargazers","contributors_url":"https://api.github.com/repos/kittinunf/Fuel/contributors","subscribers_url":"https://api.github.com/repos/kittinunf/Fuel/subscribers","subscription_url":"https://api.github.com/repos/kittinunf/Fuel/subscription","commits_url":"https://api.github.com/repos/kittinunf/Fuel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kittinunf/Fuel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kittinunf/Fuel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kittinunf/Fuel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kittinunf/Fuel/contents/{+path}","compare_url":"https://api.github.com/repos/kittinunf/Fuel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kittinunf/Fuel/merges","archive_url":"https://api.github.com/repos/kittinunf/Fuel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kittinunf/Fuel/downloads","issues_url":"https://api.github.com/repos/kittinunf/Fuel/issues{/number}","pulls_url":"https://api.github.com/repos/kittinunf/Fuel/pulls{/number}","milestones_url":"https://api.github.com/repos/kittinunf/Fuel/milestones{/number}","notifications_url":"https://api.github.com/repos/kittinunf/Fuel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kittinunf/Fuel/labels{/name}","releases_url":"https://api.github.com/repos/kittinunf/Fuel/releases{/id}","deployments_url":"https://api.github.com/repos/kittinunf/Fuel/deployments","created_at":"2015-06-04T04:03:33Z","updated_at":"2018-09-29T00:14:40Z","pushed_at":"2018-09-30T03:02:29Z","git_url":"git://github.com/kittinunf/Fuel.git","ssh_url":"git@github.com:kittinunf/Fuel.git","clone_url":"https://github.com/kittinunf/Fuel.git","svn_url":"https://github.com/kittinunf/Fuel","homepage":"","size":1297,"stargazers_count":2152,"watchers_count":2152,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":217,"open_issues":41,"watchers":2152,"default_branch":"master"}},"base":{"label":"kittinunf:master","ref":"master","sha":"4fcc0c7493e99e510b69afd25219df22903566de","user":{"login":"kittinunf","id":4669517,"node_id":"MDQ6VXNlcjQ2Njk1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4669517?v=4","gravatar_id":"","url":"https://api.github.com/users/kittinunf","html_url":"https://github.com/kittinunf","followers_url":"https://api.github.com/users/kittinunf/followers","following_url":"https://api.github.com/users/kittinunf/following{/other_user}","gists_url":"https://api.github.com/users/kittinunf/gists{/gist_id}","starred_url":"https://api.github.com/users/kittinunf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittinunf/subscriptions","organizations_url":"https://api.github.com/users/kittinunf/orgs","repos_url":"https://api.github.com/users/kittinunf/repos","events_url":"https://api.github.com/users/kittinunf/events{/privacy}","received_events_url":"https://api.github.com/users/kittinunf/received_events","type":"User","site_admin":false},"repo":{"id":36847034,"node_id":"MDEwOlJlcG9zaXRvcnkzNjg0NzAzNA==","name":"Fuel","full_name":"kittinunf/Fuel","private":false,"owner":{"login":"kittinunf","id":4669517,"node_id":"MDQ6VXNlcjQ2Njk1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4669517?v=4","gravatar_id":"","url":"https://api.github.com/users/kittinunf","html_url":"https://github.com/kittinunf","followers_url":"https://api.github.com/users/kittinunf/followers","following_url":"https://api.github.com/users/kittinunf/following{/other_user}","gists_url":"https://api.github.com/users/kittinunf/gists{/gist_id}","starred_url":"https://api.github.com/users/kittinunf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittinunf/subscriptions","organizations_url":"https://api.github.com/users/kittinunf/orgs","repos_url":"https://api.github.com/users/kittinunf/repos","events_url":"https://api.github.com/users/kittinunf/events{/privacy}","received_events_url":"https://api.github.com/users/kittinunf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kittinunf/Fuel","description":"The easiest HTTP networking library for Kotlin/Android","fork":false,"url":"https://api.github.com/repos/kittinunf/Fuel","forks_url":"https://api.github.com/repos/kittinunf/Fuel/forks","keys_url":"https://api.github.com/repos/kittinunf/Fuel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kittinunf/Fuel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kittinunf/Fuel/teams","hooks_url":"https://api.github.com/repos/kittinunf/Fuel/hooks","issue_events_url":"https://api.github.com/repos/kittinunf/Fuel/issues/events{/number}","events_url":"https://api.github.com/repos/kittinunf/Fuel/events","assignees_url":"https://api.github.com/repos/kittinunf/Fuel/assignees{/user}","branches_url":"https://api.github.com/repos/kittinunf/Fuel/branches{/branch}","tags_url":"https://api.github.com/repos/kittinunf/Fuel/tags","blobs_url":"https://api.github.com/repos/kittinunf/Fuel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kittinunf/Fuel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kittinunf/Fuel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kittinunf/Fuel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kittinunf/Fuel/statuses/{sha}","languages_url":"https://api.github.com/repos/kittinunf/Fuel/languages","stargazers_url":"https://api.github.com/repos/kittinunf/Fuel/stargazers","contributors_url":"https://api.github.com/repos/kittinunf/Fuel/contributors","subscribers_url":"https://api.github.com/repos/kittinunf/Fuel/subscribers","subscription_url":"https://api.github.com/repos/kittinunf/Fuel/subscription","commits_url":"https://api.github.com/repos/kittinunf/Fuel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kittinunf/Fuel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kittinunf/Fuel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kittinunf/Fuel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kittinunf/Fuel/contents/{+path}","compare_url":"https://api.github.com/repos/kittinunf/Fuel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kittinunf/Fuel/merges","archive_url":"https://api.github.com/repos/kittinunf/Fuel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kittinunf/Fuel/downloads","issues_url":"https://api.github.com/repos/kittinunf/Fuel/issues{/number}","pulls_url":"https://api.github.com/repos/kittinunf/Fuel/pulls{/number}","milestones_url":"https://api.github.com/repos/kittinunf/Fuel/milestones{/number}","notifications_url":"https://api.github.com/repos/kittinunf/Fuel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kittinunf/Fuel/labels{/name}","releases_url":"https://api.github.com/repos/kittinunf/Fuel/releases{/id}","deployments_url":"https://api.github.com/repos/kittinunf/Fuel/deployments","created_at":"2015-06-04T04:03:33Z","updated_at":"2018-09-29T00:14:40Z","pushed_at":"2018-09-30T03:02:29Z","git_url":"git://github.com/kittinunf/Fuel.git","ssh_url":"git@github.com:kittinunf/Fuel.git","clone_url":"https://github.com/kittinunf/Fuel.git","svn_url":"https://github.com/kittinunf/Fuel","homepage":"","size":1297,"stargazers_count":2152,"watchers_count":2152,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":217,"open_issues":41,"watchers":2152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kittinunf/Fuel/pulls/438"},"html":{"href":"https://github.com/kittinunf/Fuel/pull/438"},"issue":{"href":"https://api.github.com/repos/kittinunf/Fuel/issues/438"},"comments":{"href":"https://api.github.com/repos/kittinunf/Fuel/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/kittinunf/Fuel/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/kittinunf/Fuel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kittinunf/Fuel/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/kittinunf/Fuel/statuses/ecb15e29e4c01e09233f742ffa9729f51f586d00"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kittinunf"}}