{"action":"closed","number":1877,"pull_request":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1877","id":173862507,"html_url":"https://github.com/gfx-rs/gfx/pull/1877","diff_url":"https://github.com/gfx-rs/gfx/pull/1877.diff","patch_url":"https://github.com/gfx-rs/gfx/pull/1877.patch","issue_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1877","number":1877,"state":"closed","locked":false,"title":"[WIP, dx12] careful temporary image placement for buffer copies","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"Fixes #1843\r\nPR checklist:\r\n- [ ] `make` succeeds (on *nix)\r\n- [ ] `make reftests` succeeds\r\n- [ ] tested examples with the following backends:\r\n\r\nBasic idea is that we can't always map a virtual image at the buffer offset that the user provided, given that image offset in row/columns may be non-zero. Instead, we roll back the offset as much as needed. This is not ideal, given that it only works if the given buffer offset is big enough in the first place.\r\n\r\nNote: I haven't yet tested this.","created_at":"2018-03-08T21:58:44Z","updated_at":"2018-03-28T20:17:02Z","closed_at":"2018-03-28T20:17:02Z","merged_at":null,"merge_commit_sha":"674a39cbf7beb283f53a5fe3a5ddd40e2414a1a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1877/commits","review_comments_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1877/comments","review_comment_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1877/comments","statuses_url":"https://api.github.com/repos/gfx-rs/gfx/statuses/0024f7b6ea47cd40793a938a4bcf1d2cd6027743","head":{"label":"kvark:dx12-copy-image","ref":"dx12-copy-image","sha":"0024f7b6ea47cd40793a938a4bcf1d2cd6027743","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"repo":{"id":21021936,"name":"gfx","full_name":"kvark/gfx","owner":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kvark/gfx","description":"A lightweight graphics device manager for Rust","fork":true,"url":"https://api.github.com/repos/kvark/gfx","forks_url":"https://api.github.com/repos/kvark/gfx/forks","keys_url":"https://api.github.com/repos/kvark/gfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kvark/gfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kvark/gfx/teams","hooks_url":"https://api.github.com/repos/kvark/gfx/hooks","issue_events_url":"https://api.github.com/repos/kvark/gfx/issues/events{/number}","events_url":"https://api.github.com/repos/kvark/gfx/events","assignees_url":"https://api.github.com/repos/kvark/gfx/assignees{/user}","branches_url":"https://api.github.com/repos/kvark/gfx/branches{/branch}","tags_url":"https://api.github.com/repos/kvark/gfx/tags","blobs_url":"https://api.github.com/repos/kvark/gfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kvark/gfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kvark/gfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kvark/gfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kvark/gfx/statuses/{sha}","languages_url":"https://api.github.com/repos/kvark/gfx/languages","stargazers_url":"https://api.github.com/repos/kvark/gfx/stargazers","contributors_url":"https://api.github.com/repos/kvark/gfx/contributors","subscribers_url":"https://api.github.com/repos/kvark/gfx/subscribers","subscription_url":"https://api.github.com/repos/kvark/gfx/subscription","commits_url":"https://api.github.com/repos/kvark/gfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kvark/gfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kvark/gfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kvark/gfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kvark/gfx/contents/{+path}","compare_url":"https://api.github.com/repos/kvark/gfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kvark/gfx/merges","archive_url":"https://api.github.com/repos/kvark/gfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kvark/gfx/downloads","issues_url":"https://api.github.com/repos/kvark/gfx/issues{/number}","pulls_url":"https://api.github.com/repos/kvark/gfx/pulls{/number}","milestones_url":"https://api.github.com/repos/kvark/gfx/milestones{/number}","notifications_url":"https://api.github.com/repos/kvark/gfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kvark/gfx/labels{/name}","releases_url":"https://api.github.com/repos/kvark/gfx/releases{/id}","deployments_url":"https://api.github.com/repos/kvark/gfx/deployments","created_at":"2014-06-20T01:55:38Z","updated_at":"2017-03-26T03:43:39Z","pushed_at":"2018-03-28T20:14:29Z","git_url":"git://github.com/kvark/gfx.git","ssh_url":"git@github.com:kvark/gfx.git","clone_url":"https://github.com/kvark/gfx.git","svn_url":"https://github.com/kvark/gfx","homepage":"","size":12611,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gfx-rs:master","ref":"master","sha":"71f9bc489508b0aef419921e6750bf822620950e","user":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars3.githubusercontent.com/u/8213174?v=4","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":13847975,"name":"gfx","full_name":"gfx-rs/gfx","owner":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars3.githubusercontent.com/u/8213174?v=4","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gfx-rs/gfx","description":"A high-performance, bindless graphics API for Rust.","fork":false,"url":"https://api.github.com/repos/gfx-rs/gfx","forks_url":"https://api.github.com/repos/gfx-rs/gfx/forks","keys_url":"https://api.github.com/repos/gfx-rs/gfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfx-rs/gfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfx-rs/gfx/teams","hooks_url":"https://api.github.com/repos/gfx-rs/gfx/hooks","issue_events_url":"https://api.github.com/repos/gfx-rs/gfx/issues/events{/number}","events_url":"https://api.github.com/repos/gfx-rs/gfx/events","assignees_url":"https://api.github.com/repos/gfx-rs/gfx/assignees{/user}","branches_url":"https://api.github.com/repos/gfx-rs/gfx/branches{/branch}","tags_url":"https://api.github.com/repos/gfx-rs/gfx/tags","blobs_url":"https://api.github.com/repos/gfx-rs/gfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfx-rs/gfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfx-rs/gfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfx-rs/gfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfx-rs/gfx/statuses/{sha}","languages_url":"https://api.github.com/repos/gfx-rs/gfx/languages","stargazers_url":"https://api.github.com/repos/gfx-rs/gfx/stargazers","contributors_url":"https://api.github.com/repos/gfx-rs/gfx/contributors","subscribers_url":"https://api.github.com/repos/gfx-rs/gfx/subscribers","subscription_url":"https://api.github.com/repos/gfx-rs/gfx/subscription","commits_url":"https://api.github.com/repos/gfx-rs/gfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfx-rs/gfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfx-rs/gfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfx-rs/gfx/contents/{+path}","compare_url":"https://api.github.com/repos/gfx-rs/gfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfx-rs/gfx/merges","archive_url":"https://api.github.com/repos/gfx-rs/gfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfx-rs/gfx/downloads","issues_url":"https://api.github.com/repos/gfx-rs/gfx/issues{/number}","pulls_url":"https://api.github.com/repos/gfx-rs/gfx/pulls{/number}","milestones_url":"https://api.github.com/repos/gfx-rs/gfx/milestones{/number}","notifications_url":"https://api.github.com/repos/gfx-rs/gfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfx-rs/gfx/labels{/name}","releases_url":"https://api.github.com/repos/gfx-rs/gfx/releases{/id}","deployments_url":"https://api.github.com/repos/gfx-rs/gfx/deployments","created_at":"2013-10-25T00:35:35Z","updated_at":"2018-03-28T17:50:34Z","pushed_at":"2018-03-28T20:16:42Z","git_url":"git://github.com/gfx-rs/gfx.git","ssh_url":"git@github.com:gfx-rs/gfx.git","clone_url":"https://github.com/gfx-rs/gfx.git","svn_url":"https://github.com/gfx-rs/gfx","homepage":"http://gfx-rs.github.io/","size":29019,"stargazers_count":1517,"watchers_count":1517,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":211,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":233,"open_issues":211,"watchers":1517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1877"},"html":{"href":"https://github.com/gfx-rs/gfx/pull/1877"},"issue":{"href":"https://api.github.com/repos/gfx-rs/gfx/issues/1877"},"comments":{"href":"https://api.github.com/repos/gfx-rs/gfx/issues/1877/comments"},"review_comments":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1877/comments"},"review_comment":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1877/commits"},"statuses":{"href":"https://api.github.com/repos/gfx-rs/gfx/statuses/0024f7b6ea47cd40793a938a4bcf1d2cd6027743"}},"author_association":"OWNER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":1,"additions":123,"deletions":80,"changed_files":1}}
{"actor":{"display_login":"kvark"}}