{"action":"created","comment":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/comments/245071326","pull_request_review_id":189104583,"id":245071326,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTA3MTMyNg==","diff_hunk":"@@ -0,0 +1,60 @@\n+use solana::ledger::{create_tmp_genesis, create_tmp_sample_ledger, LedgerWriter};\n+use solana_sdk::signature::{Keypair, KeypairUtil};\n+use std::process::Command;\n+use std::process::Output;\n+use std::sync::Arc;\n+\n+static TARGET_PATH: &str = \"../target/debug/solana-ledger-tool\";","path":"ledger-tool/tests/basic.rs","position":null,"original_position":7,"commit_id":"bb3ef89a4927237db11b4fd1d0ed467ba7e429a5","original_commit_id":"7ca9a86cc13558188109bb4dda34a6e327bf6df1","user":{"login":"AkhRani","id":4325881,"node_id":"MDQ6VXNlcjQzMjU4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/4325881?v=4","gravatar_id":"","url":"https://api.github.com/users/AkhRani","html_url":"https://github.com/AkhRani","followers_url":"https://api.github.com/users/AkhRani/followers","following_url":"https://api.github.com/users/AkhRani/following{/other_user}","gists_url":"https://api.github.com/users/AkhRani/gists{/gist_id}","starred_url":"https://api.github.com/users/AkhRani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkhRani/subscriptions","organizations_url":"https://api.github.com/users/AkhRani/orgs","repos_url":"https://api.github.com/users/AkhRani/repos","events_url":"https://api.github.com/users/AkhRani/events{/privacy}","received_events_url":"https://api.github.com/users/AkhRani/received_events","type":"User","site_admin":false},"body":"Oops.  I amended and pushed the commit but didn't add the latest changes.","created_at":"2019-01-03T17:19:20Z","updated_at":"2019-01-03T17:19:21Z","html_url":"https://github.com/solana-labs/solana/pull/2196#discussion_r245071326","pull_request_url":"https://api.github.com/repos/solana-labs/solana/pulls/2196","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments/245071326"},"html":{"href":"https://github.com/solana-labs/solana/pull/2196#discussion_r245071326"},"pull_request":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2196"}},"in_reply_to_id":244642983},"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/2196","id":239025482,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDI1NDgy","html_url":"https://github.com/solana-labs/solana/pull/2196","diff_url":"https://github.com/solana-labs/solana/pull/2196.diff","patch_url":"https://github.com/solana-labs/solana/pull/2196.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/2196","number":2196,"state":"open","locked":false,"title":"Enhance ledger-tool","user":{"login":"AkhRani","id":4325881,"node_id":"MDQ6VXNlcjQzMjU4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/4325881?v=4","gravatar_id":"","url":"https://api.github.com/users/AkhRani","html_url":"https://github.com/AkhRani","followers_url":"https://api.github.com/users/AkhRani/followers","following_url":"https://api.github.com/users/AkhRani/following{/other_user}","gists_url":"https://api.github.com/users/AkhRani/gists{/gist_id}","starred_url":"https://api.github.com/users/AkhRani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkhRani/subscriptions","organizations_url":"https://api.github.com/users/AkhRani/orgs","repos_url":"https://api.github.com/users/AkhRani/repos","events_url":"https://api.github.com/users/AkhRani/events{/privacy}","received_events_url":"https://api.github.com/users/AkhRani/received_events","type":"User","site_admin":false},"body":"Add a command-line argument (min-hashes) to restrict the entries\r\nprocessed by ledger-tool.  For example, --min-hashes 1 will strip\r\n\"empty\" Entries, i.e. those with num_hashes = 0.\r\n\r\n#### Problem\r\n\r\n#### Summary of Changes\r\n\r\nFixes #946\r\n","created_at":"2018-12-17T04:41:16Z","updated_at":"2019-01-03T17:19:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"809a5e94653a0b0e98b9872d1453bad249a5fcb6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rob-solana","id":40183961,"node_id":"MDQ6VXNlcjQwMTgzOTYx","avatar_url":"https://avatars0.githubusercontent.com/u/40183961?v=4","gravatar_id":"","url":"https://api.github.com/users/rob-solana","html_url":"https://github.com/rob-solana","followers_url":"https://api.github.com/users/rob-solana/followers","following_url":"https://api.github.com/users/rob-solana/following{/other_user}","gists_url":"https://api.github.com/users/rob-solana/gists{/gist_id}","starred_url":"https://api.github.com/users/rob-solana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rob-solana/subscriptions","organizations_url":"https://api.github.com/users/rob-solana/orgs","repos_url":"https://api.github.com/users/rob-solana/repos","events_url":"https://api.github.com/users/rob-solana/events{/privacy}","received_events_url":"https://api.github.com/users/rob-solana/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/2196/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/2196/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/2196/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/bb3ef89a4927237db11b4fd1d0ed467ba7e429a5","head":{"label":"AkhRani:enhance_ledger_tool","ref":"enhance_ledger_tool","sha":"bb3ef89a4927237db11b4fd1d0ed467ba7e429a5","user":{"login":"AkhRani","id":4325881,"node_id":"MDQ6VXNlcjQzMjU4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/4325881?v=4","gravatar_id":"","url":"https://api.github.com/users/AkhRani","html_url":"https://github.com/AkhRani","followers_url":"https://api.github.com/users/AkhRani/followers","following_url":"https://api.github.com/users/AkhRani/following{/other_user}","gists_url":"https://api.github.com/users/AkhRani/gists{/gist_id}","starred_url":"https://api.github.com/users/AkhRani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkhRani/subscriptions","organizations_url":"https://api.github.com/users/AkhRani/orgs","repos_url":"https://api.github.com/users/AkhRani/repos","events_url":"https://api.github.com/users/AkhRani/events{/privacy}","received_events_url":"https://api.github.com/users/AkhRani/received_events","type":"User","site_admin":false},"repo":{"id":160621668,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA2MjE2Njg=","name":"solana","full_name":"AkhRani/solana","private":false,"owner":{"login":"AkhRani","id":4325881,"node_id":"MDQ6VXNlcjQzMjU4ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/4325881?v=4","gravatar_id":"","url":"https://api.github.com/users/AkhRani","html_url":"https://github.com/AkhRani","followers_url":"https://api.github.com/users/AkhRani/followers","following_url":"https://api.github.com/users/AkhRani/following{/other_user}","gists_url":"https://api.github.com/users/AkhRani/gists{/gist_id}","starred_url":"https://api.github.com/users/AkhRani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkhRani/subscriptions","organizations_url":"https://api.github.com/users/AkhRani/orgs","repos_url":"https://api.github.com/users/AkhRani/repos","events_url":"https://api.github.com/users/AkhRani/events{/privacy}","received_events_url":"https://api.github.com/users/AkhRani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AkhRani/solana","description":"Blockchain Rebuilt for Scale","fork":true,"url":"https://api.github.com/repos/AkhRani/solana","forks_url":"https://api.github.com/repos/AkhRani/solana/forks","keys_url":"https://api.github.com/repos/AkhRani/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AkhRani/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AkhRani/solana/teams","hooks_url":"https://api.github.com/repos/AkhRani/solana/hooks","issue_events_url":"https://api.github.com/repos/AkhRani/solana/issues/events{/number}","events_url":"https://api.github.com/repos/AkhRani/solana/events","assignees_url":"https://api.github.com/repos/AkhRani/solana/assignees{/user}","branches_url":"https://api.github.com/repos/AkhRani/solana/branches{/branch}","tags_url":"https://api.github.com/repos/AkhRani/solana/tags","blobs_url":"https://api.github.com/repos/AkhRani/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AkhRani/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AkhRani/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/AkhRani/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AkhRani/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/AkhRani/solana/languages","stargazers_url":"https://api.github.com/repos/AkhRani/solana/stargazers","contributors_url":"https://api.github.com/repos/AkhRani/solana/contributors","subscribers_url":"https://api.github.com/repos/AkhRani/solana/subscribers","subscription_url":"https://api.github.com/repos/AkhRani/solana/subscription","commits_url":"https://api.github.com/repos/AkhRani/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/AkhRani/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/AkhRani/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/AkhRani/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/AkhRani/solana/contents/{+path}","compare_url":"https://api.github.com/repos/AkhRani/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AkhRani/solana/merges","archive_url":"https://api.github.com/repos/AkhRani/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AkhRani/solana/downloads","issues_url":"https://api.github.com/repos/AkhRani/solana/issues{/number}","pulls_url":"https://api.github.com/repos/AkhRani/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/AkhRani/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/AkhRani/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AkhRani/solana/labels{/name}","releases_url":"https://api.github.com/repos/AkhRani/solana/releases{/id}","deployments_url":"https://api.github.com/repos/AkhRani/solana/deployments","created_at":"2018-12-06T05:07:52Z","updated_at":"2018-12-22T21:39:06Z","pushed_at":"2019-01-03T17:18:11Z","git_url":"git://github.com/AkhRani/solana.git","ssh_url":"git@github.com:AkhRani/solana.git","clone_url":"https://github.com/AkhRani/solana.git","svn_url":"https://github.com/AkhRani/solana","homepage":"https://solana.com","size":15168,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"c4259fc8cc2142ba31cdf6b1f454df8cfd0ad0f5","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","private":false,"owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/solana-labs/solana","description":"Blockchain Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2019-01-03T16:13:08Z","pushed_at":"2019-01-03T17:18:12Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":15318,"stargazers_count":401,"watchers_count":401,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":190,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":73,"open_issues":190,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2196"},"html":{"href":"https://github.com/solana-labs/solana/pull/2196"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/2196"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/2196/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2196/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/2196/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/bb3ef89a4927237db11b4fd1d0ed467ba7e429a5"}},"author_association":"NONE"}}
{"actor":{"display_login":"AkhRani"}}