{"action":"closed","number":7779,"pull_request":{"url":"https://api.github.com/repos/libretro/RetroArch/pulls/7779","id":240234948,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjM0OTQ4","html_url":"https://github.com/libretro/RetroArch/pull/7779","diff_url":"https://github.com/libretro/RetroArch/pull/7779.diff","patch_url":"https://github.com/libretro/RetroArch/pull/7779.patch","issue_url":"https://api.github.com/repos/libretro/RetroArch/issues/7779","number":7779,"state":"closed","locked":false,"title":"(RGUI) Enable customisation of background and border colours","user":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nWhen using RGUI, it is currently only possible to change the text colour. This PR enables customisation of the background and border colours as well. I've wired up the associated menu options, but it's not really practical to set any of the colours via the GUI - manual editing of the config file is pretty much required. (I may look at adding some pre-configured 'themes', but I won't have time for this until after Christmas...)\r\n\r\nHere are some quick config examples I threw together:\r\n\r\n    menu_entry_hover_color = 0xffBCDDE6\r\n    menu_entry_normal_color = 0xffc6c5b9\r\n    menu_title_color = 0xff86C7C7\r\n    menu_bg_dark_color = 0xC0495C6B\r\n    menu_bg_light_color = 0xC0526778\r\n    menu_border_dark_color = 0xC058848F\r\n    menu_border_light_color = 0xC060909C\r\n\r\n![undersea](https://user-images.githubusercontent.com/38211560/50296966-8f185f00-0473-11e9-8f6d-a4e6fd687fea.png)\r\n\r\n    menu_entry_hover_color = 0xffE8D1B0\r\n    menu_entry_normal_color = 0xffFFFFE6\r\n    menu_title_color = 0xffcbd4c2\r\n    menu_bg_dark_color = 0xC06E4F52\r\n    menu_bg_light_color = 0xC0705154\r\n    menu_border_dark_color = 0xC0C1C9B8\r\n    menu_border_light_color = 0xC0cbd4c2\r\n\r\n![brown](https://user-images.githubusercontent.com/38211560/50297018-aeaf8780-0473-11e9-99ca-b5f6f673ad4d.png)\r\n\r\n    menu_entry_hover_color = 0xffc4ebc8\r\n    menu_entry_normal_color = 0xff8EAFE6\r\n    menu_title_color = 0xffCCBFFF\r\n    menu_bg_dark_color = 0xC05744A6\r\n    menu_bg_light_color = 0xC05f4bb6\r\n    menu_border_dark_color = 0xC0819FD1\r\n    menu_border_light_color = 0xC083A1D4\r\n\r\n![blue](https://user-images.githubusercontent.com/38211560/50297064-cd158300-0473-11e9-8c3e-db99279dda05.png)\r\n\r\n    menu_entry_hover_color = 0xff7FC1CA\r\n    menu_entry_normal_color = 0xffF5F5F5\r\n    menu_title_color = 0xff83AFE5\r\n    menu_bg_dark_color = 0xC03C4C55\r\n    menu_bg_light_color = 0xC03C4C55\r\n    menu_border_dark_color = 0xC0546873\r\n    menu_border_light_color = 0xC0546873\r\n\r\n![nova](https://user-images.githubusercontent.com/38211560/50297156-fc2bf480-0473-11e9-87f2-90bb6b273577.png)\r\n\r\n    menu_entry_hover_color = 0xff98C379\r\n    menu_entry_normal_color = 0xffAAAFBA\r\n    menu_title_color = 0xffD19A66\r\n    menu_bg_dark_color = 0xC03B414D\r\n    menu_bg_light_color = 0xC03B414D\r\n    menu_border_dark_color = 0xC0656D7A\r\n    menu_border_light_color = 0xC0656D7A\r\n\r\n![onedark](https://user-images.githubusercontent.com/38211560/50297185-1665d280-0474-11e9-888c-e2c6e607013a.png)\r\n\r\nThe default config retains the standard grey and green colours we all know (and love...?)\r\n\r\n------\r\n\r\n**IMPORTANT NOTE**: The original colour handling code is obfuscated to the point of lunacy. I have no idea what pixel format it is using for the Wii, PSP, PS2 and Switch builds, so for those platforms this PR changes nothing. If someone can tell me what kind of colour conversion should be used for these cases, I can get rid of the current `#if defined` nonsense and make this universal.\r\n","created_at":"2018-12-20T16:46:44Z","updated_at":"2018-12-20T19:51:12Z","closed_at":"2018-12-20T19:51:12Z","merged_at":"2018-12-20T19:51:12Z","merge_commit_sha":"1d3874a1420e42c559b5e6f357a7ddac2251a716","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libretro/RetroArch/pulls/7779/commits","review_comments_url":"https://api.github.com/repos/libretro/RetroArch/pulls/7779/comments","review_comment_url":"https://api.github.com/repos/libretro/RetroArch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libretro/RetroArch/issues/7779/comments","statuses_url":"https://api.github.com/repos/libretro/RetroArch/statuses/f603d4ec302769ffd89e3659e126f29d07460aa9","head":{"label":"jdgleaver:rgui-colours","ref":"rgui-colours","sha":"f603d4ec302769ffd89e3659e126f29d07460aa9","user":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"repo":{"id":155872771,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4NzI3NzE=","name":"RetroArch","full_name":"jdgleaver/RetroArch","private":false,"owner":{"login":"jdgleaver","id":38211560,"node_id":"MDQ6VXNlcjM4MjExNTYw","avatar_url":"https://avatars3.githubusercontent.com/u/38211560?v=4","gravatar_id":"","url":"https://api.github.com/users/jdgleaver","html_url":"https://github.com/jdgleaver","followers_url":"https://api.github.com/users/jdgleaver/followers","following_url":"https://api.github.com/users/jdgleaver/following{/other_user}","gists_url":"https://api.github.com/users/jdgleaver/gists{/gist_id}","starred_url":"https://api.github.com/users/jdgleaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdgleaver/subscriptions","organizations_url":"https://api.github.com/users/jdgleaver/orgs","repos_url":"https://api.github.com/users/jdgleaver/repos","events_url":"https://api.github.com/users/jdgleaver/events{/privacy}","received_events_url":"https://api.github.com/users/jdgleaver/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdgleaver/RetroArch","description":"Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.","fork":true,"url":"https://api.github.com/repos/jdgleaver/RetroArch","forks_url":"https://api.github.com/repos/jdgleaver/RetroArch/forks","keys_url":"https://api.github.com/repos/jdgleaver/RetroArch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdgleaver/RetroArch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdgleaver/RetroArch/teams","hooks_url":"https://api.github.com/repos/jdgleaver/RetroArch/hooks","issue_events_url":"https://api.github.com/repos/jdgleaver/RetroArch/issues/events{/number}","events_url":"https://api.github.com/repos/jdgleaver/RetroArch/events","assignees_url":"https://api.github.com/repos/jdgleaver/RetroArch/assignees{/user}","branches_url":"https://api.github.com/repos/jdgleaver/RetroArch/branches{/branch}","tags_url":"https://api.github.com/repos/jdgleaver/RetroArch/tags","blobs_url":"https://api.github.com/repos/jdgleaver/RetroArch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdgleaver/RetroArch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdgleaver/RetroArch/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdgleaver/RetroArch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdgleaver/RetroArch/statuses/{sha}","languages_url":"https://api.github.com/repos/jdgleaver/RetroArch/languages","stargazers_url":"https://api.github.com/repos/jdgleaver/RetroArch/stargazers","contributors_url":"https://api.github.com/repos/jdgleaver/RetroArch/contributors","subscribers_url":"https://api.github.com/repos/jdgleaver/RetroArch/subscribers","subscription_url":"https://api.github.com/repos/jdgleaver/RetroArch/subscription","commits_url":"https://api.github.com/repos/jdgleaver/RetroArch/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdgleaver/RetroArch/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdgleaver/RetroArch/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdgleaver/RetroArch/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdgleaver/RetroArch/contents/{+path}","compare_url":"https://api.github.com/repos/jdgleaver/RetroArch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdgleaver/RetroArch/merges","archive_url":"https://api.github.com/repos/jdgleaver/RetroArch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdgleaver/RetroArch/downloads","issues_url":"https://api.github.com/repos/jdgleaver/RetroArch/issues{/number}","pulls_url":"https://api.github.com/repos/jdgleaver/RetroArch/pulls{/number}","milestones_url":"https://api.github.com/repos/jdgleaver/RetroArch/milestones{/number}","notifications_url":"https://api.github.com/repos/jdgleaver/RetroArch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdgleaver/RetroArch/labels{/name}","releases_url":"https://api.github.com/repos/jdgleaver/RetroArch/releases{/id}","deployments_url":"https://api.github.com/repos/jdgleaver/RetroArch/deployments","created_at":"2018-11-02T13:52:41Z","updated_at":"2018-12-20T16:13:05Z","pushed_at":"2018-12-20T16:16:14Z","git_url":"git://github.com/jdgleaver/RetroArch.git","ssh_url":"git@github.com:jdgleaver/RetroArch.git","clone_url":"https://github.com/jdgleaver/RetroArch.git","svn_url":"https://github.com/jdgleaver/RetroArch","homepage":"http://www.libretro.com","size":189198,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libretro:master","ref":"master","sha":"d41bb64d171c539763b988c1c6920a180d74c599","user":{"login":"libretro","id":1812827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTI4Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1812827?v=4","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"repo":{"id":689344,"node_id":"MDEwOlJlcG9zaXRvcnk2ODkzNDQ=","name":"RetroArch","full_name":"libretro/RetroArch","private":false,"owner":{"login":"libretro","id":1812827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTI4Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1812827?v=4","gravatar_id":"","url":"https://api.github.com/users/libretro","html_url":"https://github.com/libretro","followers_url":"https://api.github.com/users/libretro/followers","following_url":"https://api.github.com/users/libretro/following{/other_user}","gists_url":"https://api.github.com/users/libretro/gists{/gist_id}","starred_url":"https://api.github.com/users/libretro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libretro/subscriptions","organizations_url":"https://api.github.com/users/libretro/orgs","repos_url":"https://api.github.com/users/libretro/repos","events_url":"https://api.github.com/users/libretro/events{/privacy}","received_events_url":"https://api.github.com/users/libretro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libretro/RetroArch","description":"Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.","fork":false,"url":"https://api.github.com/repos/libretro/RetroArch","forks_url":"https://api.github.com/repos/libretro/RetroArch/forks","keys_url":"https://api.github.com/repos/libretro/RetroArch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libretro/RetroArch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libretro/RetroArch/teams","hooks_url":"https://api.github.com/repos/libretro/RetroArch/hooks","issue_events_url":"https://api.github.com/repos/libretro/RetroArch/issues/events{/number}","events_url":"https://api.github.com/repos/libretro/RetroArch/events","assignees_url":"https://api.github.com/repos/libretro/RetroArch/assignees{/user}","branches_url":"https://api.github.com/repos/libretro/RetroArch/branches{/branch}","tags_url":"https://api.github.com/repos/libretro/RetroArch/tags","blobs_url":"https://api.github.com/repos/libretro/RetroArch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libretro/RetroArch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libretro/RetroArch/git/refs{/sha}","trees_url":"https://api.github.com/repos/libretro/RetroArch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libretro/RetroArch/statuses/{sha}","languages_url":"https://api.github.com/repos/libretro/RetroArch/languages","stargazers_url":"https://api.github.com/repos/libretro/RetroArch/stargazers","contributors_url":"https://api.github.com/repos/libretro/RetroArch/contributors","subscribers_url":"https://api.github.com/repos/libretro/RetroArch/subscribers","subscription_url":"https://api.github.com/repos/libretro/RetroArch/subscription","commits_url":"https://api.github.com/repos/libretro/RetroArch/commits{/sha}","git_commits_url":"https://api.github.com/repos/libretro/RetroArch/git/commits{/sha}","comments_url":"https://api.github.com/repos/libretro/RetroArch/comments{/number}","issue_comment_url":"https://api.github.com/repos/libretro/RetroArch/issues/comments{/number}","contents_url":"https://api.github.com/repos/libretro/RetroArch/contents/{+path}","compare_url":"https://api.github.com/repos/libretro/RetroArch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libretro/RetroArch/merges","archive_url":"https://api.github.com/repos/libretro/RetroArch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libretro/RetroArch/downloads","issues_url":"https://api.github.com/repos/libretro/RetroArch/issues{/number}","pulls_url":"https://api.github.com/repos/libretro/RetroArch/pulls{/number}","milestones_url":"https://api.github.com/repos/libretro/RetroArch/milestones{/number}","notifications_url":"https://api.github.com/repos/libretro/RetroArch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libretro/RetroArch/labels{/name}","releases_url":"https://api.github.com/repos/libretro/RetroArch/releases{/id}","deployments_url":"https://api.github.com/repos/libretro/RetroArch/deployments","created_at":"2010-05-27T14:47:40Z","updated_at":"2018-12-20T19:49:43Z","pushed_at":"2018-12-20T19:51:12Z","git_url":"git://github.com/libretro/RetroArch.git","ssh_url":"git@github.com:libretro/RetroArch.git","clone_url":"https://github.com/libretro/RetroArch.git","svn_url":"https://github.com/libretro/RetroArch","homepage":"http://www.libretro.com","size":189111,"stargazers_count":2753,"watchers_count":2753,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":802,"mirror_url":null,"archived":false,"open_issues_count":1116,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":802,"open_issues":1116,"watchers":2753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/7779"},"html":{"href":"https://github.com/libretro/RetroArch/pull/7779"},"issue":{"href":"https://api.github.com/repos/libretro/RetroArch/issues/7779"},"comments":{"href":"https://api.github.com/repos/libretro/RetroArch/issues/7779/comments"},"review_comments":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/7779/comments"},"review_comment":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libretro/RetroArch/pulls/7779/commits"},"statuses":{"href":"https://api.github.com/repos/libretro/RetroArch/statuses/f603d4ec302769ffd89e3659e126f29d07460aa9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"twinaphex","id":1075274,"node_id":"MDQ6VXNlcjEwNzUyNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1075274?v=4","gravatar_id":"","url":"https://api.github.com/users/twinaphex","html_url":"https://github.com/twinaphex","followers_url":"https://api.github.com/users/twinaphex/followers","following_url":"https://api.github.com/users/twinaphex/following{/other_user}","gists_url":"https://api.github.com/users/twinaphex/gists{/gist_id}","starred_url":"https://api.github.com/users/twinaphex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twinaphex/subscriptions","organizations_url":"https://api.github.com/users/twinaphex/orgs","repos_url":"https://api.github.com/users/twinaphex/repos","events_url":"https://api.github.com/users/twinaphex/events{/privacy}","received_events_url":"https://api.github.com/users/twinaphex/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":241,"deletions":63,"changed_files":9}}
{"actor":{"display_login":"twinaphex"}}