{"action":"created","comment":{"url":"https://api.github.com/repos/trademapper/trademapper-js/pulls/comments/238243182","pull_request_review_id":180734389,"id":238243182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODI0MzE4Mg==","diff_hunk":"@@ -256,12 +266,17 @@ define([\n \t\t\t\t\t\tbreak;\n \t\t\t\t\t}\n \t\t\t\t}\n-\t\t\t\tif (colType !== 'location') {\n+\n+\t\t\t\tif (colType !== 'location' && colType !== 'port_code') {\n \t\t\t\t\trole = this.headerNameToLocationRole(header, true);\n \t\t\t\t\tif (role !== '') {\n \t\t\t\t\t\tif (header.toLowerCase().indexOf('long') > -1 ||\n \t\t\t\t\t\t\t\theader.toLowerCase().indexOf('lat') > -1) {\n \t\t\t\t\t\t\tcolType = 'location_extra';\n+\t\t\t\t\t\t} else if (header.toLowerCase().indexOf('iata') > -1 ||\n+\t\t\t\t\t\t\t\t\t\t\t header.toLowerCase().indexOf('icao') > -1 ||\n+\t\t\t\t\t\t\t\t\t\t\t header.toLowerCase().indexOf('unlocode') > -1) {","path":"trademapper/js/trademapper.customcsv.js","position":68,"original_position":68,"commit_id":"932697c1106afece8319fa40d54c77414735dce3","original_commit_id":"932697c1106afece8319fa40d54c77414735dce3","user":{"login":"townxelliot","id":83619,"node_id":"MDQ6VXNlcjgzNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/83619?v=4","gravatar_id":"","url":"https://api.github.com/users/townxelliot","html_url":"https://github.com/townxelliot","followers_url":"https://api.github.com/users/townxelliot/followers","following_url":"https://api.github.com/users/townxelliot/following{/other_user}","gists_url":"https://api.github.com/users/townxelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/townxelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/townxelliot/subscriptions","organizations_url":"https://api.github.com/users/townxelliot/orgs","repos_url":"https://api.github.com/users/townxelliot/repos","events_url":"https://api.github.com/users/townxelliot/events{/privacy}","received_events_url":"https://api.github.com/users/townxelliot/received_events","type":"User","site_admin":false},"body":"Will do this.","created_at":"2018-12-03T12:08:04Z","updated_at":"2018-12-03T12:08:04Z","html_url":"https://github.com/trademapper/trademapper-js/pull/68#discussion_r238243182","pull_request_url":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/trademapper/trademapper-js/pulls/comments/238243182"},"html":{"href":"https://github.com/trademapper/trademapper-js/pull/68#discussion_r238243182"},"pull_request":{"href":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68"}},"in_reply_to_id":238222029},"pull_request":{"url":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68","id":234311815,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzExODE1","html_url":"https://github.com/trademapper/trademapper-js/pull/68","diff_url":"https://github.com/trademapper/trademapper-js/pull/68.diff","patch_url":"https://github.com/trademapper/trademapper-js/pull/68.patch","issue_url":"https://api.github.com/repos/trademapper/trademapper-js/issues/68","number":68,"state":"open","locked":false,"title":"Enable mapping between ports (+ slider fix)","user":{"login":"townxelliot","id":83619,"node_id":"MDQ6VXNlcjgzNjE5","avatar_url":"https://avatars3.githubusercontent.com/u/83619?v=4","gravatar_id":"","url":"https://api.github.com/users/townxelliot","html_url":"https://github.com/townxelliot","followers_url":"https://api.github.com/users/townxelliot/followers","following_url":"https://api.github.com/users/townxelliot/following{/other_user}","gists_url":"https://api.github.com/users/townxelliot/gists{/gist_id}","starred_url":"https://api.github.com/users/townxelliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/townxelliot/subscriptions","organizations_url":"https://api.github.com/users/townxelliot/orgs","repos_url":"https://api.github.com/users/townxelliot/repos","events_url":"https://api.github.com/users/townxelliot/events{/privacy}","received_events_url":"https://api.github.com/users/townxelliot/received_events","type":"User","site_admin":false},"body":"* Add script to convert openflights airport data (ICAO and IATA codes) and UNLOCODE data in CSV format to JS.\r\n* Add airport and seaport data as JS and wrap in an access API (getPortDetails() etc.).\r\n* Extend filter dialog to provide \"port code\" as a location type, along with auto-recognition of ICAO, UNLOCODE and IATA location columns.\r\n* Enable filter spec to accept multiple location columns with the same order and role, but not same order with different roles.\r\n* Modify route code to sort points based on their order property, rather than their position in the route array. This is so that points can be grouped by order, and the most-specific used as the actual point when routes are constructed.\r\n* Add code to use whichever trade node is most specific for a role in a route, with lat/lon being more specific than port code, and port code more specific than country code.\r\n* Modify map draw code so that countries containing a port on a route are highlighted.\r\n\r\n(I included the slider fix commit in this PR as it's tiny and doesn't merit a separate review.)","created_at":"2018-11-28T15:09:55Z","updated_at":"2018-12-03T12:08:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91eeb3c0f73ab520c7644dfcabe112a4a876d22d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68/commits","review_comments_url":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68/comments","review_comment_url":"https://api.github.com/repos/trademapper/trademapper-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trademapper/trademapper-js/issues/68/comments","statuses_url":"https://api.github.com/repos/trademapper/trademapper-js/statuses/932697c1106afece8319fa40d54c77414735dce3","head":{"label":"trademapper:elliots-ports","ref":"elliots-ports","sha":"932697c1106afece8319fa40d54c77414735dce3","user":{"login":"trademapper","id":8256554,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTY1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8256554?v=4","gravatar_id":"","url":"https://api.github.com/users/trademapper","html_url":"https://github.com/trademapper","followers_url":"https://api.github.com/users/trademapper/followers","following_url":"https://api.github.com/users/trademapper/following{/other_user}","gists_url":"https://api.github.com/users/trademapper/gists{/gist_id}","starred_url":"https://api.github.com/users/trademapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trademapper/subscriptions","organizations_url":"https://api.github.com/users/trademapper/orgs","repos_url":"https://api.github.com/users/trademapper/repos","events_url":"https://api.github.com/users/trademapper/events{/privacy}","received_events_url":"https://api.github.com/users/trademapper/received_events","type":"Organization","site_admin":false},"repo":{"id":22211216,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIxMTIxNg==","name":"trademapper-js","full_name":"trademapper/trademapper-js","private":false,"owner":{"login":"trademapper","id":8256554,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTY1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8256554?v=4","gravatar_id":"","url":"https://api.github.com/users/trademapper","html_url":"https://github.com/trademapper","followers_url":"https://api.github.com/users/trademapper/followers","following_url":"https://api.github.com/users/trademapper/following{/other_user}","gists_url":"https://api.github.com/users/trademapper/gists{/gist_id}","starred_url":"https://api.github.com/users/trademapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trademapper/subscriptions","organizations_url":"https://api.github.com/users/trademapper/orgs","repos_url":"https://api.github.com/users/trademapper/repos","events_url":"https://api.github.com/users/trademapper/events{/privacy}","received_events_url":"https://api.github.com/users/trademapper/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trademapper/trademapper-js","description":"JS libraries for mapping trade using d3.js","fork":false,"url":"https://api.github.com/repos/trademapper/trademapper-js","forks_url":"https://api.github.com/repos/trademapper/trademapper-js/forks","keys_url":"https://api.github.com/repos/trademapper/trademapper-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trademapper/trademapper-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trademapper/trademapper-js/teams","hooks_url":"https://api.github.com/repos/trademapper/trademapper-js/hooks","issue_events_url":"https://api.github.com/repos/trademapper/trademapper-js/issues/events{/number}","events_url":"https://api.github.com/repos/trademapper/trademapper-js/events","assignees_url":"https://api.github.com/repos/trademapper/trademapper-js/assignees{/user}","branches_url":"https://api.github.com/repos/trademapper/trademapper-js/branches{/branch}","tags_url":"https://api.github.com/repos/trademapper/trademapper-js/tags","blobs_url":"https://api.github.com/repos/trademapper/trademapper-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trademapper/trademapper-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trademapper/trademapper-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/trademapper/trademapper-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trademapper/trademapper-js/statuses/{sha}","languages_url":"https://api.github.com/repos/trademapper/trademapper-js/languages","stargazers_url":"https://api.github.com/repos/trademapper/trademapper-js/stargazers","contributors_url":"https://api.github.com/repos/trademapper/trademapper-js/contributors","subscribers_url":"https://api.github.com/repos/trademapper/trademapper-js/subscribers","subscription_url":"https://api.github.com/repos/trademapper/trademapper-js/subscription","commits_url":"https://api.github.com/repos/trademapper/trademapper-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/trademapper/trademapper-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/trademapper/trademapper-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/trademapper/trademapper-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/trademapper/trademapper-js/contents/{+path}","compare_url":"https://api.github.com/repos/trademapper/trademapper-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trademapper/trademapper-js/merges","archive_url":"https://api.github.com/repos/trademapper/trademapper-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trademapper/trademapper-js/downloads","issues_url":"https://api.github.com/repos/trademapper/trademapper-js/issues{/number}","pulls_url":"https://api.github.com/repos/trademapper/trademapper-js/pulls{/number}","milestones_url":"https://api.github.com/repos/trademapper/trademapper-js/milestones{/number}","notifications_url":"https://api.github.com/repos/trademapper/trademapper-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trademapper/trademapper-js/labels{/name}","releases_url":"https://api.github.com/repos/trademapper/trademapper-js/releases{/id}","deployments_url":"https://api.github.com/repos/trademapper/trademapper-js/deployments","created_at":"2014-07-24T11:58:09Z","updated_at":"2018-11-13T14:09:29Z","pushed_at":"2018-11-29T19:04:14Z","git_url":"git://github.com/trademapper/trademapper-js.git","ssh_url":"git@github.com:trademapper/trademapper-js.git","clone_url":"https://github.com/trademapper/trademapper-js.git","svn_url":"https://github.com/trademapper/trademapper-js","homepage":null,"size":3626,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":36,"watchers":20,"default_branch":"master"}},"base":{"label":"trademapper:staging","ref":"staging","sha":"7bbbcbbfb3f92e33e4a14e11a490553950396179","user":{"login":"trademapper","id":8256554,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTY1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8256554?v=4","gravatar_id":"","url":"https://api.github.com/users/trademapper","html_url":"https://github.com/trademapper","followers_url":"https://api.github.com/users/trademapper/followers","following_url":"https://api.github.com/users/trademapper/following{/other_user}","gists_url":"https://api.github.com/users/trademapper/gists{/gist_id}","starred_url":"https://api.github.com/users/trademapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trademapper/subscriptions","organizations_url":"https://api.github.com/users/trademapper/orgs","repos_url":"https://api.github.com/users/trademapper/repos","events_url":"https://api.github.com/users/trademapper/events{/privacy}","received_events_url":"https://api.github.com/users/trademapper/received_events","type":"Organization","site_admin":false},"repo":{"id":22211216,"node_id":"MDEwOlJlcG9zaXRvcnkyMjIxMTIxNg==","name":"trademapper-js","full_name":"trademapper/trademapper-js","private":false,"owner":{"login":"trademapper","id":8256554,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTY1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8256554?v=4","gravatar_id":"","url":"https://api.github.com/users/trademapper","html_url":"https://github.com/trademapper","followers_url":"https://api.github.com/users/trademapper/followers","following_url":"https://api.github.com/users/trademapper/following{/other_user}","gists_url":"https://api.github.com/users/trademapper/gists{/gist_id}","starred_url":"https://api.github.com/users/trademapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trademapper/subscriptions","organizations_url":"https://api.github.com/users/trademapper/orgs","repos_url":"https://api.github.com/users/trademapper/repos","events_url":"https://api.github.com/users/trademapper/events{/privacy}","received_events_url":"https://api.github.com/users/trademapper/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/trademapper/trademapper-js","description":"JS libraries for mapping trade using d3.js","fork":false,"url":"https://api.github.com/repos/trademapper/trademapper-js","forks_url":"https://api.github.com/repos/trademapper/trademapper-js/forks","keys_url":"https://api.github.com/repos/trademapper/trademapper-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trademapper/trademapper-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trademapper/trademapper-js/teams","hooks_url":"https://api.github.com/repos/trademapper/trademapper-js/hooks","issue_events_url":"https://api.github.com/repos/trademapper/trademapper-js/issues/events{/number}","events_url":"https://api.github.com/repos/trademapper/trademapper-js/events","assignees_url":"https://api.github.com/repos/trademapper/trademapper-js/assignees{/user}","branches_url":"https://api.github.com/repos/trademapper/trademapper-js/branches{/branch}","tags_url":"https://api.github.com/repos/trademapper/trademapper-js/tags","blobs_url":"https://api.github.com/repos/trademapper/trademapper-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trademapper/trademapper-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trademapper/trademapper-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/trademapper/trademapper-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trademapper/trademapper-js/statuses/{sha}","languages_url":"https://api.github.com/repos/trademapper/trademapper-js/languages","stargazers_url":"https://api.github.com/repos/trademapper/trademapper-js/stargazers","contributors_url":"https://api.github.com/repos/trademapper/trademapper-js/contributors","subscribers_url":"https://api.github.com/repos/trademapper/trademapper-js/subscribers","subscription_url":"https://api.github.com/repos/trademapper/trademapper-js/subscription","commits_url":"https://api.github.com/repos/trademapper/trademapper-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/trademapper/trademapper-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/trademapper/trademapper-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/trademapper/trademapper-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/trademapper/trademapper-js/contents/{+path}","compare_url":"https://api.github.com/repos/trademapper/trademapper-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trademapper/trademapper-js/merges","archive_url":"https://api.github.com/repos/trademapper/trademapper-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trademapper/trademapper-js/downloads","issues_url":"https://api.github.com/repos/trademapper/trademapper-js/issues{/number}","pulls_url":"https://api.github.com/repos/trademapper/trademapper-js/pulls{/number}","milestones_url":"https://api.github.com/repos/trademapper/trademapper-js/milestones{/number}","notifications_url":"https://api.github.com/repos/trademapper/trademapper-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trademapper/trademapper-js/labels{/name}","releases_url":"https://api.github.com/repos/trademapper/trademapper-js/releases{/id}","deployments_url":"https://api.github.com/repos/trademapper/trademapper-js/deployments","created_at":"2014-07-24T11:58:09Z","updated_at":"2018-11-13T14:09:29Z","pushed_at":"2018-11-29T19:04:14Z","git_url":"git://github.com/trademapper/trademapper-js.git","ssh_url":"git@github.com:trademapper/trademapper-js.git","clone_url":"https://github.com/trademapper/trademapper-js.git","svn_url":"https://github.com/trademapper/trademapper-js","homepage":null,"size":3626,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":36,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68"},"html":{"href":"https://github.com/trademapper/trademapper-js/pull/68"},"issue":{"href":"https://api.github.com/repos/trademapper/trademapper-js/issues/68"},"comments":{"href":"https://api.github.com/repos/trademapper/trademapper-js/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/trademapper/trademapper-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trademapper/trademapper-js/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/trademapper/trademapper-js/statuses/932697c1106afece8319fa40d54c77414735dce3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"townxelliot"}}