{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/240547856","pull_request_review_id":183581809,"id":240547856,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU0Nzg1Ng==","diff_hunk":"@@ -71,17 +71,27 @@ final class PNCounterMap[A] private[akka] (\n \n   def size: Int = underlying.size\n \n+  /**\n+   * Increment the counter by 1.\n+   */\n+  def increment(key: A)(implicit node: SelfUniqueAddress): PNCounterMap[A] =","path":"akka-distributed-data/src/main/scala/akka/cluster/ddata/PNCounterMap.scala","position":21,"original_position":21,"commit_id":"3fe920af494bb9bcbc0460a27a2d6c93120097ee","original_commit_id":"3fe920af494bb9bcbc0460a27a2d6c93120097ee","user":{"login":"patriknw","id":336161,"node_id":"MDQ6VXNlcjMzNjE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"missing `increment(key: A, delta: Long)`\r\n\r\nLet's skip the default param value of 1, i.e. change this one to `increment(key: A, delta: Long)`","created_at":"2018-12-11T10:15:47Z","updated_at":"2018-12-11T10:32:50Z","html_url":"https://github.com/akka/akka/pull/26074#discussion_r240547856","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/26074","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/240547856"},"html":{"href":"https://github.com/akka/akka/pull/26074#discussion_r240547856"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/26074"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/26074","id":236716099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzE2MDk5","html_url":"https://github.com/akka/akka/pull/26074","diff_url":"https://github.com/akka/akka/pull/26074.diff","patch_url":"https://github.com/akka/akka/pull/26074.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/26074","number":26074,"state":"open","locked":false,"title":"Typed Distributed Data requires untyped Cluster #25746","user":{"login":"helena","id":406103,"node_id":"MDQ6VXNlcjQwNjEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/406103?v=4","gravatar_id":"","url":"https://api.github.com/users/helena","html_url":"https://github.com/helena","followers_url":"https://api.github.com/users/helena/followers","following_url":"https://api.github.com/users/helena/following{/other_user}","gists_url":"https://api.github.com/users/helena/gists{/gist_id}","starred_url":"https://api.github.com/users/helena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena/subscriptions","organizations_url":"https://api.github.com/users/helena/orgs","repos_url":"https://api.github.com/users/helena/repos","events_url":"https://api.github.com/users/helena/events{/privacy}","received_events_url":"https://api.github.com/users/helena/received_events","type":"User","site_admin":false},"body":"[#25746](https://github.com/akka/akka/issues/25746)\r\n\r\nWas hoping to get this in for the release but review cycle, akka-docs updates to add, and I'll have to change these now since it's not going to make it in:\r\n```\r\n  @deprecated(\"...\", since = \"2.5.19\")\r\n```","created_at":"2018-12-07T00:17:10Z","updated_at":"2018-12-11T10:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6714892161a833c25555023506e33a9c948e9371","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johanandren","id":666915,"node_id":"MDQ6VXNlcjY2NjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/666915?v=4","gravatar_id":"","url":"https://api.github.com/users/johanandren","html_url":"https://github.com/johanandren","followers_url":"https://api.github.com/users/johanandren/followers","following_url":"https://api.github.com/users/johanandren/following{/other_user}","gists_url":"https://api.github.com/users/johanandren/gists{/gist_id}","starred_url":"https://api.github.com/users/johanandren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanandren/subscriptions","organizations_url":"https://api.github.com/users/johanandren/orgs","repos_url":"https://api.github.com/users/johanandren/repos","events_url":"https://api.github.com/users/johanandren/events{/privacy}","received_events_url":"https://api.github.com/users/johanandren/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":37797347,"node_id":"MDU6TGFiZWwzNzc5NzM0Nw==","url":"https://api.github.com/repos/akka/akka/labels/tested","name":"tested","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/26074/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/26074/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/26074/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/3fe920af494bb9bcbc0460a27a2d6c93120097ee","head":{"label":"helena:wip-typed-cluster-ddata2","ref":"wip-typed-cluster-ddata2","sha":"3fe920af494bb9bcbc0460a27a2d6c93120097ee","user":{"login":"helena","id":406103,"node_id":"MDQ6VXNlcjQwNjEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/406103?v=4","gravatar_id":"","url":"https://api.github.com/users/helena","html_url":"https://github.com/helena","followers_url":"https://api.github.com/users/helena/followers","following_url":"https://api.github.com/users/helena/following{/other_user}","gists_url":"https://api.github.com/users/helena/gists{/gist_id}","starred_url":"https://api.github.com/users/helena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena/subscriptions","organizations_url":"https://api.github.com/users/helena/orgs","repos_url":"https://api.github.com/users/helena/repos","events_url":"https://api.github.com/users/helena/events{/privacy}","received_events_url":"https://api.github.com/users/helena/received_events","type":"User","site_admin":false},"repo":{"id":3929870,"node_id":"MDEwOlJlcG9zaXRvcnkzOTI5ODcw","name":"akka","full_name":"helena/akka","private":false,"owner":{"login":"helena","id":406103,"node_id":"MDQ6VXNlcjQwNjEwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/406103?v=4","gravatar_id":"","url":"https://api.github.com/users/helena","html_url":"https://github.com/helena","followers_url":"https://api.github.com/users/helena/followers","following_url":"https://api.github.com/users/helena/following{/other_user}","gists_url":"https://api.github.com/users/helena/gists{/gist_id}","starred_url":"https://api.github.com/users/helena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena/subscriptions","organizations_url":"https://api.github.com/users/helena/orgs","repos_url":"https://api.github.com/users/helena/repos","events_url":"https://api.github.com/users/helena/events{/privacy}","received_events_url":"https://api.github.com/users/helena/received_events","type":"User","site_admin":false},"html_url":"https://github.com/helena/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/helena/akka","forks_url":"https://api.github.com/repos/helena/akka/forks","keys_url":"https://api.github.com/repos/helena/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helena/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helena/akka/teams","hooks_url":"https://api.github.com/repos/helena/akka/hooks","issue_events_url":"https://api.github.com/repos/helena/akka/issues/events{/number}","events_url":"https://api.github.com/repos/helena/akka/events","assignees_url":"https://api.github.com/repos/helena/akka/assignees{/user}","branches_url":"https://api.github.com/repos/helena/akka/branches{/branch}","tags_url":"https://api.github.com/repos/helena/akka/tags","blobs_url":"https://api.github.com/repos/helena/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helena/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helena/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/helena/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helena/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/helena/akka/languages","stargazers_url":"https://api.github.com/repos/helena/akka/stargazers","contributors_url":"https://api.github.com/repos/helena/akka/contributors","subscribers_url":"https://api.github.com/repos/helena/akka/subscribers","subscription_url":"https://api.github.com/repos/helena/akka/subscription","commits_url":"https://api.github.com/repos/helena/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/helena/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/helena/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/helena/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/helena/akka/contents/{+path}","compare_url":"https://api.github.com/repos/helena/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helena/akka/merges","archive_url":"https://api.github.com/repos/helena/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helena/akka/downloads","issues_url":"https://api.github.com/repos/helena/akka/issues{/number}","pulls_url":"https://api.github.com/repos/helena/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/helena/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/helena/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helena/akka/labels{/name}","releases_url":"https://api.github.com/repos/helena/akka/releases{/id}","deployments_url":"https://api.github.com/repos/helena/akka/deployments","created_at":"2012-04-04T15:02:32Z","updated_at":"2018-12-10T16:59:23Z","pushed_at":"2018-12-10T16:59:20Z","git_url":"git://github.com/helena/akka.git","ssh_url":"git@github.com:helena/akka.git","clone_url":"https://github.com/helena/akka.git","svn_url":"https://github.com/helena/akka","homepage":"http://akka.io","size":206459,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"712b72f64962cbc9c039eff221432d6234a398f8","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAwMTM=","name":"akka","full_name":"akka/akka","private":false,"owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2018-12-11T06:03:43Z","pushed_at":"2018-12-11T09:55:41Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":216338,"stargazers_count":9319,"watchers_count":9319,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2923,"mirror_url":null,"archived":false,"open_issues_count":833,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2923,"open_issues":833,"watchers":9319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/26074"},"html":{"href":"https://github.com/akka/akka/pull/26074"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/26074"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/26074/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/26074/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/26074/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/3fe920af494bb9bcbc0460a27a2d6c93120097ee"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"patriknw"}}