{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69584","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69584/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69584/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69584/events","html_url":"https://github.com/kubernetes/kubernetes/pull/69584","id":368346887,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTQ2MjI4","number":69584,"title":"[WIP] remove cloudprovider dependencies to pkg/api/v1/service","user":{"login":"andrewsykim","id":12699319,"node_id":"MDQ6VXNlcjEyNjk5MzE5","avatar_url":"https://avatars0.githubusercontent.com/u/12699319?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewsykim","html_url":"https://github.com/andrewsykim","followers_url":"https://api.github.com/users/andrewsykim/followers","following_url":"https://api.github.com/users/andrewsykim/following{/other_user}","gists_url":"https://api.github.com/users/andrewsykim/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewsykim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewsykim/subscriptions","organizations_url":"https://api.github.com/users/andrewsykim/orgs","repos_url":"https://api.github.com/users/andrewsykim/repos","events_url":"https://api.github.com/users/andrewsykim/events{/privacy}","received_events_url":"https://api.github.com/users/andrewsykim/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":122775691,"node_id":"MDU6TGFiZWwxMjI3NzU2OTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/cleanup","name":"kind/cleanup","color":"c7def8","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":958178286,"node_id":"MDU6TGFiZWw5NTgxNzgyODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cloud-provider","name":"sig/cloud-provider","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"cheftako","id":947971,"node_id":"MDQ6VXNlcjk0Nzk3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false},"assignees":[{"login":"cheftako","id":947971,"node_id":"MDQ6VXNlcjk0Nzk3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/947971?v=4","gravatar_id":"","url":"https://api.github.com/users/cheftako","html_url":"https://github.com/cheftako","followers_url":"https://api.github.com/users/cheftako/followers","following_url":"https://api.github.com/users/cheftako/following{/other_user}","gists_url":"https://api.github.com/users/cheftako/gists{/gist_id}","starred_url":"https://api.github.com/users/cheftako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheftako/subscriptions","organizations_url":"https://api.github.com/users/cheftako/orgs","repos_url":"https://api.github.com/users/cheftako/repos","events_url":"https://api.github.com/users/cheftako/events{/privacy}","received_events_url":"https://api.github.com/users/cheftako/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-09T18:49:31Z","updated_at":"2018-10-09T18:53:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/69584","html_url":"https://github.com/kubernetes/kubernetes/pull/69584","diff_url":"https://github.com/kubernetes/kubernetes/pull/69584.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/69584.patch"},"body":"**What this PR does / why we need it**:\r\nRemoves provider dependencies to `pkg/api/v1/service`.\r\n\r\n**Special notes for your reviewer**:\r\nEnded up duplicating some code in `pkg/api/v1/service/util.go` to `k8s.io/cloud-provider/utils`. I couldn't think of a better alternative around this so happy to discuss better options here. I'm also not sold on the package name `k8s.io/cloud-provider/utils`, happy to discuss alternatives :). \r\n\r\n**Release note**:\r\n```release-note\r\nremove cloudprovider dependencies to pkg/api/v1/service\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/428308784","html_url":"https://github.com/kubernetes/kubernetes/pull/69584#issuecomment-428308784","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/69584","id":428308784,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODMwODc4NA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T18:53:59Z","updated_at":"2018-10-09T18:53:59Z","author_association":"CONTRIBUTOR","body":"@andrewsykim: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-build | e2b58067bc197a98b2cd2073422d407536566514 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69584/pull-kubernetes-bazel-build/60339/) | `/test pull-kubernetes-bazel-build`\npull-kubernetes-bazel-test | e2b58067bc197a98b2cd2073422d407536566514 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69584/pull-kubernetes-bazel-test/62928/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | e2b58067bc197a98b2cd2073422d407536566514 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69584/pull-kubernetes-e2e-kops-aws/108767/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce | e2b58067bc197a98b2cd2073422d407536566514 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69584/pull-kubernetes-e2e-gce/55213/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | e2b58067bc197a98b2cd2073422d407536566514 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69584/pull-kubernetes-e2e-gce-device-plugin-gpu/49727/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-kubemark-e2e-gce-big | e2b58067bc197a98b2cd2073422d407536566514 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/69584/pull-kubernetes-kubemark-e2e-gce-big/24692/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/69584). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/andrewsykim). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}