{"action":"closed","number":54,"pull_request":{"url":"https://api.github.com/repos/aertslab/SCENIC/pulls/54","id":230283233,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjgzMjMz","html_url":"https://github.com/aertslab/SCENIC/pull/54","diff_url":"https://github.com/aertslab/SCENIC/pull/54.diff","patch_url":"https://github.com/aertslab/SCENIC/pull/54.patch","issue_url":"https://api.github.com/repos/aertslab/SCENIC/issues/54","number":54,"state":"closed","locked":false,"title":"Fixed problem with correlation added to tfModules in runSCENIC_1_coexNetwork2modules","user":{"login":"FloWuenne","id":11639154,"node_id":"MDQ6VXNlcjExNjM5MTU0","avatar_url":"https://avatars1.githubusercontent.com/u/11639154?v=4","gravatar_id":"","url":"https://api.github.com/users/FloWuenne","html_url":"https://github.com/FloWuenne","followers_url":"https://api.github.com/users/FloWuenne/followers","following_url":"https://api.github.com/users/FloWuenne/following{/other_user}","gists_url":"https://api.github.com/users/FloWuenne/gists{/gist_id}","starred_url":"https://api.github.com/users/FloWuenne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FloWuenne/subscriptions","organizations_url":"https://api.github.com/users/FloWuenne/orgs","repos_url":"https://api.github.com/users/FloWuenne/repos","events_url":"https://api.github.com/users/FloWuenne/events{/privacy}","received_events_url":"https://api.github.com/users/FloWuenne/received_events","type":"User","site_admin":false},"body":"Encountered an issue with `runSCENIC_1_coexNetwork2modules`.\r\nWhen subsetting the `corrMat` using the `targets` from the `tfModules`. If the target vector is handled as a factor, subsetting the `CorrMat` using the factor will result in wrong correlations being considered for the genes and classification of correlations between TF and genes (1,0 or -1) in the downstream table `tfModules_withCorr` will be wrong. This then directly affect the downstream enrichment analysis of TF motifs since \"wrong\" positive correlated genes would be considered. \r\n\r\nSetting the `targets` vector `as.character ` makes sure that the subset of genes from the correlation Matrix is correct.","created_at":"2018-11-12T22:06:37Z","updated_at":"2019-01-04T23:03:52Z","closed_at":"2019-01-04T23:03:52Z","merged_at":null,"merge_commit_sha":"fc7e08f0a1aaaec336759d4909437b22171103f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aertslab/SCENIC/pulls/54/commits","review_comments_url":"https://api.github.com/repos/aertslab/SCENIC/pulls/54/comments","review_comment_url":"https://api.github.com/repos/aertslab/SCENIC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aertslab/SCENIC/issues/54/comments","statuses_url":"https://api.github.com/repos/aertslab/SCENIC/statuses/912f52f237103744f46c8fdedb1dc866d2da74a3","head":{"label":"FloWuenne:master","ref":"master","sha":"912f52f237103744f46c8fdedb1dc866d2da74a3","user":{"login":"FloWuenne","id":11639154,"node_id":"MDQ6VXNlcjExNjM5MTU0","avatar_url":"https://avatars1.githubusercontent.com/u/11639154?v=4","gravatar_id":"","url":"https://api.github.com/users/FloWuenne","html_url":"https://github.com/FloWuenne","followers_url":"https://api.github.com/users/FloWuenne/followers","following_url":"https://api.github.com/users/FloWuenne/following{/other_user}","gists_url":"https://api.github.com/users/FloWuenne/gists{/gist_id}","starred_url":"https://api.github.com/users/FloWuenne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FloWuenne/subscriptions","organizations_url":"https://api.github.com/users/FloWuenne/orgs","repos_url":"https://api.github.com/users/FloWuenne/repos","events_url":"https://api.github.com/users/FloWuenne/events{/privacy}","received_events_url":"https://api.github.com/users/FloWuenne/received_events","type":"User","site_admin":false},"repo":{"id":157262432,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNjI0MzI=","name":"SCENIC","full_name":"FloWuenne/SCENIC","private":false,"owner":{"login":"FloWuenne","id":11639154,"node_id":"MDQ6VXNlcjExNjM5MTU0","avatar_url":"https://avatars1.githubusercontent.com/u/11639154?v=4","gravatar_id":"","url":"https://api.github.com/users/FloWuenne","html_url":"https://github.com/FloWuenne","followers_url":"https://api.github.com/users/FloWuenne/followers","following_url":"https://api.github.com/users/FloWuenne/following{/other_user}","gists_url":"https://api.github.com/users/FloWuenne/gists{/gist_id}","starred_url":"https://api.github.com/users/FloWuenne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FloWuenne/subscriptions","organizations_url":"https://api.github.com/users/FloWuenne/orgs","repos_url":"https://api.github.com/users/FloWuenne/repos","events_url":"https://api.github.com/users/FloWuenne/events{/privacy}","received_events_url":"https://api.github.com/users/FloWuenne/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FloWuenne/SCENIC","description":"SCENIC is an R package to infer Gene Regulatory Networks and cell types from single-cell RNA-seq data.","fork":true,"url":"https://api.github.com/repos/FloWuenne/SCENIC","forks_url":"https://api.github.com/repos/FloWuenne/SCENIC/forks","keys_url":"https://api.github.com/repos/FloWuenne/SCENIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FloWuenne/SCENIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FloWuenne/SCENIC/teams","hooks_url":"https://api.github.com/repos/FloWuenne/SCENIC/hooks","issue_events_url":"https://api.github.com/repos/FloWuenne/SCENIC/issues/events{/number}","events_url":"https://api.github.com/repos/FloWuenne/SCENIC/events","assignees_url":"https://api.github.com/repos/FloWuenne/SCENIC/assignees{/user}","branches_url":"https://api.github.com/repos/FloWuenne/SCENIC/branches{/branch}","tags_url":"https://api.github.com/repos/FloWuenne/SCENIC/tags","blobs_url":"https://api.github.com/repos/FloWuenne/SCENIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FloWuenne/SCENIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FloWuenne/SCENIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/FloWuenne/SCENIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FloWuenne/SCENIC/statuses/{sha}","languages_url":"https://api.github.com/repos/FloWuenne/SCENIC/languages","stargazers_url":"https://api.github.com/repos/FloWuenne/SCENIC/stargazers","contributors_url":"https://api.github.com/repos/FloWuenne/SCENIC/contributors","subscribers_url":"https://api.github.com/repos/FloWuenne/SCENIC/subscribers","subscription_url":"https://api.github.com/repos/FloWuenne/SCENIC/subscription","commits_url":"https://api.github.com/repos/FloWuenne/SCENIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/FloWuenne/SCENIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/FloWuenne/SCENIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/FloWuenne/SCENIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/FloWuenne/SCENIC/contents/{+path}","compare_url":"https://api.github.com/repos/FloWuenne/SCENIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FloWuenne/SCENIC/merges","archive_url":"https://api.github.com/repos/FloWuenne/SCENIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FloWuenne/SCENIC/downloads","issues_url":"https://api.github.com/repos/FloWuenne/SCENIC/issues{/number}","pulls_url":"https://api.github.com/repos/FloWuenne/SCENIC/pulls{/number}","milestones_url":"https://api.github.com/repos/FloWuenne/SCENIC/milestones{/number}","notifications_url":"https://api.github.com/repos/FloWuenne/SCENIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FloWuenne/SCENIC/labels{/name}","releases_url":"https://api.github.com/repos/FloWuenne/SCENIC/releases{/id}","deployments_url":"https://api.github.com/repos/FloWuenne/SCENIC/deployments","created_at":"2018-11-12T19:06:59Z","updated_at":"2018-11-13T18:06:38Z","pushed_at":"2018-11-16T16:42:20Z","git_url":"git://github.com/FloWuenne/SCENIC.git","ssh_url":"git@github.com:FloWuenne/SCENIC.git","clone_url":"https://github.com/FloWuenne/SCENIC.git","svn_url":"https://github.com/FloWuenne/SCENIC","homepage":"http://scenic.aertslab.org","size":267350,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aertslab:master","ref":"master","sha":"441b56204cd942f96bb9814cc0d7bb2cffa47497","user":{"login":"aertslab","id":3940817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDA4MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3940817?v=4","gravatar_id":"","url":"https://api.github.com/users/aertslab","html_url":"https://github.com/aertslab","followers_url":"https://api.github.com/users/aertslab/followers","following_url":"https://api.github.com/users/aertslab/following{/other_user}","gists_url":"https://api.github.com/users/aertslab/gists{/gist_id}","starred_url":"https://api.github.com/users/aertslab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aertslab/subscriptions","organizations_url":"https://api.github.com/users/aertslab/orgs","repos_url":"https://api.github.com/users/aertslab/repos","events_url":"https://api.github.com/users/aertslab/events{/privacy}","received_events_url":"https://api.github.com/users/aertslab/received_events","type":"Organization","site_admin":false},"repo":{"id":63242557,"node_id":"MDEwOlJlcG9zaXRvcnk2MzI0MjU1Nw==","name":"SCENIC","full_name":"aertslab/SCENIC","private":false,"owner":{"login":"aertslab","id":3940817,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDA4MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/3940817?v=4","gravatar_id":"","url":"https://api.github.com/users/aertslab","html_url":"https://github.com/aertslab","followers_url":"https://api.github.com/users/aertslab/followers","following_url":"https://api.github.com/users/aertslab/following{/other_user}","gists_url":"https://api.github.com/users/aertslab/gists{/gist_id}","starred_url":"https://api.github.com/users/aertslab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aertslab/subscriptions","organizations_url":"https://api.github.com/users/aertslab/orgs","repos_url":"https://api.github.com/users/aertslab/repos","events_url":"https://api.github.com/users/aertslab/events{/privacy}","received_events_url":"https://api.github.com/users/aertslab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aertslab/SCENIC","description":"SCENIC is an R package to infer Gene Regulatory Networks and cell types from single-cell RNA-seq data.","fork":false,"url":"https://api.github.com/repos/aertslab/SCENIC","forks_url":"https://api.github.com/repos/aertslab/SCENIC/forks","keys_url":"https://api.github.com/repos/aertslab/SCENIC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aertslab/SCENIC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aertslab/SCENIC/teams","hooks_url":"https://api.github.com/repos/aertslab/SCENIC/hooks","issue_events_url":"https://api.github.com/repos/aertslab/SCENIC/issues/events{/number}","events_url":"https://api.github.com/repos/aertslab/SCENIC/events","assignees_url":"https://api.github.com/repos/aertslab/SCENIC/assignees{/user}","branches_url":"https://api.github.com/repos/aertslab/SCENIC/branches{/branch}","tags_url":"https://api.github.com/repos/aertslab/SCENIC/tags","blobs_url":"https://api.github.com/repos/aertslab/SCENIC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aertslab/SCENIC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aertslab/SCENIC/git/refs{/sha}","trees_url":"https://api.github.com/repos/aertslab/SCENIC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aertslab/SCENIC/statuses/{sha}","languages_url":"https://api.github.com/repos/aertslab/SCENIC/languages","stargazers_url":"https://api.github.com/repos/aertslab/SCENIC/stargazers","contributors_url":"https://api.github.com/repos/aertslab/SCENIC/contributors","subscribers_url":"https://api.github.com/repos/aertslab/SCENIC/subscribers","subscription_url":"https://api.github.com/repos/aertslab/SCENIC/subscription","commits_url":"https://api.github.com/repos/aertslab/SCENIC/commits{/sha}","git_commits_url":"https://api.github.com/repos/aertslab/SCENIC/git/commits{/sha}","comments_url":"https://api.github.com/repos/aertslab/SCENIC/comments{/number}","issue_comment_url":"https://api.github.com/repos/aertslab/SCENIC/issues/comments{/number}","contents_url":"https://api.github.com/repos/aertslab/SCENIC/contents/{+path}","compare_url":"https://api.github.com/repos/aertslab/SCENIC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aertslab/SCENIC/merges","archive_url":"https://api.github.com/repos/aertslab/SCENIC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aertslab/SCENIC/downloads","issues_url":"https://api.github.com/repos/aertslab/SCENIC/issues{/number}","pulls_url":"https://api.github.com/repos/aertslab/SCENIC/pulls{/number}","milestones_url":"https://api.github.com/repos/aertslab/SCENIC/milestones{/number}","notifications_url":"https://api.github.com/repos/aertslab/SCENIC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aertslab/SCENIC/labels{/name}","releases_url":"https://api.github.com/repos/aertslab/SCENIC/releases{/id}","deployments_url":"https://api.github.com/repos/aertslab/SCENIC/deployments","created_at":"2016-07-13T12:04:50Z","updated_at":"2019-01-03T08:16:11Z","pushed_at":"2018-11-13T18:06:37Z","git_url":"git://github.com/aertslab/SCENIC.git","ssh_url":"git@github.com:aertslab/SCENIC.git","clone_url":"https://github.com/aertslab/SCENIC.git","svn_url":"https://github.com/aertslab/SCENIC","homepage":"http://scenic.aertslab.org","size":267505,"stargazers_count":47,"watchers_count":47,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":32,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aertslab/SCENIC/pulls/54"},"html":{"href":"https://github.com/aertslab/SCENIC/pull/54"},"issue":{"href":"https://api.github.com/repos/aertslab/SCENIC/issues/54"},"comments":{"href":"https://api.github.com/repos/aertslab/SCENIC/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/aertslab/SCENIC/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/aertslab/SCENIC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aertslab/SCENIC/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/aertslab/SCENIC/statuses/912f52f237103744f46c8fdedb1dc866d2da74a3"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"FloWuenne"}}