{"action":"created","comment":{"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments/186567703","pull_request_review_id":118172814,"id":186567703,"diff_hunk":"@@ -44,21 +58,21 @@ func (p *packetHandler) NextFrame() (rpcMessage, error) {\n \n \t// Interpret the byte as the length field of a fixarray of up\n \t// to 15 elements: see\n-\t// https://github.com/msgpack/msgpack/blob/master/spec.md#formats-array\n-\t// . Do this so we can decode directly into the expected\n-\t// fields without copying.\n+\t// https://github.com/msgpack/msgpack/blob/master/spec.md#formats-array .","path":"rpc/packetizer.go","position":null,"original_position":55,"commit_id":"b751dcede916ed8eedf8c6071c082d4f6bfd2ddd","original_commit_id":"79c5961902c6b29d45caf16d3f2de080df940d8b","user":{"login":"akalin-keybase","id":13270622,"avatar_url":"https://avatars3.githubusercontent.com/u/13270622?v=4","gravatar_id":"","url":"https://api.github.com/users/akalin-keybase","html_url":"https://github.com/akalin-keybase","followers_url":"https://api.github.com/users/akalin-keybase/followers","following_url":"https://api.github.com/users/akalin-keybase/following{/other_user}","gists_url":"https://api.github.com/users/akalin-keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/akalin-keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalin-keybase/subscriptions","organizations_url":"https://api.github.com/users/akalin-keybase/orgs","repos_url":"https://api.github.com/users/akalin-keybase/repos","events_url":"https://api.github.com/users/akalin-keybase/events{/privacy}","received_events_url":"https://api.github.com/users/akalin-keybase/received_events","type":"User","site_admin":false},"body":"I try not to end a sentence with a URL and punctuation, since the punctuation can be interpreted as part of the URL. Changed the wording slightly instead.","created_at":"2018-05-07T22:18:01Z","updated_at":"2018-05-07T22:18:01Z","html_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/144#discussion_r186567703","pull_request_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments/186567703"},"html":{"href":"https://github.com/keybase/go-framed-msgpack-rpc/pull/144#discussion_r186567703"},"pull_request":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144"}},"in_reply_to_id":184543635},"pull_request":{"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144","id":177959016,"html_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/144","diff_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/144.diff","patch_url":"https://github.com/keybase/go-framed-msgpack-rpc/pull/144.patch","issue_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/144","number":144,"state":"open","locked":false,"title":"Make dependence on go-codec explicit","user":{"login":"akalin-keybase","id":13270622,"avatar_url":"https://avatars3.githubusercontent.com/u/13270622?v=4","gravatar_id":"","url":"https://api.github.com/users/akalin-keybase","html_url":"https://github.com/akalin-keybase","followers_url":"https://api.github.com/users/akalin-keybase/followers","following_url":"https://api.github.com/users/akalin-keybase/following{/other_user}","gists_url":"https://api.github.com/users/akalin-keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/akalin-keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akalin-keybase/subscriptions","organizations_url":"https://api.github.com/users/akalin-keybase/orgs","repos_url":"https://api.github.com/users/akalin-keybase/repos","events_url":"https://api.github.com/users/akalin-keybase/events{/privacy}","received_events_url":"https://api.github.com/users/akalin-keybase/received_events","type":"User","site_admin":false},"body":"Document exactly how we rely on codec.Decoder's behavior. Relax our\r\ntests correspondingly.\r\n\r\nRemove the unneeded decoder interface.\r\n\r\nAdd packetizer tests.","created_at":"2018-03-28T08:07:23Z","updated_at":"2018-05-07T22:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0aa499c59848ba3ff8b65f2d4e15ca7345955bd8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144/commits","review_comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144/comments","review_comment_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/144/comments","statuses_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/b751dcede916ed8eedf8c6071c082d4f6bfd2ddd","head":{"label":"keybase:akalin/codec-behavior","ref":"akalin/codec-behavior","sha":"b751dcede916ed8eedf8c6071c082d4f6bfd2ddd","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":43102191,"name":"go-framed-msgpack-rpc","full_name":"keybase/go-framed-msgpack-rpc","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/go-framed-msgpack-rpc","description":"Framed RPC for go","fork":true,"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc","forks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/forks","keys_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/teams","hooks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/hooks","issue_events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/events","assignees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/tags","blobs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/languages","stargazers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/stargazers","contributors_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contributors","subscribers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscribers","subscription_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscription","commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/merges","archive_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/downloads","issues_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/labels{/name}","releases_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/deployments","created_at":"2015-09-25T01:19:58Z","updated_at":"2018-03-27T15:22:10Z","pushed_at":"2018-05-07T22:16:41Z","git_url":"git://github.com/keybase/go-framed-msgpack-rpc.git","ssh_url":"git@github.com:keybase/go-framed-msgpack-rpc.git","clone_url":"https://github.com/keybase/go-framed-msgpack-rpc.git","svn_url":"https://github.com/keybase/go-framed-msgpack-rpc","homepage":null,"size":413,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"keybase:master","ref":"master","sha":"e74f657d091fb4320a6dd7dac6b8eb7ff4ddb35f","user":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"repo":{"id":43102191,"name":"go-framed-msgpack-rpc","full_name":"keybase/go-framed-msgpack-rpc","owner":{"login":"keybase","id":5400834,"avatar_url":"https://avatars2.githubusercontent.com/u/5400834?v=4","gravatar_id":"","url":"https://api.github.com/users/keybase","html_url":"https://github.com/keybase","followers_url":"https://api.github.com/users/keybase/followers","following_url":"https://api.github.com/users/keybase/following{/other_user}","gists_url":"https://api.github.com/users/keybase/gists{/gist_id}","starred_url":"https://api.github.com/users/keybase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keybase/subscriptions","organizations_url":"https://api.github.com/users/keybase/orgs","repos_url":"https://api.github.com/users/keybase/repos","events_url":"https://api.github.com/users/keybase/events{/privacy}","received_events_url":"https://api.github.com/users/keybase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/keybase/go-framed-msgpack-rpc","description":"Framed RPC for go","fork":true,"url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc","forks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/forks","keys_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/teams","hooks_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/hooks","issue_events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/events{/number}","events_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/events","assignees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/assignees{/user}","branches_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/branches{/branch}","tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/tags","blobs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/{sha}","languages_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/languages","stargazers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/stargazers","contributors_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contributors","subscribers_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscribers","subscription_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/subscription","commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/contents/{+path}","compare_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/merges","archive_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/downloads","issues_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues{/number}","pulls_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls{/number}","milestones_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/milestones{/number}","notifications_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/labels{/name}","releases_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/releases{/id}","deployments_url":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/deployments","created_at":"2015-09-25T01:19:58Z","updated_at":"2018-03-27T15:22:10Z","pushed_at":"2018-05-07T22:16:41Z","git_url":"git://github.com/keybase/go-framed-msgpack-rpc.git","ssh_url":"git@github.com:keybase/go-framed-msgpack-rpc.git","clone_url":"https://github.com/keybase/go-framed-msgpack-rpc.git","svn_url":"https://github.com/keybase/go-framed-msgpack-rpc","homepage":null,"size":413,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144"},"html":{"href":"https://github.com/keybase/go-framed-msgpack-rpc/pull/144"},"issue":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/144"},"comments":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/keybase/go-framed-msgpack-rpc/statuses/b751dcede916ed8eedf8c6071c082d4f6bfd2ddd"}},"author_association":"NONE"}}
{"actor":{"display_login":"akalin-keybase"}}