{"action":"opened","issue":{"url":"https://api.github.com/repos/fabric8-analytics/fabric8-analytics-jobs/issues/302","repository_url":"https://api.github.com/repos/fabric8-analytics/fabric8-analytics-jobs","labels_url":"https://api.github.com/repos/fabric8-analytics/fabric8-analytics-jobs/issues/302/labels{/name}","comments_url":"https://api.github.com/repos/fabric8-analytics/fabric8-analytics-jobs/issues/302/comments","events_url":"https://api.github.com/repos/fabric8-analytics/fabric8-analytics-jobs/issues/302/events","html_url":"https://github.com/fabric8-analytics/fabric8-analytics-jobs/issues/302","id":356774218,"node_id":"MDU6SXNzdWUzNTY3NzQyMTg=","number":302,"title":"Unused parameter found in the GitHubMostStarred.execute method","user":{"login":"tisnik","id":4579967,"node_id":"MDQ6VXNlcjQ1Nzk5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/4579967?v=4","gravatar_id":"","url":"https://api.github.com/users/tisnik","html_url":"https://github.com/tisnik","followers_url":"https://api.github.com/users/tisnik/followers","following_url":"https://api.github.com/users/tisnik/following{/other_user}","gists_url":"https://api.github.com/users/tisnik/gists{/gist_id}","starred_url":"https://api.github.com/users/tisnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tisnik/subscriptions","organizations_url":"https://api.github.com/users/tisnik/orgs","repos_url":"https://api.github.com/users/tisnik/repos","events_url":"https://api.github.com/users/tisnik/events{/privacy}","received_events_url":"https://api.github.com/users/tisnik/received_events","type":"User","site_admin":false},"labels":[{"id":593969571,"node_id":"MDU6TGFiZWw1OTM5Njk1NzE=","url":"https://api.github.com/repos/fabric8-analytics/fabric8-analytics-jobs/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-04T11:49:31Z","updated_at":"2018-09-04T11:49:31Z","closed_at":null,"author_association":"MEMBER","body":"The parameter `popular` is never used in the `GitHubMostStarred.execute`:\r\n```\r\nf8a_jobs/handlers/github_most_starred.py\r\nf8a_jobs/handlers/github_most_starred.py:95: unused variable 'popular' (100% confidence)\r\n```\r\n\r\nThis is kinda strange as the parameter seems to have a good meaning:\r\n\r\n```\r\n    def execute(self, ecosystem, popular=True, count=None, nversions=None, force=False,\r\n                recursive_limit=None, min_stars=None, max_stars=None, skip_if_exists=True,\r\n                start_from=0):\r\n        \"\"\"Process the parameters and start analyses on the most-starred GitHub projects.\r\n\r\n        :param ecosystem: ecosystem name\r\n        :param popular: boolean, sort index by popularity\r\n```"}}
{"actor":{"display_login":"tisnik"}}