{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/beats/pulls/comments/208750502","pull_request_review_id":144626358,"id":208750502,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc1MDUwMg==","diff_hunk":"@@ -115,20 +115,42 @@ var IsDuration = Is(\"is a duration\", func(path Path, v interface{}) *Results {\n \t)\n })\n \n-// IsEqual tests that the given object is equal to the actual object.\n-func IsEqual(to interface{}) IsDef {\n-\treturn Is(\"equals\", func(path Path, v interface{}) *Results {\n-\t\tif reflect.DeepEqual(v, to) {\n+func IsEqualTime(to time.Time) IsDef {","path":"libbeat/common/mapval/is_defs.go","position":8,"original_position":8,"commit_id":"42635d503812c888d6d83d75e1e098b2375440ea","original_commit_id":"42635d503812c888d6d83d75e1e098b2375440ea","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"exported function IsEqualTime should have comment or be unexported","created_at":"2018-08-08T22:02:10Z","updated_at":"2018-08-08T22:02:10Z","html_url":"https://github.com/elastic/beats/pull/7545#discussion_r208750502","pull_request_url":"https://api.github.com/repos/elastic/beats/pulls/7545","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments/208750502"},"html":{"href":"https://github.com/elastic/beats/pull/7545#discussion_r208750502"},"pull_request":{"href":"https://api.github.com/repos/elastic/beats/pulls/7545"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/beats/pulls/7545","id":200120297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTIwMjk3","html_url":"https://github.com/elastic/beats/pull/7545","diff_url":"https://github.com/elastic/beats/pull/7545.diff","patch_url":"https://github.com/elastic/beats/pull/7545.patch","issue_url":"https://api.github.com/repos/elastic/beats/issues/7545","number":7545,"state":"open","locked":false,"title":"[WIP] Work on TLS metadata","user":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"WIP Work toward adding extra TLS metadata. Would resolve #6300 and #3741 once complete. \r\n\r\nThe PR is based off of #7784 , hence the large diff. We should wait for that to merge before reviewing this further.\r\n\r\nI'm submitting this PR early to get feedback from @urso on this approach to injecting the TLS metadata into the dialchain. The code is very rough, but I wanted to get feedback early before I start adding tests and rounding this out.\r\n\r\nAnother goal of this PR would be to add tests to the namespaces and types this PR touches. Heartbeat needs more tests and the strategy here is to add a feature, and retroactively add tests alongside it.\r\n\r\nOne thing we might also want to consider is that there is shared code for the dialchain in `libbeat/outputs/transport` that probably should just move up a level to `libbeat/transport`.\r\n\r\n","created_at":"2018-07-09T14:36:27Z","updated_at":"2018-08-08T22:02:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2887f4c63bd7e29e1d306e78c415426acbd62be3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":459123149,"node_id":"MDU6TGFiZWw0NTkxMjMxNDk=","url":"https://api.github.com/repos/elastic/beats/labels/Heartbeat","name":"Heartbeat","color":"008000","default":false},{"id":216798909,"node_id":"MDU6TGFiZWwyMTY3OTg5MDk=","url":"https://api.github.com/repos/elastic/beats/labels/in%20progress","name":"in progress","color":"207de5","default":false},{"id":360512612,"node_id":"MDU6TGFiZWwzNjA1MTI2MTI=","url":"https://api.github.com/repos/elastic/beats/labels/needs%20tests","name":"needs tests","color":"cc317c","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/beats/pulls/7545/commits","review_comments_url":"https://api.github.com/repos/elastic/beats/pulls/7545/comments","review_comment_url":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/beats/issues/7545/comments","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/42635d503812c888d6d83d75e1e098b2375440ea","head":{"label":"andrewvc:work-on-extended-tls-data","ref":"work-on-extended-tls-data","sha":"42635d503812c888d6d83d75e1e098b2375440ea","user":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":119769836,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3Njk4MzY=","name":"beats","full_name":"andrewvc/beats","owner":{"login":"andrewvc","id":131427,"node_id":"MDQ6VXNlcjEzMTQyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/131427?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":true,"url":"https://api.github.com/repos/andrewvc/beats","forks_url":"https://api.github.com/repos/andrewvc/beats/forks","keys_url":"https://api.github.com/repos/andrewvc/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/beats/teams","hooks_url":"https://api.github.com/repos/andrewvc/beats/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/beats/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/beats/events","assignees_url":"https://api.github.com/repos/andrewvc/beats/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/beats/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/beats/tags","blobs_url":"https://api.github.com/repos/andrewvc/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/beats/languages","stargazers_url":"https://api.github.com/repos/andrewvc/beats/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/beats/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/beats/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/beats/subscription","commits_url":"https://api.github.com/repos/andrewvc/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/beats/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/beats/merges","archive_url":"https://api.github.com/repos/andrewvc/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/beats/downloads","issues_url":"https://api.github.com/repos/andrewvc/beats/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/beats/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/beats/releases{/id}","deployments_url":"https://api.github.com/repos/andrewvc/beats/deployments","created_at":"2018-02-01T02:11:47Z","updated_at":"2018-02-01T02:11:55Z","pushed_at":"2018-08-08T22:01:56Z","git_url":"git://github.com/andrewvc/beats.git","ssh_url":"git@github.com:andrewvc/beats.git","clone_url":"https://github.com/andrewvc/beats.git","svn_url":"https://github.com/andrewvc/beats","homepage":"https://www.elastic.co/products/beats","size":86091,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"c4e7b13c90e4183ccc14a5255826e158470b7394","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":16554739,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU1NDczOQ==","name":"beats","full_name":"elastic/beats","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/beats","description":":tropical_fish: Beats - Lightweight shippers for Elasticsearch & Logstash ","fork":false,"url":"https://api.github.com/repos/elastic/beats","forks_url":"https://api.github.com/repos/elastic/beats/forks","keys_url":"https://api.github.com/repos/elastic/beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/beats/teams","hooks_url":"https://api.github.com/repos/elastic/beats/hooks","issue_events_url":"https://api.github.com/repos/elastic/beats/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/beats/events","assignees_url":"https://api.github.com/repos/elastic/beats/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/beats/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/beats/tags","blobs_url":"https://api.github.com/repos/elastic/beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/beats/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/beats/languages","stargazers_url":"https://api.github.com/repos/elastic/beats/stargazers","contributors_url":"https://api.github.com/repos/elastic/beats/contributors","subscribers_url":"https://api.github.com/repos/elastic/beats/subscribers","subscription_url":"https://api.github.com/repos/elastic/beats/subscription","commits_url":"https://api.github.com/repos/elastic/beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/beats/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/beats/merges","archive_url":"https://api.github.com/repos/elastic/beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/beats/downloads","issues_url":"https://api.github.com/repos/elastic/beats/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/beats/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/beats/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/beats/labels{/name}","releases_url":"https://api.github.com/repos/elastic/beats/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/beats/deployments","created_at":"2014-02-05T19:01:02Z","updated_at":"2018-08-08T18:08:44Z","pushed_at":"2018-08-08T22:01:59Z","git_url":"git://github.com/elastic/beats.git","ssh_url":"git@github.com:elastic/beats.git","clone_url":"https://github.com/elastic/beats.git","svn_url":"https://github.com/elastic/beats","homepage":"https://www.elastic.co/products/beats","size":87577,"stargazers_count":5951,"watchers_count":5951,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1838,"mirror_url":null,"archived":false,"open_issues_count":882,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1838,"open_issues":882,"watchers":5951,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/beats/pulls/7545"},"html":{"href":"https://github.com/elastic/beats/pull/7545"},"issue":{"href":"https://api.github.com/repos/elastic/beats/issues/7545"},"comments":{"href":"https://api.github.com/repos/elastic/beats/issues/7545/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/beats/pulls/7545/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/beats/pulls/7545/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/beats/statuses/42635d503812c888d6d83d75e1e098b2375440ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}