{"action":"created","comment":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments/200475836","pull_request_review_id":134801295,"id":200475836,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQ3NTgzNg==","diff_hunk":"@@ -44,4 +44,9 @@ contract(\"ZeroExExchangeWrapper\", (accounts) => {\n       { from: ownerAccount },\n     );\n   });\n+\n+  describe(\"#exchange\", async () => {","path":"test/core/external/zeroExExchangeWrapper.spec.ts","position":5,"original_position":5,"commit_id":"e3caa5cb205673e23c1d749dc434a14c04349312","original_commit_id":"e3caa5cb205673e23c1d749dc434a14c04349312","user":{"login":"asoong","id":3453571,"node_id":"MDQ6VXNlcjM0NTM1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3453571?v=4","gravatar_id":"","url":"https://api.github.com/users/asoong","html_url":"https://github.com/asoong","followers_url":"https://api.github.com/users/asoong/followers","following_url":"https://api.github.com/users/asoong/following{/other_user}","gists_url":"https://api.github.com/users/asoong/gists{/gist_id}","starred_url":"https://api.github.com/users/asoong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asoong/subscriptions","organizations_url":"https://api.github.com/users/asoong/orgs","repos_url":"https://api.github.com/users/asoong/repos","events_url":"https://api.github.com/users/asoong/events{/privacy}","received_events_url":"https://api.github.com/users/asoong/received_events","type":"User","site_admin":false},"body":"?","created_at":"2018-07-05T20:11:12Z","updated_at":"2018-07-05T20:11:58Z","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/89#discussion_r200475836","pull_request_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments/200475836"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/89#discussion_r200475836"},"pull_request":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89"}}},"pull_request":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89","id":199385449,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Mzg1NDQ5","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/89","diff_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/89.diff","patch_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/89.patch","issue_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/89","number":89,"state":"open","locked":false,"title":"Exchange Wrapper Set Up","user":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"body":"- Add Exchange Wrapper contracts\r\n- Add parsing of makerAsset\r\n- Lots of test helpers with creating order data","created_at":"2018-07-05T07:51:30Z","updated_at":"2018-07-05T20:11:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff5384b64bfcda4a3bc2fa231309808faad5fde3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89/commits","review_comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89/comments","review_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/89/comments","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/e3caa5cb205673e23c1d749dc434a14c04349312","head":{"label":"SetProtocol:felix/0x-wrapper","ref":"felix/0x-wrapper","sha":"e3caa5cb205673e23c1d749dc434a14c04349312","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"{Set} Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-07-05T05:33:51Z","pushed_at":"2018-07-05T19:01:48Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"","size":1574,"stargazers_count":57,"watchers_count":57,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":7,"watchers":57,"default_branch":"master"}},"base":{"label":"SetProtocol:master","ref":"master","sha":"f602be4c9d6d1b4890fb2fedbe40b00a472d8725","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"{Set} Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-07-05T05:33:51Z","pushed_at":"2018-07-05T19:01:48Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"","size":1574,"stargazers_count":57,"watchers_count":57,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":7,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/89"},"issue":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/89"},"comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/89/comments"},"review_comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89/comments"},"review_comment":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/89/commits"},"statuses":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/e3caa5cb205673e23c1d749dc434a14c04349312"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"asoong"}}