{"action":"created","issue":{"url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/issues/1","repository_url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet","labels_url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/issues/1/comments","events_url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/issues/1/events","html_url":"https://github.com/FoundatioFx/Foundatio.Storage.SshNet/pull/1","id":385655705,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTc0MjU4","number":1,"title":"unescape username & password in shh connection","user":{"login":"naishx","id":13622683,"node_id":"MDQ6VXNlcjEzNjIyNjgz","avatar_url":"https://avatars1.githubusercontent.com/u/13622683?v=4","gravatar_id":"","url":"https://api.github.com/users/naishx","html_url":"https://github.com/naishx","followers_url":"https://api.github.com/users/naishx/followers","following_url":"https://api.github.com/users/naishx/following{/other_user}","gists_url":"https://api.github.com/users/naishx/gists{/gist_id}","starred_url":"https://api.github.com/users/naishx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naishx/subscriptions","organizations_url":"https://api.github.com/users/naishx/orgs","repos_url":"https://api.github.com/users/naishx/repos","events_url":"https://api.github.com/users/naishx/events{/privacy}","received_events_url":"https://api.github.com/users/naishx/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-11-29T10:00:50Z","updated_at":"2018-11-30T12:23:20Z","closed_at":"2018-11-30T12:22:26Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/pulls/1","html_url":"https://github.com/FoundatioFx/Foundatio.Storage.SshNet/pull/1","diff_url":"https://github.com/FoundatioFx/Foundatio.Storage.SshNet/pull/1.diff","patch_url":"https://github.com/FoundatioFx/Foundatio.Storage.SshNet/pull/1.patch"},"body":"added Uri.UnescapeDataString for ssh username and passwort in ssh connection. So it's possible to use domain username.\r\n\r\nExample :\r\n\r\n```\r\nvar usernameWithDomain = Uri.EscapeDataString(@\"domain\\bob\");\r\nvar sshConnectionString = \"ssh://\" + usernameWithDomain + \":password@host\";\r\n```\r\n\r\nWill create:\r\n\"ssh://domain%5Cbob:password@host\"\r\n\r\nBefore this change the methode CreateConnectionInfo() did not unescape username and password, so you could not connect."},"comment":{"url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/issues/comments/443188283","html_url":"https://github.com/FoundatioFx/Foundatio.Storage.SshNet/pull/1#issuecomment-443188283","issue_url":"https://api.github.com/repos/FoundatioFx/Foundatio.Storage.SshNet/issues/1","id":443188283,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzE4ODI4Mw==","user":{"login":"niemyjski","id":1020579,"node_id":"MDQ6VXNlcjEwMjA1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1020579?v=4","gravatar_id":"","url":"https://api.github.com/users/niemyjski","html_url":"https://github.com/niemyjski","followers_url":"https://api.github.com/users/niemyjski/followers","following_url":"https://api.github.com/users/niemyjski/following{/other_user}","gists_url":"https://api.github.com/users/niemyjski/gists{/gist_id}","starred_url":"https://api.github.com/users/niemyjski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niemyjski/subscriptions","organizations_url":"https://api.github.com/users/niemyjski/orgs","repos_url":"https://api.github.com/users/niemyjski/repos","events_url":"https://api.github.com/users/niemyjski/events{/privacy}","received_events_url":"https://api.github.com/users/niemyjski/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T12:23:20Z","updated_at":"2018-11-30T12:23:20Z","author_association":"MEMBER","body":"It should be shortly (by next week I'd think), we've been making some changes to the storage interface to make paging lots easier for file lists. In the mean time we have nightly builds that get pushed out to myget."}}
{"actor":{"display_login":"niemyjski"}}