{"action":"created","comment":{"url":"https://api.github.com/repos/keras-team/keras/pulls/comments/245324783","pull_request_review_id":189403258,"id":245324783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTMyNDc4Mw==","diff_hunk":"@@ -1267,6 +1267,14 @@ def __init__(self, units,\n \n     def build(self, input_shape):\n         input_dim = input_shape[-1]\n+\n+        if type(self.recurrent_initializer).__name__ == 'Identity':","path":"keras/layers/recurrent.py","position":5,"original_position":5,"commit_id":"8598b76f979bf28990a6ae9a6ddd085860323f8b","original_commit_id":"8598b76f979bf28990a6ae9a6ddd085860323f8b","user":{"login":"RaphaelMeudec","id":12402673,"node_id":"MDQ6VXNlcjEyNDAyNjcz","avatar_url":"https://avatars3.githubusercontent.com/u/12402673?v=4","gravatar_id":"","url":"https://api.github.com/users/RaphaelMeudec","html_url":"https://github.com/RaphaelMeudec","followers_url":"https://api.github.com/users/RaphaelMeudec/followers","following_url":"https://api.github.com/users/RaphaelMeudec/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelMeudec/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelMeudec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelMeudec/subscriptions","organizations_url":"https://api.github.com/users/RaphaelMeudec/orgs","repos_url":"https://api.github.com/users/RaphaelMeudec/repos","events_url":"https://api.github.com/users/RaphaelMeudec/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelMeudec/received_events","type":"User","site_admin":false},"body":"By checking on the input shape ratio given to the build method?","created_at":"2019-01-04T15:13:52Z","updated_at":"2019-01-04T15:13:52Z","html_url":"https://github.com/keras-team/keras/pull/11887#discussion_r245324783","pull_request_url":"https://api.github.com/repos/keras-team/keras/pulls/11887","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/keras-team/keras/pulls/comments/245324783"},"html":{"href":"https://github.com/keras-team/keras/pull/11887#discussion_r245324783"},"pull_request":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11887"}},"in_reply_to_id":245317727},"pull_request":{"url":"https://api.github.com/repos/keras-team/keras/pulls/11887","id":239228461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjI4NDYx","html_url":"https://github.com/keras-team/keras/pull/11887","diff_url":"https://github.com/keras-team/keras/pull/11887.diff","patch_url":"https://github.com/keras-team/keras/pull/11887.patch","issue_url":"https://api.github.com/repos/keras-team/keras/issues/11887","number":11887,"state":"open","locked":false,"title":"Identity initializer with zero padding","user":{"login":"RaphaelMeudec","id":12402673,"node_id":"MDQ6VXNlcjEyNDAyNjcz","avatar_url":"https://avatars3.githubusercontent.com/u/12402673?v=4","gravatar_id":"","url":"https://api.github.com/users/RaphaelMeudec","html_url":"https://github.com/RaphaelMeudec","followers_url":"https://api.github.com/users/RaphaelMeudec/followers","following_url":"https://api.github.com/users/RaphaelMeudec/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelMeudec/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelMeudec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelMeudec/subscriptions","organizations_url":"https://api.github.com/users/RaphaelMeudec/orgs","repos_url":"https://api.github.com/users/RaphaelMeudec/repos","events_url":"https://api.github.com/users/RaphaelMeudec/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelMeudec/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nThis PR changes the behaviour of `initializers.Identity` to match Tensorflow's behaviour (pad with 0s if matrix is not square)\r\n\r\n### Related Issues\r\n\r\n#11774 \r\n\r\n### PR Overview\r\n\r\n- [n] This PR requires new unit tests [y/n] (make sure tests are included) -> tests have been updated but no new tests required\r\n- [y] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)\r\n- [y] This PR is backwards compatible [y/n]\r\n- [n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)\r\n","created_at":"2018-12-17T17:38:55Z","updated_at":"2019-01-04T15:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc530af339a12517061ade48d57514e6a6a62119","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keras-team/keras/pulls/11887/commits","review_comments_url":"https://api.github.com/repos/keras-team/keras/pulls/11887/comments","review_comment_url":"https://api.github.com/repos/keras-team/keras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keras-team/keras/issues/11887/comments","statuses_url":"https://api.github.com/repos/keras-team/keras/statuses/8598b76f979bf28990a6ae9a6ddd085860323f8b","head":{"label":"RaphaelMeudec:identity-initializer-with-zero-padding","ref":"identity-initializer-with-zero-padding","sha":"8598b76f979bf28990a6ae9a6ddd085860323f8b","user":{"login":"RaphaelMeudec","id":12402673,"node_id":"MDQ6VXNlcjEyNDAyNjcz","avatar_url":"https://avatars3.githubusercontent.com/u/12402673?v=4","gravatar_id":"","url":"https://api.github.com/users/RaphaelMeudec","html_url":"https://github.com/RaphaelMeudec","followers_url":"https://api.github.com/users/RaphaelMeudec/followers","following_url":"https://api.github.com/users/RaphaelMeudec/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelMeudec/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelMeudec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelMeudec/subscriptions","organizations_url":"https://api.github.com/users/RaphaelMeudec/orgs","repos_url":"https://api.github.com/users/RaphaelMeudec/repos","events_url":"https://api.github.com/users/RaphaelMeudec/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelMeudec/received_events","type":"User","site_admin":false},"repo":{"id":162164154,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxNjQxNTQ=","name":"keras","full_name":"RaphaelMeudec/keras","private":false,"owner":{"login":"RaphaelMeudec","id":12402673,"node_id":"MDQ6VXNlcjEyNDAyNjcz","avatar_url":"https://avatars3.githubusercontent.com/u/12402673?v=4","gravatar_id":"","url":"https://api.github.com/users/RaphaelMeudec","html_url":"https://github.com/RaphaelMeudec","followers_url":"https://api.github.com/users/RaphaelMeudec/followers","following_url":"https://api.github.com/users/RaphaelMeudec/following{/other_user}","gists_url":"https://api.github.com/users/RaphaelMeudec/gists{/gist_id}","starred_url":"https://api.github.com/users/RaphaelMeudec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaphaelMeudec/subscriptions","organizations_url":"https://api.github.com/users/RaphaelMeudec/orgs","repos_url":"https://api.github.com/users/RaphaelMeudec/repos","events_url":"https://api.github.com/users/RaphaelMeudec/events{/privacy}","received_events_url":"https://api.github.com/users/RaphaelMeudec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RaphaelMeudec/keras","description":"Deep Learning for humans","fork":true,"url":"https://api.github.com/repos/RaphaelMeudec/keras","forks_url":"https://api.github.com/repos/RaphaelMeudec/keras/forks","keys_url":"https://api.github.com/repos/RaphaelMeudec/keras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RaphaelMeudec/keras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RaphaelMeudec/keras/teams","hooks_url":"https://api.github.com/repos/RaphaelMeudec/keras/hooks","issue_events_url":"https://api.github.com/repos/RaphaelMeudec/keras/issues/events{/number}","events_url":"https://api.github.com/repos/RaphaelMeudec/keras/events","assignees_url":"https://api.github.com/repos/RaphaelMeudec/keras/assignees{/user}","branches_url":"https://api.github.com/repos/RaphaelMeudec/keras/branches{/branch}","tags_url":"https://api.github.com/repos/RaphaelMeudec/keras/tags","blobs_url":"https://api.github.com/repos/RaphaelMeudec/keras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RaphaelMeudec/keras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RaphaelMeudec/keras/git/refs{/sha}","trees_url":"https://api.github.com/repos/RaphaelMeudec/keras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RaphaelMeudec/keras/statuses/{sha}","languages_url":"https://api.github.com/repos/RaphaelMeudec/keras/languages","stargazers_url":"https://api.github.com/repos/RaphaelMeudec/keras/stargazers","contributors_url":"https://api.github.com/repos/RaphaelMeudec/keras/contributors","subscribers_url":"https://api.github.com/repos/RaphaelMeudec/keras/subscribers","subscription_url":"https://api.github.com/repos/RaphaelMeudec/keras/subscription","commits_url":"https://api.github.com/repos/RaphaelMeudec/keras/commits{/sha}","git_commits_url":"https://api.github.com/repos/RaphaelMeudec/keras/git/commits{/sha}","comments_url":"https://api.github.com/repos/RaphaelMeudec/keras/comments{/number}","issue_comment_url":"https://api.github.com/repos/RaphaelMeudec/keras/issues/comments{/number}","contents_url":"https://api.github.com/repos/RaphaelMeudec/keras/contents/{+path}","compare_url":"https://api.github.com/repos/RaphaelMeudec/keras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RaphaelMeudec/keras/merges","archive_url":"https://api.github.com/repos/RaphaelMeudec/keras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RaphaelMeudec/keras/downloads","issues_url":"https://api.github.com/repos/RaphaelMeudec/keras/issues{/number}","pulls_url":"https://api.github.com/repos/RaphaelMeudec/keras/pulls{/number}","milestones_url":"https://api.github.com/repos/RaphaelMeudec/keras/milestones{/number}","notifications_url":"https://api.github.com/repos/RaphaelMeudec/keras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RaphaelMeudec/keras/labels{/name}","releases_url":"https://api.github.com/repos/RaphaelMeudec/keras/releases{/id}","deployments_url":"https://api.github.com/repos/RaphaelMeudec/keras/deployments","created_at":"2018-12-17T17:06:42Z","updated_at":"2019-01-03T12:39:59Z","pushed_at":"2019-01-03T12:39:54Z","git_url":"git://github.com/RaphaelMeudec/keras.git","ssh_url":"git@github.com:RaphaelMeudec/keras.git","clone_url":"https://github.com/RaphaelMeudec/keras.git","svn_url":"https://github.com/RaphaelMeudec/keras","homepage":"http://keras.io/","size":12181,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keras-team:master","ref":"master","sha":"e11c48d9ce3ee47bb8a966549b14cbd5b10ee70d","user":{"login":"keras-team","id":34455048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1MDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34455048?v=4","gravatar_id":"","url":"https://api.github.com/users/keras-team","html_url":"https://github.com/keras-team","followers_url":"https://api.github.com/users/keras-team/followers","following_url":"https://api.github.com/users/keras-team/following{/other_user}","gists_url":"https://api.github.com/users/keras-team/gists{/gist_id}","starred_url":"https://api.github.com/users/keras-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keras-team/subscriptions","organizations_url":"https://api.github.com/users/keras-team/orgs","repos_url":"https://api.github.com/users/keras-team/repos","events_url":"https://api.github.com/users/keras-team/events{/privacy}","received_events_url":"https://api.github.com/users/keras-team/received_events","type":"Organization","site_admin":false},"repo":{"id":33015583,"node_id":"MDEwOlJlcG9zaXRvcnkzMzAxNTU4Mw==","name":"keras","full_name":"keras-team/keras","private":false,"owner":{"login":"keras-team","id":34455048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1MDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34455048?v=4","gravatar_id":"","url":"https://api.github.com/users/keras-team","html_url":"https://github.com/keras-team","followers_url":"https://api.github.com/users/keras-team/followers","following_url":"https://api.github.com/users/keras-team/following{/other_user}","gists_url":"https://api.github.com/users/keras-team/gists{/gist_id}","starred_url":"https://api.github.com/users/keras-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keras-team/subscriptions","organizations_url":"https://api.github.com/users/keras-team/orgs","repos_url":"https://api.github.com/users/keras-team/repos","events_url":"https://api.github.com/users/keras-team/events{/privacy}","received_events_url":"https://api.github.com/users/keras-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keras-team/keras","description":"Deep Learning for humans","fork":false,"url":"https://api.github.com/repos/keras-team/keras","forks_url":"https://api.github.com/repos/keras-team/keras/forks","keys_url":"https://api.github.com/repos/keras-team/keras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keras-team/keras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keras-team/keras/teams","hooks_url":"https://api.github.com/repos/keras-team/keras/hooks","issue_events_url":"https://api.github.com/repos/keras-team/keras/issues/events{/number}","events_url":"https://api.github.com/repos/keras-team/keras/events","assignees_url":"https://api.github.com/repos/keras-team/keras/assignees{/user}","branches_url":"https://api.github.com/repos/keras-team/keras/branches{/branch}","tags_url":"https://api.github.com/repos/keras-team/keras/tags","blobs_url":"https://api.github.com/repos/keras-team/keras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keras-team/keras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keras-team/keras/git/refs{/sha}","trees_url":"https://api.github.com/repos/keras-team/keras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keras-team/keras/statuses/{sha}","languages_url":"https://api.github.com/repos/keras-team/keras/languages","stargazers_url":"https://api.github.com/repos/keras-team/keras/stargazers","contributors_url":"https://api.github.com/repos/keras-team/keras/contributors","subscribers_url":"https://api.github.com/repos/keras-team/keras/subscribers","subscription_url":"https://api.github.com/repos/keras-team/keras/subscription","commits_url":"https://api.github.com/repos/keras-team/keras/commits{/sha}","git_commits_url":"https://api.github.com/repos/keras-team/keras/git/commits{/sha}","comments_url":"https://api.github.com/repos/keras-team/keras/comments{/number}","issue_comment_url":"https://api.github.com/repos/keras-team/keras/issues/comments{/number}","contents_url":"https://api.github.com/repos/keras-team/keras/contents/{+path}","compare_url":"https://api.github.com/repos/keras-team/keras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keras-team/keras/merges","archive_url":"https://api.github.com/repos/keras-team/keras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keras-team/keras/downloads","issues_url":"https://api.github.com/repos/keras-team/keras/issues{/number}","pulls_url":"https://api.github.com/repos/keras-team/keras/pulls{/number}","milestones_url":"https://api.github.com/repos/keras-team/keras/milestones{/number}","notifications_url":"https://api.github.com/repos/keras-team/keras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keras-team/keras/labels{/name}","releases_url":"https://api.github.com/repos/keras-team/keras/releases{/id}","deployments_url":"https://api.github.com/repos/keras-team/keras/deployments","created_at":"2015-03-28T00:35:42Z","updated_at":"2019-01-04T14:57:34Z","pushed_at":"2019-01-04T14:48:39Z","git_url":"git://github.com/keras-team/keras.git","ssh_url":"git@github.com:keras-team/keras.git","clone_url":"https://github.com/keras-team/keras.git","svn_url":"https://github.com/keras-team/keras","homepage":"http://keras.io/","size":12171,"stargazers_count":37067,"watchers_count":37067,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14139,"mirror_url":null,"archived":false,"open_issues_count":2049,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14139,"open_issues":2049,"watchers":37067,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11887"},"html":{"href":"https://github.com/keras-team/keras/pull/11887"},"issue":{"href":"https://api.github.com/repos/keras-team/keras/issues/11887"},"comments":{"href":"https://api.github.com/repos/keras-team/keras/issues/11887/comments"},"review_comments":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11887/comments"},"review_comment":{"href":"https://api.github.com/repos/keras-team/keras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keras-team/keras/pulls/11887/commits"},"statuses":{"href":"https://api.github.com/repos/keras-team/keras/statuses/8598b76f979bf28990a6ae9a6ddd085860323f8b"}},"author_association":"NONE"}}
{"actor":{"display_login":"RaphaelMeudec"}}