{"action":"closed","number":982,"pull_request":{"url":"https://api.github.com/repos/coreos/flannel/pulls/982","id":182667530,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyNjY3NTMw","html_url":"https://github.com/coreos/flannel/pull/982","diff_url":"https://github.com/coreos/flannel/pull/982.diff","patch_url":"https://github.com/coreos/flannel/pull/982.patch","issue_url":"https://api.github.com/repos/coreos/flannel/issues/982","number":982,"state":"closed","locked":false,"title":"subnet/kube: Handle missed node deletions","user":{"login":"richardmarshall","id":25832,"node_id":"MDQ6VXNlcjI1ODMy","avatar_url":"https://avatars1.githubusercontent.com/u/25832?v=4","gravatar_id":"","url":"https://api.github.com/users/richardmarshall","html_url":"https://github.com/richardmarshall","followers_url":"https://api.github.com/users/richardmarshall/followers","following_url":"https://api.github.com/users/richardmarshall/following{/other_user}","gists_url":"https://api.github.com/users/richardmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmarshall/subscriptions","organizations_url":"https://api.github.com/users/richardmarshall/orgs","repos_url":"https://api.github.com/users/richardmarshall/repos","events_url":"https://api.github.com/users/richardmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/richardmarshall/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nIf the node controller misses the deletion of a node the DeltaFIFO will insert a tombstone object (DeletedFinalStateUnknown) with the last known view of the object. The current code will panic due to a failed type assertion to v1.Node.\r\n\r\nThis PR includes a fix for this panic by checking the result of the type assertion and attempting to extract the last know state from the tombstone.\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [ ] Documentation\r\n- [ ] Release note\r\n\r\n## Release Note\r\n<!-- Writing a release note:\r\n- By default, no release note action is required.\r\n- If you're unsure whether or not your PR needs a note, ask your reviewer for guidance.\r\n- If this PR requires a release note, update the block below to include a concise note describing\r\n  the change and any important impacts this PR may have.\r\n-->\r\n\r\n```release-note\r\nNone required\r\n```\r\n","created_at":"2018-04-19T05:11:12Z","updated_at":"2018-07-09T20:31:30Z","closed_at":"2018-07-09T20:31:30Z","merged_at":null,"merge_commit_sha":"770b480e0db7eb1c2bbec087f8d72b2b60266981","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/flannel/pulls/982/commits","review_comments_url":"https://api.github.com/repos/coreos/flannel/pulls/982/comments","review_comment_url":"https://api.github.com/repos/coreos/flannel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/flannel/issues/982/comments","statuses_url":"https://api.github.com/repos/coreos/flannel/statuses/71dc25eebdf60b532efdfccf1595db041c7310e1","head":{"label":"richardmarshall:type_assertion_check","ref":"type_assertion_check","sha":"71dc25eebdf60b532efdfccf1595db041c7310e1","user":{"login":"richardmarshall","id":25832,"node_id":"MDQ6VXNlcjI1ODMy","avatar_url":"https://avatars1.githubusercontent.com/u/25832?v=4","gravatar_id":"","url":"https://api.github.com/users/richardmarshall","html_url":"https://github.com/richardmarshall","followers_url":"https://api.github.com/users/richardmarshall/followers","following_url":"https://api.github.com/users/richardmarshall/following{/other_user}","gists_url":"https://api.github.com/users/richardmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmarshall/subscriptions","organizations_url":"https://api.github.com/users/richardmarshall/orgs","repos_url":"https://api.github.com/users/richardmarshall/repos","events_url":"https://api.github.com/users/richardmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/richardmarshall/received_events","type":"User","site_admin":false},"repo":{"id":121575879,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1NzU4Nzk=","name":"flannel","full_name":"richardmarshall/flannel","owner":{"login":"richardmarshall","id":25832,"node_id":"MDQ6VXNlcjI1ODMy","avatar_url":"https://avatars1.githubusercontent.com/u/25832?v=4","gravatar_id":"","url":"https://api.github.com/users/richardmarshall","html_url":"https://github.com/richardmarshall","followers_url":"https://api.github.com/users/richardmarshall/followers","following_url":"https://api.github.com/users/richardmarshall/following{/other_user}","gists_url":"https://api.github.com/users/richardmarshall/gists{/gist_id}","starred_url":"https://api.github.com/users/richardmarshall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardmarshall/subscriptions","organizations_url":"https://api.github.com/users/richardmarshall/orgs","repos_url":"https://api.github.com/users/richardmarshall/repos","events_url":"https://api.github.com/users/richardmarshall/events{/privacy}","received_events_url":"https://api.github.com/users/richardmarshall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardmarshall/flannel","description":"flannel is a network fabric for containers, designed for Kubernetes","fork":true,"url":"https://api.github.com/repos/richardmarshall/flannel","forks_url":"https://api.github.com/repos/richardmarshall/flannel/forks","keys_url":"https://api.github.com/repos/richardmarshall/flannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardmarshall/flannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardmarshall/flannel/teams","hooks_url":"https://api.github.com/repos/richardmarshall/flannel/hooks","issue_events_url":"https://api.github.com/repos/richardmarshall/flannel/issues/events{/number}","events_url":"https://api.github.com/repos/richardmarshall/flannel/events","assignees_url":"https://api.github.com/repos/richardmarshall/flannel/assignees{/user}","branches_url":"https://api.github.com/repos/richardmarshall/flannel/branches{/branch}","tags_url":"https://api.github.com/repos/richardmarshall/flannel/tags","blobs_url":"https://api.github.com/repos/richardmarshall/flannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardmarshall/flannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardmarshall/flannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardmarshall/flannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardmarshall/flannel/statuses/{sha}","languages_url":"https://api.github.com/repos/richardmarshall/flannel/languages","stargazers_url":"https://api.github.com/repos/richardmarshall/flannel/stargazers","contributors_url":"https://api.github.com/repos/richardmarshall/flannel/contributors","subscribers_url":"https://api.github.com/repos/richardmarshall/flannel/subscribers","subscription_url":"https://api.github.com/repos/richardmarshall/flannel/subscription","commits_url":"https://api.github.com/repos/richardmarshall/flannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardmarshall/flannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardmarshall/flannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardmarshall/flannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardmarshall/flannel/contents/{+path}","compare_url":"https://api.github.com/repos/richardmarshall/flannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardmarshall/flannel/merges","archive_url":"https://api.github.com/repos/richardmarshall/flannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardmarshall/flannel/downloads","issues_url":"https://api.github.com/repos/richardmarshall/flannel/issues{/number}","pulls_url":"https://api.github.com/repos/richardmarshall/flannel/pulls{/number}","milestones_url":"https://api.github.com/repos/richardmarshall/flannel/milestones{/number}","notifications_url":"https://api.github.com/repos/richardmarshall/flannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardmarshall/flannel/labels{/name}","releases_url":"https://api.github.com/repos/richardmarshall/flannel/releases{/id}","deployments_url":"https://api.github.com/repos/richardmarshall/flannel/deployments","created_at":"2018-02-15T00:06:09Z","updated_at":"2018-02-15T00:06:12Z","pushed_at":"2018-03-11T19:18:57Z","git_url":"git://github.com/richardmarshall/flannel.git","ssh_url":"git@github.com:richardmarshall/flannel.git","clone_url":"https://github.com/richardmarshall/flannel.git","svn_url":"https://github.com/richardmarshall/flannel","homepage":"","size":45290,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"62a1314e51047e25606b4e4e30bd23d7a8d746bc","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":21704134,"node_id":"MDEwOlJlcG9zaXRvcnkyMTcwNDEzNA==","name":"flannel","full_name":"coreos/flannel","owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/flannel","description":"flannel is a network fabric for containers, designed for Kubernetes","fork":false,"url":"https://api.github.com/repos/coreos/flannel","forks_url":"https://api.github.com/repos/coreos/flannel/forks","keys_url":"https://api.github.com/repos/coreos/flannel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/flannel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/flannel/teams","hooks_url":"https://api.github.com/repos/coreos/flannel/hooks","issue_events_url":"https://api.github.com/repos/coreos/flannel/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/flannel/events","assignees_url":"https://api.github.com/repos/coreos/flannel/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/flannel/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/flannel/tags","blobs_url":"https://api.github.com/repos/coreos/flannel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/flannel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/flannel/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/flannel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/flannel/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/flannel/languages","stargazers_url":"https://api.github.com/repos/coreos/flannel/stargazers","contributors_url":"https://api.github.com/repos/coreos/flannel/contributors","subscribers_url":"https://api.github.com/repos/coreos/flannel/subscribers","subscription_url":"https://api.github.com/repos/coreos/flannel/subscription","commits_url":"https://api.github.com/repos/coreos/flannel/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/flannel/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/flannel/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/flannel/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/flannel/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/flannel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/flannel/merges","archive_url":"https://api.github.com/repos/coreos/flannel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/flannel/downloads","issues_url":"https://api.github.com/repos/coreos/flannel/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/flannel/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/flannel/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/flannel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/flannel/labels{/name}","releases_url":"https://api.github.com/repos/coreos/flannel/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/flannel/deployments","created_at":"2014-07-10T17:45:29Z","updated_at":"2018-07-09T20:25:17Z","pushed_at":"2018-07-09T20:30:14Z","git_url":"git://github.com/coreos/flannel.git","ssh_url":"git@github.com:coreos/flannel.git","clone_url":"https://github.com/coreos/flannel.git","svn_url":"https://github.com/coreos/flannel","homepage":"","size":45298,"stargazers_count":3221,"watchers_count":3221,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":769,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":769,"open_issues":121,"watchers":3221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/flannel/pulls/982"},"html":{"href":"https://github.com/coreos/flannel/pull/982"},"issue":{"href":"https://api.github.com/repos/coreos/flannel/issues/982"},"comments":{"href":"https://api.github.com/repos/coreos/flannel/issues/982/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/flannel/pulls/982/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/flannel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/flannel/pulls/982/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/flannel/statuses/71dc25eebdf60b532efdfccf1595db041c7310e1"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"tomdee"}}