{"action":"created","comment":{"url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/comments/211651796","pull_request_review_id":148118802,"id":211651796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY1MTc5Ng==","diff_hunk":"@@ -22,23 +21,12 @@ module.exports = class Bundle {\n \t\tthis._config = generateConfig(config, { browsers, resolvePath });\n \t}\n \n-\t// recompiles the bundle if its dependency graph includes any of the given files\n-\trecompile(...filepaths) {\n-\t\tlet modules = this._modules || new Set([this.entryPoint]); // XXX: awkward?\n-\t\tlet relevant = filepaths.some(filepath => modules.has(filepath));\n-\t\treturn relevant && this.compile();\n-\t}\n-\n-\tcompile() {\n-\t\tif(this._runner) { // recompile\n-\t\t\treturn this._runner.rerun();\n+\t// compiles the bundle if its dependency graph includes any of the given files\n+\tcompile(filepaths) {\n+\t\tif(filepaths && !this._modules.has(...filepaths)) {","path":"lib/bundle/index.js","position":null,"original_position":24,"commit_id":"be6aab42a283f243f3308f8a1d8a4b718dbda2f3","original_commit_id":"46245ca1aef198c5ef775091b3b2ff2664713e26","user":{"login":"moonglum","id":95788,"node_id":"MDQ6VXNlcjk1Nzg4","avatar_url":"https://avatars3.githubusercontent.com/u/95788?v=4","gravatar_id":"","url":"https://api.github.com/users/moonglum","html_url":"https://github.com/moonglum","followers_url":"https://api.github.com/users/moonglum/followers","following_url":"https://api.github.com/users/moonglum/following{/other_user}","gists_url":"https://api.github.com/users/moonglum/gists{/gist_id}","starred_url":"https://api.github.com/users/moonglum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonglum/subscriptions","organizations_url":"https://api.github.com/users/moonglum/orgs","repos_url":"https://api.github.com/users/moonglum/repos","events_url":"https://api.github.com/users/moonglum/events{/privacy}","received_events_url":"https://api.github.com/users/moonglum/received_events","type":"User","site_admin":false},"body":"compile can't be invoked by the watcher before that initial build completed. It has the SerializedRunner to make sure that it finished first.","created_at":"2018-08-21T15:30:21Z","updated_at":"2018-08-21T15:30:21Z","html_url":"https://github.com/faucet-pipeline/faucet-pipeline-js/pull/66#discussion_r211651796","pull_request_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/comments/211651796"},"html":{"href":"https://github.com/faucet-pipeline/faucet-pipeline-js/pull/66#discussion_r211651796"},"pull_request":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66"}},"in_reply_to_id":211644815},"pull_request":{"url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66","id":208314733,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzE0NzMz","html_url":"https://github.com/faucet-pipeline/faucet-pipeline-js/pull/66","diff_url":"https://github.com/faucet-pipeline/faucet-pipeline-js/pull/66.diff","patch_url":"https://github.com/faucet-pipeline/faucet-pipeline-js/pull/66.patch","issue_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/66","number":66,"state":"open","locked":false,"title":"Adjust to the new API of faucet-pipeline-core","user":{"login":"moonglum","id":95788,"node_id":"MDQ6VXNlcjk1Nzg4","avatar_url":"https://avatars3.githubusercontent.com/u/95788?v=4","gravatar_id":"","url":"https://api.github.com/users/moonglum","html_url":"https://github.com/moonglum","followers_url":"https://api.github.com/users/moonglum/followers","following_url":"https://api.github.com/users/moonglum/following{/other_user}","gists_url":"https://api.github.com/users/moonglum/gists{/gist_id}","starred_url":"https://api.github.com/users/moonglum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moonglum/subscriptions","organizations_url":"https://api.github.com/users/moonglum/orgs","repos_url":"https://api.github.com/users/moonglum/repos","events_url":"https://api.github.com/users/moonglum/events{/privacy}","received_events_url":"https://api.github.com/users/moonglum/received_events","type":"User","site_admin":false},"body":"* Adjust the CLI tests to the new configuration format\r\n* Remove all the code that was necessary for watching for changes etc.\r\n* Adjusted the tests to call the returned function. Otherwise, kept them the same.\r\n* Removed the watcher test, because there is no watching going on in here. Replaced it with two tests that check if the rebuild functionality isworking correctly.","created_at":"2018-08-14T15:07:54Z","updated_at":"2018-08-21T15:30:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3497b8c0a2b4517686f4f6913dd009541dd3db5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66/commits","review_comments_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66/comments","review_comment_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/66/comments","statuses_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/statuses/be6aab42a283f243f3308f8a1d8a4b718dbda2f3","head":{"label":"faucet-pipeline:lord-buckethead","ref":"lord-buckethead","sha":"be6aab42a283f243f3308f8a1d8a4b718dbda2f3","user":{"login":"faucet-pipeline","id":29569303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY5MzAz","avatar_url":"https://avatars2.githubusercontent.com/u/29569303?v=4","gravatar_id":"","url":"https://api.github.com/users/faucet-pipeline","html_url":"https://github.com/faucet-pipeline","followers_url":"https://api.github.com/users/faucet-pipeline/followers","following_url":"https://api.github.com/users/faucet-pipeline/following{/other_user}","gists_url":"https://api.github.com/users/faucet-pipeline/gists{/gist_id}","starred_url":"https://api.github.com/users/faucet-pipeline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faucet-pipeline/subscriptions","organizations_url":"https://api.github.com/users/faucet-pipeline/orgs","repos_url":"https://api.github.com/users/faucet-pipeline/repos","events_url":"https://api.github.com/users/faucet-pipeline/events{/privacy}","received_events_url":"https://api.github.com/users/faucet-pipeline/received_events","type":"Organization","site_admin":false},"repo":{"id":94875882,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg3NTg4Mg==","name":"faucet-pipeline-js","full_name":"faucet-pipeline/faucet-pipeline-js","owner":{"login":"faucet-pipeline","id":29569303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY5MzAz","avatar_url":"https://avatars2.githubusercontent.com/u/29569303?v=4","gravatar_id":"","url":"https://api.github.com/users/faucet-pipeline","html_url":"https://github.com/faucet-pipeline","followers_url":"https://api.github.com/users/faucet-pipeline/followers","following_url":"https://api.github.com/users/faucet-pipeline/following{/other_user}","gists_url":"https://api.github.com/users/faucet-pipeline/gists{/gist_id}","starred_url":"https://api.github.com/users/faucet-pipeline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faucet-pipeline/subscriptions","organizations_url":"https://api.github.com/users/faucet-pipeline/orgs","repos_url":"https://api.github.com/users/faucet-pipeline/repos","events_url":"https://api.github.com/users/faucet-pipeline/events{/privacy}","received_events_url":"https://api.github.com/users/faucet-pipeline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/faucet-pipeline/faucet-pipeline-js","description":"JavaScript asset pipeline","fork":false,"url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js","forks_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/forks","keys_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/teams","hooks_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/hooks","issue_events_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/events{/number}","events_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/events","assignees_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/assignees{/user}","branches_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/branches{/branch}","tags_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/tags","blobs_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/statuses/{sha}","languages_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/languages","stargazers_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/stargazers","contributors_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/contributors","subscribers_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/subscribers","subscription_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/subscription","commits_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/contents/{+path}","compare_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/merges","archive_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/downloads","issues_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues{/number}","pulls_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls{/number}","milestones_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/milestones{/number}","notifications_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/labels{/name}","releases_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/releases{/id}","deployments_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/deployments","created_at":"2017-06-20T09:49:13Z","updated_at":"2018-08-14T12:28:50Z","pushed_at":"2018-08-21T15:22:53Z","git_url":"git://github.com/faucet-pipeline/faucet-pipeline-js.git","ssh_url":"git@github.com:faucet-pipeline/faucet-pipeline-js.git","clone_url":"https://github.com/faucet-pipeline/faucet-pipeline-js.git","svn_url":"https://github.com/faucet-pipeline/faucet-pipeline-js","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"faucet-pipeline:master","ref":"master","sha":"3fc71b4708f66299781e365157f41eb268bf9d6f","user":{"login":"faucet-pipeline","id":29569303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY5MzAz","avatar_url":"https://avatars2.githubusercontent.com/u/29569303?v=4","gravatar_id":"","url":"https://api.github.com/users/faucet-pipeline","html_url":"https://github.com/faucet-pipeline","followers_url":"https://api.github.com/users/faucet-pipeline/followers","following_url":"https://api.github.com/users/faucet-pipeline/following{/other_user}","gists_url":"https://api.github.com/users/faucet-pipeline/gists{/gist_id}","starred_url":"https://api.github.com/users/faucet-pipeline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faucet-pipeline/subscriptions","organizations_url":"https://api.github.com/users/faucet-pipeline/orgs","repos_url":"https://api.github.com/users/faucet-pipeline/repos","events_url":"https://api.github.com/users/faucet-pipeline/events{/privacy}","received_events_url":"https://api.github.com/users/faucet-pipeline/received_events","type":"Organization","site_admin":false},"repo":{"id":94875882,"node_id":"MDEwOlJlcG9zaXRvcnk5NDg3NTg4Mg==","name":"faucet-pipeline-js","full_name":"faucet-pipeline/faucet-pipeline-js","owner":{"login":"faucet-pipeline","id":29569303,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTY5MzAz","avatar_url":"https://avatars2.githubusercontent.com/u/29569303?v=4","gravatar_id":"","url":"https://api.github.com/users/faucet-pipeline","html_url":"https://github.com/faucet-pipeline","followers_url":"https://api.github.com/users/faucet-pipeline/followers","following_url":"https://api.github.com/users/faucet-pipeline/following{/other_user}","gists_url":"https://api.github.com/users/faucet-pipeline/gists{/gist_id}","starred_url":"https://api.github.com/users/faucet-pipeline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faucet-pipeline/subscriptions","organizations_url":"https://api.github.com/users/faucet-pipeline/orgs","repos_url":"https://api.github.com/users/faucet-pipeline/repos","events_url":"https://api.github.com/users/faucet-pipeline/events{/privacy}","received_events_url":"https://api.github.com/users/faucet-pipeline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/faucet-pipeline/faucet-pipeline-js","description":"JavaScript asset pipeline","fork":false,"url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js","forks_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/forks","keys_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/teams","hooks_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/hooks","issue_events_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/events{/number}","events_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/events","assignees_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/assignees{/user}","branches_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/branches{/branch}","tags_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/tags","blobs_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/statuses/{sha}","languages_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/languages","stargazers_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/stargazers","contributors_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/contributors","subscribers_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/subscribers","subscription_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/subscription","commits_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/contents/{+path}","compare_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/merges","archive_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/downloads","issues_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues{/number}","pulls_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls{/number}","milestones_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/milestones{/number}","notifications_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/labels{/name}","releases_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/releases{/id}","deployments_url":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/deployments","created_at":"2017-06-20T09:49:13Z","updated_at":"2018-08-14T12:28:50Z","pushed_at":"2018-08-21T15:22:53Z","git_url":"git://github.com/faucet-pipeline/faucet-pipeline-js.git","ssh_url":"git@github.com:faucet-pipeline/faucet-pipeline-js.git","clone_url":"https://github.com/faucet-pipeline/faucet-pipeline-js.git","svn_url":"https://github.com/faucet-pipeline/faucet-pipeline-js","homepage":null,"size":264,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66"},"html":{"href":"https://github.com/faucet-pipeline/faucet-pipeline-js/pull/66"},"issue":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/66"},"comments":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/faucet-pipeline/faucet-pipeline-js/statuses/be6aab42a283f243f3308f8a1d8a4b718dbda2f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"moonglum"}}