{"action":"created","comment":{"url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/comments/237778545","pull_request_review_id":180150383,"id":237778545,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzc3ODU0NQ==","diff_hunk":"@@ -131,26 +159,156 @@ public void shouldAssertPhoneIsFoundWhenGetKeyInRange() {\n     @Test\n     @DirtiesContext\n     public void shouldAssertLimitedPhonesFromOffsetFoundWhenFindAllInRange() {\n-        phones = phoneDao.findAll(IN_RANGE_OFFSET, IN_RANGE_LIMIT);\n+        phones = phoneDao.findAll(IN_RANGE_OFFSET, IN_RANGE_LIMIT, STANDARD_SEARCH, STANDARD_ORDER, STANDARD_ASCEND);\n \n         Assert.isTrue(phones.size() == IN_RANGE_LIMIT, ERROR_PHONES_FIND_ALL + Arrays.toString(new Object[]{IN_RANGE_LIMIT, phones.size()}));\n     }\n \n     @Test\n     @DirtiesContext\n     public void shouldAssertPhonesNotFoundWhenFindAllZeroLimit() {\n-        phones = phoneDao.findAll(IN_RANGE_OFFSET, EMPTY_LIMIT);\n-\n+        phones = phoneDao.findAll(EMPTY_LIMIT, EMPTY_LIMIT, STANDARD_SEARCH, STANDARD_ORDER, STANDARD_ASCEND);","path":"core/src/test/java/com/es/core/model/phone/JdbcPhoneDaoTest.java","position":105,"original_position":105,"commit_id":"eaeddf445dd839ada7f3fcb570a33b6d800bd70a","original_commit_id":"eaeddf445dd839ada7f3fcb570a33b6d800bd70a","user":{"login":"AlexKrauchukExpert","id":31649693,"node_id":"MDQ6VXNlcjMxNjQ5Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/31649693?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKrauchukExpert","html_url":"https://github.com/AlexKrauchukExpert","followers_url":"https://api.github.com/users/AlexKrauchukExpert/followers","following_url":"https://api.github.com/users/AlexKrauchukExpert/following{/other_user}","gists_url":"https://api.github.com/users/AlexKrauchukExpert/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKrauchukExpert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKrauchukExpert/subscriptions","organizations_url":"https://api.github.com/users/AlexKrauchukExpert/orgs","repos_url":"https://api.github.com/users/AlexKrauchukExpert/repos","events_url":"https://api.github.com/users/AlexKrauchukExpert/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKrauchukExpert/received_events","type":"User","site_admin":false},"body":"given when then","created_at":"2018-11-30T08:28:09Z","updated_at":"2018-11-30T08:40:50Z","html_url":"https://github.com/ivanalexeenko/phoneshop/pull/2#discussion_r237778545","pull_request_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/comments/237778545"},"html":{"href":"https://github.com/ivanalexeenko/phoneshop/pull/2#discussion_r237778545"},"pull_request":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2","id":231809363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODA5MzYz","html_url":"https://github.com/ivanalexeenko/phoneshop/pull/2","diff_url":"https://github.com/ivanalexeenko/phoneshop/pull/2.diff","patch_url":"https://github.com/ivanalexeenko/phoneshop/pull/2.patch","issue_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/2","number":2,"state":"open","locked":false,"title":"Task 2 : Implemented table ordering,pagination and search","user":{"login":"ivanalexeenko","id":31345230,"node_id":"MDQ6VXNlcjMxMzQ1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/31345230?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanalexeenko","html_url":"https://github.com/ivanalexeenko","followers_url":"https://api.github.com/users/ivanalexeenko/followers","following_url":"https://api.github.com/users/ivanalexeenko/following{/other_user}","gists_url":"https://api.github.com/users/ivanalexeenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalexeenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalexeenko/subscriptions","organizations_url":"https://api.github.com/users/ivanalexeenko/orgs","repos_url":"https://api.github.com/users/ivanalexeenko/repos","events_url":"https://api.github.com/users/ivanalexeenko/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalexeenko/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-18T19:48:06Z","updated_at":"2018-11-30T08:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9496191cbc981568941fd5e294e8d1b0622e742d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/2/comments","statuses_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/statuses/eaeddf445dd839ada7f3fcb570a33b6d800bd70a","head":{"label":"ivanalexeenko:Task_2","ref":"Task_2","sha":"eaeddf445dd839ada7f3fcb570a33b6d800bd70a","user":{"login":"ivanalexeenko","id":31345230,"node_id":"MDQ6VXNlcjMxMzQ1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/31345230?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanalexeenko","html_url":"https://github.com/ivanalexeenko","followers_url":"https://api.github.com/users/ivanalexeenko/followers","following_url":"https://api.github.com/users/ivanalexeenko/following{/other_user}","gists_url":"https://api.github.com/users/ivanalexeenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalexeenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalexeenko/subscriptions","organizations_url":"https://api.github.com/users/ivanalexeenko/orgs","repos_url":"https://api.github.com/users/ivanalexeenko/repos","events_url":"https://api.github.com/users/ivanalexeenko/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalexeenko/received_events","type":"User","site_admin":false},"repo":{"id":154130518,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxMzA1MTg=","name":"phoneshop","full_name":"ivanalexeenko/phoneshop","private":false,"owner":{"login":"ivanalexeenko","id":31345230,"node_id":"MDQ6VXNlcjMxMzQ1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/31345230?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanalexeenko","html_url":"https://github.com/ivanalexeenko","followers_url":"https://api.github.com/users/ivanalexeenko/followers","following_url":"https://api.github.com/users/ivanalexeenko/following{/other_user}","gists_url":"https://api.github.com/users/ivanalexeenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalexeenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalexeenko/subscriptions","organizations_url":"https://api.github.com/users/ivanalexeenko/orgs","repos_url":"https://api.github.com/users/ivanalexeenko/repos","events_url":"https://api.github.com/users/ivanalexeenko/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalexeenko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivanalexeenko/phoneshop","description":"Test code envy","fork":true,"url":"https://api.github.com/repos/ivanalexeenko/phoneshop","forks_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/forks","keys_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/teams","hooks_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/hooks","issue_events_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/events{/number}","events_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/events","assignees_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/assignees{/user}","branches_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/branches{/branch}","tags_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/tags","blobs_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/languages","stargazers_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/stargazers","contributors_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/contributors","subscribers_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/subscribers","subscription_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/subscription","commits_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/contents/{+path}","compare_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/merges","archive_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/downloads","issues_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues{/number}","pulls_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/labels{/name}","releases_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/releases{/id}","deployments_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/deployments","created_at":"2018-10-22T11:16:53Z","updated_at":"2018-11-09T06:55:15Z","pushed_at":"2018-11-29T17:43:12Z","git_url":"git://github.com/ivanalexeenko/phoneshop.git","ssh_url":"git@github.com:ivanalexeenko/phoneshop.git","clone_url":"https://github.com/ivanalexeenko/phoneshop.git","svn_url":"https://github.com/ivanalexeenko/phoneshop","homepage":null,"size":1071,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ivanalexeenko:master","ref":"master","sha":"5a6553fe40624eefc008c5c2cb48c0526eb802d6","user":{"login":"ivanalexeenko","id":31345230,"node_id":"MDQ6VXNlcjMxMzQ1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/31345230?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanalexeenko","html_url":"https://github.com/ivanalexeenko","followers_url":"https://api.github.com/users/ivanalexeenko/followers","following_url":"https://api.github.com/users/ivanalexeenko/following{/other_user}","gists_url":"https://api.github.com/users/ivanalexeenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalexeenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalexeenko/subscriptions","organizations_url":"https://api.github.com/users/ivanalexeenko/orgs","repos_url":"https://api.github.com/users/ivanalexeenko/repos","events_url":"https://api.github.com/users/ivanalexeenko/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalexeenko/received_events","type":"User","site_admin":false},"repo":{"id":154130518,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQxMzA1MTg=","name":"phoneshop","full_name":"ivanalexeenko/phoneshop","private":false,"owner":{"login":"ivanalexeenko","id":31345230,"node_id":"MDQ6VXNlcjMxMzQ1MjMw","avatar_url":"https://avatars0.githubusercontent.com/u/31345230?v=4","gravatar_id":"","url":"https://api.github.com/users/ivanalexeenko","html_url":"https://github.com/ivanalexeenko","followers_url":"https://api.github.com/users/ivanalexeenko/followers","following_url":"https://api.github.com/users/ivanalexeenko/following{/other_user}","gists_url":"https://api.github.com/users/ivanalexeenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ivanalexeenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivanalexeenko/subscriptions","organizations_url":"https://api.github.com/users/ivanalexeenko/orgs","repos_url":"https://api.github.com/users/ivanalexeenko/repos","events_url":"https://api.github.com/users/ivanalexeenko/events{/privacy}","received_events_url":"https://api.github.com/users/ivanalexeenko/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ivanalexeenko/phoneshop","description":"Test code envy","fork":true,"url":"https://api.github.com/repos/ivanalexeenko/phoneshop","forks_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/forks","keys_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/teams","hooks_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/hooks","issue_events_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/events{/number}","events_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/events","assignees_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/assignees{/user}","branches_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/branches{/branch}","tags_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/tags","blobs_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/statuses/{sha}","languages_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/languages","stargazers_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/stargazers","contributors_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/contributors","subscribers_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/subscribers","subscription_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/subscription","commits_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/contents/{+path}","compare_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/merges","archive_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/downloads","issues_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues{/number}","pulls_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls{/number}","milestones_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/milestones{/number}","notifications_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/labels{/name}","releases_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/releases{/id}","deployments_url":"https://api.github.com/repos/ivanalexeenko/phoneshop/deployments","created_at":"2018-10-22T11:16:53Z","updated_at":"2018-11-09T06:55:15Z","pushed_at":"2018-11-29T17:43:12Z","git_url":"git://github.com/ivanalexeenko/phoneshop.git","ssh_url":"git@github.com:ivanalexeenko/phoneshop.git","clone_url":"https://github.com/ivanalexeenko/phoneshop.git","svn_url":"https://github.com/ivanalexeenko/phoneshop","homepage":null,"size":1071,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2"},"html":{"href":"https://github.com/ivanalexeenko/phoneshop/pull/2"},"issue":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/2"},"comments":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ivanalexeenko/phoneshop/statuses/eaeddf445dd839ada7f3fcb570a33b6d800bd70a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"AlexKrauchukExpert"}}