{"action":"created","issue":{"url":"https://api.github.com/repos/canmet-energy/btap_tasks/issues/48","repository_url":"https://api.github.com/repos/canmet-energy/btap_tasks","labels_url":"https://api.github.com/repos/canmet-energy/btap_tasks/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/canmet-energy/btap_tasks/issues/48/comments","events_url":"https://api.github.com/repos/canmet-energy/btap_tasks/issues/48/events","html_url":"https://github.com/canmet-energy/btap_tasks/issues/48","id":322414398,"node_id":"MDU6SXNzdWUzMjI0MTQzOTg=","number":48,"title":"NECB 2015 QAQC","user":{"login":"padmassun","id":24966493,"node_id":"MDQ6VXNlcjI0OTY2NDkz","avatar_url":"https://avatars1.githubusercontent.com/u/24966493?v=4","gravatar_id":"","url":"https://api.github.com/users/padmassun","html_url":"https://github.com/padmassun","followers_url":"https://api.github.com/users/padmassun/followers","following_url":"https://api.github.com/users/padmassun/following{/other_user}","gists_url":"https://api.github.com/users/padmassun/gists{/gist_id}","starred_url":"https://api.github.com/users/padmassun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmassun/subscriptions","organizations_url":"https://api.github.com/users/padmassun/orgs","repos_url":"https://api.github.com/users/padmassun/repos","events_url":"https://api.github.com/users/padmassun/events{/privacy}","received_events_url":"https://api.github.com/users/padmassun/received_events","type":"User","site_admin":false},"labels":[{"id":930304532,"node_id":"MDU6TGFiZWw5MzAzMDQ1MzI=","url":"https://api.github.com/repos/canmet-energy/btap_tasks/labels/QAQC","name":"QAQC","color":"a357f9","default":false},{"id":816653668,"node_id":"MDU6TGFiZWw4MTY2NTM2Njg=","url":"https://api.github.com/repos/canmet-energy/btap_tasks/labels/Standards","name":"Standards","color":"4aad08","default":false}],"state":"open","locked":false,"assignee":{"login":"padmassun","id":24966493,"node_id":"MDQ6VXNlcjI0OTY2NDkz","avatar_url":"https://avatars1.githubusercontent.com/u/24966493?v=4","gravatar_id":"","url":"https://api.github.com/users/padmassun","html_url":"https://github.com/padmassun","followers_url":"https://api.github.com/users/padmassun/followers","following_url":"https://api.github.com/users/padmassun/following{/other_user}","gists_url":"https://api.github.com/users/padmassun/gists{/gist_id}","starred_url":"https://api.github.com/users/padmassun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmassun/subscriptions","organizations_url":"https://api.github.com/users/padmassun/orgs","repos_url":"https://api.github.com/users/padmassun/repos","events_url":"https://api.github.com/users/padmassun/events{/privacy}","received_events_url":"https://api.github.com/users/padmassun/received_events","type":"User","site_admin":false},"assignees":[{"login":"padmassun","id":24966493,"node_id":"MDQ6VXNlcjI0OTY2NDkz","avatar_url":"https://avatars1.githubusercontent.com/u/24966493?v=4","gravatar_id":"","url":"https://api.github.com/users/padmassun","html_url":"https://github.com/padmassun","followers_url":"https://api.github.com/users/padmassun/followers","following_url":"https://api.github.com/users/padmassun/following{/other_user}","gists_url":"https://api.github.com/users/padmassun/gists{/gist_id}","starred_url":"https://api.github.com/users/padmassun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmassun/subscriptions","organizations_url":"https://api.github.com/users/padmassun/orgs","repos_url":"https://api.github.com/users/padmassun/repos","events_url":"https://api.github.com/users/padmassun/events{/privacy}","received_events_url":"https://api.github.com/users/padmassun/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/canmet-energy/btap_tasks/milestones/1","html_url":"https://github.com/canmet-energy/btap_tasks/milestone/1","labels_url":"https://api.github.com/repos/canmet-energy/btap_tasks/milestones/1/labels","id":3148334,"node_id":"MDk6TWlsZXN0b25lMzE0ODMzNA==","number":1,"title":"NECB2015","description":"The implementation of the NECB 2015 into OpenStudio","creator":{"login":"phylroy","id":5103270,"node_id":"MDQ6VXNlcjUxMDMyNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5103270?v=4","gravatar_id":"","url":"https://api.github.com/users/phylroy","html_url":"https://github.com/phylroy","followers_url":"https://api.github.com/users/phylroy/followers","following_url":"https://api.github.com/users/phylroy/following{/other_user}","gists_url":"https://api.github.com/users/phylroy/gists{/gist_id}","starred_url":"https://api.github.com/users/phylroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phylroy/subscriptions","organizations_url":"https://api.github.com/users/phylroy/orgs","repos_url":"https://api.github.com/users/phylroy/repos","events_url":"https://api.github.com/users/phylroy/events{/privacy}","received_events_url":"https://api.github.com/users/phylroy/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":5,"state":"open","created_at":"2018-02-27T18:18:39Z","updated_at":"2018-05-30T18:16:49Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":4,"created_at":"2018-05-11T19:50:13Z","updated_at":"2018-06-05T15:51:15Z","closed_at":null,"author_association":"NONE","body":"## Objective\r\nGeneralize QAQC process, such that new NECB templates can be added easily with minimal changes to qaqc code. \r\n\r\n## Process\r\nCreate QAQC methods under `Standard` class, which will be inherited by the NECB Template (NECB2011 and NECB2015 class). \r\n\r\n### Pseudocode\r\n```\r\nIf no changes\r\n    Call `super()`\r\nif ONLY values changes\r\n    Read values from an external source (json or csv)\r\n      e.g. super(path/to/datafile)\r\nif [(value AND logic) OR (logic)] changes\r\n    override default method from standard class\r\n```\r\n# Summary of Changes\r\n\r\n## Pumps\r\nNECB 2011: SANITY-??\r\nNECB 2015: 8.4.4.14\r\n  + _**Value Changes**_\r\n  + _**Logic Changes**_\r\n\r\n## Space compliance\r\nRe: `lighting_per_area`, `occupancy_per_area`, `occupancy_schedule`, `electric_equipment_per_area`\r\nNECB 2011: 8.4.3.6\r\nNEBC 2015: \r\n  + Need a full rewrite (? maybe not) for 2015\r\n  + Logic changes for 2015. Can be (possibly?) merged with 2011 \r\n    + different LPD ratios\r\n\r\n## Envelope compliance\r\nRe: `fenestration_to_door_and_window_percentage`, `skylight_to_roof_percentage`\r\nNECB 2011: 3.2.1.4\r\nNECB 2015: \r\n  + No changes to values\r\n  + No changes to logic\r\n    + ~Remove (?) skylight to roof ratio for 2015~\r\n\r\n## Infiltration Compliance\r\nRe: `infiltration_method` and `infiltration_flow_per_m2`\r\nNECB 2011: 8.4.3.6\r\nNECB 2015: \r\n  + No changes to values\r\n  + No changes to logic\r\n\r\n## Exterior Opaque Compliance\r\nRe: `ext_wall_conductances`, `ext_roof_conductances`, and `ext_floor_conductances`\r\nNECB 2011: 3.2.2.2\r\nNECB 2015: \r\n  + _**Value Changes**_\r\n    + read values from external json file depending on template type and climate index\r\n  + No changes to logic\r\n\r\n## Exterior Fenestration Compliance\r\nRe: `ext_window_conductances`, `ext_door_conductances`, `ext_overhead_door_conductances`, and `ext_skylight_conductances`\r\nNECB 2011: 3.2.2.3\r\nNECB 2015: \r\n  + _**Value Changes**_\r\n    + read values from external json file depending on template type template type and climate index\r\n  + No changes to logic\r\n\r\n## Exterior Ground Compliance\r\nRe: `ground_wall_conductances`, `ground_roof_conductances`, and `ground_floor_conductances`\r\nNECB 2011: 3.2.3.1\r\nNECB 2015: \r\n  + _**Value Changes**_\r\n    + read values from external json file depending on template type template type and climate index\r\n  + No changes to logic\r\n\r\n## Zone sizing\r\nRe: `heating_sizing_factor` and `cooling_sizing_factor`\r\nNECB 2011: ?\r\nNECB 2015: \r\n  + No changes to values\r\n  + No changes to logic\r\n\r\n## Design Supply Temperature Sizing\r\nRe: `heating_design_supply_air_temp` and `cooling_design_supply_temp`\r\nNECB 2011: ?\r\nNECB 2015: \r\n**Errors exist on the code themselves for NECB 2011, 2015, and 2017**\r\n  + No changes to values\r\n  + No changes to logic\r\n\r\n## Economizer compliance\r\nRe: `DifferentialEnthalpy` and `NoEconomizer`\r\nNECB 2011: 5.2.2.7\r\nNECB 2015: 5.2.2.8\r\n  + _**Logic changes**_\r\n  + _**Value changes**_\r\n\r\n2015 Introduces 2 stage economizer.\r\n  + proposed solution by @mlubun is to find the equivalent size\r\n\r\n## HRV Compliance\r\nRe: `HRV present` and `HRV absent` (boolean)\r\nNECB 2011: 5.2.10.1\r\nNECB 2015: 5.2.10.4\r\n  + No changes to values\r\n  + _**Some changes to logic**_\r\n    + call `super()` and append logic for MURBS \r\n\r\n## VAV and PSZ fan power\r\nRe: acceptable (both absolute and percent) difference between the actual and NECB value for fan power\r\nNECB 2011: 5.2.3.3 and 5.2.3.2\r\nNECB 2015:\r\n  + No changes to values\r\n  + No changes to logic\r\n"},"comment":{"url":"https://api.github.com/repos/canmet-energy/btap_tasks/issues/comments/394761916","html_url":"https://github.com/canmet-energy/btap_tasks/issues/48#issuecomment-394761916","issue_url":"https://api.github.com/repos/canmet-energy/btap_tasks/issues/48","id":394761916,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDc2MTkxNg==","user":{"login":"padmassun","id":24966493,"node_id":"MDQ6VXNlcjI0OTY2NDkz","avatar_url":"https://avatars1.githubusercontent.com/u/24966493?v=4","gravatar_id":"","url":"https://api.github.com/users/padmassun","html_url":"https://github.com/padmassun","followers_url":"https://api.github.com/users/padmassun/followers","following_url":"https://api.github.com/users/padmassun/following{/other_user}","gists_url":"https://api.github.com/users/padmassun/gists{/gist_id}","starred_url":"https://api.github.com/users/padmassun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmassun/subscriptions","organizations_url":"https://api.github.com/users/padmassun/orgs","repos_url":"https://api.github.com/users/padmassun/repos","events_url":"https://api.github.com/users/padmassun/events{/privacy}","received_events_url":"https://api.github.com/users/padmassun/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T15:51:15Z","updated_at":"2018-06-05T15:51:15Z","author_association":"NONE","body":"## Exterior Fenestration Compliance\r\nRe: `ext_window_conductances`,` ext_door_conductances`, `ext_overhead_door_conductances`, and `ext_skylight_conductances`\r\nNECB 2011: 3.2.2.3\r\nNECB 2015: 3.2.2.3\r\n\r\n+ ~Value Changes~ _**NO VALUE CHANGES**_\r\n+ No changes to logic"}}
{"actor":{"display_login":"padmassun"}}