{"action":"created","issue":{"url":"https://api.github.com/repos/iodide-project/pyodide/issues/189","repository_url":"https://api.github.com/repos/iodide-project/pyodide","labels_url":"https://api.github.com/repos/iodide-project/pyodide/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/iodide-project/pyodide/issues/189/comments","events_url":"https://api.github.com/repos/iodide-project/pyodide/issues/189/events","html_url":"https://github.com/iodide-project/pyodide/issues/189","id":363659037,"node_id":"MDU6SXNzdWUzNjM2NTkwMzc=","number":189,"title":"META: results with emscripten assertion checking on","user":{"login":"rth","id":630936,"node_id":"MDQ6VXNlcjYzMDkzNg==","avatar_url":"https://avatars0.githubusercontent.com/u/630936?v=4","gravatar_id":"","url":"https://api.github.com/users/rth","html_url":"https://github.com/rth","followers_url":"https://api.github.com/users/rth/followers","following_url":"https://api.github.com/users/rth/following{/other_user}","gists_url":"https://api.github.com/users/rth/gists{/gist_id}","starred_url":"https://api.github.com/users/rth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rth/subscriptions","organizations_url":"https://api.github.com/users/rth/orgs","repos_url":"https://api.github.com/users/rth/repos","events_url":"https://api.github.com/users/rth/events{/privacy}","received_events_url":"https://api.github.com/users/rth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-25T16:13:17Z","updated_at":"2018-09-25T20:27:35Z","closed_at":null,"author_association":"MEMBER","body":"The default `emscripten` build flags appear to be focused more on keeping the produced files small and on performance. Some of the checks/assertions are skipped and exceptions are not caught. \r\n\r\nIn this issue I report the result of the test suite when enabling more debug flags / assertion checking,\r\n```\r\n  -s ASSERTIONS=2 \\\r\n  -s SAFE_HEAP=1 \\\r\n  -s EXCEPTION_DEBUG=1 \\\r\n  -s DISABLE_EXCEPTION_CATCHING=0 \\\r\n  -s ERROR_ON_UNDEFINED_SYMBOLS=1 \\\r\n  -s \"BINARYEN_TRAP_MODE='clamp'\"\r\n```\r\nadded both to `LDFLAGS` and `SIDE_LDFLAGS` (for good measure) passed to emscripten.\r\n\r\nWith these options using Firefox there are 43 failed tests (out of 455) full log can be found in [pyodide-tests-debug-flags.log](https://github.com/iodide-project/pyodide/files/2415996/pyodide-tests-debug-flags.log). Not all errors / warnings are probably important, but some may be informative for errors reported in other issues.\r\n\r\nI'll edit edit this description with a link to a few specific issues extracted from the test logs.\r\n\r\nAlthough setting these flags overall makes the output files larger (by ~40% LZ4 compressed) and the test suite runs much slower as a result (by a factor of 5 times), if might be worth considering including some of the less costly ones in the default settings, in particular,\r\n``` \r\n-s \"BINARYEN_TRAP_MODE='clamp'\"\r\n-s ERROR_ON_UNDEFINED_SYMBOLS=1   # this will be enabled by default in emscripten\r\n```\r\n "},"comment":{"url":"https://api.github.com/repos/iodide-project/pyodide/issues/comments/424489590","html_url":"https://github.com/iodide-project/pyodide/issues/189#issuecomment-424489590","issue_url":"https://api.github.com/repos/iodide-project/pyodide/issues/189","id":424489590,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDQ4OTU5MA==","user":{"login":"mdboom","id":38294,"node_id":"MDQ6VXNlcjM4Mjk0","avatar_url":"https://avatars3.githubusercontent.com/u/38294?v=4","gravatar_id":"","url":"https://api.github.com/users/mdboom","html_url":"https://github.com/mdboom","followers_url":"https://api.github.com/users/mdboom/followers","following_url":"https://api.github.com/users/mdboom/following{/other_user}","gists_url":"https://api.github.com/users/mdboom/gists{/gist_id}","starred_url":"https://api.github.com/users/mdboom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdboom/subscriptions","organizations_url":"https://api.github.com/users/mdboom/orgs","repos_url":"https://api.github.com/users/mdboom/repos","events_url":"https://api.github.com/users/mdboom/events{/privacy}","received_events_url":"https://api.github.com/users/mdboom/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T20:27:35Z","updated_at":"2018-09-25T20:27:35Z","author_association":"MEMBER","body":"We could also consider adding these in a separate Circle-CI build that doesn't get deployed (so runtime isn't as important).  Though maybe that's only helpful once we clean out all of the failures..."}}
{"actor":{"display_login":"mdboom"}}