{"action":"created","comment":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/206945185","pull_request_review_id":142434557,"id":206945185,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjk0NTE4NQ==","diff_hunk":"@@ -0,0 +1,113 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.jclouds.aliyun.ecs.compute;\n+\n+import com.google.common.collect.ImmutableMap;\n+import com.google.common.collect.ImmutableSet;\n+import com.google.inject.Module;\n+import org.jclouds.compute.ComputeServiceContext;\n+import org.jclouds.compute.domain.NodeMetadata;\n+import org.jclouds.compute.domain.Template;\n+import org.jclouds.compute.domain.TemplateBuilder;\n+import org.jclouds.compute.internal.BaseComputeServiceLiveTest;\n+import org.jclouds.rest.AuthorizationException;\n+import org.jclouds.scriptbuilder.domain.Statement;\n+import org.jclouds.scriptbuilder.domain.Statements;\n+import org.jclouds.scriptbuilder.statements.java.InstallJDK;\n+import org.jclouds.scriptbuilder.statements.login.AdminAccess;\n+import org.jclouds.sshj.config.SshjSshClientModule;\n+import org.testng.annotations.Test;\n+\n+import java.util.Properties;\n+\n+import static org.jclouds.aliyun.ecs.compute.options.ECSServiceTemplateOptions.Builder.vpcId;\n+\n+/**\n+ * Live tests for the {@link org.jclouds.compute.ComputeService} integration.\n+ */\n+@Test(groups = \"live\", singleThreaded = true, testName = \"ECSComputeServiceLiveTest\")\n+public class ECSComputeServiceLiveTest extends BaseComputeServiceLiveTest {\n+\n+   private String vpcId;\n+   private String vSwitchId;\n+\n+   public ECSComputeServiceLiveTest() {\n+      provider = \"aliyun-ecs\";\n+   }\n+\n+   @Override\n+   protected Properties setupProperties() {\n+      Properties properties = super.setupProperties();\n+      vpcId = setIfTestSystemPropertyPresent(properties,  provider + \".vpcId\");\n+      vSwitchId = setIfTestSystemPropertyPresent(properties,  provider + \".vSwitchId\");\n+      return properties;\n+   }\n+\n+   @Override\n+   protected TemplateBuilder templateBuilder() {\n+      return super.templateBuilder()\n+                      .options(vpcId(vpcId)\n+                      .vSwitchId(vSwitchId));\n+   }\n+\n+   @Override\n+   protected Template addRunScriptToTemplate(Template template) {\n+      template.getOptions().runScript(Statements.newStatementList(\n+            new Statement[] { AdminAccess.standard(), Statements.exec(\"sleep 50\"), InstallJDK.fromOpenJDK() }));\n+      return template;\n+   }\n+\n+   @Override\n+   protected Module getSshModule() {\n+      return new SshjSshClientModule();\n+   }\n+\n+   @Override\n+   @Test(expectedExceptions = AuthorizationException.class)\n+   public void testCorrectAuthException() throws Exception {","path":"aliyun-ecs/src/test/java/org/jclouds/aliyun/ecs/compute/ECSComputeServiceLiveTest.java","position":81,"original_position":81,"commit_id":"39fef5305d6cdfb660ecee32244eba7e7f5f68b5","original_commit_id":"39fef5305d6cdfb660ecee32244eba7e7f5f68b5","user":{"login":"nacx","id":446705,"node_id":"MDQ6VXNlcjQ0NjcwNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/446705?v=4","gravatar_id":"","url":"https://api.github.com/users/nacx","html_url":"https://github.com/nacx","followers_url":"https://api.github.com/users/nacx/followers","following_url":"https://api.github.com/users/nacx/following{/other_user}","gists_url":"https://api.github.com/users/nacx/gists{/gist_id}","starred_url":"https://api.github.com/users/nacx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nacx/subscriptions","organizations_url":"https://api.github.com/users/nacx/orgs","repos_url":"https://api.github.com/users/nacx/repos","events_url":"https://api.github.com/users/nacx/events{/privacy}","received_events_url":"https://api.github.com/users/nacx/received_events","type":"User","site_admin":false},"body":"Why do we need to override this test?","created_at":"2018-08-01T16:23:13Z","updated_at":"2018-08-01T16:28:58Z","html_url":"https://github.com/jclouds/jclouds-labs/pull/443#discussion_r206945185","pull_request_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments/206945185"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/443#discussion_r206945185"},"pull_request":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443","id":205452898,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDUyODk4","html_url":"https://github.com/jclouds/jclouds-labs/pull/443","diff_url":"https://github.com/jclouds/jclouds-labs/pull/443.diff","patch_url":"https://github.com/jclouds/jclouds-labs/pull/443.patch","issue_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/443","number":443,"state":"open","locked":false,"title":"[JCLOUDS-1430] Aliyun ECS","user":{"login":"andreaturli","id":222887,"node_id":"MDQ6VXNlcjIyMjg4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/222887?v=4","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"body":"- add instance API\r\n- add compute abstraction","created_at":"2018-08-01T14:53:48Z","updated_at":"2018-08-01T16:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e69a63369b9ebac2e8f5ba7f06fa636174a8de7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443/commits","review_comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443/comments","review_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/443/comments","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/39fef5305d6cdfb660ecee32244eba7e7f5f68b5","head":{"label":"andreaturli:JCLOUDS-1430/compute-abstraction","ref":"JCLOUDS-1430/compute-abstraction","sha":"39fef5305d6cdfb660ecee32244eba7e7f5f68b5","user":{"login":"andreaturli","id":222887,"node_id":"MDQ6VXNlcjIyMjg4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/222887?v=4","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"repo":{"id":11312222,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMjIyMg==","name":"jclouds-labs","full_name":"andreaturli/jclouds-labs","owner":{"login":"andreaturli","id":222887,"node_id":"MDQ6VXNlcjIyMjg4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/222887?v=4","gravatar_id":"","url":"https://api.github.com/users/andreaturli","html_url":"https://github.com/andreaturli","followers_url":"https://api.github.com/users/andreaturli/followers","following_url":"https://api.github.com/users/andreaturli/following{/other_user}","gists_url":"https://api.github.com/users/andreaturli/gists{/gist_id}","starred_url":"https://api.github.com/users/andreaturli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreaturli/subscriptions","organizations_url":"https://api.github.com/users/andreaturli/orgs","repos_url":"https://api.github.com/users/andreaturli/repos","events_url":"https://api.github.com/users/andreaturli/events{/privacy}","received_events_url":"https://api.github.com/users/andreaturli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreaturli/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":true,"url":"https://api.github.com/repos/andreaturli/jclouds-labs","forks_url":"https://api.github.com/repos/andreaturli/jclouds-labs/forks","keys_url":"https://api.github.com/repos/andreaturli/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreaturli/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreaturli/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/andreaturli/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/andreaturli/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/andreaturli/jclouds-labs/events","assignees_url":"https://api.github.com/repos/andreaturli/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/andreaturli/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/andreaturli/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/andreaturli/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreaturli/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreaturli/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreaturli/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreaturli/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/andreaturli/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/andreaturli/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/andreaturli/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/andreaturli/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/andreaturli/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/andreaturli/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreaturli/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreaturli/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreaturli/jclouds-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreaturli/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/andreaturli/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreaturli/jclouds-labs/merges","archive_url":"https://api.github.com/repos/andreaturli/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreaturli/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/andreaturli/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/andreaturli/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/andreaturli/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/andreaturli/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreaturli/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/andreaturli/jclouds-labs/releases{/id}","deployments_url":"https://api.github.com/repos/andreaturli/jclouds-labs/deployments","created_at":"2013-07-10T13:07:52Z","updated_at":"2018-07-31T20:28:17Z","pushed_at":"2018-08-01T14:52:24Z","git_url":"git://github.com/andreaturli/jclouds-labs.git","ssh_url":"git@github.com:andreaturli/jclouds-labs.git","clone_url":"https://github.com/andreaturli/jclouds-labs.git","svn_url":"https://github.com/andreaturli/jclouds-labs","homepage":null,"size":23855,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":5,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"jclouds:master","ref":"master","sha":"a5dbf0065d8fa8cabcaf020b7c10fe2f7ccf8d6a","user":{"login":"jclouds","id":108982,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODk4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/108982?v=4","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"repo":{"id":10040970,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0MDk3MA==","name":"jclouds-labs","full_name":"jclouds/jclouds-labs","owner":{"login":"jclouds","id":108982,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODk4Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/108982?v=4","gravatar_id":"","url":"https://api.github.com/users/jclouds","html_url":"https://github.com/jclouds","followers_url":"https://api.github.com/users/jclouds/followers","following_url":"https://api.github.com/users/jclouds/following{/other_user}","gists_url":"https://api.github.com/users/jclouds/gists{/gist_id}","starred_url":"https://api.github.com/users/jclouds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jclouds/subscriptions","organizations_url":"https://api.github.com/users/jclouds/orgs","repos_url":"https://api.github.com/users/jclouds/repos","events_url":"https://api.github.com/users/jclouds/events{/privacy}","received_events_url":"https://api.github.com/users/jclouds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jclouds/jclouds-labs","description":"Read-only mirror of ASF Git Repo for jclouds labs","fork":false,"url":"https://api.github.com/repos/jclouds/jclouds-labs","forks_url":"https://api.github.com/repos/jclouds/jclouds-labs/forks","keys_url":"https://api.github.com/repos/jclouds/jclouds-labs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jclouds/jclouds-labs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jclouds/jclouds-labs/teams","hooks_url":"https://api.github.com/repos/jclouds/jclouds-labs/hooks","issue_events_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/events{/number}","events_url":"https://api.github.com/repos/jclouds/jclouds-labs/events","assignees_url":"https://api.github.com/repos/jclouds/jclouds-labs/assignees{/user}","branches_url":"https://api.github.com/repos/jclouds/jclouds-labs/branches{/branch}","tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/tags","blobs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/{sha}","languages_url":"https://api.github.com/repos/jclouds/jclouds-labs/languages","stargazers_url":"https://api.github.com/repos/jclouds/jclouds-labs/stargazers","contributors_url":"https://api.github.com/repos/jclouds/jclouds-labs/contributors","subscribers_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscribers","subscription_url":"https://api.github.com/repos/jclouds/jclouds-labs/subscription","commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jclouds/jclouds-labs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jclouds/jclouds-labs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jclouds/jclouds-labs/contents/{+path}","compare_url":"https://api.github.com/repos/jclouds/jclouds-labs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jclouds/jclouds-labs/merges","archive_url":"https://api.github.com/repos/jclouds/jclouds-labs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jclouds/jclouds-labs/downloads","issues_url":"https://api.github.com/repos/jclouds/jclouds-labs/issues{/number}","pulls_url":"https://api.github.com/repos/jclouds/jclouds-labs/pulls{/number}","milestones_url":"https://api.github.com/repos/jclouds/jclouds-labs/milestones{/number}","notifications_url":"https://api.github.com/repos/jclouds/jclouds-labs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jclouds/jclouds-labs/labels{/name}","releases_url":"https://api.github.com/repos/jclouds/jclouds-labs/releases{/id}","deployments_url":"https://api.github.com/repos/jclouds/jclouds-labs/deployments","created_at":"2013-05-13T20:47:47Z","updated_at":"2018-07-31T20:16:59Z","pushed_at":"2018-08-01T14:53:49Z","git_url":"git://github.com/jclouds/jclouds-labs.git","ssh_url":"git@github.com:jclouds/jclouds-labs.git","clone_url":"https://github.com/jclouds/jclouds-labs.git","svn_url":"https://github.com/jclouds/jclouds-labs","homepage":null,"size":22947,"stargazers_count":42,"watchers_count":42,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":101,"open_issues":4,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443"},"html":{"href":"https://github.com/jclouds/jclouds-labs/pull/443"},"issue":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/443"},"comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/jclouds/jclouds-labs/statuses/39fef5305d6cdfb660ecee32244eba7e7f5f68b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nacx"}}