{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/pmdk/issues/2586","repository_url":"https://api.github.com/repos/pmem/pmdk","labels_url":"https://api.github.com/repos/pmem/pmdk/issues/2586/labels{/name}","comments_url":"https://api.github.com/repos/pmem/pmdk/issues/2586/comments","events_url":"https://api.github.com/repos/pmem/pmdk/issues/2586/events","html_url":"https://github.com/pmem/pmdk/pull/2586","id":294416796,"number":2586,"title":"common: clean up travis build matrix","user":{"login":"krzycz","id":8184299,"avatar_url":"https://avatars2.githubusercontent.com/u/8184299?v=4","gravatar_id":"","url":"https://api.github.com/users/krzycz","html_url":"https://github.com/krzycz","followers_url":"https://api.github.com/users/krzycz/followers","following_url":"https://api.github.com/users/krzycz/following{/other_user}","gists_url":"https://api.github.com/users/krzycz/gists{/gist_id}","starred_url":"https://api.github.com/users/krzycz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzycz/subscriptions","organizations_url":"https://api.github.com/users/krzycz/orgs","repos_url":"https://api.github.com/users/krzycz/repos","events_url":"https://api.github.com/users/krzycz/events{/privacy}","received_events_url":"https://api.github.com/users/krzycz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-05T14:43:48Z","updated_at":"2018-02-07T10:03:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pmem/pmdk/pulls/2586","html_url":"https://github.com/pmem/pmdk/pull/2586","diff_url":"https://github.com/pmem/pmdk/pull/2586.diff","patch_url":"https://github.com/pmem/pmdk/pull/2586.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/pmdk/2586)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/pmem/pmdk/issues/comments/363718312","html_url":"https://github.com/pmem/pmdk/pull/2586#issuecomment-363718312","issue_url":"https://api.github.com/repos/pmem/pmdk/issues/2586","id":363718312,"user":{"login":"wlemkows","id":19204460,"avatar_url":"https://avatars3.githubusercontent.com/u/19204460?v=4","gravatar_id":"","url":"https://api.github.com/users/wlemkows","html_url":"https://github.com/wlemkows","followers_url":"https://api.github.com/users/wlemkows/followers","following_url":"https://api.github.com/users/wlemkows/following{/other_user}","gists_url":"https://api.github.com/users/wlemkows/gists{/gist_id}","starred_url":"https://api.github.com/users/wlemkows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlemkows/subscriptions","organizations_url":"https://api.github.com/users/wlemkows/orgs","repos_url":"https://api.github.com/users/wlemkows/repos","events_url":"https://api.github.com/users/wlemkows/events{/privacy}","received_events_url":"https://api.github.com/users/wlemkows/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T10:03:25Z","updated_at":"2018-02-07T10:03:25Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[.travis.yml, line 37 at r2](https://reviewable.io:443/reviews/pmem/pmdk/2586#-L4aQ4tt9xc9HAPGw3LO-r2-37:-L4ji2kMauv4T1mA6sE4:b-8fx2u7) ([raw file](https://github.com/pmem/pmdk/blob/83b32f83c1233fa404230bf3522037755e534096/.travis.yml#L37)):*\n<details><summary><i>Previously, krzycz (Krzysztof Czurylo) wrote…</i></summary><blockquote>\n\nHmmm. Now I see it would be more elegant to use flags like \"WITH_VALGRIND=0|1\" and based on that set EXTRA_CFLAGS inside build-travis.sh.\nSame for LIBCPP_LIBDIR/INCDIR or PMDX_CXX (could be set based on PMDK_CC) , etc.\n</blockquote></details>\n\n:+1: \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/pmem/pmdk/2586)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"wlemkows"}}