{"action":"created","comment":{"url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/comments/234863624","pull_request_review_id":176596868,"id":234863624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDg2MzYyNA==","diff_hunk":"@@ -91,6 +91,9 @@ env:\n    - C=picorv32     P=mimasv2          T=\"base\"\n    - C=picorv32     P=opsis            T=\"base net\"\n    - C=picorv32     P=tinyfpga_bx      T=\"base\"      F=stub\n+   # picorv32 minimal\n+   - C=picorv32.minimal P=arty   T=\"base net\"","path":".travis.yml","position":5,"original_position":5,"commit_id":"598d83071c091b925bbe5b00c3a462665d7e55d8","original_commit_id":"598d83071c091b925bbe5b00c3a462665d7e55d8","user":{"login":"mithro","id":21212,"node_id":"MDQ6VXNlcjIxMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/21212?v=4","gravatar_id":"","url":"https://api.github.com/users/mithro","html_url":"https://github.com/mithro","followers_url":"https://api.github.com/users/mithro/followers","following_url":"https://api.github.com/users/mithro/following{/other_user}","gists_url":"https://api.github.com/users/mithro/gists{/gist_id}","starred_url":"https://api.github.com/users/mithro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mithro/subscriptions","organizations_url":"https://api.github.com/users/mithro/orgs","repos_url":"https://api.github.com/users/mithro/repos","events_url":"https://api.github.com/users/mithro/events{/privacy}","received_events_url":"https://api.github.com/users/mithro/received_events","type":"User","site_admin":false},"body":"Formatting","created_at":"2018-11-20T04:09:18Z","updated_at":"2018-11-20T04:09:19Z","html_url":"https://github.com/timvideos/litex-buildenv/pull/105#discussion_r234863624","pull_request_url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/comments/234863624"},"html":{"href":"https://github.com/timvideos/litex-buildenv/pull/105#discussion_r234863624"},"pull_request":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105","id":232177968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTc3OTY4","html_url":"https://github.com/timvideos/litex-buildenv/pull/105","diff_url":"https://github.com/timvideos/litex-buildenv/pull/105.diff","patch_url":"https://github.com/timvideos/litex-buildenv/pull/105.patch","issue_url":"https://api.github.com/repos/timvideos/litex-buildenv/issues/105","number":105,"state":"open","locked":false,"title":"Riscv32 Support","user":{"login":"cr1901","id":6418027,"node_id":"MDQ6VXNlcjY0MTgwMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6418027?v=4","gravatar_id":"","url":"https://api.github.com/users/cr1901","html_url":"https://github.com/cr1901","followers_url":"https://api.github.com/users/cr1901/followers","following_url":"https://api.github.com/users/cr1901/following{/other_user}","gists_url":"https://api.github.com/users/cr1901/gists{/gist_id}","starred_url":"https://api.github.com/users/cr1901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr1901/subscriptions","organizations_url":"https://api.github.com/users/cr1901/orgs","repos_url":"https://api.github.com/users/cr1901/repos","events_url":"https://api.github.com/users/cr1901/events{/privacy}","received_events_url":"https://api.github.com/users/cr1901/received_events","type":"User","site_admin":false},"body":"This PR adds tested support for PicoRV32 for the following platforms:\r\n* `arty`, including BIOS, micropython boot, and the `litex` module.\r\n* `icebreaker`, including BIOS, micropython boot; using the `litex` module currently causes the CPU to lock up.\r\n\r\nWhile `picorv32` was already part of the build matrix for `arty`, getting `picorv32` to actually _boot_ required a few changes to the runtime code due to a synthesis-time/hardcoded IRQ vector.<sup>1</sup>\r\n\r\nI'm currently looking into the `litex` crash on `icebreaker`. Other targets should follow shortly.\r\n\r\n1. _I do not recommend using picorv32 with `mimasv2`._ `mimasv2` is unique in that the BIOS runs XIP while the actual firmware (such as `micropython`) runs from DRAM. Due to the hardcoded IRQ vector, this means that all interrupts must access the very slow flash at least as part of the interrupt prologue.\r\n\r\n      Running interrupts from flash isn't unique in `litex-buildenv`, but this is the only case where I can think of where which CPU you choose drastically changes the performance of interrupts.","created_at":"2018-11-20T03:04:40Z","updated_at":"2018-11-20T04:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0646af46183303597e9ce8851717c61d26ff526","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":809489574,"node_id":"MDU6TGFiZWw4MDk0ODk1NzQ=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/board-arty","name":"board-arty","color":"ededed","default":false},{"id":809489575,"node_id":"MDU6TGFiZWw4MDk0ODk1NzU=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/boards-artix7","name":"boards-artix7","color":"ededed","default":false},{"id":855872809,"node_id":"MDU6TGFiZWw4NTU4NzI4MDk=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/firmware-fpga","name":"firmware-fpga","color":"ededed","default":false},{"id":809426267,"node_id":"MDU6TGFiZWw4MDk0MjYyNjc=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/firmware-softcpu","name":"firmware-softcpu","color":"ededed","default":false},{"id":808546589,"node_id":"MDU6TGFiZWw4MDg1NDY1ODk=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/hdmi2***","name":"hdmi2***","color":"ededed","default":false},{"id":809426268,"node_id":"MDU6TGFiZWw4MDk0MjYyNjg=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/level-firmware","name":"level-firmware","color":"ededed","default":false},{"id":808289220,"node_id":"MDU6TGFiZWw4MDgyODkyMjA=","url":"https://api.github.com/repos/timvideos/litex-buildenv/labels/level-infrastructure","name":"level-infrastructure","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105/commits","review_comments_url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105/comments","review_comment_url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/timvideos/litex-buildenv/issues/105/comments","statuses_url":"https://api.github.com/repos/timvideos/litex-buildenv/statuses/598d83071c091b925bbe5b00c3a462665d7e55d8","head":{"label":"cr1901:riscv32","ref":"riscv32","sha":"598d83071c091b925bbe5b00c3a462665d7e55d8","user":{"login":"cr1901","id":6418027,"node_id":"MDQ6VXNlcjY0MTgwMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6418027?v=4","gravatar_id":"","url":"https://api.github.com/users/cr1901","html_url":"https://github.com/cr1901","followers_url":"https://api.github.com/users/cr1901/followers","following_url":"https://api.github.com/users/cr1901/following{/other_user}","gists_url":"https://api.github.com/users/cr1901/gists{/gist_id}","starred_url":"https://api.github.com/users/cr1901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr1901/subscriptions","organizations_url":"https://api.github.com/users/cr1901/orgs","repos_url":"https://api.github.com/users/cr1901/repos","events_url":"https://api.github.com/users/cr1901/events{/privacy}","received_events_url":"https://api.github.com/users/cr1901/received_events","type":"User","site_admin":false},"repo":{"id":117318209,"node_id":"MDEwOlJlcG9zaXRvcnkxMTczMTgyMDk=","name":"litex-buildenv","full_name":"cr1901/litex-buildenv","private":false,"owner":{"login":"cr1901","id":6418027,"node_id":"MDQ6VXNlcjY0MTgwMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6418027?v=4","gravatar_id":"","url":"https://api.github.com/users/cr1901","html_url":"https://github.com/cr1901","followers_url":"https://api.github.com/users/cr1901/followers","following_url":"https://api.github.com/users/cr1901/following{/other_user}","gists_url":"https://api.github.com/users/cr1901/gists{/gist_id}","starred_url":"https://api.github.com/users/cr1901/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cr1901/subscriptions","organizations_url":"https://api.github.com/users/cr1901/orgs","repos_url":"https://api.github.com/users/cr1901/repos","events_url":"https://api.github.com/users/cr1901/events{/privacy}","received_events_url":"https://api.github.com/users/cr1901/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cr1901/litex-buildenv","description":"An environment for building LiteX based FPGA designs. Makes it easy to get everything you need!","fork":true,"url":"https://api.github.com/repos/cr1901/litex-buildenv","forks_url":"https://api.github.com/repos/cr1901/litex-buildenv/forks","keys_url":"https://api.github.com/repos/cr1901/litex-buildenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cr1901/litex-buildenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cr1901/litex-buildenv/teams","hooks_url":"https://api.github.com/repos/cr1901/litex-buildenv/hooks","issue_events_url":"https://api.github.com/repos/cr1901/litex-buildenv/issues/events{/number}","events_url":"https://api.github.com/repos/cr1901/litex-buildenv/events","assignees_url":"https://api.github.com/repos/cr1901/litex-buildenv/assignees{/user}","branches_url":"https://api.github.com/repos/cr1901/litex-buildenv/branches{/branch}","tags_url":"https://api.github.com/repos/cr1901/litex-buildenv/tags","blobs_url":"https://api.github.com/repos/cr1901/litex-buildenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cr1901/litex-buildenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cr1901/litex-buildenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/cr1901/litex-buildenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cr1901/litex-buildenv/statuses/{sha}","languages_url":"https://api.github.com/repos/cr1901/litex-buildenv/languages","stargazers_url":"https://api.github.com/repos/cr1901/litex-buildenv/stargazers","contributors_url":"https://api.github.com/repos/cr1901/litex-buildenv/contributors","subscribers_url":"https://api.github.com/repos/cr1901/litex-buildenv/subscribers","subscription_url":"https://api.github.com/repos/cr1901/litex-buildenv/subscription","commits_url":"https://api.github.com/repos/cr1901/litex-buildenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/cr1901/litex-buildenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/cr1901/litex-buildenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/cr1901/litex-buildenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/cr1901/litex-buildenv/contents/{+path}","compare_url":"https://api.github.com/repos/cr1901/litex-buildenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cr1901/litex-buildenv/merges","archive_url":"https://api.github.com/repos/cr1901/litex-buildenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cr1901/litex-buildenv/downloads","issues_url":"https://api.github.com/repos/cr1901/litex-buildenv/issues{/number}","pulls_url":"https://api.github.com/repos/cr1901/litex-buildenv/pulls{/number}","milestones_url":"https://api.github.com/repos/cr1901/litex-buildenv/milestones{/number}","notifications_url":"https://api.github.com/repos/cr1901/litex-buildenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cr1901/litex-buildenv/labels{/name}","releases_url":"https://api.github.com/repos/cr1901/litex-buildenv/releases{/id}","deployments_url":"https://api.github.com/repos/cr1901/litex-buildenv/deployments","created_at":"2018-01-13T05:51:38Z","updated_at":"2018-09-05T20:37:59Z","pushed_at":"2018-11-20T03:53:18Z","git_url":"git://github.com/cr1901/litex-buildenv.git","ssh_url":"git@github.com:cr1901/litex-buildenv.git","clone_url":"https://github.com/cr1901/litex-buildenv.git","svn_url":"https://github.com/cr1901/litex-buildenv","homepage":null,"size":8252,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"timvideos:master","ref":"master","sha":"a33050bfddcea81d650df5a5361ee50cc4940e39","user":{"login":"timvideos","id":811205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTIwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/811205?v=4","gravatar_id":"","url":"https://api.github.com/users/timvideos","html_url":"https://github.com/timvideos","followers_url":"https://api.github.com/users/timvideos/followers","following_url":"https://api.github.com/users/timvideos/following{/other_user}","gists_url":"https://api.github.com/users/timvideos/gists{/gist_id}","starred_url":"https://api.github.com/users/timvideos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvideos/subscriptions","organizations_url":"https://api.github.com/users/timvideos/orgs","repos_url":"https://api.github.com/users/timvideos/repos","events_url":"https://api.github.com/users/timvideos/events{/privacy}","received_events_url":"https://api.github.com/users/timvideos/received_events","type":"Organization","site_admin":false},"repo":{"id":115785208,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3ODUyMDg=","name":"litex-buildenv","full_name":"timvideos/litex-buildenv","private":false,"owner":{"login":"timvideos","id":811205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTIwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/811205?v=4","gravatar_id":"","url":"https://api.github.com/users/timvideos","html_url":"https://github.com/timvideos","followers_url":"https://api.github.com/users/timvideos/followers","following_url":"https://api.github.com/users/timvideos/following{/other_user}","gists_url":"https://api.github.com/users/timvideos/gists{/gist_id}","starred_url":"https://api.github.com/users/timvideos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timvideos/subscriptions","organizations_url":"https://api.github.com/users/timvideos/orgs","repos_url":"https://api.github.com/users/timvideos/repos","events_url":"https://api.github.com/users/timvideos/events{/privacy}","received_events_url":"https://api.github.com/users/timvideos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/timvideos/litex-buildenv","description":"An environment for building LiteX based FPGA designs. Makes it easy to get everything you need!","fork":false,"url":"https://api.github.com/repos/timvideos/litex-buildenv","forks_url":"https://api.github.com/repos/timvideos/litex-buildenv/forks","keys_url":"https://api.github.com/repos/timvideos/litex-buildenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timvideos/litex-buildenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timvideos/litex-buildenv/teams","hooks_url":"https://api.github.com/repos/timvideos/litex-buildenv/hooks","issue_events_url":"https://api.github.com/repos/timvideos/litex-buildenv/issues/events{/number}","events_url":"https://api.github.com/repos/timvideos/litex-buildenv/events","assignees_url":"https://api.github.com/repos/timvideos/litex-buildenv/assignees{/user}","branches_url":"https://api.github.com/repos/timvideos/litex-buildenv/branches{/branch}","tags_url":"https://api.github.com/repos/timvideos/litex-buildenv/tags","blobs_url":"https://api.github.com/repos/timvideos/litex-buildenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timvideos/litex-buildenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timvideos/litex-buildenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/timvideos/litex-buildenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timvideos/litex-buildenv/statuses/{sha}","languages_url":"https://api.github.com/repos/timvideos/litex-buildenv/languages","stargazers_url":"https://api.github.com/repos/timvideos/litex-buildenv/stargazers","contributors_url":"https://api.github.com/repos/timvideos/litex-buildenv/contributors","subscribers_url":"https://api.github.com/repos/timvideos/litex-buildenv/subscribers","subscription_url":"https://api.github.com/repos/timvideos/litex-buildenv/subscription","commits_url":"https://api.github.com/repos/timvideos/litex-buildenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/timvideos/litex-buildenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/timvideos/litex-buildenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/timvideos/litex-buildenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/timvideos/litex-buildenv/contents/{+path}","compare_url":"https://api.github.com/repos/timvideos/litex-buildenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timvideos/litex-buildenv/merges","archive_url":"https://api.github.com/repos/timvideos/litex-buildenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timvideos/litex-buildenv/downloads","issues_url":"https://api.github.com/repos/timvideos/litex-buildenv/issues{/number}","pulls_url":"https://api.github.com/repos/timvideos/litex-buildenv/pulls{/number}","milestones_url":"https://api.github.com/repos/timvideos/litex-buildenv/milestones{/number}","notifications_url":"https://api.github.com/repos/timvideos/litex-buildenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timvideos/litex-buildenv/labels{/name}","releases_url":"https://api.github.com/repos/timvideos/litex-buildenv/releases{/id}","deployments_url":"https://api.github.com/repos/timvideos/litex-buildenv/deployments","created_at":"2017-12-30T08:50:22Z","updated_at":"2018-11-14T03:24:27Z","pushed_at":"2018-11-20T03:53:19Z","git_url":"git://github.com/timvideos/litex-buildenv.git","ssh_url":"git@github.com:timvideos/litex-buildenv.git","clone_url":"https://github.com/timvideos/litex-buildenv.git","svn_url":"https://github.com/timvideos/litex-buildenv","homepage":null,"size":8224,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":27,"open_issues":32,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105"},"html":{"href":"https://github.com/timvideos/litex-buildenv/pull/105"},"issue":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/issues/105"},"comments":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/timvideos/litex-buildenv/statuses/598d83071c091b925bbe5b00c3a462665d7e55d8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mithro"}}