{"push_id":3111642317,"size":12,"distinct_size":8,"ref":"refs/heads/packager-debug-log","head":"269713fd394f54febcef434b14105301afcd7eeb","before":"799b961da9c8fa214a693e8a557eec0e8f225e6b","commits":[{"sha":"da36bcc6a5645bd5ac5996a38024a181e2655ee9","author":{"name":"stealthycoin","email":"2eb47a78c2b695b7e561e86cd6ec73851ddbd672@users.noreply.github.com"},"message":"Add support for python 3.7\n\nLambda now supports python3.7. This commit adds support for packaging\nyour Chalice app, and deploying it to python 3.7.","distinct":false,"url":"https://api.github.com/repos/jamesls/chalice/commits/da36bcc6a5645bd5ac5996a38024a181e2655ee9"},{"sha":"5badfe81aafc15b5e89d5ad550d3f58455c61acc","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Fix flake8 warnings by using latest version\n\nWas getting FutureWarnings about set syntax with the version\nof flake8 we use.  Upgrading to flake8 fixed this bug but we\nstarted getting errors about line breaks before a binary operator\n(W504).  It appears pep8 has changed its default guidance:\n\nhttps://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator\n\n> In Python code, it is permissible to break before or after a binary\n> operator, as long as the convention is consistent locally. For new code\n> Knuth's style is suggested.\n\nGiven this isn't new code, we'll keep  our existing convention\nand ignore the new guidance.","distinct":false,"url":"https://api.github.com/repos/jamesls/chalice/commits/5badfe81aafc15b5e89d5ad550d3f58455c61acc"},{"sha":"5d5a26fd05e09cea13d31023e3a66d865845f5a3","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Get pylint working with py37\n\nI needed to upgrade to pylint >= 2, as\nthe old pylint does not work on python 3.7.\nYou'll get an error of:\n\n```\n...\nFile \"astroid/decorators.py\", line 138, in raise_if_nothing_inferred\n  yield next(generator)\n\nRuntimeError: generator raised StopIteration\n```\n\nHowever ugprade from pylint 1.x to 2.x introduced new linting issues\nI had to fix.  In most cases I opted to keep our existing standards\nand disable any new checks that were failing.  These were primarily\nrefactoring warnings:\n\nR0205: Class 'BaseType' inherits from object, can be safely removed from bases in python3 (useless-object-inheritance)\nR1705: Unnecessary \"elif\" after \"return\" (no-else-return)\nR1710: Either all return statements in a function should return an expression, or none of them should. (inconsistent-return-statements)\n\nThe only slightly invasive change is renaming all the mypy custom types\nwe use from `UPPER_SNAKE` to `CamelCase` types.","distinct":false,"url":"https://api.github.com/repos/jamesls/chalice/commits/5d5a26fd05e09cea13d31023e3a66d865845f5a3"},{"sha":"78f2d8c08db2c0f7cdea3a78a633c78b7155aea0","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Remove incorrect package replacement","distinct":false,"url":"https://api.github.com/repos/jamesls/chalice/commits/78f2d8c08db2c0f7cdea3a78a633c78b7155aea0"},{"sha":"27aa55e3cf153d13cd4eea32764f605b697cc209","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Fix typo bug in lambda python version detection\n\nAlso made the logic slightly more explicit.","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/27aa55e3cf153d13cd4eea32764f605b697cc209"},{"sha":"5be4f2537ffaee65f948760d8e1bf239c205034b","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Ignore relative-import error to get pylint working on py2","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/5be4f2537ffaee65f948760d8e1bf239c205034b"},{"sha":"62404864c807b1bf791e2db698fb8c825db3d4ee","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Fix pylint version env marker for py2","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/62404864c807b1bf791e2db698fb8c825db3d4ee"},{"sha":"ee5e18e5b7e89507f65dadfa777c971032af974c","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Fix typecheck error","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/ee5e18e5b7e89507f65dadfa777c971032af974c"},{"sha":"d59be4d27abdd5614187f7405851b1d7d4c3a53a","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Use not foo == bar\n\nThis will trigger the __eq__ method which is what we actually\nwant to test.","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/d59be4d27abdd5614187f7405851b1d7d4c3a53a"},{"sha":"eb44a565f201ea62948fa8161d5f91c5875a5c73","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Merge branch 'python-37-support'\n\nPR #992\n\n* python-37-support:\n  Use not foo == bar\n  Fix typecheck error\n  Fix pylint version env marker for py2\n  Ignore relative-import error to get pylint working on py2\n  Fix typo bug in lambda python version detection\n  Remove incorrect package replacement\n  Get pylint working with py37\n  Fix flake8 warnings by using latest version\n  Add support for python 3.7","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/eb44a565f201ea62948fa8161d5f91c5875a5c73"},{"sha":"c9a5e13507908ffe6be44551569ecdbc9ff28ac6","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Add py37 to changelog","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/c9a5e13507908ffe6be44551569ecdbc9ff28ac6"},{"sha":"269713fd394f54febcef434b14105301afcd7eeb","author":{"name":"James Saryerwinnie","email":"93f8bb0eb2c659b85694486c41717eaf0fe23cd4@jamesls.com"},"message":"Verify we see a debug log from chalice code\n\nThe existing test_debug_flag_enables_logging test\nwas relying on a debug message being present from botocore.\nIf you package an empty project with nothing in requirements.txt\nyou'll get:\n\n```\n$ chalice --debug package out5\n2018-12-05 15:27:26,586 botocore.hooks [DEBUG] Changing event name from creating-client-class.iot-data to creating-client-class.iot-data-plane\n2018-12-05 15:27:26,590 botocore.hooks [DEBUG] Changing event name from before-call.apigateway to before-call.api-gateway\n2018-12-05 15:27:26,591 botocore.hooks [DEBUG] Changing event name from request-created.machinelearning.Predict to request-created.machine-learning.Predict\n...\n```\n\nwhich all come from botocore when you create a client.\nThe issue is that those messages in botocore are only present in\nversions of botocore after the \"service id\" switchover.  Our\nversion range dependency of botocore includes versions of botocore\nbefore we switched the internal to user service id.  As a result\nthis test can fail if you have old (but allowed) version of\nbotocore installed.\n\nThe fix is to explicitly verify a debug message from within\nthe chalice code base so it's something we can control.  I added\na debug message to the packager that's in every code path\nto ensure we see debug logs.","distinct":true,"url":"https://api.github.com/repos/jamesls/chalice/commits/269713fd394f54febcef434b14105301afcd7eeb"}]}
{"actor":{"display_login":"jamesls"}}