{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/719","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/719/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/719/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/719/events","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/issues/719","id":312187180,"number":719,"title":"Option to disable automatic tracing","user":{"login":"tjmehta","id":640279,"avatar_url":"https://avatars0.githubusercontent.com/u/640279?v=4","gravatar_id":"","url":"https://api.github.com/users/tjmehta","html_url":"https://github.com/tjmehta","followers_url":"https://api.github.com/users/tjmehta/followers","following_url":"https://api.github.com/users/tjmehta/following{/other_user}","gists_url":"https://api.github.com/users/tjmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmehta/subscriptions","organizations_url":"https://api.github.com/users/tjmehta/orgs","repos_url":"https://api.github.com/users/tjmehta/repos","events_url":"https://api.github.com/users/tjmehta/events{/privacy}","received_events_url":"https://api.github.com/users/tjmehta/received_events","type":"User","site_admin":false},"labels":[{"id":592763495,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"kjin","id":2365820,"avatar_url":"https://avatars3.githubusercontent.com/u/2365820?v=4","gravatar_id":"","url":"https://api.github.com/users/kjin","html_url":"https://github.com/kjin","followers_url":"https://api.github.com/users/kjin/followers","following_url":"https://api.github.com/users/kjin/following{/other_user}","gists_url":"https://api.github.com/users/kjin/gists{/gist_id}","starred_url":"https://api.github.com/users/kjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjin/subscriptions","organizations_url":"https://api.github.com/users/kjin/orgs","repos_url":"https://api.github.com/users/kjin/repos","events_url":"https://api.github.com/users/kjin/events{/privacy}","received_events_url":"https://api.github.com/users/kjin/received_events","type":"User","site_admin":false},"assignees":[{"login":"kjin","id":2365820,"avatar_url":"https://avatars3.githubusercontent.com/u/2365820?v=4","gravatar_id":"","url":"https://api.github.com/users/kjin","html_url":"https://github.com/kjin","followers_url":"https://api.github.com/users/kjin/followers","following_url":"https://api.github.com/users/kjin/following{/other_user}","gists_url":"https://api.github.com/users/kjin/gists{/gist_id}","starred_url":"https://api.github.com/users/kjin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjin/subscriptions","organizations_url":"https://api.github.com/users/kjin/orgs","repos_url":"https://api.github.com/users/kjin/repos","events_url":"https://api.github.com/users/kjin/events{/privacy}","received_events_url":"https://api.github.com/users/kjin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-04-07T08:41:08Z","updated_at":"2018-04-16T16:52:06Z","closed_at":"2018-04-16T16:01:48Z","author_association":"NONE","body":"Hello,\r\n\r\nIs there any way to disable automatic tracing altogether? It would be nice if this module exposed a simple span tracing API. \r\n\r\nThanks"},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/comments/381673911","html_url":"https://github.com/GoogleCloudPlatform/cloud-trace-nodejs/issues/719#issuecomment-381673911","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-trace-nodejs/issues/719","id":381673911,"user":{"login":"tjmehta","id":640279,"avatar_url":"https://avatars0.githubusercontent.com/u/640279?v=4","gravatar_id":"","url":"https://api.github.com/users/tjmehta","html_url":"https://github.com/tjmehta","followers_url":"https://api.github.com/users/tjmehta/followers","following_url":"https://api.github.com/users/tjmehta/following{/other_user}","gists_url":"https://api.github.com/users/tjmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/tjmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjmehta/subscriptions","organizations_url":"https://api.github.com/users/tjmehta/orgs","repos_url":"https://api.github.com/users/tjmehta/repos","events_url":"https://api.github.com/users/tjmehta/events{/privacy}","received_events_url":"https://api.github.com/users/tjmehta/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T16:52:06Z","updated_at":"2018-04-16T16:52:06Z","author_association":"NONE","body":"In my experience, CLS support for various asynchronous operations is not guaranteed. It would be nice to have a simple span API that can be managed by the user without “magic”. Also, CLS’s monkey patching can lead to messier error stacks. If you are able to remove CLS from a base RootSpan class. You easily extend the class and layer CLS on top of it.\r\n\r\nExposing a base API would be more flexible for users to build custom app tracing helpers from.\r\n\r\nI have modified this library in the past to expose a RootSpan class where I can “createChildSpan”s and pass the spans around my application. My http/websockets api uses the req (or socket) as a common context that is accessible by all my functions. It’s nice to avoid monkey patching when it isn’t required."}}
{"actor":{"display_login":"tjmehta"}}