{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments/206333025","pull_request_review_id":141729826,"id":206333025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjMzMzAyNQ==","diff_hunk":"@@ -2123,7 +2123,7 @@ OO.Ads.manager(function(_, $) {\n       var mediaFile = linearXml.find(\"MediaFile\");\n \n       parseTrackingEvents(result.tracking, linearXml);\n-      if (mediaFile.size() > 0) {\n+      if (mediaFile.length > 0) {","path":"js/ad_manager_vast.js","position":14,"original_position":14,"commit_id":"05a6a7a11cde01205dc21f97b44b04c3278e2504","original_commit_id":"05a6a7a11cde01205dc21f97b44b04c3278e2504","user":{"login":"aeng7","id":14931241,"node_id":"MDQ6VXNlcjE0OTMxMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/14931241?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng7","html_url":"https://github.com/aeng7","followers_url":"https://api.github.com/users/aeng7/followers","following_url":"https://api.github.com/users/aeng7/following{/other_user}","gists_url":"https://api.github.com/users/aeng7/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng7/subscriptions","organizations_url":"https://api.github.com/users/aeng7/orgs","repos_url":"https://api.github.com/users/aeng7/repos","events_url":"https://api.github.com/users/aeng7/events{/privacy}","received_events_url":"https://api.github.com/users/aeng7/received_events","type":"User","site_admin":false},"body":"This should still be fine. The .length returns the same value as .size(). Both of these APIs have existed since version 1.0 of jquery:\r\n\r\nhttps://api.jquery.com/length/","created_at":"2018-07-30T21:46:34Z","updated_at":"2018-07-30T21:46:34Z","html_url":"https://github.com/ooyala/html5-ad-plugins/pull/269#discussion_r206333025","pull_request_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments/206333025"},"html":{"href":"https://github.com/ooyala/html5-ad-plugins/pull/269#discussion_r206333025"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269"}},"in_reply_to_id":203913365},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269","id":202719451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzE5NDUx","html_url":"https://github.com/ooyala/html5-ad-plugins/pull/269","diff_url":"https://github.com/ooyala/html5-ad-plugins/pull/269.diff","patch_url":"https://github.com/ooyala/html5-ad-plugins/pull/269.patch","issue_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/269","number":269,"state":"open","locked":false,"title":"Player 3986","user":{"login":"aeng7","id":14931241,"node_id":"MDQ6VXNlcjE0OTMxMjQx","avatar_url":"https://avatars3.githubusercontent.com/u/14931241?v=4","gravatar_id":"","url":"https://api.github.com/users/aeng7","html_url":"https://github.com/aeng7","followers_url":"https://api.github.com/users/aeng7/followers","following_url":"https://api.github.com/users/aeng7/following{/other_user}","gists_url":"https://api.github.com/users/aeng7/gists{/gist_id}","starred_url":"https://api.github.com/users/aeng7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeng7/subscriptions","organizations_url":"https://api.github.com/users/aeng7/orgs","repos_url":"https://api.github.com/users/aeng7/repos","events_url":"https://api.github.com/users/aeng7/events{/privacy}","received_events_url":"https://api.github.com/users/aeng7/received_events","type":"User","site_admin":false},"body":"Updating Node to 8.11.3 and allow for usage of ES6. DO NOT MERGE YET! Opening just for review. We'll need to update html5-common and the build scripts to accommodate for these Node updates","created_at":"2018-07-20T00:45:52Z","updated_at":"2018-07-30T21:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9b489a0c70f5a726cbfacb63cb5ee03c03668c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/269/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/05a6a7a11cde01205dc21f97b44b04c3278e2504","head":{"label":"ooyala:player-3986","ref":"player-3986","sha":"05a6a7a11cde01205dc21f97b44b04c3278e2504","user":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":33886489,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NjQ4OQ==","name":"html5-ad-plugins","full_name":"ooyala/html5-ad-plugins","owner":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-ad-plugins","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-ad-plugins","forks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/forks","keys_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/events","assignees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/merges","archive_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/deployments","created_at":"2015-04-13T18:37:19Z","updated_at":"2018-07-17T22:53:44Z","pushed_at":"2018-07-27T00:15:00Z","git_url":"git://github.com/ooyala/html5-ad-plugins.git","ssh_url":"git@github.com:ooyala/html5-ad-plugins.git","clone_url":"https://github.com/ooyala/html5-ad-plugins.git","svn_url":"https://github.com/ooyala/html5-ad-plugins","homepage":null,"size":1665,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":6,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"ooyala:master","ref":"master","sha":"47e8b01ad07e4263cddda4b6dee288c8ed32a313","user":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":33886489,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NjQ4OQ==","name":"html5-ad-plugins","full_name":"ooyala/html5-ad-plugins","owner":{"login":"ooyala","id":365274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTI3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/365274?v=4","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-ad-plugins","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-ad-plugins","forks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/forks","keys_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/events","assignees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/merges","archive_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/deployments","created_at":"2015-04-13T18:37:19Z","updated_at":"2018-07-17T22:53:44Z","pushed_at":"2018-07-27T00:15:00Z","git_url":"git://github.com/ooyala/html5-ad-plugins.git","ssh_url":"git@github.com:ooyala/html5-ad-plugins.git","clone_url":"https://github.com/ooyala/html5-ad-plugins.git","svn_url":"https://github.com/ooyala/html5-ad-plugins","homepage":null,"size":1665,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":6,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269"},"html":{"href":"https://github.com/ooyala/html5-ad-plugins/pull/269"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/269"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/05a6a7a11cde01205dc21f97b44b04c3278e2504"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aeng7"}}