{"action":"created","issue":{"url":"https://api.github.com/repos/ArkEcosystem/core/issues/655","repository_url":"https://api.github.com/repos/ArkEcosystem/core","labels_url":"https://api.github.com/repos/ArkEcosystem/core/issues/655/labels{/name}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/issues/655/comments","events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/655/events","html_url":"https://github.com/ArkEcosystem/core/pull/655","id":332919354,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Mjg3MTM2","number":655,"title":"Ensure that values are added and not concatenated","user":{"login":"ItsANameToo","id":35610748,"node_id":"MDQ6VXNlcjM1NjEwNzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/35610748?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsANameToo","html_url":"https://github.com/ItsANameToo","followers_url":"https://api.github.com/users/ItsANameToo/followers","following_url":"https://api.github.com/users/ItsANameToo/following{/other_user}","gists_url":"https://api.github.com/users/ItsANameToo/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsANameToo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsANameToo/subscriptions","organizations_url":"https://api.github.com/users/ItsANameToo/orgs","repos_url":"https://api.github.com/users/ItsANameToo/repos","events_url":"https://api.github.com/users/ItsANameToo/events{/privacy}","received_events_url":"https://api.github.com/users/ItsANameToo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-15T21:29:30Z","updated_at":"2018-06-15T21:38:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/655","html_url":"https://github.com/ArkEcosystem/core/pull/655","diff_url":"https://github.com/ArkEcosystem/core/pull/655.diff","patch_url":"https://github.com/ArkEcosystem/core/pull/655.patch"},"body":"## Proposed changes\r\nSo it seems that values needed to be added, but where concatenated instead (Wooh, JavaScript). This PR ensures that the values are being added (as intended) by converting them to `Number` first.\r\n\r\n## Types of changes\r\n\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply_\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Build (changes that affect the build system)\r\n- [ ] Docs (documentation only changes)\r\n- [ ] Test (adding missing tests or fixing existing tests)\r\n- [ ] Other... Please describe:\r\n\r\n## Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/docs/contributing) documentation\r\n- [ ] Lint and unit tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n"},"comment":{"url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments/397749143","html_url":"https://github.com/ArkEcosystem/core/pull/655#issuecomment-397749143","issue_url":"https://api.github.com/repos/ArkEcosystem/core/issues/655","id":397749143,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzc0OTE0Mw==","user":{"login":"ItsANameToo","id":35610748,"node_id":"MDQ6VXNlcjM1NjEwNzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/35610748?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsANameToo","html_url":"https://github.com/ItsANameToo","followers_url":"https://api.github.com/users/ItsANameToo/followers","following_url":"https://api.github.com/users/ItsANameToo/following{/other_user}","gists_url":"https://api.github.com/users/ItsANameToo/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsANameToo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsANameToo/subscriptions","organizations_url":"https://api.github.com/users/ItsANameToo/orgs","repos_url":"https://api.github.com/users/ItsANameToo/repos","events_url":"https://api.github.com/users/ItsANameToo/events{/privacy}","received_events_url":"https://api.github.com/users/ItsANameToo/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T21:38:43Z","updated_at":"2018-06-15T21:38:43Z","author_association":"NONE","body":"Before merging: please let me figure out how to test the change properly as I have no idea atm 😬 "}}
{"actor":{"display_login":"ItsANameToo"}}