{"action":"created","issue":{"url":"https://api.github.com/repos/akavel/up/issues/5","repository_url":"https://api.github.com/repos/akavel/up","labels_url":"https://api.github.com/repos/akavel/up/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/akavel/up/issues/5/comments","events_url":"https://api.github.com/repos/akavel/up/issues/5/events","html_url":"https://github.com/akavel/up/issues/5","id":373551659,"node_id":"MDU6SXNzdWUzNzM1NTE2NTk=","number":5,"title":"Make Warning more prominent ","user":{"login":"colbygk","id":192393,"node_id":"MDQ6VXNlcjE5MjM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/192393?v=4","gravatar_id":"","url":"https://api.github.com/users/colbygk","html_url":"https://github.com/colbygk","followers_url":"https://api.github.com/users/colbygk/followers","following_url":"https://api.github.com/users/colbygk/following{/other_user}","gists_url":"https://api.github.com/users/colbygk/gists{/gist_id}","starred_url":"https://api.github.com/users/colbygk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colbygk/subscriptions","organizations_url":"https://api.github.com/users/colbygk/orgs","repos_url":"https://api.github.com/users/colbygk/repos","events_url":"https://api.github.com/users/colbygk/events{/privacy}","received_events_url":"https://api.github.com/users/colbygk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-24T15:48:20Z","updated_at":"2018-10-24T16:47:22Z","closed_at":null,"author_association":"NONE","body":"At the risk of ignoring tongue in cheekiness; this warning seems too buried. Also there is a world of difference between \"being careful using rm or dd\" vs having a simple typo immediately be run as a command vs having to type something fully before hitting enter. I understand the impulse of closing this loop of iterate and see results; doing it this way though seems beyond dangerous.\r\n\r\n```\r\nWARNING: Please be careful when using it! It could be dangerous. In particular, writing \"rm\" or \"dd\" \r\ninto it could be like running around with a chainsaw. But you'd be careful writing \"rm\" anywhere in \r\nLinux anyway, no? Also, why would you want to pipe something into \"rm\"? Other than that, I don't \r\nreally have good ideas how to protect against cases like this. And in the other, non-dangerous \r\ncases, I find the tool immensely useful. If you have some ideas how to try to protect, please share! \r\nThat said, a tool wouldn't be really Unixy if you couldn't hurt yourself with it, right? ;P\r\n```"},"comment":{"url":"https://api.github.com/repos/akavel/up/issues/comments/432736876","html_url":"https://github.com/akavel/up/issues/5#issuecomment-432736876","issue_url":"https://api.github.com/repos/akavel/up/issues/5","id":432736876,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjczNjg3Ng==","user":{"login":"akavel","id":273837,"node_id":"MDQ6VXNlcjI3MzgzNw==","avatar_url":"https://avatars1.githubusercontent.com/u/273837?v=4","gravatar_id":"","url":"https://api.github.com/users/akavel","html_url":"https://github.com/akavel","followers_url":"https://api.github.com/users/akavel/followers","following_url":"https://api.github.com/users/akavel/following{/other_user}","gists_url":"https://api.github.com/users/akavel/gists{/gist_id}","starred_url":"https://api.github.com/users/akavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akavel/subscriptions","organizations_url":"https://api.github.com/users/akavel/orgs","repos_url":"https://api.github.com/users/akavel/repos","events_url":"https://api.github.com/users/akavel/events{/privacy}","received_events_url":"https://api.github.com/users/akavel/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T16:47:22Z","updated_at":"2018-10-24T16:47:22Z","author_association":"OWNER","body":"Hm; but what would you like me to say? And where?\r\n\r\nI cannot for now think of a way that this could be still useful as it is, while at the same time not being potentially dangerous.\r\n\r\nThat on the technical side. If you feel just changing the message would be enough: where and how would you suggest to put it? If I put it before I even explain what it is, I feel I could scare virtually everybody away from even trying it, by projecting an ominous first impression. I tried to put it quite early, just after explaining how to enter the command into the app...\r\n\r\nOr should I put it straight by the title of the app? How to make it prominent enough? \"up - a pipe building app, DANGEROUS, DON'T USE IT\"?\r\n\r\nOne thing I'm starting to think of, is that maybe it's not a good idea to use *up* with commands that *could change any permanent state of something* (such as writing to files, modifying/deleting them, accessing external web services, etc...). That might be the main message I'd like to try to publish... but not 100% sure about it yet; I'm just starting to think about it; still in an early stage of trying to collect initial thoughts after the public release, and still getting new feedback.\r\n\r\nWhat I'm trying to also say, is that I actually don't think it's *that* much more dangerous than xargs or bash. In particular, I haven't yet imagined a command one could easily type accidentally, that could be really disastrous. Even after typing \"rm\", you still need to type *something* that you want to remove. I can't yet see how this could be done *really* accidentally. And again, you usually don't pipe anything into \"rm\". One may want to try doing \"xargs rm\"; but then again, I don't see how it'd be easy to do accidentally as of now? And if I were to do this purposefully, I'd be careful even when writing this in regular bash; I wouldn't want to try doing it in *up* at any cost... like I wouldn't try driving a ferrari through a minefield...\r\n\r\nWith all that said, I'm totally into trying to invent ways to make it safer. I'm super open to ideas, already collecting some in a notebook, will try to think what to do with them further down the road. (E.g. a shortcut key for pausing/unpausing the \"immediate execution\" mode.) None of them seem 100% bullet-proof however, unfortunately. But neither bash/xargs are... Hm; actually the pausing/unpausing seems a reasonable cop-out, maybe... then one can choose the preferred mode... maybe even \"require enter to execute\" would be good enough for typical usage? Even if somewhat slower..."}}
{"actor":{"display_login":"akavel"}}