{"action":"created","comment":{"url":"https://api.github.com/repos/graphql-java/graphql-java/pulls/comments/211123206","pull_request_review_id":147479793,"id":211123206,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEyMzIwNg==","diff_hunk":"@@ -46,15 +48,15 @@ public DataFetchingEnvironmentImpl(Object source,\n                                        ExecutionTypeInfo fieldTypeInfo,\n                                        ExecutionContext executionContext) {\n         this.source = source;\n-        this.arguments = arguments;\n+        this.arguments = arguments == null ? Collections.emptyMap() : unmodifiableMap(arguments);","path":"src/main/java/graphql/schema/DataFetchingEnvironmentImpl.java","position":21,"original_position":21,"commit_id":"cea213fc3d1ccd4e28f1d976fa6dee39c4e97a81","original_commit_id":"cea213fc3d1ccd4e28f1d976fa6dee39c4e97a81","user":{"login":"andimarek","id":1706744,"node_id":"MDQ6VXNlcjE3MDY3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1706744?v=4","gravatar_id":"","url":"https://api.github.com/users/andimarek","html_url":"https://github.com/andimarek","followers_url":"https://api.github.com/users/andimarek/followers","following_url":"https://api.github.com/users/andimarek/following{/other_user}","gists_url":"https://api.github.com/users/andimarek/gists{/gist_id}","starred_url":"https://api.github.com/users/andimarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andimarek/subscriptions","organizations_url":"https://api.github.com/users/andimarek/orgs","repos_url":"https://api.github.com/users/andimarek/repos","events_url":"https://api.github.com/users/andimarek/events{/privacy}","received_events_url":"https://api.github.com/users/andimarek/received_events","type":"User","site_admin":false},"body":"can we instead of having a unmodifiable map, return always a copy in getArguments? I prefer it because it is less surprising for the client imho.","created_at":"2018-08-20T01:15:16Z","updated_at":"2018-08-20T01:15:29Z","html_url":"https://github.com/graphql-java/graphql-java/pull/1165#discussion_r211123206","pull_request_url":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graphql-java/graphql-java/pulls/comments/211123206"},"html":{"href":"https://github.com/graphql-java/graphql-java/pull/1165#discussion_r211123206"},"pull_request":{"href":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165"}}},"pull_request":{"url":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165","id":207568438,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTY4NDM4","html_url":"https://github.com/graphql-java/graphql-java/pull/1165","diff_url":"https://github.com/graphql-java/graphql-java/pull/1165.diff","patch_url":"https://github.com/graphql-java/graphql-java/pull/1165.patch","issue_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/1165","number":1165,"state":"open","locked":false,"title":"immutable arguments","user":{"login":"bbakerman","id":1661769,"node_id":"MDQ6VXNlcjE2NjE3Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/1661769?v=4","gravatar_id":"","url":"https://api.github.com/users/bbakerman","html_url":"https://github.com/bbakerman","followers_url":"https://api.github.com/users/bbakerman/followers","following_url":"https://api.github.com/users/bbakerman/following{/other_user}","gists_url":"https://api.github.com/users/bbakerman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbakerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbakerman/subscriptions","organizations_url":"https://api.github.com/users/bbakerman/orgs","repos_url":"https://api.github.com/users/bbakerman/repos","events_url":"https://api.github.com/users/bbakerman/events{/privacy}","received_events_url":"https://api.github.com/users/bbakerman/received_events","type":"User","site_admin":false},"body":"See 1158 ","created_at":"2018-08-10T10:18:08Z","updated_at":"2018-08-20T01:15:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6037c3b447f38045f19fd658562b273cabf51d39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165/commits","review_comments_url":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165/comments","review_comment_url":"https://api.github.com/repos/graphql-java/graphql-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/1165/comments","statuses_url":"https://api.github.com/repos/graphql-java/graphql-java/statuses/cea213fc3d1ccd4e28f1d976fa6dee39c4e97a81","head":{"label":"bbakerman:1158-immutable-arguments","ref":"1158-immutable-arguments","sha":"cea213fc3d1ccd4e28f1d976fa6dee39c4e97a81","user":{"login":"bbakerman","id":1661769,"node_id":"MDQ6VXNlcjE2NjE3Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/1661769?v=4","gravatar_id":"","url":"https://api.github.com/users/bbakerman","html_url":"https://github.com/bbakerman","followers_url":"https://api.github.com/users/bbakerman/followers","following_url":"https://api.github.com/users/bbakerman/following{/other_user}","gists_url":"https://api.github.com/users/bbakerman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbakerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbakerman/subscriptions","organizations_url":"https://api.github.com/users/bbakerman/orgs","repos_url":"https://api.github.com/users/bbakerman/repos","events_url":"https://api.github.com/users/bbakerman/events{/privacy}","received_events_url":"https://api.github.com/users/bbakerman/received_events","type":"User","site_admin":false},"repo":{"id":76249849,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI0OTg0OQ==","name":"graphql-java","full_name":"bbakerman/graphql-java","owner":{"login":"bbakerman","id":1661769,"node_id":"MDQ6VXNlcjE2NjE3Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/1661769?v=4","gravatar_id":"","url":"https://api.github.com/users/bbakerman","html_url":"https://github.com/bbakerman","followers_url":"https://api.github.com/users/bbakerman/followers","following_url":"https://api.github.com/users/bbakerman/following{/other_user}","gists_url":"https://api.github.com/users/bbakerman/gists{/gist_id}","starred_url":"https://api.github.com/users/bbakerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbakerman/subscriptions","organizations_url":"https://api.github.com/users/bbakerman/orgs","repos_url":"https://api.github.com/users/bbakerman/repos","events_url":"https://api.github.com/users/bbakerman/events{/privacy}","received_events_url":"https://api.github.com/users/bbakerman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bbakerman/graphql-java","description":"GraphQL Java implementation","fork":true,"url":"https://api.github.com/repos/bbakerman/graphql-java","forks_url":"https://api.github.com/repos/bbakerman/graphql-java/forks","keys_url":"https://api.github.com/repos/bbakerman/graphql-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bbakerman/graphql-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bbakerman/graphql-java/teams","hooks_url":"https://api.github.com/repos/bbakerman/graphql-java/hooks","issue_events_url":"https://api.github.com/repos/bbakerman/graphql-java/issues/events{/number}","events_url":"https://api.github.com/repos/bbakerman/graphql-java/events","assignees_url":"https://api.github.com/repos/bbakerman/graphql-java/assignees{/user}","branches_url":"https://api.github.com/repos/bbakerman/graphql-java/branches{/branch}","tags_url":"https://api.github.com/repos/bbakerman/graphql-java/tags","blobs_url":"https://api.github.com/repos/bbakerman/graphql-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bbakerman/graphql-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bbakerman/graphql-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/bbakerman/graphql-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bbakerman/graphql-java/statuses/{sha}","languages_url":"https://api.github.com/repos/bbakerman/graphql-java/languages","stargazers_url":"https://api.github.com/repos/bbakerman/graphql-java/stargazers","contributors_url":"https://api.github.com/repos/bbakerman/graphql-java/contributors","subscribers_url":"https://api.github.com/repos/bbakerman/graphql-java/subscribers","subscription_url":"https://api.github.com/repos/bbakerman/graphql-java/subscription","commits_url":"https://api.github.com/repos/bbakerman/graphql-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/bbakerman/graphql-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/bbakerman/graphql-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/bbakerman/graphql-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/bbakerman/graphql-java/contents/{+path}","compare_url":"https://api.github.com/repos/bbakerman/graphql-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bbakerman/graphql-java/merges","archive_url":"https://api.github.com/repos/bbakerman/graphql-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bbakerman/graphql-java/downloads","issues_url":"https://api.github.com/repos/bbakerman/graphql-java/issues{/number}","pulls_url":"https://api.github.com/repos/bbakerman/graphql-java/pulls{/number}","milestones_url":"https://api.github.com/repos/bbakerman/graphql-java/milestones{/number}","notifications_url":"https://api.github.com/repos/bbakerman/graphql-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bbakerman/graphql-java/labels{/name}","releases_url":"https://api.github.com/repos/bbakerman/graphql-java/releases{/id}","deployments_url":"https://api.github.com/repos/bbakerman/graphql-java/deployments","created_at":"2016-12-12T11:20:32Z","updated_at":"2018-08-16T09:49:25Z","pushed_at":"2018-08-17T08:00:37Z","git_url":"git://github.com/bbakerman/graphql-java.git","ssh_url":"git@github.com:bbakerman/graphql-java.git","clone_url":"https://github.com/bbakerman/graphql-java.git","svn_url":"https://github.com/bbakerman/graphql-java","homepage":"","size":4871,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"graphql-java:master","ref":"master","sha":"4c0c33a12024684b334dcbe7789c6c39cc1b2cc4","user":{"login":"graphql-java","id":14289921,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mjg5OTIx","avatar_url":"https://avatars3.githubusercontent.com/u/14289921?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-java","html_url":"https://github.com/graphql-java","followers_url":"https://api.github.com/users/graphql-java/followers","following_url":"https://api.github.com/users/graphql-java/following{/other_user}","gists_url":"https://api.github.com/users/graphql-java/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-java/subscriptions","organizations_url":"https://api.github.com/users/graphql-java/orgs","repos_url":"https://api.github.com/users/graphql-java/repos","events_url":"https://api.github.com/users/graphql-java/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-java/received_events","type":"Organization","site_admin":false},"repo":{"id":38602457,"node_id":"MDEwOlJlcG9zaXRvcnkzODYwMjQ1Nw==","name":"graphql-java","full_name":"graphql-java/graphql-java","owner":{"login":"graphql-java","id":14289921,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mjg5OTIx","avatar_url":"https://avatars3.githubusercontent.com/u/14289921?v=4","gravatar_id":"","url":"https://api.github.com/users/graphql-java","html_url":"https://github.com/graphql-java","followers_url":"https://api.github.com/users/graphql-java/followers","following_url":"https://api.github.com/users/graphql-java/following{/other_user}","gists_url":"https://api.github.com/users/graphql-java/gists{/gist_id}","starred_url":"https://api.github.com/users/graphql-java/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphql-java/subscriptions","organizations_url":"https://api.github.com/users/graphql-java/orgs","repos_url":"https://api.github.com/users/graphql-java/repos","events_url":"https://api.github.com/users/graphql-java/events{/privacy}","received_events_url":"https://api.github.com/users/graphql-java/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphql-java/graphql-java","description":"GraphQL Java implementation","fork":false,"url":"https://api.github.com/repos/graphql-java/graphql-java","forks_url":"https://api.github.com/repos/graphql-java/graphql-java/forks","keys_url":"https://api.github.com/repos/graphql-java/graphql-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphql-java/graphql-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphql-java/graphql-java/teams","hooks_url":"https://api.github.com/repos/graphql-java/graphql-java/hooks","issue_events_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/events{/number}","events_url":"https://api.github.com/repos/graphql-java/graphql-java/events","assignees_url":"https://api.github.com/repos/graphql-java/graphql-java/assignees{/user}","branches_url":"https://api.github.com/repos/graphql-java/graphql-java/branches{/branch}","tags_url":"https://api.github.com/repos/graphql-java/graphql-java/tags","blobs_url":"https://api.github.com/repos/graphql-java/graphql-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphql-java/graphql-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphql-java/graphql-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphql-java/graphql-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphql-java/graphql-java/statuses/{sha}","languages_url":"https://api.github.com/repos/graphql-java/graphql-java/languages","stargazers_url":"https://api.github.com/repos/graphql-java/graphql-java/stargazers","contributors_url":"https://api.github.com/repos/graphql-java/graphql-java/contributors","subscribers_url":"https://api.github.com/repos/graphql-java/graphql-java/subscribers","subscription_url":"https://api.github.com/repos/graphql-java/graphql-java/subscription","commits_url":"https://api.github.com/repos/graphql-java/graphql-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphql-java/graphql-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphql-java/graphql-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphql-java/graphql-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphql-java/graphql-java/contents/{+path}","compare_url":"https://api.github.com/repos/graphql-java/graphql-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphql-java/graphql-java/merges","archive_url":"https://api.github.com/repos/graphql-java/graphql-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphql-java/graphql-java/downloads","issues_url":"https://api.github.com/repos/graphql-java/graphql-java/issues{/number}","pulls_url":"https://api.github.com/repos/graphql-java/graphql-java/pulls{/number}","milestones_url":"https://api.github.com/repos/graphql-java/graphql-java/milestones{/number}","notifications_url":"https://api.github.com/repos/graphql-java/graphql-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphql-java/graphql-java/labels{/name}","releases_url":"https://api.github.com/repos/graphql-java/graphql-java/releases{/id}","deployments_url":"https://api.github.com/repos/graphql-java/graphql-java/deployments","created_at":"2015-07-06T06:52:20Z","updated_at":"2018-08-19T06:59:52Z","pushed_at":"2018-08-17T08:00:39Z","git_url":"git://github.com/graphql-java/graphql-java.git","ssh_url":"git@github.com:graphql-java/graphql-java.git","clone_url":"https://github.com/graphql-java/graphql-java.git","svn_url":"https://github.com/graphql-java/graphql-java","homepage":"","size":3827,"stargazers_count":2464,"watchers_count":2464,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":453,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":453,"open_issues":55,"watchers":2464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165"},"html":{"href":"https://github.com/graphql-java/graphql-java/pull/1165"},"issue":{"href":"https://api.github.com/repos/graphql-java/graphql-java/issues/1165"},"comments":{"href":"https://api.github.com/repos/graphql-java/graphql-java/issues/1165/comments"},"review_comments":{"href":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165/comments"},"review_comment":{"href":"https://api.github.com/repos/graphql-java/graphql-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphql-java/graphql-java/pulls/1165/commits"},"statuses":{"href":"https://api.github.com/repos/graphql-java/graphql-java/statuses/cea213fc3d1ccd4e28f1d976fa6dee39c4e97a81"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andimarek"}}