{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/214515300","pull_request_review_id":151595042,"id":214515300,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDUxNTMwMA==","diff_hunk":"@@ -349,6 +352,9 @@ function getPlugins(\n           renaming: !shouldStayReadable,\n         })\n       ),\n+    // HACK to work around the fact that Rollup isn't removing unused, pure-module imports.\n+    // Note that this plugin must be called after closure applies DCE.\n+    isProduction && stripUnusedImports(pureExternalModules),","path":"scripts/rollup/build.js","position":32,"original_position":32,"commit_id":"c8d58994470742c1dd865880d73f69e554f0fb28","original_commit_id":"c8d58994470742c1dd865880d73f69e554f0fb28","user":{"login":"gaearon","id":810438,"node_id":"MDQ6VXNlcjgxMDQzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/810438?v=4","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"We still need this right?","created_at":"2018-09-01T14:34:28Z","updated_at":"2018-09-01T14:39:23Z","html_url":"https://github.com/facebook/react/pull/13509#discussion_r214515300","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/13509","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/214515300"},"html":{"href":"https://github.com/facebook/react/pull/13509#discussion_r214515300"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/13509"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/13509","id":211827810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODI3ODEw","html_url":"https://github.com/facebook/react/pull/13509","diff_url":"https://github.com/facebook/react/pull/13509.diff","patch_url":"https://github.com/facebook/react/pull/13509.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/13509","number":13509,"state":"open","locked":false,"title":"Interaction tracking follow up","user":{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"body":"Follow up for PR #13253. Resolves #13512\r\n\r\n* **Reduce new dependencies** by merging the new interaction-tracking package into the (not yet released) react-scheduler package (final name TBD).\r\n* **Avoid breaking backwards compatibility**.\r\n  * The react-scheduler API has been _inlined_ for UMD React bundle and re-exported via `React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED` so that renderers can safely use the new API without requiring any new `<script>` tags to be added. A UMD fork has been added to redirect react-scheduler imports to `React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED` instead.\r\n  * This react-scheduler API has been _re-exported_ from the shared NPM package for the CJS React bundle. I've added hard `dependencies` on react-scheduler to each reconciler renderer (e.g. react-dom, react-native, react-test-renderer) so that CJS updates will just work without requiring any additional `npm install` steps.\r\n* **Enable the new API to be accessed from UMD bundles** by adding a UMD bundle for the react-scheduler package that (lazily) forwards methods to the `React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED` export. Lazy forwards are important so that the `<script>` tags can be declared in the future-safe order (ie. react-scheduler before react). \r\n\r\nAll methods for the new react-scheduler package (including interaction tracking APIs) have been prefixed with \"unstable_\" since they're new and relatively unproven.\r\n\r\nAs part of this change, the react-scheduler code (which used to be inlined into individual renderers) has been moved to the react package. This makes it look like the react UMD bundle has grown more than it has (rather, there is a corresponding decrease in e.g. react-dom). [Here are some diffs](https://gist.github.com/bvaughn/d900b1b3cff04ca939bbefbf60702fc5) that show the various CJS and UMD changes (NOTE these diffs reflect suspense being enabled so they may be a bit larger than otherwise expected.)\r\n\r\nI've added a new Rollup plugin ([`scripts/rollup/plugins/strip-unused-imports.js`](https://github.com/bvaughn/react/blob/interaction-tracking-follow-up/scripts/rollup/plugins/strip-unused-imports.js)) to strip unused imports from production bundles so that production react-dom won't have any references to the tracking API.\r\n\r\nI've also added a new fixture ([`fixtures/tracking/index.html`](https://github.com/bvaughn/react/blob/interaction-tracking-follow-up/fixtures/tracking/index.html) and [`fixtures/tracking/script.js`](https://github.com/bvaughn/react/blob/interaction-tracking-follow-up/fixtures/tracking/script.js)) to ensure that the UMD bundles are wired up correctly.\r\n\r\n### Non-blocking follow up work\r\n- [ ] Decide on a name for the react-scheduler package.\r\n- [ ] Decide on the version of the initial react-scheduler release and update `package.json`s. (I assume 16.5 but for now I've left as 0.1).\r\n- [ ] Agree on the entry point names for tracking and tracking-subscription APIs. (Currently they're `react-scheduler/tracking` and `react-scheduler/tracking-subscriptions` but I'm not married to these.)","created_at":"2018-08-29T17:18:58Z","updated_at":"2018-09-01T14:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6854f7b73cb4d68eac1b1df376db4bbbd47d908","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/13509/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/13509/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/13509/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/c8d58994470742c1dd865880d73f69e554f0fb28","head":{"label":"bvaughn:interaction-tracking-follow-up","ref":"interaction-tracking-follow-up","sha":"c8d58994470742c1dd865880d73f69e554f0fb28","user":{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"repo":{"id":74410855,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQxMDg1NQ==","name":"react","full_name":"bvaughn/react","owner":{"login":"bvaughn","id":29597,"node_id":"MDQ6VXNlcjI5NTk3","avatar_url":"https://avatars0.githubusercontent.com/u/29597?v=4","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bvaughn/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/bvaughn/react","forks_url":"https://api.github.com/repos/bvaughn/react/forks","keys_url":"https://api.github.com/repos/bvaughn/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bvaughn/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bvaughn/react/teams","hooks_url":"https://api.github.com/repos/bvaughn/react/hooks","issue_events_url":"https://api.github.com/repos/bvaughn/react/issues/events{/number}","events_url":"https://api.github.com/repos/bvaughn/react/events","assignees_url":"https://api.github.com/repos/bvaughn/react/assignees{/user}","branches_url":"https://api.github.com/repos/bvaughn/react/branches{/branch}","tags_url":"https://api.github.com/repos/bvaughn/react/tags","blobs_url":"https://api.github.com/repos/bvaughn/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bvaughn/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bvaughn/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/bvaughn/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bvaughn/react/statuses/{sha}","languages_url":"https://api.github.com/repos/bvaughn/react/languages","stargazers_url":"https://api.github.com/repos/bvaughn/react/stargazers","contributors_url":"https://api.github.com/repos/bvaughn/react/contributors","subscribers_url":"https://api.github.com/repos/bvaughn/react/subscribers","subscription_url":"https://api.github.com/repos/bvaughn/react/subscription","commits_url":"https://api.github.com/repos/bvaughn/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/bvaughn/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/bvaughn/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/bvaughn/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/bvaughn/react/contents/{+path}","compare_url":"https://api.github.com/repos/bvaughn/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bvaughn/react/merges","archive_url":"https://api.github.com/repos/bvaughn/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bvaughn/react/downloads","issues_url":"https://api.github.com/repos/bvaughn/react/issues{/number}","pulls_url":"https://api.github.com/repos/bvaughn/react/pulls{/number}","milestones_url":"https://api.github.com/repos/bvaughn/react/milestones{/number}","notifications_url":"https://api.github.com/repos/bvaughn/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bvaughn/react/labels{/name}","releases_url":"https://api.github.com/repos/bvaughn/react/releases{/id}","deployments_url":"https://api.github.com/repos/bvaughn/react/deployments","created_at":"2016-11-21T22:18:38Z","updated_at":"2018-08-18T16:28:04Z","pushed_at":"2018-08-31T23:27:52Z","git_url":"git://github.com/bvaughn/react.git","ssh_url":"git@github.com:bvaughn/react.git","clone_url":"https://github.com/bvaughn/react.git","svn_url":"https://github.com/bvaughn/react","homepage":"https://bvaughn.github.io/react/","size":137451,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"0452c9bba5707e4473fff17a24d36402a957dc66","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDI1MA==","name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2018-09-01T14:31:33Z","pushed_at":"2018-09-01T12:21:37Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":137811,"stargazers_count":110145,"watchers_count":110145,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19655,"mirror_url":null,"archived":false,"open_issues_count":351,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19655,"open_issues":351,"watchers":110145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/13509"},"html":{"href":"https://github.com/facebook/react/pull/13509"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/13509"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/13509/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/13509/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/13509/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/c8d58994470742c1dd865880d73f69e554f0fb28"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gaearon"}}