{"action":"created","comment":{"url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments/203286661","pull_request_review_id":138135804,"id":203286661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzI4NjY2MQ==","diff_hunk":"@@ -61,29 +57,37 @@\n         padding: 0.35em 2.6em;\n         color: #575757;\n     }\n-    .ciq-menu{\n-        cq-menu-dropdown,\n-        .cq-menu-dropdown {\n-            transform: translateX( -50% ) translateY( 3em );\n-            left: 50%;\n-            &.cq-menu-dropdown-enter-done, &.cq-menu-dropdown-enter-active{\n-                opacity: 1;\n-                z-index: 6;\n-                transform: translateX( -50% ) translateY( 0em );\n-            }\n-            &.cq-menu-dropdown-exit-active{\n-                opacity: 0;\n-                z-index: -3;\n-            }\n+}\n+\n+/* Menu dropdown open/close animation */\n+.cq-chart-controls .ciq-menu .cq-menu-dropdown {\n+    .cq-chart-control-bottom & {\n+        /* the left and translateX 50% centers the dropdowns */\n+        left: 50%;\n+        transform: translateX(-50%) translateY(3em);","path":"sass/components/_chart-controls.scss","position":43,"original_position":43,"commit_id":"1d203aa2e27c0d8995b3a714d2169584d92fabe7","original_commit_id":"29d081bfae112e3d55b68a4ce867754c4d87eeb7","user":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"body":"@shayanbinary you have a lot of `left: 50%` and `translateX(-50%)` duplicated all over the scss files. I've consolidated it to only be here.","created_at":"2018-07-18T08:09:54Z","updated_at":"2018-07-18T08:12:22Z","html_url":"https://github.com/binary-com/SmartCharts/pull/392#discussion_r203286661","pull_request_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments/203286661"},"html":{"href":"https://github.com/binary-com/SmartCharts/pull/392#discussion_r203286661"},"pull_request":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392","id":202162650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTYyNjUw","html_url":"https://github.com/binary-com/SmartCharts/pull/392","diff_url":"https://github.com/binary-com/SmartCharts/pull/392.diff","patch_url":"https://github.com/binary-com/SmartCharts/pull/392.patch","issue_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/392","number":392,"state":"open","locked":false,"title":"[Mobile] Dropdowns and Dialogs should fill the screen instead of being trapped in the chart","user":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-18T07:34:45Z","updated_at":"2018-07-18T08:12:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7d98373decdd899c5285ee396659f20fe745ace","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392/commits","review_comments_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392/comments","review_comment_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/392/comments","statuses_url":"https://api.github.com/repos/binary-com/SmartCharts/statuses/1d203aa2e27c0d8995b3a714d2169584d92fabe7","head":{"label":"brucebinary:liberate-dropdowns-dialogs","ref":"liberate-dropdowns-dialogs","sha":"1d203aa2e27c0d8995b3a714d2169584d92fabe7","user":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"repo":{"id":127390473,"node_id":"MDEwOlJlcG9zaXRvcnkxMjczOTA0NzM=","name":"SmartCharts","full_name":"brucebinary/SmartCharts","owner":{"login":"brucebinary","id":32833572,"node_id":"MDQ6VXNlcjMyODMzNTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32833572?v=4","gravatar_id":"","url":"https://api.github.com/users/brucebinary","html_url":"https://github.com/brucebinary","followers_url":"https://api.github.com/users/brucebinary/followers","following_url":"https://api.github.com/users/brucebinary/following{/other_user}","gists_url":"https://api.github.com/users/brucebinary/gists{/gist_id}","starred_url":"https://api.github.com/users/brucebinary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucebinary/subscriptions","organizations_url":"https://api.github.com/users/brucebinary/orgs","repos_url":"https://api.github.com/users/brucebinary/repos","events_url":"https://api.github.com/users/brucebinary/events{/privacy}","received_events_url":"https://api.github.com/users/brucebinary/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brucebinary/SmartCharts","description":null,"fork":true,"url":"https://api.github.com/repos/brucebinary/SmartCharts","forks_url":"https://api.github.com/repos/brucebinary/SmartCharts/forks","keys_url":"https://api.github.com/repos/brucebinary/SmartCharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brucebinary/SmartCharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brucebinary/SmartCharts/teams","hooks_url":"https://api.github.com/repos/brucebinary/SmartCharts/hooks","issue_events_url":"https://api.github.com/repos/brucebinary/SmartCharts/issues/events{/number}","events_url":"https://api.github.com/repos/brucebinary/SmartCharts/events","assignees_url":"https://api.github.com/repos/brucebinary/SmartCharts/assignees{/user}","branches_url":"https://api.github.com/repos/brucebinary/SmartCharts/branches{/branch}","tags_url":"https://api.github.com/repos/brucebinary/SmartCharts/tags","blobs_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brucebinary/SmartCharts/statuses/{sha}","languages_url":"https://api.github.com/repos/brucebinary/SmartCharts/languages","stargazers_url":"https://api.github.com/repos/brucebinary/SmartCharts/stargazers","contributors_url":"https://api.github.com/repos/brucebinary/SmartCharts/contributors","subscribers_url":"https://api.github.com/repos/brucebinary/SmartCharts/subscribers","subscription_url":"https://api.github.com/repos/brucebinary/SmartCharts/subscription","commits_url":"https://api.github.com/repos/brucebinary/SmartCharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/brucebinary/SmartCharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/brucebinary/SmartCharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/brucebinary/SmartCharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/brucebinary/SmartCharts/contents/{+path}","compare_url":"https://api.github.com/repos/brucebinary/SmartCharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brucebinary/SmartCharts/merges","archive_url":"https://api.github.com/repos/brucebinary/SmartCharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brucebinary/SmartCharts/downloads","issues_url":"https://api.github.com/repos/brucebinary/SmartCharts/issues{/number}","pulls_url":"https://api.github.com/repos/brucebinary/SmartCharts/pulls{/number}","milestones_url":"https://api.github.com/repos/brucebinary/SmartCharts/milestones{/number}","notifications_url":"https://api.github.com/repos/brucebinary/SmartCharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brucebinary/SmartCharts/labels{/name}","releases_url":"https://api.github.com/repos/brucebinary/SmartCharts/releases{/id}","deployments_url":"https://api.github.com/repos/brucebinary/SmartCharts/deployments","created_at":"2018-03-30T06:27:21Z","updated_at":"2018-05-28T02:17:04Z","pushed_at":"2018-07-18T08:12:13Z","git_url":"git://github.com/brucebinary/SmartCharts.git","ssh_url":"git@github.com:brucebinary/SmartCharts.git","clone_url":"https://github.com/brucebinary/SmartCharts.git","svn_url":"https://github.com/brucebinary/SmartCharts","homepage":null,"size":26911,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"binary-com:dev","ref":"dev","sha":"a09e5cf4a82c6fc38165c1736ea2b00cd9eccc36","user":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"repo":{"id":115597557,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU1OTc1NTc=","name":"SmartCharts","full_name":"binary-com/SmartCharts","owner":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/binary-com/SmartCharts","description":null,"fork":false,"url":"https://api.github.com/repos/binary-com/SmartCharts","forks_url":"https://api.github.com/repos/binary-com/SmartCharts/forks","keys_url":"https://api.github.com/repos/binary-com/SmartCharts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary-com/SmartCharts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary-com/SmartCharts/teams","hooks_url":"https://api.github.com/repos/binary-com/SmartCharts/hooks","issue_events_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/events{/number}","events_url":"https://api.github.com/repos/binary-com/SmartCharts/events","assignees_url":"https://api.github.com/repos/binary-com/SmartCharts/assignees{/user}","branches_url":"https://api.github.com/repos/binary-com/SmartCharts/branches{/branch}","tags_url":"https://api.github.com/repos/binary-com/SmartCharts/tags","blobs_url":"https://api.github.com/repos/binary-com/SmartCharts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary-com/SmartCharts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary-com/SmartCharts/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary-com/SmartCharts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary-com/SmartCharts/statuses/{sha}","languages_url":"https://api.github.com/repos/binary-com/SmartCharts/languages","stargazers_url":"https://api.github.com/repos/binary-com/SmartCharts/stargazers","contributors_url":"https://api.github.com/repos/binary-com/SmartCharts/contributors","subscribers_url":"https://api.github.com/repos/binary-com/SmartCharts/subscribers","subscription_url":"https://api.github.com/repos/binary-com/SmartCharts/subscription","commits_url":"https://api.github.com/repos/binary-com/SmartCharts/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary-com/SmartCharts/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary-com/SmartCharts/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary-com/SmartCharts/issues/comments{/number}","contents_url":"https://api.github.com/repos/binary-com/SmartCharts/contents/{+path}","compare_url":"https://api.github.com/repos/binary-com/SmartCharts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary-com/SmartCharts/merges","archive_url":"https://api.github.com/repos/binary-com/SmartCharts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary-com/SmartCharts/downloads","issues_url":"https://api.github.com/repos/binary-com/SmartCharts/issues{/number}","pulls_url":"https://api.github.com/repos/binary-com/SmartCharts/pulls{/number}","milestones_url":"https://api.github.com/repos/binary-com/SmartCharts/milestones{/number}","notifications_url":"https://api.github.com/repos/binary-com/SmartCharts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary-com/SmartCharts/labels{/name}","releases_url":"https://api.github.com/repos/binary-com/SmartCharts/releases{/id}","deployments_url":"https://api.github.com/repos/binary-com/SmartCharts/deployments","created_at":"2017-12-28T07:28:49Z","updated_at":"2018-07-18T00:34:41Z","pushed_at":"2018-07-18T08:12:14Z","git_url":"git://github.com/binary-com/SmartCharts.git","ssh_url":"git@github.com:binary-com/SmartCharts.git","clone_url":"https://github.com/binary-com/SmartCharts.git","svn_url":"https://github.com/binary-com/SmartCharts","homepage":null,"size":50498,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":10,"open_issues":10,"watchers":6,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392"},"html":{"href":"https://github.com/binary-com/SmartCharts/pull/392"},"issue":{"href":"https://api.github.com/repos/binary-com/SmartCharts/issues/392"},"comments":{"href":"https://api.github.com/repos/binary-com/SmartCharts/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binary-com/SmartCharts/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/binary-com/SmartCharts/statuses/1d203aa2e27c0d8995b3a714d2169584d92fabe7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"brucebinary"}}