{"action":"created","comment":{"url":"https://api.github.com/repos/bblfsh/sdk/pulls/comments/235786275","pull_request_review_id":177733966,"id":235786275,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc4NjI3NQ==","diff_hunk":"@@ -71,6 +73,12 @@ func (s *Server) initialize() error {\n \t\treturn err\n \t}\n \n+\tgrpcOpts, err := cmdutil.GRPCSizeOptions(*maxMessageSize)\n+\tif err != nil {\n+\t\ts.Logger.Warningf(err.Error())","path":"driver/server/server.go","position":30,"original_position":30,"commit_id":"664933f6d548b63a504d7db520ab651e439d8e54","original_commit_id":"664933f6d548b63a504d7db520ab651e439d8e54","user":{"login":"bzz","id":5582506,"node_id":"MDQ6VXNlcjU1ODI1MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"body":"Guys, please, let's keep this discussion in a single place =)\r\n\r\nI'm open for reasonable arguments why this approach is better then a current one at https://github.com/bblfsh/bblfshd/pull/216#discussion_r235785584","created_at":"2018-11-22T16:53:55Z","updated_at":"2018-11-22T16:53:55Z","html_url":"https://github.com/bblfsh/sdk/pull/329#discussion_r235786275","pull_request_url":"https://api.github.com/repos/bblfsh/sdk/pulls/329","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/comments/235786275"},"html":{"href":"https://github.com/bblfsh/sdk/pull/329#discussion_r235786275"},"pull_request":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/329"}},"in_reply_to_id":235762041},"pull_request":{"url":"https://api.github.com/repos/bblfsh/sdk/pulls/329","id":232763420,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzYzNDIw","html_url":"https://github.com/bblfsh/sdk/pull/329","diff_url":"https://github.com/bblfsh/sdk/pull/329.diff","patch_url":"https://github.com/bblfsh/sdk/pull/329.patch","issue_url":"https://api.github.com/repos/bblfsh/sdk/issues/329","number":329,"state":"open","locked":false,"title":"Shared gRPC server config between bblfshd/driver","user":{"login":"bzz","id":5582506,"node_id":"MDQ6VXNlcjU1ODI1MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"body":"Part of the https://github.com/bblfsh/client-go/issues/102\r\n\r\nIncludes:\r\n - move `sdk.BuildGRPCOptions` from bblfshd to SDK\r\n - add same CLI `grpc-max-message-size` arg to all Drivers","created_at":"2018-11-21T18:36:04Z","updated_at":"2018-11-22T16:53:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51790e34c6ed4f448b10e2a35302a184d3359d11","assignee":{"login":"bzz","id":5582506,"node_id":"MDQ6VXNlcjU1ODI1MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"assignees":[{"login":"bzz","id":5582506,"node_id":"MDQ6VXNlcjU1ODI1MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"juanjux","id":277378,"node_id":"MDQ6VXNlcjI3NzM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/277378?v=4","gravatar_id":"","url":"https://api.github.com/users/juanjux","html_url":"https://github.com/juanjux","followers_url":"https://api.github.com/users/juanjux/followers","following_url":"https://api.github.com/users/juanjux/following{/other_user}","gists_url":"https://api.github.com/users/juanjux/gists{/gist_id}","starred_url":"https://api.github.com/users/juanjux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanjux/subscriptions","organizations_url":"https://api.github.com/users/juanjux/orgs","repos_url":"https://api.github.com/users/juanjux/repos","events_url":"https://api.github.com/users/juanjux/events{/privacy}","received_events_url":"https://api.github.com/users/juanjux/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bblfsh/sdk/pulls/329/commits","review_comments_url":"https://api.github.com/repos/bblfsh/sdk/pulls/329/comments","review_comment_url":"https://api.github.com/repos/bblfsh/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bblfsh/sdk/issues/329/comments","statuses_url":"https://api.github.com/repos/bblfsh/sdk/statuses/664933f6d548b63a504d7db520ab651e439d8e54","head":{"label":"bzz:refactoring/add-grpc-server-options","ref":"refactoring/add-grpc-server-options","sha":"664933f6d548b63a504d7db520ab651e439d8e54","user":{"login":"bzz","id":5582506,"node_id":"MDQ6VXNlcjU1ODI1MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"repo":{"id":88647863,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY0Nzg2Mw==","name":"sdk","full_name":"bzz/sdk","private":false,"owner":{"login":"bzz","id":5582506,"node_id":"MDQ6VXNlcjU1ODI1MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5582506?v=4","gravatar_id":"","url":"https://api.github.com/users/bzz","html_url":"https://github.com/bzz","followers_url":"https://api.github.com/users/bzz/followers","following_url":"https://api.github.com/users/bzz/following{/other_user}","gists_url":"https://api.github.com/users/bzz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzz/subscriptions","organizations_url":"https://api.github.com/users/bzz/orgs","repos_url":"https://api.github.com/users/bzz/repos","events_url":"https://api.github.com/users/bzz/events{/privacy}","received_events_url":"https://api.github.com/users/bzz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bzz/sdk","description":"Babelfish driver SDK ","fork":true,"url":"https://api.github.com/repos/bzz/sdk","forks_url":"https://api.github.com/repos/bzz/sdk/forks","keys_url":"https://api.github.com/repos/bzz/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bzz/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bzz/sdk/teams","hooks_url":"https://api.github.com/repos/bzz/sdk/hooks","issue_events_url":"https://api.github.com/repos/bzz/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/bzz/sdk/events","assignees_url":"https://api.github.com/repos/bzz/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/bzz/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/bzz/sdk/tags","blobs_url":"https://api.github.com/repos/bzz/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bzz/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bzz/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bzz/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bzz/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bzz/sdk/languages","stargazers_url":"https://api.github.com/repos/bzz/sdk/stargazers","contributors_url":"https://api.github.com/repos/bzz/sdk/contributors","subscribers_url":"https://api.github.com/repos/bzz/sdk/subscribers","subscription_url":"https://api.github.com/repos/bzz/sdk/subscription","commits_url":"https://api.github.com/repos/bzz/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bzz/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bzz/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bzz/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bzz/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/bzz/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bzz/sdk/merges","archive_url":"https://api.github.com/repos/bzz/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bzz/sdk/downloads","issues_url":"https://api.github.com/repos/bzz/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/bzz/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bzz/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bzz/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bzz/sdk/labels{/name}","releases_url":"https://api.github.com/repos/bzz/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/bzz/sdk/deployments","created_at":"2017-04-18T16:38:30Z","updated_at":"2018-11-20T12:46:37Z","pushed_at":"2018-11-22T13:36:43Z","git_url":"git://github.com/bzz/sdk.git","ssh_url":"git@github.com:bzz/sdk.git","clone_url":"https://github.com/bzz/sdk.git","svn_url":"https://github.com/bzz/sdk","homepage":"","size":1472,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bblfsh:master","ref":"master","sha":"d932d3391d5e12c1d6af03e39e0e75f0d2d44107","user":{"login":"bblfsh","id":25795418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Nzk1NDE4","avatar_url":"https://avatars0.githubusercontent.com/u/25795418?v=4","gravatar_id":"","url":"https://api.github.com/users/bblfsh","html_url":"https://github.com/bblfsh","followers_url":"https://api.github.com/users/bblfsh/followers","following_url":"https://api.github.com/users/bblfsh/following{/other_user}","gists_url":"https://api.github.com/users/bblfsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfsh/subscriptions","organizations_url":"https://api.github.com/users/bblfsh/orgs","repos_url":"https://api.github.com/users/bblfsh/repos","events_url":"https://api.github.com/users/bblfsh/events{/privacy}","received_events_url":"https://api.github.com/users/bblfsh/received_events","type":"Organization","site_admin":false},"repo":{"id":82719719,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcxOTcxOQ==","name":"sdk","full_name":"bblfsh/sdk","private":false,"owner":{"login":"bblfsh","id":25795418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Nzk1NDE4","avatar_url":"https://avatars0.githubusercontent.com/u/25795418?v=4","gravatar_id":"","url":"https://api.github.com/users/bblfsh","html_url":"https://github.com/bblfsh","followers_url":"https://api.github.com/users/bblfsh/followers","following_url":"https://api.github.com/users/bblfsh/following{/other_user}","gists_url":"https://api.github.com/users/bblfsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bblfsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bblfsh/subscriptions","organizations_url":"https://api.github.com/users/bblfsh/orgs","repos_url":"https://api.github.com/users/bblfsh/repos","events_url":"https://api.github.com/users/bblfsh/events{/privacy}","received_events_url":"https://api.github.com/users/bblfsh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bblfsh/sdk","description":"Babelfish driver SDK ","fork":false,"url":"https://api.github.com/repos/bblfsh/sdk","forks_url":"https://api.github.com/repos/bblfsh/sdk/forks","keys_url":"https://api.github.com/repos/bblfsh/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bblfsh/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bblfsh/sdk/teams","hooks_url":"https://api.github.com/repos/bblfsh/sdk/hooks","issue_events_url":"https://api.github.com/repos/bblfsh/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/bblfsh/sdk/events","assignees_url":"https://api.github.com/repos/bblfsh/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/bblfsh/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/bblfsh/sdk/tags","blobs_url":"https://api.github.com/repos/bblfsh/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bblfsh/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bblfsh/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/bblfsh/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bblfsh/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/bblfsh/sdk/languages","stargazers_url":"https://api.github.com/repos/bblfsh/sdk/stargazers","contributors_url":"https://api.github.com/repos/bblfsh/sdk/contributors","subscribers_url":"https://api.github.com/repos/bblfsh/sdk/subscribers","subscription_url":"https://api.github.com/repos/bblfsh/sdk/subscription","commits_url":"https://api.github.com/repos/bblfsh/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/bblfsh/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/bblfsh/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/bblfsh/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/bblfsh/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/bblfsh/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bblfsh/sdk/merges","archive_url":"https://api.github.com/repos/bblfsh/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bblfsh/sdk/downloads","issues_url":"https://api.github.com/repos/bblfsh/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/bblfsh/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/bblfsh/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/bblfsh/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bblfsh/sdk/labels{/name}","releases_url":"https://api.github.com/repos/bblfsh/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/bblfsh/sdk/deployments","created_at":"2017-02-21T19:41:42Z","updated_at":"2018-11-06T11:02:32Z","pushed_at":"2018-11-22T13:36:45Z","git_url":"git://github.com/bblfsh/sdk.git","ssh_url":"git@github.com:bblfsh/sdk.git","clone_url":"https://github.com/bblfsh/sdk.git","svn_url":"https://github.com/bblfsh/sdk","homepage":"","size":1485,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":18,"open_issues":14,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/329"},"html":{"href":"https://github.com/bblfsh/sdk/pull/329"},"issue":{"href":"https://api.github.com/repos/bblfsh/sdk/issues/329"},"comments":{"href":"https://api.github.com/repos/bblfsh/sdk/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bblfsh/sdk/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/bblfsh/sdk/statuses/664933f6d548b63a504d7db520ab651e439d8e54"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bzz"}}