{"action":"created","issue":{"url":"https://api.github.com/repos/beakerbrowser/beaker/issues/991","repository_url":"https://api.github.com/repos/beakerbrowser/beaker","labels_url":"https://api.github.com/repos/beakerbrowser/beaker/issues/991/labels{/name}","comments_url":"https://api.github.com/repos/beakerbrowser/beaker/issues/991/comments","events_url":"https://api.github.com/repos/beakerbrowser/beaker/issues/991/events","html_url":"https://github.com/beakerbrowser/beaker/pull/991","id":323723914,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4NTExOTY0","number":991,"title":"Exclude unused sodium-native binaries from builds","user":{"login":"samuelmaddock","id":1656324,"node_id":"MDQ6VXNlcjE2NTYzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1656324?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelmaddock","html_url":"https://github.com/samuelmaddock","followers_url":"https://api.github.com/users/samuelmaddock/followers","following_url":"https://api.github.com/users/samuelmaddock/following{/other_user}","gists_url":"https://api.github.com/users/samuelmaddock/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelmaddock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelmaddock/subscriptions","organizations_url":"https://api.github.com/users/samuelmaddock/orgs","repos_url":"https://api.github.com/users/samuelmaddock/repos","events_url":"https://api.github.com/users/samuelmaddock/events{/privacy}","received_events_url":"https://api.github.com/users/samuelmaddock/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-16T17:52:45Z","updated_at":"2018-08-14T14:40:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/beakerbrowser/beaker/pulls/991","html_url":"https://github.com/beakerbrowser/beaker/pull/991","diff_url":"https://github.com/beakerbrowser/beaker/pull/991.diff","patch_url":"https://github.com/beakerbrowser/beaker/pull/991.patch"},"body":"Release builds are including all platform binaries for sodium-native which adds a lot to the build size. This change includes only binaries for the current platform.\r\n\r\n```bash\r\n# Before change\r\n~/projects/beaker (master) $ du -sh ./dist/mac/Beaker\\ Browser.app/\r\n240M    ./dist/mac/Beaker Browser.app/\r\n\r\n# After change\r\n~/projects/beaker (master) $ du -sh ./dist/mac/Beaker\\ Browser.app/\r\n225M    ./dist/mac/Beaker Browser.app/\r\n```\r\n\r\nIt looks like Beaker only uses sodium-native within the background process so only the node binaries are required. I wasn't sure which ABI version is needed so it still includes all node binary versions for the platform.\r\n\r\nNote that I've only tested this on macOS."},"comment":{"url":"https://api.github.com/repos/beakerbrowser/beaker/issues/comments/412895853","html_url":"https://github.com/beakerbrowser/beaker/pull/991#issuecomment-412895853","issue_url":"https://api.github.com/repos/beakerbrowser/beaker/issues/991","id":412895853,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjg5NTg1Mw==","user":{"login":"samuelmaddock","id":1656324,"node_id":"MDQ6VXNlcjE2NTYzMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1656324?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelmaddock","html_url":"https://github.com/samuelmaddock","followers_url":"https://api.github.com/users/samuelmaddock/followers","following_url":"https://api.github.com/users/samuelmaddock/following{/other_user}","gists_url":"https://api.github.com/users/samuelmaddock/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelmaddock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelmaddock/subscriptions","organizations_url":"https://api.github.com/users/samuelmaddock/orgs","repos_url":"https://api.github.com/users/samuelmaddock/repos","events_url":"https://api.github.com/users/samuelmaddock/events{/privacy}","received_events_url":"https://api.github.com/users/samuelmaddock/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T14:40:36Z","updated_at":"2018-08-14T14:40:36Z","author_association":"CONTRIBUTOR","body":"@pmario The configuration uses [file macros](https://www.electron.build/file-patterns#file-macros) to target the configured platform and architecture for each build. I don't think Beaker Browser is configured to build for 32-bit Windows. However, if it was, it would be a separate build only containing the 32-bit sodium-native binaries."}}
{"actor":{"display_login":"samuelmaddock"}}