{"action":"created","comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/217107358","pull_request_review_id":154743181,"id":217107358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzEwNzM1OA==","diff_hunk":"@@ -2,7 +2,6 @@\n using System.Collections.Generic;\n using System.Data;\n using System.Data.Common;\n-using System.Data.Odbc;","path":"src/NHibernate/Driver/OdbcDriver.cs","position":4,"original_position":4,"commit_id":"5e8f2c8ae956bf69a3d3723252750d9fd67a02e0","original_commit_id":"5e8f2c8ae956bf69a3d3723252750d9fd67a02e0","user":{"login":"fredericDelaporte","id":12201973,"node_id":"MDQ6VXNlcjEyMjAxOTcz","avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"body":"Unrelated, but why not.","created_at":"2018-09-12T16:43:50Z","updated_at":"2018-09-12T16:56:26Z","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1846#discussion_r217107358","pull_request_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments/217107358"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1846#discussion_r217107358"},"pull_request":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846"}}},"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846","id":214967323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTY3MzIz","html_url":"https://github.com/nhibernate/nhibernate-core/pull/1846","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/1846.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/1846.patch","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1846","number":1846,"state":"open","locked":false,"title":"Remove dependency on System.Security.Permissions package for .NET Standard and .NET Core","user":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"body":"System.Security.Permissions package is used to check that `ReflectionPermission` is granted to perform a small optimization for `DynamicMethod`, however in .NET Standard and .NET Core permissions are not really supported and `SecurityManager.IsGranted` always returns `false`.\r\n\r\nAlso for .NET Framework the obsoleted `SecurityManager.IsGranted` was replaced with a preferred method of checking permissions.","created_at":"2018-09-12T13:46:23Z","updated_at":"2018-09-12T16:56:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a8df636749d0b2294f0f888061bcb154770e12c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":717851256,"node_id":"MDU6TGFiZWw3MTc4NTEyNTY=","url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/c:%20Core","name":"c: Core","color":"ededed","default":false},{"id":717863290,"node_id":"MDU6TGFiZWw3MTc4NjMyOTA=","url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/p:%20Minor","name":"p: Minor","color":"f9d0c4","default":false},{"id":661468479,"node_id":"MDU6TGFiZWw2NjE0Njg0Nzk=","url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/t:%20Improvement","name":"t: Improvement","color":"c5def5","default":false}],"milestone":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones/14","html_url":"https://github.com/nhibernate/nhibernate-core/milestone/14","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones/14/labels","id":3217719,"node_id":"MDk6TWlsZXN0b25lMzIxNzcxOQ==","number":14,"title":"5.2","description":"","creator":{"login":"fredericDelaporte","id":12201973,"node_id":"MDQ6VXNlcjEyMjAxOTcz","avatar_url":"https://avatars2.githubusercontent.com/u/12201973?v=4","gravatar_id":"","url":"https://api.github.com/users/fredericDelaporte","html_url":"https://github.com/fredericDelaporte","followers_url":"https://api.github.com/users/fredericDelaporte/followers","following_url":"https://api.github.com/users/fredericDelaporte/following{/other_user}","gists_url":"https://api.github.com/users/fredericDelaporte/gists{/gist_id}","starred_url":"https://api.github.com/users/fredericDelaporte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredericDelaporte/subscriptions","organizations_url":"https://api.github.com/users/fredericDelaporte/orgs","repos_url":"https://api.github.com/users/fredericDelaporte/repos","events_url":"https://api.github.com/users/fredericDelaporte/events{/privacy}","received_events_url":"https://api.github.com/users/fredericDelaporte/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":130,"state":"open","created_at":"2018-03-26T14:35:58Z","updated_at":"2018-09-12T13:46:23Z","due_on":"2018-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846/commits","review_comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846/comments","review_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1846/comments","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/5e8f2c8ae956bf69a3d3723252750d9fd67a02e0","head":{"label":"hazzik:no-System.Security.Permissions","ref":"no-System.Security.Permissions","sha":"5e8f2c8ae956bf69a3d3723252750d9fd67a02e0","user":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"repo":{"id":3009271,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjcx","name":"nhibernate-core","full_name":"hazzik/nhibernate-core","owner":{"login":"hazzik","id":144791,"node_id":"MDQ6VXNlcjE0NDc5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/144791?v=4","gravatar_id":"","url":"https://api.github.com/users/hazzik","html_url":"https://github.com/hazzik","followers_url":"https://api.github.com/users/hazzik/followers","following_url":"https://api.github.com/users/hazzik/following{/other_user}","gists_url":"https://api.github.com/users/hazzik/gists{/gist_id}","starred_url":"https://api.github.com/users/hazzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazzik/subscriptions","organizations_url":"https://api.github.com/users/hazzik/orgs","repos_url":"https://api.github.com/users/hazzik/repos","events_url":"https://api.github.com/users/hazzik/events{/privacy}","received_events_url":"https://api.github.com/users/hazzik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hazzik/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":true,"url":"https://api.github.com/repos/hazzik/nhibernate-core","forks_url":"https://api.github.com/repos/hazzik/nhibernate-core/forks","keys_url":"https://api.github.com/repos/hazzik/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazzik/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazzik/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/hazzik/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/hazzik/nhibernate-core/events","assignees_url":"https://api.github.com/repos/hazzik/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/hazzik/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/hazzik/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazzik/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hazzik/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/hazzik/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/hazzik/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/hazzik/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/hazzik/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/hazzik/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazzik/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazzik/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazzik/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/hazzik/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazzik/nhibernate-core/merges","archive_url":"https://api.github.com/repos/hazzik/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazzik/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/hazzik/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/hazzik/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hazzik/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hazzik/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazzik/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/hazzik/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/hazzik/nhibernate-core/deployments","created_at":"2011-12-19T02:04:00Z","updated_at":"2018-08-05T09:41:24Z","pushed_at":"2018-09-12T13:45:38Z","git_url":"git://github.com/hazzik/nhibernate-core.git","ssh_url":"git@github.com:hazzik/nhibernate-core.git","clone_url":"https://github.com/hazzik/nhibernate-core.git","svn_url":"https://github.com/hazzik/nhibernate-core","homepage":"http://nhibernate.info","size":85108,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"nhibernate:master","ref":"master","sha":"2a6021fe8b1ce7baf7c6a1c6cee0b810291ba714","user":{"login":"nhibernate","id":961041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":2206199,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA2MTk5","name":"nhibernate-core","full_name":"nhibernate/nhibernate-core","owner":{"login":"nhibernate","id":961041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2MTA0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/961041?v=4","gravatar_id":"","url":"https://api.github.com/users/nhibernate","html_url":"https://github.com/nhibernate","followers_url":"https://api.github.com/users/nhibernate/followers","following_url":"https://api.github.com/users/nhibernate/following{/other_user}","gists_url":"https://api.github.com/users/nhibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/nhibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhibernate/subscriptions","organizations_url":"https://api.github.com/users/nhibernate/orgs","repos_url":"https://api.github.com/users/nhibernate/repos","events_url":"https://api.github.com/users/nhibernate/events{/privacy}","received_events_url":"https://api.github.com/users/nhibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nhibernate/nhibernate-core","description":"NHibernate Object Relational Mapper","fork":false,"url":"https://api.github.com/repos/nhibernate/nhibernate-core","forks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/forks","keys_url":"https://api.github.com/repos/nhibernate/nhibernate-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhibernate/nhibernate-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhibernate/nhibernate-core/teams","hooks_url":"https://api.github.com/repos/nhibernate/nhibernate-core/hooks","issue_events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/events{/number}","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/events","assignees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/assignees{/user}","branches_url":"https://api.github.com/repos/nhibernate/nhibernate-core/branches{/branch}","tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/tags","blobs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/{sha}","languages_url":"https://api.github.com/repos/nhibernate/nhibernate-core/languages","stargazers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/stargazers","contributors_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contributors","subscribers_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscribers","subscription_url":"https://api.github.com/repos/nhibernate/nhibernate-core/subscription","commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhibernate/nhibernate-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhibernate/nhibernate-core/contents/{+path}","compare_url":"https://api.github.com/repos/nhibernate/nhibernate-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhibernate/nhibernate-core/merges","archive_url":"https://api.github.com/repos/nhibernate/nhibernate-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhibernate/nhibernate-core/downloads","issues_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues{/number}","pulls_url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls{/number}","milestones_url":"https://api.github.com/repos/nhibernate/nhibernate-core/milestones{/number}","notifications_url":"https://api.github.com/repos/nhibernate/nhibernate-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels{/name}","releases_url":"https://api.github.com/repos/nhibernate/nhibernate-core/releases{/id}","deployments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/deployments","created_at":"2011-08-14T17:51:09Z","updated_at":"2018-09-12T08:10:02Z","pushed_at":"2018-09-12T13:46:24Z","git_url":"git://github.com/nhibernate/nhibernate-core.git","ssh_url":"git@github.com:nhibernate/nhibernate-core.git","clone_url":"https://github.com/nhibernate/nhibernate-core.git","svn_url":"https://github.com/nhibernate/nhibernate-core","homepage":"http://nhibernate.info","size":85031,"stargazers_count":1444,"watchers_count":1444,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":790,"mirror_url":null,"archived":false,"open_issues_count":623,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":790,"open_issues":623,"watchers":1444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846"},"html":{"href":"https://github.com/nhibernate/nhibernate-core/pull/1846"},"issue":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1846"},"comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/1846/comments"},"review_comments":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846/comments"},"review_comment":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/1846/commits"},"statuses":{"href":"https://api.github.com/repos/nhibernate/nhibernate-core/statuses/5e8f2c8ae956bf69a3d3723252750d9fd67a02e0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fredericDelaporte"}}