{"action":"created","issue":{"url":"https://api.github.com/repos/hishamhm/htop/issues/770","repository_url":"https://api.github.com/repos/hishamhm/htop","labels_url":"https://api.github.com/repos/hishamhm/htop/issues/770/labels{/name}","comments_url":"https://api.github.com/repos/hishamhm/htop/issues/770/comments","events_url":"https://api.github.com/repos/hishamhm/htop/issues/770/events","html_url":"https://github.com/hishamhm/htop/pull/770","id":309331607,"number":770,"title":"MakeHeader.py: Fix for non-utf8 environments","user":{"login":"volkov-am","id":1501891,"avatar_url":"https://avatars2.githubusercontent.com/u/1501891?v=4","gravatar_id":"","url":"https://api.github.com/users/volkov-am","html_url":"https://github.com/volkov-am","followers_url":"https://api.github.com/users/volkov-am/followers","following_url":"https://api.github.com/users/volkov-am/following{/other_user}","gists_url":"https://api.github.com/users/volkov-am/gists{/gist_id}","starred_url":"https://api.github.com/users/volkov-am/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volkov-am/subscriptions","organizations_url":"https://api.github.com/users/volkov-am/orgs","repos_url":"https://api.github.com/users/volkov-am/repos","events_url":"https://api.github.com/users/volkov-am/events{/privacy}","received_events_url":"https://api.github.com/users/volkov-am/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-28T11:43:37Z","updated_at":"2018-04-05T22:56:19Z","closed_at":"2018-04-05T22:55:51Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hishamhm/htop/pulls/770","html_url":"https://github.com/hishamhm/htop/pull/770","diff_url":"https://github.com/hishamhm/htop/pull/770.diff","patch_url":"https://github.com/hishamhm/htop/pull/770.patch"},"body":"Header creation fails with non-utf8 locale and python3.\r\nSimply set LC_ALL=\"C\" and use python3 to reproduce the issue.\r\n\r\nenv LC_ALL=\"C\" ./scripts/MakeHeader.py MetersPanel.c\r\nTraceback (most recent call last):\r\n  File \"./scripts/MakeHeader.py\", line 32, in <module>\r\n    for line in file.readlines():\r\n  File \"/usr/lib64/python3.5/encodings/ascii.py\", line 26, in decode\r\n    return codecs.ascii_decode(input, self.errors)[0]\r\nUnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 956: ordinal not in range(128)\r\n\r\nThis changes is python2 and python3 compatible\r\n\r\ncStringIO.StringIO module is removed because it is not able to accept unicode strings\r\nhttps://docs.python.org/2/library/stringio.html#cStringIO.StringIO"},"comment":{"url":"https://api.github.com/repos/hishamhm/htop/issues/comments/379100717","html_url":"https://github.com/hishamhm/htop/pull/770#issuecomment-379100717","issue_url":"https://api.github.com/repos/hishamhm/htop/issues/770","id":379100717,"user":{"login":"hishamhm","id":245621,"avatar_url":"https://avatars3.githubusercontent.com/u/245621?v=4","gravatar_id":"","url":"https://api.github.com/users/hishamhm","html_url":"https://github.com/hishamhm","followers_url":"https://api.github.com/users/hishamhm/followers","following_url":"https://api.github.com/users/hishamhm/following{/other_user}","gists_url":"https://api.github.com/users/hishamhm/gists{/gist_id}","starred_url":"https://api.github.com/users/hishamhm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hishamhm/subscriptions","organizations_url":"https://api.github.com/users/hishamhm/orgs","repos_url":"https://api.github.com/users/hishamhm/repos","events_url":"https://api.github.com/users/hishamhm/events{/privacy}","received_events_url":"https://api.github.com/users/hishamhm/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T22:56:19Z","updated_at":"2018-04-05T22:56:19Z","author_association":"OWNER","body":"@volkov-am Thank you for coming up with the solution! This is now merged. A release is coming this weekend!"}}
{"actor":{"display_login":"hishamhm"}}