{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments/211968234","pull_request_review_id":148499375,"id":211968234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTk2ODIzNA==","diff_hunk":"@@ -230,6 +230,22 @@ get_enabled_rpmmd_repos (DnfContext *dnfctx, DnfRepoEnabled enablement)\n   return g_steal_pointer (&ret);\n }\n \n+/* Get a bool from @keyfile, adding it to @builder */\n+static void\n+tf_bind_boolean (GKeyFile *keyfile,\n+                 GVariantBuilder *builder,\n+                 const char *name,\n+                 gboolean default_value)\n+{\n+  gboolean v = default_value;\n+  g_autofree char *value_str = g_key_file_get_value (keyfile, \"tree\", name, NULL);","path":"src/libpriv/rpmostree-core.c","position":null,"original_position":12,"commit_id":"542d4aa11fd585aba85c345c0b384e91fb88da25","original_commit_id":"fc1a667f672e87748708494978f3b84f7196b996","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"Fixed :arrow_down: ","created_at":"2018-08-22T14:09:11Z","updated_at":"2018-08-22T14:09:12Z","html_url":"https://github.com/projectatomic/rpm-ostree/pull/1513#discussion_r211968234","pull_request_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments/211968234"},"html":{"href":"https://github.com/projectatomic/rpm-ostree/pull/1513#discussion_r211968234"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513"}},"in_reply_to_id":211961655},"pull_request":{"url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513","id":210135563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMTM1NTYz","html_url":"https://github.com/projectatomic/rpm-ostree/pull/1513","diff_url":"https://github.com/projectatomic/rpm-ostree/pull/1513.diff","patch_url":"https://github.com/projectatomic/rpm-ostree/pull/1513.patch","issue_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1513","number":1513,"state":"open","locked":false,"title":"Add `recommends` to treefile (default on)","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"This is for: https://github.com/projectatomic/rpm-ostree/issues/718\r\nBut I'm not going to close that issue as this only does the server\r\nside, and I think we should support it client side too.\r\n\r\nSince I wrote that issue, we ended up skipping the `dnf_transaction_depsolve()`\r\nAPI, and hence we don't need to block on a libdnf change.  So\r\nthis was quite simple.\r\n","created_at":"2018-08-22T13:34:24Z","updated_at":"2018-08-22T14:09:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26f352b9e4228a66e6c481af1e7f9f99450368c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513/commits","review_comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513/comments","review_comment_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1513/comments","statuses_url":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/542d4aa11fd585aba85c345c0b384e91fb88da25","head":{"label":"cgwalters:recommends","ref":"recommends","sha":"542d4aa11fd585aba85c345c0b384e91fb88da25","user":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"repo":{"id":26416044,"node_id":"MDEwOlJlcG9zaXRvcnkyNjQxNjA0NA==","name":"rpm-ostree","full_name":"cgwalters/rpm-ostree","owner":{"login":"cgwalters","id":244096,"node_id":"MDQ6VXNlcjI0NDA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgwalters/rpm-ostree","description":"Store RPMs in OSTree repository","fork":true,"url":"https://api.github.com/repos/cgwalters/rpm-ostree","forks_url":"https://api.github.com/repos/cgwalters/rpm-ostree/forks","keys_url":"https://api.github.com/repos/cgwalters/rpm-ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgwalters/rpm-ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgwalters/rpm-ostree/teams","hooks_url":"https://api.github.com/repos/cgwalters/rpm-ostree/hooks","issue_events_url":"https://api.github.com/repos/cgwalters/rpm-ostree/issues/events{/number}","events_url":"https://api.github.com/repos/cgwalters/rpm-ostree/events","assignees_url":"https://api.github.com/repos/cgwalters/rpm-ostree/assignees{/user}","branches_url":"https://api.github.com/repos/cgwalters/rpm-ostree/branches{/branch}","tags_url":"https://api.github.com/repos/cgwalters/rpm-ostree/tags","blobs_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgwalters/rpm-ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/cgwalters/rpm-ostree/languages","stargazers_url":"https://api.github.com/repos/cgwalters/rpm-ostree/stargazers","contributors_url":"https://api.github.com/repos/cgwalters/rpm-ostree/contributors","subscribers_url":"https://api.github.com/repos/cgwalters/rpm-ostree/subscribers","subscription_url":"https://api.github.com/repos/cgwalters/rpm-ostree/subscription","commits_url":"https://api.github.com/repos/cgwalters/rpm-ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgwalters/rpm-ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgwalters/rpm-ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgwalters/rpm-ostree/contents/{+path}","compare_url":"https://api.github.com/repos/cgwalters/rpm-ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgwalters/rpm-ostree/merges","archive_url":"https://api.github.com/repos/cgwalters/rpm-ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgwalters/rpm-ostree/downloads","issues_url":"https://api.github.com/repos/cgwalters/rpm-ostree/issues{/number}","pulls_url":"https://api.github.com/repos/cgwalters/rpm-ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/cgwalters/rpm-ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/cgwalters/rpm-ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgwalters/rpm-ostree/labels{/name}","releases_url":"https://api.github.com/repos/cgwalters/rpm-ostree/releases{/id}","deployments_url":"https://api.github.com/repos/cgwalters/rpm-ostree/deployments","created_at":"2014-11-10T01:32:34Z","updated_at":"2017-12-05T17:51:48Z","pushed_at":"2018-08-22T14:08:56Z","git_url":"git://github.com/cgwalters/rpm-ostree.git","ssh_url":"git@github.com:cgwalters/rpm-ostree.git","clone_url":"https://github.com/cgwalters/rpm-ostree.git","svn_url":"https://github.com/cgwalters/rpm-ostree","homepage":null,"size":8036,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"6a274b831d2dea7fa8c05a82999f205ab16393b9","user":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":15369584,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2OTU4NA==","name":"rpm-ostree","full_name":"projectatomic/rpm-ostree","owner":{"login":"projectatomic","id":6852258,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NTIyNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/rpm-ostree","description":"⚛📦 Hybrid image/package system with atomic upgrades and package layering","fork":false,"url":"https://api.github.com/repos/projectatomic/rpm-ostree","forks_url":"https://api.github.com/repos/projectatomic/rpm-ostree/forks","keys_url":"https://api.github.com/repos/projectatomic/rpm-ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/rpm-ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/rpm-ostree/teams","hooks_url":"https://api.github.com/repos/projectatomic/rpm-ostree/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/rpm-ostree/events","assignees_url":"https://api.github.com/repos/projectatomic/rpm-ostree/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/rpm-ostree/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/rpm-ostree/tags","blobs_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/rpm-ostree/languages","stargazers_url":"https://api.github.com/repos/projectatomic/rpm-ostree/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/rpm-ostree/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/rpm-ostree/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/rpm-ostree/subscription","commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/rpm-ostree/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/rpm-ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/rpm-ostree/merges","archive_url":"https://api.github.com/repos/projectatomic/rpm-ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/rpm-ostree/downloads","issues_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/rpm-ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/rpm-ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/rpm-ostree/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/rpm-ostree/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/deployments","created_at":"2013-12-22T03:16:38Z","updated_at":"2018-08-21T14:49:33Z","pushed_at":"2018-08-22T14:08:57Z","git_url":"git://github.com/projectatomic/rpm-ostree.git","ssh_url":"git@github.com:projectatomic/rpm-ostree.git","clone_url":"https://github.com/projectatomic/rpm-ostree.git","svn_url":"https://github.com/projectatomic/rpm-ostree","homepage":"","size":7172,"stargazers_count":227,"watchers_count":227,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":180,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":84,"open_issues":180,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513"},"html":{"href":"https://github.com/projectatomic/rpm-ostree/pull/1513"},"issue":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1513"},"comments":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1513/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1513/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/542d4aa11fd585aba85c345c0b384e91fb88da25"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cgwalters"}}