{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/209173495","pull_request_review_id":145136318,"id":209173495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE3MzQ5NQ==","diff_hunk":"@@ -0,0 +1,36 @@\n+/********************************************************************************\n+ * Copyright (C) 2018 TypeFox and others.\n+ *\n+ * This program and the accompanying materials are made available under the\n+ * terms of the Eclipse Public License v. 2.0 which is available at\n+ * http://www.eclipse.org/legal/epl-2.0.\n+ *\n+ * This Source Code may also be made available under the following Secondary\n+ * Licenses when the conditions for such availability set forth in the Eclipse\n+ * Public License v. 2.0 are satisfied: GNU General Public License, version 2\n+ * with the GNU Classpath Exception which is available at\n+ * https://www.gnu.org/software/classpath/license.html.\n+ *\n+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0\n+ ********************************************************************************/\n+\n+import { injectable } from 'inversify';\n+import URI from '@theia/core/lib/common/uri';\n+import { Endpoint } from '@theia/core/lib/browser';\n+\n+@injectable()\n+export class PreviewLinkNormalizer {\n+\n+    normalizeLink(documentUri: URI, link: string): string {\n+        try {\n+            const uri = new URI(link);\n+            if (!uri.scheme) {\n+                const location = documentUri.parent.resolve(link).path.toString();\n+                return new Endpoint({ path: 'mini-browser/' + location }).getRestUrl().toString();","path":"packages/preview/src/browser/preview-link-normalizer.ts","position":null,"original_position":29,"commit_id":"d5aac191d5bcefa5def610a8781db9a344ec9fc9","original_commit_id":"36bd206a3f190ff9a26c4871f3fa64d6a3f1f6c0","user":{"login":"AlexTugarev","id":914497,"node_id":"MDQ6VXNlcjkxNDQ5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/914497?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexTugarev","html_url":"https://github.com/AlexTugarev","followers_url":"https://api.github.com/users/AlexTugarev/followers","following_url":"https://api.github.com/users/AlexTugarev/following{/other_user}","gists_url":"https://api.github.com/users/AlexTugarev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexTugarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexTugarev/subscriptions","organizations_url":"https://api.github.com/users/AlexTugarev/orgs","repos_url":"https://api.github.com/users/AlexTugarev/repos","events_url":"https://api.github.com/users/AlexTugarev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexTugarev/received_events","type":"User","site_admin":false},"body":"Please, have a look.","created_at":"2018-08-10T07:52:58Z","updated_at":"2018-08-10T07:52:59Z","html_url":"https://github.com/theia-ide/theia/pull/2531#discussion_r209173495","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/2531","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/209173495"},"html":{"href":"https://github.com/theia-ide/theia/pull/2531#discussion_r209173495"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2531"}},"in_reply_to_id":209118938},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/2531","id":206992584,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTkyNTg0","html_url":"https://github.com/theia-ide/theia/pull/2531","diff_url":"https://github.com/theia-ide/theia/pull/2531.diff","patch_url":"https://github.com/theia-ide/theia/pull/2531.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/2531","number":2531,"state":"open","locked":false,"title":"[preview/md] show images from workspace","user":{"login":"AlexTugarev","id":914497,"node_id":"MDQ6VXNlcjkxNDQ5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/914497?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexTugarev","html_url":"https://github.com/AlexTugarev","followers_url":"https://api.github.com/users/AlexTugarev/followers","following_url":"https://api.github.com/users/AlexTugarev/following{/other_user}","gists_url":"https://api.github.com/users/AlexTugarev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexTugarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexTugarev/subscriptions","organizations_url":"https://api.github.com/users/AlexTugarev/orgs","repos_url":"https://api.github.com/users/AlexTugarev/repos","events_url":"https://api.github.com/users/AlexTugarev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexTugarev/received_events","type":"User","site_admin":false},"body":"this PR introduces a link normalizer for the markdown renderer, which will convert relative links (of images) to \"mini-browser\" links.\r\n\r\nCloses #2055\r\n\r\nTODO:\r\n- [x] write some tests\r\n- [ ] check for content types","created_at":"2018-08-08T12:35:09Z","updated_at":"2018-08-10T07:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50c7ac9955eb3880bea944e86d785a1f69ccbf62","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/2531/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/2531/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/2531/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/d5aac191d5bcefa5def610a8781db9a344ec9fc9","head":{"label":"theia-ide:at/md-images","ref":"at/md-images","sha":"d5aac191d5bcefa5def610a8781db9a344ec9fc9","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-08-10T07:18:26Z","pushed_at":"2018-08-10T07:52:28Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":122869,"stargazers_count":1097,"watchers_count":1097,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"archived":false,"open_issues_count":549,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":181,"open_issues":549,"watchers":1097,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"5336443c48e75152f587c1221af8c9e6932415e0","user":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA1MDY4MA==","name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTMwMzIz","avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2018-08-10T07:18:26Z","pushed_at":"2018-08-10T07:52:28Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"http://theia-ide.org","size":122869,"stargazers_count":1097,"watchers_count":1097,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":181,"mirror_url":null,"archived":false,"open_issues_count":549,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":181,"open_issues":549,"watchers":1097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2531"},"html":{"href":"https://github.com/theia-ide/theia/pull/2531"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/2531"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/2531/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2531/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/2531/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/d5aac191d5bcefa5def610a8781db9a344ec9fc9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AlexTugarev"}}