{"action":"created","comment":{"url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments/186094092","pull_request_review_id":117616550,"id":186094092,"diff_hunk":"@@ -3931,8 +4039,8 @@ static void *janus_audiobridge_handler(void *data) {\n \t\t\tanswer->s_name = g_strdup(s_name);\n \t\t\t/* Add a fmtp attribute */\n \t\t\tjanus_sdp_attribute *a = janus_sdp_attribute_create(\"fmtp\",\n-\t\t\t\t\"%d maxplaybackrate=%\"SCNu32\"; stereo=0; sprop-stereo=0; useinbandfec=0\\r\\n\",\n-\t\t\t\t\tparticipant->opus_pt, participant->room->sampling_rate);\n+\t\t\t\t\"%d maxplaybackrate=%\"SCNu32\"; stereo=0; sprop-stereo=0; useinbandfec=%s\\r\\n\",\n+\t\t\t\t\tparticipant->opus_pt, participant->room->sampling_rate, use_fec ? \"1\" : \"0\");","path":"plugins/janus_audiobridge.c","position":218,"original_position":218,"commit_id":"e3c644fbc52fa7a569170f568e45c3d8d1b606f8","original_commit_id":"e3c644fbc52fa7a569170f568e45c3d8d1b606f8","user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars1.githubusercontent.com/u/3684796?v=4","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"body":"Why a string? It can be %d with `use_fec ? 1 : 0`.","created_at":"2018-05-04T14:09:52Z","updated_at":"2018-05-04T14:10:11Z","html_url":"https://github.com/meetecho/janus-gateway/pull/1215#discussion_r186094092","pull_request_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments/186094092"},"html":{"href":"https://github.com/meetecho/janus-gateway/pull/1215#discussion_r186094092"},"pull_request":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215"}}},"pull_request":{"url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215","id":183763648,"html_url":"https://github.com/meetecho/janus-gateway/pull/1215","diff_url":"https://github.com/meetecho/janus-gateway/pull/1215.diff","patch_url":"https://github.com/meetecho/janus-gateway/pull/1215.patch","issue_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/1215","number":1215,"state":"open","locked":false,"title":"Opus FEC implementation proposal","user":{"login":"mtbramo","id":33903326,"avatar_url":"https://avatars2.githubusercontent.com/u/33903326?v=4","gravatar_id":"","url":"https://api.github.com/users/mtbramo","html_url":"https://github.com/mtbramo","followers_url":"https://api.github.com/users/mtbramo/followers","following_url":"https://api.github.com/users/mtbramo/following{/other_user}","gists_url":"https://api.github.com/users/mtbramo/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbramo/subscriptions","organizations_url":"https://api.github.com/users/mtbramo/orgs","repos_url":"https://api.github.com/users/mtbramo/repos","events_url":"https://api.github.com/users/mtbramo/events{/privacy}","received_events_url":"https://api.github.com/users/mtbramo/received_events","type":"User","site_admin":false},"body":"It's an implementation of 'Forward Error Correction' featue to improve  poor audio quality due to packets dropped or lost.\r\nWe use Opus encoder capability to embed redundant data and decoder one to rebuild lost packet from FEC data obtain in next packet it receives. We also use 'Packet lost concealment' feature by passing null information to decoder in case of multiple consecutive sequences losts.\r\n\r\nTested on 0.3.0 release, audio quality improvement verified (subjective).","created_at":"2018-04-24T14:50:59Z","updated_at":"2018-05-04T14:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da6cb60be672b1b8f59d0817dad56a600adfca37","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215/commits","review_comments_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215/comments","review_comment_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/1215/comments","statuses_url":"https://api.github.com/repos/meetecho/janus-gateway/statuses/e3c644fbc52fa7a569170f568e45c3d8d1b606f8","head":{"label":"mtbramo:mtbramo-patch-1","ref":"mtbramo-patch-1","sha":"e3c644fbc52fa7a569170f568e45c3d8d1b606f8","user":{"login":"mtbramo","id":33903326,"avatar_url":"https://avatars2.githubusercontent.com/u/33903326?v=4","gravatar_id":"","url":"https://api.github.com/users/mtbramo","html_url":"https://github.com/mtbramo","followers_url":"https://api.github.com/users/mtbramo/followers","following_url":"https://api.github.com/users/mtbramo/following{/other_user}","gists_url":"https://api.github.com/users/mtbramo/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbramo/subscriptions","organizations_url":"https://api.github.com/users/mtbramo/orgs","repos_url":"https://api.github.com/users/mtbramo/repos","events_url":"https://api.github.com/users/mtbramo/events{/privacy}","received_events_url":"https://api.github.com/users/mtbramo/received_events","type":"User","site_admin":false},"repo":{"id":130863086,"name":"janus-gateway","full_name":"mtbramo/janus-gateway","owner":{"login":"mtbramo","id":33903326,"avatar_url":"https://avatars2.githubusercontent.com/u/33903326?v=4","gravatar_id":"","url":"https://api.github.com/users/mtbramo","html_url":"https://github.com/mtbramo","followers_url":"https://api.github.com/users/mtbramo/followers","following_url":"https://api.github.com/users/mtbramo/following{/other_user}","gists_url":"https://api.github.com/users/mtbramo/gists{/gist_id}","starred_url":"https://api.github.com/users/mtbramo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtbramo/subscriptions","organizations_url":"https://api.github.com/users/mtbramo/orgs","repos_url":"https://api.github.com/users/mtbramo/repos","events_url":"https://api.github.com/users/mtbramo/events{/privacy}","received_events_url":"https://api.github.com/users/mtbramo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtbramo/janus-gateway","description":"Janus WebRTC Gateway","fork":true,"url":"https://api.github.com/repos/mtbramo/janus-gateway","forks_url":"https://api.github.com/repos/mtbramo/janus-gateway/forks","keys_url":"https://api.github.com/repos/mtbramo/janus-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtbramo/janus-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtbramo/janus-gateway/teams","hooks_url":"https://api.github.com/repos/mtbramo/janus-gateway/hooks","issue_events_url":"https://api.github.com/repos/mtbramo/janus-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/mtbramo/janus-gateway/events","assignees_url":"https://api.github.com/repos/mtbramo/janus-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/mtbramo/janus-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/mtbramo/janus-gateway/tags","blobs_url":"https://api.github.com/repos/mtbramo/janus-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtbramo/janus-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtbramo/janus-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtbramo/janus-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtbramo/janus-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/mtbramo/janus-gateway/languages","stargazers_url":"https://api.github.com/repos/mtbramo/janus-gateway/stargazers","contributors_url":"https://api.github.com/repos/mtbramo/janus-gateway/contributors","subscribers_url":"https://api.github.com/repos/mtbramo/janus-gateway/subscribers","subscription_url":"https://api.github.com/repos/mtbramo/janus-gateway/subscription","commits_url":"https://api.github.com/repos/mtbramo/janus-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtbramo/janus-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtbramo/janus-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtbramo/janus-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtbramo/janus-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/mtbramo/janus-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtbramo/janus-gateway/merges","archive_url":"https://api.github.com/repos/mtbramo/janus-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtbramo/janus-gateway/downloads","issues_url":"https://api.github.com/repos/mtbramo/janus-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/mtbramo/janus-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/mtbramo/janus-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/mtbramo/janus-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtbramo/janus-gateway/labels{/name}","releases_url":"https://api.github.com/repos/mtbramo/janus-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/mtbramo/janus-gateway/deployments","created_at":"2018-04-24T14:00:35Z","updated_at":"2018-04-24T14:00:38Z","pushed_at":"2018-04-26T17:07:23Z","git_url":"git://github.com/mtbramo/janus-gateway.git","ssh_url":"git@github.com:mtbramo/janus-gateway.git","clone_url":"https://github.com/mtbramo/janus-gateway.git","svn_url":"https://github.com/mtbramo/janus-gateway","homepage":null,"size":20572,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meetecho:master","ref":"master","sha":"673ac3fdc2c683c5bd79338408805d22b394577e","user":{"login":"meetecho","id":4520545,"avatar_url":"https://avatars2.githubusercontent.com/u/4520545?v=4","gravatar_id":"","url":"https://api.github.com/users/meetecho","html_url":"https://github.com/meetecho","followers_url":"https://api.github.com/users/meetecho/followers","following_url":"https://api.github.com/users/meetecho/following{/other_user}","gists_url":"https://api.github.com/users/meetecho/gists{/gist_id}","starred_url":"https://api.github.com/users/meetecho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetecho/subscriptions","organizations_url":"https://api.github.com/users/meetecho/orgs","repos_url":"https://api.github.com/users/meetecho/repos","events_url":"https://api.github.com/users/meetecho/events{/privacy}","received_events_url":"https://api.github.com/users/meetecho/received_events","type":"Organization","site_admin":false},"repo":{"id":16734696,"name":"janus-gateway","full_name":"meetecho/janus-gateway","owner":{"login":"meetecho","id":4520545,"avatar_url":"https://avatars2.githubusercontent.com/u/4520545?v=4","gravatar_id":"","url":"https://api.github.com/users/meetecho","html_url":"https://github.com/meetecho","followers_url":"https://api.github.com/users/meetecho/followers","following_url":"https://api.github.com/users/meetecho/following{/other_user}","gists_url":"https://api.github.com/users/meetecho/gists{/gist_id}","starred_url":"https://api.github.com/users/meetecho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetecho/subscriptions","organizations_url":"https://api.github.com/users/meetecho/orgs","repos_url":"https://api.github.com/users/meetecho/repos","events_url":"https://api.github.com/users/meetecho/events{/privacy}","received_events_url":"https://api.github.com/users/meetecho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetecho/janus-gateway","description":"Janus WebRTC Server","fork":false,"url":"https://api.github.com/repos/meetecho/janus-gateway","forks_url":"https://api.github.com/repos/meetecho/janus-gateway/forks","keys_url":"https://api.github.com/repos/meetecho/janus-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetecho/janus-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetecho/janus-gateway/teams","hooks_url":"https://api.github.com/repos/meetecho/janus-gateway/hooks","issue_events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/meetecho/janus-gateway/events","assignees_url":"https://api.github.com/repos/meetecho/janus-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/meetecho/janus-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/meetecho/janus-gateway/tags","blobs_url":"https://api.github.com/repos/meetecho/janus-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetecho/janus-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetecho/janus-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetecho/janus-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetecho/janus-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/meetecho/janus-gateway/languages","stargazers_url":"https://api.github.com/repos/meetecho/janus-gateway/stargazers","contributors_url":"https://api.github.com/repos/meetecho/janus-gateway/contributors","subscribers_url":"https://api.github.com/repos/meetecho/janus-gateway/subscribers","subscription_url":"https://api.github.com/repos/meetecho/janus-gateway/subscription","commits_url":"https://api.github.com/repos/meetecho/janus-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetecho/janus-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetecho/janus-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/meetecho/janus-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetecho/janus-gateway/merges","archive_url":"https://api.github.com/repos/meetecho/janus-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetecho/janus-gateway/downloads","issues_url":"https://api.github.com/repos/meetecho/janus-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/meetecho/janus-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/meetecho/janus-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/labels{/name}","releases_url":"https://api.github.com/repos/meetecho/janus-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/meetecho/janus-gateway/deployments","created_at":"2014-02-11T15:14:39Z","updated_at":"2018-05-04T13:54:16Z","pushed_at":"2018-05-04T14:06:10Z","git_url":"git://github.com/meetecho/janus-gateway.git","ssh_url":"git@github.com:meetecho/janus-gateway.git","clone_url":"https://github.com/meetecho/janus-gateway.git","svn_url":"https://github.com/meetecho/janus-gateway","homepage":"","size":20712,"stargazers_count":1790,"watchers_count":1790,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":724,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":724,"open_issues":27,"watchers":1790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215"},"html":{"href":"https://github.com/meetecho/janus-gateway/pull/1215"},"issue":{"href":"https://api.github.com/repos/meetecho/janus-gateway/issues/1215"},"comments":{"href":"https://api.github.com/repos/meetecho/janus-gateway/issues/1215/comments"},"review_comments":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215/comments"},"review_comment":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/1215/commits"},"statuses":{"href":"https://api.github.com/repos/meetecho/janus-gateway/statuses/e3c644fbc52fa7a569170f568e45c3d8d1b606f8"}},"author_association":"NONE"}}
{"actor":{"display_login":"lminiero"}}