{"action":"opened","number":67,"pull_request":{"url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/67","id":184753141,"html_url":"https://github.com/elifesciences/elife-crossref-xml-generation/pull/67","diff_url":"https://github.com/elifesciences/elife-crossref-xml-generation/pull/67.diff","patch_url":"https://github.com/elifesciences/elife-crossref-xml-generation/pull/67.patch","issue_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/67","number":67,"state":"open","locked":false,"title":"eLife elocation_id and config refactoring","user":{"login":"gnott","id":1779115,"avatar_url":"https://avatars1.githubusercontent.com/u/1779115?v=4","gravatar_id":"","url":"https://api.github.com/users/gnott","html_url":"https://github.com/gnott","followers_url":"https://api.github.com/users/gnott/followers","following_url":"https://api.github.com/users/gnott/following{/other_user}","gists_url":"https://api.github.com/users/gnott/gists{/gist_id}","starred_url":"https://api.github.com/users/gnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnott/subscriptions","organizations_url":"https://api.github.com/users/gnott/orgs","repos_url":"https://api.github.com/users/gnott/repos","events_url":"https://api.github.com/users/gnott/events{/privacy}","received_events_url":"https://api.github.com/users/gnott/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/elifesciences/elife-crossref-feed/issues/134.\r\n\r\nBreaking change to how the configuration is specified and passed in the generation functions.\r\n\r\nI started out aiming to solve the basic issue of including the ``elocation-id`` value for eLife deposits, which would have been possible by changing one configuration value.\r\n\r\nFollowing to where in the ``elife-bot`` project this library is used, I noticed it was difficult to load the configuration file from a different location, since it was always preferring to load the default ``crossref.cfg`` file. Now, instead of specifying the config section to load, the config object itself is passed in to the generate functions, to allow for more flexibility.\r\n\r\nThe files in the ``test_data`` folder here should all be for eLife articles, and now include the ``elocation-id`` value.\r\n\r\nOnce this PR is ok and merged, I can continue with the ``elife-bot`` project integration based on the refactoring here.\r\n\r\nI will also have a PR for the ``elife-bot-formula`` repo to deploy an updated ``crossref.cfg`` file to our production system.","created_at":"2018-04-28T00:29:50Z","updated_at":"2018-04-28T00:29:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/67/commits","review_comments_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/67/comments","review_comment_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/67/comments","statuses_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/statuses/86b89f9ef132203f5310b67ae7f95a4226f18162","head":{"label":"elifesciences:feature-elife-elocation-id","ref":"feature-elife-elocation-id","sha":"86b89f9ef132203f5310b67ae7f95a4226f18162","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":95716515,"name":"elife-crossref-xml-generation","full_name":"elifesciences/elife-crossref-xml-generation","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/elife-crossref-xml-generation","description":"Crossref deposit of journal articles","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation","forks_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/deployments","created_at":"2017-06-28T22:21:40Z","updated_at":"2018-04-11T22:10:46Z","pushed_at":"2018-04-28T00:18:59Z","git_url":"git://github.com/elifesciences/elife-crossref-xml-generation.git","ssh_url":"git@github.com:elifesciences/elife-crossref-xml-generation.git","clone_url":"https://github.com/elifesciences/elife-crossref-xml-generation.git","svn_url":"https://github.com/elifesciences/elife-crossref-xml-generation","homepage":null,"size":911,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"e26049867fedd6954f0de2a02c86c66035629329","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":95716515,"name":"elife-crossref-xml-generation","full_name":"elifesciences/elife-crossref-xml-generation","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/elife-crossref-xml-generation","description":"Crossref deposit of journal articles","fork":false,"url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation","forks_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/forks","keys_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/teams","hooks_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/events","assignees_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/tags","blobs_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/languages","stargazers_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/subscription","commits_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/merges","archive_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/downloads","issues_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/deployments","created_at":"2017-06-28T22:21:40Z","updated_at":"2018-04-11T22:10:46Z","pushed_at":"2018-04-28T00:18:59Z","git_url":"git://github.com/elifesciences/elife-crossref-xml-generation.git","ssh_url":"git@github.com:elifesciences/elife-crossref-xml-generation.git","clone_url":"https://github.com/elifesciences/elife-crossref-xml-generation.git","svn_url":"https://github.com/elifesciences/elife-crossref-xml-generation","homepage":null,"size":911,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/67"},"html":{"href":"https://github.com/elifesciences/elife-crossref-xml-generation/pull/67"},"issue":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/67"},"comments":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/elife-crossref-xml-generation/statuses/86b89f9ef132203f5310b67ae7f95a4226f18162"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":54,"deletions":28,"changed_files":18}}
{"actor":{"display_login":"gnott"}}