{"push_id":2899306331,"size":61,"distinct_size":61,"ref":"refs/heads/master","head":"74cc80fd99df4874fcd1cfd5ce5db0f771106b3a","before":"e80738c16b91226fa48991ad680004bbacf693b9","commits":[{"sha":"dade6921fda086a7190119b7082b6a73bb35ba7d","author":{"name":"Josh Attenberg","email":"809dedc0796693c04825d990d4aacafb6b162287@gmail.com"},"message":"more functional meanshift example","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/dade6921fda086a7190119b7082b6a73bb35ba7d"},{"sha":"917b9e511d92bcc410f639955c71ed48ce0c11c1","author":{"name":"slawekslex","email":"8d5c2e2656071e44b9d70cc769a3b7a65b18370c@gmail.com"},"message":"Fixes how structured.proc_df() one hot encoding works on a test set.\n\nThe problem:\r\nWhen we pass max_n_cat to proc_df() it looks at the number of distinct values to decide whether to expand it into 1-hot encoded columns or not.\r\nThe issue arrises when the test set has smaller number of distinct values and falls below the treshold while the train set doesn't. We end up with different set of columns in the two sets.\r\n\r\nProposed solution:\r\nRather than look at the count of distinct values look at the number of categories associated with the column. This will be the same between the sets if train_cats(), apply_cats() functions were use\r\n\r\nExample:\r\n    df1 = pd.DataFrame({'col1':['a','b','c']})\r\n    df2 = pd.DataFrame({'col1':['a','b','b']})\r\n    train_cats(df1)\r\n    apply_cats(df2, df1)\r\n    df1_proc,*_ = proc_df(df1, max_n_cat=2)\r\n    df2_proc,*_ = proc_df(df2, max_n_cat=2)\r\n    set(df1_proc.columns) == set(df2_proc.columns)\r\n\r\nUsed to return False and now returns True\r\n\r\nTest Plan:\r\n    - Run the Example above\r\n    - Loaded a test set with a mix of numerical, low and high cardinality categories. Verify that things work as before.","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/917b9e511d92bcc410f639955c71ed48ce0c11c1"},{"sha":"8783ac17eb7008f478638808fb82220e34b83b8e","author":{"name":"slawekslex","email":"8d5c2e2656071e44b9d70cc769a3b7a65b18370c@gmail.com"},"message":"Merge pull request #1 from slawekslex/proc_df_categories\n\nFixes how structured.proc_df() one hot encoding works on a test set.","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/8783ac17eb7008f478638808fb82220e34b83b8e"},{"sha":"d0fee095dafdd9985bddbd55fc7acde9f9c5ebf5","author":{"name":"Donfa1con","email":"603584c15fba535be3ad6490faa92b3a4b8dad85@inbox.ru"},"message":"Set same type for DynamicUnet parameters","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/d0fee095dafdd9985bddbd55fc7acde9f9c5ebf5"},{"sha":"058983779bcdb8f5fd6326512e64ed9be136c564","author":{"name":"Josh Attenberg","email":"809dedc0796693c04825d990d4aacafb6b162287@gmail.com"},"message":"to_gpu, updating the name, run with gpu","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/058983779bcdb8f5fd6326512e64ed9be136c564"},{"sha":"bb3912fb6fd5c84dd230597e4a19dc5b3461aa44","author":{"name":"Aayush Yadav","email":"3647aa6412b9c9452b58e7cd13b875b347785a9c@gmail.com"},"message":"Update learner.py","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/bb3912fb6fd5c84dd230597e4a19dc5b3461aa44"},{"sha":"4c96defaedc5af4d0adfe67005b4e6720e5a6e16","author":{"name":"Aayush Yadav","email":"3647aa6412b9c9452b58e7cd13b875b347785a9c@gmail.com"},"message":"Delete losses.py","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/4c96defaedc5af4d0adfe67005b4e6720e5a6e16"},{"sha":"b52c834608cce5ce70ec99f414c738111a9623da","author":{"name":"Eric Noulard","email":"bf5e4217e6d57d6f87279b13b878ff0011ed058d@antidot.net"},"message":"pandas_summary v0.0.41 does not exist","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/b52c834608cce5ce70ec99f414c738111a9623da"},{"sha":"02f9d275dc367f4a742706aa097a6b8569fbce3c","author":{"name":"John Richmond","email":"13364c96d85de414d7fdd126acb6d41e3ccce221@gmail.com"},"message":"Changes to make the learner.predict_array method work when called from conv_learner when .precompute = True.  I have had to over ride he predict_array function in Learner since conv_learner over rides the model property and otherwise causes a problem.\n\nI have also added a check in the predict_array method to make sure that it is passed a numpy array.  In some to the fastai notebook examples it looks to get passed an image which caused me confusion.","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/02f9d275dc367f4a742706aa097a6b8569fbce3c"},{"sha":"569d350e3cc5252b3594b54c1a32e6cfc2643e72","author":{"name":"Jörg Dietrich","email":"90c9d7bdfb9d0c5e66af97805a37e344db1ed038@joergdietrich.com"},"message":"add tqdm progress bar for evaluation of validation set","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/569d350e3cc5252b3594b54c1a32e6cfc2643e72"},{"sha":"6577a8621c0197141796429172e691b48082ce9b","author":{"name":"George Peristerakis","email":"40ee243b4046b3368883f1a6a1b1f9ee2392fa90@gmail.com"},"message":"Added the spacy library in the install_required list","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/6577a8621c0197141796429172e691b48082ce9b"},{"sha":"341b3d7a0cef7ff072c16de514448eab81f7bb71","author":{"name":"Sylvain Gugger","email":"222c4d44cc8ec39802c192ed0aa3f97cdb77ff4e@users.noreply.github.com"},"message":"Style change","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/341b3d7a0cef7ff072c16de514448eab81f7bb71"},{"sha":"e17501538300a78103f793dfe0667859184e6766","author":{"name":"Sylvain Gugger","email":"222c4d44cc8ec39802c192ed0aa3f97cdb77ff4e@users.noreply.github.com"},"message":"Merge pull request #733 from fromLittleAcorns/master\n\nChanges to make the learner.predict_array method work when called fro…","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/e17501538300a78103f793dfe0667859184e6766"},{"sha":"a99eb436a92454eb292e5d04beb34da2148bcf75","author":{"name":"Sylvain Gugger","email":"222c4d44cc8ec39802c192ed0aa3f97cdb77ff4e@users.noreply.github.com"},"message":"Merge pull request #724 from dust0x/master\n\nDelete losses.py, remove import(s)","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/a99eb436a92454eb292e5d04beb34da2148bcf75"},{"sha":"2f16221cd956d6d79f082feeb11ec2958f5f38e8","author":{"name":"Sylvain Gugger","email":"222c4d44cc8ec39802c192ed0aa3f97cdb77ff4e@users.noreply.github.com"},"message":"Small refactor","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/2f16221cd956d6d79f082feeb11ec2958f5f38e8"},{"sha":"745ddabcf9301b0078a16ac6333cd41684df149b","author":{"name":"Sylvain Gugger","email":"222c4d44cc8ec39802c192ed0aa3f97cdb77ff4e@users.noreply.github.com"},"message":"Merge pull request #734 from joergdietrich/validation_progress\n\nadd tqdm progress bar for evaluation of validation set","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/745ddabcf9301b0078a16ac6333cd41684df149b"},{"sha":"043172a1a9e141a97b17b083720228be0d1cfbd5","author":{"name":"Aayush Yadav","email":"3647aa6412b9c9452b58e7cd13b875b347785a9c@gmail.com"},"message":"Update layer_optimizer.py","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/043172a1a9e141a97b17b083720228be0d1cfbd5"},{"sha":"c15bf6caeec5e7ca1a06604abe45c0e42f839e4c","author":{"name":"Aayush Yadav","email":"3647aa6412b9c9452b58e7cd13b875b347785a9c@gmail.com"},"message":"Merge pull request #1 from dust0x/dust0x-patch-1\n\nUpdate layer_optimizer (test passed)","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/c15bf6caeec5e7ca1a06604abe45c0e42f839e4c"},{"sha":"d625b52ea000e6bc0a979f99f8ca59fae2d97691","author":{"name":"Stas Bekman","email":"bef361c46d3d1fa291296f6d65d7f2ef6cbcf237@stason.org"},"message":"replace accuracy_np() with accuracy() to fix:\n\nTypeError: eq received an invalid combination of arguments - got (torch.cuda.LongTensor), but expected one of:\n\n(int value)\ndidn’t match because some of the arguments have invalid types: (!torch.cuda.LongTensor!)\n(torch.LongTensor other)\ndidn’t match because some of the arguments have invalid types: (!torch.cuda.LongTensor!)\n￼","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/d625b52ea000e6bc0a979f99f8ca59fae2d97691"},{"sha":"be685202a888953a3884ca3c52310910b50e73de","author":{"name":"Royal Bhati","email":"4a5f1914d57cf3d43f87145d9dea4ebee83adb99@gmail.com"},"message":"typo fixed","distinct":true,"url":"https://api.github.com/repos/mattevenson/fastai/commits/be685202a888953a3884ca3c52310910b50e73de"}]}
{"actor":{"display_login":"mattevenson"}}