{"action":"created","comment":{"url":"https://api.github.com/repos/robotika/osgar/pulls/comments/216449603","pull_request_review_id":153933666,"id":216449603,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ0OTYwMw==","diff_hunk":"@@ -46,6 +51,9 @@ def __init__(self, config, bus):\n         self.bus = bus\n         self.buf = b''\n \n+        speed = config.get('speed', 1000000)  # default 1Mbit\n+        self.can_speed_cmd = CAN_SPEED[speed]","path":"osgar/drivers/canserial.py","position":19,"original_position":19,"commit_id":"95778560697aa9dea6f45eca489c584cad53d204","original_commit_id":"95778560697aa9dea6f45eca489c584cad53d204","user":{"login":"zwn","id":1130051,"node_id":"MDQ6VXNlcjExMzAwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1130051?v=4","gravatar_id":"","url":"https://api.github.com/users/zwn","html_url":"https://github.com/zwn","followers_url":"https://api.github.com/users/zwn/followers","following_url":"https://api.github.com/users/zwn/following{/other_user}","gists_url":"https://api.github.com/users/zwn/gists{/gist_id}","starred_url":"https://api.github.com/users/zwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwn/subscriptions","organizations_url":"https://api.github.com/users/zwn/orgs","repos_url":"https://api.github.com/users/zwn/repos","events_url":"https://api.github.com/users/zwn/events{/privacy}","received_events_url":"https://api.github.com/users/zwn/received_events","type":"User","site_admin":false},"body":"It does not feel right to throw exception here if the value of `speed` is not a valid key in `CAN_SPEED`. Or is that intentional?","created_at":"2018-09-10T19:47:23Z","updated_at":"2018-09-10T19:47:23Z","html_url":"https://github.com/robotika/osgar/pull/80#discussion_r216449603","pull_request_url":"https://api.github.com/repos/robotika/osgar/pulls/80","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/robotika/osgar/pulls/comments/216449603"},"html":{"href":"https://github.com/robotika/osgar/pull/80#discussion_r216449603"},"pull_request":{"href":"https://api.github.com/repos/robotika/osgar/pulls/80"}}},"pull_request":{"url":"https://api.github.com/repos/robotika/osgar/pulls/80","id":214383202,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzgzMjAy","html_url":"https://github.com/robotika/osgar/pull/80","diff_url":"https://github.com/robotika/osgar/pull/80.diff","patch_url":"https://github.com/robotika/osgar/pull/80.patch","issue_url":"https://api.github.com/repos/robotika/osgar/issues/80","number":80,"state":"open","locked":false,"title":"CANSerial - add configurable speed and CANOpen mode","user":{"login":"m3d","id":5664353,"node_id":"MDQ6VXNlcjU2NjQzNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5664353?v=4","gravatar_id":"","url":"https://api.github.com/users/m3d","html_url":"https://github.com/m3d","followers_url":"https://api.github.com/users/m3d/followers","following_url":"https://api.github.com/users/m3d/following{/other_user}","gists_url":"https://api.github.com/users/m3d/gists{/gist_id}","starred_url":"https://api.github.com/users/m3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3d/subscriptions","organizations_url":"https://api.github.com/users/m3d/orgs","repos_url":"https://api.github.com/users/m3d/repos","events_url":"https://api.github.com/users/m3d/events{/privacy}","received_events_url":"https://api.github.com/users/m3d/received_events","type":"User","site_admin":false},"body":"John Deere and Eduro robots need CAN speed 250kb/s and switch for operation and pre-operational\r\nstate. This is cherry-picked commit for tomorrow Eduro development.","created_at":"2018-09-10T17:09:32Z","updated_at":"2018-09-10T19:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39d82000a604067011543e6f4587d3f11d57fe03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotika/osgar/pulls/80/commits","review_comments_url":"https://api.github.com/repos/robotika/osgar/pulls/80/comments","review_comment_url":"https://api.github.com/repos/robotika/osgar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotika/osgar/issues/80/comments","statuses_url":"https://api.github.com/repos/robotika/osgar/statuses/95778560697aa9dea6f45eca489c584cad53d204","head":{"label":"robotika:feature/canserial-config","ref":"feature/canserial-config","sha":"95778560697aa9dea6f45eca489c584cad53d204","user":{"login":"robotika","id":5670473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzA0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5670473?v=4","gravatar_id":"","url":"https://api.github.com/users/robotika","html_url":"https://github.com/robotika","followers_url":"https://api.github.com/users/robotika/followers","following_url":"https://api.github.com/users/robotika/following{/other_user}","gists_url":"https://api.github.com/users/robotika/gists{/gist_id}","starred_url":"https://api.github.com/users/robotika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotika/subscriptions","organizations_url":"https://api.github.com/users/robotika/orgs","repos_url":"https://api.github.com/users/robotika/repos","events_url":"https://api.github.com/users/robotika/events{/privacy}","received_events_url":"https://api.github.com/users/robotika/received_events","type":"Organization","site_admin":false},"repo":{"id":20634831,"node_id":"MDEwOlJlcG9zaXRvcnkyMDYzNDgzMQ==","name":"osgar","full_name":"robotika/osgar","owner":{"login":"robotika","id":5670473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzA0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5670473?v=4","gravatar_id":"","url":"https://api.github.com/users/robotika","html_url":"https://github.com/robotika","followers_url":"https://api.github.com/users/robotika/followers","following_url":"https://api.github.com/users/robotika/following{/other_user}","gists_url":"https://api.github.com/users/robotika/gists{/gist_id}","starred_url":"https://api.github.com/users/robotika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotika/subscriptions","organizations_url":"https://api.github.com/users/robotika/orgs","repos_url":"https://api.github.com/users/robotika/repos","events_url":"https://api.github.com/users/robotika/events{/privacy}","received_events_url":"https://api.github.com/users/robotika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotika/osgar","description":"Open Source Garden (Autonomous) Robot","fork":false,"url":"https://api.github.com/repos/robotika/osgar","forks_url":"https://api.github.com/repos/robotika/osgar/forks","keys_url":"https://api.github.com/repos/robotika/osgar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotika/osgar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotika/osgar/teams","hooks_url":"https://api.github.com/repos/robotika/osgar/hooks","issue_events_url":"https://api.github.com/repos/robotika/osgar/issues/events{/number}","events_url":"https://api.github.com/repos/robotika/osgar/events","assignees_url":"https://api.github.com/repos/robotika/osgar/assignees{/user}","branches_url":"https://api.github.com/repos/robotika/osgar/branches{/branch}","tags_url":"https://api.github.com/repos/robotika/osgar/tags","blobs_url":"https://api.github.com/repos/robotika/osgar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotika/osgar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotika/osgar/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotika/osgar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotika/osgar/statuses/{sha}","languages_url":"https://api.github.com/repos/robotika/osgar/languages","stargazers_url":"https://api.github.com/repos/robotika/osgar/stargazers","contributors_url":"https://api.github.com/repos/robotika/osgar/contributors","subscribers_url":"https://api.github.com/repos/robotika/osgar/subscribers","subscription_url":"https://api.github.com/repos/robotika/osgar/subscription","commits_url":"https://api.github.com/repos/robotika/osgar/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotika/osgar/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotika/osgar/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotika/osgar/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotika/osgar/contents/{+path}","compare_url":"https://api.github.com/repos/robotika/osgar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotika/osgar/merges","archive_url":"https://api.github.com/repos/robotika/osgar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotika/osgar/downloads","issues_url":"https://api.github.com/repos/robotika/osgar/issues{/number}","pulls_url":"https://api.github.com/repos/robotika/osgar/pulls{/number}","milestones_url":"https://api.github.com/repos/robotika/osgar/milestones{/number}","notifications_url":"https://api.github.com/repos/robotika/osgar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotika/osgar/labels{/name}","releases_url":"https://api.github.com/repos/robotika/osgar/releases{/id}","deployments_url":"https://api.github.com/repos/robotika/osgar/deployments","created_at":"2014-06-09T04:54:03Z","updated_at":"2018-09-10T16:10:01Z","pushed_at":"2018-09-10T17:54:04Z","git_url":"git://github.com/robotika/osgar.git","ssh_url":"git@github.com:robotika/osgar.git","clone_url":"https://github.com/robotika/osgar.git","svn_url":"https://github.com/robotika/osgar","homepage":null,"size":510,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"robotika:master","ref":"master","sha":"fc56e87be055dbf57c45ef39f68cb79b0ac795eb","user":{"login":"robotika","id":5670473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzA0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5670473?v=4","gravatar_id":"","url":"https://api.github.com/users/robotika","html_url":"https://github.com/robotika","followers_url":"https://api.github.com/users/robotika/followers","following_url":"https://api.github.com/users/robotika/following{/other_user}","gists_url":"https://api.github.com/users/robotika/gists{/gist_id}","starred_url":"https://api.github.com/users/robotika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotika/subscriptions","organizations_url":"https://api.github.com/users/robotika/orgs","repos_url":"https://api.github.com/users/robotika/repos","events_url":"https://api.github.com/users/robotika/events{/privacy}","received_events_url":"https://api.github.com/users/robotika/received_events","type":"Organization","site_admin":false},"repo":{"id":20634831,"node_id":"MDEwOlJlcG9zaXRvcnkyMDYzNDgzMQ==","name":"osgar","full_name":"robotika/osgar","owner":{"login":"robotika","id":5670473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NzA0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5670473?v=4","gravatar_id":"","url":"https://api.github.com/users/robotika","html_url":"https://github.com/robotika","followers_url":"https://api.github.com/users/robotika/followers","following_url":"https://api.github.com/users/robotika/following{/other_user}","gists_url":"https://api.github.com/users/robotika/gists{/gist_id}","starred_url":"https://api.github.com/users/robotika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotika/subscriptions","organizations_url":"https://api.github.com/users/robotika/orgs","repos_url":"https://api.github.com/users/robotika/repos","events_url":"https://api.github.com/users/robotika/events{/privacy}","received_events_url":"https://api.github.com/users/robotika/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotika/osgar","description":"Open Source Garden (Autonomous) Robot","fork":false,"url":"https://api.github.com/repos/robotika/osgar","forks_url":"https://api.github.com/repos/robotika/osgar/forks","keys_url":"https://api.github.com/repos/robotika/osgar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotika/osgar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotika/osgar/teams","hooks_url":"https://api.github.com/repos/robotika/osgar/hooks","issue_events_url":"https://api.github.com/repos/robotika/osgar/issues/events{/number}","events_url":"https://api.github.com/repos/robotika/osgar/events","assignees_url":"https://api.github.com/repos/robotika/osgar/assignees{/user}","branches_url":"https://api.github.com/repos/robotika/osgar/branches{/branch}","tags_url":"https://api.github.com/repos/robotika/osgar/tags","blobs_url":"https://api.github.com/repos/robotika/osgar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotika/osgar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotika/osgar/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotika/osgar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotika/osgar/statuses/{sha}","languages_url":"https://api.github.com/repos/robotika/osgar/languages","stargazers_url":"https://api.github.com/repos/robotika/osgar/stargazers","contributors_url":"https://api.github.com/repos/robotika/osgar/contributors","subscribers_url":"https://api.github.com/repos/robotika/osgar/subscribers","subscription_url":"https://api.github.com/repos/robotika/osgar/subscription","commits_url":"https://api.github.com/repos/robotika/osgar/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotika/osgar/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotika/osgar/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotika/osgar/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotika/osgar/contents/{+path}","compare_url":"https://api.github.com/repos/robotika/osgar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotika/osgar/merges","archive_url":"https://api.github.com/repos/robotika/osgar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotika/osgar/downloads","issues_url":"https://api.github.com/repos/robotika/osgar/issues{/number}","pulls_url":"https://api.github.com/repos/robotika/osgar/pulls{/number}","milestones_url":"https://api.github.com/repos/robotika/osgar/milestones{/number}","notifications_url":"https://api.github.com/repos/robotika/osgar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotika/osgar/labels{/name}","releases_url":"https://api.github.com/repos/robotika/osgar/releases{/id}","deployments_url":"https://api.github.com/repos/robotika/osgar/deployments","created_at":"2014-06-09T04:54:03Z","updated_at":"2018-09-10T16:10:01Z","pushed_at":"2018-09-10T17:54:04Z","git_url":"git://github.com/robotika/osgar.git","ssh_url":"git@github.com:robotika/osgar.git","clone_url":"https://github.com/robotika/osgar.git","svn_url":"https://github.com/robotika/osgar","homepage":null,"size":510,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotika/osgar/pulls/80"},"html":{"href":"https://github.com/robotika/osgar/pull/80"},"issue":{"href":"https://api.github.com/repos/robotika/osgar/issues/80"},"comments":{"href":"https://api.github.com/repos/robotika/osgar/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/robotika/osgar/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/robotika/osgar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotika/osgar/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/robotika/osgar/statuses/95778560697aa9dea6f45eca489c584cad53d204"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"zwn"}}