{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/245018771","pull_request_review_id":189035661,"id":245018771,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAxODc3MQ==","diff_hunk":"@@ -35,6 +35,9 @@ public List<ExtractResult> Extract(string text, DateObject reference)\n                 timePeriodErs = TimeZoneUtility.MergeTimeZones(timePeriodErs, config.TimeZoneExtractor.Extract(text, reference), text);\r\n             }\r\n \r\n+            //TODO: Quick fix to solve german morgen (morning) / morgen (tomorrow) ambiguity, move to config\r\n+            if (text.Equals(\"morgen\")) timePeriodErs.Clear();\r","path":".NET/Microsoft.Recognizers.Text.DateTime/Extractors/BaseTimePeriodExtractor.cs","position":14,"original_position":14,"commit_id":"c2181a5267f6784b1fd8a876f3ed9b35e9aea4db","original_commit_id":"c2181a5267f6784b1fd8a876f3ed9b35e9aea4db","user":{"login":"n01d","id":5029466,"node_id":"MDQ6VXNlcjUwMjk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5029466?v=4","gravatar_id":"","url":"https://api.github.com/users/n01d","html_url":"https://github.com/n01d","followers_url":"https://api.github.com/users/n01d/followers","following_url":"https://api.github.com/users/n01d/following{/other_user}","gists_url":"https://api.github.com/users/n01d/gists{/gist_id}","starred_url":"https://api.github.com/users/n01d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01d/subscriptions","organizations_url":"https://api.github.com/users/n01d/orgs","repos_url":"https://api.github.com/users/n01d/repos","events_url":"https://api.github.com/users/n01d/events{/privacy}","received_events_url":"https://api.github.com/users/n01d/received_events","type":"User","site_admin":false},"body":"Fixing it with a hard match in the base class isn't a nice way to do it, but the only way we found without changing the configs for all languages. This adresses cases where the first word ist \"morgen\" like \"morgen abend\" or \"morgen früh\", so there will never be a \".\" or other non word char between those words, as this would change the meaning. I will add the brackets.","created_at":"2019-01-03T14:40:15Z","updated_at":"2019-01-03T14:40:16Z","html_url":"https://github.com/Microsoft/Recognizers-Text/pull/1084#discussion_r245018771","pull_request_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments/245018771"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/1084#discussion_r245018771"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084"}},"in_reply_to_id":244905621},"pull_request":{"url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084","id":241220752,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjIwNzUy","html_url":"https://github.com/Microsoft/Recognizers-Text/pull/1084","diff_url":"https://github.com/Microsoft/Recognizers-Text/pull/1084.diff","patch_url":"https://github.com/Microsoft/Recognizers-Text/pull/1084.patch","issue_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/1084","number":1084,"state":"open","locked":false,"title":"Handle tomorrow/morning ambiguity for German, add to Holidays","user":{"login":"n01d","id":5029466,"node_id":"MDQ6VXNlcjUwMjk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5029466?v=4","gravatar_id":"","url":"https://api.github.com/users/n01d","html_url":"https://github.com/n01d","followers_url":"https://api.github.com/users/n01d/followers","following_url":"https://api.github.com/users/n01d/following{/other_user}","gists_url":"https://api.github.com/users/n01d/gists{/gist_id}","starred_url":"https://api.github.com/users/n01d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01d/subscriptions","organizations_url":"https://api.github.com/users/n01d/orgs","repos_url":"https://api.github.com/users/n01d/repos","events_url":"https://api.github.com/users/n01d/events{/privacy}","received_events_url":"https://api.github.com/users/n01d/received_events","type":"User","site_admin":false},"body":"- Handle morgen (tomorrow) / morgen (morning) ambiguity for German\r\n- Add more holidays for German DateTime\r\n- Update and add to test specs for Datetime German","created_at":"2018-12-27T20:42:05Z","updated_at":"2019-01-03T14:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/1084/comments","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/c2181a5267f6784b1fd8a876f3ed9b35e9aea4db","head":{"label":"n01d:refactoring/timeofday","ref":"refactoring/timeofday","sha":"c2181a5267f6784b1fd8a876f3ed9b35e9aea4db","user":{"login":"n01d","id":5029466,"node_id":"MDQ6VXNlcjUwMjk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5029466?v=4","gravatar_id":"","url":"https://api.github.com/users/n01d","html_url":"https://github.com/n01d","followers_url":"https://api.github.com/users/n01d/followers","following_url":"https://api.github.com/users/n01d/following{/other_user}","gists_url":"https://api.github.com/users/n01d/gists{/gist_id}","starred_url":"https://api.github.com/users/n01d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01d/subscriptions","organizations_url":"https://api.github.com/users/n01d/orgs","repos_url":"https://api.github.com/users/n01d/repos","events_url":"https://api.github.com/users/n01d/events{/privacy}","received_events_url":"https://api.github.com/users/n01d/received_events","type":"User","site_admin":false},"repo":{"id":149270632,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkyNzA2MzI=","name":"Recognizers-Text","full_name":"n01d/Recognizers-Text","private":false,"owner":{"login":"n01d","id":5029466,"node_id":"MDQ6VXNlcjUwMjk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5029466?v=4","gravatar_id":"","url":"https://api.github.com/users/n01d","html_url":"https://github.com/n01d","followers_url":"https://api.github.com/users/n01d/followers","following_url":"https://api.github.com/users/n01d/following{/other_user}","gists_url":"https://api.github.com/users/n01d/gists{/gist_id}","starred_url":"https://api.github.com/users/n01d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01d/subscriptions","organizations_url":"https://api.github.com/users/n01d/orgs","repos_url":"https://api.github.com/users/n01d/repos","events_url":"https://api.github.com/users/n01d/events{/privacy}","received_events_url":"https://api.github.com/users/n01d/received_events","type":"User","site_admin":false},"html_url":"https://github.com/n01d/Recognizers-Text","description":"Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, and date/time expressed in multiple languages (CN, EN, FR, ES, and PT. Partial support for DE, JA, KO, NL). Contributions are greatly welcome! Packages are available at https://www.nuget.org/profiles/Recognizers.Text and https://www.npmjs.com/~recognizers.text","fork":true,"url":"https://api.github.com/repos/n01d/Recognizers-Text","forks_url":"https://api.github.com/repos/n01d/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/n01d/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n01d/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n01d/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/n01d/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/n01d/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/n01d/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/n01d/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/n01d/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/n01d/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/n01d/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n01d/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n01d/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/n01d/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n01d/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/n01d/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/n01d/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/n01d/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/n01d/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/n01d/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/n01d/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/n01d/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/n01d/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/n01d/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/n01d/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/n01d/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n01d/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/n01d/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n01d/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/n01d/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/n01d/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/n01d/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/n01d/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n01d/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/n01d/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/n01d/Recognizers-Text/deployments","created_at":"2018-09-18T10:31:59Z","updated_at":"2018-12-19T15:34:19Z","pushed_at":"2018-12-27T19:51:31Z","git_url":"git://github.com/n01d/Recognizers-Text.git","ssh_url":"git@github.com:n01d/Recognizers-Text.git","clone_url":"https://github.com/n01d/Recognizers-Text.git","svn_url":"https://github.com/n01d/Recognizers-Text","homepage":"","size":18095,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"6086827231d8080187a76df0f1caf63b70d60b41","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":88544417,"node_id":"MDEwOlJlcG9zaXRvcnk4ODU0NDQxNw==","name":"Recognizers-Text","full_name":"Microsoft/Recognizers-Text","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/Recognizers-Text","description":"Microsoft.Recognizers.Text provides recognition and resolution of numbers, units, and date/time expressed in multiple languages (CN, EN, FR, ES, and PT. Partial support for DE, JA, KO, NL). Contributions are greatly welcome! Packages are available at https://www.nuget.org/profiles/Recognizers.Text and https://www.npmjs.com/~recognizers.text","fork":false,"url":"https://api.github.com/repos/Microsoft/Recognizers-Text","forks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/forks","keys_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/teams","hooks_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/events","assignees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/tags","blobs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/languages","stargazers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/subscription","commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/merges","archive_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/downloads","issues_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/Recognizers-Text/deployments","created_at":"2017-04-17T19:45:47Z","updated_at":"2019-01-03T05:20:49Z","pushed_at":"2019-01-03T14:01:38Z","git_url":"git://github.com/Microsoft/Recognizers-Text.git","ssh_url":"git@github.com:Microsoft/Recognizers-Text.git","clone_url":"https://github.com/Microsoft/Recognizers-Text.git","svn_url":"https://github.com/Microsoft/Recognizers-Text","homepage":"","size":18270,"stargazers_count":300,"watchers_count":300,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":156,"open_issues":74,"watchers":300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084"},"html":{"href":"https://github.com/Microsoft/Recognizers-Text/pull/1084"},"issue":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/1084"},"comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/Recognizers-Text/statuses/c2181a5267f6784b1fd8a876f3ed9b35e9aea4db"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"n01d"}}