{"action":"created","comment":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/222618677","pull_request_review_id":161547676,"id":222618677,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjYxODY3Nw==","diff_hunk":"@@ -120,6 +120,37 @@ describe('Public API', function () {\n             });\n     });\n \n+    it('browse posts with author filter', function (done) {","path":"core/test/functional/routes/api/public_api_spec.js","position":83,"original_position":4,"commit_id":"752671ff92f00a282c043d2afd86136ffc6c022c","original_commit_id":"37b859a5b960e96e207e63b31b328669614ee158","user":{"login":"gargol","id":675397,"node_id":"MDQ6VXNlcjY3NTM5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/675397?v=4","gravatar_id":"","url":"https://api.github.com/users/gargol","html_url":"https://github.com/gargol","followers_url":"https://api.github.com/users/gargol/followers","following_url":"https://api.github.com/users/gargol/following{/other_user}","gists_url":"https://api.github.com/users/gargol/gists{/gist_id}","starred_url":"https://api.github.com/users/gargol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gargol/subscriptions","organizations_url":"https://api.github.com/users/gargol/orgs","repos_url":"https://api.github.com/users/gargol/repos","events_url":"https://api.github.com/users/gargol/events{/privacy}","received_events_url":"https://api.github.com/users/gargol/received_events","type":"User","site_admin":false},"body":"sure :+1: ","created_at":"2018-10-04T10:41:21Z","updated_at":"2018-10-04T10:41:21Z","html_url":"https://github.com/TryGhost/Ghost/pull/9940#discussion_r222618677","pull_request_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments/222618677"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9940#discussion_r222618677"},"pull_request":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940"}},"in_reply_to_id":222615075},"pull_request":{"url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940","id":219981728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTgxNzI4","html_url":"https://github.com/TryGhost/Ghost/pull/9940","diff_url":"https://github.com/TryGhost/Ghost/pull/9940.diff","patch_url":"https://github.com/TryGhost/Ghost/pull/9940.patch","issue_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9940","number":9940,"state":"open","locked":false,"title":"[WIP] Remove API integration tests","user":{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"body":"**Please no review!!!**\r\n\r\nReasons:\r\n- integration tests are slow\r\n- they are a mix of unit and routing tests\r\n- we want to reduce the tests for api versioning\r\n- we decided to keep API routing tests per api version\r\n- and the rest should be unit test covered \r\n\r\nGoals:\r\n- do not move every integration test to routing or unit (!!!!)\r\n- if you reconsider an integration test:\r\n  - look at what it does\r\n  - check if it's already covered\r\n  - look at the assertions and check if it's already covered\r\n\r\n___\r\n\r\nI added one example. This example is intense:\r\n- we want to ensure the SQL queries are correct for complex filtering\r\n- **but we only want to do that once or twice, no need to do that for all cases** (just for some to ensure we don't break anything)\r\n- i've looked for it's purpose (public api test) and double checked the exisiting assertions\r\n\r\nI assume 80% of the integration tests can be just removed, and the rest should be covered in unit or routing test. \r\n\r\nTBC","created_at":"2018-10-03T10:10:08Z","updated_at":"2018-10-04T10:41:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6612a0c194f0cdeda5ff265bbc4a61c5bca2e1c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940/commits","review_comments_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940/comments","review_comment_url":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/issues/9940/comments","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/752671ff92f00a282c043d2afd86136ffc6c022c","head":{"label":"kirrg001:remove-integration-tests","ref":"remove-integration-tests","sha":"752671ff92f00a282c043d2afd86136ffc6c022c","user":{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"repo":{"id":55587930,"node_id":"MDEwOlJlcG9zaXRvcnk1NTU4NzkzMA==","name":"Ghost","full_name":"kirrg001/Ghost","private":false,"owner":{"login":"kirrg001","id":1160712,"node_id":"MDQ6VXNlcjExNjA3MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1160712?v=4","gravatar_id":"","url":"https://api.github.com/users/kirrg001","html_url":"https://github.com/kirrg001","followers_url":"https://api.github.com/users/kirrg001/followers","following_url":"https://api.github.com/users/kirrg001/following{/other_user}","gists_url":"https://api.github.com/users/kirrg001/gists{/gist_id}","starred_url":"https://api.github.com/users/kirrg001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirrg001/subscriptions","organizations_url":"https://api.github.com/users/kirrg001/orgs","repos_url":"https://api.github.com/users/kirrg001/repos","events_url":"https://api.github.com/users/kirrg001/events{/privacy}","received_events_url":"https://api.github.com/users/kirrg001/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kirrg001/Ghost","description":"Just a blogging platform","fork":true,"url":"https://api.github.com/repos/kirrg001/Ghost","forks_url":"https://api.github.com/repos/kirrg001/Ghost/forks","keys_url":"https://api.github.com/repos/kirrg001/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirrg001/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirrg001/Ghost/teams","hooks_url":"https://api.github.com/repos/kirrg001/Ghost/hooks","issue_events_url":"https://api.github.com/repos/kirrg001/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/kirrg001/Ghost/events","assignees_url":"https://api.github.com/repos/kirrg001/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/kirrg001/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/kirrg001/Ghost/tags","blobs_url":"https://api.github.com/repos/kirrg001/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirrg001/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirrg001/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirrg001/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirrg001/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/kirrg001/Ghost/languages","stargazers_url":"https://api.github.com/repos/kirrg001/Ghost/stargazers","contributors_url":"https://api.github.com/repos/kirrg001/Ghost/contributors","subscribers_url":"https://api.github.com/repos/kirrg001/Ghost/subscribers","subscription_url":"https://api.github.com/repos/kirrg001/Ghost/subscription","commits_url":"https://api.github.com/repos/kirrg001/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirrg001/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirrg001/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirrg001/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirrg001/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/kirrg001/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirrg001/Ghost/merges","archive_url":"https://api.github.com/repos/kirrg001/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirrg001/Ghost/downloads","issues_url":"https://api.github.com/repos/kirrg001/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/kirrg001/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/kirrg001/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/kirrg001/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirrg001/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/kirrg001/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/kirrg001/Ghost/deployments","created_at":"2016-04-06T08:16:39Z","updated_at":"2018-06-23T07:36:36Z","pushed_at":"2018-10-04T10:01:30Z","git_url":"git://github.com/kirrg001/Ghost.git","ssh_url":"git@github.com:kirrg001/Ghost.git","clone_url":"https://github.com/kirrg001/Ghost.git","svn_url":"https://github.com/kirrg001/Ghost","homepage":"https://ghost.org","size":30157,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"TryGhost:master","ref":"master","sha":"15da580016c16c04319c678dd987b3c78b25209a","user":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"repo":{"id":9852918,"node_id":"MDEwOlJlcG9zaXRvcnk5ODUyOTE4","name":"Ghost","full_name":"TryGhost/Ghost","private":false,"owner":{"login":"TryGhost","id":2178663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNzg2NjM=","avatar_url":"https://avatars3.githubusercontent.com/u/2178663?v=4","gravatar_id":"","url":"https://api.github.com/users/TryGhost","html_url":"https://github.com/TryGhost","followers_url":"https://api.github.com/users/TryGhost/followers","following_url":"https://api.github.com/users/TryGhost/following{/other_user}","gists_url":"https://api.github.com/users/TryGhost/gists{/gist_id}","starred_url":"https://api.github.com/users/TryGhost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TryGhost/subscriptions","organizations_url":"https://api.github.com/users/TryGhost/orgs","repos_url":"https://api.github.com/users/TryGhost/repos","events_url":"https://api.github.com/users/TryGhost/events{/privacy}","received_events_url":"https://api.github.com/users/TryGhost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TryGhost/Ghost","description":"The platform for professional publishers","fork":false,"url":"https://api.github.com/repos/TryGhost/Ghost","forks_url":"https://api.github.com/repos/TryGhost/Ghost/forks","keys_url":"https://api.github.com/repos/TryGhost/Ghost/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TryGhost/Ghost/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TryGhost/Ghost/teams","hooks_url":"https://api.github.com/repos/TryGhost/Ghost/hooks","issue_events_url":"https://api.github.com/repos/TryGhost/Ghost/issues/events{/number}","events_url":"https://api.github.com/repos/TryGhost/Ghost/events","assignees_url":"https://api.github.com/repos/TryGhost/Ghost/assignees{/user}","branches_url":"https://api.github.com/repos/TryGhost/Ghost/branches{/branch}","tags_url":"https://api.github.com/repos/TryGhost/Ghost/tags","blobs_url":"https://api.github.com/repos/TryGhost/Ghost/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TryGhost/Ghost/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TryGhost/Ghost/git/refs{/sha}","trees_url":"https://api.github.com/repos/TryGhost/Ghost/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TryGhost/Ghost/statuses/{sha}","languages_url":"https://api.github.com/repos/TryGhost/Ghost/languages","stargazers_url":"https://api.github.com/repos/TryGhost/Ghost/stargazers","contributors_url":"https://api.github.com/repos/TryGhost/Ghost/contributors","subscribers_url":"https://api.github.com/repos/TryGhost/Ghost/subscribers","subscription_url":"https://api.github.com/repos/TryGhost/Ghost/subscription","commits_url":"https://api.github.com/repos/TryGhost/Ghost/commits{/sha}","git_commits_url":"https://api.github.com/repos/TryGhost/Ghost/git/commits{/sha}","comments_url":"https://api.github.com/repos/TryGhost/Ghost/comments{/number}","issue_comment_url":"https://api.github.com/repos/TryGhost/Ghost/issues/comments{/number}","contents_url":"https://api.github.com/repos/TryGhost/Ghost/contents/{+path}","compare_url":"https://api.github.com/repos/TryGhost/Ghost/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TryGhost/Ghost/merges","archive_url":"https://api.github.com/repos/TryGhost/Ghost/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TryGhost/Ghost/downloads","issues_url":"https://api.github.com/repos/TryGhost/Ghost/issues{/number}","pulls_url":"https://api.github.com/repos/TryGhost/Ghost/pulls{/number}","milestones_url":"https://api.github.com/repos/TryGhost/Ghost/milestones{/number}","notifications_url":"https://api.github.com/repos/TryGhost/Ghost/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TryGhost/Ghost/labels{/name}","releases_url":"https://api.github.com/repos/TryGhost/Ghost/releases{/id}","deployments_url":"https://api.github.com/repos/TryGhost/Ghost/deployments","created_at":"2013-05-04T11:09:13Z","updated_at":"2018-10-04T07:19:55Z","pushed_at":"2018-10-04T10:37:06Z","git_url":"git://github.com/TryGhost/Ghost.git","ssh_url":"git@github.com:TryGhost/Ghost.git","clone_url":"https://github.com/TryGhost/Ghost.git","svn_url":"https://github.com/TryGhost/Ghost","homepage":"https://ghost.org","size":33409,"stargazers_count":27512,"watchers_count":27512,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5917,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5917,"open_issues":144,"watchers":27512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940"},"html":{"href":"https://github.com/TryGhost/Ghost/pull/9940"},"issue":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9940"},"comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/issues/9940/comments"},"review_comments":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940/comments"},"review_comment":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TryGhost/Ghost/pulls/9940/commits"},"statuses":{"href":"https://api.github.com/repos/TryGhost/Ghost/statuses/752671ff92f00a282c043d2afd86136ffc6c022c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gargol"}}