{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1327","repository_url":"https://api.github.com/repos/kubeflow/kubeflow","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1327/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1327/comments","events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1327/events","html_url":"https://github.com/kubeflow/kubeflow/pull/1327","id":348471076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODE0MDY1","number":1327,"title":"Fix iap-ingress certificate creation and use BackendConfig for IAP","user":{"login":"danisla","id":323725,"node_id":"MDQ6VXNlcjMyMzcyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/323725?v=4","gravatar_id":"","url":"https://api.github.com/users/danisla","html_url":"https://github.com/danisla","followers_url":"https://api.github.com/users/danisla/followers","following_url":"https://api.github.com/users/danisla/following{/other_user}","gists_url":"https://api.github.com/users/danisla/gists{/gist_id}","starred_url":"https://api.github.com/users/danisla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danisla/subscriptions","organizations_url":"https://api.github.com/users/danisla/orgs","repos_url":"https://api.github.com/users/danisla/repos","events_url":"https://api.github.com/users/danisla/events{/privacy}","received_events_url":"https://api.github.com/users/danisla/received_events","type":"User","site_admin":false},"labels":[{"id":1016516455,"node_id":"MDU6TGFiZWwxMDE2NTE2NDU1","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":796399084,"node_id":"MDU6TGFiZWw3OTYzOTkwODQ=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"jlewi","id":777219,"node_id":"MDQ6VXNlcjc3NzIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jlewi","id":777219,"node_id":"MDQ6VXNlcjc3NzIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},{"login":"kunmingg","id":37601826,"node_id":"MDQ6VXNlcjM3NjAxODI2","avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":13,"created_at":"2018-08-07T20:16:06Z","updated_at":"2018-08-16T21:33:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1327","html_url":"https://github.com/kubeflow/kubeflow/pull/1327","diff_url":"https://github.com/kubeflow/kubeflow/pull/1327.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/1327.patch"},"body":"- Added k8s job for patching ingress with the TLS spec after the certificate is acquired.\r\n- Refactored IAP enabler to use BackendConfig to enable IAP. Script still has to set timeout and health check. BackendConfig is only available on GKE __1.10.5__.\r\n- Updated cert-manager to v0.4.0 which no longer depends on container for ingress-shim. \r\n\r\nFix #1146 Use BackendConfig to enable IAP\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/1327)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments/413691488","html_url":"https://github.com/kubeflow/kubeflow/pull/1327#issuecomment-413691488","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1327","id":413691488,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzY5MTQ4OA==","user":{"login":"richardsliu","id":39319471,"node_id":"MDQ6VXNlcjM5MzE5NDcx","avatar_url":"https://avatars1.githubusercontent.com/u/39319471?v=4","gravatar_id":"","url":"https://api.github.com/users/richardsliu","html_url":"https://github.com/richardsliu","followers_url":"https://api.github.com/users/richardsliu/followers","following_url":"https://api.github.com/users/richardsliu/following{/other_user}","gists_url":"https://api.github.com/users/richardsliu/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsliu/subscriptions","organizations_url":"https://api.github.com/users/richardsliu/orgs","repos_url":"https://api.github.com/users/richardsliu/repos","events_url":"https://api.github.com/users/richardsliu/events{/privacy}","received_events_url":"https://api.github.com/users/richardsliu/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T21:33:05Z","updated_at":"2018-08-16T21:33:05Z","author_association":"CONTRIBUTOR","body":"/retest"}}
{"actor":{"display_login":"richardsliu"}}