{"action":"closed","number":124,"pull_request":{"url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/124","id":202776076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzc2MDc2","html_url":"https://github.com/neutrinolabs/xorgxrdp/pull/124","diff_url":"https://github.com/neutrinolabs/xorgxrdp/pull/124.diff","patch_url":"https://github.com/neutrinolabs/xorgxrdp/pull/124.patch","issue_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues/124","number":124,"state":"closed","locked":false,"title":"Fix invalid memory access in rdpmouseControl()","user":{"login":"matt335672","id":30179339,"node_id":"MDQ6VXNlcjMwMTc5MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/30179339?v=4","gravatar_id":"","url":"https://api.github.com/users/matt335672","html_url":"https://github.com/matt335672","followers_url":"https://api.github.com/users/matt335672/followers","following_url":"https://api.github.com/users/matt335672/following{/other_user}","gists_url":"https://api.github.com/users/matt335672/gists{/gist_id}","starred_url":"https://api.github.com/users/matt335672/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt335672/subscriptions","organizations_url":"https://api.github.com/users/matt335672/orgs","repos_url":"https://api.github.com/users/matt335672/repos","events_url":"https://api.github.com/users/matt335672/events{/privacy}","received_events_url":"https://api.github.com/users/matt335672/received_events","type":"User","site_admin":false},"body":"This is one of a couple of pull requests to address the memory issues found in #104 by @keithrob91.\r\n\r\nThis is the simpler of the two and corresponds to the last paragraph of the issue raised.\r\n\r\nThe second argument of the call to InitPointerDeviceStruct() is an array based at 1, rather than 0. This can be seen in other projects. See for example vncPointerProc() from TigerVNC's [unix/xserver/hw/vnc/Input.c](https://github.com/TigerVNC/tigervnc/blob/master/unix/xserver/hw/vnc/Input.c). The Xorg code on the other end is in [xserver/dix/devices.c](https://cgit.freedesktop.org/xorg/xserver/tree/dix/devices.c)","created_at":"2018-07-20T08:10:46Z","updated_at":"2018-07-22T03:19:40Z","closed_at":"2018-07-22T03:19:40Z","merged_at":"2018-07-22T03:19:40Z","merge_commit_sha":"7bd3f7275e1539a2298da864376bc57177a80a85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/124/commits","review_comments_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/124/comments","review_comment_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues/124/comments","statuses_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/statuses/cad9094a9c071fe9634570fb44118c13e8a7376a","head":{"label":"matt335672:rdp-mouse-invalid-mem-rw","ref":"rdp-mouse-invalid-mem-rw","sha":"cad9094a9c071fe9634570fb44118c13e8a7376a","user":{"login":"matt335672","id":30179339,"node_id":"MDQ6VXNlcjMwMTc5MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/30179339?v=4","gravatar_id":"","url":"https://api.github.com/users/matt335672","html_url":"https://github.com/matt335672","followers_url":"https://api.github.com/users/matt335672/followers","following_url":"https://api.github.com/users/matt335672/following{/other_user}","gists_url":"https://api.github.com/users/matt335672/gists{/gist_id}","starred_url":"https://api.github.com/users/matt335672/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt335672/subscriptions","organizations_url":"https://api.github.com/users/matt335672/orgs","repos_url":"https://api.github.com/users/matt335672/repos","events_url":"https://api.github.com/users/matt335672/events{/privacy}","received_events_url":"https://api.github.com/users/matt335672/received_events","type":"User","site_admin":false},"repo":{"id":116028349,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYwMjgzNDk=","name":"xorgxrdp","full_name":"matt335672/xorgxrdp","owner":{"login":"matt335672","id":30179339,"node_id":"MDQ6VXNlcjMwMTc5MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/30179339?v=4","gravatar_id":"","url":"https://api.github.com/users/matt335672","html_url":"https://github.com/matt335672","followers_url":"https://api.github.com/users/matt335672/followers","following_url":"https://api.github.com/users/matt335672/following{/other_user}","gists_url":"https://api.github.com/users/matt335672/gists{/gist_id}","starred_url":"https://api.github.com/users/matt335672/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt335672/subscriptions","organizations_url":"https://api.github.com/users/matt335672/orgs","repos_url":"https://api.github.com/users/matt335672/repos","events_url":"https://api.github.com/users/matt335672/events{/privacy}","received_events_url":"https://api.github.com/users/matt335672/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matt335672/xorgxrdp","description":"Xorg drivers for xrdp","fork":true,"url":"https://api.github.com/repos/matt335672/xorgxrdp","forks_url":"https://api.github.com/repos/matt335672/xorgxrdp/forks","keys_url":"https://api.github.com/repos/matt335672/xorgxrdp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matt335672/xorgxrdp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matt335672/xorgxrdp/teams","hooks_url":"https://api.github.com/repos/matt335672/xorgxrdp/hooks","issue_events_url":"https://api.github.com/repos/matt335672/xorgxrdp/issues/events{/number}","events_url":"https://api.github.com/repos/matt335672/xorgxrdp/events","assignees_url":"https://api.github.com/repos/matt335672/xorgxrdp/assignees{/user}","branches_url":"https://api.github.com/repos/matt335672/xorgxrdp/branches{/branch}","tags_url":"https://api.github.com/repos/matt335672/xorgxrdp/tags","blobs_url":"https://api.github.com/repos/matt335672/xorgxrdp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matt335672/xorgxrdp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matt335672/xorgxrdp/git/refs{/sha}","trees_url":"https://api.github.com/repos/matt335672/xorgxrdp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matt335672/xorgxrdp/statuses/{sha}","languages_url":"https://api.github.com/repos/matt335672/xorgxrdp/languages","stargazers_url":"https://api.github.com/repos/matt335672/xorgxrdp/stargazers","contributors_url":"https://api.github.com/repos/matt335672/xorgxrdp/contributors","subscribers_url":"https://api.github.com/repos/matt335672/xorgxrdp/subscribers","subscription_url":"https://api.github.com/repos/matt335672/xorgxrdp/subscription","commits_url":"https://api.github.com/repos/matt335672/xorgxrdp/commits{/sha}","git_commits_url":"https://api.github.com/repos/matt335672/xorgxrdp/git/commits{/sha}","comments_url":"https://api.github.com/repos/matt335672/xorgxrdp/comments{/number}","issue_comment_url":"https://api.github.com/repos/matt335672/xorgxrdp/issues/comments{/number}","contents_url":"https://api.github.com/repos/matt335672/xorgxrdp/contents/{+path}","compare_url":"https://api.github.com/repos/matt335672/xorgxrdp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matt335672/xorgxrdp/merges","archive_url":"https://api.github.com/repos/matt335672/xorgxrdp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matt335672/xorgxrdp/downloads","issues_url":"https://api.github.com/repos/matt335672/xorgxrdp/issues{/number}","pulls_url":"https://api.github.com/repos/matt335672/xorgxrdp/pulls{/number}","milestones_url":"https://api.github.com/repos/matt335672/xorgxrdp/milestones{/number}","notifications_url":"https://api.github.com/repos/matt335672/xorgxrdp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matt335672/xorgxrdp/labels{/name}","releases_url":"https://api.github.com/repos/matt335672/xorgxrdp/releases{/id}","deployments_url":"https://api.github.com/repos/matt335672/xorgxrdp/deployments","created_at":"2018-01-02T15:17:54Z","updated_at":"2018-07-18T14:20:08Z","pushed_at":"2018-07-21T14:06:15Z","git_url":"git://github.com/matt335672/xorgxrdp.git","ssh_url":"git@github.com:matt335672/xorgxrdp.git","clone_url":"https://github.com/matt335672/xorgxrdp.git","svn_url":"https://github.com/matt335672/xorgxrdp","homepage":null,"size":439,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"neutrinolabs:devel","ref":"devel","sha":"c3ea569821096eaf28a8c04a80b3a2e836b065fd","user":{"login":"neutrinolabs","id":2615587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MTU1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2615587?v=4","gravatar_id":"","url":"https://api.github.com/users/neutrinolabs","html_url":"https://github.com/neutrinolabs","followers_url":"https://api.github.com/users/neutrinolabs/followers","following_url":"https://api.github.com/users/neutrinolabs/following{/other_user}","gists_url":"https://api.github.com/users/neutrinolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/neutrinolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neutrinolabs/subscriptions","organizations_url":"https://api.github.com/users/neutrinolabs/orgs","repos_url":"https://api.github.com/users/neutrinolabs/repos","events_url":"https://api.github.com/users/neutrinolabs/events{/privacy}","received_events_url":"https://api.github.com/users/neutrinolabs/received_events","type":"Organization","site_admin":false},"repo":{"id":24623762,"node_id":"MDEwOlJlcG9zaXRvcnkyNDYyMzc2Mg==","name":"xorgxrdp","full_name":"neutrinolabs/xorgxrdp","owner":{"login":"neutrinolabs","id":2615587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MTU1ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2615587?v=4","gravatar_id":"","url":"https://api.github.com/users/neutrinolabs","html_url":"https://github.com/neutrinolabs","followers_url":"https://api.github.com/users/neutrinolabs/followers","following_url":"https://api.github.com/users/neutrinolabs/following{/other_user}","gists_url":"https://api.github.com/users/neutrinolabs/gists{/gist_id}","starred_url":"https://api.github.com/users/neutrinolabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neutrinolabs/subscriptions","organizations_url":"https://api.github.com/users/neutrinolabs/orgs","repos_url":"https://api.github.com/users/neutrinolabs/repos","events_url":"https://api.github.com/users/neutrinolabs/events{/privacy}","received_events_url":"https://api.github.com/users/neutrinolabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neutrinolabs/xorgxrdp","description":"Xorg drivers for xrdp","fork":false,"url":"https://api.github.com/repos/neutrinolabs/xorgxrdp","forks_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/forks","keys_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/teams","hooks_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/hooks","issue_events_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues/events{/number}","events_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/events","assignees_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/assignees{/user}","branches_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/branches{/branch}","tags_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/tags","blobs_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/git/refs{/sha}","trees_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/statuses/{sha}","languages_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/languages","stargazers_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/stargazers","contributors_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/contributors","subscribers_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/subscribers","subscription_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/subscription","commits_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/commits{/sha}","git_commits_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/git/commits{/sha}","comments_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/comments{/number}","issue_comment_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues/comments{/number}","contents_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/contents/{+path}","compare_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/merges","archive_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/downloads","issues_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues{/number}","pulls_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls{/number}","milestones_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/milestones{/number}","notifications_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/labels{/name}","releases_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/releases{/id}","deployments_url":"https://api.github.com/repos/neutrinolabs/xorgxrdp/deployments","created_at":"2014-09-30T03:55:45Z","updated_at":"2018-07-16T10:58:19Z","pushed_at":"2018-07-22T03:19:40Z","git_url":"git://github.com/neutrinolabs/xorgxrdp.git","ssh_url":"git@github.com:neutrinolabs/xorgxrdp.git","clone_url":"https://github.com/neutrinolabs/xorgxrdp.git","svn_url":"https://github.com/neutrinolabs/xorgxrdp","homepage":null,"size":437,"stargazers_count":66,"watchers_count":66,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":13,"watchers":66,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/124"},"html":{"href":"https://github.com/neutrinolabs/xorgxrdp/pull/124"},"issue":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues/124"},"comments":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/issues/124/comments"},"review_comments":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/124/comments"},"review_comment":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/pulls/124/commits"},"statuses":{"href":"https://api.github.com/repos/neutrinolabs/xorgxrdp/statuses/cad9094a9c071fe9634570fb44118c13e8a7376a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"metalefty","id":941609,"node_id":"MDQ6VXNlcjk0MTYwOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/941609?v=4","gravatar_id":"","url":"https://api.github.com/users/metalefty","html_url":"https://github.com/metalefty","followers_url":"https://api.github.com/users/metalefty/followers","following_url":"https://api.github.com/users/metalefty/following{/other_user}","gists_url":"https://api.github.com/users/metalefty/gists{/gist_id}","starred_url":"https://api.github.com/users/metalefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metalefty/subscriptions","organizations_url":"https://api.github.com/users/metalefty/orgs","repos_url":"https://api.github.com/users/metalefty/repos","events_url":"https://api.github.com/users/metalefty/events{/privacy}","received_events_url":"https://api.github.com/users/metalefty/received_events","type":"User","site_admin":false},"comments":3,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"metalefty"}}