{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/179632275","pull_request_review_id":109915168,"id":179632275,"diff_hunk":"@@ -313,11 +305,10 @@\n           \"name\": \"nicLoopNode\"\n         },\n         \"dependsOn\": [\n-  {{if .MasterProfile.IsCustomVNET}}","path":"parts/k8s/kubernetesmasterresources.t","position":49,"original_position":49,"commit_id":"f52a43c5a5a6cad89109c419992e525d48e16163","original_commit_id":"f52a43c5a5a6cad89109c419992e525d48e16163","user":{"login":"jackfrancis","id":1494193,"avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"body":"Before: if custom VNET depend on nsgID in master NIC / else depend on vnetID in master NIC\r\n\r\nAfter: if custom VNET depend on nsgID in master NIC / else depend on vnetID + nsgID in master NIC","created_at":"2018-04-06T00:04:32Z","updated_at":"2018-04-06T00:04:32Z","html_url":"https://github.com/Azure/acs-engine/pull/2604#discussion_r179632275","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2604","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/179632275"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2604#discussion_r179632275"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2604"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/2604","id":179786523,"html_url":"https://github.com/Azure/acs-engine/pull/2604","diff_url":"https://github.com/Azure/acs-engine/pull/2604.diff","patch_url":"https://github.com/Azure/acs-engine/pull/2604.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/2604","number":2604,"state":"open","locked":false,"title":"attach NSGs to nics, not to the subnet","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"This PR attaches the NSG to the nics, not to the subnet, in k8s deployments.  This is a precursor to being able to attach different NSGs to different VMs where required.","created_at":"2018-04-05T20:24:05Z","updated_at":"2018-04-06T00:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba716029fdd65f1fb7c75bba655dcec44b3570d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2604/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/2604/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/2604/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/f52a43c5a5a6cad89109c419992e525d48e16163","head":{"label":"jim-minter:nsgs_on_nics","ref":"nsgs_on_nics","sha":"f52a43c5a5a6cad89109c419992e525d48e16163","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"repo":{"id":123941851,"name":"acs-engine","full_name":"jim-minter/acs-engine","owner":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jim-minter/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":true,"url":"https://api.github.com/repos/jim-minter/acs-engine","forks_url":"https://api.github.com/repos/jim-minter/acs-engine/forks","keys_url":"https://api.github.com/repos/jim-minter/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jim-minter/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jim-minter/acs-engine/teams","hooks_url":"https://api.github.com/repos/jim-minter/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/jim-minter/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/jim-minter/acs-engine/events","assignees_url":"https://api.github.com/repos/jim-minter/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/jim-minter/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/jim-minter/acs-engine/tags","blobs_url":"https://api.github.com/repos/jim-minter/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jim-minter/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jim-minter/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/jim-minter/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jim-minter/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/jim-minter/acs-engine/languages","stargazers_url":"https://api.github.com/repos/jim-minter/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/jim-minter/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/jim-minter/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/jim-minter/acs-engine/subscription","commits_url":"https://api.github.com/repos/jim-minter/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/jim-minter/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/jim-minter/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/jim-minter/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/jim-minter/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/jim-minter/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jim-minter/acs-engine/merges","archive_url":"https://api.github.com/repos/jim-minter/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jim-minter/acs-engine/downloads","issues_url":"https://api.github.com/repos/jim-minter/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/jim-minter/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/jim-minter/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/jim-minter/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jim-minter/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/jim-minter/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/jim-minter/acs-engine/deployments","created_at":"2018-03-05T15:46:58Z","updated_at":"2018-03-05T15:47:02Z","pushed_at":"2018-04-05T20:22:40Z","git_url":"git://github.com/jim-minter/acs-engine.git","ssh_url":"git@github.com:jim-minter/acs-engine.git","clone_url":"https://github.com/jim-minter/acs-engine.git","svn_url":"https://github.com/jim-minter/acs-engine","homepage":"","size":65886,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"63ff4e79ddba3f51f567e36321609e191901898c","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - a place for community to collaborate and build the best open Docker container infrastructure for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-04-05T21:18:14Z","pushed_at":"2018-04-05T23:52:59Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":75542,"stargazers_count":721,"watchers_count":721,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":464,"mirror_url":null,"archived":false,"open_issues_count":428,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":464,"open_issues":428,"watchers":721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2604"},"html":{"href":"https://github.com/Azure/acs-engine/pull/2604"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2604"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/2604/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2604/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/2604/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/f52a43c5a5a6cad89109c419992e525d48e16163"}},"author_association":"NONE"}}
{"actor":{"display_login":"jackfrancis"}}