{"action":"created","comment":{"url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/comments/204143395","pull_request_review_id":139178642,"id":204143395,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDE0MzM5NQ==","diff_hunk":"@@ -176,6 +176,15 @@ def test_varread_pr355():\n     assert differ([expected_path, actual_path])\n \n \n+def test_cff2_no_vf_bug353():\n+    # read CFF2 WITHOUT VF info, write a CFF2 out. 'regular_CFF2.otf'\n+    # is derived by taking the regular.otf file from the sfntdiff\n+    # 'input_data' directory, and converting the CFF table to CFF2.","path":"Tests/tx_test.py","position":7,"original_position":7,"commit_id":"bc2270a76741fe06f55a3447a74c01f7a250045a","original_commit_id":"bc2270a76741fe06f55a3447a74c01f7a250045a","user":{"login":"miguelsousa","id":2119742,"node_id":"MDQ6VXNlcjIxMTk3NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/2119742?v=4","gravatar_id":"","url":"https://api.github.com/users/miguelsousa","html_url":"https://github.com/miguelsousa","followers_url":"https://api.github.com/users/miguelsousa/followers","following_url":"https://api.github.com/users/miguelsousa/following{/other_user}","gists_url":"https://api.github.com/users/miguelsousa/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelsousa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelsousa/subscriptions","organizations_url":"https://api.github.com/users/miguelsousa/orgs","repos_url":"https://api.github.com/users/miguelsousa/repos","events_url":"https://api.github.com/users/miguelsousa/events{/privacy}","received_events_url":"https://api.github.com/users/miguelsousa/received_events","type":"User","site_admin":false},"body":"How was the conversion from CFF to CFF2 step done? I'm mostly curious.","created_at":"2018-07-20T19:11:43Z","updated_at":"2018-07-20T19:11:43Z","html_url":"https://github.com/adobe-type-tools/afdko/pull/504#discussion_r204143395","pull_request_url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/comments/204143395"},"html":{"href":"https://github.com/adobe-type-tools/afdko/pull/504#discussion_r204143395"},"pull_request":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504","id":202908430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTA4NDMw","html_url":"https://github.com/adobe-type-tools/afdko/pull/504","diff_url":"https://github.com/adobe-type-tools/afdko/pull/504.diff","patch_url":"https://github.com/adobe-type-tools/afdko/pull/504.patch","issue_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/504","number":504,"state":"open","locked":false,"title":"[tx] tx fails when converting a non-VF FF2 OTF font to cff2. Adding test.","user":{"login":"readroberts","id":2856984,"node_id":"MDQ6VXNlcjI4NTY5ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2856984?v=4","gravatar_id":"","url":"https://api.github.com/users/readroberts","html_url":"https://github.com/readroberts","followers_url":"https://api.github.com/users/readroberts/followers","following_url":"https://api.github.com/users/readroberts/following{/other_user}","gists_url":"https://api.github.com/users/readroberts/gists{/gist_id}","starred_url":"https://api.github.com/users/readroberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/readroberts/subscriptions","organizations_url":"https://api.github.com/users/readroberts/orgs","repos_url":"https://api.github.com/users/readroberts/repos","events_url":"https://api.github.com/users/readroberts/events{/privacy}","received_events_url":"https://api.github.com/users/readroberts/received_events","type":"User","site_admin":false},"body":"Add test for issue 353: tx fails when converting a non-VF FF2 OTF font to cff2.","created_at":"2018-07-20T17:16:49Z","updated_at":"2018-07-20T19:11:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"400e7f2cef4f2ca5e06290c57e474f4b63520dd0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504/commits","review_comments_url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504/comments","review_comment_url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/504/comments","statuses_url":"https://api.github.com/repos/adobe-type-tools/afdko/statuses/bc2270a76741fe06f55a3447a74c01f7a250045a","head":{"label":"adobe-type-tools:updated-tests-issue353","ref":"updated-tests-issue353","sha":"bc2270a76741fe06f55a3447a74c01f7a250045a","user":{"login":"adobe-type-tools","id":2768660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Njg2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768660?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe-type-tools","html_url":"https://github.com/adobe-type-tools","followers_url":"https://api.github.com/users/adobe-type-tools/followers","following_url":"https://api.github.com/users/adobe-type-tools/following{/other_user}","gists_url":"https://api.github.com/users/adobe-type-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-type-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-type-tools/subscriptions","organizations_url":"https://api.github.com/users/adobe-type-tools/orgs","repos_url":"https://api.github.com/users/adobe-type-tools/repos","events_url":"https://api.github.com/users/adobe-type-tools/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-type-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":24213271,"node_id":"MDEwOlJlcG9zaXRvcnkyNDIxMzI3MQ==","name":"afdko","full_name":"adobe-type-tools/afdko","owner":{"login":"adobe-type-tools","id":2768660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Njg2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768660?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe-type-tools","html_url":"https://github.com/adobe-type-tools","followers_url":"https://api.github.com/users/adobe-type-tools/followers","following_url":"https://api.github.com/users/adobe-type-tools/following{/other_user}","gists_url":"https://api.github.com/users/adobe-type-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-type-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-type-tools/subscriptions","organizations_url":"https://api.github.com/users/adobe-type-tools/orgs","repos_url":"https://api.github.com/users/adobe-type-tools/repos","events_url":"https://api.github.com/users/adobe-type-tools/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-type-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-type-tools/afdko","description":"Adobe Font Development Kit for OpenType","fork":false,"url":"https://api.github.com/repos/adobe-type-tools/afdko","forks_url":"https://api.github.com/repos/adobe-type-tools/afdko/forks","keys_url":"https://api.github.com/repos/adobe-type-tools/afdko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-type-tools/afdko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-type-tools/afdko/teams","hooks_url":"https://api.github.com/repos/adobe-type-tools/afdko/hooks","issue_events_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-type-tools/afdko/events","assignees_url":"https://api.github.com/repos/adobe-type-tools/afdko/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-type-tools/afdko/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-type-tools/afdko/tags","blobs_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-type-tools/afdko/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-type-tools/afdko/languages","stargazers_url":"https://api.github.com/repos/adobe-type-tools/afdko/stargazers","contributors_url":"https://api.github.com/repos/adobe-type-tools/afdko/contributors","subscribers_url":"https://api.github.com/repos/adobe-type-tools/afdko/subscribers","subscription_url":"https://api.github.com/repos/adobe-type-tools/afdko/subscription","commits_url":"https://api.github.com/repos/adobe-type-tools/afdko/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-type-tools/afdko/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-type-tools/afdko/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-type-tools/afdko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-type-tools/afdko/merges","archive_url":"https://api.github.com/repos/adobe-type-tools/afdko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-type-tools/afdko/downloads","issues_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-type-tools/afdko/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-type-tools/afdko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-type-tools/afdko/labels{/name}","releases_url":"https://api.github.com/repos/adobe-type-tools/afdko/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-type-tools/afdko/deployments","created_at":"2014-09-19T02:26:06Z","updated_at":"2018-07-20T19:01:35Z","pushed_at":"2018-07-20T19:01:40Z","git_url":"git://github.com/adobe-type-tools/afdko.git","ssh_url":"git@github.com:adobe-type-tools/afdko.git","clone_url":"https://github.com/adobe-type-tools/afdko.git","svn_url":"https://github.com/adobe-type-tools/afdko","homepage":"","size":15717,"stargazers_count":237,"watchers_count":237,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":87,"watchers":237,"default_branch":"develop"}},"base":{"label":"adobe-type-tools:develop","ref":"develop","sha":"0a47e4adecb12b8f730ec688c6afb71bca7cd812","user":{"login":"adobe-type-tools","id":2768660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Njg2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768660?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe-type-tools","html_url":"https://github.com/adobe-type-tools","followers_url":"https://api.github.com/users/adobe-type-tools/followers","following_url":"https://api.github.com/users/adobe-type-tools/following{/other_user}","gists_url":"https://api.github.com/users/adobe-type-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-type-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-type-tools/subscriptions","organizations_url":"https://api.github.com/users/adobe-type-tools/orgs","repos_url":"https://api.github.com/users/adobe-type-tools/repos","events_url":"https://api.github.com/users/adobe-type-tools/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-type-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":24213271,"node_id":"MDEwOlJlcG9zaXRvcnkyNDIxMzI3MQ==","name":"afdko","full_name":"adobe-type-tools/afdko","owner":{"login":"adobe-type-tools","id":2768660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3Njg2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/2768660?v=4","gravatar_id":"","url":"https://api.github.com/users/adobe-type-tools","html_url":"https://github.com/adobe-type-tools","followers_url":"https://api.github.com/users/adobe-type-tools/followers","following_url":"https://api.github.com/users/adobe-type-tools/following{/other_user}","gists_url":"https://api.github.com/users/adobe-type-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/adobe-type-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adobe-type-tools/subscriptions","organizations_url":"https://api.github.com/users/adobe-type-tools/orgs","repos_url":"https://api.github.com/users/adobe-type-tools/repos","events_url":"https://api.github.com/users/adobe-type-tools/events{/privacy}","received_events_url":"https://api.github.com/users/adobe-type-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adobe-type-tools/afdko","description":"Adobe Font Development Kit for OpenType","fork":false,"url":"https://api.github.com/repos/adobe-type-tools/afdko","forks_url":"https://api.github.com/repos/adobe-type-tools/afdko/forks","keys_url":"https://api.github.com/repos/adobe-type-tools/afdko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adobe-type-tools/afdko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adobe-type-tools/afdko/teams","hooks_url":"https://api.github.com/repos/adobe-type-tools/afdko/hooks","issue_events_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/events{/number}","events_url":"https://api.github.com/repos/adobe-type-tools/afdko/events","assignees_url":"https://api.github.com/repos/adobe-type-tools/afdko/assignees{/user}","branches_url":"https://api.github.com/repos/adobe-type-tools/afdko/branches{/branch}","tags_url":"https://api.github.com/repos/adobe-type-tools/afdko/tags","blobs_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/refs{/sha}","trees_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adobe-type-tools/afdko/statuses/{sha}","languages_url":"https://api.github.com/repos/adobe-type-tools/afdko/languages","stargazers_url":"https://api.github.com/repos/adobe-type-tools/afdko/stargazers","contributors_url":"https://api.github.com/repos/adobe-type-tools/afdko/contributors","subscribers_url":"https://api.github.com/repos/adobe-type-tools/afdko/subscribers","subscription_url":"https://api.github.com/repos/adobe-type-tools/afdko/subscription","commits_url":"https://api.github.com/repos/adobe-type-tools/afdko/commits{/sha}","git_commits_url":"https://api.github.com/repos/adobe-type-tools/afdko/git/commits{/sha}","comments_url":"https://api.github.com/repos/adobe-type-tools/afdko/comments{/number}","issue_comment_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues/comments{/number}","contents_url":"https://api.github.com/repos/adobe-type-tools/afdko/contents/{+path}","compare_url":"https://api.github.com/repos/adobe-type-tools/afdko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adobe-type-tools/afdko/merges","archive_url":"https://api.github.com/repos/adobe-type-tools/afdko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adobe-type-tools/afdko/downloads","issues_url":"https://api.github.com/repos/adobe-type-tools/afdko/issues{/number}","pulls_url":"https://api.github.com/repos/adobe-type-tools/afdko/pulls{/number}","milestones_url":"https://api.github.com/repos/adobe-type-tools/afdko/milestones{/number}","notifications_url":"https://api.github.com/repos/adobe-type-tools/afdko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adobe-type-tools/afdko/labels{/name}","releases_url":"https://api.github.com/repos/adobe-type-tools/afdko/releases{/id}","deployments_url":"https://api.github.com/repos/adobe-type-tools/afdko/deployments","created_at":"2014-09-19T02:26:06Z","updated_at":"2018-07-20T19:01:35Z","pushed_at":"2018-07-20T19:01:40Z","git_url":"git://github.com/adobe-type-tools/afdko.git","ssh_url":"git@github.com:adobe-type-tools/afdko.git","clone_url":"https://github.com/adobe-type-tools/afdko.git","svn_url":"https://github.com/adobe-type-tools/afdko","homepage":"","size":15717,"stargazers_count":237,"watchers_count":237,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":87,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":87,"watchers":237,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504"},"html":{"href":"https://github.com/adobe-type-tools/afdko/pull/504"},"issue":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/issues/504"},"comments":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/adobe-type-tools/afdko/statuses/bc2270a76741fe06f55a3447a74c01f7a250045a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"miguelsousa"}}