{"action":"created","comment":{"url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/comments/181830329","pull_request_review_id":112522294,"id":181830329,"diff_hunk":"@@ -47,27 +47,55 @@ Default: `local.net/nfs`\n \n Default: `local-nfs`\n \n-### `hostPath`\n+### `provisionerVolume`\n \n-If this is empty, no local storage will be used, making this completely emphemeral.\n+There are a number of modes you can use. These are the available options.","path":"README.md","position":8,"original_position":8,"commit_id":"364417af11a281315b96650b94c125f20efee881","original_commit_id":"364417af11a281315b96650b94c125f20efee881","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"body":"I wanted to make this a bit more declarative. In the previous implementation, there were certain configurations that we're super-obvious to me. For instance, if hostPath was not set, it used emptyDir. Or, setting useTmpFs while defining other variables made the setting do nothing. \r\n\r\nBy using one \"mode\" value, it makes it very obvious which mode you're using.","created_at":"2018-04-16T17:51:32Z","updated_at":"2018-04-16T17:52:09Z","html_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart/pull/5#discussion_r181830329","pull_request_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/comments/181830329"},"html":{"href":"https://github.com/IlyaSemenov/nfs-provisioner-chart/pull/5#discussion_r181830329"},"pull_request":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5","id":181941035,"html_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart/pull/5","diff_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart/pull/5.diff","patch_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart/pull/5.patch","issue_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues/5","number":5,"state":"open","locked":false,"title":"Allow Configuring a PVC for the provisioner","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"body":"I needed this functionality and have tested it out on my cluster.\r\n\r\nI'd like to unlock this functionality for others.\r\n\r\nPlease note that this would represent a breaking change for the chart. I'm curious to hear your thoughts on a breaking change. I'm new to writing helm charts, so there might be a way to support backwards compatibility here if we think it's really important. Feedback welcome!","created_at":"2018-04-16T17:49:35Z","updated_at":"2018-04-16T17:52:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"027a0d8f137854ae062b10fcb16dd0d8552373ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5/commits","review_comments_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5/comments","review_comment_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues/5/comments","statuses_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/statuses/364417af11a281315b96650b94c125f20efee881","head":{"label":"blimmer:feature/pvc-options","ref":"feature/pvc-options","sha":"364417af11a281315b96650b94c125f20efee881","user":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"repo":{"id":129768495,"name":"nfs-provisioner-chart","full_name":"blimmer/nfs-provisioner-chart","owner":{"login":"blimmer","id":630449,"avatar_url":"https://avatars1.githubusercontent.com/u/630449?v=4","gravatar_id":"","url":"https://api.github.com/users/blimmer","html_url":"https://github.com/blimmer","followers_url":"https://api.github.com/users/blimmer/followers","following_url":"https://api.github.com/users/blimmer/following{/other_user}","gists_url":"https://api.github.com/users/blimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/blimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blimmer/subscriptions","organizations_url":"https://api.github.com/users/blimmer/orgs","repos_url":"https://api.github.com/users/blimmer/repos","events_url":"https://api.github.com/users/blimmer/events{/privacy}","received_events_url":"https://api.github.com/users/blimmer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blimmer/nfs-provisioner-chart","description":"Helm chart for NFS provisioner","fork":true,"url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart","forks_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/forks","keys_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/teams","hooks_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/hooks","issue_events_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/issues/events{/number}","events_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/events","assignees_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/assignees{/user}","branches_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/branches{/branch}","tags_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/tags","blobs_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/languages","stargazers_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/stargazers","contributors_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/contributors","subscribers_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/subscribers","subscription_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/subscription","commits_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/contents/{+path}","compare_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/merges","archive_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/downloads","issues_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/issues{/number}","pulls_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/labels{/name}","releases_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/releases{/id}","deployments_url":"https://api.github.com/repos/blimmer/nfs-provisioner-chart/deployments","created_at":"2018-04-16T15:50:27Z","updated_at":"2018-04-16T15:50:29Z","pushed_at":"2018-04-16T17:48:01Z","git_url":"git://github.com/blimmer/nfs-provisioner-chart.git","ssh_url":"git@github.com:blimmer/nfs-provisioner-chart.git","clone_url":"https://github.com/blimmer/nfs-provisioner-chart.git","svn_url":"https://github.com/blimmer/nfs-provisioner-chart","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IlyaSemenov:master","ref":"master","sha":"66412c983dd5e367f7051134e818a1755fa30a3b","user":{"login":"IlyaSemenov","id":128121,"avatar_url":"https://avatars1.githubusercontent.com/u/128121?v=4","gravatar_id":"","url":"https://api.github.com/users/IlyaSemenov","html_url":"https://github.com/IlyaSemenov","followers_url":"https://api.github.com/users/IlyaSemenov/followers","following_url":"https://api.github.com/users/IlyaSemenov/following{/other_user}","gists_url":"https://api.github.com/users/IlyaSemenov/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaSemenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaSemenov/subscriptions","organizations_url":"https://api.github.com/users/IlyaSemenov/orgs","repos_url":"https://api.github.com/users/IlyaSemenov/repos","events_url":"https://api.github.com/users/IlyaSemenov/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaSemenov/received_events","type":"User","site_admin":false},"repo":{"id":105753568,"name":"nfs-provisioner-chart","full_name":"IlyaSemenov/nfs-provisioner-chart","owner":{"login":"IlyaSemenov","id":128121,"avatar_url":"https://avatars1.githubusercontent.com/u/128121?v=4","gravatar_id":"","url":"https://api.github.com/users/IlyaSemenov","html_url":"https://github.com/IlyaSemenov","followers_url":"https://api.github.com/users/IlyaSemenov/followers","following_url":"https://api.github.com/users/IlyaSemenov/following{/other_user}","gists_url":"https://api.github.com/users/IlyaSemenov/gists{/gist_id}","starred_url":"https://api.github.com/users/IlyaSemenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IlyaSemenov/subscriptions","organizations_url":"https://api.github.com/users/IlyaSemenov/orgs","repos_url":"https://api.github.com/users/IlyaSemenov/repos","events_url":"https://api.github.com/users/IlyaSemenov/events{/privacy}","received_events_url":"https://api.github.com/users/IlyaSemenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart","description":"Helm chart for NFS provisioner","fork":false,"url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart","forks_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/forks","keys_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/teams","hooks_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/hooks","issue_events_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues/events{/number}","events_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/events","assignees_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/assignees{/user}","branches_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/branches{/branch}","tags_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/tags","blobs_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/languages","stargazers_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/stargazers","contributors_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/contributors","subscribers_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/subscribers","subscription_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/subscription","commits_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/contents/{+path}","compare_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/merges","archive_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/downloads","issues_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues{/number}","pulls_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/labels{/name}","releases_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/releases{/id}","deployments_url":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/deployments","created_at":"2017-10-04T09:54:31Z","updated_at":"2018-04-11T08:22:55Z","pushed_at":"2018-04-16T17:49:36Z","git_url":"git://github.com/IlyaSemenov/nfs-provisioner-chart.git","ssh_url":"git@github.com:IlyaSemenov/nfs-provisioner-chart.git","clone_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart.git","svn_url":"https://github.com/IlyaSemenov/nfs-provisioner-chart","homepage":null,"size":17,"stargazers_count":7,"watchers_count":7,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5"},"html":{"href":"https://github.com/IlyaSemenov/nfs-provisioner-chart/pull/5"},"issue":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues/5"},"comments":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/IlyaSemenov/nfs-provisioner-chart/statuses/364417af11a281315b96650b94c125f20efee881"}},"author_association":"NONE"}}
{"actor":{"display_login":"blimmer"}}