{"action":"created","issue":{"url":"https://api.github.com/repos/nodkz/react-relay-network-layer/issues/58","repository_url":"https://api.github.com/repos/nodkz/react-relay-network-layer","labels_url":"https://api.github.com/repos/nodkz/react-relay-network-layer/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/nodkz/react-relay-network-layer/issues/58/comments","events_url":"https://api.github.com/repos/nodkz/react-relay-network-layer/issues/58/events","html_url":"https://github.com/nodkz/react-relay-network-layer/issues/58","id":321934203,"number":58,"title":"Retry middleware not retrying","user":{"login":"danny-larsen","id":9655724,"avatar_url":"https://avatars3.githubusercontent.com/u/9655724?v=4","gravatar_id":"","url":"https://api.github.com/users/danny-larsen","html_url":"https://github.com/danny-larsen","followers_url":"https://api.github.com/users/danny-larsen/followers","following_url":"https://api.github.com/users/danny-larsen/following{/other_user}","gists_url":"https://api.github.com/users/danny-larsen/gists{/gist_id}","starred_url":"https://api.github.com/users/danny-larsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danny-larsen/subscriptions","organizations_url":"https://api.github.com/users/danny-larsen/orgs","repos_url":"https://api.github.com/users/danny-larsen/repos","events_url":"https://api.github.com/users/danny-larsen/events{/privacy}","received_events_url":"https://api.github.com/users/danny-larsen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-05-10T13:37:37Z","updated_at":"2018-05-22T10:22:35Z","closed_at":null,"author_association":"NONE","body":"I cannot get the retry middleware working.\r\n\r\nI am trying to get it to retry on fetch failures, but that does not seem to work. Is it only working for requests that actually return a status code?\r\n\r\n**EDIT**\r\nSo after poking around in the code I see that it is only retrying for timeout errors. Is there a reason for that?\r\n\r\n\r\nif (err === timeoutError) {\r\n            var retryDelayMS = retryAfterMs(attempt);\r\n            if (retryDelayMS) {\r\n              logger('response timeout, retrying after ' + retryDelayMS + ' ms');\r\n              return sendTimedRequest(timeout, retryDelayMS);\r\n            }\r\n          }\r\n"},"comment":{"url":"https://api.github.com/repos/nodkz/react-relay-network-layer/issues/comments/390940706","html_url":"https://github.com/nodkz/react-relay-network-layer/issues/58#issuecomment-390940706","issue_url":"https://api.github.com/repos/nodkz/react-relay-network-layer/issues/58","id":390940706,"user":{"login":"nodkz","id":1946920,"avatar_url":"https://avatars2.githubusercontent.com/u/1946920?v=4","gravatar_id":"","url":"https://api.github.com/users/nodkz","html_url":"https://github.com/nodkz","followers_url":"https://api.github.com/users/nodkz/followers","following_url":"https://api.github.com/users/nodkz/following{/other_user}","gists_url":"https://api.github.com/users/nodkz/gists{/gist_id}","starred_url":"https://api.github.com/users/nodkz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodkz/subscriptions","organizations_url":"https://api.github.com/users/nodkz/orgs","repos_url":"https://api.github.com/users/nodkz/repos","events_url":"https://api.github.com/users/nodkz/events{/privacy}","received_events_url":"https://api.github.com/users/nodkz/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T10:22:35Z","updated_at":"2018-05-22T10:22:35Z","author_association":"OWNER","body":"Errors may be different eg 403, 404 and we should them pass to other middlewares.\r\nSo you need to catch that error exactly `Failed to fetch` and add it to line 71 via `or` operator."}}
{"actor":{"display_login":"nodkz"}}