{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/208773121","pull_request_review_id":144652627,"id":208773121,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc3MzEyMQ==","diff_hunk":"@@ -53,7 +53,15 @@ EventPipeEventInstance::EventPipeEventInstance(\n \n     m_pData = pData;\n     m_dataLength = length;\n-    QueryPerformanceCounter(&m_timeStamp);\n+\n+    // Declare the timeStamp as a local and require that it be 4-byte aligned.\n+    // If the timeStamp is not 4-byte aligned, QueryPerformanceCounter will return E_NOACCESS on some versions of Windows.\n+    // This codepath is more susceptible to having an unaligned m_timeStamp because EventPipeEventInstance\n+    // is initialized via placement-new into the EventPipe circular buffer.\n+    DECLSPEC_ALIGN(4) LARGE_INTEGER timeStamp;","path":"src/vm/eventpipeeventinstance.cpp","position":10,"original_position":10,"commit_id":"dc61038ac543c1fdbbd2282066703f2231918fa4","original_commit_id":"dc61038ac543c1fdbbd2282066703f2231918fa4","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"You do not need ` DECLSPEC_ALIGN` here. The compiler will guarantee sufficient alignment by default. (And that alignment is 8 on some platforms.)","created_at":"2018-08-09T00:08:33Z","updated_at":"2018-08-09T00:08:34Z","html_url":"https://github.com/dotnet/coreclr/pull/19372#discussion_r208773121","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19372","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/208773121"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19372#discussion_r208773121"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19372"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/19372","id":207168485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTY4NDg1","html_url":"https://github.com/dotnet/coreclr/pull/19372","diff_url":"https://github.com/dotnet/coreclr/pull/19372.diff","patch_url":"https://github.com/dotnet/coreclr/pull/19372.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/19372","number":19372,"state":"open","locked":false,"title":"Fix EventPipe failures due to unaligned argument to QueryPerformanceCounter","user":{"login":"brianrob","id":6210322,"node_id":"MDQ6VXNlcjYyMTAzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"body":"Some of the EventPipe tests are failing on our official runs because calls to ```QueryPerformanceCounter``` are failing.  This occurs when the argument passed to ```QueryPerformanceCounter``` is not 4-byte aligned, which is fairly common for the timeStamp field, which is part of an object that is initialized via placement-new into the EventPipe circular buffer.\r\n\r\nThe fix is to create a stack-allocated timeStamp field whose alignment is guaranteed to be 4-bytes.\r\n\r\nI am investigating separately whether this needs to be fixed more consistently across the codebase.\r\n\r\nFixes #19268.","created_at":"2018-08-08T23:54:54Z","updated_at":"2018-08-09T00:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cea737d2cff91b12223dfb686bdd7d30418b746a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19372/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/19372/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/19372/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/dc61038ac543c1fdbbd2282066703f2231918fa4","head":{"label":"brianrob:queryperformancecounter_alignment","ref":"queryperformancecounter_alignment","sha":"dc61038ac543c1fdbbd2282066703f2231918fa4","user":{"login":"brianrob","id":6210322,"node_id":"MDQ6VXNlcjYyMTAzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"repo":{"id":30316731,"node_id":"MDEwOlJlcG9zaXRvcnkzMDMxNjczMQ==","name":"coreclr","full_name":"brianrob/coreclr","owner":{"login":"brianrob","id":6210322,"node_id":"MDQ6VXNlcjYyMTAzMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6210322?v=4","gravatar_id":"","url":"https://api.github.com/users/brianrob","html_url":"https://github.com/brianrob","followers_url":"https://api.github.com/users/brianrob/followers","following_url":"https://api.github.com/users/brianrob/following{/other_user}","gists_url":"https://api.github.com/users/brianrob/gists{/gist_id}","starred_url":"https://api.github.com/users/brianrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianrob/subscriptions","organizations_url":"https://api.github.com/users/brianrob/orgs","repos_url":"https://api.github.com/users/brianrob/repos","events_url":"https://api.github.com/users/brianrob/events{/privacy}","received_events_url":"https://api.github.com/users/brianrob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianrob/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/brianrob/coreclr","forks_url":"https://api.github.com/repos/brianrob/coreclr/forks","keys_url":"https://api.github.com/repos/brianrob/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianrob/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianrob/coreclr/teams","hooks_url":"https://api.github.com/repos/brianrob/coreclr/hooks","issue_events_url":"https://api.github.com/repos/brianrob/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/brianrob/coreclr/events","assignees_url":"https://api.github.com/repos/brianrob/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/brianrob/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/brianrob/coreclr/tags","blobs_url":"https://api.github.com/repos/brianrob/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianrob/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianrob/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianrob/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianrob/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/brianrob/coreclr/languages","stargazers_url":"https://api.github.com/repos/brianrob/coreclr/stargazers","contributors_url":"https://api.github.com/repos/brianrob/coreclr/contributors","subscribers_url":"https://api.github.com/repos/brianrob/coreclr/subscribers","subscription_url":"https://api.github.com/repos/brianrob/coreclr/subscription","commits_url":"https://api.github.com/repos/brianrob/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianrob/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianrob/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianrob/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianrob/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/brianrob/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianrob/coreclr/merges","archive_url":"https://api.github.com/repos/brianrob/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianrob/coreclr/downloads","issues_url":"https://api.github.com/repos/brianrob/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/brianrob/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/brianrob/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/brianrob/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianrob/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/brianrob/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/brianrob/coreclr/deployments","created_at":"2015-02-04T19:27:15Z","updated_at":"2018-08-06T22:05:35Z","pushed_at":"2018-08-08T23:50:08Z","git_url":"git://github.com/brianrob/coreclr.git","ssh_url":"git@github.com:brianrob/coreclr.git","clone_url":"https://github.com/brianrob/coreclr.git","svn_url":"https://github.com/brianrob/coreclr","homepage":"","size":230925,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"df8e05daed1d45dc5bcec2614667fc3ec0992ce6","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-08-08T22:54:29Z","pushed_at":"2018-08-08T23:54:55Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":233377,"stargazers_count":9691,"watchers_count":9691,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2401,"mirror_url":null,"archived":false,"open_issues_count":1773,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2401,"open_issues":1773,"watchers":9691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19372"},"html":{"href":"https://github.com/dotnet/coreclr/pull/19372"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19372"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/19372/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19372/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/19372/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/dc61038ac543c1fdbbd2282066703f2231918fa4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jkotas"}}