{"action":"created","issue":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1350","repository_url":"https://api.github.com/repos/CorfuDB/CorfuDB","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1350/labels{/name}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1350/comments","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1350/events","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1350","id":338788374,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjMzMDM0","number":1350,"title":"Seal before reset of healing node.","user":{"login":"zalokhan","id":10751367,"node_id":"MDQ6VXNlcjEwNzUxMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"zalokhan","id":10751367,"node_id":"MDQ6VXNlcjEwNzUxMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"assignees":[{"login":"zalokhan","id":10751367,"node_id":"MDQ6VXNlcjEwNzUxMzY3","avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-06T02:56:36Z","updated_at":"2018-07-06T03:29:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1350","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1350","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/1350.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/1350.patch"},"body":"## Overview\r\n\r\nDescription: Reset the logunit node while `HealNodeWorkflow` after we have sealed. Also, make the reset epoch unaware to allow a stale node to recover. The reset epoch is persisted by the node to prevent multiple resets from wiping the data on the same epoch.\r\n\r\nWhy should this be merged: A node with a very old epoch can never heal as it fails on reset with a wrong epoch exception.\r\n\r\nRelated issue(s) (if applicable): #<number>\r\n\r\n\r\n## Checklist (Definition of Done):\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] [Coding conventions](https://github.com/CorfuDB/CorfuDB/wiki/Corfu-Style-Guidelines) (e.g. for logging, unit tests) have been followed\r\n- [x] Change is covered by automated tests\r\n- [x] Public API has Javadoc\r\n"},"comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments/402915054","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1350#issuecomment-402915054","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1350","id":402915054,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjkxNTA1NA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-07-06T03:29:00Z","updated_at":"2018-07-06T03:29:00Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=h1) Report\n> Merging [#1350](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=desc) into [master](https://codecov.io/gh/CorfuDB/CorfuDB/commit/7c7d2e89c2a820f5928e6ea75bde4dd11e26e4bb?src=pr&el=desc) will **increase** coverage by `0.12%`.\n> The diff coverage is `85.71%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/graphs/tree.svg?width=650&height=150&src=pr&token=Wouw9OaGMi)](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1350      +/-   ##\n==========================================\n+ Coverage   68.95%   69.07%   +0.12%     \n==========================================\n  Files         264      264              \n  Lines       11498    11510      +12     \n  Branches     1117     1117              \n==========================================\n+ Hits         7928     7951      +23     \n+ Misses       3119     3110       -9     \n+ Partials      451      449       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...org/corfudb/runtime/view/LayoutManagementView.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3J1bnRpbWUvdmlldy9MYXlvdXRNYW5hZ2VtZW50Vmlldy5qYXZh) | `73.65% <100%> (+2.22%)` | :arrow_up: |\n| [...g/corfudb/infrastructure/BatchWriterOperation.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9CYXRjaFdyaXRlck9wZXJhdGlvbi5qYXZh) | `93.33% <100%> (+0.47%)` | :arrow_up: |\n| [...g/corfudb/protocols/wireprotocol/CorfuMsgType.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3Byb3RvY29scy93aXJlcHJvdG9jb2wvQ29yZnVNc2dUeXBlLmphdmE=) | `91.95% <100%> (ø)` | :arrow_up: |\n| [...ava/org/corfudb/runtime/clients/LogUnitClient.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3J1bnRpbWUvY2xpZW50cy9Mb2dVbml0Q2xpZW50LmphdmE=) | `72.91% <100%> (ø)` | :arrow_up: |\n| [...cture/orchestrator/workflows/HealNodeWorkflow.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9vcmNoZXN0cmF0b3Ivd29ya2Zsb3dzL0hlYWxOb2RlV29ya2Zsb3cuamF2YQ==) | `100% <100%> (+2.85%)` | :arrow_up: |\n| [...java/org/corfudb/infrastructure/ServerContext.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9TZXJ2ZXJDb250ZXh0LmphdmE=) | `89.47% <75%> (-0.32%)` | :arrow_down: |\n| [...n/java/org/corfudb/infrastructure/BatchWriter.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9CYXRjaFdyaXRlci5qYXZh) | `75.45% <80%> (+0.45%)` | :arrow_up: |\n| [...java/org/corfudb/infrastructure/LogUnitServer.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9Mb2dVbml0U2VydmVyLmphdmE=) | `86.15% <80%> (-0.47%)` | :arrow_down: |\n| [...untime/src/main/java/org/corfudb/util/CFUtils.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-cnVudGltZS9zcmMvbWFpbi9qYXZhL29yZy9jb3JmdWRiL3V0aWwvQ0ZVdGlscy5qYXZh) | `75.75% <0%> (-6.07%)` | :arrow_down: |\n| [...udb/infrastructure/management/FailureDetector.java](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree#diff-aW5mcmFzdHJ1Y3R1cmUvc3JjL21haW4vamF2YS9vcmcvY29yZnVkYi9pbmZyYXN0cnVjdHVyZS9tYW5hZ2VtZW50L0ZhaWx1cmVEZXRlY3Rvci5qYXZh) | `90.1% <0%> (-1.1%)` | :arrow_down: |\n| ... and [6 more](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=footer). Last update [7c7d2e8...30631c6](https://codecov.io/gh/CorfuDB/CorfuDB/pull/1350?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}