{"action":"created","issue":{"url":"https://api.github.com/repos/cilium/cilium/issues/2804","repository_url":"https://api.github.com/repos/cilium/cilium","labels_url":"https://api.github.com/repos/cilium/cilium/issues/2804/labels{/name}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/2804/comments","events_url":"https://api.github.com/repos/cilium/cilium/issues/2804/events","html_url":"https://github.com/cilium/cilium/pull/2804","id":296845790,"number":2804,"title":"pkg/policy: remove ReverseRules from Consumable","user":{"login":"ianvernon","id":3858271,"avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"labels":[{"id":746643464,"url":"https://api.github.com/repos/cilium/cilium/labels/area/policy","name":"area/policy","color":"c9f97a","default":false},{"id":403149902,"url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-13T18:48:55Z","updated_at":"2018-02-15T23:55:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/2804","html_url":"https://github.com/cilium/cilium/pull/2804","diff_url":"https://github.com/cilium/cilium/pull/2804.diff","patch_url":"https://github.com/cilium/cilium/pull/2804.patch"},"body":"If connection-tracking was not enabled for an endpoint, in order to ensure that\r\ntraffic between endpoints managed by Cilium would flow, if a policy allowed\r\ningress to endpoint A from endpoint B, then B's policy maps were also updated\r\nto allow ingress to itself from A as well. However, this only worked if both\r\nendpoints were local to the same node, as the sharing of this information is\r\ndone on a per-daemon level; security identities are not resolved on each node\r\nin the cluster. As such, remove ReverseRules, which was used to store such data,\r\nfrom the Consumable structure.\r\n\r\nSigned-off by: Ian Vernon <ian@cilium.io>\r\n\r\nFixes: #2795 \r\n\r\nNote: this is based off of changes that in #2769. I will rebase accordingly when that fix is merged. "},"comment":{"url":"https://api.github.com/repos/cilium/cilium/issues/comments/366102204","html_url":"https://github.com/cilium/cilium/pull/2804#issuecomment-366102204","issue_url":"https://api.github.com/repos/cilium/cilium/issues/2804","id":366102204,"user":{"login":"ianvernon","id":3858271,"avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T23:55:27Z","updated_at":"2018-02-15T23:55:27Z","author_association":"CONTRIBUTOR","body":"@aanm, you were right; this lead me to find out an issue with the corresponding Ginkgo test, which I've fixed here: https://github.com/cilium/cilium/pull/2847 . \r\n\r\n#2847 should block this P, as I will have update the tests accordingly on this PR (#2804) to account for the removal of ReverseRules."}}
{"actor":{"display_login":"ianvernon"}}