{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/234884781","pull_request_review_id":176621108,"id":234884781,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDg4NDc4MQ==","diff_hunk":"@@ -249,7 +249,20 @@ body {\n   float: right;\n }\n \n-\n .field-media-input {\n   margin-right: 220px;\n }\n+\n+// Quickicon specific\n+.message-alert {\n+  text-align: left !important;\n+}\n+\n+// Message specific\n+joomla-alert .joomla-alert--close, joomla-alert .joomla-alert-button--close {","path":"administrator/templates/atum/scss/template-rtl.scss","position":15,"original_position":15,"commit_id":"573f0ac5f65970ccb84ee9ab61c1e4269ac271de","original_commit_id":"573f0ac5f65970ccb84ee9ab61c1e4269ac271de","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"body":"@C-Lodder\r\nThis is an override for RTL.\r\nThe scss for alert is in `/node_modules/joomla-ui-custom-elements/src/scss/alert/alert.scss`\r\n\r\nThere is no provisions done for RTL in custom-elements which means we would have to use `html[dir=rtl] `(which is not a problem I guess).\r\n\r\nAlso it means that until someone merges a possible pull request in https://github.com/joomla-projects/custom-elements/blob/master/dist/css/joomla-alert.css and possibly https://github.com/joomla-projects/custom-elements/blob/master/dist/css/joomla-alert.min.css, this PR would not correct by itself the RTL display issue with alerts.\r\n\r\nThe other solution I see is to add these (with `html[dir=rtl] `), in the `atum/scss/blocks/_alert.scss` and also in Cassiopea equivalent file —which means that every 3rd party template will necessarily have to do that to be rtl compatible.\r\n\r\nJust let me know what is the way to go.\r\ncalling @wilsonge as he has the hand on merging stuff in https://github.com/joomla-projects/custom-elements","created_at":"2018-11-20T06:43:28Z","updated_at":"2018-11-20T06:43:28Z","html_url":"https://github.com/joomla/joomla-cms/pull/23095#discussion_r234884781","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/234884781"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/23095#discussion_r234884781"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095"}},"in_reply_to_id":234793167},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095","id":231489987,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDg5OTg3","html_url":"https://github.com/joomla/joomla-cms/pull/23095","diff_url":"https://github.com/joomla/joomla-cms/pull/23095.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/23095.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23095","number":23095,"state":"open","locked":false,"title":"[4.0] RFC Quickicons Joomla and Extensions updates","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"body":"Replaces and complete https://github.com/joomla/joomla-cms/pull/23061 (for what concerns Joomla Update).\r\n\r\nImplement NOTE in https://github.com/joomla/joomla-cms/pull/23061#issuecomment-438581619\r\n\r\n### Summary of Changes\r\n1. Adding Joomla Version\r\n2. Change icon color to `warning` when an update is available as `danger` is used in case of error.\r\n3. Place the `Update Now` and `View Updates` buttons to the bottom right of the Message, centering the rest of the message.\r\n4. Adapt Atum CSS concerned to RTL, including the `joomla-alert`\r\n5. Correct unnecessary `,` and `:` in the language strings\r\n5. Correct `Text::script` to `false` by default to let single quotes in language strings to display unescaped instead of `\\'`\r\n\r\n### Testing Instructions\r\n_To test on 4.0-dev branch_\r\n\r\n**Concerning joomlaupdate:**\r\nModify version.php line 63 to const EXTRA_VERSION = 'alpha4-dev';\r\nGo to database and Fix database.\r\nThen in JoomlaUpdate Options choose Custom URL and add this link (Thanks Tobias) :\r\nhttps://update.joomla.org/core/nightlies/next_major_list.xml\r\nSave Options.\r\nDisplay Control Panel.\r\n\r\n**Concerning extensions update:**\r\nInstall an older language pack in order to get a warning for an update.\r\n[fr-FR_joomla_lang_full_3.9.0v1.zip](https://github.com/joomla/joomla-cms/files/2570924/fr-FR_joomla_lang_full_3.9.0v1.zip)\r\n\r\nin both cases, test also RTL by installing and switching to Persian language.\r\n\r\nTest before patch, then run npm ci\r\n\r\n\r\n### Expected result\r\n<img width=\"500\" alt=\"screen shot 2018-11-16 at 11 22 24\" src=\"https://user-images.githubusercontent.com/869724/48616602-61338c80-e994-11e8-96f9-185e30713108.png\">\r\n<img width=\"401\" alt=\"screen shot 2018-11-16 at 09 31 19\" src=\"https://user-images.githubusercontent.com/869724/48616603-61338c80-e994-11e8-9127-da4ac265e7b9.png\">\r\n<img width=\"476\" alt=\"screen shot 2018-11-16 at 09 30 00\" src=\"https://user-images.githubusercontent.com/869724/48616604-61cc2300-e994-11e8-9b7e-57b8426de777.png\">\r\n<img width=\"442\" alt=\"screen shot 2018-11-16 at 11 45 28\" src=\"https://user-images.githubusercontent.com/869724/48616889-30a02280-e995-11e8-955f-606a54572336.png\">\r\n\r\n@tuum @wilsonge ","created_at":"2018-11-16T10:52:35Z","updated_at":"2018-11-20T06:43:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eecb67665c4e5fe6b6d352087ddcc623d821eaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":878880830,"node_id":"MDU6TGFiZWw4Nzg4ODA4MzA=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/J4%20Issue","name":"J4 Issue","color":"f4d524","default":false},{"id":198658453,"node_id":"MDU6TGFiZWwxOTg2NTg0NTM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/Language%20Change","name":"Language Change","color":"eb6420","default":false},{"id":444033883,"node_id":"MDU6TGFiZWw0NDQwMzM4ODM=","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-4.0-dev","name":"PR-4.0-dev","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/23095/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/573f0ac5f65970ccb84ee9ab61c1e4269ac271de","head":{"label":"infograf768:4.0-quickicon-all-updates","ref":"4.0-quickicon-all-updates","sha":"573f0ac5f65970ccb84ee9ab61c1e4269ac271de","user":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"repo":{"id":3025712,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI1NzEy","name":"joomla-cms","full_name":"infograf768/joomla-cms","private":false,"owner":{"login":"infograf768","id":869724,"node_id":"MDQ6VXNlcjg2OTcyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/869724?v=4","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"html_url":"https://github.com/infograf768/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/infograf768/joomla-cms","forks_url":"https://api.github.com/repos/infograf768/joomla-cms/forks","keys_url":"https://api.github.com/repos/infograf768/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infograf768/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infograf768/joomla-cms/teams","hooks_url":"https://api.github.com/repos/infograf768/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/infograf768/joomla-cms/events","assignees_url":"https://api.github.com/repos/infograf768/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/infograf768/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/infograf768/joomla-cms/tags","blobs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infograf768/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/infograf768/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infograf768/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/infograf768/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/infograf768/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/infograf768/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/infograf768/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/infograf768/joomla-cms/subscription","commits_url":"https://api.github.com/repos/infograf768/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/infograf768/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/infograf768/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/infograf768/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/infograf768/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infograf768/joomla-cms/merges","archive_url":"https://api.github.com/repos/infograf768/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infograf768/joomla-cms/downloads","issues_url":"https://api.github.com/repos/infograf768/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/infograf768/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/infograf768/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infograf768/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/infograf768/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/infograf768/joomla-cms/deployments","created_at":"2011-12-21T08:55:33Z","updated_at":"2016-02-15T02:03:35Z","pushed_at":"2018-11-19T09:51:32Z","git_url":"git://github.com/infograf768/joomla-cms.git","ssh_url":"git@github.com:infograf768/joomla-cms.git","clone_url":"https://github.com/infograf768/joomla-cms.git","svn_url":"https://github.com/infograf768/joomla-cms","homepage":"http://joomla.org","size":237044,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"joomla:4.0-dev","ref":"4.0-dev","sha":"c98df413958942ce90efcbfd87628586edbf0f03","user":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"node_id":"MDEwOlJlcG9zaXRvcnkyNDY0OTA4","name":"joomla-cms","full_name":"joomla/joomla-cms","private":false,"owner":{"login":"joomla","id":751633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTYzMw==","avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2018-11-19T15:33:26Z","pushed_at":"2018-11-20T00:30:26Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":246556,"stargazers_count":2988,"watchers_count":2988,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2784,"mirror_url":null,"archived":false,"open_issues_count":876,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2784,"open_issues":876,"watchers":2988,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/23095"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/23095"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/23095/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/23095/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/573f0ac5f65970ccb84ee9ab61c1e4269ac271de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"infograf768"}}