{"action":"created","issue":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/14611","repository_url":"https://api.github.com/repos/ionic-team/ionic","labels_url":"https://api.github.com/repos/ionic-team/ionic/issues/14611/labels{/name}","comments_url":"https://api.github.com/repos/ionic-team/ionic/issues/14611/comments","events_url":"https://api.github.com/repos/ionic-team/ionic/issues/14611/events","html_url":"https://github.com/ionic-team/ionic/issues/14611","id":331568254,"node_id":"MDU6SXNzdWUzMzE1NjgyNTQ=","number":14611,"title":"Ionic v4: Tabs - tabbarLayout options are not shown as expected","user":{"login":"FdezRomero","id":1807985,"node_id":"MDQ6VXNlcjE4MDc5ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1807985?v=4","gravatar_id":"","url":"https://api.github.com/users/FdezRomero","html_url":"https://github.com/FdezRomero","followers_url":"https://api.github.com/users/FdezRomero/followers","following_url":"https://api.github.com/users/FdezRomero/following{/other_user}","gists_url":"https://api.github.com/users/FdezRomero/gists{/gist_id}","starred_url":"https://api.github.com/users/FdezRomero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FdezRomero/subscriptions","organizations_url":"https://api.github.com/users/FdezRomero/orgs","repos_url":"https://api.github.com/users/FdezRomero/repos","events_url":"https://api.github.com/users/FdezRomero/events{/privacy}","received_events_url":"https://api.github.com/users/FdezRomero/received_events","type":"User","site_admin":false},"labels":[{"id":81957344,"node_id":"MDU6TGFiZWw4MTk1NzM0NA==","url":"https://api.github.com/repos/ionic-team/ionic/labels/tabs","name":"tabs","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-12T12:35:25Z","updated_at":"2018-08-09T22:31:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n# Bug Report\r\n\r\n**Ionic Info**\r\nRun `ionic info` from a terminal/cmd prompt and paste the output below.\r\n\r\n```\r\ncli packages: (/usr/local/lib/node_modules)\r\n\r\n   @ionic/cli-utils  : 2.0.0-rc.6\r\n   ionic (Ionic CLI) : 4.0.0-rc.6\r\n\r\nlocal packages:\r\n\r\n   @angular-devkit/core       : 0.6.8\r\n   @angular-devkit/schematics : 0.6.8\r\n   @angular/cli               : 6.0.8\r\n   @ionic/schematics-angular  : 1.0.0-rc.6\r\n   Ionic Framework            : @ionic/angular 4.0.0-alpha.7\r\n\r\nSystem:\r\n\r\n   NodeJS : v8.11.1\r\n   npm    : 6.1.0\r\n   OS     : macOS High Sierra\r\n```\r\n\r\n**Describe the Bug**\r\nWhen using `<ion-tabs tabbarLayout=\"icon-start\">`, the tab button icons are still shown on top of the labels:\r\n\r\n**icon-start**:\r\n![image](https://user-images.githubusercontent.com/1807985/41290445-2a64279a-6e4d-11e8-8056-feaf51134c8c.png)\r\n\r\nOther options like `icon-end`, `icon-bottom`, `icon-hide` and `title-hide` also have layout problems.\r\n\r\n**title-hide**:\r\n![image](https://user-images.githubusercontent.com/1807985/41290795-35fd3cd0-6e4e-11e8-84ca-3d686d2d5d01.png)\r\n\r\n**Steps to Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Create a `@ionic/angular@4.0.0-alpha.7` project with the CLI, select the **tabs** starter: `ionic start tabs-layout tabs --type angular`\r\n2. Open `src/app/pages/tabs/tabs.page.html`\r\n3. Add `tabbarLayout=\"icon-start\"` to the `<ion-tabs>`\r\n4. Run in the browser with `npm run start`\r\n\r\n**Related Code**\r\n```html\r\n<ion-tabs tabbarLayout=\"icon-start\">\r\n  <ion-tab label=\"Home\" icon=\"home\" href=\"/tabs/(home:home)\">\r\n    <ion-router-outlet name=\"home\"></ion-router-outlet>\r\n  </ion-tab>\r\n  <ion-tab label=\"About\" icon=\"information-circle\" href=\"/tabs/(about:about)\">\r\n    <ion-router-outlet name=\"about\"></ion-router-outlet>\r\n  </ion-tab>\r\n  <ion-tab label=\"Contact\" icon=\"contacts\" href=\"/tabs/(contact:contact)\">\r\n    <ion-router-outlet name=\"contact\"></ion-router-outlet>\r\n  </ion-tab>\r\n</ion-tabs>\r\n```\r\n\r\n**Expected Behavior**\r\nTab button icons should be placed at the side of their labels. Other layout options should be positioned correctly.\r\n\r\n**Additional Context**\r\nList any other information that is relevant to your issue. Stack traces, related issues, suggestions on how to fix, Stack Overflow links, forum links, screenshots, OS if applicable, etc.\r\n"},"comment":{"url":"https://api.github.com/repos/ionic-team/ionic/issues/comments/411918811","html_url":"https://github.com/ionic-team/ionic/issues/14611#issuecomment-411918811","issue_url":"https://api.github.com/repos/ionic-team/ionic/issues/14611","id":411918811,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTkxODgxMQ==","user":{"login":"brandyscarney","id":6577830,"node_id":"MDQ6VXNlcjY1Nzc4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6577830?v=4","gravatar_id":"","url":"https://api.github.com/users/brandyscarney","html_url":"https://github.com/brandyscarney","followers_url":"https://api.github.com/users/brandyscarney/followers","following_url":"https://api.github.com/users/brandyscarney/following{/other_user}","gists_url":"https://api.github.com/users/brandyscarney/gists{/gist_id}","starred_url":"https://api.github.com/users/brandyscarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandyscarney/subscriptions","organizations_url":"https://api.github.com/users/brandyscarney/orgs","repos_url":"https://api.github.com/users/brandyscarney/repos","events_url":"https://api.github.com/users/brandyscarney/events{/privacy}","received_events_url":"https://api.github.com/users/brandyscarney/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T22:31:25Z","updated_at":"2018-08-09T22:31:25Z","author_association":"MEMBER","body":"@Mobiletainment I haven't gotten back to finishing it yet. I submitted a PR for it so you can see where it's at: https://github.com/ionic-team/ionic/pull/15113\r\n\r\nI have fixed the layout itself but there are still some issues with padding and margin between elements. "}}
{"actor":{"display_login":"brandyscarney"}}