{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/entangled/pulls/comments/212317442","pull_request_review_id":148921376,"id":212317442,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjMxNzQ0Mg==","diff_hunk":"@@ -30,6 +30,23 @@ iota_api_result_t iota_api_get_node_info(\n iota_api_result_t iota_api_get_neighbors(\n     const iota_http_service_t* const service, get_neighbors_res_t* const res) {\n   iota_api_result_t result = {0};\n+\n+  char_buffer_t* req_buff = char_buffer_new();\n+  char_buffer_t* res_buff = char_buffer_new();\n+\n+  result.error = service->serializer.vtable.get_neighbors_serialize_request(\n+      &service->serializer, req_buff);\n+  if (result.error != RC_OK) goto done;","path":"cclient/iota_api.c","position":10,"original_position":10,"commit_id":"108ba6d52da319069112f985515d2ff0aaa156b4","original_commit_id":"108ba6d52da319069112f985515d2ff0aaa156b4","user":{"login":"thibault-martinez","id":3305068,"node_id":"MDQ6VXNlcjMzMDUwNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3305068?v=4","gravatar_id":"","url":"https://api.github.com/users/thibault-martinez","html_url":"https://github.com/thibault-martinez","followers_url":"https://api.github.com/users/thibault-martinez/followers","following_url":"https://api.github.com/users/thibault-martinez/following{/other_user}","gists_url":"https://api.github.com/users/thibault-martinez/gists{/gist_id}","starred_url":"https://api.github.com/users/thibault-martinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thibault-martinez/subscriptions","organizations_url":"https://api.github.com/users/thibault-martinez/orgs","repos_url":"https://api.github.com/users/thibault-martinez/repos","events_url":"https://api.github.com/users/thibault-martinez/events{/privacy}","received_events_url":"https://api.github.com/users/thibault-martinez/received_events","type":"User","site_admin":false},"body":"It's more readable, less error-prone, and it match the codebase style","created_at":"2018-08-23T13:53:31Z","updated_at":"2018-08-23T13:53:31Z","html_url":"https://github.com/iotaledger/entangled/pull/188#discussion_r212317442","pull_request_url":"https://api.github.com/repos/iotaledger/entangled/pulls/188","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/comments/212317442"},"html":{"href":"https://github.com/iotaledger/entangled/pull/188#discussion_r212317442"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/188"}},"in_reply_to_id":212269320},"pull_request":{"url":"https://api.github.com/repos/iotaledger/entangled/pulls/188","id":210409280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDA5Mjgw","html_url":"https://github.com/iotaledger/entangled/pull/188","diff_url":"https://github.com/iotaledger/entangled/pull/188.diff","patch_url":"https://github.com/iotaledger/entangled/pull/188.patch","issue_url":"https://api.github.com/repos/iotaledger/entangled/issues/188","number":188,"state":"open","locked":false,"title":"cclient: implement iota_api_get_neighbors","user":{"login":"oopsmonk","id":462383,"node_id":"MDQ6VXNlcjQ2MjM4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/462383?v=4","gravatar_id":"","url":"https://api.github.com/users/oopsmonk","html_url":"https://github.com/oopsmonk","followers_url":"https://api.github.com/users/oopsmonk/followers","following_url":"https://api.github.com/users/oopsmonk/following{/other_user}","gists_url":"https://api.github.com/users/oopsmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/oopsmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oopsmonk/subscriptions","organizations_url":"https://api.github.com/users/oopsmonk/orgs","repos_url":"https://api.github.com/users/oopsmonk/repos","events_url":"https://api.github.com/users/oopsmonk/events{/privacy}","received_events_url":"https://api.github.com/users/oopsmonk/received_events","type":"User","site_admin":false},"body":"This PR implements iota_api_get_neighbors.\r\n\r\n# Test Plan:\r\nCI must pass","created_at":"2018-08-23T10:59:26Z","updated_at":"2018-08-23T13:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4be435b5e48c17a513cc0e61d564a9fbcfbc4788","assignee":null,"assignees":[],"requested_reviewers":[{"login":"th0br0","id":30996,"node_id":"MDQ6VXNlcjMwOTk2","avatar_url":"https://avatars0.githubusercontent.com/u/30996?v=4","gravatar_id":"","url":"https://api.github.com/users/th0br0","html_url":"https://github.com/th0br0","followers_url":"https://api.github.com/users/th0br0/followers","following_url":"https://api.github.com/users/th0br0/following{/other_user}","gists_url":"https://api.github.com/users/th0br0/gists{/gist_id}","starred_url":"https://api.github.com/users/th0br0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/th0br0/subscriptions","organizations_url":"https://api.github.com/users/th0br0/orgs","repos_url":"https://api.github.com/users/th0br0/repos","events_url":"https://api.github.com/users/th0br0/events{/privacy}","received_events_url":"https://api.github.com/users/th0br0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/entangled/pulls/188/commits","review_comments_url":"https://api.github.com/repos/iotaledger/entangled/pulls/188/comments","review_comment_url":"https://api.github.com/repos/iotaledger/entangled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/entangled/issues/188/comments","statuses_url":"https://api.github.com/repos/iotaledger/entangled/statuses/108ba6d52da319069112f985515d2ff0aaa156b4","head":{"label":"oopsmonk:cclient_api_getNeighbors","ref":"cclient_api_getNeighbors","sha":"108ba6d52da319069112f985515d2ff0aaa156b4","user":{"login":"oopsmonk","id":462383,"node_id":"MDQ6VXNlcjQ2MjM4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/462383?v=4","gravatar_id":"","url":"https://api.github.com/users/oopsmonk","html_url":"https://github.com/oopsmonk","followers_url":"https://api.github.com/users/oopsmonk/followers","following_url":"https://api.github.com/users/oopsmonk/following{/other_user}","gists_url":"https://api.github.com/users/oopsmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/oopsmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oopsmonk/subscriptions","organizations_url":"https://api.github.com/users/oopsmonk/orgs","repos_url":"https://api.github.com/users/oopsmonk/repos","events_url":"https://api.github.com/users/oopsmonk/events{/privacy}","received_events_url":"https://api.github.com/users/oopsmonk/received_events","type":"User","site_admin":false},"repo":{"id":141985335,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5ODUzMzU=","name":"entangled","full_name":"oopsmonk/entangled","owner":{"login":"oopsmonk","id":462383,"node_id":"MDQ6VXNlcjQ2MjM4Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/462383?v=4","gravatar_id":"","url":"https://api.github.com/users/oopsmonk","html_url":"https://github.com/oopsmonk","followers_url":"https://api.github.com/users/oopsmonk/followers","following_url":"https://api.github.com/users/oopsmonk/following{/other_user}","gists_url":"https://api.github.com/users/oopsmonk/gists{/gist_id}","starred_url":"https://api.github.com/users/oopsmonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oopsmonk/subscriptions","organizations_url":"https://api.github.com/users/oopsmonk/orgs","repos_url":"https://api.github.com/users/oopsmonk/repos","events_url":"https://api.github.com/users/oopsmonk/events{/privacy}","received_events_url":"https://api.github.com/users/oopsmonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oopsmonk/entangled","description":"enTangle'd is an amalgamation of all things Tangle","fork":true,"url":"https://api.github.com/repos/oopsmonk/entangled","forks_url":"https://api.github.com/repos/oopsmonk/entangled/forks","keys_url":"https://api.github.com/repos/oopsmonk/entangled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oopsmonk/entangled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oopsmonk/entangled/teams","hooks_url":"https://api.github.com/repos/oopsmonk/entangled/hooks","issue_events_url":"https://api.github.com/repos/oopsmonk/entangled/issues/events{/number}","events_url":"https://api.github.com/repos/oopsmonk/entangled/events","assignees_url":"https://api.github.com/repos/oopsmonk/entangled/assignees{/user}","branches_url":"https://api.github.com/repos/oopsmonk/entangled/branches{/branch}","tags_url":"https://api.github.com/repos/oopsmonk/entangled/tags","blobs_url":"https://api.github.com/repos/oopsmonk/entangled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oopsmonk/entangled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oopsmonk/entangled/git/refs{/sha}","trees_url":"https://api.github.com/repos/oopsmonk/entangled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oopsmonk/entangled/statuses/{sha}","languages_url":"https://api.github.com/repos/oopsmonk/entangled/languages","stargazers_url":"https://api.github.com/repos/oopsmonk/entangled/stargazers","contributors_url":"https://api.github.com/repos/oopsmonk/entangled/contributors","subscribers_url":"https://api.github.com/repos/oopsmonk/entangled/subscribers","subscription_url":"https://api.github.com/repos/oopsmonk/entangled/subscription","commits_url":"https://api.github.com/repos/oopsmonk/entangled/commits{/sha}","git_commits_url":"https://api.github.com/repos/oopsmonk/entangled/git/commits{/sha}","comments_url":"https://api.github.com/repos/oopsmonk/entangled/comments{/number}","issue_comment_url":"https://api.github.com/repos/oopsmonk/entangled/issues/comments{/number}","contents_url":"https://api.github.com/repos/oopsmonk/entangled/contents/{+path}","compare_url":"https://api.github.com/repos/oopsmonk/entangled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oopsmonk/entangled/merges","archive_url":"https://api.github.com/repos/oopsmonk/entangled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oopsmonk/entangled/downloads","issues_url":"https://api.github.com/repos/oopsmonk/entangled/issues{/number}","pulls_url":"https://api.github.com/repos/oopsmonk/entangled/pulls{/number}","milestones_url":"https://api.github.com/repos/oopsmonk/entangled/milestones{/number}","notifications_url":"https://api.github.com/repos/oopsmonk/entangled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oopsmonk/entangled/labels{/name}","releases_url":"https://api.github.com/repos/oopsmonk/entangled/releases{/id}","deployments_url":"https://api.github.com/repos/oopsmonk/entangled/deployments","created_at":"2018-07-23T08:32:27Z","updated_at":"2018-08-23T10:11:24Z","pushed_at":"2018-08-23T10:51:32Z","git_url":"git://github.com/oopsmonk/entangled.git","ssh_url":"git@github.com:oopsmonk/entangled.git","clone_url":"https://github.com/oopsmonk/entangled.git","svn_url":"https://github.com/oopsmonk/entangled","homepage":"","size":828,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"iotaledger:develop","ref":"develop","sha":"8175572a13634d693966c2f28e2b050b36088bb3","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":137051507,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwNTE1MDc=","name":"entangled","full_name":"iotaledger/entangled","owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iotaledger/entangled","description":"enTangle'd is an amalgamation of all things Tangle","fork":false,"url":"https://api.github.com/repos/iotaledger/entangled","forks_url":"https://api.github.com/repos/iotaledger/entangled/forks","keys_url":"https://api.github.com/repos/iotaledger/entangled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/entangled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/entangled/teams","hooks_url":"https://api.github.com/repos/iotaledger/entangled/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/entangled/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/entangled/events","assignees_url":"https://api.github.com/repos/iotaledger/entangled/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/entangled/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/entangled/tags","blobs_url":"https://api.github.com/repos/iotaledger/entangled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/entangled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/entangled/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/entangled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/entangled/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/entangled/languages","stargazers_url":"https://api.github.com/repos/iotaledger/entangled/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/entangled/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/entangled/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/entangled/subscription","commits_url":"https://api.github.com/repos/iotaledger/entangled/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/entangled/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/entangled/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/entangled/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/entangled/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/entangled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/entangled/merges","archive_url":"https://api.github.com/repos/iotaledger/entangled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/entangled/downloads","issues_url":"https://api.github.com/repos/iotaledger/entangled/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/entangled/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/entangled/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/entangled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/entangled/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/entangled/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/entangled/deployments","created_at":"2018-06-12T09:49:47Z","updated_at":"2018-08-23T10:29:18Z","pushed_at":"2018-08-23T10:59:27Z","git_url":"git://github.com/iotaledger/entangled.git","ssh_url":"git@github.com:iotaledger/entangled.git","clone_url":"https://github.com/iotaledger/entangled.git","svn_url":"https://github.com/iotaledger/entangled","homepage":"","size":830,"stargazers_count":15,"watchers_count":15,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":62,"license":null,"forks":20,"open_issues":62,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/188"},"html":{"href":"https://github.com/iotaledger/entangled/pull/188"},"issue":{"href":"https://api.github.com/repos/iotaledger/entangled/issues/188"},"comments":{"href":"https://api.github.com/repos/iotaledger/entangled/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/entangled/statuses/108ba6d52da319069112f985515d2ff0aaa156b4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"thibault-martinez"}}