{"action":"created","comment":{"url":"https://api.github.com/repos/moby/moby/pulls/comments/171037368","pull_request_review_id":99820019,"id":171037368,"diff_hunk":"@@ -32,23 +32,11 @@\n # the case. Therefore, you don't have to disable it anymore.\n #\n \n-FROM buildpack-deps:stretch AS base\n+FROM golang:1.9.4 AS base","path":"Dockerfile","position":5,"original_position":5,"commit_id":"4ef3925444fd76adc5959f18d53a4ea10e1e729a","original_commit_id":"4ef3925444fd76adc5959f18d53a4ea10e1e729a","user":{"login":"tianon","id":161631,"avatar_url":"https://avatars1.githubusercontent.com/u/161631?v=4","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},"body":"We have a long tradition of pushing the RCs too: :innocent: \r\n```console\r\n$ docker-hub-list-tags.sh library/golang | grep rc | grep -vE 'onbuild|wheezy|windowsservercore|nanoserver|cross'\r\nrc\r\n1.10-rc\r\n1.10rc2\r\nrc-stretch\r\n1.10-rc-stretch\r\n1.10rc2-stretch\r\nrc-alpine\r\n1.10-rc-alpine\r\n1.10rc2-alpine\r\nrc-alpine3.7\r\n1.10-rc-alpine3.7\r\n1.10rc2-alpine3.7\r\n1.10rc1\r\n1.10rc1-alpine\r\n1.10rc1-alpine3.7\r\n1.10rc1-stretch\r\n1.9-rc-alpine\r\n1.9rc2-alpine\r\nrc-alpine3.6\r\n1.9-rc-alpine3.6\r\n1.9rc2-alpine3.6\r\n1.9-rc\r\n1.9rc2\r\n1.9-rc-stretch\r\n1.9rc2-stretch\r\n1.9rc1-alpine\r\n1.9rc1-alpine3.6\r\n1.9rc1\r\n1.9rc1-stretch\r\n1.8-rc-alpine\r\n1.8rc3-alpine\r\n1.8-rc-stretch\r\n1.8rc3-stretch\r\n1.8-rc\r\n1.8rc3\r\n1.8rc2-alpine\r\n1.8rc2\r\n1.8rc1\r\n1.8rc1-alpine\r\n1.7rc6-alpine\r\n1.7rc6\r\n1.7rc5-alpine\r\n1.7rc5\r\n1.7rc4-alpine\r\n1.7rc4\r\n1.7rc3\r\n1.7rc3-alpine\r\n1.7rc2-alpine\r\n1.7rc2\r\n1.7rc1-alpine\r\n1.7rc1\r\n1.6rc2-alpine\r\n1.6rc2\r\n1.6rc1-alpine\r\n1.6rc1\r\n1.5rc1\r\n1.4rc2\r\n1.4rc1\r\n```\r\n(back to Go 1.4rc1 -- https://github.com/docker-library/golang/pull/26; 2014! :smile:)","created_at":"2018-02-27T19:22:23Z","updated_at":"2018-02-27T19:22:23Z","html_url":"https://github.com/moby/moby/pull/36425#discussion_r171037368","pull_request_url":"https://api.github.com/repos/moby/moby/pulls/36425","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/comments/171037368"},"html":{"href":"https://github.com/moby/moby/pull/36425#discussion_r171037368"},"pull_request":{"href":"https://api.github.com/repos/moby/moby/pulls/36425"}},"in_reply_to_id":170895877},"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/36425","id":171593588,"html_url":"https://github.com/moby/moby/pull/36425","diff_url":"https://github.com/moby/moby/pull/36425.diff","patch_url":"https://github.com/moby/moby/pull/36425.patch","issue_url":"https://api.github.com/repos/moby/moby/issues/36425","number":36425,"state":"open","locked":false,"title":"Follow-up fixes on multi-stage moby's Dockerfile","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"- Do not copy golang in itself (`runtime-dev` is already base on `golang`)\r\n- Use `golang` official image as base (instead of `debian:stretch` and installing go manually)\r\n\r\nThis is gonna affect the cache quite a lot (because well, it's updating the base image for almost everything 😅 )\r\n\r\nSigned-off-by: Vincent Demeester <vincent@sbr.pm>\r\n","created_at":"2018-02-27T08:32:11Z","updated_at":"2018-02-27T19:22:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df26505ebbc0a9ced369ddc56f34237db065b1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tianon","id":161631,"avatar_url":"https://avatars1.githubusercontent.com/u/161631?v=4","gravatar_id":"","url":"https://api.github.com/users/tianon","html_url":"https://github.com/tianon","followers_url":"https://api.github.com/users/tianon/followers","following_url":"https://api.github.com/users/tianon/following{/other_user}","gists_url":"https://api.github.com/users/tianon/gists{/gist_id}","starred_url":"https://api.github.com/users/tianon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianon/subscriptions","organizations_url":"https://api.github.com/users/tianon/orgs","repos_url":"https://api.github.com/users/tianon/repos","events_url":"https://api.github.com/users/tianon/events{/privacy}","received_events_url":"https://api.github.com/users/tianon/received_events","type":"User","site_admin":false},{"login":"tonistiigi","id":585223,"avatar_url":"https://avatars1.githubusercontent.com/u/585223?v=4","gravatar_id":"","url":"https://api.github.com/users/tonistiigi","html_url":"https://github.com/tonistiigi","followers_url":"https://api.github.com/users/tonistiigi/followers","following_url":"https://api.github.com/users/tonistiigi/following{/other_user}","gists_url":"https://api.github.com/users/tonistiigi/gists{/gist_id}","starred_url":"https://api.github.com/users/tonistiigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonistiigi/subscriptions","organizations_url":"https://api.github.com/users/tonistiigi/orgs","repos_url":"https://api.github.com/users/tonistiigi/repos","events_url":"https://api.github.com/users/tonistiigi/events{/privacy}","received_events_url":"https://api.github.com/users/tonistiigi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":175375407,"url":"https://api.github.com/repos/moby/moby/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/moby/moby/pulls/36425/commits","review_comments_url":"https://api.github.com/repos/moby/moby/pulls/36425/comments","review_comment_url":"https://api.github.com/repos/moby/moby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moby/moby/issues/36425/comments","statuses_url":"https://api.github.com/repos/moby/moby/statuses/4ef3925444fd76adc5959f18d53a4ea10e1e729a","head":{"label":"vdemeester:dockerfile-adjusts","ref":"dockerfile-adjusts","sha":"4ef3925444fd76adc5959f18d53a4ea10e1e729a","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"repo":{"id":32953007,"name":"moby","full_name":"vdemeester/moby","owner":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars0.githubusercontent.com/u/6508?v=4","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vdemeester/moby","description":"🐳 Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/vdemeester/moby","forks_url":"https://api.github.com/repos/vdemeester/moby/forks","keys_url":"https://api.github.com/repos/vdemeester/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdemeester/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdemeester/moby/teams","hooks_url":"https://api.github.com/repos/vdemeester/moby/hooks","issue_events_url":"https://api.github.com/repos/vdemeester/moby/issues/events{/number}","events_url":"https://api.github.com/repos/vdemeester/moby/events","assignees_url":"https://api.github.com/repos/vdemeester/moby/assignees{/user}","branches_url":"https://api.github.com/repos/vdemeester/moby/branches{/branch}","tags_url":"https://api.github.com/repos/vdemeester/moby/tags","blobs_url":"https://api.github.com/repos/vdemeester/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdemeester/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdemeester/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdemeester/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdemeester/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/vdemeester/moby/languages","stargazers_url":"https://api.github.com/repos/vdemeester/moby/stargazers","contributors_url":"https://api.github.com/repos/vdemeester/moby/contributors","subscribers_url":"https://api.github.com/repos/vdemeester/moby/subscribers","subscription_url":"https://api.github.com/repos/vdemeester/moby/subscription","commits_url":"https://api.github.com/repos/vdemeester/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdemeester/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdemeester/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdemeester/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdemeester/moby/contents/{+path}","compare_url":"https://api.github.com/repos/vdemeester/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdemeester/moby/merges","archive_url":"https://api.github.com/repos/vdemeester/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdemeester/moby/downloads","issues_url":"https://api.github.com/repos/vdemeester/moby/issues{/number}","pulls_url":"https://api.github.com/repos/vdemeester/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/vdemeester/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/vdemeester/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdemeester/moby/labels{/name}","releases_url":"https://api.github.com/repos/vdemeester/moby/releases{/id}","deployments_url":"https://api.github.com/repos/vdemeester/moby/deployments","created_at":"2015-03-26T21:32:15Z","updated_at":"2017-04-19T12:04:25Z","pushed_at":"2018-02-27T18:26:51Z","git_url":"git://github.com/vdemeester/moby.git","ssh_url":"git@github.com:vdemeester/moby.git","clone_url":"https://github.com/vdemeester/moby.git","svn_url":"https://github.com/vdemeester/moby","homepage":"http://www.docker.com","size":132309,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moby:master","ref":"master","sha":"600475715eb93fa402d1642a3586421c7182d63b","user":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"moby","full_name":"moby/moby","owner":{"login":"moby","id":27259197,"avatar_url":"https://avatars1.githubusercontent.com/u/27259197?v=4","gravatar_id":"","url":"https://api.github.com/users/moby","html_url":"https://github.com/moby","followers_url":"https://api.github.com/users/moby/followers","following_url":"https://api.github.com/users/moby/following{/other_user}","gists_url":"https://api.github.com/users/moby/gists{/gist_id}","starred_url":"https://api.github.com/users/moby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moby/subscriptions","organizations_url":"https://api.github.com/users/moby/orgs","repos_url":"https://api.github.com/users/moby/repos","events_url":"https://api.github.com/users/moby/events{/privacy}","received_events_url":"https://api.github.com/users/moby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moby/moby","description":"Moby Project - a collaborative project for the container ecosystem to assemble container-based systems","fork":false,"url":"https://api.github.com/repos/moby/moby","forks_url":"https://api.github.com/repos/moby/moby/forks","keys_url":"https://api.github.com/repos/moby/moby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moby/moby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moby/moby/teams","hooks_url":"https://api.github.com/repos/moby/moby/hooks","issue_events_url":"https://api.github.com/repos/moby/moby/issues/events{/number}","events_url":"https://api.github.com/repos/moby/moby/events","assignees_url":"https://api.github.com/repos/moby/moby/assignees{/user}","branches_url":"https://api.github.com/repos/moby/moby/branches{/branch}","tags_url":"https://api.github.com/repos/moby/moby/tags","blobs_url":"https://api.github.com/repos/moby/moby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moby/moby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moby/moby/git/refs{/sha}","trees_url":"https://api.github.com/repos/moby/moby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moby/moby/statuses/{sha}","languages_url":"https://api.github.com/repos/moby/moby/languages","stargazers_url":"https://api.github.com/repos/moby/moby/stargazers","contributors_url":"https://api.github.com/repos/moby/moby/contributors","subscribers_url":"https://api.github.com/repos/moby/moby/subscribers","subscription_url":"https://api.github.com/repos/moby/moby/subscription","commits_url":"https://api.github.com/repos/moby/moby/commits{/sha}","git_commits_url":"https://api.github.com/repos/moby/moby/git/commits{/sha}","comments_url":"https://api.github.com/repos/moby/moby/comments{/number}","issue_comment_url":"https://api.github.com/repos/moby/moby/issues/comments{/number}","contents_url":"https://api.github.com/repos/moby/moby/contents/{+path}","compare_url":"https://api.github.com/repos/moby/moby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moby/moby/merges","archive_url":"https://api.github.com/repos/moby/moby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moby/moby/downloads","issues_url":"https://api.github.com/repos/moby/moby/issues{/number}","pulls_url":"https://api.github.com/repos/moby/moby/pulls{/number}","milestones_url":"https://api.github.com/repos/moby/moby/milestones{/number}","notifications_url":"https://api.github.com/repos/moby/moby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moby/moby/labels{/name}","releases_url":"https://api.github.com/repos/moby/moby/releases{/id}","deployments_url":"https://api.github.com/repos/moby/moby/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2018-02-27T19:03:48Z","pushed_at":"2018-02-27T19:20:34Z","git_url":"git://github.com/moby/moby.git","ssh_url":"git@github.com:moby/moby.git","clone_url":"https://github.com/moby/moby.git","svn_url":"https://github.com/moby/moby","homepage":"https://mobyproject.org/","size":136594,"stargazers_count":47798,"watchers_count":47798,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14099,"mirror_url":null,"archived":false,"open_issues_count":3064,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14099,"open_issues":3064,"watchers":47798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moby/moby/pulls/36425"},"html":{"href":"https://github.com/moby/moby/pull/36425"},"issue":{"href":"https://api.github.com/repos/moby/moby/issues/36425"},"comments":{"href":"https://api.github.com/repos/moby/moby/issues/36425/comments"},"review_comments":{"href":"https://api.github.com/repos/moby/moby/pulls/36425/comments"},"review_comment":{"href":"https://api.github.com/repos/moby/moby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moby/moby/pulls/36425/commits"},"statuses":{"href":"https://api.github.com/repos/moby/moby/statuses/4ef3925444fd76adc5959f18d53a4ea10e1e729a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tianon"}}