{"action":"created","comment":{"url":"https://api.github.com/repos/stfc/PSyclone/pulls/comments/242940846","pull_request_review_id":186576879,"id":242940846,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mjk0MDg0Ng==","diff_hunk":"@@ -71,80 +71,26 @@\n NEMO_INDEX_ORDERING = [\"lon\", \"lat\", \"levels\", \"tracers\"]\n \n \n-class ASTProcessor(object):\n+class NemoASTProcessor(fparser2ASTProcessor):","path":"src/psyclone/nemo.py","position":14,"original_position":14,"commit_id":"46ad04341623ee1d1a7d4e8c7aabb6d5fac49526","original_commit_id":"3b897cd6a89e09630aafbbf66b6ee72fc2e32b30","user":{"login":"sergisiso","id":1449555,"node_id":"MDQ6VXNlcjE0NDk1NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1449555?v=4","gravatar_id":"","url":"https://api.github.com/users/sergisiso","html_url":"https://github.com/sergisiso","followers_url":"https://api.github.com/users/sergisiso/followers","following_url":"https://api.github.com/users/sergisiso/following{/other_user}","gists_url":"https://api.github.com/users/sergisiso/gists{/gist_id}","starred_url":"https://api.github.com/users/sergisiso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergisiso/subscriptions","organizations_url":"https://api.github.com/users/sergisiso/orgs","repos_url":"https://api.github.com/users/sergisiso/repos","events_url":"https://api.github.com/users/sergisiso/events{/privacy}","received_events_url":"https://api.github.com/users/sergisiso/received_events","type":"User","site_admin":false},"body":"Do you think ASTProcessor class should be a file of its own instead of psyGen.py? I notice pylint complains that the files are to long and the ASTProcessor and its tests are growing in my following PRs.","created_at":"2018-12-19T14:43:20Z","updated_at":"2018-12-19T14:43:21Z","html_url":"https://github.com/stfc/PSyclone/pull/247#discussion_r242940846","pull_request_url":"https://api.github.com/repos/stfc/PSyclone/pulls/247","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stfc/PSyclone/pulls/comments/242940846"},"html":{"href":"https://github.com/stfc/PSyclone/pull/247#discussion_r242940846"},"pull_request":{"href":"https://api.github.com/repos/stfc/PSyclone/pulls/247"}},"in_reply_to_id":242710295},"pull_request":{"url":"https://api.github.com/repos/stfc/PSyclone/pulls/247","id":234315859,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzE1ODU5","html_url":"https://github.com/stfc/PSyclone/pull/247","diff_url":"https://github.com/stfc/PSyclone/pull/247.diff","patch_url":"https://github.com/stfc/PSyclone/pull/247.patch","issue_url":"https://api.github.com/repos/stfc/PSyclone/issues/247","number":247,"state":"open","locked":false,"title":"Extend PSyIRe to express kernel code","user":{"login":"sergisiso","id":1449555,"node_id":"MDQ6VXNlcjE0NDk1NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1449555?v=4","gravatar_id":"","url":"https://api.github.com/users/sergisiso","html_url":"https://github.com/sergisiso","followers_url":"https://api.github.com/users/sergisiso/followers","following_url":"https://api.github.com/users/sergisiso/following{/other_user}","gists_url":"https://api.github.com/users/sergisiso/gists{/gist_id}","starred_url":"https://api.github.com/users/sergisiso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergisiso/subscriptions","organizations_url":"https://api.github.com/users/sergisiso/orgs","repos_url":"https://api.github.com/users/sergisiso/repos","events_url":"https://api.github.com/users/sergisiso/events{/privacy}","received_events_url":"https://api.github.com/users/sergisiso/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-28T15:20:25Z","updated_at":"2018-12-19T14:43:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7e4e093efdadfb96e2f4f886c44083ed1603bc1","assignee":{"login":"sergisiso","id":1449555,"node_id":"MDQ6VXNlcjE0NDk1NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1449555?v=4","gravatar_id":"","url":"https://api.github.com/users/sergisiso","html_url":"https://github.com/sergisiso","followers_url":"https://api.github.com/users/sergisiso/followers","following_url":"https://api.github.com/users/sergisiso/following{/other_user}","gists_url":"https://api.github.com/users/sergisiso/gists{/gist_id}","starred_url":"https://api.github.com/users/sergisiso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergisiso/subscriptions","organizations_url":"https://api.github.com/users/sergisiso/orgs","repos_url":"https://api.github.com/users/sergisiso/repos","events_url":"https://api.github.com/users/sergisiso/events{/privacy}","received_events_url":"https://api.github.com/users/sergisiso/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergisiso","id":1449555,"node_id":"MDQ6VXNlcjE0NDk1NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1449555?v=4","gravatar_id":"","url":"https://api.github.com/users/sergisiso","html_url":"https://github.com/sergisiso","followers_url":"https://api.github.com/users/sergisiso/followers","following_url":"https://api.github.com/users/sergisiso/following{/other_user}","gists_url":"https://api.github.com/users/sergisiso/gists{/gist_id}","starred_url":"https://api.github.com/users/sergisiso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergisiso/subscriptions","organizations_url":"https://api.github.com/users/sergisiso/orgs","repos_url":"https://api.github.com/users/sergisiso/repos","events_url":"https://api.github.com/users/sergisiso/events{/privacy}","received_events_url":"https://api.github.com/users/sergisiso/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"arporter","id":17409212,"node_id":"MDQ6VXNlcjE3NDA5MjEy","avatar_url":"https://avatars1.githubusercontent.com/u/17409212?v=4","gravatar_id":"","url":"https://api.github.com/users/arporter","html_url":"https://github.com/arporter","followers_url":"https://api.github.com/users/arporter/followers","following_url":"https://api.github.com/users/arporter/following{/other_user}","gists_url":"https://api.github.com/users/arporter/gists{/gist_id}","starred_url":"https://api.github.com/users/arporter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arporter/subscriptions","organizations_url":"https://api.github.com/users/arporter/orgs","repos_url":"https://api.github.com/users/arporter/repos","events_url":"https://api.github.com/users/arporter/events{/privacy}","received_events_url":"https://api.github.com/users/arporter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":801586449,"node_id":"MDU6TGFiZWw4MDE1ODY0NDk=","url":"https://api.github.com/repos/stfc/PSyclone/labels/reviewed%20with%20actions","name":"reviewed with actions","color":"14e2b9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stfc/PSyclone/pulls/247/commits","review_comments_url":"https://api.github.com/repos/stfc/PSyclone/pulls/247/comments","review_comment_url":"https://api.github.com/repos/stfc/PSyclone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stfc/PSyclone/issues/247/comments","statuses_url":"https://api.github.com/repos/stfc/PSyclone/statuses/46ad04341623ee1d1a7d4e8c7aabb6d5fac49526","head":{"label":"stfc:kernelPSyIR","ref":"kernelPSyIR","sha":"46ad04341623ee1d1a7d4e8c7aabb6d5fac49526","user":{"login":"stfc","id":3727936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3Mjc5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3727936?v=4","gravatar_id":"","url":"https://api.github.com/users/stfc","html_url":"https://github.com/stfc","followers_url":"https://api.github.com/users/stfc/followers","following_url":"https://api.github.com/users/stfc/following{/other_user}","gists_url":"https://api.github.com/users/stfc/gists{/gist_id}","starred_url":"https://api.github.com/users/stfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfc/subscriptions","organizations_url":"https://api.github.com/users/stfc/orgs","repos_url":"https://api.github.com/users/stfc/repos","events_url":"https://api.github.com/users/stfc/events{/privacy}","received_events_url":"https://api.github.com/users/stfc/received_events","type":"Organization","site_admin":false},"repo":{"id":83541466,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU0MTQ2Ng==","name":"PSyclone","full_name":"stfc/PSyclone","private":false,"owner":{"login":"stfc","id":3727936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3Mjc5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3727936?v=4","gravatar_id":"","url":"https://api.github.com/users/stfc","html_url":"https://github.com/stfc","followers_url":"https://api.github.com/users/stfc/followers","following_url":"https://api.github.com/users/stfc/following{/other_user}","gists_url":"https://api.github.com/users/stfc/gists{/gist_id}","starred_url":"https://api.github.com/users/stfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfc/subscriptions","organizations_url":"https://api.github.com/users/stfc/orgs","repos_url":"https://api.github.com/users/stfc/repos","events_url":"https://api.github.com/users/stfc/events{/privacy}","received_events_url":"https://api.github.com/users/stfc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stfc/PSyclone","description":"Domain-specific compiler for Finite Difference/Volume/Element Earth-system models in Fortran","fork":false,"url":"https://api.github.com/repos/stfc/PSyclone","forks_url":"https://api.github.com/repos/stfc/PSyclone/forks","keys_url":"https://api.github.com/repos/stfc/PSyclone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stfc/PSyclone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stfc/PSyclone/teams","hooks_url":"https://api.github.com/repos/stfc/PSyclone/hooks","issue_events_url":"https://api.github.com/repos/stfc/PSyclone/issues/events{/number}","events_url":"https://api.github.com/repos/stfc/PSyclone/events","assignees_url":"https://api.github.com/repos/stfc/PSyclone/assignees{/user}","branches_url":"https://api.github.com/repos/stfc/PSyclone/branches{/branch}","tags_url":"https://api.github.com/repos/stfc/PSyclone/tags","blobs_url":"https://api.github.com/repos/stfc/PSyclone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stfc/PSyclone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stfc/PSyclone/git/refs{/sha}","trees_url":"https://api.github.com/repos/stfc/PSyclone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stfc/PSyclone/statuses/{sha}","languages_url":"https://api.github.com/repos/stfc/PSyclone/languages","stargazers_url":"https://api.github.com/repos/stfc/PSyclone/stargazers","contributors_url":"https://api.github.com/repos/stfc/PSyclone/contributors","subscribers_url":"https://api.github.com/repos/stfc/PSyclone/subscribers","subscription_url":"https://api.github.com/repos/stfc/PSyclone/subscription","commits_url":"https://api.github.com/repos/stfc/PSyclone/commits{/sha}","git_commits_url":"https://api.github.com/repos/stfc/PSyclone/git/commits{/sha}","comments_url":"https://api.github.com/repos/stfc/PSyclone/comments{/number}","issue_comment_url":"https://api.github.com/repos/stfc/PSyclone/issues/comments{/number}","contents_url":"https://api.github.com/repos/stfc/PSyclone/contents/{+path}","compare_url":"https://api.github.com/repos/stfc/PSyclone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stfc/PSyclone/merges","archive_url":"https://api.github.com/repos/stfc/PSyclone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stfc/PSyclone/downloads","issues_url":"https://api.github.com/repos/stfc/PSyclone/issues{/number}","pulls_url":"https://api.github.com/repos/stfc/PSyclone/pulls{/number}","milestones_url":"https://api.github.com/repos/stfc/PSyclone/milestones{/number}","notifications_url":"https://api.github.com/repos/stfc/PSyclone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stfc/PSyclone/labels{/name}","releases_url":"https://api.github.com/repos/stfc/PSyclone/releases{/id}","deployments_url":"https://api.github.com/repos/stfc/PSyclone/deployments","created_at":"2017-03-01T10:17:58Z","updated_at":"2018-12-19T14:04:14Z","pushed_at":"2018-12-19T14:37:12Z","git_url":"git://github.com/stfc/PSyclone.git","ssh_url":"git@github.com:stfc/PSyclone.git","clone_url":"https://github.com/stfc/PSyclone.git","svn_url":"https://github.com/stfc/PSyclone","homepage":null,"size":31338,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":78,"watchers":21,"default_branch":"master"}},"base":{"label":"stfc:master","ref":"master","sha":"ba95a0d792fd30c663505ac8c9ca2e4245e01eec","user":{"login":"stfc","id":3727936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3Mjc5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3727936?v=4","gravatar_id":"","url":"https://api.github.com/users/stfc","html_url":"https://github.com/stfc","followers_url":"https://api.github.com/users/stfc/followers","following_url":"https://api.github.com/users/stfc/following{/other_user}","gists_url":"https://api.github.com/users/stfc/gists{/gist_id}","starred_url":"https://api.github.com/users/stfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfc/subscriptions","organizations_url":"https://api.github.com/users/stfc/orgs","repos_url":"https://api.github.com/users/stfc/repos","events_url":"https://api.github.com/users/stfc/events{/privacy}","received_events_url":"https://api.github.com/users/stfc/received_events","type":"Organization","site_admin":false},"repo":{"id":83541466,"node_id":"MDEwOlJlcG9zaXRvcnk4MzU0MTQ2Ng==","name":"PSyclone","full_name":"stfc/PSyclone","private":false,"owner":{"login":"stfc","id":3727936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3Mjc5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/3727936?v=4","gravatar_id":"","url":"https://api.github.com/users/stfc","html_url":"https://github.com/stfc","followers_url":"https://api.github.com/users/stfc/followers","following_url":"https://api.github.com/users/stfc/following{/other_user}","gists_url":"https://api.github.com/users/stfc/gists{/gist_id}","starred_url":"https://api.github.com/users/stfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stfc/subscriptions","organizations_url":"https://api.github.com/users/stfc/orgs","repos_url":"https://api.github.com/users/stfc/repos","events_url":"https://api.github.com/users/stfc/events{/privacy}","received_events_url":"https://api.github.com/users/stfc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stfc/PSyclone","description":"Domain-specific compiler for Finite Difference/Volume/Element Earth-system models in Fortran","fork":false,"url":"https://api.github.com/repos/stfc/PSyclone","forks_url":"https://api.github.com/repos/stfc/PSyclone/forks","keys_url":"https://api.github.com/repos/stfc/PSyclone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stfc/PSyclone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stfc/PSyclone/teams","hooks_url":"https://api.github.com/repos/stfc/PSyclone/hooks","issue_events_url":"https://api.github.com/repos/stfc/PSyclone/issues/events{/number}","events_url":"https://api.github.com/repos/stfc/PSyclone/events","assignees_url":"https://api.github.com/repos/stfc/PSyclone/assignees{/user}","branches_url":"https://api.github.com/repos/stfc/PSyclone/branches{/branch}","tags_url":"https://api.github.com/repos/stfc/PSyclone/tags","blobs_url":"https://api.github.com/repos/stfc/PSyclone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stfc/PSyclone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stfc/PSyclone/git/refs{/sha}","trees_url":"https://api.github.com/repos/stfc/PSyclone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stfc/PSyclone/statuses/{sha}","languages_url":"https://api.github.com/repos/stfc/PSyclone/languages","stargazers_url":"https://api.github.com/repos/stfc/PSyclone/stargazers","contributors_url":"https://api.github.com/repos/stfc/PSyclone/contributors","subscribers_url":"https://api.github.com/repos/stfc/PSyclone/subscribers","subscription_url":"https://api.github.com/repos/stfc/PSyclone/subscription","commits_url":"https://api.github.com/repos/stfc/PSyclone/commits{/sha}","git_commits_url":"https://api.github.com/repos/stfc/PSyclone/git/commits{/sha}","comments_url":"https://api.github.com/repos/stfc/PSyclone/comments{/number}","issue_comment_url":"https://api.github.com/repos/stfc/PSyclone/issues/comments{/number}","contents_url":"https://api.github.com/repos/stfc/PSyclone/contents/{+path}","compare_url":"https://api.github.com/repos/stfc/PSyclone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stfc/PSyclone/merges","archive_url":"https://api.github.com/repos/stfc/PSyclone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stfc/PSyclone/downloads","issues_url":"https://api.github.com/repos/stfc/PSyclone/issues{/number}","pulls_url":"https://api.github.com/repos/stfc/PSyclone/pulls{/number}","milestones_url":"https://api.github.com/repos/stfc/PSyclone/milestones{/number}","notifications_url":"https://api.github.com/repos/stfc/PSyclone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stfc/PSyclone/labels{/name}","releases_url":"https://api.github.com/repos/stfc/PSyclone/releases{/id}","deployments_url":"https://api.github.com/repos/stfc/PSyclone/deployments","created_at":"2017-03-01T10:17:58Z","updated_at":"2018-12-19T14:04:14Z","pushed_at":"2018-12-19T14:37:12Z","git_url":"git://github.com/stfc/PSyclone.git","ssh_url":"git@github.com:stfc/PSyclone.git","clone_url":"https://github.com/stfc/PSyclone.git","svn_url":"https://github.com/stfc/PSyclone","homepage":null,"size":31338,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":78,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stfc/PSyclone/pulls/247"},"html":{"href":"https://github.com/stfc/PSyclone/pull/247"},"issue":{"href":"https://api.github.com/repos/stfc/PSyclone/issues/247"},"comments":{"href":"https://api.github.com/repos/stfc/PSyclone/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/stfc/PSyclone/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/stfc/PSyclone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stfc/PSyclone/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/stfc/PSyclone/statuses/46ad04341623ee1d1a7d4e8c7aabb6d5fac49526"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sergisiso"}}