{"action":"created","comment":{"url":"https://api.github.com/repos/crust-firmware/crust/pulls/comments/180420414","pull_request_review_id":110835376,"id":180420414,"diff_hunk":"@@ -36,6 +39,15 @@ static struct device r_twd    __device;\n static struct device sy8106a __device;\n #endif\n \n+#if CONFIG_PMIC_AXP803\n+static struct device axp803_pmic = {\n+\t.name = \"axp803-pmic\",\n+\t.drv  = &axp803_pmic_driver.drv,\n+\t.bus  = &r_i2c,\n+\t.addr = 0x34,","path":"platform/sun50i/devices.c","position":22,"original_position":19,"commit_id":"12e4fa9a5ede70e419499409ff6abba654414cf8","original_commit_id":"42ce176d4623ada1b32ea7aaafa67f25c57e68f7","user":{"login":"drewwalters96","id":9168811,"avatar_url":"https://avatars1.githubusercontent.com/u/9168811?v=4","gravatar_id":"","url":"https://api.github.com/users/drewwalters96","html_url":"https://github.com/drewwalters96","followers_url":"https://api.github.com/users/drewwalters96/followers","following_url":"https://api.github.com/users/drewwalters96/following{/other_user}","gists_url":"https://api.github.com/users/drewwalters96/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwalters96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwalters96/subscriptions","organizations_url":"https://api.github.com/users/drewwalters96/orgs","repos_url":"https://api.github.com/users/drewwalters96/repos","events_url":"https://api.github.com/users/drewwalters96/events{/privacy}","received_events_url":"https://api.github.com/users/drewwalters96/received_events","type":"User","site_admin":false},"body":"For `.addr`? I am not sure what you mean - the `axp803_regulator` has the address `0x34` hard-coded as well.","created_at":"2018-04-10T13:30:57Z","updated_at":"2018-04-10T13:30:58Z","html_url":"https://github.com/crust-firmware/crust/pull/132#discussion_r180420414","pull_request_url":"https://api.github.com/repos/crust-firmware/crust/pulls/132","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/crust-firmware/crust/pulls/comments/180420414"},"html":{"href":"https://github.com/crust-firmware/crust/pull/132#discussion_r180420414"},"pull_request":{"href":"https://api.github.com/repos/crust-firmware/crust/pulls/132"}},"in_reply_to_id":180299723},"pull_request":{"url":"https://api.github.com/repos/crust-firmware/crust/pulls/132","id":179796321,"html_url":"https://github.com/crust-firmware/crust/pull/132","diff_url":"https://github.com/crust-firmware/crust/pull/132.diff","patch_url":"https://github.com/crust-firmware/crust/pull/132.patch","issue_url":"https://api.github.com/repos/crust-firmware/crust/issues/132","number":132,"state":"open","locked":false,"title":"common: Add shutdown and suspend protocols","user":{"login":"drewwalters96","id":9168811,"avatar_url":"https://avatars1.githubusercontent.com/u/9168811?v=4","gravatar_id":"","url":"https://api.github.com/users/drewwalters96","html_url":"https://github.com/drewwalters96","followers_url":"https://api.github.com/users/drewwalters96/followers","following_url":"https://api.github.com/users/drewwalters96/following{/other_user}","gists_url":"https://api.github.com/users/drewwalters96/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwalters96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwalters96/subscriptions","organizations_url":"https://api.github.com/users/drewwalters96/orgs","repos_url":"https://api.github.com/users/drewwalters96/repos","events_url":"https://api.github.com/users/drewwalters96/events{/privacy}","received_events_url":"https://api.github.com/users/drewwalters96/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for contributing to Crust firmware!\r\n\r\nPull requests that do not follow the guidelines outlined in the Crust firmware\r\ncontribution guidelines are subject to immediate rejection! -->\r\n\r\n## Purpose\r\n<!-- Please include the purpose of changes included in this pull request. -->\r\nThe purpose of this pull request is to add a common shutdown and suspend procedure that disables unnecessary peripherals before entering a low-power state.\r\n\r\n<!-- Please add the issue number of the issue this pull request addresses. If\r\nthis pull request addresses multiple issues, please add them as a\r\ncomma-separated list (i.e. Closes #1, Closes #2, Fixes #3).\r\n\r\nNOTE: when submitting a bug fix, please uses \"Fixes\" rather than \"Closes\" -->\r\nCloses #39, Closes #40\r\n\r\n## Considerations for reviewers\r\n<!-- (Optional) Include considerations or notes for project maintainers and\r\nreviewers.  -->\r\nNot tested on hardware.","created_at":"2018-04-05T21:04:40Z","updated_at":"2018-04-10T13:30:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e296e07ceaed446bb37b5a89dba60d069fa2e3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"agom94","id":18688003,"avatar_url":"https://avatars0.githubusercontent.com/u/18688003?v=4","gravatar_id":"","url":"https://api.github.com/users/agom94","html_url":"https://github.com/agom94","followers_url":"https://api.github.com/users/agom94/followers","following_url":"https://api.github.com/users/agom94/following{/other_user}","gists_url":"https://api.github.com/users/agom94/gists{/gist_id}","starred_url":"https://api.github.com/users/agom94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agom94/subscriptions","organizations_url":"https://api.github.com/users/agom94/orgs","repos_url":"https://api.github.com/users/agom94/repos","events_url":"https://api.github.com/users/agom94/events{/privacy}","received_events_url":"https://api.github.com/users/agom94/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":819247003,"url":"https://api.github.com/repos/crust-firmware/crust/labels/A-common","name":"A-common","color":"fbca04","default":false},{"id":819243806,"url":"https://api.github.com/repos/crust-firmware/crust/labels/A-drivers","name":"A-drivers","color":"fbca04","default":false},{"id":819273767,"url":"https://api.github.com/repos/crust-firmware/crust/labels/T-required","name":"T-required","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crust-firmware/crust/pulls/132/commits","review_comments_url":"https://api.github.com/repos/crust-firmware/crust/pulls/132/comments","review_comment_url":"https://api.github.com/repos/crust-firmware/crust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crust-firmware/crust/issues/132/comments","statuses_url":"https://api.github.com/repos/crust-firmware/crust/statuses/12e4fa9a5ede70e419499409ff6abba654414cf8","head":{"label":"drewwalters96:common/device-shutdown","ref":"common/device-shutdown","sha":"12e4fa9a5ede70e419499409ff6abba654414cf8","user":{"login":"drewwalters96","id":9168811,"avatar_url":"https://avatars1.githubusercontent.com/u/9168811?v=4","gravatar_id":"","url":"https://api.github.com/users/drewwalters96","html_url":"https://github.com/drewwalters96","followers_url":"https://api.github.com/users/drewwalters96/followers","following_url":"https://api.github.com/users/drewwalters96/following{/other_user}","gists_url":"https://api.github.com/users/drewwalters96/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwalters96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwalters96/subscriptions","organizations_url":"https://api.github.com/users/drewwalters96/orgs","repos_url":"https://api.github.com/users/drewwalters96/repos","events_url":"https://api.github.com/users/drewwalters96/events{/privacy}","received_events_url":"https://api.github.com/users/drewwalters96/received_events","type":"User","site_admin":false},"repo":{"id":116304428,"name":"crust","full_name":"drewwalters96/crust","owner":{"login":"drewwalters96","id":9168811,"avatar_url":"https://avatars1.githubusercontent.com/u/9168811?v=4","gravatar_id":"","url":"https://api.github.com/users/drewwalters96","html_url":"https://github.com/drewwalters96","followers_url":"https://api.github.com/users/drewwalters96/followers","following_url":"https://api.github.com/users/drewwalters96/following{/other_user}","gists_url":"https://api.github.com/users/drewwalters96/gists{/gist_id}","starred_url":"https://api.github.com/users/drewwalters96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewwalters96/subscriptions","organizations_url":"https://api.github.com/users/drewwalters96/orgs","repos_url":"https://api.github.com/users/drewwalters96/repos","events_url":"https://api.github.com/users/drewwalters96/events{/privacy}","received_events_url":"https://api.github.com/users/drewwalters96/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drewwalters96/crust","description":"ARISC firmware for sunxi SoCs","fork":true,"url":"https://api.github.com/repos/drewwalters96/crust","forks_url":"https://api.github.com/repos/drewwalters96/crust/forks","keys_url":"https://api.github.com/repos/drewwalters96/crust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drewwalters96/crust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drewwalters96/crust/teams","hooks_url":"https://api.github.com/repos/drewwalters96/crust/hooks","issue_events_url":"https://api.github.com/repos/drewwalters96/crust/issues/events{/number}","events_url":"https://api.github.com/repos/drewwalters96/crust/events","assignees_url":"https://api.github.com/repos/drewwalters96/crust/assignees{/user}","branches_url":"https://api.github.com/repos/drewwalters96/crust/branches{/branch}","tags_url":"https://api.github.com/repos/drewwalters96/crust/tags","blobs_url":"https://api.github.com/repos/drewwalters96/crust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drewwalters96/crust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drewwalters96/crust/git/refs{/sha}","trees_url":"https://api.github.com/repos/drewwalters96/crust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drewwalters96/crust/statuses/{sha}","languages_url":"https://api.github.com/repos/drewwalters96/crust/languages","stargazers_url":"https://api.github.com/repos/drewwalters96/crust/stargazers","contributors_url":"https://api.github.com/repos/drewwalters96/crust/contributors","subscribers_url":"https://api.github.com/repos/drewwalters96/crust/subscribers","subscription_url":"https://api.github.com/repos/drewwalters96/crust/subscription","commits_url":"https://api.github.com/repos/drewwalters96/crust/commits{/sha}","git_commits_url":"https://api.github.com/repos/drewwalters96/crust/git/commits{/sha}","comments_url":"https://api.github.com/repos/drewwalters96/crust/comments{/number}","issue_comment_url":"https://api.github.com/repos/drewwalters96/crust/issues/comments{/number}","contents_url":"https://api.github.com/repos/drewwalters96/crust/contents/{+path}","compare_url":"https://api.github.com/repos/drewwalters96/crust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drewwalters96/crust/merges","archive_url":"https://api.github.com/repos/drewwalters96/crust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drewwalters96/crust/downloads","issues_url":"https://api.github.com/repos/drewwalters96/crust/issues{/number}","pulls_url":"https://api.github.com/repos/drewwalters96/crust/pulls{/number}","milestones_url":"https://api.github.com/repos/drewwalters96/crust/milestones{/number}","notifications_url":"https://api.github.com/repos/drewwalters96/crust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drewwalters96/crust/labels{/name}","releases_url":"https://api.github.com/repos/drewwalters96/crust/releases{/id}","deployments_url":"https://api.github.com/repos/drewwalters96/crust/deployments","created_at":"2018-01-04T20:28:01Z","updated_at":"2018-04-08T22:04:54Z","pushed_at":"2018-04-10T02:35:49Z","git_url":"git://github.com/drewwalters96/crust.git","ssh_url":"git@github.com:drewwalters96/crust.git","clone_url":"https://github.com/drewwalters96/crust.git","svn_url":"https://github.com/drewwalters96/crust","homepage":null,"size":369,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crust-firmware:master","ref":"master","sha":"75c620c82dec5090859cff30b7ec0422f607daf3","user":{"login":"crust-firmware","id":34251778,"avatar_url":"https://avatars1.githubusercontent.com/u/34251778?v=4","gravatar_id":"","url":"https://api.github.com/users/crust-firmware","html_url":"https://github.com/crust-firmware","followers_url":"https://api.github.com/users/crust-firmware/followers","following_url":"https://api.github.com/users/crust-firmware/following{/other_user}","gists_url":"https://api.github.com/users/crust-firmware/gists{/gist_id}","starred_url":"https://api.github.com/users/crust-firmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crust-firmware/subscriptions","organizations_url":"https://api.github.com/users/crust-firmware/orgs","repos_url":"https://api.github.com/users/crust-firmware/repos","events_url":"https://api.github.com/users/crust-firmware/events{/privacy}","received_events_url":"https://api.github.com/users/crust-firmware/received_events","type":"Organization","site_admin":false},"repo":{"id":114480237,"name":"crust","full_name":"crust-firmware/crust","owner":{"login":"crust-firmware","id":34251778,"avatar_url":"https://avatars1.githubusercontent.com/u/34251778?v=4","gravatar_id":"","url":"https://api.github.com/users/crust-firmware","html_url":"https://github.com/crust-firmware","followers_url":"https://api.github.com/users/crust-firmware/followers","following_url":"https://api.github.com/users/crust-firmware/following{/other_user}","gists_url":"https://api.github.com/users/crust-firmware/gists{/gist_id}","starred_url":"https://api.github.com/users/crust-firmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crust-firmware/subscriptions","organizations_url":"https://api.github.com/users/crust-firmware/orgs","repos_url":"https://api.github.com/users/crust-firmware/repos","events_url":"https://api.github.com/users/crust-firmware/events{/privacy}","received_events_url":"https://api.github.com/users/crust-firmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crust-firmware/crust","description":"ARISC firmware for sunxi SoCs","fork":false,"url":"https://api.github.com/repos/crust-firmware/crust","forks_url":"https://api.github.com/repos/crust-firmware/crust/forks","keys_url":"https://api.github.com/repos/crust-firmware/crust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crust-firmware/crust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crust-firmware/crust/teams","hooks_url":"https://api.github.com/repos/crust-firmware/crust/hooks","issue_events_url":"https://api.github.com/repos/crust-firmware/crust/issues/events{/number}","events_url":"https://api.github.com/repos/crust-firmware/crust/events","assignees_url":"https://api.github.com/repos/crust-firmware/crust/assignees{/user}","branches_url":"https://api.github.com/repos/crust-firmware/crust/branches{/branch}","tags_url":"https://api.github.com/repos/crust-firmware/crust/tags","blobs_url":"https://api.github.com/repos/crust-firmware/crust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crust-firmware/crust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crust-firmware/crust/git/refs{/sha}","trees_url":"https://api.github.com/repos/crust-firmware/crust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crust-firmware/crust/statuses/{sha}","languages_url":"https://api.github.com/repos/crust-firmware/crust/languages","stargazers_url":"https://api.github.com/repos/crust-firmware/crust/stargazers","contributors_url":"https://api.github.com/repos/crust-firmware/crust/contributors","subscribers_url":"https://api.github.com/repos/crust-firmware/crust/subscribers","subscription_url":"https://api.github.com/repos/crust-firmware/crust/subscription","commits_url":"https://api.github.com/repos/crust-firmware/crust/commits{/sha}","git_commits_url":"https://api.github.com/repos/crust-firmware/crust/git/commits{/sha}","comments_url":"https://api.github.com/repos/crust-firmware/crust/comments{/number}","issue_comment_url":"https://api.github.com/repos/crust-firmware/crust/issues/comments{/number}","contents_url":"https://api.github.com/repos/crust-firmware/crust/contents/{+path}","compare_url":"https://api.github.com/repos/crust-firmware/crust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crust-firmware/crust/merges","archive_url":"https://api.github.com/repos/crust-firmware/crust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crust-firmware/crust/downloads","issues_url":"https://api.github.com/repos/crust-firmware/crust/issues{/number}","pulls_url":"https://api.github.com/repos/crust-firmware/crust/pulls{/number}","milestones_url":"https://api.github.com/repos/crust-firmware/crust/milestones{/number}","notifications_url":"https://api.github.com/repos/crust-firmware/crust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crust-firmware/crust/labels{/name}","releases_url":"https://api.github.com/repos/crust-firmware/crust/releases{/id}","deployments_url":"https://api.github.com/repos/crust-firmware/crust/deployments","created_at":"2017-12-16T18:00:03Z","updated_at":"2018-04-10T05:17:35Z","pushed_at":"2018-04-10T05:29:05Z","git_url":"git://github.com/crust-firmware/crust.git","ssh_url":"git@github.com:crust-firmware/crust.git","clone_url":"https://github.com/crust-firmware/crust.git","svn_url":"https://github.com/crust-firmware/crust","homepage":null,"size":344,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":29,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crust-firmware/crust/pulls/132"},"html":{"href":"https://github.com/crust-firmware/crust/pull/132"},"issue":{"href":"https://api.github.com/repos/crust-firmware/crust/issues/132"},"comments":{"href":"https://api.github.com/repos/crust-firmware/crust/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/crust-firmware/crust/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/crust-firmware/crust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crust-firmware/crust/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/crust-firmware/crust/statuses/12e4fa9a5ede70e419499409ff6abba654414cf8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"drewwalters96"}}