{"action":"opened","issue":{"url":"https://api.github.com/repos/pynucastro/pynucastro/issues/46","repository_url":"https://api.github.com/repos/pynucastro/pynucastro","labels_url":"https://api.github.com/repos/pynucastro/pynucastro/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/pynucastro/pynucastro/issues/46/comments","events_url":"https://api.github.com/repos/pynucastro/pynucastro/issues/46/events","html_url":"https://github.com/pynucastro/pynucastro/issues/46","id":302935659,"number":46,"title":"Treatment of reverse rates from REACLIB","user":{"login":"jschwab","id":772632,"avatar_url":"https://avatars2.githubusercontent.com/u/772632?v=4","gravatar_id":"","url":"https://api.github.com/users/jschwab","html_url":"https://github.com/jschwab","followers_url":"https://api.github.com/users/jschwab/followers","following_url":"https://api.github.com/users/jschwab/following{/other_user}","gists_url":"https://api.github.com/users/jschwab/gists{/gist_id}","starred_url":"https://api.github.com/users/jschwab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschwab/subscriptions","organizations_url":"https://api.github.com/users/jschwab/orgs","repos_url":"https://api.github.com/users/jschwab/repos","events_url":"https://api.github.com/users/jschwab/events{/privacy}","received_events_url":"https://api.github.com/users/jschwab/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-07T01:54:09Z","updated_at":"2018-03-07T01:54:09Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In `examples/library-filtering-examples.ipynb` it says:\r\n\r\n> Note that at this time pynucastro has not yet implemented nuclear partition functions, so these reverse rates are calculated only from detailed balance in the Reaclib library.\r\n\r\nThis seems like a limitation that should likely be documented more prominently.\r\n\r\nThe front of the [REACLIB webpage](https://groups.nscl.msu.edu/jina/reaclib/db/index.php) says:\r\n\r\n> How are reverse rates calculated? or What does the \"v\" flag mean?\r\n> * The \"v\" flag in REACLIB format, identifies \"reverse\" rates\r\n> * \"Reverse\" rates are calculated via detailed balance (without partition functions)\r\n> * Therefore, rates with this flag must be corrected to include partition function modifications.\r\n\r\nSo unless I misunderstand, that means pynucastro isn't correctly applying REACLIB for reverse rates.\r\n\r\n[Rauscher & Thielemann](http://adsabs.harvard.edu/abs/2000ADNDT..75....1R) give the advice that if you want to integrate reaction networks -- which is one of the stated applications for the pynucastro-generated code -- that the best practice is to calculate the reverse rate from the forward rate via detailed balance, including the partition functions.  They state that the consistency this gives you is \"essential for application in astrophysical reaction networks\" (Sec 3.2).\r\n\r\nI don't necessarily see this as a blocker for acceptance, but I do want agree on how to present this choice and also hear your thoughts on the way forward.\r\n\r\n"}}
{"actor":{"display_login":"jschwab"}}