{"action":"created","comment":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/comments/218375158","pull_request_review_id":156296449,"id":218375158,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODM3NTE1OA==","diff_hunk":"@@ -158,6 +164,11 @@ private MediaCodecInfo(\n     adaptive = !forceDisableAdaptive && capabilities != null && isAdaptive(capabilities);\n     tunneling = capabilities != null && isTunneling(capabilities);\n     secure = forceSecure || (capabilities != null && isSecure(capabilities));\n+    if (!name.toLowerCase().startsWith(\"omx.google.\")) {","path":"library/core/src/main/java/com/google/android/exoplayer2/mediacodec/MediaCodecInfo.java","position":17,"original_position":17,"commit_id":"3f85d246e1c89452513e06451998e99f61d5ed88","original_commit_id":"61a88c94167c7eded22a35fbcf4f3b4cfa5f4dad","user":{"login":"ojw28","id":7881572,"node_id":"MDQ6VXNlcjc4ODE1NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/7881572?v=4","gravatar_id":"","url":"https://api.github.com/users/ojw28","html_url":"https://github.com/ojw28","followers_url":"https://api.github.com/users/ojw28/followers","following_url":"https://api.github.com/users/ojw28/following{/other_user}","gists_url":"https://api.github.com/users/ojw28/gists{/gist_id}","starred_url":"https://api.github.com/users/ojw28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojw28/subscriptions","organizations_url":"https://api.github.com/users/ojw28/orgs","repos_url":"https://api.github.com/users/ojw28/repos","events_url":"https://api.github.com/users/ojw28/events{/privacy}","received_events_url":"https://api.github.com/users/ojw28/received_events","type":"User","site_admin":false},"body":"ExoPlayer is highly extensible, and YouTube have exploited this to customize behavior to suit there needs. So you shouldn't expect them to behave in exactly the same way.\r\n\r\nIt probably wont always make sense to select VP9 over H264. There are quite a few factors to consider. It's much harder for us to implement a generic track selection algorithm that'll be optimal for all use cases, than it is for YouTube to implement it for just their specific use case, with knowledge of things like the transcodes they generate etc. Hence for large streaming services it often makes sense to provide some custom components for ExoPlayer, such as a custom `TrackSelector`.\r\n\r\nThat said, there's probably room for improvement in our `DefaultTrackSelector` logic. For example if the not-quite-accurate hardware check indicates both codecs are supported by hardware, and all other things are equal, then it would indeed make sense to default to VP9 (ditto for H265). I've filed #4835 to track this.","created_at":"2018-09-18T10:15:25Z","updated_at":"2018-09-18T10:15:25Z","html_url":"https://github.com/google/ExoPlayer/pull/4833#discussion_r218375158","pull_request_url":"https://api.github.com/repos/google/ExoPlayer/pulls/4833","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/comments/218375158"},"html":{"href":"https://github.com/google/ExoPlayer/pull/4833#discussion_r218375158"},"pull_request":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/4833"}},"in_reply_to_id":218329364},"pull_request":{"url":"https://api.github.com/repos/google/ExoPlayer/pulls/4833","id":216211903,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjExOTAz","html_url":"https://github.com/google/ExoPlayer/pull/4833","diff_url":"https://github.com/google/ExoPlayer/pull/4833.diff","patch_url":"https://github.com/google/ExoPlayer/pull/4833.patch","issue_url":"https://api.github.com/repos/google/ExoPlayer/issues/4833","number":4833,"state":"closed","locked":false,"title":"Hardware support flag","user":{"login":"manishPatwari","id":11611899,"node_id":"MDQ6VXNlcjExNjExODk5","avatar_url":"https://avatars3.githubusercontent.com/u/11611899?v=4","gravatar_id":"","url":"https://api.github.com/users/manishPatwari","html_url":"https://github.com/manishPatwari","followers_url":"https://api.github.com/users/manishPatwari/followers","following_url":"https://api.github.com/users/manishPatwari/following{/other_user}","gists_url":"https://api.github.com/users/manishPatwari/gists{/gist_id}","starred_url":"https://api.github.com/users/manishPatwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishPatwari/subscriptions","organizations_url":"https://api.github.com/users/manishPatwari/orgs","repos_url":"https://api.github.com/users/manishPatwari/repos","events_url":"https://api.github.com/users/manishPatwari/events{/privacy}","received_events_url":"https://api.github.com/users/manishPatwari/received_events","type":"User","site_admin":false},"body":"Added \"isHardwareSupported\" flag in MediaCodecInfo. This flag I have added here because MediaCodecInfo is cache and its been used multiple time. I have written TrackSelector which will select MediaCodecInfo if its Hardware supproted.","created_at":"2018-09-18T07:44:06Z","updated_at":"2018-09-18T10:15:25Z","closed_at":"2018-09-18T07:52:27Z","merged_at":null,"merge_commit_sha":"25123f2f4835d588a16d74ef70970162f5736f6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":278711129,"node_id":"MDU6TGFiZWwyNzg3MTExMjk=","url":"https://api.github.com/repos/google/ExoPlayer/labels/cla:%20no","name":"cla: no","color":"fc2929","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/google/ExoPlayer/pulls/4833/commits","review_comments_url":"https://api.github.com/repos/google/ExoPlayer/pulls/4833/comments","review_comment_url":"https://api.github.com/repos/google/ExoPlayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ExoPlayer/issues/4833/comments","statuses_url":"https://api.github.com/repos/google/ExoPlayer/statuses/3f85d246e1c89452513e06451998e99f61d5ed88","head":{"label":"manishPatwari:hardwareSupportFlag","ref":"hardwareSupportFlag","sha":"3f85d246e1c89452513e06451998e99f61d5ed88","user":{"login":"manishPatwari","id":11611899,"node_id":"MDQ6VXNlcjExNjExODk5","avatar_url":"https://avatars3.githubusercontent.com/u/11611899?v=4","gravatar_id":"","url":"https://api.github.com/users/manishPatwari","html_url":"https://github.com/manishPatwari","followers_url":"https://api.github.com/users/manishPatwari/followers","following_url":"https://api.github.com/users/manishPatwari/following{/other_user}","gists_url":"https://api.github.com/users/manishPatwari/gists{/gist_id}","starred_url":"https://api.github.com/users/manishPatwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishPatwari/subscriptions","organizations_url":"https://api.github.com/users/manishPatwari/orgs","repos_url":"https://api.github.com/users/manishPatwari/repos","events_url":"https://api.github.com/users/manishPatwari/events{/privacy}","received_events_url":"https://api.github.com/users/manishPatwari/received_events","type":"User","site_admin":false},"repo":{"id":149106717,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxMDY3MTc=","name":"ExoPlayer","full_name":"manishPatwari/ExoPlayer","private":false,"owner":{"login":"manishPatwari","id":11611899,"node_id":"MDQ6VXNlcjExNjExODk5","avatar_url":"https://avatars3.githubusercontent.com/u/11611899?v=4","gravatar_id":"","url":"https://api.github.com/users/manishPatwari","html_url":"https://github.com/manishPatwari","followers_url":"https://api.github.com/users/manishPatwari/followers","following_url":"https://api.github.com/users/manishPatwari/following{/other_user}","gists_url":"https://api.github.com/users/manishPatwari/gists{/gist_id}","starred_url":"https://api.github.com/users/manishPatwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishPatwari/subscriptions","organizations_url":"https://api.github.com/users/manishPatwari/orgs","repos_url":"https://api.github.com/users/manishPatwari/repos","events_url":"https://api.github.com/users/manishPatwari/events{/privacy}","received_events_url":"https://api.github.com/users/manishPatwari/received_events","type":"User","site_admin":false},"html_url":"https://github.com/manishPatwari/ExoPlayer","description":"An extensible media player for Android","fork":true,"url":"https://api.github.com/repos/manishPatwari/ExoPlayer","forks_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/forks","keys_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/teams","hooks_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/hooks","issue_events_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/events","assignees_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/tags","blobs_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/languages","stargazers_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/stargazers","contributors_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/contributors","subscribers_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/subscribers","subscription_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/subscription","commits_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/merges","archive_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/downloads","issues_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/labels{/name}","releases_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/releases{/id}","deployments_url":"https://api.github.com/repos/manishPatwari/ExoPlayer/deployments","created_at":"2018-09-17T10:11:57Z","updated_at":"2018-09-17T10:12:04Z","pushed_at":"2018-09-18T07:45:17Z","git_url":"git://github.com/manishPatwari/ExoPlayer.git","ssh_url":"git@github.com:manishPatwari/ExoPlayer.git","clone_url":"https://github.com/manishPatwari/ExoPlayer.git","svn_url":"https://github.com/manishPatwari/ExoPlayer","homepage":"","size":77850,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"release-v2"}},"base":{"label":"google:dev-v2","ref":"dev-v2","sha":"b09e36dcb7c3ebd992407ba6a844353177f30ed3","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20818126,"node_id":"MDEwOlJlcG9zaXRvcnkyMDgxODEyNg==","name":"ExoPlayer","full_name":"google/ExoPlayer","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/ExoPlayer","description":"An extensible media player for Android","fork":false,"url":"https://api.github.com/repos/google/ExoPlayer","forks_url":"https://api.github.com/repos/google/ExoPlayer/forks","keys_url":"https://api.github.com/repos/google/ExoPlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ExoPlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ExoPlayer/teams","hooks_url":"https://api.github.com/repos/google/ExoPlayer/hooks","issue_events_url":"https://api.github.com/repos/google/ExoPlayer/issues/events{/number}","events_url":"https://api.github.com/repos/google/ExoPlayer/events","assignees_url":"https://api.github.com/repos/google/ExoPlayer/assignees{/user}","branches_url":"https://api.github.com/repos/google/ExoPlayer/branches{/branch}","tags_url":"https://api.github.com/repos/google/ExoPlayer/tags","blobs_url":"https://api.github.com/repos/google/ExoPlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ExoPlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ExoPlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ExoPlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ExoPlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ExoPlayer/languages","stargazers_url":"https://api.github.com/repos/google/ExoPlayer/stargazers","contributors_url":"https://api.github.com/repos/google/ExoPlayer/contributors","subscribers_url":"https://api.github.com/repos/google/ExoPlayer/subscribers","subscription_url":"https://api.github.com/repos/google/ExoPlayer/subscription","commits_url":"https://api.github.com/repos/google/ExoPlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ExoPlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ExoPlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ExoPlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ExoPlayer/contents/{+path}","compare_url":"https://api.github.com/repos/google/ExoPlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ExoPlayer/merges","archive_url":"https://api.github.com/repos/google/ExoPlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ExoPlayer/downloads","issues_url":"https://api.github.com/repos/google/ExoPlayer/issues{/number}","pulls_url":"https://api.github.com/repos/google/ExoPlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ExoPlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ExoPlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ExoPlayer/labels{/name}","releases_url":"https://api.github.com/repos/google/ExoPlayer/releases{/id}","deployments_url":"https://api.github.com/repos/google/ExoPlayer/deployments","created_at":"2014-06-13T21:19:18Z","updated_at":"2018-09-18T08:27:49Z","pushed_at":"2018-09-18T07:45:19Z","git_url":"git://github.com/google/ExoPlayer.git","ssh_url":"git@github.com:google/ExoPlayer.git","clone_url":"https://github.com/google/ExoPlayer.git","svn_url":"https://github.com/google/ExoPlayer","homepage":"","size":77950,"stargazers_count":11140,"watchers_count":11140,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3460,"mirror_url":null,"archived":false,"open_issues_count":284,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3460,"open_issues":284,"watchers":11140,"default_branch":"release-v2"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/4833"},"html":{"href":"https://github.com/google/ExoPlayer/pull/4833"},"issue":{"href":"https://api.github.com/repos/google/ExoPlayer/issues/4833"},"comments":{"href":"https://api.github.com/repos/google/ExoPlayer/issues/4833/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/4833/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ExoPlayer/pulls/4833/commits"},"statuses":{"href":"https://api.github.com/repos/google/ExoPlayer/statuses/3f85d246e1c89452513e06451998e99f61d5ed88"}},"author_association":"NONE"}}
{"actor":{"display_login":"ojw28"}}