{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/274","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/274/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/274/events","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/274","id":337956758,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDA3ODY1","number":274,"title":"[WIP] Add support for custom endpoint","user":{"login":"djberg96","id":78529,"node_id":"MDQ6VXNlcjc4NTI5","avatar_url":"https://avatars3.githubusercontent.com/u/78529?v=4","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"labels":[{"id":536171837,"node_id":"MDU6TGFiZWw1MzYxNzE4Mzc=","url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/labels/wip","name":"wip","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-03T15:46:50Z","updated_at":"2018-07-05T19:07:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/pulls/274","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/274","diff_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/274.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/274.patch"},"body":"In order to support the Azure Stack environment we need to allow the users to set a custom endpoint since the default environments will not work. With the help of automatic discovery baked into the azure-armrest gem, we can support this fairly easily. If no endpoint is set then it simply defaults to finding the environment based on region as before.\r\n\r\nPartially addresses https://bugzilla.redhat.com/show_bug.cgi?id=1594381\r\n\r\nWe will still need a modification on the UI side as well.\r\n\r\nWIP for now until I add some specs."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/comments/402823315","html_url":"https://github.com/ManageIQ/manageiq-providers-azure/pull/274#issuecomment-402823315","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-azure/issues/274","id":402823315,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjgyMzMxNQ==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T19:07:47Z","updated_at":"2018-07-05T19:07:47Z","author_association":"MEMBER","body":"<rubocop />Checked commit https://github.com/djberg96/manageiq-providers-azure/commit/71ac9c49d998b0d4e73c6009e7f038b43b79f2f3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n3 files checked, 1 offense detected\n\n**app/models/manageiq/providers/azure/manager_mixin.rb**\n- [ ] :exclamation: - [Line 29](https://github.com/djberg96/manageiq-providers-azure/blob/71ac9c49d998b0d4e73c6009e7f038b43b79f2f3/app/models/manageiq/providers/azure/manager_mixin.rb#L29), Col 10 - [Style/SafeNavigation](http://rubydoc.info/gems/rubocop/0.52.1/RuboCop/Cop/Style/SafeNavigation) - Use safe navigation (`&.`) instead of checking if an object exists before calling the method.\n"}}
{"actor":{"display_login":"miq-bot"}}