{"action":"created","comment":{"url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments/231097053","pull_request_review_id":171984523,"id":231097053,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTA5NzA1Mw==","diff_hunk":"@@ -93,17 +86,14 @@ private void getServicesGuids(List<String> servicesToDeleteNames, ExecutionWrapp\n     }\r\n \r\n     private void validateGuidMapping(List<String> servicesToDelete, Map<String, String> serviceGuids, ExecutionWrapper execution) {\r\n-        servicesToDelete.stream()\r\n+        List<String> servicesWithoutGuid = servicesToDelete.stream()\r\n             .filter(name -> serviceGuids.get(name) == null)\r\n-            .forEach(invalidEntry -> execution.getStepLogger()\r\n-                .error(Messages.ERROR_MAPPING_SERVICE_NAME_TO_GUID, invalidEntry));\r\n+            .collect(Collectors.toList());\r\n \r\n-        Optional<String> firstServiceWithoutGuid = servicesToDelete.stream()\r\n-            .filter(name -> serviceGuids.get(name) == null)\r\n-            .findFirst();\r\n+        String names = String.join(\",\", servicesWithoutGuid);\r","path":"com.sap.cloud.lm.sl.cf.process/src/main/java/com/sap/cloud/lm/sl/cf/process/steps/DeleteServicesStep.java","position":92,"original_position":66,"commit_id":"0c939e4a13c273579e04cf5f211251198683c62d","original_commit_id":"0c939e4a13c273579e04cf5f211251198683c62d","user":{"login":"enchobelezirev","id":9638278,"node_id":"MDQ6VXNlcjk2MzgyNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/9638278?v=4","gravatar_id":"","url":"https://api.github.com/users/enchobelezirev","html_url":"https://github.com/enchobelezirev","followers_url":"https://api.github.com/users/enchobelezirev/followers","following_url":"https://api.github.com/users/enchobelezirev/following{/other_user}","gists_url":"https://api.github.com/users/enchobelezirev/gists{/gist_id}","starred_url":"https://api.github.com/users/enchobelezirev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enchobelezirev/subscriptions","organizations_url":"https://api.github.com/users/enchobelezirev/orgs","repos_url":"https://api.github.com/users/enchobelezirev/repos","events_url":"https://api.github.com/users/enchobelezirev/events{/privacy}","received_events_url":"https://api.github.com/users/enchobelezirev/received_events","type":"User","site_admin":false},"body":"Could you remove this?\r\nAnd on line 96 to do: throw new SLException(Messages.ERROR_MAPPING_SERVICE_NAMES_TO_GUIDS, String.join(\",\", servicesWithoutGuid););","created_at":"2018-11-06T12:04:40Z","updated_at":"2018-11-06T12:06:23Z","html_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/302#discussion_r231097053","pull_request_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments/231097053"},"html":{"href":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/302#discussion_r231097053"},"pull_request":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302","id":225360345,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzYwMzQ1","html_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/302","diff_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/302.diff","patch_url":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/302.patch","issue_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/302","number":302,"state":"open","locked":false,"title":"Poll async service deletions","user":{"login":"petko-boyadzhiev","id":43955302,"node_id":"MDQ6VXNlcjQzOTU1MzAy","avatar_url":"https://avatars2.githubusercontent.com/u/43955302?v=4","gravatar_id":"","url":"https://api.github.com/users/petko-boyadzhiev","html_url":"https://github.com/petko-boyadzhiev","followers_url":"https://api.github.com/users/petko-boyadzhiev/followers","following_url":"https://api.github.com/users/petko-boyadzhiev/following{/other_user}","gists_url":"https://api.github.com/users/petko-boyadzhiev/gists{/gist_id}","starred_url":"https://api.github.com/users/petko-boyadzhiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petko-boyadzhiev/subscriptions","organizations_url":"https://api.github.com/users/petko-boyadzhiev/orgs","repos_url":"https://api.github.com/users/petko-boyadzhiev/repos","events_url":"https://api.github.com/users/petko-boyadzhiev/events{/privacy}","received_events_url":"https://api.github.com/users/petko-boyadzhiev/received_events","type":"User","site_admin":false},"body":"#### Description: \r\nCurrently, all processes that include deletion of services only just trigger the deletion without waiting for those deletions to finish. This could cause problems if the user then attempts to redeploy the same MTA immediately after the process finishes. \r\n\r\nThis pull request adopts an already established (in the current BPMN) polling mechanism for waiting for the actual service deletion.\r\n#### Issue: LMCROSSITXSADEPLOY-498\r\n\r\n","created_at":"2018-10-24T11:10:23Z","updated_at":"2018-11-06T12:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3abe6d554ee5af9f4345a3a5e07d86c5f428a92c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nictas","id":16129525,"node_id":"MDQ6VXNlcjE2MTI5NTI1","avatar_url":"https://avatars3.githubusercontent.com/u/16129525?v=4","gravatar_id":"","url":"https://api.github.com/users/nictas","html_url":"https://github.com/nictas","followers_url":"https://api.github.com/users/nictas/followers","following_url":"https://api.github.com/users/nictas/following{/other_user}","gists_url":"https://api.github.com/users/nictas/gists{/gist_id}","starred_url":"https://api.github.com/users/nictas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nictas/subscriptions","organizations_url":"https://api.github.com/users/nictas/orgs","repos_url":"https://api.github.com/users/nictas/repos","events_url":"https://api.github.com/users/nictas/events{/privacy}","received_events_url":"https://api.github.com/users/nictas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302/commits","review_comments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302/comments","review_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/302/comments","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/statuses/0c939e4a13c273579e04cf5f211251198683c62d","head":{"label":"petko-boyadzhiev:poll-async-service-deletions","ref":"poll-async-service-deletions","sha":"0c939e4a13c273579e04cf5f211251198683c62d","user":{"login":"petko-boyadzhiev","id":43955302,"node_id":"MDQ6VXNlcjQzOTU1MzAy","avatar_url":"https://avatars2.githubusercontent.com/u/43955302?v=4","gravatar_id":"","url":"https://api.github.com/users/petko-boyadzhiev","html_url":"https://github.com/petko-boyadzhiev","followers_url":"https://api.github.com/users/petko-boyadzhiev/followers","following_url":"https://api.github.com/users/petko-boyadzhiev/following{/other_user}","gists_url":"https://api.github.com/users/petko-boyadzhiev/gists{/gist_id}","starred_url":"https://api.github.com/users/petko-boyadzhiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petko-boyadzhiev/subscriptions","organizations_url":"https://api.github.com/users/petko-boyadzhiev/orgs","repos_url":"https://api.github.com/users/petko-boyadzhiev/repos","events_url":"https://api.github.com/users/petko-boyadzhiev/events{/privacy}","received_events_url":"https://api.github.com/users/petko-boyadzhiev/received_events","type":"User","site_admin":false},"repo":{"id":152228304,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyMjgzMDQ=","name":"multiapps-controller","full_name":"petko-boyadzhiev/multiapps-controller","private":false,"owner":{"login":"petko-boyadzhiev","id":43955302,"node_id":"MDQ6VXNlcjQzOTU1MzAy","avatar_url":"https://avatars2.githubusercontent.com/u/43955302?v=4","gravatar_id":"","url":"https://api.github.com/users/petko-boyadzhiev","html_url":"https://github.com/petko-boyadzhiev","followers_url":"https://api.github.com/users/petko-boyadzhiev/followers","following_url":"https://api.github.com/users/petko-boyadzhiev/following{/other_user}","gists_url":"https://api.github.com/users/petko-boyadzhiev/gists{/gist_id}","starred_url":"https://api.github.com/users/petko-boyadzhiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petko-boyadzhiev/subscriptions","organizations_url":"https://api.github.com/users/petko-boyadzhiev/orgs","repos_url":"https://api.github.com/users/petko-boyadzhiev/repos","events_url":"https://api.github.com/users/petko-boyadzhiev/events{/privacy}","received_events_url":"https://api.github.com/users/petko-boyadzhiev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/petko-boyadzhiev/multiapps-controller","description":"The server side component (controller) for Multi-Target Application (MTA) for Cloud Foundry","fork":true,"url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller","forks_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/forks","keys_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/teams","hooks_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/hooks","issue_events_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/issues/events{/number}","events_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/events","assignees_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/assignees{/user}","branches_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/branches{/branch}","tags_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/tags","blobs_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/languages","stargazers_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/stargazers","contributors_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/contributors","subscribers_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/subscribers","subscription_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/subscription","commits_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/contents/{+path}","compare_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/merges","archive_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/downloads","issues_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/issues{/number}","pulls_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/labels{/name}","releases_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/releases{/id}","deployments_url":"https://api.github.com/repos/petko-boyadzhiev/multiapps-controller/deployments","created_at":"2018-10-09T09:56:52Z","updated_at":"2018-10-09T09:56:57Z","pushed_at":"2018-11-06T11:54:37Z","git_url":"git://github.com/petko-boyadzhiev/multiapps-controller.git","ssh_url":"git@github.com:petko-boyadzhiev/multiapps-controller.git","clone_url":"https://github.com/petko-boyadzhiev/multiapps-controller.git","svn_url":"https://github.com/petko-boyadzhiev/multiapps-controller","homepage":"","size":31067,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudfoundry-incubator:master","ref":"master","sha":"5aaee25f0ab4048c89034dbb3f5fb4a9a21cd152","user":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":105860042,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4NjAwNDI=","name":"multiapps-controller","full_name":"cloudfoundry-incubator/multiapps-controller","private":false,"owner":{"login":"cloudfoundry-incubator","id":5680605,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5680605?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudfoundry-incubator","html_url":"https://github.com/cloudfoundry-incubator","followers_url":"https://api.github.com/users/cloudfoundry-incubator/followers","following_url":"https://api.github.com/users/cloudfoundry-incubator/following{/other_user}","gists_url":"https://api.github.com/users/cloudfoundry-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudfoundry-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudfoundry-incubator/subscriptions","organizations_url":"https://api.github.com/users/cloudfoundry-incubator/orgs","repos_url":"https://api.github.com/users/cloudfoundry-incubator/repos","events_url":"https://api.github.com/users/cloudfoundry-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/cloudfoundry-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudfoundry-incubator/multiapps-controller","description":"The server side component (controller) for Multi-Target Application (MTA) for Cloud Foundry","fork":false,"url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller","forks_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/forks","keys_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/teams","hooks_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/hooks","issue_events_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/events{/number}","events_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/events","assignees_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/assignees{/user}","branches_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/branches{/branch}","tags_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/tags","blobs_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/languages","stargazers_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/stargazers","contributors_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/contributors","subscribers_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/subscribers","subscription_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/subscription","commits_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/contents/{+path}","compare_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/merges","archive_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/downloads","issues_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues{/number}","pulls_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/labels{/name}","releases_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/releases{/id}","deployments_url":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/deployments","created_at":"2017-10-05T07:14:47Z","updated_at":"2018-11-06T09:48:11Z","pushed_at":"2018-11-06T11:54:39Z","git_url":"git://github.com/cloudfoundry-incubator/multiapps-controller.git","ssh_url":"git@github.com:cloudfoundry-incubator/multiapps-controller.git","clone_url":"https://github.com/cloudfoundry-incubator/multiapps-controller.git","svn_url":"https://github.com/cloudfoundry-incubator/multiapps-controller","homepage":"","size":31037,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":11,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302"},"html":{"href":"https://github.com/cloudfoundry-incubator/multiapps-controller/pull/302"},"issue":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/302"},"comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/cloudfoundry-incubator/multiapps-controller/statuses/0c939e4a13c273579e04cf5f211251198683c62d"}},"author_association":"NONE"}}
{"actor":{"display_login":"enchobelezirev"}}