{"action":"created","comment":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/199993539","pull_request_review_id":134220181,"id":199993539,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTk5MzUzOQ==","diff_hunk":"@@ -597,7 +597,8 @@ def simple_hotplug(self, device, monitor, bus=None):\n         \"\"\"\n         self.set_dirty()\n \n-        if isinstance(device, qdevices.QDevice):\n+        if isinstance(device, qdevices.QDevice) and \\\n+                \"bus\" in self.execute_qemu(\"-device %s,?\" % device[\"driver\"]):","path":"virttest/qemu_devices/qcontainer.py","position":6,"original_position":6,"commit_id":"28856e0c09e15fba8e509cfacada23ff12077bcc","original_commit_id":"28856e0c09e15fba8e509cfacada23ff12077bcc","user":{"login":"vivianQizhu","id":15028109,"node_id":"MDQ6VXNlcjE1MDI4MTA5","avatar_url":"https://avatars3.githubusercontent.com/u/15028109?v=4","gravatar_id":"","url":"https://api.github.com/users/vivianQizhu","html_url":"https://github.com/vivianQizhu","followers_url":"https://api.github.com/users/vivianQizhu/followers","following_url":"https://api.github.com/users/vivianQizhu/following{/other_user}","gists_url":"https://api.github.com/users/vivianQizhu/gists{/gist_id}","starred_url":"https://api.github.com/users/vivianQizhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivianQizhu/subscriptions","organizations_url":"https://api.github.com/users/vivianQizhu/orgs","repos_url":"https://api.github.com/users/vivianQizhu/repos","events_url":"https://api.github.com/users/vivianQizhu/events{/privacy}","received_events_url":"https://api.github.com/users/vivianQizhu/received_events","type":"User","site_admin":false},"body":"It looks like `/usr/libexec/qemu-kvm -device ?` will give exactly the device has bus or not.","created_at":"2018-07-04T02:18:00Z","updated_at":"2018-07-04T02:18:01Z","html_url":"https://github.com/avocado-framework/avocado-vt/pull/1646#discussion_r199993539","pull_request_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments/199993539"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/1646#discussion_r199993539"},"pull_request":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646"}},"in_reply_to_id":199991953},"pull_request":{"url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646","id":198836775,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODM2Nzc1","html_url":"https://github.com/avocado-framework/avocado-vt/pull/1646","diff_url":"https://github.com/avocado-framework/avocado-vt/pull/1646.diff","patch_url":"https://github.com/avocado-framework/avocado-vt/pull/1646.patch","issue_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1646","number":1646,"state":"open","locked":false,"title":"qcontainer: Don't set bus for devices which have no 'bus' option","user":{"login":"huangyum","id":14800999,"node_id":"MDQ6VXNlcjE0ODAwOTk5","avatar_url":"https://avatars3.githubusercontent.com/u/14800999?v=4","gravatar_id":"","url":"https://api.github.com/users/huangyum","html_url":"https://github.com/huangyum","followers_url":"https://api.github.com/users/huangyum/followers","following_url":"https://api.github.com/users/huangyum/following{/other_user}","gists_url":"https://api.github.com/users/huangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyum/subscriptions","organizations_url":"https://api.github.com/users/huangyum/orgs","repos_url":"https://api.github.com/users/huangyum/repos","events_url":"https://api.github.com/users/huangyum/events{/privacy}","received_events_url":"https://api.github.com/users/huangyum/received_events","type":"User","site_admin":false},"body":"ID: 1597464\r\nSigned-off-by: Yumei Huang <yuhuang@redhat.com>","created_at":"2018-07-03T02:53:31Z","updated_at":"2018-07-04T02:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54c50ffefe5dca1ec7206cf20f5823d493858d00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646/commits","review_comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646/comments","review_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1646/comments","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/28856e0c09e15fba8e509cfacada23ff12077bcc","head":{"label":"huangyum:bz_1597464","ref":"bz_1597464","sha":"28856e0c09e15fba8e509cfacada23ff12077bcc","user":{"login":"huangyum","id":14800999,"node_id":"MDQ6VXNlcjE0ODAwOTk5","avatar_url":"https://avatars3.githubusercontent.com/u/14800999?v=4","gravatar_id":"","url":"https://api.github.com/users/huangyum","html_url":"https://github.com/huangyum","followers_url":"https://api.github.com/users/huangyum/followers","following_url":"https://api.github.com/users/huangyum/following{/other_user}","gists_url":"https://api.github.com/users/huangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyum/subscriptions","organizations_url":"https://api.github.com/users/huangyum/orgs","repos_url":"https://api.github.com/users/huangyum/repos","events_url":"https://api.github.com/users/huangyum/events{/privacy}","received_events_url":"https://api.github.com/users/huangyum/received_events","type":"User","site_admin":false},"repo":{"id":73053588,"node_id":"MDEwOlJlcG9zaXRvcnk3MzA1MzU4OA==","name":"avocado-vt","full_name":"huangyum/avocado-vt","owner":{"login":"huangyum","id":14800999,"node_id":"MDQ6VXNlcjE0ODAwOTk5","avatar_url":"https://avatars3.githubusercontent.com/u/14800999?v=4","gravatar_id":"","url":"https://api.github.com/users/huangyum","html_url":"https://github.com/huangyum","followers_url":"https://api.github.com/users/huangyum/followers","following_url":"https://api.github.com/users/huangyum/following{/other_user}","gists_url":"https://api.github.com/users/huangyum/gists{/gist_id}","starred_url":"https://api.github.com/users/huangyum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huangyum/subscriptions","organizations_url":"https://api.github.com/users/huangyum/orgs","repos_url":"https://api.github.com/users/huangyum/repos","events_url":"https://api.github.com/users/huangyum/events{/privacy}","received_events_url":"https://api.github.com/users/huangyum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huangyum/avocado-vt","description":"Avocado VT Plugin","fork":true,"url":"https://api.github.com/repos/huangyum/avocado-vt","forks_url":"https://api.github.com/repos/huangyum/avocado-vt/forks","keys_url":"https://api.github.com/repos/huangyum/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huangyum/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huangyum/avocado-vt/teams","hooks_url":"https://api.github.com/repos/huangyum/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/huangyum/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/huangyum/avocado-vt/events","assignees_url":"https://api.github.com/repos/huangyum/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/huangyum/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/huangyum/avocado-vt/tags","blobs_url":"https://api.github.com/repos/huangyum/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huangyum/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huangyum/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/huangyum/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huangyum/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/huangyum/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/huangyum/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/huangyum/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/huangyum/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/huangyum/avocado-vt/subscription","commits_url":"https://api.github.com/repos/huangyum/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/huangyum/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/huangyum/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/huangyum/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/huangyum/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/huangyum/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huangyum/avocado-vt/merges","archive_url":"https://api.github.com/repos/huangyum/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huangyum/avocado-vt/downloads","issues_url":"https://api.github.com/repos/huangyum/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/huangyum/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/huangyum/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/huangyum/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huangyum/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/huangyum/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/huangyum/avocado-vt/deployments","created_at":"2016-11-07T07:39:01Z","updated_at":"2018-07-03T01:58:39Z","pushed_at":"2018-07-03T15:06:03Z","git_url":"git://github.com/huangyum/avocado-vt.git","ssh_url":"git@github.com:huangyum/avocado-vt.git","clone_url":"https://github.com/huangyum/avocado-vt.git","svn_url":"https://github.com/huangyum/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":28157,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avocado-framework:master","ref":"master","sha":"d6550641c6ee638a2dd9f73149291b246270787d","user":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":36371959,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM3MTk1OQ==","name":"avocado-vt","full_name":"avocado-framework/avocado-vt","owner":{"login":"avocado-framework","id":7245719,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDU3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7245719?v=4","gravatar_id":"","url":"https://api.github.com/users/avocado-framework","html_url":"https://github.com/avocado-framework","followers_url":"https://api.github.com/users/avocado-framework/followers","following_url":"https://api.github.com/users/avocado-framework/following{/other_user}","gists_url":"https://api.github.com/users/avocado-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/avocado-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avocado-framework/subscriptions","organizations_url":"https://api.github.com/users/avocado-framework/orgs","repos_url":"https://api.github.com/users/avocado-framework/repos","events_url":"https://api.github.com/users/avocado-framework/events{/privacy}","received_events_url":"https://api.github.com/users/avocado-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avocado-framework/avocado-vt","description":"Avocado VT Plugin","fork":false,"url":"https://api.github.com/repos/avocado-framework/avocado-vt","forks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/forks","keys_url":"https://api.github.com/repos/avocado-framework/avocado-vt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avocado-framework/avocado-vt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avocado-framework/avocado-vt/teams","hooks_url":"https://api.github.com/repos/avocado-framework/avocado-vt/hooks","issue_events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/events{/number}","events_url":"https://api.github.com/repos/avocado-framework/avocado-vt/events","assignees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/assignees{/user}","branches_url":"https://api.github.com/repos/avocado-framework/avocado-vt/branches{/branch}","tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/tags","blobs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/refs{/sha}","trees_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/{sha}","languages_url":"https://api.github.com/repos/avocado-framework/avocado-vt/languages","stargazers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/stargazers","contributors_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contributors","subscribers_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscribers","subscription_url":"https://api.github.com/repos/avocado-framework/avocado-vt/subscription","commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/commits{/sha}","git_commits_url":"https://api.github.com/repos/avocado-framework/avocado-vt/git/commits{/sha}","comments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/comments{/number}","issue_comment_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/comments{/number}","contents_url":"https://api.github.com/repos/avocado-framework/avocado-vt/contents/{+path}","compare_url":"https://api.github.com/repos/avocado-framework/avocado-vt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avocado-framework/avocado-vt/merges","archive_url":"https://api.github.com/repos/avocado-framework/avocado-vt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avocado-framework/avocado-vt/downloads","issues_url":"https://api.github.com/repos/avocado-framework/avocado-vt/issues{/number}","pulls_url":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls{/number}","milestones_url":"https://api.github.com/repos/avocado-framework/avocado-vt/milestones{/number}","notifications_url":"https://api.github.com/repos/avocado-framework/avocado-vt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avocado-framework/avocado-vt/labels{/name}","releases_url":"https://api.github.com/repos/avocado-framework/avocado-vt/releases{/id}","deployments_url":"https://api.github.com/repos/avocado-framework/avocado-vt/deployments","created_at":"2015-05-27T14:22:13Z","updated_at":"2018-07-03T14:11:59Z","pushed_at":"2018-07-03T18:56:23Z","git_url":"git://github.com/avocado-framework/avocado-vt.git","ssh_url":"git@github.com:avocado-framework/avocado-vt.git","clone_url":"https://github.com/avocado-framework/avocado-vt.git","svn_url":"https://github.com/avocado-framework/avocado-vt","homepage":"http://avocado-vt.readthedocs.org/","size":28175,"stargazers_count":34,"watchers_count":34,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":137,"open_issues":128,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646"},"html":{"href":"https://github.com/avocado-framework/avocado-vt/pull/1646"},"issue":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1646"},"comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/issues/1646/comments"},"review_comments":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646/comments"},"review_comment":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/pulls/1646/commits"},"statuses":{"href":"https://api.github.com/repos/avocado-framework/avocado-vt/statuses/28856e0c09e15fba8e509cfacada23ff12077bcc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vivianQizhu"}}