{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/comments/179720802","pull_request_review_id":110018604,"id":179720802,"diff_hunk":"@@ -79,9 +98,12 @@ func routes(host string, router *mux.Router, dataStore DataStore, outputQueue Ou\n \tapi.router.HandleFunc(\"/filters/{filter_blueprint_id}/dimensions/{name}/options/{option}\", api.removeFilterBlueprintDimensionOption).Methods(\"DELETE\")\n \n \tapi.router.HandleFunc(\"/filter-outputs/{filter_output_id}\", api.getFilterOutput).Methods(\"GET\")\n-\tapi.router.HandleFunc(\"/filter-outputs/{filter_output_id}\", api.updateFilterOutput).Methods(\"PUT\")\n \tapi.router.HandleFunc(\"/filter-outputs/{filter_output_id}/preview\", api.getFilterOutputPreview).Methods(\"GET\")","path":"api/api.go","position":54,"original_position":54,"commit_id":"c035eccb351cda993962fb3308ce07c013fb1a50","original_commit_id":"c035eccb351cda993962fb3308ce07c013fb1a50","user":{"login":"CarlHembrough","id":1786012,"avatar_url":"https://avatars0.githubusercontent.com/u/1786012?v=4","gravatar_id":"","url":"https://api.github.com/users/CarlHembrough","html_url":"https://github.com/CarlHembrough","followers_url":"https://api.github.com/users/CarlHembrough/followers","following_url":"https://api.github.com/users/CarlHembrough/following{/other_user}","gists_url":"https://api.github.com/users/CarlHembrough/gists{/gist_id}","starred_url":"https://api.github.com/users/CarlHembrough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarlHembrough/subscriptions","organizations_url":"https://api.github.com/users/CarlHembrough/orgs","repos_url":"https://api.github.com/users/CarlHembrough/repos","events_url":"https://api.github.com/users/CarlHembrough/events{/privacy}","received_events_url":"https://api.github.com/users/CarlHembrough/received_events","type":"User","site_admin":false},"body":"I don't think so - I believe this is the preview of the first 20 rows of data, so would be available for both","created_at":"2018-04-06T10:41:01Z","updated_at":"2018-04-06T10:41:02Z","html_url":"https://github.com/ONSdigital/dp-filter-api/pull/67#discussion_r179720802","pull_request_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/comments/179720802"},"html":{"href":"https://github.com/ONSdigital/dp-filter-api/pull/67#discussion_r179720802"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67"}},"in_reply_to_id":179530079},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67","id":179689259,"html_url":"https://github.com/ONSdigital/dp-filter-api/pull/67","diff_url":"https://github.com/ONSdigital/dp-filter-api/pull/67.diff","patch_url":"https://github.com/ONSdigital/dp-filter-api/pull/67.patch","issue_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/67","number":67,"state":"open","locked":false,"title":"Feature/disable private endpoints","user":{"login":"CarlHembrough","id":1786012,"avatar_url":"https://avatars0.githubusercontent.com/u/1786012?v=4","gravatar_id":"","url":"https://api.github.com/users/CarlHembrough","html_url":"https://github.com/CarlHembrough","followers_url":"https://api.github.com/users/CarlHembrough/followers","following_url":"https://api.github.com/users/CarlHembrough/following{/other_user}","gists_url":"https://api.github.com/users/CarlHembrough/gists{/gist_id}","starred_url":"https://api.github.com/users/CarlHembrough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarlHembrough/subscriptions","organizations_url":"https://api.github.com/users/CarlHembrough/orgs","repos_url":"https://api.github.com/users/CarlHembrough/repos","events_url":"https://api.github.com/users/CarlHembrough/events{/privacy}","received_events_url":"https://api.github.com/users/CarlHembrough/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\n* Only enable private endpoints if ENABLE_PRIVATE_ENDPOINTS env var is set\r\n* Default ENABLE_PRIVATE_ENDPOINTS to true in dev env\r\n* Make nomad task names web / publishing specific\r\n* Only enable identity middleware in publishing","created_at":"2018-04-05T14:12:53Z","updated_at":"2018-04-06T10:41:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78e3e7fcbd824b0aaf43f370cd95573941f7ebb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/67/comments","statuses_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/statuses/c035eccb351cda993962fb3308ce07c013fb1a50","head":{"label":"ONSdigital:feature/disable-private-endpoints","ref":"feature/disable-private-endpoints","sha":"c035eccb351cda993962fb3308ce07c013fb1a50","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":97220496,"name":"dp-filter-api","full_name":"ONSdigital/dp-filter-api","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-filter-api","description":"API to maintain dataset filter jobs","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-filter-api","forks_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/deployments","created_at":"2017-07-14T10:05:55Z","updated_at":"2018-04-04T12:28:17Z","pushed_at":"2018-04-05T14:12:53Z","git_url":"git://github.com/ONSdigital/dp-filter-api.git","ssh_url":"git@github.com:ONSdigital/dp-filter-api.git","clone_url":"https://github.com/ONSdigital/dp-filter-api.git","svn_url":"https://github.com/ONSdigital/dp-filter-api","homepage":null,"size":1104,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"cmd-develop"}},"base":{"label":"ONSdigital:cmd-develop","ref":"cmd-develop","sha":"ef2d3c1f26852573235ccc681f49bebb89553eff","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":97220496,"name":"dp-filter-api","full_name":"ONSdigital/dp-filter-api","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-filter-api","description":"API to maintain dataset filter jobs","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-filter-api","forks_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-filter-api/deployments","created_at":"2017-07-14T10:05:55Z","updated_at":"2018-04-04T12:28:17Z","pushed_at":"2018-04-05T14:12:53Z","git_url":"git://github.com/ONSdigital/dp-filter-api.git","ssh_url":"git@github.com:ONSdigital/dp-filter-api.git","clone_url":"https://github.com/ONSdigital/dp-filter-api.git","svn_url":"https://github.com/ONSdigital/dp-filter-api","homepage":null,"size":1104,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"cmd-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67"},"html":{"href":"https://github.com/ONSdigital/dp-filter-api/pull/67"},"issue":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/67"},"comments":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/dp-filter-api/statuses/c035eccb351cda993962fb3308ce07c013fb1a50"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"CarlHembrough"}}