{"action":"closed","number":21395,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21395","id":195685445,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1Njg1NDQ1","html_url":"https://github.com/nodejs/node/pull/21395","diff_url":"https://github.com/nodejs/node/pull/21395.diff","patch_url":"https://github.com/nodejs/node/pull/21395.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21395","number":21395,"state":"closed","locked":false,"title":"src: guard against nullptr returned by uv_err_name","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"body":"In Electron, `uv_err_name` returns `nullptr` on unknown system errors, which V8 tries to create a string from and then crashes. \r\n\r\nThis PR introduces a guard against `err_name` being set to null by setting it to `UnknownSystemError` if `nullptr` is returned by `uv_err_name` and thus preventing the V8 crash.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-06-19T00:47:11Z","updated_at":"2018-06-19T16:00:15Z","closed_at":"2018-06-19T16:00:15Z","merged_at":null,"merge_commit_sha":"825144b28efafcdecd2a66ffa41e729db504cf75","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":214431115,"node_id":"MDU6TGFiZWwyMTQ0MzExMTU=","url":"https://api.github.com/repos/nodejs/node/labels/libuv","name":"libuv","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21395/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21395/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21395/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/83da50db07885ad0067ed779cdb02bbba6421262","head":{"label":"codebytere:guard-uv-err-name","ref":"guard-uv-err-name","sha":"83da50db07885ad0067ed779cdb02bbba6421262","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"repo":{"id":135801488,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU4MDE0ODg=","name":"node","full_name":"codebytere/node","owner":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/codebytere/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/codebytere/node","forks_url":"https://api.github.com/repos/codebytere/node/forks","keys_url":"https://api.github.com/repos/codebytere/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codebytere/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codebytere/node/teams","hooks_url":"https://api.github.com/repos/codebytere/node/hooks","issue_events_url":"https://api.github.com/repos/codebytere/node/issues/events{/number}","events_url":"https://api.github.com/repos/codebytere/node/events","assignees_url":"https://api.github.com/repos/codebytere/node/assignees{/user}","branches_url":"https://api.github.com/repos/codebytere/node/branches{/branch}","tags_url":"https://api.github.com/repos/codebytere/node/tags","blobs_url":"https://api.github.com/repos/codebytere/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codebytere/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codebytere/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/codebytere/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codebytere/node/statuses/{sha}","languages_url":"https://api.github.com/repos/codebytere/node/languages","stargazers_url":"https://api.github.com/repos/codebytere/node/stargazers","contributors_url":"https://api.github.com/repos/codebytere/node/contributors","subscribers_url":"https://api.github.com/repos/codebytere/node/subscribers","subscription_url":"https://api.github.com/repos/codebytere/node/subscription","commits_url":"https://api.github.com/repos/codebytere/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/codebytere/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/codebytere/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/codebytere/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/codebytere/node/contents/{+path}","compare_url":"https://api.github.com/repos/codebytere/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codebytere/node/merges","archive_url":"https://api.github.com/repos/codebytere/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codebytere/node/downloads","issues_url":"https://api.github.com/repos/codebytere/node/issues{/number}","pulls_url":"https://api.github.com/repos/codebytere/node/pulls{/number}","milestones_url":"https://api.github.com/repos/codebytere/node/milestones{/number}","notifications_url":"https://api.github.com/repos/codebytere/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codebytere/node/labels{/name}","releases_url":"https://api.github.com/repos/codebytere/node/releases{/id}","deployments_url":"https://api.github.com/repos/codebytere/node/deployments","created_at":"2018-06-02T08:38:31Z","updated_at":"2018-06-19T00:16:46Z","pushed_at":"2018-06-19T07:43:26Z","git_url":"git://github.com/codebytere/node.git","ssh_url":"git@github.com:codebytere/node.git","clone_url":"https://github.com/codebytere/node.git","svn_url":"https://github.com/codebytere/node","homepage":"https://nodejs.org","size":384760,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"8944a4f162d132d850e73d83f94fb333ed594374","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-06-19T15:06:22Z","pushed_at":"2018-06-19T15:57:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":385167,"stargazers_count":50469,"watchers_count":50469,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10593,"mirror_url":null,"archived":false,"open_issues_count":739,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10593,"open_issues":739,"watchers":50469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21395"},"html":{"href":"https://github.com/nodejs/node/pull/21395"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21395"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21395/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21395/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21395/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/83da50db07885ad0067ed779cdb02bbba6421262"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"codebytere"}}