{"action":"created","comment":{"url":"https://api.github.com/repos/brick/reflection/pulls/comments/172156001","pull_request_review_id":101124263,"id":172156001,"diff_hunk":"@@ -19,6 +19,85 @@ public function testGetMethodsDoesNotReturnStaticMethods()\n         $this->assertCount(0, $methods);\n     }\n \n+    public function testGetReflectionFunction()\n+    {\n+        $reflectionFunc = function()\n+        {\n+            return 'reflectedFunction';\n+        };\n+        $functions = (new ReflectionTools)->getReflectionFunction($reflectionFunc);\n+\n+        $this->assertCount(0, $functions->getParameters());","path":"tests/ReflectionToolsTest.php","position":12,"original_position":12,"commit_id":"14625aa0aca90014cfd5f6607c5581c3bb274563","original_commit_id":"14625aa0aca90014cfd5f6607c5581c3bb274563","user":{"login":"BenMorel","id":1952838,"avatar_url":"https://avatars3.githubusercontent.com/u/1952838?v=4","gravatar_id":"","url":"https://api.github.com/users/BenMorel","html_url":"https://github.com/BenMorel","followers_url":"https://api.github.com/users/BenMorel/followers","following_url":"https://api.github.com/users/BenMorel/following{/other_user}","gists_url":"https://api.github.com/users/BenMorel/gists{/gist_id}","starred_url":"https://api.github.com/users/BenMorel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenMorel/subscriptions","organizations_url":"https://api.github.com/users/BenMorel/orgs","repos_url":"https://api.github.com/users/BenMorel/repos","events_url":"https://api.github.com/users/BenMorel/events{/privacy}","received_events_url":"https://api.github.com/users/BenMorel/received_events","type":"User","site_admin":false},"body":"It would actually be better to check that `$function` (without `s`, please) is an instance of `ReflectionFunction` and that `getName()` returns the proper value!","created_at":"2018-03-05T11:19:51Z","updated_at":"2018-03-05T11:19:51Z","html_url":"https://github.com/brick/reflection/pull/1#discussion_r172156001","pull_request_url":"https://api.github.com/repos/brick/reflection/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/brick/reflection/pulls/comments/172156001"},"html":{"href":"https://github.com/brick/reflection/pull/1#discussion_r172156001"},"pull_request":{"href":"https://api.github.com/repos/brick/reflection/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/brick/reflection/pulls/1","id":172786253,"html_url":"https://github.com/brick/reflection/pull/1","diff_url":"https://github.com/brick/reflection/pull/1.diff","patch_url":"https://github.com/brick/reflection/pull/1.patch","issue_url":"https://api.github.com/repos/brick/reflection/issues/1","number":1,"state":"open","locked":false,"title":"Test enhancement","user":{"login":"peter279k","id":9021747,"avatar_url":"https://avatars2.githubusercontent.com/u/9021747?v=4","gravatar_id":"","url":"https://api.github.com/users/peter279k","html_url":"https://github.com/peter279k","followers_url":"https://api.github.com/users/peter279k/followers","following_url":"https://api.github.com/users/peter279k/following{/other_user}","gists_url":"https://api.github.com/users/peter279k/gists{/gist_id}","starred_url":"https://api.github.com/users/peter279k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter279k/subscriptions","organizations_url":"https://api.github.com/users/peter279k/orgs","repos_url":"https://api.github.com/users/peter279k/repos","events_url":"https://api.github.com/users/peter279k/events{/privacy}","received_events_url":"https://api.github.com/users/peter279k/received_events","type":"User","site_admin":false},"body":"# Changed log\r\n\r\n- enhance the tests.","created_at":"2018-03-05T06:45:29Z","updated_at":"2018-03-05T11:19:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72ef7c5c3048fcbb9056f8a5031245f6b58d0214","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brick/reflection/pulls/1/commits","review_comments_url":"https://api.github.com/repos/brick/reflection/pulls/1/comments","review_comment_url":"https://api.github.com/repos/brick/reflection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brick/reflection/issues/1/comments","statuses_url":"https://api.github.com/repos/brick/reflection/statuses/14625aa0aca90014cfd5f6607c5581c3bb274563","head":{"label":"peter279k:test_enhancement","ref":"test_enhancement","sha":"14625aa0aca90014cfd5f6607c5581c3bb274563","user":{"login":"peter279k","id":9021747,"avatar_url":"https://avatars2.githubusercontent.com/u/9021747?v=4","gravatar_id":"","url":"https://api.github.com/users/peter279k","html_url":"https://github.com/peter279k","followers_url":"https://api.github.com/users/peter279k/followers","following_url":"https://api.github.com/users/peter279k/following{/other_user}","gists_url":"https://api.github.com/users/peter279k/gists{/gist_id}","starred_url":"https://api.github.com/users/peter279k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter279k/subscriptions","organizations_url":"https://api.github.com/users/peter279k/orgs","repos_url":"https://api.github.com/users/peter279k/repos","events_url":"https://api.github.com/users/peter279k/events{/privacy}","received_events_url":"https://api.github.com/users/peter279k/received_events","type":"User","site_admin":false},"repo":{"id":123782069,"name":"reflection","full_name":"peter279k/reflection","owner":{"login":"peter279k","id":9021747,"avatar_url":"https://avatars2.githubusercontent.com/u/9021747?v=4","gravatar_id":"","url":"https://api.github.com/users/peter279k","html_url":"https://github.com/peter279k","followers_url":"https://api.github.com/users/peter279k/followers","following_url":"https://api.github.com/users/peter279k/following{/other_user}","gists_url":"https://api.github.com/users/peter279k/gists{/gist_id}","starred_url":"https://api.github.com/users/peter279k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter279k/subscriptions","organizations_url":"https://api.github.com/users/peter279k/orgs","repos_url":"https://api.github.com/users/peter279k/repos","events_url":"https://api.github.com/users/peter279k/events{/privacy}","received_events_url":"https://api.github.com/users/peter279k/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peter279k/reflection","description":"Low-level tools to extend PHP reflection capabilities","fork":true,"url":"https://api.github.com/repos/peter279k/reflection","forks_url":"https://api.github.com/repos/peter279k/reflection/forks","keys_url":"https://api.github.com/repos/peter279k/reflection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peter279k/reflection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peter279k/reflection/teams","hooks_url":"https://api.github.com/repos/peter279k/reflection/hooks","issue_events_url":"https://api.github.com/repos/peter279k/reflection/issues/events{/number}","events_url":"https://api.github.com/repos/peter279k/reflection/events","assignees_url":"https://api.github.com/repos/peter279k/reflection/assignees{/user}","branches_url":"https://api.github.com/repos/peter279k/reflection/branches{/branch}","tags_url":"https://api.github.com/repos/peter279k/reflection/tags","blobs_url":"https://api.github.com/repos/peter279k/reflection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peter279k/reflection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peter279k/reflection/git/refs{/sha}","trees_url":"https://api.github.com/repos/peter279k/reflection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peter279k/reflection/statuses/{sha}","languages_url":"https://api.github.com/repos/peter279k/reflection/languages","stargazers_url":"https://api.github.com/repos/peter279k/reflection/stargazers","contributors_url":"https://api.github.com/repos/peter279k/reflection/contributors","subscribers_url":"https://api.github.com/repos/peter279k/reflection/subscribers","subscription_url":"https://api.github.com/repos/peter279k/reflection/subscription","commits_url":"https://api.github.com/repos/peter279k/reflection/commits{/sha}","git_commits_url":"https://api.github.com/repos/peter279k/reflection/git/commits{/sha}","comments_url":"https://api.github.com/repos/peter279k/reflection/comments{/number}","issue_comment_url":"https://api.github.com/repos/peter279k/reflection/issues/comments{/number}","contents_url":"https://api.github.com/repos/peter279k/reflection/contents/{+path}","compare_url":"https://api.github.com/repos/peter279k/reflection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peter279k/reflection/merges","archive_url":"https://api.github.com/repos/peter279k/reflection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peter279k/reflection/downloads","issues_url":"https://api.github.com/repos/peter279k/reflection/issues{/number}","pulls_url":"https://api.github.com/repos/peter279k/reflection/pulls{/number}","milestones_url":"https://api.github.com/repos/peter279k/reflection/milestones{/number}","notifications_url":"https://api.github.com/repos/peter279k/reflection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peter279k/reflection/labels{/name}","releases_url":"https://api.github.com/repos/peter279k/reflection/releases{/id}","deployments_url":"https://api.github.com/repos/peter279k/reflection/deployments","created_at":"2018-03-04T11:27:57Z","updated_at":"2018-03-04T11:27:59Z","pushed_at":"2018-03-05T07:04:58Z","git_url":"git://github.com/peter279k/reflection.git","ssh_url":"git@github.com:peter279k/reflection.git","clone_url":"https://github.com/peter279k/reflection.git","svn_url":"https://github.com/peter279k/reflection","homepage":"","size":29,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brick:master","ref":"master","sha":"090e5f9b5fc755754d1e1cc49a567b64cdf4c1ff","user":{"login":"brick","id":3463355,"avatar_url":"https://avatars3.githubusercontent.com/u/3463355?v=4","gravatar_id":"","url":"https://api.github.com/users/brick","html_url":"https://github.com/brick","followers_url":"https://api.github.com/users/brick/followers","following_url":"https://api.github.com/users/brick/following{/other_user}","gists_url":"https://api.github.com/users/brick/gists{/gist_id}","starred_url":"https://api.github.com/users/brick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brick/subscriptions","organizations_url":"https://api.github.com/users/brick/orgs","repos_url":"https://api.github.com/users/brick/repos","events_url":"https://api.github.com/users/brick/events{/privacy}","received_events_url":"https://api.github.com/users/brick/received_events","type":"Organization","site_admin":false},"repo":{"id":23952097,"name":"reflection","full_name":"brick/reflection","owner":{"login":"brick","id":3463355,"avatar_url":"https://avatars3.githubusercontent.com/u/3463355?v=4","gravatar_id":"","url":"https://api.github.com/users/brick","html_url":"https://github.com/brick","followers_url":"https://api.github.com/users/brick/followers","following_url":"https://api.github.com/users/brick/following{/other_user}","gists_url":"https://api.github.com/users/brick/gists{/gist_id}","starred_url":"https://api.github.com/users/brick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brick/subscriptions","organizations_url":"https://api.github.com/users/brick/orgs","repos_url":"https://api.github.com/users/brick/repos","events_url":"https://api.github.com/users/brick/events{/privacy}","received_events_url":"https://api.github.com/users/brick/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brick/reflection","description":"Low-level tools to extend PHP reflection capabilities","fork":false,"url":"https://api.github.com/repos/brick/reflection","forks_url":"https://api.github.com/repos/brick/reflection/forks","keys_url":"https://api.github.com/repos/brick/reflection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brick/reflection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brick/reflection/teams","hooks_url":"https://api.github.com/repos/brick/reflection/hooks","issue_events_url":"https://api.github.com/repos/brick/reflection/issues/events{/number}","events_url":"https://api.github.com/repos/brick/reflection/events","assignees_url":"https://api.github.com/repos/brick/reflection/assignees{/user}","branches_url":"https://api.github.com/repos/brick/reflection/branches{/branch}","tags_url":"https://api.github.com/repos/brick/reflection/tags","blobs_url":"https://api.github.com/repos/brick/reflection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brick/reflection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brick/reflection/git/refs{/sha}","trees_url":"https://api.github.com/repos/brick/reflection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brick/reflection/statuses/{sha}","languages_url":"https://api.github.com/repos/brick/reflection/languages","stargazers_url":"https://api.github.com/repos/brick/reflection/stargazers","contributors_url":"https://api.github.com/repos/brick/reflection/contributors","subscribers_url":"https://api.github.com/repos/brick/reflection/subscribers","subscription_url":"https://api.github.com/repos/brick/reflection/subscription","commits_url":"https://api.github.com/repos/brick/reflection/commits{/sha}","git_commits_url":"https://api.github.com/repos/brick/reflection/git/commits{/sha}","comments_url":"https://api.github.com/repos/brick/reflection/comments{/number}","issue_comment_url":"https://api.github.com/repos/brick/reflection/issues/comments{/number}","contents_url":"https://api.github.com/repos/brick/reflection/contents/{+path}","compare_url":"https://api.github.com/repos/brick/reflection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brick/reflection/merges","archive_url":"https://api.github.com/repos/brick/reflection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brick/reflection/downloads","issues_url":"https://api.github.com/repos/brick/reflection/issues{/number}","pulls_url":"https://api.github.com/repos/brick/reflection/pulls{/number}","milestones_url":"https://api.github.com/repos/brick/reflection/milestones{/number}","notifications_url":"https://api.github.com/repos/brick/reflection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brick/reflection/labels{/name}","releases_url":"https://api.github.com/repos/brick/reflection/releases{/id}","deployments_url":"https://api.github.com/repos/brick/reflection/deployments","created_at":"2014-09-12T08:01:57Z","updated_at":"2018-03-03T18:23:37Z","pushed_at":"2018-03-05T07:04:59Z","git_url":"git://github.com/brick/reflection.git","ssh_url":"git@github.com:brick/reflection.git","clone_url":"https://github.com/brick/reflection.git","svn_url":"https://github.com/brick/reflection","homepage":"","size":26,"stargazers_count":6,"watchers_count":6,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brick/reflection/pulls/1"},"html":{"href":"https://github.com/brick/reflection/pull/1"},"issue":{"href":"https://api.github.com/repos/brick/reflection/issues/1"},"comments":{"href":"https://api.github.com/repos/brick/reflection/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/brick/reflection/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/brick/reflection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brick/reflection/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/brick/reflection/statuses/14625aa0aca90014cfd5f6607c5581c3bb274563"}},"author_association":"NONE"}}
{"actor":{"display_login":"BenMorel"}}