{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/201885726","pull_request_review_id":136475558,"id":201885726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg4NTcyNg==","diff_hunk":"@@ -0,0 +1,84 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+#pragma once\n+\n+#include <vector>\n+\n+#include \"Domain/DomainCreators/RegisterDerivedWithCharm.cpp\"\n+#include \"Domain/Tags.hpp\"\n+#include \"ErrorHandling/FloatingPointExceptions.hpp\"\n+#include \"Evolution/Actions/ComputeVolumeDuDt.hpp\"  // IWYU pragma: keep\n+#include \"Evolution/Actions/ComputeVolumeFluxes.hpp\"  // IWYU pragma: keep\n+#include \"Evolution/DiscontinuousGalerkin/DgElementArray.hpp\"  // IWYU pragma: keep\n+// for LocalLaxFriedrichsFlux","path":"src/Evolution/Executables/Burgers/EvolveBurgers.hpp","position":14,"original_position":14,"commit_id":"c1755c859ff59be381b369c5bd8741744425d4f5","original_commit_id":"c1755c859ff59be381b369c5bd8741744425d4f5","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"What is the comment to? Normally they're on the same as the include, if not could you specify e.g. `// Equations.hpp for Local`?","created_at":"2018-07-12T01:27:19Z","updated_at":"2018-07-12T01:37:58Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/805#discussion_r201885726","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/201885726"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/805#discussion_r201885726"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805","id":199589329,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTg5MzI5","html_url":"https://github.com/sxs-collaboration/spectre/pull/805","diff_url":"https://github.com/sxs-collaboration/spectre/pull/805.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/805.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/805","number":805,"state":"open","locked":false,"title":"Burgers executable","user":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\n<!--\r\nAt a high level, describe what this PR does.\r\n-->\r\n\r\n### Types of changes:\r\n\r\n- [ ] Bugfix\r\n- [ ] New feature\r\n\r\n### Component:\r\n\r\n- [ ] Code\r\n- [ ] Documentation\r\n- [ ] Build system\r\n- [ ] Continuous integration\r\n\r\n### Code review checklist\r\n\r\n- [ ] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [ ] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [ ] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).\r\n\r\n### Further comments\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by\r\nexplaining why you chose the solution you did and what alternatives you\r\nconsidered, etc...\r\n-->\r\n","created_at":"2018-07-05T21:15:12Z","updated_at":"2018-07-12T01:37:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f307e752c472a21dd42cb97ee475ba77a4a953c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/805/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/c1755c859ff59be381b369c5bd8741744425d4f5","head":{"label":"wthrowe:burgers-executable","ref":"burgers-executable","sha":"c1755c859ff59be381b369c5bd8741744425d4f5","user":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"repo":{"id":96371688,"node_id":"MDEwOlJlcG9zaXRvcnk5NjM3MTY4OA==","name":"spectre","full_name":"wthrowe/spectre","owner":{"login":"wthrowe","id":867117,"node_id":"MDQ6VXNlcjg2NzExNw==","avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wthrowe/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/wthrowe/spectre","forks_url":"https://api.github.com/repos/wthrowe/spectre/forks","keys_url":"https://api.github.com/repos/wthrowe/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wthrowe/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wthrowe/spectre/teams","hooks_url":"https://api.github.com/repos/wthrowe/spectre/hooks","issue_events_url":"https://api.github.com/repos/wthrowe/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/wthrowe/spectre/events","assignees_url":"https://api.github.com/repos/wthrowe/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/wthrowe/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/wthrowe/spectre/tags","blobs_url":"https://api.github.com/repos/wthrowe/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wthrowe/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wthrowe/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/wthrowe/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wthrowe/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/wthrowe/spectre/languages","stargazers_url":"https://api.github.com/repos/wthrowe/spectre/stargazers","contributors_url":"https://api.github.com/repos/wthrowe/spectre/contributors","subscribers_url":"https://api.github.com/repos/wthrowe/spectre/subscribers","subscription_url":"https://api.github.com/repos/wthrowe/spectre/subscription","commits_url":"https://api.github.com/repos/wthrowe/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/wthrowe/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/wthrowe/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/wthrowe/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/wthrowe/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/wthrowe/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wthrowe/spectre/merges","archive_url":"https://api.github.com/repos/wthrowe/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wthrowe/spectre/downloads","issues_url":"https://api.github.com/repos/wthrowe/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/wthrowe/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/wthrowe/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/wthrowe/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wthrowe/spectre/labels{/name}","releases_url":"https://api.github.com/repos/wthrowe/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/wthrowe/spectre/deployments","created_at":"2017-07-06T00:23:14Z","updated_at":"2017-07-06T00:23:15Z","pushed_at":"2018-07-11T03:15:39Z","git_url":"git://github.com/wthrowe/spectre.git","ssh_url":"git@github.com:wthrowe/spectre.git","clone_url":"https://github.com/wthrowe/spectre.git","svn_url":"https://github.com/wthrowe/spectre","homepage":null,"size":12251,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"bb6d230c5a115b4b1e8e9884bd894f96feb8fcd3","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-07-11T23:34:51Z","pushed_at":"2018-07-11T23:34:45Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":12032,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":23,"open_issues":101,"watchers":26,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/805"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/805"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/805/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/805/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/c1755c859ff59be381b369c5bd8741744425d4f5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nilsdeppe"}}