{"action":"created","comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/166804657","pull_request_review_id":94925937,"id":166804657,"diff_hunk":"@@ -10,8 +11,10 @@\n  * in reverse order.\n  */\n public class ReversePhasesCustomizer implements PlanCustomizer {\n+\n     @Override\n     public Plan updatePlan(Plan plan) {\n+        // Definitely don't reverse the uninstall plan!","path":"frameworks/helloworld/src/main/java/com/mesosphere/sdk/helloworld/scheduler/ReversePhasesCustomizer.java","position":17,"original_position":17,"commit_id":"288d942a1a382edd6ee5a1cf6dfeb650893a236e","original_commit_id":"288d942a1a382edd6ee5a1cf6dfeb650893a236e","user":{"login":"benclarkwood","id":4732025,"avatar_url":"https://avatars3.githubusercontent.com/u/4732025?v=4","gravatar_id":"","url":"https://api.github.com/users/benclarkwood","html_url":"https://github.com/benclarkwood","followers_url":"https://api.github.com/users/benclarkwood/followers","following_url":"https://api.github.com/users/benclarkwood/following{/other_user}","gists_url":"https://api.github.com/users/benclarkwood/gists{/gist_id}","starred_url":"https://api.github.com/users/benclarkwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benclarkwood/subscriptions","organizations_url":"https://api.github.com/users/benclarkwood/orgs","repos_url":"https://api.github.com/users/benclarkwood/repos","events_url":"https://api.github.com/users/benclarkwood/events{/privacy}","received_events_url":"https://api.github.com/users/benclarkwood/received_events","type":"User","site_admin":false},"body":"Oh. Comment is nonsense now. Good catch.","created_at":"2018-02-08T00:53:23Z","updated_at":"2018-02-08T00:53:23Z","html_url":"https://github.com/mesosphere/dcos-commons/pull/2214#discussion_r166804657","pull_request_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments/166804657"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2214#discussion_r166804657"},"pull_request":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214"}},"in_reply_to_id":166801316},"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214","id":167810889,"html_url":"https://github.com/mesosphere/dcos-commons/pull/2214","diff_url":"https://github.com/mesosphere/dcos-commons/pull/2214.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/2214.patch","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2214","number":2214,"state":"open","locked":false,"title":"[INFINITY-3113] Uninstall scheduler not using plan customizer","user":{"login":"benclarkwood","id":4732025,"avatar_url":"https://avatars3.githubusercontent.com/u/4732025?v=4","gravatar_id":"","url":"https://api.github.com/users/benclarkwood","html_url":"https://github.com/benclarkwood","followers_url":"https://api.github.com/users/benclarkwood/followers","following_url":"https://api.github.com/users/benclarkwood/following{/other_user}","gists_url":"https://api.github.com/users/benclarkwood/gists{/gist_id}","starred_url":"https://api.github.com/users/benclarkwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benclarkwood/subscriptions","organizations_url":"https://api.github.com/users/benclarkwood/orgs","repos_url":"https://api.github.com/users/benclarkwood/repos","events_url":"https://api.github.com/users/benclarkwood/events{/privacy}","received_events_url":"https://api.github.com/users/benclarkwood/received_events","type":"User","site_admin":false},"body":"1. Make the uninstall scheduler use the plan customizer\r\n2. Add a unit test to verify the customizer is used\r\n3. Doc the altered behavior of the customizer","created_at":"2018-02-07T21:15:07Z","updated_at":"2018-02-08T00:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a21942767c88e7dd5d05e267012b27e355e79ca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gabrielhartmann","id":567111,"avatar_url":"https://avatars1.githubusercontent.com/u/567111?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielhartmann","html_url":"https://github.com/gabrielhartmann","followers_url":"https://api.github.com/users/gabrielhartmann/followers","following_url":"https://api.github.com/users/gabrielhartmann/following{/other_user}","gists_url":"https://api.github.com/users/gabrielhartmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielhartmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielhartmann/subscriptions","organizations_url":"https://api.github.com/users/gabrielhartmann/orgs","repos_url":"https://api.github.com/users/gabrielhartmann/repos","events_url":"https://api.github.com/users/gabrielhartmann/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielhartmann/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214/commits","review_comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214/comments","review_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2214/comments","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/288d942a1a382edd6ee5a1cf6dfeb650893a236e","head":{"label":"mesosphere:INFINITY-3113-uninstall-customizer","ref":"INFINITY-3113-uninstall-customizer","sha":"288d942a1a382edd6ee5a1cf6dfeb650893a236e","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-01-27T09:16:17Z","pushed_at":"2018-02-08T00:50:56Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":59317,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":121,"open_issues":59,"watchers":118,"default_branch":"master"}},"base":{"label":"mesosphere:master","ref":"master","sha":"d0c35185c9b04548e772193da47ebe04cd5b55bf","user":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":60286497,"name":"dcos-commons","full_name":"mesosphere/dcos-commons","owner":{"login":"mesosphere","id":3458585,"avatar_url":"https://avatars0.githubusercontent.com/u/3458585?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere","html_url":"https://github.com/mesosphere","followers_url":"https://api.github.com/users/mesosphere/followers","following_url":"https://api.github.com/users/mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere/subscriptions","organizations_url":"https://api.github.com/users/mesosphere/orgs","repos_url":"https://api.github.com/users/mesosphere/repos","events_url":"https://api.github.com/users/mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mesosphere/dcos-commons","description":"Simplifying stateful services","fork":false,"url":"https://api.github.com/repos/mesosphere/dcos-commons","forks_url":"https://api.github.com/repos/mesosphere/dcos-commons/forks","keys_url":"https://api.github.com/repos/mesosphere/dcos-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mesosphere/dcos-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mesosphere/dcos-commons/teams","hooks_url":"https://api.github.com/repos/mesosphere/dcos-commons/hooks","issue_events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/events{/number}","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/events","assignees_url":"https://api.github.com/repos/mesosphere/dcos-commons/assignees{/user}","branches_url":"https://api.github.com/repos/mesosphere/dcos-commons/branches{/branch}","tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/tags","blobs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/mesosphere/dcos-commons/languages","stargazers_url":"https://api.github.com/repos/mesosphere/dcos-commons/stargazers","contributors_url":"https://api.github.com/repos/mesosphere/dcos-commons/contributors","subscribers_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscribers","subscription_url":"https://api.github.com/repos/mesosphere/dcos-commons/subscription","commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mesosphere/dcos-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mesosphere/dcos-commons/contents/{+path}","compare_url":"https://api.github.com/repos/mesosphere/dcos-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mesosphere/dcos-commons/merges","archive_url":"https://api.github.com/repos/mesosphere/dcos-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mesosphere/dcos-commons/downloads","issues_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues{/number}","pulls_url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/mesosphere/dcos-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/mesosphere/dcos-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/labels{/name}","releases_url":"https://api.github.com/repos/mesosphere/dcos-commons/releases{/id}","deployments_url":"https://api.github.com/repos/mesosphere/dcos-commons/deployments","created_at":"2016-06-02T18:09:08Z","updated_at":"2018-01-27T09:16:17Z","pushed_at":"2018-02-08T00:50:56Z","git_url":"git://github.com/mesosphere/dcos-commons.git","ssh_url":"git@github.com:mesosphere/dcos-commons.git","clone_url":"https://github.com/mesosphere/dcos-commons.git","svn_url":"https://github.com/mesosphere/dcos-commons","homepage":"https://mesosphere.github.io/dcos-commons/","size":59317,"stargazers_count":118,"watchers_count":118,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":121,"open_issues":59,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214"},"html":{"href":"https://github.com/mesosphere/dcos-commons/pull/2214"},"issue":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2214"},"comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/issues/2214/comments"},"review_comments":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214/comments"},"review_comment":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/2214/commits"},"statuses":{"href":"https://api.github.com/repos/mesosphere/dcos-commons/statuses/288d942a1a382edd6ee5a1cf6dfeb650893a236e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benclarkwood"}}