{"action":"created","issue":{"url":"https://api.github.com/repos/stan-dev/cmdstan/issues/618","repository_url":"https://api.github.com/repos/stan-dev/cmdstan","labels_url":"https://api.github.com/repos/stan-dev/cmdstan/issues/618/labels{/name}","comments_url":"https://api.github.com/repos/stan-dev/cmdstan/issues/618/comments","events_url":"https://api.github.com/repos/stan-dev/cmdstan/issues/618/events","html_url":"https://github.com/stan-dev/cmdstan/pull/618","id":322942732,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3OTIyMDM3","number":618,"title":"add MPI facilities to cmdstan","user":{"login":"wds15","id":12070126,"node_id":"MDQ6VXNlcjEyMDcwMTI2","avatar_url":"https://avatars0.githubusercontent.com/u/12070126?v=4","gravatar_id":"","url":"https://api.github.com/users/wds15","html_url":"https://github.com/wds15","followers_url":"https://api.github.com/users/wds15/followers","following_url":"https://api.github.com/users/wds15/following{/other_user}","gists_url":"https://api.github.com/users/wds15/gists{/gist_id}","starred_url":"https://api.github.com/users/wds15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wds15/subscriptions","organizations_url":"https://api.github.com/users/wds15/orgs","repos_url":"https://api.github.com/users/wds15/repos","events_url":"https://api.github.com/users/wds15/events{/privacy}","received_events_url":"https://api.github.com/users/wds15/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":70,"created_at":"2018-05-14T19:08:04Z","updated_at":"2018-07-02T21:16:09Z","closed_at":"2018-06-28T13:49:27Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stan-dev/cmdstan/pulls/618","html_url":"https://github.com/stan-dev/cmdstan/pull/618","diff_url":"https://github.com/stan-dev/cmdstan/pull/618.diff","patch_url":"https://github.com/stan-dev/cmdstan/pull/618.patch"},"body":"#### Submisison Checklist\r\n\r\n- [X] Run tests: `./runCmdStanTests.py src/test`\r\n- [X] Declare copyright holder and open-source license: see below\r\n\r\n#### Summary:\r\nAdd support for MPI parallelism.\r\n\r\nThings to settle on:\r\n\r\n- Currently there is no additional output from cmdstan on MPI things as this is beyond me (putting the output in the right place and then adjusting the tests - I do not know that). Moreover, I think it would be ok to leave out MPI status printouts, since the MPI configuration is controlled by the runtime environment.\r\n- Is the current doc enough? I am basically pointing people to the stan-math wiki as I would much prefer to not duplicate documentation for MPI matter in multiple places.\r\n\r\n#### Intended Effect:\r\nEnable MPI for use with stan-math. Hence, the build system is adjusted to automatically build the needed libraries whenever STAN_MPI=true is defined and the compiler is set to a MPI aware compiler. In addition, the MPI resource is initialized during the execution of a command.\r\n\r\n#### How to Verify:\r\nSetup MPI according to our wiki on stan-math. A test has been added which checks that MPI is working properly. This can be executed with \r\n\r\n`./runCmdStanTests.py src/test/interface/mpi_test.cpp`\r\n\r\nIn addition, all unit tests are now executed on the Jenkins with MPI enabled on non-windows machines.\r\n\r\n#### Side Effects:\r\n\r\n#### Documentation:\r\nAdded to the cmdstan guide a section \"Optional Parallelization\" in the appendix B which points essentially to the stan-math wiki where all needed steps are detailed to do the installation. \r\n\r\n#### Copyright and Licensing\r\n\r\nPlease list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Sebastian Weber\r\n\r\nBy submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:\r\n- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)\r\n- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)\r\n"},"comment":{"url":"https://api.github.com/repos/stan-dev/cmdstan/issues/comments/401938923","html_url":"https://github.com/stan-dev/cmdstan/pull/618#issuecomment-401938923","issue_url":"https://api.github.com/repos/stan-dev/cmdstan/issues/618","id":401938923,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTkzODkyMw==","user":{"login":"wds15","id":12070126,"node_id":"MDQ6VXNlcjEyMDcwMTI2","avatar_url":"https://avatars0.githubusercontent.com/u/12070126?v=4","gravatar_id":"","url":"https://api.github.com/users/wds15","html_url":"https://github.com/wds15","followers_url":"https://api.github.com/users/wds15/followers","following_url":"https://api.github.com/users/wds15/following{/other_user}","gists_url":"https://api.github.com/users/wds15/gists{/gist_id}","starred_url":"https://api.github.com/users/wds15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wds15/subscriptions","organizations_url":"https://api.github.com/users/wds15/orgs","repos_url":"https://api.github.com/users/wds15/repos","events_url":"https://api.github.com/users/wds15/events{/privacy}","received_events_url":"https://api.github.com/users/wds15/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T21:16:09Z","updated_at":"2018-07-02T21:16:09Z","author_association":"CONTRIBUTOR","body":"Bummer...\r\n\r\nI did add to the main makefile of cmdstan\r\n\r\n`CXX = $(CC)`\r\n\r\nwhich does align it with the stan-math makefile, but turns out that this is the wrong thing?! I am pretty sure we have that line in stan-math (which does not make it correct)... so we need to align.\r\n\r\nWhen I remove that line, then all seems to be working again (I should really stop working on makefiles)... and there seems to be no issue with `libc++`."}}
{"actor":{"display_login":"wds15"}}