{"action":"created","comment":{"url":"https://api.github.com/repos/algolia/instantsearch.js/pulls/comments/177729610","pull_request_review_id":107653278,"id":177729610,"diff_hunk":"@@ -3,13 +3,11 @@\n import algoliasearch from 'algoliasearch/src/browser/builds/algoliasearchLite.js';\n import algoliasearchHelper from 'algoliasearch-helper';\n import forEach from 'lodash/forEach';\n-import mergeWith from 'lodash/mergeWith';\n-import union from 'lodash/union';\n-import isPlainObject from 'lodash/isPlainObject';\n import { EventEmitter } from 'events';\n import urlSyncWidget from './url-sync.js';\n import version from './version.js';\n import createHelpers from './createHelpers.js';\n+import { enhanceConfiguration } from './utils.js';","path":"src/lib/InstantSearch.js","position":11,"original_position":11,"commit_id":"f4a367fb4b653a105cb9e2fcc87d6d668dc46a67","original_commit_id":"f4a367fb4b653a105cb9e2fcc87d6d668dc46a67","user":{"login":"iam4x","id":893837,"avatar_url":"https://avatars2.githubusercontent.com/u/893837?v=4","gravatar_id":"","url":"https://api.github.com/users/iam4x","html_url":"https://github.com/iam4x","followers_url":"https://api.github.com/users/iam4x/followers","following_url":"https://api.github.com/users/iam4x/following{/other_user}","gists_url":"https://api.github.com/users/iam4x/gists{/gist_id}","starred_url":"https://api.github.com/users/iam4x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iam4x/subscriptions","organizations_url":"https://api.github.com/users/iam4x/orgs","repos_url":"https://api.github.com/users/iam4x/repos","events_url":"https://api.github.com/users/iam4x/events{/privacy}","received_events_url":"https://api.github.com/users/iam4x/received_events","type":"User","site_admin":false},"body":"Not the scope of the PR, we should keep this on mind and have it in another one or with the instantsearch-core refactoring.","created_at":"2018-03-28T12:22:47Z","updated_at":"2018-03-28T12:22:47Z","html_url":"https://github.com/algolia/instantsearch.js/pull/2839#discussion_r177729610","pull_request_url":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/algolia/instantsearch.js/pulls/comments/177729610"},"html":{"href":"https://github.com/algolia/instantsearch.js/pull/2839#discussion_r177729610"},"pull_request":{"href":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839"}},"in_reply_to_id":177726031},"pull_request":{"url":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839","id":177777609,"html_url":"https://github.com/algolia/instantsearch.js/pull/2839","diff_url":"https://github.com/algolia/instantsearch.js/pull/2839.diff","patch_url":"https://github.com/algolia/instantsearch.js/pull/2839.patch","issue_url":"https://api.github.com/repos/algolia/instantsearch.js/issues/2839","number":2839,"state":"open","locked":false,"title":"Feat/connect configure","user":{"login":"iam4x","id":893837,"avatar_url":"https://avatars2.githubusercontent.com/u/893837?v=4","gravatar_id":"","url":"https://api.github.com/users/iam4x","html_url":"https://github.com/iam4x","followers_url":"https://api.github.com/users/iam4x/followers","following_url":"https://api.github.com/users/iam4x/following{/other_user}","gists_url":"https://api.github.com/users/iam4x/gists{/gist_id}","starred_url":"https://api.github.com/users/iam4x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iam4x/subscriptions","organizations_url":"https://api.github.com/users/iam4x/orgs","repos_url":"https://api.github.com/users/iam4x/repos","events_url":"https://api.github.com/users/iam4x/events{/privacy}","received_events_url":"https://api.github.com/users/iam4x/received_events","type":"User","site_admin":false},"body":"Fixes #2829 \r\n\r\n* `renderFn` && `unmountFn` would be only called if they were provided\r\n* `renderFn` gets a `refine()` function to apply new search parameters\r\n\r\nFlow of `refine()` :\r\n\r\n1. Remove last `searchParameters` applied on the state\r\n2. Compute new state by merging the new `searchParameters` and the actual state\r\n3. Trigger a search with the new state\r\n4. Replace `widgetParams.searchParameters` by the new one\r\n\r\nThis should cover the cases we discussed in the issue 👍 ","created_at":"2018-03-27T15:25:22Z","updated_at":"2018-03-28T12:22:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0ee15ea6eacdce474926acaaec4d8b522a6a039","assignee":null,"assignees":[],"requested_reviewers":[{"login":"samouss","id":6513513,"avatar_url":"https://avatars2.githubusercontent.com/u/6513513?v=4","gravatar_id":"","url":"https://api.github.com/users/samouss","html_url":"https://github.com/samouss","followers_url":"https://api.github.com/users/samouss/followers","following_url":"https://api.github.com/users/samouss/following{/other_user}","gists_url":"https://api.github.com/users/samouss/gists{/gist_id}","starred_url":"https://api.github.com/users/samouss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouss/subscriptions","organizations_url":"https://api.github.com/users/samouss/orgs","repos_url":"https://api.github.com/users/samouss/repos","events_url":"https://api.github.com/users/samouss/events{/privacy}","received_events_url":"https://api.github.com/users/samouss/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839/commits","review_comments_url":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839/comments","review_comment_url":"https://api.github.com/repos/algolia/instantsearch.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/algolia/instantsearch.js/issues/2839/comments","statuses_url":"https://api.github.com/repos/algolia/instantsearch.js/statuses/f4a367fb4b653a105cb9e2fcc87d6d668dc46a67","head":{"label":"algolia:feat/connectConfigure","ref":"feat/connectConfigure","sha":"f4a367fb4b653a105cb9e2fcc87d6d668dc46a67","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":39443258,"name":"instantsearch.js","full_name":"algolia/instantsearch.js","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/instantsearch.js","description":":zap: Lightning-fast search for your apps, by Algolia","fork":false,"url":"https://api.github.com/repos/algolia/instantsearch.js","forks_url":"https://api.github.com/repos/algolia/instantsearch.js/forks","keys_url":"https://api.github.com/repos/algolia/instantsearch.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/instantsearch.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/instantsearch.js/teams","hooks_url":"https://api.github.com/repos/algolia/instantsearch.js/hooks","issue_events_url":"https://api.github.com/repos/algolia/instantsearch.js/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/instantsearch.js/events","assignees_url":"https://api.github.com/repos/algolia/instantsearch.js/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/instantsearch.js/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/instantsearch.js/tags","blobs_url":"https://api.github.com/repos/algolia/instantsearch.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/instantsearch.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/instantsearch.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/instantsearch.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/instantsearch.js/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/instantsearch.js/languages","stargazers_url":"https://api.github.com/repos/algolia/instantsearch.js/stargazers","contributors_url":"https://api.github.com/repos/algolia/instantsearch.js/contributors","subscribers_url":"https://api.github.com/repos/algolia/instantsearch.js/subscribers","subscription_url":"https://api.github.com/repos/algolia/instantsearch.js/subscription","commits_url":"https://api.github.com/repos/algolia/instantsearch.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/instantsearch.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/instantsearch.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/instantsearch.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/instantsearch.js/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/instantsearch.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/instantsearch.js/merges","archive_url":"https://api.github.com/repos/algolia/instantsearch.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/instantsearch.js/downloads","issues_url":"https://api.github.com/repos/algolia/instantsearch.js/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/instantsearch.js/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/instantsearch.js/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/instantsearch.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/instantsearch.js/labels{/name}","releases_url":"https://api.github.com/repos/algolia/instantsearch.js/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/instantsearch.js/deployments","created_at":"2015-07-21T12:10:27Z","updated_at":"2018-03-28T09:35:09Z","pushed_at":"2018-03-28T10:09:35Z","git_url":"git://github.com/algolia/instantsearch.js.git","ssh_url":"git@github.com:algolia/instantsearch.js.git","clone_url":"https://github.com/algolia/instantsearch.js.git","svn_url":"https://github.com/algolia/instantsearch.js","homepage":"https://community.algolia.com/instantsearch.js","size":189047,"stargazers_count":1886,"watchers_count":1886,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":266,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":266,"open_issues":128,"watchers":1886,"default_branch":"develop"}},"base":{"label":"algolia:feat/2.7","ref":"feat/2.7","sha":"4bd54c5a7b2e701264e86b8f4329b272be38b9f5","user":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":39443258,"name":"instantsearch.js","full_name":"algolia/instantsearch.js","owner":{"login":"algolia","id":2034458,"avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/algolia/instantsearch.js","description":":zap: Lightning-fast search for your apps, by Algolia","fork":false,"url":"https://api.github.com/repos/algolia/instantsearch.js","forks_url":"https://api.github.com/repos/algolia/instantsearch.js/forks","keys_url":"https://api.github.com/repos/algolia/instantsearch.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/instantsearch.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/instantsearch.js/teams","hooks_url":"https://api.github.com/repos/algolia/instantsearch.js/hooks","issue_events_url":"https://api.github.com/repos/algolia/instantsearch.js/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/instantsearch.js/events","assignees_url":"https://api.github.com/repos/algolia/instantsearch.js/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/instantsearch.js/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/instantsearch.js/tags","blobs_url":"https://api.github.com/repos/algolia/instantsearch.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/instantsearch.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/instantsearch.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/instantsearch.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/instantsearch.js/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/instantsearch.js/languages","stargazers_url":"https://api.github.com/repos/algolia/instantsearch.js/stargazers","contributors_url":"https://api.github.com/repos/algolia/instantsearch.js/contributors","subscribers_url":"https://api.github.com/repos/algolia/instantsearch.js/subscribers","subscription_url":"https://api.github.com/repos/algolia/instantsearch.js/subscription","commits_url":"https://api.github.com/repos/algolia/instantsearch.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/instantsearch.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/instantsearch.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/instantsearch.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/instantsearch.js/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/instantsearch.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/instantsearch.js/merges","archive_url":"https://api.github.com/repos/algolia/instantsearch.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/instantsearch.js/downloads","issues_url":"https://api.github.com/repos/algolia/instantsearch.js/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/instantsearch.js/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/instantsearch.js/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/instantsearch.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/instantsearch.js/labels{/name}","releases_url":"https://api.github.com/repos/algolia/instantsearch.js/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/instantsearch.js/deployments","created_at":"2015-07-21T12:10:27Z","updated_at":"2018-03-28T09:35:09Z","pushed_at":"2018-03-28T10:09:35Z","git_url":"git://github.com/algolia/instantsearch.js.git","ssh_url":"git@github.com:algolia/instantsearch.js.git","clone_url":"https://github.com/algolia/instantsearch.js.git","svn_url":"https://github.com/algolia/instantsearch.js","homepage":"https://community.algolia.com/instantsearch.js","size":189047,"stargazers_count":1886,"watchers_count":1886,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":266,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":266,"open_issues":128,"watchers":1886,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839"},"html":{"href":"https://github.com/algolia/instantsearch.js/pull/2839"},"issue":{"href":"https://api.github.com/repos/algolia/instantsearch.js/issues/2839"},"comments":{"href":"https://api.github.com/repos/algolia/instantsearch.js/issues/2839/comments"},"review_comments":{"href":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839/comments"},"review_comment":{"href":"https://api.github.com/repos/algolia/instantsearch.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/algolia/instantsearch.js/pulls/2839/commits"},"statuses":{"href":"https://api.github.com/repos/algolia/instantsearch.js/statuses/f4a367fb4b653a105cb9e2fcc87d6d668dc46a67"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"iam4x"}}