{"action":"opened","number":43,"pull_request":{"url":"https://api.github.com/repos/tonerdo/readline/pulls/43","id":186164182,"html_url":"https://github.com/tonerdo/readline/pull/43","diff_url":"https://github.com/tonerdo/readline/pull/43.diff","patch_url":"https://github.com/tonerdo/readline/pull/43.patch","issue_url":"https://api.github.com/repos/tonerdo/readline/issues/43","number":43,"state":"open","locked":false,"title":"Refactor Tests","user":{"login":"rubberduck203","id":2716800,"avatar_url":"https://avatars0.githubusercontent.com/u/2716800?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck203","html_url":"https://github.com/rubberduck203","followers_url":"https://api.github.com/users/rubberduck203/followers","following_url":"https://api.github.com/users/rubberduck203/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck203/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck203/subscriptions","organizations_url":"https://api.github.com/users/rubberduck203/orgs","repos_url":"https://api.github.com/users/rubberduck203/repos","events_url":"https://api.github.com/users/rubberduck203/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck203/received_events","type":"User","site_admin":false},"body":"I was having a bit of trouble following the tests at times.\r\nThis PR extracts a lot of the commonly duplicated code for creating `ConsoleKeyInfo` instances.\r\nIt also converts manual `for` loops into maps for readability.\r\nI'm hoping this helps keep the tests maintainable into the future.\r\n\r\nThe new extension classes may or may not be useful in the main code base.\r\nI didn't think about how they might be leveraged elsewhere yet.","created_at":"2018-05-05T16:28:42Z","updated_at":"2018-05-05T16:28:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tonerdo/readline/pulls/43/commits","review_comments_url":"https://api.github.com/repos/tonerdo/readline/pulls/43/comments","review_comment_url":"https://api.github.com/repos/tonerdo/readline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tonerdo/readline/issues/43/comments","statuses_url":"https://api.github.com/repos/tonerdo/readline/statuses/062d21f0ee91ee56ad890ad01ccc83e5d10be917","head":{"label":"rubberduck203:testcleanup","ref":"testcleanup","sha":"062d21f0ee91ee56ad890ad01ccc83e5d10be917","user":{"login":"rubberduck203","id":2716800,"avatar_url":"https://avatars0.githubusercontent.com/u/2716800?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck203","html_url":"https://github.com/rubberduck203","followers_url":"https://api.github.com/users/rubberduck203/followers","following_url":"https://api.github.com/users/rubberduck203/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck203/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck203/subscriptions","organizations_url":"https://api.github.com/users/rubberduck203/orgs","repos_url":"https://api.github.com/users/rubberduck203/repos","events_url":"https://api.github.com/users/rubberduck203/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck203/received_events","type":"User","site_admin":false},"repo":{"id":131455210,"name":"readline","full_name":"rubberduck203/readline","owner":{"login":"rubberduck203","id":2716800,"avatar_url":"https://avatars0.githubusercontent.com/u/2716800?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck203","html_url":"https://github.com/rubberduck203","followers_url":"https://api.github.com/users/rubberduck203/followers","following_url":"https://api.github.com/users/rubberduck203/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck203/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck203/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck203/subscriptions","organizations_url":"https://api.github.com/users/rubberduck203/orgs","repos_url":"https://api.github.com/users/rubberduck203/repos","events_url":"https://api.github.com/users/rubberduck203/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck203/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rubberduck203/readline","description":"A Pure C# GNU-Readline like library for .NET/.NET Core","fork":true,"url":"https://api.github.com/repos/rubberduck203/readline","forks_url":"https://api.github.com/repos/rubberduck203/readline/forks","keys_url":"https://api.github.com/repos/rubberduck203/readline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck203/readline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck203/readline/teams","hooks_url":"https://api.github.com/repos/rubberduck203/readline/hooks","issue_events_url":"https://api.github.com/repos/rubberduck203/readline/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck203/readline/events","assignees_url":"https://api.github.com/repos/rubberduck203/readline/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck203/readline/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck203/readline/tags","blobs_url":"https://api.github.com/repos/rubberduck203/readline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck203/readline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck203/readline/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck203/readline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck203/readline/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck203/readline/languages","stargazers_url":"https://api.github.com/repos/rubberduck203/readline/stargazers","contributors_url":"https://api.github.com/repos/rubberduck203/readline/contributors","subscribers_url":"https://api.github.com/repos/rubberduck203/readline/subscribers","subscription_url":"https://api.github.com/repos/rubberduck203/readline/subscription","commits_url":"https://api.github.com/repos/rubberduck203/readline/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck203/readline/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck203/readline/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck203/readline/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck203/readline/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck203/readline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck203/readline/merges","archive_url":"https://api.github.com/repos/rubberduck203/readline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck203/readline/downloads","issues_url":"https://api.github.com/repos/rubberduck203/readline/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck203/readline/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck203/readline/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck203/readline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck203/readline/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck203/readline/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck203/readline/deployments","created_at":"2018-04-29T00:54:03Z","updated_at":"2018-05-05T16:17:44Z","pushed_at":"2018-05-05T16:22:44Z","git_url":"git://github.com/rubberduck203/readline.git","ssh_url":"git@github.com:rubberduck203/readline.git","clone_url":"https://github.com/rubberduck203/readline.git","svn_url":"https://github.com/rubberduck203/readline","homepage":"","size":89,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tonerdo:master","ref":"master","sha":"77c1761072df4cce910c676e1874ef38cdfb0ccb","user":{"login":"tonerdo","id":7319262,"avatar_url":"https://avatars3.githubusercontent.com/u/7319262?v=4","gravatar_id":"","url":"https://api.github.com/users/tonerdo","html_url":"https://github.com/tonerdo","followers_url":"https://api.github.com/users/tonerdo/followers","following_url":"https://api.github.com/users/tonerdo/following{/other_user}","gists_url":"https://api.github.com/users/tonerdo/gists{/gist_id}","starred_url":"https://api.github.com/users/tonerdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonerdo/subscriptions","organizations_url":"https://api.github.com/users/tonerdo/orgs","repos_url":"https://api.github.com/users/tonerdo/repos","events_url":"https://api.github.com/users/tonerdo/events{/privacy}","received_events_url":"https://api.github.com/users/tonerdo/received_events","type":"User","site_admin":false},"repo":{"id":79130594,"name":"readline","full_name":"tonerdo/readline","owner":{"login":"tonerdo","id":7319262,"avatar_url":"https://avatars3.githubusercontent.com/u/7319262?v=4","gravatar_id":"","url":"https://api.github.com/users/tonerdo","html_url":"https://github.com/tonerdo","followers_url":"https://api.github.com/users/tonerdo/followers","following_url":"https://api.github.com/users/tonerdo/following{/other_user}","gists_url":"https://api.github.com/users/tonerdo/gists{/gist_id}","starred_url":"https://api.github.com/users/tonerdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonerdo/subscriptions","organizations_url":"https://api.github.com/users/tonerdo/orgs","repos_url":"https://api.github.com/users/tonerdo/repos","events_url":"https://api.github.com/users/tonerdo/events{/privacy}","received_events_url":"https://api.github.com/users/tonerdo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tonerdo/readline","description":"A Pure C# GNU-Readline like library for .NET/.NET Core","fork":false,"url":"https://api.github.com/repos/tonerdo/readline","forks_url":"https://api.github.com/repos/tonerdo/readline/forks","keys_url":"https://api.github.com/repos/tonerdo/readline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tonerdo/readline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tonerdo/readline/teams","hooks_url":"https://api.github.com/repos/tonerdo/readline/hooks","issue_events_url":"https://api.github.com/repos/tonerdo/readline/issues/events{/number}","events_url":"https://api.github.com/repos/tonerdo/readline/events","assignees_url":"https://api.github.com/repos/tonerdo/readline/assignees{/user}","branches_url":"https://api.github.com/repos/tonerdo/readline/branches{/branch}","tags_url":"https://api.github.com/repos/tonerdo/readline/tags","blobs_url":"https://api.github.com/repos/tonerdo/readline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tonerdo/readline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tonerdo/readline/git/refs{/sha}","trees_url":"https://api.github.com/repos/tonerdo/readline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tonerdo/readline/statuses/{sha}","languages_url":"https://api.github.com/repos/tonerdo/readline/languages","stargazers_url":"https://api.github.com/repos/tonerdo/readline/stargazers","contributors_url":"https://api.github.com/repos/tonerdo/readline/contributors","subscribers_url":"https://api.github.com/repos/tonerdo/readline/subscribers","subscription_url":"https://api.github.com/repos/tonerdo/readline/subscription","commits_url":"https://api.github.com/repos/tonerdo/readline/commits{/sha}","git_commits_url":"https://api.github.com/repos/tonerdo/readline/git/commits{/sha}","comments_url":"https://api.github.com/repos/tonerdo/readline/comments{/number}","issue_comment_url":"https://api.github.com/repos/tonerdo/readline/issues/comments{/number}","contents_url":"https://api.github.com/repos/tonerdo/readline/contents/{+path}","compare_url":"https://api.github.com/repos/tonerdo/readline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tonerdo/readline/merges","archive_url":"https://api.github.com/repos/tonerdo/readline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tonerdo/readline/downloads","issues_url":"https://api.github.com/repos/tonerdo/readline/issues{/number}","pulls_url":"https://api.github.com/repos/tonerdo/readline/pulls{/number}","milestones_url":"https://api.github.com/repos/tonerdo/readline/milestones{/number}","notifications_url":"https://api.github.com/repos/tonerdo/readline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tonerdo/readline/labels{/name}","releases_url":"https://api.github.com/repos/tonerdo/readline/releases{/id}","deployments_url":"https://api.github.com/repos/tonerdo/readline/deployments","created_at":"2017-01-16T15:15:38Z","updated_at":"2018-05-05T09:43:32Z","pushed_at":"2018-05-05T09:43:30Z","git_url":"git://github.com/tonerdo/readline.git","ssh_url":"git@github.com:tonerdo/readline.git","clone_url":"https://github.com/tonerdo/readline.git","svn_url":"https://github.com/tonerdo/readline","homepage":"","size":85,"stargazers_count":525,"watchers_count":525,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":31,"open_issues":14,"watchers":525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tonerdo/readline/pulls/43"},"html":{"href":"https://github.com/tonerdo/readline/pull/43"},"issue":{"href":"https://api.github.com/repos/tonerdo/readline/issues/43"},"comments":{"href":"https://api.github.com/repos/tonerdo/readline/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/tonerdo/readline/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/tonerdo/readline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tonerdo/readline/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/tonerdo/readline/statuses/062d21f0ee91ee56ad890ad01ccc83e5d10be917"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":220,"deletions":251,"changed_files":3}}
{"actor":{"display_login":"rubberduck203"}}