{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/202274482","pull_request_review_id":136942166,"id":202274482,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjI3NDQ4Mg==","diff_hunk":"@@ -46,7 +48,9 @@ export class DeleteResource extends React.Component {\n \t */\n \tgetLabel() {\n \t\treturn {\n-\t\t\tlabel: this.props.resource ? this.props.resource.get('label', '') : '',\n+\t\t\tlabel: this.props.resource","path":"packages/containers/src/DeleteResource/DeleteResource.container.js","position":null,"original_position":14,"commit_id":"39df8afb14165591064a3d175f3419da09473d81","original_commit_id":"5a9fce112463dc508f26c70c92a221667680c18c","user":{"login":"yyanwang","id":3214228,"node_id":"MDQ6VXNlcjMyMTQyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3214228?v=4","gravatar_id":"","url":"https://api.github.com/users/yyanwang","html_url":"https://github.com/yyanwang","followers_url":"https://api.github.com/users/yyanwang/followers","following_url":"https://api.github.com/users/yyanwang/following{/other_user}","gists_url":"https://api.github.com/users/yyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/yyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyanwang/subscriptions","organizations_url":"https://api.github.com/users/yyanwang/orgs","repos_url":"https://api.github.com/users/yyanwang/repos","events_url":"https://api.github.com/users/yyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/yyanwang/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-07-13T08:10:43Z","updated_at":"2018-07-13T08:10:43Z","html_url":"https://github.com/Talend/ui/pull/1518#discussion_r202274482","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/1518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/202274482"},"html":{"href":"https://github.com/Talend/ui/pull/1518#discussion_r202274482"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/1518"}},"in_reply_to_id":201593047},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/1518","id":199684597,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Njg0NTk3","html_url":"https://github.com/Talend/ui/pull/1518","diff_url":"https://github.com/Talend/ui/pull/1518.diff","patch_url":"https://github.com/Talend/ui/pull/1518.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/1518","number":1518,"state":"open","locked":false,"title":"fix(containers/DeleteResource): fix redirect saga, etc","user":{"login":"yyanwang","id":3214228,"node_id":"MDQ6VXNlcjMyMTQyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3214228?v=4","gravatar_id":"","url":"https://api.github.com/users/yyanwang","html_url":"https://github.com/yyanwang","followers_url":"https://api.github.com/users/yyanwang/followers","following_url":"https://api.github.com/users/yyanwang/following{/other_user}","gists_url":"https://api.github.com/users/yyanwang/gists{/gist_id}","starred_url":"https://api.github.com/users/yyanwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yyanwang/subscriptions","organizations_url":"https://api.github.com/users/yyanwang/orgs","repos_url":"https://api.github.com/users/yyanwang/repos","events_url":"https://api.github.com/users/yyanwang/events{/privacy}","received_events_url":"https://api.github.com/users/yyanwang/received_events","type":"User","site_admin":false},"body":"**What is the problem this PR is trying to solve?**\r\n\r\nresourceType is used for two purpose:\r\n* it is the collection id where all resources of this type is stored in redux\r\n* it is the fragment of URL to call to delete\r\n\r\nMost of the time it can be different.\r\n\r\n**What is the chosen solution to this problem?**\r\n\r\nChange several things about DeleteResource:\r\n* add `redirectUrl` to action model data\r\n* add prop `collectionId` in which stores resources. If not provided then use `resourceType` as collection name.\r\n* add prop `resourceUri` which is used as backend api to delete resource. if not provided then use `${uri}/${resourceType}/${resourceId}`;\r\n* rename actions from `Yes/No` to `DELETE/CANCEL`(according to guidelines).\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n* [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n* [x] Tests for the changes have been added (for bug fixes / features) And [non reg](./screenshots.md) done before need review\r\n* [ ] Docs have been added / updated (for bug fixes / features)\r\n* [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- if the PR introduces a breaking change, add the description here. So when you merge this PR, add this description into the [breaking change wiki](https://github.com/Talend/ui/wiki/BREAKING-CHANGE) in the next version -->\r\n\r\n<!-- **Original Template** -->\r\n\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n","created_at":"2018-07-06T08:54:45Z","updated_at":"2018-07-13T08:10:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"635f2ab35babeae8bfd7b8a761785bd107855d25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":521021722,"node_id":"MDU6TGFiZWw1MjEwMjE3MjI=","url":"https://api.github.com/repos/Talend/ui/labels/need%20review","name":"need review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/1518/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/1518/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/1518/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/39df8afb14165591064a3d175f3419da09473d81","head":{"label":"Talend:ywang/fix/containers/DeleteR3esource/redirectUrl","ref":"ywang/fix/containers/DeleteR3esource/redirectUrl","sha":"39df8afb14165591064a3d175f3419da09473d81","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM0Mzk0Ng==","name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-07-13T07:10:01Z","pushed_at":"2018-07-13T07:55:07Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":30299,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":57,"watchers":56,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"8a9c85ab90791e9cd9a72d075d90da99e1ff526b","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM0Mzk0Ng==","name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-07-13T07:10:01Z","pushed_at":"2018-07-13T07:55:07Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":30299,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":57,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/1518"},"html":{"href":"https://github.com/Talend/ui/pull/1518"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/1518"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/1518/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/1518/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/1518/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/39df8afb14165591064a3d175f3419da09473d81"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yyanwang"}}