{"action":"created","issue":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/23448","repository_url":"https://api.github.com/repos/code-dot-org/code-dot-org","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/23448/labels{/name}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/23448/comments","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/23448/events","html_url":"https://github.com/code-dot-org/code-dot-org/pull/23448","id":337230610,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDg2NTI3","number":23448,"title":"Upgrade ejs to 2.6.1","user":{"login":"islemaster","id":1615761,"node_id":"MDQ6VXNlcjE2MTU3NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1615761?v=4","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"labels":[{"id":399384770,"node_id":"MDU6TGFiZWwzOTkzODQ3NzA=","url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels/code-hygiene","name":"code-hygiene","color":"4d575f","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-30T17:31:48Z","updated_at":"2018-07-03T00:28:19Z","closed_at":"2018-07-03T00:24:37Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/23448","html_url":"https://github.com/code-dot-org/code-dot-org/pull/23448","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/23448.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/23448.patch"},"body":"Upgrades `ejs` from `0.8.4` to `2.6.1`.  Also updates `ejs-compiled-loader`'s dependencies so it uses the same version of `ejs` that we depend on directly.\r\n\r\nHere's the [1.x ejs repository](https://github.com/tj/ejs) and the [2.x ejs repository](https://github.com/mde/ejs).  There are definitely breaking changes in the move to 2.0; the README in the 1.x repository says:\r\n\r\n> NOTE: Version 2 of EJS makes some breaking changes with this version (notably, removal of the filters feature).\r\n\r\nThe [2.x Changelog](https://github.com/mde/ejs/blob/master/CHANGELOG.md#v201-2015-01-02) seems to list breaking changes in its first entry.\r\n\r\n- Single custom delimiter (e.g., `?`) with `delimiter` option instead of `open`/`close` options\r\n  Configuration passed to `compile` or `render` customizing EJS open/close tags.  We don't use this.\r\n- `include` now runtime function call instead of preprocessor directive\r\n  It looks like we never use this.\r\n- Variable-based includes now possible\r\n  Does not sound like a breaking change, and we don't use `include` right now.\r\n- Comment tag support (`<%#`)\r\n  Does not sound like a breaking change, and we don't use this combination of symbols anywhere right now.\r\n- `data` and `options` now separate params (i.e., `render(str, data, options);`)\r\n  This sounds like it should break our code all over the place.  However, we pass options in `compile` whose signature hasn't changed:\r\n  https://github.com/code-dot-org/code-dot-org/blob/9231ab43e52de7b3ba8f25651022030002adf0e5/apps/tasks/ejs.js#L13-L18\r\n  And, as far as I can tell, every place we call render we only pass `data` - and even if we didn't, these calls are backwards-compatible, just in case. See [the new usage docs](https://github.com/mde/ejs#usage)\r\n- Removed support for filters\r\n  I already checked and we're not using the [Filters feature](https://github.com/tj/ejs#filters)."},"comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments/401976645","html_url":"https://github.com/code-dot-org/code-dot-org/pull/23448#issuecomment-401976645","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/23448","id":401976645,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTk3NjY0NQ==","user":{"login":"islemaster","id":1615761,"node_id":"MDQ6VXNlcjE2MTU3NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/1615761?v=4","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T00:28:19Z","updated_at":"2018-07-03T00:28:19Z","author_association":"MEMBER","body":"Noted in the tech debt roadmap under the existing item for converting levels.js content to levelbuilder."}}
{"actor":{"display_login":"islemaster"}}