{"action":"created","comment":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/comments/215341943","pull_request_review_id":152583147,"id":215341943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM0MTk0Mw==","diff_hunk":"@@ -477,6 +483,42 @@ Locale &Locale::operator=(const Locale &other)\n     return *this;\n }\n \n+Locale& Locale::operator=(Locale&& other) U_NOEXCEPT {\n+    if (this == &other) {","path":"icu4c/source/common/locid.cpp","position":18,"original_position":18,"commit_id":"3a099d592cb2d70f6e11562d6b07a338c038f591","original_commit_id":"3a099d592cb2d70f6e11562d6b07a338c038f591","user":{"login":"markusicu","id":12720407,"node_id":"MDQ6VXNlcjEyNzIwNDA3","avatar_url":"https://avatars2.githubusercontent.com/u/12720407?v=4","gravatar_id":"","url":"https://api.github.com/users/markusicu","html_url":"https://github.com/markusicu","followers_url":"https://api.github.com/users/markusicu/followers","following_url":"https://api.github.com/users/markusicu/following{/other_user}","gists_url":"https://api.github.com/users/markusicu/gists{/gist_id}","starred_url":"https://api.github.com/users/markusicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusicu/subscriptions","organizations_url":"https://api.github.com/users/markusicu/orgs","repos_url":"https://api.github.com/users/markusicu/repos","events_url":"https://api.github.com/users/markusicu/events{/privacy}","received_events_url":"https://api.github.com/users/markusicu/received_events","type":"User","site_admin":false},"body":"In UnicodeString::moveFrom() I wrote\r\n  // No explicit check for self move assignment, consistent with standard library.\r\n  // Self move assignment causes no crash nor leak but might make the object bogus.\r\nwhy differ here?","created_at":"2018-09-05T16:33:41Z","updated_at":"2018-09-05T16:38:40Z","html_url":"https://github.com/unicode-org/icu/pull/94#discussion_r215341943","pull_request_url":"https://api.github.com/repos/unicode-org/icu/pulls/94","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments/215341943"},"html":{"href":"https://github.com/unicode-org/icu/pull/94#discussion_r215341943"},"pull_request":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/unicode-org/icu/pulls/94","id":212955052,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyOTU1MDUy","html_url":"https://github.com/unicode-org/icu/pull/94","diff_url":"https://github.com/unicode-org/icu/pull/94.diff","patch_url":"https://github.com/unicode-org/icu/pull/94.patch","issue_url":"https://api.github.com/repos/unicode-org/icu/issues/94","number":94,"state":"open","locked":false,"title":"PAPA ICU-13645 Add C++11 move constructor and assign operator to Locale.","user":{"login":"roubert","id":724587,"node_id":"MDQ6VXNlcjcyNDU4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/724587?v=4","gravatar_id":"","url":"https://api.github.com/users/roubert","html_url":"https://github.com/roubert","followers_url":"https://api.github.com/users/roubert/followers","following_url":"https://api.github.com/users/roubert/following{/other_user}","gists_url":"https://api.github.com/users/roubert/gists{/gist_id}","starred_url":"https://api.github.com/users/roubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roubert/subscriptions","organizations_url":"https://api.github.com/users/roubert/orgs","repos_url":"https://api.github.com/users/roubert/repos","events_url":"https://api.github.com/users/roubert/events{/privacy}","received_events_url":"https://api.github.com/users/roubert/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-04T12:14:49Z","updated_at":"2018-09-05T16:38:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c8e202c427acc7b92685100b14be09faada8247","assignee":{"login":"sffc","id":1145762,"node_id":"MDQ6VXNlcjExNDU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1145762?v=4","gravatar_id":"","url":"https://api.github.com/users/sffc","html_url":"https://github.com/sffc","followers_url":"https://api.github.com/users/sffc/followers","following_url":"https://api.github.com/users/sffc/following{/other_user}","gists_url":"https://api.github.com/users/sffc/gists{/gist_id}","starred_url":"https://api.github.com/users/sffc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sffc/subscriptions","organizations_url":"https://api.github.com/users/sffc/orgs","repos_url":"https://api.github.com/users/sffc/repos","events_url":"https://api.github.com/users/sffc/events{/privacy}","received_events_url":"https://api.github.com/users/sffc/received_events","type":"User","site_admin":false},"assignees":[{"login":"sffc","id":1145762,"node_id":"MDQ6VXNlcjExNDU3NjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1145762?v=4","gravatar_id":"","url":"https://api.github.com/users/sffc","html_url":"https://github.com/sffc","followers_url":"https://api.github.com/users/sffc/followers","following_url":"https://api.github.com/users/sffc/following{/other_user}","gists_url":"https://api.github.com/users/sffc/gists{/gist_id}","starred_url":"https://api.github.com/users/sffc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sffc/subscriptions","organizations_url":"https://api.github.com/users/sffc/orgs","repos_url":"https://api.github.com/users/sffc/repos","events_url":"https://api.github.com/users/sffc/events{/privacy}","received_events_url":"https://api.github.com/users/sffc/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unicode-org/icu/pulls/94/commits","review_comments_url":"https://api.github.com/repos/unicode-org/icu/pulls/94/comments","review_comment_url":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unicode-org/icu/issues/94/comments","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/3a099d592cb2d70f6e11562d6b07a338c038f591","head":{"label":"roubert:13645","ref":"13645","sha":"3a099d592cb2d70f6e11562d6b07a338c038f591","user":{"login":"roubert","id":724587,"node_id":"MDQ6VXNlcjcyNDU4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/724587?v=4","gravatar_id":"","url":"https://api.github.com/users/roubert","html_url":"https://github.com/roubert","followers_url":"https://api.github.com/users/roubert/followers","following_url":"https://api.github.com/users/roubert/following{/other_user}","gists_url":"https://api.github.com/users/roubert/gists{/gist_id}","starred_url":"https://api.github.com/users/roubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roubert/subscriptions","organizations_url":"https://api.github.com/users/roubert/orgs","repos_url":"https://api.github.com/users/roubert/repos","events_url":"https://api.github.com/users/roubert/events{/privacy}","received_events_url":"https://api.github.com/users/roubert/received_events","type":"User","site_admin":false},"repo":{"id":143279543,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNzk1NDM=","name":"icu","full_name":"roubert/icu","owner":{"login":"roubert","id":724587,"node_id":"MDQ6VXNlcjcyNDU4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/724587?v=4","gravatar_id":"","url":"https://api.github.com/users/roubert","html_url":"https://github.com/roubert","followers_url":"https://api.github.com/users/roubert/followers","following_url":"https://api.github.com/users/roubert/following{/other_user}","gists_url":"https://api.github.com/users/roubert/gists{/gist_id}","starred_url":"https://api.github.com/users/roubert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roubert/subscriptions","organizations_url":"https://api.github.com/users/roubert/orgs","repos_url":"https://api.github.com/users/roubert/repos","events_url":"https://api.github.com/users/roubert/events{/privacy}","received_events_url":"https://api.github.com/users/roubert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roubert/icu","description":"The new home of the ICU project source code.","fork":true,"url":"https://api.github.com/repos/roubert/icu","forks_url":"https://api.github.com/repos/roubert/icu/forks","keys_url":"https://api.github.com/repos/roubert/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roubert/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roubert/icu/teams","hooks_url":"https://api.github.com/repos/roubert/icu/hooks","issue_events_url":"https://api.github.com/repos/roubert/icu/issues/events{/number}","events_url":"https://api.github.com/repos/roubert/icu/events","assignees_url":"https://api.github.com/repos/roubert/icu/assignees{/user}","branches_url":"https://api.github.com/repos/roubert/icu/branches{/branch}","tags_url":"https://api.github.com/repos/roubert/icu/tags","blobs_url":"https://api.github.com/repos/roubert/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roubert/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roubert/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/roubert/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roubert/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/roubert/icu/languages","stargazers_url":"https://api.github.com/repos/roubert/icu/stargazers","contributors_url":"https://api.github.com/repos/roubert/icu/contributors","subscribers_url":"https://api.github.com/repos/roubert/icu/subscribers","subscription_url":"https://api.github.com/repos/roubert/icu/subscription","commits_url":"https://api.github.com/repos/roubert/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/roubert/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/roubert/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/roubert/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/roubert/icu/contents/{+path}","compare_url":"https://api.github.com/repos/roubert/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roubert/icu/merges","archive_url":"https://api.github.com/repos/roubert/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roubert/icu/downloads","issues_url":"https://api.github.com/repos/roubert/icu/issues{/number}","pulls_url":"https://api.github.com/repos/roubert/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/roubert/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/roubert/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roubert/icu/labels{/name}","releases_url":"https://api.github.com/repos/roubert/icu/releases{/id}","deployments_url":"https://api.github.com/repos/roubert/icu/deployments","created_at":"2018-08-02T10:27:50Z","updated_at":"2018-09-04T11:54:14Z","pushed_at":"2018-09-04T20:57:45Z","git_url":"git://github.com/roubert/icu.git","ssh_url":"git@github.com:roubert/icu.git","clone_url":"https://github.com/roubert/icu.git","svn_url":"https://github.com/roubert/icu","homepage":"http://icu-project.org","size":202671,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unicode-org:master","ref":"master","sha":"e59a297a7a64d80e6179cfd00cbe16f95ed1869a","user":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"repo":{"id":49244766,"node_id":"MDEwOlJlcG9zaXRvcnk0OTI0NDc2Ng==","name":"icu","full_name":"unicode-org/icu","owner":{"login":"unicode-org","id":13873561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODczNTYx","avatar_url":"https://avatars2.githubusercontent.com/u/13873561?v=4","gravatar_id":"","url":"https://api.github.com/users/unicode-org","html_url":"https://github.com/unicode-org","followers_url":"https://api.github.com/users/unicode-org/followers","following_url":"https://api.github.com/users/unicode-org/following{/other_user}","gists_url":"https://api.github.com/users/unicode-org/gists{/gist_id}","starred_url":"https://api.github.com/users/unicode-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unicode-org/subscriptions","organizations_url":"https://api.github.com/users/unicode-org/orgs","repos_url":"https://api.github.com/users/unicode-org/repos","events_url":"https://api.github.com/users/unicode-org/events{/privacy}","received_events_url":"https://api.github.com/users/unicode-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/unicode-org/icu","description":"The new home of the ICU project source code.","fork":false,"url":"https://api.github.com/repos/unicode-org/icu","forks_url":"https://api.github.com/repos/unicode-org/icu/forks","keys_url":"https://api.github.com/repos/unicode-org/icu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unicode-org/icu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unicode-org/icu/teams","hooks_url":"https://api.github.com/repos/unicode-org/icu/hooks","issue_events_url":"https://api.github.com/repos/unicode-org/icu/issues/events{/number}","events_url":"https://api.github.com/repos/unicode-org/icu/events","assignees_url":"https://api.github.com/repos/unicode-org/icu/assignees{/user}","branches_url":"https://api.github.com/repos/unicode-org/icu/branches{/branch}","tags_url":"https://api.github.com/repos/unicode-org/icu/tags","blobs_url":"https://api.github.com/repos/unicode-org/icu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unicode-org/icu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unicode-org/icu/git/refs{/sha}","trees_url":"https://api.github.com/repos/unicode-org/icu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unicode-org/icu/statuses/{sha}","languages_url":"https://api.github.com/repos/unicode-org/icu/languages","stargazers_url":"https://api.github.com/repos/unicode-org/icu/stargazers","contributors_url":"https://api.github.com/repos/unicode-org/icu/contributors","subscribers_url":"https://api.github.com/repos/unicode-org/icu/subscribers","subscription_url":"https://api.github.com/repos/unicode-org/icu/subscription","commits_url":"https://api.github.com/repos/unicode-org/icu/commits{/sha}","git_commits_url":"https://api.github.com/repos/unicode-org/icu/git/commits{/sha}","comments_url":"https://api.github.com/repos/unicode-org/icu/comments{/number}","issue_comment_url":"https://api.github.com/repos/unicode-org/icu/issues/comments{/number}","contents_url":"https://api.github.com/repos/unicode-org/icu/contents/{+path}","compare_url":"https://api.github.com/repos/unicode-org/icu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unicode-org/icu/merges","archive_url":"https://api.github.com/repos/unicode-org/icu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unicode-org/icu/downloads","issues_url":"https://api.github.com/repos/unicode-org/icu/issues{/number}","pulls_url":"https://api.github.com/repos/unicode-org/icu/pulls{/number}","milestones_url":"https://api.github.com/repos/unicode-org/icu/milestones{/number}","notifications_url":"https://api.github.com/repos/unicode-org/icu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unicode-org/icu/labels{/name}","releases_url":"https://api.github.com/repos/unicode-org/icu/releases{/id}","deployments_url":"https://api.github.com/repos/unicode-org/icu/deployments","created_at":"2016-01-08T02:42:32Z","updated_at":"2018-09-04T14:06:42Z","pushed_at":"2018-09-04T22:09:13Z","git_url":"git://github.com/unicode-org/icu.git","ssh_url":"git@github.com:unicode-org/icu.git","clone_url":"https://github.com/unicode-org/icu.git","svn_url":"https://github.com/unicode-org/icu","homepage":"http://icu-project.org","size":238750,"stargazers_count":136,"watchers_count":136,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":50,"open_issues":21,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/94"},"html":{"href":"https://github.com/unicode-org/icu/pull/94"},"issue":{"href":"https://api.github.com/repos/unicode-org/icu/issues/94"},"comments":{"href":"https://api.github.com/repos/unicode-org/icu/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unicode-org/icu/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/unicode-org/icu/statuses/3a099d592cb2d70f6e11562d6b07a338c038f591"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"markusicu"}}