{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/233266984","pull_request_review_id":174641983,"id":233266984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzI2Njk4NA==","diff_hunk":"@@ -178,7 +150,117 @@ public async Task ReceiveAsync_ServerSplitHeader_ValidDataReceived()\n             }\n         }\n \n+        [OuterLoop] // Connects to external server.\n+        [Theory]\n+        [MemberData(nameof(EchoServersAndBoolean))]\n+        public async Task WebSocketProtocol_CreateFromConnectedStream_CloseAsyncClosesStream(Uri echoUri, bool explicitCloseAsync)\n+        {\n+            using (var client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp))\n+            {\n+                bool secure = echoUri.Scheme == \"wss\";\n+                client.Connect(echoUri.Host, secure ? 443 : 80);\n+\n+                using (Stream stream = await CreateWebSocketStream(echoUri, client, secure))\n+                {\n+                    using (WebSocket socket = CreateFromStream(stream, false, null, TimeSpan.FromSeconds(10)))\n+                    {\n+                        Assert.NotNull(socket);\n+                        Assert.Equal(WebSocketState.Open, socket.State);\n+\n+                        Assert.True(stream.CanRead);\n+                        Assert.True(stream.CanWrite);\n+\n+                        if (explicitCloseAsync) // make sure CloseAsync ends up disposing the stream\n+                        {\n+                            await socket.CloseAsync(WebSocketCloseStatus.NormalClosure, \"\", CancellationToken.None);\n+                            Assert.False(stream.CanRead);\n+                            Assert.False(stream.CanWrite);\n+                        }\n+                    }\n+\n+                    Assert.False(stream.CanRead);\n+                    Assert.False(stream.CanWrite);\n+                }\n+            }\n+        }\n+\n+        [OuterLoop] // Connects to external server.\n+        [Theory]\n+        [MemberData(nameof(EchoServersAndBoolean))]\n+        public async Task WebSocketProtocol_CreateFromConnectedStream_CloseAsyncAfterCloseReceivedClosesStream(Uri echoUri, bool useCloseOutputAsync)\n+        {\n+            using (var client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp))\n+            {\n+                bool secure = echoUri.Scheme == \"wss\";\n+                client.Connect(echoUri.Host, secure ? 443 : 80);\n+\n+                using (Stream stream = await CreateWebSocketStream(echoUri, client, secure))\n+                using (WebSocket socket = CreateFromStream(stream, false, null, TimeSpan.FromSeconds(10)))\n+                {\n+                    Assert.NotNull(socket);\n+                    Assert.Equal(WebSocketState.Open, socket.State);\n+\n+                    // Ask server to send us a close\n+                    await socket.SendAsync(Encoding.UTF8.GetBytes(\".close\"), WebSocketMessageType.Text, true, default);\n+\n+                    // Verify received server-initiated close message.\n+                    WebSocketReceiveResult recvResult = await socket.ReceiveAsync(new byte[256], default);\n+                    Assert.Equal(WebSocketCloseStatus.NormalClosure, recvResult.CloseStatus);\n+                    Assert.Equal(WebSocketCloseStatus.NormalClosure, socket.CloseStatus);\n+                    Assert.Equal(WebSocketState.CloseReceived, socket.State);\n+\n+                    Assert.True(stream.CanRead);\n+                    Assert.True(stream.CanWrite);\n+\n+                    await (useCloseOutputAsync ?\n+                        socket.CloseOutputAsync(WebSocketCloseStatus.NormalClosure, \"\", CancellationToken.None) :\n+                        socket.CloseAsync(WebSocketCloseStatus.NormalClosure, \"\", CancellationToken.None));\n+\n+                    Assert.False(stream.CanRead);\n+                    Assert.False(stream.CanWrite);\n+                }\n+            }\n+        }\n+\n+        private static async Task<Stream> CreateWebSocketStream(Uri echoUri, Socket client, bool secure)\n+        {\n+            Stream stream = new NetworkStream(client, ownsSocket: false);","path":"src/Common/tests/System/Net/WebSockets/WebSocketCreateTest.cs","position":146,"original_position":146,"commit_id":"d94274da6f91970c47b75ba6b040063da277d282","original_commit_id":"d94274da6f91970c47b75ba6b040063da277d282","user":{"login":"davidsh","id":7684835,"node_id":"MDQ6VXNlcjc2ODQ4MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7684835?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsh","html_url":"https://github.com/davidsh","followers_url":"https://api.github.com/users/davidsh/followers","following_url":"https://api.github.com/users/davidsh/following{/other_user}","gists_url":"https://api.github.com/users/davidsh/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsh/subscriptions","organizations_url":"https://api.github.com/users/davidsh/orgs","repos_url":"https://api.github.com/users/davidsh/repos","events_url":"https://api.github.com/users/davidsh/events{/privacy}","received_events_url":"https://api.github.com/users/davidsh/received_events","type":"User","site_admin":false},"body":"nit: can use 'var'.","created_at":"2018-11-13T23:47:03Z","updated_at":"2018-11-13T23:47:03Z","html_url":"https://github.com/dotnet/corefx/pull/33473#discussion_r233266984","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/33473","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/233266984"},"html":{"href":"https://github.com/dotnet/corefx/pull/33473#discussion_r233266984"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33473"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/33473","id":230662074,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjYyMDc0","html_url":"https://github.com/dotnet/corefx/pull/33473","diff_url":"https://github.com/dotnet/corefx/pull/33473.diff","patch_url":"https://github.com/dotnet/corefx/pull/33473.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/33473","number":33473,"state":"open","locked":false,"title":"Ensure ManagedWebSocket.CloseOutputAsync closes the underlying stream","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"body":"When we issue a close, we then wait for the response close message, and after receiving it, dispose of the web socket instance, which then closes the stream.  We don't currently do the same when sending a close frame having already received a close frame, but we should.\r\n\r\nFixes https://github.com/dotnet/corefx/issues/33339\r\ncc: @davidsh, @anurse ","created_at":"2018-11-13T23:34:29Z","updated_at":"2018-11-13T23:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16945b9d6a300bd786456a4080b06bfc1977fcf9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/33473/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/33473/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/33473/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/d94274da6f91970c47b75ba6b040063da277d282","head":{"label":"stephentoub:fixmwscloseoutput","ref":"fixmwscloseoutput","sha":"d94274da6f91970c47b75ba6b040063da277d282","user":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"repo":{"id":26551529,"node_id":"MDEwOlJlcG9zaXRvcnkyNjU1MTUyOQ==","name":"corefx","full_name":"stephentoub/corefx","private":false,"owner":{"login":"stephentoub","id":2642209,"node_id":"MDQ6VXNlcjI2NDIyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/2642209?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentoub","html_url":"https://github.com/stephentoub","followers_url":"https://api.github.com/users/stephentoub/followers","following_url":"https://api.github.com/users/stephentoub/following{/other_user}","gists_url":"https://api.github.com/users/stephentoub/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentoub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentoub/subscriptions","organizations_url":"https://api.github.com/users/stephentoub/orgs","repos_url":"https://api.github.com/users/stephentoub/repos","events_url":"https://api.github.com/users/stephentoub/events{/privacy}","received_events_url":"https://api.github.com/users/stephentoub/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stephentoub/corefx","description":"This repository contains the foundational libraries that make up the .NET Core development stack.","fork":true,"url":"https://api.github.com/repos/stephentoub/corefx","forks_url":"https://api.github.com/repos/stephentoub/corefx/forks","keys_url":"https://api.github.com/repos/stephentoub/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephentoub/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephentoub/corefx/teams","hooks_url":"https://api.github.com/repos/stephentoub/corefx/hooks","issue_events_url":"https://api.github.com/repos/stephentoub/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/stephentoub/corefx/events","assignees_url":"https://api.github.com/repos/stephentoub/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/stephentoub/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/stephentoub/corefx/tags","blobs_url":"https://api.github.com/repos/stephentoub/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephentoub/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephentoub/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephentoub/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephentoub/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/stephentoub/corefx/languages","stargazers_url":"https://api.github.com/repos/stephentoub/corefx/stargazers","contributors_url":"https://api.github.com/repos/stephentoub/corefx/contributors","subscribers_url":"https://api.github.com/repos/stephentoub/corefx/subscribers","subscription_url":"https://api.github.com/repos/stephentoub/corefx/subscription","commits_url":"https://api.github.com/repos/stephentoub/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephentoub/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephentoub/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephentoub/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephentoub/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/stephentoub/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephentoub/corefx/merges","archive_url":"https://api.github.com/repos/stephentoub/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephentoub/corefx/downloads","issues_url":"https://api.github.com/repos/stephentoub/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/stephentoub/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/stephentoub/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/stephentoub/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephentoub/corefx/labels{/name}","releases_url":"https://api.github.com/repos/stephentoub/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/stephentoub/corefx/deployments","created_at":"2014-11-12T19:06:24Z","updated_at":"2018-11-13T23:37:43Z","pushed_at":"2018-11-13T23:37:40Z","git_url":"git://github.com/stephentoub/corefx.git","ssh_url":"git@github.com:stephentoub/corefx.git","clone_url":"https://github.com/stephentoub/corefx.git","svn_url":"https://github.com/stephentoub/corefx","homepage":"","size":184643,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e33f5f2b75b93e454efba5906dd160b1099112f2","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-11-13T21:43:58Z","pushed_at":"2018-11-13T23:34:29Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":192229,"stargazers_count":15134,"watchers_count":15134,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4482,"mirror_url":null,"archived":false,"open_issues_count":2612,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4482,"open_issues":2612,"watchers":15134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33473"},"html":{"href":"https://github.com/dotnet/corefx/pull/33473"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33473"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/33473/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33473/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/33473/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/d94274da6f91970c47b75ba6b040063da277d282"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidsh"}}