{"action":"created","comment":{"url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/comments/234422958","pull_request_review_id":176069222,"id":234422958,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQyMjk1OA==","diff_hunk":"@@ -16,6 +16,9 @@ class SGECluster(JobQueueCluster):\n     ----------\n     queue : str\n         Destination queue for each worker job. Passed to `#$ -q` option.\n+    memory: str\n+        The amount of memory requested per worker job. Passed to `#$ -l` option. Can be\n+        specified in lieu of `resource_spec`.","path":"dask_jobqueue/sge.py","position":6,"original_position":6,"commit_id":"695535e7be512cd7417156fc41546788725f4295","original_commit_id":"695535e7be512cd7417156fc41546788725f4295","user":{"login":"guillaumeeb","id":17138587,"node_id":"MDQ6VXNlcjE3MTM4NTg3","avatar_url":"https://avatars0.githubusercontent.com/u/17138587?v=4","gravatar_id":"","url":"https://api.github.com/users/guillaumeeb","html_url":"https://github.com/guillaumeeb","followers_url":"https://api.github.com/users/guillaumeeb/followers","following_url":"https://api.github.com/users/guillaumeeb/following{/other_user}","gists_url":"https://api.github.com/users/guillaumeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/guillaumeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillaumeeb/subscriptions","organizations_url":"https://api.github.com/users/guillaumeeb/orgs","repos_url":"https://api.github.com/users/guillaumeeb/repos","events_url":"https://api.github.com/users/guillaumeeb/events{/privacy}","received_events_url":"https://api.github.com/users/guillaumeeb/received_events","type":"User","site_admin":false},"body":"Not sure you should override default docstring here. The addition you mademoiselle should be implicit, even if it is not the case currently.","created_at":"2018-11-17T22:02:46Z","updated_at":"2018-11-17T22:13:59Z","html_url":"https://github.com/dask/dask-jobqueue/pull/197#discussion_r234422958","pull_request_url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dask/dask-jobqueue/pulls/comments/234422958"},"html":{"href":"https://github.com/dask/dask-jobqueue/pull/197#discussion_r234422958"},"pull_request":{"href":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197","id":231641629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjQxNjI5","html_url":"https://github.com/dask/dask-jobqueue/pull/197","diff_url":"https://github.com/dask/dask-jobqueue/pull/197.diff","patch_url":"https://github.com/dask/dask-jobqueue/pull/197.patch","issue_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/197","number":197,"state":"open","locked":false,"title":"added a memory string parser","user":{"login":"ericmjl","id":2631566,"node_id":"MDQ6VXNlcjI2MzE1NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2631566?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmjl","html_url":"https://github.com/ericmjl","followers_url":"https://api.github.com/users/ericmjl/followers","following_url":"https://api.github.com/users/ericmjl/following{/other_user}","gists_url":"https://api.github.com/users/ericmjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmjl/subscriptions","organizations_url":"https://api.github.com/users/ericmjl/orgs","repos_url":"https://api.github.com/users/ericmjl/repos","events_url":"https://api.github.com/users/ericmjl/events{/privacy}","received_events_url":"https://api.github.com/users/ericmjl/received_events","type":"User","site_admin":false},"body":"cc: @jhamman, @sntgluca, @guillaumeeb \r\n\r\nI am proceeding with very small steps with this PR. This PR is a very focused one, and only adds a memory string parser, such that an end-user can specify the amount of RAM that they would like per worker node.\r\n\r\nI have done the following:\r\n\r\n- Added a memory string parser\r\n- Updated the docstring to state that memory is a kwarg that can be specified in lieu of the resource string.\r\n\r\nIf I remember correctly, I can use multiple lines to specify resources. Hence:\r\n\r\n```\r\n#$ -l m_mem_free=8G\r\n#$ -l h_rt=1500000\r\n``` \r\n\r\nshould be equivalent to:\r\n\r\n```\r\n#$ -l m_mem_free=8G,h_rt=1500000\r\n```\r\n\r\n@sntgluca, can you confirm/disprove my memory on this?\r\n\r\nStill wondering about the following:\r\n\r\n- Should I add a test for the memory string parser? If so, where is the best place to put it?\r\n- Should I append to the example shown in the SGECluster docstring?\r\n\r\nIf merged, then this PR resolves in part #195, but not fully.","created_at":"2018-11-16T20:06:45Z","updated_at":"2018-11-17T22:13:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8664c1247a37a9633611d2af09f46e41a37e9eac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197/commits","review_comments_url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197/comments","review_comment_url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/197/comments","statuses_url":"https://api.github.com/repos/dask/dask-jobqueue/statuses/695535e7be512cd7417156fc41546788725f4295","head":{"label":"ericmjl:parse-memory","ref":"parse-memory","sha":"695535e7be512cd7417156fc41546788725f4295","user":{"login":"ericmjl","id":2631566,"node_id":"MDQ6VXNlcjI2MzE1NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2631566?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmjl","html_url":"https://github.com/ericmjl","followers_url":"https://api.github.com/users/ericmjl/followers","following_url":"https://api.github.com/users/ericmjl/following{/other_user}","gists_url":"https://api.github.com/users/ericmjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmjl/subscriptions","organizations_url":"https://api.github.com/users/ericmjl/orgs","repos_url":"https://api.github.com/users/ericmjl/repos","events_url":"https://api.github.com/users/ericmjl/events{/privacy}","received_events_url":"https://api.github.com/users/ericmjl/received_events","type":"User","site_admin":false},"repo":{"id":138161497,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNjE0OTc=","name":"dask-jobqueue","full_name":"ericmjl/dask-jobqueue","private":false,"owner":{"login":"ericmjl","id":2631566,"node_id":"MDQ6VXNlcjI2MzE1NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2631566?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmjl","html_url":"https://github.com/ericmjl","followers_url":"https://api.github.com/users/ericmjl/followers","following_url":"https://api.github.com/users/ericmjl/following{/other_user}","gists_url":"https://api.github.com/users/ericmjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmjl/subscriptions","organizations_url":"https://api.github.com/users/ericmjl/orgs","repos_url":"https://api.github.com/users/ericmjl/repos","events_url":"https://api.github.com/users/ericmjl/events{/privacy}","received_events_url":"https://api.github.com/users/ericmjl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ericmjl/dask-jobqueue","description":"Deploy Dask on job schedulers like PBS, SLURM, and SGE","fork":true,"url":"https://api.github.com/repos/ericmjl/dask-jobqueue","forks_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/forks","keys_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/teams","hooks_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/hooks","issue_events_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/issues/events{/number}","events_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/events","assignees_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/assignees{/user}","branches_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/branches{/branch}","tags_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/tags","blobs_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/statuses/{sha}","languages_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/languages","stargazers_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/stargazers","contributors_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/contributors","subscribers_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/subscribers","subscription_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/subscription","commits_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/contents/{+path}","compare_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/merges","archive_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/downloads","issues_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/issues{/number}","pulls_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/pulls{/number}","milestones_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/milestones{/number}","notifications_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/labels{/name}","releases_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/releases{/id}","deployments_url":"https://api.github.com/repos/ericmjl/dask-jobqueue/deployments","created_at":"2018-06-21T11:28:36Z","updated_at":"2018-06-24T21:59:54Z","pushed_at":"2018-11-16T20:02:50Z","git_url":"git://github.com/ericmjl/dask-jobqueue.git","ssh_url":"git@github.com:ericmjl/dask-jobqueue.git","clone_url":"https://github.com/ericmjl/dask-jobqueue.git","svn_url":"https://github.com/ericmjl/dask-jobqueue","homepage":"https://dask-jobqueue.readthedocs.io","size":265,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dask:master","ref":"master","sha":"cb62fa4a194e0b7db086a913f00ed0bd0957898e","user":{"login":"dask","id":17131925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"repo":{"id":123497963,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0OTc5NjM=","name":"dask-jobqueue","full_name":"dask/dask-jobqueue","private":false,"owner":{"login":"dask","id":17131925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MTMxOTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17131925?v=4","gravatar_id":"","url":"https://api.github.com/users/dask","html_url":"https://github.com/dask","followers_url":"https://api.github.com/users/dask/followers","following_url":"https://api.github.com/users/dask/following{/other_user}","gists_url":"https://api.github.com/users/dask/gists{/gist_id}","starred_url":"https://api.github.com/users/dask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dask/subscriptions","organizations_url":"https://api.github.com/users/dask/orgs","repos_url":"https://api.github.com/users/dask/repos","events_url":"https://api.github.com/users/dask/events{/privacy}","received_events_url":"https://api.github.com/users/dask/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dask/dask-jobqueue","description":"Deploy Dask on job schedulers like PBS, SLURM, and SGE","fork":false,"url":"https://api.github.com/repos/dask/dask-jobqueue","forks_url":"https://api.github.com/repos/dask/dask-jobqueue/forks","keys_url":"https://api.github.com/repos/dask/dask-jobqueue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dask/dask-jobqueue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dask/dask-jobqueue/teams","hooks_url":"https://api.github.com/repos/dask/dask-jobqueue/hooks","issue_events_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/events{/number}","events_url":"https://api.github.com/repos/dask/dask-jobqueue/events","assignees_url":"https://api.github.com/repos/dask/dask-jobqueue/assignees{/user}","branches_url":"https://api.github.com/repos/dask/dask-jobqueue/branches{/branch}","tags_url":"https://api.github.com/repos/dask/dask-jobqueue/tags","blobs_url":"https://api.github.com/repos/dask/dask-jobqueue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dask/dask-jobqueue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dask/dask-jobqueue/git/refs{/sha}","trees_url":"https://api.github.com/repos/dask/dask-jobqueue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dask/dask-jobqueue/statuses/{sha}","languages_url":"https://api.github.com/repos/dask/dask-jobqueue/languages","stargazers_url":"https://api.github.com/repos/dask/dask-jobqueue/stargazers","contributors_url":"https://api.github.com/repos/dask/dask-jobqueue/contributors","subscribers_url":"https://api.github.com/repos/dask/dask-jobqueue/subscribers","subscription_url":"https://api.github.com/repos/dask/dask-jobqueue/subscription","commits_url":"https://api.github.com/repos/dask/dask-jobqueue/commits{/sha}","git_commits_url":"https://api.github.com/repos/dask/dask-jobqueue/git/commits{/sha}","comments_url":"https://api.github.com/repos/dask/dask-jobqueue/comments{/number}","issue_comment_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/comments{/number}","contents_url":"https://api.github.com/repos/dask/dask-jobqueue/contents/{+path}","compare_url":"https://api.github.com/repos/dask/dask-jobqueue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dask/dask-jobqueue/merges","archive_url":"https://api.github.com/repos/dask/dask-jobqueue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dask/dask-jobqueue/downloads","issues_url":"https://api.github.com/repos/dask/dask-jobqueue/issues{/number}","pulls_url":"https://api.github.com/repos/dask/dask-jobqueue/pulls{/number}","milestones_url":"https://api.github.com/repos/dask/dask-jobqueue/milestones{/number}","notifications_url":"https://api.github.com/repos/dask/dask-jobqueue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dask/dask-jobqueue/labels{/name}","releases_url":"https://api.github.com/repos/dask/dask-jobqueue/releases{/id}","deployments_url":"https://api.github.com/repos/dask/dask-jobqueue/deployments","created_at":"2018-03-01T22:07:33Z","updated_at":"2018-11-15T08:59:27Z","pushed_at":"2018-11-16T20:06:45Z","git_url":"git://github.com/dask/dask-jobqueue.git","ssh_url":"git@github.com:dask/dask-jobqueue.git","clone_url":"https://github.com/dask/dask-jobqueue.git","svn_url":"https://github.com/dask/dask-jobqueue","homepage":"https://dask-jobqueue.readthedocs.io","size":262,"stargazers_count":63,"watchers_count":63,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":34,"open_issues":24,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197"},"html":{"href":"https://github.com/dask/dask-jobqueue/pull/197"},"issue":{"href":"https://api.github.com/repos/dask/dask-jobqueue/issues/197"},"comments":{"href":"https://api.github.com/repos/dask/dask-jobqueue/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/dask/dask-jobqueue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dask/dask-jobqueue/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/dask/dask-jobqueue/statuses/695535e7be512cd7417156fc41546788725f4295"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"guillaumeeb"}}