{"action":"created","issue":{"url":"https://api.github.com/repos/jesseduffield/lazygit/issues/309","repository_url":"https://api.github.com/repos/jesseduffield/lazygit","labels_url":"https://api.github.com/repos/jesseduffield/lazygit/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/jesseduffield/lazygit/issues/309/comments","events_url":"https://api.github.com/repos/jesseduffield/lazygit/issues/309/events","html_url":"https://github.com/jesseduffield/lazygit/pull/309","id":371218416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzE1MTM2","number":309,"title":"Add password and/or username question  #81 #145","user":{"login":"mjarkk","id":15320763,"node_id":"MDQ6VXNlcjE1MzIwNzYz","avatar_url":"https://avatars3.githubusercontent.com/u/15320763?v=4","gravatar_id":"","url":"https://api.github.com/users/mjarkk","html_url":"https://github.com/mjarkk","followers_url":"https://api.github.com/users/mjarkk/followers","following_url":"https://api.github.com/users/mjarkk/following{/other_user}","gists_url":"https://api.github.com/users/mjarkk/gists{/gist_id}","starred_url":"https://api.github.com/users/mjarkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjarkk/subscriptions","organizations_url":"https://api.github.com/users/mjarkk/orgs","repos_url":"https://api.github.com/users/mjarkk/repos","events_url":"https://api.github.com/users/mjarkk/events{/privacy}","received_events_url":"https://api.github.com/users/mjarkk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-10-17T18:50:18Z","updated_at":"2018-11-14T09:56:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jesseduffield/lazygit/pulls/309","html_url":"https://github.com/jesseduffield/lazygit/pull/309","diff_url":"https://github.com/jesseduffield/lazygit/pull/309.diff","patch_url":"https://github.com/jesseduffield/lazygit/pull/309.patch"},"body":"Today i found a fix for #81 #145 *(only for UNIX based systems)*  \r\nUsing this fix it's possible to fully run `git push` in the background and send every new word that the terminal prints to a function and write data to the terminal from that function without having any side effects from and to gocui\r\n\r\n**Note:** This fix doesn't work on windows due to a compile error that's why i fallback on the old way for windows There are a view ways to get this working on windows but there are a lot of problems that come with that like when you run this from git bash it executes the sub process in another shell what maybe doesn't have git and the amount of extra code to add to only get this working on windows. a view other things you'll probably need can be found [here](https://github.com/rprichard/winpty#prerequisites)"},"comment":{"url":"https://api.github.com/repos/jesseduffield/lazygit/issues/comments/438604235","html_url":"https://github.com/jesseduffield/lazygit/pull/309#issuecomment-438604235","issue_url":"https://api.github.com/repos/jesseduffield/lazygit/issues/309","id":438604235,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODYwNDIzNQ==","user":{"login":"jesseduffield","id":8456633,"node_id":"MDQ6VXNlcjg0NTY2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/8456633?v=4","gravatar_id":"","url":"https://api.github.com/users/jesseduffield","html_url":"https://github.com/jesseduffield","followers_url":"https://api.github.com/users/jesseduffield/followers","following_url":"https://api.github.com/users/jesseduffield/following{/other_user}","gists_url":"https://api.github.com/users/jesseduffield/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseduffield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseduffield/subscriptions","organizations_url":"https://api.github.com/users/jesseduffield/orgs","repos_url":"https://api.github.com/users/jesseduffield/repos","events_url":"https://api.github.com/users/jesseduffield/events{/privacy}","received_events_url":"https://api.github.com/users/jesseduffield/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T09:56:03Z","updated_at":"2018-11-14T09:56:03Z","author_association":"OWNER","body":"I've come across another issue where after successfully entering a username/password, after waiting for a bit, the application freezes. This actually reminds me of a bug that I had with the commit message  where it would be sent to the back of the panels out of view, but would keep focus, and it would be impossible to restore focus to the normal panels. I'm not sure if that's what's happening here, maybe it's an issue with stdin not being given back to lazygit.\r\n\r\nThe closest I can get to a reliably reproduction of the error is to try pushing, then when the prompt comes up asking for the username, just leave it there for a while, and then you'll get the following image, without the ability to exit or do anything:\r\n\r\n![image](https://user-images.githubusercontent.com/8456633/48474904-aa2df880-e84f-11e8-965c-79d7c5d634c2.png)\r\n"}}
{"actor":{"display_login":"jesseduffield"}}