{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27518","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27518/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27518/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27518/events","html_url":"https://github.com/cockroachdb/cockroach/pull/27518","id":341124435,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzcyNjE1","number":27518,"title":"storage: add replica to unquiesced map only after raft group is init'd","user":{"login":"spencerkimball","id":6147149,"node_id":"MDQ6VXNlcjYxNDcxNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6147149?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-13T18:53:53Z","updated_at":"2018-07-20T00:33:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/27518","html_url":"https://github.com/cockroachdb/cockroach/pull/27518","diff_url":"https://github.com/cockroachdb/cockroach/pull/27518.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/27518.patch"},"body":"Previously, we were adding all newly created replicas directly to the\r\nstore's `unquiescedReplicas` map, where they'd stay, despite being\r\nquiesced, until the raft group was lazily loaded. They'd be continually\r\nticked because `Replica.tick()` preemptively exits if the Raft group\r\nhasn't yet been loaded.\r\n\r\nThis change moves adding the replica to the `unquiescedReplicas` map\r\nuntil after the Raft group is first created, allowing it to be ticked\r\nat least once.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/406454149","html_url":"https://github.com/cockroachdb/cockroach/pull/27518#issuecomment-406454149","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/27518","id":406454149,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjQ1NDE0OQ==","user":{"login":"spencerkimball","id":6147149,"node_id":"MDQ6VXNlcjYxNDcxNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6147149?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T00:33:50Z","updated_at":"2018-07-20T00:33:50Z","author_association":"MEMBER","body":"@bdarnell I've simplified the change and also discovered why we do need to add the replica to the `unquiescedReplicas` map when adding to the store in some cases."}}
{"actor":{"display_login":"spencerkimball"}}