{"action":"created","issue":{"url":"https://api.github.com/repos/milesgranger/gap_statistic/issues/14","repository_url":"https://api.github.com/repos/milesgranger/gap_statistic","labels_url":"https://api.github.com/repos/milesgranger/gap_statistic/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/milesgranger/gap_statistic/issues/14/comments","events_url":"https://api.github.com/repos/milesgranger/gap_statistic/issues/14/events","html_url":"https://github.com/milesgranger/gap_statistic/issues/14","id":342182621,"node_id":"MDU6SXNzdWUzNDIxODI2MjE=","number":14,"title":"gap statistic calculation incorrect?","user":{"login":"rakshita95","id":29198165,"node_id":"MDQ6VXNlcjI5MTk4MTY1","avatar_url":"https://avatars3.githubusercontent.com/u/29198165?v=4","gravatar_id":"","url":"https://api.github.com/users/rakshita95","html_url":"https://github.com/rakshita95","followers_url":"https://api.github.com/users/rakshita95/followers","following_url":"https://api.github.com/users/rakshita95/following{/other_user}","gists_url":"https://api.github.com/users/rakshita95/gists{/gist_id}","starred_url":"https://api.github.com/users/rakshita95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakshita95/subscriptions","organizations_url":"https://api.github.com/users/rakshita95/orgs","repos_url":"https://api.github.com/users/rakshita95/repos","events_url":"https://api.github.com/users/rakshita95/events{/privacy}","received_events_url":"https://api.github.com/users/rakshita95/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-18T05:32:55Z","updated_at":"2018-07-19T00:43:08Z","closed_at":null,"author_association":"NONE","body":"Look at this notebook, I noticed that you are calculating gap statistic as:\r\n`gap = np.log(np.mean(refDisps)) - np.log(origDisp)`\r\n\r\nShouldn't it be `gap = np.mean(np.log(refDisps)) - np.log(origDisp)` instead?\r\n"},"comment":{"url":"https://api.github.com/repos/milesgranger/gap_statistic/issues/comments/406117708","html_url":"https://github.com/milesgranger/gap_statistic/issues/14#issuecomment-406117708","issue_url":"https://api.github.com/repos/milesgranger/gap_statistic/issues/14","id":406117708,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjExNzcwOA==","user":{"login":"milesgranger","id":13764397,"node_id":"MDQ6VXNlcjEzNzY0Mzk3","avatar_url":"https://avatars2.githubusercontent.com/u/13764397?v=4","gravatar_id":"","url":"https://api.github.com/users/milesgranger","html_url":"https://github.com/milesgranger","followers_url":"https://api.github.com/users/milesgranger/followers","following_url":"https://api.github.com/users/milesgranger/following{/other_user}","gists_url":"https://api.github.com/users/milesgranger/gists{/gist_id}","starred_url":"https://api.github.com/users/milesgranger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milesgranger/subscriptions","organizations_url":"https://api.github.com/users/milesgranger/orgs","repos_url":"https://api.github.com/users/milesgranger/repos","events_url":"https://api.github.com/users/milesgranger/events{/privacy}","received_events_url":"https://api.github.com/users/milesgranger/received_events","type":"User","site_admin":false},"created_at":"2018-07-19T00:43:08Z","updated_at":"2018-07-19T00:43:08Z","author_association":"OWNER","body":"Great, I'll look more into this later, thanks. Feel free to open a PR yourself if you'd like, might take me a while to get around to this. "}}
{"actor":{"display_login":"milesgranger"}}