{"action":"created","comment":{"url":"https://api.github.com/repos/AscEmu/AscEmu/pulls/comments/197805075","pull_request_review_id":131618773,"id":197805075,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzgwNTA3NQ==","diff_hunk":"@@ -1523,9 +1523,9 @@ void WorldSession::HandleDeclinedPlayerNameOpcode(WorldPacket& recv_data)\n \n     recv_data >> guid;\n \n-    std::string declinedname[6];\n+    std::string declinedname[MAX_DECLINED_NAME_CASES];\n \n-    for(int i = 0; i < 6; ++i)\n+    for(int i = 0; i < MAX_DECLINED_NAME_CASES; ++i)\n     {","path":"src/world/Server/Packets/Handlers/CharacterHandler.cpp","position":null,"original_position":9,"commit_id":"3819e4598fff17a66ce5ee2bc8bc41209ffcd43d","original_commit_id":"4a87722bc45daa12684e78a87701fa8f7e6621ca","user":{"login":"schnek","id":1216225,"node_id":"MDQ6VXNlcjEyMTYyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1216225?v=4","gravatar_id":"","url":"https://api.github.com/users/schnek","html_url":"https://github.com/schnek","followers_url":"https://api.github.com/users/schnek/followers","following_url":"https://api.github.com/users/schnek/following{/other_user}","gists_url":"https://api.github.com/users/schnek/gists{/gist_id}","starred_url":"https://api.github.com/users/schnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnek/subscriptions","organizations_url":"https://api.github.com/users/schnek/orgs","repos_url":"https://api.github.com/users/schnek/repos","events_url":"https://api.github.com/users/schnek/events{/privacy}","received_events_url":"https://api.github.com/users/schnek/received_events","type":"User","site_admin":false},"body":"uint8_t in the future ..","created_at":"2018-06-25T13:56:06Z","updated_at":"2018-06-25T13:56:06Z","html_url":"https://github.com/AscEmu/AscEmu/pull/589#discussion_r197805075","pull_request_url":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/AscEmu/AscEmu/pulls/comments/197805075"},"html":{"href":"https://github.com/AscEmu/AscEmu/pull/589#discussion_r197805075"},"pull_request":{"href":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589"}},"in_reply_to_id":197799437},"pull_request":{"url":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589","id":184936190,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0OTM2MTkw","html_url":"https://github.com/AscEmu/AscEmu/pull/589","diff_url":"https://github.com/AscEmu/AscEmu/pull/589.diff","patch_url":"https://github.com/AscEmu/AscEmu/pull/589.patch","issue_url":"https://api.github.com/repos/AscEmu/AscEmu/issues/589","number":589,"state":"open","locked":false,"title":"[wip] Add external library (UTF8-CPP)","user":{"login":"schnek","id":1216225,"node_id":"MDQ6VXNlcjEyMTYyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1216225?v=4","gravatar_id":"","url":"https://api.github.com/users/schnek","html_url":"https://github.com/schnek","followers_url":"https://api.github.com/users/schnek/followers","following_url":"https://api.github.com/users/schnek/following{/other_user}","gists_url":"https://api.github.com/users/schnek/gists{/gist_id}","starred_url":"https://api.github.com/users/schnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnek/subscriptions","organizations_url":"https://api.github.com/users/schnek/orgs","repos_url":"https://api.github.com/users/schnek/repos","events_url":"https://api.github.com/users/schnek/events{/privacy}","received_events_url":"https://api.github.com/users/schnek/received_events","type":"User","site_admin":false},"body":"- [ ] world\r\n![image](https://user-images.githubusercontent.com/1216225/39480145-03c345c4-4d70-11e8-9138-8e48151d8a99.png)\r\n\r\n- [ ] support declension Russian client\r\n\r\nmethod void WorldSession::HandleDeclinedPlayerNameOpcode { }\r\n![image](https://user-images.githubusercontent.com/1216225/39480008-9c6c4fb0-4d6f-11e8-9711-38acad103f59.png)\r\n\r\n- [ ] concole (72c138b18783149c6d0c1f80896a5429287bbc55)\r\n\r\n> [DEBUG] WorldSession::handleNameQueryOpcode Received CMSG_NAME_QUERY for: ╨╝╨╕╤И╨║╨░\r\n> [DETAIL] Player::SendInitialLogonPackets WORLD: Sent initial logon packets for ???????.\r\n> [DETAIL] WorldSession::FullLogin WORLD: Created new player for existing players (???????)\r\n[DEBUG] WorldSession::FullLogin Player ╨Ф╨Х╨Р╨Ф╨о╨Э╨Ш╨Ъ╨Ю╨а╨Э logged in.\r\n[DETAIL] WorldSession::FullLogin WORLD: Created new player for existing players (╨Ф╨Х╨Р╨Ф╨о╨Э╨Ш╨Ъ╨Ю╨а╨Э)\r\n[DETAIL] Player::SendInitialLogonPackets WORLD: Sent initial logon packets for ╨Ф╨Х╨Р╨Ф╨о╨Э╨Ш╨Ъ╨Ю╨а╨Э.\r\n[DETAIL] Player::ApplyLevelInfo Player ╨Ф╨Х╨Р╨Ф╨о╨Э╨Ш╨Ъ╨Ю╨а╨Э set parameters to level 5\r\n[DEBUG] WorldSession::handleNameQueryOpcode Received CMSG_NAME_QUERY for: ╨Ф╨Х╨Р╨Ф╨о╨Э╨Ш╨Ъ╨Ю╨а╨Э\r\n\r\n- [ ] todo: update encoding to world_db\r\n\r\n","created_at":"2018-04-30T11:45:18Z","updated_at":"2018-06-25T13:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4417059027f4450d8f5df943eedcb6e15c4bee48","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589/commits","review_comments_url":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589/comments","review_comment_url":"https://api.github.com/repos/AscEmu/AscEmu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AscEmu/AscEmu/issues/589/comments","statuses_url":"https://api.github.com/repos/AscEmu/AscEmu/statuses/3819e4598fff17a66ce5ee2bc8bc41209ffcd43d","head":{"label":"schnek:utfcpp_locale_2","ref":"utfcpp_locale_2","sha":"3819e4598fff17a66ce5ee2bc8bc41209ffcd43d","user":{"login":"schnek","id":1216225,"node_id":"MDQ6VXNlcjEyMTYyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1216225?v=4","gravatar_id":"","url":"https://api.github.com/users/schnek","html_url":"https://github.com/schnek","followers_url":"https://api.github.com/users/schnek/followers","following_url":"https://api.github.com/users/schnek/following{/other_user}","gists_url":"https://api.github.com/users/schnek/gists{/gist_id}","starred_url":"https://api.github.com/users/schnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnek/subscriptions","organizations_url":"https://api.github.com/users/schnek/orgs","repos_url":"https://api.github.com/users/schnek/repos","events_url":"https://api.github.com/users/schnek/events{/privacy}","received_events_url":"https://api.github.com/users/schnek/received_events","type":"User","site_admin":false},"repo":{"id":116258625,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYyNTg2MjU=","name":"AscEmu","full_name":"schnek/AscEmu","owner":{"login":"schnek","id":1216225,"node_id":"MDQ6VXNlcjEyMTYyMjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1216225?v=4","gravatar_id":"","url":"https://api.github.com/users/schnek","html_url":"https://github.com/schnek","followers_url":"https://api.github.com/users/schnek/followers","following_url":"https://api.github.com/users/schnek/following{/other_user}","gists_url":"https://api.github.com/users/schnek/gists{/gist_id}","starred_url":"https://api.github.com/users/schnek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schnek/subscriptions","organizations_url":"https://api.github.com/users/schnek/orgs","repos_url":"https://api.github.com/users/schnek/repos","events_url":"https://api.github.com/users/schnek/events{/privacy}","received_events_url":"https://api.github.com/users/schnek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schnek/AscEmu","description":"AscEmu... a never ending place to work.","fork":true,"url":"https://api.github.com/repos/schnek/AscEmu","forks_url":"https://api.github.com/repos/schnek/AscEmu/forks","keys_url":"https://api.github.com/repos/schnek/AscEmu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schnek/AscEmu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schnek/AscEmu/teams","hooks_url":"https://api.github.com/repos/schnek/AscEmu/hooks","issue_events_url":"https://api.github.com/repos/schnek/AscEmu/issues/events{/number}","events_url":"https://api.github.com/repos/schnek/AscEmu/events","assignees_url":"https://api.github.com/repos/schnek/AscEmu/assignees{/user}","branches_url":"https://api.github.com/repos/schnek/AscEmu/branches{/branch}","tags_url":"https://api.github.com/repos/schnek/AscEmu/tags","blobs_url":"https://api.github.com/repos/schnek/AscEmu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schnek/AscEmu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schnek/AscEmu/git/refs{/sha}","trees_url":"https://api.github.com/repos/schnek/AscEmu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schnek/AscEmu/statuses/{sha}","languages_url":"https://api.github.com/repos/schnek/AscEmu/languages","stargazers_url":"https://api.github.com/repos/schnek/AscEmu/stargazers","contributors_url":"https://api.github.com/repos/schnek/AscEmu/contributors","subscribers_url":"https://api.github.com/repos/schnek/AscEmu/subscribers","subscription_url":"https://api.github.com/repos/schnek/AscEmu/subscription","commits_url":"https://api.github.com/repos/schnek/AscEmu/commits{/sha}","git_commits_url":"https://api.github.com/repos/schnek/AscEmu/git/commits{/sha}","comments_url":"https://api.github.com/repos/schnek/AscEmu/comments{/number}","issue_comment_url":"https://api.github.com/repos/schnek/AscEmu/issues/comments{/number}","contents_url":"https://api.github.com/repos/schnek/AscEmu/contents/{+path}","compare_url":"https://api.github.com/repos/schnek/AscEmu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schnek/AscEmu/merges","archive_url":"https://api.github.com/repos/schnek/AscEmu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schnek/AscEmu/downloads","issues_url":"https://api.github.com/repos/schnek/AscEmu/issues{/number}","pulls_url":"https://api.github.com/repos/schnek/AscEmu/pulls{/number}","milestones_url":"https://api.github.com/repos/schnek/AscEmu/milestones{/number}","notifications_url":"https://api.github.com/repos/schnek/AscEmu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schnek/AscEmu/labels{/name}","releases_url":"https://api.github.com/repos/schnek/AscEmu/releases{/id}","deployments_url":"https://api.github.com/repos/schnek/AscEmu/deployments","created_at":"2018-01-04T12:39:49Z","updated_at":"2018-03-31T14:41:04Z","pushed_at":"2018-06-25T12:10:33Z","git_url":"git://github.com/schnek/AscEmu.git","ssh_url":"git@github.com:schnek/AscEmu.git","clone_url":"https://github.com/schnek/AscEmu.git","svn_url":"https://github.com/schnek/AscEmu","homepage":"http://www.ascemu.org","size":44804,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AscEmu:master","ref":"master","sha":"2b531b1010202570e62d06d08285e0e474832fcc","user":{"login":"AscEmu","id":8471310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NzEzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8471310?v=4","gravatar_id":"","url":"https://api.github.com/users/AscEmu","html_url":"https://github.com/AscEmu","followers_url":"https://api.github.com/users/AscEmu/followers","following_url":"https://api.github.com/users/AscEmu/following{/other_user}","gists_url":"https://api.github.com/users/AscEmu/gists{/gist_id}","starred_url":"https://api.github.com/users/AscEmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AscEmu/subscriptions","organizations_url":"https://api.github.com/users/AscEmu/orgs","repos_url":"https://api.github.com/users/AscEmu/repos","events_url":"https://api.github.com/users/AscEmu/events{/privacy}","received_events_url":"https://api.github.com/users/AscEmu/received_events","type":"Organization","site_admin":false},"repo":{"id":23041371,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA0MTM3MQ==","name":"AscEmu","full_name":"AscEmu/AscEmu","owner":{"login":"AscEmu","id":8471310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0NzEzMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8471310?v=4","gravatar_id":"","url":"https://api.github.com/users/AscEmu","html_url":"https://github.com/AscEmu","followers_url":"https://api.github.com/users/AscEmu/followers","following_url":"https://api.github.com/users/AscEmu/following{/other_user}","gists_url":"https://api.github.com/users/AscEmu/gists{/gist_id}","starred_url":"https://api.github.com/users/AscEmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AscEmu/subscriptions","organizations_url":"https://api.github.com/users/AscEmu/orgs","repos_url":"https://api.github.com/users/AscEmu/repos","events_url":"https://api.github.com/users/AscEmu/events{/privacy}","received_events_url":"https://api.github.com/users/AscEmu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AscEmu/AscEmu","description":"AscEmu... a never ending place to work.","fork":false,"url":"https://api.github.com/repos/AscEmu/AscEmu","forks_url":"https://api.github.com/repos/AscEmu/AscEmu/forks","keys_url":"https://api.github.com/repos/AscEmu/AscEmu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AscEmu/AscEmu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AscEmu/AscEmu/teams","hooks_url":"https://api.github.com/repos/AscEmu/AscEmu/hooks","issue_events_url":"https://api.github.com/repos/AscEmu/AscEmu/issues/events{/number}","events_url":"https://api.github.com/repos/AscEmu/AscEmu/events","assignees_url":"https://api.github.com/repos/AscEmu/AscEmu/assignees{/user}","branches_url":"https://api.github.com/repos/AscEmu/AscEmu/branches{/branch}","tags_url":"https://api.github.com/repos/AscEmu/AscEmu/tags","blobs_url":"https://api.github.com/repos/AscEmu/AscEmu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AscEmu/AscEmu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AscEmu/AscEmu/git/refs{/sha}","trees_url":"https://api.github.com/repos/AscEmu/AscEmu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AscEmu/AscEmu/statuses/{sha}","languages_url":"https://api.github.com/repos/AscEmu/AscEmu/languages","stargazers_url":"https://api.github.com/repos/AscEmu/AscEmu/stargazers","contributors_url":"https://api.github.com/repos/AscEmu/AscEmu/contributors","subscribers_url":"https://api.github.com/repos/AscEmu/AscEmu/subscribers","subscription_url":"https://api.github.com/repos/AscEmu/AscEmu/subscription","commits_url":"https://api.github.com/repos/AscEmu/AscEmu/commits{/sha}","git_commits_url":"https://api.github.com/repos/AscEmu/AscEmu/git/commits{/sha}","comments_url":"https://api.github.com/repos/AscEmu/AscEmu/comments{/number}","issue_comment_url":"https://api.github.com/repos/AscEmu/AscEmu/issues/comments{/number}","contents_url":"https://api.github.com/repos/AscEmu/AscEmu/contents/{+path}","compare_url":"https://api.github.com/repos/AscEmu/AscEmu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AscEmu/AscEmu/merges","archive_url":"https://api.github.com/repos/AscEmu/AscEmu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AscEmu/AscEmu/downloads","issues_url":"https://api.github.com/repos/AscEmu/AscEmu/issues{/number}","pulls_url":"https://api.github.com/repos/AscEmu/AscEmu/pulls{/number}","milestones_url":"https://api.github.com/repos/AscEmu/AscEmu/milestones{/number}","notifications_url":"https://api.github.com/repos/AscEmu/AscEmu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AscEmu/AscEmu/labels{/name}","releases_url":"https://api.github.com/repos/AscEmu/AscEmu/releases{/id}","deployments_url":"https://api.github.com/repos/AscEmu/AscEmu/deployments","created_at":"2014-08-17T13:43:22Z","updated_at":"2018-06-24T18:41:00Z","pushed_at":"2018-06-25T12:10:34Z","git_url":"git://github.com/AscEmu/AscEmu.git","ssh_url":"git@github.com:AscEmu/AscEmu.git","clone_url":"https://github.com/AscEmu/AscEmu.git","svn_url":"https://github.com/AscEmu/AscEmu","homepage":"http://www.ascemu.org","size":44810,"stargazers_count":37,"watchers_count":37,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":38,"open_issues":104,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589"},"html":{"href":"https://github.com/AscEmu/AscEmu/pull/589"},"issue":{"href":"https://api.github.com/repos/AscEmu/AscEmu/issues/589"},"comments":{"href":"https://api.github.com/repos/AscEmu/AscEmu/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/AscEmu/AscEmu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AscEmu/AscEmu/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/AscEmu/AscEmu/statuses/3819e4598fff17a66ce5ee2bc8bc41209ffcd43d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"schnek"}}