{"push_id":2332333770,"size":4,"distinct_size":4,"ref":"refs/heads/mpuncel/hot-restarter-term-passthrough","head":"489a91999163fbc4c8f5d15f790cbde20c37a88c","before":"3f5faf6eb72ae11884a9a1ae5a81f8f83893bac3","commits":[{"sha":"a89608353d7d507222ac1d00c2eb69a46249697b","author":{"name":"Daniel Hochman","email":"bffe347857be9022a65ee48674ee458abc8bd788@users.noreply.github.com"},"message":"redis: attribute stats to hosts (#2611)\n\nSigned-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>","distinct":true,"url":"https://api.github.com/repos/mpuncel/envoy/commits/a89608353d7d507222ac1d00c2eb69a46249697b"},{"sha":"034135f9b5e3a212af545ef485ee7c4f16c0debc","author":{"name":"htuch","email":"35d8823a91070b33cb5c164eb2b14f829f672e81@users.noreply.github.com"},"message":"Revert \"server: factor out MainCommon as a class, with a run method (#2568)\" (#2613)\n\nThis reverts commit deffec6a177bdb00586d1d7682aca5dbb395e68a, which was\r\ncausing CI to flake today in TSAN runs. The proximate root cause is\r\nthe change in #2568, which appears not to correctly setup logging in\r\n--mode=validate. This in turn leads to some log related races that I\r\ndon't fully grok.\r\n\r\nRolling back to unblock CI, we should make sure hotrestart_test passes\r\nTSAN with high confidence before rolling forward again.\r\n\r\nSigned-off-by: Harvey Tuch <htuch@google.com>","distinct":true,"url":"https://api.github.com/repos/mpuncel/envoy/commits/034135f9b5e3a212af545ef485ee7c4f16c0debc"},{"sha":"f754736b4a7a393bf360c584abeb71a4a58a810d","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"hot-restarter.py: propagate SIGTERM to child processes\n\nThis allows hot-restarter.py to be used as a parent process to a\ncontainer engine (e.g. `runc`). Prior to this change, hot-restarter.py\nwould send a SIGKILL to all children when it receives a SIGTERM for\nsimplicity, because it assumed that its children were envoy processes\nwhich have no state to clean up.\n\nHowever, when running hot-restarter.py with children that have state\nthat should be cleaned up (e.g. container state), it's better to\npropagate the SIGTERM in order to allow children to exit gracefully.\n\nSIGTERM is now handled by propagating SIGTERM to all children, and then\nwaiting until either all children have exited gracefully or a constant\ntimeout has been hit, at which point the children are forcibly killed as\nthey were before.\n\nSigned-off-by: Michael Puncel <mpuncel@squareup.com>","distinct":true,"url":"https://api.github.com/repos/mpuncel/envoy/commits/f754736b4a7a393bf360c584abeb71a4a58a810d"},{"sha":"489a91999163fbc4c8f5d15f790cbde20c37a88c","author":{"name":"Michael Puncel","email":"bd32ba719f8cdb86af52c928dd2db9e4b6e0f145@squareup.com"},"message":"Add line to RAW_RELEASE_NOTES.md describing hot-restarter.py change\n\nSigned-off-by: Michael Puncel <mpuncel@squareup.com>","distinct":true,"url":"https://api.github.com/repos/mpuncel/envoy/commits/489a91999163fbc4c8f5d15f790cbde20c37a88c"}]}
{"actor":{"display_login":"mpuncel"}}