{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-testing-data/issues/31","repository_url":"https://api.github.com/repos/mne-tools/mne-testing-data","labels_url":"https://api.github.com/repos/mne-tools/mne-testing-data/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-testing-data/issues/31/comments","events_url":"https://api.github.com/repos/mne-tools/mne-testing-data/issues/31/events","html_url":"https://github.com/mne-tools/mne-testing-data/pull/31","id":300855635,"number":31,"title":"Adding hdf5 test files","user":{"login":"smgutstein","id":4708900,"avatar_url":"https://avatars2.githubusercontent.com/u/4708900?v=4","gravatar_id":"","url":"https://api.github.com/users/smgutstein","html_url":"https://github.com/smgutstein","followers_url":"https://api.github.com/users/smgutstein/followers","following_url":"https://api.github.com/users/smgutstein/following{/other_user}","gists_url":"https://api.github.com/users/smgutstein/gists{/gist_id}","starred_url":"https://api.github.com/users/smgutstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smgutstein/subscriptions","organizations_url":"https://api.github.com/users/smgutstein/orgs","repos_url":"https://api.github.com/users/smgutstein/repos","events_url":"https://api.github.com/users/smgutstein/events{/privacy}","received_events_url":"https://api.github.com/users/smgutstein/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-02-28T01:21:26Z","updated_at":"2018-03-01T06:10:04Z","closed_at":"2018-02-28T04:19:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-testing-data/pulls/31","html_url":"https://github.com/mne-tools/mne-testing-data/pull/31","diff_url":"https://github.com/mne-tools/mne-testing-data/pull/31.diff","patch_url":"https://github.com/mne-tools/mne-testing-data/pull/31.patch"},"body":"I used Matlab to convert these files, so they should be in the same format that files created by eeglab would be in"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-testing-data/issues/comments/369484554","html_url":"https://github.com/mne-tools/mne-testing-data/pull/31#issuecomment-369484554","issue_url":"https://api.github.com/repos/mne-tools/mne-testing-data/issues/31","id":369484554,"user":{"login":"smgutstein","id":4708900,"avatar_url":"https://avatars2.githubusercontent.com/u/4708900?v=4","gravatar_id":"","url":"https://api.github.com/users/smgutstein","html_url":"https://github.com/smgutstein","followers_url":"https://api.github.com/users/smgutstein/followers","following_url":"https://api.github.com/users/smgutstein/following{/other_user}","gists_url":"https://api.github.com/users/smgutstein/gists{/gist_id}","starred_url":"https://api.github.com/users/smgutstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smgutstein/subscriptions","organizations_url":"https://api.github.com/users/smgutstein/orgs","repos_url":"https://api.github.com/users/smgutstein/repos","events_url":"https://api.github.com/users/smgutstein/events{/privacy}","received_events_url":"https://api.github.com/users/smgutstein/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T06:10:04Z","updated_at":"2018-03-01T06:10:04Z","author_association":"CONTRIBUTOR","body":"Well, I suppose the point of unit testing is that it forces you to find\nyour unknown unknowns.\n\nThe main one I've found is that I had assumed the structure of the EEG\nvariable in the sample record I obtained from one of our EEG expts would be\nstatic. This doesn't seem to be the case. When I look at the differences\nbetween test_raw_h5.set (derived from test_raw.set) and test_raw_hdf5.set\n(derived from the local expt and which started me on getting hdf5 files\nreadable), I find, in part, the following:\n\n1. In test_raw_hdf5.set, chaninfo has 4 fields (nodatchans, nosedir,\nplotrad & shrink), in test_raw_h5.set, it has 1 (icachansind).\n\n2. In test_raw_hdf5.set, chanlocs is stored as an HDF5 Group with 12 fileds\n(X, Y, Z, labels, radius, ref, sph_phi, sph_radius, sph_theta, theta, type\nand urchan) in test_raw_h5.set, it's a dataset without named fields (at\nleast that I know how to get at).\n\n3. (In the limits of my limited understanding) When HDF5 stores things in a\ngroup, it makes certain each member of the group has roughly the same type.\nAs a result, string variables are stored in uint16 arrays where each number\nis the ascii value of a letter. I hard coded, in hdf_2_dict (a method I\nadded to eeglab.py), conversions for some fields that I knew had to be\nconverted. But my list was not complete, nor did it make allowance for the\nstructure differences between the EEG's stored in test_raw_hdf5.set and\ntest_raw_h5.set\n\nIs there documentation giving:\n\n1. The allowed/possible sets of fields and sub-fields for the EEG variable\n2. A listing of which fields contain string values\n\nOn Wed, Feb 28, 2018 at 10:41 AM, Eric Larson <notifications@github.com>\nwrote:\n\n> Excellent, thanks for checking. You should be good to update your PR to\n> use version 0.45 of the testing data, instructions in step 5 here\n> <https://github.com/mne-tools/mne-testing-data/blob/master/README.md#add-or-change-files-in-the-repo-for-use-with-mne>\n> .\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/mne-tools/mne-testing-data/pull/31#issuecomment-369277723>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AEfaJF5WfyiWXfs1sFWOKLDbJBDRfL2uks5tZXJTgaJpZM4SV6tU>\n> .\n>\n"}}
{"actor":{"display_login":"smgutstein"}}