{"action":"created","comment":{"url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/comments/199886377","pull_request_review_id":134093330,"id":199886377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTg4NjM3Nw==","diff_hunk":"@@ -1,25 +1,32 @@\n-add_library(prometheus-cpp\n+set(PROMETHEUS_SOURCES ","path":"lib/CMakeLists.txt","position":2,"original_position":2,"commit_id":"303e5ff1b86f179c1489f06b2096703274b98774","original_commit_id":"93eabdcfb622962ade33a2a918921e8d80586812","user":{"login":"jupp0r","id":161598,"node_id":"MDQ6VXNlcjE2MTU5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/161598?v=4","gravatar_id":"","url":"https://api.github.com/users/jupp0r","html_url":"https://github.com/jupp0r","followers_url":"https://api.github.com/users/jupp0r/followers","following_url":"https://api.github.com/users/jupp0r/following{/other_user}","gists_url":"https://api.github.com/users/jupp0r/gists{/gist_id}","starred_url":"https://api.github.com/users/jupp0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupp0r/subscriptions","organizations_url":"https://api.github.com/users/jupp0r/orgs","repos_url":"https://api.github.com/users/jupp0r/repos","events_url":"https://api.github.com/users/jupp0r/events{/privacy}","received_events_url":"https://api.github.com/users/jupp0r/received_events","type":"User","site_admin":false},"body":"I think it would be nicer to be able to choose between a core library and one that comes with an embedded http server. My main concern is that an option will cause problems with distro packaging because only one option combination can ever be selected for a binary package. The core library option would allow us to distribute two packages so consumers can still use whatever option they want without building from source.","created_at":"2018-07-03T17:13:37Z","updated_at":"2018-07-03T17:13:37Z","html_url":"https://github.com/jupp0r/prometheus-cpp/pull/114#discussion_r199886377","pull_request_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/comments/199886377"},"html":{"href":"https://github.com/jupp0r/prometheus-cpp/pull/114#discussion_r199886377"},"pull_request":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114"}},"in_reply_to_id":198486609},"pull_request":{"url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114","id":196664895,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjY0ODk1","html_url":"https://github.com/jupp0r/prometheus-cpp/pull/114","diff_url":"https://github.com/jupp0r/prometheus-cpp/pull/114.diff","patch_url":"https://github.com/jupp0r/prometheus-cpp/pull/114.patch","issue_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues/114","number":114,"state":"open","locked":false,"title":"added build options BUILD_TESTING and BUILD_CIVETWEB","user":{"login":"bvgastel","id":1301653,"node_id":"MDQ6VXNlcjEzMDE2NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1301653?v=4","gravatar_id":"","url":"https://api.github.com/users/bvgastel","html_url":"https://github.com/bvgastel","followers_url":"https://api.github.com/users/bvgastel/followers","following_url":"https://api.github.com/users/bvgastel/following{/other_user}","gists_url":"https://api.github.com/users/bvgastel/gists{/gist_id}","starred_url":"https://api.github.com/users/bvgastel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvgastel/subscriptions","organizations_url":"https://api.github.com/users/bvgastel/orgs","repos_url":"https://api.github.com/users/bvgastel/repos","events_url":"https://api.github.com/users/bvgastel/events{/privacy}","received_events_url":"https://api.github.com/users/bvgastel/received_events","type":"User","site_admin":false},"body":"These options are to build the testing and to embed the webserver in prometheus-cpp. This way, the project can be used in a more flexible way. The options defaults to on.\r\n\r\nOnly adjusted the CMake file so it works for us.\r\n\r\nRelated to https://github.com/jupp0r/prometheus-cpp/pull/112 .","created_at":"2018-06-22T08:02:34Z","updated_at":"2018-07-03T17:13:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90734037c93ae952b0339e17a7fbfdf498a2ecc2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114/commits","review_comments_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114/comments","review_comment_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues/114/comments","statuses_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/statuses/303e5ff1b86f179c1489f06b2096703274b98774","head":{"label":"bvgastel:master","ref":"master","sha":"303e5ff1b86f179c1489f06b2096703274b98774","user":{"login":"bvgastel","id":1301653,"node_id":"MDQ6VXNlcjEzMDE2NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1301653?v=4","gravatar_id":"","url":"https://api.github.com/users/bvgastel","html_url":"https://github.com/bvgastel","followers_url":"https://api.github.com/users/bvgastel/followers","following_url":"https://api.github.com/users/bvgastel/following{/other_user}","gists_url":"https://api.github.com/users/bvgastel/gists{/gist_id}","starred_url":"https://api.github.com/users/bvgastel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvgastel/subscriptions","organizations_url":"https://api.github.com/users/bvgastel/orgs","repos_url":"https://api.github.com/users/bvgastel/repos","events_url":"https://api.github.com/users/bvgastel/events{/privacy}","received_events_url":"https://api.github.com/users/bvgastel/received_events","type":"User","site_admin":false},"repo":{"id":138271422,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgyNzE0MjI=","name":"prometheus-cpp","full_name":"bvgastel/prometheus-cpp","owner":{"login":"bvgastel","id":1301653,"node_id":"MDQ6VXNlcjEzMDE2NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1301653?v=4","gravatar_id":"","url":"https://api.github.com/users/bvgastel","html_url":"https://github.com/bvgastel","followers_url":"https://api.github.com/users/bvgastel/followers","following_url":"https://api.github.com/users/bvgastel/following{/other_user}","gists_url":"https://api.github.com/users/bvgastel/gists{/gist_id}","starred_url":"https://api.github.com/users/bvgastel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvgastel/subscriptions","organizations_url":"https://api.github.com/users/bvgastel/orgs","repos_url":"https://api.github.com/users/bvgastel/repos","events_url":"https://api.github.com/users/bvgastel/events{/privacy}","received_events_url":"https://api.github.com/users/bvgastel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bvgastel/prometheus-cpp","description":"Prometheus Client Library for Modern C++","fork":true,"url":"https://api.github.com/repos/bvgastel/prometheus-cpp","forks_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/forks","keys_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/teams","hooks_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/hooks","issue_events_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/events","assignees_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/tags","blobs_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/languages","stargazers_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/stargazers","contributors_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/contributors","subscribers_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/subscribers","subscription_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/subscription","commits_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/merges","archive_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/downloads","issues_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/labels{/name}","releases_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/bvgastel/prometheus-cpp/deployments","created_at":"2018-06-22T07:40:57Z","updated_at":"2018-06-27T17:07:49Z","pushed_at":"2018-06-27T17:07:47Z","git_url":"git://github.com/bvgastel/prometheus-cpp.git","ssh_url":"git@github.com:bvgastel/prometheus-cpp.git","clone_url":"https://github.com/bvgastel/prometheus-cpp.git","svn_url":"https://github.com/bvgastel/prometheus-cpp","homepage":null,"size":164,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupp0r:master","ref":"master","sha":"42cc95ccf71e34c24964b503315938590142f0ba","user":{"login":"jupp0r","id":161598,"node_id":"MDQ6VXNlcjE2MTU5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/161598?v=4","gravatar_id":"","url":"https://api.github.com/users/jupp0r","html_url":"https://github.com/jupp0r","followers_url":"https://api.github.com/users/jupp0r/followers","following_url":"https://api.github.com/users/jupp0r/following{/other_user}","gists_url":"https://api.github.com/users/jupp0r/gists{/gist_id}","starred_url":"https://api.github.com/users/jupp0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupp0r/subscriptions","organizations_url":"https://api.github.com/users/jupp0r/orgs","repos_url":"https://api.github.com/users/jupp0r/repos","events_url":"https://api.github.com/users/jupp0r/events{/privacy}","received_events_url":"https://api.github.com/users/jupp0r/received_events","type":"User","site_admin":false},"repo":{"id":66925865,"node_id":"MDEwOlJlcG9zaXRvcnk2NjkyNTg2NQ==","name":"prometheus-cpp","full_name":"jupp0r/prometheus-cpp","owner":{"login":"jupp0r","id":161598,"node_id":"MDQ6VXNlcjE2MTU5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/161598?v=4","gravatar_id":"","url":"https://api.github.com/users/jupp0r","html_url":"https://github.com/jupp0r","followers_url":"https://api.github.com/users/jupp0r/followers","following_url":"https://api.github.com/users/jupp0r/following{/other_user}","gists_url":"https://api.github.com/users/jupp0r/gists{/gist_id}","starred_url":"https://api.github.com/users/jupp0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupp0r/subscriptions","organizations_url":"https://api.github.com/users/jupp0r/orgs","repos_url":"https://api.github.com/users/jupp0r/repos","events_url":"https://api.github.com/users/jupp0r/events{/privacy}","received_events_url":"https://api.github.com/users/jupp0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jupp0r/prometheus-cpp","description":"Prometheus Client Library for Modern C++","fork":false,"url":"https://api.github.com/repos/jupp0r/prometheus-cpp","forks_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/forks","keys_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/teams","hooks_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/hooks","issue_events_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/events","assignees_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/tags","blobs_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/languages","stargazers_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/stargazers","contributors_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/contributors","subscribers_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/subscribers","subscription_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/subscription","commits_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/merges","archive_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/downloads","issues_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/labels{/name}","releases_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/jupp0r/prometheus-cpp/deployments","created_at":"2016-08-30T09:18:37Z","updated_at":"2018-07-03T17:07:36Z","pushed_at":"2018-07-03T17:07:34Z","git_url":"git://github.com/jupp0r/prometheus-cpp.git","ssh_url":"git@github.com:jupp0r/prometheus-cpp.git","clone_url":"https://github.com/jupp0r/prometheus-cpp.git","svn_url":"https://github.com/jupp0r/prometheus-cpp","homepage":null,"size":162,"stargazers_count":103,"watchers_count":103,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":10,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114"},"html":{"href":"https://github.com/jupp0r/prometheus-cpp/pull/114"},"issue":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues/114"},"comments":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/jupp0r/prometheus-cpp/statuses/303e5ff1b86f179c1489f06b2096703274b98774"}},"author_association":"NONE"}}
{"actor":{"display_login":"jupp0r"}}