{"action":"created","issue":{"url":"https://api.github.com/repos/test-editor/web-testeditor-commons/issues/20","repository_url":"https://api.github.com/repos/test-editor/web-testeditor-commons","labels_url":"https://api.github.com/repos/test-editor/web-testeditor-commons/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/test-editor/web-testeditor-commons/issues/20/comments","events_url":"https://api.github.com/repos/test-editor/web-testeditor-commons/issues/20/events","html_url":"https://github.com/test-editor/web-testeditor-commons/pull/20","id":362223399,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MDAwMTQ1","number":20,"title":"migrate and adapt indicator box component from workspace navigator","user":{"login":"jjelschen","id":2879473,"node_id":"MDQ6VXNlcjI4Nzk0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2879473?v=4","gravatar_id":"","url":"https://api.github.com/users/jjelschen","html_url":"https://github.com/jjelschen","followers_url":"https://api.github.com/users/jjelschen/followers","following_url":"https://api.github.com/users/jjelschen/following{/other_user}","gists_url":"https://api.github.com/users/jjelschen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjelschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjelschen/subscriptions","organizations_url":"https://api.github.com/users/jjelschen/orgs","repos_url":"https://api.github.com/users/jjelschen/repos","events_url":"https://api.github.com/users/jjelschen/events{/privacy}","received_events_url":"https://api.github.com/users/jjelschen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-20T14:47:01Z","updated_at":"2018-09-20T15:06:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/test-editor/web-testeditor-commons/pulls/20","html_url":"https://github.com/test-editor/web-testeditor-commons/pull/20","diff_url":"https://github.com/test-editor/web-testeditor-commons/pull/20.diff","patch_url":"https://github.com/test-editor/web-testeditor-commons/pull/20.patch"},"body":"This doesn't do anything yet, its just the indicator box component and dependencies migrated and adapted over to this module.\r\n\r\nI did make one significant change in that the markers are now stored with each node directly, as opposed to keeping them in a central place (was: the `Workspace` class), in a map with path strings as keys to look them up. While this has cleared up the code that makes up this PR, it will mean that the way marker values are being set needs to change.\r\n\r\nOne option would be to traverse the whole tree to find particular nodes to manipulate marker states. Alternatively, we could signal marker changes via message bus events. If both methods turn out to be too expensive, we would need a lookup map, again, which, this time around, I would propose to design as a \"tree index\", i.e. a map from node id to node object. Downside of that is the additional bookkeeping required to keep the tree structure and its index in sync…"},"comment":{"url":"https://api.github.com/repos/test-editor/web-testeditor-commons/issues/comments/423218735","html_url":"https://github.com/test-editor/web-testeditor-commons/pull/20#issuecomment-423218735","issue_url":"https://api.github.com/repos/test-editor/web-testeditor-commons/issues/20","id":423218735,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzIxODczNQ==","user":{"login":"jjelschen","id":2879473,"node_id":"MDQ6VXNlcjI4Nzk0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2879473?v=4","gravatar_id":"","url":"https://api.github.com/users/jjelschen","html_url":"https://github.com/jjelschen","followers_url":"https://api.github.com/users/jjelschen/followers","following_url":"https://api.github.com/users/jjelschen/following{/other_user}","gists_url":"https://api.github.com/users/jjelschen/gists{/gist_id}","starred_url":"https://api.github.com/users/jjelschen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjelschen/subscriptions","organizations_url":"https://api.github.com/users/jjelschen/orgs","repos_url":"https://api.github.com/users/jjelschen/repos","events_url":"https://api.github.com/users/jjelschen/events{/privacy}","received_events_url":"https://api.github.com/users/jjelschen/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T15:06:40Z","updated_at":"2018-09-20T15:06:40Z","author_association":"CONTRIBUTOR","body":"Had to turn off source maps for testing, as we have done in other projects, as well, to workaround the [Angular CLI bug](angular/angular-cli#7296). However, that bug usually only caused a wrong (generic) error message in failing tests. But in this case, two unit tests failed with the message indicative of said bug, but actually ran green with sourcemaps disabled. So I'm not sure what to make of that…"}}
{"actor":{"display_login":"jjelschen"}}