{"action":"created","issue":{"url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/322","repository_url":"https://api.github.com/repos/TechFortress/GriefPrevention","labels_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/322/labels{/name}","comments_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/322/comments","events_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/322/events","html_url":"https://github.com/TechFortress/GriefPrevention/issues/322","id":344164340,"node_id":"MDU6SXNzdWUzNDQxNjQzNDA=","number":322,"title":"GriefPrevention randomly added 171105 Claim blocks to \"accruedblocks\".","user":{"login":"FrozenBeard","id":144046,"node_id":"MDQ6VXNlcjE0NDA0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/144046?v=4","gravatar_id":"","url":"https://api.github.com/users/FrozenBeard","html_url":"https://github.com/FrozenBeard","followers_url":"https://api.github.com/users/FrozenBeard/followers","following_url":"https://api.github.com/users/FrozenBeard/following{/other_user}","gists_url":"https://api.github.com/users/FrozenBeard/gists{/gist_id}","starred_url":"https://api.github.com/users/FrozenBeard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrozenBeard/subscriptions","organizations_url":"https://api.github.com/users/FrozenBeard/orgs","repos_url":"https://api.github.com/users/FrozenBeard/repos","events_url":"https://api.github.com/users/FrozenBeard/events{/privacy}","received_events_url":"https://api.github.com/users/FrozenBeard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-24T19:03:50Z","updated_at":"2018-07-27T14:32:21Z","closed_at":null,"author_association":"NONE","body":"I just cant catch a break with GP randomly messing with data in the database after the fiasco with #279.\r\nI haven't used Plan on my server since that event.\r\nWell I'm back with another \"what the hell is GP randomly doing\", put on your \"WTF hat\", I cant figure it out. This time around 171105  claim blocks were added to an admins \"accruedblocks\" MySQL data after he noticed after removing a claim from a player.\r\n\r\nThe only thing I have changed recently is I have updated Paperspigot to the latest release:\r\nPaperSpigot:\r\n`This server is running Paper version git-Paper-1509 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT) Previous version: git-Paper-1476 (MC: 1.12.2)`\r\nI updated Java & the OS and Waterfall bungee, I haven't touched the plugin in a long time.\r\nGriefPrevention version 16.8.dev \r\n\r\nAn admin deleted a claim of a user that's been offline for 745 days. The message back to him was him \"_Claim abandoned.  You now have 171108 available claim blocks._\" it wasn't his claim, yet it somehow looks like it changed his \"accruedblocks\" claim blocks on the surface, one thing I did find out is he used  /AbandonClaim instead of /deleteclaim so this may be where the issue arises, I'm not sure how to find out. He did not have 171105, he had 0, which is why he noticed.\r\n\r\nWe pulled his personal logs off his computer for today and found he had luckily run /claimslist earlier on in the day, and I run it again to compare the two to make sure none of his Claims had been resized or deleted, and you can clearly see the the difference between the two https://www.diffchecker.com/p8QmCFV4 the left is earlier on in the day, the right is after he noticed the massive increase in \"accruedblocks\".\r\n\r\nAfter digging through his personal client logs, the server logs and GP's logs I found this in the GP logs:\r\n```\r\n13:35 Retrieved data for 7e556548-0a59-4c43-bd7b-44f3bc9b3261: accrued: 190751 bonus: 171133\r\n13:35 Retrieved data for 7e556548-0a59-4c43-bd7b-44f3bc9b3261: accrued: 190751 bonus: 171133\r\n13:35 Lawzoneon has more claimed land than blocks available.  Adding blocks to fix.\r\n13:35 Lawzoneon Accrued blocks: 190685 Bonus blocks: 171133\r\n13:35 Total blocks: 361818 Total claimed area: 361874\r\n13:35 PirateCraft_1: x-3914, z1782 // PirateCraft_1: x-3819, z1879 = 9408\r\n13:35 PirateCraft_1_nether: x-446, z228 // PirateCraft_1_nether: x-436, z243 = 176\r\n13:35 PirateCraft_1: x2936, z-7639 // PirateCraft_1: x3092, z-7484 = 24492\r\n13:35 PirateCraft_1: x-3683, z2242 // PirateCraft_1: x-3673, z2252 = 121\r\n13:35 PirateCraft_1: x-3482, z-115 // PirateCraft_1: x-3472, z-105 = 121\r\n13:35 PirateCraft_1_nether: x3189, z-2747 // PirateCraft_1_nether: x3199, z-2737 = 121\r\n13:35 PirateCraft_1: x-2802, z-1149 // PirateCraft_1: x-2783, z-1131 = 380\r\n13:35 PirateCraft_1: x-4467, z2266 // PirateCraft_1: x-4439, z2303 = 1102\r\n13:35 PirateCraft_1: x-3581, z1610 // PirateCraft_1: x-3571, z1617 = 88\r\n13:35 PirateCraft_1: x-3577, z1619 // PirateCraft_1: x-3564, z1624 = 84\r\n13:35 PirateCraft_1: x-3597, z1556 // PirateCraft_1: x-3592, z1569 = 84\r\n13:35 PirateCraft_1: x-3639, z1535 // PirateCraft_1: x-3633, z1548 = 98\r\n13:35 PirateCraft_1: x-3640, z1575 // PirateCraft_1: x-3633, z1584 = 80\r\n13:35 PirateCraft_1: x-3592, z1599 // PirateCraft_1: x-3573, z1602 = 80\r\n13:35 PirateCraft_1: x7384, z-5512 // PirateCraft_1: x7447, z-5449 = 4096\r\n13:35 PirateCraft_1: x-920, z4527 // PirateCraft_1: x-912, z4535 = 81\r\n13:35 PirateCraft_1: x-3357, z424 // PirateCraft_1: x-3322, z459 = 1296\r\n13:35 PirateCraft_1: x-4060, z2042 // PirateCraft_1: x-4032, z2064 = 667\r\n13:35 PirateCraft_1: x3368, z2271 // PirateCraft_1: x3417, z2285 = 750\r\n13:35 PirateCraft_1_nether: x-2955, z-2439 // PirateCraft_1_nether: x-2945, z-2429 = 121\r\n13:35 PirateCraft_1: x-3580, z2170 // PirateCraft_1: x-3539, z2200 = 1302\r\n13:35 PirateCraft_1_nether: x-3969, z-2999 // PirateCraft_1_nether: x-3959, z-2989 = 121\r\n13:35 PirateCraft_1_nether: x-3178, z-2720 // PirateCraft_1_nether: x-3168, z-2710 = 121\r\n13:35 PirateCraft_1_nether: x-3978, z-2933 // PirateCraft_1_nether: x-3968, z-2923 = 121\r\n13:35 PirateCraft_1: x-3521, z8323 // PirateCraft_1: x-3495, z8369 = 1269\r\n13:35 PirateCraft_1_nether: x-441, z-288 // PirateCraft_1_nether: x-437, z227 = 2580\r\n13:35 PirateCraft_1: x-4981, z3287 // PirateCraft_1: x-4920, z3333 = 2914\r\n13:35 PirateCraft_1_the_end: x-32, z1324 // PirateCraft_1_the_end: x587, z1823 = 310000\r\n13:35 New accrued blocks: 361874\r\n13:35 New total blocks: 533007\r\n13:35 Lawzoneon Accrued blocks: 361874 Bonus blocks: 171133 Group Bonus Blocks: 0\r\n13:35 Total blocks: 533007 Total claimed area: 361874\r\n13:35 Remaining claim blocks to use: 171133 (should be 0)\r\n```\r\n\r\nWhere it randomly just sets him at _New accrued blocks: 361874_.\r\n\r\nSo from what I can see, him deleting a players claim only alerted him of the change to his claims blocks.\r\n\r\nHe notices the claim block change at 2:01 or 3:01 his time.\r\nI noticed this \"Adding blocks to fix\" at 13:35 my time 14:35 his time.\r\n\r\nHis username is Lawzoneon, his uuid is 7e556548-0a59-4c43-bd7b-44f3bc9b3261\r\nFull GP Log: https://gist.github.com/FrozenBeard/e1b3a967298c1560a05a3b25e861263c\r\nFull Server Log: https://gist.github.com/FrozenBeard/c7d72de75fadfb798ec14563179ff9fd\r\nHis Personal Minecraft Log: https://gist.github.com/FrozenBeard/a624e35d899836ed9493d7cc09404a24\r\n\r\nAnother note: As I was going through the server logs line by line and checking his GP save progress at\r\n12:41:46 GP removed 109 \"accruedblocks\" claim blocks from 190850 to 190741 for no reason at all, this accruedblocks should never be negated from, only increment with time played.\r\n\r\n**Edit**: **I figured out what GP has done wrong.**\r\nHe had 0 claim blocks to use. GP for some reason decided to just remove 109 accrued blocks randomly. accrued blocks should never have anything removed directly from its data. This then triggered the \"Adding blocks to fix\" check as he had less Claim blocks to what hes actually used due to the -109.\r\nThe second problem is the \"Adding blocks to fix\" isn't right, all it does is just counts up all the Claims hes claimed in the worlds and just resets the \"accrued blocks\" MySQL data directly to that, completely ignores the bonusblocks. If you look at the previous and current /claimslist on the diffchecker you can actually confirm this, add up all the Claims area and it comes out exactly at 361846, so thats where its getting its number. But if you remove his bonus blocks (171133) from it it gives you 190723, his previous Acquired blocks are 190741, this is very, very close. \r\n\r\nSo there are two issues GP is doing here.\r\n\r\n- Randomly removing 109 Claim blocks \"accruedblocks\" from a user.\r\n- The \"Fix\" check, does not remove the bonusblocks first, it just slaps the FULL claim area into the database\r\n"},"comment":{"url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/comments/408436569","html_url":"https://github.com/TechFortress/GriefPrevention/issues/322#issuecomment-408436569","issue_url":"https://api.github.com/repos/TechFortress/GriefPrevention/issues/322","id":408436569,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODQzNjU2OQ==","user":{"login":"FrozenBeard","id":144046,"node_id":"MDQ6VXNlcjE0NDA0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/144046?v=4","gravatar_id":"","url":"https://api.github.com/users/FrozenBeard","html_url":"https://github.com/FrozenBeard","followers_url":"https://api.github.com/users/FrozenBeard/followers","following_url":"https://api.github.com/users/FrozenBeard/following{/other_user}","gists_url":"https://api.github.com/users/FrozenBeard/gists{/gist_id}","starred_url":"https://api.github.com/users/FrozenBeard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrozenBeard/subscriptions","organizations_url":"https://api.github.com/users/FrozenBeard/orgs","repos_url":"https://api.github.com/users/FrozenBeard/repos","events_url":"https://api.github.com/users/FrozenBeard/events{/privacy}","received_events_url":"https://api.github.com/users/FrozenBeard/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T14:32:21Z","updated_at":"2018-07-27T14:32:21Z","author_association":"NONE","body":"I wanted to do a quick search to see how many people these affects, I don't keep backups of my GP logs, but I do have 15 log files, so not that many, 15 days of logs from GP.\r\nI scanned them all for \"_has more claimed land than blocks available_\" to see just how many people roughly these bugs are messing with claim blocks.\r\n**87** matches across 15 files\r\nThat's insane, it went from thinking it was a minor bug to a pretty major one."}}
{"actor":{"display_login":"FrozenBeard"}}