{"action":"created","comment":{"url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments/228173340","pull_request_review_id":168381921,"id":228173340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE3MzM0MA==","diff_hunk":"@@ -605,6 +604,8 @@ def iterdict(self, query, batch_size, tag_to_projected_entity_dict):\n                             }\n                             for tag, projected_entities_dict in tag_to_projected_entity_dict.items()\n                         }\n+            else:\n+                raise Exception(\"Got an empty dictionary\")","path":"aiida/backends/sqlalchemy/querybuilder_sqla.py","position":null,"original_position":181,"commit_id":"ef97ec82e350078488973a91f7cb9906589074a0","original_commit_id":"aaa616d4b26d7335ba1e3345fc69a46f2a3d116e","user":{"login":"lekah","id":15344896,"node_id":"MDQ6VXNlcjE1MzQ0ODk2","avatar_url":"https://avatars3.githubusercontent.com/u/15344896?v=4","gravatar_id":"","url":"https://api.github.com/users/lekah","html_url":"https://github.com/lekah","followers_url":"https://api.github.com/users/lekah/followers","following_url":"https://api.github.com/users/lekah/following{/other_user}","gists_url":"https://api.github.com/users/lekah/gists{/gist_id}","starred_url":"https://api.github.com/users/lekah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lekah/subscriptions","organizations_url":"https://api.github.com/users/lekah/orgs","repos_url":"https://api.github.com/users/lekah/repos","events_url":"https://api.github.com/users/lekah/events{/privacy}","received_events_url":"https://api.github.com/users/lekah/received_events","type":"User","site_admin":false},"body":"OK for the exceptions, I put in more appropriate (b037028)\r\nI can't reproduce the failing test locally though.","created_at":"2018-10-25T13:31:21Z","updated_at":"2018-10-25T13:31:21Z","html_url":"https://github.com/aiidateam/aiida_core/pull/2113#discussion_r228173340","pull_request_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments/228173340"},"html":{"href":"https://github.com/aiidateam/aiida_core/pull/2113#discussion_r228173340"},"pull_request":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113"}},"in_reply_to_id":228120592},"pull_request":{"url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113","id":225471094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDcxMDk0","html_url":"https://github.com/aiidateam/aiida_core/pull/2113","diff_url":"https://github.com/aiidateam/aiida_core/pull/2113.diff","patch_url":"https://github.com/aiidateam/aiida_core/pull/2113.patch","issue_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2113","number":2113,"state":"open","locked":false,"title":"Fix 465 upgrade sqlalchemy","user":{"login":"lekah","id":15344896,"node_id":"MDQ6VXNlcjE1MzQ0ODk2","avatar_url":"https://avatars3.githubusercontent.com/u/15344896?v=4","gravatar_id":"","url":"https://api.github.com/users/lekah","html_url":"https://github.com/lekah","followers_url":"https://api.github.com/users/lekah/followers","following_url":"https://api.github.com/users/lekah/following{/other_user}","gists_url":"https://api.github.com/users/lekah/gists{/gist_id}","starred_url":"https://api.github.com/users/lekah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lekah/subscriptions","organizations_url":"https://api.github.com/users/lekah/orgs","repos_url":"https://api.github.com/users/lekah/repos","events_url":"https://api.github.com/users/lekah/events{/privacy}","received_events_url":"https://api.github.com/users/lekah/received_events","type":"User","site_admin":false},"body":"This fixes the long-standing issue of upgrading SQLAlchemy. \r\nThe way attributes stored in a JSON were queried had to be chained.\r\nAdditional tests were added to see this kind of errors before.\r\nIn essence, the issue was that the type check and value check were in arbitrary order. \r\nNow a case statements enforces type check before value check.","created_at":"2018-10-24T16:29:55Z","updated_at":"2018-10-25T13:31:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c02edbdb04f7e6fa2b5e2fe21539829f1d5ad7e1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sphuber","id":6992332,"node_id":"MDQ6VXNlcjY5OTIzMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6992332?v=4","gravatar_id":"","url":"https://api.github.com/users/sphuber","html_url":"https://github.com/sphuber","followers_url":"https://api.github.com/users/sphuber/followers","following_url":"https://api.github.com/users/sphuber/following{/other_user}","gists_url":"https://api.github.com/users/sphuber/gists{/gist_id}","starred_url":"https://api.github.com/users/sphuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphuber/subscriptions","organizations_url":"https://api.github.com/users/sphuber/orgs","repos_url":"https://api.github.com/users/sphuber/repos","events_url":"https://api.github.com/users/sphuber/events{/privacy}","received_events_url":"https://api.github.com/users/sphuber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113/commits","review_comments_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113/comments","review_comment_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/2113/comments","statuses_url":"https://api.github.com/repos/aiidateam/aiida_core/statuses/ef97ec82e350078488973a91f7cb9906589074a0","head":{"label":"aiidateam:fix_465_upgrade_sqlalchemy","ref":"fix_465_upgrade_sqlalchemy","sha":"ef97ec82e350078488973a91f7cb9906589074a0","user":{"login":"aiidateam","id":22181836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTgxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/22181836?v=4","gravatar_id":"","url":"https://api.github.com/users/aiidateam","html_url":"https://github.com/aiidateam","followers_url":"https://api.github.com/users/aiidateam/followers","following_url":"https://api.github.com/users/aiidateam/following{/other_user}","gists_url":"https://api.github.com/users/aiidateam/gists{/gist_id}","starred_url":"https://api.github.com/users/aiidateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiidateam/subscriptions","organizations_url":"https://api.github.com/users/aiidateam/orgs","repos_url":"https://api.github.com/users/aiidateam/repos","events_url":"https://api.github.com/users/aiidateam/events{/privacy}","received_events_url":"https://api.github.com/users/aiidateam/received_events","type":"Organization","site_admin":false},"repo":{"id":77234579,"node_id":"MDEwOlJlcG9zaXRvcnk3NzIzNDU3OQ==","name":"aiida_core","full_name":"aiidateam/aiida_core","private":false,"owner":{"login":"aiidateam","id":22181836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTgxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/22181836?v=4","gravatar_id":"","url":"https://api.github.com/users/aiidateam","html_url":"https://github.com/aiidateam","followers_url":"https://api.github.com/users/aiidateam/followers","following_url":"https://api.github.com/users/aiidateam/following{/other_user}","gists_url":"https://api.github.com/users/aiidateam/gists{/gist_id}","starred_url":"https://api.github.com/users/aiidateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiidateam/subscriptions","organizations_url":"https://api.github.com/users/aiidateam/orgs","repos_url":"https://api.github.com/users/aiidateam/repos","events_url":"https://api.github.com/users/aiidateam/events{/privacy}","received_events_url":"https://api.github.com/users/aiidateam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aiidateam/aiida_core","description":"The official repository for the AiiDA code","fork":false,"url":"https://api.github.com/repos/aiidateam/aiida_core","forks_url":"https://api.github.com/repos/aiidateam/aiida_core/forks","keys_url":"https://api.github.com/repos/aiidateam/aiida_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiidateam/aiida_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiidateam/aiida_core/teams","hooks_url":"https://api.github.com/repos/aiidateam/aiida_core/hooks","issue_events_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/events{/number}","events_url":"https://api.github.com/repos/aiidateam/aiida_core/events","assignees_url":"https://api.github.com/repos/aiidateam/aiida_core/assignees{/user}","branches_url":"https://api.github.com/repos/aiidateam/aiida_core/branches{/branch}","tags_url":"https://api.github.com/repos/aiidateam/aiida_core/tags","blobs_url":"https://api.github.com/repos/aiidateam/aiida_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiidateam/aiida_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiidateam/aiida_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiidateam/aiida_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiidateam/aiida_core/statuses/{sha}","languages_url":"https://api.github.com/repos/aiidateam/aiida_core/languages","stargazers_url":"https://api.github.com/repos/aiidateam/aiida_core/stargazers","contributors_url":"https://api.github.com/repos/aiidateam/aiida_core/contributors","subscribers_url":"https://api.github.com/repos/aiidateam/aiida_core/subscribers","subscription_url":"https://api.github.com/repos/aiidateam/aiida_core/subscription","commits_url":"https://api.github.com/repos/aiidateam/aiida_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiidateam/aiida_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/aiidateam/aiida_core/contents/{+path}","compare_url":"https://api.github.com/repos/aiidateam/aiida_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiidateam/aiida_core/merges","archive_url":"https://api.github.com/repos/aiidateam/aiida_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiidateam/aiida_core/downloads","issues_url":"https://api.github.com/repos/aiidateam/aiida_core/issues{/number}","pulls_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls{/number}","milestones_url":"https://api.github.com/repos/aiidateam/aiida_core/milestones{/number}","notifications_url":"https://api.github.com/repos/aiidateam/aiida_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiidateam/aiida_core/labels{/name}","releases_url":"https://api.github.com/repos/aiidateam/aiida_core/releases{/id}","deployments_url":"https://api.github.com/repos/aiidateam/aiida_core/deployments","created_at":"2016-12-23T15:38:21Z","updated_at":"2018-10-25T10:50:56Z","pushed_at":"2018-10-25T13:28:23Z","git_url":"git://github.com/aiidateam/aiida_core.git","ssh_url":"git@github.com:aiidateam/aiida_core.git","clone_url":"https://github.com/aiidateam/aiida_core.git","svn_url":"https://github.com/aiidateam/aiida_core","homepage":null,"size":47485,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":248,"watchers":128,"default_branch":"develop"}},"base":{"label":"aiidateam:develop","ref":"develop","sha":"a9400ea314acfb9c11a740bf33a988d90e11d153","user":{"login":"aiidateam","id":22181836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTgxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/22181836?v=4","gravatar_id":"","url":"https://api.github.com/users/aiidateam","html_url":"https://github.com/aiidateam","followers_url":"https://api.github.com/users/aiidateam/followers","following_url":"https://api.github.com/users/aiidateam/following{/other_user}","gists_url":"https://api.github.com/users/aiidateam/gists{/gist_id}","starred_url":"https://api.github.com/users/aiidateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiidateam/subscriptions","organizations_url":"https://api.github.com/users/aiidateam/orgs","repos_url":"https://api.github.com/users/aiidateam/repos","events_url":"https://api.github.com/users/aiidateam/events{/privacy}","received_events_url":"https://api.github.com/users/aiidateam/received_events","type":"Organization","site_admin":false},"repo":{"id":77234579,"node_id":"MDEwOlJlcG9zaXRvcnk3NzIzNDU3OQ==","name":"aiida_core","full_name":"aiidateam/aiida_core","private":false,"owner":{"login":"aiidateam","id":22181836,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTgxODM2","avatar_url":"https://avatars3.githubusercontent.com/u/22181836?v=4","gravatar_id":"","url":"https://api.github.com/users/aiidateam","html_url":"https://github.com/aiidateam","followers_url":"https://api.github.com/users/aiidateam/followers","following_url":"https://api.github.com/users/aiidateam/following{/other_user}","gists_url":"https://api.github.com/users/aiidateam/gists{/gist_id}","starred_url":"https://api.github.com/users/aiidateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiidateam/subscriptions","organizations_url":"https://api.github.com/users/aiidateam/orgs","repos_url":"https://api.github.com/users/aiidateam/repos","events_url":"https://api.github.com/users/aiidateam/events{/privacy}","received_events_url":"https://api.github.com/users/aiidateam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aiidateam/aiida_core","description":"The official repository for the AiiDA code","fork":false,"url":"https://api.github.com/repos/aiidateam/aiida_core","forks_url":"https://api.github.com/repos/aiidateam/aiida_core/forks","keys_url":"https://api.github.com/repos/aiidateam/aiida_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiidateam/aiida_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiidateam/aiida_core/teams","hooks_url":"https://api.github.com/repos/aiidateam/aiida_core/hooks","issue_events_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/events{/number}","events_url":"https://api.github.com/repos/aiidateam/aiida_core/events","assignees_url":"https://api.github.com/repos/aiidateam/aiida_core/assignees{/user}","branches_url":"https://api.github.com/repos/aiidateam/aiida_core/branches{/branch}","tags_url":"https://api.github.com/repos/aiidateam/aiida_core/tags","blobs_url":"https://api.github.com/repos/aiidateam/aiida_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiidateam/aiida_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiidateam/aiida_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiidateam/aiida_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiidateam/aiida_core/statuses/{sha}","languages_url":"https://api.github.com/repos/aiidateam/aiida_core/languages","stargazers_url":"https://api.github.com/repos/aiidateam/aiida_core/stargazers","contributors_url":"https://api.github.com/repos/aiidateam/aiida_core/contributors","subscribers_url":"https://api.github.com/repos/aiidateam/aiida_core/subscribers","subscription_url":"https://api.github.com/repos/aiidateam/aiida_core/subscription","commits_url":"https://api.github.com/repos/aiidateam/aiida_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiidateam/aiida_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiidateam/aiida_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiidateam/aiida_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/aiidateam/aiida_core/contents/{+path}","compare_url":"https://api.github.com/repos/aiidateam/aiida_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiidateam/aiida_core/merges","archive_url":"https://api.github.com/repos/aiidateam/aiida_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiidateam/aiida_core/downloads","issues_url":"https://api.github.com/repos/aiidateam/aiida_core/issues{/number}","pulls_url":"https://api.github.com/repos/aiidateam/aiida_core/pulls{/number}","milestones_url":"https://api.github.com/repos/aiidateam/aiida_core/milestones{/number}","notifications_url":"https://api.github.com/repos/aiidateam/aiida_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiidateam/aiida_core/labels{/name}","releases_url":"https://api.github.com/repos/aiidateam/aiida_core/releases{/id}","deployments_url":"https://api.github.com/repos/aiidateam/aiida_core/deployments","created_at":"2016-12-23T15:38:21Z","updated_at":"2018-10-25T10:50:56Z","pushed_at":"2018-10-25T13:28:23Z","git_url":"git://github.com/aiidateam/aiida_core.git","ssh_url":"git@github.com:aiidateam/aiida_core.git","clone_url":"https://github.com/aiidateam/aiida_core.git","svn_url":"https://github.com/aiidateam/aiida_core","homepage":null,"size":47485,"stargazers_count":128,"watchers_count":128,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":248,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":248,"watchers":128,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113"},"html":{"href":"https://github.com/aiidateam/aiida_core/pull/2113"},"issue":{"href":"https://api.github.com/repos/aiidateam/aiida_core/issues/2113"},"comments":{"href":"https://api.github.com/repos/aiidateam/aiida_core/issues/2113/comments"},"review_comments":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113/comments"},"review_comment":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aiidateam/aiida_core/pulls/2113/commits"},"statuses":{"href":"https://api.github.com/repos/aiidateam/aiida_core/statuses/ef97ec82e350078488973a91f7cb9906589074a0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lekah"}}