{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/8000","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/8000/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/8000/comments","events_url":"https://api.github.com/repos/helm/charts/issues/8000/events","html_url":"https://github.com/helm/charts/pull/8000","id":364372496,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTc0ODAx","number":8000,"title":"[stable/prometheus-mysql-exporter] split datasource in separate mysql connection vars","user":{"login":"monotek","id":1069919,"node_id":"MDQ6VXNlcjEwNjk5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1069919?v=4","gravatar_id":"","url":"https://api.github.com/users/monotek","html_url":"https://github.com/monotek","followers_url":"https://api.github.com/users/monotek/followers","following_url":"https://api.github.com/users/monotek/following{/other_user}","gists_url":"https://api.github.com/users/monotek/gists{/gist_id}","starred_url":"https://api.github.com/users/monotek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monotek/subscriptions","organizations_url":"https://api.github.com/users/monotek/orgs","repos_url":"https://api.github.com/users/monotek/repos","events_url":"https://api.github.com/users/monotek/events{/privacy}","received_events_url":"https://api.github.com/users/monotek/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false}],"state":"open","locked":false,"assignee":{"login":"sameersbn","id":410147,"node_id":"MDQ6VXNlcjQxMDE0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/410147?v=4","gravatar_id":"","url":"https://api.github.com/users/sameersbn","html_url":"https://github.com/sameersbn","followers_url":"https://api.github.com/users/sameersbn/followers","following_url":"https://api.github.com/users/sameersbn/following{/other_user}","gists_url":"https://api.github.com/users/sameersbn/gists{/gist_id}","starred_url":"https://api.github.com/users/sameersbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameersbn/subscriptions","organizations_url":"https://api.github.com/users/sameersbn/orgs","repos_url":"https://api.github.com/users/sameersbn/repos","events_url":"https://api.github.com/users/sameersbn/events{/privacy}","received_events_url":"https://api.github.com/users/sameersbn/received_events","type":"User","site_admin":false},"assignees":[{"login":"sameersbn","id":410147,"node_id":"MDQ6VXNlcjQxMDE0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/410147?v=4","gravatar_id":"","url":"https://api.github.com/users/sameersbn","html_url":"https://github.com/sameersbn","followers_url":"https://api.github.com/users/sameersbn/followers","following_url":"https://api.github.com/users/sameersbn/following{/other_user}","gists_url":"https://api.github.com/users/sameersbn/gists{/gist_id}","starred_url":"https://api.github.com/users/sameersbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameersbn/subscriptions","organizations_url":"https://api.github.com/users/sameersbn/orgs","repos_url":"https://api.github.com/users/sameersbn/repos","events_url":"https://api.github.com/users/sameersbn/events{/privacy}","received_events_url":"https://api.github.com/users/sameersbn/received_events","type":"User","site_admin":false},{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},{"login":"cpanato","id":4115580,"node_id":"MDQ6VXNlcjQxMTU1ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/4115580?v=4","gravatar_id":"","url":"https://api.github.com/users/cpanato","html_url":"https://github.com/cpanato","followers_url":"https://api.github.com/users/cpanato/followers","following_url":"https://api.github.com/users/cpanato/following{/other_user}","gists_url":"https://api.github.com/users/cpanato/gists{/gist_id}","starred_url":"https://api.github.com/users/cpanato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpanato/subscriptions","organizations_url":"https://api.github.com/users/cpanato/orgs","repos_url":"https://api.github.com/users/cpanato/repos","events_url":"https://api.github.com/users/cpanato/events{/privacy}","received_events_url":"https://api.github.com/users/cpanato/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-09-27T09:01:23Z","updated_at":"2018-10-06T19:47:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/8000","html_url":"https://github.com/helm/charts/pull/8000","diff_url":"https://github.com/helm/charts/pull/8000.diff","patch_url":"https://github.com/helm/charts/pull/8000.patch"},"body":"Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>\r\n\r\n<!--\r\nThank you for contributing to helm/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/helm/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n#### What this PR does / why we need it:\r\n* splits datasource in separate mysql connection vars which makes secret handling easier (SOPS)\r\n* updated image version to 0.11.0\r\n\r\n#### Which issue this PR fixes\r\n*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*\r\n    - fixes #\r\n\r\n#### Special notes for your reviewer:\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n- [x] Variables are documented in the README.md\r\n"},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/427601380","html_url":"https://github.com/helm/charts/pull/8000#issuecomment-427601380","issue_url":"https://api.github.com/repos/helm/charts/issues/8000","id":427601380,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzYwMTM4MA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T19:47:26Z","updated_at":"2018-10-06T19:47:26Z","author_association":"CONTRIBUTOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/helm/charts/pull/8000#issuecomment-425103432\" title=\"LGTM\">cpanato</a>*, *<a href=\"https://github.com/helm/charts/pull/8000#issuecomment-427601374\" title=\"LGTM\">Juanchimienti</a>*, *<a href=\"https://github.com/helm/charts/pull/8000#\" title=\"Author self-approved\">monotek</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **sameersbn**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @sameersbn` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/helm/charts/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sameersbn\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}