{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/blueprint/issues/185","repository_url":"https://api.github.com/repos/palantir/blueprint","labels_url":"https://api.github.com/repos/palantir/blueprint/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/185/comments","events_url":"https://api.github.com/repos/palantir/blueprint/issues/185/events","html_url":"https://github.com/palantir/blueprint/issues/185","id":189818162,"node_id":"MDU6SXNzdWUxODk4MTgxNjI=","number":185,"title":"Support for client-side routing on href props","user":{"login":"isTravis","id":1000455,"node_id":"MDQ6VXNlcjEwMDA0NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1000455?v=4","gravatar_id":"","url":"https://api.github.com/users/isTravis","html_url":"https://github.com/isTravis","followers_url":"https://api.github.com/users/isTravis/followers","following_url":"https://api.github.com/users/isTravis/following{/other_user}","gists_url":"https://api.github.com/users/isTravis/gists{/gist_id}","starred_url":"https://api.github.com/users/isTravis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isTravis/subscriptions","organizations_url":"https://api.github.com/users/isTravis/orgs","repos_url":"https://api.github.com/users/isTravis/repos","events_url":"https://api.github.com/users/isTravis/events{/privacy}","received_events_url":"https://api.github.com/users/isTravis/received_events","type":"User","site_admin":false},"labels":[{"id":478396843,"node_id":"MDU6TGFiZWw0NzgzOTY4NDM=","url":"https://api.github.com/repos/palantir/blueprint/labels/P2","name":"P2","color":"e5bf47","default":false},{"id":480887469,"node_id":"MDU6TGFiZWw0ODA4ODc0Njk=","url":"https://api.github.com/repos/palantir/blueprint/labels/Package:%20core","name":"Package: core","color":"f5f8fa","default":false},{"id":478396761,"node_id":"MDU6TGFiZWw0NzgzOTY3NjE=","url":"https://api.github.com/repos/palantir/blueprint/labels/Status:%20needs%20proposal","name":"Status: needs proposal","color":"ffad6a","default":false},{"id":478396702,"node_id":"MDU6TGFiZWw0NzgzOTY3MDI=","url":"https://api.github.com/repos/palantir/blueprint/labels/Type:%20enhancement","name":"Type: enhancement","color":"f2ca4b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2016-11-16T19:33:09Z","updated_at":"2018-10-30T22:46:37Z","closed_at":null,"author_association":"NONE","body":"Many components (such as `Menu`) can take an href prop. This prop maps to the href value of an `<a>` tag. For many react projects that use client-side routing, anchor tags are replaced by `<Link>` (e.g. in [react-router](https://github.com/ReactTraining/react-router/blob/master/docs/API.md#link)) components that ensure the routing happens client-side. \r\n\r\nIf the `<Link>` component is placed inside the text prop, everything behaves as expected, but React throws a warning for having nested `<a>` tags. \r\n\r\nPerhaps we could supply our own component to be used in place of the `<a>` tag in these situations.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/palantir/blueprint/issues/comments/434497406","html_url":"https://github.com/palantir/blueprint/issues/185#issuecomment-434497406","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/185","id":434497406,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDQ5NzQwNg==","user":{"login":"jtreminio","id":589398,"node_id":"MDQ6VXNlcjU4OTM5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/589398?v=4","gravatar_id":"","url":"https://api.github.com/users/jtreminio","html_url":"https://github.com/jtreminio","followers_url":"https://api.github.com/users/jtreminio/followers","following_url":"https://api.github.com/users/jtreminio/following{/other_user}","gists_url":"https://api.github.com/users/jtreminio/gists{/gist_id}","starred_url":"https://api.github.com/users/jtreminio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtreminio/subscriptions","organizations_url":"https://api.github.com/users/jtreminio/orgs","repos_url":"https://api.github.com/users/jtreminio/repos","events_url":"https://api.github.com/users/jtreminio/events{/privacy}","received_events_url":"https://api.github.com/users/jtreminio/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T22:46:37Z","updated_at":"2018-10-30T22:46:37Z","author_association":"NONE","body":"I'm not familiar enough with either React or React Router to answer `does the state of the router stay in place`.\r\n\r\nI click the links and it takes me to the proper Component without doing a hard reload, seems to work exactly as React Router usually does when using `<Link>` component. I would assume since the official docs recommend this method it works as intended."}}
{"actor":{"display_login":"jtreminio"}}