{"action":"created","comment":{"url":"https://api.github.com/repos/googlesamples/easypermissions/pulls/comments/174920736","pull_request_review_id":104366895,"id":174920736,"diff_hunk":"@@ -152,32 +152,25 @@ public void onActivityResult(int requestCode, int resultCode, Intent data) {\n }\n ```\n \n-### RationaleCallbacks\n-Implement this callback if you want to interact with the rationale dialog.\n+### Interacting with the rationale dialog\n \n-```java\n-public class RationaleFragment extends Fragment implements EasyPermissions.RationaleCallbacks {\n+Implement the EasyPermissions.RationaleCallbacks if you want to interact with the rationale dialog.\n \n-    @Override\n-    public void onRationaleAccepted(int requestCode) {\n-        // Rationale accpets to request some permissions\n-        // ...\n-    }\n+```java\n+@Override\n+public void onRationaleAccepted(int requestCode) {\n+    // Rationale accpets to request some permissions\n+    // ...\n+}\n \n-    @Override\n-    public void onRationaleDenied(int requestCode) {\n-        // Rationale denied to request some permissions\n-        // ...\n-    }\n+@Override\n+public void onRationaleDenied(int requestCode) {\n+    // Rationale denied to request some permissions\n+    // ...\n }\n ```\n \n-Check out [RationaleFragment](https://github.com/googlesamples/blob/master/app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java) in the sample app folder for the full example.\n-\n-Note that permissions are not requested when the user denies or cancel the rationale dialog and `onPermissionsDenied` will be invoked.\n-The user will need to reinvoke the function that requests permissions. This is callbacks can be useful for analytics tracking and UI states\n-updates.\n-\n+Rationale callbacks don't necessarily imply permission changes. To check for those, see the EasyPermissions.PermissionCallbacks.","path":"README.md","position":null,"original_position":42,"commit_id":"3309d6a0a97751eeaa179c509be2aac51b4c40e1","original_commit_id":"3309d6a0a97751eeaa179c509be2aac51b4c40e1","user":{"login":"SUPERCILEX","id":9490724,"avatar_url":"https://avatars2.githubusercontent.com/u/9490724?v=4","gravatar_id":"","url":"https://api.github.com/users/SUPERCILEX","html_url":"https://github.com/SUPERCILEX","followers_url":"https://api.github.com/users/SUPERCILEX/followers","following_url":"https://api.github.com/users/SUPERCILEX/following{/other_user}","gists_url":"https://api.github.com/users/SUPERCILEX/gists{/gist_id}","starred_url":"https://api.github.com/users/SUPERCILEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUPERCILEX/subscriptions","organizations_url":"https://api.github.com/users/SUPERCILEX/orgs","repos_url":"https://api.github.com/users/SUPERCILEX/repos","events_url":"https://api.github.com/users/SUPERCILEX/events{/privacy}","received_events_url":"https://api.github.com/users/SUPERCILEX/received_events","type":"User","site_admin":false},"body":"Same here: \\`...\\`.","created_at":"2018-03-15T20:25:06Z","updated_at":"2018-03-15T20:26:29Z","html_url":"https://github.com/googlesamples/easypermissions/pull/208#discussion_r174920736","pull_request_url":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlesamples/easypermissions/pulls/comments/174920736"},"html":{"href":"https://github.com/googlesamples/easypermissions/pull/208#discussion_r174920736"},"pull_request":{"href":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208","id":174954256,"html_url":"https://github.com/googlesamples/easypermissions/pull/208","diff_url":"https://github.com/googlesamples/easypermissions/pull/208.diff","patch_url":"https://github.com/googlesamples/easypermissions/pull/208.patch","issue_url":"https://api.github.com/repos/googlesamples/easypermissions/issues/208","number":208,"state":"open","locked":false,"title":"Added RationaleDialogCallback","user":{"login":"ernestkamara","id":502798,"avatar_url":"https://avatars1.githubusercontent.com/u/502798?v=4","gravatar_id":"","url":"https://api.github.com/users/ernestkamara","html_url":"https://github.com/ernestkamara","followers_url":"https://api.github.com/users/ernestkamara/followers","following_url":"https://api.github.com/users/ernestkamara/following{/other_user}","gists_url":"https://api.github.com/users/ernestkamara/gists{/gist_id}","starred_url":"https://api.github.com/users/ernestkamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernestkamara/subscriptions","organizations_url":"https://api.github.com/users/ernestkamara/orgs","repos_url":"https://api.github.com/users/ernestkamara/repos","events_url":"https://api.github.com/users/ernestkamara/events{/privacy}","received_events_url":"https://api.github.com/users/ernestkamara/received_events","type":"User","site_admin":false},"body":"`RationaleDialogCallback` is an extension of `PermissionCallbacks` and forwards the rationale\r\ndialog buttons click events to the host that requesting a permission(s). `RationaleDialogCallback` is useful for events logging and is completely optional.\r\n\r\nCheck out [RationaleFragment](https://github.com/ernestkamara/easypermissions/blob/master/app/src/main/java/pub/devrel/easypermissions/sample/RationaleFragment.java) in the sample app folder for example.\r\n","created_at":"2018-03-14T13:26:59Z","updated_at":"2018-03-15T20:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e390a9377da883e5d51aab60c0e5788aa5e994f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208/commits","review_comments_url":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208/comments","review_comment_url":"https://api.github.com/repos/googlesamples/easypermissions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlesamples/easypermissions/issues/208/comments","statuses_url":"https://api.github.com/repos/googlesamples/easypermissions/statuses/3309d6a0a97751eeaa179c509be2aac51b4c40e1","head":{"label":"ernestkamara:master","ref":"master","sha":"3309d6a0a97751eeaa179c509be2aac51b4c40e1","user":{"login":"ernestkamara","id":502798,"avatar_url":"https://avatars1.githubusercontent.com/u/502798?v=4","gravatar_id":"","url":"https://api.github.com/users/ernestkamara","html_url":"https://github.com/ernestkamara","followers_url":"https://api.github.com/users/ernestkamara/followers","following_url":"https://api.github.com/users/ernestkamara/following{/other_user}","gists_url":"https://api.github.com/users/ernestkamara/gists{/gist_id}","starred_url":"https://api.github.com/users/ernestkamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernestkamara/subscriptions","organizations_url":"https://api.github.com/users/ernestkamara/orgs","repos_url":"https://api.github.com/users/ernestkamara/repos","events_url":"https://api.github.com/users/ernestkamara/events{/privacy}","received_events_url":"https://api.github.com/users/ernestkamara/received_events","type":"User","site_admin":false},"repo":{"id":95115322,"name":"easypermissions","full_name":"ernestkamara/easypermissions","owner":{"login":"ernestkamara","id":502798,"avatar_url":"https://avatars1.githubusercontent.com/u/502798?v=4","gravatar_id":"","url":"https://api.github.com/users/ernestkamara","html_url":"https://github.com/ernestkamara","followers_url":"https://api.github.com/users/ernestkamara/followers","following_url":"https://api.github.com/users/ernestkamara/following{/other_user}","gists_url":"https://api.github.com/users/ernestkamara/gists{/gist_id}","starred_url":"https://api.github.com/users/ernestkamara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ernestkamara/subscriptions","organizations_url":"https://api.github.com/users/ernestkamara/orgs","repos_url":"https://api.github.com/users/ernestkamara/repos","events_url":"https://api.github.com/users/ernestkamara/events{/privacy}","received_events_url":"https://api.github.com/users/ernestkamara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ernestkamara/easypermissions","description":"Simplify Android M system permissions","fork":true,"url":"https://api.github.com/repos/ernestkamara/easypermissions","forks_url":"https://api.github.com/repos/ernestkamara/easypermissions/forks","keys_url":"https://api.github.com/repos/ernestkamara/easypermissions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ernestkamara/easypermissions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ernestkamara/easypermissions/teams","hooks_url":"https://api.github.com/repos/ernestkamara/easypermissions/hooks","issue_events_url":"https://api.github.com/repos/ernestkamara/easypermissions/issues/events{/number}","events_url":"https://api.github.com/repos/ernestkamara/easypermissions/events","assignees_url":"https://api.github.com/repos/ernestkamara/easypermissions/assignees{/user}","branches_url":"https://api.github.com/repos/ernestkamara/easypermissions/branches{/branch}","tags_url":"https://api.github.com/repos/ernestkamara/easypermissions/tags","blobs_url":"https://api.github.com/repos/ernestkamara/easypermissions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ernestkamara/easypermissions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ernestkamara/easypermissions/git/refs{/sha}","trees_url":"https://api.github.com/repos/ernestkamara/easypermissions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ernestkamara/easypermissions/statuses/{sha}","languages_url":"https://api.github.com/repos/ernestkamara/easypermissions/languages","stargazers_url":"https://api.github.com/repos/ernestkamara/easypermissions/stargazers","contributors_url":"https://api.github.com/repos/ernestkamara/easypermissions/contributors","subscribers_url":"https://api.github.com/repos/ernestkamara/easypermissions/subscribers","subscription_url":"https://api.github.com/repos/ernestkamara/easypermissions/subscription","commits_url":"https://api.github.com/repos/ernestkamara/easypermissions/commits{/sha}","git_commits_url":"https://api.github.com/repos/ernestkamara/easypermissions/git/commits{/sha}","comments_url":"https://api.github.com/repos/ernestkamara/easypermissions/comments{/number}","issue_comment_url":"https://api.github.com/repos/ernestkamara/easypermissions/issues/comments{/number}","contents_url":"https://api.github.com/repos/ernestkamara/easypermissions/contents/{+path}","compare_url":"https://api.github.com/repos/ernestkamara/easypermissions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ernestkamara/easypermissions/merges","archive_url":"https://api.github.com/repos/ernestkamara/easypermissions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ernestkamara/easypermissions/downloads","issues_url":"https://api.github.com/repos/ernestkamara/easypermissions/issues{/number}","pulls_url":"https://api.github.com/repos/ernestkamara/easypermissions/pulls{/number}","milestones_url":"https://api.github.com/repos/ernestkamara/easypermissions/milestones{/number}","notifications_url":"https://api.github.com/repos/ernestkamara/easypermissions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ernestkamara/easypermissions/labels{/name}","releases_url":"https://api.github.com/repos/ernestkamara/easypermissions/releases{/id}","deployments_url":"https://api.github.com/repos/ernestkamara/easypermissions/deployments","created_at":"2017-06-22T12:52:41Z","updated_at":"2018-03-15T20:23:36Z","pushed_at":"2018-03-15T20:23:32Z","git_url":"git://github.com/ernestkamara/easypermissions.git","ssh_url":"git@github.com:ernestkamara/easypermissions.git","clone_url":"https://github.com/ernestkamara/easypermissions.git","svn_url":"https://github.com/ernestkamara/easypermissions","homepage":"","size":437,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlesamples:master","ref":"master","sha":"813e74493247a722c2c010445dcd926553fa0140","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":48446680,"name":"easypermissions","full_name":"googlesamples/easypermissions","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/easypermissions","description":"Simplify Android M system permissions","fork":false,"url":"https://api.github.com/repos/googlesamples/easypermissions","forks_url":"https://api.github.com/repos/googlesamples/easypermissions/forks","keys_url":"https://api.github.com/repos/googlesamples/easypermissions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/easypermissions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/easypermissions/teams","hooks_url":"https://api.github.com/repos/googlesamples/easypermissions/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/easypermissions/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/easypermissions/events","assignees_url":"https://api.github.com/repos/googlesamples/easypermissions/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/easypermissions/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/easypermissions/tags","blobs_url":"https://api.github.com/repos/googlesamples/easypermissions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/easypermissions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/easypermissions/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/easypermissions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/easypermissions/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/easypermissions/languages","stargazers_url":"https://api.github.com/repos/googlesamples/easypermissions/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/easypermissions/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/easypermissions/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/easypermissions/subscription","commits_url":"https://api.github.com/repos/googlesamples/easypermissions/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/easypermissions/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/easypermissions/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/easypermissions/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/easypermissions/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/easypermissions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/easypermissions/merges","archive_url":"https://api.github.com/repos/googlesamples/easypermissions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/easypermissions/downloads","issues_url":"https://api.github.com/repos/googlesamples/easypermissions/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/easypermissions/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/easypermissions/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/easypermissions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/easypermissions/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/easypermissions/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/easypermissions/deployments","created_at":"2015-12-22T18:05:53Z","updated_at":"2018-03-15T15:55:53Z","pushed_at":"2018-03-15T20:23:36Z","git_url":"git://github.com/googlesamples/easypermissions.git","ssh_url":"git@github.com:googlesamples/easypermissions.git","clone_url":"https://github.com/googlesamples/easypermissions.git","svn_url":"https://github.com/googlesamples/easypermissions","homepage":"https://firebaseopensource.com/projects/googlesamples/easypermissions/","size":432,"stargazers_count":5249,"watchers_count":5249,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":879,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":879,"open_issues":4,"watchers":5249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208"},"html":{"href":"https://github.com/googlesamples/easypermissions/pull/208"},"issue":{"href":"https://api.github.com/repos/googlesamples/easypermissions/issues/208"},"comments":{"href":"https://api.github.com/repos/googlesamples/easypermissions/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/googlesamples/easypermissions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlesamples/easypermissions/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/googlesamples/easypermissions/statuses/3309d6a0a97751eeaa179c509be2aac51b4c40e1"}},"author_association":"NONE"}}
{"actor":{"display_login":"SUPERCILEX"}}