{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/200460705","pull_request_review_id":134783377,"id":200460705,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQ2MDcwNQ==","diff_hunk":"@@ -24,13 +24,14 @@\n import java.util.Objects;\n import lombok.extern.slf4j.Slf4j;\n import org.apache.pulsar.tests.DockerUtils;\n+import org.testcontainers.containers.output.Slf4jLogConsumer;\n import org.testcontainers.containers.wait.strategy.HostPortWaitStrategy;\n \n /**\n  * Abstract Test Container for Pulsar.\n  */\n @Slf4j\n-public abstract class PulsarContainer<SelfT extends PulsarContainer<SelfT>> extends ChaosContainer<SelfT> {\n+public class PulsarContainer<SELF extends PulsarContainer<SELF>> extends ChaosContainer<SELF> {","path":"tests/integration-tests-topologies/src/main/java/org/apache/pulsar/tests/containers/PulsarContainer.java","position":12,"original_position":12,"commit_id":"a848ac9d34249281456a41178a06ed21faac110d","original_commit_id":"a848ac9d34249281456a41178a06ed21faac110d","user":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"body":"will restore it","created_at":"2018-07-05T19:13:36Z","updated_at":"2018-07-05T19:13:36Z","html_url":"https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200460705","pull_request_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/200460705"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/2078#discussion_r200460705"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078"}},"in_reply_to_id":200437290},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078","id":199064724,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MDY0NzI0","html_url":"https://github.com/apache/incubator-pulsar/pull/2078","diff_url":"https://github.com/apache/incubator-pulsar/pull/2078.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/2078.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/2078","number":2078,"state":"open","locked":false,"title":"Enhance Pulsar cluster with container logs","user":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"body":"### Motivation\r\nThis is continuation of the existing work to move from the arquiilian framework to test containers library , here we focus on more traceability in the pulsar test containers with logging and migrate the smoke test from the old framework.\r\n\r\n### Result\r\nSmoke test based on testcontainers should be removing the older arquillian based version.","created_at":"2018-07-03T19:40:13Z","updated_at":"2018-07-05T19:13:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e57fcfa176891e0f409ab9e71a0d202dfa7e575","assignee":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"assignees":[{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":440785362,"node_id":"MDU6TGFiZWw0NDA3ODUzNjI=","url":"https://api.github.com/repos/apache/incubator-pulsar/labels/component/test","name":"component/test","color":"006b75","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/13","html_url":"https://github.com/apache/incubator-pulsar/milestone/13","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/13/labels","id":3118453,"node_id":"MDk6TWlsZXN0b25lMzExODQ1Mw==","number":13,"title":"2.1.0-incubating","description":"","creator":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":265,"state":"open","created_at":"2018-02-15T04:20:44Z","updated_at":"2018-07-05T19:08:38Z","due_on":"2018-06-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/2078/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/a848ac9d34249281456a41178a06ed21faac110d","head":{"label":"aahmed-se:testMigration1","ref":"testMigration1","sha":"a848ac9d34249281456a41178a06ed21faac110d","user":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"repo":{"id":113290037,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyOTAwMzc=","name":"incubator-pulsar","full_name":"aahmed-se/incubator-pulsar","owner":{"login":"aahmed-se","id":8009085,"node_id":"MDQ6VXNlcjgwMDkwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/8009085?v=4","gravatar_id":"","url":"https://api.github.com/users/aahmed-se","html_url":"https://github.com/aahmed-se","followers_url":"https://api.github.com/users/aahmed-se/followers","following_url":"https://api.github.com/users/aahmed-se/following{/other_user}","gists_url":"https://api.github.com/users/aahmed-se/gists{/gist_id}","starred_url":"https://api.github.com/users/aahmed-se/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aahmed-se/subscriptions","organizations_url":"https://api.github.com/users/aahmed-se/orgs","repos_url":"https://api.github.com/users/aahmed-se/repos","events_url":"https://api.github.com/users/aahmed-se/events{/privacy}","received_events_url":"https://api.github.com/users/aahmed-se/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aahmed-se/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/aahmed-se/incubator-pulsar","forks_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/aahmed-se/incubator-pulsar/deployments","created_at":"2017-12-06T08:34:39Z","updated_at":"2018-06-21T21:06:50Z","pushed_at":"2018-07-05T05:41:30Z","git_url":"git://github.com/aahmed-se/incubator-pulsar.git","ssh_url":"git@github.com:aahmed-se/incubator-pulsar.git","clone_url":"https://github.com/aahmed-se/incubator-pulsar.git","svn_url":"https://github.com/aahmed-se/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":26899,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"59fc8e22ac75f0b7c9e718444bd74cb4dbbd01ea","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxMg==","name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2018-07-05T15:36:07Z","pushed_at":"2018-07-05T16:38:51Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":35822,"stargazers_count":1811,"watchers_count":1811,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":377,"open_issues":165,"watchers":1811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/2078"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/2078"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/2078/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/2078/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/a848ac9d34249281456a41178a06ed21faac110d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aahmed-se"}}