{"action":"created","comment":{"url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments/186223617","pull_request_review_id":117770223,"id":186223617,"diff_hunk":"@@ -123,6 +127,8 @@ class VASTParser\n                     # Get full URL if url is defined\n                     ad.nextWrapperURL = @resolveVastAdTagURI(ad.nextWrapperURL, url)\n \n+                 # sequence doesn't carry over in wrapper element\n+                options.determinedSequence = ad.sequence","path":"src/parser.coffee","position":16,"original_position":16,"commit_id":"c3dca62d7acbf929c654cd84939b4a1d7ad8cf24","original_commit_id":"c3dca62d7acbf929c654cd84939b4a1d7ad8cf24","user":{"login":"walkerflocker","id":20342359,"avatar_url":"https://avatars2.githubusercontent.com/u/20342359?v=4","gravatar_id":"","url":"https://api.github.com/users/walkerflocker","html_url":"https://github.com/walkerflocker","followers_url":"https://api.github.com/users/walkerflocker/followers","following_url":"https://api.github.com/users/walkerflocker/following{/other_user}","gists_url":"https://api.github.com/users/walkerflocker/gists{/gist_id}","starred_url":"https://api.github.com/users/walkerflocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkerflocker/subscriptions","organizations_url":"https://api.github.com/users/walkerflocker/orgs","repos_url":"https://api.github.com/users/walkerflocker/repos","events_url":"https://api.github.com/users/walkerflocker/events{/privacy}","received_events_url":"https://api.github.com/users/walkerflocker/received_events","type":"User","site_admin":false},"body":"for sure, will also make a test","created_at":"2018-05-04T21:15:23Z","updated_at":"2018-05-04T21:15:24Z","html_url":"https://github.com/dailymotion/vast-client-js/pull/214#discussion_r186223617","pull_request_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments/186223617"},"html":{"href":"https://github.com/dailymotion/vast-client-js/pull/214#discussion_r186223617"},"pull_request":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214"}},"in_reply_to_id":185754338},"pull_request":{"url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214","id":183809964,"html_url":"https://github.com/dailymotion/vast-client-js/pull/214","diff_url":"https://github.com/dailymotion/vast-client-js/pull/214.diff","patch_url":"https://github.com/dailymotion/vast-client-js/pull/214.patch","issue_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/214","number":214,"state":"open","locked":false,"title":"Sequence persists for wrapper ad","user":{"login":"walkerflocker","id":20342359,"avatar_url":"https://avatars2.githubusercontent.com/u/20342359?v=4","gravatar_id":"","url":"https://api.github.com/users/walkerflocker","html_url":"https://github.com/walkerflocker","followers_url":"https://api.github.com/users/walkerflocker/followers","following_url":"https://api.github.com/users/walkerflocker/following{/other_user}","gists_url":"https://api.github.com/users/walkerflocker/gists{/gist_id}","starred_url":"https://api.github.com/users/walkerflocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkerflocker/subscriptions","organizations_url":"https://api.github.com/users/walkerflocker/orgs","repos_url":"https://api.github.com/users/walkerflocker/repos","events_url":"https://api.github.com/users/walkerflocker/events{/privacy}","received_events_url":"https://api.github.com/users/walkerflocker/received_events","type":"User","site_admin":false},"body":"If there is a wrapper tag in an ad with a sequence, this pr will set that sequence on the ad found from the wrapper request. Right now it is coming back as null","created_at":"2018-04-24T17:29:15Z","updated_at":"2018-05-04T21:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98445901973da98f59e4ea8236bb92dc28f9717a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":31088698,"url":"https://api.github.com/repos/dailymotion/vast-client-js/labels/bug","name":"bug","color":"fc2929","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214/commits","review_comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214/comments","review_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/214/comments","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/c3dca62d7acbf929c654cd84939b4a1d7ad8cf24","head":{"label":"walkerflocker:preserve-sequence-on-wrapper","ref":"preserve-sequence-on-wrapper","sha":"c3dca62d7acbf929c654cd84939b4a1d7ad8cf24","user":{"login":"walkerflocker","id":20342359,"avatar_url":"https://avatars2.githubusercontent.com/u/20342359?v=4","gravatar_id":"","url":"https://api.github.com/users/walkerflocker","html_url":"https://github.com/walkerflocker","followers_url":"https://api.github.com/users/walkerflocker/followers","following_url":"https://api.github.com/users/walkerflocker/following{/other_user}","gists_url":"https://api.github.com/users/walkerflocker/gists{/gist_id}","starred_url":"https://api.github.com/users/walkerflocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkerflocker/subscriptions","organizations_url":"https://api.github.com/users/walkerflocker/orgs","repos_url":"https://api.github.com/users/walkerflocker/repos","events_url":"https://api.github.com/users/walkerflocker/events{/privacy}","received_events_url":"https://api.github.com/users/walkerflocker/received_events","type":"User","site_admin":false},"repo":{"id":130887471,"name":"vast-client-js","full_name":"walkerflocker/vast-client-js","owner":{"login":"walkerflocker","id":20342359,"avatar_url":"https://avatars2.githubusercontent.com/u/20342359?v=4","gravatar_id":"","url":"https://api.github.com/users/walkerflocker","html_url":"https://github.com/walkerflocker","followers_url":"https://api.github.com/users/walkerflocker/followers","following_url":"https://api.github.com/users/walkerflocker/following{/other_user}","gists_url":"https://api.github.com/users/walkerflocker/gists{/gist_id}","starred_url":"https://api.github.com/users/walkerflocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walkerflocker/subscriptions","organizations_url":"https://api.github.com/users/walkerflocker/orgs","repos_url":"https://api.github.com/users/walkerflocker/repos","events_url":"https://api.github.com/users/walkerflocker/events{/privacy}","received_events_url":"https://api.github.com/users/walkerflocker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/walkerflocker/vast-client-js","description":"VAST 3.0 client library for JavaScript","fork":true,"url":"https://api.github.com/repos/walkerflocker/vast-client-js","forks_url":"https://api.github.com/repos/walkerflocker/vast-client-js/forks","keys_url":"https://api.github.com/repos/walkerflocker/vast-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walkerflocker/vast-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walkerflocker/vast-client-js/teams","hooks_url":"https://api.github.com/repos/walkerflocker/vast-client-js/hooks","issue_events_url":"https://api.github.com/repos/walkerflocker/vast-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/walkerflocker/vast-client-js/events","assignees_url":"https://api.github.com/repos/walkerflocker/vast-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/walkerflocker/vast-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/walkerflocker/vast-client-js/tags","blobs_url":"https://api.github.com/repos/walkerflocker/vast-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walkerflocker/vast-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walkerflocker/vast-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/walkerflocker/vast-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walkerflocker/vast-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/walkerflocker/vast-client-js/languages","stargazers_url":"https://api.github.com/repos/walkerflocker/vast-client-js/stargazers","contributors_url":"https://api.github.com/repos/walkerflocker/vast-client-js/contributors","subscribers_url":"https://api.github.com/repos/walkerflocker/vast-client-js/subscribers","subscription_url":"https://api.github.com/repos/walkerflocker/vast-client-js/subscription","commits_url":"https://api.github.com/repos/walkerflocker/vast-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/walkerflocker/vast-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/walkerflocker/vast-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/walkerflocker/vast-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/walkerflocker/vast-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/walkerflocker/vast-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walkerflocker/vast-client-js/merges","archive_url":"https://api.github.com/repos/walkerflocker/vast-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walkerflocker/vast-client-js/downloads","issues_url":"https://api.github.com/repos/walkerflocker/vast-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/walkerflocker/vast-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/walkerflocker/vast-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/walkerflocker/vast-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walkerflocker/vast-client-js/labels{/name}","releases_url":"https://api.github.com/repos/walkerflocker/vast-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/walkerflocker/vast-client-js/deployments","created_at":"2018-04-24T17:02:45Z","updated_at":"2018-04-24T17:23:27Z","pushed_at":"2018-05-02T18:01:39Z","git_url":"git://github.com/walkerflocker/vast-client-js.git","ssh_url":"git@github.com:walkerflocker/vast-client-js.git","clone_url":"https://github.com/walkerflocker/vast-client-js.git","svn_url":"https://github.com/walkerflocker/vast-client-js","homepage":"http://www.iab.net/media/file/VASTv3.0.pdf","size":1002,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dailymotion:master","ref":"master","sha":"8870707729f8cc5fed7688562fc5d9f000e5cfe0","user":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars2.githubusercontent.com/u/115313?v=4","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"repo":{"id":8641521,"name":"vast-client-js","full_name":"dailymotion/vast-client-js","owner":{"login":"dailymotion","id":115313,"avatar_url":"https://avatars2.githubusercontent.com/u/115313?v=4","gravatar_id":"","url":"https://api.github.com/users/dailymotion","html_url":"https://github.com/dailymotion","followers_url":"https://api.github.com/users/dailymotion/followers","following_url":"https://api.github.com/users/dailymotion/following{/other_user}","gists_url":"https://api.github.com/users/dailymotion/gists{/gist_id}","starred_url":"https://api.github.com/users/dailymotion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dailymotion/subscriptions","organizations_url":"https://api.github.com/users/dailymotion/orgs","repos_url":"https://api.github.com/users/dailymotion/repos","events_url":"https://api.github.com/users/dailymotion/events{/privacy}","received_events_url":"https://api.github.com/users/dailymotion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dailymotion/vast-client-js","description":"VAST 3.0 client library for JavaScript","fork":false,"url":"https://api.github.com/repos/dailymotion/vast-client-js","forks_url":"https://api.github.com/repos/dailymotion/vast-client-js/forks","keys_url":"https://api.github.com/repos/dailymotion/vast-client-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dailymotion/vast-client-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dailymotion/vast-client-js/teams","hooks_url":"https://api.github.com/repos/dailymotion/vast-client-js/hooks","issue_events_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/events{/number}","events_url":"https://api.github.com/repos/dailymotion/vast-client-js/events","assignees_url":"https://api.github.com/repos/dailymotion/vast-client-js/assignees{/user}","branches_url":"https://api.github.com/repos/dailymotion/vast-client-js/branches{/branch}","tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/tags","blobs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/{sha}","languages_url":"https://api.github.com/repos/dailymotion/vast-client-js/languages","stargazers_url":"https://api.github.com/repos/dailymotion/vast-client-js/stargazers","contributors_url":"https://api.github.com/repos/dailymotion/vast-client-js/contributors","subscribers_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscribers","subscription_url":"https://api.github.com/repos/dailymotion/vast-client-js/subscription","commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/dailymotion/vast-client-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/dailymotion/vast-client-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/dailymotion/vast-client-js/contents/{+path}","compare_url":"https://api.github.com/repos/dailymotion/vast-client-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dailymotion/vast-client-js/merges","archive_url":"https://api.github.com/repos/dailymotion/vast-client-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dailymotion/vast-client-js/downloads","issues_url":"https://api.github.com/repos/dailymotion/vast-client-js/issues{/number}","pulls_url":"https://api.github.com/repos/dailymotion/vast-client-js/pulls{/number}","milestones_url":"https://api.github.com/repos/dailymotion/vast-client-js/milestones{/number}","notifications_url":"https://api.github.com/repos/dailymotion/vast-client-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dailymotion/vast-client-js/labels{/name}","releases_url":"https://api.github.com/repos/dailymotion/vast-client-js/releases{/id}","deployments_url":"https://api.github.com/repos/dailymotion/vast-client-js/deployments","created_at":"2013-03-08T02:37:23Z","updated_at":"2018-05-02T16:16:04Z","pushed_at":"2018-05-02T18:01:40Z","git_url":"git://github.com/dailymotion/vast-client-js.git","ssh_url":"git@github.com:dailymotion/vast-client-js.git","clone_url":"https://github.com/dailymotion/vast-client-js.git","svn_url":"https://github.com/dailymotion/vast-client-js","homepage":"https://www.iab.com/wp-content/uploads/2015/06/VASTv3_0.pdf","size":1066,"stargazers_count":201,"watchers_count":201,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":140,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":140,"open_issues":12,"watchers":201,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214"},"html":{"href":"https://github.com/dailymotion/vast-client-js/pull/214"},"issue":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/issues/214"},"comments":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/dailymotion/vast-client-js/statuses/c3dca62d7acbf929c654cd84939b4a1d7ad8cf24"}},"author_association":"NONE"}}
{"actor":{"display_login":"walkerflocker"}}