{"action":"created","comment":{"url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/comments/193599073","pull_request_review_id":126601926,"id":193599073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzU5OTA3Mw==","diff_hunk":"@@ -141,20 +141,15 @@ function onReady(app) {\n                 //experimentalFeatures: true,\n                 disableBlinkFeatures: 'Auxclick',\n                 devTools: app.config.app.debug,\n-                preload: path.join(app.dir.desktopApp, 'preload.js')\n+                preload: path.resolve(__dirname, 'preload.js'),\n             },\n-            icon: path.join(app.dir.root, 'assets/icons/png/256x256.png')\n+            icon: __static + '/assets/icons/png/256x256.png'\n         });\n+        const webAppPath = (isDevMode())? `http://localhost:${process.env.ELECTRON_WEBPACK_WDS_PORT}/index.html` : `file://${__dirname}/index.html`;\n+        \n+        app.win.loadURL(webAppPath);\n \n-        let webAppPath = path.join(app.dir.root, '/app/src', 'index.html');\n-\n-        app.win.loadURL(url.format({\n-            pathname: webAppPath,\n-            protocol: 'file:',\n-            slashes: true\n-        }));\n-\n-        if (app.config.app.debug) {\n+        if (isDebugging()) {","path":"src/main/main.js","position":null,"original_position":58,"commit_id":"352b8ee1f9083e1e7fabac7d2895a4582f0a6a09","original_commit_id":"274c785805bac2f27b3b7afafcdb9370c9ef0b83","user":{"login":"altninja","id":8450022,"node_id":"MDQ6VXNlcjg0NTAwMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/8450022?v=4","gravatar_id":"","url":"https://api.github.com/users/altninja","html_url":"https://github.com/altninja","followers_url":"https://api.github.com/users/altninja/followers","following_url":"https://api.github.com/users/altninja/following{/other_user}","gists_url":"https://api.github.com/users/altninja/gists{/gist_id}","starred_url":"https://api.github.com/users/altninja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/altninja/subscriptions","organizations_url":"https://api.github.com/users/altninja/orgs","repos_url":"https://api.github.com/users/altninja/repos","events_url":"https://api.github.com/users/altninja/events{/privacy}","received_events_url":"https://api.github.com/users/altninja/received_events","type":"User","site_admin":false},"body":"I wonder if we can move the Debugging / Dev mode stuff in to a single function / conditional instead of I think there are 3 now in the main process?","created_at":"2018-06-07T00:39:36Z","updated_at":"2018-06-07T00:59:02Z","html_url":"https://github.com/SelfKeyFoundation/Identity-Wallet/pull/208#discussion_r193599073","pull_request_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/comments/193599073"},"html":{"href":"https://github.com/SelfKeyFoundation/Identity-Wallet/pull/208#discussion_r193599073"},"pull_request":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208","id":192369415,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzY5NDE1","html_url":"https://github.com/SelfKeyFoundation/Identity-Wallet/pull/208","diff_url":"https://github.com/SelfKeyFoundation/Identity-Wallet/pull/208.diff","patch_url":"https://github.com/SelfKeyFoundation/Identity-Wallet/pull/208.patch","issue_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/208","number":208,"state":"closed","locked":false,"title":"Fix/build with webpack","user":{"login":"dfcowell","id":1295890,"node_id":"MDQ6VXNlcjEyOTU4OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1295890?v=4","gravatar_id":"","url":"https://api.github.com/users/dfcowell","html_url":"https://github.com/dfcowell","followers_url":"https://api.github.com/users/dfcowell/followers","following_url":"https://api.github.com/users/dfcowell/following{/other_user}","gists_url":"https://api.github.com/users/dfcowell/gists{/gist_id}","starred_url":"https://api.github.com/users/dfcowell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfcowell/subscriptions","organizations_url":"https://api.github.com/users/dfcowell/orgs","repos_url":"https://api.github.com/users/dfcowell/repos","events_url":"https://api.github.com/users/dfcowell/events{/privacy}","received_events_url":"https://api.github.com/users/dfcowell/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-04T10:52:06Z","updated_at":"2018-06-07T00:59:02Z","closed_at":"2018-06-06T18:04:38Z","merged_at":null,"merge_commit_sha":"b3f7c394d7803f853aabd0a88c034cda18bdaec0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208/commits","review_comments_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208/comments","review_comment_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/208/comments","statuses_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/statuses/352b8ee1f9083e1e7fabac7d2895a4582f0a6a09","head":{"label":"SelfKeyFoundation:fix/build-with-webpack","ref":"fix/build-with-webpack","sha":"352b8ee1f9083e1e7fabac7d2895a4582f0a6a09","user":{"login":"SelfKeyFoundation","id":32091359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDkxMzU5","avatar_url":"https://avatars3.githubusercontent.com/u/32091359?v=4","gravatar_id":"","url":"https://api.github.com/users/SelfKeyFoundation","html_url":"https://github.com/SelfKeyFoundation","followers_url":"https://api.github.com/users/SelfKeyFoundation/followers","following_url":"https://api.github.com/users/SelfKeyFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SelfKeyFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SelfKeyFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SelfKeyFoundation/subscriptions","organizations_url":"https://api.github.com/users/SelfKeyFoundation/orgs","repos_url":"https://api.github.com/users/SelfKeyFoundation/repos","events_url":"https://api.github.com/users/SelfKeyFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SelfKeyFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":105664964,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2NjQ5NjQ=","name":"Identity-Wallet","full_name":"SelfKeyFoundation/Identity-Wallet","owner":{"login":"SelfKeyFoundation","id":32091359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDkxMzU5","avatar_url":"https://avatars3.githubusercontent.com/u/32091359?v=4","gravatar_id":"","url":"https://api.github.com/users/SelfKeyFoundation","html_url":"https://github.com/SelfKeyFoundation","followers_url":"https://api.github.com/users/SelfKeyFoundation/followers","following_url":"https://api.github.com/users/SelfKeyFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SelfKeyFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SelfKeyFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SelfKeyFoundation/subscriptions","organizations_url":"https://api.github.com/users/SelfKeyFoundation/orgs","repos_url":"https://api.github.com/users/SelfKeyFoundation/repos","events_url":"https://api.github.com/users/SelfKeyFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SelfKeyFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SelfKeyFoundation/Identity-Wallet","description":"Code for the SelfKey Identity Wallet","fork":false,"url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet","forks_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/forks","keys_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/teams","hooks_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/hooks","issue_events_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/events{/number}","events_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/events","assignees_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/assignees{/user}","branches_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/branches{/branch}","tags_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/tags","blobs_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/languages","stargazers_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/stargazers","contributors_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/contributors","subscribers_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/subscribers","subscription_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/subscription","commits_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/contents/{+path}","compare_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/merges","archive_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/downloads","issues_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues{/number}","pulls_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/labels{/name}","releases_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/releases{/id}","deployments_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/deployments","created_at":"2017-10-03T14:57:43Z","updated_at":"2018-06-01T08:17:13Z","pushed_at":"2018-06-07T00:47:19Z","git_url":"git://github.com/SelfKeyFoundation/Identity-Wallet.git","ssh_url":"git@github.com:SelfKeyFoundation/Identity-Wallet.git","clone_url":"https://github.com/SelfKeyFoundation/Identity-Wallet.git","svn_url":"https://github.com/SelfKeyFoundation/Identity-Wallet","homepage":null,"size":22025,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":6,"watchers":11,"default_branch":"dev"}},"base":{"label":"SelfKeyFoundation:dev","ref":"dev","sha":"182163e45f3fdbe93880fa6841b2b25170f04d64","user":{"login":"SelfKeyFoundation","id":32091359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDkxMzU5","avatar_url":"https://avatars3.githubusercontent.com/u/32091359?v=4","gravatar_id":"","url":"https://api.github.com/users/SelfKeyFoundation","html_url":"https://github.com/SelfKeyFoundation","followers_url":"https://api.github.com/users/SelfKeyFoundation/followers","following_url":"https://api.github.com/users/SelfKeyFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SelfKeyFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SelfKeyFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SelfKeyFoundation/subscriptions","organizations_url":"https://api.github.com/users/SelfKeyFoundation/orgs","repos_url":"https://api.github.com/users/SelfKeyFoundation/repos","events_url":"https://api.github.com/users/SelfKeyFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SelfKeyFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":105664964,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2NjQ5NjQ=","name":"Identity-Wallet","full_name":"SelfKeyFoundation/Identity-Wallet","owner":{"login":"SelfKeyFoundation","id":32091359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDkxMzU5","avatar_url":"https://avatars3.githubusercontent.com/u/32091359?v=4","gravatar_id":"","url":"https://api.github.com/users/SelfKeyFoundation","html_url":"https://github.com/SelfKeyFoundation","followers_url":"https://api.github.com/users/SelfKeyFoundation/followers","following_url":"https://api.github.com/users/SelfKeyFoundation/following{/other_user}","gists_url":"https://api.github.com/users/SelfKeyFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/SelfKeyFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SelfKeyFoundation/subscriptions","organizations_url":"https://api.github.com/users/SelfKeyFoundation/orgs","repos_url":"https://api.github.com/users/SelfKeyFoundation/repos","events_url":"https://api.github.com/users/SelfKeyFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/SelfKeyFoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SelfKeyFoundation/Identity-Wallet","description":"Code for the SelfKey Identity Wallet","fork":false,"url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet","forks_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/forks","keys_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/teams","hooks_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/hooks","issue_events_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/events{/number}","events_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/events","assignees_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/assignees{/user}","branches_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/branches{/branch}","tags_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/tags","blobs_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/languages","stargazers_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/stargazers","contributors_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/contributors","subscribers_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/subscribers","subscription_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/subscription","commits_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/contents/{+path}","compare_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/merges","archive_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/downloads","issues_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues{/number}","pulls_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/labels{/name}","releases_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/releases{/id}","deployments_url":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/deployments","created_at":"2017-10-03T14:57:43Z","updated_at":"2018-06-01T08:17:13Z","pushed_at":"2018-06-07T00:47:19Z","git_url":"git://github.com/SelfKeyFoundation/Identity-Wallet.git","ssh_url":"git@github.com:SelfKeyFoundation/Identity-Wallet.git","clone_url":"https://github.com/SelfKeyFoundation/Identity-Wallet.git","svn_url":"https://github.com/SelfKeyFoundation/Identity-Wallet","homepage":null,"size":22025,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":6,"watchers":11,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208"},"html":{"href":"https://github.com/SelfKeyFoundation/Identity-Wallet/pull/208"},"issue":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/208"},"comments":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/SelfKeyFoundation/Identity-Wallet/statuses/352b8ee1f9083e1e7fabac7d2895a4582f0a6a09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"altninja"}}