{"action":"created","issue":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2170","repository_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2170/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2170/comments","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2170/events","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/2170","id":308004654,"number":2170,"title":"Improve bulk product image upload UX","user":{"login":"myriamboure","id":8135376,"avatar_url":"https://avatars0.githubusercontent.com/u/8135376?v=4","gravatar_id":"","url":"https://api.github.com/users/myriamboure","html_url":"https://github.com/myriamboure","followers_url":"https://api.github.com/users/myriamboure/followers","following_url":"https://api.github.com/users/myriamboure/following{/other_user}","gists_url":"https://api.github.com/users/myriamboure/gists{/gist_id}","starred_url":"https://api.github.com/users/myriamboure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myriamboure/subscriptions","organizations_url":"https://api.github.com/users/myriamboure/orgs","repos_url":"https://api.github.com/users/myriamboure/repos","events_url":"https://api.github.com/users/myriamboure/events{/privacy}","received_events_url":"https://api.github.com/users/myriamboure/received_events","type":"User","site_admin":false},"labels":[{"id":782472441,"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/labels/bug-s3","name":"bug-s3","color":"ff9600","default":false}],"state":"open","locked":false,"assignee":{"login":"Matt-Yorkley","id":9029026,"avatar_url":"https://avatars0.githubusercontent.com/u/9029026?v=4","gravatar_id":"","url":"https://api.github.com/users/Matt-Yorkley","html_url":"https://github.com/Matt-Yorkley","followers_url":"https://api.github.com/users/Matt-Yorkley/followers","following_url":"https://api.github.com/users/Matt-Yorkley/following{/other_user}","gists_url":"https://api.github.com/users/Matt-Yorkley/gists{/gist_id}","starred_url":"https://api.github.com/users/Matt-Yorkley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matt-Yorkley/subscriptions","organizations_url":"https://api.github.com/users/Matt-Yorkley/orgs","repos_url":"https://api.github.com/users/Matt-Yorkley/repos","events_url":"https://api.github.com/users/Matt-Yorkley/events{/privacy}","received_events_url":"https://api.github.com/users/Matt-Yorkley/received_events","type":"User","site_admin":false},"assignees":[{"login":"Matt-Yorkley","id":9029026,"avatar_url":"https://avatars0.githubusercontent.com/u/9029026?v=4","gravatar_id":"","url":"https://api.github.com/users/Matt-Yorkley","html_url":"https://github.com/Matt-Yorkley","followers_url":"https://api.github.com/users/Matt-Yorkley/followers","following_url":"https://api.github.com/users/Matt-Yorkley/following{/other_user}","gists_url":"https://api.github.com/users/Matt-Yorkley/gists{/gist_id}","starred_url":"https://api.github.com/users/Matt-Yorkley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matt-Yorkley/subscriptions","organizations_url":"https://api.github.com/users/Matt-Yorkley/orgs","repos_url":"https://api.github.com/users/Matt-Yorkley/repos","events_url":"https://api.github.com/users/Matt-Yorkley/events{/privacy}","received_events_url":"https://api.github.com/users/Matt-Yorkley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-03-23T12:05:26Z","updated_at":"2018-03-29T12:28:45Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Description\r\nWhile testing https://github.com/openfoodfoundation/openfoodnetwork/pull/1464 new feature to upload image in bulk product edit page, I noticed that the upload UX was a bit user unfriendly.\r\n\r\n## Expected Behavior\r\n\r\nStill being discussed so wait until we have agreed on a solution before starting!!!\r\n\r\n**Option 1:**\r\n- If there is no image I click on image frame, open modal with “choose image”, I choose, it upload in the preview modal and I have two options “change image” or “confirm”. If click “change image” I am asked to choose again an image. If I click on “confirm” the modal closes and the image displays in the product bulk edit list.\r\n- If there is an image I can click on it either to see it bigger or because I want to change it. So if I click on an existing image should have the preview modal open with only one button “change image” (and ability to close the modal of course)\r\n\r\n**Option 2:**\r\n- If there is no image I click on image frame, open modal with “choose image”, I choose, it uploads, closes the modal directly and displays instantly in the product bulk edit list without the preview step. (less clicks is better)\r\n- If there is an image I can click on it either to see it bigger or because I want to change it. So if I click on an existing image should have the preview modal open with only one button “change image” (and ability to close the modal of course). That way I can also check how my image looks like if I want, but it makes the process quicker for those who just want to go quick.\r\n\r\n\r\n## Actual Behavior\r\nWhen upload a image in bulk product edit page, display preview but modal remains open with \"upload an image\" button (confusing and one more click needed)\r\n\r\n## Steps to Reproduce\r\n1. On \"products\", bulk edit product page\r\n2. Click on an empty image frame on the first column, upload an image and see UX\r\n\r\n## Animated Gif/Screenshot\r\n![screenshot from 2018-03-23 13-01-10](https://user-images.githubusercontent.com/8135376/37828117-4ec59918-2e9a-11e8-8847-924444e55b29.png)\r\n\r\n## Context\r\nNoticed that while testing bulk edit product image upload PR1464\r\n\r\n## Severity\r\ns3\r\n\r\n## Your Environment\r\n- Version used: branch PR1464 deployed on UK stagig\r\n- Browser name and version: Version 64.0.3282.167 (Official Build) (64-bit)\r\n- Operating System and version (desktop or mobile): Ubuntu 16.04 LTS\r\n\r\n## Possible Fix\r\n- either no preview, closes the modal as soon as image is chosen\r\n- either preview but the two button choices: \"change image\" or \"accept\"\r\nSill in discussion\r\n"},"comment":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/comments/377219587","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/2170#issuecomment-377219587","issue_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2170","id":377219587,"user":{"login":"daniellemoorhead","id":10949052,"avatar_url":"https://avatars1.githubusercontent.com/u/10949052?v=4","gravatar_id":"","url":"https://api.github.com/users/daniellemoorhead","html_url":"https://github.com/daniellemoorhead","followers_url":"https://api.github.com/users/daniellemoorhead/followers","following_url":"https://api.github.com/users/daniellemoorhead/following{/other_user}","gists_url":"https://api.github.com/users/daniellemoorhead/gists{/gist_id}","starred_url":"https://api.github.com/users/daniellemoorhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniellemoorhead/subscriptions","organizations_url":"https://api.github.com/users/daniellemoorhead/orgs","repos_url":"https://api.github.com/users/daniellemoorhead/repos","events_url":"https://api.github.com/users/daniellemoorhead/events{/privacy}","received_events_url":"https://api.github.com/users/daniellemoorhead/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T12:28:45Z","updated_at":"2018-03-29T12:28:45Z","author_association":"NONE","body":"Will leave to @sstead and potentially @oeoeaio to have an opinion :-)"}}
{"actor":{"display_login":"daniellemoorhead"}}