{"action":"created","issue":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1471","repository_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1471/labels{/name}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1471/comments","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1471/events","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/issues/1471","id":328942507,"node_id":"MDU6SXNzdWUzMjg5NDI1MDc=","number":1471,"title":"Split NodeSettings class and also ensure that settings objects are always in the loaded state","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-04T07:43:03Z","updated_at":"2018-06-04T08:13:25Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The NodeSettings class is currently both a configuration source for all settings classes AND the settings class for the base feature. This improvement splits the class into two separate classes: `NodeConfiguration` and `BaseSettings`. \r\n\r\nIn addition the use of public xxxSettings(Action<RpcSettings> callback) will be replaced with public xxxSettings(NodeSettings nodeSettings, Action<RpcSettings> callback) in the singletons so that the settings objects will always be in the loaded state. Example:\r\n\r\n```\r\n                features\r\n                .AddFeature<BaseFeature>()\r\n                .FeatureServices(services =>\r\n                {\r\n                    services.AddSingleton<DBreezeSerializer>();\r\n                   // Ensure that the settings are loaded...\r\n                    services.AddSingleton<BaseSettings>(new BaseSettings(fullNodeBuilder.NodeSettings, setup));\r\n                    services.AddSingleton(fullNodeBuilder.NodeSettings.LoggerFactory);\r\n\r\n```\r\n\r\nThe above will also remove the need for the `LoadConfiguration` call in the `NodeSettings` constructor.\r\n\r\nThis will require 2 or 3 PRs to make the changes easy to review."},"comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments/394270834","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/issues/1471#issuecomment-394270834","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1471","id":394270834,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDI3MDgzNA==","user":{"login":"quantumagi","id":29645989,"node_id":"MDQ6VXNlcjI5NjQ1OTg5","avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"created_at":"2018-06-04T08:13:25Z","updated_at":"2018-06-04T08:13:25Z","author_association":"CONTRIBUTOR","body":"This first PR is ensuring that we have a `public xxxSettings(NodeSettings nodeSettings, Action callback)` method for all settings classes and also does some logging improvements."}}
{"actor":{"display_login":"quantumagi"}}