{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/215605977","pull_request_review_id":152905016,"id":215605977,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTYwNTk3Nw==","diff_hunk":"@@ -6,8 +6,8 @@ export const config = () => {\n     version: '0.1',\n     /** Configuration related with session */\n     session: {\n-      /** TimeOut in Minutes default 24 hours */\n-      sessionTimeOut: 24 * UNIT_TIME.HOUR * MILLISECONDS,\n+      /** TimeOut in Minutes default 10 hours */\n+      sessionTimeOut: 10 * UNIT_TIME.HOUR * MILLISECONDS,","path":"src/config.ts","position":7,"original_position":7,"commit_id":"b7468bb4d0d20d1d211662082e9b3af2652964a2","original_commit_id":"b7468bb4d0d20d1d211662082e9b3af2652964a2","user":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"body":"Well, that's not that easy, the backend value is configurable by user, whereas the frontend value is not. That's why I say it would be better that the frontend reads the token expiry date.","created_at":"2018-09-06T12:29:31Z","updated_at":"2018-09-06T12:29:32Z","html_url":"https://github.com/kiali/kiali-ui/pull/652#discussion_r215605977","pull_request_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/652","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments/215605977"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/652#discussion_r215605977"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/652"}},"in_reply_to_id":215601156},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/652","id":213593240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTkzMjQw","html_url":"https://github.com/kiali/kiali-ui/pull/652","diff_url":"https://github.com/kiali/kiali-ui/pull/652.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/652.patch","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/652","number":652,"state":"open","locked":false,"title":"KIALI-1457 Fix frontend session timeout out of sync ","user":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"body":"… with actual backend timeout\r\nAlso add a better error message in such situation.\r\n\r\nhttps://issues.jboss.org/browse/KIALI-1457\r\n\r\n","created_at":"2018-09-06T12:02:28Z","updated_at":"2018-09-06T12:29:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35f05f57a3d6330b96c757b2aa35e6f8a806b3c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/652/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/652/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/652/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/b7468bb4d0d20d1d211662082e9b3af2652964a2","head":{"label":"jotak:kiali-1457","ref":"kiali-1457","sha":"b7468bb4d0d20d1d211662082e9b3af2652964a2","user":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"repo":{"id":120734238,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA3MzQyMzg=","name":"swsui","full_name":"jotak/swsui","owner":{"login":"jotak","id":2153442,"node_id":"MDQ6VXNlcjIxNTM0NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2153442?v=4","gravatar_id":"","url":"https://api.github.com/users/jotak","html_url":"https://github.com/jotak","followers_url":"https://api.github.com/users/jotak/followers","following_url":"https://api.github.com/users/jotak/following{/other_user}","gists_url":"https://api.github.com/users/jotak/gists{/gist_id}","starred_url":"https://api.github.com/users/jotak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jotak/subscriptions","organizations_url":"https://api.github.com/users/jotak/orgs","repos_url":"https://api.github.com/users/jotak/repos","events_url":"https://api.github.com/users/jotak/events{/privacy}","received_events_url":"https://api.github.com/users/jotak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jotak/swsui","description":null,"fork":true,"url":"https://api.github.com/repos/jotak/swsui","forks_url":"https://api.github.com/repos/jotak/swsui/forks","keys_url":"https://api.github.com/repos/jotak/swsui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jotak/swsui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jotak/swsui/teams","hooks_url":"https://api.github.com/repos/jotak/swsui/hooks","issue_events_url":"https://api.github.com/repos/jotak/swsui/issues/events{/number}","events_url":"https://api.github.com/repos/jotak/swsui/events","assignees_url":"https://api.github.com/repos/jotak/swsui/assignees{/user}","branches_url":"https://api.github.com/repos/jotak/swsui/branches{/branch}","tags_url":"https://api.github.com/repos/jotak/swsui/tags","blobs_url":"https://api.github.com/repos/jotak/swsui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jotak/swsui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jotak/swsui/git/refs{/sha}","trees_url":"https://api.github.com/repos/jotak/swsui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jotak/swsui/statuses/{sha}","languages_url":"https://api.github.com/repos/jotak/swsui/languages","stargazers_url":"https://api.github.com/repos/jotak/swsui/stargazers","contributors_url":"https://api.github.com/repos/jotak/swsui/contributors","subscribers_url":"https://api.github.com/repos/jotak/swsui/subscribers","subscription_url":"https://api.github.com/repos/jotak/swsui/subscription","commits_url":"https://api.github.com/repos/jotak/swsui/commits{/sha}","git_commits_url":"https://api.github.com/repos/jotak/swsui/git/commits{/sha}","comments_url":"https://api.github.com/repos/jotak/swsui/comments{/number}","issue_comment_url":"https://api.github.com/repos/jotak/swsui/issues/comments{/number}","contents_url":"https://api.github.com/repos/jotak/swsui/contents/{+path}","compare_url":"https://api.github.com/repos/jotak/swsui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jotak/swsui/merges","archive_url":"https://api.github.com/repos/jotak/swsui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jotak/swsui/downloads","issues_url":"https://api.github.com/repos/jotak/swsui/issues{/number}","pulls_url":"https://api.github.com/repos/jotak/swsui/pulls{/number}","milestones_url":"https://api.github.com/repos/jotak/swsui/milestones{/number}","notifications_url":"https://api.github.com/repos/jotak/swsui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jotak/swsui/labels{/name}","releases_url":"https://api.github.com/repos/jotak/swsui/releases{/id}","deployments_url":"https://api.github.com/repos/jotak/swsui/deployments","created_at":"2018-02-08T08:39:31Z","updated_at":"2018-05-23T06:55:32Z","pushed_at":"2018-09-06T12:06:51Z","git_url":"git://github.com/jotak/swsui.git","ssh_url":"git@github.com:jotak/swsui.git","clone_url":"https://github.com/jotak/swsui.git","svn_url":"https://github.com/jotak/swsui","homepage":null,"size":2903,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"e66b7704806cdb4a928a5c8f609a54036be26376","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":120308264,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDgyNjQ=","name":"kiali-ui","full_name":"kiali/kiali-ui","owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiali/kiali-ui","description":"Frontend part of Kiali (use kiali/kial to report issues)","fork":false,"url":"https://api.github.com/repos/kiali/kiali-ui","forks_url":"https://api.github.com/repos/kiali/kiali-ui/forks","keys_url":"https://api.github.com/repos/kiali/kiali-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-ui/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-ui/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-ui/events","assignees_url":"https://api.github.com/repos/kiali/kiali-ui/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-ui/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-ui/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-ui/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-ui/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-ui/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-ui/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-ui/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-ui/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-ui/merges","archive_url":"https://api.github.com/repos/kiali/kiali-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-ui/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-ui/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-ui/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-ui/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-ui/deployments","created_at":"2018-02-05T13:27:15Z","updated_at":"2018-09-05T15:28:14Z","pushed_at":"2018-09-06T12:06:53Z","git_url":"git://github.com/kiali/kiali-ui.git","ssh_url":"git@github.com:kiali/kiali-ui.git","clone_url":"https://github.com/kiali/kiali-ui.git","svn_url":"https://github.com/kiali/kiali-ui","homepage":"https://kiali.io","size":2892,"stargazers_count":32,"watchers_count":32,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":7,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/652"},"html":{"href":"https://github.com/kiali/kiali-ui/pull/652"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/652"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/issues/652/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/652/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-ui/pulls/652/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-ui/statuses/b7468bb4d0d20d1d211662082e9b3af2652964a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jotak"}}