{"action":"created","issue":{"url":"https://api.github.com/repos/castwide/solargraph/issues/82","repository_url":"https://api.github.com/repos/castwide/solargraph","labels_url":"https://api.github.com/repos/castwide/solargraph/issues/82/labels{/name}","comments_url":"https://api.github.com/repos/castwide/solargraph/issues/82/comments","events_url":"https://api.github.com/repos/castwide/solargraph/issues/82/events","html_url":"https://github.com/castwide/solargraph/pull/82","id":351903145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzYwMjg2","number":82,"title":"FIX: Request textDocument/hover failed","user":{"login":"piktur","id":3710893,"node_id":"MDQ6VXNlcjM3MTA4OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3710893?v=4","gravatar_id":"","url":"https://api.github.com/users/piktur","html_url":"https://github.com/piktur","followers_url":"https://api.github.com/users/piktur/followers","following_url":"https://api.github.com/users/piktur/following{/other_user}","gists_url":"https://api.github.com/users/piktur/gists{/gist_id}","starred_url":"https://api.github.com/users/piktur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piktur/subscriptions","organizations_url":"https://api.github.com/users/piktur/orgs","repos_url":"https://api.github.com/users/piktur/repos","events_url":"https://api.github.com/users/piktur/events{/privacy}","received_events_url":"https://api.github.com/users/piktur/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-19T13:28:34Z","updated_at":"2018-08-19T22:54:32Z","closed_at":"2018-08-19T19:31:44Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/castwide/solargraph/pulls/82","html_url":"https://github.com/castwide/solargraph/pull/82","diff_url":"https://github.com/castwide/solargraph/pull/82.diff","patch_url":"https://github.com/castwide/solargraph/pull/82.patch"},"body":"Great news from #81! Looking forward to the improvement. In the meantime this PR attempts to ensure correct type for String addition:\r\n\r\nVSCode log output\r\n```\r\n[Error] Request textDocument/definition failed.\r\n  Message: [TypeError] no implicit conversion of nil into String\r\n  Code: -32603 \r\n```\r\n\r\nand backtrace from VSCode DevTools\r\n<img width=\"977\" alt=\"screen shot 2018-08-19 at 22 55 36\" src=\"https://user-images.githubusercontent.com/3710893/44309210-8f8de400-a406-11e8-8ad9-a6760472e9b6.png\">\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/castwide/solargraph/issues/comments/414161848","html_url":"https://github.com/castwide/solargraph/pull/82#issuecomment-414161848","issue_url":"https://api.github.com/repos/castwide/solargraph/issues/82","id":414161848,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDE2MTg0OA==","user":{"login":"castwide","id":3704922,"node_id":"MDQ6VXNlcjM3MDQ5MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/3704922?v=4","gravatar_id":"","url":"https://api.github.com/users/castwide","html_url":"https://github.com/castwide","followers_url":"https://api.github.com/users/castwide/followers","following_url":"https://api.github.com/users/castwide/following{/other_user}","gists_url":"https://api.github.com/users/castwide/gists{/gist_id}","starred_url":"https://api.github.com/users/castwide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/castwide/subscriptions","organizations_url":"https://api.github.com/users/castwide/orgs","repos_url":"https://api.github.com/users/castwide/repos","events_url":"https://api.github.com/users/castwide/events{/privacy}","received_events_url":"https://api.github.com/users/castwide/received_events","type":"User","site_admin":false},"created_at":"2018-08-19T22:54:32Z","updated_at":"2018-08-19T22:54:32Z","author_association":"OWNER","body":"Writing a spec for this case, I noticed that similar problems can happen with a few other Fragment methods, so I added some more changes to ensure that `word`, `remainder`, `signature`, `base`, and `chain` (and methods that compose from them like `whole_word`) always return strings. Thanks again for the catch."}}
{"actor":{"display_login":"castwide"}}