{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/comments/201438161","pull_request_review_id":135940870,"id":201438161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQzODE2MQ==","diff_hunk":"@@ -99,6 +104,11 @@ export class ScriptingService implements IScriptingService {\n \t\tthis._providers[providerId] = provider;\n \t}\n \n+\tpublic isProviderRegistered(providerId: string): boolean {\n+\t\tlet provider = this._providers[providerId];\n+\t\treturn !!provider;","path":"src/sql/services/scripting/scriptingService.ts","position":18,"original_position":18,"commit_id":"14bb5a80b72ce14222fcae78e7f72867e5e2f427","original_commit_id":"14bb5a80b72ce14222fcae78e7f72867e5e2f427","user":{"login":"kevcunnane","id":10819925,"node_id":"MDQ6VXNlcjEwODE5OTI1","avatar_url":"https://avatars3.githubusercontent.com/u/10819925?v=4","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"body":"No - it says it \"should\" be a boolean, not that it is. It'd just return a reference to the provider, which would let us do a falsy check by not have a boolean. Therefore it's nicer to have it really return an actual boolean instead.","created_at":"2018-07-10T17:56:27Z","updated_at":"2018-07-10T17:56:28Z","html_url":"https://github.com/Microsoft/sqlopsstudio/pull/1883#discussion_r201438161","pull_request_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/comments/201438161"},"html":{"href":"https://github.com/Microsoft/sqlopsstudio/pull/1883#discussion_r201438161"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883"}},"in_reply_to_id":201432804},"pull_request":{"url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883","id":200267858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjY3ODU4","html_url":"https://github.com/Microsoft/sqlopsstudio/pull/1883","diff_url":"https://github.com/Microsoft/sqlopsstudio/pull/1883.diff","patch_url":"https://github.com/Microsoft/sqlopsstudio/pull/1883.patch","issue_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/1883","number":1883,"state":"open","locked":false,"title":"Extensibility: Context menu support in Object Explorer ","user":{"login":"kevcunnane","id":10819925,"node_id":"MDQ6VXNlcjEwODE5OTI1","avatar_url":"https://avatars3.githubusercontent.com/u/10819925?v=4","gravatar_id":"","url":"https://api.github.com/users/kevcunnane","html_url":"https://github.com/kevcunnane","followers_url":"https://api.github.com/users/kevcunnane/followers","following_url":"https://api.github.com/users/kevcunnane/following{/other_user}","gists_url":"https://api.github.com/users/kevcunnane/gists{/gist_id}","starred_url":"https://api.github.com/users/kevcunnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevcunnane/subscriptions","organizations_url":"https://api.github.com/users/kevcunnane/orgs","repos_url":"https://api.github.com/users/kevcunnane/repos","events_url":"https://api.github.com/users/kevcunnane/events{/privacy}","received_events_url":"https://api.github.com/users/kevcunnane/received_events","type":"User","site_admin":false},"body":"- Fixes #1867 context menu should be extensible\r\n- Added context keys to support \"when\" conditions on the new extensions\r\n- Fixes issue where actions like New Query, scripting show up even if these are not valid for the provider type or object type\r\n- Fixed node expansion bug where rapid connect / expand / disconnect could break the app (fix in ObjectExplorerService.onNodeExpanded)\r\n- Major change to how internal actions work. These cannot assume the context has non-serializable objects. Opened up some APIs to make this easier to handle.\r\n- Fixed a number of existing bugs in internal actions.\r\n  - Notably, DisconnectAction was adding a listener on each right-click on an active connection and never getting it disposed. This wasn't needed at all due to design changes.\r\n  - Another bug fix is that the Manage action now correctly navigates to the DB dashboard for database-level connections. Before this it went to the server-level dashboard.","created_at":"2018-07-10T02:37:31Z","updated_at":"2018-07-10T17:56:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ee8cdc4ad2b0afaeb91cfa94a486400e189b9ad","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anthonydresser","id":4324725,"node_id":"MDQ6VXNlcjQzMjQ3MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4324725?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonydresser","html_url":"https://github.com/anthonydresser","followers_url":"https://api.github.com/users/anthonydresser/followers","following_url":"https://api.github.com/users/anthonydresser/following{/other_user}","gists_url":"https://api.github.com/users/anthonydresser/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonydresser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonydresser/subscriptions","organizations_url":"https://api.github.com/users/anthonydresser/orgs","repos_url":"https://api.github.com/users/anthonydresser/repos","events_url":"https://api.github.com/users/anthonydresser/events{/privacy}","received_events_url":"https://api.github.com/users/anthonydresser/received_events","type":"User","site_admin":false},{"login":"llali","id":17187348,"node_id":"MDQ6VXNlcjE3MTg3MzQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17187348?v=4","gravatar_id":"","url":"https://api.github.com/users/llali","html_url":"https://github.com/llali","followers_url":"https://api.github.com/users/llali/followers","following_url":"https://api.github.com/users/llali/following{/other_user}","gists_url":"https://api.github.com/users/llali/gists{/gist_id}","starred_url":"https://api.github.com/users/llali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llali/subscriptions","organizations_url":"https://api.github.com/users/llali/orgs","repos_url":"https://api.github.com/users/llali/repos","events_url":"https://api.github.com/users/llali/events{/privacy}","received_events_url":"https://api.github.com/users/llali/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883/commits","review_comments_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883/comments","review_comment_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/1883/comments","statuses_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/statuses/14bb5a80b72ce14222fcae78e7f72867e5e2f427","head":{"label":"Microsoft:feat/oeContextContributions","ref":"feat/oeContextContributions","sha":"14bb5a80b72ce14222fcae78e7f72867e5e2f427","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"sqlopsstudio","full_name":"Microsoft/sqlopsstudio","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sqlopsstudio","description":"SQL Operations Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/Microsoft/sqlopsstudio","forks_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/forks","keys_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/teams","hooks_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/events","assignees_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/tags","blobs_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/subscription","commits_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/merges","archive_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/downloads","issues_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2018-07-10T16:53:04Z","pushed_at":"2018-07-10T16:53:01Z","git_url":"git://github.com/Microsoft/sqlopsstudio.git","ssh_url":"git@github.com:Microsoft/sqlopsstudio.git","clone_url":"https://github.com/Microsoft/sqlopsstudio.git","svn_url":"https://github.com/Microsoft/sqlopsstudio","homepage":"","size":26942,"stargazers_count":3873,"watchers_count":3873,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":230,"open_issues":584,"watchers":3873,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b2ceb09e4dec09da5175bc6618c3fe6cb361dd2f","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":109200851,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkyMDA4NTE=","name":"sqlopsstudio","full_name":"Microsoft/sqlopsstudio","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sqlopsstudio","description":"SQL Operations Studio is a data management tool that enables working with SQL Server, Azure SQL DB and SQL DW from Windows, macOS and Linux.","fork":false,"url":"https://api.github.com/repos/Microsoft/sqlopsstudio","forks_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/forks","keys_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/teams","hooks_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/events","assignees_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/tags","blobs_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/subscription","commits_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/merges","archive_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/downloads","issues_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sqlopsstudio/deployments","created_at":"2017-11-02T01:00:13Z","updated_at":"2018-07-10T16:53:04Z","pushed_at":"2018-07-10T16:53:01Z","git_url":"git://github.com/Microsoft/sqlopsstudio.git","ssh_url":"git@github.com:Microsoft/sqlopsstudio.git","clone_url":"https://github.com/Microsoft/sqlopsstudio.git","svn_url":"https://github.com/Microsoft/sqlopsstudio","homepage":"","size":26942,"stargazers_count":3873,"watchers_count":3873,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":230,"open_issues":584,"watchers":3873,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883"},"html":{"href":"https://github.com/Microsoft/sqlopsstudio/pull/1883"},"issue":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/1883"},"comments":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/issues/1883/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/pulls/1883/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/sqlopsstudio/statuses/14bb5a80b72ce14222fcae78e7f72867e5e2f427"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kevcunnane"}}