{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/Ada-C10/hotel/pulls/36","id":214363428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzYzNDI4","html_url":"https://github.com/Ada-C10/hotel/pull/36","diff_url":"https://github.com/Ada-C10/hotel/pull/36.diff","patch_url":"https://github.com/Ada-C10/hotel/pull/36.patch","issue_url":"https://api.github.com/repos/Ada-C10/hotel/issues/36","number":36,"state":"open","locked":false,"title":"Val - Edges - Hotel","user":{"login":"valgidzi","id":18450444,"node_id":"MDQ6VXNlcjE4NDUwNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/18450444?v=4","gravatar_id":"","url":"https://api.github.com/users/valgidzi","html_url":"https://github.com/valgidzi","followers_url":"https://api.github.com/users/valgidzi/followers","following_url":"https://api.github.com/users/valgidzi/following{/other_user}","gists_url":"https://api.github.com/users/valgidzi/gists{/gist_id}","starred_url":"https://api.github.com/users/valgidzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valgidzi/subscriptions","organizations_url":"https://api.github.com/users/valgidzi/orgs","repos_url":"https://api.github.com/users/valgidzi/repos","events_url":"https://api.github.com/users/valgidzi/events{/privacy}","received_events_url":"https://api.github.com/users/valgidzi/received_events","type":"User","site_admin":false},"body":"# Hotel\r\nCongratulations! You're submitting your assignment!\r\n\r\n## Comprehension Questions\r\nQuestion | Answer\r\n:------------- | :-------------\r\nDescribe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? | One of the biggest design decisions I made was to not make a Room class. I decided to store the room numbers as hash keys paired with reservation date array values. I decided not to make a room class because in this program rooms only have data, not behavior.\r\nDescribe a concept that you gained more clarity on as you worked on this assignment. | I gained a better understanding of the importance of writing code that is easy to change. It was easier to make design decisions because I wasn't forced to stick with them if I decided to make another change down the road.\r\nDescribe a _nominal test_ that you wrote for this assignment. | For the Reservation#get_all_dates method, I wrote a nominal test - \"contains all dates for a reservation in the same month\".\r\nDescribe an _edge case test_ that you wrote for this assignment. | For the Reservation#get_all_dates method, I wrote an edge case test - \"contains all dates for a reservation spanning 2 years\".\r\nHow do you feel you did in writing pseudocode first, then writing the tests and then the code? | Generally, I feel I did well with the workflow. Sometimes I would slip out of writing pseudocode and start writing actual code, but overall I followed the workflow and felt it gave me a better approach to writing my code.\r\n","created_at":"2018-09-10T15:56:22Z","updated_at":"2018-09-10T15:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C10/hotel/pulls/36/commits","review_comments_url":"https://api.github.com/repos/Ada-C10/hotel/pulls/36/comments","review_comment_url":"https://api.github.com/repos/Ada-C10/hotel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C10/hotel/issues/36/comments","statuses_url":"https://api.github.com/repos/Ada-C10/hotel/statuses/104690cdc6539ef1f83373c9789e3da24a556f19","head":{"label":"valgidzi:master","ref":"master","sha":"104690cdc6539ef1f83373c9789e3da24a556f19","user":{"login":"valgidzi","id":18450444,"node_id":"MDQ6VXNlcjE4NDUwNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/18450444?v=4","gravatar_id":"","url":"https://api.github.com/users/valgidzi","html_url":"https://github.com/valgidzi","followers_url":"https://api.github.com/users/valgidzi/followers","following_url":"https://api.github.com/users/valgidzi/following{/other_user}","gists_url":"https://api.github.com/users/valgidzi/gists{/gist_id}","starred_url":"https://api.github.com/users/valgidzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valgidzi/subscriptions","organizations_url":"https://api.github.com/users/valgidzi/orgs","repos_url":"https://api.github.com/users/valgidzi/repos","events_url":"https://api.github.com/users/valgidzi/events{/privacy}","received_events_url":"https://api.github.com/users/valgidzi/received_events","type":"User","site_admin":false},"repo":{"id":147566186,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1NjYxODY=","name":"hotel","full_name":"valgidzi/hotel","owner":{"login":"valgidzi","id":18450444,"node_id":"MDQ6VXNlcjE4NDUwNDQ0","avatar_url":"https://avatars2.githubusercontent.com/u/18450444?v=4","gravatar_id":"","url":"https://api.github.com/users/valgidzi","html_url":"https://github.com/valgidzi","followers_url":"https://api.github.com/users/valgidzi/followers","following_url":"https://api.github.com/users/valgidzi/following{/other_user}","gists_url":"https://api.github.com/users/valgidzi/gists{/gist_id}","starred_url":"https://api.github.com/users/valgidzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valgidzi/subscriptions","organizations_url":"https://api.github.com/users/valgidzi/orgs","repos_url":"https://api.github.com/users/valgidzi/repos","events_url":"https://api.github.com/users/valgidzi/events{/privacy}","received_events_url":"https://api.github.com/users/valgidzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/valgidzi/hotel","description":null,"fork":true,"url":"https://api.github.com/repos/valgidzi/hotel","forks_url":"https://api.github.com/repos/valgidzi/hotel/forks","keys_url":"https://api.github.com/repos/valgidzi/hotel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valgidzi/hotel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valgidzi/hotel/teams","hooks_url":"https://api.github.com/repos/valgidzi/hotel/hooks","issue_events_url":"https://api.github.com/repos/valgidzi/hotel/issues/events{/number}","events_url":"https://api.github.com/repos/valgidzi/hotel/events","assignees_url":"https://api.github.com/repos/valgidzi/hotel/assignees{/user}","branches_url":"https://api.github.com/repos/valgidzi/hotel/branches{/branch}","tags_url":"https://api.github.com/repos/valgidzi/hotel/tags","blobs_url":"https://api.github.com/repos/valgidzi/hotel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valgidzi/hotel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valgidzi/hotel/git/refs{/sha}","trees_url":"https://api.github.com/repos/valgidzi/hotel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valgidzi/hotel/statuses/{sha}","languages_url":"https://api.github.com/repos/valgidzi/hotel/languages","stargazers_url":"https://api.github.com/repos/valgidzi/hotel/stargazers","contributors_url":"https://api.github.com/repos/valgidzi/hotel/contributors","subscribers_url":"https://api.github.com/repos/valgidzi/hotel/subscribers","subscription_url":"https://api.github.com/repos/valgidzi/hotel/subscription","commits_url":"https://api.github.com/repos/valgidzi/hotel/commits{/sha}","git_commits_url":"https://api.github.com/repos/valgidzi/hotel/git/commits{/sha}","comments_url":"https://api.github.com/repos/valgidzi/hotel/comments{/number}","issue_comment_url":"https://api.github.com/repos/valgidzi/hotel/issues/comments{/number}","contents_url":"https://api.github.com/repos/valgidzi/hotel/contents/{+path}","compare_url":"https://api.github.com/repos/valgidzi/hotel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valgidzi/hotel/merges","archive_url":"https://api.github.com/repos/valgidzi/hotel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valgidzi/hotel/downloads","issues_url":"https://api.github.com/repos/valgidzi/hotel/issues{/number}","pulls_url":"https://api.github.com/repos/valgidzi/hotel/pulls{/number}","milestones_url":"https://api.github.com/repos/valgidzi/hotel/milestones{/number}","notifications_url":"https://api.github.com/repos/valgidzi/hotel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valgidzi/hotel/labels{/name}","releases_url":"https://api.github.com/repos/valgidzi/hotel/releases{/id}","deployments_url":"https://api.github.com/repos/valgidzi/hotel/deployments","created_at":"2018-09-05T19:02:37Z","updated_at":"2018-09-10T15:43:31Z","pushed_at":"2018-09-10T15:43:29Z","git_url":"git://github.com/valgidzi/hotel.git","ssh_url":"git@github.com:valgidzi/hotel.git","clone_url":"https://github.com/valgidzi/hotel.git","svn_url":"https://github.com/valgidzi/hotel","homepage":null,"size":56,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C10:master","ref":"master","sha":"2b3553f21f43de58b3705777750106b44b94a7de","user":{"login":"Ada-C10","id":40303054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/40303054?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C10","html_url":"https://github.com/Ada-C10","followers_url":"https://api.github.com/users/Ada-C10/followers","following_url":"https://api.github.com/users/Ada-C10/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C10/subscriptions","organizations_url":"https://api.github.com/users/Ada-C10/orgs","repos_url":"https://api.github.com/users/Ada-C10/repos","events_url":"https://api.github.com/users/Ada-C10/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C10/received_events","type":"Organization","site_admin":false},"repo":{"id":147387059,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczODcwNTk=","name":"hotel","full_name":"Ada-C10/hotel","owner":{"login":"Ada-C10","id":40303054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/40303054?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C10","html_url":"https://github.com/Ada-C10","followers_url":"https://api.github.com/users/Ada-C10/followers","following_url":"https://api.github.com/users/Ada-C10/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C10/subscriptions","organizations_url":"https://api.github.com/users/Ada-C10/orgs","repos_url":"https://api.github.com/users/Ada-C10/repos","events_url":"https://api.github.com/users/Ada-C10/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C10/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C10/hotel","description":null,"fork":true,"url":"https://api.github.com/repos/Ada-C10/hotel","forks_url":"https://api.github.com/repos/Ada-C10/hotel/forks","keys_url":"https://api.github.com/repos/Ada-C10/hotel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C10/hotel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C10/hotel/teams","hooks_url":"https://api.github.com/repos/Ada-C10/hotel/hooks","issue_events_url":"https://api.github.com/repos/Ada-C10/hotel/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C10/hotel/events","assignees_url":"https://api.github.com/repos/Ada-C10/hotel/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C10/hotel/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C10/hotel/tags","blobs_url":"https://api.github.com/repos/Ada-C10/hotel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C10/hotel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C10/hotel/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C10/hotel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C10/hotel/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C10/hotel/languages","stargazers_url":"https://api.github.com/repos/Ada-C10/hotel/stargazers","contributors_url":"https://api.github.com/repos/Ada-C10/hotel/contributors","subscribers_url":"https://api.github.com/repos/Ada-C10/hotel/subscribers","subscription_url":"https://api.github.com/repos/Ada-C10/hotel/subscription","commits_url":"https://api.github.com/repos/Ada-C10/hotel/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C10/hotel/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C10/hotel/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C10/hotel/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C10/hotel/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C10/hotel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C10/hotel/merges","archive_url":"https://api.github.com/repos/Ada-C10/hotel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C10/hotel/downloads","issues_url":"https://api.github.com/repos/Ada-C10/hotel/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C10/hotel/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C10/hotel/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C10/hotel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C10/hotel/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C10/hotel/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C10/hotel/deployments","created_at":"2018-09-04T18:01:42Z","updated_at":"2018-09-04T18:01:44Z","pushed_at":"2018-09-10T15:50:48Z","git_url":"git://github.com/Ada-C10/hotel.git","ssh_url":"git@github.com:Ada-C10/hotel.git","clone_url":"https://github.com/Ada-C10/hotel.git","svn_url":"https://github.com/Ada-C10/hotel","homepage":null,"size":35,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":36,"license":null,"forks":46,"open_issues":36,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C10/hotel/pulls/36"},"html":{"href":"https://github.com/Ada-C10/hotel/pull/36"},"issue":{"href":"https://api.github.com/repos/Ada-C10/hotel/issues/36"},"comments":{"href":"https://api.github.com/repos/Ada-C10/hotel/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C10/hotel/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C10/hotel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C10/hotel/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C10/hotel/statuses/104690cdc6539ef1f83373c9789e3da24a556f19"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":42,"additions":629,"deletions":1,"changed_files":12}}
{"actor":{"display_login":"valgidzi"}}