{"action":"created","issue":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1630","repository_url":"https://api.github.com/repos/KratosMultiphysics/Kratos","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1630/labels{/name}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1630/comments","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1630/events","html_url":"https://github.com/KratosMultiphysics/Kratos/issues/1630","id":303514474,"number":1630,"title":"Calculation of reaction in FluidDynamicsApplication","user":{"login":"adityaghantasala","id":2531316,"avatar_url":"https://avatars1.githubusercontent.com/u/2531316?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaghantasala","html_url":"https://github.com/adityaghantasala","followers_url":"https://api.github.com/users/adityaghantasala/followers","following_url":"https://api.github.com/users/adityaghantasala/following{/other_user}","gists_url":"https://api.github.com/users/adityaghantasala/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaghantasala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaghantasala/subscriptions","organizations_url":"https://api.github.com/users/adityaghantasala/orgs","repos_url":"https://api.github.com/users/adityaghantasala/repos","events_url":"https://api.github.com/users/adityaghantasala/events{/privacy}","received_events_url":"https://api.github.com/users/adityaghantasala/received_events","type":"User","site_admin":false},"labels":[{"id":539268248,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/applications","name":"applications","color":"d4c5f9","default":false},{"id":538395922,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true},{"id":538395924,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":{"login":"jcotela","id":5071546,"avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false},"assignees":[{"login":"jcotela","id":5071546,"avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false},{"login":"RiccardoRossi","id":8059665,"avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-03-08T15:11:40Z","updated_at":"2018-03-09T10:53:51Z","closed_at":null,"author_association":"MEMBER","body":"Hello all \r\n\r\nUsually the reactions for a given problem are calculated in the CalculateReactions function of the Builder and Solver. This function is called in the `SolveSolutionStep`  of the `residualbased_newton_raphson_strategy` . \r\n\r\nThen we (me and @navaneethkn ) observed something in the code of `residualbase_predictorcorrector_velocity_bossak_scheme_turbulent.h`  \r\nused for FluidDynamics. \r\nThe reactions are calculated and update over all of the domain in the `FinalizeSolutionStep` of this scheme. \r\n\r\nDoes this mean the reactions are doubled always ? \r\n\r\nAlso the function  `FinalizeSolutionStep`  of this scheme does calculate the whole system again (which can be expensive). Can `Calculate_RHS_Contribution` used here (that is if it is necessary to update reactions here) ??"},"comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments/371780563","html_url":"https://github.com/KratosMultiphysics/Kratos/issues/1630#issuecomment-371780563","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/1630","id":371780563,"user":{"login":"jcotela","id":5071546,"avatar_url":"https://avatars3.githubusercontent.com/u/5071546?v=4","gravatar_id":"","url":"https://api.github.com/users/jcotela","html_url":"https://github.com/jcotela","followers_url":"https://api.github.com/users/jcotela/followers","following_url":"https://api.github.com/users/jcotela/following{/other_user}","gists_url":"https://api.github.com/users/jcotela/gists{/gist_id}","starred_url":"https://api.github.com/users/jcotela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcotela/subscriptions","organizations_url":"https://api.github.com/users/jcotela/orgs","repos_url":"https://api.github.com/users/jcotela/repos","events_url":"https://api.github.com/users/jcotela/events{/privacy}","received_events_url":"https://api.github.com/users/jcotela/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T10:53:51Z","updated_at":"2018-03-09T10:53:51Z","author_association":"MEMBER","body":"OK it seems we all agree that having the builder and solver compute the reactions everywhere would be a good idea. Shall we do it only for the block one for now, or should all builder and solvers work like this?"}}
{"actor":{"display_login":"jcotela"}}