{"action":"created","issue":{"url":"https://api.github.com/repos/spritsail/plex-media-server/issues/6","repository_url":"https://api.github.com/repos/spritsail/plex-media-server","labels_url":"https://api.github.com/repos/spritsail/plex-media-server/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/spritsail/plex-media-server/issues/6/comments","events_url":"https://api.github.com/repos/spritsail/plex-media-server/issues/6/events","html_url":"https://github.com/spritsail/plex-media-server/pull/6","id":383138646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjc5ODEx","number":6,"title":"Added log environment variables and made executable files restricted to SUID user","user":{"login":"qdm12","id":15654980,"node_id":"MDQ6VXNlcjE1NjU0OTgw","avatar_url":"https://avatars1.githubusercontent.com/u/15654980?v=4","gravatar_id":"","url":"https://api.github.com/users/qdm12","html_url":"https://github.com/qdm12","followers_url":"https://api.github.com/users/qdm12/followers","following_url":"https://api.github.com/users/qdm12/following{/other_user}","gists_url":"https://api.github.com/users/qdm12/gists{/gist_id}","starred_url":"https://api.github.com/users/qdm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qdm12/subscriptions","organizations_url":"https://api.github.com/users/qdm12/orgs","repos_url":"https://api.github.com/users/qdm12/repos","events_url":"https://api.github.com/users/qdm12/events{/privacy}","received_events_url":"https://api.github.com/users/qdm12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-21T14:18:34Z","updated_at":"2018-11-22T11:52:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/spritsail/plex-media-server/pulls/6","html_url":"https://github.com/spritsail/plex-media-server/pull/6","diff_url":"https://github.com/spritsail/plex-media-server/pull/6.diff","patch_url":"https://github.com/spritsail/plex-media-server/pull/6.patch"},"body":"- Added `LOGVERBOSE` and `LOGDEBUG` environment variables\r\n- `/output/usr/local/bin/*` files are only readable and executable by their owner\r\n- `/output/usr/local/bin/*` files are owned by $SUID at launch (entrypoint) as $SUID is user-defined"},"comment":{"url":"https://api.github.com/repos/spritsail/plex-media-server/issues/comments/441006898","html_url":"https://github.com/spritsail/plex-media-server/pull/6#issuecomment-441006898","issue_url":"https://api.github.com/repos/spritsail/plex-media-server/issues/6","id":441006898,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTAwNjg5OA==","user":{"login":"qdm12","id":15654980,"node_id":"MDQ6VXNlcjE1NjU0OTgw","avatar_url":"https://avatars1.githubusercontent.com/u/15654980?v=4","gravatar_id":"","url":"https://api.github.com/users/qdm12","html_url":"https://github.com/qdm12","followers_url":"https://api.github.com/users/qdm12/followers","following_url":"https://api.github.com/users/qdm12/following{/other_user}","gists_url":"https://api.github.com/users/qdm12/gists{/gist_id}","starred_url":"https://api.github.com/users/qdm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qdm12/subscriptions","organizations_url":"https://api.github.com/users/qdm12/orgs","repos_url":"https://api.github.com/users/qdm12/repos","events_url":"https://api.github.com/users/qdm12/events{/privacy}","received_events_url":"https://api.github.com/users/qdm12/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T11:52:38Z","updated_at":"2018-11-22T11:52:38Z","author_association":"NONE","body":"> Can I ask why you changed the permission of the executable files?\r\n\r\nThe executable files were `755` and owned by root I believe:\r\n- Writable, readable and executable as root (pointless as root can change them anyway)\r\n- Readable and executable as group root\r\n- Readable and executable as all other users (that's what was used with SUID)\r\n\r\nI think it should be restricted to SUID only and be only readable and executable (`500`).\r\n\r\n> It's useful for the scripts to be executable by anyone, and not really a risk to do so, for the case of debugging.\r\n\r\nIt the user wants to modify executables, he can `docker exec -it --user=\"root\" plex /bin/sh` or run the container as root.\r\n\r\n> Was it to ensure the config file gets written as the correct user? If so we should handle that by attempting to chown the file after creation.\r\n\r\nAt each docker run / start, the user provided SUID may change so `chown` has to be in the entrypoint, not in the Dockerfile.\r\n"}}
{"actor":{"display_login":"qdm12"}}