{"action":"closed","issue":{"url":"https://api.github.com/repos/brave/brave-browser/issues/1416","repository_url":"https://api.github.com/repos/brave/brave-browser","labels_url":"https://api.github.com/repos/brave/brave-browser/issues/1416/labels{/name}","comments_url":"https://api.github.com/repos/brave/brave-browser/issues/1416/comments","events_url":"https://api.github.com/repos/brave/brave-browser/issues/1416/events","html_url":"https://github.com/brave/brave-browser/issues/1416","id":366553456,"node_id":"MDU6SXNzdWUzNjY1NTM0NTY=","number":1416,"title":"brave_template_url_prepopulate_data_unittest.cc causes unit test build to fail","user":{"login":"mkarolin","id":41635752,"node_id":"MDQ6VXNlcjQxNjM1NzUy","avatar_url":"https://avatars0.githubusercontent.com/u/41635752?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarolin","html_url":"https://github.com/mkarolin","followers_url":"https://api.github.com/users/mkarolin/followers","following_url":"https://api.github.com/users/mkarolin/following{/other_user}","gists_url":"https://api.github.com/users/mkarolin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarolin/subscriptions","organizations_url":"https://api.github.com/users/mkarolin/orgs","repos_url":"https://api.github.com/users/mkarolin/repos","events_url":"https://api.github.com/users/mkarolin/events{/privacy}","received_events_url":"https://api.github.com/users/mkarolin/received_events","type":"User","site_admin":false},"labels":[{"id":867267559,"node_id":"MDU6TGFiZWw4NjcyNjc1NTk=","url":"https://api.github.com/repos/brave/brave-browser/labels/tests","name":"tests","color":"a1a4b2","default":false}],"state":"closed","locked":false,"assignee":{"login":"mkarolin","id":41635752,"node_id":"MDQ6VXNlcjQxNjM1NzUy","avatar_url":"https://avatars0.githubusercontent.com/u/41635752?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarolin","html_url":"https://github.com/mkarolin","followers_url":"https://api.github.com/users/mkarolin/followers","following_url":"https://api.github.com/users/mkarolin/following{/other_user}","gists_url":"https://api.github.com/users/mkarolin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarolin/subscriptions","organizations_url":"https://api.github.com/users/mkarolin/orgs","repos_url":"https://api.github.com/users/mkarolin/repos","events_url":"https://api.github.com/users/mkarolin/events{/privacy}","received_events_url":"https://api.github.com/users/mkarolin/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkarolin","id":41635752,"node_id":"MDQ6VXNlcjQxNjM1NzUy","avatar_url":"https://avatars0.githubusercontent.com/u/41635752?v=4","gravatar_id":"","url":"https://api.github.com/users/mkarolin","html_url":"https://github.com/mkarolin","followers_url":"https://api.github.com/users/mkarolin/followers","following_url":"https://api.github.com/users/mkarolin/following{/other_user}","gists_url":"https://api.github.com/users/mkarolin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkarolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkarolin/subscriptions","organizations_url":"https://api.github.com/users/mkarolin/orgs","repos_url":"https://api.github.com/users/mkarolin/repos","events_url":"https://api.github.com/users/mkarolin/events{/privacy}","received_events_url":"https://api.github.com/users/mkarolin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-03T22:24:46Z","updated_at":"2018-10-03T23:06:30Z","closed_at":"2018-10-03T23:06:30Z","author_association":"CONTRIBUTOR","body":"## Description \r\n`../../brave/chromium_src/components/search_engines/brave_template_url_prepopulate_data_unittest.cc(38,7):  error: reference to 'PrepopulatedEngine' is ambiguous\r\nconst PrepopulatedEngine* const kBraveAddedEngines[] = {\r\n      ^\r\n../..\\brave/components/search_engines/brave_prepopulated_engines.h(12,8):  note: candidate found by name lookup is 'PrepopulatedEngine'\r\nstruct PrepopulatedEngine;\r\n       ^\r\n../..\\components/search_engines/template_url_data_util.h(15,8):  note: candidate found by name lookup is 'TemplateURLPrepopulateData::PrepopulatedEngine'\r\nstruct PrepopulatedEngine;\r\n       ^\r\n../../brave/chromium_src/components/search_engines/brave_template_url_prepopulate_data_unittest.cc(39,5):  error: cannot initialize an array element of type 'const PrepopulatedEngine *const' with an rvalue of type 'const TemplateURLPrepopulateData::PrepopulatedEngine *'\r\n    &amazon,          &duckduckgo,    &ecosia,    &findx,\r\n    ^~~~~~~\r\n`\r\n\r\n## Steps to Reproduce\r\n<!--Please add a series of steps to reproduce the issue-->\r\n\r\n   1. npm run test -- brave_unit_tests Debug --filter=BraveTemplateURLPrepopulateDataTest.*\r\n\r\n\r\n"}}
{"actor":{"display_login":"mkarolin"}}