{"action":"created","issue":{"url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/1025","repository_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey","labels_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/1025/labels{/name}","comments_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/1025/comments","events_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/1025/events","html_url":"https://github.com/LimeSurvey/LimeSurvey/pull/1025","id":308466402,"number":1025,"title":"Usage of Expression in theme [All done]","user":{"login":"Shnoulle","id":1439428,"avatar_url":"https://avatars2.githubusercontent.com/u/1439428?v=4","gravatar_id":"","url":"https://api.github.com/users/Shnoulle","html_url":"https://github.com/Shnoulle","followers_url":"https://api.github.com/users/Shnoulle/followers","following_url":"https://api.github.com/users/Shnoulle/following{/other_user}","gists_url":"https://api.github.com/users/Shnoulle/gists{/gist_id}","starred_url":"https://api.github.com/users/Shnoulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shnoulle/subscriptions","organizations_url":"https://api.github.com/users/Shnoulle/orgs","repos_url":"https://api.github.com/users/Shnoulle/repos","events_url":"https://api.github.com/users/Shnoulle/events{/privacy}","received_events_url":"https://api.github.com/users/Shnoulle/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-03-26T07:52:43Z","updated_at":"2018-03-29T14:46:34Z","closed_at":"2018-03-29T12:59:47Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/1025","html_url":"https://github.com/LimeSurvey/LimeSurvey/pull/1025","diff_url":"https://github.com/LimeSurvey/LimeSurvey/pull/1025.diff","patch_url":"https://github.com/LimeSurvey/LimeSurvey/pull/1025.patch"},"body":"Fixed issue #13533 : Unable to use Expression Manager inside template \r\nFixed issue #13529 : Survey/Group text with exppression are not updated via javascript\r\n\r\nThis leave choice for Theme developper, currently seems group descriptin must be added but can remove Survey title : less used.\r\n\r\nTheme developer can use Expression like this `{{ processString(Expresssion) }}` expression can come from existing object \r\nexemples \r\n\r\n- `processString(aSurveyInfo.surveyls_title)` \r\n- `processString('{strip_tags(TOKEN:ATTRIBUTE_1)}')`\r\n\r\nPurpose is to replace existing system and workaround already existing in template.\r\n\r\n\r\n- [x] Move function to EM\r\n- [x] Test group by group\r\n- [x] Test question by question\r\n- [x] Test all in one\r\n- [x] Test other page (save, clearall)"},"comment":{"url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/comments/377259010","html_url":"https://github.com/LimeSurvey/LimeSurvey/pull/1025#issuecomment-377259010","issue_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/1025","id":377259010,"user":{"login":"tpartner","id":1437729,"avatar_url":"https://avatars1.githubusercontent.com/u/1437729?v=4","gravatar_id":"","url":"https://api.github.com/users/tpartner","html_url":"https://github.com/tpartner","followers_url":"https://api.github.com/users/tpartner/followers","following_url":"https://api.github.com/users/tpartner/following{/other_user}","gists_url":"https://api.github.com/users/tpartner/gists{/gist_id}","starred_url":"https://api.github.com/users/tpartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpartner/subscriptions","organizations_url":"https://api.github.com/users/tpartner/orgs","repos_url":"https://api.github.com/users/tpartner/repos","events_url":"https://api.github.com/users/tpartner/events{/privacy}","received_events_url":"https://api.github.com/users/tpartner/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T14:46:34Z","updated_at":"2018-03-29T14:46:34Z","author_association":"COLLABORATOR","body":"1. Yes, in some cases we can cheat by processing the twig vars, but doesn't that defeat the purpose of \"Usage of Expression in theme\"?\r\n\r\n2. Don' know\r\n\r\n3. I think if we provide some EM vars, we should provide all of them (that are available in the group/question text or old pstpl files.\r\n\r\nHere's a better illustration:\r\n\r\n![capture-4](https://user-images.githubusercontent.com/1437729/38095415-704e1dc8-333e-11e8-9eba-80a6538dfc31.png)\r\n"}}
{"actor":{"display_login":"tpartner"}}