{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/169197731","pull_request_review_id":97685274,"id":169197731,"diff_hunk":"@@ -119,8 +119,8 @@ int process_request(RGWRados* const store,\n                     int* http_ret)\n {\n   int ret = 0;\n-\n-  client_io->init(g_ceph_context);\n+  int cio_error = 0;\n+  cio_error = client_io->init(g_ceph_context);","path":"src/rgw/rgw_process.cc","position":7,"original_position":7,"commit_id":"06b5db7dc56785ad591ab0d34578bfb06253c85c","original_commit_id":"09e277f4d8cb8c8cb7932fc83b26438f8406a062","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2018-02-20T01:01:46Z","updated_at":"2018-02-20T01:01:46Z","html_url":"https://github.com/ceph/ceph/pull/20488#discussion_r169197731","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/20488","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/169197731"},"html":{"href":"https://github.com/ceph/ceph/pull/20488#discussion_r169197731"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20488"}},"in_reply_to_id":169193583},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/20488","id":170005463,"html_url":"https://github.com/ceph/ceph/pull/20488","diff_url":"https://github.com/ceph/ceph/pull/20488.diff","patch_url":"https://github.com/ceph/ceph/pull/20488.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/20488","number":20488,"state":"open","locked":false,"title":"rgw:  make init env methods return an error","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"body":"Since web frontends may signal an error when requests are malformed or so, let\r\nus double check this and raise errors early. The current user of this is\r\ncivetweb frontend; which can potentially return null from `parse_http_headers`\r\nwhen a HTTP header without a \":\" is supplied at which point headers.value is\r\nnull which can lead to undefined behaviour later in RGW.\r\n\r\nFixes: http://tracker.ceph.com/issues/23039\r\nSigned-off-by: Abhishek Lekshmanan <abhishek@suse.com>","created_at":"2018-02-19T16:31:12Z","updated_at":"2018-02-20T01:01:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e27e8869371bc2fb8294ec0e17c33581d4bcc71c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mattbenjamin","id":301287,"avatar_url":"https://avatars2.githubusercontent.com/u/301287?v=4","gravatar_id":"","url":"https://api.github.com/users/mattbenjamin","html_url":"https://github.com/mattbenjamin","followers_url":"https://api.github.com/users/mattbenjamin/followers","following_url":"https://api.github.com/users/mattbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/mattbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/mattbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattbenjamin/subscriptions","organizations_url":"https://api.github.com/users/mattbenjamin/orgs","repos_url":"https://api.github.com/users/mattbenjamin/repos","events_url":"https://api.github.com/users/mattbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/mattbenjamin/received_events","type":"User","site_admin":false},{"login":"cbodley","id":1928002,"avatar_url":"https://avatars2.githubusercontent.com/u/1928002?v=4","gravatar_id":"","url":"https://api.github.com/users/cbodley","html_url":"https://github.com/cbodley","followers_url":"https://api.github.com/users/cbodley/followers","following_url":"https://api.github.com/users/cbodley/following{/other_user}","gists_url":"https://api.github.com/users/cbodley/gists{/gist_id}","starred_url":"https://api.github.com/users/cbodley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbodley/subscriptions","organizations_url":"https://api.github.com/users/cbodley/orgs","repos_url":"https://api.github.com/users/cbodley/repos","events_url":"https://api.github.com/users/cbodley/events{/privacy}","received_events_url":"https://api.github.com/users/cbodley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":134774049,"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329618,"url":"https://api.github.com/repos/ceph/ceph/labels/rgw","name":"rgw","color":"00ffe4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/20488/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/20488/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/20488/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/06b5db7dc56785ad591ab0d34578bfb06253c85c","head":{"label":"theanalyst:rgw/frontend-init","ref":"rgw/frontend-init","sha":"06b5db7dc56785ad591ab0d34578bfb06253c85c","user":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"repo":{"id":21639729,"name":"ceph","full_name":"theanalyst/ceph","owner":{"login":"theanalyst","id":1433152,"avatar_url":"https://avatars0.githubusercontent.com/u/1433152?v=4","gravatar_id":"","url":"https://api.github.com/users/theanalyst","html_url":"https://github.com/theanalyst","followers_url":"https://api.github.com/users/theanalyst/followers","following_url":"https://api.github.com/users/theanalyst/following{/other_user}","gists_url":"https://api.github.com/users/theanalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/theanalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theanalyst/subscriptions","organizations_url":"https://api.github.com/users/theanalyst/orgs","repos_url":"https://api.github.com/users/theanalyst/repos","events_url":"https://api.github.com/users/theanalyst/events{/privacy}","received_events_url":"https://api.github.com/users/theanalyst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theanalyst/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/theanalyst/ceph","forks_url":"https://api.github.com/repos/theanalyst/ceph/forks","keys_url":"https://api.github.com/repos/theanalyst/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theanalyst/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theanalyst/ceph/teams","hooks_url":"https://api.github.com/repos/theanalyst/ceph/hooks","issue_events_url":"https://api.github.com/repos/theanalyst/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/theanalyst/ceph/events","assignees_url":"https://api.github.com/repos/theanalyst/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/theanalyst/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/theanalyst/ceph/tags","blobs_url":"https://api.github.com/repos/theanalyst/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theanalyst/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theanalyst/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/theanalyst/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theanalyst/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/theanalyst/ceph/languages","stargazers_url":"https://api.github.com/repos/theanalyst/ceph/stargazers","contributors_url":"https://api.github.com/repos/theanalyst/ceph/contributors","subscribers_url":"https://api.github.com/repos/theanalyst/ceph/subscribers","subscription_url":"https://api.github.com/repos/theanalyst/ceph/subscription","commits_url":"https://api.github.com/repos/theanalyst/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/theanalyst/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/theanalyst/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/theanalyst/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/theanalyst/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/theanalyst/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theanalyst/ceph/merges","archive_url":"https://api.github.com/repos/theanalyst/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theanalyst/ceph/downloads","issues_url":"https://api.github.com/repos/theanalyst/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/theanalyst/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/theanalyst/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/theanalyst/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theanalyst/ceph/labels{/name}","releases_url":"https://api.github.com/repos/theanalyst/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/theanalyst/ceph/deployments","created_at":"2014-07-09T04:45:38Z","updated_at":"2016-01-19T13:53:44Z","pushed_at":"2018-02-20T00:27:59Z","git_url":"git://github.com/theanalyst/ceph.git","ssh_url":"git@github.com:theanalyst/ceph.git","clone_url":"https://github.com/theanalyst/ceph.git","svn_url":"https://github.com/theanalyst/ceph","homepage":"http://ceph.com","size":263419,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"379897e89410f03ba5c848ad315d11af1ef5f428","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-02-19T22:43:37Z","pushed_at":"2018-02-20T00:28:02Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":268590,"stargazers_count":4129,"watchers_count":4129,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2318,"mirror_url":null,"archived":false,"open_issues_count":633,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2318,"open_issues":633,"watchers":4129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20488"},"html":{"href":"https://github.com/ceph/ceph/pull/20488"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/20488"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/20488/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20488/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20488/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/06b5db7dc56785ad591ab0d34578bfb06253c85c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"theanalyst"}}