{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/223193734","pull_request_review_id":162270076,"id":223193734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE5MzczNA==","diff_hunk":"@@ -102,11 +105,12 @@ func init() {\n // DiscoveryResponse models a JSON response from the Triton discovery.\n type DiscoveryResponse struct {\n \tContainers []struct {\n-\t\tServerUUID  string `json:\"server_uuid\"`\n-\t\tVMAlias     string `json:\"vm_alias\"`\n-\t\tVMBrand     string `json:\"vm_brand\"`\n-\t\tVMImageUUID string `json:\"vm_image_uuid\"`\n-\t\tVMUUID      string `json:\"vm_uuid\"`\n+\t\tGroups      []string `json:\"groups:`","path":"discovery/triton/triton.go","position":null,"original_position":33,"commit_id":"5468c90e509705895fccd4bb50299b54493c568f","original_commit_id":"d650048d22fbfd62195580226d9fd84b5c957e40","user":{"login":"richardkiene","id":656216,"node_id":"MDQ6VXNlcjY1NjIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/656216?v=4","gravatar_id":"","url":"https://api.github.com/users/richardkiene","html_url":"https://github.com/richardkiene","followers_url":"https://api.github.com/users/richardkiene/followers","following_url":"https://api.github.com/users/richardkiene/following{/other_user}","gists_url":"https://api.github.com/users/richardkiene/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkiene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkiene/subscriptions","organizations_url":"https://api.github.com/users/richardkiene/orgs","repos_url":"https://api.github.com/users/richardkiene/repos","events_url":"https://api.github.com/users/richardkiene/events{/privacy}","received_events_url":"https://api.github.com/users/richardkiene/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2018-10-06T21:02:36Z","updated_at":"2018-10-06T21:02:36Z","html_url":"https://github.com/prometheus/prometheus/pull/4701#discussion_r223193734","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4701","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/223193734"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4701#discussion_r223193734"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4701"}},"in_reply_to_id":223192616},"pull_request":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/4701","id":220813870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODEzODcw","html_url":"https://github.com/prometheus/prometheus/pull/4701","diff_url":"https://github.com/prometheus/prometheus/pull/4701.diff","patch_url":"https://github.com/prometheus/prometheus/pull/4701.patch","issue_url":"https://api.github.com/repos/prometheus/prometheus/issues/4701","number":4701,"state":"open","locked":false,"title":"Add ability to filter triton_sd targets by pre-defined groups","user":{"login":"richardkiene","id":656216,"node_id":"MDQ6VXNlcjY1NjIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/656216?v=4","gravatar_id":"","url":"https://api.github.com/users/richardkiene","html_url":"https://github.com/richardkiene","followers_url":"https://api.github.com/users/richardkiene/followers","following_url":"https://api.github.com/users/richardkiene/following{/other_user}","gists_url":"https://api.github.com/users/richardkiene/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkiene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkiene/subscriptions","organizations_url":"https://api.github.com/users/richardkiene/orgs","repos_url":"https://api.github.com/users/richardkiene/repos","events_url":"https://api.github.com/users/richardkiene/events{/privacy}","received_events_url":"https://api.github.com/users/richardkiene/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Richard Kiene <richard.kiene@joyent.com>\r\n\r\nAs Triton and Manta installs have become substantially larger and customer reliance upon Prometheus has become more important, it has become painfully obvious that filtering is a necessary feature of Triton Service Discovery. This pull request leverages the newly added group filtering support that we've added to [Triton CMON](https://github.com/joyent/triton-cmon).\r\n\r\n//cc: @fabxc @brian-brazil ","created_at":"2018-10-05T20:20:34Z","updated_at":"2018-10-06T21:02:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0cd8ba0c727e3e68d742fc5151f17a1d10f7bad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4701/commits","review_comments_url":"https://api.github.com/repos/prometheus/prometheus/pulls/4701/comments","review_comment_url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/prometheus/issues/4701/comments","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/5468c90e509705895fccd4bb50299b54493c568f","head":{"label":"richardkiene:TRITON-755","ref":"TRITON-755","sha":"5468c90e509705895fccd4bb50299b54493c568f","user":{"login":"richardkiene","id":656216,"node_id":"MDQ6VXNlcjY1NjIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/656216?v=4","gravatar_id":"","url":"https://api.github.com/users/richardkiene","html_url":"https://github.com/richardkiene","followers_url":"https://api.github.com/users/richardkiene/followers","following_url":"https://api.github.com/users/richardkiene/following{/other_user}","gists_url":"https://api.github.com/users/richardkiene/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkiene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkiene/subscriptions","organizations_url":"https://api.github.com/users/richardkiene/orgs","repos_url":"https://api.github.com/users/richardkiene/repos","events_url":"https://api.github.com/users/richardkiene/events{/privacy}","received_events_url":"https://api.github.com/users/richardkiene/received_events","type":"User","site_admin":false},"repo":{"id":100737373,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3MzczNzM=","name":"prometheus","full_name":"richardkiene/prometheus","private":false,"owner":{"login":"richardkiene","id":656216,"node_id":"MDQ6VXNlcjY1NjIxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/656216?v=4","gravatar_id":"","url":"https://api.github.com/users/richardkiene","html_url":"https://github.com/richardkiene","followers_url":"https://api.github.com/users/richardkiene/followers","following_url":"https://api.github.com/users/richardkiene/following{/other_user}","gists_url":"https://api.github.com/users/richardkiene/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkiene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkiene/subscriptions","organizations_url":"https://api.github.com/users/richardkiene/orgs","repos_url":"https://api.github.com/users/richardkiene/repos","events_url":"https://api.github.com/users/richardkiene/events{/privacy}","received_events_url":"https://api.github.com/users/richardkiene/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richardkiene/prometheus","description":"The Prometheus monitoring system and time series database.","fork":true,"url":"https://api.github.com/repos/richardkiene/prometheus","forks_url":"https://api.github.com/repos/richardkiene/prometheus/forks","keys_url":"https://api.github.com/repos/richardkiene/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardkiene/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardkiene/prometheus/teams","hooks_url":"https://api.github.com/repos/richardkiene/prometheus/hooks","issue_events_url":"https://api.github.com/repos/richardkiene/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/richardkiene/prometheus/events","assignees_url":"https://api.github.com/repos/richardkiene/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/richardkiene/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/richardkiene/prometheus/tags","blobs_url":"https://api.github.com/repos/richardkiene/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardkiene/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardkiene/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardkiene/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardkiene/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/richardkiene/prometheus/languages","stargazers_url":"https://api.github.com/repos/richardkiene/prometheus/stargazers","contributors_url":"https://api.github.com/repos/richardkiene/prometheus/contributors","subscribers_url":"https://api.github.com/repos/richardkiene/prometheus/subscribers","subscription_url":"https://api.github.com/repos/richardkiene/prometheus/subscription","commits_url":"https://api.github.com/repos/richardkiene/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardkiene/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardkiene/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardkiene/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardkiene/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/richardkiene/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardkiene/prometheus/merges","archive_url":"https://api.github.com/repos/richardkiene/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardkiene/prometheus/downloads","issues_url":"https://api.github.com/repos/richardkiene/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/richardkiene/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/richardkiene/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/richardkiene/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardkiene/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/richardkiene/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/richardkiene/prometheus/deployments","created_at":"2017-08-18T17:55:27Z","updated_at":"2018-09-27T16:59:48Z","pushed_at":"2018-10-06T20:58:12Z","git_url":"git://github.com/richardkiene/prometheus.git","ssh_url":"git@github.com:richardkiene/prometheus.git","clone_url":"https://github.com/richardkiene/prometheus.git","svn_url":"https://github.com/richardkiene/prometheus","homepage":"https://prometheus.io/","size":41511,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"e1e2821ccabab5955c5af5daafb76a621f431c40","user":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":6838921,"node_id":"MDEwOlJlcG9zaXRvcnk2ODM4OTIx","name":"prometheus","full_name":"prometheus/prometheus","private":false,"owner":{"login":"prometheus","id":3380462,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODA0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/3380462?v=4","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prometheus/prometheus","description":"The Prometheus monitoring system and time series database.","fork":false,"url":"https://api.github.com/repos/prometheus/prometheus","forks_url":"https://api.github.com/repos/prometheus/prometheus/forks","keys_url":"https://api.github.com/repos/prometheus/prometheus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/prometheus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/prometheus/teams","hooks_url":"https://api.github.com/repos/prometheus/prometheus/hooks","issue_events_url":"https://api.github.com/repos/prometheus/prometheus/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/prometheus/events","assignees_url":"https://api.github.com/repos/prometheus/prometheus/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/prometheus/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/prometheus/tags","blobs_url":"https://api.github.com/repos/prometheus/prometheus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/prometheus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/prometheus/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/prometheus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/prometheus/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/prometheus/languages","stargazers_url":"https://api.github.com/repos/prometheus/prometheus/stargazers","contributors_url":"https://api.github.com/repos/prometheus/prometheus/contributors","subscribers_url":"https://api.github.com/repos/prometheus/prometheus/subscribers","subscription_url":"https://api.github.com/repos/prometheus/prometheus/subscription","commits_url":"https://api.github.com/repos/prometheus/prometheus/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/prometheus/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/prometheus/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/prometheus/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/prometheus/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/prometheus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/prometheus/merges","archive_url":"https://api.github.com/repos/prometheus/prometheus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/prometheus/downloads","issues_url":"https://api.github.com/repos/prometheus/prometheus/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/prometheus/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/prometheus/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/prometheus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/prometheus/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/prometheus/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/prometheus/deployments","created_at":"2012-11-24T11:14:12Z","updated_at":"2018-10-06T16:49:07Z","pushed_at":"2018-10-06T20:58:15Z","git_url":"git://github.com/prometheus/prometheus.git","ssh_url":"git@github.com:prometheus/prometheus.git","clone_url":"https://github.com/prometheus/prometheus.git","svn_url":"https://github.com/prometheus/prometheus","homepage":"https://prometheus.io/","size":41739,"stargazers_count":19314,"watchers_count":19314,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2585,"mirror_url":null,"archived":false,"open_issues_count":307,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2585,"open_issues":307,"watchers":19314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4701"},"html":{"href":"https://github.com/prometheus/prometheus/pull/4701"},"issue":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4701"},"comments":{"href":"https://api.github.com/repos/prometheus/prometheus/issues/4701/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4701/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/4701/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/prometheus/statuses/5468c90e509705895fccd4bb50299b54493c568f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"richardkiene"}}