{"action":"created","issue":{"url":"https://api.github.com/repos/theory/pgtap/issues/161","repository_url":"https://api.github.com/repos/theory/pgtap","labels_url":"https://api.github.com/repos/theory/pgtap/issues/161/labels{/name}","comments_url":"https://api.github.com/repos/theory/pgtap/issues/161/comments","events_url":"https://api.github.com/repos/theory/pgtap/issues/161/events","html_url":"https://github.com/theory/pgtap/issues/161","id":308401043,"node_id":"MDU6SXNzdWUzMDg0MDEwNDM=","number":161,"title":"Probable bug in 0.97-0.98 upgrade in PG 10","user":{"login":"decibel","id":235814,"node_id":"MDQ6VXNlcjIzNTgxNA==","avatar_url":"https://avatars1.githubusercontent.com/u/235814?v=4","gravatar_id":"","url":"https://api.github.com/users/decibel","html_url":"https://github.com/decibel","followers_url":"https://api.github.com/users/decibel/followers","following_url":"https://api.github.com/users/decibel/following{/other_user}","gists_url":"https://api.github.com/users/decibel/gists{/gist_id}","starred_url":"https://api.github.com/users/decibel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibel/subscriptions","organizations_url":"https://api.github.com/users/decibel/orgs","repos_url":"https://api.github.com/users/decibel/repos","events_url":"https://api.github.com/users/decibel/events{/privacy}","received_events_url":"https://api.github.com/users/decibel/received_events","type":"User","site_admin":false},"labels":[{"id":24372233,"node_id":"MDU6TGFiZWwyNDM3MjIzMw==","url":"https://api.github.com/repos/theory/pgtap/labels/bug","name":"bug","color":"e10c02","default":true}],"state":"open","locked":false,"assignee":{"login":"theory","id":46604,"node_id":"MDQ6VXNlcjQ2NjA0","avatar_url":"https://avatars3.githubusercontent.com/u/46604?v=4","gravatar_id":"","url":"https://api.github.com/users/theory","html_url":"https://github.com/theory","followers_url":"https://api.github.com/users/theory/followers","following_url":"https://api.github.com/users/theory/following{/other_user}","gists_url":"https://api.github.com/users/theory/gists{/gist_id}","starred_url":"https://api.github.com/users/theory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theory/subscriptions","organizations_url":"https://api.github.com/users/theory/orgs","repos_url":"https://api.github.com/users/theory/repos","events_url":"https://api.github.com/users/theory/events{/privacy}","received_events_url":"https://api.github.com/users/theory/received_events","type":"User","site_admin":false},"assignees":[{"login":"theory","id":46604,"node_id":"MDQ6VXNlcjQ2NjA0","avatar_url":"https://avatars3.githubusercontent.com/u/46604?v=4","gravatar_id":"","url":"https://api.github.com/users/theory","html_url":"https://github.com/theory","followers_url":"https://api.github.com/users/theory/followers","following_url":"https://api.github.com/users/theory/following{/other_user}","gists_url":"https://api.github.com/users/theory/gists{/gist_id}","starred_url":"https://api.github.com/users/theory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theory/subscriptions","organizations_url":"https://api.github.com/users/theory/orgs","repos_url":"https://api.github.com/users/theory/repos","events_url":"https://api.github.com/users/theory/events{/privacy}","received_events_url":"https://api.github.com/users/theory/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-03-26T00:26:57Z","updated_at":"2018-06-23T22:30:35Z","closed_at":null,"author_association":"COLLABORATOR","body":"As part of #156, I'm getting the following error while running my upgrade tests (`make clean updatecheck` in branch https://github.com/decibel/pgtap/tree/test_upgrade). I'm pretty sure this is a legitimate error and not some artifact of my tests. I suspect the solution is to move the partition-related table_owner checks into `tests/sql/partitions.sql`. Actually, I'm surprised that any of the partition checks in `tests/sql/ownership.sql` work in < 10.0 (`git grep 'part, user, desc'` shows a bunch more than just the two that failed).\r\n\r\nI can move the tests over if that's indeed the correct solution.\r\n\r\n```\r\n! not ok 118 - table_owner_is(part, user, desc) should pass\r\n! # Failed test 118: \"table_owner_is(part, user, desc) should pass\"\r\n! #         have: false\r\n! #         want: true\r\n  ok 119 - table_owner_is(part, user, desc) should have the proper description\r\n! not ok 120 - table_owner_is(part, user, desc) should have the proper diagnostics\r\n! # Failed test 120: \"table_owner_is(part, user, desc) should have the proper diagnostics\"\r\n! #         have:      Table apart does not exist\r\n! #         want: \r\n```"},"comment":{"url":"https://api.github.com/repos/theory/pgtap/issues/comments/399714734","html_url":"https://github.com/theory/pgtap/issues/161#issuecomment-399714734","issue_url":"https://api.github.com/repos/theory/pgtap/issues/161","id":399714734,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTcxNDczNA==","user":{"login":"decibel","id":235814,"node_id":"MDQ6VXNlcjIzNTgxNA==","avatar_url":"https://avatars1.githubusercontent.com/u/235814?v=4","gravatar_id":"","url":"https://api.github.com/users/decibel","html_url":"https://github.com/decibel","followers_url":"https://api.github.com/users/decibel/followers","following_url":"https://api.github.com/users/decibel/following{/other_user}","gists_url":"https://api.github.com/users/decibel/gists{/gist_id}","starred_url":"https://api.github.com/users/decibel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decibel/subscriptions","organizations_url":"https://api.github.com/users/decibel/orgs","repos_url":"https://api.github.com/users/decibel/repos","events_url":"https://api.github.com/users/decibel/events{/privacy}","received_events_url":"https://api.github.com/users/decibel/received_events","type":"User","site_admin":false},"created_at":"2018-06-23T22:30:35Z","updated_at":"2018-06-23T22:30:35Z","author_association":"COLLABORATOR","body":"I found the bug. If you upgrade, table_owner_is(name,name,text) has this line:\r\n\r\n`owner NAME := _get_rel_owner('r'::char, $1);`\r\n\r\nif you do a base install, you get...\r\n\r\n`owner NAME := _get_rel_owner('{r,p}'::char[], $1);`"}}
{"actor":{"display_login":"decibel"}}