{"action":"opened","number":1233,"pull_request":{"url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1233","id":187593991,"html_url":"https://github.com/bigcommerce/cornerstone/pull/1233","diff_url":"https://github.com/bigcommerce/cornerstone/pull/1233.diff","patch_url":"https://github.com/bigcommerce/cornerstone/pull/1233.patch","issue_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1233","number":1233,"state":"open","locked":false,"title":"Do not Merge Yet:  fix(storefront): STRF-2456 Fixing Schema Org meta tags","user":{"login":"davidwrpayne","id":4246575,"avatar_url":"https://avatars0.githubusercontent.com/u/4246575?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwrpayne","html_url":"https://github.com/davidwrpayne","followers_url":"https://api.github.com/users/davidwrpayne/followers","following_url":"https://api.github.com/users/davidwrpayne/following{/other_user}","gists_url":"https://api.github.com/users/davidwrpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwrpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwrpayne/subscriptions","organizations_url":"https://api.github.com/users/davidwrpayne/orgs","repos_url":"https://api.github.com/users/davidwrpayne/repos","events_url":"https://api.github.com/users/davidwrpayne/events{/privacy}","received_events_url":"https://api.github.com/users/davidwrpayne/received_events","type":"User","site_admin":false},"body":":warning: not quite ready for review\r\n#### What?\r\n\r\nWe are adding schema.org offer tags on div's that schema.org doesn't care about what price was\r\nit only cares about what price currently is afaict  I need to validate still that price-range schema works.\r\n\r\n- [x] Test case about simple product\r\n- [x] Test case about complex product\r\n- [ ] Test case about pricelist enabled product\r\n- [ ] Test case about Product with varying Tax inclusion settings.\r\n\r\n#### Tickets / Documentation\r\n\r\n- [STRF-2456](https://jira.bigcommerce.com/browse/STRF-2456)\r\n\r\n#### Screenshots\r\n\r\nFixed product schema with \"was\" and \"currently\" prices\r\n![screen shot 2018-05-11 at 5 10 11 pm](https://user-images.githubusercontent.com/4246575/39951393-47aed46c-553e-11e8-97f8-fb8ee5a37a05.png)\r\n\r\n","created_at":"2018-05-12T00:13:30Z","updated_at":"2018-05-12T00:13:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1233/commits","review_comments_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1233/comments","review_comment_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1233/comments","statuses_url":"https://api.github.com/repos/bigcommerce/cornerstone/statuses/c153b8904c5340acfb2cbb612fece3afc080889c","head":{"label":"davidwrpayne:STRF-2456","ref":"STRF-2456","sha":"c153b8904c5340acfb2cbb612fece3afc080889c","user":{"login":"davidwrpayne","id":4246575,"avatar_url":"https://avatars0.githubusercontent.com/u/4246575?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwrpayne","html_url":"https://github.com/davidwrpayne","followers_url":"https://api.github.com/users/davidwrpayne/followers","following_url":"https://api.github.com/users/davidwrpayne/following{/other_user}","gists_url":"https://api.github.com/users/davidwrpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwrpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwrpayne/subscriptions","organizations_url":"https://api.github.com/users/davidwrpayne/orgs","repos_url":"https://api.github.com/users/davidwrpayne/repos","events_url":"https://api.github.com/users/davidwrpayne/events{/privacy}","received_events_url":"https://api.github.com/users/davidwrpayne/received_events","type":"User","site_admin":false},"repo":{"id":133099557,"name":"cornerstone","full_name":"davidwrpayne/cornerstone","owner":{"login":"davidwrpayne","id":4246575,"avatar_url":"https://avatars0.githubusercontent.com/u/4246575?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwrpayne","html_url":"https://github.com/davidwrpayne","followers_url":"https://api.github.com/users/davidwrpayne/followers","following_url":"https://api.github.com/users/davidwrpayne/following{/other_user}","gists_url":"https://api.github.com/users/davidwrpayne/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwrpayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwrpayne/subscriptions","organizations_url":"https://api.github.com/users/davidwrpayne/orgs","repos_url":"https://api.github.com/users/davidwrpayne/repos","events_url":"https://api.github.com/users/davidwrpayne/events{/privacy}","received_events_url":"https://api.github.com/users/davidwrpayne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidwrpayne/cornerstone","description":"The BigCommerce Cornerstone theme","fork":true,"url":"https://api.github.com/repos/davidwrpayne/cornerstone","forks_url":"https://api.github.com/repos/davidwrpayne/cornerstone/forks","keys_url":"https://api.github.com/repos/davidwrpayne/cornerstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidwrpayne/cornerstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidwrpayne/cornerstone/teams","hooks_url":"https://api.github.com/repos/davidwrpayne/cornerstone/hooks","issue_events_url":"https://api.github.com/repos/davidwrpayne/cornerstone/issues/events{/number}","events_url":"https://api.github.com/repos/davidwrpayne/cornerstone/events","assignees_url":"https://api.github.com/repos/davidwrpayne/cornerstone/assignees{/user}","branches_url":"https://api.github.com/repos/davidwrpayne/cornerstone/branches{/branch}","tags_url":"https://api.github.com/repos/davidwrpayne/cornerstone/tags","blobs_url":"https://api.github.com/repos/davidwrpayne/cornerstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidwrpayne/cornerstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidwrpayne/cornerstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidwrpayne/cornerstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidwrpayne/cornerstone/statuses/{sha}","languages_url":"https://api.github.com/repos/davidwrpayne/cornerstone/languages","stargazers_url":"https://api.github.com/repos/davidwrpayne/cornerstone/stargazers","contributors_url":"https://api.github.com/repos/davidwrpayne/cornerstone/contributors","subscribers_url":"https://api.github.com/repos/davidwrpayne/cornerstone/subscribers","subscription_url":"https://api.github.com/repos/davidwrpayne/cornerstone/subscription","commits_url":"https://api.github.com/repos/davidwrpayne/cornerstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidwrpayne/cornerstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidwrpayne/cornerstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidwrpayne/cornerstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidwrpayne/cornerstone/contents/{+path}","compare_url":"https://api.github.com/repos/davidwrpayne/cornerstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidwrpayne/cornerstone/merges","archive_url":"https://api.github.com/repos/davidwrpayne/cornerstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidwrpayne/cornerstone/downloads","issues_url":"https://api.github.com/repos/davidwrpayne/cornerstone/issues{/number}","pulls_url":"https://api.github.com/repos/davidwrpayne/cornerstone/pulls{/number}","milestones_url":"https://api.github.com/repos/davidwrpayne/cornerstone/milestones{/number}","notifications_url":"https://api.github.com/repos/davidwrpayne/cornerstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidwrpayne/cornerstone/labels{/name}","releases_url":"https://api.github.com/repos/davidwrpayne/cornerstone/releases{/id}","deployments_url":"https://api.github.com/repos/davidwrpayne/cornerstone/deployments","created_at":"2018-05-12T00:05:04Z","updated_at":"2018-05-12T00:05:07Z","pushed_at":"2018-05-12T00:05:38Z","git_url":"git://github.com/davidwrpayne/cornerstone.git","ssh_url":"git@github.com:davidwrpayne/cornerstone.git","clone_url":"https://github.com/davidwrpayne/cornerstone.git","svn_url":"https://github.com/davidwrpayne/cornerstone","homepage":"https://stencil.bigcommerce.com/docs","size":34994,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bigcommerce:master","ref":"master","sha":"48c7a2876f8eca950843c9d842728e61d982a9c0","user":{"login":"bigcommerce","id":186342,"avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":34682093,"name":"cornerstone","full_name":"bigcommerce/cornerstone","owner":{"login":"bigcommerce","id":186342,"avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigcommerce/cornerstone","description":"The BigCommerce Cornerstone theme","fork":false,"url":"https://api.github.com/repos/bigcommerce/cornerstone","forks_url":"https://api.github.com/repos/bigcommerce/cornerstone/forks","keys_url":"https://api.github.com/repos/bigcommerce/cornerstone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigcommerce/cornerstone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigcommerce/cornerstone/teams","hooks_url":"https://api.github.com/repos/bigcommerce/cornerstone/hooks","issue_events_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/events{/number}","events_url":"https://api.github.com/repos/bigcommerce/cornerstone/events","assignees_url":"https://api.github.com/repos/bigcommerce/cornerstone/assignees{/user}","branches_url":"https://api.github.com/repos/bigcommerce/cornerstone/branches{/branch}","tags_url":"https://api.github.com/repos/bigcommerce/cornerstone/tags","blobs_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigcommerce/cornerstone/statuses/{sha}","languages_url":"https://api.github.com/repos/bigcommerce/cornerstone/languages","stargazers_url":"https://api.github.com/repos/bigcommerce/cornerstone/stargazers","contributors_url":"https://api.github.com/repos/bigcommerce/cornerstone/contributors","subscribers_url":"https://api.github.com/repos/bigcommerce/cornerstone/subscribers","subscription_url":"https://api.github.com/repos/bigcommerce/cornerstone/subscription","commits_url":"https://api.github.com/repos/bigcommerce/cornerstone/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigcommerce/cornerstone/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigcommerce/cornerstone/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigcommerce/cornerstone/contents/{+path}","compare_url":"https://api.github.com/repos/bigcommerce/cornerstone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigcommerce/cornerstone/merges","archive_url":"https://api.github.com/repos/bigcommerce/cornerstone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigcommerce/cornerstone/downloads","issues_url":"https://api.github.com/repos/bigcommerce/cornerstone/issues{/number}","pulls_url":"https://api.github.com/repos/bigcommerce/cornerstone/pulls{/number}","milestones_url":"https://api.github.com/repos/bigcommerce/cornerstone/milestones{/number}","notifications_url":"https://api.github.com/repos/bigcommerce/cornerstone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigcommerce/cornerstone/labels{/name}","releases_url":"https://api.github.com/repos/bigcommerce/cornerstone/releases{/id}","deployments_url":"https://api.github.com/repos/bigcommerce/cornerstone/deployments","created_at":"2015-04-27T17:58:18Z","updated_at":"2018-05-09T18:21:00Z","pushed_at":"2018-05-11T23:55:22Z","git_url":"git://github.com/bigcommerce/cornerstone.git","ssh_url":"git@github.com:bigcommerce/cornerstone.git","clone_url":"https://github.com/bigcommerce/cornerstone.git","svn_url":"https://github.com/bigcommerce/cornerstone","homepage":"https://stencil.bigcommerce.com/docs","size":34994,"stargazers_count":59,"watchers_count":59,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":141,"open_issues":49,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1233"},"html":{"href":"https://github.com/bigcommerce/cornerstone/pull/1233"},"issue":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1233"},"comments":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/issues/1233/comments"},"review_comments":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1233/comments"},"review_comment":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/pulls/1233/commits"},"statuses":{"href":"https://api.github.com/repos/bigcommerce/cornerstone/statuses/c153b8904c5340acfb2cbb612fece3afc080889c"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":41,"deletions":30,"changed_files":3}}
{"actor":{"display_login":"davidwrpayne"}}