{"action":"created","comment":{"url":"https://api.github.com/repos/Codappix/search_core/pulls/comments/228876531","pull_request_review_id":169240313,"id":228876531,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODg3NjUzMQ==","diff_hunk":"@@ -132,27 +148,65 @@ public function getRecord(int $identifier) : array\n         return $record ?: [];\n     }\n \n+    /**\n+     * @param array $records\n+     * @return void\n+     */\n     public function filterRecordsByRootLineBlacklist(array &$records)\n     {\n         $records = array_filter(\n             $records,\n             function ($record) {\n-                return ! $this->isRecordBlacklistedByRootline($record);\n+                return !$this->isRecordBlacklistedByRootline($record);\n             }\n         );\n     }\n \n+    /**\n+     * @param array $record\n+     * @return void\n+     */\n     public function prepareRecord(array &$record)\n     {\n-        if (isset($record['uid']) && !isset($record['search_identifier'])) {\n-            $record['search_identifier'] = $record['uid'];\n-        }\n         if (isset($record[$this->tca['ctrl']['label']]) && !isset($record['search_title'])) {\n             $record['search_title'] = $record[$this->tca['ctrl']['label']];\n         }\n+\n+        if (isset(\n+            $this->tca['ctrl']['enablecolumns']['fe_group'],\n+            $record[$this->tca['ctrl']['enablecolumns']['fe_group']]\n+        )) {\n+            $groups = GeneralUtility::intExplode(\n+                ',',\n+                $record[$this->tca['ctrl']['enablecolumns']['fe_group']],\n+                true\n+            );\n+            // Always fallback on public visibility when configured\n+            $record['search_access'] = !empty($groups) ? $groups : [0];\n+        }\n+\n+        if (!isset($record['search_page_typolink'])) {","path":"Classes/Domain/Index/TcaIndexer/TcaTableService.php","position":86,"original_position":112,"commit_id":"2d9062b6e329bab8b92cad0e1f39aefe4a841ba0","original_commit_id":"0d14f80f62c43eb6842d98cacd46195d9ebc402e","user":{"login":"bmoex","id":2414665,"node_id":"MDQ6VXNlcjI0MTQ2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2414665?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoex","html_url":"https://github.com/bmoex","followers_url":"https://api.github.com/users/bmoex/followers","following_url":"https://api.github.com/users/bmoex/following{/other_user}","gists_url":"https://api.github.com/users/bmoex/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoex/subscriptions","organizations_url":"https://api.github.com/users/bmoex/orgs","repos_url":"https://api.github.com/users/bmoex/repos","events_url":"https://api.github.com/users/bmoex/events{/privacy}","received_events_url":"https://api.github.com/users/bmoex/received_events","type":"User","site_admin":false},"body":"I will remove this functionality. This could easily be handled in a view as well.","created_at":"2018-10-29T10:48:38Z","updated_at":"2018-10-29T10:48:38Z","html_url":"https://github.com/Codappix/search_core/pull/167#discussion_r228876531","pull_request_url":"https://api.github.com/repos/Codappix/search_core/pulls/167","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Codappix/search_core/pulls/comments/228876531"},"html":{"href":"https://github.com/Codappix/search_core/pull/167#discussion_r228876531"},"pull_request":{"href":"https://api.github.com/repos/Codappix/search_core/pulls/167"}},"in_reply_to_id":228707719},"pull_request":{"url":"https://api.github.com/repos/Codappix/search_core/pulls/167","id":226015804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDE1ODA0","html_url":"https://github.com/Codappix/search_core/pull/167","diff_url":"https://github.com/Codappix/search_core/pull/167.diff","patch_url":"https://github.com/Codappix/search_core/pull/167.patch","issue_url":"https://api.github.com/repos/Codappix/search_core/issues/167","number":167,"state":"open","locked":false,"title":"[FEATURE] Elastic 6.x support","user":{"login":"bmoex","id":2414665,"node_id":"MDQ6VXNlcjI0MTQ2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2414665?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoex","html_url":"https://github.com/bmoex","followers_url":"https://api.github.com/users/bmoex/followers","following_url":"https://api.github.com/users/bmoex/following{/other_user}","gists_url":"https://api.github.com/users/bmoex/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoex/subscriptions","organizations_url":"https://api.github.com/users/bmoex/orgs","repos_url":"https://api.github.com/users/bmoex/repos","events_url":"https://api.github.com/users/bmoex/events{/privacy}","received_events_url":"https://api.github.com/users/bmoex/received_events","type":"User","site_admin":false},"body":"- Removed multiple documents from indexation\r\n- Added specific deletion from same index\r\n- Bugfixed the Generator loop when loop was not finished but has no results in the 50 items\r\n- Added a new Functional test for deleteDocuments\r\n- Added typolink to indexation\r\n- Seperated form & list plugin for flexible usage\r\n- Added frontend access lookup for searching in hidden/public pages\r\n","created_at":"2018-10-26T08:29:51Z","updated_at":"2018-10-29T10:48:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6406deb37895b0034fc4e8e20cd957db4493b23","assignee":{"login":"DanielSiepmann","id":354250,"node_id":"MDQ6VXNlcjM1NDI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/354250?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielSiepmann","html_url":"https://github.com/DanielSiepmann","followers_url":"https://api.github.com/users/DanielSiepmann/followers","following_url":"https://api.github.com/users/DanielSiepmann/following{/other_user}","gists_url":"https://api.github.com/users/DanielSiepmann/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSiepmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSiepmann/subscriptions","organizations_url":"https://api.github.com/users/DanielSiepmann/orgs","repos_url":"https://api.github.com/users/DanielSiepmann/repos","events_url":"https://api.github.com/users/DanielSiepmann/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSiepmann/received_events","type":"User","site_admin":false},"assignees":[{"login":"DanielSiepmann","id":354250,"node_id":"MDQ6VXNlcjM1NDI1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/354250?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielSiepmann","html_url":"https://github.com/DanielSiepmann","followers_url":"https://api.github.com/users/DanielSiepmann/followers","following_url":"https://api.github.com/users/DanielSiepmann/following{/other_user}","gists_url":"https://api.github.com/users/DanielSiepmann/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielSiepmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielSiepmann/subscriptions","organizations_url":"https://api.github.com/users/DanielSiepmann/orgs","repos_url":"https://api.github.com/users/DanielSiepmann/repos","events_url":"https://api.github.com/users/DanielSiepmann/events{/privacy}","received_events_url":"https://api.github.com/users/DanielSiepmann/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Codappix/search_core/pulls/167/commits","review_comments_url":"https://api.github.com/repos/Codappix/search_core/pulls/167/comments","review_comment_url":"https://api.github.com/repos/Codappix/search_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Codappix/search_core/issues/167/comments","statuses_url":"https://api.github.com/repos/Codappix/search_core/statuses/2d9062b6e329bab8b92cad0e1f39aefe4a841ba0","head":{"label":"bmoex:feature/elastic-upgrade","ref":"feature/elastic-upgrade","sha":"2d9062b6e329bab8b92cad0e1f39aefe4a841ba0","user":{"login":"bmoex","id":2414665,"node_id":"MDQ6VXNlcjI0MTQ2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2414665?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoex","html_url":"https://github.com/bmoex","followers_url":"https://api.github.com/users/bmoex/followers","following_url":"https://api.github.com/users/bmoex/following{/other_user}","gists_url":"https://api.github.com/users/bmoex/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoex/subscriptions","organizations_url":"https://api.github.com/users/bmoex/orgs","repos_url":"https://api.github.com/users/bmoex/repos","events_url":"https://api.github.com/users/bmoex/events{/privacy}","received_events_url":"https://api.github.com/users/bmoex/received_events","type":"User","site_admin":false},"repo":{"id":151233550,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyMzM1NTA=","name":"search_core","full_name":"bmoex/search_core","private":false,"owner":{"login":"bmoex","id":2414665,"node_id":"MDQ6VXNlcjI0MTQ2NjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2414665?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoex","html_url":"https://github.com/bmoex","followers_url":"https://api.github.com/users/bmoex/followers","following_url":"https://api.github.com/users/bmoex/following{/other_user}","gists_url":"https://api.github.com/users/bmoex/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoex/subscriptions","organizations_url":"https://api.github.com/users/bmoex/orgs","repos_url":"https://api.github.com/users/bmoex/repos","events_url":"https://api.github.com/users/bmoex/events{/privacy}","received_events_url":"https://api.github.com/users/bmoex/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bmoex/search_core","description":"TYPO3 CMS 8.x Extension with basic Integration of Elasticsearch","fork":true,"url":"https://api.github.com/repos/bmoex/search_core","forks_url":"https://api.github.com/repos/bmoex/search_core/forks","keys_url":"https://api.github.com/repos/bmoex/search_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmoex/search_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmoex/search_core/teams","hooks_url":"https://api.github.com/repos/bmoex/search_core/hooks","issue_events_url":"https://api.github.com/repos/bmoex/search_core/issues/events{/number}","events_url":"https://api.github.com/repos/bmoex/search_core/events","assignees_url":"https://api.github.com/repos/bmoex/search_core/assignees{/user}","branches_url":"https://api.github.com/repos/bmoex/search_core/branches{/branch}","tags_url":"https://api.github.com/repos/bmoex/search_core/tags","blobs_url":"https://api.github.com/repos/bmoex/search_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmoex/search_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmoex/search_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmoex/search_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmoex/search_core/statuses/{sha}","languages_url":"https://api.github.com/repos/bmoex/search_core/languages","stargazers_url":"https://api.github.com/repos/bmoex/search_core/stargazers","contributors_url":"https://api.github.com/repos/bmoex/search_core/contributors","subscribers_url":"https://api.github.com/repos/bmoex/search_core/subscribers","subscription_url":"https://api.github.com/repos/bmoex/search_core/subscription","commits_url":"https://api.github.com/repos/bmoex/search_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmoex/search_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmoex/search_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmoex/search_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmoex/search_core/contents/{+path}","compare_url":"https://api.github.com/repos/bmoex/search_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmoex/search_core/merges","archive_url":"https://api.github.com/repos/bmoex/search_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmoex/search_core/downloads","issues_url":"https://api.github.com/repos/bmoex/search_core/issues{/number}","pulls_url":"https://api.github.com/repos/bmoex/search_core/pulls{/number}","milestones_url":"https://api.github.com/repos/bmoex/search_core/milestones{/number}","notifications_url":"https://api.github.com/repos/bmoex/search_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmoex/search_core/labels{/name}","releases_url":"https://api.github.com/repos/bmoex/search_core/releases{/id}","deployments_url":"https://api.github.com/repos/bmoex/search_core/deployments","created_at":"2018-10-02T09:52:18Z","updated_at":"2018-10-02T09:52:20Z","pushed_at":"2018-10-27T12:08:20Z","git_url":"git://github.com/bmoex/search_core.git","ssh_url":"git@github.com:bmoex/search_core.git","clone_url":"https://github.com/bmoex/search_core.git","svn_url":"https://github.com/bmoex/search_core","homepage":"https://search-core.readthedocs.io/en/latest/","size":950,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Codappix:develop","ref":"develop","sha":"21693cf87e2c8f315f3985a5b7eb2990f1e5bc35","user":{"login":"Codappix","id":10426452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDI2NDUy","avatar_url":"https://avatars0.githubusercontent.com/u/10426452?v=4","gravatar_id":"","url":"https://api.github.com/users/Codappix","html_url":"https://github.com/Codappix","followers_url":"https://api.github.com/users/Codappix/followers","following_url":"https://api.github.com/users/Codappix/following{/other_user}","gists_url":"https://api.github.com/users/Codappix/gists{/gist_id}","starred_url":"https://api.github.com/users/Codappix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codappix/subscriptions","organizations_url":"https://api.github.com/users/Codappix/orgs","repos_url":"https://api.github.com/users/Codappix/repos","events_url":"https://api.github.com/users/Codappix/events{/privacy}","received_events_url":"https://api.github.com/users/Codappix/received_events","type":"Organization","site_admin":false},"repo":{"id":76018568,"node_id":"MDEwOlJlcG9zaXRvcnk3NjAxODU2OA==","name":"search_core","full_name":"Codappix/search_core","private":false,"owner":{"login":"Codappix","id":10426452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDI2NDUy","avatar_url":"https://avatars0.githubusercontent.com/u/10426452?v=4","gravatar_id":"","url":"https://api.github.com/users/Codappix","html_url":"https://github.com/Codappix","followers_url":"https://api.github.com/users/Codappix/followers","following_url":"https://api.github.com/users/Codappix/following{/other_user}","gists_url":"https://api.github.com/users/Codappix/gists{/gist_id}","starred_url":"https://api.github.com/users/Codappix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Codappix/subscriptions","organizations_url":"https://api.github.com/users/Codappix/orgs","repos_url":"https://api.github.com/users/Codappix/repos","events_url":"https://api.github.com/users/Codappix/events{/privacy}","received_events_url":"https://api.github.com/users/Codappix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Codappix/search_core","description":"TYPO3 CMS 8.x Extension with basic Integration of Elasticsearch","fork":false,"url":"https://api.github.com/repos/Codappix/search_core","forks_url":"https://api.github.com/repos/Codappix/search_core/forks","keys_url":"https://api.github.com/repos/Codappix/search_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Codappix/search_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Codappix/search_core/teams","hooks_url":"https://api.github.com/repos/Codappix/search_core/hooks","issue_events_url":"https://api.github.com/repos/Codappix/search_core/issues/events{/number}","events_url":"https://api.github.com/repos/Codappix/search_core/events","assignees_url":"https://api.github.com/repos/Codappix/search_core/assignees{/user}","branches_url":"https://api.github.com/repos/Codappix/search_core/branches{/branch}","tags_url":"https://api.github.com/repos/Codappix/search_core/tags","blobs_url":"https://api.github.com/repos/Codappix/search_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Codappix/search_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Codappix/search_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Codappix/search_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Codappix/search_core/statuses/{sha}","languages_url":"https://api.github.com/repos/Codappix/search_core/languages","stargazers_url":"https://api.github.com/repos/Codappix/search_core/stargazers","contributors_url":"https://api.github.com/repos/Codappix/search_core/contributors","subscribers_url":"https://api.github.com/repos/Codappix/search_core/subscribers","subscription_url":"https://api.github.com/repos/Codappix/search_core/subscription","commits_url":"https://api.github.com/repos/Codappix/search_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Codappix/search_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Codappix/search_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Codappix/search_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Codappix/search_core/contents/{+path}","compare_url":"https://api.github.com/repos/Codappix/search_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Codappix/search_core/merges","archive_url":"https://api.github.com/repos/Codappix/search_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Codappix/search_core/downloads","issues_url":"https://api.github.com/repos/Codappix/search_core/issues{/number}","pulls_url":"https://api.github.com/repos/Codappix/search_core/pulls{/number}","milestones_url":"https://api.github.com/repos/Codappix/search_core/milestones{/number}","notifications_url":"https://api.github.com/repos/Codappix/search_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Codappix/search_core/labels{/name}","releases_url":"https://api.github.com/repos/Codappix/search_core/releases{/id}","deployments_url":"https://api.github.com/repos/Codappix/search_core/deployments","created_at":"2016-12-09T08:54:05Z","updated_at":"2018-09-27T15:36:08Z","pushed_at":"2018-10-27T12:08:21Z","git_url":"git://github.com/Codappix/search_core.git","ssh_url":"git@github.com:Codappix/search_core.git","clone_url":"https://github.com/Codappix/search_core.git","svn_url":"https://github.com/Codappix/search_core","homepage":"https://search-core.readthedocs.io/en/latest/","size":760,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":6,"open_issues":11,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Codappix/search_core/pulls/167"},"html":{"href":"https://github.com/Codappix/search_core/pull/167"},"issue":{"href":"https://api.github.com/repos/Codappix/search_core/issues/167"},"comments":{"href":"https://api.github.com/repos/Codappix/search_core/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/Codappix/search_core/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/Codappix/search_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Codappix/search_core/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/Codappix/search_core/statuses/2d9062b6e329bab8b92cad0e1f39aefe4a841ba0"}},"author_association":"NONE"}}
{"actor":{"display_login":"bmoex"}}