{"action":"created","comment":{"url":"https://api.github.com/repos/json-api/json-api/pulls/comments/168121486","pull_request_review_id":96432675,"id":168121486,"diff_hunk":"@@ -360,10 +372,21 @@ response that includes the resource as the primary data.\n A \"resource identifier object\" is an object that identifies an individual\n resource.\n \n-A \"resource identifier object\" **MUST** contain `type` and `id` members.\n+A \"resource identifier object\" **MUST** contain a `type` member. A resource\n+identifier object **MUST** also contain an `id` member, except when it contains\n+a `lid` that identifies it as matching a new resource to be created on the\n+server.\n+\n+A \"resource identifier object\" **MAY** contain a `lid` member. If `id` is\n+omitted due to the exception described above, a `lid` member **MUST** be\n+included. A `lid` member **MUST** also be included if the referenced resource is\n+represented elsewhere in the document with a `lid`. The value of a `lid` member\n+**MUST** be identical for every representation of the resource in the document.\n+\n+The values of the `id`, `lid`, and `type` members **MUST** be strings.\n \n-A \"resource identifier object\" **MAY** also include a `meta` member, whose value is a [meta] object that\n-contains non-standard meta-information.\n+A \"resource identifier object\" **MAY** also include a `meta` member, whose value","path":"_format/1.1/index.md","position":50,"original_position":50,"commit_id":"eedd85ca4723a1d7fbea2ba906e73b93989b2866","original_commit_id":"eedd85ca4723a1d7fbea2ba906e73b93989b2866","user":{"login":"wimleers","id":14240,"avatar_url":"https://avatars0.githubusercontent.com/u/14240?v=4","gravatar_id":"","url":"https://api.github.com/users/wimleers","html_url":"https://github.com/wimleers","followers_url":"https://api.github.com/users/wimleers/followers","following_url":"https://api.github.com/users/wimleers/following{/other_user}","gists_url":"https://api.github.com/users/wimleers/gists{/gist_id}","starred_url":"https://api.github.com/users/wimleers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wimleers/subscriptions","organizations_url":"https://api.github.com/users/wimleers/orgs","repos_url":"https://api.github.com/users/wimleers/repos","events_url":"https://api.github.com/users/wimleers/events{/privacy}","received_events_url":"https://api.github.com/users/wimleers/received_events","type":"User","site_admin":false},"body":"There is no actual change here, just reflowing. This change can/should hence be reverted AFAICT.","created_at":"2018-02-14T09:45:33Z","updated_at":"2018-02-14T09:47:49Z","html_url":"https://github.com/json-api/json-api/pull/1244#discussion_r168121486","pull_request_url":"https://api.github.com/repos/json-api/json-api/pulls/1244","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/json-api/json-api/pulls/comments/168121486"},"html":{"href":"https://github.com/json-api/json-api/pull/1244#discussion_r168121486"},"pull_request":{"href":"https://api.github.com/repos/json-api/json-api/pulls/1244"}}},"pull_request":{"url":"https://api.github.com/repos/json-api/json-api/pulls/1244","id":157371807,"html_url":"https://github.com/json-api/json-api/pull/1244","diff_url":"https://github.com/json-api/json-api/pull/1244.diff","patch_url":"https://github.com/json-api/json-api/pull/1244.patch","issue_url":"https://api.github.com/repos/json-api/json-api/issues/1244","number":1244,"state":"open","locked":false,"title":"Introduce Local IDs to v1.1","user":{"login":"dgeb","id":29122,"avatar_url":"https://avatars0.githubusercontent.com/u/29122?v=4","gravatar_id":"","url":"https://api.github.com/users/dgeb","html_url":"https://github.com/dgeb","followers_url":"https://api.github.com/users/dgeb/followers","following_url":"https://api.github.com/users/dgeb/following{/other_user}","gists_url":"https://api.github.com/users/dgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/dgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgeb/subscriptions","organizations_url":"https://api.github.com/users/dgeb/orgs","repos_url":"https://api.github.com/users/dgeb/repos","events_url":"https://api.github.com/users/dgeb/events{/privacy}","received_events_url":"https://api.github.com/users/dgeb/received_events","type":"User","site_admin":false},"body":"A client may include a \"local ID\" as a `lid` member in a resource object to\r\nuniquely identify the resource within the request document. Every representation\r\nof that resource, whether as a resource object or resource identifier object,\r\nmust then include the matching `lid` member and value.\r\n\r\nWhen a server receives a request document that contains resources with local\r\nIDs, the server must include the matching `lid` member and value in every \r\nrepresentation of that resource or resource identifier in the response document.\r\n\r\nThis addition paves the way for requests of all kinds that may need to establish\r\nlinkage between resources that have not yet been assigned a server-generated ID.\r\n\r\n----\r\n\r\nNote: This proposal obviously overlaps with a portion of #1197, but I'd like to more fully integrate the concept of local ids in the spec without restricting them to a section on \"side posting\".\r\n\r\nNote: I'm proposing the name `lid` after considering negative feedback to my `key` proposal in #1197. I favor a name that references either \"local\" or \"document\" instead of \"temporary\", because this field does not really seem to have a temporal component to it. I also don't like squishing multiple words into one (like `tempid`) but an abbreviation like `lid` is different and consistent with `id`.","created_at":"2017-12-09T03:48:23Z","updated_at":"2018-02-14T09:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bec659085a1dc9850a69684e217908d1c05a9f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/json-api/json-api/pulls/1244/commits","review_comments_url":"https://api.github.com/repos/json-api/json-api/pulls/1244/comments","review_comment_url":"https://api.github.com/repos/json-api/json-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/json-api/json-api/issues/1244/comments","statuses_url":"https://api.github.com/repos/json-api/json-api/statuses/eedd85ca4723a1d7fbea2ba906e73b93989b2866","head":{"label":"json-api:lids","ref":"lids","sha":"eedd85ca4723a1d7fbea2ba906e73b93989b2866","user":{"login":"json-api","id":4341694,"avatar_url":"https://avatars2.githubusercontent.com/u/4341694?v=4","gravatar_id":"","url":"https://api.github.com/users/json-api","html_url":"https://github.com/json-api","followers_url":"https://api.github.com/users/json-api/followers","following_url":"https://api.github.com/users/json-api/following{/other_user}","gists_url":"https://api.github.com/users/json-api/gists{/gist_id}","starred_url":"https://api.github.com/users/json-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-api/subscriptions","organizations_url":"https://api.github.com/users/json-api/orgs","repos_url":"https://api.github.com/users/json-api/repos","events_url":"https://api.github.com/users/json-api/events{/privacy}","received_events_url":"https://api.github.com/users/json-api/received_events","type":"Organization","site_admin":false},"repo":{"id":9859154,"name":"json-api","full_name":"json-api/json-api","owner":{"login":"json-api","id":4341694,"avatar_url":"https://avatars2.githubusercontent.com/u/4341694?v=4","gravatar_id":"","url":"https://api.github.com/users/json-api","html_url":"https://github.com/json-api","followers_url":"https://api.github.com/users/json-api/followers","following_url":"https://api.github.com/users/json-api/following{/other_user}","gists_url":"https://api.github.com/users/json-api/gists{/gist_id}","starred_url":"https://api.github.com/users/json-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-api/subscriptions","organizations_url":"https://api.github.com/users/json-api/orgs","repos_url":"https://api.github.com/users/json-api/repos","events_url":"https://api.github.com/users/json-api/events{/privacy}","received_events_url":"https://api.github.com/users/json-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/json-api/json-api","description":"A specification for building JSON APIs","fork":false,"url":"https://api.github.com/repos/json-api/json-api","forks_url":"https://api.github.com/repos/json-api/json-api/forks","keys_url":"https://api.github.com/repos/json-api/json-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/json-api/json-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/json-api/json-api/teams","hooks_url":"https://api.github.com/repos/json-api/json-api/hooks","issue_events_url":"https://api.github.com/repos/json-api/json-api/issues/events{/number}","events_url":"https://api.github.com/repos/json-api/json-api/events","assignees_url":"https://api.github.com/repos/json-api/json-api/assignees{/user}","branches_url":"https://api.github.com/repos/json-api/json-api/branches{/branch}","tags_url":"https://api.github.com/repos/json-api/json-api/tags","blobs_url":"https://api.github.com/repos/json-api/json-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/json-api/json-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/json-api/json-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/json-api/json-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/json-api/json-api/statuses/{sha}","languages_url":"https://api.github.com/repos/json-api/json-api/languages","stargazers_url":"https://api.github.com/repos/json-api/json-api/stargazers","contributors_url":"https://api.github.com/repos/json-api/json-api/contributors","subscribers_url":"https://api.github.com/repos/json-api/json-api/subscribers","subscription_url":"https://api.github.com/repos/json-api/json-api/subscription","commits_url":"https://api.github.com/repos/json-api/json-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/json-api/json-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/json-api/json-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/json-api/json-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/json-api/json-api/contents/{+path}","compare_url":"https://api.github.com/repos/json-api/json-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/json-api/json-api/merges","archive_url":"https://api.github.com/repos/json-api/json-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/json-api/json-api/downloads","issues_url":"https://api.github.com/repos/json-api/json-api/issues{/number}","pulls_url":"https://api.github.com/repos/json-api/json-api/pulls{/number}","milestones_url":"https://api.github.com/repos/json-api/json-api/milestones{/number}","notifications_url":"https://api.github.com/repos/json-api/json-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/json-api/json-api/labels{/name}","releases_url":"https://api.github.com/repos/json-api/json-api/releases{/id}","deployments_url":"https://api.github.com/repos/json-api/json-api/deployments","created_at":"2013-05-04T19:29:30Z","updated_at":"2018-02-13T12:12:52Z","pushed_at":"2018-02-12T20:33:37Z","git_url":"git://github.com/json-api/json-api.git","ssh_url":"git@github.com:json-api/json-api.git","clone_url":"https://github.com/json-api/json-api.git","svn_url":"https://github.com/json-api/json-api","homepage":"http://jsonapi.org","size":2221,"stargazers_count":5038,"watchers_count":5038,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":604,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":604,"open_issues":128,"watchers":5038,"default_branch":"gh-pages"}},"base":{"label":"json-api:gh-pages","ref":"gh-pages","sha":"0342e468f1ddfbfbbadf0ad4bcfde123b89847fa","user":{"login":"json-api","id":4341694,"avatar_url":"https://avatars2.githubusercontent.com/u/4341694?v=4","gravatar_id":"","url":"https://api.github.com/users/json-api","html_url":"https://github.com/json-api","followers_url":"https://api.github.com/users/json-api/followers","following_url":"https://api.github.com/users/json-api/following{/other_user}","gists_url":"https://api.github.com/users/json-api/gists{/gist_id}","starred_url":"https://api.github.com/users/json-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-api/subscriptions","organizations_url":"https://api.github.com/users/json-api/orgs","repos_url":"https://api.github.com/users/json-api/repos","events_url":"https://api.github.com/users/json-api/events{/privacy}","received_events_url":"https://api.github.com/users/json-api/received_events","type":"Organization","site_admin":false},"repo":{"id":9859154,"name":"json-api","full_name":"json-api/json-api","owner":{"login":"json-api","id":4341694,"avatar_url":"https://avatars2.githubusercontent.com/u/4341694?v=4","gravatar_id":"","url":"https://api.github.com/users/json-api","html_url":"https://github.com/json-api","followers_url":"https://api.github.com/users/json-api/followers","following_url":"https://api.github.com/users/json-api/following{/other_user}","gists_url":"https://api.github.com/users/json-api/gists{/gist_id}","starred_url":"https://api.github.com/users/json-api/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/json-api/subscriptions","organizations_url":"https://api.github.com/users/json-api/orgs","repos_url":"https://api.github.com/users/json-api/repos","events_url":"https://api.github.com/users/json-api/events{/privacy}","received_events_url":"https://api.github.com/users/json-api/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/json-api/json-api","description":"A specification for building JSON APIs","fork":false,"url":"https://api.github.com/repos/json-api/json-api","forks_url":"https://api.github.com/repos/json-api/json-api/forks","keys_url":"https://api.github.com/repos/json-api/json-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/json-api/json-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/json-api/json-api/teams","hooks_url":"https://api.github.com/repos/json-api/json-api/hooks","issue_events_url":"https://api.github.com/repos/json-api/json-api/issues/events{/number}","events_url":"https://api.github.com/repos/json-api/json-api/events","assignees_url":"https://api.github.com/repos/json-api/json-api/assignees{/user}","branches_url":"https://api.github.com/repos/json-api/json-api/branches{/branch}","tags_url":"https://api.github.com/repos/json-api/json-api/tags","blobs_url":"https://api.github.com/repos/json-api/json-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/json-api/json-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/json-api/json-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/json-api/json-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/json-api/json-api/statuses/{sha}","languages_url":"https://api.github.com/repos/json-api/json-api/languages","stargazers_url":"https://api.github.com/repos/json-api/json-api/stargazers","contributors_url":"https://api.github.com/repos/json-api/json-api/contributors","subscribers_url":"https://api.github.com/repos/json-api/json-api/subscribers","subscription_url":"https://api.github.com/repos/json-api/json-api/subscription","commits_url":"https://api.github.com/repos/json-api/json-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/json-api/json-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/json-api/json-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/json-api/json-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/json-api/json-api/contents/{+path}","compare_url":"https://api.github.com/repos/json-api/json-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/json-api/json-api/merges","archive_url":"https://api.github.com/repos/json-api/json-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/json-api/json-api/downloads","issues_url":"https://api.github.com/repos/json-api/json-api/issues{/number}","pulls_url":"https://api.github.com/repos/json-api/json-api/pulls{/number}","milestones_url":"https://api.github.com/repos/json-api/json-api/milestones{/number}","notifications_url":"https://api.github.com/repos/json-api/json-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/json-api/json-api/labels{/name}","releases_url":"https://api.github.com/repos/json-api/json-api/releases{/id}","deployments_url":"https://api.github.com/repos/json-api/json-api/deployments","created_at":"2013-05-04T19:29:30Z","updated_at":"2018-02-13T12:12:52Z","pushed_at":"2018-02-12T20:33:37Z","git_url":"git://github.com/json-api/json-api.git","ssh_url":"git@github.com:json-api/json-api.git","clone_url":"https://github.com/json-api/json-api.git","svn_url":"https://github.com/json-api/json-api","homepage":"http://jsonapi.org","size":2221,"stargazers_count":5038,"watchers_count":5038,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":604,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":604,"open_issues":128,"watchers":5038,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/json-api/json-api/pulls/1244"},"html":{"href":"https://github.com/json-api/json-api/pull/1244"},"issue":{"href":"https://api.github.com/repos/json-api/json-api/issues/1244"},"comments":{"href":"https://api.github.com/repos/json-api/json-api/issues/1244/comments"},"review_comments":{"href":"https://api.github.com/repos/json-api/json-api/pulls/1244/comments"},"review_comment":{"href":"https://api.github.com/repos/json-api/json-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/json-api/json-api/pulls/1244/commits"},"statuses":{"href":"https://api.github.com/repos/json-api/json-api/statuses/eedd85ca4723a1d7fbea2ba906e73b93989b2866"}},"author_association":"OWNER"}}
{"actor":{"display_login":"wimleers"}}