{"push_id":3017257301,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"e01b68f83502532c752548862875751d3f0ff164","before":"680f06dee90c274ae83cef2abd9a3d64659e7cdf","commits":[{"sha":"e01b68f83502532c752548862875751d3f0ff164","author":{"name":"Michael Altfield","email":"17b9e1c64588c7fa6419b4d29dc1f4426279ba01@michaelaltfield.net"},"message":"return error code on FAIL in ajax subscribe (#432)\n\n* Adding (more) graceful failure when phplist does not have access to random_bytes() from some cryptographically secure pseudorandom number generator (CSPRNG). For more info, please see:\r\n\r\n * https://discuss.phplist.org/t/common-installation-errors-manual-chapter-feedback-and-discussion/217/4\r\n * https://mantis.phplist.org/view.php?id=18546\r\n * https://tech.michaelaltfield.net/2018/08/25/fix-phplist-500-error-due-to-random_compat/\r\n\r\n* Added a line to throw an exception when the phplist ajax subscribe endpoint fails to add a new subscriber. Throwing this exception causes php to return a 500 Internal Server Error, rather than the existing functionality which just returns a 200 error (merely containing 'FAIL' in the body of the response). Consequently, the ajax client thinks the failure is actually a success, since the http status code is still a 200.\r\n\r\nThis change makes the response more robust and easier for ajax clients (such as the jquery example linked below) to catch errors from phplist.\r\n\r\n * https://discuss.phplist.org/t/ajax-subscribe-api/974\r\n\r\nFor more information, please see the following phplist bug report:\r\n\r\n * https://mantis.phplist.org/view.php?id=19524","distinct":true,"url":"https://api.github.com/repos/phpList/phplist3/commits/e01b68f83502532c752548862875751d3f0ff164"}]}
{"actor":{"display_login":"samtuke"}}