{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/228246065","pull_request_review_id":168474999,"id":228246065,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI0NjA2NQ==","diff_hunk":"@@ -74,9 +75,11 @@ const TabsMixin = {\n         onClick={this.tabs_handleTabClick.bind(this, tab)}\n         {...attributes}\n       >\n-        <span className=\"menu-tabbed-item-label-text\">\n-          {this.tabs_tabs[tab]}\n-        </span>\n+        <Trans\n+          render=\"span\"\n+          className=\"menu-tabbed-item-label-text\"\n+          id={this.tabs_tabs[tab]}","path":"src/js/mixins/TabsMixin.js","position":15,"original_position":15,"commit_id":"bd8036f687755eb1c2b4e6331cb11e6bc8bf2c0e","original_commit_id":"bd8036f687755eb1c2b4e6331cb11e6bc8bf2c0e","user":{"login":"brandonc","id":174332,"node_id":"MDQ6VXNlcjE3NDMzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/174332?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonc","html_url":"https://github.com/brandonc","followers_url":"https://api.github.com/users/brandonc/followers","following_url":"https://api.github.com/users/brandonc/following{/other_user}","gists_url":"https://api.github.com/users/brandonc/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonc/subscriptions","organizations_url":"https://api.github.com/users/brandonc/orgs","repos_url":"https://api.github.com/users/brandonc/repos","events_url":"https://api.github.com/users/brandonc/events{/privacy}","received_events_url":"https://api.github.com/users/brandonc/received_events","type":"User","site_admin":false},"body":"`i18nMark` doesn't translate, it just let's the extractor know about a string that needs translation. You then plug any of those into a Trans component to perform the actual translation.","created_at":"2018-10-25T16:30:12Z","updated_at":"2018-10-25T16:30:12Z","html_url":"https://github.com/dcos/dcos-ui/pull/3373#discussion_r228246065","pull_request_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments/228246065"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/3373#discussion_r228246065"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373"}},"in_reply_to_id":228245571},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373","id":225265345,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjY1MzQ1","html_url":"https://github.com/dcos/dcos-ui/pull/3373","diff_url":"https://github.com/dcos/dcos-ui/pull/3373.diff","patch_url":"https://github.com/dcos/dcos-ui/pull/3373.patch","issue_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3373","number":3373,"state":"open","locked":false,"title":"DCOS-43820: Mark and translate tab labels","user":{"login":"brandonc","id":174332,"node_id":"MDQ6VXNlcjE3NDMzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/174332?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonc","html_url":"https://github.com/brandonc","followers_url":"https://api.github.com/users/brandonc/followers","following_url":"https://api.github.com/users/brandonc/following{/other_user}","gists_url":"https://api.github.com/users/brandonc/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonc/subscriptions","organizations_url":"https://api.github.com/users/brandonc/orgs","repos_url":"https://api.github.com/users/brandonc/repos","events_url":"https://api.github.com/users/brandonc/events{/privacy}","received_events_url":"https://api.github.com/users/brandonc/received_events","type":"User","site_admin":false},"body":"Noticed this translation opportunity while working on adding translation to enterprise plugins.\r\n\r\n## Testing\r\n\r\nThere should be no visual differences or markup changes as a result of merging this PR","created_at":"2018-10-24T05:00:36Z","updated_at":"2018-10-25T16:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac5c6cd564a89fd6500a16b37cf763b4ab95f6de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/issues/3373/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/bd8036f687755eb1c2b4e6331cb11e6bc8bf2c0e","head":{"label":"dcos:brandonc/DCOS-43820_translate_tab_labels","ref":"brandonc/DCOS-43820_translate_tab_labels","sha":"bd8036f687755eb1c2b4e6331cb11e6bc8bf2c0e","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU0NzUwNA==","name":"dcos-ui","full_name":"dcos/dcos-ui","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-10-25T15:55:52Z","pushed_at":"2018-10-25T16:21:42Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":45989,"stargazers_count":190,"watchers_count":190,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":77,"open_issues":15,"watchers":190,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"2a799bc045b8bf1293e13b3ef722bcdfe579aa16","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56547504,"node_id":"MDEwOlJlcG9zaXRvcnk1NjU0NzUwNA==","name":"dcos-ui","full_name":"dcos/dcos-ui","private":false,"owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dcos/dcos-ui","description":"The UI for The Datacenter Operating System","fork":false,"url":"https://api.github.com/repos/dcos/dcos-ui","forks_url":"https://api.github.com/repos/dcos/dcos-ui/forks","keys_url":"https://api.github.com/repos/dcos/dcos-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-ui/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-ui/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-ui/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-ui/events","assignees_url":"https://api.github.com/repos/dcos/dcos-ui/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-ui/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-ui/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-ui/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-ui/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-ui/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-ui/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-ui/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-ui/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-ui/merges","archive_url":"https://api.github.com/repos/dcos/dcos-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-ui/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-ui/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-ui/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-ui/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-ui/deployments","created_at":"2016-04-18T22:48:06Z","updated_at":"2018-10-25T15:55:52Z","pushed_at":"2018-10-25T16:21:42Z","git_url":"git://github.com/dcos/dcos-ui.git","ssh_url":"git@github.com:dcos/dcos-ui.git","clone_url":"https://github.com/dcos/dcos-ui.git","svn_url":"https://github.com/dcos/dcos-ui","homepage":"https://dcos.io/","size":45989,"stargazers_count":190,"watchers_count":190,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":77,"open_issues":15,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373"},"html":{"href":"https://github.com/dcos/dcos-ui/pull/3373"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/3373"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/issues/3373/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-ui/pulls/3373/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-ui/statuses/bd8036f687755eb1c2b4e6331cb11e6bc8bf2c0e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"brandonc"}}