{"action":"closed","number":292,"pull_request":{"url":"https://api.github.com/repos/audacity/audacity/pulls/292","id":209682723,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjgyNzIz","html_url":"https://github.com/audacity/audacity/pull/292","diff_url":"https://github.com/audacity/audacity/pull/292.diff","patch_url":"https://github.com/audacity/audacity/pull/292.patch","issue_url":"https://api.github.com/repos/audacity/audacity/issues/292","number":292,"state":"closed","locked":false,"title":"Seek fix","user":{"login":"Paul-Licameli","id":11670369,"node_id":"MDQ6VXNlcjExNjcwMzY5","avatar_url":"https://avatars0.githubusercontent.com/u/11670369?v=4","gravatar_id":"","url":"https://api.github.com/users/Paul-Licameli","html_url":"https://github.com/Paul-Licameli","followers_url":"https://api.github.com/users/Paul-Licameli/followers","following_url":"https://api.github.com/users/Paul-Licameli/following{/other_user}","gists_url":"https://api.github.com/users/Paul-Licameli/gists{/gist_id}","starred_url":"https://api.github.com/users/Paul-Licameli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paul-Licameli/subscriptions","organizations_url":"https://api.github.com/users/Paul-Licameli/orgs","repos_url":"https://api.github.com/users/Paul-Licameli/repos","events_url":"https://api.github.com/users/Paul-Licameli/events{/privacy}","received_events_url":"https://api.github.com/users/Paul-Licameli/received_events","type":"User","site_admin":false},"body":"The place in the PortAudio callback that detects a dried-up RingBuffer really shouldn't be hit.  We should eliminated all identifiable causes of that.\r\n\r\nJames lately fixed the case where it happened with scrubbing on WASAPI.\r\n\r\nThese changes fix it in case of seeking (with mouse, not arrow keys).  First, it happened most of the time seeking; then after some of the fix, there remained the cases of very slow mouse movement, and of moving the mouse past the end of track.\r\n\r\nIncidentally some of the breaking-up of very big AudioIO functions is accomplished here:  first I split out AudioIO::AllocateBuffers, then in other commits I make modifications.\r\n\r\nThese modifications attempt to maintain a certain minimum occupancy in the RingBuffer, and will be a preliminary to eliminating the use of a condition variable, perhaps in the next Audacity version.\r\n\r\n","created_at":"2018-08-21T01:08:19Z","updated_at":"2018-08-22T00:59:53Z","closed_at":"2018-08-22T00:59:53Z","merged_at":null,"merge_commit_sha":"3067ae3e62dd03dfbfbbc518ae9f47d97e928e8a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/audacity/audacity/milestones/1","html_url":"https://github.com/audacity/audacity/milestone/1","labels_url":"https://api.github.com/repos/audacity/audacity/milestones/1/labels","id":1996963,"node_id":"MDk6TWlsZXN0b25lMTk5Njk2Mw==","number":1,"title":"PLEASE READ this Fake Milestone","description":"http://wiki.audacityteam.org/w/index.php?title=GitHub_Pull_Requests\r\n\r\nThis isn't a milestone.  It's a way to tell people making any decent sized pull requests to please come over talk with us at the audacity devel email list.  If you just rely on the GitHub pull request messages, you may find we ignore or close the pull request for what does not seem to you to be a good reason.  Please come and talk.\r\n\r\nTranslators should subscribe to audacity translators email list instead.\r\n\r\nThere is a bit more  on our wiki about how we use these pull requests and the labels.\r\n\r\n","creator":{"login":"JamesCrook","id":1621525,"node_id":"MDQ6VXNlcjE2MjE1MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1621525?v=4","gravatar_id":"","url":"https://api.github.com/users/JamesCrook","html_url":"https://github.com/JamesCrook","followers_url":"https://api.github.com/users/JamesCrook/followers","following_url":"https://api.github.com/users/JamesCrook/following{/other_user}","gists_url":"https://api.github.com/users/JamesCrook/gists{/gist_id}","starred_url":"https://api.github.com/users/JamesCrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamesCrook/subscriptions","organizations_url":"https://api.github.com/users/JamesCrook/orgs","repos_url":"https://api.github.com/users/JamesCrook/repos","events_url":"https://api.github.com/users/JamesCrook/events{/privacy}","received_events_url":"https://api.github.com/users/JamesCrook/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":64,"state":"open","created_at":"2016-09-11T21:32:59Z","updated_at":"2018-08-22T00:59:53Z","due_on":"2020-01-01T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/audacity/audacity/pulls/292/commits","review_comments_url":"https://api.github.com/repos/audacity/audacity/pulls/292/comments","review_comment_url":"https://api.github.com/repos/audacity/audacity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/audacity/audacity/issues/292/comments","statuses_url":"https://api.github.com/repos/audacity/audacity/statuses/30c914bcf32eb1dc1d4322995f8800426b11093f","head":{"label":"Paul-Licameli:seek-fix","ref":"seek-fix","sha":"30c914bcf32eb1dc1d4322995f8800426b11093f","user":{"login":"Paul-Licameli","id":11670369,"node_id":"MDQ6VXNlcjExNjcwMzY5","avatar_url":"https://avatars0.githubusercontent.com/u/11670369?v=4","gravatar_id":"","url":"https://api.github.com/users/Paul-Licameli","html_url":"https://github.com/Paul-Licameli","followers_url":"https://api.github.com/users/Paul-Licameli/followers","following_url":"https://api.github.com/users/Paul-Licameli/following{/other_user}","gists_url":"https://api.github.com/users/Paul-Licameli/gists{/gist_id}","starred_url":"https://api.github.com/users/Paul-Licameli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paul-Licameli/subscriptions","organizations_url":"https://api.github.com/users/Paul-Licameli/orgs","repos_url":"https://api.github.com/users/Paul-Licameli/repos","events_url":"https://api.github.com/users/Paul-Licameli/events{/privacy}","received_events_url":"https://api.github.com/users/Paul-Licameli/received_events","type":"User","site_admin":false},"repo":{"id":32991761,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk5MTc2MQ==","name":"audacity","full_name":"Paul-Licameli/audacity","owner":{"login":"Paul-Licameli","id":11670369,"node_id":"MDQ6VXNlcjExNjcwMzY5","avatar_url":"https://avatars0.githubusercontent.com/u/11670369?v=4","gravatar_id":"","url":"https://api.github.com/users/Paul-Licameli","html_url":"https://github.com/Paul-Licameli","followers_url":"https://api.github.com/users/Paul-Licameli/followers","following_url":"https://api.github.com/users/Paul-Licameli/following{/other_user}","gists_url":"https://api.github.com/users/Paul-Licameli/gists{/gist_id}","starred_url":"https://api.github.com/users/Paul-Licameli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Paul-Licameli/subscriptions","organizations_url":"https://api.github.com/users/Paul-Licameli/orgs","repos_url":"https://api.github.com/users/Paul-Licameli/repos","events_url":"https://api.github.com/users/Paul-Licameli/events{/privacy}","received_events_url":"https://api.github.com/users/Paul-Licameli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Paul-Licameli/audacity","description":"Source code for the Audacity Open Source sound Editor.","fork":true,"url":"https://api.github.com/repos/Paul-Licameli/audacity","forks_url":"https://api.github.com/repos/Paul-Licameli/audacity/forks","keys_url":"https://api.github.com/repos/Paul-Licameli/audacity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Paul-Licameli/audacity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Paul-Licameli/audacity/teams","hooks_url":"https://api.github.com/repos/Paul-Licameli/audacity/hooks","issue_events_url":"https://api.github.com/repos/Paul-Licameli/audacity/issues/events{/number}","events_url":"https://api.github.com/repos/Paul-Licameli/audacity/events","assignees_url":"https://api.github.com/repos/Paul-Licameli/audacity/assignees{/user}","branches_url":"https://api.github.com/repos/Paul-Licameli/audacity/branches{/branch}","tags_url":"https://api.github.com/repos/Paul-Licameli/audacity/tags","blobs_url":"https://api.github.com/repos/Paul-Licameli/audacity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Paul-Licameli/audacity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Paul-Licameli/audacity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Paul-Licameli/audacity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Paul-Licameli/audacity/statuses/{sha}","languages_url":"https://api.github.com/repos/Paul-Licameli/audacity/languages","stargazers_url":"https://api.github.com/repos/Paul-Licameli/audacity/stargazers","contributors_url":"https://api.github.com/repos/Paul-Licameli/audacity/contributors","subscribers_url":"https://api.github.com/repos/Paul-Licameli/audacity/subscribers","subscription_url":"https://api.github.com/repos/Paul-Licameli/audacity/subscription","commits_url":"https://api.github.com/repos/Paul-Licameli/audacity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Paul-Licameli/audacity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Paul-Licameli/audacity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Paul-Licameli/audacity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Paul-Licameli/audacity/contents/{+path}","compare_url":"https://api.github.com/repos/Paul-Licameli/audacity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Paul-Licameli/audacity/merges","archive_url":"https://api.github.com/repos/Paul-Licameli/audacity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Paul-Licameli/audacity/downloads","issues_url":"https://api.github.com/repos/Paul-Licameli/audacity/issues{/number}","pulls_url":"https://api.github.com/repos/Paul-Licameli/audacity/pulls{/number}","milestones_url":"https://api.github.com/repos/Paul-Licameli/audacity/milestones{/number}","notifications_url":"https://api.github.com/repos/Paul-Licameli/audacity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Paul-Licameli/audacity/labels{/name}","releases_url":"https://api.github.com/repos/Paul-Licameli/audacity/releases{/id}","deployments_url":"https://api.github.com/repos/Paul-Licameli/audacity/deployments","created_at":"2015-03-27T14:46:44Z","updated_at":"2018-05-29T04:22:25Z","pushed_at":"2018-08-22T00:56:16Z","git_url":"git://github.com/Paul-Licameli/audacity.git","ssh_url":"git@github.com:Paul-Licameli/audacity.git","clone_url":"https://github.com/Paul-Licameli/audacity.git","svn_url":"https://github.com/Paul-Licameli/audacity","homepage":null,"size":118140,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"audacity:master","ref":"master","sha":"4ec1393c271c0a5cfeb85099e54ed4599d301b08","user":{"login":"audacity","id":11648186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjQ4MTg2","avatar_url":"https://avatars0.githubusercontent.com/u/11648186?v=4","gravatar_id":"","url":"https://api.github.com/users/audacity","html_url":"https://github.com/audacity","followers_url":"https://api.github.com/users/audacity/followers","following_url":"https://api.github.com/users/audacity/following{/other_user}","gists_url":"https://api.github.com/users/audacity/gists{/gist_id}","starred_url":"https://api.github.com/users/audacity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audacity/subscriptions","organizations_url":"https://api.github.com/users/audacity/orgs","repos_url":"https://api.github.com/users/audacity/repos","events_url":"https://api.github.com/users/audacity/events{/privacy}","received_events_url":"https://api.github.com/users/audacity/received_events","type":"Organization","site_admin":false},"repo":{"id":32921736,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkyMTczNg==","name":"audacity","full_name":"audacity/audacity","owner":{"login":"audacity","id":11648186,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjQ4MTg2","avatar_url":"https://avatars0.githubusercontent.com/u/11648186?v=4","gravatar_id":"","url":"https://api.github.com/users/audacity","html_url":"https://github.com/audacity","followers_url":"https://api.github.com/users/audacity/followers","following_url":"https://api.github.com/users/audacity/following{/other_user}","gists_url":"https://api.github.com/users/audacity/gists{/gist_id}","starred_url":"https://api.github.com/users/audacity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audacity/subscriptions","organizations_url":"https://api.github.com/users/audacity/orgs","repos_url":"https://api.github.com/users/audacity/repos","events_url":"https://api.github.com/users/audacity/events{/privacy}","received_events_url":"https://api.github.com/users/audacity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/audacity/audacity","description":"Audio Editor : : : :  developer list at : : https://lists.sourceforge.net/lists/listinfo/audacity-devel                                                 ","fork":false,"url":"https://api.github.com/repos/audacity/audacity","forks_url":"https://api.github.com/repos/audacity/audacity/forks","keys_url":"https://api.github.com/repos/audacity/audacity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/audacity/audacity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/audacity/audacity/teams","hooks_url":"https://api.github.com/repos/audacity/audacity/hooks","issue_events_url":"https://api.github.com/repos/audacity/audacity/issues/events{/number}","events_url":"https://api.github.com/repos/audacity/audacity/events","assignees_url":"https://api.github.com/repos/audacity/audacity/assignees{/user}","branches_url":"https://api.github.com/repos/audacity/audacity/branches{/branch}","tags_url":"https://api.github.com/repos/audacity/audacity/tags","blobs_url":"https://api.github.com/repos/audacity/audacity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/audacity/audacity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/audacity/audacity/git/refs{/sha}","trees_url":"https://api.github.com/repos/audacity/audacity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/audacity/audacity/statuses/{sha}","languages_url":"https://api.github.com/repos/audacity/audacity/languages","stargazers_url":"https://api.github.com/repos/audacity/audacity/stargazers","contributors_url":"https://api.github.com/repos/audacity/audacity/contributors","subscribers_url":"https://api.github.com/repos/audacity/audacity/subscribers","subscription_url":"https://api.github.com/repos/audacity/audacity/subscription","commits_url":"https://api.github.com/repos/audacity/audacity/commits{/sha}","git_commits_url":"https://api.github.com/repos/audacity/audacity/git/commits{/sha}","comments_url":"https://api.github.com/repos/audacity/audacity/comments{/number}","issue_comment_url":"https://api.github.com/repos/audacity/audacity/issues/comments{/number}","contents_url":"https://api.github.com/repos/audacity/audacity/contents/{+path}","compare_url":"https://api.github.com/repos/audacity/audacity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/audacity/audacity/merges","archive_url":"https://api.github.com/repos/audacity/audacity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/audacity/audacity/downloads","issues_url":"https://api.github.com/repos/audacity/audacity/issues{/number}","pulls_url":"https://api.github.com/repos/audacity/audacity/pulls{/number}","milestones_url":"https://api.github.com/repos/audacity/audacity/milestones{/number}","notifications_url":"https://api.github.com/repos/audacity/audacity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/audacity/audacity/labels{/name}","releases_url":"https://api.github.com/repos/audacity/audacity/releases{/id}","deployments_url":"https://api.github.com/repos/audacity/audacity/deployments","created_at":"2015-03-26T10:46:17Z","updated_at":"2018-08-22T00:55:40Z","pushed_at":"2018-08-22T00:56:18Z","git_url":"git://github.com/audacity/audacity.git","ssh_url":"git@github.com:audacity/audacity.git","clone_url":"https://github.com/audacity/audacity.git","svn_url":"https://github.com/audacity/audacity","homepage":"","size":116327,"stargazers_count":1382,"watchers_count":1382,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":426,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":426,"open_issues":25,"watchers":1382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/audacity/audacity/pulls/292"},"html":{"href":"https://github.com/audacity/audacity/pull/292"},"issue":{"href":"https://api.github.com/repos/audacity/audacity/issues/292"},"comments":{"href":"https://api.github.com/repos/audacity/audacity/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/audacity/audacity/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/audacity/audacity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/audacity/audacity/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/audacity/audacity/statuses/30c914bcf32eb1dc1d4322995f8800426b11093f"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":12,"additions":254,"deletions":160,"changed_files":2}}
{"actor":{"display_login":"Paul-Licameli"}}