{"action":"created","issue":{"url":"https://api.github.com/repos/erikbern/ann-benchmarks/issues/93","repository_url":"https://api.github.com/repos/erikbern/ann-benchmarks","labels_url":"https://api.github.com/repos/erikbern/ann-benchmarks/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/erikbern/ann-benchmarks/issues/93/comments","events_url":"https://api.github.com/repos/erikbern/ann-benchmarks/issues/93/events","html_url":"https://github.com/erikbern/ann-benchmarks/pull/93","id":354402105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTcyNTgy","number":93,"title":"Added ONNG results.","user":{"login":"maumueller","id":6311646,"node_id":"MDQ6VXNlcjYzMTE2NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6311646?v=4","gravatar_id":"","url":"https://api.github.com/users/maumueller","html_url":"https://github.com/maumueller","followers_url":"https://api.github.com/users/maumueller/followers","following_url":"https://api.github.com/users/maumueller/following{/other_user}","gists_url":"https://api.github.com/users/maumueller/gists{/gist_id}","starred_url":"https://api.github.com/users/maumueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maumueller/subscriptions","organizations_url":"https://api.github.com/users/maumueller/orgs","repos_url":"https://api.github.com/users/maumueller/repos","events_url":"https://api.github.com/users/maumueller/events{/privacy}","received_events_url":"https://api.github.com/users/maumueller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-27T17:15:22Z","updated_at":"2018-08-28T06:33:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/erikbern/ann-benchmarks/pulls/93","html_url":"https://github.com/erikbern/ann-benchmarks/pull/93","diff_url":"https://github.com/erikbern/ann-benchmarks/pull/93.diff","patch_url":"https://github.com/erikbern/ann-benchmarks/pull/93.patch"},"body":"After #92 I was interested to see how ONNG actually performs, and it performs quite well! (Much better than their other variant.) Find the updated result plot files in the PR and on http://ann-benchmarks.com. \r\n\r\nOne problem with the plot script in this situation: The change done to PANNG  in `algos.yaml` by https://github.com/erikbern/ann-benchmarks/commit/0b50eb2f149bd0dee343d8c8274b2d3b8d7827b8 made the PANNG result files inaccessible to `plot.py`, since their names changed. I dislike this tight connection between the algos.yaml file and the result files. The plotting done in `create_website.py` just enumerates all result files and plots them, which is much more robust. Maybe we should update `plot.py` to use the same approach? "},"comment":{"url":"https://api.github.com/repos/erikbern/ann-benchmarks/issues/comments/416467253","html_url":"https://github.com/erikbern/ann-benchmarks/pull/93#issuecomment-416467253","issue_url":"https://api.github.com/repos/erikbern/ann-benchmarks/issues/93","id":416467253,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjQ2NzI1Mw==","user":{"login":"masajiro","id":20806009,"node_id":"MDQ6VXNlcjIwODA2MDA5","avatar_url":"https://avatars1.githubusercontent.com/u/20806009?v=4","gravatar_id":"","url":"https://api.github.com/users/masajiro","html_url":"https://github.com/masajiro","followers_url":"https://api.github.com/users/masajiro/followers","following_url":"https://api.github.com/users/masajiro/following{/other_user}","gists_url":"https://api.github.com/users/masajiro/gists{/gist_id}","starred_url":"https://api.github.com/users/masajiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masajiro/subscriptions","organizations_url":"https://api.github.com/users/masajiro/orgs","repos_url":"https://api.github.com/users/masajiro/repos","events_url":"https://api.github.com/users/masajiro/events{/privacy}","received_events_url":"https://api.github.com/users/masajiro/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T06:33:12Z","updated_at":"2018-08-28T06:33:12Z","author_association":"CONTRIBUTOR","body":"@maumueller \r\nThank you for plotting ONNG.\r\n> maybe you could provide preprocessing parameters for these datasets?\r\n\r\nI will investigate better parameters to shorten the construction time. However, it is a very difficult balancing act, because, in most cases, shortening the construction time tends to reduce the search performances."}}
{"actor":{"display_login":"masajiro"}}