{"action":"opened","number":98,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/98","id":172402626,"html_url":"https://github.com/Microsoft/vscode-azuretools/pull/98","diff_url":"https://github.com/Microsoft/vscode-azuretools/pull/98.diff","patch_url":"https://github.com/Microsoft/vscode-azuretools/pull/98.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/98","number":98,"state":"open","locked":false,"title":"Fix zip ignore/glob settings","user":{"login":"EricJizbaMSFT","id":11282622,"avatar_url":"https://avatars2.githubusercontent.com/u/11282622?v=4","gravatar_id":"","url":"https://api.github.com/users/EricJizbaMSFT","html_url":"https://github.com/EricJizbaMSFT","followers_url":"https://api.github.com/users/EricJizbaMSFT/followers","following_url":"https://api.github.com/users/EricJizbaMSFT/following{/other_user}","gists_url":"https://api.github.com/users/EricJizbaMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/EricJizbaMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricJizbaMSFT/subscriptions","organizations_url":"https://api.github.com/users/EricJizbaMSFT/orgs","repos_url":"https://api.github.com/users/EricJizbaMSFT/repos","events_url":"https://api.github.com/users/EricJizbaMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/EricJizbaMSFT/received_events","type":"User","site_admin":false},"body":"1. The ignore setting can be a string or string array\r\n1. We have to pass in the folder path so that these settings work in multi-root workspace scenarios","created_at":"2018-03-02T01:48:09Z","updated_at":"2018-03-02T01:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/98/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/98/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/98/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/0aa4313cf5c3ec8cd77f5bbaceb433cbe9d059dd","head":{"label":"Microsoft:ej/zip","ref":"ej/zip","sha":"0aa4313cf5c3ec8cd77f5bbaceb433cbe9d059dd","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106758861,"name":"vscode-azuretools","full_name":"Microsoft/vscode-azuretools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azuretools","description":"Common packages for building Azure extensions for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azuretools","forks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/deployments","created_at":"2017-10-13T00:27:20Z","updated_at":"2018-02-20T08:12:48Z","pushed_at":"2018-03-02T01:42:53Z","git_url":"git://github.com/Microsoft/vscode-azuretools.git","ssh_url":"git@github.com:Microsoft/vscode-azuretools.git","clone_url":"https://github.com/Microsoft/vscode-azuretools.git","svn_url":"https://github.com/Microsoft/vscode-azuretools","homepage":null,"size":291,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":3,"open_issues":15,"watchers":7,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"a18ba6dbd5ba36bf1c2868d03386b97bd71d32b7","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":106758861,"name":"vscode-azuretools","full_name":"Microsoft/vscode-azuretools","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode-azuretools","description":"Common packages for building Azure extensions for VS Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode-azuretools","forks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode-azuretools/deployments","created_at":"2017-10-13T00:27:20Z","updated_at":"2018-02-20T08:12:48Z","pushed_at":"2018-03-02T01:42:53Z","git_url":"git://github.com/Microsoft/vscode-azuretools.git","ssh_url":"git@github.com:Microsoft/vscode-azuretools.git","clone_url":"https://github.com/Microsoft/vscode-azuretools.git","svn_url":"https://github.com/Microsoft/vscode-azuretools","homepage":null,"size":291,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":3,"open_issues":15,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/98"},"html":{"href":"https://github.com/Microsoft/vscode-azuretools/pull/98"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/98"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode-azuretools/statuses/0aa4313cf5c3ec8cd77f5bbaceb433cbe9d059dd"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"EricJizbaMSFT"}}