{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4314","repository_url":"https://api.github.com/repos/Azure/azure-quickstart-templates","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4314/labels{/name}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4314/comments","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4314/events","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4314","id":299978867,"number":4314,"title":"Remove unused parameter","user":{"login":"alexandair","id":3135708,"avatar_url":"https://avatars2.githubusercontent.com/u/3135708?v=4","gravatar_id":"","url":"https://api.github.com/users/alexandair","html_url":"https://github.com/alexandair","followers_url":"https://api.github.com/users/alexandair/followers","following_url":"https://api.github.com/users/alexandair/following{/other_user}","gists_url":"https://api.github.com/users/alexandair/gists{/gist_id}","starred_url":"https://api.github.com/users/alexandair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexandair/subscriptions","organizations_url":"https://api.github.com/users/alexandair/orgs","repos_url":"https://api.github.com/users/alexandair/repos","events_url":"https://api.github.com/users/alexandair/events{/privacy}","received_events_url":"https://api.github.com/users/alexandair/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-24T22:36:57Z","updated_at":"2018-03-02T22:51:12Z","closed_at":"2018-03-02T22:51:12Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/4314","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4314","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/4314.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/4314.patch"},"body":"vmName parameter is not used in the template.\r\n\r\n### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources.  While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [x] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n* Removed unused vmName parameter.\r\n*\r\n*\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments/370076279","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/4314#issuecomment-370076279","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/4314","id":370076279,"user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars1.githubusercontent.com/u/10090014?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T22:51:12Z","updated_at":"2018-03-02T22:51:12Z","author_association":"COLLABORATOR","body":"CI will use the param file in the branch - the problem in this case is you removed the param from the param file but it's required by the template (even if it's not used, it's still defined).  I'm going to close the PR, feel free to reopen if you get it working..."}}
{"actor":{"display_login":"bmoore-msft"}}