{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/166471156","pull_request_review_id":94528495,"id":166471156,"diff_hunk":"@@ -1056,34 +1085,33 @@ class Table(val hc: HailContext, val ir: TableIR) {\n \n   def collect(): IndexedSeq[Row] = rdd.collect()\n \n-  def write(path: String, overwrite: Boolean = false) {\n-    if (!path.endsWith(\".kt\") && !path.endsWith(\".kt/\"))\n-      fatal(s\"write path must end in '.kt', but found '$path'\")\n+  def write(path: String, overwrite: Boolean = false, codecSpecJSONStr: String = null) {","path":"src/main/scala/is/hail/table/Table.scala","position":283,"original_position":283,"commit_id":"6f4e35ecfa819cc35c298099725acba86efd9677","original_commit_id":"6f4e35ecfa819cc35c298099725acba86efd9677","user":{"login":"danking","id":106194,"avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"body":"This isn't a performance critical place, we generally have preferred explicit option types over relying on the nullability of reference types.","created_at":"2018-02-06T23:04:02Z","updated_at":"2018-02-06T23:09:04Z","html_url":"https://github.com/hail-is/hail/pull/2859#discussion_r166471156","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/2859","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/166471156"},"html":{"href":"https://github.com/hail-is/hail/pull/2859#discussion_r166471156"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/2859"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/2859","id":167031430,"html_url":"https://github.com/hail-is/hail/pull/2859","diff_url":"https://github.com/hail-is/hail/pull/2859.diff","patch_url":"https://github.com/hail-is/hail/pull/2859.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/2859","number":2859,"state":"open","locked":false,"title":"parameterize en/decoder","user":{"login":"cseed","id":1244990,"avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"body":" - made decoder stuff modular/composable\r\n - CodecSpec, stored in RVDSpec (and hence in metadata) describes the en/decoding process\r\n - exposed to Python (private parameter in MT and Table.write)\r\n","created_at":"2018-02-04T21:37:42Z","updated_at":"2018-02-06T23:09:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61af9c89d99a2f89bbe127ca1c66d433e746a401","assignee":{"login":"danking","id":106194,"avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"assignees":[{"login":"danking","id":106194,"avatar_url":"https://avatars2.githubusercontent.com/u/106194?v=4","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/2859/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/2859/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/2859/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/6f4e35ecfa819cc35c298099725acba86efd9677","head":{"label":"cseed:codecspec","ref":"codecspec","sha":"6f4e35ecfa819cc35c298099725acba86efd9677","user":{"login":"cseed","id":1244990,"avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"repo":{"id":64697338,"name":"hail","full_name":"cseed/hail","owner":{"login":"cseed","id":1244990,"avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cseed/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/cseed/hail","forks_url":"https://api.github.com/repos/cseed/hail/forks","keys_url":"https://api.github.com/repos/cseed/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cseed/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cseed/hail/teams","hooks_url":"https://api.github.com/repos/cseed/hail/hooks","issue_events_url":"https://api.github.com/repos/cseed/hail/issues/events{/number}","events_url":"https://api.github.com/repos/cseed/hail/events","assignees_url":"https://api.github.com/repos/cseed/hail/assignees{/user}","branches_url":"https://api.github.com/repos/cseed/hail/branches{/branch}","tags_url":"https://api.github.com/repos/cseed/hail/tags","blobs_url":"https://api.github.com/repos/cseed/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cseed/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cseed/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/cseed/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cseed/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/cseed/hail/languages","stargazers_url":"https://api.github.com/repos/cseed/hail/stargazers","contributors_url":"https://api.github.com/repos/cseed/hail/contributors","subscribers_url":"https://api.github.com/repos/cseed/hail/subscribers","subscription_url":"https://api.github.com/repos/cseed/hail/subscription","commits_url":"https://api.github.com/repos/cseed/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/cseed/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/cseed/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/cseed/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/cseed/hail/contents/{+path}","compare_url":"https://api.github.com/repos/cseed/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cseed/hail/merges","archive_url":"https://api.github.com/repos/cseed/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cseed/hail/downloads","issues_url":"https://api.github.com/repos/cseed/hail/issues{/number}","pulls_url":"https://api.github.com/repos/cseed/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/cseed/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/cseed/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cseed/hail/labels{/name}","releases_url":"https://api.github.com/repos/cseed/hail/releases{/id}","deployments_url":"https://api.github.com/repos/cseed/hail/deployments","created_at":"2016-08-01T19:57:20Z","updated_at":"2016-08-01T19:57:22Z","pushed_at":"2018-02-06T05:13:50Z","git_url":"git://github.com/cseed/hail.git","ssh_url":"git@github.com:cseed/hail.git","clone_url":"https://github.com/cseed/hail.git","svn_url":"https://github.com/cseed/hail","homepage":"","size":32900,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:breaking","ref":"breaking","sha":"633a4bb7dfa6b0a38d92d02926cc3660d764a6f0","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-02-06T17:14:51Z","pushed_at":"2018-02-06T23:08:09Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":30581,"stargazers_count":289,"watchers_count":289,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":92,"open_issues":123,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/2859"},"html":{"href":"https://github.com/hail-is/hail/pull/2859"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/2859"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/2859/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/2859/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/2859/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/6f4e35ecfa819cc35c298099725acba86efd9677"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"danking"}}