{"action":"created","comment":{"url":"https://api.github.com/repos/openebs/istgt/pulls/comments/195895998","pull_request_review_id":129356037,"id":195895998,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTg5NTk5OA==","diff_hunk":"@@ -2633,6 +2643,38 @@ void *timerfn(void *ptr __attribute__((__unused__)))\n \t\t}\n \t\twhile((conn = (CONN *)(istgt_queue_dequeue(&backupconns))) != NULL)\n \t\t\tistgt_queue_enqueue(&closedconns, conn);\n+\n+\t\tclock_gettime(clockid, &now);\n+\t\ttimesdiff(clockid, last_check, now, diff);\n+\t\tms = diff.tv_sec * 1000;\n+\t\tms += diff.tv_nsec / 1000000;\n+\n+\t\tif (ms > check_interval1) {\n+\t\t\tcheck_interval1 = check_interval2;","path":"src/istgt.c","position":35,"original_position":35,"commit_id":"8c08718e2d6d0f7b8210d83a8d5739a228c4dad9","original_commit_id":"8c08718e2d6d0f7b8210d83a8d5739a228c4dad9","user":{"login":"vishnuitta","id":25415415,"node_id":"MDQ6VXNlcjI1NDE1NDE1","avatar_url":"https://avatars2.githubusercontent.com/u/25415415?v=4","gravatar_id":"","url":"https://api.github.com/users/vishnuitta","html_url":"https://github.com/vishnuitta","followers_url":"https://api.github.com/users/vishnuitta/followers","following_url":"https://api.github.com/users/vishnuitta/following{/other_user}","gists_url":"https://api.github.com/users/vishnuitta/gists{/gist_id}","starred_url":"https://api.github.com/users/vishnuitta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishnuitta/subscriptions","organizations_url":"https://api.github.com/users/vishnuitta/orgs","repos_url":"https://api.github.com/users/vishnuitta/repos","events_url":"https://api.github.com/users/vishnuitta/events{/privacy}","received_events_url":"https://api.github.com/users/vishnuitta/received_events","type":"User","site_admin":false},"body":"why do we need check_interval2? can you put some comments in the logic?\r\nAlso, put some comments in data_conn.c for logic.","created_at":"2018-06-16T06:39:06Z","updated_at":"2018-06-16T06:39:07Z","html_url":"https://github.com/openebs/istgt/pull/39#discussion_r195895998","pull_request_url":"https://api.github.com/repos/openebs/istgt/pulls/39","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openebs/istgt/pulls/comments/195895998"},"html":{"href":"https://github.com/openebs/istgt/pull/39#discussion_r195895998"},"pull_request":{"href":"https://api.github.com/repos/openebs/istgt/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/openebs/istgt/pulls/39","id":194639532,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NjM5NTMy","html_url":"https://github.com/openebs/istgt/pull/39","diff_url":"https://github.com/openebs/istgt/pull/39.diff","patch_url":"https://github.com/openebs/istgt/pull/39.patch","issue_url":"https://api.github.com/repos/openebs/istgt/issues/39","number":39,"state":"open","locked":false,"title":"TA637 : debug logs for replica interface","user":{"login":"mynktl","id":33252549,"node_id":"MDQ6VXNlcjMzMjUyNTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/33252549?v=4","gravatar_id":"","url":"https://api.github.com/users/mynktl","html_url":"https://github.com/mynktl","followers_url":"https://api.github.com/users/mynktl/followers","following_url":"https://api.github.com/users/mynktl/following{/other_user}","gists_url":"https://api.github.com/users/mynktl/gists{/gist_id}","starred_url":"https://api.github.com/users/mynktl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mynktl/subscriptions","organizations_url":"https://api.github.com/users/mynktl/orgs","repos_url":"https://api.github.com/users/mynktl/repos","events_url":"https://api.github.com/users/mynktl/events{/privacy}","received_events_url":"https://api.github.com/users/mynktl/received_events","type":"User","site_admin":false},"body":"**Added debug logs for replica interface**\r\n from log, replica can be identified using `replica(zvol_guid)` or `replica(replica_ip:replica_port)`\r\n\r\n       ","created_at":"2018-06-13T16:08:16Z","updated_at":"2018-06-16T06:39:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1e54b5c4f0ef33b5ab47653c93a5b9f58d7eda7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"payes","id":10355850,"node_id":"MDQ6VXNlcjEwMzU1ODUw","avatar_url":"https://avatars3.githubusercontent.com/u/10355850?v=4","gravatar_id":"","url":"https://api.github.com/users/payes","html_url":"https://github.com/payes","followers_url":"https://api.github.com/users/payes/followers","following_url":"https://api.github.com/users/payes/following{/other_user}","gists_url":"https://api.github.com/users/payes/gists{/gist_id}","starred_url":"https://api.github.com/users/payes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payes/subscriptions","organizations_url":"https://api.github.com/users/payes/orgs","repos_url":"https://api.github.com/users/payes/repos","events_url":"https://api.github.com/users/payes/events{/privacy}","received_events_url":"https://api.github.com/users/payes/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openebs/istgt/pulls/39/commits","review_comments_url":"https://api.github.com/repos/openebs/istgt/pulls/39/comments","review_comment_url":"https://api.github.com/repos/openebs/istgt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openebs/istgt/issues/39/comments","statuses_url":"https://api.github.com/repos/openebs/istgt/statuses/8c08718e2d6d0f7b8210d83a8d5739a228c4dad9","head":{"label":"mynktl:TA637","ref":"TA637","sha":"8c08718e2d6d0f7b8210d83a8d5739a228c4dad9","user":{"login":"mynktl","id":33252549,"node_id":"MDQ6VXNlcjMzMjUyNTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/33252549?v=4","gravatar_id":"","url":"https://api.github.com/users/mynktl","html_url":"https://github.com/mynktl","followers_url":"https://api.github.com/users/mynktl/followers","following_url":"https://api.github.com/users/mynktl/following{/other_user}","gists_url":"https://api.github.com/users/mynktl/gists{/gist_id}","starred_url":"https://api.github.com/users/mynktl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mynktl/subscriptions","organizations_url":"https://api.github.com/users/mynktl/orgs","repos_url":"https://api.github.com/users/mynktl/repos","events_url":"https://api.github.com/users/mynktl/events{/privacy}","received_events_url":"https://api.github.com/users/mynktl/received_events","type":"User","site_admin":false},"repo":{"id":127879765,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc4Nzk3NjU=","name":"istgt","full_name":"mynktl/istgt","owner":{"login":"mynktl","id":33252549,"node_id":"MDQ6VXNlcjMzMjUyNTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/33252549?v=4","gravatar_id":"","url":"https://api.github.com/users/mynktl","html_url":"https://github.com/mynktl","followers_url":"https://api.github.com/users/mynktl/followers","following_url":"https://api.github.com/users/mynktl/following{/other_user}","gists_url":"https://api.github.com/users/mynktl/gists{/gist_id}","starred_url":"https://api.github.com/users/mynktl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mynktl/subscriptions","organizations_url":"https://api.github.com/users/mynktl/orgs","repos_url":"https://api.github.com/users/mynktl/repos","events_url":"https://api.github.com/users/mynktl/events{/privacy}","received_events_url":"https://api.github.com/users/mynktl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mynktl/istgt","description":null,"fork":true,"url":"https://api.github.com/repos/mynktl/istgt","forks_url":"https://api.github.com/repos/mynktl/istgt/forks","keys_url":"https://api.github.com/repos/mynktl/istgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mynktl/istgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mynktl/istgt/teams","hooks_url":"https://api.github.com/repos/mynktl/istgt/hooks","issue_events_url":"https://api.github.com/repos/mynktl/istgt/issues/events{/number}","events_url":"https://api.github.com/repos/mynktl/istgt/events","assignees_url":"https://api.github.com/repos/mynktl/istgt/assignees{/user}","branches_url":"https://api.github.com/repos/mynktl/istgt/branches{/branch}","tags_url":"https://api.github.com/repos/mynktl/istgt/tags","blobs_url":"https://api.github.com/repos/mynktl/istgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mynktl/istgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mynktl/istgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mynktl/istgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mynktl/istgt/statuses/{sha}","languages_url":"https://api.github.com/repos/mynktl/istgt/languages","stargazers_url":"https://api.github.com/repos/mynktl/istgt/stargazers","contributors_url":"https://api.github.com/repos/mynktl/istgt/contributors","subscribers_url":"https://api.github.com/repos/mynktl/istgt/subscribers","subscription_url":"https://api.github.com/repos/mynktl/istgt/subscription","commits_url":"https://api.github.com/repos/mynktl/istgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mynktl/istgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mynktl/istgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mynktl/istgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mynktl/istgt/contents/{+path}","compare_url":"https://api.github.com/repos/mynktl/istgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mynktl/istgt/merges","archive_url":"https://api.github.com/repos/mynktl/istgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mynktl/istgt/downloads","issues_url":"https://api.github.com/repos/mynktl/istgt/issues{/number}","pulls_url":"https://api.github.com/repos/mynktl/istgt/pulls{/number}","milestones_url":"https://api.github.com/repos/mynktl/istgt/milestones{/number}","notifications_url":"https://api.github.com/repos/mynktl/istgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mynktl/istgt/labels{/name}","releases_url":"https://api.github.com/repos/mynktl/istgt/releases{/id}","deployments_url":"https://api.github.com/repos/mynktl/istgt/deployments","created_at":"2018-04-03T08:56:06Z","updated_at":"2018-04-03T08:56:08Z","pushed_at":"2018-06-15T09:27:32Z","git_url":"git://github.com/mynktl/istgt.git","ssh_url":"git@github.com:mynktl/istgt.git","clone_url":"https://github.com/mynktl/istgt.git","svn_url":"https://github.com/mynktl/istgt","homepage":null,"size":732,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openebs:replication","ref":"replication","sha":"b888b670f1be6d966c18f4b3dbce9df92be4a1d3","user":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"repo":{"id":123117757,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMxMTc3NTc=","name":"istgt","full_name":"openebs/istgt","owner":{"login":"openebs","id":20769039,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNzY5MDM5","avatar_url":"https://avatars0.githubusercontent.com/u/20769039?v=4","gravatar_id":"","url":"https://api.github.com/users/openebs","html_url":"https://github.com/openebs","followers_url":"https://api.github.com/users/openebs/followers","following_url":"https://api.github.com/users/openebs/following{/other_user}","gists_url":"https://api.github.com/users/openebs/gists{/gist_id}","starred_url":"https://api.github.com/users/openebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openebs/subscriptions","organizations_url":"https://api.github.com/users/openebs/orgs","repos_url":"https://api.github.com/users/openebs/repos","events_url":"https://api.github.com/users/openebs/events{/privacy}","received_events_url":"https://api.github.com/users/openebs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openebs/istgt","description":null,"fork":false,"url":"https://api.github.com/repos/openebs/istgt","forks_url":"https://api.github.com/repos/openebs/istgt/forks","keys_url":"https://api.github.com/repos/openebs/istgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openebs/istgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openebs/istgt/teams","hooks_url":"https://api.github.com/repos/openebs/istgt/hooks","issue_events_url":"https://api.github.com/repos/openebs/istgt/issues/events{/number}","events_url":"https://api.github.com/repos/openebs/istgt/events","assignees_url":"https://api.github.com/repos/openebs/istgt/assignees{/user}","branches_url":"https://api.github.com/repos/openebs/istgt/branches{/branch}","tags_url":"https://api.github.com/repos/openebs/istgt/tags","blobs_url":"https://api.github.com/repos/openebs/istgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openebs/istgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openebs/istgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/openebs/istgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openebs/istgt/statuses/{sha}","languages_url":"https://api.github.com/repos/openebs/istgt/languages","stargazers_url":"https://api.github.com/repos/openebs/istgt/stargazers","contributors_url":"https://api.github.com/repos/openebs/istgt/contributors","subscribers_url":"https://api.github.com/repos/openebs/istgt/subscribers","subscription_url":"https://api.github.com/repos/openebs/istgt/subscription","commits_url":"https://api.github.com/repos/openebs/istgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/openebs/istgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/openebs/istgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/openebs/istgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/openebs/istgt/contents/{+path}","compare_url":"https://api.github.com/repos/openebs/istgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openebs/istgt/merges","archive_url":"https://api.github.com/repos/openebs/istgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openebs/istgt/downloads","issues_url":"https://api.github.com/repos/openebs/istgt/issues{/number}","pulls_url":"https://api.github.com/repos/openebs/istgt/pulls{/number}","milestones_url":"https://api.github.com/repos/openebs/istgt/milestones{/number}","notifications_url":"https://api.github.com/repos/openebs/istgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openebs/istgt/labels{/name}","releases_url":"https://api.github.com/repos/openebs/istgt/releases{/id}","deployments_url":"https://api.github.com/repos/openebs/istgt/deployments","created_at":"2018-02-27T11:10:49Z","updated_at":"2018-06-12T15:21:46Z","pushed_at":"2018-06-16T06:19:49Z","git_url":"git://github.com/openebs/istgt.git","ssh_url":"git@github.com:openebs/istgt.git","clone_url":"https://github.com/openebs/istgt.git","svn_url":"https://github.com/openebs/istgt","homepage":null,"size":642,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openebs/istgt/pulls/39"},"html":{"href":"https://github.com/openebs/istgt/pull/39"},"issue":{"href":"https://api.github.com/repos/openebs/istgt/issues/39"},"comments":{"href":"https://api.github.com/repos/openebs/istgt/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/openebs/istgt/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/openebs/istgt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openebs/istgt/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/openebs/istgt/statuses/8c08718e2d6d0f7b8210d83a8d5739a228c4dad9"}},"author_association":"NONE"}}
{"actor":{"display_login":"vishnuitta"}}