{"action":"created","issue":{"url":"https://api.github.com/repos/theia-ide/theia/issues/2355","repository_url":"https://api.github.com/repos/theia-ide/theia","labels_url":"https://api.github.com/repos/theia-ide/theia/issues/2355/labels{/name}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/2355/comments","events_url":"https://api.github.com/repos/theia-ide/theia/issues/2355/events","html_url":"https://github.com/theia-ide/theia/pull/2355","id":340652676,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMDEyNjk5","number":2355,"title":"[preview/markdown] Fix reveal of source for empty regions","user":{"login":"AlexTugarev","id":914497,"node_id":"MDQ6VXNlcjkxNDQ5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/914497?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexTugarev","html_url":"https://github.com/AlexTugarev","followers_url":"https://api.github.com/users/AlexTugarev/followers","following_url":"https://api.github.com/users/AlexTugarev/following{/other_user}","gists_url":"https://api.github.com/users/AlexTugarev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexTugarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexTugarev/subscriptions","organizations_url":"https://api.github.com/users/AlexTugarev/orgs","repos_url":"https://api.github.com/users/AlexTugarev/repos","events_url":"https://api.github.com/users/AlexTugarev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexTugarev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-12T14:04:26Z","updated_at":"2018-07-13T12:49:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/2355","html_url":"https://github.com/theia-ide/theia/pull/2355","diff_url":"https://github.com/theia-ide/theia/pull/2355.diff","patch_url":"https://github.com/theia-ide/theia/pull/2355.patch"},"body":"- improves navigation started with double-click in preview widget\r\n- get rid of `throttle-debounce` (one lib is enough!)\r\n\r\nFixes #2322\r\n"},"comment":{"url":"https://api.github.com/repos/theia-ide/theia/issues/comments/404824009","html_url":"https://github.com/theia-ide/theia/pull/2355#issuecomment-404824009","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/2355","id":404824009,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDgyNDAwOQ==","user":{"login":"AlexTugarev","id":914497,"node_id":"MDQ6VXNlcjkxNDQ5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/914497?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexTugarev","html_url":"https://github.com/AlexTugarev","followers_url":"https://api.github.com/users/AlexTugarev/followers","following_url":"https://api.github.com/users/AlexTugarev/following{/other_user}","gists_url":"https://api.github.com/users/AlexTugarev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexTugarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexTugarev/subscriptions","organizations_url":"https://api.github.com/users/AlexTugarev/orgs","repos_url":"https://api.github.com/users/AlexTugarev/repos","events_url":"https://api.github.com/users/AlexTugarev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexTugarev/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T12:49:46Z","updated_at":"2018-07-13T12:49:46Z","author_association":"MEMBER","body":"> Quick question: when there is an md file, let's say with 20 empty lines. Where should be the cursor/selection when opening the Code Editor from the Preview (with the double-click)? Thanks!\r\n\r\n@kittaakos the mapping between source lines and rendered html is only a approximation. the generation of some opening tags is overridden to insert the line information, see [here](https://github.com/theia-ide/theia/blob/master/packages/preview/src/browser/markdown/markdown-preview-handler.ts#L218). in between of two annotated elements in the output, we can just approximate the line number.\r\n\r\nthe question about empty lines, well you already did answer that. just wanted to add, how it comes, that there would be no line information available.\r\n\r\n"}}
{"actor":{"display_login":"AlexTugarev"}}