{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63557","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63557/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63557/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63557/events","html_url":"https://github.com/kubernetes/kubernetes/pull/63557","id":321365573,"number":63557,"title":"apiserver: Fail if dry-run query param is specified","user":{"login":"apelisse","id":1929644,"avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-05-08T22:14:25Z","updated_at":"2018-05-14T18:42:49Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/63557","html_url":"https://github.com/kubernetes/kubernetes/pull/63557","diff_url":"https://github.com/kubernetes/kubernetes/pull/63557.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/63557.patch"},"body":"Adds a dry-run query parameter now that does nothing but reject the request. The sooner we have this check in master, the safer it will be for clients to send dry-run requests that are not going to be applied nonetheless.\r\n\r\nThis is lacking test and probably documentation. I'm not a 100% sure where to add these, please comment :-)"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/388921064","html_url":"https://github.com/kubernetes/kubernetes/pull/63557#issuecomment-388921064","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/63557","id":388921064,"user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T18:42:49Z","updated_at":"2018-05-14T18:42:49Z","author_association":"OWNER","body":"Thanks for putting the test like we discussed IRL :)\r\n\r\nI have one suggestion but I think it's optional.\r\n\r\nI think, given where you put the check, it's not possible to screw it up by doing start-up plumbing wrong, so there's no need to do an integration check.\r\n\r\nI'm not sure how to make this work for aggregated apiservers--we can't force people to upgrade. I will discuss in the issue.\r\n\r\n/lgtm\r\n/approve"}}
{"actor":{"display_login":"lavalamp"}}