{"action":"created","comment":{"url":"https://api.github.com/repos/rollerderby/scoreboard/pulls/comments/223207792","pull_request_review_id":162284807,"id":223207792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIwNzc5Mg==","diff_hunk":"@@ -384,8 +377,8 @@ protected boolean isMasterClock() {\n \tpublic static final int DEFAULT_MINIMUM_NUMBER = 1;\n \tpublic static final int DEFAULT_MAXIMUM_NUMBER = 999;\n \tpublic static final long DEFAULT_MINIMUM_TIME = 0;\n-\tpublic static final long DEFAULT_MAXIMUM_TIME = 3600000;\n-\tpublic static final boolean DEFAULT_DIRECTION = false;\n+\tpublic static final long DEFAULT_MAXIMUM_TIME = 3600000; // 60 minutes","path":"src/com/carolinarollergirls/scoreboard/defaults/DefaultClockModel.java","position":89,"original_position":89,"commit_id":"4439017904dbd182b68f9204dd73637dc7b47825","original_commit_id":"4439017904dbd182b68f9204dd73637dc7b47825","user":{"login":"frank-weinberg","id":34135287,"node_id":"MDQ6VXNlcjM0MTM1Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/34135287?v=4","gravatar_id":"","url":"https://api.github.com/users/frank-weinberg","html_url":"https://github.com/frank-weinberg","followers_url":"https://api.github.com/users/frank-weinberg/followers","following_url":"https://api.github.com/users/frank-weinberg/following{/other_user}","gists_url":"https://api.github.com/users/frank-weinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-weinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-weinberg/subscriptions","organizations_url":"https://api.github.com/users/frank-weinberg/orgs","repos_url":"https://api.github.com/users/frank-weinberg/repos","events_url":"https://api.github.com/users/frank-weinberg/events{/privacy}","received_events_url":"https://api.github.com/users/frank-weinberg/received_events","type":"User","site_admin":false},"body":"If you set your time to derby via \"Start game\" the maximum will be increased accordingly.","created_at":"2018-10-07T10:15:25Z","updated_at":"2018-10-07T10:15:25Z","html_url":"https://github.com/rollerderby/scoreboard/pull/176#discussion_r223207792","pull_request_url":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rollerderby/scoreboard/pulls/comments/223207792"},"html":{"href":"https://github.com/rollerderby/scoreboard/pull/176#discussion_r223207792"},"pull_request":{"href":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176"}},"in_reply_to_id":223205875},"pull_request":{"url":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176","id":220811492,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODExNDky","html_url":"https://github.com/rollerderby/scoreboard/pull/176","diff_url":"https://github.com/rollerderby/scoreboard/pull/176.diff","patch_url":"https://github.com/rollerderby/scoreboard/pull/176.patch","issue_url":"https://api.github.com/repos/rollerderby/scoreboard/issues/176","number":176,"state":"open","locked":false,"title":"Extend ruleset to support more game types","user":{"login":"frank-weinberg","id":34135287,"node_id":"MDQ6VXNlcjM0MTM1Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/34135287?v=4","gravatar_id":"","url":"https://api.github.com/users/frank-weinberg","html_url":"https://github.com/frank-weinberg","followers_url":"https://api.github.com/users/frank-weinberg/followers","following_url":"https://api.github.com/users/frank-weinberg/following{/other_user}","gists_url":"https://api.github.com/users/frank-weinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-weinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-weinberg/subscriptions","organizations_url":"https://api.github.com/users/frank-weinberg/orgs","repos_url":"https://api.github.com/users/frank-weinberg/repos","events_url":"https://api.github.com/users/frank-weinberg/events{/privacy}","received_events_url":"https://api.github.com/users/frank-weinberg/received_events","type":"User","site_admin":false},"body":"- Make the number of penalties that lead to foul out configurable (up to 9)\r\n- Add rules to select which types of timeout stop the period clock (if any)\r\n- Add rule that stops period clock if timeouts last longer than a given time\r\n- Support intermissions that are not all of the same length (and display the official score for more than 15 minutes on WFTDA sanctioned rules)\r\n- Allow to disable the automatic ending of jams after 2 minutes\r\n- Allow to enable automatic ending of team timeouts\r\n\r\nAlso remove rules for clock settings that are not sensible to change\r\n(e.g. minimum times, which should be kept at 0) and rename the remaining\r\nclock rules so they reflect the semantic of the rule (e.g. number of\r\nperiods) instead of the internal variable name (e.g.\r\nClock.Period.maximumNumber).\r\n\r\nUnder the hood:\r\n- Refer to rules and settings via constants\r\n- Add unit tests for non-default rule settings\r\n- Do not display the common prefix \"Rule.\" in the ruleset editor\r\n\r\ncloses #111 \r\ncloses #170 ","created_at":"2018-10-05T20:10:31Z","updated_at":"2018-10-07T10:15:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20d9ab339b9c807f5d31d8ccf8e16cff3d70ae6a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176/commits","review_comments_url":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176/comments","review_comment_url":"https://api.github.com/repos/rollerderby/scoreboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rollerderby/scoreboard/issues/176/comments","statuses_url":"https://api.github.com/repos/rollerderby/scoreboard/statuses/4439017904dbd182b68f9204dd73637dc7b47825","head":{"label":"frank-weinberg:rulesets","ref":"rulesets","sha":"4439017904dbd182b68f9204dd73637dc7b47825","user":{"login":"frank-weinberg","id":34135287,"node_id":"MDQ6VXNlcjM0MTM1Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/34135287?v=4","gravatar_id":"","url":"https://api.github.com/users/frank-weinberg","html_url":"https://github.com/frank-weinberg","followers_url":"https://api.github.com/users/frank-weinberg/followers","following_url":"https://api.github.com/users/frank-weinberg/following{/other_user}","gists_url":"https://api.github.com/users/frank-weinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-weinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-weinberg/subscriptions","organizations_url":"https://api.github.com/users/frank-weinberg/orgs","repos_url":"https://api.github.com/users/frank-weinberg/repos","events_url":"https://api.github.com/users/frank-weinberg/events{/privacy}","received_events_url":"https://api.github.com/users/frank-weinberg/received_events","type":"User","site_admin":false},"repo":{"id":112658260,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NTgyNjA=","name":"scoreboard","full_name":"frank-weinberg/scoreboard","private":false,"owner":{"login":"frank-weinberg","id":34135287,"node_id":"MDQ6VXNlcjM0MTM1Mjg3","avatar_url":"https://avatars1.githubusercontent.com/u/34135287?v=4","gravatar_id":"","url":"https://api.github.com/users/frank-weinberg","html_url":"https://github.com/frank-weinberg","followers_url":"https://api.github.com/users/frank-weinberg/followers","following_url":"https://api.github.com/users/frank-weinberg/following{/other_user}","gists_url":"https://api.github.com/users/frank-weinberg/gists{/gist_id}","starred_url":"https://api.github.com/users/frank-weinberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frank-weinberg/subscriptions","organizations_url":"https://api.github.com/users/frank-weinberg/orgs","repos_url":"https://api.github.com/users/frank-weinberg/repos","events_url":"https://api.github.com/users/frank-weinberg/events{/privacy}","received_events_url":"https://api.github.com/users/frank-weinberg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/frank-weinberg/scoreboard","description":"CRG Derby Scoreboard","fork":true,"url":"https://api.github.com/repos/frank-weinberg/scoreboard","forks_url":"https://api.github.com/repos/frank-weinberg/scoreboard/forks","keys_url":"https://api.github.com/repos/frank-weinberg/scoreboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frank-weinberg/scoreboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frank-weinberg/scoreboard/teams","hooks_url":"https://api.github.com/repos/frank-weinberg/scoreboard/hooks","issue_events_url":"https://api.github.com/repos/frank-weinberg/scoreboard/issues/events{/number}","events_url":"https://api.github.com/repos/frank-weinberg/scoreboard/events","assignees_url":"https://api.github.com/repos/frank-weinberg/scoreboard/assignees{/user}","branches_url":"https://api.github.com/repos/frank-weinberg/scoreboard/branches{/branch}","tags_url":"https://api.github.com/repos/frank-weinberg/scoreboard/tags","blobs_url":"https://api.github.com/repos/frank-weinberg/scoreboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frank-weinberg/scoreboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frank-weinberg/scoreboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/frank-weinberg/scoreboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frank-weinberg/scoreboard/statuses/{sha}","languages_url":"https://api.github.com/repos/frank-weinberg/scoreboard/languages","stargazers_url":"https://api.github.com/repos/frank-weinberg/scoreboard/stargazers","contributors_url":"https://api.github.com/repos/frank-weinberg/scoreboard/contributors","subscribers_url":"https://api.github.com/repos/frank-weinberg/scoreboard/subscribers","subscription_url":"https://api.github.com/repos/frank-weinberg/scoreboard/subscription","commits_url":"https://api.github.com/repos/frank-weinberg/scoreboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/frank-weinberg/scoreboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/frank-weinberg/scoreboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/frank-weinberg/scoreboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/frank-weinberg/scoreboard/contents/{+path}","compare_url":"https://api.github.com/repos/frank-weinberg/scoreboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frank-weinberg/scoreboard/merges","archive_url":"https://api.github.com/repos/frank-weinberg/scoreboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frank-weinberg/scoreboard/downloads","issues_url":"https://api.github.com/repos/frank-weinberg/scoreboard/issues{/number}","pulls_url":"https://api.github.com/repos/frank-weinberg/scoreboard/pulls{/number}","milestones_url":"https://api.github.com/repos/frank-weinberg/scoreboard/milestones{/number}","notifications_url":"https://api.github.com/repos/frank-weinberg/scoreboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frank-weinberg/scoreboard/labels{/name}","releases_url":"https://api.github.com/repos/frank-weinberg/scoreboard/releases{/id}","deployments_url":"https://api.github.com/repos/frank-weinberg/scoreboard/deployments","created_at":"2017-11-30T20:41:27Z","updated_at":"2018-10-06T20:25:57Z","pushed_at":"2018-10-06T20:30:17Z","git_url":"git://github.com/frank-weinberg/scoreboard.git","ssh_url":"git@github.com:frank-weinberg/scoreboard.git","clone_url":"https://github.com/frank-weinberg/scoreboard.git","svn_url":"https://github.com/frank-weinberg/scoreboard","homepage":"","size":66506,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"rollerderby:dev","ref":"dev","sha":"0a0474750064e213cc90d31e8866f7209a0a7256","user":{"login":"rollerderby","id":1960037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjAwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1960037?v=4","gravatar_id":"","url":"https://api.github.com/users/rollerderby","html_url":"https://github.com/rollerderby","followers_url":"https://api.github.com/users/rollerderby/followers","following_url":"https://api.github.com/users/rollerderby/following{/other_user}","gists_url":"https://api.github.com/users/rollerderby/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerderby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerderby/subscriptions","organizations_url":"https://api.github.com/users/rollerderby/orgs","repos_url":"https://api.github.com/users/rollerderby/repos","events_url":"https://api.github.com/users/rollerderby/events{/privacy}","received_events_url":"https://api.github.com/users/rollerderby/received_events","type":"Organization","site_admin":false},"repo":{"id":11660672,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY2MDY3Mg==","name":"scoreboard","full_name":"rollerderby/scoreboard","private":false,"owner":{"login":"rollerderby","id":1960037,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NjAwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1960037?v=4","gravatar_id":"","url":"https://api.github.com/users/rollerderby","html_url":"https://github.com/rollerderby","followers_url":"https://api.github.com/users/rollerderby/followers","following_url":"https://api.github.com/users/rollerderby/following{/other_user}","gists_url":"https://api.github.com/users/rollerderby/gists{/gist_id}","starred_url":"https://api.github.com/users/rollerderby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rollerderby/subscriptions","organizations_url":"https://api.github.com/users/rollerderby/orgs","repos_url":"https://api.github.com/users/rollerderby/repos","events_url":"https://api.github.com/users/rollerderby/events{/privacy}","received_events_url":"https://api.github.com/users/rollerderby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rollerderby/scoreboard","description":"CRG Derby Scoreboard","fork":false,"url":"https://api.github.com/repos/rollerderby/scoreboard","forks_url":"https://api.github.com/repos/rollerderby/scoreboard/forks","keys_url":"https://api.github.com/repos/rollerderby/scoreboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rollerderby/scoreboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rollerderby/scoreboard/teams","hooks_url":"https://api.github.com/repos/rollerderby/scoreboard/hooks","issue_events_url":"https://api.github.com/repos/rollerderby/scoreboard/issues/events{/number}","events_url":"https://api.github.com/repos/rollerderby/scoreboard/events","assignees_url":"https://api.github.com/repos/rollerderby/scoreboard/assignees{/user}","branches_url":"https://api.github.com/repos/rollerderby/scoreboard/branches{/branch}","tags_url":"https://api.github.com/repos/rollerderby/scoreboard/tags","blobs_url":"https://api.github.com/repos/rollerderby/scoreboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rollerderby/scoreboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rollerderby/scoreboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/rollerderby/scoreboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rollerderby/scoreboard/statuses/{sha}","languages_url":"https://api.github.com/repos/rollerderby/scoreboard/languages","stargazers_url":"https://api.github.com/repos/rollerderby/scoreboard/stargazers","contributors_url":"https://api.github.com/repos/rollerderby/scoreboard/contributors","subscribers_url":"https://api.github.com/repos/rollerderby/scoreboard/subscribers","subscription_url":"https://api.github.com/repos/rollerderby/scoreboard/subscription","commits_url":"https://api.github.com/repos/rollerderby/scoreboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/rollerderby/scoreboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/rollerderby/scoreboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/rollerderby/scoreboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/rollerderby/scoreboard/contents/{+path}","compare_url":"https://api.github.com/repos/rollerderby/scoreboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rollerderby/scoreboard/merges","archive_url":"https://api.github.com/repos/rollerderby/scoreboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rollerderby/scoreboard/downloads","issues_url":"https://api.github.com/repos/rollerderby/scoreboard/issues{/number}","pulls_url":"https://api.github.com/repos/rollerderby/scoreboard/pulls{/number}","milestones_url":"https://api.github.com/repos/rollerderby/scoreboard/milestones{/number}","notifications_url":"https://api.github.com/repos/rollerderby/scoreboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rollerderby/scoreboard/labels{/name}","releases_url":"https://api.github.com/repos/rollerderby/scoreboard/releases{/id}","deployments_url":"https://api.github.com/repos/rollerderby/scoreboard/deployments","created_at":"2013-07-25T13:10:13Z","updated_at":"2018-10-06T20:25:28Z","pushed_at":"2018-10-07T09:32:42Z","git_url":"git://github.com/rollerderby/scoreboard.git","ssh_url":"git@github.com:rollerderby/scoreboard.git","clone_url":"https://github.com/rollerderby/scoreboard.git","svn_url":"https://github.com/rollerderby/scoreboard","homepage":"","size":66391,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":30,"watchers":44,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176"},"html":{"href":"https://github.com/rollerderby/scoreboard/pull/176"},"issue":{"href":"https://api.github.com/repos/rollerderby/scoreboard/issues/176"},"comments":{"href":"https://api.github.com/repos/rollerderby/scoreboard/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/rollerderby/scoreboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rollerderby/scoreboard/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/rollerderby/scoreboard/statuses/4439017904dbd182b68f9204dd73637dc7b47825"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"frank-weinberg"}}