{"action":"created","issue":{"url":"https://api.github.com/repos/Jean-Romain/RCSF/issues/4","repository_url":"https://api.github.com/repos/Jean-Romain/RCSF","labels_url":"https://api.github.com/repos/Jean-Romain/RCSF/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Jean-Romain/RCSF/issues/4/comments","events_url":"https://api.github.com/repos/Jean-Romain/RCSF/issues/4/events","html_url":"https://github.com/Jean-Romain/RCSF/issues/4","id":351646672,"node_id":"MDU6SXNzdWUzNTE2NDY2NzI=","number":4,"title":"Ready for release?","user":{"login":"Jean-Romain","id":3872279,"node_id":"MDQ6VXNlcjM4NzIyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3872279?v=4","gravatar_id":"","url":"https://api.github.com/users/Jean-Romain","html_url":"https://github.com/Jean-Romain","followers_url":"https://api.github.com/users/Jean-Romain/followers","following_url":"https://api.github.com/users/Jean-Romain/following{/other_user}","gists_url":"https://api.github.com/users/Jean-Romain/gists{/gist_id}","starred_url":"https://api.github.com/users/Jean-Romain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jean-Romain/subscriptions","organizations_url":"https://api.github.com/users/Jean-Romain/orgs","repos_url":"https://api.github.com/users/Jean-Romain/repos","events_url":"https://api.github.com/users/Jean-Romain/events{/privacy}","received_events_url":"https://api.github.com/users/Jean-Romain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jianboqi","id":1770654,"node_id":"MDQ6VXNlcjE3NzA2NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1770654?v=4","gravatar_id":"","url":"https://api.github.com/users/jianboqi","html_url":"https://github.com/jianboqi","followers_url":"https://api.github.com/users/jianboqi/followers","following_url":"https://api.github.com/users/jianboqi/following{/other_user}","gists_url":"https://api.github.com/users/jianboqi/gists{/gist_id}","starred_url":"https://api.github.com/users/jianboqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianboqi/subscriptions","organizations_url":"https://api.github.com/users/jianboqi/orgs","repos_url":"https://api.github.com/users/jianboqi/repos","events_url":"https://api.github.com/users/jianboqi/events{/privacy}","received_events_url":"https://api.github.com/users/jianboqi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jianboqi","id":1770654,"node_id":"MDQ6VXNlcjE3NzA2NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1770654?v=4","gravatar_id":"","url":"https://api.github.com/users/jianboqi","html_url":"https://github.com/jianboqi","followers_url":"https://api.github.com/users/jianboqi/followers","following_url":"https://api.github.com/users/jianboqi/following{/other_user}","gists_url":"https://api.github.com/users/jianboqi/gists{/gist_id}","starred_url":"https://api.github.com/users/jianboqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianboqi/subscriptions","organizations_url":"https://api.github.com/users/jianboqi/orgs","repos_url":"https://api.github.com/users/jianboqi/repos","events_url":"https://api.github.com/users/jianboqi/events{/privacy}","received_events_url":"https://api.github.com/users/jianboqi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2018-08-17T15:50:49Z","updated_at":"2018-08-22T08:14:18Z","closed_at":null,"author_association":"OWNER","body":"The package is almost ready to be released on CRAN\r\n\r\n- [x] C++ code passes `valgrid` tests\r\n- [x] Package passes `R CMD check`\r\n- [x] Modification of original C++ code to enable user abortion if the computation time is too long. f729fdb\r\n- [x] Remove `std::cout` code that is not allowed in R. Could be replaced by `Rcpp::Rcout` eventually. f729fdb\r\n- [ ] Check the documentation (spelling, correctness)\r\n- [ ] add a longer description in file DESCRIPTION in tag `Description:`\r\n\r\n@jianboqi could you please look at the two unchecked boxes? Thanks.\r\n\r\nAlso 3 important points to discuss:\r\n\r\n- the package has only one function. Is there some other features that could be exposed to R?\r\n- openMP? I can enable the support of openMP but to be honest I need to learn first. So is it really useful? Do you have benchmark? What is the gain? In other words is it really cost-effective to me to spend hours on this question?\r\n- progress bar. You commented the progress bar. I understand why. You don't actually know the progress because the number of iteration is not fixed. The algo can finish after 2 iterations or 100. Do you have a idea how we could estimate the progress? I think it is important because we are talking about systematically long computations\r\n"},"comment":{"url":"https://api.github.com/repos/Jean-Romain/RCSF/issues/comments/414950543","html_url":"https://github.com/Jean-Romain/RCSF/issues/4#issuecomment-414950543","issue_url":"https://api.github.com/repos/Jean-Romain/RCSF/issues/4","id":414950543,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDk1MDU0Mw==","user":{"login":"Jean-Romain","id":3872279,"node_id":"MDQ6VXNlcjM4NzIyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3872279?v=4","gravatar_id":"","url":"https://api.github.com/users/Jean-Romain","html_url":"https://github.com/Jean-Romain","followers_url":"https://api.github.com/users/Jean-Romain/followers","following_url":"https://api.github.com/users/Jean-Romain/following{/other_user}","gists_url":"https://api.github.com/users/Jean-Romain/gists{/gist_id}","starred_url":"https://api.github.com/users/Jean-Romain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jean-Romain/subscriptions","organizations_url":"https://api.github.com/users/Jean-Romain/orgs","repos_url":"https://api.github.com/users/Jean-Romain/repos","events_url":"https://api.github.com/users/Jean-Romain/events{/privacy}","received_events_url":"https://api.github.com/users/Jean-Romain/received_events","type":"User","site_admin":false},"created_at":"2018-08-22T08:14:18Z","updated_at":"2018-08-22T08:14:18Z","author_association":"OWNER","body":"Great. I also shorten the description to fit better with a classical package description. I think everything looks good now."}}
{"actor":{"display_login":"Jean-Romain"}}