{"action":"created","issue":{"url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2571","repository_url":"https://api.github.com/repos/elixir-ecto/ecto","labels_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2571/labels{/name}","comments_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2571/comments","events_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2571/events","html_url":"https://github.com/elixir-ecto/ecto/issues/2571","id":327111033,"number":2571,"title":"Ditch compile-time config","user":{"login":"michalmuskala","id":477062,"avatar_url":"https://avatars0.githubusercontent.com/u/477062?v=4","gravatar_id":"","url":"https://api.github.com/users/michalmuskala","html_url":"https://github.com/michalmuskala","followers_url":"https://api.github.com/users/michalmuskala/followers","following_url":"https://api.github.com/users/michalmuskala/following{/other_user}","gists_url":"https://api.github.com/users/michalmuskala/gists{/gist_id}","starred_url":"https://api.github.com/users/michalmuskala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalmuskala/subscriptions","organizations_url":"https://api.github.com/users/michalmuskala/orgs","repos_url":"https://api.github.com/users/michalmuskala/repos","events_url":"https://api.github.com/users/michalmuskala/events{/privacy}","received_events_url":"https://api.github.com/users/michalmuskala/received_events","type":"User","site_admin":false},"labels":[{"id":48484338,"url":"https://api.github.com/repos/elixir-ecto/ecto/labels/Kind:Chore","name":"Kind:Chore","color":"006b75","default":false},{"id":169894583,"url":"https://api.github.com/repos/elixir-ecto/ecto/labels/Level:Intermediate","name":"Level:Intermediate","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-28T20:22:46Z","updated_at":"2018-05-29T09:38:55Z","closed_at":null,"author_association":"MEMBER","body":"Today the only two compile-time values are adapter and loggers. \r\n\r\nWe need the adapter because it might do some code generation. This can be solved, by recommending that the adapter is passed directly to `use Ecto.Repo` call instead of passing it through config. This is already possible today, but should be promoted as a default.\r\n\r\nThe other compile-time value is `loggers` - we read it at compile-time to minimise the cost of logging. Doing it at runtime, though should be only marginally less efficient. This might require some measurements. It is also possible to pass this option directly to `use` today.\r\n\r\nRight now, even if all required compile-time options are passed to `use` directly, ecto still requires an empty config (e.g. `config :my_app, MyApp.Repo, []`). This shouldn't be necessary."},"comment":{"url":"https://api.github.com/repos/elixir-ecto/ecto/issues/comments/392715969","html_url":"https://github.com/elixir-ecto/ecto/issues/2571#issuecomment-392715969","issue_url":"https://api.github.com/repos/elixir-ecto/ecto/issues/2571","id":392715969,"user":{"login":"michalmuskala","id":477062,"avatar_url":"https://avatars0.githubusercontent.com/u/477062?v=4","gravatar_id":"","url":"https://api.github.com/users/michalmuskala","html_url":"https://github.com/michalmuskala","followers_url":"https://api.github.com/users/michalmuskala/followers","following_url":"https://api.github.com/users/michalmuskala/following{/other_user}","gists_url":"https://api.github.com/users/michalmuskala/gists{/gist_id}","starred_url":"https://api.github.com/users/michalmuskala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalmuskala/subscriptions","organizations_url":"https://api.github.com/users/michalmuskala/orgs","repos_url":"https://api.github.com/users/michalmuskala/repos","events_url":"https://api.github.com/users/michalmuskala/events{/privacy}","received_events_url":"https://api.github.com/users/michalmuskala/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T09:38:55Z","updated_at":"2018-05-29T09:38:55Z","author_association":"MEMBER","body":"We could always make `log` an overridable callback in repo. This would mean changing the mechanism completely, though."}}
{"actor":{"display_login":"michalmuskala"}}