{"action":"created","issue":{"url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1551","repository_url":"https://api.github.com/repos/habitat-sh/core-plans","labels_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1551/labels{/name}","comments_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1551/comments","events_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1551/events","html_url":"https://github.com/habitat-sh/core-plans/pull/1551","id":327414778,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMjE1ODgw","number":1551,"title":"[meson] Remove Meson's handling of rpath","user":{"login":"smacfarlane","id":36851,"node_id":"MDQ6VXNlcjM2ODUx","avatar_url":"https://avatars0.githubusercontent.com/u/36851?v=4","gravatar_id":"","url":"https://api.github.com/users/smacfarlane","html_url":"https://github.com/smacfarlane","followers_url":"https://api.github.com/users/smacfarlane/followers","following_url":"https://api.github.com/users/smacfarlane/following{/other_user}","gists_url":"https://api.github.com/users/smacfarlane/gists{/gist_id}","starred_url":"https://api.github.com/users/smacfarlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smacfarlane/subscriptions","organizations_url":"https://api.github.com/users/smacfarlane/orgs","repos_url":"https://api.github.com/users/smacfarlane/repos","events_url":"https://api.github.com/users/smacfarlane/events{/privacy}","received_events_url":"https://api.github.com/users/smacfarlane/received_events","type":"User","site_admin":false},"labels":[{"id":858243385,"node_id":"MDU6TGFiZWw4NTgyNDMzODU=","url":"https://api.github.com/repos/habitat-sh/core-plans/labels/T-DO-NOT-MERGE","name":"T-DO-NOT-MERGE","color":"d62f3f","default":false}],"state":"closed","locked":false,"assignee":{"login":"fnichol","id":261548,"node_id":"MDQ6VXNlcjI2MTU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/261548?v=4","gravatar_id":"","url":"https://api.github.com/users/fnichol","html_url":"https://github.com/fnichol","followers_url":"https://api.github.com/users/fnichol/followers","following_url":"https://api.github.com/users/fnichol/following{/other_user}","gists_url":"https://api.github.com/users/fnichol/gists{/gist_id}","starred_url":"https://api.github.com/users/fnichol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnichol/subscriptions","organizations_url":"https://api.github.com/users/fnichol/orgs","repos_url":"https://api.github.com/users/fnichol/repos","events_url":"https://api.github.com/users/fnichol/events{/privacy}","received_events_url":"https://api.github.com/users/fnichol/received_events","type":"User","site_admin":false},"assignees":[{"login":"fnichol","id":261548,"node_id":"MDQ6VXNlcjI2MTU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/261548?v=4","gravatar_id":"","url":"https://api.github.com/users/fnichol","html_url":"https://github.com/fnichol","followers_url":"https://api.github.com/users/fnichol/followers","following_url":"https://api.github.com/users/fnichol/following{/other_user}","gists_url":"https://api.github.com/users/fnichol/gists{/gist_id}","starred_url":"https://api.github.com/users/fnichol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnichol/subscriptions","organizations_url":"https://api.github.com/users/fnichol/orgs","repos_url":"https://api.github.com/users/fnichol/repos","events_url":"https://api.github.com/users/fnichol/events{/privacy}","received_events_url":"https://api.github.com/users/fnichol/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/habitat-sh/core-plans/milestones/6","html_url":"https://github.com/habitat-sh/core-plans/milestone/6","labels_url":"https://api.github.com/repos/habitat-sh/core-plans/milestones/6/labels","id":2936158,"node_id":"MDk6TWlsZXN0b25lMjkzNjE1OA==","number":6,"title":"Base Packages Refresh 2018.03","description":"","creator":{"login":"fnichol","id":261548,"node_id":"MDQ6VXNlcjI2MTU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/261548?v=4","gravatar_id":"","url":"https://api.github.com/users/fnichol","html_url":"https://github.com/fnichol","followers_url":"https://api.github.com/users/fnichol/followers","following_url":"https://api.github.com/users/fnichol/following{/other_user}","gists_url":"https://api.github.com/users/fnichol/gists{/gist_id}","starred_url":"https://api.github.com/users/fnichol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnichol/subscriptions","organizations_url":"https://api.github.com/users/fnichol/orgs","repos_url":"https://api.github.com/users/fnichol/repos","events_url":"https://api.github.com/users/fnichol/events{/privacy}","received_events_url":"https://api.github.com/users/fnichol/received_events","type":"User","site_admin":false},"open_issues":31,"closed_issues":83,"state":"open","created_at":"2017-11-24T21:40:29Z","updated_at":"2018-06-19T17:40:11Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-29T17:21:16Z","updated_at":"2018-06-19T17:40:11Z","closed_at":"2018-06-19T17:40:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/habitat-sh/core-plans/pulls/1551","html_url":"https://github.com/habitat-sh/core-plans/pull/1551","diff_url":"https://github.com/habitat-sh/core-plans/pull/1551.diff","patch_url":"https://github.com/habitat-sh/core-plans/pull/1551.patch"},"body":"Meson manipulates the rpath of binaries/libraries post-build and doesn't currently take into account LD_RUN_PATH.  This prevents software built with Meson in Habitat from being able to find the libraries needed after the artifact is generated. \r\n\r\nI first considered modifying the Meson source to handle our use case, but decided against it as I don't have much Python experience and modifying the code that is patching binaries and libraries felt very risky. It would have the upside of _just working_ from both Habitats and Mesons perspective\r\n\r\nThe next solution I considered, and the one I chose, is to patch out the code that modifies the rpath. I chose this since it allows builds to behave like all other Habitat builds. It has the downside of requiring plan authors to be aware of this, if the package they are building uses the `install_rpath` feature Meson provides. \r\n\r\nI also considered that plan authors would either need to patch `meson.build` to set the `install_rpath` correctly for their software, or utilize `patchelf` to set the rpath correctly for their software, but I feel  both of these put too much burden on plan developers.  \r\n\r\nUnfortunately, the solution I chose results in the following remaining in the RUNPATH as reported by readelf: `Library runpath: [$ORIGIN/src/shared:XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX:` .   I think this is safe to leave, and it unblocks the  base plans refresh (stage3: systemd , which uses meson), but we would want to revisit in the future. \r\n\r\nReference:\r\nhttps://github.com/mesonbuild/meson/issues/314\r\nhttps://github.com/mesonbuild/meson/issues/2567\r\n\r\nSigned-off-by: Scott Macfarlane <smacfarlane@chef.io>"},"comment":{"url":"https://api.github.com/repos/habitat-sh/core-plans/issues/comments/398484086","html_url":"https://github.com/habitat-sh/core-plans/pull/1551#issuecomment-398484086","issue_url":"https://api.github.com/repos/habitat-sh/core-plans/issues/1551","id":398484086,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQ4NDA4Ng==","user":{"login":"fnichol","id":261548,"node_id":"MDQ6VXNlcjI2MTU0OA==","avatar_url":"https://avatars2.githubusercontent.com/u/261548?v=4","gravatar_id":"","url":"https://api.github.com/users/fnichol","html_url":"https://github.com/fnichol","followers_url":"https://api.github.com/users/fnichol/followers","following_url":"https://api.github.com/users/fnichol/following{/other_user}","gists_url":"https://api.github.com/users/fnichol/gists{/gist_id}","starred_url":"https://api.github.com/users/fnichol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnichol/subscriptions","organizations_url":"https://api.github.com/users/fnichol/orgs","repos_url":"https://api.github.com/users/fnichol/repos","events_url":"https://api.github.com/users/fnichol/events{/privacy}","received_events_url":"https://api.github.com/users/fnichol/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T17:40:11Z","updated_at":"2018-06-19T17:40:11Z","author_association":"MEMBER","body":"We've merged #1210 which contains this work. Thanks again!!"}}
{"actor":{"display_login":"fnichol"}}