{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/166718217","pull_request_review_id":94826920,"id":166718217,"diff_hunk":"@@ -53,14 +53,25 @@ os::cmd::expect_success 'oc delete is myruby'\n os::cmd::expect_failure_and_text 'oc new-app https://github.com/openshift/nodejs-ex --strategy=docker' 'No Dockerfile was found'\n \n # repo related error message validation\n-os::cmd::expect_failure_and_text 'oc new-app mysql-persisten mysql' 'mysql-persisten as a local directory'\n-os::cmd::expect_failure_and_text 'oc new-app mysql-persisten mysql' 'mysql as a local directory'\n-os::cmd::expect_failure_and_text 'oc new-app --strategy=docker https://192.30.253.113/openshift/ruby-hello-world.git' 'as a Git repository URL:  '\n-os::cmd::expect_failure_and_text 'oc new-app https://www.google.com/openshift/nodejs-e' 'as a Git repository URL:  '\n-os::cmd::expect_failure_and_text 'oc new-app https://examplegit.com/openshift/nodejs-e' 'as a Git repository URL:  '\n-os::cmd::expect_failure_and_text 'oc new-build --strategy=docker https://192.30.253.113/openshift/ruby-hello-world.git' 'as a Git repository URL:  '\n-os::cmd::expect_failure_and_text 'oc new-build https://www.google.com/openshift/nodejs-e' 'as a Git repository URL:  '\n-os::cmd::expect_failure_and_text 'oc new-build https://examplegit.com/openshift/nodejs-e' 'as a Git repository URL:  '\n+# oc new-app mysql-persisten mysql reacts differently when run after oc cluster up; with cluster up, it\n+# finds the mysql-persistent template in the openshift namespace and cites a partial match, but in this test\n+# that namespace/template combo does not exist, and so falls back to the generic not match / unable to locate resource\n+#os::cmd::expect_failure_and_text 'oc new-app mysql-persisten mysql' 'only a partial match was found for'","path":"test/cmd/newapp.sh","position":15,"original_position":15,"commit_id":"cdebd14abc468c1207145e7e7ec30acb8fecf076","original_commit_id":"c9cd154fe704bd4df54225d78398448542d46016","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"so do we have any test coverage for partial matches?\r\n","created_at":"2018-02-07T18:53:41Z","updated_at":"2018-02-07T18:53:41Z","html_url":"https://github.com/openshift/origin/pull/18272#discussion_r166718217","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/18272","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/166718217"},"html":{"href":"https://github.com/openshift/origin/pull/18272#discussion_r166718217"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/18272"}},"in_reply_to_id":164894599},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/18272","id":164929708,"html_url":"https://github.com/openshift/origin/pull/18272","diff_url":"https://github.com/openshift/origin/pull/18272.diff","patch_url":"https://github.com/openshift/origin/pull/18272.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/18272","number":18272,"state":"open","locked":false,"title":"adjust newapp/newbuild error messages (arg classification vs. actual …","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"…processing\r\n\r\nFixes https://github.com/openshift/origin/issues/17925\r\n\r\n@openshift/sig-developer-experience ptal\r\n\r\nNow produces:\r\n\r\n```\r\ngmontero ~/go/src/github.com/openshift/origin  (new-app-bld-msgs)$ oc new-build --name imagesourcetest python~https://github.com/openshift-katacoda/blog-django-py --source-image xxx --source-image-path=yyy --dry-run\r\nerror: unable to locate resource for \"xxx\"\r\n\r\nThe 'oc new-build' command will match arguments to the following types:\r\n\r\n  1. Images tagged into image streams in the current project or the 'openshift' project\r\n     - if you don't specify a tag, we'll add ':latest'\r\n  2. Images in the Docker Hub, on remote registries, or on the local Docker engine\r\n  3. Git repository URLs or local paths that point to Git repositories\r\n\r\n--allow-missing-images can be used to force the use of an image that was not matched\r\n\r\nSee 'oc new-build -h' for examples.\r\n\r\n```","created_at":"2018-01-24T18:39:56Z","updated_at":"2018-02-07T18:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ec2d27d6d23112508b638a0f310afc4bdd7df31","assignee":null,"assignees":[],"requested_reviewers":[{"login":"soltysh","id":576341,"avatar_url":"https://avatars2.githubusercontent.com/u/576341?v=4","gravatar_id":"","url":"https://api.github.com/users/soltysh","html_url":"https://github.com/soltysh","followers_url":"https://api.github.com/users/soltysh/followers","following_url":"https://api.github.com/users/soltysh/following{/other_user}","gists_url":"https://api.github.com/users/soltysh/gists{/gist_id}","starred_url":"https://api.github.com/users/soltysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soltysh/subscriptions","organizations_url":"https://api.github.com/users/soltysh/orgs","repos_url":"https://api.github.com/users/soltysh/repos","events_url":"https://api.github.com/users/soltysh/events{/privacy}","received_events_url":"https://api.github.com/users/soltysh/received_events","type":"User","site_admin":false},{"login":"csrwng","id":5834976,"avatar_url":"https://avatars1.githubusercontent.com/u/5834976?v=4","gravatar_id":"","url":"https://api.github.com/users/csrwng","html_url":"https://github.com/csrwng","followers_url":"https://api.github.com/users/csrwng/followers","following_url":"https://api.github.com/users/csrwng/following{/other_user}","gists_url":"https://api.github.com/users/csrwng/gists{/gist_id}","starred_url":"https://api.github.com/users/csrwng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csrwng/subscriptions","organizations_url":"https://api.github.com/users/csrwng/orgs","repos_url":"https://api.github.com/users/csrwng/repos","events_url":"https://api.github.com/users/csrwng/events{/privacy}","received_events_url":"https://api.github.com/users/csrwng/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/18272/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/18272/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/18272/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/cdebd14abc468c1207145e7e7ec30acb8fecf076","head":{"label":"gabemontero:new-app-bld-msgs","ref":"new-app-bld-msgs","sha":"cdebd14abc468c1207145e7e7ec30acb8fecf076","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36941154,"name":"origin","full_name":"gabemontero/origin","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/gabemontero/origin","forks_url":"https://api.github.com/repos/gabemontero/origin/forks","keys_url":"https://api.github.com/repos/gabemontero/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/origin/teams","hooks_url":"https://api.github.com/repos/gabemontero/origin/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/origin/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/origin/events","assignees_url":"https://api.github.com/repos/gabemontero/origin/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/origin/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/origin/tags","blobs_url":"https://api.github.com/repos/gabemontero/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/origin/languages","stargazers_url":"https://api.github.com/repos/gabemontero/origin/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/origin/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/origin/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/origin/subscription","commits_url":"https://api.github.com/repos/gabemontero/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/origin/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/origin/merges","archive_url":"https://api.github.com/repos/gabemontero/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/origin/downloads","issues_url":"https://api.github.com/repos/gabemontero/origin/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/origin/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/origin/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/origin/deployments","created_at":"2015-06-05T15:48:08Z","updated_at":"2017-03-13T17:37:13Z","pushed_at":"2018-02-07T15:01:30Z","git_url":"git://github.com/gabemontero/origin.git","ssh_url":"git@github.com:gabemontero/origin.git","clone_url":"https://github.com/gabemontero/origin.git","svn_url":"https://github.com/gabemontero/origin","homepage":"http://www.openshift.org","size":947627,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"72136400e9ada27bdeee508e679cd5d1fd8f4c11","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2018-02-07T14:53:55Z","pushed_at":"2018-02-07T18:44:50Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":926297,"stargazers_count":4039,"watchers_count":4039,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2539,"mirror_url":null,"archived":false,"open_issues_count":1608,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2539,"open_issues":1608,"watchers":4039,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/18272"},"html":{"href":"https://github.com/openshift/origin/pull/18272"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/18272"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/18272/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/18272/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/18272/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/cdebd14abc468c1207145e7e7ec30acb8fecf076"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bparees"}}