{"action":"created","issue":{"url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/issues/114","repository_url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk","labels_url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/issues/114/comments","events_url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/issues/114/events","html_url":"https://github.com/codeplaysoftware/computecpp-sdk/pull/114","id":323197392,"number":114,"title":"Fix Windows tests","user":{"login":"psalz","id":791348,"avatar_url":"https://avatars1.githubusercontent.com/u/791348?v=4","gravatar_id":"","url":"https://api.github.com/users/psalz","html_url":"https://github.com/psalz","followers_url":"https://api.github.com/users/psalz/followers","following_url":"https://api.github.com/users/psalz/following{/other_user}","gists_url":"https://api.github.com/users/psalz/gists{/gist_id}","starred_url":"https://api.github.com/users/psalz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psalz/subscriptions","organizations_url":"https://api.github.com/users/psalz/orgs","repos_url":"https://api.github.com/users/psalz/repos","events_url":"https://api.github.com/users/psalz/events{/privacy}","received_events_url":"https://api.github.com/users/psalz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-15T12:33:03Z","updated_at":"2018-05-15T13:19:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/pulls/114","html_url":"https://github.com/codeplaysoftware/computecpp-sdk/pull/114","diff_url":"https://github.com/codeplaysoftware/computecpp-sdk/pull/114.diff","patch_url":"https://github.com/codeplaysoftware/computecpp-sdk/pull/114.patch"},"body":"This makes the tests compile (and pass) on Windows again.\r\n\r\nThe changes made:\r\n* Remove the `-fno-ms-compatibility` flag. Without this, Clang on Windows will report the following errors:\r\n    ```\r\n    error G30564CF7: use of undeclared identifier 'chdir'; did you mean '_chdir'?\r\n    error G30564CF7: use of undeclared identifier 'fdopen'\r\n    error G30564CF7: use of undeclared identifier 'read'\r\n    error G30564CF7: use of undeclared identifier 'write'\r\n    error G30564CF7: use of undeclared identifier 'close'\r\n    ```\r\n    See #113 for more information on this change.\r\n* Remove hardcoded Google Test library paths (such as `${gtest_BINARY_DIR}/libgtest.a`), and use CMake's cross-platform \"Threads\" instead of using `pthread` directly.\r\n* Finally, the C++ language version for the `legacy-pointer` tests is set from 11 to 14 (the project default). I'm not sure why this was set in the first place, as the tests seem to run just fine without it. However,  when compiling as C++11 on Windows, Clang will complain about missing trailing return types in some MS headers (e.g. `Microsoft Visual Studio 14.0\\VC\\include\\xstddef(732,2): error G90440305: 'auto' return without trailing return type; deduced return types are a C++14 extension`).\r\n\r\nAll tests are green on Windows, except for `vptr/offset.cc` in debug builds, which [is a known issue](https://github.com/codeplaysoftware/computecpp-sdk/issues/112#issuecomment-388954438).\r\n\r\nNote that I couldn't get the experimental `vptr/runtime.cc`  tests (enabled with `-DCOMPUTECPP_INTERFACE=1`) to run, so I didn't touch those.\r\n\r\nAll tests are also confirmed to still work on Linux (on Ubuntu 16.04, with a Tesla K20m via [pocl](https://github.com/pocl/pocl))."},"comment":{"url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/issues/comments/389163504","html_url":"https://github.com/codeplaysoftware/computecpp-sdk/pull/114#issuecomment-389163504","issue_url":"https://api.github.com/repos/codeplaysoftware/computecpp-sdk/issues/114","id":389163504,"user":{"login":"DuncanMcBain","id":5628152,"avatar_url":"https://avatars2.githubusercontent.com/u/5628152?v=4","gravatar_id":"","url":"https://api.github.com/users/DuncanMcBain","html_url":"https://github.com/DuncanMcBain","followers_url":"https://api.github.com/users/DuncanMcBain/followers","following_url":"https://api.github.com/users/DuncanMcBain/following{/other_user}","gists_url":"https://api.github.com/users/DuncanMcBain/gists{/gist_id}","starred_url":"https://api.github.com/users/DuncanMcBain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DuncanMcBain/subscriptions","organizations_url":"https://api.github.com/users/DuncanMcBain/orgs","repos_url":"https://api.github.com/users/DuncanMcBain/repos","events_url":"https://api.github.com/users/DuncanMcBain/events{/privacy}","received_events_url":"https://api.github.com/users/DuncanMcBain/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T13:19:23Z","updated_at":"2018-05-15T13:19:23Z","author_association":"MEMBER","body":"OK I reran it and it works. That either means we have a race condition somewhere or Travis is a little sketchy (and at the moment, I'm inclined to believe it is the latter, as local testing has never revealed any problems with this particular code)."}}
{"actor":{"display_login":"DuncanMcBain"}}