{"action":"created","comment":{"url":"https://api.github.com/repos/compsy/vsv/pulls/comments/224412268","pull_request_review_id":163769247,"id":224412268,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDQxMjI2OA==","diff_hunk":"@@ -0,0 +1,14 @@\n+const { environment } = require('@rails/webpacker')\n+const customConfig = require('./custom')\n+\n+// Set nested object prop using path notation\n+// environment.config.set('resolve.extensions', ['.foo', '.bar'])\n+// environment.config.set('output.filename', '[name].js')\n+\n+// Merge custom config\n+environment.config.merge(customConfig)","path":"config/webpack/environment.js","position":9,"original_position":9,"commit_id":"1d6646e7553831e6b0af008acb1273610a05371d","original_commit_id":"336f52f9a4ff94e633cd8d0a06106ec067081a79","user":{"login":"emerencia","id":607965,"node_id":"MDQ6VXNlcjYwNzk2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/607965?v=4","gravatar_id":"","url":"https://api.github.com/users/emerencia","html_url":"https://github.com/emerencia","followers_url":"https://api.github.com/users/emerencia/followers","following_url":"https://api.github.com/users/emerencia/following{/other_user}","gists_url":"https://api.github.com/users/emerencia/gists{/gist_id}","starred_url":"https://api.github.com/users/emerencia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerencia/subscriptions","organizations_url":"https://api.github.com/users/emerencia/orgs","repos_url":"https://api.github.com/users/emerencia/repos","events_url":"https://api.github.com/users/emerencia/events{/privacy}","received_events_url":"https://api.github.com/users/emerencia/received_events","type":"User","site_admin":false},"body":"Ja dat is een goede manier idd om ENV variableen in javascript te gooien.","created_at":"2018-10-11T11:31:36Z","updated_at":"2018-10-11T11:31:36Z","html_url":"https://github.com/compsy/vsv/pull/589#discussion_r224412268","pull_request_url":"https://api.github.com/repos/compsy/vsv/pulls/589","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/compsy/vsv/pulls/comments/224412268"},"html":{"href":"https://github.com/compsy/vsv/pull/589#discussion_r224412268"},"pull_request":{"href":"https://api.github.com/repos/compsy/vsv/pulls/589"}},"in_reply_to_id":224409729},"pull_request":{"url":"https://api.github.com/repos/compsy/vsv/pulls/589","id":221360775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMzYwNzc1","html_url":"https://github.com/compsy/vsv/pull/589","diff_url":"https://github.com/compsy/vsv/pull/589.diff","patch_url":"https://github.com/compsy/vsv/pull/589.patch","issue_url":"https://api.github.com/repos/compsy/vsv/issues/589","number":589,"state":"open","locked":false,"title":"Use webpacker","user":{"login":"emerencia","id":607965,"node_id":"MDQ6VXNlcjYwNzk2NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/607965?v=4","gravatar_id":"","url":"https://api.github.com/users/emerencia","html_url":"https://github.com/emerencia","followers_url":"https://api.github.com/users/emerencia/followers","following_url":"https://api.github.com/users/emerencia/following{/other_user}","gists_url":"https://api.github.com/users/emerencia/gists{/gist_id}","starred_url":"https://api.github.com/users/emerencia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emerencia/subscriptions","organizations_url":"https://api.github.com/users/emerencia/orgs","repos_url":"https://api.github.com/users/emerencia/repos","events_url":"https://api.github.com/users/emerencia/events{/privacy}","received_events_url":"https://api.github.com/users/emerencia/received_events","type":"User","site_admin":false},"body":"# Description of feature\r\n...\r\n\r\n# Checklist\r\n- [ ] (If applicable) added example values of new ENV variables to .env.local and explained them in README.md.\r\n- [ ] Added unit tests to test the code.\r\n- [ ] Added integration tests to test the code within the application as a whole.\r\n","created_at":"2018-10-09T09:07:25Z","updated_at":"2018-10-11T11:31:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf3e211e34c632664a4f17fc0f5fcfb94b2c48c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compsy/vsv/pulls/589/commits","review_comments_url":"https://api.github.com/repos/compsy/vsv/pulls/589/comments","review_comment_url":"https://api.github.com/repos/compsy/vsv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compsy/vsv/issues/589/comments","statuses_url":"https://api.github.com/repos/compsy/vsv/statuses/1d6646e7553831e6b0af008acb1273610a05371d","head":{"label":"compsy:ae-react","ref":"ae-react","sha":"1d6646e7553831e6b0af008acb1273610a05371d","user":{"login":"compsy","id":18190172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTkwMTcy","avatar_url":"https://avatars3.githubusercontent.com/u/18190172?v=4","gravatar_id":"","url":"https://api.github.com/users/compsy","html_url":"https://github.com/compsy","followers_url":"https://api.github.com/users/compsy/followers","following_url":"https://api.github.com/users/compsy/following{/other_user}","gists_url":"https://api.github.com/users/compsy/gists{/gist_id}","starred_url":"https://api.github.com/users/compsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compsy/subscriptions","organizations_url":"https://api.github.com/users/compsy/orgs","repos_url":"https://api.github.com/users/compsy/repos","events_url":"https://api.github.com/users/compsy/events{/privacy}","received_events_url":"https://api.github.com/users/compsy/received_events","type":"Organization","site_admin":false},"repo":{"id":84442919,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ0MjkxOQ==","name":"vsv","full_name":"compsy/vsv","private":false,"owner":{"login":"compsy","id":18190172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTkwMTcy","avatar_url":"https://avatars3.githubusercontent.com/u/18190172?v=4","gravatar_id":"","url":"https://api.github.com/users/compsy","html_url":"https://github.com/compsy","followers_url":"https://api.github.com/users/compsy/followers","following_url":"https://api.github.com/users/compsy/following{/other_user}","gists_url":"https://api.github.com/users/compsy/gists{/gist_id}","starred_url":"https://api.github.com/users/compsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compsy/subscriptions","organizations_url":"https://api.github.com/users/compsy/orgs","repos_url":"https://api.github.com/users/compsy/repos","events_url":"https://api.github.com/users/compsy/events{/privacy}","received_events_url":"https://api.github.com/users/compsy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compsy/vsv","description":"Vroegtijdig School Verlaten Dagboekonderzoek","fork":false,"url":"https://api.github.com/repos/compsy/vsv","forks_url":"https://api.github.com/repos/compsy/vsv/forks","keys_url":"https://api.github.com/repos/compsy/vsv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compsy/vsv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compsy/vsv/teams","hooks_url":"https://api.github.com/repos/compsy/vsv/hooks","issue_events_url":"https://api.github.com/repos/compsy/vsv/issues/events{/number}","events_url":"https://api.github.com/repos/compsy/vsv/events","assignees_url":"https://api.github.com/repos/compsy/vsv/assignees{/user}","branches_url":"https://api.github.com/repos/compsy/vsv/branches{/branch}","tags_url":"https://api.github.com/repos/compsy/vsv/tags","blobs_url":"https://api.github.com/repos/compsy/vsv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compsy/vsv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compsy/vsv/git/refs{/sha}","trees_url":"https://api.github.com/repos/compsy/vsv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compsy/vsv/statuses/{sha}","languages_url":"https://api.github.com/repos/compsy/vsv/languages","stargazers_url":"https://api.github.com/repos/compsy/vsv/stargazers","contributors_url":"https://api.github.com/repos/compsy/vsv/contributors","subscribers_url":"https://api.github.com/repos/compsy/vsv/subscribers","subscription_url":"https://api.github.com/repos/compsy/vsv/subscription","commits_url":"https://api.github.com/repos/compsy/vsv/commits{/sha}","git_commits_url":"https://api.github.com/repos/compsy/vsv/git/commits{/sha}","comments_url":"https://api.github.com/repos/compsy/vsv/comments{/number}","issue_comment_url":"https://api.github.com/repos/compsy/vsv/issues/comments{/number}","contents_url":"https://api.github.com/repos/compsy/vsv/contents/{+path}","compare_url":"https://api.github.com/repos/compsy/vsv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compsy/vsv/merges","archive_url":"https://api.github.com/repos/compsy/vsv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compsy/vsv/downloads","issues_url":"https://api.github.com/repos/compsy/vsv/issues{/number}","pulls_url":"https://api.github.com/repos/compsy/vsv/pulls{/number}","milestones_url":"https://api.github.com/repos/compsy/vsv/milestones{/number}","notifications_url":"https://api.github.com/repos/compsy/vsv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compsy/vsv/labels{/name}","releases_url":"https://api.github.com/repos/compsy/vsv/releases{/id}","deployments_url":"https://api.github.com/repos/compsy/vsv/deployments","created_at":"2017-03-09T13:04:28Z","updated_at":"2018-10-10T13:57:11Z","pushed_at":"2018-10-11T11:23:26Z","git_url":"git://github.com/compsy/vsv.git","ssh_url":"git@github.com:compsy/vsv.git","clone_url":"https://github.com/compsy/vsv.git","svn_url":"https://github.com/compsy/vsv","homepage":null,"size":27036,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":21,"watchers":1,"default_branch":"master"}},"base":{"label":"compsy:master","ref":"master","sha":"50455e27ab86077314bd611617e1b9763fd2818f","user":{"login":"compsy","id":18190172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTkwMTcy","avatar_url":"https://avatars3.githubusercontent.com/u/18190172?v=4","gravatar_id":"","url":"https://api.github.com/users/compsy","html_url":"https://github.com/compsy","followers_url":"https://api.github.com/users/compsy/followers","following_url":"https://api.github.com/users/compsy/following{/other_user}","gists_url":"https://api.github.com/users/compsy/gists{/gist_id}","starred_url":"https://api.github.com/users/compsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compsy/subscriptions","organizations_url":"https://api.github.com/users/compsy/orgs","repos_url":"https://api.github.com/users/compsy/repos","events_url":"https://api.github.com/users/compsy/events{/privacy}","received_events_url":"https://api.github.com/users/compsy/received_events","type":"Organization","site_admin":false},"repo":{"id":84442919,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ0MjkxOQ==","name":"vsv","full_name":"compsy/vsv","private":false,"owner":{"login":"compsy","id":18190172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTkwMTcy","avatar_url":"https://avatars3.githubusercontent.com/u/18190172?v=4","gravatar_id":"","url":"https://api.github.com/users/compsy","html_url":"https://github.com/compsy","followers_url":"https://api.github.com/users/compsy/followers","following_url":"https://api.github.com/users/compsy/following{/other_user}","gists_url":"https://api.github.com/users/compsy/gists{/gist_id}","starred_url":"https://api.github.com/users/compsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compsy/subscriptions","organizations_url":"https://api.github.com/users/compsy/orgs","repos_url":"https://api.github.com/users/compsy/repos","events_url":"https://api.github.com/users/compsy/events{/privacy}","received_events_url":"https://api.github.com/users/compsy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compsy/vsv","description":"Vroegtijdig School Verlaten Dagboekonderzoek","fork":false,"url":"https://api.github.com/repos/compsy/vsv","forks_url":"https://api.github.com/repos/compsy/vsv/forks","keys_url":"https://api.github.com/repos/compsy/vsv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compsy/vsv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compsy/vsv/teams","hooks_url":"https://api.github.com/repos/compsy/vsv/hooks","issue_events_url":"https://api.github.com/repos/compsy/vsv/issues/events{/number}","events_url":"https://api.github.com/repos/compsy/vsv/events","assignees_url":"https://api.github.com/repos/compsy/vsv/assignees{/user}","branches_url":"https://api.github.com/repos/compsy/vsv/branches{/branch}","tags_url":"https://api.github.com/repos/compsy/vsv/tags","blobs_url":"https://api.github.com/repos/compsy/vsv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compsy/vsv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compsy/vsv/git/refs{/sha}","trees_url":"https://api.github.com/repos/compsy/vsv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compsy/vsv/statuses/{sha}","languages_url":"https://api.github.com/repos/compsy/vsv/languages","stargazers_url":"https://api.github.com/repos/compsy/vsv/stargazers","contributors_url":"https://api.github.com/repos/compsy/vsv/contributors","subscribers_url":"https://api.github.com/repos/compsy/vsv/subscribers","subscription_url":"https://api.github.com/repos/compsy/vsv/subscription","commits_url":"https://api.github.com/repos/compsy/vsv/commits{/sha}","git_commits_url":"https://api.github.com/repos/compsy/vsv/git/commits{/sha}","comments_url":"https://api.github.com/repos/compsy/vsv/comments{/number}","issue_comment_url":"https://api.github.com/repos/compsy/vsv/issues/comments{/number}","contents_url":"https://api.github.com/repos/compsy/vsv/contents/{+path}","compare_url":"https://api.github.com/repos/compsy/vsv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compsy/vsv/merges","archive_url":"https://api.github.com/repos/compsy/vsv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compsy/vsv/downloads","issues_url":"https://api.github.com/repos/compsy/vsv/issues{/number}","pulls_url":"https://api.github.com/repos/compsy/vsv/pulls{/number}","milestones_url":"https://api.github.com/repos/compsy/vsv/milestones{/number}","notifications_url":"https://api.github.com/repos/compsy/vsv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compsy/vsv/labels{/name}","releases_url":"https://api.github.com/repos/compsy/vsv/releases{/id}","deployments_url":"https://api.github.com/repos/compsy/vsv/deployments","created_at":"2017-03-09T13:04:28Z","updated_at":"2018-10-10T13:57:11Z","pushed_at":"2018-10-11T11:23:26Z","git_url":"git://github.com/compsy/vsv.git","ssh_url":"git@github.com:compsy/vsv.git","clone_url":"https://github.com/compsy/vsv.git","svn_url":"https://github.com/compsy/vsv","homepage":null,"size":27036,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":21,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/compsy/vsv/pulls/589"},"html":{"href":"https://github.com/compsy/vsv/pull/589"},"issue":{"href":"https://api.github.com/repos/compsy/vsv/issues/589"},"comments":{"href":"https://api.github.com/repos/compsy/vsv/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/compsy/vsv/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/compsy/vsv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compsy/vsv/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/compsy/vsv/statuses/1d6646e7553831e6b0af008acb1273610a05371d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"emerencia"}}