{"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/12","id":241494360,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDk0MzYw","html_url":"https://github.com/ArkEcosystem/swift-crypto/pull/12","diff_url":"https://github.com/ArkEcosystem/swift-crypto/pull/12.diff","patch_url":"https://github.com/ArkEcosystem/swift-crypto/pull/12.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/12","number":12,"state":"open","locked":false,"title":"fix: resolve issue with tx with 2nd signature and add tests","user":{"login":"ItsANameToo","id":35610748,"node_id":"MDQ6VXNlcjM1NjEwNzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/35610748?v=4","gravatar_id":"","url":"https://api.github.com/users/ItsANameToo","html_url":"https://github.com/ItsANameToo","followers_url":"https://api.github.com/users/ItsANameToo/followers","following_url":"https://api.github.com/users/ItsANameToo/following{/other_user}","gists_url":"https://api.github.com/users/ItsANameToo/gists{/gist_id}","starred_url":"https://api.github.com/users/ItsANameToo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ItsANameToo/subscriptions","organizations_url":"https://api.github.com/users/ItsANameToo/orgs","repos_url":"https://api.github.com/users/ItsANameToo/repos","events_url":"https://api.github.com/users/ItsANameToo/events{/privacy}","received_events_url":"https://api.github.com/users/ItsANameToo/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nSecond signature wasn't properly set so transactions with a second signature didn't go through. This PR also adds tests for the different builder options\r\n\r\n## Types of changes\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [x] Test (adding missing tests or fixing existing tests)\r\n\r\n## Checklist\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n\r\n## Further comments\r\n\r\nMaybe we should not include the Pods folder in the repo so changes will only be to related to the actual swift files. Reasoning before and against can be found [here](https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control)","created_at":"2018-12-30T14:41:13Z","updated_at":"2018-12-30T14:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/12/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/statuses/ff0df00f485b6e39b73ed700f1fc25c0dca2e224","head":{"label":"ArkEcosystem:fix/second-signature-signing","ref":"fix/second-signature-signing","sha":"ff0df00f485b6e39b73ed700f1fc25c0dca2e224","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":140371112,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzNzExMTI=","name":"swift-crypto","full_name":"ArkEcosystem/swift-crypto","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/swift-crypto","description":"A simple Cryptography Implementation in Swift for the ARK Blockchain.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/swift-crypto","forks_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/deployments","created_at":"2018-07-10T03:17:47Z","updated_at":"2018-12-29T17:51:02Z","pushed_at":"2018-12-30T14:38:32Z","git_url":"git://github.com/ArkEcosystem/swift-crypto.git","ssh_url":"git@github.com:ArkEcosystem/swift-crypto.git","clone_url":"https://github.com/ArkEcosystem/swift-crypto.git","svn_url":"https://github.com/ArkEcosystem/swift-crypto","homepage":"","size":470,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"ArkEcosystem:master","ref":"master","sha":"ae0f9d881729c50b227dc0dd17c9a3fe3a48f63b","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":140371112,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzNzExMTI=","name":"swift-crypto","full_name":"ArkEcosystem/swift-crypto","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/swift-crypto","description":"A simple Cryptography Implementation in Swift for the ARK Blockchain.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/swift-crypto","forks_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/swift-crypto/deployments","created_at":"2018-07-10T03:17:47Z","updated_at":"2018-12-29T17:51:02Z","pushed_at":"2018-12-30T14:38:32Z","git_url":"git://github.com/ArkEcosystem/swift-crypto.git","ssh_url":"git@github.com:ArkEcosystem/swift-crypto.git","clone_url":"https://github.com/ArkEcosystem/swift-crypto.git","svn_url":"https://github.com/ArkEcosystem/swift-crypto","homepage":"","size":470,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/12"},"html":{"href":"https://github.com/ArkEcosystem/swift-crypto/pull/12"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/12"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/swift-crypto/statuses/ff0df00f485b6e39b73ed700f1fc25c0dca2e224"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":447,"deletions":236,"changed_files":15}}
{"actor":{"display_login":"ItsANameToo"}}