{"action":"created","comment":{"url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/comments/172350287","pull_request_review_id":101352470,"id":172350287,"diff_hunk":"@@ -0,0 +1,36 @@\n+import WebSocket from 'ws'\n+import test from 'ava'\n+import openWebSocket from 'open-websocket'","path":"test/websocket-reconnect.js","position":3,"original_position":3,"commit_id":"dcab7d1d1d7a179dff505adf2996f98af3c06350","original_commit_id":"dcab7d1d1d7a179dff505adf2996f98af3c06350","user":{"login":"balthazar","id":6033345,"avatar_url":"https://avatars1.githubusercontent.com/u/6033345?v=4","gravatar_id":"","url":"https://api.github.com/users/balthazar","html_url":"https://github.com/balthazar","followers_url":"https://api.github.com/users/balthazar/followers","following_url":"https://api.github.com/users/balthazar/following{/other_user}","gists_url":"https://api.github.com/users/balthazar/gists{/gist_id}","starred_url":"https://api.github.com/users/balthazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balthazar/subscriptions","organizations_url":"https://api.github.com/users/balthazar/orgs","repos_url":"https://api.github.com/users/balthazar/repos","events_url":"https://api.github.com/users/balthazar/events{/privacy}","received_events_url":"https://api.github.com/users/balthazar/received_events","type":"User","site_admin":false},"body":"Add a newline on line 3","created_at":"2018-03-05T22:25:50Z","updated_at":"2018-03-05T22:25:59Z","html_url":"https://github.com/HyperCubeProject/binance-api-node/pull/49#discussion_r172350287","pull_request_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/comments/172350287"},"html":{"href":"https://github.com/HyperCubeProject/binance-api-node/pull/49#discussion_r172350287"},"pull_request":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49","id":171201582,"html_url":"https://github.com/HyperCubeProject/binance-api-node/pull/49","diff_url":"https://github.com/HyperCubeProject/binance-api-node/pull/49.diff","patch_url":"https://github.com/HyperCubeProject/binance-api-node/pull/49.patch","issue_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues/49","number":49,"state":"open","locked":false,"title":"Reconnecting WebSocket","user":{"login":"bennyn","id":469989,"avatar_url":"https://avatars3.githubusercontent.com/u/469989?v=4","gravatar_id":"","url":"https://api.github.com/users/bennyn","html_url":"https://github.com/bennyn","followers_url":"https://api.github.com/users/bennyn/followers","following_url":"https://api.github.com/users/bennyn/following{/other_user}","gists_url":"https://api.github.com/users/bennyn/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyn/subscriptions","organizations_url":"https://api.github.com/users/bennyn/orgs","repos_url":"https://api.github.com/users/bennyn/repos","events_url":"https://api.github.com/users/bennyn/events{/privacy}","received_events_url":"https://api.github.com/users/bennyn/received_events","type":"User","site_admin":false},"body":"In German we say \"aller guten Dinge sind drei\" which is a justification [for doing somethig a third time](https://en.wiktionary.org/wiki/aller_guten_Dinge_sind_drei). So here is yet **another reconnecting WebSocket** implementation. \r\n\r\nMy PR is based on the [reconnecting-websocket](https://github.com/pladaria/reconnecting-websocket) library. We are using that library at [Wire](https://wire.com/) to make sure that our messenger is always online (or at least tries to be!). So it's battle tested with Node.js and modern browsers. ⚔️\r\n\r\nI tested the reconnection myself but it would be great to have tests for it! Please let me know if you have an idea how to solve the testing best.\r\n\r\nThe `ReconnectingWebSocket` also provides an option called [reconnectionDelayGrowFactor](https://github.com/pladaria/reconnecting-websocket#default-options). Unfortunately, I was not able to set it because the linting rules forbid using identifier names longer than 25 characters (ESLint rule \"id-length\").","created_at":"2018-02-24T22:44:45Z","updated_at":"2018-03-05T22:25:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e2faef583decbc6c08dde7cb84aced5af333c5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":724909674,"url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/labels/enhancement","name":"enhancement","color":"0052cc","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49/commits","review_comments_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49/comments","review_comment_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues/49/comments","statuses_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/statuses/dcab7d1d1d7a179dff505adf2996f98af3c06350","head":{"label":"bennyn:rws","ref":"rws","sha":"dcab7d1d1d7a179dff505adf2996f98af3c06350","user":{"login":"bennyn","id":469989,"avatar_url":"https://avatars3.githubusercontent.com/u/469989?v=4","gravatar_id":"","url":"https://api.github.com/users/bennyn","html_url":"https://github.com/bennyn","followers_url":"https://api.github.com/users/bennyn/followers","following_url":"https://api.github.com/users/bennyn/following{/other_user}","gists_url":"https://api.github.com/users/bennyn/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyn/subscriptions","organizations_url":"https://api.github.com/users/bennyn/orgs","repos_url":"https://api.github.com/users/bennyn/repos","events_url":"https://api.github.com/users/bennyn/events{/privacy}","received_events_url":"https://api.github.com/users/bennyn/received_events","type":"User","site_admin":false},"repo":{"id":122743034,"name":"binance-api-node","full_name":"bennyn/binance-api-node","owner":{"login":"bennyn","id":469989,"avatar_url":"https://avatars3.githubusercontent.com/u/469989?v=4","gravatar_id":"","url":"https://api.github.com/users/bennyn","html_url":"https://github.com/bennyn","followers_url":"https://api.github.com/users/bennyn/followers","following_url":"https://api.github.com/users/bennyn/following{/other_user}","gists_url":"https://api.github.com/users/bennyn/gists{/gist_id}","starred_url":"https://api.github.com/users/bennyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bennyn/subscriptions","organizations_url":"https://api.github.com/users/bennyn/orgs","repos_url":"https://api.github.com/users/bennyn/repos","events_url":"https://api.github.com/users/bennyn/events{/privacy}","received_events_url":"https://api.github.com/users/bennyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bennyn/binance-api-node","description":":chart: A complete and heavily tested wrapper with typings for the Binance API.","fork":true,"url":"https://api.github.com/repos/bennyn/binance-api-node","forks_url":"https://api.github.com/repos/bennyn/binance-api-node/forks","keys_url":"https://api.github.com/repos/bennyn/binance-api-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bennyn/binance-api-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bennyn/binance-api-node/teams","hooks_url":"https://api.github.com/repos/bennyn/binance-api-node/hooks","issue_events_url":"https://api.github.com/repos/bennyn/binance-api-node/issues/events{/number}","events_url":"https://api.github.com/repos/bennyn/binance-api-node/events","assignees_url":"https://api.github.com/repos/bennyn/binance-api-node/assignees{/user}","branches_url":"https://api.github.com/repos/bennyn/binance-api-node/branches{/branch}","tags_url":"https://api.github.com/repos/bennyn/binance-api-node/tags","blobs_url":"https://api.github.com/repos/bennyn/binance-api-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bennyn/binance-api-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bennyn/binance-api-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bennyn/binance-api-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bennyn/binance-api-node/statuses/{sha}","languages_url":"https://api.github.com/repos/bennyn/binance-api-node/languages","stargazers_url":"https://api.github.com/repos/bennyn/binance-api-node/stargazers","contributors_url":"https://api.github.com/repos/bennyn/binance-api-node/contributors","subscribers_url":"https://api.github.com/repos/bennyn/binance-api-node/subscribers","subscription_url":"https://api.github.com/repos/bennyn/binance-api-node/subscription","commits_url":"https://api.github.com/repos/bennyn/binance-api-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bennyn/binance-api-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bennyn/binance-api-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bennyn/binance-api-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/bennyn/binance-api-node/contents/{+path}","compare_url":"https://api.github.com/repos/bennyn/binance-api-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bennyn/binance-api-node/merges","archive_url":"https://api.github.com/repos/bennyn/binance-api-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bennyn/binance-api-node/downloads","issues_url":"https://api.github.com/repos/bennyn/binance-api-node/issues{/number}","pulls_url":"https://api.github.com/repos/bennyn/binance-api-node/pulls{/number}","milestones_url":"https://api.github.com/repos/bennyn/binance-api-node/milestones{/number}","notifications_url":"https://api.github.com/repos/bennyn/binance-api-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bennyn/binance-api-node/labels{/name}","releases_url":"https://api.github.com/repos/bennyn/binance-api-node/releases{/id}","deployments_url":"https://api.github.com/repos/bennyn/binance-api-node/deployments","created_at":"2018-02-24T13:31:17Z","updated_at":"2018-02-24T13:31:18Z","pushed_at":"2018-03-05T21:53:08Z","git_url":"git://github.com/bennyn/binance-api-node.git","ssh_url":"git@github.com:bennyn/binance-api-node.git","clone_url":"https://github.com/bennyn/binance-api-node.git","svn_url":"https://github.com/bennyn/binance-api-node","homepage":"","size":148,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HyperCubeProject:master","ref":"master","sha":"6655aae47b4cae5e6a5917276c491c319c783b44","user":{"login":"HyperCubeProject","id":31024134,"avatar_url":"https://avatars2.githubusercontent.com/u/31024134?v=4","gravatar_id":"","url":"https://api.github.com/users/HyperCubeProject","html_url":"https://github.com/HyperCubeProject","followers_url":"https://api.github.com/users/HyperCubeProject/followers","following_url":"https://api.github.com/users/HyperCubeProject/following{/other_user}","gists_url":"https://api.github.com/users/HyperCubeProject/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperCubeProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperCubeProject/subscriptions","organizations_url":"https://api.github.com/users/HyperCubeProject/orgs","repos_url":"https://api.github.com/users/HyperCubeProject/repos","events_url":"https://api.github.com/users/HyperCubeProject/events{/privacy}","received_events_url":"https://api.github.com/users/HyperCubeProject/received_events","type":"Organization","site_admin":false},"repo":{"id":107566918,"name":"binance-api-node","full_name":"HyperCubeProject/binance-api-node","owner":{"login":"HyperCubeProject","id":31024134,"avatar_url":"https://avatars2.githubusercontent.com/u/31024134?v=4","gravatar_id":"","url":"https://api.github.com/users/HyperCubeProject","html_url":"https://github.com/HyperCubeProject","followers_url":"https://api.github.com/users/HyperCubeProject/followers","following_url":"https://api.github.com/users/HyperCubeProject/following{/other_user}","gists_url":"https://api.github.com/users/HyperCubeProject/gists{/gist_id}","starred_url":"https://api.github.com/users/HyperCubeProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyperCubeProject/subscriptions","organizations_url":"https://api.github.com/users/HyperCubeProject/orgs","repos_url":"https://api.github.com/users/HyperCubeProject/repos","events_url":"https://api.github.com/users/HyperCubeProject/events{/privacy}","received_events_url":"https://api.github.com/users/HyperCubeProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HyperCubeProject/binance-api-node","description":":chart: A complete and heavily tested wrapper with typings for the Binance API.","fork":false,"url":"https://api.github.com/repos/HyperCubeProject/binance-api-node","forks_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/forks","keys_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/teams","hooks_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/hooks","issue_events_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues/events{/number}","events_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/events","assignees_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/assignees{/user}","branches_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/branches{/branch}","tags_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/tags","blobs_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/statuses/{sha}","languages_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/languages","stargazers_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/stargazers","contributors_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/contributors","subscribers_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/subscribers","subscription_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/subscription","commits_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/contents/{+path}","compare_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/merges","archive_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/downloads","issues_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues{/number}","pulls_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls{/number}","milestones_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/milestones{/number}","notifications_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/labels{/name}","releases_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/releases{/id}","deployments_url":"https://api.github.com/repos/HyperCubeProject/binance-api-node/deployments","created_at":"2017-10-19T15:46:49Z","updated_at":"2018-03-05T06:36:30Z","pushed_at":"2018-03-05T21:53:10Z","git_url":"git://github.com/HyperCubeProject/binance-api-node.git","ssh_url":"git@github.com:HyperCubeProject/binance-api-node.git","clone_url":"https://github.com/HyperCubeProject/binance-api-node.git","svn_url":"https://github.com/HyperCubeProject/binance-api-node","homepage":"","size":135,"stargazers_count":50,"watchers_count":50,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":40,"open_issues":11,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49"},"html":{"href":"https://github.com/HyperCubeProject/binance-api-node/pull/49"},"issue":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues/49"},"comments":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/HyperCubeProject/binance-api-node/statuses/dcab7d1d1d7a179dff505adf2996f98af3c06350"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"balthazar"}}