{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/180267912","pull_request_review_id":110659836,"id":180267912,"diff_hunk":"@@ -396,8 +398,9 @@ cleanup()\n \n   # Check if the etcd is still running\n   [[ -n \"${ETCD_PID-}\" ]] && kube::etcd::stop\n-  [[ -n \"${ETCD_DIR-}\" ]] && kube::etcd::clean_etcd_dir\n-\n+  if [ \"${PRESERVE_ETCD}\" == \"false\" ]; then","path":"hack/local-up-cluster.sh","position":15,"original_position":15,"commit_id":"013d6b3a1b1fd83828984768ba5f454c841852af","original_commit_id":"013d6b3a1b1fd83828984768ba5f454c841852af","user":{"login":"ixdy","id":8061296,"avatar_url":"https://avatars3.githubusercontent.com/u/8061296?v=4","gravatar_id":"","url":"https://api.github.com/users/ixdy","html_url":"https://github.com/ixdy","followers_url":"https://api.github.com/users/ixdy/followers","following_url":"https://api.github.com/users/ixdy/following{/other_user}","gists_url":"https://api.github.com/users/ixdy/gists{/gist_id}","starred_url":"https://api.github.com/users/ixdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ixdy/subscriptions","organizations_url":"https://api.github.com/users/ixdy/orgs","repos_url":"https://api.github.com/users/ixdy/repos","events_url":"https://api.github.com/users/ixdy/events{/privacy}","received_events_url":"https://api.github.com/users/ixdy/received_events","type":"User","site_admin":false},"body":"nit: we prefer `[[ ]]` over `[ ]` for bash tests.","created_at":"2018-04-10T00:27:04Z","updated_at":"2018-04-10T00:27:04Z","html_url":"https://github.com/kubernetes/kubernetes/pull/61584#discussion_r180267912","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/180267912"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61584#discussion_r180267912"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584","id":176994443,"html_url":"https://github.com/kubernetes/kubernetes/pull/61584","diff_url":"https://github.com/kubernetes/kubernetes/pull/61584.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61584.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61584","number":61584,"state":"open","locked":false,"title":"local-up-cluster.sh: support preserving etcd optionally","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"\r\n\r\nSigned-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAllow `hack/local-up-cluster.sh` to support preserve `ETCD_DIR` when `PRESERVE` is set to non-false value.\r\n\r\nusage:\r\n```\r\n$ PRESERVE=true ETCD_DIR=/var/lib/etcd-kube-HEAD .... \\\r\n   ./hack/local-up-cluster.sh\r\n```\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\n(None)\r\n\r\n**Special notes for your reviewer**:\r\n(None)\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNone\r\n```\r\n","created_at":"2018-03-23T07:45:20Z","updated_at":"2018-04-10T00:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81b62a231c0bb8aea0fa4e96f9bffa44ff005d93","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450793,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61584/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/013d6b3a1b1fd83828984768ba5f454c841852af","head":{"label":"AkihiroSuda:preserve-etcd","ref":"preserve-etcd","sha":"013d6b3a1b1fd83828984768ba5f454c841852af","user":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"repo":{"id":104856260,"name":"kubernetes","full_name":"AkihiroSuda/kubernetes","owner":{"login":"AkihiroSuda","id":9248427,"avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AkihiroSuda/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/AkihiroSuda/kubernetes","forks_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/forks","keys_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/teams","hooks_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/events","assignees_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/tags","blobs_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/languages","stargazers_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/subscription","commits_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/merges","archive_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/downloads","issues_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/AkihiroSuda/kubernetes/deployments","created_at":"2017-09-26T08:15:41Z","updated_at":"2017-09-26T08:16:29Z","pushed_at":"2018-03-23T07:53:41Z","git_url":"git://github.com/AkihiroSuda/kubernetes.git","ssh_url":"git@github.com:AkihiroSuda/kubernetes.git","clone_url":"https://github.com/AkihiroSuda/kubernetes.git","svn_url":"https://github.com/AkihiroSuda/kubernetes","homepage":"http://kubernetes.io","size":541595,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"dce1b881284a103909f5cfa969ff56e5e0565362","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-10T00:20:51Z","pushed_at":"2018-04-10T00:21:35Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":769415,"stargazers_count":34836,"watchers_count":34836,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12335,"mirror_url":null,"archived":false,"open_issues_count":3433,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12335,"open_issues":3433,"watchers":34836,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61584"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61584"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61584/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61584/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/013d6b3a1b1fd83828984768ba5f454c841852af"}},"author_association":"NONE"}}
{"actor":{"display_login":"ixdy"}}