{"action":"created","comment":{"url":"https://api.github.com/repos/FFmpeg/FFV1/pulls/comments/222705157","pull_request_review_id":161656423,"id":222705157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjcwNTE1Nw==","diff_hunk":"@@ -186,19 +188,19 @@ a = b, a += b, a -= b, a *= b\n \n `get_bits( i )` is the action to read the next `i` bits in the bitstream, from most significant bit to least significant bit, and to return the corresponding value. The pointer is increased by `i`.\n \n-# General Description\n+# Sample Encoding\n \n-Samples within a plane are coded in raster scan order (left->right, top->bottom). Each sample is predicted by the median predictor from samples in the same plane and the difference is stored see [Coding of the Sample Difference](#coding-of-the-sample-difference).\n+For each `Slice` (as described in [the section on `Slices`](#slice)) of a `Frame`, the samples are coded in an order determined by the `colorspace_type` (see [the section on `colorspace_type`](#colorspacetype)). Each sample is predicted by the median predictor as described in [the section of the Median Predictor](#median-predictor) from other samples within the same plane and the difference is stored using the method described in [Coding of the Sample Difference](#coding-of-the-sample-difference).\n ","path":"ffv1.md","position":18,"original_position":18,"commit_id":"8cab54b17ca32955eb9cf845afdbec5104149da1","original_commit_id":"8cab54b17ca32955eb9cf845afdbec5104149da1","user":{"login":"dericed","id":762604,"node_id":"MDQ6VXNlcjc2MjYwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/762604?v=4","gravatar_id":"","url":"https://api.github.com/users/dericed","html_url":"https://github.com/dericed","followers_url":"https://api.github.com/users/dericed/followers","following_url":"https://api.github.com/users/dericed/following{/other_user}","gists_url":"https://api.github.com/users/dericed/gists{/gist_id}","starred_url":"https://api.github.com/users/dericed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dericed/subscriptions","organizations_url":"https://api.github.com/users/dericed/orgs","repos_url":"https://api.github.com/users/dericed/repos","events_url":"https://api.github.com/users/dericed/events{/privacy}","received_events_url":"https://api.github.com/users/dericed/received_events","type":"User","site_admin":false},"body":"I was concerned that `scan order (left->right, top->bottom)` was misleading since the samples are ordered like:\r\n- RGB is left->right, first plane->last plane, top->bottom\r\n- YCbCr is first plane->last plane, left->right, top->bottom\r\n","created_at":"2018-10-04T14:58:10Z","updated_at":"2018-10-04T14:58:10Z","html_url":"https://github.com/FFmpeg/FFV1/pull/130#discussion_r222705157","pull_request_url":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/FFmpeg/FFV1/pulls/comments/222705157"},"html":{"href":"https://github.com/FFmpeg/FFV1/pull/130#discussion_r222705157"},"pull_request":{"href":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130"}},"in_reply_to_id":222700916},"pull_request":{"url":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130","id":220168145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMTY4MTQ1","html_url":"https://github.com/FFmpeg/FFV1/pull/130","diff_url":"https://github.com/FFmpeg/FFV1/pull/130.diff","patch_url":"https://github.com/FFmpeg/FFV1/pull/130.patch","issue_url":"https://api.github.com/repos/FFmpeg/FFV1/issues/130","number":130,"state":"open","locked":false,"title":"More minor edits","user":{"login":"dericed","id":762604,"node_id":"MDQ6VXNlcjc2MjYwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/762604?v=4","gravatar_id":"","url":"https://api.github.com/users/dericed","html_url":"https://github.com/dericed","followers_url":"https://api.github.com/users/dericed/followers","following_url":"https://api.github.com/users/dericed/following{/other_user}","gists_url":"https://api.github.com/users/dericed/gists{/gist_id}","starred_url":"https://api.github.com/users/dericed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dericed/subscriptions","organizations_url":"https://api.github.com/users/dericed/orgs","repos_url":"https://api.github.com/users/dericed/repos","events_url":"https://api.github.com/users/dericed/events{/privacy}","received_events_url":"https://api.github.com/users/dericed/received_events","type":"User","site_admin":false},"body":"a mix of commits to add definition, make referenced concepts more consistent, and some rewording for clarity.","created_at":"2018-10-03T20:24:16Z","updated_at":"2018-10-04T14:58:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10db545e812e76dd1e44df0c755971f85ac3fc6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130/commits","review_comments_url":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130/comments","review_comment_url":"https://api.github.com/repos/FFmpeg/FFV1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FFmpeg/FFV1/issues/130/comments","statuses_url":"https://api.github.com/repos/FFmpeg/FFV1/statuses/8cab54b17ca32955eb9cf845afdbec5104149da1","head":{"label":"dericed:more-minor-edits","ref":"more-minor-edits","sha":"8cab54b17ca32955eb9cf845afdbec5104149da1","user":{"login":"dericed","id":762604,"node_id":"MDQ6VXNlcjc2MjYwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/762604?v=4","gravatar_id":"","url":"https://api.github.com/users/dericed","html_url":"https://github.com/dericed","followers_url":"https://api.github.com/users/dericed/followers","following_url":"https://api.github.com/users/dericed/following{/other_user}","gists_url":"https://api.github.com/users/dericed/gists{/gist_id}","starred_url":"https://api.github.com/users/dericed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dericed/subscriptions","organizations_url":"https://api.github.com/users/dericed/orgs","repos_url":"https://api.github.com/users/dericed/repos","events_url":"https://api.github.com/users/dericed/events{/privacy}","received_events_url":"https://api.github.com/users/dericed/received_events","type":"User","site_admin":false},"repo":{"id":12188639,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4ODYzOQ==","name":"FFV1","full_name":"dericed/FFV1","private":false,"owner":{"login":"dericed","id":762604,"node_id":"MDQ6VXNlcjc2MjYwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/762604?v=4","gravatar_id":"","url":"https://api.github.com/users/dericed","html_url":"https://github.com/dericed","followers_url":"https://api.github.com/users/dericed/followers","following_url":"https://api.github.com/users/dericed/following{/other_user}","gists_url":"https://api.github.com/users/dericed/gists{/gist_id}","starred_url":"https://api.github.com/users/dericed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dericed/subscriptions","organizations_url":"https://api.github.com/users/dericed/orgs","repos_url":"https://api.github.com/users/dericed/repos","events_url":"https://api.github.com/users/dericed/events{/privacy}","received_events_url":"https://api.github.com/users/dericed/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dericed/FFV1","description":"The FFV1 lossless video codec specification.","fork":true,"url":"https://api.github.com/repos/dericed/FFV1","forks_url":"https://api.github.com/repos/dericed/FFV1/forks","keys_url":"https://api.github.com/repos/dericed/FFV1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dericed/FFV1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dericed/FFV1/teams","hooks_url":"https://api.github.com/repos/dericed/FFV1/hooks","issue_events_url":"https://api.github.com/repos/dericed/FFV1/issues/events{/number}","events_url":"https://api.github.com/repos/dericed/FFV1/events","assignees_url":"https://api.github.com/repos/dericed/FFV1/assignees{/user}","branches_url":"https://api.github.com/repos/dericed/FFV1/branches{/branch}","tags_url":"https://api.github.com/repos/dericed/FFV1/tags","blobs_url":"https://api.github.com/repos/dericed/FFV1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dericed/FFV1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dericed/FFV1/git/refs{/sha}","trees_url":"https://api.github.com/repos/dericed/FFV1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dericed/FFV1/statuses/{sha}","languages_url":"https://api.github.com/repos/dericed/FFV1/languages","stargazers_url":"https://api.github.com/repos/dericed/FFV1/stargazers","contributors_url":"https://api.github.com/repos/dericed/FFV1/contributors","subscribers_url":"https://api.github.com/repos/dericed/FFV1/subscribers","subscription_url":"https://api.github.com/repos/dericed/FFV1/subscription","commits_url":"https://api.github.com/repos/dericed/FFV1/commits{/sha}","git_commits_url":"https://api.github.com/repos/dericed/FFV1/git/commits{/sha}","comments_url":"https://api.github.com/repos/dericed/FFV1/comments{/number}","issue_comment_url":"https://api.github.com/repos/dericed/FFV1/issues/comments{/number}","contents_url":"https://api.github.com/repos/dericed/FFV1/contents/{+path}","compare_url":"https://api.github.com/repos/dericed/FFV1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dericed/FFV1/merges","archive_url":"https://api.github.com/repos/dericed/FFV1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dericed/FFV1/downloads","issues_url":"https://api.github.com/repos/dericed/FFV1/issues{/number}","pulls_url":"https://api.github.com/repos/dericed/FFV1/pulls{/number}","milestones_url":"https://api.github.com/repos/dericed/FFV1/milestones{/number}","notifications_url":"https://api.github.com/repos/dericed/FFV1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dericed/FFV1/labels{/name}","releases_url":"https://api.github.com/repos/dericed/FFV1/releases{/id}","deployments_url":"https://api.github.com/repos/dericed/FFV1/deployments","created_at":"2013-08-18T01:35:34Z","updated_at":"2018-10-02T18:03:09Z","pushed_at":"2018-10-03T20:23:25Z","git_url":"git://github.com/dericed/FFV1.git","ssh_url":"git@github.com:dericed/FFV1.git","clone_url":"https://github.com/dericed/FFV1.git","svn_url":"https://github.com/dericed/FFV1","homepage":"","size":341,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FFmpeg:master","ref":"master","sha":"e4f649cf736b9a3abfc9935cb64e9ddb9f97892f","user":{"login":"FFmpeg","id":729418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyOTQxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/729418?v=4","gravatar_id":"","url":"https://api.github.com/users/FFmpeg","html_url":"https://github.com/FFmpeg","followers_url":"https://api.github.com/users/FFmpeg/followers","following_url":"https://api.github.com/users/FFmpeg/following{/other_user}","gists_url":"https://api.github.com/users/FFmpeg/gists{/gist_id}","starred_url":"https://api.github.com/users/FFmpeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FFmpeg/subscriptions","organizations_url":"https://api.github.com/users/FFmpeg/orgs","repos_url":"https://api.github.com/users/FFmpeg/repos","events_url":"https://api.github.com/users/FFmpeg/events{/privacy}","received_events_url":"https://api.github.com/users/FFmpeg/received_events","type":"Organization","site_admin":false},"repo":{"id":3873360,"node_id":"MDEwOlJlcG9zaXRvcnkzODczMzYw","name":"FFV1","full_name":"FFmpeg/FFV1","private":false,"owner":{"login":"FFmpeg","id":729418,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyOTQxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/729418?v=4","gravatar_id":"","url":"https://api.github.com/users/FFmpeg","html_url":"https://github.com/FFmpeg","followers_url":"https://api.github.com/users/FFmpeg/followers","following_url":"https://api.github.com/users/FFmpeg/following{/other_user}","gists_url":"https://api.github.com/users/FFmpeg/gists{/gist_id}","starred_url":"https://api.github.com/users/FFmpeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FFmpeg/subscriptions","organizations_url":"https://api.github.com/users/FFmpeg/orgs","repos_url":"https://api.github.com/users/FFmpeg/repos","events_url":"https://api.github.com/users/FFmpeg/events{/privacy}","received_events_url":"https://api.github.com/users/FFmpeg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FFmpeg/FFV1","description":"The FFV1 lossless video codec specification.","fork":false,"url":"https://api.github.com/repos/FFmpeg/FFV1","forks_url":"https://api.github.com/repos/FFmpeg/FFV1/forks","keys_url":"https://api.github.com/repos/FFmpeg/FFV1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FFmpeg/FFV1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FFmpeg/FFV1/teams","hooks_url":"https://api.github.com/repos/FFmpeg/FFV1/hooks","issue_events_url":"https://api.github.com/repos/FFmpeg/FFV1/issues/events{/number}","events_url":"https://api.github.com/repos/FFmpeg/FFV1/events","assignees_url":"https://api.github.com/repos/FFmpeg/FFV1/assignees{/user}","branches_url":"https://api.github.com/repos/FFmpeg/FFV1/branches{/branch}","tags_url":"https://api.github.com/repos/FFmpeg/FFV1/tags","blobs_url":"https://api.github.com/repos/FFmpeg/FFV1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FFmpeg/FFV1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FFmpeg/FFV1/git/refs{/sha}","trees_url":"https://api.github.com/repos/FFmpeg/FFV1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FFmpeg/FFV1/statuses/{sha}","languages_url":"https://api.github.com/repos/FFmpeg/FFV1/languages","stargazers_url":"https://api.github.com/repos/FFmpeg/FFV1/stargazers","contributors_url":"https://api.github.com/repos/FFmpeg/FFV1/contributors","subscribers_url":"https://api.github.com/repos/FFmpeg/FFV1/subscribers","subscription_url":"https://api.github.com/repos/FFmpeg/FFV1/subscription","commits_url":"https://api.github.com/repos/FFmpeg/FFV1/commits{/sha}","git_commits_url":"https://api.github.com/repos/FFmpeg/FFV1/git/commits{/sha}","comments_url":"https://api.github.com/repos/FFmpeg/FFV1/comments{/number}","issue_comment_url":"https://api.github.com/repos/FFmpeg/FFV1/issues/comments{/number}","contents_url":"https://api.github.com/repos/FFmpeg/FFV1/contents/{+path}","compare_url":"https://api.github.com/repos/FFmpeg/FFV1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FFmpeg/FFV1/merges","archive_url":"https://api.github.com/repos/FFmpeg/FFV1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FFmpeg/FFV1/downloads","issues_url":"https://api.github.com/repos/FFmpeg/FFV1/issues{/number}","pulls_url":"https://api.github.com/repos/FFmpeg/FFV1/pulls{/number}","milestones_url":"https://api.github.com/repos/FFmpeg/FFV1/milestones{/number}","notifications_url":"https://api.github.com/repos/FFmpeg/FFV1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FFmpeg/FFV1/labels{/name}","releases_url":"https://api.github.com/repos/FFmpeg/FFV1/releases{/id}","deployments_url":"https://api.github.com/repos/FFmpeg/FFV1/deployments","created_at":"2012-03-30T04:25:40Z","updated_at":"2018-10-02T23:52:39Z","pushed_at":"2018-10-03T20:24:16Z","git_url":"git://github.com/FFmpeg/FFV1.git","ssh_url":"git@github.com:FFmpeg/FFV1.git","clone_url":"https://github.com/FFmpeg/FFV1.git","svn_url":"https://github.com/FFmpeg/FFV1","homepage":"","size":333,"stargazers_count":45,"watchers_count":45,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":22,"open_issues":8,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130"},"html":{"href":"https://github.com/FFmpeg/FFV1/pull/130"},"issue":{"href":"https://api.github.com/repos/FFmpeg/FFV1/issues/130"},"comments":{"href":"https://api.github.com/repos/FFmpeg/FFV1/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/FFmpeg/FFV1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FFmpeg/FFV1/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/FFmpeg/FFV1/statuses/8cab54b17ca32955eb9cf845afdbec5104149da1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dericed"}}