{"action":"created","comment":{"url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/223839231","pull_request_review_id":163066336,"id":223839231,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzgzOTIzMQ==","diff_hunk":"@@ -175,9 +175,9 @@ bool RSA::SetPublicKey(const String& strKey)\n     m_bIsPublicKey = true;\n     m_bIsPrivateKey = false;\n \n-    if (nullptr == m_p_ascKey) {\n-        m_p_ascKey = new Armored;\n-        OT_ASSERT(nullptr != m_p_ascKey);\n+    if (m_p_ascKey->Exists()) {\n+        m_p_ascKey = Armored::Factory();\n+        OT_ASSERT(m_p_ascKey->Exists());\n     }\n ","path":"src/crypto/key/RSA.cpp","position":48,"original_position":48,"commit_id":"0290759330191322c9f7a52b8a863fcd8bad6bd8","original_commit_id":"0290759330191322c9f7a52b8a863fcd8bad6bd8","user":{"login":"FellowTraveler","id":339191,"node_id":"MDQ6VXNlcjMzOTE5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/339191?v=4","gravatar_id":"","url":"https://api.github.com/users/FellowTraveler","html_url":"https://github.com/FellowTraveler","followers_url":"https://api.github.com/users/FellowTraveler/followers","following_url":"https://api.github.com/users/FellowTraveler/following{/other_user}","gists_url":"https://api.github.com/users/FellowTraveler/gists{/gist_id}","starred_url":"https://api.github.com/users/FellowTraveler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FellowTraveler/subscriptions","organizations_url":"https://api.github.com/users/FellowTraveler/orgs","repos_url":"https://api.github.com/users/FellowTraveler/repos","events_url":"https://api.github.com/users/FellowTraveler/events{/privacy}","received_events_url":"https://api.github.com/users/FellowTraveler/received_events","type":"User","site_admin":false},"body":"2. The old version ASSERTED that the raw pointer was NOT NULL. (Because it had just allocated the memory using a call to _new)_\r\nWhereas the new version is ASSERTING that the string EXISTS (NOT EMPTY) -- of course that is a different meaning. You basically want to DELETE this assert. It no longer makes sense, since this is no longer a raw pointer.","created_at":"2018-10-09T19:50:23Z","updated_at":"2018-10-09T19:50:24Z","html_url":"https://github.com/Open-Transactions/opentxs/pull/1223#discussion_r223839231","pull_request_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments/223839231"},"html":{"href":"https://github.com/Open-Transactions/opentxs/pull/1223#discussion_r223839231"},"pull_request":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223"}},"in_reply_to_id":223838818},"pull_request":{"url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223","id":221289209,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjg5MjA5","html_url":"https://github.com/Open-Transactions/opentxs/pull/1223","diff_url":"https://github.com/Open-Transactions/opentxs/pull/1223.diff","patch_url":"https://github.com/Open-Transactions/opentxs/pull/1223.patch","issue_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/1223","number":1223,"state":"open","locked":false,"title":"Use OTArmored to instantiate Armored Objects: Mint.cpp","user":{"login":"Wallydog66","id":8482519,"node_id":"MDQ6VXNlcjg0ODI1MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8482519?v=4","gravatar_id":"","url":"https://api.github.com/users/Wallydog66","html_url":"https://github.com/Wallydog66","followers_url":"https://api.github.com/users/Wallydog66/followers","following_url":"https://api.github.com/users/Wallydog66/following{/other_user}","gists_url":"https://api.github.com/users/Wallydog66/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallydog66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallydog66/subscriptions","organizations_url":"https://api.github.com/users/Wallydog66/orgs","repos_url":"https://api.github.com/users/Wallydog66/repos","events_url":"https://api.github.com/users/Wallydog66/events{/privacy}","received_events_url":"https://api.github.com/users/Wallydog66/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-09T02:14:32Z","updated_at":"2018-10-09T19:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f2716da8dec4e4e478c16303e8b0d7dc8d5d6a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223/commits","review_comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223/comments","review_comment_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/1223/comments","statuses_url":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/0290759330191322c9f7a52b8a863fcd8bad6bd8","head":{"label":"Wallydog66:broken","ref":"broken","sha":"0290759330191322c9f7a52b8a863fcd8bad6bd8","user":{"login":"Wallydog66","id":8482519,"node_id":"MDQ6VXNlcjg0ODI1MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8482519?v=4","gravatar_id":"","url":"https://api.github.com/users/Wallydog66","html_url":"https://github.com/Wallydog66","followers_url":"https://api.github.com/users/Wallydog66/followers","following_url":"https://api.github.com/users/Wallydog66/following{/other_user}","gists_url":"https://api.github.com/users/Wallydog66/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallydog66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallydog66/subscriptions","organizations_url":"https://api.github.com/users/Wallydog66/orgs","repos_url":"https://api.github.com/users/Wallydog66/repos","events_url":"https://api.github.com/users/Wallydog66/events{/privacy}","received_events_url":"https://api.github.com/users/Wallydog66/received_events","type":"User","site_admin":false},"repo":{"id":130506607,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA1MDY2MDc=","name":"opentxs","full_name":"Wallydog66/opentxs","private":false,"owner":{"login":"Wallydog66","id":8482519,"node_id":"MDQ6VXNlcjg0ODI1MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8482519?v=4","gravatar_id":"","url":"https://api.github.com/users/Wallydog66","html_url":"https://github.com/Wallydog66","followers_url":"https://api.github.com/users/Wallydog66/followers","following_url":"https://api.github.com/users/Wallydog66/following{/other_user}","gists_url":"https://api.github.com/users/Wallydog66/gists{/gist_id}","starred_url":"https://api.github.com/users/Wallydog66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wallydog66/subscriptions","organizations_url":"https://api.github.com/users/Wallydog66/orgs","repos_url":"https://api.github.com/users/Wallydog66/repos","events_url":"https://api.github.com/users/Wallydog66/events{/privacy}","received_events_url":"https://api.github.com/users/Wallydog66/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Wallydog66/opentxs","description":"Open Transactions - Libraries and CLI","fork":true,"url":"https://api.github.com/repos/Wallydog66/opentxs","forks_url":"https://api.github.com/repos/Wallydog66/opentxs/forks","keys_url":"https://api.github.com/repos/Wallydog66/opentxs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wallydog66/opentxs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wallydog66/opentxs/teams","hooks_url":"https://api.github.com/repos/Wallydog66/opentxs/hooks","issue_events_url":"https://api.github.com/repos/Wallydog66/opentxs/issues/events{/number}","events_url":"https://api.github.com/repos/Wallydog66/opentxs/events","assignees_url":"https://api.github.com/repos/Wallydog66/opentxs/assignees{/user}","branches_url":"https://api.github.com/repos/Wallydog66/opentxs/branches{/branch}","tags_url":"https://api.github.com/repos/Wallydog66/opentxs/tags","blobs_url":"https://api.github.com/repos/Wallydog66/opentxs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wallydog66/opentxs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wallydog66/opentxs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wallydog66/opentxs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wallydog66/opentxs/statuses/{sha}","languages_url":"https://api.github.com/repos/Wallydog66/opentxs/languages","stargazers_url":"https://api.github.com/repos/Wallydog66/opentxs/stargazers","contributors_url":"https://api.github.com/repos/Wallydog66/opentxs/contributors","subscribers_url":"https://api.github.com/repos/Wallydog66/opentxs/subscribers","subscription_url":"https://api.github.com/repos/Wallydog66/opentxs/subscription","commits_url":"https://api.github.com/repos/Wallydog66/opentxs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wallydog66/opentxs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wallydog66/opentxs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wallydog66/opentxs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wallydog66/opentxs/contents/{+path}","compare_url":"https://api.github.com/repos/Wallydog66/opentxs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wallydog66/opentxs/merges","archive_url":"https://api.github.com/repos/Wallydog66/opentxs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wallydog66/opentxs/downloads","issues_url":"https://api.github.com/repos/Wallydog66/opentxs/issues{/number}","pulls_url":"https://api.github.com/repos/Wallydog66/opentxs/pulls{/number}","milestones_url":"https://api.github.com/repos/Wallydog66/opentxs/milestones{/number}","notifications_url":"https://api.github.com/repos/Wallydog66/opentxs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wallydog66/opentxs/labels{/name}","releases_url":"https://api.github.com/repos/Wallydog66/opentxs/releases{/id}","deployments_url":"https://api.github.com/repos/Wallydog66/opentxs/deployments","created_at":"2018-04-21T19:41:26Z","updated_at":"2018-10-09T14:44:00Z","pushed_at":"2018-10-09T14:54:47Z","git_url":"git://github.com/Wallydog66/opentxs.git","ssh_url":"git@github.com:Wallydog66/opentxs.git","clone_url":"https://github.com/Wallydog66/opentxs.git","svn_url":"https://github.com/Wallydog66/opentxs","homepage":"http://opentransactions.org/","size":76033,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"Open-Transactions:develop","ref":"develop","sha":"0717c13d911b2376974c5589a46ff0563d7c3008","user":{"login":"Open-Transactions","id":4221800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjE4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/4221800?v=4","gravatar_id":"","url":"https://api.github.com/users/Open-Transactions","html_url":"https://github.com/Open-Transactions","followers_url":"https://api.github.com/users/Open-Transactions/followers","following_url":"https://api.github.com/users/Open-Transactions/following{/other_user}","gists_url":"https://api.github.com/users/Open-Transactions/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-Transactions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-Transactions/subscriptions","organizations_url":"https://api.github.com/users/Open-Transactions/orgs","repos_url":"https://api.github.com/users/Open-Transactions/repos","events_url":"https://api.github.com/users/Open-Transactions/events{/privacy}","received_events_url":"https://api.github.com/users/Open-Transactions/received_events","type":"Organization","site_admin":false},"repo":{"id":22756749,"node_id":"MDEwOlJlcG9zaXRvcnkyMjc1Njc0OQ==","name":"opentxs","full_name":"Open-Transactions/opentxs","private":false,"owner":{"login":"Open-Transactions","id":4221800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjE4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/4221800?v=4","gravatar_id":"","url":"https://api.github.com/users/Open-Transactions","html_url":"https://github.com/Open-Transactions","followers_url":"https://api.github.com/users/Open-Transactions/followers","following_url":"https://api.github.com/users/Open-Transactions/following{/other_user}","gists_url":"https://api.github.com/users/Open-Transactions/gists{/gist_id}","starred_url":"https://api.github.com/users/Open-Transactions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Open-Transactions/subscriptions","organizations_url":"https://api.github.com/users/Open-Transactions/orgs","repos_url":"https://api.github.com/users/Open-Transactions/repos","events_url":"https://api.github.com/users/Open-Transactions/events{/privacy}","received_events_url":"https://api.github.com/users/Open-Transactions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Open-Transactions/opentxs","description":"Open Transactions - Libraries and CLI","fork":false,"url":"https://api.github.com/repos/Open-Transactions/opentxs","forks_url":"https://api.github.com/repos/Open-Transactions/opentxs/forks","keys_url":"https://api.github.com/repos/Open-Transactions/opentxs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Open-Transactions/opentxs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Open-Transactions/opentxs/teams","hooks_url":"https://api.github.com/repos/Open-Transactions/opentxs/hooks","issue_events_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/events{/number}","events_url":"https://api.github.com/repos/Open-Transactions/opentxs/events","assignees_url":"https://api.github.com/repos/Open-Transactions/opentxs/assignees{/user}","branches_url":"https://api.github.com/repos/Open-Transactions/opentxs/branches{/branch}","tags_url":"https://api.github.com/repos/Open-Transactions/opentxs/tags","blobs_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/{sha}","languages_url":"https://api.github.com/repos/Open-Transactions/opentxs/languages","stargazers_url":"https://api.github.com/repos/Open-Transactions/opentxs/stargazers","contributors_url":"https://api.github.com/repos/Open-Transactions/opentxs/contributors","subscribers_url":"https://api.github.com/repos/Open-Transactions/opentxs/subscribers","subscription_url":"https://api.github.com/repos/Open-Transactions/opentxs/subscription","commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Open-Transactions/opentxs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Open-Transactions/opentxs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Open-Transactions/opentxs/contents/{+path}","compare_url":"https://api.github.com/repos/Open-Transactions/opentxs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Open-Transactions/opentxs/merges","archive_url":"https://api.github.com/repos/Open-Transactions/opentxs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Open-Transactions/opentxs/downloads","issues_url":"https://api.github.com/repos/Open-Transactions/opentxs/issues{/number}","pulls_url":"https://api.github.com/repos/Open-Transactions/opentxs/pulls{/number}","milestones_url":"https://api.github.com/repos/Open-Transactions/opentxs/milestones{/number}","notifications_url":"https://api.github.com/repos/Open-Transactions/opentxs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Open-Transactions/opentxs/labels{/name}","releases_url":"https://api.github.com/repos/Open-Transactions/opentxs/releases{/id}","deployments_url":"https://api.github.com/repos/Open-Transactions/opentxs/deployments","created_at":"2014-08-08T12:13:23Z","updated_at":"2018-10-09T13:52:44Z","pushed_at":"2018-10-09T14:54:48Z","git_url":"git://github.com/Open-Transactions/opentxs.git","ssh_url":"git@github.com:Open-Transactions/opentxs.git","clone_url":"https://github.com/Open-Transactions/opentxs.git","svn_url":"https://github.com/Open-Transactions/opentxs","homepage":"http://opentransactions.org/","size":76050,"stargazers_count":92,"watchers_count":92,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":77,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":68,"open_issues":77,"watchers":92,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223"},"html":{"href":"https://github.com/Open-Transactions/opentxs/pull/1223"},"issue":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/issues/1223"},"comments":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/issues/1223/comments"},"review_comments":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223/comments"},"review_comment":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/pulls/1223/commits"},"statuses":{"href":"https://api.github.com/repos/Open-Transactions/opentxs/statuses/0290759330191322c9f7a52b8a863fcd8bad6bd8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"FellowTraveler"}}