{"action":"created","issue":{"url":"https://api.github.com/repos/Gnucash/gnucash/issues/401","repository_url":"https://api.github.com/repos/Gnucash/gnucash","labels_url":"https://api.github.com/repos/Gnucash/gnucash/issues/401/labels{/name}","comments_url":"https://api.github.com/repos/Gnucash/gnucash/issues/401/comments","events_url":"https://api.github.com/repos/Gnucash/gnucash/issues/401/events","html_url":"https://github.com/Gnucash/gnucash/pull/401","id":353686905,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjY5MzYx","number":401,"title":"Ignore deprecation warnings from glib","user":{"login":"vorlonofportland","id":2757405,"node_id":"MDQ6VXNlcjI3NTc0MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2757405?v=4","gravatar_id":"","url":"https://api.github.com/users/vorlonofportland","html_url":"https://github.com/vorlonofportland","followers_url":"https://api.github.com/users/vorlonofportland/followers","following_url":"https://api.github.com/users/vorlonofportland/following{/other_user}","gists_url":"https://api.github.com/users/vorlonofportland/gists{/gist_id}","starred_url":"https://api.github.com/users/vorlonofportland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorlonofportland/subscriptions","organizations_url":"https://api.github.com/users/vorlonofportland/orgs","repos_url":"https://api.github.com/users/vorlonofportland/repos","events_url":"https://api.github.com/users/vorlonofportland/events{/privacy}","received_events_url":"https://api.github.com/users/vorlonofportland/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-24T08:11:49Z","updated_at":"2018-09-01T03:27:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Gnucash/gnucash/pulls/401","html_url":"https://github.com/Gnucash/gnucash/pull/401","diff_url":"https://github.com/Gnucash/gnucash/pull/401.diff","patch_url":"https://github.com/Gnucash/gnucash/pull/401.patch"},"body":"In glib 2.58, g_type_class_add_private is deprecated, which causes gnucash\r\nto fail to build due to -Werror.  To get gnucash building in Ubuntu, we have\r\nturned this particular error back into a warning with\r\n-Wno-error=deprecated-declarations.\r\n\r\nThis also drops the -Wno-deprecated-register flag, which doesn't appear\r\nto be recognized at all by gcc-8.\r\n\r\nAn alternate solution of course is to update gnucash to use the current glib API.\r\n\r\nhttps://launchpad.net/ubuntu/+source/gnucash/1:3.2-1build1/+build/15137868"},"comment":{"url":"https://api.github.com/repos/Gnucash/gnucash/issues/comments/417829252","html_url":"https://github.com/Gnucash/gnucash/pull/401#issuecomment-417829252","issue_url":"https://api.github.com/repos/Gnucash/gnucash/issues/401","id":417829252,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzgyOTI1Mg==","user":{"login":"jralls","id":58910,"node_id":"MDQ6VXNlcjU4OTEw","avatar_url":"https://avatars2.githubusercontent.com/u/58910?v=4","gravatar_id":"","url":"https://api.github.com/users/jralls","html_url":"https://github.com/jralls","followers_url":"https://api.github.com/users/jralls/followers","following_url":"https://api.github.com/users/jralls/following{/other_user}","gists_url":"https://api.github.com/users/jralls/gists{/gist_id}","starred_url":"https://api.github.com/users/jralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jralls/subscriptions","organizations_url":"https://api.github.com/users/jralls/orgs","repos_url":"https://api.github.com/users/jralls/repos","events_url":"https://api.github.com/users/jralls/events{/privacy}","received_events_url":"https://api.github.com/users/jralls/received_events","type":"User","site_admin":false},"created_at":"2018-09-01T03:27:06Z","updated_at":"2018-09-01T03:27:06Z","author_association":"MEMBER","body":"I prefer -Wno-deprecated-declarations. I don't think we gain anything from warnings we're going to routinely ignore. When someone gets around to cleaning up the deprecated decls he can turn off the flag locally to find them all.\r\n\r\nThe change also removes -Wno-deprecated-register. IIRC it's there because one of the Boost libraries uses the ```register``` storage class in at least one header. If we're going to turn the error back on we need to find which one and in what Boost version it's fixed and update the minimum in the root CMakeLists.txt. "}}
{"actor":{"display_login":"jralls"}}