{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/2986","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/2986/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/2986/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/2986/events","html_url":"https://github.com/codice/ddf/pull/2986","id":299100406,"number":2986,"title":"DDF-3636: Decouple Applications from karaf features","user":{"login":"tbatie","id":9013620,"avatar_url":"https://avatars3.githubusercontent.com/u/9013620?v=4","gravatar_id":"","url":"https://api.github.com/users/tbatie","html_url":"https://github.com/tbatie","followers_url":"https://api.github.com/users/tbatie/followers","following_url":"https://api.github.com/users/tbatie/following{/other_user}","gists_url":"https://api.github.com/users/tbatie/gists{/gist_id}","starred_url":"https://api.github.com/users/tbatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbatie/subscriptions","organizations_url":"https://api.github.com/users/tbatie/orgs","repos_url":"https://api.github.com/users/tbatie/repos","events_url":"https://api.github.com/users/tbatie/events{/privacy}","received_events_url":"https://api.github.com/users/tbatie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pklinef","id":700518,"avatar_url":"https://avatars1.githubusercontent.com/u/700518?v=4","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},"assignees":[{"login":"pklinef","id":700518,"avatar_url":"https://avatars1.githubusercontent.com/u/700518?v=4","gravatar_id":"","url":"https://api.github.com/users/pklinef","html_url":"https://github.com/pklinef","followers_url":"https://api.github.com/users/pklinef/followers","following_url":"https://api.github.com/users/pklinef/following{/other_user}","gists_url":"https://api.github.com/users/pklinef/gists{/gist_id}","starred_url":"https://api.github.com/users/pklinef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pklinef/subscriptions","organizations_url":"https://api.github.com/users/pklinef/orgs","repos_url":"https://api.github.com/users/pklinef/repos","events_url":"https://api.github.com/users/pklinef/events{/privacy}","received_events_url":"https://api.github.com/users/pklinef/received_events","type":"User","site_admin":false},{"login":"figliold","id":4838043,"avatar_url":"https://avatars3.githubusercontent.com/u/4838043?v=4","gravatar_id":"","url":"https://api.github.com/users/figliold","html_url":"https://github.com/figliold","followers_url":"https://api.github.com/users/figliold/followers","following_url":"https://api.github.com/users/figliold/following{/other_user}","gists_url":"https://api.github.com/users/figliold/gists{/gist_id}","starred_url":"https://api.github.com/users/figliold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/figliold/subscriptions","organizations_url":"https://api.github.com/users/figliold/orgs","repos_url":"https://api.github.com/users/figliold/repos","events_url":"https://api.github.com/users/figliold/events{/privacy}","received_events_url":"https://api.github.com/users/figliold/received_events","type":"User","site_admin":false},{"login":"lessarderic","id":11377558,"avatar_url":"https://avatars1.githubusercontent.com/u/11377558?v=4","gravatar_id":"","url":"https://api.github.com/users/lessarderic","html_url":"https://github.com/lessarderic","followers_url":"https://api.github.com/users/lessarderic/followers","following_url":"https://api.github.com/users/lessarderic/following{/other_user}","gists_url":"https://api.github.com/users/lessarderic/gists{/gist_id}","starred_url":"https://api.github.com/users/lessarderic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lessarderic/subscriptions","organizations_url":"https://api.github.com/users/lessarderic/orgs","repos_url":"https://api.github.com/users/lessarderic/repos","events_url":"https://api.github.com/users/lessarderic/events{/privacy}","received_events_url":"https://api.github.com/users/lessarderic/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-02-21T19:37:26Z","updated_at":"2018-02-28T15:47:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/2986","html_url":"https://github.com/codice/ddf/pull/2986","diff_url":"https://github.com/codice/ddf/pull/2986.diff","patch_url":"https://github.com/codice/ddf/pull/2986.patch"},"body":"#### What does this PR do?\r\nDecouples applications from karaf. Applications only serve the purpose of categorizing configurations in the admin console with these changes. The application features still exist and can be started from the system tab.\r\n\r\nBackend changes:\r\n- Deprecated application interfaces\r\n- Remove app state and functionality including the install, uninstall, start and stop. ()\r\n- Moved app definitions to configuration filese\r\n- Fixed circular dependencies in feature files so app features can start up properly.\r\n\r\nFrontend changes:\r\n- Only allow profiles to be selected during installation.\r\n- Removed dead code related to managing app state\r\n- Removed features & details tabs of applications\r\n\r\n#### Who is reviewing it? \r\n(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)\r\n@ryeats \r\n@emanns95 \r\n@paouelle \r\n\r\n#### Choose 2 committers to review/merge the PR. \r\n(please choose ONLY two committers from below, delete the rest)\r\n@figliold \r\n@pklinef \r\n\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nEnsure install profiles are working as expected and each application tab shows configurations and plugins as before.\r\n\r\n#### Screenshots (if appropriate)\r\n![screen shot 2018-02-21 at 12 35 07 pm](https://user-images.githubusercontent.com/9013620/36501196-b688b4b2-1703-11e8-82ea-40d32fc6125e.png)\r\n![screen shot 2018-02-21 at 12 34 58 pm](https://user-images.githubusercontent.com/9013620/36501197-b6ce6f2a-1703-11e8-8240-3217844eed8f.png)\r\n\r\n#### Checklist:\r\n- [x] Documentation Updated (Will updated in separate pr)\r\n- [x] Update / Add Unit Tests\r\n- [x] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/369281811","html_url":"https://github.com/codice/ddf/pull/2986#issuecomment-369281811","issue_url":"https://api.github.com/repos/codice/ddf/issues/2986","id":369281811,"user":{"login":"cxbot","id":21088360,"avatar_url":"https://avatars2.githubusercontent.com/u/21088360?v=4","gravatar_id":"","url":"https://api.github.com/users/cxbot","html_url":"https://github.com/cxbot","followers_url":"https://api.github.com/users/cxbot/followers","following_url":"https://api.github.com/users/cxbot/following{/other_user}","gists_url":"https://api.github.com/users/cxbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cxbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxbot/subscriptions","organizations_url":"https://api.github.com/users/cxbot/orgs","repos_url":"https://api.github.com/users/cxbot/repos","events_url":"https://api.github.com/users/cxbot/events{/privacy}","received_events_url":"https://api.github.com/users/cxbot/received_events","type":"User","site_admin":false},"created_at":"2018-02-28T15:47:14Z","updated_at":"2018-02-28T15:47:14Z","author_association":"COLLABORATOR","body":"Internal build has been scheduled, your results will be available at build completion."}}
{"actor":{"display_login":"cxbot"}}