{"action":"closed","number":6444,"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/6444","id":180443139,"html_url":"https://github.com/pytorch/pytorch/pull/6444","diff_url":"https://github.com/pytorch/pytorch/pull/6444.diff","patch_url":"https://github.com/pytorch/pytorch/pull/6444.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/6444","number":6444,"state":"closed","locked":false,"title":"Make ArrayRef read-only by default.","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"Sebastian Messmer noticed that these iterators were writeable by\r\ndefault, which seemed dangerous.  Replaced with const iterators.\r\nThis doesn't seem to affect any ATen code; seems reasonable enough.\r\n\r\nSigned-off-by: Edward Z. Yang <ezyang@fb.com>\r\n\r\nCC @smessmer ","created_at":"2018-04-09T22:20:29Z","updated_at":"2018-04-24T17:30:44Z","closed_at":"2018-04-24T17:30:44Z","merged_at":"2018-04-24T17:30:44Z","merge_commit_sha":"6418c49ee9864feb9a167e1f28b630cccdf49f89","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zdevito","id":370202,"avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"gchanan","id":3768583,"avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6444/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6444/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/6444/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/1c6d0bea1e32b32eab442b12edc4436c34e88e45","head":{"label":"ezyang:pr/const-iterator-arrayref","ref":"pr/const-iterator-arrayref","sha":"1c6d0bea1e32b32eab442b12edc4436c34e88e45","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":101798885,"name":"pytorch-1","full_name":"ezyang/pytorch-1","owner":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/pytorch-1","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/ezyang/pytorch-1","forks_url":"https://api.github.com/repos/ezyang/pytorch-1/forks","keys_url":"https://api.github.com/repos/ezyang/pytorch-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/pytorch-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/pytorch-1/teams","hooks_url":"https://api.github.com/repos/ezyang/pytorch-1/hooks","issue_events_url":"https://api.github.com/repos/ezyang/pytorch-1/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/pytorch-1/events","assignees_url":"https://api.github.com/repos/ezyang/pytorch-1/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/pytorch-1/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/pytorch-1/tags","blobs_url":"https://api.github.com/repos/ezyang/pytorch-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/pytorch-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/pytorch-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/pytorch-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/pytorch-1/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/pytorch-1/languages","stargazers_url":"https://api.github.com/repos/ezyang/pytorch-1/stargazers","contributors_url":"https://api.github.com/repos/ezyang/pytorch-1/contributors","subscribers_url":"https://api.github.com/repos/ezyang/pytorch-1/subscribers","subscription_url":"https://api.github.com/repos/ezyang/pytorch-1/subscription","commits_url":"https://api.github.com/repos/ezyang/pytorch-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/pytorch-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/pytorch-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/pytorch-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezyang/pytorch-1/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/pytorch-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/pytorch-1/merges","archive_url":"https://api.github.com/repos/ezyang/pytorch-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/pytorch-1/downloads","issues_url":"https://api.github.com/repos/ezyang/pytorch-1/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/pytorch-1/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/pytorch-1/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/pytorch-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/pytorch-1/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/pytorch-1/releases{/id}","deployments_url":"https://api.github.com/repos/ezyang/pytorch-1/deployments","created_at":"2017-08-29T19:28:39Z","updated_at":"2018-04-23T14:31:20Z","pushed_at":"2018-04-23T14:29:47Z","git_url":"git://github.com/ezyang/pytorch-1.git","ssh_url":"git@github.com:ezyang/pytorch-1.git","clone_url":"https://github.com/ezyang/pytorch-1.git","svn_url":"https://github.com/ezyang/pytorch-1","homepage":"http://pytorch.org","size":50846,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"26eb08abfae978aca95470069a340ee2f097728b","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-04-24T17:17:02Z","pushed_at":"2018-04-24T17:30:44Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":50760,"stargazers_count":14311,"watchers_count":14311,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3188,"mirror_url":null,"archived":false,"open_issues_count":978,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3188,"open_issues":978,"watchers":14311,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6444"},"html":{"href":"https://github.com/pytorch/pytorch/pull/6444"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6444"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6444/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6444/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6444/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/1c6d0bea1e32b32eab442b12edc4436c34e88e45"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"ezyang"}}