{"action":"closed","number":1717,"pull_request":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/1717","id":219597109,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTk3MTA5","html_url":"https://github.com/RocketChat/Rocket.Chat.Android/pull/1717","diff_url":"https://github.com/RocketChat/Rocket.Chat.Android/pull/1717.diff","patch_url":"https://github.com/RocketChat/Rocket.Chat.Android/pull/1717.patch","issue_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues/1717","number":1717,"state":"closed","locked":false,"title":"[IMPROVEMENT] Add dialog confirmation for logout","user":{"login":"shubhsherl","id":34231951,"node_id":"MDQ6VXNlcjM0MjMxOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/34231951?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhsherl","html_url":"https://github.com/shubhsherl","followers_url":"https://api.github.com/users/shubhsherl/followers","following_url":"https://api.github.com/users/shubhsherl/following{/other_user}","gists_url":"https://api.github.com/users/shubhsherl/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhsherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhsherl/subscriptions","organizations_url":"https://api.github.com/users/shubhsherl/orgs","repos_url":"https://api.github.com/users/shubhsherl/repos","events_url":"https://api.github.com/users/shubhsherl/events{/privacy}","received_events_url":"https://api.github.com/users/shubhsherl/received_events","type":"User","site_admin":false},"body":"<!-- INSTRUCTION: Keep the line below to notify all core developers about this new PR -->\r\n@RocketChat/android\r\n\r\n<!-- INSTRUCTION: Inform the issue number that this PR closes, or remove the line below -->\r\nCloses #1715 \r\nAdd Logout Confirmation.\r\n\r\n<!-- INSTRUCTION: Tell us more about your PR with screen shots if you can -->\r\n![roc](https://user-images.githubusercontent.com/34231951/46332338-b6f8e300-c639-11e8-9e33-ca463ac63ca3.png)\r\n","created_at":"2018-10-02T06:23:35Z","updated_at":"2018-10-20T05:40:27Z","closed_at":"2018-10-20T05:40:27Z","merged_at":null,"merge_commit_sha":"96c99376b8a7882a15b6611b8c351daaf9de4116","assignee":null,"assignees":[],"requested_reviewers":[{"login":"luciofm","id":224255,"node_id":"MDQ6VXNlcjIyNDI1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/224255?v=4","gravatar_id":"","url":"https://api.github.com/users/luciofm","html_url":"https://github.com/luciofm","followers_url":"https://api.github.com/users/luciofm/followers","following_url":"https://api.github.com/users/luciofm/following{/other_user}","gists_url":"https://api.github.com/users/luciofm/gists{/gist_id}","starred_url":"https://api.github.com/users/luciofm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luciofm/subscriptions","organizations_url":"https://api.github.com/users/luciofm/orgs","repos_url":"https://api.github.com/users/luciofm/repos","events_url":"https://api.github.com/users/luciofm/events{/privacy}","received_events_url":"https://api.github.com/users/luciofm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":520468614,"node_id":"MDU6TGFiZWw1MjA0Njg2MTQ=","url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/labels/:+1:%20improvement","name":":+1: improvement","color":"EDEDED","default":false}],"milestone":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/milestones/26","html_url":"https://github.com/RocketChat/Rocket.Chat.Android/milestone/26","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/milestones/26/labels","id":3664655,"node_id":"MDk6TWlsZXN0b25lMzY2NDY1NQ==","number":26,"title":"3.1.0","description":"","creator":{"login":"rafaelks","id":551004,"node_id":"MDQ6VXNlcjU1MTAwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/551004?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelks","html_url":"https://github.com/rafaelks","followers_url":"https://api.github.com/users/rafaelks/followers","following_url":"https://api.github.com/users/rafaelks/following{/other_user}","gists_url":"https://api.github.com/users/rafaelks/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelks/subscriptions","organizations_url":"https://api.github.com/users/rafaelks/orgs","repos_url":"https://api.github.com/users/rafaelks/repos","events_url":"https://api.github.com/users/rafaelks/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelks/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":6,"state":"open","created_at":"2018-09-18T08:52:24Z","updated_at":"2018-10-20T05:40:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/1717/commits","review_comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/1717/comments","review_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues/1717/comments","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/statuses/883f985489b312b3c8ac3c832137d8e8151d887f","head":{"label":"shubhsherl:new_1715","ref":"new_1715","sha":"883f985489b312b3c8ac3c832137d8e8151d887f","user":{"login":"shubhsherl","id":34231951,"node_id":"MDQ6VXNlcjM0MjMxOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/34231951?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhsherl","html_url":"https://github.com/shubhsherl","followers_url":"https://api.github.com/users/shubhsherl/followers","following_url":"https://api.github.com/users/shubhsherl/following{/other_user}","gists_url":"https://api.github.com/users/shubhsherl/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhsherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhsherl/subscriptions","organizations_url":"https://api.github.com/users/shubhsherl/orgs","repos_url":"https://api.github.com/users/shubhsherl/repos","events_url":"https://api.github.com/users/shubhsherl/events{/privacy}","received_events_url":"https://api.github.com/users/shubhsherl/received_events","type":"User","site_admin":false},"repo":{"id":139733656,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MzM2NTY=","name":"Rocket.Chat.Android","full_name":"shubhsherl/Rocket.Chat.Android","private":false,"owner":{"login":"shubhsherl","id":34231951,"node_id":"MDQ6VXNlcjM0MjMxOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/34231951?v=4","gravatar_id":"","url":"https://api.github.com/users/shubhsherl","html_url":"https://github.com/shubhsherl","followers_url":"https://api.github.com/users/shubhsherl/followers","following_url":"https://api.github.com/users/shubhsherl/following{/other_user}","gists_url":"https://api.github.com/users/shubhsherl/gists{/gist_id}","starred_url":"https://api.github.com/users/shubhsherl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shubhsherl/subscriptions","organizations_url":"https://api.github.com/users/shubhsherl/orgs","repos_url":"https://api.github.com/users/shubhsherl/repos","events_url":"https://api.github.com/users/shubhsherl/events{/privacy}","received_events_url":"https://api.github.com/users/shubhsherl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shubhsherl/Rocket.Chat.Android","description":"Rocket.Chat Native Android Application","fork":true,"url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android","forks_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/forks","keys_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/teams","hooks_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/hooks","issue_events_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/issues/events{/number}","events_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/events","assignees_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/assignees{/user}","branches_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/branches{/branch}","tags_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/tags","blobs_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/statuses/{sha}","languages_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/languages","stargazers_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/stargazers","contributors_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/contributors","subscribers_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/subscribers","subscription_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/subscription","commits_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/contents/{+path}","compare_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/merges","archive_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/downloads","issues_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/issues{/number}","pulls_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/pulls{/number}","milestones_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/milestones{/number}","notifications_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/labels{/name}","releases_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/releases{/id}","deployments_url":"https://api.github.com/repos/shubhsherl/Rocket.Chat.Android/deployments","created_at":"2018-07-04T14:37:03Z","updated_at":"2018-07-08T06:42:46Z","pushed_at":"2018-10-20T05:37:19Z","git_url":"git://github.com/shubhsherl/Rocket.Chat.Android.git","ssh_url":"git@github.com:shubhsherl/Rocket.Chat.Android.git","clone_url":"https://github.com/shubhsherl/Rocket.Chat.Android.git","svn_url":"https://github.com/shubhsherl/Rocket.Chat.Android","homepage":"https://rocket.chat","size":15673,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RocketChat:develop","ref":"develop","sha":"aceef97bfd089b27550237d2ab6a615ba5b632c6","user":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"repo":{"id":48179404,"node_id":"MDEwOlJlcG9zaXRvcnk0ODE3OTQwNA==","name":"Rocket.Chat.Android","full_name":"RocketChat/Rocket.Chat.Android","private":false,"owner":{"login":"RocketChat","id":12508788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTA4Nzg4","avatar_url":"https://avatars1.githubusercontent.com/u/12508788?v=4","gravatar_id":"","url":"https://api.github.com/users/RocketChat","html_url":"https://github.com/RocketChat","followers_url":"https://api.github.com/users/RocketChat/followers","following_url":"https://api.github.com/users/RocketChat/following{/other_user}","gists_url":"https://api.github.com/users/RocketChat/gists{/gist_id}","starred_url":"https://api.github.com/users/RocketChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RocketChat/subscriptions","organizations_url":"https://api.github.com/users/RocketChat/orgs","repos_url":"https://api.github.com/users/RocketChat/repos","events_url":"https://api.github.com/users/RocketChat/events{/privacy}","received_events_url":"https://api.github.com/users/RocketChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/RocketChat/Rocket.Chat.Android","description":"Rocket.Chat client in Kotlin for Android","fork":false,"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android","forks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/forks","keys_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/teams","hooks_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/hooks","issue_events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues/events{/number}","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/events","assignees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/assignees{/user}","branches_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/branches{/branch}","tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/tags","blobs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/statuses/{sha}","languages_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/languages","stargazers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/stargazers","contributors_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/contributors","subscribers_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/subscribers","subscription_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/subscription","commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/contents/{+path}","compare_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/merges","archive_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/downloads","issues_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues{/number}","pulls_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls{/number}","milestones_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/milestones{/number}","notifications_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/labels{/name}","releases_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/releases{/id}","deployments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/deployments","created_at":"2015-12-17T14:36:45Z","updated_at":"2018-10-19T22:30:29Z","pushed_at":"2018-10-20T05:39:53Z","git_url":"git://github.com/RocketChat/Rocket.Chat.Android.git","ssh_url":"git@github.com:RocketChat/Rocket.Chat.Android.git","clone_url":"https://github.com/RocketChat/Rocket.Chat.Android.git","svn_url":"https://github.com/RocketChat/Rocket.Chat.Android","homepage":"https://rocket.chat","size":15623,"stargazers_count":546,"watchers_count":546,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":353,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":353,"open_issues":186,"watchers":546,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/1717"},"html":{"href":"https://github.com/RocketChat/Rocket.Chat.Android/pull/1717"},"issue":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues/1717"},"comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/issues/1717/comments"},"review_comments":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/1717/comments"},"review_comment":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/pulls/1717/commits"},"statuses":{"href":"https://api.github.com/repos/RocketChat/Rocket.Chat.Android/statuses/883f985489b312b3c8ac3c832137d8e8151d887f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":6,"additions":37,"deletions":2,"changed_files":12}}
{"actor":{"display_login":"shubhsherl"}}