{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/ruby/syck/pulls/25","id":236995204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTk1MjA0","html_url":"https://github.com/ruby/syck/pull/25","diff_url":"https://github.com/ruby/syck/pull/25.diff","patch_url":"https://github.com/ruby/syck/pull/25.patch","issue_url":"https://api.github.com/repos/ruby/syck/issues/25","number":25,"state":"closed","locked":false,"title":"Fixes syck compilation errors for ruby 2.6-r1","user":{"login":"abdollar","id":84642,"node_id":"MDQ6VXNlcjg0NjQy","avatar_url":"https://avatars0.githubusercontent.com/u/84642?v=4","gravatar_id":"","url":"https://api.github.com/users/abdollar","html_url":"https://github.com/abdollar","followers_url":"https://api.github.com/users/abdollar/followers","following_url":"https://api.github.com/users/abdollar/following{/other_user}","gists_url":"https://api.github.com/users/abdollar/gists{/gist_id}","starred_url":"https://api.github.com/users/abdollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdollar/subscriptions","organizations_url":"https://api.github.com/users/abdollar/orgs","repos_url":"https://api.github.com/users/abdollar/repos","events_url":"https://api.github.com/users/abdollar/events{/privacy}","received_events_url":"https://api.github.com/users/abdollar/received_events","type":"User","site_admin":false},"body":"This fixes a compilation error when we call bundle install using this syck gem with ruby 2.6-r1\r\n\r\nWe see the error ```/usr/local/include/ruby-2.6.0/ruby/st.h:146:52: error: unknown type name 'VALUE'``` when compiling syck.\r\n\r\nThe header fix in this pull request seems to compile with all known rubies; it has been tested with 2.5 and 2.6 and tests pass.\r\n\r\nThis header issue seems to have been introduced with ruby 2.6 at some point between preview 1 and preview 2; if that helps. I'm not sure if your tracking this on https://bugs.ruby-lang.org/ since this code was pulled out of ruby quite some time ago.\r\n","created_at":"2018-12-07T21:13:36Z","updated_at":"2018-12-27T08:33:18Z","closed_at":"2018-12-27T08:33:18Z","merged_at":"2018-12-27T08:33:18Z","merge_commit_sha":"8890c9d08edcbe38fa5486640e6a51baeb76e0f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruby/syck/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ruby/syck/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ruby/syck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby/syck/issues/25/comments","statuses_url":"https://api.github.com/repos/ruby/syck/statuses/921b9499b33df0b9e2f55fe1c51bdc8a327a02e2","head":{"label":"coupa:ruby_26_fix","ref":"ruby_26_fix","sha":"921b9499b33df0b9e2f55fe1c51bdc8a327a02e2","user":{"login":"coupa","id":58638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/58638?v=4","gravatar_id":"","url":"https://api.github.com/users/coupa","html_url":"https://github.com/coupa","followers_url":"https://api.github.com/users/coupa/followers","following_url":"https://api.github.com/users/coupa/following{/other_user}","gists_url":"https://api.github.com/users/coupa/gists{/gist_id}","starred_url":"https://api.github.com/users/coupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coupa/subscriptions","organizations_url":"https://api.github.com/users/coupa/orgs","repos_url":"https://api.github.com/users/coupa/repos","events_url":"https://api.github.com/users/coupa/events{/privacy}","received_events_url":"https://api.github.com/users/coupa/received_events","type":"Organization","site_admin":false},"repo":{"id":160864466,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4NjQ0NjY=","name":"syck","full_name":"coupa/syck","private":false,"owner":{"login":"coupa","id":58638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/58638?v=4","gravatar_id":"","url":"https://api.github.com/users/coupa","html_url":"https://github.com/coupa","followers_url":"https://api.github.com/users/coupa/followers","following_url":"https://api.github.com/users/coupa/following{/other_user}","gists_url":"https://api.github.com/users/coupa/gists{/gist_id}","starred_url":"https://api.github.com/users/coupa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coupa/subscriptions","organizations_url":"https://api.github.com/users/coupa/orgs","repos_url":"https://api.github.com/users/coupa/repos","events_url":"https://api.github.com/users/coupa/events{/privacy}","received_events_url":"https://api.github.com/users/coupa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coupa/syck","description":"Syck from stdlib turned in to a gem","fork":true,"url":"https://api.github.com/repos/coupa/syck","forks_url":"https://api.github.com/repos/coupa/syck/forks","keys_url":"https://api.github.com/repos/coupa/syck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coupa/syck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coupa/syck/teams","hooks_url":"https://api.github.com/repos/coupa/syck/hooks","issue_events_url":"https://api.github.com/repos/coupa/syck/issues/events{/number}","events_url":"https://api.github.com/repos/coupa/syck/events","assignees_url":"https://api.github.com/repos/coupa/syck/assignees{/user}","branches_url":"https://api.github.com/repos/coupa/syck/branches{/branch}","tags_url":"https://api.github.com/repos/coupa/syck/tags","blobs_url":"https://api.github.com/repos/coupa/syck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coupa/syck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coupa/syck/git/refs{/sha}","trees_url":"https://api.github.com/repos/coupa/syck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coupa/syck/statuses/{sha}","languages_url":"https://api.github.com/repos/coupa/syck/languages","stargazers_url":"https://api.github.com/repos/coupa/syck/stargazers","contributors_url":"https://api.github.com/repos/coupa/syck/contributors","subscribers_url":"https://api.github.com/repos/coupa/syck/subscribers","subscription_url":"https://api.github.com/repos/coupa/syck/subscription","commits_url":"https://api.github.com/repos/coupa/syck/commits{/sha}","git_commits_url":"https://api.github.com/repos/coupa/syck/git/commits{/sha}","comments_url":"https://api.github.com/repos/coupa/syck/comments{/number}","issue_comment_url":"https://api.github.com/repos/coupa/syck/issues/comments{/number}","contents_url":"https://api.github.com/repos/coupa/syck/contents/{+path}","compare_url":"https://api.github.com/repos/coupa/syck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coupa/syck/merges","archive_url":"https://api.github.com/repos/coupa/syck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coupa/syck/downloads","issues_url":"https://api.github.com/repos/coupa/syck/issues{/number}","pulls_url":"https://api.github.com/repos/coupa/syck/pulls{/number}","milestones_url":"https://api.github.com/repos/coupa/syck/milestones{/number}","notifications_url":"https://api.github.com/repos/coupa/syck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coupa/syck/labels{/name}","releases_url":"https://api.github.com/repos/coupa/syck/releases{/id}","deployments_url":"https://api.github.com/repos/coupa/syck/deployments","created_at":"2018-12-07T19:03:01Z","updated_at":"2018-12-07T19:03:04Z","pushed_at":"2018-12-07T19:25:38Z","git_url":"git://github.com/coupa/syck.git","ssh_url":"git@github.com:coupa/syck.git","clone_url":"https://github.com/coupa/syck.git","svn_url":"https://github.com/coupa/syck","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby:master","ref":"master","sha":"585fc55d940e04f6315331f29aadd84df87f53c8","user":{"login":"ruby","id":210414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/210414?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"repo":{"id":5939008,"node_id":"MDEwOlJlcG9zaXRvcnk1OTM5MDA4","name":"syck","full_name":"ruby/syck","private":false,"owner":{"login":"ruby","id":210414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDQxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/210414?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ruby/syck","description":"Syck from stdlib turned in to a gem","fork":false,"url":"https://api.github.com/repos/ruby/syck","forks_url":"https://api.github.com/repos/ruby/syck/forks","keys_url":"https://api.github.com/repos/ruby/syck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby/syck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby/syck/teams","hooks_url":"https://api.github.com/repos/ruby/syck/hooks","issue_events_url":"https://api.github.com/repos/ruby/syck/issues/events{/number}","events_url":"https://api.github.com/repos/ruby/syck/events","assignees_url":"https://api.github.com/repos/ruby/syck/assignees{/user}","branches_url":"https://api.github.com/repos/ruby/syck/branches{/branch}","tags_url":"https://api.github.com/repos/ruby/syck/tags","blobs_url":"https://api.github.com/repos/ruby/syck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby/syck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby/syck/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby/syck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby/syck/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby/syck/languages","stargazers_url":"https://api.github.com/repos/ruby/syck/stargazers","contributors_url":"https://api.github.com/repos/ruby/syck/contributors","subscribers_url":"https://api.github.com/repos/ruby/syck/subscribers","subscription_url":"https://api.github.com/repos/ruby/syck/subscription","commits_url":"https://api.github.com/repos/ruby/syck/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby/syck/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby/syck/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby/syck/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby/syck/contents/{+path}","compare_url":"https://api.github.com/repos/ruby/syck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby/syck/merges","archive_url":"https://api.github.com/repos/ruby/syck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby/syck/downloads","issues_url":"https://api.github.com/repos/ruby/syck/issues{/number}","pulls_url":"https://api.github.com/repos/ruby/syck/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby/syck/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby/syck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby/syck/labels{/name}","releases_url":"https://api.github.com/repos/ruby/syck/releases{/id}","deployments_url":"https://api.github.com/repos/ruby/syck/deployments","created_at":"2012-09-24T18:39:03Z","updated_at":"2018-06-30T03:36:42Z","pushed_at":"2018-12-27T08:33:18Z","git_url":"git://github.com/ruby/syck.git","ssh_url":"git@github.com:ruby/syck.git","clone_url":"https://github.com/ruby/syck.git","svn_url":"https://github.com/ruby/syck","homepage":null,"size":157,"stargazers_count":15,"watchers_count":15,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":21,"open_issues":5,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby/syck/pulls/25"},"html":{"href":"https://github.com/ruby/syck/pull/25"},"issue":{"href":"https://api.github.com/repos/ruby/syck/issues/25"},"comments":{"href":"https://api.github.com/repos/ruby/syck/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby/syck/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby/syck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby/syck/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ruby/syck/statuses/921b9499b33df0b9e2f55fe1c51bdc8a327a02e2"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hsbt","id":12301,"node_id":"MDQ6VXNlcjEyMzAx","avatar_url":"https://avatars1.githubusercontent.com/u/12301?v=4","gravatar_id":"","url":"https://api.github.com/users/hsbt","html_url":"https://github.com/hsbt","followers_url":"https://api.github.com/users/hsbt/followers","following_url":"https://api.github.com/users/hsbt/following{/other_user}","gists_url":"https://api.github.com/users/hsbt/gists{/gist_id}","starred_url":"https://api.github.com/users/hsbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsbt/subscriptions","organizations_url":"https://api.github.com/users/hsbt/orgs","repos_url":"https://api.github.com/users/hsbt/repos","events_url":"https://api.github.com/users/hsbt/events{/privacy}","received_events_url":"https://api.github.com/users/hsbt/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"hsbt"}}