{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/16670","repository_url":"https://api.github.com/repos/angular/angular.js","labels_url":"https://api.github.com/repos/angular/angular.js/issues/16670/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/16670/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/16670/events","html_url":"https://github.com/angular/angular.js/pull/16670","id":352014080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDMyMTQ5","number":16670,"title":"fix(ngRoute): extract path params containing hashes and/or question marks correctly","user":{"login":"susisu","id":2443491,"node_id":"MDQ6VXNlcjI0NDM0OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/2443491?v=4","gravatar_id":"","url":"https://api.github.com/users/susisu","html_url":"https://github.com/susisu","followers_url":"https://api.github.com/users/susisu/followers","following_url":"https://api.github.com/users/susisu/following{/other_user}","gists_url":"https://api.github.com/users/susisu/gists{/gist_id}","starred_url":"https://api.github.com/users/susisu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/susisu/subscriptions","organizations_url":"https://api.github.com/users/susisu/orgs","repos_url":"https://api.github.com/users/susisu/repos","events_url":"https://api.github.com/users/susisu/events{/privacy}","received_events_url":"https://api.github.com/users/susisu/received_events","type":"User","site_admin":false},"labels":[{"id":53200630,"node_id":"MDU6TGFiZWw1MzIwMDYzMA==","url":"https://api.github.com/repos/angular/angular.js/labels/cla:%20no","name":"cla: no","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-20T07:23:00Z","updated_at":"2018-08-20T07:31:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angular/angular.js/pulls/16670","html_url":"https://github.com/angular/angular.js/pull/16670","diff_url":"https://github.com/angular/angular.js/pull/16670.diff","patch_url":"https://github.com/angular/angular.js/pull/16670.patch"},"body":"<!-- General PR submission guidelines https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#submit-pr -->\r\n**What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)**\r\nThis PR fixes a regression introduced by 840b5f0.\r\n\r\n**What is the current behavior? (You can also link to an open issue here)**\r\nIf the path (`$location.path()`) contains hashes and/or question marks, path params are not correctly extracted.\r\n\r\nFor example, if you set `$routeProvider.when('/foo/:bar', {})` and navigate to `/foo/bar%23baz`, you will get `$routeParams.bar === \"bar\"`, not `$routeParams.bar === \"bar#baz\"`.\r\n\r\n**What is the new behavior (if this is a feature change)?**\r\nPath params are correctly extracted (`$routeParams.bar === \"bar#baz\"`).\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo.\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our [guidelines](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#commits)\r\n- [x] Fix/Feature: [Docs](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#documentation) have been added/updated\r\n- [x] Fix/Feature: Tests have been added; existing tests pass\r\n\r\n**Other information**:\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular.js/issues/comments/414223377","html_url":"https://github.com/angular/angular.js/pull/16670#issuecomment-414223377","issue_url":"https://api.github.com/repos/angular/angular.js/issues/16670","id":414223377,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDIyMzM3Nw==","user":{"login":"googlebot","id":5384588,"node_id":"MDQ6VXNlcjUzODQ1ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/5384588?v=4","gravatar_id":"","url":"https://api.github.com/users/googlebot","html_url":"https://github.com/googlebot","followers_url":"https://api.github.com/users/googlebot/followers","following_url":"https://api.github.com/users/googlebot/following{/other_user}","gists_url":"https://api.github.com/users/googlebot/gists{/gist_id}","starred_url":"https://api.github.com/users/googlebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlebot/subscriptions","organizations_url":"https://api.github.com/users/googlebot/orgs","repos_url":"https://api.github.com/users/googlebot/repos","events_url":"https://api.github.com/users/googlebot/events{/privacy}","received_events_url":"https://api.github.com/users/googlebot/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T07:31:32Z","updated_at":"2018-08-20T07:31:32Z","author_association":"NONE","body":"CLAs look good, thanks!\n\n<!-- ok -->"}}
{"actor":{"display_login":"googlebot"}}