{"action":"opened","number":64,"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/64","id":183998288,"html_url":"https://github.com/aerogear/aerogear-js-sdk/pull/64","diff_url":"https://github.com/aerogear/aerogear-js-sdk/pull/64.diff","patch_url":"https://github.com/aerogear/aerogear-js-sdk/pull/64.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/64","number":64,"state":"open","locked":false,"title":"Some propositions/improvements to documentation","user":{"login":"josemigallas","id":11672286,"avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false},"body":"## Description\r\nDespite the great job @paolobueno has done, I think there are some parts that are outdated or inaccurate. So that, in this PR I am proposing a set of changes in order to improve the current docs.\r\n\r\nSome being fixes and some others improvements, they are all gathered in the following list (with a brief justification):\r\n\r\n- [Fix] All references to \"AeroGear Services\" have been replaced for simply \"AeroGear\".\r\n- [Change / Fix] The old core-cordova approach was referenced in some sections. This has been removed. I propose we leave the documentation concerning plugins for the next sprint when we implement it.\r\n- [Change] The contributing doc has been remodeled following the format of other similar docs in github (Lerna). It has still room for improvement but the idea behind this change is to briefly and clearly describe to a new developer what do with the SDK.\r\n- [Fix] In core docs, removed \"Logging\" as a main feature.\r\n- [Change] In core docs, changed `configuration` for `appConfiguration` to differentiate between service and app configuration. \r\n- [Change] In core docs, changed example to show only config parser (metrics will be in metrics).\r\n- [Change] In metrics docs, extended info about usage, remodeled structure (First usage, then description)\r\n","created_at":"2018-04-25T11:02:46Z","updated_at":"2018-04-25T11:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/64/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/64/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/64/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/da1fb7a632325c34407e69edf8b1f6271f6444b3","head":{"label":"josemigallas:docs-fixes","ref":"docs-fixes","sha":"da1fb7a632325c34407e69edf8b1f6271f6444b3","user":{"login":"josemigallas","id":11672286,"avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false},"repo":{"id":122324579,"name":"aerogear-js-sdk","full_name":"josemigallas/aerogear-js-sdk","owner":{"login":"josemigallas","id":11672286,"avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josemigallas/aerogear-js-sdk","description":"AeroGear SDK for javascript, Apache Cordova and React Native.","fork":true,"url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk","forks_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/forks","keys_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/teams","hooks_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/events","assignees_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/tags","blobs_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/languages","stargazers_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/subscription","commits_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/merges","archive_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/downloads","issues_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/josemigallas/aerogear-js-sdk/deployments","created_at":"2018-02-21T10:54:53Z","updated_at":"2018-04-25T07:16:49Z","pushed_at":"2018-04-25T10:21:32Z","git_url":"git://github.com/josemigallas/aerogear-js-sdk.git","ssh_url":"git@github.com:josemigallas/aerogear-js-sdk.git","clone_url":"https://github.com/josemigallas/aerogear-js-sdk.git","svn_url":"https://github.com/josemigallas/aerogear-js-sdk","homepage":"http://aerogear.org","size":10863,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"ce4195529cb12ac0382fc76f88d24b6d0a29951c","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":121781914,"name":"aerogear-js-sdk","full_name":"aerogear/aerogear-js-sdk","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-js-sdk","description":"AeroGear SDK for Java Script, Apache Cordova and React Native.","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk","forks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/deployments","created_at":"2018-02-16T17:51:49Z","updated_at":"2018-04-25T08:53:59Z","pushed_at":"2018-04-25T10:10:49Z","git_url":"git://github.com/aerogear/aerogear-js-sdk.git","ssh_url":"git@github.com:aerogear/aerogear-js-sdk.git","clone_url":"https://github.com/aerogear/aerogear-js-sdk.git","svn_url":"https://github.com/aerogear/aerogear-js-sdk","homepage":"http://aerogear.org","size":10841,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/64"},"html":{"href":"https://github.com/aerogear/aerogear-js-sdk/pull/64"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/64"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/da1fb7a632325c34407e69edf8b1f6271f6444b3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":120,"deletions":113,"changed_files":3}}
{"actor":{"display_login":"josemigallas"}}