{"action":"closed","number":591,"pull_request":{"url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/591","id":175342620,"html_url":"https://github.com/Microsoft/sqltoolsservice/pull/591","diff_url":"https://github.com/Microsoft/sqltoolsservice/pull/591.diff","patch_url":"https://github.com/Microsoft/sqltoolsservice/pull/591.patch","issue_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/591","number":591,"state":"closed","locked":false,"title":"Unexpected request handler errors no longer crash SQL Tools Service","user":{"login":"MattIrv","id":3758704,"avatar_url":"https://avatars3.githubusercontent.com/u/3758704?v=4","gravatar_id":"","url":"https://api.github.com/users/MattIrv","html_url":"https://github.com/MattIrv","followers_url":"https://api.github.com/users/MattIrv/followers","following_url":"https://api.github.com/users/MattIrv/following{/other_user}","gists_url":"https://api.github.com/users/MattIrv/gists{/gist_id}","starred_url":"https://api.github.com/users/MattIrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattIrv/subscriptions","organizations_url":"https://api.github.com/users/MattIrv/orgs","repos_url":"https://api.github.com/users/MattIrv/repos","events_url":"https://api.github.com/users/MattIrv/events{/privacy}","received_events_url":"https://api.github.com/users/MattIrv/received_events","type":"User","site_admin":false},"body":"This PR makes two small changes:\r\n* Unhandled errors in request handlers that bubble up to the message dispatcher will no longer crash SQL Tools Service, but will instead be logged\r\n* Disables a flaky Binding Queue test that has caused some recent AppVeyor builds to fail (e.g. https://ci.appveyor.com/project/kburtram/sqltoolsservice/build/1.0.2039 and https://ci.appveyor.com/project/kburtram/sqltoolsservice/build/1.0.2029)\r\n* Disables a flaky Completion Service test that has caused some recent AppVeyor builds to fail (e.g. https://ci.appveyor.com/project/kburtram/sqltoolsservice/build/1.0.2041 and https://ci.appveyor.com/project/kburtram/sqltoolsservice/build/1.0.2034)","created_at":"2018-03-15T18:34:56Z","updated_at":"2018-03-15T21:14:10Z","closed_at":"2018-03-15T21:14:10Z","merged_at":"2018-03-15T21:14:10Z","merge_commit_sha":"aaa3513db268849b1f3b4f92ad320c230342a924","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benrr101","id":585878,"avatar_url":"https://avatars1.githubusercontent.com/u/585878?v=4","gravatar_id":"","url":"https://api.github.com/users/benrr101","html_url":"https://github.com/benrr101","followers_url":"https://api.github.com/users/benrr101/followers","following_url":"https://api.github.com/users/benrr101/following{/other_user}","gists_url":"https://api.github.com/users/benrr101/gists{/gist_id}","starred_url":"https://api.github.com/users/benrr101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrr101/subscriptions","organizations_url":"https://api.github.com/users/benrr101/orgs","repos_url":"https://api.github.com/users/benrr101/repos","events_url":"https://api.github.com/users/benrr101/events{/privacy}","received_events_url":"https://api.github.com/users/benrr101/received_events","type":"User","site_admin":false},{"login":"llali","id":17187348,"avatar_url":"https://avatars1.githubusercontent.com/u/17187348?v=4","gravatar_id":"","url":"https://api.github.com/users/llali","html_url":"https://github.com/llali","followers_url":"https://api.github.com/users/llali/followers","following_url":"https://api.github.com/users/llali/following{/other_user}","gists_url":"https://api.github.com/users/llali/gists{/gist_id}","starred_url":"https://api.github.com/users/llali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llali/subscriptions","organizations_url":"https://api.github.com/users/llali/orgs","repos_url":"https://api.github.com/users/llali/repos","events_url":"https://api.github.com/users/llali/events{/privacy}","received_events_url":"https://api.github.com/users/llali/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/591/commits","review_comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/591/comments","review_comment_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/591/comments","statuses_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/72f25f244c5b93290fce59df4841045a3ef3db1d","head":{"label":"Microsoft:fix/noRequestErrorCrashes","ref":"fix/noRequestErrorCrashes","sha":"72f25f244c5b93290fce59df4841045a3ef3db1d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":63441273,"name":"sqltoolsservice","full_name":"Microsoft/sqltoolsservice","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sqltoolsservice","description":"SQL Tools API service that provides SQL Server data management capabilities.","fork":false,"url":"https://api.github.com/repos/Microsoft/sqltoolsservice","forks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/forks","keys_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/teams","hooks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/events","assignees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/tags","blobs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscription","commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/merges","archive_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/downloads","issues_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/deployments","created_at":"2016-07-15T18:00:16Z","updated_at":"2018-03-15T19:48:42Z","pushed_at":"2018-03-15T21:14:10Z","git_url":"git://github.com/Microsoft/sqltoolsservice.git","ssh_url":"git@github.com:Microsoft/sqltoolsservice.git","clone_url":"https://github.com/Microsoft/sqltoolsservice.git","svn_url":"https://github.com/Microsoft/sqltoolsservice","homepage":"","size":115802,"stargazers_count":122,"watchers_count":122,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":9,"watchers":122,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"365fe2282ea58156ea23905e2747157d85fd6999","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":63441273,"name":"sqltoolsservice","full_name":"Microsoft/sqltoolsservice","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sqltoolsservice","description":"SQL Tools API service that provides SQL Server data management capabilities.","fork":false,"url":"https://api.github.com/repos/Microsoft/sqltoolsservice","forks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/forks","keys_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/teams","hooks_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/events","assignees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/tags","blobs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/subscription","commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/merges","archive_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/downloads","issues_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sqltoolsservice/deployments","created_at":"2016-07-15T18:00:16Z","updated_at":"2018-03-15T19:48:42Z","pushed_at":"2018-03-15T21:14:10Z","git_url":"git://github.com/Microsoft/sqltoolsservice.git","ssh_url":"git@github.com:Microsoft/sqltoolsservice.git","clone_url":"https://github.com/Microsoft/sqltoolsservice.git","svn_url":"https://github.com/Microsoft/sqltoolsservice","homepage":"","size":115802,"stargazers_count":122,"watchers_count":122,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":33,"open_issues":9,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/591"},"html":{"href":"https://github.com/Microsoft/sqltoolsservice/pull/591"},"issue":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/591"},"comments":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/issues/591/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/591/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/pulls/591/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/sqltoolsservice/statuses/72f25f244c5b93290fce59df4841045a3ef3db1d"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MattIrv","id":3758704,"avatar_url":"https://avatars3.githubusercontent.com/u/3758704?v=4","gravatar_id":"","url":"https://api.github.com/users/MattIrv","html_url":"https://github.com/MattIrv","followers_url":"https://api.github.com/users/MattIrv/followers","following_url":"https://api.github.com/users/MattIrv/following{/other_user}","gists_url":"https://api.github.com/users/MattIrv/gists{/gist_id}","starred_url":"https://api.github.com/users/MattIrv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattIrv/subscriptions","organizations_url":"https://api.github.com/users/MattIrv/orgs","repos_url":"https://api.github.com/users/MattIrv/repos","events_url":"https://api.github.com/users/MattIrv/events{/privacy}","received_events_url":"https://api.github.com/users/MattIrv/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":8,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"MattIrv"}}