{"action":"created","comment":{"url":"https://api.github.com/repos/square/okhttp/pulls/comments/216131255","pull_request_review_id":153554781,"id":216131255,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEzMTI1NQ==","diff_hunk":"@@ -144,53 +181,116 @@ public static Headers varyHeaders(Headers requestHeaders, Headers responseHeader\n   }\n \n   /**\n-   * Parse RFC 7617 challenges, also wrong ordered ones.\n-   * This API is only interested in the scheme name and realm.\n+   * Parse RFC 7235 challenges.\n+   * If a challenge uses the {@code token68} variant instead of auth params,\n+   * there is exactly one auth param in the challenge at key {@code null}.\n+   * Invalid headers and challenges are ignored.\n+   * No semantic validation is done, for example that {@code Basic} auth must have a\n+   * {@code realm} auth param, this is up to the caller that interprets these challenges.\n    */\n   public static List<Challenge> parseChallenges(Headers responseHeaders, String challengeHeader) {\n-    // auth-scheme = token\n-    // auth-param  = token \"=\" ( token | quoted-string )\n-    // challenge   = auth-scheme 1*SP 1#auth-param\n-    // realm       = \"realm\" \"=\" realm-value\n-    // realm-value = quoted-string\n     List<Challenge> challenges = new ArrayList<>();","path":"okhttp/src/main/java/okhttp3/internal/http/HttpHeaders.java","position":90,"original_position":90,"commit_id":"053b560372871cdaf9706ecfdae87c526ef574ef","original_commit_id":"053b560372871cdaf9706ecfdae87c526ef574ef","user":{"login":"yschimke","id":231923,"node_id":"MDQ6VXNlcjIzMTkyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/231923?v=4","gravatar_id":"","url":"https://api.github.com/users/yschimke","html_url":"https://github.com/yschimke","followers_url":"https://api.github.com/users/yschimke/followers","following_url":"https://api.github.com/users/yschimke/following{/other_user}","gists_url":"https://api.github.com/users/yschimke/gists{/gist_id}","starred_url":"https://api.github.com/users/yschimke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yschimke/subscriptions","organizations_url":"https://api.github.com/users/yschimke/orgs","repos_url":"https://api.github.com/users/yschimke/repos","events_url":"https://api.github.com/users/yschimke/events{/privacy}","received_events_url":"https://api.github.com/users/yschimke/received_events","type":"User","site_admin":false},"body":"TIOLI: is it worth caching and returning an immutable view of the List here?","created_at":"2018-09-08T14:02:34Z","updated_at":"2018-09-08T14:02:34Z","html_url":"https://github.com/square/okhttp/pull/4252#discussion_r216131255","pull_request_url":"https://api.github.com/repos/square/okhttp/pulls/4252","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/square/okhttp/pulls/comments/216131255"},"html":{"href":"https://github.com/square/okhttp/pull/4252#discussion_r216131255"},"pull_request":{"href":"https://api.github.com/repos/square/okhttp/pulls/4252"}}},"pull_request":{"url":"https://api.github.com/repos/square/okhttp/pulls/4252","id":213256597,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjU2NTk3","html_url":"https://github.com/square/okhttp/pull/4252","diff_url":"https://github.com/square/okhttp/pull/4252.diff","patch_url":"https://github.com/square/okhttp/pull/4252.patch","issue_url":"https://api.github.com/repos/square/okhttp/issues/4252","number":4252,"state":"open","locked":false,"title":"Properly parse RFC 7235 authentication headers (#4249)","user":{"login":"Vampire","id":325196,"node_id":"MDQ6VXNlcjMyNTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/325196?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampire","html_url":"https://github.com/Vampire","followers_url":"https://api.github.com/users/Vampire/followers","following_url":"https://api.github.com/users/Vampire/following{/other_user}","gists_url":"https://api.github.com/users/Vampire/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampire/subscriptions","organizations_url":"https://api.github.com/users/Vampire/orgs","repos_url":"https://api.github.com/users/Vampire/repos","events_url":"https://api.github.com/users/Vampire/events{/privacy}","received_events_url":"https://api.github.com/users/Vampire/received_events","type":"User","site_admin":false},"body":"fixes #4249","created_at":"2018-09-05T11:16:29Z","updated_at":"2018-09-08T14:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"096c06aa8f218e71fa7678b8fe788bda0556b149","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/okhttp/pulls/4252/commits","review_comments_url":"https://api.github.com/repos/square/okhttp/pulls/4252/comments","review_comment_url":"https://api.github.com/repos/square/okhttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/okhttp/issues/4252/comments","statuses_url":"https://api.github.com/repos/square/okhttp/statuses/053b560372871cdaf9706ecfdae87c526ef574ef","head":{"label":"Vampire:authentication-headers","ref":"authentication-headers","sha":"053b560372871cdaf9706ecfdae87c526ef574ef","user":{"login":"Vampire","id":325196,"node_id":"MDQ6VXNlcjMyNTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/325196?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampire","html_url":"https://github.com/Vampire","followers_url":"https://api.github.com/users/Vampire/followers","following_url":"https://api.github.com/users/Vampire/following{/other_user}","gists_url":"https://api.github.com/users/Vampire/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampire/subscriptions","organizations_url":"https://api.github.com/users/Vampire/orgs","repos_url":"https://api.github.com/users/Vampire/repos","events_url":"https://api.github.com/users/Vampire/events{/privacy}","received_events_url":"https://api.github.com/users/Vampire/received_events","type":"User","site_admin":false},"repo":{"id":146210461,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyMTA0NjE=","name":"okhttp","full_name":"Vampire/okhttp","owner":{"login":"Vampire","id":325196,"node_id":"MDQ6VXNlcjMyNTE5Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/325196?v=4","gravatar_id":"","url":"https://api.github.com/users/Vampire","html_url":"https://github.com/Vampire","followers_url":"https://api.github.com/users/Vampire/followers","following_url":"https://api.github.com/users/Vampire/following{/other_user}","gists_url":"https://api.github.com/users/Vampire/gists{/gist_id}","starred_url":"https://api.github.com/users/Vampire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vampire/subscriptions","organizations_url":"https://api.github.com/users/Vampire/orgs","repos_url":"https://api.github.com/users/Vampire/repos","events_url":"https://api.github.com/users/Vampire/events{/privacy}","received_events_url":"https://api.github.com/users/Vampire/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vampire/okhttp","description":"An HTTP+HTTP/2 client for Android and Java applications.","fork":true,"url":"https://api.github.com/repos/Vampire/okhttp","forks_url":"https://api.github.com/repos/Vampire/okhttp/forks","keys_url":"https://api.github.com/repos/Vampire/okhttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vampire/okhttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vampire/okhttp/teams","hooks_url":"https://api.github.com/repos/Vampire/okhttp/hooks","issue_events_url":"https://api.github.com/repos/Vampire/okhttp/issues/events{/number}","events_url":"https://api.github.com/repos/Vampire/okhttp/events","assignees_url":"https://api.github.com/repos/Vampire/okhttp/assignees{/user}","branches_url":"https://api.github.com/repos/Vampire/okhttp/branches{/branch}","tags_url":"https://api.github.com/repos/Vampire/okhttp/tags","blobs_url":"https://api.github.com/repos/Vampire/okhttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vampire/okhttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vampire/okhttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vampire/okhttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vampire/okhttp/statuses/{sha}","languages_url":"https://api.github.com/repos/Vampire/okhttp/languages","stargazers_url":"https://api.github.com/repos/Vampire/okhttp/stargazers","contributors_url":"https://api.github.com/repos/Vampire/okhttp/contributors","subscribers_url":"https://api.github.com/repos/Vampire/okhttp/subscribers","subscription_url":"https://api.github.com/repos/Vampire/okhttp/subscription","commits_url":"https://api.github.com/repos/Vampire/okhttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vampire/okhttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vampire/okhttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vampire/okhttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vampire/okhttp/contents/{+path}","compare_url":"https://api.github.com/repos/Vampire/okhttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vampire/okhttp/merges","archive_url":"https://api.github.com/repos/Vampire/okhttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vampire/okhttp/downloads","issues_url":"https://api.github.com/repos/Vampire/okhttp/issues{/number}","pulls_url":"https://api.github.com/repos/Vampire/okhttp/pulls{/number}","milestones_url":"https://api.github.com/repos/Vampire/okhttp/milestones{/number}","notifications_url":"https://api.github.com/repos/Vampire/okhttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vampire/okhttp/labels{/name}","releases_url":"https://api.github.com/repos/Vampire/okhttp/releases{/id}","deployments_url":"https://api.github.com/repos/Vampire/okhttp/deployments","created_at":"2018-08-26T19:34:27Z","updated_at":"2018-08-26T19:34:31Z","pushed_at":"2018-09-08T10:30:25Z","git_url":"git://github.com/Vampire/okhttp.git","ssh_url":"git@github.com:Vampire/okhttp.git","clone_url":"https://github.com/Vampire/okhttp.git","svn_url":"https://github.com/Vampire/okhttp","homepage":"http://square.github.io/okhttp/","size":18018,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"0b2486f7f32fbe21c8630f330d240546a15beb66","user":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":5152285,"node_id":"MDEwOlJlcG9zaXRvcnk1MTUyMjg1","name":"okhttp","full_name":"square/okhttp","owner":{"login":"square","id":82592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTky","avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/okhttp","description":"An HTTP+HTTP/2 client for Android and Java applications.","fork":false,"url":"https://api.github.com/repos/square/okhttp","forks_url":"https://api.github.com/repos/square/okhttp/forks","keys_url":"https://api.github.com/repos/square/okhttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/okhttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/okhttp/teams","hooks_url":"https://api.github.com/repos/square/okhttp/hooks","issue_events_url":"https://api.github.com/repos/square/okhttp/issues/events{/number}","events_url":"https://api.github.com/repos/square/okhttp/events","assignees_url":"https://api.github.com/repos/square/okhttp/assignees{/user}","branches_url":"https://api.github.com/repos/square/okhttp/branches{/branch}","tags_url":"https://api.github.com/repos/square/okhttp/tags","blobs_url":"https://api.github.com/repos/square/okhttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/okhttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/okhttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/okhttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/okhttp/statuses/{sha}","languages_url":"https://api.github.com/repos/square/okhttp/languages","stargazers_url":"https://api.github.com/repos/square/okhttp/stargazers","contributors_url":"https://api.github.com/repos/square/okhttp/contributors","subscribers_url":"https://api.github.com/repos/square/okhttp/subscribers","subscription_url":"https://api.github.com/repos/square/okhttp/subscription","commits_url":"https://api.github.com/repos/square/okhttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/okhttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/okhttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/okhttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/okhttp/contents/{+path}","compare_url":"https://api.github.com/repos/square/okhttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/okhttp/merges","archive_url":"https://api.github.com/repos/square/okhttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/okhttp/downloads","issues_url":"https://api.github.com/repos/square/okhttp/issues{/number}","pulls_url":"https://api.github.com/repos/square/okhttp/pulls{/number}","milestones_url":"https://api.github.com/repos/square/okhttp/milestones{/number}","notifications_url":"https://api.github.com/repos/square/okhttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/okhttp/labels{/name}","releases_url":"https://api.github.com/repos/square/okhttp/releases{/id}","deployments_url":"https://api.github.com/repos/square/okhttp/deployments","created_at":"2012-07-23T13:42:55Z","updated_at":"2018-09-08T12:34:45Z","pushed_at":"2018-09-08T12:23:46Z","git_url":"git://github.com/square/okhttp.git","ssh_url":"git@github.com:square/okhttp.git","clone_url":"https://github.com/square/okhttp.git","svn_url":"https://github.com/square/okhttp","homepage":"http://square.github.io/okhttp/","size":18006,"stargazers_count":28602,"watchers_count":28602,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6573,"mirror_url":null,"archived":false,"open_issues_count":173,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6573,"open_issues":173,"watchers":28602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/okhttp/pulls/4252"},"html":{"href":"https://github.com/square/okhttp/pull/4252"},"issue":{"href":"https://api.github.com/repos/square/okhttp/issues/4252"},"comments":{"href":"https://api.github.com/repos/square/okhttp/issues/4252/comments"},"review_comments":{"href":"https://api.github.com/repos/square/okhttp/pulls/4252/comments"},"review_comment":{"href":"https://api.github.com/repos/square/okhttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/okhttp/pulls/4252/commits"},"statuses":{"href":"https://api.github.com/repos/square/okhttp/statuses/053b560372871cdaf9706ecfdae87c526ef574ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yschimke"}}