{"action":"created","comment":{"url":"https://api.github.com/repos/sifive/sifive-blocks/pulls/comments/220718314","pull_request_review_id":159192145,"id":220718314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDcxODMxNA==","diff_hunk":"@@ -59,11 +112,22 @@ class SPIPhysical(c: SPIParamsBase) extends Module {\n     Mux(fmt.endian === SPIEndian.MSB, data, Cat(data.toBools))\n \n   val rxd = Cat(io.port.dq.reverse.map(_.i))\n-  val samples = Seq(rxd(1), rxd(1, 0), rxd)\n+  val rxd_delayed = Vec(Seq.fill(io.port.dq.size)(false.B))\n+\n+  //Adding fine-granularity delay buffers on the received data\n+  val fine_grain_delay = Seq.fill(io.port.dq.size) {Module(new BlackBoxDelayBuffer())}\n+  for (j <- 0 to 3 ) { ","path":"src/main/scala/devices/spi/SPIPhysical.scala","position":99,"original_position":99,"commit_id":"dba686d8d10edfb0df9b507c6a06c7fa8874489e","original_commit_id":"dba686d8d10edfb0df9b507c6a06c7fa8874489e","user":{"login":"mwachs5","id":17858596,"node_id":"MDQ6VXNlcjE3ODU4NTk2","avatar_url":"https://avatars1.githubusercontent.com/u/17858596?v=4","gravatar_id":"","url":"https://api.github.com/users/mwachs5","html_url":"https://github.com/mwachs5","followers_url":"https://api.github.com/users/mwachs5/followers","following_url":"https://api.github.com/users/mwachs5/following{/other_user}","gists_url":"https://api.github.com/users/mwachs5/gists{/gist_id}","starred_url":"https://api.github.com/users/mwachs5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwachs5/subscriptions","organizations_url":"https://api.github.com/users/mwachs5/orgs","repos_url":"https://api.github.com/users/mwachs5/repos","events_url":"https://api.github.com/users/mwachs5/events{/privacy}","received_events_url":"https://api.github.com/users/mwachs5/received_events","type":"User","site_admin":false},"body":"since fine_grain_delay may have more or less than 4 elements, can you use the same `io.port.dq.size` parameter there?\r\n\r\nYou could also use a `foreach` ","created_at":"2018-09-26T20:48:51Z","updated_at":"2018-09-26T20:48:51Z","html_url":"https://github.com/sifive/sifive-blocks/pull/85#discussion_r220718314","pull_request_url":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sifive/sifive-blocks/pulls/comments/220718314"},"html":{"href":"https://github.com/sifive/sifive-blocks/pull/85#discussion_r220718314"},"pull_request":{"href":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85","id":216405963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDA1OTYz","html_url":"https://github.com/sifive/sifive-blocks/pull/85","diff_url":"https://github.com/sifive/sifive-blocks/pull/85.diff","patch_url":"https://github.com/sifive/sifive-blocks/pull/85.patch","issue_url":"https://api.github.com/repos/sifive/sifive-blocks/issues/85","number":85,"state":"open","locked":false,"title":"Spi speedup - fine and coarse grain phase difference addition","user":{"login":"mhtwn","id":38992045,"node_id":"MDQ6VXNlcjM4OTkyMDQ1","avatar_url":"https://avatars3.githubusercontent.com/u/38992045?v=4","gravatar_id":"","url":"https://api.github.com/users/mhtwn","html_url":"https://github.com/mhtwn","followers_url":"https://api.github.com/users/mhtwn/followers","following_url":"https://api.github.com/users/mhtwn/following{/other_user}","gists_url":"https://api.github.com/users/mhtwn/gists{/gist_id}","starred_url":"https://api.github.com/users/mhtwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhtwn/subscriptions","organizations_url":"https://api.github.com/users/mhtwn/orgs","repos_url":"https://api.github.com/users/mhtwn/repos","events_url":"https://api.github.com/users/mhtwn/events{/privacy}","received_events_url":"https://api.github.com/users/mhtwn/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-18T18:43:43Z","updated_at":"2018-09-26T20:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d299790516604ffdef282a52c8a44270c44d7c0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85/commits","review_comments_url":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85/comments","review_comment_url":"https://api.github.com/repos/sifive/sifive-blocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sifive/sifive-blocks/issues/85/comments","statuses_url":"https://api.github.com/repos/sifive/sifive-blocks/statuses/dba686d8d10edfb0df9b507c6a06c7fa8874489e","head":{"label":"sifive:spi_speedup_1","ref":"spi_speedup_1","sha":"dba686d8d10edfb0df9b507c6a06c7fa8874489e","user":{"login":"sifive","id":14154771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTU0Nzcx","avatar_url":"https://avatars0.githubusercontent.com/u/14154771?v=4","gravatar_id":"","url":"https://api.github.com/users/sifive","html_url":"https://github.com/sifive","followers_url":"https://api.github.com/users/sifive/followers","following_url":"https://api.github.com/users/sifive/following{/other_user}","gists_url":"https://api.github.com/users/sifive/gists{/gist_id}","starred_url":"https://api.github.com/users/sifive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sifive/subscriptions","organizations_url":"https://api.github.com/users/sifive/orgs","repos_url":"https://api.github.com/users/sifive/repos","events_url":"https://api.github.com/users/sifive/events{/privacy}","received_events_url":"https://api.github.com/users/sifive/received_events","type":"Organization","site_admin":false},"repo":{"id":74623932,"node_id":"MDEwOlJlcG9zaXRvcnk3NDYyMzkzMg==","name":"sifive-blocks","full_name":"sifive/sifive-blocks","private":false,"owner":{"login":"sifive","id":14154771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTU0Nzcx","avatar_url":"https://avatars0.githubusercontent.com/u/14154771?v=4","gravatar_id":"","url":"https://api.github.com/users/sifive","html_url":"https://github.com/sifive","followers_url":"https://api.github.com/users/sifive/followers","following_url":"https://api.github.com/users/sifive/following{/other_user}","gists_url":"https://api.github.com/users/sifive/gists{/gist_id}","starred_url":"https://api.github.com/users/sifive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sifive/subscriptions","organizations_url":"https://api.github.com/users/sifive/orgs","repos_url":"https://api.github.com/users/sifive/repos","events_url":"https://api.github.com/users/sifive/events{/privacy}","received_events_url":"https://api.github.com/users/sifive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sifive/sifive-blocks","description":"Common RTL blocks used in SiFive's projects","fork":false,"url":"https://api.github.com/repos/sifive/sifive-blocks","forks_url":"https://api.github.com/repos/sifive/sifive-blocks/forks","keys_url":"https://api.github.com/repos/sifive/sifive-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sifive/sifive-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sifive/sifive-blocks/teams","hooks_url":"https://api.github.com/repos/sifive/sifive-blocks/hooks","issue_events_url":"https://api.github.com/repos/sifive/sifive-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/sifive/sifive-blocks/events","assignees_url":"https://api.github.com/repos/sifive/sifive-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/sifive/sifive-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/sifive/sifive-blocks/tags","blobs_url":"https://api.github.com/repos/sifive/sifive-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sifive/sifive-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sifive/sifive-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/sifive/sifive-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sifive/sifive-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/sifive/sifive-blocks/languages","stargazers_url":"https://api.github.com/repos/sifive/sifive-blocks/stargazers","contributors_url":"https://api.github.com/repos/sifive/sifive-blocks/contributors","subscribers_url":"https://api.github.com/repos/sifive/sifive-blocks/subscribers","subscription_url":"https://api.github.com/repos/sifive/sifive-blocks/subscription","commits_url":"https://api.github.com/repos/sifive/sifive-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/sifive/sifive-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/sifive/sifive-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/sifive/sifive-blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/sifive/sifive-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/sifive/sifive-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sifive/sifive-blocks/merges","archive_url":"https://api.github.com/repos/sifive/sifive-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sifive/sifive-blocks/downloads","issues_url":"https://api.github.com/repos/sifive/sifive-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/sifive/sifive-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/sifive/sifive-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/sifive/sifive-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sifive/sifive-blocks/labels{/name}","releases_url":"https://api.github.com/repos/sifive/sifive-blocks/releases{/id}","deployments_url":"https://api.github.com/repos/sifive/sifive-blocks/deployments","created_at":"2016-11-24T00:16:09Z","updated_at":"2018-09-24T13:11:46Z","pushed_at":"2018-09-26T07:43:25Z","git_url":"git://github.com/sifive/sifive-blocks.git","ssh_url":"git@github.com:sifive/sifive-blocks.git","clone_url":"https://github.com/sifive/sifive-blocks.git","svn_url":"https://github.com/sifive/sifive-blocks","homepage":"","size":338,"stargazers_count":51,"watchers_count":51,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":5,"watchers":51,"default_branch":"master"}},"base":{"label":"sifive:master","ref":"master","sha":"aad528af13a5ce5c66391a0c147cbd97af860476","user":{"login":"sifive","id":14154771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTU0Nzcx","avatar_url":"https://avatars0.githubusercontent.com/u/14154771?v=4","gravatar_id":"","url":"https://api.github.com/users/sifive","html_url":"https://github.com/sifive","followers_url":"https://api.github.com/users/sifive/followers","following_url":"https://api.github.com/users/sifive/following{/other_user}","gists_url":"https://api.github.com/users/sifive/gists{/gist_id}","starred_url":"https://api.github.com/users/sifive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sifive/subscriptions","organizations_url":"https://api.github.com/users/sifive/orgs","repos_url":"https://api.github.com/users/sifive/repos","events_url":"https://api.github.com/users/sifive/events{/privacy}","received_events_url":"https://api.github.com/users/sifive/received_events","type":"Organization","site_admin":false},"repo":{"id":74623932,"node_id":"MDEwOlJlcG9zaXRvcnk3NDYyMzkzMg==","name":"sifive-blocks","full_name":"sifive/sifive-blocks","private":false,"owner":{"login":"sifive","id":14154771,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTU0Nzcx","avatar_url":"https://avatars0.githubusercontent.com/u/14154771?v=4","gravatar_id":"","url":"https://api.github.com/users/sifive","html_url":"https://github.com/sifive","followers_url":"https://api.github.com/users/sifive/followers","following_url":"https://api.github.com/users/sifive/following{/other_user}","gists_url":"https://api.github.com/users/sifive/gists{/gist_id}","starred_url":"https://api.github.com/users/sifive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sifive/subscriptions","organizations_url":"https://api.github.com/users/sifive/orgs","repos_url":"https://api.github.com/users/sifive/repos","events_url":"https://api.github.com/users/sifive/events{/privacy}","received_events_url":"https://api.github.com/users/sifive/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sifive/sifive-blocks","description":"Common RTL blocks used in SiFive's projects","fork":false,"url":"https://api.github.com/repos/sifive/sifive-blocks","forks_url":"https://api.github.com/repos/sifive/sifive-blocks/forks","keys_url":"https://api.github.com/repos/sifive/sifive-blocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sifive/sifive-blocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sifive/sifive-blocks/teams","hooks_url":"https://api.github.com/repos/sifive/sifive-blocks/hooks","issue_events_url":"https://api.github.com/repos/sifive/sifive-blocks/issues/events{/number}","events_url":"https://api.github.com/repos/sifive/sifive-blocks/events","assignees_url":"https://api.github.com/repos/sifive/sifive-blocks/assignees{/user}","branches_url":"https://api.github.com/repos/sifive/sifive-blocks/branches{/branch}","tags_url":"https://api.github.com/repos/sifive/sifive-blocks/tags","blobs_url":"https://api.github.com/repos/sifive/sifive-blocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sifive/sifive-blocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sifive/sifive-blocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/sifive/sifive-blocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sifive/sifive-blocks/statuses/{sha}","languages_url":"https://api.github.com/repos/sifive/sifive-blocks/languages","stargazers_url":"https://api.github.com/repos/sifive/sifive-blocks/stargazers","contributors_url":"https://api.github.com/repos/sifive/sifive-blocks/contributors","subscribers_url":"https://api.github.com/repos/sifive/sifive-blocks/subscribers","subscription_url":"https://api.github.com/repos/sifive/sifive-blocks/subscription","commits_url":"https://api.github.com/repos/sifive/sifive-blocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/sifive/sifive-blocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/sifive/sifive-blocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/sifive/sifive-blocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/sifive/sifive-blocks/contents/{+path}","compare_url":"https://api.github.com/repos/sifive/sifive-blocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sifive/sifive-blocks/merges","archive_url":"https://api.github.com/repos/sifive/sifive-blocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sifive/sifive-blocks/downloads","issues_url":"https://api.github.com/repos/sifive/sifive-blocks/issues{/number}","pulls_url":"https://api.github.com/repos/sifive/sifive-blocks/pulls{/number}","milestones_url":"https://api.github.com/repos/sifive/sifive-blocks/milestones{/number}","notifications_url":"https://api.github.com/repos/sifive/sifive-blocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sifive/sifive-blocks/labels{/name}","releases_url":"https://api.github.com/repos/sifive/sifive-blocks/releases{/id}","deployments_url":"https://api.github.com/repos/sifive/sifive-blocks/deployments","created_at":"2016-11-24T00:16:09Z","updated_at":"2018-09-24T13:11:46Z","pushed_at":"2018-09-26T07:43:25Z","git_url":"git://github.com/sifive/sifive-blocks.git","ssh_url":"git@github.com:sifive/sifive-blocks.git","clone_url":"https://github.com/sifive/sifive-blocks.git","svn_url":"https://github.com/sifive/sifive-blocks","homepage":"","size":338,"stargazers_count":51,"watchers_count":51,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":5,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85"},"html":{"href":"https://github.com/sifive/sifive-blocks/pull/85"},"issue":{"href":"https://api.github.com/repos/sifive/sifive-blocks/issues/85"},"comments":{"href":"https://api.github.com/repos/sifive/sifive-blocks/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/sifive/sifive-blocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sifive/sifive-blocks/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/sifive/sifive-blocks/statuses/dba686d8d10edfb0df9b507c6a06c7fa8874489e"}},"author_association":"NONE"}}
{"actor":{"display_login":"mwachs5"}}