{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/registry-monitor/pulls/comments/214993522","pull_request_review_id":152162899,"id":214993522,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDk5MzUyMg==","diff_hunk":"@@ -576,29 +644,18 @@ func runMonitor() {\n \t\t\tif !pushTestImage(dockerClient) {\n \t\t\t\tduration = 30 * time.Second\n \t\t\t\t// Write the failure metric.\n-\t\t\t\tm, err := promFailureMetric.GetMetricWithLabelValues()\n-\t\t\t\tif err != nil {\n-\t\t\t\t\tpanic(err)\n-\t\t\t\t}\n-\n-\t\t\t\tm.Inc()\n-\n+\t\t\t\treportFailure(cloudwatchService)\n \t\t\t\tcontinue\n \t\t\t}\n \n \t\t\t// Write the push time metric.\n-\t\t\tpromPushMetric.Observe(time.Since(pushStartTime).Seconds())\n+\t\t\treportPushTime(cloudwatchService, time.Since(pushStartTime))\n \n \t\t\tlog.Infof(\"Test successful\")\n \t\t\tduration = userDuration\n \n \t\t\t// Write the success metric.\n-\t\t\tm, err := promSuccessMetric.GetMetricWithLabelValues()","path":"monitor.go","position":144,"original_position":144,"commit_id":"ab2c1bf332100e3417c8f035b8913f1e21169248","original_commit_id":"ab2c1bf332100e3417c8f035b8913f1e21169248","user":{"login":"josephschorr","id":4073002,"node_id":"MDQ6VXNlcjQwNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4073002?v=4","gravatar_id":"","url":"https://api.github.com/users/josephschorr","html_url":"https://github.com/josephschorr","followers_url":"https://api.github.com/users/josephschorr/followers","following_url":"https://api.github.com/users/josephschorr/following{/other_user}","gists_url":"https://api.github.com/users/josephschorr/gists{/gist_id}","starred_url":"https://api.github.com/users/josephschorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephschorr/subscriptions","organizations_url":"https://api.github.com/users/josephschorr/orgs","repos_url":"https://api.github.com/users/josephschorr/repos","events_url":"https://api.github.com/users/josephschorr/events{/privacy}","received_events_url":"https://api.github.com/users/josephschorr/received_events","type":"User","site_admin":false},"body":"This should be supporting both now","created_at":"2018-09-04T17:03:43Z","updated_at":"2018-09-04T17:03:43Z","html_url":"https://github.com/coreos/registry-monitor/pull/26#discussion_r214993522","pull_request_url":"https://api.github.com/repos/coreos/registry-monitor/pulls/26","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/coreos/registry-monitor/pulls/comments/214993522"},"html":{"href":"https://github.com/coreos/registry-monitor/pull/26#discussion_r214993522"},"pull_request":{"href":"https://api.github.com/repos/coreos/registry-monitor/pulls/26"}},"in_reply_to_id":214968625},"pull_request":{"url":"https://api.github.com/repos/coreos/registry-monitor/pulls/26","id":212477865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDc3ODY1","html_url":"https://github.com/coreos/registry-monitor/pull/26","diff_url":"https://github.com/coreos/registry-monitor/pull/26.diff","patch_url":"https://github.com/coreos/registry-monitor/pull/26.patch","issue_url":"https://api.github.com/repos/coreos/registry-monitor/issues/26","number":26,"state":"open","locked":false,"title":"Re-add support to monitor for reporting metrics to CloudWatch, in addition to the existing Prometheus","user":{"login":"josephschorr","id":4073002,"node_id":"MDQ6VXNlcjQwNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/4073002?v=4","gravatar_id":"","url":"https://api.github.com/users/josephschorr","html_url":"https://github.com/josephschorr","followers_url":"https://api.github.com/users/josephschorr/followers","following_url":"https://api.github.com/users/josephschorr/following{/other_user}","gists_url":"https://api.github.com/users/josephschorr/gists{/gist_id}","starred_url":"https://api.github.com/users/josephschorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephschorr/subscriptions","organizations_url":"https://api.github.com/users/josephschorr/orgs","repos_url":"https://api.github.com/users/josephschorr/repos","events_url":"https://api.github.com/users/josephschorr/events{/privacy}","received_events_url":"https://api.github.com/users/josephschorr/received_events","type":"User","site_admin":false},"body":"This will allow for those using CloudWatch (i.e. Quay.io team) to transition over with no loss of data","created_at":"2018-08-31T19:42:53Z","updated_at":"2018-09-04T17:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5272559b8e6ac3e8deddfe2dda7fd78888adaffd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/registry-monitor/pulls/26/commits","review_comments_url":"https://api.github.com/repos/coreos/registry-monitor/pulls/26/comments","review_comment_url":"https://api.github.com/repos/coreos/registry-monitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/registry-monitor/issues/26/comments","statuses_url":"https://api.github.com/repos/coreos/registry-monitor/statuses/ab2c1bf332100e3417c8f035b8913f1e21169248","head":{"label":"quay:cloudwatch","ref":"cloudwatch","sha":"ab2c1bf332100e3417c8f035b8913f1e21169248","user":{"login":"quay","id":38353654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzUzNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/38353654?v=4","gravatar_id":"","url":"https://api.github.com/users/quay","html_url":"https://github.com/quay","followers_url":"https://api.github.com/users/quay/followers","following_url":"https://api.github.com/users/quay/following{/other_user}","gists_url":"https://api.github.com/users/quay/gists{/gist_id}","starred_url":"https://api.github.com/users/quay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quay/subscriptions","organizations_url":"https://api.github.com/users/quay/orgs","repos_url":"https://api.github.com/users/quay/repos","events_url":"https://api.github.com/users/quay/events{/privacy}","received_events_url":"https://api.github.com/users/quay/received_events","type":"Organization","site_admin":false},"repo":{"id":146932607,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY5MzI2MDc=","name":"registry-monitor","full_name":"quay/registry-monitor","owner":{"login":"quay","id":38353654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzUzNjU0","avatar_url":"https://avatars3.githubusercontent.com/u/38353654?v=4","gravatar_id":"","url":"https://api.github.com/users/quay","html_url":"https://github.com/quay","followers_url":"https://api.github.com/users/quay/followers","following_url":"https://api.github.com/users/quay/following{/other_user}","gists_url":"https://api.github.com/users/quay/gists{/gist_id}","starred_url":"https://api.github.com/users/quay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quay/subscriptions","organizations_url":"https://api.github.com/users/quay/orgs","repos_url":"https://api.github.com/users/quay/repos","events_url":"https://api.github.com/users/quay/events{/privacy}","received_events_url":"https://api.github.com/users/quay/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quay/registry-monitor","description":"a simple server that pushes and pulls to a registry","fork":true,"url":"https://api.github.com/repos/quay/registry-monitor","forks_url":"https://api.github.com/repos/quay/registry-monitor/forks","keys_url":"https://api.github.com/repos/quay/registry-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quay/registry-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quay/registry-monitor/teams","hooks_url":"https://api.github.com/repos/quay/registry-monitor/hooks","issue_events_url":"https://api.github.com/repos/quay/registry-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/quay/registry-monitor/events","assignees_url":"https://api.github.com/repos/quay/registry-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/quay/registry-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/quay/registry-monitor/tags","blobs_url":"https://api.github.com/repos/quay/registry-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quay/registry-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quay/registry-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/quay/registry-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quay/registry-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/quay/registry-monitor/languages","stargazers_url":"https://api.github.com/repos/quay/registry-monitor/stargazers","contributors_url":"https://api.github.com/repos/quay/registry-monitor/contributors","subscribers_url":"https://api.github.com/repos/quay/registry-monitor/subscribers","subscription_url":"https://api.github.com/repos/quay/registry-monitor/subscription","commits_url":"https://api.github.com/repos/quay/registry-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/quay/registry-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/quay/registry-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/quay/registry-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/quay/registry-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/quay/registry-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quay/registry-monitor/merges","archive_url":"https://api.github.com/repos/quay/registry-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quay/registry-monitor/downloads","issues_url":"https://api.github.com/repos/quay/registry-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/quay/registry-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/quay/registry-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/quay/registry-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quay/registry-monitor/labels{/name}","releases_url":"https://api.github.com/repos/quay/registry-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/quay/registry-monitor/deployments","created_at":"2018-08-31T19:06:40Z","updated_at":"2018-08-31T19:06:42Z","pushed_at":"2018-08-31T19:42:39Z","git_url":"git://github.com/quay/registry-monitor.git","ssh_url":"git@github.com:quay/registry-monitor.git","clone_url":"https://github.com/quay/registry-monitor.git","svn_url":"https://github.com/quay/registry-monitor","homepage":"","size":44,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"a961594a0844842faa67cb9603d30dd2de8671c3","user":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":44697672,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY5NzY3Mg==","name":"registry-monitor","full_name":"coreos/registry-monitor","owner":{"login":"coreos","id":3730757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzA3NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/registry-monitor","description":"a simple server that pushes and pulls to a registry","fork":false,"url":"https://api.github.com/repos/coreos/registry-monitor","forks_url":"https://api.github.com/repos/coreos/registry-monitor/forks","keys_url":"https://api.github.com/repos/coreos/registry-monitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/registry-monitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/registry-monitor/teams","hooks_url":"https://api.github.com/repos/coreos/registry-monitor/hooks","issue_events_url":"https://api.github.com/repos/coreos/registry-monitor/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/registry-monitor/events","assignees_url":"https://api.github.com/repos/coreos/registry-monitor/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/registry-monitor/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/registry-monitor/tags","blobs_url":"https://api.github.com/repos/coreos/registry-monitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/registry-monitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/registry-monitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/registry-monitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/registry-monitor/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/registry-monitor/languages","stargazers_url":"https://api.github.com/repos/coreos/registry-monitor/stargazers","contributors_url":"https://api.github.com/repos/coreos/registry-monitor/contributors","subscribers_url":"https://api.github.com/repos/coreos/registry-monitor/subscribers","subscription_url":"https://api.github.com/repos/coreos/registry-monitor/subscription","commits_url":"https://api.github.com/repos/coreos/registry-monitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/registry-monitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/registry-monitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/registry-monitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/registry-monitor/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/registry-monitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/registry-monitor/merges","archive_url":"https://api.github.com/repos/coreos/registry-monitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/registry-monitor/downloads","issues_url":"https://api.github.com/repos/coreos/registry-monitor/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/registry-monitor/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/registry-monitor/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/registry-monitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/registry-monitor/labels{/name}","releases_url":"https://api.github.com/repos/coreos/registry-monitor/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/registry-monitor/deployments","created_at":"2015-10-21T18:57:40Z","updated_at":"2018-09-04T00:26:39Z","pushed_at":"2018-08-31T19:42:54Z","git_url":"git://github.com/coreos/registry-monitor.git","ssh_url":"git@github.com:coreos/registry-monitor.git","clone_url":"https://github.com/coreos/registry-monitor.git","svn_url":"https://github.com/coreos/registry-monitor","homepage":"","size":43,"stargazers_count":15,"watchers_count":15,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":2,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/registry-monitor/pulls/26"},"html":{"href":"https://github.com/coreos/registry-monitor/pull/26"},"issue":{"href":"https://api.github.com/repos/coreos/registry-monitor/issues/26"},"comments":{"href":"https://api.github.com/repos/coreos/registry-monitor/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/registry-monitor/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/registry-monitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/registry-monitor/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/registry-monitor/statuses/ab2c1bf332100e3417c8f035b8913f1e21169248"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"josephschorr"}}