{"action":"closed","issue":{"url":"https://api.github.com/repos/mikechoinoski/PuppyPlaytime/issues/3","repository_url":"https://api.github.com/repos/mikechoinoski/PuppyPlaytime","labels_url":"https://api.github.com/repos/mikechoinoski/PuppyPlaytime/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/mikechoinoski/PuppyPlaytime/issues/3/comments","events_url":"https://api.github.com/repos/mikechoinoski/PuppyPlaytime/issues/3/events","html_url":"https://github.com/mikechoinoski/PuppyPlaytime/issues/3","id":300064382,"number":3,"title":"Peer Review","user":{"login":"jaherrmann","id":31455307,"avatar_url":"https://avatars0.githubusercontent.com/u/31455307?v=4","gravatar_id":"","url":"https://api.github.com/users/jaherrmann","html_url":"https://github.com/jaherrmann","followers_url":"https://api.github.com/users/jaherrmann/followers","following_url":"https://api.github.com/users/jaherrmann/following{/other_user}","gists_url":"https://api.github.com/users/jaherrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/jaherrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaherrmann/subscriptions","organizations_url":"https://api.github.com/users/jaherrmann/orgs","repos_url":"https://api.github.com/users/jaherrmann/repos","events_url":"https://api.github.com/users/jaherrmann/events{/privacy}","received_events_url":"https://api.github.com/users/jaherrmann/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-25T21:43:35Z","updated_at":"2018-05-08T15:32:56Z","closed_at":"2018-05-08T15:32:56Z","author_association":"NONE","body":"# Design/Code Review 1\r\n\r\n## Project:\r\n\r\n### Developer:\r\n\r\n### Reviewer:\r\n\r\n|Item |Considerations| Comments/Suggestions|\r\n|--------|---------|---|\r\n|||Reviewer comments and suggestions go here. Each item should have *at least* one \"kudos\" and two suggestions for improvement|\r\n|**Problem Statement**|1. Accurately describes project purpose<br> 2. Is professional and free of typos, slang, etc.<br> 3. Fully explains the problem and the solution<br> 4. Is understandable by the average person| Your problem statement is clear, concise, and free of any glaring grammar mistakes. One suggestions is to address wether and to what extent owners will have profiles for their dogs. Another suggestion would be to add some mention of gender into the play-along calculation. I'm sure there's a few owners out there who would like something like that. |\r\n|**Design Documentation**|1. Navigation/flow through the application is logical and easy to use. <br>2. The order in which values are displayed are logical and easy to understand/use <br>3. The order in which the form fields entered are logical and easy to understand/use<br>4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens | Small typo in the application flow, under \"Search for playmate\" looks like you were going for \"User\" instead of \"Use\". Under \"show active playdate\" you mention that objects will be created for each playdate. Are those going to be playdate objects? How will they be implemented? |\r\n|**Data model/Database**|1. Everything on the screens and problem statement/flow is represented in the model <br> 2. There is at least one 1-to-many relationship.<br> 3. The model represents good database design <br>| The database design page looked good, it was pretty easy to see the flow of the database in regards to PK and FK relationships. It looks like the \"ways to play\" table is an island table right now. Was that intentional, or should it be relating to another table like \"Playdate\"? I like the level of detail you gave your screens. I would consider putting a sign-up or a log-in form right in the middle of the home page, perhaps after your description blurb.  |\r\n|**Code**|1. Proper Maven project structure is used<br> 2. a .gitignore file for IntelliJ Java projects has been implemented <br> 3. There is not any redundant or copy/paste code in the JSPs or classes<br> 4. Classes are appropriately-sized (no monster classes)<br> Property files are used appropriately: no hard-coded values <br> 5. Logging statements are used rather than System.out.println and printStackTrace.<br> 6. There are appropriate unit tests/code coverages.  | It's difficult to scrutinize the code here because everything seems to be well in order and there are no glaring problems--the javadoc looks good, and the beans are set up nicely. Looking at the code this is all nice, tight stuff. I may consider renaming generic dao to something more descriptive. There's a little inconsistent spacing in PackMemberDaoTest.java. In some methods you have a space after the method line, in others you don't. |\r\n  "}}
{"actor":{"display_login":"mikechoinoski"}}