{"action":"closed","number":570,"pull_request":{"url":"https://api.github.com/repos/travis-ci/worker/pulls/570","id":238403577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDAzNTc3","html_url":"https://github.com/travis-ci/worker/pull/570","diff_url":"https://github.com/travis-ci/worker/pull/570.diff","patch_url":"https://github.com/travis-ci/worker/pull/570.patch","issue_url":"https://api.github.com/repos/travis-ci/worker/issues/570","number":570,"state":"closed","locked":false,"title":"Add ready check endpoint for remote controller","user":{"login":"mjm","id":1181,"node_id":"MDQ6VXNlcjExODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1181?v=4","gravatar_id":"","url":"https://api.github.com/users/mjm","html_url":"https://github.com/mjm","followers_url":"https://api.github.com/users/mjm/followers","following_url":"https://api.github.com/users/mjm/following{/other_user}","gists_url":"https://api.github.com/users/mjm/gists{/gist_id}","starred_url":"https://api.github.com/users/mjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjm/subscriptions","organizations_url":"https://api.github.com/users/mjm/orgs","repos_url":"https://api.github.com/users/mjm/repos","events_url":"https://api.github.com/users/mjm/events{/privacy}","received_events_url":"https://api.github.com/users/mjm/received_events","type":"User","site_admin":false},"body":"## What is the problem that this PR is trying to fix?\r\n\r\nSometimes the worker operator makes requests to the HTTP API before the processor pool has started. This causes a crash because some properties of the ProcessorPool are not set until it's running.\r\n\r\n## What approach did you choose and why?\r\n\r\nAdd a ready check endpoint to the API which checks the pool for its readiness. We'll define a readiness probe for worker pods in Kubernetes so that the pod will not be considered ready until this check passes. It makes sense that the worker pod as a whole wouldn't be ready until the processor pool is up and running.\r\n\r\n## How can you test this?\r\n\r\nTest in staging with the worker-operator.\r\n\r\n## What feedback would you like, if any?\r\n\r\nAny.","created_at":"2018-12-13T14:12:20Z","updated_at":"2018-12-13T15:55:23Z","closed_at":"2018-12-13T15:55:23Z","merged_at":"2018-12-13T15:55:23Z","merge_commit_sha":"44d90d270944f607b072dbd21cc5001546a0bf52","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/travis-ci/worker/pulls/570/commits","review_comments_url":"https://api.github.com/repos/travis-ci/worker/pulls/570/comments","review_comment_url":"https://api.github.com/repos/travis-ci/worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/travis-ci/worker/issues/570/comments","statuses_url":"https://api.github.com/repos/travis-ci/worker/statuses/61913bc77fe56a04de8e3afe8f6f04fc56a68620","head":{"label":"travis-ci:mjm-ready-check","ref":"mjm-ready-check","sha":"61913bc77fe56a04de8e3afe8f6f04fc56a68620","user":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":27410275,"node_id":"MDEwOlJlcG9zaXRvcnkyNzQxMDI3NQ==","name":"worker","full_name":"travis-ci/worker","private":false,"owner":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/travis-ci/worker","description":"Worker runs your Travis CI jobs","fork":false,"url":"https://api.github.com/repos/travis-ci/worker","forks_url":"https://api.github.com/repos/travis-ci/worker/forks","keys_url":"https://api.github.com/repos/travis-ci/worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/worker/teams","hooks_url":"https://api.github.com/repos/travis-ci/worker/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/worker/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/worker/events","assignees_url":"https://api.github.com/repos/travis-ci/worker/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/worker/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/worker/tags","blobs_url":"https://api.github.com/repos/travis-ci/worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/worker/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/worker/languages","stargazers_url":"https://api.github.com/repos/travis-ci/worker/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/worker/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/worker/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/worker/subscription","commits_url":"https://api.github.com/repos/travis-ci/worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/worker/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/worker/merges","archive_url":"https://api.github.com/repos/travis-ci/worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/worker/downloads","issues_url":"https://api.github.com/repos/travis-ci/worker/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/worker/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/worker/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/worker/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/worker/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/worker/deployments","created_at":"2014-12-02T02:02:55Z","updated_at":"2018-12-13T15:19:41Z","pushed_at":"2018-12-13T15:55:23Z","git_url":"git://github.com/travis-ci/worker.git","ssh_url":"git@github.com:travis-ci/worker.git","clone_url":"https://github.com/travis-ci/worker.git","svn_url":"https://github.com/travis-ci/worker","homepage":"","size":5355,"stargazers_count":200,"watchers_count":200,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":14,"watchers":200,"default_branch":"master"}},"base":{"label":"travis-ci:master","ref":"master","sha":"a3c40c91297913d3a66ff1d2120337b6ccb36d94","user":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":27410275,"node_id":"MDEwOlJlcG9zaXRvcnkyNzQxMDI3NQ==","name":"worker","full_name":"travis-ci/worker","private":false,"owner":{"login":"travis-ci","id":639823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTgyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/639823?v=4","gravatar_id":"","url":"https://api.github.com/users/travis-ci","html_url":"https://github.com/travis-ci","followers_url":"https://api.github.com/users/travis-ci/followers","following_url":"https://api.github.com/users/travis-ci/following{/other_user}","gists_url":"https://api.github.com/users/travis-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/travis-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travis-ci/subscriptions","organizations_url":"https://api.github.com/users/travis-ci/orgs","repos_url":"https://api.github.com/users/travis-ci/repos","events_url":"https://api.github.com/users/travis-ci/events{/privacy}","received_events_url":"https://api.github.com/users/travis-ci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/travis-ci/worker","description":"Worker runs your Travis CI jobs","fork":false,"url":"https://api.github.com/repos/travis-ci/worker","forks_url":"https://api.github.com/repos/travis-ci/worker/forks","keys_url":"https://api.github.com/repos/travis-ci/worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travis-ci/worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travis-ci/worker/teams","hooks_url":"https://api.github.com/repos/travis-ci/worker/hooks","issue_events_url":"https://api.github.com/repos/travis-ci/worker/issues/events{/number}","events_url":"https://api.github.com/repos/travis-ci/worker/events","assignees_url":"https://api.github.com/repos/travis-ci/worker/assignees{/user}","branches_url":"https://api.github.com/repos/travis-ci/worker/branches{/branch}","tags_url":"https://api.github.com/repos/travis-ci/worker/tags","blobs_url":"https://api.github.com/repos/travis-ci/worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travis-ci/worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travis-ci/worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/travis-ci/worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travis-ci/worker/statuses/{sha}","languages_url":"https://api.github.com/repos/travis-ci/worker/languages","stargazers_url":"https://api.github.com/repos/travis-ci/worker/stargazers","contributors_url":"https://api.github.com/repos/travis-ci/worker/contributors","subscribers_url":"https://api.github.com/repos/travis-ci/worker/subscribers","subscription_url":"https://api.github.com/repos/travis-ci/worker/subscription","commits_url":"https://api.github.com/repos/travis-ci/worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/travis-ci/worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/travis-ci/worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/travis-ci/worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/travis-ci/worker/contents/{+path}","compare_url":"https://api.github.com/repos/travis-ci/worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travis-ci/worker/merges","archive_url":"https://api.github.com/repos/travis-ci/worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travis-ci/worker/downloads","issues_url":"https://api.github.com/repos/travis-ci/worker/issues{/number}","pulls_url":"https://api.github.com/repos/travis-ci/worker/pulls{/number}","milestones_url":"https://api.github.com/repos/travis-ci/worker/milestones{/number}","notifications_url":"https://api.github.com/repos/travis-ci/worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travis-ci/worker/labels{/name}","releases_url":"https://api.github.com/repos/travis-ci/worker/releases{/id}","deployments_url":"https://api.github.com/repos/travis-ci/worker/deployments","created_at":"2014-12-02T02:02:55Z","updated_at":"2018-12-13T15:19:41Z","pushed_at":"2018-12-13T15:55:23Z","git_url":"git://github.com/travis-ci/worker.git","ssh_url":"git@github.com:travis-ci/worker.git","clone_url":"https://github.com/travis-ci/worker.git","svn_url":"https://github.com/travis-ci/worker","homepage":"","size":5355,"stargazers_count":200,"watchers_count":200,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":14,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/570"},"html":{"href":"https://github.com/travis-ci/worker/pull/570"},"issue":{"href":"https://api.github.com/repos/travis-ci/worker/issues/570"},"comments":{"href":"https://api.github.com/repos/travis-ci/worker/issues/570/comments"},"review_comments":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/570/comments"},"review_comment":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/travis-ci/worker/pulls/570/commits"},"statuses":{"href":"https://api.github.com/repos/travis-ci/worker/statuses/61913bc77fe56a04de8e3afe8f6f04fc56a68620"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mjm","id":1181,"node_id":"MDQ6VXNlcjExODE=","avatar_url":"https://avatars2.githubusercontent.com/u/1181?v=4","gravatar_id":"","url":"https://api.github.com/users/mjm","html_url":"https://github.com/mjm","followers_url":"https://api.github.com/users/mjm/followers","following_url":"https://api.github.com/users/mjm/following{/other_user}","gists_url":"https://api.github.com/users/mjm/gists{/gist_id}","starred_url":"https://api.github.com/users/mjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjm/subscriptions","organizations_url":"https://api.github.com/users/mjm/orgs","repos_url":"https://api.github.com/users/mjm/repos","events_url":"https://api.github.com/users/mjm/events{/privacy}","received_events_url":"https://api.github.com/users/mjm/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":19,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"mjm"}}