{"action":"created","comment":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments/234307341","pull_request_review_id":175928975,"id":234307341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDMwNzM0MQ==","diff_hunk":"@@ -64,9 +64,9 @@ def __init__(self, entry_point, use_mpi=None, num_processes=None, process_slots_\n                 set to the number of GPUs on the instance (on GPU instances), or one (on CPU instances).\n             additional_mpi_options (str): String of options to the 'mpirun' command used to run the entry point.\n                 For example, '-X NCCL_DEBUG=WARN' will pass that option string to the mpirun command.\n-            source_dir (str): Path (absolute or relative) to a directory with any other training\n-                source code dependencies aside from tne entry point file (default: None). Structure within this\n-                directory are preserved when training on Amazon SageMaker.\n+            source_dir (str or [str]): Single path (absolute or relative) or a list of paths to directories with","path":"src/sagemaker/chainer/estimator.py","position":7,"original_position":7,"commit_id":"a04affc7562ba03a730285639fd2625cd9c940d9","original_commit_id":"a04affc7562ba03a730285639fd2625cd9c940d9","user":{"login":"laurenyu","id":6631887,"node_id":"MDQ6VXNlcjY2MzE4ODc=","avatar_url":"https://avatars2.githubusercontent.com/u/6631887?v=4","gravatar_id":"","url":"https://api.github.com/users/laurenyu","html_url":"https://github.com/laurenyu","followers_url":"https://api.github.com/users/laurenyu/followers","following_url":"https://api.github.com/users/laurenyu/following{/other_user}","gists_url":"https://api.github.com/users/laurenyu/gists{/gist_id}","starred_url":"https://api.github.com/users/laurenyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurenyu/subscriptions","organizations_url":"https://api.github.com/users/laurenyu/orgs","repos_url":"https://api.github.com/users/laurenyu/repos","events_url":"https://api.github.com/users/laurenyu/events{/privacy}","received_events_url":"https://api.github.com/users/laurenyu/received_events","type":"User","site_admin":false},"body":"let's be more explicit and use `list[str]` for lists. also I'd change it to \"A single path\"","created_at":"2018-11-16T18:37:30Z","updated_at":"2018-11-16T18:53:57Z","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/494#discussion_r234307341","pull_request_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments/234307341"},"html":{"href":"https://github.com/aws/sagemaker-python-sdk/pull/494#discussion_r234307341"},"pull_request":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494"}}},"pull_request":{"url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494","id":231465247,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDY1MjQ3","html_url":"https://github.com/aws/sagemaker-python-sdk/pull/494","diff_url":"https://github.com/aws/sagemaker-python-sdk/pull/494.diff","patch_url":"https://github.com/aws/sagemaker-python-sdk/pull/494.patch","issue_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/494","number":494,"state":"open","locked":false,"title":"Add support for additional files","user":{"login":"mvsusp","id":142074,"node_id":"MDQ6VXNlcjE0MjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/142074?v=4","gravatar_id":"","url":"https://api.github.com/users/mvsusp","html_url":"https://github.com/mvsusp","followers_url":"https://api.github.com/users/mvsusp/followers","following_url":"https://api.github.com/users/mvsusp/following{/other_user}","gists_url":"https://api.github.com/users/mvsusp/gists{/gist_id}","starred_url":"https://api.github.com/users/mvsusp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvsusp/subscriptions","organizations_url":"https://api.github.com/users/mvsusp/orgs","repos_url":"https://api.github.com/users/mvsusp/repos","events_url":"https://api.github.com/users/mvsusp/events{/privacy}","received_events_url":"https://api.github.com/users/mvsusp/received_events","type":"User","site_admin":false},"body":"*Issue #, if available:*\r\n\r\n*Description of changes:*\r\n\r\n## Merge Checklist\r\n\r\n_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request._\r\n\r\n- [X] I have read the [CONTRIBUTING](https://github.com/aws/sagemaker-python-sdk/blob/master/CONTRIBUTING.md) doc\r\n- [X] I have added tests that prove my fix is effective or that my feature works (if appropriate)\r\n- [X] I have updated the [changelog](https://github.com/aws/sagemaker-python-sdk/blob/master/CHANGELOG.rst) with a description of my changes (if appropriate)\r\n- [X] I have updated any necessary [documentation](https://github.com/aws/sagemaker-python-sdk/blob/master/README.rst) (if appropriate)\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-11-16T09:27:07Z","updated_at":"2018-11-16T18:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b37b591ca97e8af29ee95fa15efdcfa10d584d21","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nadiaya","id":32335935,"node_id":"MDQ6VXNlcjMyMzM1OTM1","avatar_url":"https://avatars2.githubusercontent.com/u/32335935?v=4","gravatar_id":"","url":"https://api.github.com/users/nadiaya","html_url":"https://github.com/nadiaya","followers_url":"https://api.github.com/users/nadiaya/followers","following_url":"https://api.github.com/users/nadiaya/following{/other_user}","gists_url":"https://api.github.com/users/nadiaya/gists{/gist_id}","starred_url":"https://api.github.com/users/nadiaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadiaya/subscriptions","organizations_url":"https://api.github.com/users/nadiaya/orgs","repos_url":"https://api.github.com/users/nadiaya/repos","events_url":"https://api.github.com/users/nadiaya/events{/privacy}","received_events_url":"https://api.github.com/users/nadiaya/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494/commits","review_comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494/comments","review_comment_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/494/comments","statuses_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/a04affc7562ba03a730285639fd2625cd9c940d9","head":{"label":"mvsusp:mvs-many-src-dirs","ref":"mvs-many-src-dirs","sha":"a04affc7562ba03a730285639fd2625cd9c940d9","user":{"login":"mvsusp","id":142074,"node_id":"MDQ6VXNlcjE0MjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/142074?v=4","gravatar_id":"","url":"https://api.github.com/users/mvsusp","html_url":"https://github.com/mvsusp","followers_url":"https://api.github.com/users/mvsusp/followers","following_url":"https://api.github.com/users/mvsusp/following{/other_user}","gists_url":"https://api.github.com/users/mvsusp/gists{/gist_id}","starred_url":"https://api.github.com/users/mvsusp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvsusp/subscriptions","organizations_url":"https://api.github.com/users/mvsusp/orgs","repos_url":"https://api.github.com/users/mvsusp/repos","events_url":"https://api.github.com/users/mvsusp/events{/privacy}","received_events_url":"https://api.github.com/users/mvsusp/received_events","type":"User","site_admin":false},"repo":{"id":113504913,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1MDQ5MTM=","name":"sagemaker-python-sdk","full_name":"mvsusp/sagemaker-python-sdk","private":false,"owner":{"login":"mvsusp","id":142074,"node_id":"MDQ6VXNlcjE0MjA3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/142074?v=4","gravatar_id":"","url":"https://api.github.com/users/mvsusp","html_url":"https://github.com/mvsusp","followers_url":"https://api.github.com/users/mvsusp/followers","following_url":"https://api.github.com/users/mvsusp/following{/other_user}","gists_url":"https://api.github.com/users/mvsusp/gists{/gist_id}","starred_url":"https://api.github.com/users/mvsusp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvsusp/subscriptions","organizations_url":"https://api.github.com/users/mvsusp/orgs","repos_url":"https://api.github.com/users/mvsusp/repos","events_url":"https://api.github.com/users/mvsusp/events{/privacy}","received_events_url":"https://api.github.com/users/mvsusp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mvsusp/sagemaker-python-sdk","description":"A library for training and deploying machine learning models on Amazon SageMaker","fork":true,"url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk","forks_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/forks","keys_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/teams","hooks_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/hooks","issue_events_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/events","assignees_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/tags","blobs_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/languages","stargazers_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/stargazers","contributors_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/contributors","subscribers_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/subscribers","subscription_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/subscription","commits_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/merges","archive_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/downloads","issues_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/mvsusp/sagemaker-python-sdk/deployments","created_at":"2017-12-07T22:28:45Z","updated_at":"2018-10-08T17:03:30Z","pushed_at":"2018-11-16T14:05:56Z","git_url":"git://github.com/mvsusp/sagemaker-python-sdk.git","ssh_url":"git@github.com:mvsusp/sagemaker-python-sdk.git","clone_url":"https://github.com/mvsusp/sagemaker-python-sdk.git","svn_url":"https://github.com/mvsusp/sagemaker-python-sdk","homepage":"","size":52955,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"641299102c35645391e31940181710ee4736a706","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":110621895,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA2MjE4OTU=","name":"sagemaker-python-sdk","full_name":"aws/sagemaker-python-sdk","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/sagemaker-python-sdk","description":"A library for training and deploying machine learning models on Amazon SageMaker","fork":false,"url":"https://api.github.com/repos/aws/sagemaker-python-sdk","forks_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/forks","keys_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/teams","hooks_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/hooks","issue_events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/events","assignees_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/tags","blobs_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/languages","stargazers_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/stargazers","contributors_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/contributors","subscribers_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/subscribers","subscription_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/subscription","commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/merges","archive_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/downloads","issues_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aws/sagemaker-python-sdk/deployments","created_at":"2017-11-14T01:03:33Z","updated_at":"2018-11-16T17:11:28Z","pushed_at":"2018-11-16T17:11:26Z","git_url":"git://github.com/aws/sagemaker-python-sdk.git","ssh_url":"git@github.com:aws/sagemaker-python-sdk.git","clone_url":"https://github.com/aws/sagemaker-python-sdk.git","svn_url":"https://github.com/aws/sagemaker-python-sdk","homepage":"","size":52928,"stargazers_count":380,"watchers_count":380,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":169,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":169,"open_issues":58,"watchers":380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494"},"html":{"href":"https://github.com/aws/sagemaker-python-sdk/pull/494"},"issue":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/494"},"comments":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/issues/494/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/pulls/494/commits"},"statuses":{"href":"https://api.github.com/repos/aws/sagemaker-python-sdk/statuses/a04affc7562ba03a730285639fd2625cd9c940d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"laurenyu"}}