{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/23094","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/23094/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23094/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/23094/events","html_url":"https://github.com/nodejs/node/pull/23094","id":363794477,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTQxNzM3","number":23094,"title":"src: use JS inheritance for `AsyncWrap`","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-25T22:46:56Z","updated_at":"2018-09-29T01:34:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23094","html_url":"https://github.com/nodejs/node/pull/23094","diff_url":"https://github.com/nodejs/node/pull/23094.diff","patch_url":"https://github.com/nodejs/node/pull/23094.patch"},"body":"For all classes descending from `AsyncWrap`, use JS inheritance\r\ninstead of manually adding methods to the individual classes.\r\n\r\nThis allows cleanup of some code around transferring handles\r\nover IPC.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/425605121","html_url":"https://github.com/nodejs/node/pull/23094#issuecomment-425605121","issue_url":"https://api.github.com/repos/nodejs/node/issues/23094","id":425605121,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTYwNTEyMQ==","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T01:34:46Z","updated_at":"2018-09-29T01:34:46Z","author_association":"MEMBER","body":"@jasnell I think this will require a backport PR for v10.x anyway … let’s run CITGM on that as well, that should give a much clearer picture."}}
{"actor":{"display_login":"addaleax"}}