{"action":"created","issue":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/792","repository_url":"https://api.github.com/repos/StrikeNP/trac_test","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/792/labels{/name}","comments_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/792/comments","events_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/792/events","html_url":"https://github.com/StrikeNP/trac_test/issues/792","id":332200653,"node_id":"MDU6SXNzdWUzMzIyMDA2NTM=","number":792,"title":"Add warning and diagnostic to calculation of spurious supersaturation (Trac #792)","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"labels":[{"id":963997231,"node_id":"MDU6TGFiZWw5NjM5OTcyMzE=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/Migrated%20from%20Trac","name":"Migrated from Trac","color":"FFFFFF","default":false},{"id":963997516,"node_id":"MDU6TGFiZWw5NjM5OTc1MTY=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/clubb_src","name":"clubb_src","color":"FFFFFF","default":false},{"id":963997043,"node_id":"MDU6TGFiZWw5NjM5OTcwNDM=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":963997810,"node_id":"MDU6TGFiZWw5NjM5OTc4MTA=","url":"https://api.github.com/repos/StrikeNP/trac_test/labels/vlarson@uwm.edu","name":"vlarson@uwm.edu","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/14","html_url":"https://github.com/StrikeNP/trac_test/milestone/14","labels_url":"https://api.github.com/repos/StrikeNP/trac_test/milestones/14/labels","id":3423346,"node_id":"MDk6TWlsZXN0b25lMzQyMzM0Ng==","number":14,"title":"Add new nightly tests, assertion checks, and unit tests","description":null,"creator":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":9,"state":"open","created_at":"2018-06-13T21:38:27Z","updated_at":"2018-06-16T14:15:46Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-06-13T23:28:53Z","updated_at":"2018-06-16T15:35:26Z","closed_at":null,"author_association":"OWNER","body":"\n**Introduction**\n\nPete Bogenschutz of NCAR, at the behest of Chuck Bardeen, added code to `advance_clubb_core` that removes spurious supersaturation created by use of the trapezoidal rule.  CAM-CLUBB-ZM uses this code, but we suspect that it is not necessary for CLUBB standalone if the trapezoidal rule is shut off.  Nevertheless, it would be comforting to have an assertion check in place, even in CLUBB standalone.  \n\n**Technical spec**\n\nHence, let's set \n\n```text\nl_vert_avg_closure  = .false.\nl_trapezoidal_rule_zt = .false.\nl_trapezoidal_rule_zm = .false.\nl_call_pdf_closure_twice = .false.\nl_use_cloud_cover = .false.\n```\nin CLUBB's model_flags.\n\nThen let's add a warning message and netcdf output (of `rcm_supersat_adj`) to this code.  Furthermore, let's remove the CLUBB_CAM preprocessor flag.  \n\n**Test**\n\nLet's hope that `rcm_supersat_adj` is small.  \n\nAttachments:\n\n[newflags_test.diff](https://github.com/larson-group/trac_attachment_archive/blob/master/clubb/newflags_test.diff)\n[newflags_test.maff](https://github.com/larson-group/trac_attachment_archive/blob/master/clubb/newflags_test.maff)\n[rcm_supersat_adj_compare.png](https://github.com/larson-group/trac_attachment_archive/blob/master/clubb/rcm_supersat_adj_compare.png)\n\nMigrated from http://carson.math.uwm.edu/trac/clubb/ticket/792\n```json\n{\n    \"status\": \"assigned\", \n    \"changetime\": \"2018-03-13T20:51:40\", \n    \"description\": \"\\n'''Introduction'''\\n\\nPete Bogenschutz of NCAR, at the behest of Chuck Bardeen, added code to `advance_clubb_core` that removes spurious supersaturation created by use of the trapezoidal rule.  CAM-CLUBB-ZM uses this code, but we suspect that it is not necessary for CLUBB standalone if the trapezoidal rule is shut off.  Nevertheless, it would be comforting to have an assertion check in place, even in CLUBB standalone.  \\n\\n'''Technical spec'''\\n\\nHence, let's set \\n{{{\\nl_vert_avg_closure  = .false.\\nl_trapezoidal_rule_zt = .false.\\nl_trapezoidal_rule_zm = .false.\\nl_call_pdf_closure_twice = .false.\\nl_use_cloud_cover = .false.\\n}}}\\nin CLUBB's model_flags.\\n\\nThen let's add a warning message and netcdf output (of `rcm_supersat_adj`) to this code.  Furthermore, let's remove the CLUBB_CAM preprocessor flag.  \\n\\n'''Test'''\\n\\nLet's hope that `rcm_supersat_adj` is small.  \", \n    \"reporter\": \"vlarson@uwm.edu\", \n    \"cc\": \"vlarson@uwm.edu\", \n    \"resolution\": \"\", \n    \"_ts\": \"1520974300479865\", \n    \"component\": \"clubb_src\", \n    \"summary\": \"Add warning and diagnostic to calculation of spurious supersaturation\", \n    \"priority\": \"major\", \n    \"keywords\": \"\", \n    \"time\": \"2016-07-15T18:15:50\", \n    \"milestone\": \"Add new nightly tests, assertion checks, and unit tests\", \n    \"owner\": \"vlarson@uwm.edu\", \n    \"type\": \"enhancement\"\n}\n```\n"},"comment":{"url":"https://api.github.com/repos/StrikeNP/trac_test/issues/comments/397820065","html_url":"https://github.com/StrikeNP/trac_test/issues/792#issuecomment-397820065","issue_url":"https://api.github.com/repos/StrikeNP/trac_test/issues/792","id":397820065,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzgyMDA2NQ==","user":{"login":"StrikeNP","id":2577059,"node_id":"MDQ6VXNlcjI1NzcwNTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2577059?v=4","gravatar_id":"","url":"https://api.github.com/users/StrikeNP","html_url":"https://github.com/StrikeNP","followers_url":"https://api.github.com/users/StrikeNP/followers","following_url":"https://api.github.com/users/StrikeNP/following{/other_user}","gists_url":"https://api.github.com/users/StrikeNP/gists{/gist_id}","starred_url":"https://api.github.com/users/StrikeNP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StrikeNP/subscriptions","organizations_url":"https://api.github.com/users/StrikeNP/orgs","repos_url":"https://api.github.com/users/StrikeNP/repos","events_url":"https://api.github.com/users/StrikeNP/events{/privacy}","received_events_url":"https://api.github.com/users/StrikeNP/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T15:35:26Z","updated_at":"2018-06-16T15:35:26Z","author_association":"OWNER","body":"**Trac update on 2016/07/19 at 00:38**\n**raut@uwm.edu commented:**\n\nCommit comment from clubb:r8201:\n\nFor https://github.com/larson-group/clubb/issues/792:\n\nI initialized some variables that were before uninitialized when `l_vert_avg_closure = F`. These uninitialized variables were used only for stats.\n\nThis commit is BIT_CHANGING in the \"_zm\" output file because some variables, such as `cloud_frac_zm`, that were output as undefined before are now output as zero. However, the simulation result does not change as a result of this commit.\n\n\n\n"}}
{"actor":{"display_login":"StrikeNP"}}