{"action":"created","comment":{"url":"https://api.github.com/repos/CompFUSE/DCA/pulls/comments/225445899","pull_request_review_id":165043213,"id":225445899,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ0NTg5OQ==","diff_hunk":"@@ -360,11 +367,12 @@ void CtauxClusterSolver<device_t, parameters_type, Data>::compute_error_bars() {\n   func::function<std::complex<double>, func::dmn_variadic<nu, nu, KClusterDmn, w>> M_k_w_new(\n       \"M_k_w_new\");\n \n+  accumulator.finalize();\n   const int nb_measurements = accumulator.get_number_of_measurements();","path":"include/dca/phys/dca_step/cluster_solver/ctaux/ctaux_cluster_solver.hpp","position":null,"original_position":79,"commit_id":"d8b383ae39d896cb5b99385a58f2840aca603a51","original_commit_id":"0aa7fb4de9e531e8189d6c0a628797a8627545e4","user":{"login":"gbalduzz","id":11310640,"node_id":"MDQ6VXNlcjExMzEwNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/11310640?v=4","gravatar_id":"","url":"https://api.github.com/users/gbalduzz","html_url":"https://github.com/gbalduzz","followers_url":"https://api.github.com/users/gbalduzz/followers","following_url":"https://api.github.com/users/gbalduzz/following{/other_user}","gists_url":"https://api.github.com/users/gbalduzz/gists{/gist_id}","starred_url":"https://api.github.com/users/gbalduzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbalduzz/subscriptions","organizations_url":"https://api.github.com/users/gbalduzz/orgs","repos_url":"https://api.github.com/users/gbalduzz/repos","events_url":"https://api.github.com/users/gbalduzz/events{/privacy}","received_events_url":"https://api.github.com/users/gbalduzz/received_events","type":"User","site_admin":false},"body":"This function should have returned an integer to begin with. Fixed in d8b383ae39d896cb5b99385a58f2840aca603a51.","created_at":"2018-10-16T08:37:17Z","updated_at":"2018-10-16T08:37:17Z","html_url":"https://github.com/CompFUSE/DCA/pull/39#discussion_r225445899","pull_request_url":"https://api.github.com/repos/CompFUSE/DCA/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CompFUSE/DCA/pulls/comments/225445899"},"html":{"href":"https://github.com/CompFUSE/DCA/pull/39#discussion_r225445899"},"pull_request":{"href":"https://api.github.com/repos/CompFUSE/DCA/pulls/39"}},"in_reply_to_id":225261682},"pull_request":{"url":"https://api.github.com/repos/CompFUSE/DCA/pulls/39","id":215761306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzYxMzA2","html_url":"https://github.com/CompFUSE/DCA/pull/39","diff_url":"https://github.com/CompFUSE/DCA/pull/39.diff","patch_url":"https://github.com/CompFUSE/DCA/pull/39.patch","issue_url":"https://api.github.com/repos/CompFUSE/DCA/issues/39","number":39,"state":"open","locked":false,"title":"Mc accumulator","user":{"login":"gbalduzz","id":11310640,"node_id":"MDQ6VXNlcjExMzEwNjQw","avatar_url":"https://avatars3.githubusercontent.com/u/11310640?v=4","gravatar_id":"","url":"https://api.github.com/users/gbalduzz","html_url":"https://github.com/gbalduzz","followers_url":"https://api.github.com/users/gbalduzz/followers","following_url":"https://api.github.com/users/gbalduzz/following{/other_user}","gists_url":"https://api.github.com/users/gbalduzz/gists{/gist_id}","starred_url":"https://api.github.com/users/gbalduzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbalduzz/subscriptions","organizations_url":"https://api.github.com/users/gbalduzz/orgs","repos_url":"https://api.github.com/users/gbalduzz/repos","events_url":"https://api.github.com/users/gbalduzz/events{/privacy}","received_events_url":"https://api.github.com/users/gbalduzz/received_events","type":"User","site_admin":false},"body":"~Depends on #33, #28, #38  and #34.~\r\nThe CT-AUX solver now uses the new accumulators and the performance of gpu_trunk is almost reached. Changes to the interface of SS-HYB have been made as well. While a full cleanup of ctaux solver, walker, and accumulator might be useful, it can be done later. For the moment I reserve the right to make minor cosmetic changes until the dependencies are merged.\r\nThe statistical tests pass.","created_at":"2018-09-15T09:52:50Z","updated_at":"2018-10-16T08:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb3e1f96dc7c414fae593de3f36c909e4137e05","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CompFUSE/DCA/pulls/39/commits","review_comments_url":"https://api.github.com/repos/CompFUSE/DCA/pulls/39/comments","review_comment_url":"https://api.github.com/repos/CompFUSE/DCA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CompFUSE/DCA/issues/39/comments","statuses_url":"https://api.github.com/repos/CompFUSE/DCA/statuses/d8b383ae39d896cb5b99385a58f2840aca603a51","head":{"label":"CompFUSE:MC_accumulator","ref":"MC_accumulator","sha":"d8b383ae39d896cb5b99385a58f2840aca603a51","user":{"login":"CompFUSE","id":40608494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjA4NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/40608494?v=4","gravatar_id":"","url":"https://api.github.com/users/CompFUSE","html_url":"https://github.com/CompFUSE","followers_url":"https://api.github.com/users/CompFUSE/followers","following_url":"https://api.github.com/users/CompFUSE/following{/other_user}","gists_url":"https://api.github.com/users/CompFUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/CompFUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompFUSE/subscriptions","organizations_url":"https://api.github.com/users/CompFUSE/orgs","repos_url":"https://api.github.com/users/CompFUSE/repos","events_url":"https://api.github.com/users/CompFUSE/events{/privacy}","received_events_url":"https://api.github.com/users/CompFUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":141548240,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NDgyNDA=","name":"DCA","full_name":"CompFUSE/DCA","private":false,"owner":{"login":"CompFUSE","id":40608494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjA4NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/40608494?v=4","gravatar_id":"","url":"https://api.github.com/users/CompFUSE","html_url":"https://github.com/CompFUSE","followers_url":"https://api.github.com/users/CompFUSE/followers","following_url":"https://api.github.com/users/CompFUSE/following{/other_user}","gists_url":"https://api.github.com/users/CompFUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/CompFUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompFUSE/subscriptions","organizations_url":"https://api.github.com/users/CompFUSE/orgs","repos_url":"https://api.github.com/users/CompFUSE/repos","events_url":"https://api.github.com/users/CompFUSE/events{/privacy}","received_events_url":"https://api.github.com/users/CompFUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CompFUSE/DCA","description":"DCA++","fork":false,"url":"https://api.github.com/repos/CompFUSE/DCA","forks_url":"https://api.github.com/repos/CompFUSE/DCA/forks","keys_url":"https://api.github.com/repos/CompFUSE/DCA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CompFUSE/DCA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CompFUSE/DCA/teams","hooks_url":"https://api.github.com/repos/CompFUSE/DCA/hooks","issue_events_url":"https://api.github.com/repos/CompFUSE/DCA/issues/events{/number}","events_url":"https://api.github.com/repos/CompFUSE/DCA/events","assignees_url":"https://api.github.com/repos/CompFUSE/DCA/assignees{/user}","branches_url":"https://api.github.com/repos/CompFUSE/DCA/branches{/branch}","tags_url":"https://api.github.com/repos/CompFUSE/DCA/tags","blobs_url":"https://api.github.com/repos/CompFUSE/DCA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CompFUSE/DCA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CompFUSE/DCA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CompFUSE/DCA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CompFUSE/DCA/statuses/{sha}","languages_url":"https://api.github.com/repos/CompFUSE/DCA/languages","stargazers_url":"https://api.github.com/repos/CompFUSE/DCA/stargazers","contributors_url":"https://api.github.com/repos/CompFUSE/DCA/contributors","subscribers_url":"https://api.github.com/repos/CompFUSE/DCA/subscribers","subscription_url":"https://api.github.com/repos/CompFUSE/DCA/subscription","commits_url":"https://api.github.com/repos/CompFUSE/DCA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CompFUSE/DCA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CompFUSE/DCA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CompFUSE/DCA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CompFUSE/DCA/contents/{+path}","compare_url":"https://api.github.com/repos/CompFUSE/DCA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CompFUSE/DCA/merges","archive_url":"https://api.github.com/repos/CompFUSE/DCA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CompFUSE/DCA/downloads","issues_url":"https://api.github.com/repos/CompFUSE/DCA/issues{/number}","pulls_url":"https://api.github.com/repos/CompFUSE/DCA/pulls{/number}","milestones_url":"https://api.github.com/repos/CompFUSE/DCA/milestones{/number}","notifications_url":"https://api.github.com/repos/CompFUSE/DCA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CompFUSE/DCA/labels{/name}","releases_url":"https://api.github.com/repos/CompFUSE/DCA/releases{/id}","deployments_url":"https://api.github.com/repos/CompFUSE/DCA/deployments","created_at":"2018-07-19T08:26:56Z","updated_at":"2018-10-10T18:30:02Z","pushed_at":"2018-10-16T08:35:41Z","git_url":"git://github.com/CompFUSE/DCA.git","ssh_url":"git@github.com:CompFUSE/DCA.git","clone_url":"https://github.com/CompFUSE/DCA.git","svn_url":"https://github.com/CompFUSE/DCA","homepage":null,"size":99224,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":17,"watchers":7,"default_branch":"master"}},"base":{"label":"CompFUSE:master","ref":"master","sha":"0de7ea48390f6ee2ddc7fbdc7695fdfaa5957d49","user":{"login":"CompFUSE","id":40608494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjA4NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/40608494?v=4","gravatar_id":"","url":"https://api.github.com/users/CompFUSE","html_url":"https://github.com/CompFUSE","followers_url":"https://api.github.com/users/CompFUSE/followers","following_url":"https://api.github.com/users/CompFUSE/following{/other_user}","gists_url":"https://api.github.com/users/CompFUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/CompFUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompFUSE/subscriptions","organizations_url":"https://api.github.com/users/CompFUSE/orgs","repos_url":"https://api.github.com/users/CompFUSE/repos","events_url":"https://api.github.com/users/CompFUSE/events{/privacy}","received_events_url":"https://api.github.com/users/CompFUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":141548240,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE1NDgyNDA=","name":"DCA","full_name":"CompFUSE/DCA","private":false,"owner":{"login":"CompFUSE","id":40608494,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjA4NDk0","avatar_url":"https://avatars2.githubusercontent.com/u/40608494?v=4","gravatar_id":"","url":"https://api.github.com/users/CompFUSE","html_url":"https://github.com/CompFUSE","followers_url":"https://api.github.com/users/CompFUSE/followers","following_url":"https://api.github.com/users/CompFUSE/following{/other_user}","gists_url":"https://api.github.com/users/CompFUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/CompFUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompFUSE/subscriptions","organizations_url":"https://api.github.com/users/CompFUSE/orgs","repos_url":"https://api.github.com/users/CompFUSE/repos","events_url":"https://api.github.com/users/CompFUSE/events{/privacy}","received_events_url":"https://api.github.com/users/CompFUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CompFUSE/DCA","description":"DCA++","fork":false,"url":"https://api.github.com/repos/CompFUSE/DCA","forks_url":"https://api.github.com/repos/CompFUSE/DCA/forks","keys_url":"https://api.github.com/repos/CompFUSE/DCA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CompFUSE/DCA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CompFUSE/DCA/teams","hooks_url":"https://api.github.com/repos/CompFUSE/DCA/hooks","issue_events_url":"https://api.github.com/repos/CompFUSE/DCA/issues/events{/number}","events_url":"https://api.github.com/repos/CompFUSE/DCA/events","assignees_url":"https://api.github.com/repos/CompFUSE/DCA/assignees{/user}","branches_url":"https://api.github.com/repos/CompFUSE/DCA/branches{/branch}","tags_url":"https://api.github.com/repos/CompFUSE/DCA/tags","blobs_url":"https://api.github.com/repos/CompFUSE/DCA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CompFUSE/DCA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CompFUSE/DCA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CompFUSE/DCA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CompFUSE/DCA/statuses/{sha}","languages_url":"https://api.github.com/repos/CompFUSE/DCA/languages","stargazers_url":"https://api.github.com/repos/CompFUSE/DCA/stargazers","contributors_url":"https://api.github.com/repos/CompFUSE/DCA/contributors","subscribers_url":"https://api.github.com/repos/CompFUSE/DCA/subscribers","subscription_url":"https://api.github.com/repos/CompFUSE/DCA/subscription","commits_url":"https://api.github.com/repos/CompFUSE/DCA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CompFUSE/DCA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CompFUSE/DCA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CompFUSE/DCA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CompFUSE/DCA/contents/{+path}","compare_url":"https://api.github.com/repos/CompFUSE/DCA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CompFUSE/DCA/merges","archive_url":"https://api.github.com/repos/CompFUSE/DCA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CompFUSE/DCA/downloads","issues_url":"https://api.github.com/repos/CompFUSE/DCA/issues{/number}","pulls_url":"https://api.github.com/repos/CompFUSE/DCA/pulls{/number}","milestones_url":"https://api.github.com/repos/CompFUSE/DCA/milestones{/number}","notifications_url":"https://api.github.com/repos/CompFUSE/DCA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CompFUSE/DCA/labels{/name}","releases_url":"https://api.github.com/repos/CompFUSE/DCA/releases{/id}","deployments_url":"https://api.github.com/repos/CompFUSE/DCA/deployments","created_at":"2018-07-19T08:26:56Z","updated_at":"2018-10-10T18:30:02Z","pushed_at":"2018-10-16T08:35:41Z","git_url":"git://github.com/CompFUSE/DCA.git","ssh_url":"git@github.com:CompFUSE/DCA.git","clone_url":"https://github.com/CompFUSE/DCA.git","svn_url":"https://github.com/CompFUSE/DCA","homepage":null,"size":99224,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":17,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CompFUSE/DCA/pulls/39"},"html":{"href":"https://github.com/CompFUSE/DCA/pull/39"},"issue":{"href":"https://api.github.com/repos/CompFUSE/DCA/issues/39"},"comments":{"href":"https://api.github.com/repos/CompFUSE/DCA/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/CompFUSE/DCA/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/CompFUSE/DCA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CompFUSE/DCA/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/CompFUSE/DCA/statuses/d8b383ae39d896cb5b99385a58f2840aca603a51"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gbalduzz"}}