{"action":"created","comment":{"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments/180304666","pull_request_review_id":110700646,"id":180304666,"diff_hunk":"@@ -475,6 +480,13 @@ func appendFile(fpath string, argDef *cmdkit.Argument, recursive, hidden bool) (\n \n \tfpath = filepath.ToSlash(filepath.Clean(fpath))\n \n+\tif travLinks {\n+\t\tfpath, err := filepath.EvalSymlinks(fpath)","path":"cli/parse.go","position":35,"original_position":35,"commit_id":"d04eb4374b127797573c5ccdd00a70da23ad1282","original_commit_id":"d04eb4374b127797573c5ccdd00a70da23ad1282","user":{"login":"Stebalien","id":310393,"avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"body":"Also, as far as I can tell, this won't conserve the filename (the first argument to NewSerialFile below).","created_at":"2018-04-10T06:02:40Z","updated_at":"2018-04-10T06:06:28Z","html_url":"https://github.com/ipfs/go-ipfs-cmds/pull/96#discussion_r180304666","pull_request_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments/180304666"},"html":{"href":"https://github.com/ipfs/go-ipfs-cmds/pull/96#discussion_r180304666"},"pull_request":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96"}},"in_reply_to_id":180304100},"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96","id":180329611,"html_url":"https://github.com/ipfs/go-ipfs-cmds/pull/96","diff_url":"https://github.com/ipfs/go-ipfs-cmds/pull/96.diff","patch_url":"https://github.com/ipfs/go-ipfs-cmds/pull/96.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/96","number":96,"state":"open","locked":false,"title":"Add link traversal option","user":{"login":"djdv","id":13862850,"avatar_url":"https://avatars1.githubusercontent.com/u/13862850?v=4","gravatar_id":"","url":"https://api.github.com/users/djdv","html_url":"https://github.com/djdv","followers_url":"https://api.github.com/users/djdv/followers","following_url":"https://api.github.com/users/djdv/following{/other_user}","gists_url":"https://api.github.com/users/djdv/gists{/gist_id}","starred_url":"https://api.github.com/users/djdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djdv/subscriptions","organizations_url":"https://api.github.com/users/djdv/orgs","repos_url":"https://api.github.com/users/djdv/repos","events_url":"https://api.github.com/users/djdv/events{/privacy}","received_events_url":"https://api.github.com/users/djdv/received_events","type":"User","site_admin":false},"body":"This allows us to follow filesystem links (symlinks, junctions, etc.).\r\nThe logic should be good but I need a suggestions on what the flag(s) should be. `traverse-links` is a placeholder.\r\n\r\nThis is needed in `go-ipfs` so that we can traverse the link and add the target instead of adding the link itself.","created_at":"2018-04-09T14:34:23Z","updated_at":"2018-04-10T06:06:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5daead9add7bc53e159e74541bf21c68134f1eb","assignee":{"login":"djdv","id":13862850,"avatar_url":"https://avatars1.githubusercontent.com/u/13862850?v=4","gravatar_id":"","url":"https://api.github.com/users/djdv","html_url":"https://github.com/djdv","followers_url":"https://api.github.com/users/djdv/followers","following_url":"https://api.github.com/users/djdv/following{/other_user}","gists_url":"https://api.github.com/users/djdv/gists{/gist_id}","starred_url":"https://api.github.com/users/djdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djdv/subscriptions","organizations_url":"https://api.github.com/users/djdv/orgs","repos_url":"https://api.github.com/users/djdv/repos","events_url":"https://api.github.com/users/djdv/events{/privacy}","received_events_url":"https://api.github.com/users/djdv/received_events","type":"User","site_admin":false},"assignees":[{"login":"djdv","id":13862850,"avatar_url":"https://avatars1.githubusercontent.com/u/13862850?v=4","gravatar_id":"","url":"https://api.github.com/users/djdv","html_url":"https://github.com/djdv","followers_url":"https://api.github.com/users/djdv/followers","following_url":"https://api.github.com/users/djdv/following{/other_user}","gists_url":"https://api.github.com/users/djdv/gists{/gist_id}","starred_url":"https://api.github.com/users/djdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djdv/subscriptions","organizations_url":"https://api.github.com/users/djdv/orgs","repos_url":"https://api.github.com/users/djdv/repos","events_url":"https://api.github.com/users/djdv/events{/privacy}","received_events_url":"https://api.github.com/users/djdv/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"keks","id":146678,"avatar_url":"https://avatars1.githubusercontent.com/u/146678?v=4","gravatar_id":"","url":"https://api.github.com/users/keks","html_url":"https://github.com/keks","followers_url":"https://api.github.com/users/keks/followers","following_url":"https://api.github.com/users/keks/following{/other_user}","gists_url":"https://api.github.com/users/keks/gists{/gist_id}","starred_url":"https://api.github.com/users/keks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keks/subscriptions","organizations_url":"https://api.github.com/users/keks/orgs","repos_url":"https://api.github.com/users/keks/repos","events_url":"https://api.github.com/users/keks/events{/privacy}","received_events_url":"https://api.github.com/users/keks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":759298994,"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/96/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/d04eb4374b127797573c5ccdd00a70da23ad1282","head":{"label":"djdv:feat/resolve-links","ref":"feat/resolve-links","sha":"d04eb4374b127797573c5ccdd00a70da23ad1282","user":{"login":"djdv","id":13862850,"avatar_url":"https://avatars1.githubusercontent.com/u/13862850?v=4","gravatar_id":"","url":"https://api.github.com/users/djdv","html_url":"https://github.com/djdv","followers_url":"https://api.github.com/users/djdv/followers","following_url":"https://api.github.com/users/djdv/following{/other_user}","gists_url":"https://api.github.com/users/djdv/gists{/gist_id}","starred_url":"https://api.github.com/users/djdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djdv/subscriptions","organizations_url":"https://api.github.com/users/djdv/orgs","repos_url":"https://api.github.com/users/djdv/repos","events_url":"https://api.github.com/users/djdv/events{/privacy}","received_events_url":"https://api.github.com/users/djdv/received_events","type":"User","site_admin":false},"repo":{"id":125053111,"name":"go-ipfs-cmds","full_name":"djdv/go-ipfs-cmds","owner":{"login":"djdv","id":13862850,"avatar_url":"https://avatars1.githubusercontent.com/u/13862850?v=4","gravatar_id":"","url":"https://api.github.com/users/djdv","html_url":"https://github.com/djdv","followers_url":"https://api.github.com/users/djdv/followers","following_url":"https://api.github.com/users/djdv/following{/other_user}","gists_url":"https://api.github.com/users/djdv/gists{/gist_id}","starred_url":"https://api.github.com/users/djdv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djdv/subscriptions","organizations_url":"https://api.github.com/users/djdv/orgs","repos_url":"https://api.github.com/users/djdv/repos","events_url":"https://api.github.com/users/djdv/events{/privacy}","received_events_url":"https://api.github.com/users/djdv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/djdv/go-ipfs-cmds","description":"IPFS commands package","fork":true,"url":"https://api.github.com/repos/djdv/go-ipfs-cmds","forks_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/forks","keys_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/teams","hooks_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/hooks","issue_events_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/issues/events{/number}","events_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/events","assignees_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/assignees{/user}","branches_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/branches{/branch}","tags_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/tags","blobs_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/git/refs{/sha}","trees_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/statuses/{sha}","languages_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/languages","stargazers_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/stargazers","contributors_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/contributors","subscribers_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/subscribers","subscription_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/subscription","commits_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/commits{/sha}","git_commits_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/git/commits{/sha}","comments_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/comments{/number}","issue_comment_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/issues/comments{/number}","contents_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/contents/{+path}","compare_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/merges","archive_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/downloads","issues_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/issues{/number}","pulls_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/pulls{/number}","milestones_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/milestones{/number}","notifications_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/labels{/name}","releases_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/releases{/id}","deployments_url":"https://api.github.com/repos/djdv/go-ipfs-cmds/deployments","created_at":"2018-03-13T13:06:57Z","updated_at":"2018-03-13T13:06:59Z","pushed_at":"2018-04-09T14:54:23Z","git_url":"git://github.com/djdv/go-ipfs-cmds.git","ssh_url":"git@github.com:djdv/go-ipfs-cmds.git","clone_url":"https://github.com/djdv/go-ipfs-cmds.git","svn_url":"https://github.com/djdv/go-ipfs-cmds","homepage":null,"size":780,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"6d7f4fc86b88d912f4f836847b819a50d75c11c6","user":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":80315005,"name":"go-ipfs-cmds","full_name":"ipfs/go-ipfs-cmds","owner":{"login":"ipfs","id":10536621,"avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ipfs/go-ipfs-cmds","description":"IPFS commands package","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs-cmds","forks_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs-cmds/deployments","created_at":"2017-01-28T22:27:18Z","updated_at":"2018-03-25T22:59:29Z","pushed_at":"2018-04-09T14:54:24Z","git_url":"git://github.com/ipfs/go-ipfs-cmds.git","ssh_url":"git@github.com:ipfs/go-ipfs-cmds.git","clone_url":"https://github.com/ipfs/go-ipfs-cmds.git","svn_url":"https://github.com/ipfs/go-ipfs-cmds","homepage":null,"size":803,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":38,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96"},"html":{"href":"https://github.com/ipfs/go-ipfs-cmds/pull/96"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/96"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs-cmds/statuses/d04eb4374b127797573c5ccdd00a70da23ad1282"}},"author_association":"NONE"}}
{"actor":{"display_login":"Stebalien"}}