{"action":"created","comment":{"url":"https://api.github.com/repos/spooky-squad/super-potato/pulls/comments/173120323","pull_request_review_id":102253545,"id":173120323,"diff_hunk":"@@ -1,138 +1,203 @@\n import math\n-from typing import Any\n+import numbers\n+\n+from typing import Any, Tuple, List\n \n \n class Vector(object):\n     \"\"\"\n-    A vector in 2d space, with x and y components.\n+    A vector in 2d space, with real x and y components.\n     \"\"\"\n \n-    def __init__(self, x: float, y: float):\n+    def __init__(self, x: numbers.Real, y: numbers.Real):\n         \"\"\"\n         Creates a vector from the x and y components.\n-\n-        :param x: float\n-        :param y: float\n         \"\"\"\n+        assert isinstance(x, numbers.Real)\n+        assert isinstance(y, numbers.Real)\n+\n         self.x = x\n         self.y = y\n \n     # Add\n \n-    def add(self, *other) -> 'Vector':\n+    def _add_vec(self, other: 'Vector') -> 'Vector':\n         \"\"\"\n-        Add other to this vector, and return this instance.\n+        Add a vector to this vector, returns this instance.\n+        \"\"\"\n+        assert isinstance(other.x, numbers.Real)\n+        assert isinstance(other.y, numbers.Real)","path":"vector.py","position":37,"original_position":37,"commit_id":"af6a1de34d7a5c780ee5009d019885b89ebb9a2c","original_commit_id":"af6a1de34d7a5c780ee5009d019885b89ebb9a2c","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Use of assert detected. The enclosed code will be removed when compiling to optimised byte code.](https://app.codacy.com/app/juicy66173/super-potato/pullRequest?prid=1403622)","created_at":"2018-03-08T10:33:42Z","updated_at":"2018-03-08T10:33:42Z","html_url":"https://github.com/spooky-squad/super-potato/pull/8#discussion_r173120323","pull_request_url":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spooky-squad/super-potato/pulls/comments/173120323"},"html":{"href":"https://github.com/spooky-squad/super-potato/pull/8#discussion_r173120323"},"pull_request":{"href":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8","id":173231146,"html_url":"https://github.com/spooky-squad/super-potato/pull/8","diff_url":"https://github.com/spooky-squad/super-potato/pull/8.diff","patch_url":"https://github.com/spooky-squad/super-potato/pull/8.patch","issue_url":"https://api.github.com/repos/spooky-squad/super-potato/issues/8","number":8,"state":"open","locked":false,"title":"Merge develop with master","user":{"login":"Juici","id":19672035,"avatar_url":"https://avatars3.githubusercontent.com/u/19672035?v=4","gravatar_id":"","url":"https://api.github.com/users/Juici","html_url":"https://github.com/Juici","followers_url":"https://api.github.com/users/Juici/followers","following_url":"https://api.github.com/users/Juici/following{/other_user}","gists_url":"https://api.github.com/users/Juici/gists{/gist_id}","starred_url":"https://api.github.com/users/Juici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juici/subscriptions","organizations_url":"https://api.github.com/users/Juici/orgs","repos_url":"https://api.github.com/users/Juici/repos","events_url":"https://api.github.com/users/Juici/events{/privacy}","received_events_url":"https://api.github.com/users/Juici/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-06T17:40:20Z","updated_at":"2018-03-08T10:33:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c13efe3e7b3bccb0297a32d405cbcf42dae438af","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8/commits","review_comments_url":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8/comments","review_comment_url":"https://api.github.com/repos/spooky-squad/super-potato/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spooky-squad/super-potato/issues/8/comments","statuses_url":"https://api.github.com/repos/spooky-squad/super-potato/statuses/af6a1de34d7a5c780ee5009d019885b89ebb9a2c","head":{"label":"spooky-squad:develop","ref":"develop","sha":"af6a1de34d7a5c780ee5009d019885b89ebb9a2c","user":{"login":"spooky-squad","id":36745687,"avatar_url":"https://avatars1.githubusercontent.com/u/36745687?v=4","gravatar_id":"","url":"https://api.github.com/users/spooky-squad","html_url":"https://github.com/spooky-squad","followers_url":"https://api.github.com/users/spooky-squad/followers","following_url":"https://api.github.com/users/spooky-squad/following{/other_user}","gists_url":"https://api.github.com/users/spooky-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/spooky-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spooky-squad/subscriptions","organizations_url":"https://api.github.com/users/spooky-squad/orgs","repos_url":"https://api.github.com/users/spooky-squad/repos","events_url":"https://api.github.com/users/spooky-squad/events{/privacy}","received_events_url":"https://api.github.com/users/spooky-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":122461646,"name":"super-potato","full_name":"spooky-squad/super-potato","owner":{"login":"spooky-squad","id":36745687,"avatar_url":"https://avatars1.githubusercontent.com/u/36745687?v=4","gravatar_id":"","url":"https://api.github.com/users/spooky-squad","html_url":"https://github.com/spooky-squad","followers_url":"https://api.github.com/users/spooky-squad/followers","following_url":"https://api.github.com/users/spooky-squad/following{/other_user}","gists_url":"https://api.github.com/users/spooky-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/spooky-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spooky-squad/subscriptions","organizations_url":"https://api.github.com/users/spooky-squad/orgs","repos_url":"https://api.github.com/users/spooky-squad/repos","events_url":"https://api.github.com/users/spooky-squad/events{/privacy}","received_events_url":"https://api.github.com/users/spooky-squad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spooky-squad/super-potato","description":"Game for CS1830","fork":false,"url":"https://api.github.com/repos/spooky-squad/super-potato","forks_url":"https://api.github.com/repos/spooky-squad/super-potato/forks","keys_url":"https://api.github.com/repos/spooky-squad/super-potato/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spooky-squad/super-potato/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spooky-squad/super-potato/teams","hooks_url":"https://api.github.com/repos/spooky-squad/super-potato/hooks","issue_events_url":"https://api.github.com/repos/spooky-squad/super-potato/issues/events{/number}","events_url":"https://api.github.com/repos/spooky-squad/super-potato/events","assignees_url":"https://api.github.com/repos/spooky-squad/super-potato/assignees{/user}","branches_url":"https://api.github.com/repos/spooky-squad/super-potato/branches{/branch}","tags_url":"https://api.github.com/repos/spooky-squad/super-potato/tags","blobs_url":"https://api.github.com/repos/spooky-squad/super-potato/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spooky-squad/super-potato/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spooky-squad/super-potato/git/refs{/sha}","trees_url":"https://api.github.com/repos/spooky-squad/super-potato/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spooky-squad/super-potato/statuses/{sha}","languages_url":"https://api.github.com/repos/spooky-squad/super-potato/languages","stargazers_url":"https://api.github.com/repos/spooky-squad/super-potato/stargazers","contributors_url":"https://api.github.com/repos/spooky-squad/super-potato/contributors","subscribers_url":"https://api.github.com/repos/spooky-squad/super-potato/subscribers","subscription_url":"https://api.github.com/repos/spooky-squad/super-potato/subscription","commits_url":"https://api.github.com/repos/spooky-squad/super-potato/commits{/sha}","git_commits_url":"https://api.github.com/repos/spooky-squad/super-potato/git/commits{/sha}","comments_url":"https://api.github.com/repos/spooky-squad/super-potato/comments{/number}","issue_comment_url":"https://api.github.com/repos/spooky-squad/super-potato/issues/comments{/number}","contents_url":"https://api.github.com/repos/spooky-squad/super-potato/contents/{+path}","compare_url":"https://api.github.com/repos/spooky-squad/super-potato/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spooky-squad/super-potato/merges","archive_url":"https://api.github.com/repos/spooky-squad/super-potato/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spooky-squad/super-potato/downloads","issues_url":"https://api.github.com/repos/spooky-squad/super-potato/issues{/number}","pulls_url":"https://api.github.com/repos/spooky-squad/super-potato/pulls{/number}","milestones_url":"https://api.github.com/repos/spooky-squad/super-potato/milestones{/number}","notifications_url":"https://api.github.com/repos/spooky-squad/super-potato/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spooky-squad/super-potato/labels{/name}","releases_url":"https://api.github.com/repos/spooky-squad/super-potato/releases{/id}","deployments_url":"https://api.github.com/repos/spooky-squad/super-potato/deployments","created_at":"2018-02-22T10:07:52Z","updated_at":"2018-02-22T20:56:33Z","pushed_at":"2018-03-08T10:28:23Z","git_url":"git://github.com/spooky-squad/super-potato.git","ssh_url":"git@github.com:spooky-squad/super-potato.git","clone_url":"https://github.com/spooky-squad/super-potato.git","svn_url":"https://github.com/spooky-squad/super-potato","homepage":"","size":39,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"spooky-squad:master","ref":"master","sha":"bd1e1f73b36565be3460e6ead78a89c6d6aac08c","user":{"login":"spooky-squad","id":36745687,"avatar_url":"https://avatars1.githubusercontent.com/u/36745687?v=4","gravatar_id":"","url":"https://api.github.com/users/spooky-squad","html_url":"https://github.com/spooky-squad","followers_url":"https://api.github.com/users/spooky-squad/followers","following_url":"https://api.github.com/users/spooky-squad/following{/other_user}","gists_url":"https://api.github.com/users/spooky-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/spooky-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spooky-squad/subscriptions","organizations_url":"https://api.github.com/users/spooky-squad/orgs","repos_url":"https://api.github.com/users/spooky-squad/repos","events_url":"https://api.github.com/users/spooky-squad/events{/privacy}","received_events_url":"https://api.github.com/users/spooky-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":122461646,"name":"super-potato","full_name":"spooky-squad/super-potato","owner":{"login":"spooky-squad","id":36745687,"avatar_url":"https://avatars1.githubusercontent.com/u/36745687?v=4","gravatar_id":"","url":"https://api.github.com/users/spooky-squad","html_url":"https://github.com/spooky-squad","followers_url":"https://api.github.com/users/spooky-squad/followers","following_url":"https://api.github.com/users/spooky-squad/following{/other_user}","gists_url":"https://api.github.com/users/spooky-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/spooky-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spooky-squad/subscriptions","organizations_url":"https://api.github.com/users/spooky-squad/orgs","repos_url":"https://api.github.com/users/spooky-squad/repos","events_url":"https://api.github.com/users/spooky-squad/events{/privacy}","received_events_url":"https://api.github.com/users/spooky-squad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spooky-squad/super-potato","description":"Game for CS1830","fork":false,"url":"https://api.github.com/repos/spooky-squad/super-potato","forks_url":"https://api.github.com/repos/spooky-squad/super-potato/forks","keys_url":"https://api.github.com/repos/spooky-squad/super-potato/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spooky-squad/super-potato/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spooky-squad/super-potato/teams","hooks_url":"https://api.github.com/repos/spooky-squad/super-potato/hooks","issue_events_url":"https://api.github.com/repos/spooky-squad/super-potato/issues/events{/number}","events_url":"https://api.github.com/repos/spooky-squad/super-potato/events","assignees_url":"https://api.github.com/repos/spooky-squad/super-potato/assignees{/user}","branches_url":"https://api.github.com/repos/spooky-squad/super-potato/branches{/branch}","tags_url":"https://api.github.com/repos/spooky-squad/super-potato/tags","blobs_url":"https://api.github.com/repos/spooky-squad/super-potato/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spooky-squad/super-potato/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spooky-squad/super-potato/git/refs{/sha}","trees_url":"https://api.github.com/repos/spooky-squad/super-potato/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spooky-squad/super-potato/statuses/{sha}","languages_url":"https://api.github.com/repos/spooky-squad/super-potato/languages","stargazers_url":"https://api.github.com/repos/spooky-squad/super-potato/stargazers","contributors_url":"https://api.github.com/repos/spooky-squad/super-potato/contributors","subscribers_url":"https://api.github.com/repos/spooky-squad/super-potato/subscribers","subscription_url":"https://api.github.com/repos/spooky-squad/super-potato/subscription","commits_url":"https://api.github.com/repos/spooky-squad/super-potato/commits{/sha}","git_commits_url":"https://api.github.com/repos/spooky-squad/super-potato/git/commits{/sha}","comments_url":"https://api.github.com/repos/spooky-squad/super-potato/comments{/number}","issue_comment_url":"https://api.github.com/repos/spooky-squad/super-potato/issues/comments{/number}","contents_url":"https://api.github.com/repos/spooky-squad/super-potato/contents/{+path}","compare_url":"https://api.github.com/repos/spooky-squad/super-potato/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spooky-squad/super-potato/merges","archive_url":"https://api.github.com/repos/spooky-squad/super-potato/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spooky-squad/super-potato/downloads","issues_url":"https://api.github.com/repos/spooky-squad/super-potato/issues{/number}","pulls_url":"https://api.github.com/repos/spooky-squad/super-potato/pulls{/number}","milestones_url":"https://api.github.com/repos/spooky-squad/super-potato/milestones{/number}","notifications_url":"https://api.github.com/repos/spooky-squad/super-potato/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spooky-squad/super-potato/labels{/name}","releases_url":"https://api.github.com/repos/spooky-squad/super-potato/releases{/id}","deployments_url":"https://api.github.com/repos/spooky-squad/super-potato/deployments","created_at":"2018-02-22T10:07:52Z","updated_at":"2018-02-22T20:56:33Z","pushed_at":"2018-03-08T10:28:23Z","git_url":"git://github.com/spooky-squad/super-potato.git","ssh_url":"git@github.com:spooky-squad/super-potato.git","clone_url":"https://github.com/spooky-squad/super-potato.git","svn_url":"https://github.com/spooky-squad/super-potato","homepage":"","size":39,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8"},"html":{"href":"https://github.com/spooky-squad/super-potato/pull/8"},"issue":{"href":"https://api.github.com/repos/spooky-squad/super-potato/issues/8"},"comments":{"href":"https://api.github.com/repos/spooky-squad/super-potato/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/spooky-squad/super-potato/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spooky-squad/super-potato/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/spooky-squad/super-potato/statuses/af6a1de34d7a5c780ee5009d019885b89ebb9a2c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"codacy-bot"}}