{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49346","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49346/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49346/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49346/events","html_url":"https://github.com/NixOS/nixpkgs/pull/49346","id":374756127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzY4NTQy","number":49346,"title":"buildGoPackage: re-enable GOCACHE","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"labels":[{"id":731735640,"node_id":"MDU6TGFiZWw3MzE3MzU2NDA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20101-500","name":"10.rebuild-darwin: 101-500","color":"d93f0b","default":false},{"id":731734374,"node_id":"MDU6TGFiZWw3MzE3MzQzNzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20101-500","name":"10.rebuild-linux: 101-500","color":"d93f0b","default":false},{"id":337081580,"node_id":"MDU6TGFiZWwzMzcwODE1ODA=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20golang","name":"6.topic: golang","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-28T13:51:39Z","updated_at":"2018-10-28T16:02:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/49346","html_url":"https://github.com/NixOS/nixpkgs/pull/49346","diff_url":"https://github.com/NixOS/nixpkgs/pull/49346.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/49346.patch"},"body":"If projects uses go1.11 modules GOCACHE is required.\r\nAlso if buildGoPackage is used in a nix-shell setting we don't\r\nwant to override GOCACHE to allow incremental builds.\r\nThis should be backported to 18.09\r\n\r\n###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/433718108","html_url":"https://github.com/NixOS/nixpkgs/pull/49346#issuecomment-433718108","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/49346","id":433718108,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzcxODEwOA==","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"created_at":"2018-10-28T16:02:03Z","updated_at":"2018-10-28T16:02:03Z","author_association":"CONTRIBUTOR","body":"Tested on a significant part of our go packages."}}
{"actor":{"display_login":"Mic92"}}