{"action":"closed","number":156,"pull_request":{"url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/156","id":206401022,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDAxMDIy","html_url":"https://github.com/ess-dmsc/forward-epics-to-kafka/pull/156","diff_url":"https://github.com/ess-dmsc/forward-epics-to-kafka/pull/156.diff","patch_url":"https://github.com/ess-dmsc/forward-epics-to-kafka/pull/156.patch","issue_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/156","number":156,"state":"closed","locked":false,"title":"Treat warnings as errors","user":{"login":"mattclarke","id":3032495,"node_id":"MDQ6VXNlcjMwMzI0OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/3032495?v=4","gravatar_id":"","url":"https://api.github.com/users/mattclarke","html_url":"https://github.com/mattclarke","followers_url":"https://api.github.com/users/mattclarke/followers","following_url":"https://api.github.com/users/mattclarke/following{/other_user}","gists_url":"https://api.github.com/users/mattclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/mattclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattclarke/subscriptions","organizations_url":"https://api.github.com/users/mattclarke/orgs","repos_url":"https://api.github.com/users/mattclarke/repos","events_url":"https://api.github.com/users/mattclarke/events{/privacy}","received_events_url":"https://api.github.com/users/mattclarke/received_events","type":"User","site_admin":false},"body":"### Description of work\r\n\r\nLike the file writer we shall try to treat warnings as if they are errors.\r\n\r\n### Issue\r\n\r\nCloses #151\r\n\r\n### Acceptance Criteria\r\n\r\nBuilds without errors and everything still works (unit tests and system tests).\r\n\r\n### Unit Tests\r\n\r\nNo changes.\r\n\r\n### Other\r\n\r\nN/A\r\n\r\n---\r\n\r\n## Code Review (To be filled in by the reviewer only)\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Do the changes function as described and is it robust?\r\n\r\n---\r\n\r\n## Nominate for Group Code Review (Anyone can nominate it)\r\nIndicate if you think the code should be reviewed in a Thursday code review session.\r\n\r\n- [ ] Recommend for group code review\r\n\r\nAlso, nominate it on the code_review Slack channel (does someone want to automate this?).\r\n","created_at":"2018-08-06T13:35:13Z","updated_at":"2018-08-08T11:05:48Z","closed_at":"2018-08-08T11:05:48Z","merged_at":"2018-08-08T11:05:47Z","merge_commit_sha":"95c57ef60f720b1d5511d68b5ea9d52159c56a44","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matthew-d-jones","id":13455433,"node_id":"MDQ6VXNlcjEzNDU1NDMz","avatar_url":"https://avatars2.githubusercontent.com/u/13455433?v=4","gravatar_id":"","url":"https://api.github.com/users/matthew-d-jones","html_url":"https://github.com/matthew-d-jones","followers_url":"https://api.github.com/users/matthew-d-jones/followers","following_url":"https://api.github.com/users/matthew-d-jones/following{/other_user}","gists_url":"https://api.github.com/users/matthew-d-jones/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-d-jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-d-jones/subscriptions","organizations_url":"https://api.github.com/users/matthew-d-jones/orgs","repos_url":"https://api.github.com/users/matthew-d-jones/repos","events_url":"https://api.github.com/users/matthew-d-jones/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-d-jones/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/156/commits","review_comments_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/156/comments","review_comment_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/156/comments","statuses_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/statuses/819c7237867a7a58f63367a5f876253ca5dacb51","head":{"label":"ess-dmsc:151_warnings_as_errors","ref":"151_warnings_as_errors","sha":"819c7237867a7a58f63367a5f876253ca5dacb51","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":81432248,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQzMjI0OA==","name":"forward-epics-to-kafka","full_name":"ess-dmsc/forward-epics-to-kafka","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/forward-epics-to-kafka","description":"Forward EPICS process variables to Kafka topics","fork":false,"url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka","forks_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/forks","keys_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/events","assignees_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/merges","archive_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/deployments","created_at":"2017-02-09T09:19:49Z","updated_at":"2018-08-06T09:41:48Z","pushed_at":"2018-08-08T11:05:47Z","git_url":"git://github.com/ess-dmsc/forward-epics-to-kafka.git","ssh_url":"git@github.com:ess-dmsc/forward-epics-to-kafka.git","clone_url":"https://github.com/ess-dmsc/forward-epics-to-kafka.git","svn_url":"https://github.com/ess-dmsc/forward-epics-to-kafka","homepage":"","size":1265,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"ess-dmsc:master","ref":"master","sha":"cc86f0a51bb5aa3df2a8124c06ad59d15a328739","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":81432248,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQzMjI0OA==","name":"forward-epics-to-kafka","full_name":"ess-dmsc/forward-epics-to-kafka","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/forward-epics-to-kafka","description":"Forward EPICS process variables to Kafka topics","fork":false,"url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka","forks_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/forks","keys_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/events","assignees_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/merges","archive_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/deployments","created_at":"2017-02-09T09:19:49Z","updated_at":"2018-08-06T09:41:48Z","pushed_at":"2018-08-08T11:05:47Z","git_url":"git://github.com/ess-dmsc/forward-epics-to-kafka.git","ssh_url":"git@github.com:ess-dmsc/forward-epics-to-kafka.git","clone_url":"https://github.com/ess-dmsc/forward-epics-to-kafka.git","svn_url":"https://github.com/ess-dmsc/forward-epics-to-kafka","homepage":"","size":1265,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":1,"open_issues":14,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/156"},"html":{"href":"https://github.com/ess-dmsc/forward-epics-to-kafka/pull/156"},"issue":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/156"},"comments":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/ess-dmsc/forward-epics-to-kafka/statuses/819c7237867a7a58f63367a5f876253ca5dacb51"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rerpha","id":14823767,"node_id":"MDQ6VXNlcjE0ODIzNzY3","avatar_url":"https://avatars3.githubusercontent.com/u/14823767?v=4","gravatar_id":"","url":"https://api.github.com/users/rerpha","html_url":"https://github.com/rerpha","followers_url":"https://api.github.com/users/rerpha/followers","following_url":"https://api.github.com/users/rerpha/following{/other_user}","gists_url":"https://api.github.com/users/rerpha/gists{/gist_id}","starred_url":"https://api.github.com/users/rerpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rerpha/subscriptions","organizations_url":"https://api.github.com/users/rerpha/orgs","repos_url":"https://api.github.com/users/rerpha/repos","events_url":"https://api.github.com/users/rerpha/events{/privacy}","received_events_url":"https://api.github.com/users/rerpha/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":15,"additions":231,"deletions":149,"changed_files":27}}
{"actor":{"display_login":"rerpha"}}