{"action":"created","comment":{"url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/comments/218755799","pull_request_review_id":156753183,"id":218755799,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc1NTc5OQ==","diff_hunk":"@@ -26,4 +27,30 @@ public String getValue() {\n             return Json.toJson(value);\n         }\n     }\n+\n+    @Override","path":"src/main/java/org/prebid/cache/model/PayloadTransfer.java","position":17,"original_position":17,"commit_id":"7ec61d0019771c9685beb3668b0096f41ca848a9","original_commit_id":"7ec61d0019771c9685beb3668b0096f41ca848a9","user":{"login":"schernysh","id":8603819,"node_id":"MDQ6VXNlcjg2MDM4MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/8603819?v=4","gravatar_id":"","url":"https://api.github.com/users/schernysh","html_url":"https://github.com/schernysh","followers_url":"https://api.github.com/users/schernysh/followers","following_url":"https://api.github.com/users/schernysh/following{/other_user}","gists_url":"https://api.github.com/users/schernysh/gists{/gist_id}","starred_url":"https://api.github.com/users/schernysh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schernysh/subscriptions","organizations_url":"https://api.github.com/users/schernysh/orgs","repos_url":"https://api.github.com/users/schernysh/repos","events_url":"https://api.github.com/users/schernysh/events{/privacy}","received_events_url":"https://api.github.com/users/schernysh/received_events","type":"User","site_admin":false},"body":"I think this is redundant since lombok's `@Value` takes care of generating these methods. Is there a good reason to replace them with own implementation?","created_at":"2018-09-19T10:48:28Z","updated_at":"2018-09-19T10:57:55Z","html_url":"https://github.com/rubicon-project/prebid-cache-java/pull/5#discussion_r218755799","pull_request_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/comments/218755799"},"html":{"href":"https://github.com/rubicon-project/prebid-cache-java/pull/5#discussion_r218755799"},"pull_request":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5","id":215973751,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTczNzUx","html_url":"https://github.com/rubicon-project/prebid-cache-java/pull/5","diff_url":"https://github.com/rubicon-project/prebid-cache-java/pull/5.diff","patch_url":"https://github.com/rubicon-project/prebid-cache-java/pull/5.patch","issue_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/5","number":5,"state":"open","locked":false,"title":"metrics refactor","user":{"login":"dhutsalo","id":11535313,"node_id":"MDQ6VXNlcjExNTM1MzEz","avatar_url":"https://avatars2.githubusercontent.com/u/11535313?v=4","gravatar_id":"","url":"https://api.github.com/users/dhutsalo","html_url":"https://github.com/dhutsalo","followers_url":"https://api.github.com/users/dhutsalo/followers","following_url":"https://api.github.com/users/dhutsalo/following{/other_user}","gists_url":"https://api.github.com/users/dhutsalo/gists{/gist_id}","starred_url":"https://api.github.com/users/dhutsalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhutsalo/subscriptions","organizations_url":"https://api.github.com/users/dhutsalo/orgs","repos_url":"https://api.github.com/users/dhutsalo/repos","events_url":"https://api.github.com/users/dhutsalo/events{/privacy}","received_events_url":"https://api.github.com/users/dhutsalo/received_events","type":"User","site_admin":false},"body":"added and changed metrics\r\nfixed tests","created_at":"2018-09-17T13:02:05Z","updated_at":"2018-09-19T10:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8780927c05d1f36b54e14384d76f6e1fc572baa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"TerentievEvgany","id":3390525,"node_id":"MDQ6VXNlcjMzOTA1MjU=","avatar_url":"https://avatars2.githubusercontent.com/u/3390525?v=4","gravatar_id":"","url":"https://api.github.com/users/TerentievEvgany","html_url":"https://github.com/TerentievEvgany","followers_url":"https://api.github.com/users/TerentievEvgany/followers","following_url":"https://api.github.com/users/TerentievEvgany/following{/other_user}","gists_url":"https://api.github.com/users/TerentievEvgany/gists{/gist_id}","starred_url":"https://api.github.com/users/TerentievEvgany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerentievEvgany/subscriptions","organizations_url":"https://api.github.com/users/TerentievEvgany/orgs","repos_url":"https://api.github.com/users/TerentievEvgany/repos","events_url":"https://api.github.com/users/TerentievEvgany/events{/privacy}","received_events_url":"https://api.github.com/users/TerentievEvgany/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5/commits","review_comments_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5/comments","review_comment_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/5/comments","statuses_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/statuses/7ec61d0019771c9685beb3668b0096f41ca848a9","head":{"label":"rubicon-project:application-metrics","ref":"application-metrics","sha":"7ec61d0019771c9685beb3668b0096f41ca848a9","user":{"login":"rubicon-project","id":367823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzgyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"repo":{"id":126012969,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwMTI5Njk=","name":"prebid-cache-java","full_name":"rubicon-project/prebid-cache-java","private":false,"owner":{"login":"rubicon-project","id":367823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzgyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubicon-project/prebid-cache-java","description":"Java version of Prebid Cache server","fork":false,"url":"https://api.github.com/repos/rubicon-project/prebid-cache-java","forks_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/forks","keys_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/teams","hooks_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/hooks","issue_events_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/events{/number}","events_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/events","assignees_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/assignees{/user}","branches_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/branches{/branch}","tags_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/tags","blobs_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/statuses/{sha}","languages_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/languages","stargazers_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/stargazers","contributors_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/contributors","subscribers_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/subscribers","subscription_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/subscription","commits_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/contents/{+path}","compare_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/merges","archive_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/downloads","issues_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues{/number}","pulls_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls{/number}","milestones_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/milestones{/number}","notifications_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/labels{/name}","releases_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/releases{/id}","deployments_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/deployments","created_at":"2018-03-20T12:19:26Z","updated_at":"2018-08-15T10:30:24Z","pushed_at":"2018-09-18T11:20:24Z","git_url":"git://github.com/rubicon-project/prebid-cache-java.git","ssh_url":"git@github.com:rubicon-project/prebid-cache-java.git","clone_url":"https://github.com/rubicon-project/prebid-cache-java.git","svn_url":"https://github.com/rubicon-project/prebid-cache-java","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"rubicon-project:master","ref":"master","sha":"cdbb87d5ffb6a567780120af566676b71910f586","user":{"login":"rubicon-project","id":367823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzgyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"repo":{"id":126012969,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwMTI5Njk=","name":"prebid-cache-java","full_name":"rubicon-project/prebid-cache-java","private":false,"owner":{"login":"rubicon-project","id":367823,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NzgyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/367823?v=4","gravatar_id":"","url":"https://api.github.com/users/rubicon-project","html_url":"https://github.com/rubicon-project","followers_url":"https://api.github.com/users/rubicon-project/followers","following_url":"https://api.github.com/users/rubicon-project/following{/other_user}","gists_url":"https://api.github.com/users/rubicon-project/gists{/gist_id}","starred_url":"https://api.github.com/users/rubicon-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubicon-project/subscriptions","organizations_url":"https://api.github.com/users/rubicon-project/orgs","repos_url":"https://api.github.com/users/rubicon-project/repos","events_url":"https://api.github.com/users/rubicon-project/events{/privacy}","received_events_url":"https://api.github.com/users/rubicon-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubicon-project/prebid-cache-java","description":"Java version of Prebid Cache server","fork":false,"url":"https://api.github.com/repos/rubicon-project/prebid-cache-java","forks_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/forks","keys_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/teams","hooks_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/hooks","issue_events_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/events{/number}","events_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/events","assignees_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/assignees{/user}","branches_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/branches{/branch}","tags_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/tags","blobs_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/statuses/{sha}","languages_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/languages","stargazers_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/stargazers","contributors_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/contributors","subscribers_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/subscribers","subscription_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/subscription","commits_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/contents/{+path}","compare_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/merges","archive_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/downloads","issues_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues{/number}","pulls_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls{/number}","milestones_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/milestones{/number}","notifications_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/labels{/name}","releases_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/releases{/id}","deployments_url":"https://api.github.com/repos/rubicon-project/prebid-cache-java/deployments","created_at":"2018-03-20T12:19:26Z","updated_at":"2018-08-15T10:30:24Z","pushed_at":"2018-09-18T11:20:24Z","git_url":"git://github.com/rubicon-project/prebid-cache-java.git","ssh_url":"git@github.com:rubicon-project/prebid-cache-java.git","clone_url":"https://github.com/rubicon-project/prebid-cache-java.git","svn_url":"https://github.com/rubicon-project/prebid-cache-java","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5"},"html":{"href":"https://github.com/rubicon-project/prebid-cache-java/pull/5"},"issue":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/5"},"comments":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/rubicon-project/prebid-cache-java/statuses/7ec61d0019771c9685beb3668b0096f41ca848a9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"schernysh"}}