{"action":"created","comment":{"url":"https://api.github.com/repos/avajs/ava/pulls/comments/207475232","pull_request_review_id":143094090,"id":207475232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQ3NTIzMg==","diff_hunk":"@@ -39,6 +39,7 @@ module.exports = (file, opts, execArgv) => {\n \t\tfile,\n \t\tbaseDir: process.cwd(),\n \t\ttty: process.stdout.isTTY ? {\n+\t\t\tcolorDepth: process.stdout.getColorDepth ? process.stdout.getColorDepth() : 1,","path":"lib/fork.js","position":4,"original_position":4,"commit_id":"935c7891d2df872e17c34cda74ba0bb1f7e37c68","original_commit_id":"935c7891d2df872e17c34cda74ba0bb1f7e37c68","user":{"login":"novemberborn","id":33538,"node_id":"MDQ6VXNlcjMzNTM4","avatar_url":"https://avatars0.githubusercontent.com/u/33538?v=4","gravatar_id":"","url":"https://api.github.com/users/novemberborn","html_url":"https://github.com/novemberborn","followers_url":"https://api.github.com/users/novemberborn/followers","following_url":"https://api.github.com/users/novemberborn/following{/other_user}","gists_url":"https://api.github.com/users/novemberborn/gists{/gist_id}","starred_url":"https://api.github.com/users/novemberborn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novemberborn/subscriptions","organizations_url":"https://api.github.com/users/novemberborn/orgs","repos_url":"https://api.github.com/users/novemberborn/repos","events_url":"https://api.github.com/users/novemberborn/events{/privacy}","received_events_url":"https://api.github.com/users/novemberborn/received_events","type":"User","site_admin":false},"body":"Perhaps leave as `undefined` if there is no `getColorDepth()`, and use that as a signal of whether to shim or not?\r\n\r\nOr `null` if you prefer.","created_at":"2018-08-03T08:26:42Z","updated_at":"2018-08-03T08:29:19Z","html_url":"https://github.com/avajs/ava/pull/1885#discussion_r207475232","pull_request_url":"https://api.github.com/repos/avajs/ava/pulls/1885","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/avajs/ava/pulls/comments/207475232"},"html":{"href":"https://github.com/avajs/ava/pull/1885#discussion_r207475232"},"pull_request":{"href":"https://api.github.com/repos/avajs/ava/pulls/1885"}}},"pull_request":{"url":"https://api.github.com/repos/avajs/ava/pulls/1885","id":205799409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Nzk5NDA5","html_url":"https://github.com/avajs/ava/pull/1885","diff_url":"https://github.com/avajs/ava/pull/1885.diff","patch_url":"https://github.com/avajs/ava/pull/1885.patch","issue_url":"https://api.github.com/repos/avajs/ava/issues/1885","number":1885,"state":"open","locked":false,"title":"Provide getColorDepth() shim for fake TTYs","user":{"login":"jagoda","id":655686,"node_id":"MDQ6VXNlcjY1NTY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/655686?v=4","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"body":"The AssertionError constructor in Node 10 depends on the TTY\r\ninterface. More specifically, if isTTY is true on stdout then\r\ngetColorDepth() must also be available. Ava provides a shim for\r\nisTTY in the test workers but does not provide a getColorDepth()\r\nimplementation. This leads to unexpected failures when code under\r\ntest is using Node's built-in assert module.\r\n\r\n<!--\r\n\r\nRead the [contributing guidelines](https://github.com/avajs/ava/blob/master/contributing.md). We are excited about pull requests, but please try to limit the scope, provide a general description of the changes, and remember, it's up to you to convince us to land it. If this fixes an open issue, link to it in the following way: `Fixes #321`. New features and bug fixes should come with tests.\r\n\r\n-->\r\n","created_at":"2018-08-02T16:54:49Z","updated_at":"2018-08-03T08:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44bbba147e516810094e7c8a0b649da0a684ac88","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/avajs/ava/pulls/1885/commits","review_comments_url":"https://api.github.com/repos/avajs/ava/pulls/1885/comments","review_comment_url":"https://api.github.com/repos/avajs/ava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/avajs/ava/issues/1885/comments","statuses_url":"https://api.github.com/repos/avajs/ava/statuses/935c7891d2df872e17c34cda74ba0bb1f7e37c68","head":{"label":"jagoda:fix-assert","ref":"fix-assert","sha":"935c7891d2df872e17c34cda74ba0bb1f7e37c68","user":{"login":"jagoda","id":655686,"node_id":"MDQ6VXNlcjY1NTY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/655686?v=4","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"repo":{"id":143302550,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMDI1NTA=","name":"ava","full_name":"jagoda/ava","owner":{"login":"jagoda","id":655686,"node_id":"MDQ6VXNlcjY1NTY4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/655686?v=4","gravatar_id":"","url":"https://api.github.com/users/jagoda","html_url":"https://github.com/jagoda","followers_url":"https://api.github.com/users/jagoda/followers","following_url":"https://api.github.com/users/jagoda/following{/other_user}","gists_url":"https://api.github.com/users/jagoda/gists{/gist_id}","starred_url":"https://api.github.com/users/jagoda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagoda/subscriptions","organizations_url":"https://api.github.com/users/jagoda/orgs","repos_url":"https://api.github.com/users/jagoda/repos","events_url":"https://api.github.com/users/jagoda/events{/privacy}","received_events_url":"https://api.github.com/users/jagoda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jagoda/ava","description":":rocket: Futuristic JavaScript test runner","fork":true,"url":"https://api.github.com/repos/jagoda/ava","forks_url":"https://api.github.com/repos/jagoda/ava/forks","keys_url":"https://api.github.com/repos/jagoda/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jagoda/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jagoda/ava/teams","hooks_url":"https://api.github.com/repos/jagoda/ava/hooks","issue_events_url":"https://api.github.com/repos/jagoda/ava/issues/events{/number}","events_url":"https://api.github.com/repos/jagoda/ava/events","assignees_url":"https://api.github.com/repos/jagoda/ava/assignees{/user}","branches_url":"https://api.github.com/repos/jagoda/ava/branches{/branch}","tags_url":"https://api.github.com/repos/jagoda/ava/tags","blobs_url":"https://api.github.com/repos/jagoda/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jagoda/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jagoda/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/jagoda/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jagoda/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/jagoda/ava/languages","stargazers_url":"https://api.github.com/repos/jagoda/ava/stargazers","contributors_url":"https://api.github.com/repos/jagoda/ava/contributors","subscribers_url":"https://api.github.com/repos/jagoda/ava/subscribers","subscription_url":"https://api.github.com/repos/jagoda/ava/subscription","commits_url":"https://api.github.com/repos/jagoda/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/jagoda/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/jagoda/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/jagoda/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/jagoda/ava/contents/{+path}","compare_url":"https://api.github.com/repos/jagoda/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jagoda/ava/merges","archive_url":"https://api.github.com/repos/jagoda/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jagoda/ava/downloads","issues_url":"https://api.github.com/repos/jagoda/ava/issues{/number}","pulls_url":"https://api.github.com/repos/jagoda/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/jagoda/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/jagoda/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jagoda/ava/labels{/name}","releases_url":"https://api.github.com/repos/jagoda/ava/releases{/id}","deployments_url":"https://api.github.com/repos/jagoda/ava/deployments","created_at":"2018-08-02T14:02:12Z","updated_at":"2018-08-02T19:32:51Z","pushed_at":"2018-08-02T19:40:32Z","git_url":"git://github.com/jagoda/ava.git","ssh_url":"git@github.com:jagoda/ava.git","clone_url":"https://github.com/jagoda/ava.git","svn_url":"https://github.com/jagoda/ava","homepage":"","size":7270,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"avajs:master","ref":"master","sha":"08f7ab4ab3a7d3edc8214a775b509e880bdace1b","user":{"login":"avajs","id":8527916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc5MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8527916?v=4","gravatar_id":"","url":"https://api.github.com/users/avajs","html_url":"https://github.com/avajs","followers_url":"https://api.github.com/users/avajs/followers","following_url":"https://api.github.com/users/avajs/following{/other_user}","gists_url":"https://api.github.com/users/avajs/gists{/gist_id}","starred_url":"https://api.github.com/users/avajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avajs/subscriptions","organizations_url":"https://api.github.com/users/avajs/orgs","repos_url":"https://api.github.com/users/avajs/repos","events_url":"https://api.github.com/users/avajs/events{/privacy}","received_events_url":"https://api.github.com/users/avajs/received_events","type":"Organization","site_admin":false},"repo":{"id":26820798,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgyMDc5OA==","name":"ava","full_name":"avajs/ava","owner":{"login":"avajs","id":8527916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Mjc5MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8527916?v=4","gravatar_id":"","url":"https://api.github.com/users/avajs","html_url":"https://github.com/avajs","followers_url":"https://api.github.com/users/avajs/followers","following_url":"https://api.github.com/users/avajs/following{/other_user}","gists_url":"https://api.github.com/users/avajs/gists{/gist_id}","starred_url":"https://api.github.com/users/avajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avajs/subscriptions","organizations_url":"https://api.github.com/users/avajs/orgs","repos_url":"https://api.github.com/users/avajs/repos","events_url":"https://api.github.com/users/avajs/events{/privacy}","received_events_url":"https://api.github.com/users/avajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/avajs/ava","description":":rocket: Futuristic JavaScript test runner","fork":false,"url":"https://api.github.com/repos/avajs/ava","forks_url":"https://api.github.com/repos/avajs/ava/forks","keys_url":"https://api.github.com/repos/avajs/ava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/avajs/ava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/avajs/ava/teams","hooks_url":"https://api.github.com/repos/avajs/ava/hooks","issue_events_url":"https://api.github.com/repos/avajs/ava/issues/events{/number}","events_url":"https://api.github.com/repos/avajs/ava/events","assignees_url":"https://api.github.com/repos/avajs/ava/assignees{/user}","branches_url":"https://api.github.com/repos/avajs/ava/branches{/branch}","tags_url":"https://api.github.com/repos/avajs/ava/tags","blobs_url":"https://api.github.com/repos/avajs/ava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/avajs/ava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/avajs/ava/git/refs{/sha}","trees_url":"https://api.github.com/repos/avajs/ava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/avajs/ava/statuses/{sha}","languages_url":"https://api.github.com/repos/avajs/ava/languages","stargazers_url":"https://api.github.com/repos/avajs/ava/stargazers","contributors_url":"https://api.github.com/repos/avajs/ava/contributors","subscribers_url":"https://api.github.com/repos/avajs/ava/subscribers","subscription_url":"https://api.github.com/repos/avajs/ava/subscription","commits_url":"https://api.github.com/repos/avajs/ava/commits{/sha}","git_commits_url":"https://api.github.com/repos/avajs/ava/git/commits{/sha}","comments_url":"https://api.github.com/repos/avajs/ava/comments{/number}","issue_comment_url":"https://api.github.com/repos/avajs/ava/issues/comments{/number}","contents_url":"https://api.github.com/repos/avajs/ava/contents/{+path}","compare_url":"https://api.github.com/repos/avajs/ava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/avajs/ava/merges","archive_url":"https://api.github.com/repos/avajs/ava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/avajs/ava/downloads","issues_url":"https://api.github.com/repos/avajs/ava/issues{/number}","pulls_url":"https://api.github.com/repos/avajs/ava/pulls{/number}","milestones_url":"https://api.github.com/repos/avajs/ava/milestones{/number}","notifications_url":"https://api.github.com/repos/avajs/ava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/avajs/ava/labels{/name}","releases_url":"https://api.github.com/repos/avajs/ava/releases{/id}","deployments_url":"https://api.github.com/repos/avajs/ava/deployments","created_at":"2014-11-18T17:20:26Z","updated_at":"2018-08-03T06:35:24Z","pushed_at":"2018-08-02T19:40:33Z","git_url":"git://github.com/avajs/ava.git","ssh_url":"git@github.com:avajs/ava.git","clone_url":"https://github.com/avajs/ava.git","svn_url":"https://github.com/avajs/ava","homepage":"","size":7267,"stargazers_count":14371,"watchers_count":14371,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":859,"mirror_url":null,"archived":false,"open_issues_count":149,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":859,"open_issues":149,"watchers":14371,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/avajs/ava/pulls/1885"},"html":{"href":"https://github.com/avajs/ava/pull/1885"},"issue":{"href":"https://api.github.com/repos/avajs/ava/issues/1885"},"comments":{"href":"https://api.github.com/repos/avajs/ava/issues/1885/comments"},"review_comments":{"href":"https://api.github.com/repos/avajs/ava/pulls/1885/comments"},"review_comment":{"href":"https://api.github.com/repos/avajs/ava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/avajs/ava/pulls/1885/commits"},"statuses":{"href":"https://api.github.com/repos/avajs/ava/statuses/935c7891d2df872e17c34cda74ba0bb1f7e37c68"}},"author_association":"NONE"}}
{"actor":{"display_login":"novemberborn"}}