{"action":"created","comment":{"url":"https://api.github.com/repos/pallets/flask/pulls/comments/221391037","pull_request_review_id":160036815,"id":221391037,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTM5MTAzNw==","diff_hunk":"@@ -20,9 +20,11 @@ Unreleased\n     stricter about header encodings than PEP 3333. (`#2766`_)\n -   Allow custom CLIs using ``FlaskGroup`` to set the debug flag without\n     it always being overwritten based on environment variables. (`#2765`_)\n+-   Fix issue with port set to 0 being overriden by the default value\n \n .. _#2766: https://github.com/pallets/flask/issues/2766\n .. _#2765: https://github.com/pallets/flask/pull/2765\n+.. _#2926: https://github.com/pallets/flask/issues/2926","path":"CHANGES.rst","position":8,"original_position":8,"commit_id":"72911d88db4b71f3db523fb56f01375ef3623bfd","original_commit_id":"72911d88db4b71f3db523fb56f01375ef3623bfd","user":{"login":"davidism","id":1242887,"node_id":"MDQ6VXNlcjEyNDI4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1242887?v=4","gravatar_id":"","url":"https://api.github.com/users/davidism","html_url":"https://github.com/davidism","followers_url":"https://api.github.com/users/davidism/followers","following_url":"https://api.github.com/users/davidism/following{/other_user}","gists_url":"https://api.github.com/users/davidism/gists{/gist_id}","starred_url":"https://api.github.com/users/davidism/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidism/subscriptions","organizations_url":"https://api.github.com/users/davidism/orgs","repos_url":"https://api.github.com/users/davidism/repos","events_url":"https://api.github.com/users/davidism/events{/privacy}","received_events_url":"https://api.github.com/users/davidism/received_events","type":"User","site_admin":false},"body":"This is the wrong link, this PR would be `.pull/2928`. And needs to referenced on the entry line above. That sentence should end with a period.","created_at":"2018-09-28T21:58:08Z","updated_at":"2018-09-28T21:58:28Z","html_url":"https://github.com/pallets/flask/pull/2928#discussion_r221391037","pull_request_url":"https://api.github.com/repos/pallets/flask/pulls/2928","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pallets/flask/pulls/comments/221391037"},"html":{"href":"https://github.com/pallets/flask/pull/2928#discussion_r221391037"},"pull_request":{"href":"https://api.github.com/repos/pallets/flask/pulls/2928"}}},"pull_request":{"url":"https://api.github.com/repos/pallets/flask/pulls/2928","id":219077857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDc3ODU3","html_url":"https://github.com/pallets/flask/pull/2928","diff_url":"https://github.com/pallets/flask/pull/2928.diff","patch_url":"https://github.com/pallets/flask/pull/2928.patch","issue_url":"https://api.github.com/repos/pallets/flask/issues/2928","number":2928,"state":"open","locked":false,"title":"Fix #2926 `Default port overrides requesting a system assigned port`","user":{"login":"vorelq","id":2547534,"node_id":"MDQ6VXNlcjI1NDc1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2547534?v=4","gravatar_id":"","url":"https://api.github.com/users/vorelq","html_url":"https://github.com/vorelq","followers_url":"https://api.github.com/users/vorelq/followers","following_url":"https://api.github.com/users/vorelq/following{/other_user}","gists_url":"https://api.github.com/users/vorelq/gists{/gist_id}","starred_url":"https://api.github.com/users/vorelq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorelq/subscriptions","organizations_url":"https://api.github.com/users/vorelq/orgs","repos_url":"https://api.github.com/users/vorelq/repos","events_url":"https://api.github.com/users/vorelq/events{/privacy}","received_events_url":"https://api.github.com/users/vorelq/received_events","type":"User","site_admin":false},"body":"Fix #2926 \r\n\r\nIn `app.py`, compare possible port values with `None` explicitly, instead of relying on bool casting. Thanks to this, `0` is treated as legitimate port value, and not overwritten by the default value.\r\n","created_at":"2018-09-28T20:30:27Z","updated_at":"2018-09-28T21:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc9d4033bb621f8ac0632fb0325d7cce2a58f21d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pallets/flask/pulls/2928/commits","review_comments_url":"https://api.github.com/repos/pallets/flask/pulls/2928/comments","review_comment_url":"https://api.github.com/repos/pallets/flask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pallets/flask/issues/2928/comments","statuses_url":"https://api.github.com/repos/pallets/flask/statuses/72911d88db4b71f3db523fb56f01375ef3623bfd","head":{"label":"vorelq:2926-default-port-overrides-zero","ref":"2926-default-port-overrides-zero","sha":"72911d88db4b71f3db523fb56f01375ef3623bfd","user":{"login":"vorelq","id":2547534,"node_id":"MDQ6VXNlcjI1NDc1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2547534?v=4","gravatar_id":"","url":"https://api.github.com/users/vorelq","html_url":"https://github.com/vorelq","followers_url":"https://api.github.com/users/vorelq/followers","following_url":"https://api.github.com/users/vorelq/following{/other_user}","gists_url":"https://api.github.com/users/vorelq/gists{/gist_id}","starred_url":"https://api.github.com/users/vorelq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorelq/subscriptions","organizations_url":"https://api.github.com/users/vorelq/orgs","repos_url":"https://api.github.com/users/vorelq/repos","events_url":"https://api.github.com/users/vorelq/events{/privacy}","received_events_url":"https://api.github.com/users/vorelq/received_events","type":"User","site_admin":false},"repo":{"id":150788277,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA3ODgyNzc=","name":"flask","full_name":"vorelq/flask","private":false,"owner":{"login":"vorelq","id":2547534,"node_id":"MDQ6VXNlcjI1NDc1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2547534?v=4","gravatar_id":"","url":"https://api.github.com/users/vorelq","html_url":"https://github.com/vorelq","followers_url":"https://api.github.com/users/vorelq/followers","following_url":"https://api.github.com/users/vorelq/following{/other_user}","gists_url":"https://api.github.com/users/vorelq/gists{/gist_id}","starred_url":"https://api.github.com/users/vorelq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vorelq/subscriptions","organizations_url":"https://api.github.com/users/vorelq/orgs","repos_url":"https://api.github.com/users/vorelq/repos","events_url":"https://api.github.com/users/vorelq/events{/privacy}","received_events_url":"https://api.github.com/users/vorelq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vorelq/flask","description":"The Python micro framework for building web applications.","fork":true,"url":"https://api.github.com/repos/vorelq/flask","forks_url":"https://api.github.com/repos/vorelq/flask/forks","keys_url":"https://api.github.com/repos/vorelq/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vorelq/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vorelq/flask/teams","hooks_url":"https://api.github.com/repos/vorelq/flask/hooks","issue_events_url":"https://api.github.com/repos/vorelq/flask/issues/events{/number}","events_url":"https://api.github.com/repos/vorelq/flask/events","assignees_url":"https://api.github.com/repos/vorelq/flask/assignees{/user}","branches_url":"https://api.github.com/repos/vorelq/flask/branches{/branch}","tags_url":"https://api.github.com/repos/vorelq/flask/tags","blobs_url":"https://api.github.com/repos/vorelq/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vorelq/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vorelq/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/vorelq/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vorelq/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/vorelq/flask/languages","stargazers_url":"https://api.github.com/repos/vorelq/flask/stargazers","contributors_url":"https://api.github.com/repos/vorelq/flask/contributors","subscribers_url":"https://api.github.com/repos/vorelq/flask/subscribers","subscription_url":"https://api.github.com/repos/vorelq/flask/subscription","commits_url":"https://api.github.com/repos/vorelq/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/vorelq/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/vorelq/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/vorelq/flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/vorelq/flask/contents/{+path}","compare_url":"https://api.github.com/repos/vorelq/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vorelq/flask/merges","archive_url":"https://api.github.com/repos/vorelq/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vorelq/flask/downloads","issues_url":"https://api.github.com/repos/vorelq/flask/issues{/number}","pulls_url":"https://api.github.com/repos/vorelq/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/vorelq/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/vorelq/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vorelq/flask/labels{/name}","releases_url":"https://api.github.com/repos/vorelq/flask/releases{/id}","deployments_url":"https://api.github.com/repos/vorelq/flask/deployments","created_at":"2018-09-28T19:52:36Z","updated_at":"2018-09-28T19:52:39Z","pushed_at":"2018-09-28T21:05:47Z","git_url":"git://github.com/vorelq/flask.git","ssh_url":"git@github.com:vorelq/flask.git","clone_url":"https://github.com/vorelq/flask.git","svn_url":"https://github.com/vorelq/flask","homepage":"https://www.palletsprojects.com/p/flask/","size":6281,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pallets:master","ref":"master","sha":"9a2e6ead00f2e5a3a6fe5a3136951c7a038fe5ed","user":{"login":"pallets","id":16748505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQ4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"repo":{"id":596892,"node_id":"MDEwOlJlcG9zaXRvcnk1OTY4OTI=","name":"flask","full_name":"pallets/flask","private":false,"owner":{"login":"pallets","id":16748505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzQ4NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/16748505?v=4","gravatar_id":"","url":"https://api.github.com/users/pallets","html_url":"https://github.com/pallets","followers_url":"https://api.github.com/users/pallets/followers","following_url":"https://api.github.com/users/pallets/following{/other_user}","gists_url":"https://api.github.com/users/pallets/gists{/gist_id}","starred_url":"https://api.github.com/users/pallets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pallets/subscriptions","organizations_url":"https://api.github.com/users/pallets/orgs","repos_url":"https://api.github.com/users/pallets/repos","events_url":"https://api.github.com/users/pallets/events{/privacy}","received_events_url":"https://api.github.com/users/pallets/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pallets/flask","description":"The Python micro framework for building web applications.","fork":false,"url":"https://api.github.com/repos/pallets/flask","forks_url":"https://api.github.com/repos/pallets/flask/forks","keys_url":"https://api.github.com/repos/pallets/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pallets/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pallets/flask/teams","hooks_url":"https://api.github.com/repos/pallets/flask/hooks","issue_events_url":"https://api.github.com/repos/pallets/flask/issues/events{/number}","events_url":"https://api.github.com/repos/pallets/flask/events","assignees_url":"https://api.github.com/repos/pallets/flask/assignees{/user}","branches_url":"https://api.github.com/repos/pallets/flask/branches{/branch}","tags_url":"https://api.github.com/repos/pallets/flask/tags","blobs_url":"https://api.github.com/repos/pallets/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pallets/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pallets/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/pallets/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pallets/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/pallets/flask/languages","stargazers_url":"https://api.github.com/repos/pallets/flask/stargazers","contributors_url":"https://api.github.com/repos/pallets/flask/contributors","subscribers_url":"https://api.github.com/repos/pallets/flask/subscribers","subscription_url":"https://api.github.com/repos/pallets/flask/subscription","commits_url":"https://api.github.com/repos/pallets/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/pallets/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/pallets/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/pallets/flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/pallets/flask/contents/{+path}","compare_url":"https://api.github.com/repos/pallets/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pallets/flask/merges","archive_url":"https://api.github.com/repos/pallets/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pallets/flask/downloads","issues_url":"https://api.github.com/repos/pallets/flask/issues{/number}","pulls_url":"https://api.github.com/repos/pallets/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/pallets/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/pallets/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pallets/flask/labels{/name}","releases_url":"https://api.github.com/repos/pallets/flask/releases{/id}","deployments_url":"https://api.github.com/repos/pallets/flask/deployments","created_at":"2010-04-06T11:11:59Z","updated_at":"2018-09-28T21:36:14Z","pushed_at":"2018-09-28T21:05:49Z","git_url":"git://github.com/pallets/flask.git","ssh_url":"git@github.com:pallets/flask.git","clone_url":"https://github.com/pallets/flask.git","svn_url":"https://github.com/pallets/flask","homepage":"https://www.palletsprojects.com/p/flask/","size":6349,"stargazers_count":39064,"watchers_count":39064,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11361,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11361,"open_issues":49,"watchers":39064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pallets/flask/pulls/2928"},"html":{"href":"https://github.com/pallets/flask/pull/2928"},"issue":{"href":"https://api.github.com/repos/pallets/flask/issues/2928"},"comments":{"href":"https://api.github.com/repos/pallets/flask/issues/2928/comments"},"review_comments":{"href":"https://api.github.com/repos/pallets/flask/pulls/2928/comments"},"review_comment":{"href":"https://api.github.com/repos/pallets/flask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pallets/flask/pulls/2928/commits"},"statuses":{"href":"https://api.github.com/repos/pallets/flask/statuses/72911d88db4b71f3db523fb56f01375ef3623bfd"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidism"}}