{"action":"created","comment":{"url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/comments/240789161","pull_request_review_id":183901133,"id":240789161,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDc4OTE2MQ==","diff_hunk":"@@ -25,26 +25,27 @@ DESCRIPTION\n \n   s.require_path = 'lib'\n   s.files = Dir.glob('{bin,lib,config}/**/*') +\n-    %w(README.md Gemfile neo4j-rake_tasks.gemspec)\n+            %w[README.md Gemfile neo4j-rake_tasks.gemspec]\n   s.has_rdoc = true\n-  s.extra_rdoc_files = %w( README.md )\n+  s.extra_rdoc_files = %w[README.md]\n   s.rdoc_options = [\n     '--quiet',\n     '--title',\n     '--line-numbers',\n     '--main',\n     'README.rdoc',\n-    '--inline-source']\n+    '--inline-source'\n+  ]\n \n-  s.add_dependency('rake')\n   s.add_dependency('os')\n+  s.add_dependency('rake')\n   s.add_dependency('ruby-progressbar')\n-  s.add_dependency('rubyzip', '>= 1.1.7')\n+  s.add_dependency('rubyzip', '~> 1.2', '>= 1.2.1')","path":"neo4j-rake_tasks.gemspec","position":30,"original_position":30,"commit_id":"bbce01d43451fb98c29d6e0484f236668d47d7fd","original_commit_id":"bbce01d43451fb98c29d6e0484f236668d47d7fd","user":{"login":"anshizzle","id":1498248,"node_id":"MDQ6VXNlcjE0OTgyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1498248?v=4","gravatar_id":"","url":"https://api.github.com/users/anshizzle","html_url":"https://github.com/anshizzle","followers_url":"https://api.github.com/users/anshizzle/followers","following_url":"https://api.github.com/users/anshizzle/following{/other_user}","gists_url":"https://api.github.com/users/anshizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/anshizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshizzle/subscriptions","organizations_url":"https://api.github.com/users/anshizzle/orgs","repos_url":"https://api.github.com/users/anshizzle/repos","events_url":"https://api.github.com/users/anshizzle/events{/privacy}","received_events_url":"https://api.github.com/users/anshizzle/received_events","type":"User","site_admin":false},"body":"So I specifically needed because `axlsx 2.x` uses `rubyzip 1.0.0`  and `axlsx 3.0.0.pre` uses `rubyzip >=1.2.1`\r\n\r\nWith some further digging, I learned that there was a vulnerability in `rubyzip 1.1.x` as well - see https://github.com/rubyzip/rubyzip/issues/315","created_at":"2018-12-11T21:01:18Z","updated_at":"2018-12-11T21:01:19Z","html_url":"https://github.com/neo4jrb/neo4j-rake_tasks/pull/46#discussion_r240789161","pull_request_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/comments/240789161"},"html":{"href":"https://github.com/neo4jrb/neo4j-rake_tasks/pull/46#discussion_r240789161"},"pull_request":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46"}},"in_reply_to_id":240718144},"pull_request":{"url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46","id":237421523,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDIxNTIz","html_url":"https://github.com/neo4jrb/neo4j-rake_tasks/pull/46","diff_url":"https://github.com/neo4jrb/neo4j-rake_tasks/pull/46.diff","patch_url":"https://github.com/neo4jrb/neo4j-rake_tasks/pull/46.patch","issue_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues/46","number":46,"state":"open","locked":false,"title":"Upgrade rubyzip to version >= 1.2.1","user":{"login":"anshizzle","id":1498248,"node_id":"MDQ6VXNlcjE0OTgyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1498248?v=4","gravatar_id":"","url":"https://api.github.com/users/anshizzle","html_url":"https://github.com/anshizzle","followers_url":"https://api.github.com/users/anshizzle/followers","following_url":"https://api.github.com/users/anshizzle/following{/other_user}","gists_url":"https://api.github.com/users/anshizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/anshizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshizzle/subscriptions","organizations_url":"https://api.github.com/users/anshizzle/orgs","repos_url":"https://api.github.com/users/anshizzle/repos","events_url":"https://api.github.com/users/anshizzle/events{/privacy}","received_events_url":"https://api.github.com/users/anshizzle/received_events","type":"User","site_admin":false},"body":"Fixes #\r\n\r\nThis pull introduces/changes:\r\n * Upgrades rubyzip to version >= 1.2.1 \r\n * Some additional changes courtesy of rubocop\r\n\r\nPings:\r\n@cheerfulstoic\r\n@subvertallchris\r\n","created_at":"2018-12-10T18:28:44Z","updated_at":"2018-12-11T21:01:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beb7ee862c0f90acf1acaca951767c9ac2ea0d55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46/commits","review_comments_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46/comments","review_comment_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues/46/comments","statuses_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/statuses/bbce01d43451fb98c29d6e0484f236668d47d7fd","head":{"label":"anshizzle:master","ref":"master","sha":"bbce01d43451fb98c29d6e0484f236668d47d7fd","user":{"login":"anshizzle","id":1498248,"node_id":"MDQ6VXNlcjE0OTgyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1498248?v=4","gravatar_id":"","url":"https://api.github.com/users/anshizzle","html_url":"https://github.com/anshizzle","followers_url":"https://api.github.com/users/anshizzle/followers","following_url":"https://api.github.com/users/anshizzle/following{/other_user}","gists_url":"https://api.github.com/users/anshizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/anshizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshizzle/subscriptions","organizations_url":"https://api.github.com/users/anshizzle/orgs","repos_url":"https://api.github.com/users/anshizzle/repos","events_url":"https://api.github.com/users/anshizzle/events{/privacy}","received_events_url":"https://api.github.com/users/anshizzle/received_events","type":"User","site_admin":false},"repo":{"id":161214714,"node_id":"MDEwOlJlcG9zaXRvcnkxNjEyMTQ3MTQ=","name":"neo4j-rake_tasks","full_name":"anshizzle/neo4j-rake_tasks","private":false,"owner":{"login":"anshizzle","id":1498248,"node_id":"MDQ6VXNlcjE0OTgyNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1498248?v=4","gravatar_id":"","url":"https://api.github.com/users/anshizzle","html_url":"https://github.com/anshizzle","followers_url":"https://api.github.com/users/anshizzle/followers","following_url":"https://api.github.com/users/anshizzle/following{/other_user}","gists_url":"https://api.github.com/users/anshizzle/gists{/gist_id}","starred_url":"https://api.github.com/users/anshizzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshizzle/subscriptions","organizations_url":"https://api.github.com/users/anshizzle/orgs","repos_url":"https://api.github.com/users/anshizzle/repos","events_url":"https://api.github.com/users/anshizzle/events{/privacy}","received_events_url":"https://api.github.com/users/anshizzle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anshizzle/neo4j-rake_tasks","description":"Rake tasks for managing Neo4j. Tasks allow for starting, stopping, and configuring","fork":true,"url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks","forks_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/forks","keys_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/teams","hooks_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/hooks","issue_events_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/issues/events{/number}","events_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/events","assignees_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/assignees{/user}","branches_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/branches{/branch}","tags_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/tags","blobs_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/languages","stargazers_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/stargazers","contributors_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/contributors","subscribers_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/subscribers","subscription_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/subscription","commits_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/contents/{+path}","compare_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/merges","archive_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/downloads","issues_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/issues{/number}","pulls_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/labels{/name}","releases_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/releases{/id}","deployments_url":"https://api.github.com/repos/anshizzle/neo4j-rake_tasks/deployments","created_at":"2018-12-10T17:53:02Z","updated_at":"2018-12-10T18:28:36Z","pushed_at":"2018-12-10T18:28:35Z","git_url":"git://github.com/anshizzle/neo4j-rake_tasks.git","ssh_url":"git@github.com:anshizzle/neo4j-rake_tasks.git","clone_url":"https://github.com/anshizzle/neo4j-rake_tasks.git","svn_url":"https://github.com/anshizzle/neo4j-rake_tasks","homepage":null,"size":54774,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4jrb:master","ref":"master","sha":"2f76b1943ca6eb4be9ce022ad664621128e8aad7","user":{"login":"neo4jrb","id":8579795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Nzk3OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/8579795?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4jrb","html_url":"https://github.com/neo4jrb","followers_url":"https://api.github.com/users/neo4jrb/followers","following_url":"https://api.github.com/users/neo4jrb/following{/other_user}","gists_url":"https://api.github.com/users/neo4jrb/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4jrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4jrb/subscriptions","organizations_url":"https://api.github.com/users/neo4jrb/orgs","repos_url":"https://api.github.com/users/neo4jrb/repos","events_url":"https://api.github.com/users/neo4jrb/events{/privacy}","received_events_url":"https://api.github.com/users/neo4jrb/received_events","type":"Organization","site_admin":false},"repo":{"id":38841755,"node_id":"MDEwOlJlcG9zaXRvcnkzODg0MTc1NQ==","name":"neo4j-rake_tasks","full_name":"neo4jrb/neo4j-rake_tasks","private":false,"owner":{"login":"neo4jrb","id":8579795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1Nzk3OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/8579795?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4jrb","html_url":"https://github.com/neo4jrb","followers_url":"https://api.github.com/users/neo4jrb/followers","following_url":"https://api.github.com/users/neo4jrb/following{/other_user}","gists_url":"https://api.github.com/users/neo4jrb/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4jrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4jrb/subscriptions","organizations_url":"https://api.github.com/users/neo4jrb/orgs","repos_url":"https://api.github.com/users/neo4jrb/repos","events_url":"https://api.github.com/users/neo4jrb/events{/privacy}","received_events_url":"https://api.github.com/users/neo4jrb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/neo4jrb/neo4j-rake_tasks","description":"Rake tasks for managing Neo4j. Tasks allow for starting, stopping, and configuring","fork":false,"url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks","forks_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/forks","keys_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/teams","hooks_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/hooks","issue_events_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues/events{/number}","events_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/events","assignees_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/assignees{/user}","branches_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/branches{/branch}","tags_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/tags","blobs_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/languages","stargazers_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/stargazers","contributors_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/contributors","subscribers_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/subscribers","subscription_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/subscription","commits_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/contents/{+path}","compare_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/merges","archive_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/downloads","issues_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues{/number}","pulls_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/labels{/name}","releases_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/releases{/id}","deployments_url":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/deployments","created_at":"2015-07-09T19:47:23Z","updated_at":"2018-09-23T05:34:45Z","pushed_at":"2018-12-10T18:28:45Z","git_url":"git://github.com/neo4jrb/neo4j-rake_tasks.git","ssh_url":"git@github.com:neo4jrb/neo4j-rake_tasks.git","clone_url":"https://github.com/neo4jrb/neo4j-rake_tasks.git","svn_url":"https://github.com/neo4jrb/neo4j-rake_tasks","homepage":null,"size":54772,"stargazers_count":10,"watchers_count":10,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":21,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46"},"html":{"href":"https://github.com/neo4jrb/neo4j-rake_tasks/pull/46"},"issue":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues/46"},"comments":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/neo4jrb/neo4j-rake_tasks/statuses/bbce01d43451fb98c29d6e0484f236668d47d7fd"}},"author_association":"NONE"}}
{"actor":{"display_login":"anshizzle"}}