{"action":"created","issue":{"url":"https://api.github.com/repos/brentsimmons/RSParser/issues/25","repository_url":"https://api.github.com/repos/brentsimmons/RSParser","labels_url":"https://api.github.com/repos/brentsimmons/RSParser/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/brentsimmons/RSParser/issues/25/comments","events_url":"https://api.github.com/repos/brentsimmons/RSParser/issues/25/events","html_url":"https://github.com/brentsimmons/RSParser/pull/25","id":293590380,"number":25,"title":"Issue #1 : Add iOS Support","user":{"login":"dcilia","id":992986,"avatar_url":"https://avatars1.githubusercontent.com/u/992986?v=4","gravatar_id":"","url":"https://api.github.com/users/dcilia","html_url":"https://github.com/dcilia","followers_url":"https://api.github.com/users/dcilia/followers","following_url":"https://api.github.com/users/dcilia/following{/other_user}","gists_url":"https://api.github.com/users/dcilia/gists{/gist_id}","starred_url":"https://api.github.com/users/dcilia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcilia/subscriptions","organizations_url":"https://api.github.com/users/dcilia/orgs","repos_url":"https://api.github.com/users/dcilia/repos","events_url":"https://api.github.com/users/dcilia/events{/privacy}","received_events_url":"https://api.github.com/users/dcilia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-01T16:15:07Z","updated_at":"2018-02-01T17:08:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/brentsimmons/RSParser/pulls/25","html_url":"https://github.com/brentsimmons/RSParser/pull/25","diff_url":"https://github.com/brentsimmons/RSParser/pull/25.diff","patch_url":"https://github.com/brentsimmons/RSParser/pull/25.patch"},"body":"See previous discussion:\r\nhttps://github.com/brentsimmons/RSParser/pull/23\r\n\r\nSince there are no schemes, I was not able to run tests:\r\n\r\n``` \r\n$ xcrun xcodebuild -sdk iphonesimulator test\r\nBuild settings from command line:\r\n    SDKROOT = iphonesimulator11.3\r\n\r\nxcodebuild: error: The test action requires that the name of a scheme in the project is provided using the \"-scheme\" option. The \"-list\" option can be used to find the names of the schemes in the project.\r\n```\r\n\r\nRunning ```xcodebuild``` on each platform results in successful compilation.\r\n\r\nSide note:  if ```carthage``` support is desirable, we should add a shared scheme.\r\n\r\nI am going to close the other pull request.\r\n"},"comment":{"url":"https://api.github.com/repos/brentsimmons/RSParser/issues/comments/362334793","html_url":"https://github.com/brentsimmons/RSParser/pull/25#issuecomment-362334793","issue_url":"https://api.github.com/repos/brentsimmons/RSParser/issues/25","id":362334793,"user":{"login":"danielpunkass","id":14606,"avatar_url":"https://avatars1.githubusercontent.com/u/14606?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpunkass","html_url":"https://github.com/danielpunkass","followers_url":"https://api.github.com/users/danielpunkass/followers","following_url":"https://api.github.com/users/danielpunkass/following{/other_user}","gists_url":"https://api.github.com/users/danielpunkass/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpunkass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpunkass/subscriptions","organizations_url":"https://api.github.com/users/danielpunkass/orgs","repos_url":"https://api.github.com/users/danielpunkass/repos","events_url":"https://api.github.com/users/danielpunkass/events{/privacy}","received_events_url":"https://api.github.com/users/danielpunkass/received_events","type":"User","site_admin":false},"created_at":"2018-02-01T17:08:14Z","updated_at":"2018-02-01T17:08:14Z","author_association":"COLLABORATOR","body":"Thanks, @dcilia ! We should probably add a shared scheme. Just FYI you are always able to add schemes in Xcode that are not shared, if you need/want to run a specific target. I am guessing that @brentsimmons has been working with a private scheme for tests.\r\n\r\nOne note about GitHub pull requests: I'm far from an expert but I think it can be valuable to add revisions, or even start from scratch and then just reapply the same branch name to a different revision, when amending a pull request. That way all the cumulative comments are in one place and not in separate pull requests. Any changes you make to your \"add_platforms_b\" branch going forward should be automatically reflected by GitHub here.\r\n\r\nI'm going to take a look at the changes you've proposed here and see about getting the unit tests running. Maybe I'll make a shared scheme you can merge in to your branch so you can also test it with confidence."}}
{"actor":{"display_login":"danielpunkass"}}