{"action":"closed","number":142,"pull_request":{"url":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/142","id":238528981,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTI4OTgx","html_url":"https://github.com/bulwark-crypto/Bulwark/pull/142","diff_url":"https://github.com/bulwark-crypto/Bulwark/pull/142.diff","patch_url":"https://github.com/bulwark-crypto/Bulwark/pull/142.patch","issue_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues/142","number":142,"state":"closed","locked":false,"title":"Update Readme to correctly reflect Reward Splits and supply","user":{"login":"VoxTerra77","id":35669663,"node_id":"MDQ6VXNlcjM1NjY5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/35669663?v=4","gravatar_id":"","url":"https://api.github.com/users/VoxTerra77","html_url":"https://github.com/VoxTerra77","followers_url":"https://api.github.com/users/VoxTerra77/followers","following_url":"https://api.github.com/users/VoxTerra77/following{/other_user}","gists_url":"https://api.github.com/users/VoxTerra77/gists{/gist_id}","starred_url":"https://api.github.com/users/VoxTerra77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoxTerra77/subscriptions","organizations_url":"https://api.github.com/users/VoxTerra77/orgs","repos_url":"https://api.github.com/users/VoxTerra77/repos","events_url":"https://api.github.com/users/VoxTerra77/events{/privacy}","received_events_url":"https://api.github.com/users/VoxTerra77/received_events","type":"User","site_admin":false},"body":"Reward Split category renamed\r\n60/30/10 changed to 65/35\r\n\"Governance Funds\" section added to reflect the maximum possible amount to be generated via superblocks between years 1 and 5, with the addition of 72,000 BWK from the Superblock preceding the start of Year 2.\r\n\r\nPull requests without a rationale and clear improvement may be closed\r\nimmediately.\r\n\r\nPlease provide clear motivation for your patch and explain how it improves\r\nBulwark Core user experience or Bulwark Core developer experience\r\nsignificantly.\r\n\r\n* Any test improvements or new tests that improve coverage are always welcome.\r\n* All other changes should have accompanying unit tests (see `src/test/`) or\r\n  functional tests (see `test/`). Contributors should note which tests cover\r\n  modified code. If no tests exist for a region of modified code, new tests\r\n  should accompany the change.\r\n* Bug fixes are most welcome when they come with steps to reproduce or an\r\n  explanation of the potential issue as well as reasoning for the way the bug\r\n  was fixed.\r\n* Features are welcome, but might be rejected due to design or scope issues.\r\n  If a feature is based on a lot of dependencies, contributors should first\r\n  consider building the system outside of Bulwark Core, if possible.\r\n* Refactoring changes are only accepted if they are required for a feature or\r\n  bug fix or otherwise improve developer experience significantly. For example,\r\n  most \"code style\" refactoring changes require a thorough explanation why they\r\n  are useful, what downsides they have and why they *significantly* improve\r\n  developer experience or avoid serious programming bugs. Note that code style\r\n  is often a subjective matter. Unless they are explicitly mentioned to be\r\n  preferred in the [developer notes](/doc/miscellaneous/Developer-Notes.md), stylistic code\r\n  changes are usually rejected.\r\n\r\nBulwark Core has a thorough review process and even the most trivial change\r\nneeds to pass a lot of eyes and requires non-zero or even substantial time\r\neffort to review. There is a huge lack of active reviewers on the project, so\r\npatches often sit for a long time.\r\n","created_at":"2018-12-13T20:54:48Z","updated_at":"2018-12-14T01:45:37Z","closed_at":"2018-12-14T01:45:37Z","merged_at":"2018-12-14T01:45:37Z","merge_commit_sha":"8fbfe3e8089202f70f834b66e8637b1eefad16c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":775410406,"node_id":"MDU6TGFiZWw3NzU0MTA0MDY=","url":"https://api.github.com/repos/bulwark-crypto/Bulwark/labels/documentation","name":"documentation","color":"011093","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/142/commits","review_comments_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/142/comments","review_comment_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues/142/comments","statuses_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/statuses/a6acafb8948d663e900f05e1f0c7a90bbbfd2a6a","head":{"label":"VoxTerra77:patch-8","ref":"patch-8","sha":"a6acafb8948d663e900f05e1f0c7a90bbbfd2a6a","user":{"login":"VoxTerra77","id":35669663,"node_id":"MDQ6VXNlcjM1NjY5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/35669663?v=4","gravatar_id":"","url":"https://api.github.com/users/VoxTerra77","html_url":"https://github.com/VoxTerra77","followers_url":"https://api.github.com/users/VoxTerra77/followers","following_url":"https://api.github.com/users/VoxTerra77/following{/other_user}","gists_url":"https://api.github.com/users/VoxTerra77/gists{/gist_id}","starred_url":"https://api.github.com/users/VoxTerra77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoxTerra77/subscriptions","organizations_url":"https://api.github.com/users/VoxTerra77/orgs","repos_url":"https://api.github.com/users/VoxTerra77/repos","events_url":"https://api.github.com/users/VoxTerra77/events{/privacy}","received_events_url":"https://api.github.com/users/VoxTerra77/received_events","type":"User","site_admin":false},"repo":{"id":144647482,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2NDc0ODI=","name":"Bulwark","full_name":"VoxTerra77/Bulwark","private":false,"owner":{"login":"VoxTerra77","id":35669663,"node_id":"MDQ6VXNlcjM1NjY5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/35669663?v=4","gravatar_id":"","url":"https://api.github.com/users/VoxTerra77","html_url":"https://github.com/VoxTerra77","followers_url":"https://api.github.com/users/VoxTerra77/followers","following_url":"https://api.github.com/users/VoxTerra77/following{/other_user}","gists_url":"https://api.github.com/users/VoxTerra77/gists{/gist_id}","starred_url":"https://api.github.com/users/VoxTerra77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VoxTerra77/subscriptions","organizations_url":"https://api.github.com/users/VoxTerra77/orgs","repos_url":"https://api.github.com/users/VoxTerra77/repos","events_url":"https://api.github.com/users/VoxTerra77/events{/privacy}","received_events_url":"https://api.github.com/users/VoxTerra77/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VoxTerra77/Bulwark","description":"The primary development repository for the Bulwark project","fork":true,"url":"https://api.github.com/repos/VoxTerra77/Bulwark","forks_url":"https://api.github.com/repos/VoxTerra77/Bulwark/forks","keys_url":"https://api.github.com/repos/VoxTerra77/Bulwark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VoxTerra77/Bulwark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VoxTerra77/Bulwark/teams","hooks_url":"https://api.github.com/repos/VoxTerra77/Bulwark/hooks","issue_events_url":"https://api.github.com/repos/VoxTerra77/Bulwark/issues/events{/number}","events_url":"https://api.github.com/repos/VoxTerra77/Bulwark/events","assignees_url":"https://api.github.com/repos/VoxTerra77/Bulwark/assignees{/user}","branches_url":"https://api.github.com/repos/VoxTerra77/Bulwark/branches{/branch}","tags_url":"https://api.github.com/repos/VoxTerra77/Bulwark/tags","blobs_url":"https://api.github.com/repos/VoxTerra77/Bulwark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VoxTerra77/Bulwark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VoxTerra77/Bulwark/git/refs{/sha}","trees_url":"https://api.github.com/repos/VoxTerra77/Bulwark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VoxTerra77/Bulwark/statuses/{sha}","languages_url":"https://api.github.com/repos/VoxTerra77/Bulwark/languages","stargazers_url":"https://api.github.com/repos/VoxTerra77/Bulwark/stargazers","contributors_url":"https://api.github.com/repos/VoxTerra77/Bulwark/contributors","subscribers_url":"https://api.github.com/repos/VoxTerra77/Bulwark/subscribers","subscription_url":"https://api.github.com/repos/VoxTerra77/Bulwark/subscription","commits_url":"https://api.github.com/repos/VoxTerra77/Bulwark/commits{/sha}","git_commits_url":"https://api.github.com/repos/VoxTerra77/Bulwark/git/commits{/sha}","comments_url":"https://api.github.com/repos/VoxTerra77/Bulwark/comments{/number}","issue_comment_url":"https://api.github.com/repos/VoxTerra77/Bulwark/issues/comments{/number}","contents_url":"https://api.github.com/repos/VoxTerra77/Bulwark/contents/{+path}","compare_url":"https://api.github.com/repos/VoxTerra77/Bulwark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VoxTerra77/Bulwark/merges","archive_url":"https://api.github.com/repos/VoxTerra77/Bulwark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VoxTerra77/Bulwark/downloads","issues_url":"https://api.github.com/repos/VoxTerra77/Bulwark/issues{/number}","pulls_url":"https://api.github.com/repos/VoxTerra77/Bulwark/pulls{/number}","milestones_url":"https://api.github.com/repos/VoxTerra77/Bulwark/milestones{/number}","notifications_url":"https://api.github.com/repos/VoxTerra77/Bulwark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VoxTerra77/Bulwark/labels{/name}","releases_url":"https://api.github.com/repos/VoxTerra77/Bulwark/releases{/id}","deployments_url":"https://api.github.com/repos/VoxTerra77/Bulwark/deployments","created_at":"2018-08-14T00:21:30Z","updated_at":"2018-08-14T00:21:35Z","pushed_at":"2018-12-13T20:54:30Z","git_url":"git://github.com/VoxTerra77/Bulwark.git","ssh_url":"git@github.com:VoxTerra77/Bulwark.git","clone_url":"https://github.com/VoxTerra77/Bulwark.git","svn_url":"https://github.com/VoxTerra77/Bulwark","homepage":"","size":10147,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bulwark-crypto:master","ref":"master","sha":"5317f5ef7e2fef2145526a9c4ce012acb834210d","user":{"login":"bulwark-crypto","id":32829172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODI5MTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32829172?v=4","gravatar_id":"","url":"https://api.github.com/users/bulwark-crypto","html_url":"https://github.com/bulwark-crypto","followers_url":"https://api.github.com/users/bulwark-crypto/followers","following_url":"https://api.github.com/users/bulwark-crypto/following{/other_user}","gists_url":"https://api.github.com/users/bulwark-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/bulwark-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bulwark-crypto/subscriptions","organizations_url":"https://api.github.com/users/bulwark-crypto/orgs","repos_url":"https://api.github.com/users/bulwark-crypto/repos","events_url":"https://api.github.com/users/bulwark-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/bulwark-crypto/received_events","type":"Organization","site_admin":false},"repo":{"id":112736998,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3MzY5OTg=","name":"Bulwark","full_name":"bulwark-crypto/Bulwark","private":false,"owner":{"login":"bulwark-crypto","id":32829172,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODI5MTcy","avatar_url":"https://avatars0.githubusercontent.com/u/32829172?v=4","gravatar_id":"","url":"https://api.github.com/users/bulwark-crypto","html_url":"https://github.com/bulwark-crypto","followers_url":"https://api.github.com/users/bulwark-crypto/followers","following_url":"https://api.github.com/users/bulwark-crypto/following{/other_user}","gists_url":"https://api.github.com/users/bulwark-crypto/gists{/gist_id}","starred_url":"https://api.github.com/users/bulwark-crypto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bulwark-crypto/subscriptions","organizations_url":"https://api.github.com/users/bulwark-crypto/orgs","repos_url":"https://api.github.com/users/bulwark-crypto/repos","events_url":"https://api.github.com/users/bulwark-crypto/events{/privacy}","received_events_url":"https://api.github.com/users/bulwark-crypto/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bulwark-crypto/Bulwark","description":"The primary development repository for the Bulwark project","fork":false,"url":"https://api.github.com/repos/bulwark-crypto/Bulwark","forks_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/forks","keys_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/teams","hooks_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/hooks","issue_events_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues/events{/number}","events_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/events","assignees_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/assignees{/user}","branches_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/branches{/branch}","tags_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/tags","blobs_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/git/refs{/sha}","trees_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/statuses/{sha}","languages_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/languages","stargazers_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/stargazers","contributors_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/contributors","subscribers_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/subscribers","subscription_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/subscription","commits_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/commits{/sha}","git_commits_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/git/commits{/sha}","comments_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/comments{/number}","issue_comment_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues/comments{/number}","contents_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/contents/{+path}","compare_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/merges","archive_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/downloads","issues_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues{/number}","pulls_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls{/number}","milestones_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/milestones{/number}","notifications_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/labels{/name}","releases_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/releases{/id}","deployments_url":"https://api.github.com/repos/bulwark-crypto/Bulwark/deployments","created_at":"2017-12-01T12:21:10Z","updated_at":"2018-12-06T03:21:47Z","pushed_at":"2018-12-14T01:45:37Z","git_url":"git://github.com/bulwark-crypto/Bulwark.git","ssh_url":"git@github.com:bulwark-crypto/Bulwark.git","clone_url":"https://github.com/bulwark-crypto/Bulwark.git","svn_url":"https://github.com/bulwark-crypto/Bulwark","homepage":"https://bulwarkcrypto.com/","size":10705,"stargazers_count":57,"watchers_count":57,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":54,"open_issues":9,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/142"},"html":{"href":"https://github.com/bulwark-crypto/Bulwark/pull/142"},"issue":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues/142"},"comments":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/bulwark-crypto/Bulwark/statuses/a6acafb8948d663e900f05e1f0c7a90bbbfd2a6a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dustinengle","id":18477105,"node_id":"MDQ6VXNlcjE4NDc3MTA1","avatar_url":"https://avatars0.githubusercontent.com/u/18477105?v=4","gravatar_id":"","url":"https://api.github.com/users/dustinengle","html_url":"https://github.com/dustinengle","followers_url":"https://api.github.com/users/dustinengle/followers","following_url":"https://api.github.com/users/dustinengle/following{/other_user}","gists_url":"https://api.github.com/users/dustinengle/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinengle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinengle/subscriptions","organizations_url":"https://api.github.com/users/dustinengle/orgs","repos_url":"https://api.github.com/users/dustinengle/repos","events_url":"https://api.github.com/users/dustinengle/events{/privacy}","received_events_url":"https://api.github.com/users/dustinengle/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":18,"changed_files":1}}
{"actor":{"display_login":"dustinengle"}}