{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/9498","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/9498/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/9498/comments","events_url":"https://api.github.com/repos/istio/istio/issues/9498/events","html_url":"https://github.com/istio/istio/pull/9498","id":373314979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjcyMzc0","number":9498,"title":"Add MCP connection and nack rate limiting     ","user":{"login":"ayj","id":116378,"node_id":"MDQ6VXNlcjExNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-24T05:48:54Z","updated_at":"2018-10-26T22:50:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/9498","html_url":"https://github.com/istio/istio/pull/9498","diff_url":"https://github.com/istio/istio/pull/9498.diff","patch_url":"https://github.com/istio/istio/pull/9498.patch"},"body":"Fixes https://github.com/istio/istio/issues/8471\r\n\r\nThis PR also reworks the scheduling mechanism between the snapshot and serving layers in the MCP layer. The previous logic relied on channels to buffer pending pushed responses between the snapshot and serving code. This made enforcing rate limiting trickier and was potentially subject to pushing unnecessary intermediate state if the snapshot changed at a higher rate than the downstream components ACK/NACK'd. The new scheduling mechanism uses a mailbox to store the latest snapshot and a channel for indicating that the mailbox is full. This should be more durable in cases where write_rate (new snapshot) is greater than read_rate (response pushed to client). The latest snapshot version will be pushed and any intermediate snapshots skipped in such cases.\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/433563412","html_url":"https://github.com/istio/istio/pull/9498#issuecomment-433563412","issue_url":"https://api.github.com/repos/istio/istio/issues/9498","id":433563412,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzU2MzQxMg==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T22:50:06Z","updated_at":"2018-10-26T22:50:06Z","author_association":"COLLABORATOR","body":"@ayj: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/istio-integ-k8s-tests.sh | 2ca1813d97e5da70d65aa51776076f703e9bebe1 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/9498/istio-integ-k8s-tests/61) | `/test istio-integ-k8s-tests`\nprow/istio-integ-local-tests.sh | 9c5523ff4f80ebd688ba5a9c6cbcb344ba91853d | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pr-logs/pull/istio_istio/9498/istio-integ-local-tests/63) | `/test istio-integ-local-tests`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}