{"action":"created","comment":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/comments/192206491","pull_request_review_id":124928449,"id":192206491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjIwNjQ5MQ==","diff_hunk":"@@ -1121,32 +1121,58 @@ VIREO_FUNCTION_SIGNATURET(ArrayMaxMinInternal, FindArrayMaxMinInstruction)\n     AQBlock1* maxValue = minValue;\n     if (len == 0)\n         maxIndex = minIndex = -1;\n+\n+    Boolean haveSeenPositiveInfinity = false;\n+    Boolean haveSeenNegativeInfinity = false;\n     for (IntIndex i = 0; i < len; i++) {\n-        Boolean less;\n-        snippet->_p0 = arrayIn->BeginAt(i);\n+        Boolean shouldUpdateMaxOrMin = false;\n+        AQBlock1* currentElement = arrayIn->BeginAt(i);\n+        Double currentElementValue = *((Double*)currentElement);","path":"source/core/Array.cpp","position":21,"original_position":21,"commit_id":"47f1aff040f0820dfff3b7a7fcfb3769cd6186f3","original_commit_id":"47f1aff040f0820dfff3b7a7fcfb3769cd6186f3","user":{"login":"spathiwa","id":860388,"node_id":"MDQ6VXNlcjg2MDM4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/860388?v=4","gravatar_id":"","url":"https://api.github.com/users/spathiwa","html_url":"https://github.com/spathiwa","followers_url":"https://api.github.com/users/spathiwa/followers","following_url":"https://api.github.com/users/spathiwa/following{/other_user}","gists_url":"https://api.github.com/users/spathiwa/gists{/gist_id}","starred_url":"https://api.github.com/users/spathiwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spathiwa/subscriptions","organizations_url":"https://api.github.com/users/spathiwa/orgs","repos_url":"https://api.github.com/users/spathiwa/repos","events_url":"https://api.github.com/users/spathiwa/events{/privacy}","received_events_url":"https://api.github.com/users/spathiwa/received_events","type":"User","site_admin":false},"body":"Yeah, this is definitely wrong.  It's not just inf/nan -- the read of memory as double will get the wrong values in ALL cases when the array element type isn't actually doubles.\r\n","created_at":"2018-05-31T19:10:19Z","updated_at":"2018-05-31T19:10:23Z","html_url":"https://github.com/ni/VireoSDK/pull/438#discussion_r192206491","pull_request_url":"https://api.github.com/repos/ni/VireoSDK/pulls/438","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/comments/192206491"},"html":{"href":"https://github.com/ni/VireoSDK/pull/438#discussion_r192206491"},"pull_request":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/438"}},"in_reply_to_id":191784151},"pull_request":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/438","id":190417409,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNDE3NDA5","html_url":"https://github.com/ni/VireoSDK/pull/438","diff_url":"https://github.com/ni/VireoSDK/pull/438.diff","patch_url":"https://github.com/ni/VireoSDK/pull/438.patch","issue_url":"https://api.github.com/repos/ni/VireoSDK/issues/438","number":438,"state":"open","locked":false,"title":"Array max min infinities and null fix","user":{"login":"mehagar","id":7461705,"node_id":"MDQ6VXNlcjc0NjE3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/7461705?v=4","gravatar_id":"","url":"https://api.github.com/users/mehagar","html_url":"https://github.com/mehagar","followers_url":"https://api.github.com/users/mehagar/followers","following_url":"https://api.github.com/users/mehagar/following{/other_user}","gists_url":"https://api.github.com/users/mehagar/gists{/gist_id}","starred_url":"https://api.github.com/users/mehagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehagar/subscriptions","organizations_url":"https://api.github.com/users/mehagar/orgs","repos_url":"https://api.github.com/users/mehagar/repos","events_url":"https://api.github.com/users/mehagar/events{/privacy}","received_events_url":"https://api.github.com/users/mehagar/received_events","type":"User","site_admin":false},"body":"We weren't correctly setting the right max/min values when NaN's were passed in. I added the logic to handle these cases, and a test for them.","created_at":"2018-05-24T20:55:30Z","updated_at":"2018-05-31T19:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c336fe1cb43fe32b3f363e7c8686b30623db4ac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cglzaguilar","id":8452083,"node_id":"MDQ6VXNlcjg0NTIwODM=","avatar_url":"https://avatars3.githubusercontent.com/u/8452083?v=4","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ni/VireoSDK/pulls/438/commits","review_comments_url":"https://api.github.com/repos/ni/VireoSDK/pulls/438/comments","review_comment_url":"https://api.github.com/repos/ni/VireoSDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ni/VireoSDK/issues/438/comments","statuses_url":"https://api.github.com/repos/ni/VireoSDK/statuses/47f1aff040f0820dfff3b7a7fcfb3769cd6186f3","head":{"label":"mehagar:arrayMaxMin","ref":"arrayMaxMin","sha":"47f1aff040f0820dfff3b7a7fcfb3769cd6186f3","user":{"login":"mehagar","id":7461705,"node_id":"MDQ6VXNlcjc0NjE3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/7461705?v=4","gravatar_id":"","url":"https://api.github.com/users/mehagar","html_url":"https://github.com/mehagar","followers_url":"https://api.github.com/users/mehagar/followers","following_url":"https://api.github.com/users/mehagar/following{/other_user}","gists_url":"https://api.github.com/users/mehagar/gists{/gist_id}","starred_url":"https://api.github.com/users/mehagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehagar/subscriptions","organizations_url":"https://api.github.com/users/mehagar/orgs","repos_url":"https://api.github.com/users/mehagar/repos","events_url":"https://api.github.com/users/mehagar/events{/privacy}","received_events_url":"https://api.github.com/users/mehagar/received_events","type":"User","site_admin":false},"repo":{"id":116283800,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYyODM4MDA=","name":"VireoSDK","full_name":"mehagar/VireoSDK","owner":{"login":"mehagar","id":7461705,"node_id":"MDQ6VXNlcjc0NjE3MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/7461705?v=4","gravatar_id":"","url":"https://api.github.com/users/mehagar","html_url":"https://github.com/mehagar","followers_url":"https://api.github.com/users/mehagar/followers","following_url":"https://api.github.com/users/mehagar/following{/other_user}","gists_url":"https://api.github.com/users/mehagar/gists{/gist_id}","starred_url":"https://api.github.com/users/mehagar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mehagar/subscriptions","organizations_url":"https://api.github.com/users/mehagar/orgs","repos_url":"https://api.github.com/users/mehagar/repos","events_url":"https://api.github.com/users/mehagar/events{/privacy}","received_events_url":"https://api.github.com/users/mehagar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mehagar/VireoSDK","description":"Compact runtime for a subset of LabVIEW","fork":true,"url":"https://api.github.com/repos/mehagar/VireoSDK","forks_url":"https://api.github.com/repos/mehagar/VireoSDK/forks","keys_url":"https://api.github.com/repos/mehagar/VireoSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mehagar/VireoSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mehagar/VireoSDK/teams","hooks_url":"https://api.github.com/repos/mehagar/VireoSDK/hooks","issue_events_url":"https://api.github.com/repos/mehagar/VireoSDK/issues/events{/number}","events_url":"https://api.github.com/repos/mehagar/VireoSDK/events","assignees_url":"https://api.github.com/repos/mehagar/VireoSDK/assignees{/user}","branches_url":"https://api.github.com/repos/mehagar/VireoSDK/branches{/branch}","tags_url":"https://api.github.com/repos/mehagar/VireoSDK/tags","blobs_url":"https://api.github.com/repos/mehagar/VireoSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mehagar/VireoSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mehagar/VireoSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/mehagar/VireoSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mehagar/VireoSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/mehagar/VireoSDK/languages","stargazers_url":"https://api.github.com/repos/mehagar/VireoSDK/stargazers","contributors_url":"https://api.github.com/repos/mehagar/VireoSDK/contributors","subscribers_url":"https://api.github.com/repos/mehagar/VireoSDK/subscribers","subscription_url":"https://api.github.com/repos/mehagar/VireoSDK/subscription","commits_url":"https://api.github.com/repos/mehagar/VireoSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/mehagar/VireoSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/mehagar/VireoSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/mehagar/VireoSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/mehagar/VireoSDK/contents/{+path}","compare_url":"https://api.github.com/repos/mehagar/VireoSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mehagar/VireoSDK/merges","archive_url":"https://api.github.com/repos/mehagar/VireoSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mehagar/VireoSDK/downloads","issues_url":"https://api.github.com/repos/mehagar/VireoSDK/issues{/number}","pulls_url":"https://api.github.com/repos/mehagar/VireoSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/mehagar/VireoSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/mehagar/VireoSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mehagar/VireoSDK/labels{/name}","releases_url":"https://api.github.com/repos/mehagar/VireoSDK/releases{/id}","deployments_url":"https://api.github.com/repos/mehagar/VireoSDK/deployments","created_at":"2018-01-04T16:42:43Z","updated_at":"2018-05-24T20:46:22Z","pushed_at":"2018-05-29T14:10:12Z","git_url":"git://github.com/mehagar/VireoSDK.git","ssh_url":"git@github.com:mehagar/VireoSDK.git","clone_url":"https://github.com/mehagar/VireoSDK.git","svn_url":"https://github.com/mehagar/VireoSDK","homepage":"http://ni.github.io/VireoSDK/","size":26364,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ni:master","ref":"master","sha":"93cbcbe91aadf3c7c76aa1b2ec2b6e1cd91e982e","user":{"login":"ni","id":5598284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":18154590,"node_id":"MDEwOlJlcG9zaXRvcnkxODE1NDU5MA==","name":"VireoSDK","full_name":"ni/VireoSDK","owner":{"login":"ni","id":5598284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/VireoSDK","description":"Compact runtime for a subset of LabVIEW","fork":false,"url":"https://api.github.com/repos/ni/VireoSDK","forks_url":"https://api.github.com/repos/ni/VireoSDK/forks","keys_url":"https://api.github.com/repos/ni/VireoSDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/VireoSDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/VireoSDK/teams","hooks_url":"https://api.github.com/repos/ni/VireoSDK/hooks","issue_events_url":"https://api.github.com/repos/ni/VireoSDK/issues/events{/number}","events_url":"https://api.github.com/repos/ni/VireoSDK/events","assignees_url":"https://api.github.com/repos/ni/VireoSDK/assignees{/user}","branches_url":"https://api.github.com/repos/ni/VireoSDK/branches{/branch}","tags_url":"https://api.github.com/repos/ni/VireoSDK/tags","blobs_url":"https://api.github.com/repos/ni/VireoSDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/VireoSDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/VireoSDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/VireoSDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/VireoSDK/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/VireoSDK/languages","stargazers_url":"https://api.github.com/repos/ni/VireoSDK/stargazers","contributors_url":"https://api.github.com/repos/ni/VireoSDK/contributors","subscribers_url":"https://api.github.com/repos/ni/VireoSDK/subscribers","subscription_url":"https://api.github.com/repos/ni/VireoSDK/subscription","commits_url":"https://api.github.com/repos/ni/VireoSDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/VireoSDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/VireoSDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/VireoSDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/VireoSDK/contents/{+path}","compare_url":"https://api.github.com/repos/ni/VireoSDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/VireoSDK/merges","archive_url":"https://api.github.com/repos/ni/VireoSDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/VireoSDK/downloads","issues_url":"https://api.github.com/repos/ni/VireoSDK/issues{/number}","pulls_url":"https://api.github.com/repos/ni/VireoSDK/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/VireoSDK/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/VireoSDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/VireoSDK/labels{/name}","releases_url":"https://api.github.com/repos/ni/VireoSDK/releases{/id}","deployments_url":"https://api.github.com/repos/ni/VireoSDK/deployments","created_at":"2014-03-26T21:30:22Z","updated_at":"2018-05-25T19:19:34Z","pushed_at":"2018-05-29T14:10:13Z","git_url":"git://github.com/ni/VireoSDK.git","ssh_url":"git@github.com:ni/VireoSDK.git","clone_url":"https://github.com/ni/VireoSDK.git","svn_url":"https://github.com/ni/VireoSDK","homepage":"http://ni.github.io/VireoSDK/","size":26732,"stargazers_count":30,"watchers_count":30,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":20,"open_issues":41,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/438"},"html":{"href":"https://github.com/ni/VireoSDK/pull/438"},"issue":{"href":"https://api.github.com/repos/ni/VireoSDK/issues/438"},"comments":{"href":"https://api.github.com/repos/ni/VireoSDK/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ni/VireoSDK/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/ni/VireoSDK/statuses/47f1aff040f0820dfff3b7a7fcfb3769cd6186f3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spathiwa"}}