{"action":"created","issue":{"url":"https://api.github.com/repos/SCons/scons/issues/3165","repository_url":"https://api.github.com/repos/SCons/scons","labels_url":"https://api.github.com/repos/SCons/scons/issues/3165/labels{/name}","comments_url":"https://api.github.com/repos/SCons/scons/issues/3165/comments","events_url":"https://api.github.com/repos/SCons/scons/issues/3165/events","html_url":"https://github.com/SCons/scons/pull/3165","id":349184223,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzYwNDcx","number":3165,"title":"Fix the new missing-sconscript test for Windows","user":{"login":"mwichmann","id":1242215,"node_id":"MDQ6VXNlcjEyNDIyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1242215?v=4","gravatar_id":"","url":"https://api.github.com/users/mwichmann","html_url":"https://github.com/mwichmann","followers_url":"https://api.github.com/users/mwichmann/followers","following_url":"https://api.github.com/users/mwichmann/following{/other_user}","gists_url":"https://api.github.com/users/mwichmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mwichmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwichmann/subscriptions","organizations_url":"https://api.github.com/users/mwichmann/orgs","repos_url":"https://api.github.com/users/mwichmann/repos","events_url":"https://api.github.com/users/mwichmann/events{/privacy}","received_events_url":"https://api.github.com/users/mwichmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-09T15:42:18Z","updated_at":"2018-08-10T13:30:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/SCons/scons/pulls/3165","html_url":"https://github.com/SCons/scons/pull/3165","diff_url":"https://github.com/SCons/scons/pull/3165.diff","patch_url":"https://github.com/SCons/scons/pull/3165.patch"},"body":"Missed that string matching on the invalid sconscript\r\npath needs to be OS-agnostic - the CI builders don't\r\ninclude a windows image, so this was not caught.\r\nCall normpath on the path before pushing it into the\r\nexpected strings.\r\n\r\nSigned-off-by: Mats Wichmann <mats@linux.com>\r\n\r\n## Contributor Checklist:\r\n\r\n* [X] I have created a new test or updated the unit tests to cover the new/changed functionality.\r\n* [ ] I have updated `master/src/CHANGES.txt` directory (and read the `README.txt` in that directory)\r\n* [ ] I have updated the appropriate documentation\r\n\r\nUpdating a recently submitted test to fix a problem; nothing to add to docs of CHANGES."},"comment":{"url":"https://api.github.com/repos/SCons/scons/issues/comments/412082753","html_url":"https://github.com/SCons/scons/pull/3165#issuecomment-412082753","issue_url":"https://api.github.com/repos/SCons/scons/issues/3165","id":412082753,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjA4Mjc1Mw==","user":{"login":"mwichmann","id":1242215,"node_id":"MDQ6VXNlcjEyNDIyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1242215?v=4","gravatar_id":"","url":"https://api.github.com/users/mwichmann","html_url":"https://github.com/mwichmann","followers_url":"https://api.github.com/users/mwichmann/followers","following_url":"https://api.github.com/users/mwichmann/following{/other_user}","gists_url":"https://api.github.com/users/mwichmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mwichmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwichmann/subscriptions","organizations_url":"https://api.github.com/users/mwichmann/orgs","repos_url":"https://api.github.com/users/mwichmann/repos","events_url":"https://api.github.com/users/mwichmann/events{/privacy}","received_events_url":"https://api.github.com/users/mwichmann/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T13:30:52Z","updated_at":"2018-08-10T13:30:52Z","author_association":"CONTRIBUTOR","body":"Ah... I was misled by the \"chunking\" those tests do - I looked at one each from Py2.7 and Py3.6, saw they were running only 293 tests and the one I had added was not amongst them and concluded it didn't apply. Now I get how this run divides into pieces.  We can now see this:\r\n\r\n150/294 (51.02%) C:\\\\Python36\\\\python.exe -tt test\\SConscript\\must_exist.py\r\nPASSED\r\n\r\nin, for example, https://ci.appveyor.com/project/SCons/scons/build/3.0.1.199/job/tl0rwrouj04sl4vf\r\n\r\nThis build shows it failing - I'll know to look here in future:\r\nhttps://ci.appveyor.com/project/SCons/scons/build/3.0.1.198/job/39xbh3mo5n7387s2"}}
{"actor":{"display_login":"mwichmann"}}