{"action":"closed","number":184,"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/184","id":198413342,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDEzMzQy","html_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/184","diff_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/184.diff","patch_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/184.patch","issue_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/184","number":184,"state":"closed","locked":false,"title":"Fix handling limit of certificates per ALB","user":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"body":"This fixes a couple of bugs related to exceeding the maximum number of\r\ncertificates per ALB.\r\n\r\nIt limits the max size to 24 instead of 25. This is done because we need\r\nto duplicate the default certificate to work around a CloudFormation bug\r\n(#162) and therefore need one extra space for this limiting the maximum\r\nunique certificates per ALB to 24 instead of the AWS limit of 25.\r\n\r\nIt also fixes a bug in `AddIngress` which could potentially add some of\r\nthe certificates for a single ingress to a stack and the rest to\r\nanother stack resulting in an undesired state.\r\n\r\nThirdly it adds rollback complete states to `IsComplete()` to\r\nautomatically attempt to update stacks that are in a rollback complete\r\nstate.\r\n\r\nLastly it removes some of the getter methods from structs and instead\r\nexports the fields that are needed in other packages. This was done to\r\nmake it easier to use the structs in tests and because we are not\r\nwriting Java.\r\n\r\nAlso switched from glide to dep for vendoring because I can't be dealing with glide at this point :)\r\n\r\nFix #176, #175, #98 ","created_at":"2018-06-29T20:11:28Z","updated_at":"2018-07-09T09:34:30Z","closed_at":"2018-07-09T09:34:29Z","merged_at":"2018-07-09T09:34:29Z","merge_commit_sha":"230c6d9ccbafc8541db6a66e72beb893bd5f548a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":490998466,"node_id":"MDU6TGFiZWw0OTA5OTg0NjY=","url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/184/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/184/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/184/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/dbe80e89b07b7e137b059443484f279d9af557c8","head":{"label":"zalando-incubator:fix-max-certs","ref":"fix-max-certs","sha":"dbe80e89b07b7e137b059443484f279d9af557c8","user":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":75087504,"node_id":"MDEwOlJlcG9zaXRvcnk3NTA4NzUwNA==","name":"kube-ingress-aws-controller","full_name":"zalando-incubator/kube-ingress-aws-controller","owner":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","description":"Configures AWS Load Balancers according to Kubernetes Ingress resources","fork":false,"url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller","forks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/forks","keys_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/events","assignees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/merges","archive_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/deployments","created_at":"2016-11-29T14:10:14Z","updated_at":"2018-07-07T07:36:38Z","pushed_at":"2018-07-09T09:34:29Z","git_url":"git://github.com/zalando-incubator/kube-ingress-aws-controller.git","ssh_url":"git@github.com:zalando-incubator/kube-ingress-aws-controller.git","clone_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller.git","svn_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","homepage":"","size":933,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":17,"watchers":172,"default_branch":"master"}},"base":{"label":"zalando-incubator:master","ref":"master","sha":"cb90c31c032a9a9fe408efc5c2f56d1f8f3e60b8","user":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":75087504,"node_id":"MDEwOlJlcG9zaXRvcnk3NTA4NzUwNA==","name":"kube-ingress-aws-controller","full_name":"zalando-incubator/kube-ingress-aws-controller","owner":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","description":"Configures AWS Load Balancers according to Kubernetes Ingress resources","fork":false,"url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller","forks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/forks","keys_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/events","assignees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/merges","archive_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/deployments","created_at":"2016-11-29T14:10:14Z","updated_at":"2018-07-07T07:36:38Z","pushed_at":"2018-07-09T09:34:29Z","git_url":"git://github.com/zalando-incubator/kube-ingress-aws-controller.git","ssh_url":"git@github.com:zalando-incubator/kube-ingress-aws-controller.git","clone_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller.git","svn_url":"https://github.com/zalando-incubator/kube-ingress-aws-controller","homepage":"","size":933,"stargazers_count":172,"watchers_count":172,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":17,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/184"},"html":{"href":"https://github.com/zalando-incubator/kube-ingress-aws-controller/pull/184"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/184"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/issues/184/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/184/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/pulls/184/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/kube-ingress-aws-controller/statuses/dbe80e89b07b7e137b059443484f279d9af557c8"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"comments":21,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":487,"deletions":341,"changed_files":15}}
{"actor":{"display_login":"mikkeloscar"}}