{"action":"opened","number":912,"pull_request":{"url":"https://api.github.com/repos/centreon/centreon-plugins/pulls/912","id":176187846,"html_url":"https://github.com/centreon/centreon-plugins/pull/912","diff_url":"https://github.com/centreon/centreon-plugins/pull/912.diff","patch_url":"https://github.com/centreon/centreon-plugins/pull/912.patch","issue_url":"https://api.github.com/repos/centreon/centreon-plugins/issues/912","number":912,"state":"open","locked":false,"title":"SNMP: STP: Allow custom topologies","user":{"login":"nailyk-fr","id":16372405,"avatar_url":"https://avatars0.githubusercontent.com/u/16372405?v=4","gravatar_id":"","url":"https://api.github.com/users/nailyk-fr","html_url":"https://github.com/nailyk-fr","followers_url":"https://api.github.com/users/nailyk-fr/followers","following_url":"https://api.github.com/users/nailyk-fr/following{/other_user}","gists_url":"https://api.github.com/users/nailyk-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/nailyk-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nailyk-fr/subscriptions","organizations_url":"https://api.github.com/users/nailyk-fr/orgs","repos_url":"https://api.github.com/users/nailyk-fr/repos","events_url":"https://api.github.com/users/nailyk-fr/events{/privacy}","received_events_url":"https://api.github.com/users/nailyk-fr/received_events","type":"User","site_admin":false},"body":"Those PS will allow custom topologies, as mentioned in #780 \r\n\r\nThis is not perfect as it: \r\n\r\n* Output https://github.com/centreon/centreon-plugins/compare/master...nailyk-fr:master#diff-be436d687f581cbfaf7fa9f480ae2287R222 is not using the new way as it seems the new way cannot handle critical states, \r\n* Guess https://github.com/centreon/centreon-plugins/compare/master...nailyk-fr:master#diff-be436d687f581cbfaf7fa9f480ae2287R221 probably can cause false negative status, but cannot find in what condition, \r\n* As @ldidry suggest to me https://github.com/centreon/centreon-plugins/compare/master...nailyk-fr:master#diff-be436d687f581cbfaf7fa9f480ae2287R193 `(scalar $#stp_overwrite_status)+1` is now replaced with `(scalar @stp_overwrite_status)` as it is more readable, accurate, and do not require the `+1` which can lead in miss-reading the array. (same here https://github.com/centreon/centreon-plugins/compare/master...nailyk-fr:master#diff-be436d687f581cbfaf7fa9f480ae2287R162 but does not really matters)\r\n\r\nThanks :)\r\n\r\nCC: @Sims24 ","created_at":"2018-03-20T13:21:01Z","updated_at":"2018-03-20T13:21:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/centreon/centreon-plugins/pulls/912/commits","review_comments_url":"https://api.github.com/repos/centreon/centreon-plugins/pulls/912/comments","review_comment_url":"https://api.github.com/repos/centreon/centreon-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/centreon/centreon-plugins/issues/912/comments","statuses_url":"https://api.github.com/repos/centreon/centreon-plugins/statuses/c25d750d6d2c2951cf47612b0f51f8990e243ec4","head":{"label":"nailyk-fr:master","ref":"master","sha":"c25d750d6d2c2951cf47612b0f51f8990e243ec4","user":{"login":"nailyk-fr","id":16372405,"avatar_url":"https://avatars0.githubusercontent.com/u/16372405?v=4","gravatar_id":"","url":"https://api.github.com/users/nailyk-fr","html_url":"https://github.com/nailyk-fr","followers_url":"https://api.github.com/users/nailyk-fr/followers","following_url":"https://api.github.com/users/nailyk-fr/following{/other_user}","gists_url":"https://api.github.com/users/nailyk-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/nailyk-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nailyk-fr/subscriptions","organizations_url":"https://api.github.com/users/nailyk-fr/orgs","repos_url":"https://api.github.com/users/nailyk-fr/repos","events_url":"https://api.github.com/users/nailyk-fr/events{/privacy}","received_events_url":"https://api.github.com/users/nailyk-fr/received_events","type":"User","site_admin":false},"repo":{"id":126004533,"name":"centreon-plugins","full_name":"nailyk-fr/centreon-plugins","owner":{"login":"nailyk-fr","id":16372405,"avatar_url":"https://avatars0.githubusercontent.com/u/16372405?v=4","gravatar_id":"","url":"https://api.github.com/users/nailyk-fr","html_url":"https://github.com/nailyk-fr","followers_url":"https://api.github.com/users/nailyk-fr/followers","following_url":"https://api.github.com/users/nailyk-fr/following{/other_user}","gists_url":"https://api.github.com/users/nailyk-fr/gists{/gist_id}","starred_url":"https://api.github.com/users/nailyk-fr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nailyk-fr/subscriptions","organizations_url":"https://api.github.com/users/nailyk-fr/orgs","repos_url":"https://api.github.com/users/nailyk-fr/repos","events_url":"https://api.github.com/users/nailyk-fr/events{/privacy}","received_events_url":"https://api.github.com/users/nailyk-fr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nailyk-fr/centreon-plugins","description":"Collection of plugins for softwares compatible with Nagios plugins","fork":true,"url":"https://api.github.com/repos/nailyk-fr/centreon-plugins","forks_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/forks","keys_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/teams","hooks_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/hooks","issue_events_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/events","assignees_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/tags","blobs_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/languages","stargazers_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/stargazers","contributors_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/contributors","subscribers_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/subscribers","subscription_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/subscription","commits_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/merges","archive_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/downloads","issues_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/labels{/name}","releases_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/nailyk-fr/centreon-plugins/deployments","created_at":"2018-03-20T11:05:05Z","updated_at":"2018-03-20T12:11:32Z","pushed_at":"2018-03-20T12:11:31Z","git_url":"git://github.com/nailyk-fr/centreon-plugins.git","ssh_url":"git@github.com:nailyk-fr/centreon-plugins.git","clone_url":"https://github.com/nailyk-fr/centreon-plugins.git","svn_url":"https://github.com/nailyk-fr/centreon-plugins","homepage":"https://www.centreon.com","size":9607,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"centreon:master","ref":"master","sha":"0508ac678909a973b80a70eaa346cc5d2eb142b0","user":{"login":"centreon","id":1890152,"avatar_url":"https://avatars3.githubusercontent.com/u/1890152?v=4","gravatar_id":"","url":"https://api.github.com/users/centreon","html_url":"https://github.com/centreon","followers_url":"https://api.github.com/users/centreon/followers","following_url":"https://api.github.com/users/centreon/following{/other_user}","gists_url":"https://api.github.com/users/centreon/gists{/gist_id}","starred_url":"https://api.github.com/users/centreon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centreon/subscriptions","organizations_url":"https://api.github.com/users/centreon/orgs","repos_url":"https://api.github.com/users/centreon/repos","events_url":"https://api.github.com/users/centreon/events{/privacy}","received_events_url":"https://api.github.com/users/centreon/received_events","type":"Organization","site_admin":false},"repo":{"id":25678869,"name":"centreon-plugins","full_name":"centreon/centreon-plugins","owner":{"login":"centreon","id":1890152,"avatar_url":"https://avatars3.githubusercontent.com/u/1890152?v=4","gravatar_id":"","url":"https://api.github.com/users/centreon","html_url":"https://github.com/centreon","followers_url":"https://api.github.com/users/centreon/followers","following_url":"https://api.github.com/users/centreon/following{/other_user}","gists_url":"https://api.github.com/users/centreon/gists{/gist_id}","starred_url":"https://api.github.com/users/centreon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/centreon/subscriptions","organizations_url":"https://api.github.com/users/centreon/orgs","repos_url":"https://api.github.com/users/centreon/repos","events_url":"https://api.github.com/users/centreon/events{/privacy}","received_events_url":"https://api.github.com/users/centreon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/centreon/centreon-plugins","description":"Collection of plugins for softwares compatible with Nagios plugins","fork":false,"url":"https://api.github.com/repos/centreon/centreon-plugins","forks_url":"https://api.github.com/repos/centreon/centreon-plugins/forks","keys_url":"https://api.github.com/repos/centreon/centreon-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/centreon/centreon-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/centreon/centreon-plugins/teams","hooks_url":"https://api.github.com/repos/centreon/centreon-plugins/hooks","issue_events_url":"https://api.github.com/repos/centreon/centreon-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/centreon/centreon-plugins/events","assignees_url":"https://api.github.com/repos/centreon/centreon-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/centreon/centreon-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/centreon/centreon-plugins/tags","blobs_url":"https://api.github.com/repos/centreon/centreon-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/centreon/centreon-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/centreon/centreon-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/centreon/centreon-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/centreon/centreon-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/centreon/centreon-plugins/languages","stargazers_url":"https://api.github.com/repos/centreon/centreon-plugins/stargazers","contributors_url":"https://api.github.com/repos/centreon/centreon-plugins/contributors","subscribers_url":"https://api.github.com/repos/centreon/centreon-plugins/subscribers","subscription_url":"https://api.github.com/repos/centreon/centreon-plugins/subscription","commits_url":"https://api.github.com/repos/centreon/centreon-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/centreon/centreon-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/centreon/centreon-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/centreon/centreon-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/centreon/centreon-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/centreon/centreon-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/centreon/centreon-plugins/merges","archive_url":"https://api.github.com/repos/centreon/centreon-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/centreon/centreon-plugins/downloads","issues_url":"https://api.github.com/repos/centreon/centreon-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/centreon/centreon-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/centreon/centreon-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/centreon/centreon-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/centreon/centreon-plugins/labels{/name}","releases_url":"https://api.github.com/repos/centreon/centreon-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/centreon/centreon-plugins/deployments","created_at":"2014-10-24T08:27:44Z","updated_at":"2018-03-17T15:09:43Z","pushed_at":"2018-03-17T15:09:41Z","git_url":"git://github.com/centreon/centreon-plugins.git","ssh_url":"git@github.com:centreon/centreon-plugins.git","clone_url":"https://github.com/centreon/centreon-plugins.git","svn_url":"https://github.com/centreon/centreon-plugins","homepage":"https://www.centreon.com","size":9554,"stargazers_count":114,"watchers_count":114,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":101,"open_issues":102,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/centreon/centreon-plugins/pulls/912"},"html":{"href":"https://github.com/centreon/centreon-plugins/pull/912"},"issue":{"href":"https://api.github.com/repos/centreon/centreon-plugins/issues/912"},"comments":{"href":"https://api.github.com/repos/centreon/centreon-plugins/issues/912/comments"},"review_comments":{"href":"https://api.github.com/repos/centreon/centreon-plugins/pulls/912/comments"},"review_comment":{"href":"https://api.github.com/repos/centreon/centreon-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/centreon/centreon-plugins/pulls/912/commits"},"statuses":{"href":"https://api.github.com/repos/centreon/centreon-plugins/statuses/c25d750d6d2c2951cf47612b0f51f8990e243ec4"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":48,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"nailyk-fr"}}