{"action":"created","comment":{"url":"https://api.github.com/repos/citusdata/citus/pulls/comments/193235227","pull_request_review_id":126168808,"id":193235227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzIzNTIyNw==","diff_hunk":"@@ -997,6 +1026,73 @@ NormalizeWorkerListPath(void)\n }\n \n \n+static bool\n+NodeConninfoGucCheckHook(char **newval, void **extra, GucSource source)\n+{\n+\t/* this array _must_ be kept in an order usable by bsearch */\n+\tconst char *whitelist[] = {\n+\t\t\"application_name\",\n+\t\t\"connect_timeout\",\n+\t\t\t#if defined(ENABLE_GSS) && defined(ENABLE_SSPI)\n+\t\t\"gsslib\",\n+\t\t\t#endif\n+\t\t\"keepalives\",\n+\t\t\"keepalives_count\",\n+\t\t\"keepalives_idle\",\n+\t\t\"keepalives_interval\",\n+\t\t\t#if defined(ENABLE_GSS) || defined(ENABLE_SSPI)\n+\t\t\"krbsrvname\",\n+\t\t\t#endif\n+\t\t\"sslcompression\",\n+\t\t\"sslcrl\",\n+\t\t\"sslmode\",\n+\t\t\"sslrootcert\"\n+\t};\n+\tchar *errmsg = NULL;\n+\tbool conninfoValid = CheckConninfo(*newval, whitelist, lengthof(whitelist), &errmsg);\n+\n+\tif (!conninfoValid)","path":"src/backend/distributed/shared_library_init.c","position":107,"original_position":107,"commit_id":"91584d4afa936cae6cb6375a018fde4232b06ef8","original_commit_id":"91584d4afa936cae6cb6375a018fde4232b06ef8","user":{"login":"jasonmp85","id":50673,"node_id":"MDQ6VXNlcjUwNjcz","avatar_url":"https://avatars3.githubusercontent.com/u/50673?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmp85","html_url":"https://github.com/jasonmp85","followers_url":"https://api.github.com/users/jasonmp85/followers","following_url":"https://api.github.com/users/jasonmp85/following{/other_user}","gists_url":"https://api.github.com/users/jasonmp85/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmp85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmp85/subscriptions","organizations_url":"https://api.github.com/users/jasonmp85/orgs","repos_url":"https://api.github.com/users/jasonmp85/repos","events_url":"https://api.github.com/users/jasonmp85/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmp85/received_events","type":"User","site_admin":false},"body":"Sure, I'll change it.","created_at":"2018-06-05T21:55:49Z","updated_at":"2018-06-05T21:55:50Z","html_url":"https://github.com/citusdata/citus/pull/2190#discussion_r193235227","pull_request_url":"https://api.github.com/repos/citusdata/citus/pulls/2190","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/citusdata/citus/pulls/comments/193235227"},"html":{"href":"https://github.com/citusdata/citus/pull/2190#discussion_r193235227"},"pull_request":{"href":"https://api.github.com/repos/citusdata/citus/pulls/2190"}},"in_reply_to_id":192003040},"pull_request":{"url":"https://api.github.com/repos/citusdata/citus/pulls/2190","id":191031350,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMDMxMzUw","html_url":"https://github.com/citusdata/citus/pull/2190","diff_url":"https://github.com/citusdata/citus/pull/2190.diff","patch_url":"https://github.com/citusdata/citus/pull/2190.patch","issue_url":"https://api.github.com/repos/citusdata/citus/issues/2190","number":2190,"state":"open","locked":false,"title":"Add node_conninfo GUC and related logic","user":{"login":"jasonmp85","id":50673,"node_id":"MDQ6VXNlcjUwNjcz","avatar_url":"https://avatars3.githubusercontent.com/u/50673?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmp85","html_url":"https://github.com/jasonmp85","followers_url":"https://api.github.com/users/jasonmp85/followers","following_url":"https://api.github.com/users/jasonmp85/following{/other_user}","gists_url":"https://api.github.com/users/jasonmp85/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmp85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmp85/subscriptions","organizations_url":"https://api.github.com/users/jasonmp85/orgs","repos_url":"https://api.github.com/users/jasonmp85/repos","events_url":"https://api.github.com/users/jasonmp85/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmp85/received_events","type":"User","site_admin":false},"body":"To support more flexible (i.e. not at compile-time) specification of `libpq` connection parameters, this change adds a new GUC, `node_conninfo`, which must be a space-separated string of key-value pairs suitable for parsing by `libpq`'s connection establishment methods.\n\nTo avoid rebuilding and parsing these values at connection time, this change also adds a cache in front of the configuration params to permit immediate use of any previously-calculated parameters.","created_at":"2018-05-29T04:38:57Z","updated_at":"2018-06-05T21:55:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db1c2630dd01a67ef9d2a065187f4676c91a313a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/citusdata/citus/pulls/2190/commits","review_comments_url":"https://api.github.com/repos/citusdata/citus/pulls/2190/comments","review_comment_url":"https://api.github.com/repos/citusdata/citus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citusdata/citus/issues/2190/comments","statuses_url":"https://api.github.com/repos/citusdata/citus/statuses/91584d4afa936cae6cb6375a018fde4232b06ef8","head":{"label":"citusdata:conninfo_guc","ref":"conninfo_guc","sha":"91584d4afa936cae6cb6375a018fde4232b06ef8","user":{"login":"citusdata","id":2545424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDU0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2545424?v=4","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"repo":{"id":50874442,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3NDQ0Mg==","name":"citus","full_name":"citusdata/citus","owner":{"login":"citusdata","id":2545424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDU0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2545424?v=4","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citusdata/citus","description":"Scalable PostgreSQL for multi-tenant and real-time workloads","fork":false,"url":"https://api.github.com/repos/citusdata/citus","forks_url":"https://api.github.com/repos/citusdata/citus/forks","keys_url":"https://api.github.com/repos/citusdata/citus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citusdata/citus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citusdata/citus/teams","hooks_url":"https://api.github.com/repos/citusdata/citus/hooks","issue_events_url":"https://api.github.com/repos/citusdata/citus/issues/events{/number}","events_url":"https://api.github.com/repos/citusdata/citus/events","assignees_url":"https://api.github.com/repos/citusdata/citus/assignees{/user}","branches_url":"https://api.github.com/repos/citusdata/citus/branches{/branch}","tags_url":"https://api.github.com/repos/citusdata/citus/tags","blobs_url":"https://api.github.com/repos/citusdata/citus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citusdata/citus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citusdata/citus/git/refs{/sha}","trees_url":"https://api.github.com/repos/citusdata/citus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citusdata/citus/statuses/{sha}","languages_url":"https://api.github.com/repos/citusdata/citus/languages","stargazers_url":"https://api.github.com/repos/citusdata/citus/stargazers","contributors_url":"https://api.github.com/repos/citusdata/citus/contributors","subscribers_url":"https://api.github.com/repos/citusdata/citus/subscribers","subscription_url":"https://api.github.com/repos/citusdata/citus/subscription","commits_url":"https://api.github.com/repos/citusdata/citus/commits{/sha}","git_commits_url":"https://api.github.com/repos/citusdata/citus/git/commits{/sha}","comments_url":"https://api.github.com/repos/citusdata/citus/comments{/number}","issue_comment_url":"https://api.github.com/repos/citusdata/citus/issues/comments{/number}","contents_url":"https://api.github.com/repos/citusdata/citus/contents/{+path}","compare_url":"https://api.github.com/repos/citusdata/citus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citusdata/citus/merges","archive_url":"https://api.github.com/repos/citusdata/citus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citusdata/citus/downloads","issues_url":"https://api.github.com/repos/citusdata/citus/issues{/number}","pulls_url":"https://api.github.com/repos/citusdata/citus/pulls{/number}","milestones_url":"https://api.github.com/repos/citusdata/citus/milestones{/number}","notifications_url":"https://api.github.com/repos/citusdata/citus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citusdata/citus/labels{/name}","releases_url":"https://api.github.com/repos/citusdata/citus/releases{/id}","deployments_url":"https://api.github.com/repos/citusdata/citus/deployments","created_at":"2016-02-01T21:58:39Z","updated_at":"2018-06-05T14:39:00Z","pushed_at":"2018-06-05T21:04:36Z","git_url":"git://github.com/citusdata/citus.git","ssh_url":"git@github.com:citusdata/citus.git","clone_url":"https://github.com/citusdata/citus.git","svn_url":"https://github.com/citusdata/citus","homepage":"https://www.citusdata.com","size":10578,"stargazers_count":2731,"watchers_count":2731,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":530,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":195,"open_issues":530,"watchers":2731,"default_branch":"master"}},"base":{"label":"citusdata:master","ref":"master","sha":"b90c54abc0eb1a30eebd1953e42a3ccacfbe48d9","user":{"login":"citusdata","id":2545424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDU0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2545424?v=4","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"repo":{"id":50874442,"node_id":"MDEwOlJlcG9zaXRvcnk1MDg3NDQ0Mg==","name":"citus","full_name":"citusdata/citus","owner":{"login":"citusdata","id":2545424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDU0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2545424?v=4","gravatar_id":"","url":"https://api.github.com/users/citusdata","html_url":"https://github.com/citusdata","followers_url":"https://api.github.com/users/citusdata/followers","following_url":"https://api.github.com/users/citusdata/following{/other_user}","gists_url":"https://api.github.com/users/citusdata/gists{/gist_id}","starred_url":"https://api.github.com/users/citusdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citusdata/subscriptions","organizations_url":"https://api.github.com/users/citusdata/orgs","repos_url":"https://api.github.com/users/citusdata/repos","events_url":"https://api.github.com/users/citusdata/events{/privacy}","received_events_url":"https://api.github.com/users/citusdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citusdata/citus","description":"Scalable PostgreSQL for multi-tenant and real-time workloads","fork":false,"url":"https://api.github.com/repos/citusdata/citus","forks_url":"https://api.github.com/repos/citusdata/citus/forks","keys_url":"https://api.github.com/repos/citusdata/citus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citusdata/citus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citusdata/citus/teams","hooks_url":"https://api.github.com/repos/citusdata/citus/hooks","issue_events_url":"https://api.github.com/repos/citusdata/citus/issues/events{/number}","events_url":"https://api.github.com/repos/citusdata/citus/events","assignees_url":"https://api.github.com/repos/citusdata/citus/assignees{/user}","branches_url":"https://api.github.com/repos/citusdata/citus/branches{/branch}","tags_url":"https://api.github.com/repos/citusdata/citus/tags","blobs_url":"https://api.github.com/repos/citusdata/citus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citusdata/citus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citusdata/citus/git/refs{/sha}","trees_url":"https://api.github.com/repos/citusdata/citus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citusdata/citus/statuses/{sha}","languages_url":"https://api.github.com/repos/citusdata/citus/languages","stargazers_url":"https://api.github.com/repos/citusdata/citus/stargazers","contributors_url":"https://api.github.com/repos/citusdata/citus/contributors","subscribers_url":"https://api.github.com/repos/citusdata/citus/subscribers","subscription_url":"https://api.github.com/repos/citusdata/citus/subscription","commits_url":"https://api.github.com/repos/citusdata/citus/commits{/sha}","git_commits_url":"https://api.github.com/repos/citusdata/citus/git/commits{/sha}","comments_url":"https://api.github.com/repos/citusdata/citus/comments{/number}","issue_comment_url":"https://api.github.com/repos/citusdata/citus/issues/comments{/number}","contents_url":"https://api.github.com/repos/citusdata/citus/contents/{+path}","compare_url":"https://api.github.com/repos/citusdata/citus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citusdata/citus/merges","archive_url":"https://api.github.com/repos/citusdata/citus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citusdata/citus/downloads","issues_url":"https://api.github.com/repos/citusdata/citus/issues{/number}","pulls_url":"https://api.github.com/repos/citusdata/citus/pulls{/number}","milestones_url":"https://api.github.com/repos/citusdata/citus/milestones{/number}","notifications_url":"https://api.github.com/repos/citusdata/citus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citusdata/citus/labels{/name}","releases_url":"https://api.github.com/repos/citusdata/citus/releases{/id}","deployments_url":"https://api.github.com/repos/citusdata/citus/deployments","created_at":"2016-02-01T21:58:39Z","updated_at":"2018-06-05T14:39:00Z","pushed_at":"2018-06-05T21:04:36Z","git_url":"git://github.com/citusdata/citus.git","ssh_url":"git@github.com:citusdata/citus.git","clone_url":"https://github.com/citusdata/citus.git","svn_url":"https://github.com/citusdata/citus","homepage":"https://www.citusdata.com","size":10578,"stargazers_count":2731,"watchers_count":2731,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":530,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":195,"open_issues":530,"watchers":2731,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citusdata/citus/pulls/2190"},"html":{"href":"https://github.com/citusdata/citus/pull/2190"},"issue":{"href":"https://api.github.com/repos/citusdata/citus/issues/2190"},"comments":{"href":"https://api.github.com/repos/citusdata/citus/issues/2190/comments"},"review_comments":{"href":"https://api.github.com/repos/citusdata/citus/pulls/2190/comments"},"review_comment":{"href":"https://api.github.com/repos/citusdata/citus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citusdata/citus/pulls/2190/commits"},"statuses":{"href":"https://api.github.com/repos/citusdata/citus/statuses/91584d4afa936cae6cb6375a018fde4232b06ef8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jasonmp85"}}