{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/232186628","pull_request_review_id":173328066,"id":232186628,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjE4NjYyOA==","diff_hunk":"@@ -99,33 +102,40 @@ def test_with_bounds_threecubes(self):\n         for cube in result:\n             self.assertArrayAlmostEqual(cube.coord('time').bounds, [bounds])\n \n-    @ManageWarnings(record=True)\n-    def test_remove_bounds(self, warning_list=None):\n-        \"\"\"Test that the first input cube has bounds removed and warning is\n-        raised.\"\"\"\n+    def test_with_no_bounds(self):\n+        \"\"\" Test that the bounds are not changed when there are no\n+        bounds.\"\"\"\n+        cubeA = self.cube.copy()\n+        add_forecast_reference_time_and_forecast_period(cubeA)\n+        cubeB = self.cube.copy()\n+        add_forecast_reference_time_and_forecast_period(cubeB)\n+        result = iris.cube.CubeList([cubeA, cubeB])\n+        _equalise_coord_bounds(result)\n+        self.assertTrue(result[0].coord('time').bounds is None)\n+        self.assertTrue(result[1].coord('time').bounds is None)\n+\n+    def test_one_bounds(self):\n+        \"\"\"Test that if there is only 1 set of bounds on the cubes\n+        a warning is raised.\"\"\"\n         cube_with_bounds = self.cube.copy()\n         cube_with_bounds.coord('time').bounds = [0., 1.]\n         result = iris.cube.CubeList([cube_with_bounds, self.cube])\n-        _equalise_coord_bounds(result)\n-        warning_msg = (\"Removing mismatched bounds from cube\")\n-        self.assertTrue(any(warning_msg in str(item)\n-                            for item in warning_list))\n-        for cube in result:\n-            self.assertIsNone(cube.coord('time').bounds)\n+        msg = \"Cubes with mismatching bounds are not compatible\"\n+        with self.assertRaisesRegex(ValueError, msg):\n+            _equalise_coord_bounds(result)\n \n-    @ManageWarnings(record=True)\n-    def test_remove_bounds_threecubes(self, warning_list=None):\n-        \"\"\"Test that the second of three input cube has bounds removed and\n-        warning is raised.\"\"\"\n+    def test_one_bounds_threecubes(self):\n+        \"\"\"Test that when one of the input cubes has no bounds a warning is","path":"lib/improver/tests/utilities/cube_manipulation/test__equalise_coord_bounds.py","position":69,"original_position":69,"commit_id":"ec2bde1a8efe8af4b2701c20969dee1f7f608a1a","original_commit_id":"ec2bde1a8efe8af4b2701c20969dee1f7f608a1a","user":{"login":"MoseleyS","id":23079172,"node_id":"MDQ6VXNlcjIzMDc5MTcy","avatar_url":"https://avatars0.githubusercontent.com/u/23079172?v=4","gravatar_id":"","url":"https://api.github.com/users/MoseleyS","html_url":"https://github.com/MoseleyS","followers_url":"https://api.github.com/users/MoseleyS/followers","following_url":"https://api.github.com/users/MoseleyS/following{/other_user}","gists_url":"https://api.github.com/users/MoseleyS/gists{/gist_id}","starred_url":"https://api.github.com/users/MoseleyS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoseleyS/subscriptions","organizations_url":"https://api.github.com/users/MoseleyS/orgs","repos_url":"https://api.github.com/users/MoseleyS/repos","events_url":"https://api.github.com/users/MoseleyS/events{/privacy}","received_events_url":"https://api.github.com/users/MoseleyS/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n        \"\"\"Test that when one of the input cubes has no bounds an error is\r\n```","created_at":"2018-11-09T09:22:44Z","updated_at":"2018-11-09T09:28:49Z","html_url":"https://github.com/metoppv/improver/pull/724#discussion_r232186628","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/724","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/232186628"},"html":{"href":"https://github.com/metoppv/improver/pull/724#discussion_r232186628"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/724"}}},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/724","id":229090172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MDkwMTcy","html_url":"https://github.com/metoppv/improver/pull/724","diff_url":"https://github.com/metoppv/improver/pull/724.diff","patch_url":"https://github.com/metoppv/improver/pull/724.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/724","number":724,"state":"open","locked":false,"title":"Changes to make sure that time bounds are preserved in the correct way.","user":{"login":"Katie-Howard","id":26744691,"node_id":"MDQ6VXNlcjI2NzQ0Njkx","avatar_url":"https://avatars1.githubusercontent.com/u/26744691?v=4","gravatar_id":"","url":"https://api.github.com/users/Katie-Howard","html_url":"https://github.com/Katie-Howard","followers_url":"https://api.github.com/users/Katie-Howard/followers","following_url":"https://api.github.com/users/Katie-Howard/following{/other_user}","gists_url":"https://api.github.com/users/Katie-Howard/gists{/gist_id}","starred_url":"https://api.github.com/users/Katie-Howard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katie-Howard/subscriptions","organizations_url":"https://api.github.com/users/Katie-Howard/orgs","repos_url":"https://api.github.com/users/Katie-Howard/repos","events_url":"https://api.github.com/users/Katie-Howard/events{/privacy}","received_events_url":"https://api.github.com/users/Katie-Howard/received_events","type":"User","site_admin":false},"body":"Addresses #700 \r\n\r\nTesting:\r\n - [x] Ran tests and they passed OK\r\n - [x] Added new tests for the new feature(s)\r\n\r\nI have looked at cube_manipulation.py and changed the functionality of _equalise_coord_bounds slightly. This was doing most of what we wanted it to do, but if there was a cube which didn't have bounds, and one that did, it would get rid of the bounds. This was a historic fix, which after discussion with Stephen Moseley we realised we didn't need. So this functionality has been taken out.\r\n\r\nThere were unit tests to cover some of the work already, but I have updated and added to the unit tests within test_equalise_coord_bounds. This should run as required. The unit tests now cover these cases (for both the coordinate 'time' and also 'forecast_period':\r\n\r\n- Where the cubes have identical bounds\r\n- Where none of the cubes have bounds\r\n- Where the cubes have mismatched bounds (but still values within the bounds)\r\n- Where there is a cube that doesn't have bounds, and a cube that does\r\n\r\n","created_at":"2018-11-07T16:33:01Z","updated_at":"2018-11-09T09:28:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecd3fd9ef1f51d067b93b7631708741b827cda02","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/724/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/724/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/724/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/ec2bde1a8efe8af4b2701c20969dee1f7f608a1a","head":{"label":"Katie-Howard:IMPRO-955_preserve_bounds","ref":"IMPRO-955_preserve_bounds","sha":"ec2bde1a8efe8af4b2701c20969dee1f7f608a1a","user":{"login":"Katie-Howard","id":26744691,"node_id":"MDQ6VXNlcjI2NzQ0Njkx","avatar_url":"https://avatars1.githubusercontent.com/u/26744691?v=4","gravatar_id":"","url":"https://api.github.com/users/Katie-Howard","html_url":"https://github.com/Katie-Howard","followers_url":"https://api.github.com/users/Katie-Howard/followers","following_url":"https://api.github.com/users/Katie-Howard/following{/other_user}","gists_url":"https://api.github.com/users/Katie-Howard/gists{/gist_id}","starred_url":"https://api.github.com/users/Katie-Howard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katie-Howard/subscriptions","organizations_url":"https://api.github.com/users/Katie-Howard/orgs","repos_url":"https://api.github.com/users/Katie-Howard/repos","events_url":"https://api.github.com/users/Katie-Howard/events{/privacy}","received_events_url":"https://api.github.com/users/Katie-Howard/received_events","type":"User","site_admin":false},"repo":{"id":95010879,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAxMDg3OQ==","name":"improver","full_name":"Katie-Howard/improver","private":false,"owner":{"login":"Katie-Howard","id":26744691,"node_id":"MDQ6VXNlcjI2NzQ0Njkx","avatar_url":"https://avatars1.githubusercontent.com/u/26744691?v=4","gravatar_id":"","url":"https://api.github.com/users/Katie-Howard","html_url":"https://github.com/Katie-Howard","followers_url":"https://api.github.com/users/Katie-Howard/followers","following_url":"https://api.github.com/users/Katie-Howard/following{/other_user}","gists_url":"https://api.github.com/users/Katie-Howard/gists{/gist_id}","starred_url":"https://api.github.com/users/Katie-Howard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Katie-Howard/subscriptions","organizations_url":"https://api.github.com/users/Katie-Howard/orgs","repos_url":"https://api.github.com/users/Katie-Howard/repos","events_url":"https://api.github.com/users/Katie-Howard/events{/privacy}","received_events_url":"https://api.github.com/users/Katie-Howard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Katie-Howard/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":true,"url":"https://api.github.com/repos/Katie-Howard/improver","forks_url":"https://api.github.com/repos/Katie-Howard/improver/forks","keys_url":"https://api.github.com/repos/Katie-Howard/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Katie-Howard/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Katie-Howard/improver/teams","hooks_url":"https://api.github.com/repos/Katie-Howard/improver/hooks","issue_events_url":"https://api.github.com/repos/Katie-Howard/improver/issues/events{/number}","events_url":"https://api.github.com/repos/Katie-Howard/improver/events","assignees_url":"https://api.github.com/repos/Katie-Howard/improver/assignees{/user}","branches_url":"https://api.github.com/repos/Katie-Howard/improver/branches{/branch}","tags_url":"https://api.github.com/repos/Katie-Howard/improver/tags","blobs_url":"https://api.github.com/repos/Katie-Howard/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Katie-Howard/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Katie-Howard/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/Katie-Howard/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Katie-Howard/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/Katie-Howard/improver/languages","stargazers_url":"https://api.github.com/repos/Katie-Howard/improver/stargazers","contributors_url":"https://api.github.com/repos/Katie-Howard/improver/contributors","subscribers_url":"https://api.github.com/repos/Katie-Howard/improver/subscribers","subscription_url":"https://api.github.com/repos/Katie-Howard/improver/subscription","commits_url":"https://api.github.com/repos/Katie-Howard/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/Katie-Howard/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/Katie-Howard/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/Katie-Howard/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/Katie-Howard/improver/contents/{+path}","compare_url":"https://api.github.com/repos/Katie-Howard/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Katie-Howard/improver/merges","archive_url":"https://api.github.com/repos/Katie-Howard/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Katie-Howard/improver/downloads","issues_url":"https://api.github.com/repos/Katie-Howard/improver/issues{/number}","pulls_url":"https://api.github.com/repos/Katie-Howard/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/Katie-Howard/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/Katie-Howard/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Katie-Howard/improver/labels{/name}","releases_url":"https://api.github.com/repos/Katie-Howard/improver/releases{/id}","deployments_url":"https://api.github.com/repos/Katie-Howard/improver/deployments","created_at":"2017-06-21T14:07:19Z","updated_at":"2017-06-21T14:07:21Z","pushed_at":"2018-11-07T16:26:46Z","git_url":"git://github.com/Katie-Howard/improver.git","ssh_url":"git@github.com:Katie-Howard/improver.git","clone_url":"https://github.com/Katie-Howard/improver.git","svn_url":"https://github.com/Katie-Howard/improver","homepage":"","size":4034,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"4d58b6db6f213094d87d4f3dc2260af146f47ce6","user":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"node_id":"MDEwOlJlcG9zaXRvcnk4NTMzNDc2MQ==","name":"improver","full_name":"metoppv/improver","private":false,"owner":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-11-08T13:38:40Z","pushed_at":"2018-11-09T07:28:08Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":4056,"stargazers_count":20,"watchers_count":20,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":90,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":29,"open_issues":90,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/724"},"html":{"href":"https://github.com/metoppv/improver/pull/724"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/724"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/724/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/724/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/724/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/ec2bde1a8efe8af4b2701c20969dee1f7f608a1a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MoseleyS"}}