{"action":"created","issue":{"url":"https://api.github.com/repos/OpenAADL/fmu2aadl/issues/1","repository_url":"https://api.github.com/repos/OpenAADL/fmu2aadl","labels_url":"https://api.github.com/repos/OpenAADL/fmu2aadl/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/OpenAADL/fmu2aadl/issues/1/comments","events_url":"https://api.github.com/repos/OpenAADL/fmu2aadl/issues/1/events","html_url":"https://github.com/OpenAADL/fmu2aadl/issues/1","id":345662859,"node_id":"MDU6SXNzdWUzNDU2NjI4NTk=","number":1,"title":"Variable names in generated AADL files","user":{"login":"svenTeum","id":20702694,"node_id":"MDQ6VXNlcjIwNzAyNjk0","avatar_url":"https://avatars1.githubusercontent.com/u/20702694?v=4","gravatar_id":"","url":"https://api.github.com/users/svenTeum","html_url":"https://github.com/svenTeum","followers_url":"https://api.github.com/users/svenTeum/followers","following_url":"https://api.github.com/users/svenTeum/following{/other_user}","gists_url":"https://api.github.com/users/svenTeum/gists{/gist_id}","starred_url":"https://api.github.com/users/svenTeum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenTeum/subscriptions","organizations_url":"https://api.github.com/users/svenTeum/orgs","repos_url":"https://api.github.com/users/svenTeum/repos","events_url":"https://api.github.com/users/svenTeum/events{/privacy}","received_events_url":"https://api.github.com/users/svenTeum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-30T08:39:11Z","updated_at":"2018-07-30T09:01:15Z","closed_at":null,"author_association":"NONE","body":"I'm using some FMUs generated by Amesim tool. When running fmu2aadl, I get the corresponding AADL files.\r\nThe problem is that the FMUs have input/output names that contain some special characters, like for example:\r\n_pin@expseu__\r\nIn that way, I must manually edit the variable names in fmu_name.aadl and fmu_name_wrapper.c to something like\r\n_pinexpseu_\r\n(otherwise Ocarina won't compile the model using those FMUs)\r\n\r\nBecause of that manually editing, I'm not sure if some other errors I get are related to that.\r\n\r\nCould it be possible for _fmu2aadl_ to parse that kind of variable names?\r\n"},"comment":{"url":"https://api.github.com/repos/OpenAADL/fmu2aadl/issues/comments/408795977","html_url":"https://github.com/OpenAADL/fmu2aadl/issues/1#issuecomment-408795977","issue_url":"https://api.github.com/repos/OpenAADL/fmu2aadl/issues/1","id":408795977,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODc5NTk3Nw==","user":{"login":"svenTeum","id":20702694,"node_id":"MDQ6VXNlcjIwNzAyNjk0","avatar_url":"https://avatars1.githubusercontent.com/u/20702694?v=4","gravatar_id":"","url":"https://api.github.com/users/svenTeum","html_url":"https://github.com/svenTeum","followers_url":"https://api.github.com/users/svenTeum/followers","following_url":"https://api.github.com/users/svenTeum/following{/other_user}","gists_url":"https://api.github.com/users/svenTeum/gists{/gist_id}","starred_url":"https://api.github.com/users/svenTeum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenTeum/subscriptions","organizations_url":"https://api.github.com/users/svenTeum/orgs","repos_url":"https://api.github.com/users/svenTeum/repos","events_url":"https://api.github.com/users/svenTeum/events{/privacy}","received_events_url":"https://api.github.com/users/svenTeum/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T09:01:15Z","updated_at":"2018-07-30T09:01:15Z","author_association":"NONE","body":"Thanks, I will see if I can send you an FMU from Amesim (BTW how can I send you a file?)\r\nIn my case I had to replace only those two characters.\r\n\r\nAnother issue with Amesim FMUs is that they generate a specific label in ModelDescription.xml that is not parsed well when running Ocarina so I also have to edit the xml file as a previous step to building with Ocarina. But maybe I should open a different issue for that."}}
{"actor":{"display_login":"svenTeum"}}