{"action":"closed","number":24076,"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/24076","id":185388094,"html_url":"https://github.com/laravel/framework/pull/24076","diff_url":"https://github.com/laravel/framework/pull/24076.diff","patch_url":"https://github.com/laravel/framework/pull/24076.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/24076","number":24076,"state":"closed","locked":false,"title":"[5.5] Fix unsetting http query parameters when fetching request by HEAD","user":{"login":"lynn80827","id":7734247,"avatar_url":"https://avatars1.githubusercontent.com/u/7734247?v=4","gravatar_id":"","url":"https://api.github.com/users/lynn80827","html_url":"https://github.com/lynn80827","followers_url":"https://api.github.com/users/lynn80827/followers","following_url":"https://api.github.com/users/lynn80827/following{/other_user}","gists_url":"https://api.github.com/users/lynn80827/gists{/gist_id}","starred_url":"https://api.github.com/users/lynn80827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynn80827/subscriptions","organizations_url":"https://api.github.com/users/lynn80827/orgs","repos_url":"https://api.github.com/users/lynn80827/repos","events_url":"https://api.github.com/users/lynn80827/events{/privacy}","received_events_url":"https://api.github.com/users/lynn80827/received_events","type":"User","site_admin":false},"body":"When I used `$request->offsetUnset()` to remove query parameters from request, http method **GET** succeed but **HEAD** failed. It was because that **HEAD** was trying to remove parameters from `$_POST` instead of `$_GET`.\r\n\r\nAdd a test case for the modification and fix some coding styles.","created_at":"2018-05-02T09:53:06Z","updated_at":"2018-05-02T14:49:14Z","closed_at":"2018-05-02T14:49:14Z","merged_at":"2018-05-02T14:49:14Z","merge_commit_sha":"ac963a0dc8bc0e06591ee704cf279f2bff3d66ce","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/24076/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/24076/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/24076/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/7a8b256397c62ad04537ceb06ab1208908b69a46","head":{"label":"lynn80827:fix/http-request-head","ref":"fix/http-request-head","sha":"7a8b256397c62ad04537ceb06ab1208908b69a46","user":{"login":"lynn80827","id":7734247,"avatar_url":"https://avatars1.githubusercontent.com/u/7734247?v=4","gravatar_id":"","url":"https://api.github.com/users/lynn80827","html_url":"https://github.com/lynn80827","followers_url":"https://api.github.com/users/lynn80827/followers","following_url":"https://api.github.com/users/lynn80827/following{/other_user}","gists_url":"https://api.github.com/users/lynn80827/gists{/gist_id}","starred_url":"https://api.github.com/users/lynn80827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynn80827/subscriptions","organizations_url":"https://api.github.com/users/lynn80827/orgs","repos_url":"https://api.github.com/users/lynn80827/repos","events_url":"https://api.github.com/users/lynn80827/events{/privacy}","received_events_url":"https://api.github.com/users/lynn80827/received_events","type":"User","site_admin":false},"repo":{"id":90598035,"name":"framework","full_name":"lynn80827/framework","owner":{"login":"lynn80827","id":7734247,"avatar_url":"https://avatars1.githubusercontent.com/u/7734247?v=4","gravatar_id":"","url":"https://api.github.com/users/lynn80827","html_url":"https://github.com/lynn80827","followers_url":"https://api.github.com/users/lynn80827/followers","following_url":"https://api.github.com/users/lynn80827/following{/other_user}","gists_url":"https://api.github.com/users/lynn80827/gists{/gist_id}","starred_url":"https://api.github.com/users/lynn80827/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lynn80827/subscriptions","organizations_url":"https://api.github.com/users/lynn80827/orgs","repos_url":"https://api.github.com/users/lynn80827/repos","events_url":"https://api.github.com/users/lynn80827/events{/privacy}","received_events_url":"https://api.github.com/users/lynn80827/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lynn80827/framework","description":null,"fork":true,"url":"https://api.github.com/repos/lynn80827/framework","forks_url":"https://api.github.com/repos/lynn80827/framework/forks","keys_url":"https://api.github.com/repos/lynn80827/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lynn80827/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lynn80827/framework/teams","hooks_url":"https://api.github.com/repos/lynn80827/framework/hooks","issue_events_url":"https://api.github.com/repos/lynn80827/framework/issues/events{/number}","events_url":"https://api.github.com/repos/lynn80827/framework/events","assignees_url":"https://api.github.com/repos/lynn80827/framework/assignees{/user}","branches_url":"https://api.github.com/repos/lynn80827/framework/branches{/branch}","tags_url":"https://api.github.com/repos/lynn80827/framework/tags","blobs_url":"https://api.github.com/repos/lynn80827/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lynn80827/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lynn80827/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lynn80827/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lynn80827/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lynn80827/framework/languages","stargazers_url":"https://api.github.com/repos/lynn80827/framework/stargazers","contributors_url":"https://api.github.com/repos/lynn80827/framework/contributors","subscribers_url":"https://api.github.com/repos/lynn80827/framework/subscribers","subscription_url":"https://api.github.com/repos/lynn80827/framework/subscription","commits_url":"https://api.github.com/repos/lynn80827/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lynn80827/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lynn80827/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lynn80827/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/lynn80827/framework/contents/{+path}","compare_url":"https://api.github.com/repos/lynn80827/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lynn80827/framework/merges","archive_url":"https://api.github.com/repos/lynn80827/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lynn80827/framework/downloads","issues_url":"https://api.github.com/repos/lynn80827/framework/issues{/number}","pulls_url":"https://api.github.com/repos/lynn80827/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lynn80827/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lynn80827/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lynn80827/framework/labels{/name}","releases_url":"https://api.github.com/repos/lynn80827/framework/releases{/id}","deployments_url":"https://api.github.com/repos/lynn80827/framework/deployments","created_at":"2017-05-08T07:19:14Z","updated_at":"2017-05-08T07:19:23Z","pushed_at":"2018-05-02T09:55:51Z","git_url":"git://github.com/lynn80827/framework.git","ssh_url":"git@github.com:lynn80827/framework.git","clone_url":"https://github.com/lynn80827/framework.git","svn_url":"https://github.com/lynn80827/framework","homepage":"http://laravel.com","size":31918,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.4"}},"base":{"label":"laravel:5.5","ref":"5.5","sha":"84abd78cb2cb254761a110e0c244515eb08cd201","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/framework/deployments","created_at":"2013-01-10T21:27:28Z","updated_at":"2018-05-02T14:48:14Z","pushed_at":"2018-05-02T14:49:14Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":33370,"stargazers_count":12048,"watchers_count":12048,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5366,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5366,"open_issues":169,"watchers":12048,"default_branch":"5.6"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/24076"},"html":{"href":"https://github.com/laravel/framework/pull/24076"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/24076"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/24076/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/24076/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/24076/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/7a8b256397c62ad04537ceb06ab1208908b69a46"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars3.githubusercontent.com/u/463230?v=4","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":18,"deletions":5,"changed_files":2}}
{"actor":{"display_login":"taylorotwell"}}