{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18411","repository_url":"https://api.github.com/repos/tensorflow/tensorflow","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18411/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18411/comments","events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18411/events","html_url":"https://github.com/tensorflow/tensorflow/pull/18411","id":313146576,"number":18411,"title":"[INTEL MKL] AVX512 Fix for Eigen Vectorized sqrt/rsqrt Function","user":{"login":"mdfaijul","id":27521767,"avatar_url":"https://avatars3.githubusercontent.com/u/27521767?v=4","gravatar_id":"","url":"https://api.github.com/users/mdfaijul","html_url":"https://github.com/mdfaijul","followers_url":"https://api.github.com/users/mdfaijul/followers","following_url":"https://api.github.com/users/mdfaijul/following{/other_user}","gists_url":"https://api.github.com/users/mdfaijul/gists{/gist_id}","starred_url":"https://api.github.com/users/mdfaijul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdfaijul/subscriptions","organizations_url":"https://api.github.com/users/mdfaijul/orgs","repos_url":"https://api.github.com/users/mdfaijul/repos","events_url":"https://api.github.com/users/mdfaijul/events{/privacy}","received_events_url":"https://api.github.com/users/mdfaijul/received_events","type":"User","site_admin":false},"labels":[{"id":300136587,"url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"jhseu","id":170179,"avatar_url":"https://avatars1.githubusercontent.com/u/170179?v=4","gravatar_id":"","url":"https://api.github.com/users/jhseu","html_url":"https://github.com/jhseu","followers_url":"https://api.github.com/users/jhseu/followers","following_url":"https://api.github.com/users/jhseu/following{/other_user}","gists_url":"https://api.github.com/users/jhseu/gists{/gist_id}","starred_url":"https://api.github.com/users/jhseu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhseu/subscriptions","organizations_url":"https://api.github.com/users/jhseu/orgs","repos_url":"https://api.github.com/users/jhseu/repos","events_url":"https://api.github.com/users/jhseu/events{/privacy}","received_events_url":"https://api.github.com/users/jhseu/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhseu","id":170179,"avatar_url":"https://avatars1.githubusercontent.com/u/170179?v=4","gravatar_id":"","url":"https://api.github.com/users/jhseu","html_url":"https://github.com/jhseu","followers_url":"https://api.github.com/users/jhseu/followers","following_url":"https://api.github.com/users/jhseu/following{/other_user}","gists_url":"https://api.github.com/users/jhseu/gists{/gist_id}","starred_url":"https://api.github.com/users/jhseu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhseu/subscriptions","organizations_url":"https://api.github.com/users/jhseu/orgs","repos_url":"https://api.github.com/users/jhseu/repos","events_url":"https://api.github.com/users/jhseu/events{/privacy}","received_events_url":"https://api.github.com/users/jhseu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-04-11T01:54:52Z","updated_at":"2018-05-03T19:27:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/18411","html_url":"https://github.com/tensorflow/tensorflow/pull/18411","diff_url":"https://github.com/tensorflow/tensorflow/pull/18411.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/18411.patch"},"body":"This PR has two modifications:\r\n1. Downloads latest Eigen library that has AVX512 fix for vectorized sqrt/rqrt functions.\r\n\r\n2. Added a new unit-test python script [tensorflow/python/kernel_tests/sgd_optimizers_test.py] that tests several SGD optimizers calling sqrt/rsqrt function. The test fails with older Eigen library [https://bitbucket.org/eigen/eigen/get/6913f0cf7d06.tar.gz], but passes with new downloads.\r\n\r\n3. In order to check, use the following commands\r\n`bazel test --config=mkl --copt=\"-mfma\" --copt=\"-march=native\" -c opt //tensorflow/python/kernel_tests:sgd_optimizers_test\r\n`\r\n`bazel test --copt=\"-mfma\" --copt=\"-march=native\" -c opt //tensorflow/python/kernel_tests:sgd_optimizers_test`\r\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments/386409382","html_url":"https://github.com/tensorflow/tensorflow/pull/18411#issuecomment-386409382","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/18411","id":386409382,"user":{"login":"mdfaijul","id":27521767,"avatar_url":"https://avatars3.githubusercontent.com/u/27521767?v=4","gravatar_id":"","url":"https://api.github.com/users/mdfaijul","html_url":"https://github.com/mdfaijul","followers_url":"https://api.github.com/users/mdfaijul/followers","following_url":"https://api.github.com/users/mdfaijul/following{/other_user}","gists_url":"https://api.github.com/users/mdfaijul/gists{/gist_id}","starred_url":"https://api.github.com/users/mdfaijul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdfaijul/subscriptions","organizations_url":"https://api.github.com/users/mdfaijul/orgs","repos_url":"https://api.github.com/users/mdfaijul/repos","events_url":"https://api.github.com/users/mdfaijul/events{/privacy}","received_events_url":"https://api.github.com/users/mdfaijul/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T19:27:43Z","updated_at":"2018-05-03T19:27:43Z","author_association":"CONTRIBUTOR","body":"@jhseu I see there is one failure: keras integration test. Will look into this."}}
{"actor":{"display_login":"mdfaijul"}}