{"action":"created","comment":{"url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments/211630315","pull_request_review_id":148091679,"id":211630315,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTYzMDMxNQ==","diff_hunk":"@@ -133,6 +145,13 @@ def import_(module):\n except ImportError:\n     has_openbabel = False\n \n+try:\n+    import foyer\n+    has_foyer = True\n+    del foyer\n+except ImportError:\n+    has_foyer = False\n+","path":"mbuild/utils/io.py","position":29,"original_position":29,"commit_id":"8109379a22d2f469b9a4c59d3da51f7103cbb0a6","original_commit_id":"8109379a22d2f469b9a4c59d3da51f7103cbb0a6","user":{"login":"mattwthompson","id":7935382,"node_id":"MDQ6VXNlcjc5MzUzODI=","avatar_url":"https://avatars3.githubusercontent.com/u/7935382?v=4","gravatar_id":"","url":"https://api.github.com/users/mattwthompson","html_url":"https://github.com/mattwthompson","followers_url":"https://api.github.com/users/mattwthompson/followers","following_url":"https://api.github.com/users/mattwthompson/following{/other_user}","gists_url":"https://api.github.com/users/mattwthompson/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwthompson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwthompson/subscriptions","organizations_url":"https://api.github.com/users/mattwthompson/orgs","repos_url":"https://api.github.com/users/mattwthompson/repos","events_url":"https://api.github.com/users/mattwthompson/events{/privacy}","received_events_url":"https://api.github.com/users/mattwthompson/received_events","type":"User","site_admin":false},"body":"Just curious - why are these `try` blocks not indented?","created_at":"2018-08-21T14:36:32Z","updated_at":"2018-08-21T14:36:33Z","html_url":"https://github.com/mosdef-hub/mbuild/pull/457#discussion_r211630315","pull_request_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments/211630315"},"html":{"href":"https://github.com/mosdef-hub/mbuild/pull/457#discussion_r211630315"},"pull_request":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457"}}},"pull_request":{"url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457","id":209845738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5ODQ1NzM4","html_url":"https://github.com/mosdef-hub/mbuild/pull/457","diff_url":"https://github.com/mosdef-hub/mbuild/pull/457.diff","patch_url":"https://github.com/mosdef-hub/mbuild/pull/457.patch","issue_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/457","number":457,"state":"open","locked":false,"title":"Update dependency requirements","user":{"login":"summeraz","id":5833414,"node_id":"MDQ6VXNlcjU4MzM0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5833414?v=4","gravatar_id":"","url":"https://api.github.com/users/summeraz","html_url":"https://github.com/summeraz","followers_url":"https://api.github.com/users/summeraz/followers","following_url":"https://api.github.com/users/summeraz/following{/other_user}","gists_url":"https://api.github.com/users/summeraz/gists{/gist_id}","starred_url":"https://api.github.com/users/summeraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summeraz/subscriptions","organizations_url":"https://api.github.com/users/summeraz/orgs","repos_url":"https://api.github.com/users/summeraz/repos","events_url":"https://api.github.com/users/summeraz/events{/privacy}","received_events_url":"https://api.github.com/users/summeraz/received_events","type":"User","site_admin":false},"body":"We've had issues with a dependency loop due to `mbuild` and `foyer` both having each other as a required dependency. To fix this, and to make MoSDeF more modular, this PR separates `foyer` out as an optional dependency, though still required for development and testing.\r\n\r\nTo specify that `foyer` is required for testing, this PR also separates out from our `requirements.txt` file a `requirements-dev.txt` file that lists all packages required for development and testing of `mbuild`. `requirements.txt` now contains only the subset of packages that are required to actually use `mbuild`.","created_at":"2018-08-21T14:27:58Z","updated_at":"2018-08-21T14:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0edecc087516d656bd7b6fe30550c66470b60696","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457/commits","review_comments_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457/comments","review_comment_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/457/comments","statuses_url":"https://api.github.com/repos/mosdef-hub/mbuild/statuses/8109379a22d2f469b9a4c59d3da51f7103cbb0a6","head":{"label":"summeraz:foyer-dep","ref":"foyer-dep","sha":"8109379a22d2f469b9a4c59d3da51f7103cbb0a6","user":{"login":"summeraz","id":5833414,"node_id":"MDQ6VXNlcjU4MzM0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5833414?v=4","gravatar_id":"","url":"https://api.github.com/users/summeraz","html_url":"https://github.com/summeraz","followers_url":"https://api.github.com/users/summeraz/followers","following_url":"https://api.github.com/users/summeraz/following{/other_user}","gists_url":"https://api.github.com/users/summeraz/gists{/gist_id}","starred_url":"https://api.github.com/users/summeraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summeraz/subscriptions","organizations_url":"https://api.github.com/users/summeraz/orgs","repos_url":"https://api.github.com/users/summeraz/repos","events_url":"https://api.github.com/users/summeraz/events{/privacy}","received_events_url":"https://api.github.com/users/summeraz/received_events","type":"User","site_admin":false},"repo":{"id":64950178,"node_id":"MDEwOlJlcG9zaXRvcnk2NDk1MDE3OA==","name":"mbuild","full_name":"summeraz/mbuild","owner":{"login":"summeraz","id":5833414,"node_id":"MDQ6VXNlcjU4MzM0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5833414?v=4","gravatar_id":"","url":"https://api.github.com/users/summeraz","html_url":"https://github.com/summeraz","followers_url":"https://api.github.com/users/summeraz/followers","following_url":"https://api.github.com/users/summeraz/following{/other_user}","gists_url":"https://api.github.com/users/summeraz/gists{/gist_id}","starred_url":"https://api.github.com/users/summeraz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/summeraz/subscriptions","organizations_url":"https://api.github.com/users/summeraz/orgs","repos_url":"https://api.github.com/users/summeraz/repos","events_url":"https://api.github.com/users/summeraz/events{/privacy}","received_events_url":"https://api.github.com/users/summeraz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/summeraz/mbuild","description":"mBuild is a hierarchical, component based molecule builder","fork":true,"url":"https://api.github.com/repos/summeraz/mbuild","forks_url":"https://api.github.com/repos/summeraz/mbuild/forks","keys_url":"https://api.github.com/repos/summeraz/mbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/summeraz/mbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/summeraz/mbuild/teams","hooks_url":"https://api.github.com/repos/summeraz/mbuild/hooks","issue_events_url":"https://api.github.com/repos/summeraz/mbuild/issues/events{/number}","events_url":"https://api.github.com/repos/summeraz/mbuild/events","assignees_url":"https://api.github.com/repos/summeraz/mbuild/assignees{/user}","branches_url":"https://api.github.com/repos/summeraz/mbuild/branches{/branch}","tags_url":"https://api.github.com/repos/summeraz/mbuild/tags","blobs_url":"https://api.github.com/repos/summeraz/mbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/summeraz/mbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/summeraz/mbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/summeraz/mbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/summeraz/mbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/summeraz/mbuild/languages","stargazers_url":"https://api.github.com/repos/summeraz/mbuild/stargazers","contributors_url":"https://api.github.com/repos/summeraz/mbuild/contributors","subscribers_url":"https://api.github.com/repos/summeraz/mbuild/subscribers","subscription_url":"https://api.github.com/repos/summeraz/mbuild/subscription","commits_url":"https://api.github.com/repos/summeraz/mbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/summeraz/mbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/summeraz/mbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/summeraz/mbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/summeraz/mbuild/contents/{+path}","compare_url":"https://api.github.com/repos/summeraz/mbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/summeraz/mbuild/merges","archive_url":"https://api.github.com/repos/summeraz/mbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/summeraz/mbuild/downloads","issues_url":"https://api.github.com/repos/summeraz/mbuild/issues{/number}","pulls_url":"https://api.github.com/repos/summeraz/mbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/summeraz/mbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/summeraz/mbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/summeraz/mbuild/labels{/name}","releases_url":"https://api.github.com/repos/summeraz/mbuild/releases{/id}","deployments_url":"https://api.github.com/repos/summeraz/mbuild/deployments","created_at":"2016-08-04T16:26:51Z","updated_at":"2018-06-21T20:46:28Z","pushed_at":"2018-08-21T14:23:02Z","git_url":"git://github.com/summeraz/mbuild.git","ssh_url":"git@github.com:summeraz/mbuild.git","clone_url":"https://github.com/summeraz/mbuild.git","svn_url":"https://github.com/summeraz/mbuild","homepage":"http://imodels.github.io/mbuild/","size":72139,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mosdef-hub:master","ref":"master","sha":"0f9cd29239fde41b8162b483b4556a258f877bcb","user":{"login":"mosdef-hub","id":25673981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjczOTgx","avatar_url":"https://avatars2.githubusercontent.com/u/25673981?v=4","gravatar_id":"","url":"https://api.github.com/users/mosdef-hub","html_url":"https://github.com/mosdef-hub","followers_url":"https://api.github.com/users/mosdef-hub/followers","following_url":"https://api.github.com/users/mosdef-hub/following{/other_user}","gists_url":"https://api.github.com/users/mosdef-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/mosdef-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosdef-hub/subscriptions","organizations_url":"https://api.github.com/users/mosdef-hub/orgs","repos_url":"https://api.github.com/users/mosdef-hub/repos","events_url":"https://api.github.com/users/mosdef-hub/events{/privacy}","received_events_url":"https://api.github.com/users/mosdef-hub/received_events","type":"Organization","site_admin":false},"repo":{"id":13804874,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgwNDg3NA==","name":"mbuild","full_name":"mosdef-hub/mbuild","owner":{"login":"mosdef-hub","id":25673981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NjczOTgx","avatar_url":"https://avatars2.githubusercontent.com/u/25673981?v=4","gravatar_id":"","url":"https://api.github.com/users/mosdef-hub","html_url":"https://github.com/mosdef-hub","followers_url":"https://api.github.com/users/mosdef-hub/followers","following_url":"https://api.github.com/users/mosdef-hub/following{/other_user}","gists_url":"https://api.github.com/users/mosdef-hub/gists{/gist_id}","starred_url":"https://api.github.com/users/mosdef-hub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mosdef-hub/subscriptions","organizations_url":"https://api.github.com/users/mosdef-hub/orgs","repos_url":"https://api.github.com/users/mosdef-hub/repos","events_url":"https://api.github.com/users/mosdef-hub/events{/privacy}","received_events_url":"https://api.github.com/users/mosdef-hub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mosdef-hub/mbuild","description":"A hierarchical, component based molecule builder","fork":false,"url":"https://api.github.com/repos/mosdef-hub/mbuild","forks_url":"https://api.github.com/repos/mosdef-hub/mbuild/forks","keys_url":"https://api.github.com/repos/mosdef-hub/mbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mosdef-hub/mbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mosdef-hub/mbuild/teams","hooks_url":"https://api.github.com/repos/mosdef-hub/mbuild/hooks","issue_events_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/events{/number}","events_url":"https://api.github.com/repos/mosdef-hub/mbuild/events","assignees_url":"https://api.github.com/repos/mosdef-hub/mbuild/assignees{/user}","branches_url":"https://api.github.com/repos/mosdef-hub/mbuild/branches{/branch}","tags_url":"https://api.github.com/repos/mosdef-hub/mbuild/tags","blobs_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mosdef-hub/mbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/mosdef-hub/mbuild/languages","stargazers_url":"https://api.github.com/repos/mosdef-hub/mbuild/stargazers","contributors_url":"https://api.github.com/repos/mosdef-hub/mbuild/contributors","subscribers_url":"https://api.github.com/repos/mosdef-hub/mbuild/subscribers","subscription_url":"https://api.github.com/repos/mosdef-hub/mbuild/subscription","commits_url":"https://api.github.com/repos/mosdef-hub/mbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/mosdef-hub/mbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/mosdef-hub/mbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/mosdef-hub/mbuild/contents/{+path}","compare_url":"https://api.github.com/repos/mosdef-hub/mbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mosdef-hub/mbuild/merges","archive_url":"https://api.github.com/repos/mosdef-hub/mbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mosdef-hub/mbuild/downloads","issues_url":"https://api.github.com/repos/mosdef-hub/mbuild/issues{/number}","pulls_url":"https://api.github.com/repos/mosdef-hub/mbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/mosdef-hub/mbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/mosdef-hub/mbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mosdef-hub/mbuild/labels{/name}","releases_url":"https://api.github.com/repos/mosdef-hub/mbuild/releases{/id}","deployments_url":"https://api.github.com/repos/mosdef-hub/mbuild/deployments","created_at":"2013-10-23T14:24:18Z","updated_at":"2018-08-17T22:19:41Z","pushed_at":"2018-08-21T14:27:59Z","git_url":"git://github.com/mosdef-hub/mbuild.git","ssh_url":"git@github.com:mosdef-hub/mbuild.git","clone_url":"https://github.com/mosdef-hub/mbuild.git","svn_url":"https://github.com/mosdef-hub/mbuild","homepage":"http://mosdef-hub.github.io/mbuild/","size":81182,"stargazers_count":41,"watchers_count":41,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":36,"open_issues":72,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457"},"html":{"href":"https://github.com/mosdef-hub/mbuild/pull/457"},"issue":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/issues/457"},"comments":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/issues/457/comments"},"review_comments":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457/comments"},"review_comment":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/pulls/457/commits"},"statuses":{"href":"https://api.github.com/repos/mosdef-hub/mbuild/statuses/8109379a22d2f469b9a4c59d3da51f7103cbb0a6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mattwthompson"}}