{"action":"created","issue":{"url":"https://api.github.com/repos/sunchao/parquet-rs/issues/38","repository_url":"https://api.github.com/repos/sunchao/parquet-rs","labels_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/38/comments","events_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/38/events","html_url":"https://github.com/sunchao/parquet-rs/pull/38","id":292960922,"number":38,"title":"Add  DELTA_LENGTH_BYTE_ARRAY and DELTA_BYTE_ARRAY encodings","user":{"login":"sadikovi","id":7788766,"avatar_url":"https://avatars3.githubusercontent.com/u/7788766?v=4","gravatar_id":"","url":"https://api.github.com/users/sadikovi","html_url":"https://github.com/sadikovi","followers_url":"https://api.github.com/users/sadikovi/followers","following_url":"https://api.github.com/users/sadikovi/following{/other_user}","gists_url":"https://api.github.com/users/sadikovi/gists{/gist_id}","starred_url":"https://api.github.com/users/sadikovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadikovi/subscriptions","organizations_url":"https://api.github.com/users/sadikovi/orgs","repos_url":"https://api.github.com/users/sadikovi/repos","events_url":"https://api.github.com/users/sadikovi/events{/privacy}","received_events_url":"https://api.github.com/users/sadikovi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-01-30T22:25:57Z","updated_at":"2018-02-05T01:08:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sunchao/parquet-rs/pulls/38","html_url":"https://github.com/sunchao/parquet-rs/pull/38","diff_url":"https://github.com/sunchao/parquet-rs/pull/38.diff","patch_url":"https://github.com/sunchao/parquet-rs/pull/38.patch"},"body":"This PR adds `DELTA_LENGTH_BYTE_ARRAY` and `DELTA_BYTE_ARRAY` encodings and fixes some small issues in decodings.\r\n\r\nChanges:\r\n- Added `DELTA_LENGTH_BYTE_ARRAY` encoding \r\n- Added `DELTA_BYTE_ARRAY` encoding\r\n- Added `slice()` method for `ByteArray`\r\n- Reordered list of encodings/decodings to be in the same order in `get_encoder` and `get_decoder`\r\n- Updated `DELTA_BYTE_ARRAY` decoding `get()` method, fixed current_idx update, and modified overall method to handle prefix length 0 (IMHO, it is a bit simpler now)\r\n- Updated test function and generalized for all delta encodings, added tests for delta byte array decoding (tests delta length byte array decoding implicitly)\r\n- Updated generic encoding test to include delta length byte array and delta byte array encoding/decoding\r\n\r\nFixes #33 \r\nFixes #34"},"comment":{"url":"https://api.github.com/repos/sunchao/parquet-rs/issues/comments/362956639","html_url":"https://github.com/sunchao/parquet-rs/pull/38#issuecomment-362956639","issue_url":"https://api.github.com/repos/sunchao/parquet-rs/issues/38","id":362956639,"user":{"login":"sadikovi","id":7788766,"avatar_url":"https://avatars3.githubusercontent.com/u/7788766?v=4","gravatar_id":"","url":"https://api.github.com/users/sadikovi","html_url":"https://github.com/sadikovi","followers_url":"https://api.github.com/users/sadikovi/followers","following_url":"https://api.github.com/users/sadikovi/following{/other_user}","gists_url":"https://api.github.com/users/sadikovi/gists{/gist_id}","starred_url":"https://api.github.com/users/sadikovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sadikovi/subscriptions","organizations_url":"https://api.github.com/users/sadikovi/orgs","repos_url":"https://api.github.com/users/sadikovi/repos","events_url":"https://api.github.com/users/sadikovi/events{/privacy}","received_events_url":"https://api.github.com/users/sadikovi/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T01:08:09Z","updated_at":"2018-02-05T01:08:09Z","author_association":"CONTRIBUTOR","body":"@sunchao Would you mind reviewing this PR again? I addressed some of the comments and replied to your inline comments. Would appreciate if you could have a look. Thanks!"}}
{"actor":{"display_login":"sadikovi"}}