{"push_id":2959196615,"size":20,"distinct_size":0,"ref":"refs/heads/nm-1-10","head":"5afec82a5ccdb26fb2945027cd63e74ca37976d7","before":"e3e86af74e35869de996eb25e9b004a65dcda6c0","commits":[{"sha":"b9dace0aa3170abcf59279688805a20e627254e3","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: adjust logging of timeouts for NDisc result\n\nPreviously, we would directly log get_expiry(), which is the absolute timestamp\ninn nm_utils_get_monotonic_timestamp_s() scale. This time scale starts counting\nsomewhere around the time when the NetworkManager process starts, hence it is not\nvery intuitive to look at.\n\nInstead, print the remaining time that is left counting from now. Since\nwe anyway only track timeouts with a granularity of whole seconds,\nprinting up to 4 decimal places is sufficiently precise.\n\n(cherry picked from commit b680cdd06325a15ef3ca38caedcd53dd1525a5cd)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/b9dace0aa3170abcf59279688805a20e627254e3"},{"sha":"2ff8ece27ee8d52541d69163ddab0652b5b29ccd","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device: add const specifier to nm_ndisc_dad_failed() argument\n\n(cherry picked from commit cd6cf0ea361216fda993213e291d74710b73b5a5)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/2ff8ece27ee8d52541d69163ddab0652b5b29ccd"},{"sha":"8389888e08c0a71cb8fbf86487d9984efddacc29","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: ensure proper lifetime of NMNDiscAddress in ndisc_set_router_config()\n\nIn ndisc_set_router_config(), we initialize NMNDiscAddress based on\nNMPlatformIP6Address instances. Note that their handling of timestamps\nis not entirely identical.\n\nFor convenience of the user, NMPlatformIP6Address allows to not specify\nany timestamp. On the contrary, for convenience of implementation does\nNMNDiscAddress always require fully specified timestamps.\n\nProperly convert one representation into the other.\n\n(cherry picked from commit 5c4f4b354033607ac04d002da600348f0562773e)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/8389888e08c0a71cb8fbf86487d9984efddacc29"},{"sha":"cb5a47a4db519712ca27ed2444eb3d949dd65e25","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc/trivial: rename name for internal signal enum to match signal name\n\n(cherry picked from commit ede4dd70f3a28baceaa2ec4bc1642b48cccad1d9)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/cb5a47a4db519712ca27ed2444eb3d949dd65e25"},{"sha":"eca12c2ee1bc7cfb3b86a56c5df3e2ca22fd6c32","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"device/ndisc: skip link-local addresses from NDisc\n\n(cherry picked from commit fa09e7eb538a6fcb92ac8a86e9a8eb8ddb02d8d0)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/eca12c2ee1bc7cfb3b86a56c5df3e2ca22fd6c32"},{"sha":"deedb10600005873899d19a9f7edfe5b851180bd","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc/trivial: indentation and add \"const\" to auto variable\n\n(cherry picked from commit 9ff6134814de1110ee511b707f66d6529671e6e5)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/deedb10600005873899d19a9f7edfe5b851180bd"},{"sha":"391587731c732473cfc1dc03f24adadddab680d0","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: first reschedule timeout before invoking change event in check_timestamps()\n\nIt's just ugly to invoke external code in the middel of an operation.\nYou never know, whether the handler won' unref the ndisc instance.\n\n(cherry picked from commit 1f856b7cb3dc1f229753d3a14acb26a8316ba13d)\n(cherry picked from commit a3c73e783b472745850110755f58923ff4cdc130)\n(cherry picked from commit 6858e794f38b045b8f4de62165e120f439757cfa)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/391587731c732473cfc1dc03f24adadddab680d0"},{"sha":"9a06bb2b7b384f9668e52bb56a451d7633d91689","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: keep NMNDisc instance alive while processing IO in event_ready()\n\nevent_ready() calls ndp_callall_eventfd_handler(), which invokes\nour own callback, which may invoke change notification.\n\nAt that point, it's not guaranteed that the signal handler won't\ndestroy the ndisc instance, which means, the \"struct ndp\" gets destroyed\nwhile invoking callbacks. That's bad, because libndp is not robust\nagainst that.\n\nEnsure the object stays alive long enough.\n\n(cherry picked from commit 9aa628cedb707e9c4f0e0dba437ec22375a0032e)\n(cherry picked from commit efb9e2bc6b354d189da34fab07e79db1bf162cb1)\n(cherry picked from commit 2ba6d74bcab58af1dc327714216e130368ec61d6)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/9a06bb2b7b384f9668e52bb56a451d7633d91689"},{"sha":"ba6490e00e026c65c30c44d4c9287683a5ad4198","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: abort handling IO in event_ready() if we are unable to switch namespace\n\nIt should never happen that we are unable to switch the namespace.\nHowever, in case it does, we cannot just return G_SOURCE_CONTINUE,\nbecause we will just endlessly trying to process IO without actually\nreading from the socket.\n\nThis shouldn't happen, but the instance is hosed and something is\nvery wrong. No longer handle the socket to avoid an endless loop.\n\n(cherry picked from commit d444fcde34f06711208494a65cd0ea9b9ba2c592)\n(cherry picked from commit 6631debaa32d42c8e45f24a696c2e033d525c061)\n(cherry picked from commit 5c56404dfc3c568d6a68dfd17743c16b9405c0e3)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/ba6490e00e026c65c30c44d4c9287683a5ad4198"},{"sha":"3a2e6c517288aff19e0a41d37252deea3230b134","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc/trivial: move code\n\n(cherry picked from commit 4f78d82fcd135e42bc0a5dabb4522ab318c47808)\n(cherry picked from commit bd41719f95d20a5cf719a7f1ddd21c45b12dfda1)\n(cherry picked from commit cdc5848be760342066d2b9a94bea2621028dbe29)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/3a2e6c517288aff19e0a41d37252deea3230b134"},{"sha":"fc9ad78f3a7f5cf663d0ed546119245583fe50c9","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: always emit changed signal if an ndisc parameter changes\n\nNote how the nm_ndisc_add_*() return a boolean to indicate whether\nanything changes. That is taken to decide whether to emit a changed\nsignal.\n\nPreviously, we would not consider all fields which are exposed\nas public API.\n\nNote that nm-ip6-config.c would care about the lifetime of NMNDiscAddress.\nFor that, nm_ndisc_add_address() would correctly consider a change of\nthe lifetime as relevant. So, this was for the most part not broken.\nHowever, for example nm_ndisc_add_route() would ignore changes to the\ngateway.\n\nAlways signal changes if anything changes at all. It's more correct\nand robust.\n\n(cherry picked from commit 98ec56c6704aa45b438e7c70ad8860a3c0dc5b70)\n(cherry picked from commit 2e12660dd417d75e30d4a1ab689259a9c10344e4)\n(cherry picked from commit 9f6a6549999572682ea10f7e45545966d36ba6e2)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/fc9ad78f3a7f5cf663d0ed546119245583fe50c9"},{"sha":"f231b2b9b7ec6acc38a91dd224174ce17a1fa23e","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: merge branch 'th/ndisc-fixes'\n\nhttps://github.com/NetworkManager/NetworkManager/pull/219\n\n(cherry picked from commit 6e41d7906737ee79b10cf7c94036e1e080e8cab3)\n(cherry picked from commit 8ee0ca8cce95609bd3cedabece51efb436d849d4)\n(cherry picked from commit 685573e049bf09104edeb36992f3bf0be5c2b85f)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/f231b2b9b7ec6acc38a91dd224174ce17a1fa23e"},{"sha":"8177b0c397ad2d53804d446d7e5a0332234df14a","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: ignore addresses with preferred lifetime larger than lifetime\n\nPreviously, we would coerce the value so that preferred is the same\nas lifetime. However, RFC4862 5.5.3.c) says:\n\n  c)  If the preferred lifetime is greater than the valid lifetime,\n    silently ignore the Prefix Information option.  A node MAY wish to\n    log a system management error in this case.\n\nSee-also: https://tools.ietf.org/search/rfc4862#section-5.5.3\n(cherry picked from commit 43c3c259c8e2fd4aa5416b79efd47a72cca790ec)\n(cherry picked from commit eff9e161cb056c544763dd2f45de7371ac46b8bd)\n(cherry picked from commit dbfa7950cfab63491d2a237311616f98e38ab73c)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/8177b0c397ad2d53804d446d7e5a0332234df14a"},{"sha":"aeca2fb4b123be20d4cc112456a41778f984c3cc","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: ensure we skip unspecified IPv6 address in ndisc_set_router_config()\n\nLater, nm_ndisc_add_address() asserts that the address is not an\nunspecified address. Skip it, just to be sure.\n\n(cherry picked from commit 700b04d0deded1f8b8267e13202d3c29f8748e14)\n(cherry picked from commit e0e698e463ef244223d4af500ba7a688ba976c86)\n(cherry picked from commit 547dcacbfbf317b44f2ddd552339207df39d2d1c)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/aeca2fb4b123be20d4cc112456a41778f984c3cc"},{"sha":"d4b67b9441a61f03e8796972f2e9741be77799bb","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: only generate address interface identifer after checking existing prefix\n\nRFC4862 5.5.3, points d) and e) make it clear, that the list of\naddresses should be compared based on the prefix.\n\n  d)  If the prefix advertised is not equal to the prefix of an\n    address configured by stateless autoconfiguration already in the\n    list of addresses associated with the interface (where \"equal\"\n    means the two prefix lengths are the same and the first prefix-\n    length bits of the prefixes are identical), and if the Valid\n    Lifetime is not 0, form an address (and add it to the list) by\n    combining the advertised prefix with an interface identifier of\n    the link as follows:\n\nThat means, we should not initialize the interface identifier first\n(via complete_address()) and then search for the full address.\n\nSee-also: https://tools.ietf.org/search/rfc4862#section-5.5.3\n(cherry picked from commit 23c417854a943eb796a8c06e7d94b02d18f19691)\n(cherry picked from commit ac5669633c44f6da3ec417282d59d71f229c2b7a)\n(cherry picked from commit b2f084a8ae927d058818d7126e4536d3b36a23bd)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/d4b67b9441a61f03e8796972f2e9741be77799bb"},{"sha":"3d99992593e070e91fc762d73d66f68131e63b0c","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: minor refactoring loop in nm_ndisc_add_address()\n\nNo change in behavior. Just don't do so much work inside\nthe deeper nesting of the loop.\n\n(cherry picked from commit 9d0a138ef05544954de49a8056f47e34c6bf3c5a)\n(cherry picked from commit 3cecb4d0186391dcd09fb6bf70afa96fc16ebf3d)\n(cherry picked from commit 669e004299605b76ef30fe7ee7f4728f59f65acf)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/3d99992593e070e91fc762d73d66f68131e63b0c"},{"sha":"2e365f638bbf2353e060e0c55b803889a57baca3","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: handle integer overflows better for lifetime handling\n\nwe use get_expiry() to compare two lifetimes. Note, that previously,\nit would correctly truncate the calculated expiry at G_MAXINT32-1.\n\nHowever, that means, that two different lifetimes that both lie\nmore than 68 years in the future would compare equal.\n\nFix that, but extending the range to int64, so that no overflow\ncan happen.\n\n(cherry picked from commit b086535cb7f28a495a742c64ed4e212175f19860)\n(cherry picked from commit fe60843232a2bbd6e78eec5b25a1a5f8896566b2)\n(cherry picked from commit 42e61a8cc8fb56e7dd625edcec470aa090747839)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/2e365f638bbf2353e060e0c55b803889a57baca3"},{"sha":"cc16d893954172829837afd48f0fbf12a5df89a2","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: fix updating address lifetime on Router Announcement according to RFC4862\n\nThis is a denial-of-service protection, where a malicious router\nadvertisement can expire the addresses.\n\nSee-also: https://github.com/systemd/systemd/commit/6554550f35a7976f9110aff94743d3576d5f02dd\nSee-also: https://tools.ietf.org/search/rfc4862#section-5.5.3\n\nhttps://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1796622\n(cherry picked from commit 27be3e03382deb3da29e0c31dc6cb871bd6be0e8)\n(cherry picked from commit 8e2ccd3921427d6d589b0695b2b219bdb84b1121)\n(cherry picked from commit 451bf6e275517e139ee96ee2fa4acc747d10561c)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/cc16d893954172829837afd48f0fbf12a5df89a2"},{"sha":"2c47cf51b121635ab7ede44efbc7da5ed087f2e4","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: don't update dad_counter for addresses in router config\n\nI am not sure, we ever call complete_address() for router-configurations.\nMaybe not, so the dad-counter is never incremented and does not matter either.\n\nIf we however do, then we certainly want to preserve the DAD counter\nwhen the address is already tracked.\n\n(cherry picked from commit 8c6629b356039e2b2bbb87574755dad298cb0615)\n(cherry picked from commit 036d1f56ea3321056237251cda66e412f7826e7b)\n(cherry picked from commit 148c9d9b0cacc4b65a8be6fa66861e06c6847113)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/2c47cf51b121635ab7ede44efbc7da5ed087f2e4"},{"sha":"5afec82a5ccdb26fb2945027cd63e74ca37976d7","author":{"name":"Thomas Haller","email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com"},"message":"ndisc: merge branch 'th/ndisc-addr-lifetime'\n\nhttps://github.com/NetworkManager/NetworkManager/pull/228\n\nhttps://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/57\nhttps://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/1796622\n\n(cherry picked from commit 3baa016f890ebb059e1b8b18543dc2e9f904356a)\n(cherry picked from commit 8c24119859fe682a889896afa45ef108e31b6fcd)\n(cherry picked from commit c7d8f17094a24aec4a1a79447cda3bc208b751a5)","distinct":false,"url":"https://api.github.com/repos/freedesktop/NetworkManager/commits/5afec82a5ccdb26fb2945027cd63e74ca37976d7"}]}
{"actor":{"display_login":"fdo-mirror"}}