{"action":"closed","number":21629,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/21629","id":242163538,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTYzNTM4","html_url":"https://github.com/apple/swift/pull/21629","diff_url":"https://github.com/apple/swift/pull/21629.diff","patch_url":"https://github.com/apple/swift/pull/21629.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/21629","number":21629,"state":"closed","locked":false,"title":"[AutoDiff] No longer require `TangentVector` to be a vector space.","user":{"login":"rxwei","id":856507,"node_id":"MDQ6VXNlcjg1NjUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/856507?v=4","gravatar_id":"","url":"https://api.github.com/users/rxwei","html_url":"https://github.com/rxwei","followers_url":"https://api.github.com/users/rxwei/followers","following_url":"https://api.github.com/users/rxwei/following{/other_user}","gists_url":"https://api.github.com/users/rxwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rxwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxwei/subscriptions","organizations_url":"https://api.github.com/users/rxwei/orgs","repos_url":"https://api.github.com/users/rxwei/repos","events_url":"https://api.github.com/users/rxwei/events{/privacy}","received_events_url":"https://api.github.com/users/rxwei/received_events","type":"User","site_admin":false},"body":"Structs that conform to `Differentiable` should not require member spaces to have the same scalar type, so `TangentVector` and `CotangentVector` should represent a tangent bundle instead. However, correctly representing tangent bundles requires dependent types. Practically, differentiation only requires `.zero` and `+`, thus `TangentVector` and `CotangentVector` are now constrained on `AdditiveArithmetic`.\r\n\r\nThis patch does not change the behavior of `Differentiable` derived conformances yet. @dan-zheng will handle that later.","created_at":"2019-01-04T02:51:07Z","updated_at":"2019-01-04T04:40:36Z","closed_at":"2019-01-04T04:40:36Z","merged_at":"2019-01-04T04:40:36Z","merge_commit_sha":"b9a98185310f63bd530103e2ec6ea0f12501b572","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stephentyrone","id":641446,"node_id":"MDQ6VXNlcjY0MTQ0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/641446?v=4","gravatar_id":"","url":"https://api.github.com/users/stephentyrone","html_url":"https://github.com/stephentyrone","followers_url":"https://api.github.com/users/stephentyrone/followers","following_url":"https://api.github.com/users/stephentyrone/following{/other_user}","gists_url":"https://api.github.com/users/stephentyrone/gists{/gist_id}","starred_url":"https://api.github.com/users/stephentyrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephentyrone/subscriptions","organizations_url":"https://api.github.com/users/stephentyrone/orgs","repos_url":"https://api.github.com/users/stephentyrone/repos","events_url":"https://api.github.com/users/stephentyrone/events{/privacy}","received_events_url":"https://api.github.com/users/stephentyrone/received_events","type":"User","site_admin":false},{"login":"dan-zheng","id":5590046,"node_id":"MDQ6VXNlcjU1OTAwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/5590046?v=4","gravatar_id":"","url":"https://api.github.com/users/dan-zheng","html_url":"https://github.com/dan-zheng","followers_url":"https://api.github.com/users/dan-zheng/followers","following_url":"https://api.github.com/users/dan-zheng/following{/other_user}","gists_url":"https://api.github.com/users/dan-zheng/gists{/gist_id}","starred_url":"https://api.github.com/users/dan-zheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dan-zheng/subscriptions","organizations_url":"https://api.github.com/users/dan-zheng/orgs","repos_url":"https://api.github.com/users/dan-zheng/repos","events_url":"https://api.github.com/users/dan-zheng/events{/privacy}","received_events_url":"https://api.github.com/users/dan-zheng/received_events","type":"User","site_admin":false},{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/21629/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/21629/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/21629/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/6fb5f64d5669d4cf9b5add8737e502d90efd8a09","head":{"label":"rxwei:tangent-bundle","ref":"tangent-bundle","sha":"6fb5f64d5669d4cf9b5add8737e502d90efd8a09","user":{"login":"rxwei","id":856507,"node_id":"MDQ6VXNlcjg1NjUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/856507?v=4","gravatar_id":"","url":"https://api.github.com/users/rxwei","html_url":"https://github.com/rxwei","followers_url":"https://api.github.com/users/rxwei/followers","following_url":"https://api.github.com/users/rxwei/following{/other_user}","gists_url":"https://api.github.com/users/rxwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rxwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxwei/subscriptions","organizations_url":"https://api.github.com/users/rxwei/orgs","repos_url":"https://api.github.com/users/rxwei/repos","events_url":"https://api.github.com/users/rxwei/events{/privacy}","received_events_url":"https://api.github.com/users/rxwei/received_events","type":"User","site_admin":false},"repo":{"id":136226896,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMjY4OTY=","name":"swift","full_name":"rxwei/swift","private":false,"owner":{"login":"rxwei","id":856507,"node_id":"MDQ6VXNlcjg1NjUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/856507?v=4","gravatar_id":"","url":"https://api.github.com/users/rxwei","html_url":"https://github.com/rxwei","followers_url":"https://api.github.com/users/rxwei/followers","following_url":"https://api.github.com/users/rxwei/following{/other_user}","gists_url":"https://api.github.com/users/rxwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rxwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxwei/subscriptions","organizations_url":"https://api.github.com/users/rxwei/orgs","repos_url":"https://api.github.com/users/rxwei/repos","events_url":"https://api.github.com/users/rxwei/events{/privacy}","received_events_url":"https://api.github.com/users/rxwei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rxwei/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/rxwei/swift","forks_url":"https://api.github.com/repos/rxwei/swift/forks","keys_url":"https://api.github.com/repos/rxwei/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rxwei/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rxwei/swift/teams","hooks_url":"https://api.github.com/repos/rxwei/swift/hooks","issue_events_url":"https://api.github.com/repos/rxwei/swift/issues/events{/number}","events_url":"https://api.github.com/repos/rxwei/swift/events","assignees_url":"https://api.github.com/repos/rxwei/swift/assignees{/user}","branches_url":"https://api.github.com/repos/rxwei/swift/branches{/branch}","tags_url":"https://api.github.com/repos/rxwei/swift/tags","blobs_url":"https://api.github.com/repos/rxwei/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rxwei/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rxwei/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/rxwei/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rxwei/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/rxwei/swift/languages","stargazers_url":"https://api.github.com/repos/rxwei/swift/stargazers","contributors_url":"https://api.github.com/repos/rxwei/swift/contributors","subscribers_url":"https://api.github.com/repos/rxwei/swift/subscribers","subscription_url":"https://api.github.com/repos/rxwei/swift/subscription","commits_url":"https://api.github.com/repos/rxwei/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/rxwei/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/rxwei/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/rxwei/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/rxwei/swift/contents/{+path}","compare_url":"https://api.github.com/repos/rxwei/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rxwei/swift/merges","archive_url":"https://api.github.com/repos/rxwei/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rxwei/swift/downloads","issues_url":"https://api.github.com/repos/rxwei/swift/issues{/number}","pulls_url":"https://api.github.com/repos/rxwei/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/rxwei/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/rxwei/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rxwei/swift/labels{/name}","releases_url":"https://api.github.com/repos/rxwei/swift/releases{/id}","deployments_url":"https://api.github.com/repos/rxwei/swift/deployments","created_at":"2018-06-05T19:45:30Z","updated_at":"2018-12-28T09:35:21Z","pushed_at":"2019-01-04T02:49:29Z","git_url":"git://github.com/rxwei/swift.git","ssh_url":"git@github.com:rxwei/swift.git","clone_url":"https://github.com/rxwei/swift.git","svn_url":"https://github.com/rxwei/swift","homepage":"https://swift.org/","size":374622,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"tensorflow"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"96ad0c9a209d863d447ad95fb4c7f0fbd66bede6","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","private":false,"owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2019-01-04T03:39:07Z","pushed_at":"2019-01-04T04:40:36Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":376240,"stargazers_count":46216,"watchers_count":46216,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7339,"mirror_url":null,"archived":false,"open_issues_count":441,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7339,"open_issues":441,"watchers":46216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/21629"},"html":{"href":"https://github.com/apple/swift/pull/21629"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/21629"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/21629/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/21629/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/21629/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/6fb5f64d5669d4cf9b5add8737e502d90efd8a09"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rxwei","id":856507,"node_id":"MDQ6VXNlcjg1NjUwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/856507?v=4","gravatar_id":"","url":"https://api.github.com/users/rxwei","html_url":"https://github.com/rxwei","followers_url":"https://api.github.com/users/rxwei/followers","following_url":"https://api.github.com/users/rxwei/following{/other_user}","gists_url":"https://api.github.com/users/rxwei/gists{/gist_id}","starred_url":"https://api.github.com/users/rxwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxwei/subscriptions","organizations_url":"https://api.github.com/users/rxwei/orgs","repos_url":"https://api.github.com/users/rxwei/repos","events_url":"https://api.github.com/users/rxwei/events{/privacy}","received_events_url":"https://api.github.com/users/rxwei/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":10,"changed_files":1}}
{"actor":{"display_login":"rxwei"}}