{"action":"created","comment":{"url":"https://api.github.com/repos/apache/hive/pulls/comments/179993687","pull_request_review_id":110334514,"id":179993687,"diff_hunk":"@@ -1544,21 +1546,68 @@ public void testRetryableRegex() throws Exception {\n     Assert.assertTrue(\"regex should be retryable\", result);\n   }\n \n-  @Test\n-  public void testReplOpenTxn() throws Exception {\n-    int numTxn = 50000;\n+  private List<Long> openTxnForTest(int startId, int numTxn, String replPolicy) throws MetaException, NoSuchTxnException {\n     conf.setIntVar(HiveConf.ConfVars.HIVE_TXN_MAX_OPEN_BATCH, numTxn);\n+    int lastId = startId + numTxn;\n     OpenTxnRequest rqst = new OpenTxnRequest(numTxn, \"me\", \"localhost\");\n-    rqst.setReplPolicy(\"default.*\");\n-    rqst.setReplSrcTxnIds(LongStream.rangeClosed(1, numTxn)\n+    rqst.setReplPolicy(replPolicy);\n+    rqst.setReplSrcTxnIds(LongStream.rangeClosed(startId, lastId)\n             .boxed().collect(Collectors.toList()));\n     OpenTxnsResponse openedTxns = txnHandler.openTxns(rqst);\n     List<Long> txnList = openedTxns.getTxn_ids();\n     assertEquals(txnList.size(), numTxn);\n     for (long i = 0; i < numTxn; i++) {\n       long txnId = txnList.get((int) i);\n-      assertEquals(i+1, txnId);\n+      assertEquals(i + startId, txnId);\n+    }\n+    return txnList;\n+  }\n+\n+  @Test\n+  public void testReplOpenTxn() throws Exception {\n+    int numTxn = 50000;\n+    List<Long> txnList = openTxnForTest(1, numTxn, \"default.*\");\n+    assert(txnList.size() == numTxn);\n+    txnHandler.abortTxns(new AbortTxnsRequest(txnList));","path":"ql/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnHandler.java","position":52,"original_position":52,"commit_id":"09a5a19d2827068a83a17e7c9aef01291b8bffd0","original_commit_id":"09a5a19d2827068a83a17e7c9aef01291b8bffd0","user":{"login":"sankarh","id":25001186,"avatar_url":"https://avatars2.githubusercontent.com/u/25001186?v=4","gravatar_id":"","url":"https://api.github.com/users/sankarh","html_url":"https://github.com/sankarh","followers_url":"https://api.github.com/users/sankarh/followers","following_url":"https://api.github.com/users/sankarh/following{/other_user}","gists_url":"https://api.github.com/users/sankarh/gists{/gist_id}","starred_url":"https://api.github.com/users/sankarh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sankarh/subscriptions","organizations_url":"https://api.github.com/users/sankarh/orgs","repos_url":"https://api.github.com/users/sankarh/repos","events_url":"https://api.github.com/users/sankarh/events{/privacy}","received_events_url":"https://api.github.com/users/sankarh/received_events","type":"User","site_admin":false},"body":"What are we testing here? No verification after abort.","created_at":"2018-04-09T06:02:52Z","updated_at":"2018-04-09T07:01:20Z","html_url":"https://github.com/apache/hive/pull/329#discussion_r179993687","pull_request_url":"https://api.github.com/repos/apache/hive/pulls/329","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/comments/179993687"},"html":{"href":"https://github.com/apache/hive/pull/329#discussion_r179993687"},"pull_request":{"href":"https://api.github.com/repos/apache/hive/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/apache/hive/pulls/329","id":178982216,"html_url":"https://github.com/apache/hive/pull/329","diff_url":"https://github.com/apache/hive/pull/329.diff","patch_url":"https://github.com/apache/hive/pull/329.patch","issue_url":"https://api.github.com/repos/apache/hive/issues/329","number":329,"state":"open","locked":false,"title":"HIVE-19089 : Create/Replicate AllocWriteId Event","user":{"login":"maheshk114","id":19660171,"avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"body":"EVENT_ALLOCATE_WRITE_ID\r\nSource Warehouse:\r\n\r\nCreate new event type EVENT_ALLOCATE_WRITE_ID with related message format etc.\r\nCapture this event when allocate a table write ID from the sequence table by ACID operation.\r\nRepl dump should read this event from EventNotificationTable and dump the message.\r\nTarget Warehouse:\r\n\r\nRepl load should read the event from the dump and get the message.\r\nValidate if source txn ID from the event is there in the source-target txn ID map. If not there, just noop the event.\r\nIf valid, then Allocate table write ID from sequence table\r\nExtend listener notify event API to add two new parameter , dbconn and sqlgenerator to add the events to notification_log table within the same transaction ","created_at":"2018-04-03T03:04:33Z","updated_at":"2018-04-09T07:01:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6746a19353238a11cea55e9542a20677462ab08a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/hive/pulls/329/commits","review_comments_url":"https://api.github.com/repos/apache/hive/pulls/329/comments","review_comment_url":"https://api.github.com/repos/apache/hive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/hive/issues/329/comments","statuses_url":"https://api.github.com/repos/apache/hive/statuses/09a5a19d2827068a83a17e7c9aef01291b8bffd0","head":{"label":"maheshk114:BUG-95522-95521","ref":"BUG-95522-95521","sha":"09a5a19d2827068a83a17e7c9aef01291b8bffd0","user":{"login":"maheshk114","id":19660171,"avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"repo":{"id":118883759,"name":"hive","full_name":"maheshk114/hive","owner":{"login":"maheshk114","id":19660171,"avatar_url":"https://avatars3.githubusercontent.com/u/19660171?v=4","gravatar_id":"","url":"https://api.github.com/users/maheshk114","html_url":"https://github.com/maheshk114","followers_url":"https://api.github.com/users/maheshk114/followers","following_url":"https://api.github.com/users/maheshk114/following{/other_user}","gists_url":"https://api.github.com/users/maheshk114/gists{/gist_id}","starred_url":"https://api.github.com/users/maheshk114/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maheshk114/subscriptions","organizations_url":"https://api.github.com/users/maheshk114/orgs","repos_url":"https://api.github.com/users/maheshk114/repos","events_url":"https://api.github.com/users/maheshk114/events{/privacy}","received_events_url":"https://api.github.com/users/maheshk114/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maheshk114/hive","description":"Mirror of Apache Hive","fork":true,"url":"https://api.github.com/repos/maheshk114/hive","forks_url":"https://api.github.com/repos/maheshk114/hive/forks","keys_url":"https://api.github.com/repos/maheshk114/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maheshk114/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maheshk114/hive/teams","hooks_url":"https://api.github.com/repos/maheshk114/hive/hooks","issue_events_url":"https://api.github.com/repos/maheshk114/hive/issues/events{/number}","events_url":"https://api.github.com/repos/maheshk114/hive/events","assignees_url":"https://api.github.com/repos/maheshk114/hive/assignees{/user}","branches_url":"https://api.github.com/repos/maheshk114/hive/branches{/branch}","tags_url":"https://api.github.com/repos/maheshk114/hive/tags","blobs_url":"https://api.github.com/repos/maheshk114/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maheshk114/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maheshk114/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/maheshk114/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maheshk114/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/maheshk114/hive/languages","stargazers_url":"https://api.github.com/repos/maheshk114/hive/stargazers","contributors_url":"https://api.github.com/repos/maheshk114/hive/contributors","subscribers_url":"https://api.github.com/repos/maheshk114/hive/subscribers","subscription_url":"https://api.github.com/repos/maheshk114/hive/subscription","commits_url":"https://api.github.com/repos/maheshk114/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/maheshk114/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/maheshk114/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/maheshk114/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/maheshk114/hive/contents/{+path}","compare_url":"https://api.github.com/repos/maheshk114/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maheshk114/hive/merges","archive_url":"https://api.github.com/repos/maheshk114/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maheshk114/hive/downloads","issues_url":"https://api.github.com/repos/maheshk114/hive/issues{/number}","pulls_url":"https://api.github.com/repos/maheshk114/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/maheshk114/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/maheshk114/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maheshk114/hive/labels{/name}","releases_url":"https://api.github.com/repos/maheshk114/hive/releases{/id}","deployments_url":"https://api.github.com/repos/maheshk114/hive/deployments","created_at":"2018-01-25T08:17:10Z","updated_at":"2018-01-25T08:17:57Z","pushed_at":"2018-04-08T04:26:09Z","git_url":"git://github.com/maheshk114/hive.git","ssh_url":"git@github.com:maheshk114/hive.git","clone_url":"https://github.com/maheshk114/hive.git","svn_url":"https://github.com/maheshk114/hive","homepage":null,"size":384866,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6ba33b84c33e16feaa2d0683b44c35e97a6e4cb9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":206444,"name":"hive","full_name":"apache/hive","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/hive","description":"Mirror of Apache Hive","fork":false,"url":"https://api.github.com/repos/apache/hive","forks_url":"https://api.github.com/repos/apache/hive/forks","keys_url":"https://api.github.com/repos/apache/hive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/hive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/hive/teams","hooks_url":"https://api.github.com/repos/apache/hive/hooks","issue_events_url":"https://api.github.com/repos/apache/hive/issues/events{/number}","events_url":"https://api.github.com/repos/apache/hive/events","assignees_url":"https://api.github.com/repos/apache/hive/assignees{/user}","branches_url":"https://api.github.com/repos/apache/hive/branches{/branch}","tags_url":"https://api.github.com/repos/apache/hive/tags","blobs_url":"https://api.github.com/repos/apache/hive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/hive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/hive/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/hive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/hive/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/hive/languages","stargazers_url":"https://api.github.com/repos/apache/hive/stargazers","contributors_url":"https://api.github.com/repos/apache/hive/contributors","subscribers_url":"https://api.github.com/repos/apache/hive/subscribers","subscription_url":"https://api.github.com/repos/apache/hive/subscription","commits_url":"https://api.github.com/repos/apache/hive/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/hive/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/hive/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/hive/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/hive/contents/{+path}","compare_url":"https://api.github.com/repos/apache/hive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/hive/merges","archive_url":"https://api.github.com/repos/apache/hive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/hive/downloads","issues_url":"https://api.github.com/repos/apache/hive/issues{/number}","pulls_url":"https://api.github.com/repos/apache/hive/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/hive/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/hive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/hive/labels{/name}","releases_url":"https://api.github.com/repos/apache/hive/releases{/id}","deployments_url":"https://api.github.com/repos/apache/hive/deployments","created_at":"2009-05-21T02:31:01Z","updated_at":"2018-04-09T04:19:17Z","pushed_at":"2018-04-09T02:14:14Z","git_url":"git://github.com/apache/hive.git","ssh_url":"git@github.com:apache/hive.git","clone_url":"https://github.com/apache/hive.git","svn_url":"https://github.com/apache/hive","homepage":null,"size":382073,"stargazers_count":1799,"watchers_count":1799,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1916,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1916,"open_issues":134,"watchers":1799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/hive/pulls/329"},"html":{"href":"https://github.com/apache/hive/pull/329"},"issue":{"href":"https://api.github.com/repos/apache/hive/issues/329"},"comments":{"href":"https://api.github.com/repos/apache/hive/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/hive/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/hive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/hive/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/apache/hive/statuses/09a5a19d2827068a83a17e7c9aef01291b8bffd0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sankarh"}}