{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/951","repository_url":"https://api.github.com/repos/Valloric/ycmd","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/951/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/951/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/951/events","html_url":"https://github.com/Valloric/ycmd/pull/951","id":304086728,"number":951,"title":"[READY] Expand environment variables in extra conf options","user":{"login":"micbou","id":10026824,"avatar_url":"https://avatars2.githubusercontent.com/u/10026824?v=4","gravatar_id":"","url":"https://api.github.com/users/micbou","html_url":"https://github.com/micbou","followers_url":"https://api.github.com/users/micbou/followers","following_url":"https://api.github.com/users/micbou/following{/other_user}","gists_url":"https://api.github.com/users/micbou/gists{/gist_id}","starred_url":"https://api.github.com/users/micbou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micbou/subscriptions","organizations_url":"https://api.github.com/users/micbou/orgs","repos_url":"https://api.github.com/users/micbou/repos","events_url":"https://api.github.com/users/micbou/events{/privacy}","received_events_url":"https://api.github.com/users/micbou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-10T17:11:40Z","updated_at":"2018-03-10T17:23:14Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/951","html_url":"https://github.com/Valloric/ycmd/pull/951","diff_url":"https://github.com/Valloric/ycmd/pull/951.diff","patch_url":"https://github.com/Valloric/ycmd/pull/951.patch"},"body":"This PR adds support for environment variables in the `extra_conf_globlist` and `global_ycm_extra_conf` options.\r\n\r\nFixes https://github.com/Valloric/YouCompleteMe/issues/2944.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/951)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/372046670","html_url":"https://github.com/Valloric/ycmd/pull/951#issuecomment-372046670","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/951","id":372046670,"user":{"login":"bstaletic","id":7791699,"avatar_url":"https://avatars3.githubusercontent.com/u/7791699?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaletic","html_url":"https://github.com/bstaletic","followers_url":"https://api.github.com/users/bstaletic/followers","following_url":"https://api.github.com/users/bstaletic/following{/other_user}","gists_url":"https://api.github.com/users/bstaletic/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaletic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaletic/subscriptions","organizations_url":"https://api.github.com/users/bstaletic/orgs","repos_url":"https://api.github.com/users/bstaletic/repos","events_url":"https://api.github.com/users/bstaletic/events{/privacy}","received_events_url":"https://api.github.com/users/bstaletic/received_events","type":"User","site_admin":false},"created_at":"2018-03-10T17:23:14Z","updated_at":"2018-03-10T17:23:14Z","author_association":"COLLABORATOR","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReviewed 2 of 2 files at r1.\nReview status: all files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[ycmd/extra_conf_store.py, line 237 at r1](https://beta.reviewable.io/reviews/valloric/ycmd/951#-L7FtONLyDaFLpqHjcHp-r1-237:-L7FveE37EHve2KLosYk:bff5wk7) ([raw file](https://github.com/valloric/ycmd/blob/1189260f3219354e0fc652a8e68f7472bc2f4e02/ycmd/extra_conf_store.py#L237)):*\n<details><summary><i>Previously, micbou wrote…</i></summary><blockquote>\n\nWe could but this is still useful for other clients.\n</blockquote></details>\n\nI think we should stick with the python's way because ycmd should be client agnostic.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/valloric/ycmd/951#-:-L7FvqCh9z2JfSx_B-gK:bnfp4nl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bstaletic"}}