{"action":"created","issue":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1043","repository_url":"https://api.github.com/repos/gaearon/react-hot-loader","labels_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1043/labels{/name}","comments_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1043/comments","events_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1043/events","html_url":"https://github.com/gaearon/react-hot-loader/issues/1043","id":348417271,"node_id":"MDU6SXNzdWUzNDg0MTcyNzE=","number":1043,"title":"Babel 7 Support","user":{"login":"SamMorrowDrums","id":4811358,"node_id":"MDQ6VXNlcjQ4MTEzNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/4811358?v=4","gravatar_id":"","url":"https://api.github.com/users/SamMorrowDrums","html_url":"https://github.com/SamMorrowDrums","followers_url":"https://api.github.com/users/SamMorrowDrums/followers","following_url":"https://api.github.com/users/SamMorrowDrums/following{/other_user}","gists_url":"https://api.github.com/users/SamMorrowDrums/gists{/gist_id}","starred_url":"https://api.github.com/users/SamMorrowDrums/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamMorrowDrums/subscriptions","organizations_url":"https://api.github.com/users/SamMorrowDrums/orgs","repos_url":"https://api.github.com/users/SamMorrowDrums/repos","events_url":"https://api.github.com/users/SamMorrowDrums/events{/privacy}","received_events_url":"https://api.github.com/users/SamMorrowDrums/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-07T17:30:57Z","updated_at":"2018-08-10T00:29:12Z","closed_at":null,"author_association":"NONE","body":"Hi - I don't know if there is a plan to support babel 7,  I'm sure it's quite a lot of work but it currently errors when I try it with webpack 4 I get `ReferenceError: [BABEL] app/app.js: Unknown option: .visitor. `. \r\n\r\nWhen using babel-upgrade --write I get the following changes:\r\n\r\n```\r\n     \"reload\"\r\n   ],\r\n   \"devDependencies\": {\r\n-    \"babel-cli\": \"^6.7.5\",\r\n-    \"babel-core\": \"^6.26.3\",\r\n+    \"@babel/cli\": \"7.0.0-beta.54\",\r\n+    \"@babel/core\": \"7.0.0-beta.54\",\r\n+    \"@babel/plugin-external-helpers\": \"7.0.0-beta.54\",\r\n+    \"@babel/plugin-proposal-class-properties\": \"7.0.0-beta.54\",\r\n+    \"@babel/plugin-proposal-object-rest-spread\": \"7.0.0-beta.54\",\r\n+    \"@babel/preset-env\": \"7.0.0-beta.54\",\r\n+    \"@babel/preset-flow\": \"7.0.0-beta.54\",\r\n+    \"@babel/preset-react\": \"7.0.0-beta.54\",\r\n+    \"babel-core\": \"^7.0.0-bridge.0\",\r\n     \"babel-eslint\": \"^8.2.3\",\r\n     \"babel-jest\": \"^22.4.3\",\r\n     \"babel-plugin-dynamic-import-node\": \"^1.2.0\",\r\n-    \"babel-plugin-external-helpers\": \"^6.22.0\",\r\n-    \"babel-plugin-transform-class-properties\": \"^6.24.1\",\r\n-    \"babel-plugin-transform-object-rest-spread\": \"^6.26.0\",\r\n-    \"babel-preset-env\": \"^1.6.0\",\r\n-    \"babel-preset-react\": \"^6.5.0\",\r\n     \"codecov\": \"^3.0.1\",\r\n     \"conventional-github-releaser\": \"^2.0.2\",\r\n     \"create-react-class\": \"^15.6.3\",\r\n@@ -81,7 +83,7 @@\r\n     \"recompose\": \"^0.27.0\",\r\n     \"rimraf\": \"^2.5.2\",\r\n     \"rollup\": \"^0.58.2\",\r\n-    \"rollup-plugin-babel\": \"^3.0.4\",\r\n+    \"rollup-plugin-babel\": \"^4.0.0-beta.2\",\r\n     \"rollup-plugin-commonjs\": \"^9.1.3\",\r\n     \"rollup-plugin-json\": \"^2.3.0\",\r\n     \"rollup-plugin-node-resolve\": \"^3.3.0\",\r\n@@ -93,6 +95,7 @@\r\n     \"react\": \"^15.0.0 || ^16.0.0\"\r\n   },\r\n   \"dependencies\": {\r\n+    \"@babel/preset-flow\": \"7.0.0-beta.54\",\r\n     \"fast-levenshtein\": \"^2.0.6\",\r\n     \"global\": \"^4.3.0\",\r\n     \"hoist-non-react-statics\": \"^2.5.0\",\r\n\r\n```\r\n\r\nWhen running `npm build` I  cannot get past the following error (haven't had a lot of time to investigate yet) but certainly, we might need to update a variety of things to properly handle the API changes. \r\n\r\n```\r\n[!] (babel plugin) Error: Cannot find module 'babel-plugin-external-helpers' from '/home/sam/src/github.com/gaearon/react-hot-loader'\r\n- Did you mean \"@babel/external-helpers\"?\r\nsrc/index.dev.js\r\nError: Cannot find module 'babel-plugin-external-helpers' from '/home/sam/src/github.com/gaearon/react-hot-loader'\r\n- Did you mean \"@babel/external-helpers\"?\r\n    at Function.module.exports [as sync] (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/resolve/lib/sync.js:43:15)\r\n    at resolveStandardizedName (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/files/plugins.js:101:31)\r\n    at resolvePlugin (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/files/plugins.js:54:10)\r\n    at loadPlugin (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/files/plugins.js:62:20)\r\n    at createDescriptor (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/config-descriptors.js:114:9)\r\n    at items.map (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/config-descriptors.js:69:50)\r\n    at Array.map (<anonymous>)\r\n    at createDescriptors (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/config-descriptors.js:69:29)\r\n    at createPluginDescriptors (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/config-descriptors.js:65:10)\r\n    at alias (/home/sam/src/github.com/gaearon/react-hot-loader/node_modules/@babel/core/lib/config/config-descriptors.js:57:49)\r\n\r\n```\r\n\r\nWould be really great if we could begin moving towards babel 7 support. I don't know what it would entail yet - and if all the deps have a working version for that, but certainly it'll only be more important so let me know what your thoughts are."},"comment":{"url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/comments/411939044","html_url":"https://github.com/gaearon/react-hot-loader/issues/1043#issuecomment-411939044","issue_url":"https://api.github.com/repos/gaearon/react-hot-loader/issues/1043","id":411939044,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTkzOTA0NA==","user":{"login":"theKashey","id":582410,"node_id":"MDQ6VXNlcjU4MjQxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/582410?v=4","gravatar_id":"","url":"https://api.github.com/users/theKashey","html_url":"https://github.com/theKashey","followers_url":"https://api.github.com/users/theKashey/followers","following_url":"https://api.github.com/users/theKashey/following{/other_user}","gists_url":"https://api.github.com/users/theKashey/gists{/gist_id}","starred_url":"https://api.github.com/users/theKashey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theKashey/subscriptions","organizations_url":"https://api.github.com/users/theKashey/orgs","repos_url":"https://api.github.com/users/theKashey/repos","events_url":"https://api.github.com/users/theKashey/events{/privacy}","received_events_url":"https://api.github.com/users/theKashey/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T00:29:12Z","updated_at":"2018-08-10T00:29:12Z","author_association":"COLLABORATOR","body":"Babel 7 rc just got released. Reopening the ticket."}}
{"actor":{"display_login":"theKashey"}}