{"action":"created","comment":{"url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments/200964042","pull_request_review_id":135371485,"id":200964042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDk2NDA0Mg==","diff_hunk":"@@ -52,19 +52,22 @@ define(['Modernizr', 'prefixes', 'createElement', 'testAllProps', 'addTest'], fu\n           var result = false;\n           var firstChild = document.body.firstElementChild || document.body.firstChild;\n \n+          /* Hyphenation is only applied when language is explicitly set and when respective dictionary\n+           * is available. See https://developer.mozilla.org/en-US/docs/Web/CSS/hyphens for details. */\n+          div.lang = 'en';","path":"feature-detects/css/hyphens.js","position":6,"original_position":6,"commit_id":"35fc2c51f2ba9f4a8c367886a7319d9c19501217","original_commit_id":"35fc2c51f2ba9f4a8c367886a7319d9c19501217","user":{"login":"rejas","id":1313547,"node_id":"MDQ6VXNlcjEzMTM1NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1313547?v=4","gravatar_id":"","url":"https://api.github.com/users/rejas","html_url":"https://github.com/rejas","followers_url":"https://api.github.com/users/rejas/followers","following_url":"https://api.github.com/users/rejas/following{/other_user}","gists_url":"https://api.github.com/users/rejas/gists{/gist_id}","starred_url":"https://api.github.com/users/rejas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rejas/subscriptions","organizations_url":"https://api.github.com/users/rejas/orgs","repos_url":"https://api.github.com/users/rejas/repos","events_url":"https://api.github.com/users/rejas/events{/privacy}","received_events_url":"https://api.github.com/users/rejas/received_events","type":"User","site_admin":false},"body":"good find. just for documentation purposes: does it fix any special issue (in this github repo or in your work)?","created_at":"2018-07-09T11:10:26Z","updated_at":"2018-07-09T11:10:30Z","html_url":"https://github.com/Modernizr/Modernizr/pull/2345#discussion_r200964042","pull_request_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments/200964042"},"html":{"href":"https://github.com/Modernizr/Modernizr/pull/2345#discussion_r200964042"},"pull_request":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345"}}},"pull_request":{"url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345","id":200021852,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDIxODUy","html_url":"https://github.com/Modernizr/Modernizr/pull/2345","diff_url":"https://github.com/Modernizr/Modernizr/pull/2345.diff","patch_url":"https://github.com/Modernizr/Modernizr/pull/2345.patch","issue_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/2345","number":2345,"state":"open","locked":false,"title":"Fixed csshypens detection on FireFox and Safari.","user":{"login":"anenviousguest","id":8439575,"node_id":"MDQ6VXNlcjg0Mzk1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8439575?v=4","gravatar_id":"","url":"https://api.github.com/users/anenviousguest","html_url":"https://github.com/anenviousguest","followers_url":"https://api.github.com/users/anenviousguest/followers","following_url":"https://api.github.com/users/anenviousguest/following{/other_user}","gists_url":"https://api.github.com/users/anenviousguest/gists{/gist_id}","starred_url":"https://api.github.com/users/anenviousguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anenviousguest/subscriptions","organizations_url":"https://api.github.com/users/anenviousguest/orgs","repos_url":"https://api.github.com/users/anenviousguest/repos","events_url":"https://api.github.com/users/anenviousguest/events{/privacy}","received_events_url":"https://api.github.com/users/anenviousguest/received_events","type":"User","site_admin":false},"body":"# `csshyphens` detection fix for FF and Safari\r\nThis is a split version of #1428 as requested by @rejas.\r\n\r\n- There was seemingly a typo in CSS property name (`text-justification` instead of correct [`text-justify`](https://developer.mozilla.org/en-US/docs/Web/CSS/text-justify)).\r\n- The hyphenation doesn't take effect unless the `lang` attribute is explicitly set, for this reason it was erroneously detected as not supported on FF and Safari, whereas it **is** actually supported.\r\n","created_at":"2018-07-09T08:11:25Z","updated_at":"2018-07-09T11:10:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa13dabcc73b52161f8e347fde16ad7a929f37e4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"patrickkettner","id":465414,"node_id":"MDQ6VXNlcjQ2NTQxNA==","avatar_url":"https://avatars1.githubusercontent.com/u/465414?v=4","gravatar_id":"","url":"https://api.github.com/users/patrickkettner","html_url":"https://github.com/patrickkettner","followers_url":"https://api.github.com/users/patrickkettner/followers","following_url":"https://api.github.com/users/patrickkettner/following{/other_user}","gists_url":"https://api.github.com/users/patrickkettner/gists{/gist_id}","starred_url":"https://api.github.com/users/patrickkettner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrickkettner/subscriptions","organizations_url":"https://api.github.com/users/patrickkettner/orgs","repos_url":"https://api.github.com/users/patrickkettner/repos","events_url":"https://api.github.com/users/patrickkettner/events{/privacy}","received_events_url":"https://api.github.com/users/patrickkettner/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345/commits","review_comments_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345/comments","review_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/2345/comments","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/35fc2c51f2ba9f4a8c367886a7319d9c19501217","head":{"label":"anenviousguest:ff-and-safari-hyphens","ref":"ff-and-safari-hyphens","sha":"35fc2c51f2ba9f4a8c367886a7319d9c19501217","user":{"login":"anenviousguest","id":8439575,"node_id":"MDQ6VXNlcjg0Mzk1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8439575?v=4","gravatar_id":"","url":"https://api.github.com/users/anenviousguest","html_url":"https://github.com/anenviousguest","followers_url":"https://api.github.com/users/anenviousguest/followers","following_url":"https://api.github.com/users/anenviousguest/following{/other_user}","gists_url":"https://api.github.com/users/anenviousguest/gists{/gist_id}","starred_url":"https://api.github.com/users/anenviousguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anenviousguest/subscriptions","organizations_url":"https://api.github.com/users/anenviousguest/orgs","repos_url":"https://api.github.com/users/anenviousguest/repos","events_url":"https://api.github.com/users/anenviousguest/events{/privacy}","received_events_url":"https://api.github.com/users/anenviousguest/received_events","type":"User","site_admin":false},"repo":{"id":23619595,"node_id":"MDEwOlJlcG9zaXRvcnkyMzYxOTU5NQ==","name":"Modernizr","full_name":"anenviousguest/Modernizr","owner":{"login":"anenviousguest","id":8439575,"node_id":"MDQ6VXNlcjg0Mzk1NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8439575?v=4","gravatar_id":"","url":"https://api.github.com/users/anenviousguest","html_url":"https://github.com/anenviousguest","followers_url":"https://api.github.com/users/anenviousguest/followers","following_url":"https://api.github.com/users/anenviousguest/following{/other_user}","gists_url":"https://api.github.com/users/anenviousguest/gists{/gist_id}","starred_url":"https://api.github.com/users/anenviousguest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anenviousguest/subscriptions","organizations_url":"https://api.github.com/users/anenviousguest/orgs","repos_url":"https://api.github.com/users/anenviousguest/repos","events_url":"https://api.github.com/users/anenviousguest/events{/privacy}","received_events_url":"https://api.github.com/users/anenviousguest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anenviousguest/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":true,"url":"https://api.github.com/repos/anenviousguest/Modernizr","forks_url":"https://api.github.com/repos/anenviousguest/Modernizr/forks","keys_url":"https://api.github.com/repos/anenviousguest/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anenviousguest/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anenviousguest/Modernizr/teams","hooks_url":"https://api.github.com/repos/anenviousguest/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/anenviousguest/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/anenviousguest/Modernizr/events","assignees_url":"https://api.github.com/repos/anenviousguest/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/anenviousguest/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/anenviousguest/Modernizr/tags","blobs_url":"https://api.github.com/repos/anenviousguest/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anenviousguest/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anenviousguest/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/anenviousguest/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anenviousguest/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/anenviousguest/Modernizr/languages","stargazers_url":"https://api.github.com/repos/anenviousguest/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/anenviousguest/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/anenviousguest/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/anenviousguest/Modernizr/subscription","commits_url":"https://api.github.com/repos/anenviousguest/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/anenviousguest/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/anenviousguest/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/anenviousguest/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/anenviousguest/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/anenviousguest/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anenviousguest/Modernizr/merges","archive_url":"https://api.github.com/repos/anenviousguest/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anenviousguest/Modernizr/downloads","issues_url":"https://api.github.com/repos/anenviousguest/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/anenviousguest/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/anenviousguest/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/anenviousguest/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anenviousguest/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/anenviousguest/Modernizr/releases{/id}","deployments_url":"https://api.github.com/repos/anenviousguest/Modernizr/deployments","created_at":"2014-09-03T12:38:10Z","updated_at":"2014-09-03T12:55:18Z","pushed_at":"2018-07-09T08:07:42Z","git_url":"git://github.com/anenviousguest/Modernizr.git","ssh_url":"git@github.com:anenviousguest/Modernizr.git","clone_url":"https://github.com/anenviousguest/Modernizr.git","svn_url":"https://github.com/anenviousguest/Modernizr","homepage":"http://modernizr.com","size":14131,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Modernizr:master","ref":"master","sha":"e15e3e15e6112f72fb82876506b9f0c0c78c0211","user":{"login":"Modernizr","id":131060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/131060?v=4","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"repo":{"id":317757,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc3NTc=","name":"Modernizr","full_name":"Modernizr/Modernizr","owner":{"login":"Modernizr","id":131060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/131060?v=4","gravatar_id":"","url":"https://api.github.com/users/Modernizr","html_url":"https://github.com/Modernizr","followers_url":"https://api.github.com/users/Modernizr/followers","following_url":"https://api.github.com/users/Modernizr/following{/other_user}","gists_url":"https://api.github.com/users/Modernizr/gists{/gist_id}","starred_url":"https://api.github.com/users/Modernizr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Modernizr/subscriptions","organizations_url":"https://api.github.com/users/Modernizr/orgs","repos_url":"https://api.github.com/users/Modernizr/repos","events_url":"https://api.github.com/users/Modernizr/events{/privacy}","received_events_url":"https://api.github.com/users/Modernizr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Modernizr/Modernizr","description":"Modernizr is a JavaScript library that detects HTML5 and CSS3 features in the user’s browser.","fork":false,"url":"https://api.github.com/repos/Modernizr/Modernizr","forks_url":"https://api.github.com/repos/Modernizr/Modernizr/forks","keys_url":"https://api.github.com/repos/Modernizr/Modernizr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Modernizr/Modernizr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Modernizr/Modernizr/teams","hooks_url":"https://api.github.com/repos/Modernizr/Modernizr/hooks","issue_events_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/events{/number}","events_url":"https://api.github.com/repos/Modernizr/Modernizr/events","assignees_url":"https://api.github.com/repos/Modernizr/Modernizr/assignees{/user}","branches_url":"https://api.github.com/repos/Modernizr/Modernizr/branches{/branch}","tags_url":"https://api.github.com/repos/Modernizr/Modernizr/tags","blobs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Modernizr/Modernizr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Modernizr/Modernizr/git/refs{/sha}","trees_url":"https://api.github.com/repos/Modernizr/Modernizr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Modernizr/Modernizr/statuses/{sha}","languages_url":"https://api.github.com/repos/Modernizr/Modernizr/languages","stargazers_url":"https://api.github.com/repos/Modernizr/Modernizr/stargazers","contributors_url":"https://api.github.com/repos/Modernizr/Modernizr/contributors","subscribers_url":"https://api.github.com/repos/Modernizr/Modernizr/subscribers","subscription_url":"https://api.github.com/repos/Modernizr/Modernizr/subscription","commits_url":"https://api.github.com/repos/Modernizr/Modernizr/commits{/sha}","git_commits_url":"https://api.github.com/repos/Modernizr/Modernizr/git/commits{/sha}","comments_url":"https://api.github.com/repos/Modernizr/Modernizr/comments{/number}","issue_comment_url":"https://api.github.com/repos/Modernizr/Modernizr/issues/comments{/number}","contents_url":"https://api.github.com/repos/Modernizr/Modernizr/contents/{+path}","compare_url":"https://api.github.com/repos/Modernizr/Modernizr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Modernizr/Modernizr/merges","archive_url":"https://api.github.com/repos/Modernizr/Modernizr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Modernizr/Modernizr/downloads","issues_url":"https://api.github.com/repos/Modernizr/Modernizr/issues{/number}","pulls_url":"https://api.github.com/repos/Modernizr/Modernizr/pulls{/number}","milestones_url":"https://api.github.com/repos/Modernizr/Modernizr/milestones{/number}","notifications_url":"https://api.github.com/repos/Modernizr/Modernizr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Modernizr/Modernizr/labels{/name}","releases_url":"https://api.github.com/repos/Modernizr/Modernizr/releases{/id}","deployments_url":"https://api.github.com/repos/Modernizr/Modernizr/deployments","created_at":"2009-09-25T20:13:23Z","updated_at":"2018-07-09T10:01:06Z","pushed_at":"2018-07-09T11:07:47Z","git_url":"git://github.com/Modernizr/Modernizr.git","ssh_url":"git@github.com:Modernizr/Modernizr.git","clone_url":"https://github.com/Modernizr/Modernizr.git","svn_url":"https://github.com/Modernizr/Modernizr","homepage":"https://modernizr.com","size":35989,"stargazers_count":22725,"watchers_count":22725,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2989,"mirror_url":null,"archived":false,"open_issues_count":182,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2989,"open_issues":182,"watchers":22725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345"},"html":{"href":"https://github.com/Modernizr/Modernizr/pull/2345"},"issue":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/2345"},"comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/issues/2345/comments"},"review_comments":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345/comments"},"review_comment":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Modernizr/Modernizr/pulls/2345/commits"},"statuses":{"href":"https://api.github.com/repos/Modernizr/Modernizr/statuses/35fc2c51f2ba9f4a8c367886a7319d9c19501217"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rejas"}}