{"action":"closed","number":331,"pull_request":{"url":"https://api.github.com/repos/kaltura/playkit-js/pulls/331","id":240214363,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjE0MzYz","html_url":"https://github.com/kaltura/playkit-js/pull/331","diff_url":"https://github.com/kaltura/playkit-js/pull/331.diff","patch_url":"https://github.com/kaltura/playkit-js/pull/331.patch","issue_url":"https://api.github.com/repos/kaltura/playkit-js/issues/331","number":331,"state":"closed","locked":false,"title":"fix(FEC-8779): change media does not work if external caption is shown","user":{"login":"odedhutzler","id":31587052,"node_id":"MDQ6VXNlcjMxNTg3MDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"body":"### Description of the Changes\r\n\r\nchange the order we call the functions\r\nprotect calling to cues so we won't call it on undefined.\r\n\r\n### CheckLists\r\n\r\n- [x] changes have been done against master branch, and PR does not conflict\r\n- [ ] new unit / functional tests have been added (whenever applicable)\r\n- [ ] test are passing in local environment\r\n- [ ] Travis tests are passing (or test results are not worse than on master branch :))\r\n- [ ] Docs have been updated\r\n","created_at":"2018-12-20T15:44:44Z","updated_at":"2018-12-20T15:57:42Z","closed_at":"2018-12-20T15:57:41Z","merged_at":"2018-12-20T15:57:41Z","merge_commit_sha":"2b487726c74ee07fc21a307528a14782cfb03b0d","assignee":{"login":"odedhutzler","id":31587052,"node_id":"MDQ6VXNlcjMxNTg3MDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"assignees":[{"login":"odedhutzler","id":31587052,"node_id":"MDQ6VXNlcjMxNTg3MDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":545260082,"node_id":"MDU6TGFiZWw1NDUyNjAwODI=","url":"https://api.github.com/repos/kaltura/playkit-js/labels/Priority:%20High","name":"Priority: High","color":"e11d21","default":false},{"id":528473177,"node_id":"MDU6TGFiZWw1Mjg0NzMxNzc=","url":"https://api.github.com/repos/kaltura/playkit-js/labels/Type:%20Bug","name":"Type: Bug","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/331/commits","review_comments_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/331/comments","review_comment_url":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/issues/331/comments","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/3a62bedb048bbb5e61d77f77ecafd1d4340cc19b","head":{"label":"kaltura:FEC-8779","ref":"FEC-8779","sha":"3a62bedb048bbb5e61d77f77ecafd1d4340cc19b","user":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQwNzYyOQ==","name":"playkit-js","full_name":"kaltura/playkit-js","private":false,"owner":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kaltura/playkit-js","description":"State of the Art HTML5 Player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2018-12-16T15:09:03Z","pushed_at":"2018-12-20T15:57:41Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":"","size":49851,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":12,"open_issues":9,"watchers":27,"default_branch":"master"}},"base":{"label":"kaltura:master","ref":"master","sha":"2695cb4a848c259e4b448c09bed68011db18ee2a","user":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"repo":{"id":80407629,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQwNzYyOQ==","name":"playkit-js","full_name":"kaltura/playkit-js","private":false,"owner":{"login":"kaltura","id":319096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTA5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/319096?v=4","gravatar_id":"","url":"https://api.github.com/users/kaltura","html_url":"https://github.com/kaltura","followers_url":"https://api.github.com/users/kaltura/followers","following_url":"https://api.github.com/users/kaltura/following{/other_user}","gists_url":"https://api.github.com/users/kaltura/gists{/gist_id}","starred_url":"https://api.github.com/users/kaltura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaltura/subscriptions","organizations_url":"https://api.github.com/users/kaltura/orgs","repos_url":"https://api.github.com/users/kaltura/repos","events_url":"https://api.github.com/users/kaltura/events{/privacy}","received_events_url":"https://api.github.com/users/kaltura/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kaltura/playkit-js","description":"State of the Art HTML5 Player","fork":false,"url":"https://api.github.com/repos/kaltura/playkit-js","forks_url":"https://api.github.com/repos/kaltura/playkit-js/forks","keys_url":"https://api.github.com/repos/kaltura/playkit-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaltura/playkit-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaltura/playkit-js/teams","hooks_url":"https://api.github.com/repos/kaltura/playkit-js/hooks","issue_events_url":"https://api.github.com/repos/kaltura/playkit-js/issues/events{/number}","events_url":"https://api.github.com/repos/kaltura/playkit-js/events","assignees_url":"https://api.github.com/repos/kaltura/playkit-js/assignees{/user}","branches_url":"https://api.github.com/repos/kaltura/playkit-js/branches{/branch}","tags_url":"https://api.github.com/repos/kaltura/playkit-js/tags","blobs_url":"https://api.github.com/repos/kaltura/playkit-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaltura/playkit-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaltura/playkit-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaltura/playkit-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaltura/playkit-js/statuses/{sha}","languages_url":"https://api.github.com/repos/kaltura/playkit-js/languages","stargazers_url":"https://api.github.com/repos/kaltura/playkit-js/stargazers","contributors_url":"https://api.github.com/repos/kaltura/playkit-js/contributors","subscribers_url":"https://api.github.com/repos/kaltura/playkit-js/subscribers","subscription_url":"https://api.github.com/repos/kaltura/playkit-js/subscription","commits_url":"https://api.github.com/repos/kaltura/playkit-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaltura/playkit-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaltura/playkit-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaltura/playkit-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaltura/playkit-js/contents/{+path}","compare_url":"https://api.github.com/repos/kaltura/playkit-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaltura/playkit-js/merges","archive_url":"https://api.github.com/repos/kaltura/playkit-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaltura/playkit-js/downloads","issues_url":"https://api.github.com/repos/kaltura/playkit-js/issues{/number}","pulls_url":"https://api.github.com/repos/kaltura/playkit-js/pulls{/number}","milestones_url":"https://api.github.com/repos/kaltura/playkit-js/milestones{/number}","notifications_url":"https://api.github.com/repos/kaltura/playkit-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaltura/playkit-js/labels{/name}","releases_url":"https://api.github.com/repos/kaltura/playkit-js/releases{/id}","deployments_url":"https://api.github.com/repos/kaltura/playkit-js/deployments","created_at":"2017-01-30T09:22:52Z","updated_at":"2018-12-16T15:09:03Z","pushed_at":"2018-12-20T15:57:41Z","git_url":"git://github.com/kaltura/playkit-js.git","ssh_url":"git@github.com:kaltura/playkit-js.git","clone_url":"https://github.com/kaltura/playkit-js.git","svn_url":"https://github.com/kaltura/playkit-js","homepage":"","size":49851,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":12,"open_issues":9,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/331"},"html":{"href":"https://github.com/kaltura/playkit-js/pull/331"},"issue":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/331"},"comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kaltura/playkit-js/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/kaltura/playkit-js/statuses/3a62bedb048bbb5e61d77f77ecafd1d4340cc19b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"odedhutzler","id":31587052,"node_id":"MDQ6VXNlcjMxNTg3MDUy","avatar_url":"https://avatars2.githubusercontent.com/u/31587052?v=4","gravatar_id":"","url":"https://api.github.com/users/odedhutzler","html_url":"https://github.com/odedhutzler","followers_url":"https://api.github.com/users/odedhutzler/followers","following_url":"https://api.github.com/users/odedhutzler/following{/other_user}","gists_url":"https://api.github.com/users/odedhutzler/gists{/gist_id}","starred_url":"https://api.github.com/users/odedhutzler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odedhutzler/subscriptions","organizations_url":"https://api.github.com/users/odedhutzler/orgs","repos_url":"https://api.github.com/users/odedhutzler/repos","events_url":"https://api.github.com/users/odedhutzler/events{/privacy}","received_events_url":"https://api.github.com/users/odedhutzler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"odedhutzler"}}