{"action":"closed","number":20,"pull_request":{"url":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/20","id":190928338,"html_url":"https://github.com/tom-corwin/LibUISharp/pull/20","diff_url":"https://github.com/tom-corwin/LibUISharp/pull/20.diff","patch_url":"https://github.com/tom-corwin/LibUISharp/pull/20.patch","issue_url":"https://api.github.com/repos/tom-corwin/LibUISharp/issues/20","number":20,"state":"closed","locked":false,"title":"Suggestion to avoid null strings for default values to avoid crashes on MacOS","user":{"login":"scriptam","id":1056438,"avatar_url":"https://avatars3.githubusercontent.com/u/1056438?v=4","gravatar_id":"","url":"https://api.github.com/users/scriptam","html_url":"https://github.com/scriptam","followers_url":"https://api.github.com/users/scriptam/followers","following_url":"https://api.github.com/users/scriptam/following{/other_user}","gists_url":"https://api.github.com/users/scriptam/gists{/gist_id}","starred_url":"https://api.github.com/users/scriptam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scriptam/subscriptions","organizations_url":"https://api.github.com/users/scriptam/orgs","repos_url":"https://api.github.com/users/scriptam/repos","events_url":"https://api.github.com/users/scriptam/events{/privacy}","received_events_url":"https://api.github.com/users/scriptam/received_events","type":"User","site_admin":false},"body":"A minor guard against default null string values (and corresponding 0 value IntPtr) for common use cases. Since some parameters like \"description\" is optional on the method, it should not lead to a crash but be substituted with an empty string instead.\r\nA global fix may be possible to patch within the ToLibuiString, however it will likely lead to side effects, as there may be times where string == null is indeed needed to equate to IntPtr == 0. ","created_at":"2018-05-28T13:15:50Z","updated_at":"2018-05-28T15:36:57Z","closed_at":"2018-05-28T15:36:57Z","merged_at":"2018-05-28T15:36:57Z","merge_commit_sha":"9b8e274035cdbc1df61c854c9724759f571ef034","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/20/commits","review_comments_url":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/20/comments","review_comment_url":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tom-corwin/LibUISharp/issues/20/comments","statuses_url":"https://api.github.com/repos/tom-corwin/LibUISharp/statuses/e84c422f158da5cc33660b82d580cb2a5d8239db","head":{"label":"scriptam:master","ref":"master","sha":"e84c422f158da5cc33660b82d580cb2a5d8239db","user":{"login":"scriptam","id":1056438,"avatar_url":"https://avatars3.githubusercontent.com/u/1056438?v=4","gravatar_id":"","url":"https://api.github.com/users/scriptam","html_url":"https://github.com/scriptam","followers_url":"https://api.github.com/users/scriptam/followers","following_url":"https://api.github.com/users/scriptam/following{/other_user}","gists_url":"https://api.github.com/users/scriptam/gists{/gist_id}","starred_url":"https://api.github.com/users/scriptam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scriptam/subscriptions","organizations_url":"https://api.github.com/users/scriptam/orgs","repos_url":"https://api.github.com/users/scriptam/repos","events_url":"https://api.github.com/users/scriptam/events{/privacy}","received_events_url":"https://api.github.com/users/scriptam/received_events","type":"User","site_admin":false},"repo":{"id":134698745,"name":"LibUISharp","full_name":"scriptam/LibUISharp","owner":{"login":"scriptam","id":1056438,"avatar_url":"https://avatars3.githubusercontent.com/u/1056438?v=4","gravatar_id":"","url":"https://api.github.com/users/scriptam","html_url":"https://github.com/scriptam","followers_url":"https://api.github.com/users/scriptam/followers","following_url":"https://api.github.com/users/scriptam/following{/other_user}","gists_url":"https://api.github.com/users/scriptam/gists{/gist_id}","starred_url":"https://api.github.com/users/scriptam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scriptam/subscriptions","organizations_url":"https://api.github.com/users/scriptam/orgs","repos_url":"https://api.github.com/users/scriptam/repos","events_url":"https://api.github.com/users/scriptam/events{/privacy}","received_events_url":"https://api.github.com/users/scriptam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scriptam/LibUISharp","description":"C# bindings for https://github.com/andlabs/libui targeting .NET Standard, and soon, .NET Framework and Mono.","fork":true,"url":"https://api.github.com/repos/scriptam/LibUISharp","forks_url":"https://api.github.com/repos/scriptam/LibUISharp/forks","keys_url":"https://api.github.com/repos/scriptam/LibUISharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scriptam/LibUISharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scriptam/LibUISharp/teams","hooks_url":"https://api.github.com/repos/scriptam/LibUISharp/hooks","issue_events_url":"https://api.github.com/repos/scriptam/LibUISharp/issues/events{/number}","events_url":"https://api.github.com/repos/scriptam/LibUISharp/events","assignees_url":"https://api.github.com/repos/scriptam/LibUISharp/assignees{/user}","branches_url":"https://api.github.com/repos/scriptam/LibUISharp/branches{/branch}","tags_url":"https://api.github.com/repos/scriptam/LibUISharp/tags","blobs_url":"https://api.github.com/repos/scriptam/LibUISharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scriptam/LibUISharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scriptam/LibUISharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/scriptam/LibUISharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scriptam/LibUISharp/statuses/{sha}","languages_url":"https://api.github.com/repos/scriptam/LibUISharp/languages","stargazers_url":"https://api.github.com/repos/scriptam/LibUISharp/stargazers","contributors_url":"https://api.github.com/repos/scriptam/LibUISharp/contributors","subscribers_url":"https://api.github.com/repos/scriptam/LibUISharp/subscribers","subscription_url":"https://api.github.com/repos/scriptam/LibUISharp/subscription","commits_url":"https://api.github.com/repos/scriptam/LibUISharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/scriptam/LibUISharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/scriptam/LibUISharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/scriptam/LibUISharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/scriptam/LibUISharp/contents/{+path}","compare_url":"https://api.github.com/repos/scriptam/LibUISharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scriptam/LibUISharp/merges","archive_url":"https://api.github.com/repos/scriptam/LibUISharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scriptam/LibUISharp/downloads","issues_url":"https://api.github.com/repos/scriptam/LibUISharp/issues{/number}","pulls_url":"https://api.github.com/repos/scriptam/LibUISharp/pulls{/number}","milestones_url":"https://api.github.com/repos/scriptam/LibUISharp/milestones{/number}","notifications_url":"https://api.github.com/repos/scriptam/LibUISharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scriptam/LibUISharp/labels{/name}","releases_url":"https://api.github.com/repos/scriptam/LibUISharp/releases{/id}","deployments_url":"https://api.github.com/repos/scriptam/LibUISharp/deployments","created_at":"2018-05-24T10:20:21Z","updated_at":"2018-05-28T13:09:09Z","pushed_at":"2018-05-28T13:09:08Z","git_url":"git://github.com/scriptam/LibUISharp.git","ssh_url":"git@github.com:scriptam/LibUISharp.git","clone_url":"https://github.com/scriptam/LibUISharp.git","svn_url":"https://github.com/scriptam/LibUISharp","homepage":"","size":734,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tom-corwin:master","ref":"master","sha":"2f0a55e6a1536b1f22c9462be2b7c3336c7d1038","user":{"login":"tom-corwin","id":20215001,"avatar_url":"https://avatars1.githubusercontent.com/u/20215001?v=4","gravatar_id":"","url":"https://api.github.com/users/tom-corwin","html_url":"https://github.com/tom-corwin","followers_url":"https://api.github.com/users/tom-corwin/followers","following_url":"https://api.github.com/users/tom-corwin/following{/other_user}","gists_url":"https://api.github.com/users/tom-corwin/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-corwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-corwin/subscriptions","organizations_url":"https://api.github.com/users/tom-corwin/orgs","repos_url":"https://api.github.com/users/tom-corwin/repos","events_url":"https://api.github.com/users/tom-corwin/events{/privacy}","received_events_url":"https://api.github.com/users/tom-corwin/received_events","type":"User","site_admin":false},"repo":{"id":118301414,"name":"LibUISharp","full_name":"tom-corwin/LibUISharp","owner":{"login":"tom-corwin","id":20215001,"avatar_url":"https://avatars1.githubusercontent.com/u/20215001?v=4","gravatar_id":"","url":"https://api.github.com/users/tom-corwin","html_url":"https://github.com/tom-corwin","followers_url":"https://api.github.com/users/tom-corwin/followers","following_url":"https://api.github.com/users/tom-corwin/following{/other_user}","gists_url":"https://api.github.com/users/tom-corwin/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-corwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-corwin/subscriptions","organizations_url":"https://api.github.com/users/tom-corwin/orgs","repos_url":"https://api.github.com/users/tom-corwin/repos","events_url":"https://api.github.com/users/tom-corwin/events{/privacy}","received_events_url":"https://api.github.com/users/tom-corwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tom-corwin/LibUISharp","description":"C# bindings for https://github.com/andlabs/libui targeting .NET Standard, and soon, .NET Framework and Mono.","fork":false,"url":"https://api.github.com/repos/tom-corwin/LibUISharp","forks_url":"https://api.github.com/repos/tom-corwin/LibUISharp/forks","keys_url":"https://api.github.com/repos/tom-corwin/LibUISharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tom-corwin/LibUISharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tom-corwin/LibUISharp/teams","hooks_url":"https://api.github.com/repos/tom-corwin/LibUISharp/hooks","issue_events_url":"https://api.github.com/repos/tom-corwin/LibUISharp/issues/events{/number}","events_url":"https://api.github.com/repos/tom-corwin/LibUISharp/events","assignees_url":"https://api.github.com/repos/tom-corwin/LibUISharp/assignees{/user}","branches_url":"https://api.github.com/repos/tom-corwin/LibUISharp/branches{/branch}","tags_url":"https://api.github.com/repos/tom-corwin/LibUISharp/tags","blobs_url":"https://api.github.com/repos/tom-corwin/LibUISharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tom-corwin/LibUISharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tom-corwin/LibUISharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tom-corwin/LibUISharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tom-corwin/LibUISharp/statuses/{sha}","languages_url":"https://api.github.com/repos/tom-corwin/LibUISharp/languages","stargazers_url":"https://api.github.com/repos/tom-corwin/LibUISharp/stargazers","contributors_url":"https://api.github.com/repos/tom-corwin/LibUISharp/contributors","subscribers_url":"https://api.github.com/repos/tom-corwin/LibUISharp/subscribers","subscription_url":"https://api.github.com/repos/tom-corwin/LibUISharp/subscription","commits_url":"https://api.github.com/repos/tom-corwin/LibUISharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tom-corwin/LibUISharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tom-corwin/LibUISharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tom-corwin/LibUISharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tom-corwin/LibUISharp/contents/{+path}","compare_url":"https://api.github.com/repos/tom-corwin/LibUISharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tom-corwin/LibUISharp/merges","archive_url":"https://api.github.com/repos/tom-corwin/LibUISharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tom-corwin/LibUISharp/downloads","issues_url":"https://api.github.com/repos/tom-corwin/LibUISharp/issues{/number}","pulls_url":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls{/number}","milestones_url":"https://api.github.com/repos/tom-corwin/LibUISharp/milestones{/number}","notifications_url":"https://api.github.com/repos/tom-corwin/LibUISharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tom-corwin/LibUISharp/labels{/name}","releases_url":"https://api.github.com/repos/tom-corwin/LibUISharp/releases{/id}","deployments_url":"https://api.github.com/repos/tom-corwin/LibUISharp/deployments","created_at":"2018-01-21T03:33:46Z","updated_at":"2018-05-28T03:11:21Z","pushed_at":"2018-05-28T15:36:57Z","git_url":"git://github.com/tom-corwin/LibUISharp.git","ssh_url":"git@github.com:tom-corwin/LibUISharp.git","clone_url":"https://github.com/tom-corwin/LibUISharp.git","svn_url":"https://github.com/tom-corwin/LibUISharp","homepage":"","size":790,"stargazers_count":18,"watchers_count":18,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":8,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/20"},"html":{"href":"https://github.com/tom-corwin/LibUISharp/pull/20"},"issue":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/issues/20"},"comments":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/tom-corwin/LibUISharp/statuses/e84c422f158da5cc33660b82d580cb2a5d8239db"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tom-corwin","id":20215001,"avatar_url":"https://avatars1.githubusercontent.com/u/20215001?v=4","gravatar_id":"","url":"https://api.github.com/users/tom-corwin","html_url":"https://github.com/tom-corwin","followers_url":"https://api.github.com/users/tom-corwin/followers","following_url":"https://api.github.com/users/tom-corwin/following{/other_user}","gists_url":"https://api.github.com/users/tom-corwin/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-corwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-corwin/subscriptions","organizations_url":"https://api.github.com/users/tom-corwin/orgs","repos_url":"https://api.github.com/users/tom-corwin/repos","events_url":"https://api.github.com/users/tom-corwin/events{/privacy}","received_events_url":"https://api.github.com/users/tom-corwin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"tom-corwin"}}