{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/186724164","pull_request_review_id":118356766,"id":186724164,"diff_hunk":"@@ -1504,16 +1553,33 @@ def transmute_cols(self, **named_exprs) -> 'MatrixTable':\n         Returns\n         -------\n         :class:`.MatrixTable`\n-            Annotated matrix table.\n         \"\"\"\n-        raise NotImplementedError()\n+        named_exprs = {k: to_expr(v) for k, v in named_exprs.items()}\n+        fields_referenced = set()\n+        for k, v in named_exprs.items():\n+            check_collisions(self._fields, k, self._col_indices)","path":"python/hail/matrixtable.py","position":113,"original_position":113,"commit_id":"475a7ac23174b96cc22da15d29c3d2cb8af141f0","original_commit_id":"475a7ac23174b96cc22da15d29c3d2cb8af141f0","user":{"login":"jigold","id":1693348,"avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"body":"I think it might be good to add a function that returns the fields referenced and that takes an index as the parameter. That way you can reduce the amount of duplicated code between the 5 methods between MT and Table.","created_at":"2018-05-08T13:22:26Z","updated_at":"2018-05-08T13:28:28Z","html_url":"https://github.com/hail-is/hail/pull/3526#discussion_r186724164","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/3526","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/186724164"},"html":{"href":"https://github.com/hail-is/hail/pull/3526#discussion_r186724164"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3526"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/3526","id":186460990,"html_url":"https://github.com/hail-is/hail/pull/3526","diff_url":"https://github.com/hail-is/hail/pull/3526.diff","patch_url":"https://github.com/hail-is/hail/pull/3526.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/3526","number":3526,"state":"open","locked":false,"title":"Implement the four MatrixTable transmute methods","user":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-07T20:50:56Z","updated_at":"2018-05-08T13:28:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9f125a19361990a830dbeb8e16e502c39d97b5c","assignee":{"login":"jigold","id":1693348,"avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false},"assignees":[{"login":"jigold","id":1693348,"avatar_url":"https://avatars2.githubusercontent.com/u/1693348?v=4","gravatar_id":"","url":"https://api.github.com/users/jigold","html_url":"https://github.com/jigold","followers_url":"https://api.github.com/users/jigold/followers","following_url":"https://api.github.com/users/jigold/following{/other_user}","gists_url":"https://api.github.com/users/jigold/gists{/gist_id}","starred_url":"https://api.github.com/users/jigold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jigold/subscriptions","organizations_url":"https://api.github.com/users/jigold/orgs","repos_url":"https://api.github.com/users/jigold/repos","events_url":"https://api.github.com/users/jigold/events{/privacy}","received_events_url":"https://api.github.com/users/jigold/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/3526/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/3526/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/3526/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/475a7ac23174b96cc22da15d29c3d2cb8af141f0","head":{"label":"tpoterba:implement-transmute","ref":"implement-transmute","sha":"475a7ac23174b96cc22da15d29c3d2cb8af141f0","user":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"repo":{"id":64860564,"name":"hail","full_name":"tpoterba/hail","owner":{"login":"tpoterba","id":10562794,"avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tpoterba/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/tpoterba/hail","forks_url":"https://api.github.com/repos/tpoterba/hail/forks","keys_url":"https://api.github.com/repos/tpoterba/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpoterba/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpoterba/hail/teams","hooks_url":"https://api.github.com/repos/tpoterba/hail/hooks","issue_events_url":"https://api.github.com/repos/tpoterba/hail/issues/events{/number}","events_url":"https://api.github.com/repos/tpoterba/hail/events","assignees_url":"https://api.github.com/repos/tpoterba/hail/assignees{/user}","branches_url":"https://api.github.com/repos/tpoterba/hail/branches{/branch}","tags_url":"https://api.github.com/repos/tpoterba/hail/tags","blobs_url":"https://api.github.com/repos/tpoterba/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpoterba/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpoterba/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpoterba/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpoterba/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/tpoterba/hail/languages","stargazers_url":"https://api.github.com/repos/tpoterba/hail/stargazers","contributors_url":"https://api.github.com/repos/tpoterba/hail/contributors","subscribers_url":"https://api.github.com/repos/tpoterba/hail/subscribers","subscription_url":"https://api.github.com/repos/tpoterba/hail/subscription","commits_url":"https://api.github.com/repos/tpoterba/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpoterba/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpoterba/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpoterba/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpoterba/hail/contents/{+path}","compare_url":"https://api.github.com/repos/tpoterba/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpoterba/hail/merges","archive_url":"https://api.github.com/repos/tpoterba/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpoterba/hail/downloads","issues_url":"https://api.github.com/repos/tpoterba/hail/issues{/number}","pulls_url":"https://api.github.com/repos/tpoterba/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/tpoterba/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/tpoterba/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpoterba/hail/labels{/name}","releases_url":"https://api.github.com/repos/tpoterba/hail/releases{/id}","deployments_url":"https://api.github.com/repos/tpoterba/hail/deployments","created_at":"2016-08-03T16:15:03Z","updated_at":"2016-08-03T16:15:05Z","pushed_at":"2018-05-08T10:19:00Z","git_url":"git://github.com/tpoterba/hail.git","ssh_url":"git@github.com:tpoterba/hail.git","clone_url":"https://github.com/tpoterba/hail.git","svn_url":"https://github.com/tpoterba/hail","homepage":"","size":36766,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"b0c58139e8a66faa99b82df4b765e26fa6352a55","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-05-08T13:18:32Z","pushed_at":"2018-05-08T13:18:28Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":34968,"stargazers_count":318,"watchers_count":318,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":145,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":97,"open_issues":145,"watchers":318,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3526"},"html":{"href":"https://github.com/hail-is/hail/pull/3526"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/3526"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/3526/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3526/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/3526/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/475a7ac23174b96cc22da15d29c3d2cb8af141f0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jigold"}}