{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/196005337","pull_request_review_id":129474202,"id":196005337,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjAwNTMzNw==","diff_hunk":"@@ -2181,13 +2182,41 @@ TEST_F(SetAccountDetailTest, InValidWhenOtherCreator) {\n  * @when creator is setting details to their account\n  * @then successfully execute the command\n  */\n-TEST_F(SetAccountDetailTest, ValidWhenHasPermissions) {\n+TEST_F(SetAccountDetailTest, ValidWhenHasRolePermission) {\n   // TODO 2018-04-20 Alexey Chernyshov - IR-1276 - rework with CommandBuilder\n   command = buildCommand(\n       TestTransactionBuilder().setAccountDetail(kAccountId, kKey, kValue));\n   set_aacount_detail =","path":"test/module/irohad/execution/command_validate_execute_test.cpp","position":56,"original_position":56,"commit_id":"33666b554cf7bd10cf8384e6403ccbffba9228d6","original_commit_id":"33666b554cf7bd10cf8384e6403ccbffba9228d6","user":{"login":"igor-egorov","id":36847043,"node_id":"MDQ6VXNlcjM2ODQ3MDQz","avatar_url":"https://avatars0.githubusercontent.com/u/36847043?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-egorov","html_url":"https://github.com/igor-egorov","followers_url":"https://api.github.com/users/igor-egorov/followers","following_url":"https://api.github.com/users/igor-egorov/following{/other_user}","gists_url":"https://api.github.com/users/igor-egorov/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-egorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-egorov/subscriptions","organizations_url":"https://api.github.com/users/igor-egorov/orgs","repos_url":"https://api.github.com/users/igor-egorov/repos","events_url":"https://api.github.com/users/igor-egorov/events{/privacy}","received_events_url":"https://api.github.com/users/igor-egorov/received_events","type":"User","site_admin":false},"body":"Can we fix the typo?) `set_aacount_detail` -> `set_account_detail` (since the variable was touched by the pr)","created_at":"2018-06-18T08:53:30Z","updated_at":"2018-06-18T08:56:46Z","html_url":"https://github.com/hyperledger/iroha/pull/1452#discussion_r196005337","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1452","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/196005337"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1452#discussion_r196005337"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1452"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1452","id":194113048,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTEzMDQ4","html_url":"https://github.com/hyperledger/iroha/pull/1452","diff_url":"https://github.com/hyperledger/iroha/pull/1452.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1452.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1452","number":1452,"state":"open","locked":false,"title":"Fix bugs related to SetAccountDetail","user":{"login":"l4l","id":5658339,"node_id":"MDQ6VXNlcjU2NTgzMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/5658339?v=4","gravatar_id":"","url":"https://api.github.com/users/l4l","html_url":"https://github.com/l4l","followers_url":"https://api.github.com/users/l4l/followers","following_url":"https://api.github.com/users/l4l/following{/other_user}","gists_url":"https://api.github.com/users/l4l/gists{/gist_id}","starred_url":"https://api.github.com/users/l4l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l4l/subscriptions","organizations_url":"https://api.github.com/users/l4l/orgs","repos_url":"https://api.github.com/users/l4l/repos","events_url":"https://api.github.com/users/l4l/events{/privacy}","received_events_url":"https://api.github.com/users/l4l/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n\r\nMakes a required fixes so that following tests accepted:\r\n- SetAccountDetail on itself can be set w/o any perm\r\n\r\n### Benefits\r\n\r\nLess bugs, more coverage\r\n\r\n### Possible Drawbacks \r\n\r\nNone\r\n","created_at":"2018-06-11T21:49:37Z","updated_at":"2018-06-18T08:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1689c0de35a4aec7d416603f1546b8bd533c14a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":765063496,"node_id":"MDU6TGFiZWw3NjUwNjM0OTY=","url":"https://api.github.com/repos/hyperledger/iroha/labels/bug","name":"bug","color":"ee3f46","default":true},{"id":899696018,"node_id":"MDU6TGFiZWw4OTk2OTYwMTg=","url":"https://api.github.com/repos/hyperledger/iroha/labels/command","name":"command","color":"d582e5","default":false},{"id":684699993,"node_id":"MDU6TGFiZWw2ODQ2OTk5OTM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/needs-review","name":"needs-review","color":"f9d0c4","default":false},{"id":878215203,"node_id":"MDU6TGFiZWw4NzgyMTUyMDM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/tests","name":"tests","color":"69e075","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1452/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1452/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1452/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/33666b554cf7bd10cf8384e6403ccbffba9228d6","head":{"label":"hyperledger:fix/set_detail","ref":"fix/set_detail","sha":"33666b554cf7bd10cf8384e6403ccbffba9228d6","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-06-17T19:26:33Z","pushed_at":"2018-06-18T08:27:54Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":48729,"stargazers_count":819,"watchers_count":819,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":256,"open_issues":48,"watchers":819,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"fc742db1b817dc93d916e0e4fe843c46ac6f2631","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-06-17T19:26:33Z","pushed_at":"2018-06-18T08:27:54Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":48729,"stargazers_count":819,"watchers_count":819,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":256,"open_issues":48,"watchers":819,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1452"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1452"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1452"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1452/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1452/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1452/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/33666b554cf7bd10cf8384e6403ccbffba9228d6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"igor-egorov"}}