{"action":"created","issue":{"url":"https://api.github.com/repos/flutter/flutter/issues/18649","repository_url":"https://api.github.com/repos/flutter/flutter","labels_url":"https://api.github.com/repos/flutter/flutter/issues/18649/labels{/name}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/18649/comments","events_url":"https://api.github.com/repos/flutter/flutter/issues/18649/events","html_url":"https://github.com/flutter/flutter/pull/18649","id":334245073,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MjY4ODQx","number":18649,"title":"make crash server URL customizable from environment","user":{"login":"yjbanov","id":211513,"node_id":"MDQ6VXNlcjIxMTUxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-20T20:52:21Z","updated_at":"2018-06-20T22:17:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/18649","html_url":"https://github.com/flutter/flutter/pull/18649","diff_url":"https://github.com/flutter/flutter/pull/18649.diff","patch_url":"https://github.com/flutter/flutter/pull/18649.patch"},"body":"Introduce `FLUTTER_CRASH_SERVER_BASE_URL` environment variable that can be used to override the default server for crash reports in Flutter Tools.\r\n\r\nSee this discussion: https://github.com/flutter/flutter/issues/15646#issuecomment-398801255\r\n\r\n/cc @tvolkert @liyuqian "},"comment":{"url":"https://api.github.com/repos/flutter/flutter/issues/comments/398915357","html_url":"https://github.com/flutter/flutter/pull/18649#issuecomment-398915357","issue_url":"https://api.github.com/repos/flutter/flutter/issues/18649","id":398915357,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODkxNTM1Nw==","user":{"login":"yjbanov","id":211513,"node_id":"MDQ6VXNlcjIxMTUxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/211513?v=4","gravatar_id":"","url":"https://api.github.com/users/yjbanov","html_url":"https://github.com/yjbanov","followers_url":"https://api.github.com/users/yjbanov/followers","following_url":"https://api.github.com/users/yjbanov/following{/other_user}","gists_url":"https://api.github.com/users/yjbanov/gists{/gist_id}","starred_url":"https://api.github.com/users/yjbanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yjbanov/subscriptions","organizations_url":"https://api.github.com/users/yjbanov/orgs","repos_url":"https://api.github.com/users/yjbanov/repos","events_url":"https://api.github.com/users/yjbanov/events{/privacy}","received_events_url":"https://api.github.com/users/yjbanov/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T22:17:12Z","updated_at":"2018-06-20T22:17:12Z","author_association":"CONTRIBUTOR","body":"> 1. We should also set a default crash server for China (after that server is up) maybe in a later PR?\r\n\r\nHopefully it's not too hard to run a custom server for collecting crash reports. I'm not sure if the Flutter will be able to provide it.\r\n\r\n> 2. Shall we allow multiple crash servers? For example, could it be possible that Alibaba wants to have is own crash report server, and Google wants that report too so we'll send one report to two servers?\r\n\r\nPerhaps `FLUTTER_CRASH_SERVER_BASE_URL` could be a comma-separated list of URLs and crash reporter would send a report to all of them? But also, a custom server could act as a proxy and both store a copy of each report and forward it to another server. Let's see if there's enough interest in something like this and we can expand the functionality. I just don't want to add it speculatively. Would you mind filing an issue for that so others could comment?\r\n"}}
{"actor":{"display_login":"yjbanov"}}