{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/che/issues/11890","repository_url":"https://api.github.com/repos/eclipse/che","labels_url":"https://api.github.com/repos/eclipse/che/issues/11890/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/che/issues/11890/comments","events_url":"https://api.github.com/repos/eclipse/che/issues/11890/events","html_url":"https://github.com/eclipse/che/pull/11890","id":379227902,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzQ1Njg2","number":11890,"title":"Make a workspace run without any user env","user":{"login":"garagatyi","id":1851863,"node_id":"MDQ6VXNlcjE4NTE4NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1851863?v=4","gravatar_id":"","url":"https://api.github.com/users/garagatyi","html_url":"https://github.com/garagatyi","followers_url":"https://api.github.com/users/garagatyi/followers","following_url":"https://api.github.com/users/garagatyi/following{/other_user}","gists_url":"https://api.github.com/users/garagatyi/gists{/gist_id}","starred_url":"https://api.github.com/users/garagatyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garagatyi/subscriptions","organizations_url":"https://api.github.com/users/garagatyi/orgs","repos_url":"https://api.github.com/users/garagatyi/repos","events_url":"https://api.github.com/users/garagatyi/events{/privacy}","received_events_url":"https://api.github.com/users/garagatyi/received_events","type":"User","site_admin":false},"labels":[{"id":345100523,"node_id":"MDU6TGFiZWwzNDUxMDA1MjM=","url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-11-09T16:21:13Z","updated_at":"2018-11-20T14:45:35Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/11890","html_url":"https://github.com/eclipse/che/pull/11890","diff_url":"https://github.com/eclipse/che/pull/11890.diff","patch_url":"https://github.com/eclipse/che/pull/11890.patch"},"body":"### What does this PR do?\r\n*I created this PR to get early feedbacks from Che teams. Please on this stage elaborate about bugs found, use cases, but not docs, tests.*\r\nThis PR allows running Che 7 workspace without any user environment but with Che 7 tooling set.\r\nWorkspace without environment has an empty list of environments and null value in `defaultEnv` field.\r\nField `activeEnv` is supposed to be `null` too.\r\nVideo: https://youtu.be/QeeRtoYZU-o\r\n\r\n**Why**\r\nIt is useful to be able to run Theia workspace for Theia plugins development without any additional machines since Theia has hosted mode.\r\nAnother use-case is when IDE container has everything needs for a user to run his application - great for starting a new project that is lightweight and doesn't have tons of apps in the deployment.\r\n\r\n**What is changed:**\r\n- Migration of DB:\r\n - make `defaultEnv` nullable\r\n - remove env_name from runtimes primary key\r\n - make `env_name` in runtimes nullable\r\n- Make code respect the fact that there are workspaces with no env\r\n- settings API that returns the list of supported environment types returns `no-environment` type that indicates that infrastructure support workspace with no environment at all.  \r\n\r\n\r\nChecked:\r\n- Che 7 on OS infra\r\n- Che 7 on OS infra with GWT IDE sidecar\r\n\r\nTo check:\r\n- Che 7 on k8s infra\r\n- Factory\r\n- what happens if workspace is running and we do rolling update of Che master\r\n- what happens when workspace is starting, we do migration and then it becomes running (rolling update)\r\n- Che 7 with Postgres and Auth\r\n- Che 7 with H2 and existing+running workspaces\r\n- Che 7 with Postgres and existing+running workspaces \r\n- RhChe 7\r\n\r\nDoesn't support:\r\n- Docker \r\n- Che 6 on all the infras\r\n\r\nTodo:\r\n- fix UD\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n<!-- #### Changelog -->\r\n<!-- The changelog will be pulled from the PR's title. \r\n     Please provide a clear and meaningful title to the PR and don't include issue number -->\r\n\r\n\r\n#### Release Notes\r\n<!-- markdown to be included in marketing announcement - N/A for bugs -->\r\n\r\n\r\n#### Docs PR\r\n<!-- Please add a matching PR to [the docs repo](https://github.com/eclipse/che-docs) and link that PR to this issue.\r\nBoth will be merged at the same time. -->\r\n"},"comment":{"url":"https://api.github.com/repos/eclipse/che/issues/comments/440297795","html_url":"https://github.com/eclipse/che/pull/11890#issuecomment-440297795","issue_url":"https://api.github.com/repos/eclipse/che/issues/11890","id":440297795,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDI5Nzc5NQ==","user":{"login":"skabashnyuk","id":1614429,"node_id":"MDQ6VXNlcjE2MTQ0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1614429?v=4","gravatar_id":"","url":"https://api.github.com/users/skabashnyuk","html_url":"https://github.com/skabashnyuk","followers_url":"https://api.github.com/users/skabashnyuk/followers","following_url":"https://api.github.com/users/skabashnyuk/following{/other_user}","gists_url":"https://api.github.com/users/skabashnyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/skabashnyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skabashnyuk/subscriptions","organizations_url":"https://api.github.com/users/skabashnyuk/orgs","repos_url":"https://api.github.com/users/skabashnyuk/repos","events_url":"https://api.github.com/users/skabashnyuk/events{/privacy}","received_events_url":"https://api.github.com/users/skabashnyuk/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T14:45:35Z","updated_at":"2018-11-20T14:45:35Z","author_association":"CONTRIBUTOR","body":"ok for me in general. I trust @sleshchenko and @mshaposhnik to make a final decision.\r\n"}}
{"actor":{"display_login":"skabashnyuk"}}