{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/agora/pulls/comments/173842735","pull_request_review_id":103098114,"id":173842735,"diff_hunk":"@@ -54,6 +54,15 @@ object ApiService extends LazyLogging with SprayJsonSupport with DefaultJsonProt\n         complete(InternalServerError, AgoraException(e.getMessage, e.getCause, InternalServerError))\n     }\n   }\n+\n+  val rejectionHandler: RejectionHandler =\n+    RejectionHandler.newBuilder().handle {\n+      case MalformedRequestContentRejection(message, cause) => complete(BadRequest, message)","path":"src/main/scala/org/broadinstitute/dsde/agora/server/webservice/ApiService.scala","position":16,"original_position":16,"commit_id":"2fd2906784d81ee07f97dcf2b0d1b2295496f70e","original_commit_id":"2fd2906784d81ee07f97dcf2b0d1b2295496f70e","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars2.githubusercontent.com/u/116679?v=4","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"This was only used in `ApiServiceSpec` but tests relied on this being handled in this way which is why I added it back to all routes.","created_at":"2018-03-12T15:40:54Z","updated_at":"2018-03-12T15:40:54Z","html_url":"https://github.com/broadinstitute/agora/pull/254#discussion_r173842735","pull_request_url":"https://api.github.com/repos/broadinstitute/agora/pulls/254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/comments/173842735"},"html":{"href":"https://github.com/broadinstitute/agora/pull/254#discussion_r173842735"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/agora/pulls/254","id":174407416,"html_url":"https://github.com/broadinstitute/agora/pull/254","diff_url":"https://github.com/broadinstitute/agora/pull/254.diff","patch_url":"https://github.com/broadinstitute/agora/pull/254.patch","issue_url":"https://api.github.com/repos/broadinstitute/agora/issues/254","number":254,"state":"open","locked":false,"title":"GAWB-3052: rejection handling","user":{"login":"rushtong","id":116679,"avatar_url":"https://avatars2.githubusercontent.com/u/116679?v=4","gravatar_id":"","url":"https://api.github.com/users/rushtong","html_url":"https://github.com/rushtong","followers_url":"https://api.github.com/users/rushtong/followers","following_url":"https://api.github.com/users/rushtong/following{/other_user}","gists_url":"https://api.github.com/users/rushtong/gists{/gist_id}","starred_url":"https://api.github.com/users/rushtong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rushtong/subscriptions","organizations_url":"https://api.github.com/users/rushtong/orgs","repos_url":"https://api.github.com/users/rushtong/repos","events_url":"https://api.github.com/users/rushtong/events{/privacy}","received_events_url":"https://api.github.com/users/rushtong/received_events","type":"User","site_admin":false},"body":"Rejections are slightly different between spray/akka-http. In the current repo, we only care about one error case where the requested content type is incorrect and respond with a nice error. \r\n\r\nThis PR:\r\n* Adds the older version of handling the custom case to a custom handler.\r\n* Re-adds the one case where tests were custom handling a rejection.\r\n\r\n- [ ] **Submitter**: Include the JIRA issue number in the PR description\r\n- [ ] **Submitter**: Make sure Swagger is updated if API changes\r\n- [ ] **Submitter**: If updating admin endpoints, also update [firecloud-admin-cli](https://github.com/broadinstitute/firecloud-admin-cli)\r\n- [ ] **Submitter**: Check documentation and code comments. Add explanatory PR comments if helpful.\r\n- [ ] **Submitter**: JIRA ticket checks:\r\n  * Acceptance criteria exists and is met\r\n  * Note any changes to implementation from the description\r\n  * To Demo flag is set\r\n  * Release Summary is filled out, if applicable\r\n  * Add notes on how to QA\r\n- [ ] **Submitter**: Update RC_XXX release ticket with any config or environment changes necessary\r\n- [ ] **Submitter**: Update FISMA documentation if changes to:\r\n  * Authentication\r\n  * Authorization\r\n  * Encryption\r\n  * Audit trails\r\n- [ ] **Submitter**: If you're adding new libraries, sign us up to security updates for them\r\n- [ ] Tell the tech lead (TL) that the PR exists if they wants to look at it\r\n- [ ] Anoint a lead reviewer (LR). **Assign PR to LR**\r\n* Review cycle:\r\n  * LR reviews\r\n  * Rest of team may comment on PR at will\r\n  * **LR assigns to submitter** for feedback fixes\r\n  * Submitter rebases to develop again if necessary\r\n  * Submitter makes further commits. DO NOT SQUASH\r\n  * Submitter updates documentation as needed\r\n  * Submitter **reassigns to LR** for further feedback\r\n- [ ] **TL** sign off\r\n- [ ] **LR** sign off\r\n- [ ] **Product Owner** sign off\r\n- [ ] **Assign to submitter** to finalize\r\n- [ ] **Submitter**: Verify all tests go green, including CI tests\r\n- [ ] **Submitter**: Squash commits and merge to develop\r\n- [ ] **Submitter**: Delete branch after merge\r\n- [ ] **Submitter**: **Test this change works on dev environment after deployment**. YOU own getting it fixed if dev isn't working for ANY reason!\r\n- [ ] **Submitter**: Verify swagger UI on dev environment still works after deployment\r\n- [ ] **Submitter**: Inform other teams of any API changes via Slack and/or email\r\n- [ ] **Submitter**: Mark JIRA issue as resolved once this checklist is completed\r\n","created_at":"2018-03-12T15:38:05Z","updated_at":"2018-03-12T15:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdad343bdb1b2e5ea46db6f28db00f49816d0e25","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/agora/pulls/254/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/agora/pulls/254/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/agora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/agora/issues/254/comments","statuses_url":"https://api.github.com/repos/broadinstitute/agora/statuses/2fd2906784d81ee07f97dcf2b0d1b2295496f70e","head":{"label":"broadinstitute:gr-GAWB-3052-rejections","ref":"gr-GAWB-3052-rejections","sha":"2fd2906784d81ee07f97dcf2b0d1b2295496f70e","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34753721,"name":"agora","full_name":"broadinstitute/agora","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/agora","description":"It's a methods repository!","fork":false,"url":"https://api.github.com/repos/broadinstitute/agora","forks_url":"https://api.github.com/repos/broadinstitute/agora/forks","keys_url":"https://api.github.com/repos/broadinstitute/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/agora/teams","hooks_url":"https://api.github.com/repos/broadinstitute/agora/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/agora/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/agora/events","assignees_url":"https://api.github.com/repos/broadinstitute/agora/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/agora/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/agora/tags","blobs_url":"https://api.github.com/repos/broadinstitute/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/agora/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/agora/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/agora/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/agora/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/agora/subscription","commits_url":"https://api.github.com/repos/broadinstitute/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/agora/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/agora/merges","archive_url":"https://api.github.com/repos/broadinstitute/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/agora/downloads","issues_url":"https://api.github.com/repos/broadinstitute/agora/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/agora/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/agora/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/agora/deployments","created_at":"2015-04-28T20:18:52Z","updated_at":"2018-03-12T15:40:54Z","pushed_at":"2018-03-12T15:38:06Z","git_url":"git://github.com/broadinstitute/agora.git","ssh_url":"git@github.com:broadinstitute/agora.git","clone_url":"https://github.com/broadinstitute/agora.git","svn_url":"https://github.com/broadinstitute/agora","homepage":"","size":8846,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":4,"watchers":5,"default_branch":"develop"}},"base":{"label":"broadinstitute:ky_GAWB-3052_spray_migration","ref":"ky_GAWB-3052_spray_migration","sha":"aa3d5558a7da56912966a3962f93e8a50f565dd4","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34753721,"name":"agora","full_name":"broadinstitute/agora","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/agora","description":"It's a methods repository!","fork":false,"url":"https://api.github.com/repos/broadinstitute/agora","forks_url":"https://api.github.com/repos/broadinstitute/agora/forks","keys_url":"https://api.github.com/repos/broadinstitute/agora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/agora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/agora/teams","hooks_url":"https://api.github.com/repos/broadinstitute/agora/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/agora/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/agora/events","assignees_url":"https://api.github.com/repos/broadinstitute/agora/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/agora/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/agora/tags","blobs_url":"https://api.github.com/repos/broadinstitute/agora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/agora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/agora/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/agora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/agora/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/agora/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/agora/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/agora/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/agora/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/agora/subscription","commits_url":"https://api.github.com/repos/broadinstitute/agora/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/agora/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/agora/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/agora/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/agora/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/agora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/agora/merges","archive_url":"https://api.github.com/repos/broadinstitute/agora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/agora/downloads","issues_url":"https://api.github.com/repos/broadinstitute/agora/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/agora/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/agora/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/agora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/agora/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/agora/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/agora/deployments","created_at":"2015-04-28T20:18:52Z","updated_at":"2018-03-12T15:40:54Z","pushed_at":"2018-03-12T15:38:06Z","git_url":"git://github.com/broadinstitute/agora.git","ssh_url":"git@github.com:broadinstitute/agora.git","clone_url":"https://github.com/broadinstitute/agora.git","svn_url":"https://github.com/broadinstitute/agora","homepage":"","size":8846,"stargazers_count":5,"watchers_count":5,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":4,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/254"},"html":{"href":"https://github.com/broadinstitute/agora/pull/254"},"issue":{"href":"https://api.github.com/repos/broadinstitute/agora/issues/254"},"comments":{"href":"https://api.github.com/repos/broadinstitute/agora/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/agora/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/agora/statuses/2fd2906784d81ee07f97dcf2b0d1b2295496f70e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rushtong"}}