{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/171868854","pull_request_review_id":100800759,"id":171868854,"diff_hunk":"@@ -518,7 +518,17 @@ private function createEncoder($config, ContainerBuilder $container)\n         // Argon2i encoder\n         if ('argon2i' === $config['algorithm']) {\n             if (!Argon2iPasswordEncoder::isSupported()) {\n-                throw new InvalidConfigurationException('Argon2i algorithm is not supported. Please install the libsodium extension or upgrade to PHP 7.2+.');\n+                // Debugging on Heroku and derivatives is a lot of work, show specific error to save end users some time\n+                if (false !== strpos($_ENV['PATH'], 'heroku')) {\n+                    throw new InvalidConfigurationException('Argon2i algorithm is not supported on Heroku, use BCrypt instead.');\n+                }\n+                if (\\PHP_VERSION_ID >= 70200) {\n+                    // Argon2 support got added in libsodium 1.0.9\n+                    if (version_compare(\\SODIUM_LIBRARY_VERSION, '1.0.9', '<')) {","path":"src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php","position":11,"original_position":11,"commit_id":"77c4d0dba1f2dc366ad0b6a307f4a35b73b464bb","original_commit_id":"77c4d0dba1f2dc366ad0b6a307f4a35b73b464bb","user":{"login":"greg0ire","id":657779,"avatar_url":"https://avatars1.githubusercontent.com/u/657779?v=4","gravatar_id":"","url":"https://api.github.com/users/greg0ire","html_url":"https://github.com/greg0ire","followers_url":"https://api.github.com/users/greg0ire/followers","following_url":"https://api.github.com/users/greg0ire/following{/other_user}","gists_url":"https://api.github.com/users/greg0ire/gists{/gist_id}","starred_url":"https://api.github.com/users/greg0ire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg0ire/subscriptions","organizations_url":"https://api.github.com/users/greg0ire/orgs","repos_url":"https://api.github.com/users/greg0ire/repos","events_url":"https://api.github.com/users/greg0ire/events{/privacy}","received_events_url":"https://api.github.com/users/greg0ire/received_events","type":"User","site_admin":false},"body":"@chalasr how about doing feature detection instead: https://github.com/symfony/symfony/pull/26190#discussion_r168623244 ?","created_at":"2018-03-02T14:59:32Z","updated_at":"2018-03-02T14:59:33Z","html_url":"https://github.com/symfony/symfony/pull/26190#discussion_r171868854","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/26190","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/171868854"},"html":{"href":"https://github.com/symfony/symfony/pull/26190#discussion_r171868854"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26190"}},"in_reply_to_id":171866223},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/26190","id":169378785,"html_url":"https://github.com/symfony/symfony/pull/26190","diff_url":"https://github.com/symfony/symfony/pull/26190.diff","patch_url":"https://github.com/symfony/symfony/pull/26190.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/26190","number":26190,"state":"open","locked":false,"title":"Fix Argon2 Error to be more accurate.","user":{"login":"iSDP","id":6475387,"avatar_url":"https://avatars3.githubusercontent.com/u/6475387?v=4","gravatar_id":"","url":"https://api.github.com/users/iSDP","html_url":"https://github.com/iSDP","followers_url":"https://api.github.com/users/iSDP/followers","following_url":"https://api.github.com/users/iSDP/following{/other_user}","gists_url":"https://api.github.com/users/iSDP/gists{/gist_id}","starred_url":"https://api.github.com/users/iSDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSDP/subscriptions","organizations_url":"https://api.github.com/users/iSDP/orgs","repos_url":"https://api.github.com/users/iSDP/repos","events_url":"https://api.github.com/users/iSDP/events{/privacy}","received_events_url":"https://api.github.com/users/iSDP/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master?\r\n| Bug fix?      | yes\r\n| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->\r\n| BC breaks?    | no\r\n| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->\r\n| Tests pass?   | ?\r\n| Fixed tickets | ~\r\n| License       | MIT\r\n| Doc PR        | ~\r\n","created_at":"2018-02-15T14:00:39Z","updated_at":"2018-03-02T14:59:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee13b9268c37c2b1ac9009e4cdfe10e34e36eb6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100079,"url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":238909857,"url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Work","name":"Status: Needs Work","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/10","html_url":"https://github.com/symfony/symfony/milestone/10","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/10/labels","id":2117464,"number":10,"title":"3.4","description":"https://symfony.com/roadmap?version=3.4#checker","creator":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":701,"state":"open","created_at":"2016-11-06T20:24:23Z","updated_at":"2018-03-02T14:14:25Z","due_on":"2020-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/26190/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/26190/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/26190/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/77c4d0dba1f2dc366ad0b6a307f4a35b73b464bb","head":{"label":"iSDP:fix-argon2-error","ref":"fix-argon2-error","sha":"77c4d0dba1f2dc366ad0b6a307f4a35b73b464bb","user":{"login":"iSDP","id":6475387,"avatar_url":"https://avatars3.githubusercontent.com/u/6475387?v=4","gravatar_id":"","url":"https://api.github.com/users/iSDP","html_url":"https://github.com/iSDP","followers_url":"https://api.github.com/users/iSDP/followers","following_url":"https://api.github.com/users/iSDP/following{/other_user}","gists_url":"https://api.github.com/users/iSDP/gists{/gist_id}","starred_url":"https://api.github.com/users/iSDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSDP/subscriptions","organizations_url":"https://api.github.com/users/iSDP/orgs","repos_url":"https://api.github.com/users/iSDP/repos","events_url":"https://api.github.com/users/iSDP/events{/privacy}","received_events_url":"https://api.github.com/users/iSDP/received_events","type":"User","site_admin":false},"repo":{"id":121635712,"name":"symfony","full_name":"iSDP/symfony","owner":{"login":"iSDP","id":6475387,"avatar_url":"https://avatars3.githubusercontent.com/u/6475387?v=4","gravatar_id":"","url":"https://api.github.com/users/iSDP","html_url":"https://github.com/iSDP","followers_url":"https://api.github.com/users/iSDP/followers","following_url":"https://api.github.com/users/iSDP/following{/other_user}","gists_url":"https://api.github.com/users/iSDP/gists{/gist_id}","starred_url":"https://api.github.com/users/iSDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iSDP/subscriptions","organizations_url":"https://api.github.com/users/iSDP/orgs","repos_url":"https://api.github.com/users/iSDP/repos","events_url":"https://api.github.com/users/iSDP/events{/privacy}","received_events_url":"https://api.github.com/users/iSDP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iSDP/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/iSDP/symfony","forks_url":"https://api.github.com/repos/iSDP/symfony/forks","keys_url":"https://api.github.com/repos/iSDP/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iSDP/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iSDP/symfony/teams","hooks_url":"https://api.github.com/repos/iSDP/symfony/hooks","issue_events_url":"https://api.github.com/repos/iSDP/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/iSDP/symfony/events","assignees_url":"https://api.github.com/repos/iSDP/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/iSDP/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/iSDP/symfony/tags","blobs_url":"https://api.github.com/repos/iSDP/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iSDP/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iSDP/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/iSDP/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iSDP/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/iSDP/symfony/languages","stargazers_url":"https://api.github.com/repos/iSDP/symfony/stargazers","contributors_url":"https://api.github.com/repos/iSDP/symfony/contributors","subscribers_url":"https://api.github.com/repos/iSDP/symfony/subscribers","subscription_url":"https://api.github.com/repos/iSDP/symfony/subscription","commits_url":"https://api.github.com/repos/iSDP/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/iSDP/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/iSDP/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/iSDP/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/iSDP/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/iSDP/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iSDP/symfony/merges","archive_url":"https://api.github.com/repos/iSDP/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iSDP/symfony/downloads","issues_url":"https://api.github.com/repos/iSDP/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/iSDP/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/iSDP/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/iSDP/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iSDP/symfony/labels{/name}","releases_url":"https://api.github.com/repos/iSDP/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/iSDP/symfony/deployments","created_at":"2018-02-15T13:56:47Z","updated_at":"2018-02-15T13:57:06Z","pushed_at":"2018-02-15T22:59:26Z","git_url":"git://github.com/iSDP/symfony.git","ssh_url":"git@github.com:iSDP/symfony.git","clone_url":"https://github.com/iSDP/symfony.git","svn_url":"https://github.com/iSDP/symfony","homepage":"symfony.com","size":109321,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"b0facfec018093fb9ad65658f654ab7af06f6f87","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-03-02T14:21:56Z","pushed_at":"2018-03-02T14:57:34Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":114420,"stargazers_count":16826,"watchers_count":16826,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6058,"mirror_url":null,"archived":false,"open_issues_count":809,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":6058,"open_issues":809,"watchers":16826,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26190"},"html":{"href":"https://github.com/symfony/symfony/pull/26190"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/26190"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/26190/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26190/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/26190/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/77c4d0dba1f2dc366ad0b6a307f4a35b73b464bb"}},"author_association":"NONE"}}
{"actor":{"display_login":"greg0ire"}}