{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1267","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1267/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1267/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1267/events","html_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1267","id":188797114,"number":1267,"title":"EZP-26593: Enable audit log by default","user":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2016-11-11T16:27:00Z","updated_at":"2016-11-12T12:18:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/pulls/1267","html_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1267","diff_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1267.diff","patch_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1267.patch"},"body":"https://jira.ez.no/browse/EZP-26593\r\n\r\nThis feature should be enabled by default: https://doc.ez.no/eZ-Publish/Technical-manual/4.x/Features/Audit-trailing\r\n\r\n* We eventually enable the audit log for most clients\r\n* The audit log usually gets enabled after something bad has happened (and at that point we waste a bunch of time trying to analyze the Apache logs)\r\n* There are only positives to having the audit log enabled\r\n* The log files automatically rotate, so there isn't additional configuration that we need to remember"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/comments/260118946","html_url":"https://github.com/ezsystems/ezpublish-legacy/pull/1267#issuecomment-260118946","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-legacy/issues/1267","id":260118946,"user":{"login":"gggeek","id":308634,"avatar_url":"https://avatars.githubusercontent.com/u/308634?v=3","gravatar_id":"","url":"https://api.github.com/users/gggeek","html_url":"https://github.com/gggeek","followers_url":"https://api.github.com/users/gggeek/followers","following_url":"https://api.github.com/users/gggeek/following{/other_user}","gists_url":"https://api.github.com/users/gggeek/gists{/gist_id}","starred_url":"https://api.github.com/users/gggeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gggeek/subscriptions","organizations_url":"https://api.github.com/users/gggeek/orgs","repos_url":"https://api.github.com/users/gggeek/repos","events_url":"https://api.github.com/users/gggeek/events{/privacy}","received_events_url":"https://api.github.com/users/gggeek/received_events","type":"User","site_admin":false},"created_at":"2016-11-12T12:18:30Z","updated_at":"2016-11-12T12:18:30Z","body":"I'm in favour of having it on by default - the audit log is rotated, and the IO you get out of it is small anyway.\r\n\r\nMy main concern with it in fact is that it is not omni-comprehensive, and that it should log *more* operations. All operations except content publication should be logged: move/hide/set-state/set-section/trash/swap-nodes/add-or-remove-location/change-sorting/change-priority etc... (without the need to set up up dedicated workflow events)\r\n\r\nBtw, is this even a feature in eZ5? Maybe we should have a budle for that?\r\n\r\nSide note : @crevillo Sf does many things different than eZ by default/principle. The funny thing is: quite a few of them make lots of sense for a framework, but less for a CMS. Eg. the whole \"throw your arms in the air if there is the smallest error anywhere\" works fine for code and configuration, but not for code that touches content, as content *always* ends up inconsistent (and eZ had to turn a lot of screws to reintroduce graceful handling of those cases in version 5, instead of 'show blank page'. Heck, proper handling of bad object relations is still being worked on these days...)\r\n"}}
{"actor":{"display_login":"gggeek"}}