{"action":"opened","number":75,"pull_request":{"url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/75","id":73170954,"html_url":"https://github.com/projectatomic/bubblewrap/pull/75","diff_url":"https://github.com/projectatomic/bubblewrap/pull/75.diff","patch_url":"https://github.com/projectatomic/bubblewrap/pull/75.patch","issue_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/75","number":75,"state":"open","locked":false,"title":"build: put libraries in LDADD, not LDFLAGS","user":{"login":"smcv","id":1561141,"avatar_url":"https://avatars.githubusercontent.com/u/1561141?v=3","gravatar_id":"","url":"https://api.github.com/users/smcv","html_url":"https://github.com/smcv","followers_url":"https://api.github.com/users/smcv/followers","following_url":"https://api.github.com/users/smcv/following{/other_user}","gists_url":"https://api.github.com/users/smcv/gists{/gist_id}","starred_url":"https://api.github.com/users/smcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcv/subscriptions","organizations_url":"https://api.github.com/users/smcv/orgs","repos_url":"https://api.github.com/users/smcv/repos","events_url":"https://api.github.com/users/smcv/events{/privacy}","received_events_url":"https://api.github.com/users/smcv/received_events","type":"User","site_admin":false},"body":"Automake linking looks like this (I'm simplifying a bit):\r\n\r\n    $(CC) $(foo_CFLAGS) $(foo_LDFLAGS) -ofoo $(objects) $(foo_LDADD)\r\n\r\nThe correct order is that if a library A is used to satisfy the symbol\r\nrequirements of an object or library B, then A must come after B on the\r\nlink line. Otherwise, static linking or linking with -Wl,--as-needed\r\nwill fail. As a result, libraries and the -L options used to locate them\r\nshould always be in LDADD (for executables) or LIBADD (for libraries),\r\nnever in LDFLAGS.\r\n\r\nUbuntu's linker defaults to the equivalent of -Wl,--as-needed, so\r\nthis causes failure to build on Ubuntu, which can be reproduced with\r\n\r\n    ./autogen.sh CC=\"gcc -Wl,--as-needed\" && make\r\n\r\non other distributions.","created_at":"2016-06-09T07:56:49Z","updated_at":"2016-06-09T07:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/75/commits","review_comments_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/75/comments","review_comment_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/75/comments","statuses_url":"https://api.github.com/repos/projectatomic/bubblewrap/statuses/82cd67bb8104f2bb4c74aac126bea6bc05880763","head":{"label":"smcv:linker","ref":"linker","sha":"82cd67bb8104f2bb4c74aac126bea6bc05880763","user":{"login":"smcv","id":1561141,"avatar_url":"https://avatars.githubusercontent.com/u/1561141?v=3","gravatar_id":"","url":"https://api.github.com/users/smcv","html_url":"https://github.com/smcv","followers_url":"https://api.github.com/users/smcv/followers","following_url":"https://api.github.com/users/smcv/following{/other_user}","gists_url":"https://api.github.com/users/smcv/gists{/gist_id}","starred_url":"https://api.github.com/users/smcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcv/subscriptions","organizations_url":"https://api.github.com/users/smcv/orgs","repos_url":"https://api.github.com/users/smcv/repos","events_url":"https://api.github.com/users/smcv/events{/privacy}","received_events_url":"https://api.github.com/users/smcv/received_events","type":"User","site_admin":false},"repo":{"id":60757793,"name":"bubblewrap","full_name":"smcv/bubblewrap","owner":{"login":"smcv","id":1561141,"avatar_url":"https://avatars.githubusercontent.com/u/1561141?v=3","gravatar_id":"","url":"https://api.github.com/users/smcv","html_url":"https://github.com/smcv","followers_url":"https://api.github.com/users/smcv/followers","following_url":"https://api.github.com/users/smcv/following{/other_user}","gists_url":"https://api.github.com/users/smcv/gists{/gist_id}","starred_url":"https://api.github.com/users/smcv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smcv/subscriptions","organizations_url":"https://api.github.com/users/smcv/orgs","repos_url":"https://api.github.com/users/smcv/repos","events_url":"https://api.github.com/users/smcv/events{/privacy}","received_events_url":"https://api.github.com/users/smcv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smcv/bubblewrap","description":"Unprivileged sandboxing tool","fork":true,"url":"https://api.github.com/repos/smcv/bubblewrap","forks_url":"https://api.github.com/repos/smcv/bubblewrap/forks","keys_url":"https://api.github.com/repos/smcv/bubblewrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smcv/bubblewrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smcv/bubblewrap/teams","hooks_url":"https://api.github.com/repos/smcv/bubblewrap/hooks","issue_events_url":"https://api.github.com/repos/smcv/bubblewrap/issues/events{/number}","events_url":"https://api.github.com/repos/smcv/bubblewrap/events","assignees_url":"https://api.github.com/repos/smcv/bubblewrap/assignees{/user}","branches_url":"https://api.github.com/repos/smcv/bubblewrap/branches{/branch}","tags_url":"https://api.github.com/repos/smcv/bubblewrap/tags","blobs_url":"https://api.github.com/repos/smcv/bubblewrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smcv/bubblewrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smcv/bubblewrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/smcv/bubblewrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smcv/bubblewrap/statuses/{sha}","languages_url":"https://api.github.com/repos/smcv/bubblewrap/languages","stargazers_url":"https://api.github.com/repos/smcv/bubblewrap/stargazers","contributors_url":"https://api.github.com/repos/smcv/bubblewrap/contributors","subscribers_url":"https://api.github.com/repos/smcv/bubblewrap/subscribers","subscription_url":"https://api.github.com/repos/smcv/bubblewrap/subscription","commits_url":"https://api.github.com/repos/smcv/bubblewrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/smcv/bubblewrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/smcv/bubblewrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/smcv/bubblewrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/smcv/bubblewrap/contents/{+path}","compare_url":"https://api.github.com/repos/smcv/bubblewrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smcv/bubblewrap/merges","archive_url":"https://api.github.com/repos/smcv/bubblewrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smcv/bubblewrap/downloads","issues_url":"https://api.github.com/repos/smcv/bubblewrap/issues{/number}","pulls_url":"https://api.github.com/repos/smcv/bubblewrap/pulls{/number}","milestones_url":"https://api.github.com/repos/smcv/bubblewrap/milestones{/number}","notifications_url":"https://api.github.com/repos/smcv/bubblewrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smcv/bubblewrap/labels{/name}","releases_url":"https://api.github.com/repos/smcv/bubblewrap/releases{/id}","deployments_url":"https://api.github.com/repos/smcv/bubblewrap/deployments","created_at":"2016-06-09T07:42:57Z","updated_at":"2016-06-09T07:42:58Z","pushed_at":"2016-06-09T07:56:15Z","git_url":"git://github.com/smcv/bubblewrap.git","ssh_url":"git@github.com:smcv/bubblewrap.git","clone_url":"https://github.com/smcv/bubblewrap.git","svn_url":"https://github.com/smcv/bubblewrap","homepage":"","size":270,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"6ad6c24bf31cd3cd450e51aba675e82516aeae16","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":51868010,"name":"bubblewrap","full_name":"projectatomic/bubblewrap","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars.githubusercontent.com/u/6852258?v=3","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/bubblewrap","description":"Unprivileged sandboxing tool","fork":false,"url":"https://api.github.com/repos/projectatomic/bubblewrap","forks_url":"https://api.github.com/repos/projectatomic/bubblewrap/forks","keys_url":"https://api.github.com/repos/projectatomic/bubblewrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/bubblewrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/bubblewrap/teams","hooks_url":"https://api.github.com/repos/projectatomic/bubblewrap/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/bubblewrap/events","assignees_url":"https://api.github.com/repos/projectatomic/bubblewrap/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/bubblewrap/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/bubblewrap/tags","blobs_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/bubblewrap/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/bubblewrap/languages","stargazers_url":"https://api.github.com/repos/projectatomic/bubblewrap/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/bubblewrap/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/bubblewrap/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/bubblewrap/subscription","commits_url":"https://api.github.com/repos/projectatomic/bubblewrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/bubblewrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/bubblewrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/bubblewrap/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/bubblewrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/bubblewrap/merges","archive_url":"https://api.github.com/repos/projectatomic/bubblewrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/bubblewrap/downloads","issues_url":"https://api.github.com/repos/projectatomic/bubblewrap/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/bubblewrap/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/bubblewrap/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/bubblewrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/bubblewrap/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/bubblewrap/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/bubblewrap/deployments","created_at":"2016-02-16T20:36:10Z","updated_at":"2016-06-08T14:44:57Z","pushed_at":"2016-06-02T16:01:07Z","git_url":"git://github.com/projectatomic/bubblewrap.git","ssh_url":"git@github.com:projectatomic/bubblewrap.git","clone_url":"https://github.com/projectatomic/bubblewrap.git","svn_url":"https://github.com/projectatomic/bubblewrap","homepage":"","size":270,"stargazers_count":98,"watchers_count":98,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/75"},"html":{"href":"https://github.com/projectatomic/bubblewrap/pull/75"},"issue":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/issues/75"},"comments":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/bubblewrap/statuses/82cd67bb8104f2bb4c74aac126bea6bc05880763"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"smcv"}}