{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/VPenkov/okayNav/pulls/40","id":66136299,"html_url":"https://github.com/VPenkov/okayNav/pull/40","diff_url":"https://github.com/VPenkov/okayNav/pull/40.diff","patch_url":"https://github.com/VPenkov/okayNav/pull/40.patch","issue_url":"https://api.github.com/repos/VPenkov/okayNav/issues/40","number":40,"state":"closed","locked":false,"title":"Declare variable self in order to avoid global assignment","user":{"login":"splattne","id":200860,"avatar_url":"https://avatars.githubusercontent.com/u/200860?v=3","gravatar_id":"","url":"https://api.github.com/users/splattne","html_url":"https://github.com/splattne","followers_url":"https://api.github.com/users/splattne/followers","following_url":"https://api.github.com/users/splattne/following{/other_user}","gists_url":"https://api.github.com/users/splattne/gists{/gist_id}","starred_url":"https://api.github.com/users/splattne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattne/subscriptions","organizations_url":"https://api.github.com/users/splattne/orgs","repos_url":"https://api.github.com/users/splattne/repos","events_url":"https://api.github.com/users/splattne/events{/privacy}","received_events_url":"https://api.github.com/users/splattne/received_events","type":"User","site_admin":false},"body":"In line 48 (now 49) self is assigned globally to windows which could break a lot of things in applications and other libraries.","created_at":"2016-04-12T10:46:21Z","updated_at":"2016-05-01T14:06:29Z","closed_at":"2016-05-01T14:06:29Z","merged_at":"2016-05-01T14:06:29Z","merge_commit_sha":"a74202a2b4ac250a45bb34fddd29c770169ab694","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/VPenkov/okayNav/pulls/40/commits","review_comments_url":"https://api.github.com/repos/VPenkov/okayNav/pulls/40/comments","review_comment_url":"https://api.github.com/repos/VPenkov/okayNav/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VPenkov/okayNav/issues/40/comments","statuses_url":"https://api.github.com/repos/VPenkov/okayNav/statuses/960d3e3642617aafb472ba749d06580be4d1d56b","head":{"label":"splattne:patch-2","ref":"patch-2","sha":"960d3e3642617aafb472ba749d06580be4d1d56b","user":{"login":"splattne","id":200860,"avatar_url":"https://avatars.githubusercontent.com/u/200860?v=3","gravatar_id":"","url":"https://api.github.com/users/splattne","html_url":"https://github.com/splattne","followers_url":"https://api.github.com/users/splattne/followers","following_url":"https://api.github.com/users/splattne/following{/other_user}","gists_url":"https://api.github.com/users/splattne/gists{/gist_id}","starred_url":"https://api.github.com/users/splattne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattne/subscriptions","organizations_url":"https://api.github.com/users/splattne/orgs","repos_url":"https://api.github.com/users/splattne/repos","events_url":"https://api.github.com/users/splattne/events{/privacy}","received_events_url":"https://api.github.com/users/splattne/received_events","type":"User","site_admin":false},"repo":{"id":56054399,"name":"okayNav","full_name":"splattne/okayNav","owner":{"login":"splattne","id":200860,"avatar_url":"https://avatars.githubusercontent.com/u/200860?v=3","gravatar_id":"","url":"https://api.github.com/users/splattne","html_url":"https://github.com/splattne","followers_url":"https://api.github.com/users/splattne/followers","following_url":"https://api.github.com/users/splattne/following{/other_user}","gists_url":"https://api.github.com/users/splattne/gists{/gist_id}","starred_url":"https://api.github.com/users/splattne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splattne/subscriptions","organizations_url":"https://api.github.com/users/splattne/orgs","repos_url":"https://api.github.com/users/splattne/repos","events_url":"https://api.github.com/users/splattne/events{/privacy}","received_events_url":"https://api.github.com/users/splattne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/splattne/okayNav","description":"The world's okayest responsive navigation","fork":true,"url":"https://api.github.com/repos/splattne/okayNav","forks_url":"https://api.github.com/repos/splattne/okayNav/forks","keys_url":"https://api.github.com/repos/splattne/okayNav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/splattne/okayNav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/splattne/okayNav/teams","hooks_url":"https://api.github.com/repos/splattne/okayNav/hooks","issue_events_url":"https://api.github.com/repos/splattne/okayNav/issues/events{/number}","events_url":"https://api.github.com/repos/splattne/okayNav/events","assignees_url":"https://api.github.com/repos/splattne/okayNav/assignees{/user}","branches_url":"https://api.github.com/repos/splattne/okayNav/branches{/branch}","tags_url":"https://api.github.com/repos/splattne/okayNav/tags","blobs_url":"https://api.github.com/repos/splattne/okayNav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/splattne/okayNav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/splattne/okayNav/git/refs{/sha}","trees_url":"https://api.github.com/repos/splattne/okayNav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/splattne/okayNav/statuses/{sha}","languages_url":"https://api.github.com/repos/splattne/okayNav/languages","stargazers_url":"https://api.github.com/repos/splattne/okayNav/stargazers","contributors_url":"https://api.github.com/repos/splattne/okayNav/contributors","subscribers_url":"https://api.github.com/repos/splattne/okayNav/subscribers","subscription_url":"https://api.github.com/repos/splattne/okayNav/subscription","commits_url":"https://api.github.com/repos/splattne/okayNav/commits{/sha}","git_commits_url":"https://api.github.com/repos/splattne/okayNav/git/commits{/sha}","comments_url":"https://api.github.com/repos/splattne/okayNav/comments{/number}","issue_comment_url":"https://api.github.com/repos/splattne/okayNav/issues/comments{/number}","contents_url":"https://api.github.com/repos/splattne/okayNav/contents/{+path}","compare_url":"https://api.github.com/repos/splattne/okayNav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/splattne/okayNav/merges","archive_url":"https://api.github.com/repos/splattne/okayNav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/splattne/okayNav/downloads","issues_url":"https://api.github.com/repos/splattne/okayNav/issues{/number}","pulls_url":"https://api.github.com/repos/splattne/okayNav/pulls{/number}","milestones_url":"https://api.github.com/repos/splattne/okayNav/milestones{/number}","notifications_url":"https://api.github.com/repos/splattne/okayNav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/splattne/okayNav/labels{/name}","releases_url":"https://api.github.com/repos/splattne/okayNav/releases{/id}","deployments_url":"https://api.github.com/repos/splattne/okayNav/deployments","created_at":"2016-04-12T10:44:11Z","updated_at":"2016-04-12T10:44:13Z","pushed_at":"2016-04-12T10:46:07Z","git_url":"git://github.com/splattne/okayNav.git","ssh_url":"git@github.com:splattne/okayNav.git","clone_url":"https://github.com/splattne/okayNav.git","svn_url":"https://github.com/splattne/okayNav","homepage":null,"size":2764,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VPenkov:master","ref":"master","sha":"6aee3d44be81efeb22b0640b64a81ac00851badc","user":{"login":"VPenkov","id":1693651,"avatar_url":"https://avatars.githubusercontent.com/u/1693651?v=3","gravatar_id":"","url":"https://api.github.com/users/VPenkov","html_url":"https://github.com/VPenkov","followers_url":"https://api.github.com/users/VPenkov/followers","following_url":"https://api.github.com/users/VPenkov/following{/other_user}","gists_url":"https://api.github.com/users/VPenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VPenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VPenkov/subscriptions","organizations_url":"https://api.github.com/users/VPenkov/orgs","repos_url":"https://api.github.com/users/VPenkov/repos","events_url":"https://api.github.com/users/VPenkov/events{/privacy}","received_events_url":"https://api.github.com/users/VPenkov/received_events","type":"User","site_admin":false},"repo":{"id":51771596,"name":"okayNav","full_name":"VPenkov/okayNav","owner":{"login":"VPenkov","id":1693651,"avatar_url":"https://avatars.githubusercontent.com/u/1693651?v=3","gravatar_id":"","url":"https://api.github.com/users/VPenkov","html_url":"https://github.com/VPenkov","followers_url":"https://api.github.com/users/VPenkov/followers","following_url":"https://api.github.com/users/VPenkov/following{/other_user}","gists_url":"https://api.github.com/users/VPenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VPenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VPenkov/subscriptions","organizations_url":"https://api.github.com/users/VPenkov/orgs","repos_url":"https://api.github.com/users/VPenkov/repos","events_url":"https://api.github.com/users/VPenkov/events{/privacy}","received_events_url":"https://api.github.com/users/VPenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VPenkov/okayNav","description":"The world's okayest responsive navigation","fork":false,"url":"https://api.github.com/repos/VPenkov/okayNav","forks_url":"https://api.github.com/repos/VPenkov/okayNav/forks","keys_url":"https://api.github.com/repos/VPenkov/okayNav/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VPenkov/okayNav/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VPenkov/okayNav/teams","hooks_url":"https://api.github.com/repos/VPenkov/okayNav/hooks","issue_events_url":"https://api.github.com/repos/VPenkov/okayNav/issues/events{/number}","events_url":"https://api.github.com/repos/VPenkov/okayNav/events","assignees_url":"https://api.github.com/repos/VPenkov/okayNav/assignees{/user}","branches_url":"https://api.github.com/repos/VPenkov/okayNav/branches{/branch}","tags_url":"https://api.github.com/repos/VPenkov/okayNav/tags","blobs_url":"https://api.github.com/repos/VPenkov/okayNav/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VPenkov/okayNav/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VPenkov/okayNav/git/refs{/sha}","trees_url":"https://api.github.com/repos/VPenkov/okayNav/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VPenkov/okayNav/statuses/{sha}","languages_url":"https://api.github.com/repos/VPenkov/okayNav/languages","stargazers_url":"https://api.github.com/repos/VPenkov/okayNav/stargazers","contributors_url":"https://api.github.com/repos/VPenkov/okayNav/contributors","subscribers_url":"https://api.github.com/repos/VPenkov/okayNav/subscribers","subscription_url":"https://api.github.com/repos/VPenkov/okayNav/subscription","commits_url":"https://api.github.com/repos/VPenkov/okayNav/commits{/sha}","git_commits_url":"https://api.github.com/repos/VPenkov/okayNav/git/commits{/sha}","comments_url":"https://api.github.com/repos/VPenkov/okayNav/comments{/number}","issue_comment_url":"https://api.github.com/repos/VPenkov/okayNav/issues/comments{/number}","contents_url":"https://api.github.com/repos/VPenkov/okayNav/contents/{+path}","compare_url":"https://api.github.com/repos/VPenkov/okayNav/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VPenkov/okayNav/merges","archive_url":"https://api.github.com/repos/VPenkov/okayNav/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VPenkov/okayNav/downloads","issues_url":"https://api.github.com/repos/VPenkov/okayNav/issues{/number}","pulls_url":"https://api.github.com/repos/VPenkov/okayNav/pulls{/number}","milestones_url":"https://api.github.com/repos/VPenkov/okayNav/milestones{/number}","notifications_url":"https://api.github.com/repos/VPenkov/okayNav/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VPenkov/okayNav/labels{/name}","releases_url":"https://api.github.com/repos/VPenkov/okayNav/releases{/id}","deployments_url":"https://api.github.com/repos/VPenkov/okayNav/deployments","created_at":"2016-02-15T17:12:47Z","updated_at":"2016-05-01T12:31:53Z","pushed_at":"2016-05-01T14:06:29Z","git_url":"git://github.com/VPenkov/okayNav.git","ssh_url":"git@github.com:VPenkov/okayNav.git","clone_url":"https://github.com/VPenkov/okayNav.git","svn_url":"https://github.com/VPenkov/okayNav","homepage":null,"size":2773,"stargazers_count":3689,"watchers_count":3689,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":16,"forks":257,"open_issues":16,"watchers":3689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VPenkov/okayNav/pulls/40"},"html":{"href":"https://github.com/VPenkov/okayNav/pull/40"},"issue":{"href":"https://api.github.com/repos/VPenkov/okayNav/issues/40"},"comments":{"href":"https://api.github.com/repos/VPenkov/okayNav/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/VPenkov/okayNav/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/VPenkov/okayNav/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VPenkov/okayNav/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/VPenkov/okayNav/statuses/960d3e3642617aafb472ba749d06580be4d1d56b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"VPenkov","id":1693651,"avatar_url":"https://avatars.githubusercontent.com/u/1693651?v=3","gravatar_id":"","url":"https://api.github.com/users/VPenkov","html_url":"https://github.com/VPenkov","followers_url":"https://api.github.com/users/VPenkov/followers","following_url":"https://api.github.com/users/VPenkov/following{/other_user}","gists_url":"https://api.github.com/users/VPenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/VPenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VPenkov/subscriptions","organizations_url":"https://api.github.com/users/VPenkov/orgs","repos_url":"https://api.github.com/users/VPenkov/repos","events_url":"https://api.github.com/users/VPenkov/events{/privacy}","received_events_url":"https://api.github.com/users/VPenkov/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":1,"changed_files":1}}