{"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/83617486","pull_request_review_id":4448499,"id":83617486,"diff_hunk":"@@ -112,4 +117,25 @@ public void shouldExposeOnlyMarkedPictureViewsAsRenditions() throws Exception {\n         runtimeHarness.undeployContrib(\"org.nuxeo.ecm.platform.picture.core\",\n                 \"OSGI-INF/imaging-picture-renditions-override.xml\");\n     }\n+\n+    @Test\n+    public void shouldDeclareRenditionDefinitionImageToPDF() {\n+        List<RenditionDefinition> renditionDefinitions = renditionService.getDeclaredRenditionDefinitions();\n+        List<RenditionDefinition> imageToPDFRenditionDefinitions = renditionDefinitions.stream()\n+            .filter(rD -> rD.getName().equals(\"imageToPDF\")).collect(Collectors.toList());\n+        assertEquals(1, imageToPDFRenditionDefinitions.size());\n+        RenditionDefinition imageToPDFRenditionDefinition = imageToPDFRenditionDefinitions.get(0);\n+        assertEquals(\"Image.Blob.ConvertToPDF\", imageToPDFRenditionDefinition.getOperationChain());\n+        assertEquals(1, imageToPDFRenditionDefinition.getFilterIds().size());\n+        assertEquals(\"hasPictureFacet\", imageToPDFRenditionDefinition.getFilterIds().get(0));\n+    }\n+\n+    @Test\n+    public void shouldMakeRenditionAvailableImageToPDF() throws Exception {\n+        Blob source = Blobs.createBlob(FileUtils.getResourceFileFromContext(\"images/test.jpg\"));\n+        DocumentModel doc = session.createDocumentModel(\"/\", \"picture\", \"Picture\");\n+        doc.setProperty(\"file\", \"filename\", source.getFilename());\n+        doc.setProperty(\"file\", \"content\", source);\n+        assertNotNull(renditionService.getRendition(doc, \"imageToPDF\"));","path":"nuxeo-features/nuxeo-platform-imaging/nuxeo-platform-imaging-core/src/test/java/org/nuxeo/ecm/platform/picture/core/test/TestPictureRenditions.java","position":43,"original_position":43,"commit_id":"bf66ff6ecb1de98c9793c7aeaed38d36ac4f2dd9","original_commit_id":"bf66ff6ecb1de98c9793c7aeaed38d36ac4f2dd9","user":{"login":"mnixo","id":4223240,"avatar_url":"https://avatars.githubusercontent.com/u/4223240?v=3","gravatar_id":"","url":"https://api.github.com/users/mnixo","html_url":"https://github.com/mnixo","followers_url":"https://api.github.com/users/mnixo/followers","following_url":"https://api.github.com/users/mnixo/following{/other_user}","gists_url":"https://api.github.com/users/mnixo/gists{/gist_id}","starred_url":"https://api.github.com/users/mnixo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnixo/subscriptions","organizations_url":"https://api.github.com/users/mnixo/orgs","repos_url":"https://api.github.com/users/mnixo/repos","events_url":"https://api.github.com/users/mnixo/events{/privacy}","received_events_url":"https://api.github.com/users/mnixo/received_events","type":"User","site_admin":false},"body":"Exactly. It should be `converter`.\r\nThis test was supposed to verify if given a `Picture` doc the `imageToPDF` rendition is available (so it's independent from the chain parameterization). I'm adding an actual conversion step after that, nonetheless. Thanks!","created_at":"2016-10-17T10:37:41Z","updated_at":"2016-10-17T10:37:41Z","html_url":"https://github.com/nuxeo/nuxeo/pull/287#discussion_r83617486","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments/83617486"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/287#discussion_r83617486"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287","id":89394767,"html_url":"https://github.com/nuxeo/nuxeo/pull/287","diff_url":"https://github.com/nuxeo/nuxeo/pull/287.diff","patch_url":"https://github.com/nuxeo/nuxeo/pull/287.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/287","number":287,"state":"open","locked":false,"title":"feature-NXP-16696-add-pdf-rendition-picture","user":{"login":"mnixo","id":4223240,"avatar_url":"https://avatars.githubusercontent.com/u/4223240?v=3","gravatar_id":"","url":"https://api.github.com/users/mnixo","html_url":"https://github.com/mnixo","followers_url":"https://api.github.com/users/mnixo/followers","following_url":"https://api.github.com/users/mnixo/following{/other_user}","gists_url":"https://api.github.com/users/mnixo/gists{/gist_id}","starred_url":"https://api.github.com/users/mnixo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnixo/subscriptions","organizations_url":"https://api.github.com/users/mnixo/orgs","repos_url":"https://api.github.com/users/mnixo/repos","events_url":"https://api.github.com/users/mnixo/events{/privacy}","received_events_url":"https://api.github.com/users/mnixo/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-14T14:30:15Z","updated_at":"2016-10-17T10:37:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90f730aa0c21aa86d930fedbd736aed0b606febc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/287/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/bf66ff6ecb1de98c9793c7aeaed38d36ac4f2dd9","head":{"label":"nuxeo:feature-NXP-16696-add-pdf-rendition-picture","ref":"feature-NXP-16696-add-pdf-rendition-picture","sha":"bf66ff6ecb1de98c9793c7aeaed38d36ac4f2dd9","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"name":"nuxeo","full_name":"nuxeo/nuxeo","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2016-10-16T06:13:50Z","pushed_at":"2016-10-17T10:17:32Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":253030,"stargazers_count":119,"watchers_count":119,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":24,"forks":89,"open_issues":24,"watchers":119,"default_branch":"master"}},"base":{"label":"nuxeo:master","ref":"master","sha":"af0262b33a06b3b1dbac391d967330974aa0efc7","user":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":2988101,"name":"nuxeo","full_name":"nuxeo/nuxeo","owner":{"login":"nuxeo","id":460607,"avatar_url":"https://avatars.githubusercontent.com/u/460607?v=3","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo","description":"Content management platform to build modern business applications","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo","forks_url":"https://api.github.com/repos/nuxeo/nuxeo/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo/deployments","created_at":"2011-12-15T14:35:41Z","updated_at":"2016-10-16T06:13:50Z","pushed_at":"2016-10-17T10:17:32Z","git_url":"git://github.com/nuxeo/nuxeo.git","ssh_url":"git@github.com:nuxeo/nuxeo.git","clone_url":"https://github.com/nuxeo/nuxeo.git","svn_url":"https://github.com/nuxeo/nuxeo","homepage":"http://www.nuxeo.com","size":253030,"stargazers_count":119,"watchers_count":119,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"open_issues_count":24,"forks":89,"open_issues":24,"watchers":119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287"},"html":{"href":"https://github.com/nuxeo/nuxeo/pull/287"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/287"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo/statuses/bf66ff6ecb1de98c9793c7aeaed38d36ac4f2dd9"}}}}
{"actor":{"display_login":"mnixo"}}