{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28472","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28472/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28472/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28472/events","html_url":"https://github.com/kubernetes/kubernetes/issues/28472","id":163743543,"number":28472,"title":"Clarifying API Guarantee on ListOptions.ResourceVersion","user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-07-04T21:16:32Z","updated_at":"2016-07-05T03:54:37Z","closed_at":null,"body":"Currently in ListOptions, the docs \\[[link](https://github.com/kubernetes/kubernetes/blob/ef0c9f0c5b8efbba948a0be2c98d9d2e32e0b68c/pkg/api/types.go#L2229-L2230)\\] says \"(no effect on list yet)\".\r\n\r\nHowever, in storage.Interface, List API has ResourceVersion ([link](https://github.com/kubernetes/kubernetes/blob/ef0c9f0c5b8efbba948a0be2c98d9d2e32e0b68c/pkg/storage/interfaces.go#L127)):\r\n```\r\nList(ctx context.Context, key string, resourceVersion string, ...)\r\n```\r\n\r\nEven worse, the behaviors are inconsistent. While the implementation in etcd_helper ignores it, cacher uses it and needs to wait until the cached global resource version has caught up.\r\n\r\nWe need to clarify this inconsistent behavior and API guarantee on ListOptions.ResourceVersion. According to the api, we should totally ignore it. If so we shouldn't even have it passed down to storage layer."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/230382711","html_url":"https://github.com/kubernetes/kubernetes/issues/28472#issuecomment-230382711","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/28472","id":230382711,"user":{"login":"hongchaodeng","id":920884,"avatar_url":"https://avatars.githubusercontent.com/u/920884?v=3","gravatar_id":"","url":"https://api.github.com/users/hongchaodeng","html_url":"https://github.com/hongchaodeng","followers_url":"https://api.github.com/users/hongchaodeng/followers","following_url":"https://api.github.com/users/hongchaodeng/following{/other_user}","gists_url":"https://api.github.com/users/hongchaodeng/gists{/gist_id}","starred_url":"https://api.github.com/users/hongchaodeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongchaodeng/subscriptions","organizations_url":"https://api.github.com/users/hongchaodeng/orgs","repos_url":"https://api.github.com/users/hongchaodeng/repos","events_url":"https://api.github.com/users/hongchaodeng/events{/privacy}","received_events_url":"https://api.github.com/users/hongchaodeng/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T03:54:37Z","updated_at":"2016-07-05T03:54:37Z","body":"I would like to add a test for it to make sure on the capabilities/guarantees.\r\nBut I need the exact answer for whether this api:\r\n```Go\r\ntype ListOptions struct {\r\n\t...\r\n\t// The resource version to watch (no effect on list yet)\r\n\tResourceVersion string\r\n}\r\n```\r\nis still right? Yes or no?\r\nIf No, is the behavior on cacher/watch_cache the desired behavior that we should test?"}}
{"actor":{"display_login":"hongchaodeng"}}