{"action":"created","comment":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/56880725","id":56880725,"diff_hunk":"@@ -0,0 +1,186 @@\n+//\n+// Copyright (C) 2016 Google, Inc.\n+//\n+// All rights reserved.\n+//\n+// Redistribution and use in source and binary forms, with or without\n+// modification, are permitted provided that the following conditions\n+// are met:\n+//\n+//    Redistributions of source code must retain the above copyright\n+//    notice, this list of conditions and the following disclaimer.\n+//\n+//    Redistributions in binary form must reproduce the above\n+//    copyright notice, this list of conditions and the following\n+//    disclaimer in the documentation and/or other materials provided\n+//    with the distribution.\n+//\n+//    Neither the name of Google Inc. nor the names of its\n+//    contributors may be used to endorse or promote products derived\n+//    from this software without specific prior written permission.\n+//\n+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+// \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS\n+// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE\n+// COPYRIGHT HOLDERS OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,\n+// INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,\n+// BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+// LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER\n+// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN\n+// ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE\n+// POSSIBILITY OF SUCH DAMAGE.\n+\n+#include <algorithm>\n+\n+#include <gtest/gtest.h>\n+\n+#include \"TestFixture.h\"\n+\n+// We need CMake to provide us the absolute path to the directory containing\n+// test files, so we are certain to find those files no matter where the test\n+// harness binary is generated. This provides out-of-source build capability.\n+#ifndef GLSLANG_TEST_DIRECTORY\n+#error \\\n+    \"GLSLANG_TEST_DIRECTORY needs to be defined for gtest to locate test files.\"\n+#endif\n+\n+namespace glslangtest {\n+namespace {\n+\n+using CompileToSpirvTest = GlslangTest<::testing::TestWithParam<std::string>>;","path":"gtests/Spv.FromFile.cpp","position":44,"original_position":52,"commit_id":"a80673afde1c93902e62f7cc1b4265b822d72a54","original_commit_id":"df203bd895fe79b1d08fbd45f5a84c17aaceb42e","user":{"login":"johnkslang","id":5607714,"avatar_url":"https://avatars.githubusercontent.com/u/5607714?v=3","gravatar_id":"","url":"https://api.github.com/users/johnkslang","html_url":"https://github.com/johnkslang","followers_url":"https://api.github.com/users/johnkslang/followers","following_url":"https://api.github.com/users/johnkslang/following{/other_user}","gists_url":"https://api.github.com/users/johnkslang/gists{/gist_id}","starred_url":"https://api.github.com/users/johnkslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnkslang/subscriptions","organizations_url":"https://api.github.com/users/johnkslang/orgs","repos_url":"https://api.github.com/users/johnkslang/repos","events_url":"https://api.github.com/users/johnkslang/events{/privacy}","received_events_url":"https://api.github.com/users/johnkslang/received_events","type":"User","site_admin":false},"body":"Unfortunately, C++11 isn't all or nothing, it's the subset that works on some older tools.  But, it looks like this has been tested, so things should be okay.","created_at":"2016-03-21T19:20:41Z","updated_at":"2016-03-21T19:20:41Z","html_url":"https://github.com/KhronosGroup/glslang/pull/190#discussion_r56880725","pull_request_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190","_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments/56880725"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/190#discussion_r56880725"},"pull_request":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190","id":61783455,"html_url":"https://github.com/KhronosGroup/glslang/pull/190","diff_url":"https://github.com/KhronosGroup/glslang/pull/190.diff","patch_url":"https://github.com/KhronosGroup/glslang/pull/190.patch","issue_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/190","number":190,"state":"open","locked":false,"title":"Add Google Test as the new test framework","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"body":"Addresses #189.\r\n\r\nThis patch add Google Test as an external project for future unit tests and subsuming the responsibility of `runtests`.","created_at":"2016-03-04T22:50:26Z","updated_at":"2016-03-21T19:20:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4ea31318d25215e53e22b621892cc376fb6ae2e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190/commits","review_comments_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190/comments","review_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/190/comments","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/a80673afde1c93902e62f7cc1b4265b822d72a54","head":{"label":"antiagainst:gtest","ref":"gtest","sha":"a80673afde1c93902e62f7cc1b4265b822d72a54","user":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"repo":{"id":38177324,"name":"glslang","full_name":"antiagainst/glslang","owner":{"login":"antiagainst","id":487928,"avatar_url":"https://avatars.githubusercontent.com/u/487928?v=3","gravatar_id":"","url":"https://api.github.com/users/antiagainst","html_url":"https://github.com/antiagainst","followers_url":"https://api.github.com/users/antiagainst/followers","following_url":"https://api.github.com/users/antiagainst/following{/other_user}","gists_url":"https://api.github.com/users/antiagainst/gists{/gist_id}","starred_url":"https://api.github.com/users/antiagainst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antiagainst/subscriptions","organizations_url":"https://api.github.com/users/antiagainst/orgs","repos_url":"https://api.github.com/users/antiagainst/repos","events_url":"https://api.github.com/users/antiagainst/events{/privacy}","received_events_url":"https://api.github.com/users/antiagainst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/antiagainst/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":true,"url":"https://api.github.com/repos/antiagainst/glslang","forks_url":"https://api.github.com/repos/antiagainst/glslang/forks","keys_url":"https://api.github.com/repos/antiagainst/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/antiagainst/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/antiagainst/glslang/teams","hooks_url":"https://api.github.com/repos/antiagainst/glslang/hooks","issue_events_url":"https://api.github.com/repos/antiagainst/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/antiagainst/glslang/events","assignees_url":"https://api.github.com/repos/antiagainst/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/antiagainst/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/antiagainst/glslang/tags","blobs_url":"https://api.github.com/repos/antiagainst/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/antiagainst/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/antiagainst/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/antiagainst/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/antiagainst/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/antiagainst/glslang/languages","stargazers_url":"https://api.github.com/repos/antiagainst/glslang/stargazers","contributors_url":"https://api.github.com/repos/antiagainst/glslang/contributors","subscribers_url":"https://api.github.com/repos/antiagainst/glslang/subscribers","subscription_url":"https://api.github.com/repos/antiagainst/glslang/subscription","commits_url":"https://api.github.com/repos/antiagainst/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/antiagainst/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/antiagainst/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/antiagainst/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/antiagainst/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/antiagainst/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/antiagainst/glslang/merges","archive_url":"https://api.github.com/repos/antiagainst/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/antiagainst/glslang/downloads","issues_url":"https://api.github.com/repos/antiagainst/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/antiagainst/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/antiagainst/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/antiagainst/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/antiagainst/glslang/labels{/name}","releases_url":"https://api.github.com/repos/antiagainst/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/antiagainst/glslang/deployments","created_at":"2015-06-27T22:18:05Z","updated_at":"2016-01-26T23:13:55Z","pushed_at":"2016-03-21T15:46:30Z","git_url":"git://github.com/antiagainst/glslang.git","ssh_url":"git@github.com:antiagainst/glslang.git","clone_url":"https://github.com/antiagainst/glslang.git","svn_url":"https://github.com/antiagainst/glslang","homepage":null,"size":24614,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KhronosGroup:master","ref":"master","sha":"6d2b07dc3952739b7d540cc326a21eff8c3ef935","user":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":38064932,"name":"glslang","full_name":"KhronosGroup/glslang","owner":{"login":"KhronosGroup","id":1608701,"avatar_url":"https://avatars.githubusercontent.com/u/1608701?v=3","gravatar_id":"","url":"https://api.github.com/users/KhronosGroup","html_url":"https://github.com/KhronosGroup","followers_url":"https://api.github.com/users/KhronosGroup/followers","following_url":"https://api.github.com/users/KhronosGroup/following{/other_user}","gists_url":"https://api.github.com/users/KhronosGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/KhronosGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KhronosGroup/subscriptions","organizations_url":"https://api.github.com/users/KhronosGroup/orgs","repos_url":"https://api.github.com/users/KhronosGroup/repos","events_url":"https://api.github.com/users/KhronosGroup/events{/privacy}","received_events_url":"https://api.github.com/users/KhronosGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KhronosGroup/glslang","description":"Khronos reference front-end for GLSL and ESSL","fork":false,"url":"https://api.github.com/repos/KhronosGroup/glslang","forks_url":"https://api.github.com/repos/KhronosGroup/glslang/forks","keys_url":"https://api.github.com/repos/KhronosGroup/glslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KhronosGroup/glslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KhronosGroup/glslang/teams","hooks_url":"https://api.github.com/repos/KhronosGroup/glslang/hooks","issue_events_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/events{/number}","events_url":"https://api.github.com/repos/KhronosGroup/glslang/events","assignees_url":"https://api.github.com/repos/KhronosGroup/glslang/assignees{/user}","branches_url":"https://api.github.com/repos/KhronosGroup/glslang/branches{/branch}","tags_url":"https://api.github.com/repos/KhronosGroup/glslang/tags","blobs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KhronosGroup/glslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KhronosGroup/glslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/KhronosGroup/glslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KhronosGroup/glslang/statuses/{sha}","languages_url":"https://api.github.com/repos/KhronosGroup/glslang/languages","stargazers_url":"https://api.github.com/repos/KhronosGroup/glslang/stargazers","contributors_url":"https://api.github.com/repos/KhronosGroup/glslang/contributors","subscribers_url":"https://api.github.com/repos/KhronosGroup/glslang/subscribers","subscription_url":"https://api.github.com/repos/KhronosGroup/glslang/subscription","commits_url":"https://api.github.com/repos/KhronosGroup/glslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/KhronosGroup/glslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/KhronosGroup/glslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/KhronosGroup/glslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/KhronosGroup/glslang/contents/{+path}","compare_url":"https://api.github.com/repos/KhronosGroup/glslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KhronosGroup/glslang/merges","archive_url":"https://api.github.com/repos/KhronosGroup/glslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KhronosGroup/glslang/downloads","issues_url":"https://api.github.com/repos/KhronosGroup/glslang/issues{/number}","pulls_url":"https://api.github.com/repos/KhronosGroup/glslang/pulls{/number}","milestones_url":"https://api.github.com/repos/KhronosGroup/glslang/milestones{/number}","notifications_url":"https://api.github.com/repos/KhronosGroup/glslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KhronosGroup/glslang/labels{/name}","releases_url":"https://api.github.com/repos/KhronosGroup/glslang/releases{/id}","deployments_url":"https://api.github.com/repos/KhronosGroup/glslang/deployments","created_at":"2015-06-25T17:54:39Z","updated_at":"2016-03-21T06:39:21Z","pushed_at":"2016-03-21T18:59:20Z","git_url":"git://github.com/KhronosGroup/glslang.git","ssh_url":"git@github.com:KhronosGroup/glslang.git","clone_url":"https://github.com/KhronosGroup/glslang.git","svn_url":"https://github.com/KhronosGroup/glslang","homepage":null,"size":25543,"stargazers_count":226,"watchers_count":226,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":48,"forks":75,"open_issues":48,"watchers":226,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190"},"html":{"href":"https://github.com/KhronosGroup/glslang/pull/190"},"issue":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/190"},"comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KhronosGroup/glslang/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/KhronosGroup/glslang/statuses/a80673afde1c93902e62f7cc1b4265b822d72a54"}}}}