{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/91147056","pull_request_review_id":11655808,"id":91147056,"diff_hunk":"@@ -408,14 +410,16 @@ func (proxier *Proxier) Sync() {\n \tproxier.mu.Lock()\n \tdefer proxier.mu.Unlock()\n \tproxier.syncProxyRules()\n+\tproxier.timer.Stop()","path":"pkg/proxy/iptables/proxier.go","position":13,"original_position":13,"commit_id":"ee3b1dc9cd45bd7251667ba9cb8363add5d757a5","original_commit_id":"9ae62e381608c3d13fe6dcd4e44f28b32826e8d0","user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"body":"comment on this?  Or maybe rename to `sync` or `syncOnce`","created_at":"2016-12-06T19:00:26Z","updated_at":"2016-12-06T19:00:26Z","html_url":"https://github.com/kubernetes/kubernetes/pull/37726#discussion_r91147056","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/91147056"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37726#discussion_r91147056"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726","id":95997127,"html_url":"https://github.com/kubernetes/kubernetes/pull/37726","diff_url":"https://github.com/kubernetes/kubernetes/pull/37726.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37726.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37726","number":37726,"state":"open","locked":false,"title":"[kube-proxy] Fix for non-blocking updates during min-sync-period","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAddresses the issue that was seen in #36281 \r\n\r\nRelated: #36332 \r\nRelated: #35334\r\n\r\n/cc @thockin @bprashanth @jeremyeder \r\n\r\n**Special notes for your reviewer**:\r\nFollow on PR from #35334\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access) \r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. \r\n-->\r\n\r\n```\r\nNONE\r\n```\r\n\r\n","created_at":"2016-11-30T23:37:35Z","updated_at":"2016-12-06T19:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f017025b92ca96370ba4a78eba405f4c0274c73e","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"assignees":[{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"bprashanth","id":10927820,"avatar_url":"https://avatars.githubusercontent.com/u/10927820?v=3","gravatar_id":"","url":"https://api.github.com/users/bprashanth","html_url":"https://github.com/bprashanth","followers_url":"https://api.github.com/users/bprashanth/followers","following_url":"https://api.github.com/users/bprashanth/following{/other_user}","gists_url":"https://api.github.com/users/bprashanth/gists{/gist_id}","starred_url":"https://api.github.com/users/bprashanth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bprashanth/subscriptions","organizations_url":"https://api.github.com/users/bprashanth/orgs","repos_url":"https://api.github.com/users/bprashanth/repos","events_url":"https://api.github.com/users/bprashanth/events{/privacy}","received_events_url":"https://api.github.com/users/bprashanth/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.5","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/23/labels","id":1945978,"number":23,"title":"v1.5","description":"","creator":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"open_issues":110,"closed_issues":966,"state":"open","created_at":"2016-08-16T21:47:28Z","updated_at":"2016-12-06T14:32:22Z","due_on":"2016-12-09T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37726/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ee3b1dc9cd45bd7251667ba9cb8363add5d757a5","head":{"label":"timothysc:proxy_min_sync_fix","ref":"proxy_min_sync_fix","sha":"ee3b1dc9cd45bd7251667ba9cb8363add5d757a5","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"repo":{"id":28345483,"name":"kubernetes","full_name":"timothysc/kubernetes","owner":{"login":"timothysc","id":169553,"avatar_url":"https://avatars.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timothysc/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/timothysc/kubernetes","forks_url":"https://api.github.com/repos/timothysc/kubernetes/forks","keys_url":"https://api.github.com/repos/timothysc/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timothysc/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timothysc/kubernetes/teams","hooks_url":"https://api.github.com/repos/timothysc/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/timothysc/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/timothysc/kubernetes/events","assignees_url":"https://api.github.com/repos/timothysc/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/timothysc/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/timothysc/kubernetes/tags","blobs_url":"https://api.github.com/repos/timothysc/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timothysc/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timothysc/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/timothysc/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timothysc/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/timothysc/kubernetes/languages","stargazers_url":"https://api.github.com/repos/timothysc/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/timothysc/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/timothysc/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/timothysc/kubernetes/subscription","commits_url":"https://api.github.com/repos/timothysc/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/timothysc/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/timothysc/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/timothysc/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/timothysc/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/timothysc/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timothysc/kubernetes/merges","archive_url":"https://api.github.com/repos/timothysc/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timothysc/kubernetes/downloads","issues_url":"https://api.github.com/repos/timothysc/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/timothysc/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/timothysc/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/timothysc/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timothysc/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/timothysc/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/timothysc/kubernetes/deployments","created_at":"2014-12-22T15:52:58Z","updated_at":"2015-03-06T19:21:46Z","pushed_at":"2016-12-05T21:16:00Z","git_url":"git://github.com/timothysc/kubernetes.git","ssh_url":"git@github.com:timothysc/kubernetes.git","clone_url":"https://github.com/timothysc/kubernetes.git","svn_url":"https://github.com/timothysc/kubernetes","homepage":null,"size":354854,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"55f13b5729a81ae23e17970bd5b857bf15d893bf","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-12-06T16:23:09Z","pushed_at":"2016-12-06T18:53:58Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":660423,"stargazers_count":18931,"watchers_count":18931,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6294,"mirror_url":null,"open_issues_count":5377,"forks":6294,"open_issues":5377,"watchers":18931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/37726"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37726"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/37726/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37726/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ee3b1dc9cd45bd7251667ba9cb8363add5d757a5"}}}}
{"actor":{"display_login":"thockin"}}