{"action":"opened","issue":{"url":"https://api.github.com/repos/mslegrand/pointR/issues/14","repository_url":"https://api.github.com/repos/mslegrand/pointR","labels_url":"https://api.github.com/repos/mslegrand/pointR/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/mslegrand/pointR/issues/14/comments","events_url":"https://api.github.com/repos/mslegrand/pointR/issues/14/events","html_url":"https://github.com/mslegrand/pointR/issues/14","id":177235383,"number":14,"title":"Change the  tagging behaviour for frequency >0","user":{"login":"mslegrand","id":5139775,"avatar_url":"https://avatars.githubusercontent.com/u/5139775?v=3","gravatar_id":"","url":"https://api.github.com/users/mslegrand","html_url":"https://github.com/mslegrand","followers_url":"https://api.github.com/users/mslegrand/followers","following_url":"https://api.github.com/users/mslegrand/following{/other_user}","gists_url":"https://api.github.com/users/mslegrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mslegrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mslegrand/subscriptions","organizations_url":"https://api.github.com/users/mslegrand/orgs","repos_url":"https://api.github.com/users/mslegrand/repos","events_url":"https://api.github.com/users/mslegrand/events{/privacy}","received_events_url":"https://api.github.com/users/mslegrand/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-09-15T17:20:55Z","updated_at":"2016-09-15T17:20:55Z","closed_at":null,"body":"**Proposed changes to tagging frequency** \r\n\r\n1. Tag frequency is set (fixed) during the first tagging operation. \r\nIn particular, when first tagged, a popup modal will ask for frequency and \r\n    confirmation. \r\n2. If the tag frequency is set to a period p>0, (aka. periodic tagging) then all subsequent\r\nindices that are 1 mod p are to be tagged.\r\n3. Periodic tagging makes no exceptions, thus deleting a point or inserting a point does not change  the indices, (unless at the end).\r\nRather the points associated with the tags, change instead.\r\n In particular, if a tagged point is deleted, the next point becomes tagged, and the tagging data frame remains intact except for possibly\r\nthe last row. If the tag index of the last row exceeds the number of points, that row is deleted.  A similar situation occurs for insertion\r\nof a point. \r\n\r\n**Note** Requirement 3, appears simpler, but actually creates a new case. Formerly, both manual and periodic\r\ninserts and deletes were handled identically (except for the addition of a tag when necessary). Now they are not.\r\n\r\n\r\nImplementation changes required for the above\r\n1. modulePointsBar tagFreq selectInput, becomes an output (readonly)\r\n2. serverMouseClicks::observe input$mouseMssg : cmd= add, delete are to be rewritten\r\n\r\n3. serverPlotBarPoints::observe pointInfoList$tagFreq() needs to be rewritten\r\n    A. popup modal to ask for frequency and confirmation\r\n    B. tag button is hidden (or disabled) for freq>0.\r\n        "}}
{"actor":{"display_login":"mslegrand"}}