{"action":"created","issue":{"url":"https://api.github.com/repos/FAForever/fa/issues/1590","repository_url":"https://api.github.com/repos/FAForever/fa","labels_url":"https://api.github.com/repos/FAForever/fa/issues/1590/labels{/name}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/1590/comments","events_url":"https://api.github.com/repos/FAForever/fa/issues/1590/events","html_url":"https://github.com/FAForever/fa/pull/1590","id":181760878,"number":1590,"title":"Fix/share conditions","user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/FAForever/fa/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-07T20:29:22Z","updated_at":"2016-10-10T12:10:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/1590","html_url":"https://github.com/FAForever/fa/pull/1590","diff_url":"https://github.com/FAForever/fa/pull/1590.diff","patch_url":"https://github.com/FAForever/fa/pull/1590.patch"},"body":"Hashtag noticed that EcoManager bypassed the new modes because it auto-gives units when you die. This accounts for that by simply gifting them back to you, then carrying out the main mode action.\r\n\r\nIt also includes a change, killing walls when players die. I suspect they were excluded because the sheer count of walls might crash the game when trying to cycle through the GetListOfUnits table. I hope that by doing the walls on their own, and by forking the thread to happen while the main one waits, we will nullify this concern."},"comment":{"url":"https://api.github.com/repos/FAForever/fa/issues/comments/252600596","html_url":"https://github.com/FAForever/fa/pull/1590#issuecomment-252600596","issue_url":"https://api.github.com/repos/FAForever/fa/issues/1590","id":252600596,"user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"created_at":"2016-10-10T12:10:59Z","updated_at":"2016-10-10T12:10:59Z","body":"Yup, the regression was only for the new modes. For SUD, code in SimUtils is called that kills everything with unit.oldowner == selfIIndex, but for the new modes I made the decision that it would be nice if previously gifted units weren't affects. I didn't consider into my decision the existence of auto-give, which would of course then make the new modes useless. This corrects that."}}
{"actor":{"display_login":"aeoncleanse"}}