{"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments/52936672","id":52936672,"diff_hunk":"@@ -556,6 +602,16 @@ def _on_screen_register_finished(self, obj):\n         It may need to auto attach, etc. The 'finished' signal indicates register\n         and attach are finished, while 'register-finished' is just the first part.\"\"\"\n \n+        # if self.info.get_property('server-info-changed'):","path":"src/subscription_manager/gui/registergui.py","position":73,"original_position":108,"commit_id":"49f03afae1ff3f7b1ec03059538e4fdfbf04e60f","original_commit_id":"ccd9b51cddd53349bfa45a85f93fcee70f00de24","user":{"login":"alikins","id":15162,"avatar_url":"https://avatars.githubusercontent.com/u/15162?v=3","gravatar_id":"","url":"https://api.github.com/users/alikins","html_url":"https://github.com/alikins","followers_url":"https://api.github.com/users/alikins/followers","following_url":"https://api.github.com/users/alikins/following{/other_user}","gists_url":"https://api.github.com/users/alikins/gists{/gist_id}","starred_url":"https://api.github.com/users/alikins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alikins/subscriptions","organizations_url":"https://api.github.com/users/alikins/orgs","repos_url":"https://api.github.com/users/alikins/repos","events_url":"https://api.github.com/users/alikins/events{/privacy}","received_events_url":"https://api.github.com/users/alikins/received_events","type":"User","site_admin":false},"body":"I think the current 'RegisterWidget._on_connection_info_changed' should be replaced with 'RegisterWidget._on_server_info_changed'. Changes to RegisterInfo's 'server-info' will trigger that callback\r\n(if the current handlers for serverInfo's 'notify::hostname' signals (and friends) are updated for server-info).\r\n\r\nAlways persisting the config post register seems correct to me. \r\n\r\nBut, I think this may make more sense in a handler for RegisterWidget's 'register-finished' instead of it's handler for each screens 'screen-register-finished'. Ie, I think this should move to RegisterWidget.do_register_finished()\r\n \r\n(The Screens emit a 'screen-register-finished' that is handled by RegisterWidget._on_screen_register_finished, which then makes RegisterWidget emit it's 'register-finished'. The RegisterWidget.do_register_finished will then be\r\nthe first handle called (even before a handler setup by a parent dialog like RegisterDialog). Given config doesn't seem like something that a different parent dialog should need to have to change, RegisterWidget.do_register_finished() seems reasonable).","created_at":"2016-02-15T19:38:52Z","updated_at":"2016-02-15T19:38:52Z","html_url":"https://github.com/candlepin/subscription-manager/pull/1385#discussion_r52936672","pull_request_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385","_links":{"self":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments/52936672"},"html":{"href":"https://github.com/candlepin/subscription-manager/pull/1385#discussion_r52936672"},"pull_request":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385"}}},"pull_request":{"url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385","id":59382933,"html_url":"https://github.com/candlepin/subscription-manager/pull/1385","diff_url":"https://github.com/candlepin/subscription-manager/pull/1385.diff","patch_url":"https://github.com/candlepin/subscription-manager/pull/1385.patch","issue_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/1385","number":1385,"state":"open","locked":false,"title":"1302775: Ensure all screens are displayed in firstboot.","user":{"login":"cnsnyder","id":7536566,"avatar_url":"https://avatars.githubusercontent.com/u/7536566?v=3","gravatar_id":"","url":"https://api.github.com/users/cnsnyder","html_url":"https://github.com/cnsnyder","followers_url":"https://api.github.com/users/cnsnyder/followers","following_url":"https://api.github.com/users/cnsnyder/following{/other_user}","gists_url":"https://api.github.com/users/cnsnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/cnsnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnsnyder/subscriptions","organizations_url":"https://api.github.com/users/cnsnyder/orgs","repos_url":"https://api.github.com/users/cnsnyder/repos","events_url":"https://api.github.com/users/cnsnyder/events{/privacy}","received_events_url":"https://api.github.com/users/cnsnyder/received_events","type":"User","site_admin":false},"body":"This PR is for the fix to BZ 1302775. It is still a work in progress.","created_at":"2016-02-15T16:06:17Z","updated_at":"2016-02-15T19:38:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5340989ba12c87d4fde1e3c39c565b35fd6c6fcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385/commits","review_comments_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385/comments","review_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/1385/comments","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/49f03afae1ff3f7b1ec03059538e4fdfbf04e60f","head":{"label":"candlepin:csnyder/firstboot_nav_fix","ref":"csnyder/firstboot_nav_fix","sha":"49f03afae1ff3f7b1ec03059538e4fdfbf04e60f","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4360334,"name":"subscription-manager","full_name":"candlepin/subscription-manager","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/subscription-manager","description":"A GUI and CLI client for Candlepin","fork":false,"url":"https://api.github.com/repos/candlepin/subscription-manager","forks_url":"https://api.github.com/repos/candlepin/subscription-manager/forks","keys_url":"https://api.github.com/repos/candlepin/subscription-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/subscription-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/subscription-manager/teams","hooks_url":"https://api.github.com/repos/candlepin/subscription-manager/hooks","issue_events_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/subscription-manager/events","assignees_url":"https://api.github.com/repos/candlepin/subscription-manager/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/subscription-manager/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/subscription-manager/tags","blobs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/subscription-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/subscription-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/subscription-manager/languages","stargazers_url":"https://api.github.com/repos/candlepin/subscription-manager/stargazers","contributors_url":"https://api.github.com/repos/candlepin/subscription-manager/contributors","subscribers_url":"https://api.github.com/repos/candlepin/subscription-manager/subscribers","subscription_url":"https://api.github.com/repos/candlepin/subscription-manager/subscription","commits_url":"https://api.github.com/repos/candlepin/subscription-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/subscription-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/subscription-manager/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/subscription-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/subscription-manager/merges","archive_url":"https://api.github.com/repos/candlepin/subscription-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/subscription-manager/downloads","issues_url":"https://api.github.com/repos/candlepin/subscription-manager/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/subscription-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/subscription-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/subscription-manager/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/subscription-manager/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/subscription-manager/deployments","created_at":"2012-05-17T16:13:30Z","updated_at":"2016-01-11T19:01:49Z","pushed_at":"2016-02-15T19:37:53Z","git_url":"git://github.com/candlepin/subscription-manager.git","ssh_url":"git@github.com:candlepin/subscription-manager.git","clone_url":"https://github.com/candlepin/subscription-manager.git","svn_url":"https://github.com/candlepin/subscription-manager","homepage":"http://candlepinproject.org/","size":32309,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":10,"forks":28,"open_issues":10,"watchers":14,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"87148e677acd5064d00265756dad63d04e011e3e","user":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4360334,"name":"subscription-manager","full_name":"candlepin/subscription-manager","owner":{"login":"candlepin","id":1749632,"avatar_url":"https://avatars.githubusercontent.com/u/1749632?v=3","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/candlepin/subscription-manager","description":"A GUI and CLI client for Candlepin","fork":false,"url":"https://api.github.com/repos/candlepin/subscription-manager","forks_url":"https://api.github.com/repos/candlepin/subscription-manager/forks","keys_url":"https://api.github.com/repos/candlepin/subscription-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/subscription-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/subscription-manager/teams","hooks_url":"https://api.github.com/repos/candlepin/subscription-manager/hooks","issue_events_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/subscription-manager/events","assignees_url":"https://api.github.com/repos/candlepin/subscription-manager/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/subscription-manager/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/subscription-manager/tags","blobs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/subscription-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/subscription-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/subscription-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/subscription-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/subscription-manager/languages","stargazers_url":"https://api.github.com/repos/candlepin/subscription-manager/stargazers","contributors_url":"https://api.github.com/repos/candlepin/subscription-manager/contributors","subscribers_url":"https://api.github.com/repos/candlepin/subscription-manager/subscribers","subscription_url":"https://api.github.com/repos/candlepin/subscription-manager/subscription","commits_url":"https://api.github.com/repos/candlepin/subscription-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/subscription-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/subscription-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/subscription-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/subscription-manager/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/subscription-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/subscription-manager/merges","archive_url":"https://api.github.com/repos/candlepin/subscription-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/subscription-manager/downloads","issues_url":"https://api.github.com/repos/candlepin/subscription-manager/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/subscription-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/subscription-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/subscription-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/subscription-manager/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/subscription-manager/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/subscription-manager/deployments","created_at":"2012-05-17T16:13:30Z","updated_at":"2016-01-11T19:01:49Z","pushed_at":"2016-02-15T19:37:53Z","git_url":"git://github.com/candlepin/subscription-manager.git","ssh_url":"git@github.com:candlepin/subscription-manager.git","clone_url":"https://github.com/candlepin/subscription-manager.git","svn_url":"https://github.com/candlepin/subscription-manager","homepage":"http://candlepinproject.org/","size":32309,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":10,"forks":28,"open_issues":10,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385"},"html":{"href":"https://github.com/candlepin/subscription-manager/pull/1385"},"issue":{"href":"https://api.github.com/repos/candlepin/subscription-manager/issues/1385"},"comments":{"href":"https://api.github.com/repos/candlepin/subscription-manager/issues/1385/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/subscription-manager/pulls/1385/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/subscription-manager/statuses/49f03afae1ff3f7b1ec03059538e4fdfbf04e60f"}}}}