{"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/66727111","id":66727111,"diff_hunk":"@@ -488,7 +488,8 @@ void TrackerFiltersList::addItem(const QString &tracker, const QString &hash)\n         trackerItem = new QListWidgetItem();\n         trackerItem->setData(Qt::DecorationRole, GuiIconProvider::instance()->getIcon(\"network-server\"));\n \n-        downloadFavicon(QString(\"http://%1/favicon.ico\").arg(host));\n+        if(Preferences::instance()->isLoadFaviconsEnabled())","path":"src/gui/transferlistfilterswidget.cpp","position":5,"original_position":5,"commit_id":"ea8ce6f51475bf481f2543026c31fc4c5ee2eab4","original_commit_id":"ea8ce6f51475bf481f2543026c31fc4c5ee2eab4","user":{"login":"sledgehammer999","id":273315,"avatar_url":"https://avatars.githubusercontent.com/u/273315?v=3","gravatar_id":"","url":"https://api.github.com/users/sledgehammer999","html_url":"https://github.com/sledgehammer999","followers_url":"https://api.github.com/users/sledgehammer999/followers","following_url":"https://api.github.com/users/sledgehammer999/following{/other_user}","gists_url":"https://api.github.com/users/sledgehammer999/gists{/gist_id}","starred_url":"https://api.github.com/users/sledgehammer999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sledgehammer999/subscriptions","organizations_url":"https://api.github.com/users/sledgehammer999/orgs","repos_url":"https://api.github.com/users/sledgehammer999/repos","events_url":"https://api.github.com/users/sledgehammer999/events{/privacy}","received_events_url":"https://api.github.com/users/sledgehammer999/received_events","type":"User","site_admin":false},"body":"Good point. But this will be a \"tough\" one to implement cleanly. All the classes in that file are simple enough.\r\n@slin31 here is what you have to look for Preferences class has a `changed()` signal. You need to connect to that and chance your local value(which is created/cached in the constructor of TrackerFiltersList probably).","created_at":"2016-06-12T20:53:44Z","updated_at":"2016-06-12T20:53:44Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/5365#discussion_r66727111","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/66727111"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/5365#discussion_r66727111"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365"}}},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365","id":73483052,"html_url":"https://github.com/qbittorrent/qBittorrent/pull/5365","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/5365.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/5365.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/5365","number":5365,"state":"open","locked":false,"title":"Add option to disable downloading of tracker favicons. Closes #5286","user":{"login":"slin31","id":8920528,"avatar_url":"https://avatars.githubusercontent.com/u/8920528?v=3","gravatar_id":"","url":"https://api.github.com/users/slin31","html_url":"https://github.com/slin31","followers_url":"https://api.github.com/users/slin31/followers","following_url":"https://api.github.com/users/slin31/following{/other_user}","gists_url":"https://api.github.com/users/slin31/gists{/gist_id}","starred_url":"https://api.github.com/users/slin31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slin31/subscriptions","organizations_url":"https://api.github.com/users/slin31/orgs","repos_url":"https://api.github.com/users/slin31/repos","events_url":"https://api.github.com/users/slin31/events{/privacy}","received_events_url":"https://api.github.com/users/slin31/received_events","type":"User","site_admin":false},"body":"This adds a feature that allows people to toggle if the tracker favicons are downloaded or if the default placeholder is used.\r\nThis closes #5286.\r\nHere you can see the difference between loaded favicons and the placeholder:\r\n![2016-06-12_03 19 25](https://cloud.githubusercontent.com/assets/8920528/15988354/38310cc0-304d-11e6-872d-e12992430411.png)\r\n\r\nAnd the checkbox in the Options menu:\r\n![2016-06-12_03 19 53](https://cloud.githubusercontent.com/assets/8920528/15988355/4d4e872c-304d-11e6-9b16-924aec4b3b6a.png)\r\n\r\nThis is my first pullrequest here, please let me know if there is anything I could do better.","created_at":"2016-06-12T01:27:43Z","updated_at":"2016-06-12T20:53:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe38bdb38db716213032df91a173e927e4c90f36","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/5365/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/ea8ce6f51475bf481f2543026c31fc4c5ee2eab4","head":{"label":"slin31:load-favicon-option","ref":"load-favicon-option","sha":"ea8ce6f51475bf481f2543026c31fc4c5ee2eab4","user":{"login":"slin31","id":8920528,"avatar_url":"https://avatars.githubusercontent.com/u/8920528?v=3","gravatar_id":"","url":"https://api.github.com/users/slin31","html_url":"https://github.com/slin31","followers_url":"https://api.github.com/users/slin31/followers","following_url":"https://api.github.com/users/slin31/following{/other_user}","gists_url":"https://api.github.com/users/slin31/gists{/gist_id}","starred_url":"https://api.github.com/users/slin31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slin31/subscriptions","organizations_url":"https://api.github.com/users/slin31/orgs","repos_url":"https://api.github.com/users/slin31/repos","events_url":"https://api.github.com/users/slin31/events{/privacy}","received_events_url":"https://api.github.com/users/slin31/received_events","type":"User","site_admin":false},"repo":{"id":60881182,"name":"qBittorrent","full_name":"slin31/qBittorrent","owner":{"login":"slin31","id":8920528,"avatar_url":"https://avatars.githubusercontent.com/u/8920528?v=3","gravatar_id":"","url":"https://api.github.com/users/slin31","html_url":"https://github.com/slin31","followers_url":"https://api.github.com/users/slin31/followers","following_url":"https://api.github.com/users/slin31/following{/other_user}","gists_url":"https://api.github.com/users/slin31/gists{/gist_id}","starred_url":"https://api.github.com/users/slin31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slin31/subscriptions","organizations_url":"https://api.github.com/users/slin31/orgs","repos_url":"https://api.github.com/users/slin31/repos","events_url":"https://api.github.com/users/slin31/events{/privacy}","received_events_url":"https://api.github.com/users/slin31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slin31/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/slin31/qBittorrent","forks_url":"https://api.github.com/repos/slin31/qBittorrent/forks","keys_url":"https://api.github.com/repos/slin31/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slin31/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slin31/qBittorrent/teams","hooks_url":"https://api.github.com/repos/slin31/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/slin31/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/slin31/qBittorrent/events","assignees_url":"https://api.github.com/repos/slin31/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/slin31/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/slin31/qBittorrent/tags","blobs_url":"https://api.github.com/repos/slin31/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slin31/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slin31/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/slin31/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slin31/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/slin31/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/slin31/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/slin31/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/slin31/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/slin31/qBittorrent/subscription","commits_url":"https://api.github.com/repos/slin31/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/slin31/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/slin31/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/slin31/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/slin31/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/slin31/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slin31/qBittorrent/merges","archive_url":"https://api.github.com/repos/slin31/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slin31/qBittorrent/downloads","issues_url":"https://api.github.com/repos/slin31/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/slin31/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/slin31/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/slin31/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slin31/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/slin31/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/slin31/qBittorrent/deployments","created_at":"2016-06-10T22:49:28Z","updated_at":"2016-06-10T22:49:32Z","pushed_at":"2016-06-12T01:13:11Z","git_url":"git://github.com/slin31/qBittorrent.git","ssh_url":"git@github.com:slin31/qBittorrent.git","clone_url":"https://github.com/slin31/qBittorrent.git","svn_url":"https://github.com/slin31/qBittorrent","homepage":"http://www.qbittorrent.org","size":129478,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"d060b0d342607af04b6f4e62294d8935bb89dc33","user":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"name":"qBittorrent","full_name":"qbittorrent/qBittorrent","owner":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/deployments","created_at":"2012-02-04T09:37:46Z","updated_at":"2016-06-12T01:53:16Z","pushed_at":"2016-06-12T14:30:19Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"git@github.com:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"http://www.qbittorrent.org","size":138687,"stargazers_count":1785,"watchers_count":1785,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":481,"mirror_url":null,"open_issues_count":1562,"forks":481,"open_issues":1562,"watchers":1785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/5365"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/5365"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/5365/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/5365/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/ea8ce6f51475bf481f2543026c31fc4c5ee2eab4"}}}}
{"actor":{"display_login":"sledgehammer999"}}