{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/elide/pulls/comments/59578691","id":59578691,"diff_hunk":"@@ -238,14 +238,15 @@ public void commit() {\n             joinCriteria(sessionCriteria, loadClass);\n         }\n \n+        sessionCriteria.setResultTransformer(Criteria.DISTINCT_ROOT_ENTITY);\n         if (!isScrollEnabled || isJoinQuery()) {\n             return sessionCriteria.list();\n         }\n         return new ScrollableIterator(sessionCriteria.scroll(scrollMode));\n     }\n \n     /**\n-     * Should this transaction use JOINs. By default will be enabled if Sparse fields are available.\n+     * Should this transaction use JOINs. By default will be enabled only if parameter <code>join=true</code>.","path":"elide-datastore/elide-datastore-hibernate3/src/main/java/com/yahoo/elide/datastores/hibernate3/HibernateTransaction.java","position":13,"original_position":13,"commit_id":"6f120dfa52f9bc3b66da922c6d48190ef010dfa2","original_commit_id":"6f120dfa52f9bc3b66da922c6d48190ef010dfa2","user":{"login":"DeathByTape","id":732305,"avatar_url":"https://avatars.githubusercontent.com/u/732305?v=3","gravatar_id":"","url":"https://api.github.com/users/DeathByTape","html_url":"https://github.com/DeathByTape","followers_url":"https://api.github.com/users/DeathByTape/followers","following_url":"https://api.github.com/users/DeathByTape/following{/other_user}","gists_url":"https://api.github.com/users/DeathByTape/gists{/gist_id}","starred_url":"https://api.github.com/users/DeathByTape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeathByTape/subscriptions","organizations_url":"https://api.github.com/users/DeathByTape/orgs","repos_url":"https://api.github.com/users/DeathByTape/repos","events_url":"https://api.github.com/users/DeathByTape/events{/privacy}","received_events_url":"https://api.github.com/users/DeathByTape/received_events","type":"User","site_admin":false},"body":"I wonder if this should be a server parameter since it can be dangerous if not properly configured.","created_at":"2016-04-13T16:21:07Z","updated_at":"2016-04-13T16:21:07Z","html_url":"https://github.com/yahoo/elide/pull/209#discussion_r59578691","pull_request_url":"https://api.github.com/repos/yahoo/elide/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments/59578691"},"html":{"href":"https://github.com/yahoo/elide/pull/209#discussion_r59578691"},"pull_request":{"href":"https://api.github.com/repos/yahoo/elide/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/yahoo/elide/pulls/209","id":66068919,"html_url":"https://github.com/yahoo/elide/pull/209","diff_url":"https://github.com/yahoo/elide/pull/209.diff","patch_url":"https://github.com/yahoo/elide/pull/209.patch","issue_url":"https://api.github.com/repos/yahoo/elide/issues/209","number":209,"state":"open","locked":false,"title":"Use Criteria.DISTINCT_ROOT_ENTITY and disable join by default","user":{"login":"wcekan","id":8713769,"avatar_url":"https://avatars.githubusercontent.com/u/8713769?v=3","gravatar_id":"","url":"https://api.github.com/users/wcekan","html_url":"https://github.com/wcekan","followers_url":"https://api.github.com/users/wcekan/followers","following_url":"https://api.github.com/users/wcekan/following{/other_user}","gists_url":"https://api.github.com/users/wcekan/gists{/gist_id}","starred_url":"https://api.github.com/users/wcekan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wcekan/subscriptions","organizations_url":"https://api.github.com/users/wcekan/orgs","repos_url":"https://api.github.com/users/wcekan/repos","events_url":"https://api.github.com/users/wcekan/events{/privacy}","received_events_url":"https://api.github.com/users/wcekan/received_events","type":"User","site_admin":false},"body":"Disabled any JOIN by default due to cross-product expansion of many queries.","created_at":"2016-04-11T21:53:15Z","updated_at":"2016-04-13T16:21:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"114f7ffcc5ba0eee1977927535083896cd93d5d7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/elide/pulls/209/commits","review_comments_url":"https://api.github.com/repos/yahoo/elide/pulls/209/comments","review_comment_url":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/elide/issues/209/comments","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/6f120dfa52f9bc3b66da922c6d48190ef010dfa2","head":{"label":"yahoo:scroll-on-joins","ref":"scroll-on-joins","sha":"6f120dfa52f9bc3b66da922c6d48190ef010dfa2","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/elide/deployments","created_at":"2015-10-12T17:55:01Z","updated_at":"2016-04-08T15:20:35Z","pushed_at":"2016-04-13T16:15:37Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":1968,"stargazers_count":90,"watchers_count":90,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":17,"forks":18,"open_issues":17,"watchers":90,"default_branch":"master"}},"base":{"label":"yahoo:master","ref":"master","sha":"b3b8c9a1ee7e6a1bb7cc8d9c5850492a4ece391f","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars.githubusercontent.com/u/16574?v=3","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/elide/deployments","created_at":"2015-10-12T17:55:01Z","updated_at":"2016-04-08T15:20:35Z","pushed_at":"2016-04-13T16:15:37Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":1968,"stargazers_count":90,"watchers_count":90,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":17,"forks":18,"open_issues":17,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/209"},"html":{"href":"https://github.com/yahoo/elide/pull/209"},"issue":{"href":"https://api.github.com/repos/yahoo/elide/issues/209"},"comments":{"href":"https://api.github.com/repos/yahoo/elide/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/elide/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/elide/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/elide/statuses/6f120dfa52f9bc3b66da922c6d48190ef010dfa2"}}}}