{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/50907755","id":50907755,"diff_hunk":"@@ -1180,8 +1185,6 @@ private void RerouteAllQueuedMessages(ActivationData activation, ActivationAddre\n                     throw new DuplicateActivationException(id);\n                 }\n             }\n-            // We currently don't have any other case for multiple activations except for StatelessWorker.","path":"src/OrleansRuntime/Catalog/Catalog.cs","position":123,"original_position":107,"commit_id":"f019797727b189186d4ab2881c52e8570d42c6cd","original_commit_id":"3b6eab2ffe41924ee558c2241eb4298dc9db75ed","user":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"body":"But no the following line with `//await scheduler.RunOrQueueTask`?\r\n\r\nOr if you meant it to stay as an example of what we'd do in case of a future multi-activation case, I think the line is already incorrect because of the changed `RegisterAsync` behavior that now also includes what used to be `RegisterSingleActivationAsync`. Now it requires an additional bool argument.\r\n\r\nI think we should remove that code line to avoid potential confusion but leave the comment line before it.","created_at":"2016-01-26T22:00:42Z","updated_at":"2016-01-26T22:00:42Z","html_url":"https://github.com/dotnet/orleans/pull/1108#discussion_r50907755","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/1108","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/50907755"},"html":{"href":"https://github.com/dotnet/orleans/pull/1108#discussion_r50907755"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1108"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/1108","id":52588268,"html_url":"https://github.com/dotnet/orleans/pull/1108","diff_url":"https://github.com/dotnet/orleans/pull/1108.diff","patch_url":"https://github.com/dotnet/orleans/pull/1108.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/1108","number":1108,"state":"open","locked":false,"title":"GrainDirectory Refactoring and Multi-Cluster Registration","user":{"login":"sebastianburckhardt","id":6415760,"avatar_url":"https://avatars.githubusercontent.com/u/6415760?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianburckhardt","html_url":"https://github.com/sebastianburckhardt","followers_url":"https://api.github.com/users/sebastianburckhardt/followers","following_url":"https://api.github.com/users/sebastianburckhardt/following{/other_user}","gists_url":"https://api.github.com/users/sebastianburckhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianburckhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianburckhardt/subscriptions","organizations_url":"https://api.github.com/users/sebastianburckhardt/orgs","repos_url":"https://api.github.com/users/sebastianburckhardt/repos","events_url":"https://api.github.com/users/sebastianburckhardt/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianburckhardt/received_events","type":"User","site_admin":false},"body":"This branch contains\r\n\r\n- some basic refactoring of the local and remote grain directory. There was a lot of code duplication between the various functions (register, registersingleact, unregister, delete) and between the local and remote grain directory. The proposed refactoring puts shared functionality into LocalGrainDirectory. It adds a hopcount parameter into the signature of the directory operations (replacing the retries parameter), which allows us to tell if something is a remote or local request, and whether we should retry. \r\n\r\n-  hooks for specifying a multi-cluster grain registration strategy. This strategy is defined by the type of the grain (e.g. using attributes). The strategy is used to look up the corresponding registrar for the grain. The actual registration/unregistration/deletion of a grain is done by that registrar.   \r\n","created_at":"2015-12-03T20:33:30Z","updated_at":"2016-01-26T22:00:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4364fbb2ce3cbad0b0dcad7036871c69cecfe033","assignee":{"login":"jdom","id":1361686,"avatar_url":"https://avatars.githubusercontent.com/u/1361686?v=3","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/11","html_url":"https://github.com/dotnet/orleans/milestones/Multi-Cluster","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/11/labels","id":1443112,"number":11,"title":"Multi-Cluster","description":"","creator":{"login":"gabikliot","id":10171207,"avatar_url":"https://avatars.githubusercontent.com/u/10171207?v=3","gravatar_id":"","url":"https://api.github.com/users/gabikliot","html_url":"https://github.com/gabikliot","followers_url":"https://api.github.com/users/gabikliot/followers","following_url":"https://api.github.com/users/gabikliot/following{/other_user}","gists_url":"https://api.github.com/users/gabikliot/gists{/gist_id}","starred_url":"https://api.github.com/users/gabikliot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabikliot/subscriptions","organizations_url":"https://api.github.com/users/gabikliot/orgs","repos_url":"https://api.github.com/users/gabikliot/repos","events_url":"https://api.github.com/users/gabikliot/events{/privacy}","received_events_url":"https://api.github.com/users/gabikliot/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2015-12-03T22:32:42Z","updated_at":"2015-12-16T21:36:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/1108/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/1108/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/1108/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/f019797727b189186d4ab2881c52e8570d42c6cd","head":{"label":"sebastianburckhardt:geo-graindirstruct","ref":"geo-graindirstruct","sha":"f019797727b189186d4ab2881c52e8570d42c6cd","user":{"login":"sebastianburckhardt","id":6415760,"avatar_url":"https://avatars.githubusercontent.com/u/6415760?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianburckhardt","html_url":"https://github.com/sebastianburckhardt","followers_url":"https://api.github.com/users/sebastianburckhardt/followers","following_url":"https://api.github.com/users/sebastianburckhardt/following{/other_user}","gists_url":"https://api.github.com/users/sebastianburckhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianburckhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianburckhardt/subscriptions","organizations_url":"https://api.github.com/users/sebastianburckhardt/orgs","repos_url":"https://api.github.com/users/sebastianburckhardt/repos","events_url":"https://api.github.com/users/sebastianburckhardt/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianburckhardt/received_events","type":"User","site_admin":false},"repo":{"id":32952293,"name":"orleans","full_name":"sebastianburckhardt/orleans","owner":{"login":"sebastianburckhardt","id":6415760,"avatar_url":"https://avatars.githubusercontent.com/u/6415760?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianburckhardt","html_url":"https://github.com/sebastianburckhardt","followers_url":"https://api.github.com/users/sebastianburckhardt/followers","following_url":"https://api.github.com/users/sebastianburckhardt/following{/other_user}","gists_url":"https://api.github.com/users/sebastianburckhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianburckhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianburckhardt/subscriptions","organizations_url":"https://api.github.com/users/sebastianburckhardt/orgs","repos_url":"https://api.github.com/users/sebastianburckhardt/repos","events_url":"https://api.github.com/users/sebastianburckhardt/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianburckhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sebastianburckhardt/orleans","description":"Orleans - Distributed Actor Model","fork":true,"url":"https://api.github.com/repos/sebastianburckhardt/orleans","forks_url":"https://api.github.com/repos/sebastianburckhardt/orleans/forks","keys_url":"https://api.github.com/repos/sebastianburckhardt/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastianburckhardt/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastianburckhardt/orleans/teams","hooks_url":"https://api.github.com/repos/sebastianburckhardt/orleans/hooks","issue_events_url":"https://api.github.com/repos/sebastianburckhardt/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/sebastianburckhardt/orleans/events","assignees_url":"https://api.github.com/repos/sebastianburckhardt/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/sebastianburckhardt/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/sebastianburckhardt/orleans/tags","blobs_url":"https://api.github.com/repos/sebastianburckhardt/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastianburckhardt/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastianburckhardt/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastianburckhardt/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastianburckhardt/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastianburckhardt/orleans/languages","stargazers_url":"https://api.github.com/repos/sebastianburckhardt/orleans/stargazers","contributors_url":"https://api.github.com/repos/sebastianburckhardt/orleans/contributors","subscribers_url":"https://api.github.com/repos/sebastianburckhardt/orleans/subscribers","subscription_url":"https://api.github.com/repos/sebastianburckhardt/orleans/subscription","commits_url":"https://api.github.com/repos/sebastianburckhardt/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastianburckhardt/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastianburckhardt/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastianburckhardt/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastianburckhardt/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/sebastianburckhardt/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastianburckhardt/orleans/merges","archive_url":"https://api.github.com/repos/sebastianburckhardt/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastianburckhardt/orleans/downloads","issues_url":"https://api.github.com/repos/sebastianburckhardt/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/sebastianburckhardt/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastianburckhardt/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastianburckhardt/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastianburckhardt/orleans/labels{/name}","releases_url":"https://api.github.com/repos/sebastianburckhardt/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/sebastianburckhardt/orleans/deployments","created_at":"2015-03-26T21:15:24Z","updated_at":"2016-01-06T09:01:49Z","pushed_at":"2016-01-26T16:48:38Z","git_url":"git://github.com/sebastianburckhardt/orleans.git","ssh_url":"git@github.com:sebastianburckhardt/orleans.git","clone_url":"https://github.com/sebastianburckhardt/orleans.git","svn_url":"https://github.com/sebastianburckhardt/orleans","homepage":"http://dotnet.github.io/orleans","size":12566,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"geo-orleans"}},"base":{"label":"dotnet:master","ref":"master","sha":"a6d447625b86067c387cf8103605999a5248b6da","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2016-01-26T10:43:19Z","pushed_at":"2016-01-26T21:16:47Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":31470,"stargazers_count":1507,"watchers_count":1507,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":375,"mirror_url":null,"open_issues_count":143,"forks":375,"open_issues":143,"watchers":1507,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1108"},"html":{"href":"https://github.com/dotnet/orleans/pull/1108"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/1108"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/1108/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1108/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1108/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/f019797727b189186d4ab2881c52e8570d42c6cd"}}}}