{"action":"created","comment":{"url":"https://api.github.com/repos/siemens/fossology/pulls/comments/93252308","pull_request_review_id":13774954,"id":93252308,"diff_hunk":"@@ -42,7 +42,7 @@ selectedLicensesTableConfig = {\n \n editableConfiguration = {\n   \"sUpdateURL\": \"?mod=conclude-license&do=updateClearings\",\n-  \"fnOnEditing\": function(input) {return input[0].value;},\n+  \"fnOnEditing\": function(input) { if(input[0].value.length === 0){ input[0].value = \" \"; } return input[0].value;},","path":"src/www/ui/template/ui-clearing-view.js.twig","position":5,"original_position":5,"commit_id":"c52b6ca31f893a8098262a85adc5b40d7405da2b","original_commit_id":"c52b6ca31f893a8098262a85adc5b40d7405da2b","user":{"login":"maximilianhuber","id":1187050,"avatar_url":"https://avatars.githubusercontent.com/u/1187050?v=3","gravatar_id":"","url":"https://api.github.com/users/maximilianhuber","html_url":"https://github.com/maximilianhuber","followers_url":"https://api.github.com/users/maximilianhuber/followers","following_url":"https://api.github.com/users/maximilianhuber/following{/other_user}","gists_url":"https://api.github.com/users/maximilianhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianhuber/subscriptions","organizations_url":"https://api.github.com/users/maximilianhuber/orgs","repos_url":"https://api.github.com/users/maximilianhuber/repos","events_url":"https://api.github.com/users/maximilianhuber/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianhuber/received_events","type":"User","site_admin":false},"body":"It would be more save to write `input[0].value === \"\"` instead of `input[0].value.length === 0`\r\n\r\nWhy not write something like `if(input[0].value === \"\"){ return \" \"; } return input[0].value;` this would prevent the modification of `input[0].value`.","created_at":"2016-12-20T14:53:36Z","updated_at":"2016-12-20T14:53:41Z","html_url":"https://github.com/siemens/fossology/pull/13#discussion_r93252308","pull_request_url":"https://api.github.com/repos/siemens/fossology/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/siemens/fossology/pulls/comments/93252308"},"html":{"href":"https://github.com/siemens/fossology/pull/13#discussion_r93252308"},"pull_request":{"href":"https://api.github.com/repos/siemens/fossology/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/siemens/fossology/pulls/13","id":89154427,"html_url":"https://github.com/siemens/fossology/pull/13","diff_url":"https://github.com/siemens/fossology/pull/13.diff","patch_url":"https://github.com/siemens/fossology/pull/13.patch","issue_url":"https://api.github.com/repos/siemens/fossology/issues/13","number":13,"state":"open","locked":false,"title":"fix(customlicensetext): removing custom text if not required","user":{"login":"shaheemazmalmmd","id":10155976,"avatar_url":"https://avatars.githubusercontent.com/u/10155976?v=3","gravatar_id":"","url":"https://api.github.com/users/shaheemazmalmmd","html_url":"https://github.com/shaheemazmalmmd","followers_url":"https://api.github.com/users/shaheemazmalmmd/followers","following_url":"https://api.github.com/users/shaheemazmalmmd/following{/other_user}","gists_url":"https://api.github.com/users/shaheemazmalmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/shaheemazmalmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaheemazmalmmd/subscriptions","organizations_url":"https://api.github.com/users/shaheemazmalmmd/orgs","repos_url":"https://api.github.com/users/shaheemazmalmmd/repos","events_url":"https://api.github.com/users/shaheemazmalmmd/events{/privacy}","received_events_url":"https://api.github.com/users/shaheemazmalmmd/received_events","type":"User","site_admin":false},"body":"Removal of custom text in single file view of license browser.\n","created_at":"2016-10-13T08:12:29Z","updated_at":"2016-12-20T14:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3272c8c24537ad5d8bb2d74fd1e9e9300407e546","assignee":{"login":"maximilianhuber","id":1187050,"avatar_url":"https://avatars.githubusercontent.com/u/1187050?v=3","gravatar_id":"","url":"https://api.github.com/users/maximilianhuber","html_url":"https://github.com/maximilianhuber","followers_url":"https://api.github.com/users/maximilianhuber/followers","following_url":"https://api.github.com/users/maximilianhuber/following{/other_user}","gists_url":"https://api.github.com/users/maximilianhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianhuber/subscriptions","organizations_url":"https://api.github.com/users/maximilianhuber/orgs","repos_url":"https://api.github.com/users/maximilianhuber/repos","events_url":"https://api.github.com/users/maximilianhuber/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianhuber/received_events","type":"User","site_admin":false},"assignees":[{"login":"maximilianhuber","id":1187050,"avatar_url":"https://avatars.githubusercontent.com/u/1187050?v=3","gravatar_id":"","url":"https://api.github.com/users/maximilianhuber","html_url":"https://github.com/maximilianhuber","followers_url":"https://api.github.com/users/maximilianhuber/followers","following_url":"https://api.github.com/users/maximilianhuber/following{/other_user}","gists_url":"https://api.github.com/users/maximilianhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianhuber/subscriptions","organizations_url":"https://api.github.com/users/maximilianhuber/orgs","repos_url":"https://api.github.com/users/maximilianhuber/repos","events_url":"https://api.github.com/users/maximilianhuber/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianhuber/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/siemens/fossology/pulls/13/commits","review_comments_url":"https://api.github.com/repos/siemens/fossology/pulls/13/comments","review_comment_url":"https://api.github.com/repos/siemens/fossology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/siemens/fossology/issues/13/comments","statuses_url":"https://api.github.com/repos/siemens/fossology/statuses/c52b6ca31f893a8098262a85adc5b40d7405da2b","head":{"label":"siemens:contrib/fixcustomlictext","ref":"contrib/fixcustomlictext","sha":"c52b6ca31f893a8098262a85adc5b40d7405da2b","user":{"login":"siemens","id":624020,"avatar_url":"https://avatars.githubusercontent.com/u/624020?v=3","gravatar_id":"","url":"https://api.github.com/users/siemens","html_url":"https://github.com/siemens","followers_url":"https://api.github.com/users/siemens/followers","following_url":"https://api.github.com/users/siemens/following{/other_user}","gists_url":"https://api.github.com/users/siemens/gists{/gist_id}","starred_url":"https://api.github.com/users/siemens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siemens/subscriptions","organizations_url":"https://api.github.com/users/siemens/orgs","repos_url":"https://api.github.com/users/siemens/repos","events_url":"https://api.github.com/users/siemens/events{/privacy}","received_events_url":"https://api.github.com/users/siemens/received_events","type":"Organization","site_admin":false},"repo":{"id":25910533,"name":"fossology","full_name":"siemens/fossology","owner":{"login":"siemens","id":624020,"avatar_url":"https://avatars.githubusercontent.com/u/624020?v=3","gravatar_id":"","url":"https://api.github.com/users/siemens","html_url":"https://github.com/siemens","followers_url":"https://api.github.com/users/siemens/followers","following_url":"https://api.github.com/users/siemens/following{/other_user}","gists_url":"https://api.github.com/users/siemens/gists{/gist_id}","starred_url":"https://api.github.com/users/siemens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siemens/subscriptions","organizations_url":"https://api.github.com/users/siemens/orgs","repos_url":"https://api.github.com/users/siemens/repos","events_url":"https://api.github.com/users/siemens/events{/privacy}","received_events_url":"https://api.github.com/users/siemens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/siemens/fossology","description":"The FOSSology software is a system for analyzing and studying FOSS – Free and Open Source Software. Today people use FOSSology as part of their open source governance activities. Specifically to scan files for licenses and copyrights.","fork":true,"url":"https://api.github.com/repos/siemens/fossology","forks_url":"https://api.github.com/repos/siemens/fossology/forks","keys_url":"https://api.github.com/repos/siemens/fossology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siemens/fossology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siemens/fossology/teams","hooks_url":"https://api.github.com/repos/siemens/fossology/hooks","issue_events_url":"https://api.github.com/repos/siemens/fossology/issues/events{/number}","events_url":"https://api.github.com/repos/siemens/fossology/events","assignees_url":"https://api.github.com/repos/siemens/fossology/assignees{/user}","branches_url":"https://api.github.com/repos/siemens/fossology/branches{/branch}","tags_url":"https://api.github.com/repos/siemens/fossology/tags","blobs_url":"https://api.github.com/repos/siemens/fossology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siemens/fossology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siemens/fossology/git/refs{/sha}","trees_url":"https://api.github.com/repos/siemens/fossology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siemens/fossology/statuses/{sha}","languages_url":"https://api.github.com/repos/siemens/fossology/languages","stargazers_url":"https://api.github.com/repos/siemens/fossology/stargazers","contributors_url":"https://api.github.com/repos/siemens/fossology/contributors","subscribers_url":"https://api.github.com/repos/siemens/fossology/subscribers","subscription_url":"https://api.github.com/repos/siemens/fossology/subscription","commits_url":"https://api.github.com/repos/siemens/fossology/commits{/sha}","git_commits_url":"https://api.github.com/repos/siemens/fossology/git/commits{/sha}","comments_url":"https://api.github.com/repos/siemens/fossology/comments{/number}","issue_comment_url":"https://api.github.com/repos/siemens/fossology/issues/comments{/number}","contents_url":"https://api.github.com/repos/siemens/fossology/contents/{+path}","compare_url":"https://api.github.com/repos/siemens/fossology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siemens/fossology/merges","archive_url":"https://api.github.com/repos/siemens/fossology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siemens/fossology/downloads","issues_url":"https://api.github.com/repos/siemens/fossology/issues{/number}","pulls_url":"https://api.github.com/repos/siemens/fossology/pulls{/number}","milestones_url":"https://api.github.com/repos/siemens/fossology/milestones{/number}","notifications_url":"https://api.github.com/repos/siemens/fossology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siemens/fossology/labels{/name}","releases_url":"https://api.github.com/repos/siemens/fossology/releases{/id}","deployments_url":"https://api.github.com/repos/siemens/fossology/deployments","created_at":"2014-10-29T08:03:21Z","updated_at":"2016-11-08T22:57:05Z","pushed_at":"2016-11-07T09:35:45Z","git_url":"git://github.com/siemens/fossology.git","ssh_url":"git@github.com:siemens/fossology.git","clone_url":"https://github.com/siemens/fossology.git","svn_url":"https://github.com/siemens/fossology","homepage":null,"size":279970,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":6,"default_branch":"master"}},"base":{"label":"siemens:master","ref":"master","sha":"244e97b9367960c7711bd7fed76aecf9b8fc52fd","user":{"login":"siemens","id":624020,"avatar_url":"https://avatars.githubusercontent.com/u/624020?v=3","gravatar_id":"","url":"https://api.github.com/users/siemens","html_url":"https://github.com/siemens","followers_url":"https://api.github.com/users/siemens/followers","following_url":"https://api.github.com/users/siemens/following{/other_user}","gists_url":"https://api.github.com/users/siemens/gists{/gist_id}","starred_url":"https://api.github.com/users/siemens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siemens/subscriptions","organizations_url":"https://api.github.com/users/siemens/orgs","repos_url":"https://api.github.com/users/siemens/repos","events_url":"https://api.github.com/users/siemens/events{/privacy}","received_events_url":"https://api.github.com/users/siemens/received_events","type":"Organization","site_admin":false},"repo":{"id":25910533,"name":"fossology","full_name":"siemens/fossology","owner":{"login":"siemens","id":624020,"avatar_url":"https://avatars.githubusercontent.com/u/624020?v=3","gravatar_id":"","url":"https://api.github.com/users/siemens","html_url":"https://github.com/siemens","followers_url":"https://api.github.com/users/siemens/followers","following_url":"https://api.github.com/users/siemens/following{/other_user}","gists_url":"https://api.github.com/users/siemens/gists{/gist_id}","starred_url":"https://api.github.com/users/siemens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siemens/subscriptions","organizations_url":"https://api.github.com/users/siemens/orgs","repos_url":"https://api.github.com/users/siemens/repos","events_url":"https://api.github.com/users/siemens/events{/privacy}","received_events_url":"https://api.github.com/users/siemens/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/siemens/fossology","description":"The FOSSology software is a system for analyzing and studying FOSS – Free and Open Source Software. Today people use FOSSology as part of their open source governance activities. Specifically to scan files for licenses and copyrights.","fork":true,"url":"https://api.github.com/repos/siemens/fossology","forks_url":"https://api.github.com/repos/siemens/fossology/forks","keys_url":"https://api.github.com/repos/siemens/fossology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/siemens/fossology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/siemens/fossology/teams","hooks_url":"https://api.github.com/repos/siemens/fossology/hooks","issue_events_url":"https://api.github.com/repos/siemens/fossology/issues/events{/number}","events_url":"https://api.github.com/repos/siemens/fossology/events","assignees_url":"https://api.github.com/repos/siemens/fossology/assignees{/user}","branches_url":"https://api.github.com/repos/siemens/fossology/branches{/branch}","tags_url":"https://api.github.com/repos/siemens/fossology/tags","blobs_url":"https://api.github.com/repos/siemens/fossology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/siemens/fossology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/siemens/fossology/git/refs{/sha}","trees_url":"https://api.github.com/repos/siemens/fossology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/siemens/fossology/statuses/{sha}","languages_url":"https://api.github.com/repos/siemens/fossology/languages","stargazers_url":"https://api.github.com/repos/siemens/fossology/stargazers","contributors_url":"https://api.github.com/repos/siemens/fossology/contributors","subscribers_url":"https://api.github.com/repos/siemens/fossology/subscribers","subscription_url":"https://api.github.com/repos/siemens/fossology/subscription","commits_url":"https://api.github.com/repos/siemens/fossology/commits{/sha}","git_commits_url":"https://api.github.com/repos/siemens/fossology/git/commits{/sha}","comments_url":"https://api.github.com/repos/siemens/fossology/comments{/number}","issue_comment_url":"https://api.github.com/repos/siemens/fossology/issues/comments{/number}","contents_url":"https://api.github.com/repos/siemens/fossology/contents/{+path}","compare_url":"https://api.github.com/repos/siemens/fossology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/siemens/fossology/merges","archive_url":"https://api.github.com/repos/siemens/fossology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/siemens/fossology/downloads","issues_url":"https://api.github.com/repos/siemens/fossology/issues{/number}","pulls_url":"https://api.github.com/repos/siemens/fossology/pulls{/number}","milestones_url":"https://api.github.com/repos/siemens/fossology/milestones{/number}","notifications_url":"https://api.github.com/repos/siemens/fossology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/siemens/fossology/labels{/name}","releases_url":"https://api.github.com/repos/siemens/fossology/releases{/id}","deployments_url":"https://api.github.com/repos/siemens/fossology/deployments","created_at":"2014-10-29T08:03:21Z","updated_at":"2016-11-08T22:57:05Z","pushed_at":"2016-11-07T09:35:45Z","git_url":"git://github.com/siemens/fossology.git","ssh_url":"git@github.com:siemens/fossology.git","clone_url":"https://github.com/siemens/fossology.git","svn_url":"https://github.com/siemens/fossology","homepage":null,"size":279970,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/siemens/fossology/pulls/13"},"html":{"href":"https://github.com/siemens/fossology/pull/13"},"issue":{"href":"https://api.github.com/repos/siemens/fossology/issues/13"},"comments":{"href":"https://api.github.com/repos/siemens/fossology/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/siemens/fossology/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/siemens/fossology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/siemens/fossology/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/siemens/fossology/statuses/c52b6ca31f893a8098262a85adc5b40d7405da2b"}}}}
{"actor":{"display_login":"maximilianhuber"}}