{"action":"closed","issue":{"url":"https://api.github.com/repos/mrihtar/Garmin-FIT/issues/1","repository_url":"https://api.github.com/repos/mrihtar/Garmin-FIT","labels_url":"https://api.github.com/repos/mrihtar/Garmin-FIT/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/mrihtar/Garmin-FIT/issues/1/comments","events_url":"https://api.github.com/repos/mrihtar/Garmin-FIT/issues/1/events","html_url":"https://github.com/mrihtar/Garmin-FIT/issues/1","id":168525498,"number":1,"title":"Problems with big endian","user":{"login":"laufhannes","id":8313118,"avatar_url":"https://avatars.githubusercontent.com/u/8313118?v=3","gravatar_id":"","url":"https://api.github.com/users/laufhannes","html_url":"https://github.com/laufhannes","followers_url":"https://api.github.com/users/laufhannes/followers","following_url":"https://api.github.com/users/laufhannes/following{/other_user}","gists_url":"https://api.github.com/users/laufhannes/gists{/gist_id}","starred_url":"https://api.github.com/users/laufhannes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laufhannes/subscriptions","organizations_url":"https://api.github.com/users/laufhannes/orgs","repos_url":"https://api.github.com/users/laufhannes/repos","events_url":"https://api.github.com/users/laufhannes/events{/privacy}","received_events_url":"https://api.github.com/users/laufhannes/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-07-31T16:20:35Z","updated_at":"2016-10-17T20:14:56Z","closed_at":"2016-10-17T20:14:56Z","body":"The perl module has some problems with big endian values. \r\n\r\n - The parser will fail for big endian files with array-valued fields (such as for hrv)\r\n   - see Runalyze/Runalyze#1797 for a related issue\r\n   - see https://github.com/Runalyze/Runalyze/commit/73a59bae079e45af12d6923451cdfefb67906518 for a fix\r\n - The parser will fail on big endian systems\r\n   - see Runalyze/Runalyze#1875 for a related issue\r\n   - message numbers will be wrong\r\n   - for a fix:\r\n     - `$endian != $my_endian` should be `$endian` ([#L4780](https://github.com/mrihtar/Garmin-FIT/blob/4a8df447236e0d1617da0fd129564d9bc51328b7/Garmin/FIT.pm#L4780), [#L4828](https://github.com/mrihtar/Garmin-FIT/blob/4a8df447236e0d1617da0fd129564d9bc51328b7/Garmin/FIT.pm#L4828), [#L4868](https://github.com/mrihtar/Garmin-FIT/blob/4a8df447236e0d1617da0fd129564d9bc51328b7/Garmin/FIT.pm#L4868)) \r\n     - add `$v = reverse $v if ref $desc->{endian_converter} eq 'ARRAY';` to [#L4927](https://github.com/mrihtar/Garmin-FIT/blob/4a8df447236e0d1617da0fd129564d9bc51328b7/Garmin/FIT.pm#L4927)\r\n\r\nI can add a pull request for this, but I don't have a big endian system to check and a final confirmation that the last point fixes wrong ordering of arrayed-valued fields is still missing (see https://github.com/Runalyze/Runalyze/issues/1875#issuecomment-234050418).\r\n\r\nPS: Thanks for having a repo for Kiyokazu's perl module!"}}
{"actor":{"display_login":"mrihtar"}}