{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/14359","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/14359/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/14359/comments","events_url":"https://api.github.com/repos/servo/servo/issues/14359/events","html_url":"https://github.com/servo/servo/pull/14359","id":191472668,"number":14359,"title":"Reuse box-shadow code for drop-shadow filter","user":{"login":"shinglyu","id":3250983,"avatar_url":"https://avatars.githubusercontent.com/u/3250983?v=3","gravatar_id":"","url":"https://api.github.com/users/shinglyu","html_url":"https://github.com/shinglyu","followers_url":"https://api.github.com/users/shinglyu/followers","following_url":"https://api.github.com/users/shinglyu/following{/other_user}","gists_url":"https://api.github.com/users/shinglyu/gists{/gist_id}","starred_url":"https://api.github.com/users/shinglyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinglyu/subscriptions","organizations_url":"https://api.github.com/users/shinglyu/orgs","repos_url":"https://api.github.com/users/shinglyu/repos","events_url":"https://api.github.com/users/shinglyu/events{/privacy}","received_events_url":"https://api.github.com/users/shinglyu/received_events","type":"User","site_admin":false},"labels":[{"id":155503129,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-merge","name":"S-awaiting-merge","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"assignees":[{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2016-11-24T09:38:06Z","updated_at":"2016-12-14T00:19:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/14359","html_url":"https://github.com/servo/servo/pull/14359","diff_url":"https://github.com/servo/servo/pull/14359.diff","patch_url":"https://github.com/servo/servo/pull/14359.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nFollowup for #14218. Extracted the `Shadow` struct and methods into `values::*`, and make `box-shadow` and `drop-shadow` share the new `Shadow` type. The `ToCss` trait is not reused because they behave different in the two properties.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #14219  (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [x] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/14359)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/266904358","html_url":"https://github.com/servo/servo/pull/14359#issuecomment-266904358","issue_url":"https://api.github.com/repos/servo/servo/issues/14359","id":266904358,"user":{"login":"bors-servo","id":4368172,"avatar_url":"https://avatars.githubusercontent.com/u/4368172?v=3","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2016-12-14T00:19:51Z","updated_at":"2016-12-14T00:19:51Z","body":":broken_heart: Test failed - [mac-dev-unit](http://build.servo.org/builders/mac-dev-unit/builds/4696)"}}
{"actor":{"display_login":"bors-servo"}}