{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14636","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14636/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14636/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14636/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14636","id":123980941,"number":14636,"title":"Refactor handling of dodging","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-27T14:18:56Z","updated_at":"2016-01-04T11:47:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/14636","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14636","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14636.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14636.patch"},"body":"This PR is derived from #14627 but includes only changes to fix `player::on_dodge` which unlike `monster::on_dodge` is not called in most circumstances. A later PR can make any behavioral changes affecting training on hits vs misses.\r\n\r\nAfter this PR `monster::on_dodge` or `player::on_dodge` is called when both a melee attack or a  special attack (including projectile attacks) from `monattack.cpp` is successfully dodged. All of the player logic for dodging is moved to `player::on_dodge()`. Monsters currently do nothing in `monster::on_dodge()`.\r\n\r\nCommit comments provide more explanation as to the specific changes which include some incidental improvements to documentation and code style.  The only behavioral change is that dodging is always practiced even if difficulty is 0 to prevent skill rust."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/168655017","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/14636#issuecomment-168655017","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/14636","id":168655017,"user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"created_at":"2016-01-04T11:47:54Z","updated_at":"2016-01-04T11:47:54Z","body":"The simplest way would probably be to make a new branch from the newest master, merge this one to it and PR the new one."}}