{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/90424956","pull_request_review_id":10942169,"id":90424956,"diff_hunk":"@@ -164,6 +175,21 @@ sub upload {\n \n     my $res = $OpenQA::Worker::Common::ua->start($tx);\n \n+    # Upload known server failures (Instead of anything that's not 200)\n+    unless ($res->res->code =~ m/^5/) {\n+        if ($retry_counter++ == $retry_limit) {\n+            my $msg = sprintf(\"Uploads have failed for %s\\n\", $filename);\n+            open(my $log, '>>', \"autoinst-log.txt\");\n+            print $log $msg;\n+            close $log;\n+            print STDERR $msg;\n+            return 0;\n+        }\n+        else {\n+            goto START_UPLOAD;","path":"lib/OpenQA/Worker/Jobs.pm","position":null,"original_position":40,"commit_id":"679727199cd29a9b534e469ddf55ede2f6894c5d","original_commit_id":"3558e00cf18f1efbb9919b0d627baaa7d48fef36","user":{"login":"foursixnine","id":229240,"avatar_url":"https://avatars.githubusercontent.com/u/229240?v=3","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"body":"Here goes a new try :)","created_at":"2016-12-01T11:01:27Z","updated_at":"2016-12-01T11:01:27Z","html_url":"https://github.com/os-autoinst/openQA/pull/1053#discussion_r90424956","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/90424956"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1053#discussion_r90424956"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053","id":95926485,"html_url":"https://github.com/os-autoinst/openQA/pull/1053","diff_url":"https://github.com/os-autoinst/openQA/pull/1053.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/1053.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1053","number":1053,"state":"open","locked":false,"title":"Add retry for failed uploads on server errors (5xx)","user":{"login":"foursixnine","id":229240,"avatar_url":"https://avatars.githubusercontent.com/u/229240?v=3","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"body":"Add a simple GOTO instruction to ensure that if the upload failed\r\ndue to server being unavailable (status 5xx) that will be executed\r\nup to $retry_limit times for $tics of 1 second each.\r\n\r\nThis one in particular is related to: [poo#13876](https://progress.opensuse.org/issues/13876). The missing autoinst.log is a bit unrelated. \r\n\r\n","created_at":"2016-11-30T16:34:39Z","updated_at":"2016-12-01T11:01:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de00162f5a3fd82ead84c13eb03a52c1a166c908","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/1053/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/679727199cd29a9b534e469ddf55ede2f6894c5d","head":{"label":"foursixnine:fix/retry_file_uploads","ref":"fix/retry_file_uploads","sha":"679727199cd29a9b534e469ddf55ede2f6894c5d","user":{"login":"foursixnine","id":229240,"avatar_url":"https://avatars.githubusercontent.com/u/229240?v=3","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"repo":{"id":70133290,"name":"openQA","full_name":"foursixnine/openQA","owner":{"login":"foursixnine","id":229240,"avatar_url":"https://avatars.githubusercontent.com/u/229240?v=3","gravatar_id":"","url":"https://api.github.com/users/foursixnine","html_url":"https://github.com/foursixnine","followers_url":"https://api.github.com/users/foursixnine/followers","following_url":"https://api.github.com/users/foursixnine/following{/other_user}","gists_url":"https://api.github.com/users/foursixnine/gists{/gist_id}","starred_url":"https://api.github.com/users/foursixnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foursixnine/subscriptions","organizations_url":"https://api.github.com/users/foursixnine/orgs","repos_url":"https://api.github.com/users/foursixnine/repos","events_url":"https://api.github.com/users/foursixnine/events{/privacy}","received_events_url":"https://api.github.com/users/foursixnine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/foursixnine/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/foursixnine/openQA","forks_url":"https://api.github.com/repos/foursixnine/openQA/forks","keys_url":"https://api.github.com/repos/foursixnine/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foursixnine/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foursixnine/openQA/teams","hooks_url":"https://api.github.com/repos/foursixnine/openQA/hooks","issue_events_url":"https://api.github.com/repos/foursixnine/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/foursixnine/openQA/events","assignees_url":"https://api.github.com/repos/foursixnine/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/foursixnine/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/foursixnine/openQA/tags","blobs_url":"https://api.github.com/repos/foursixnine/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foursixnine/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foursixnine/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/foursixnine/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foursixnine/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/foursixnine/openQA/languages","stargazers_url":"https://api.github.com/repos/foursixnine/openQA/stargazers","contributors_url":"https://api.github.com/repos/foursixnine/openQA/contributors","subscribers_url":"https://api.github.com/repos/foursixnine/openQA/subscribers","subscription_url":"https://api.github.com/repos/foursixnine/openQA/subscription","commits_url":"https://api.github.com/repos/foursixnine/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/foursixnine/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/foursixnine/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/foursixnine/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/foursixnine/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/foursixnine/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foursixnine/openQA/merges","archive_url":"https://api.github.com/repos/foursixnine/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foursixnine/openQA/downloads","issues_url":"https://api.github.com/repos/foursixnine/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/foursixnine/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/foursixnine/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/foursixnine/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foursixnine/openQA/labels{/name}","releases_url":"https://api.github.com/repos/foursixnine/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/foursixnine/openQA/deployments","created_at":"2016-10-06T07:43:14Z","updated_at":"2016-10-06T07:43:17Z","pushed_at":"2016-12-01T10:59:56Z","git_url":"git://github.com/foursixnine/openQA.git","ssh_url":"git@github.com:foursixnine/openQA.git","clone_url":"https://github.com/foursixnine/openQA.git","svn_url":"https://github.com/foursixnine/openQA","homepage":"http://openqa.opensuse.org/","size":16053,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"fb78fafa30fb39b792250a982594526577ff6731","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/openQA/deployments","created_at":"2014-06-16T12:23:22Z","updated_at":"2016-11-21T15:58:06Z","pushed_at":"2016-12-01T10:59:56Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":17531,"stargazers_count":72,"watchers_count":72,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":29,"forks":58,"open_issues":29,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/1053"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1053"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/1053/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/1053/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/679727199cd29a9b534e469ddf55ede2f6894c5d"}}}}
{"actor":{"display_login":"foursixnine"}}