{"action":"created","comment":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/78073768","id":78073768,"diff_hunk":"@@ -1265,46 +1265,40 @@ def generateMainClasses(): Unit = {\n \n             ${(i == 0).gen(xs\"\"\"\n               @Override\n-              public <T> Tuple1<T> prepend(T value) {\n+              public <T> Tuple1<T> append(T value) {\n                  return new Tuple1<>(value);\n               }\n \n               @Override\n-              public <T> Tuple1<T> append(T value) {\n+              public <T> Tuple1<T> prepend(T value) {\n                  return new Tuple1<>(value);\n               }\n             \"\"\")}\n \n             ${(i > 0 && i < N).gen(xs\"\"\"\n               @Override\n-              public <T> Tuple${i + 1}<T, ${(1 to i).gen(j => s\"T$j\")(\", \")}> prepend(T value) {\n-                  return Tuple.of(value, ${(1 to i).gen(j => s\"_$j\")(\", \")});\n-              }\n-\n-              @Override\n               public <T> Tuple${i + 1}<${(1 to i).gen(j => s\"T$j\")(\", \")}, T> append(T value) {\n                   return Tuple.of(${(1 to i).gen(j => s\"_$j\")(\", \")}, value);\n               }\n-            \"\"\")}\n \n-            ${(i == N).gen(xs\"\"\"\n               @Override\n-              public <T> Tuple prepend(T value) {\n-                  throw new UnsupportedOperationException(\"Prepend to Tuple${N}\");\n+              public <T> Tuple${i + 1}<T, ${(1 to i).gen(j => s\"T$j\")(\", \")}> prepend(T value) {\n+                  return Tuple.of(value, ${(1 to i).gen(j => s\"_$j\")(\", \")});\n               }\n+            \"\"\")}\n \n+            ${(i == N).gen(xs\"\"\"\n               @Override\n               public <T> Tuple append(T value) {\n                   throw new UnsupportedOperationException(\"Append to Tuple${N}\");\n               }\n-            \"\"\")}\n \n-            ${(i > 0).gen(xs\"\"\"\n-              public static $generics $className<${(1 to i).gen(j => s\"Seq<? extends T$j>\")(\", \")}> sequence(Iterable<$className<${(1 to i).gen(j => s\"? extends T$j\")(\", \")}>> tuples) {\n-                Objects.requireNonNull(tuples, \"tuples is null\");\n-                return new $className<>(${(1 to i).gen(j => s\"${im.getType(\"javaslang.collection.Iterator\")}.ofAll(tuples).map($className::_$j).toList()\")(\", \")});\n+              @Override\n+              public <T> Tuple prepend(T value) {\n+                  throw new UnsupportedOperationException(\"Prepend to Tuple${N}\");","path":"javaslang/generator/Generator.scala","position":50,"original_position":50,"commit_id":"3b497bf0ef23ed85dca05a08ff5f089ba2a2b013","original_commit_id":"3b497bf0ef23ed85dca05a08ff5f089ba2a2b013","user":{"login":"danieldietrich","id":743833,"avatar_url":"https://avatars.githubusercontent.com/u/743833?v=3","gravatar_id":"","url":"https://api.github.com/users/danieldietrich","html_url":"https://github.com/danieldietrich","followers_url":"https://api.github.com/users/danieldietrich/followers","following_url":"https://api.github.com/users/danieldietrich/following{/other_user}","gists_url":"https://api.github.com/users/danieldietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietrich/subscriptions","organizations_url":"https://api.github.com/users/danieldietrich/orgs","repos_url":"https://api.github.com/users/danieldietrich/repos","events_url":"https://api.github.com/users/danieldietrich/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietrich/received_events","type":"User","site_admin":false},"body":"A `list.toTuple()` is not possible because the number of elements may exceed the max Tuple arity.\r\n\r\n`tuple.toSeq()` exists already.\r\n\r\nWhat we really need is a heterogenous list (`HList`). We have already an issue for that but the generics are not human-readable any more when the list grows. For now I would not implement an HList. It would start to make sense when we have local variable type inference in Java.\r\n\r\n@ashrko619 Sorry for being torn back and forth. I think we need a more in-depth analysis for future features, including code examples, pros, cons etc.\r\n\r\nPlease give me some time to think about this feature...","created_at":"2016-09-08T19:30:41Z","updated_at":"2016-09-08T19:30:41Z","html_url":"https://github.com/javaslang/javaslang/pull/1559#discussion_r78073768","pull_request_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1559","_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments/78073768"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1559#discussion_r78073768"},"pull_request":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1559"}}},"pull_request":{"url":"https://api.github.com/repos/javaslang/javaslang/pulls/1559","id":84413233,"html_url":"https://github.com/javaslang/javaslang/pull/1559","diff_url":"https://github.com/javaslang/javaslang/pull/1559.diff","patch_url":"https://github.com/javaslang/javaslang/pull/1559.patch","issue_url":"https://api.github.com/repos/javaslang/javaslang/issues/1559","number":1559,"state":"open","locked":false,"title":"Refactored sequence methods","user":{"login":"ashrko619","id":11240142,"avatar_url":"https://avatars.githubusercontent.com/u/11240142?v=3","gravatar_id":"","url":"https://api.github.com/users/ashrko619","html_url":"https://github.com/ashrko619","followers_url":"https://api.github.com/users/ashrko619/followers","following_url":"https://api.github.com/users/ashrko619/following{/other_user}","gists_url":"https://api.github.com/users/ashrko619/gists{/gist_id}","starred_url":"https://api.github.com/users/ashrko619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashrko619/subscriptions","organizations_url":"https://api.github.com/users/ashrko619/orgs","repos_url":"https://api.github.com/users/ashrko619/repos","events_url":"https://api.github.com/users/ashrko619/events{/privacy}","received_events_url":"https://api.github.com/users/ashrko619/received_events","type":"User","site_admin":false},"body":"PR for #1556.\r\n\r\nHere we have to name the methods as sequence* otherwise they have the same type erasure.","created_at":"2016-09-08T04:31:30Z","updated_at":"2016-09-08T19:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9927ec13521bea50e66fff40ea4c08324846beb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1559/commits","review_comments_url":"https://api.github.com/repos/javaslang/javaslang/pulls/1559/comments","review_comment_url":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javaslang/javaslang/issues/1559/comments","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/3b497bf0ef23ed85dca05a08ff5f089ba2a2b013","head":{"label":"ashrko619:ash-refactor","ref":"ash-refactor","sha":"3b497bf0ef23ed85dca05a08ff5f089ba2a2b013","user":{"login":"ashrko619","id":11240142,"avatar_url":"https://avatars.githubusercontent.com/u/11240142?v=3","gravatar_id":"","url":"https://api.github.com/users/ashrko619","html_url":"https://github.com/ashrko619","followers_url":"https://api.github.com/users/ashrko619/followers","following_url":"https://api.github.com/users/ashrko619/following{/other_user}","gists_url":"https://api.github.com/users/ashrko619/gists{/gist_id}","starred_url":"https://api.github.com/users/ashrko619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashrko619/subscriptions","organizations_url":"https://api.github.com/users/ashrko619/orgs","repos_url":"https://api.github.com/users/ashrko619/repos","events_url":"https://api.github.com/users/ashrko619/events{/privacy}","received_events_url":"https://api.github.com/users/ashrko619/received_events","type":"User","site_admin":false},"repo":{"id":62787782,"name":"javaslang","full_name":"ashrko619/javaslang","owner":{"login":"ashrko619","id":11240142,"avatar_url":"https://avatars.githubusercontent.com/u/11240142?v=3","gravatar_id":"","url":"https://api.github.com/users/ashrko619","html_url":"https://github.com/ashrko619","followers_url":"https://api.github.com/users/ashrko619/followers","following_url":"https://api.github.com/users/ashrko619/following{/other_user}","gists_url":"https://api.github.com/users/ashrko619/gists{/gist_id}","starred_url":"https://api.github.com/users/ashrko619/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashrko619/subscriptions","organizations_url":"https://api.github.com/users/ashrko619/orgs","repos_url":"https://api.github.com/users/ashrko619/repos","events_url":"https://api.github.com/users/ashrko619/events{/privacy}","received_events_url":"https://api.github.com/users/ashrko619/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashrko619/javaslang","description":"A functional library for Java 8+ that provides persistent data types and functional control structures.","fork":true,"url":"https://api.github.com/repos/ashrko619/javaslang","forks_url":"https://api.github.com/repos/ashrko619/javaslang/forks","keys_url":"https://api.github.com/repos/ashrko619/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashrko619/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashrko619/javaslang/teams","hooks_url":"https://api.github.com/repos/ashrko619/javaslang/hooks","issue_events_url":"https://api.github.com/repos/ashrko619/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/ashrko619/javaslang/events","assignees_url":"https://api.github.com/repos/ashrko619/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/ashrko619/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/ashrko619/javaslang/tags","blobs_url":"https://api.github.com/repos/ashrko619/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashrko619/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashrko619/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashrko619/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashrko619/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/ashrko619/javaslang/languages","stargazers_url":"https://api.github.com/repos/ashrko619/javaslang/stargazers","contributors_url":"https://api.github.com/repos/ashrko619/javaslang/contributors","subscribers_url":"https://api.github.com/repos/ashrko619/javaslang/subscribers","subscription_url":"https://api.github.com/repos/ashrko619/javaslang/subscription","commits_url":"https://api.github.com/repos/ashrko619/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashrko619/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashrko619/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashrko619/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashrko619/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/ashrko619/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashrko619/javaslang/merges","archive_url":"https://api.github.com/repos/ashrko619/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashrko619/javaslang/downloads","issues_url":"https://api.github.com/repos/ashrko619/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/ashrko619/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/ashrko619/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/ashrko619/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashrko619/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/ashrko619/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/ashrko619/javaslang/deployments","created_at":"2016-07-07T08:09:48Z","updated_at":"2016-07-07T08:09:50Z","pushed_at":"2016-09-08T04:18:59Z","git_url":"git://github.com/ashrko619/javaslang.git","ssh_url":"git@github.com:ashrko619/javaslang.git","clone_url":"https://github.com/ashrko619/javaslang.git","svn_url":"https://github.com/ashrko619/javaslang","homepage":"http://javaslang.io","size":12632,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"javaslang:master","ref":"master","sha":"9ce8cfdd8f4914852bb6acfadc452449f1f3b69b","user":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"repo":{"id":16378879,"name":"javaslang","full_name":"javaslang/javaslang","owner":{"login":"javaslang","id":5786132,"avatar_url":"https://avatars.githubusercontent.com/u/5786132?v=3","gravatar_id":"","url":"https://api.github.com/users/javaslang","html_url":"https://github.com/javaslang","followers_url":"https://api.github.com/users/javaslang/followers","following_url":"https://api.github.com/users/javaslang/following{/other_user}","gists_url":"https://api.github.com/users/javaslang/gists{/gist_id}","starred_url":"https://api.github.com/users/javaslang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaslang/subscriptions","organizations_url":"https://api.github.com/users/javaslang/orgs","repos_url":"https://api.github.com/users/javaslang/repos","events_url":"https://api.github.com/users/javaslang/events{/privacy}","received_events_url":"https://api.github.com/users/javaslang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/javaslang/javaslang","description":"A functional library for Java 8+ that provides persistent data types and functional control structures.","fork":false,"url":"https://api.github.com/repos/javaslang/javaslang","forks_url":"https://api.github.com/repos/javaslang/javaslang/forks","keys_url":"https://api.github.com/repos/javaslang/javaslang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javaslang/javaslang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javaslang/javaslang/teams","hooks_url":"https://api.github.com/repos/javaslang/javaslang/hooks","issue_events_url":"https://api.github.com/repos/javaslang/javaslang/issues/events{/number}","events_url":"https://api.github.com/repos/javaslang/javaslang/events","assignees_url":"https://api.github.com/repos/javaslang/javaslang/assignees{/user}","branches_url":"https://api.github.com/repos/javaslang/javaslang/branches{/branch}","tags_url":"https://api.github.com/repos/javaslang/javaslang/tags","blobs_url":"https://api.github.com/repos/javaslang/javaslang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javaslang/javaslang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javaslang/javaslang/git/refs{/sha}","trees_url":"https://api.github.com/repos/javaslang/javaslang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javaslang/javaslang/statuses/{sha}","languages_url":"https://api.github.com/repos/javaslang/javaslang/languages","stargazers_url":"https://api.github.com/repos/javaslang/javaslang/stargazers","contributors_url":"https://api.github.com/repos/javaslang/javaslang/contributors","subscribers_url":"https://api.github.com/repos/javaslang/javaslang/subscribers","subscription_url":"https://api.github.com/repos/javaslang/javaslang/subscription","commits_url":"https://api.github.com/repos/javaslang/javaslang/commits{/sha}","git_commits_url":"https://api.github.com/repos/javaslang/javaslang/git/commits{/sha}","comments_url":"https://api.github.com/repos/javaslang/javaslang/comments{/number}","issue_comment_url":"https://api.github.com/repos/javaslang/javaslang/issues/comments{/number}","contents_url":"https://api.github.com/repos/javaslang/javaslang/contents/{+path}","compare_url":"https://api.github.com/repos/javaslang/javaslang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javaslang/javaslang/merges","archive_url":"https://api.github.com/repos/javaslang/javaslang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javaslang/javaslang/downloads","issues_url":"https://api.github.com/repos/javaslang/javaslang/issues{/number}","pulls_url":"https://api.github.com/repos/javaslang/javaslang/pulls{/number}","milestones_url":"https://api.github.com/repos/javaslang/javaslang/milestones{/number}","notifications_url":"https://api.github.com/repos/javaslang/javaslang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javaslang/javaslang/labels{/name}","releases_url":"https://api.github.com/repos/javaslang/javaslang/releases{/id}","deployments_url":"https://api.github.com/repos/javaslang/javaslang/deployments","created_at":"2014-01-30T14:07:25Z","updated_at":"2016-09-08T19:00:44Z","pushed_at":"2016-09-08T18:37:12Z","git_url":"git://github.com/javaslang/javaslang.git","ssh_url":"git@github.com:javaslang/javaslang.git","clone_url":"https://github.com/javaslang/javaslang.git","svn_url":"https://github.com/javaslang/javaslang","homepage":"http://javaslang.io","size":14297,"stargazers_count":1136,"watchers_count":1136,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":133,"mirror_url":null,"open_issues_count":126,"forks":133,"open_issues":126,"watchers":1136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1559"},"html":{"href":"https://github.com/javaslang/javaslang/pull/1559"},"issue":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1559"},"comments":{"href":"https://api.github.com/repos/javaslang/javaslang/issues/1559/comments"},"review_comments":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1559/comments"},"review_comment":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javaslang/javaslang/pulls/1559/commits"},"statuses":{"href":"https://api.github.com/repos/javaslang/javaslang/statuses/3b497bf0ef23ed85dca05a08ff5f089ba2a2b013"}}}}
{"actor":{"display_login":"danieldietrich"}}