{"action":"closed","number":11,"pull_request":{"url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/11","id":63960136,"html_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX/pull/11","diff_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX/pull/11.diff","patch_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX/pull/11.patch","issue_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/11","number":11,"state":"closed","locked":false,"title":"Properly deliver events back to objective-c","user":{"login":"richardjrossiii","id":699752,"avatar_url":"https://avatars.githubusercontent.com/u/699752?v=3","gravatar_id":"","url":"https://api.github.com/users/richardjrossiii","html_url":"https://github.com/richardjrossiii","followers_url":"https://api.github.com/users/richardjrossiii/followers","following_url":"https://api.github.com/users/richardjrossiii/following{/other_user}","gists_url":"https://api.github.com/users/richardjrossiii/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjrossiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjrossiii/subscriptions","organizations_url":"https://api.github.com/users/richardjrossiii/orgs","repos_url":"https://api.github.com/users/richardjrossiii/repos","events_url":"https://api.github.com/users/richardjrossiii/events{/privacy}","received_events_url":"https://api.github.com/users/richardjrossiii/received_events","type":"User","site_admin":false},"body":"This was bugged, as HandlerConverter would be destroyed as soon as its scope was exited, causing no events to be delivered. By adding an associated object on the subscription that should be held onto by objective-c, it now only gets destroyed when the subscription does.\r\n\r\nFixes #7.","created_at":"2016-03-23T22:00:17Z","updated_at":"2016-03-24T21:21:13Z","closed_at":"2016-03-24T21:21:13Z","merged_at":"2016-03-24T21:21:13Z","merge_commit_sha":"944065de1c11702a2dcb77922a490180add977d3","assignee":{"login":"richardjrossiii","id":699752,"avatar_url":"https://avatars.githubusercontent.com/u/699752?v=3","gravatar_id":"","url":"https://api.github.com/users/richardjrossiii","html_url":"https://github.com/richardjrossiii","followers_url":"https://api.github.com/users/richardjrossiii/followers","following_url":"https://api.github.com/users/richardjrossiii/following{/other_user}","gists_url":"https://api.github.com/users/richardjrossiii/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjrossiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjrossiii/subscriptions","organizations_url":"https://api.github.com/users/richardjrossiii/orgs","repos_url":"https://api.github.com/users/richardjrossiii/repos","events_url":"https://api.github.com/users/richardjrossiii/events{/privacy}","received_events_url":"https://api.github.com/users/richardjrossiii/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/11/commits","review_comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/11/comments","review_comment_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/11/comments","statuses_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/statuses/480c2672db82cc288c505f18c2497ae83ff84478","head":{"label":"ParsePlatform:richardross.objc.weak","ref":"richardross.objc.weak","sha":"480c2672db82cc288c505f18c2497ae83ff84478","user":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54243777,"name":"ParseLiveQuery-iOS-OSX","full_name":"ParsePlatform/ParseLiveQuery-iOS-OSX","owner":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX","description":"Parse LiveQuery Client for iOS/OS X.","fork":false,"url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX","forks_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/forks","keys_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/teams","hooks_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/hooks","issue_events_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/events{/number}","events_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/events","assignees_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/assignees{/user}","branches_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/branches{/branch}","tags_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/tags","blobs_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/languages","stargazers_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/stargazers","contributors_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/contributors","subscribers_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/subscribers","subscription_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/subscription","commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/contents/{+path}","compare_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/merges","archive_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/downloads","issues_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues{/number}","pulls_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/labels{/name}","releases_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/releases{/id}","deployments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/deployments","created_at":"2016-03-19T02:42:19Z","updated_at":"2016-03-24T14:49:42Z","pushed_at":"2016-03-24T21:21:13Z","git_url":"git://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX.git","ssh_url":"git@github.com:ParsePlatform/ParseLiveQuery-iOS-OSX.git","clone_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX.git","svn_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX","homepage":null,"size":47,"stargazers_count":28,"watchers_count":28,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":28,"default_branch":"master"}},"base":{"label":"ParsePlatform:master","ref":"master","sha":"4531b82e1ddcfdfbb3f585c3e57ec8660c834ab5","user":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":54243777,"name":"ParseLiveQuery-iOS-OSX","full_name":"ParsePlatform/ParseLiveQuery-iOS-OSX","owner":{"login":"ParsePlatform","id":1294580,"avatar_url":"https://avatars.githubusercontent.com/u/1294580?v=3","gravatar_id":"","url":"https://api.github.com/users/ParsePlatform","html_url":"https://github.com/ParsePlatform","followers_url":"https://api.github.com/users/ParsePlatform/followers","following_url":"https://api.github.com/users/ParsePlatform/following{/other_user}","gists_url":"https://api.github.com/users/ParsePlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/ParsePlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParsePlatform/subscriptions","organizations_url":"https://api.github.com/users/ParsePlatform/orgs","repos_url":"https://api.github.com/users/ParsePlatform/repos","events_url":"https://api.github.com/users/ParsePlatform/events{/privacy}","received_events_url":"https://api.github.com/users/ParsePlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX","description":"Parse LiveQuery Client for iOS/OS X.","fork":false,"url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX","forks_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/forks","keys_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/teams","hooks_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/hooks","issue_events_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/events{/number}","events_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/events","assignees_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/assignees{/user}","branches_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/branches{/branch}","tags_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/tags","blobs_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/statuses/{sha}","languages_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/languages","stargazers_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/stargazers","contributors_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/contributors","subscribers_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/subscribers","subscription_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/subscription","commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/contents/{+path}","compare_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/merges","archive_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/downloads","issues_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues{/number}","pulls_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls{/number}","milestones_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/milestones{/number}","notifications_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/labels{/name}","releases_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/releases{/id}","deployments_url":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/deployments","created_at":"2016-03-19T02:42:19Z","updated_at":"2016-03-24T14:49:42Z","pushed_at":"2016-03-24T21:21:13Z","git_url":"git://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX.git","ssh_url":"git@github.com:ParsePlatform/ParseLiveQuery-iOS-OSX.git","clone_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX.git","svn_url":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX","homepage":null,"size":47,"stargazers_count":28,"watchers_count":28,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/11"},"html":{"href":"https://github.com/ParsePlatform/ParseLiveQuery-iOS-OSX/pull/11"},"issue":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/11"},"comments":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/ParsePlatform/ParseLiveQuery-iOS-OSX/statuses/480c2672db82cc288c505f18c2497ae83ff84478"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"richardjrossiii","id":699752,"avatar_url":"https://avatars.githubusercontent.com/u/699752?v=3","gravatar_id":"","url":"https://api.github.com/users/richardjrossiii","html_url":"https://github.com/richardjrossiii","followers_url":"https://api.github.com/users/richardjrossiii/followers","following_url":"https://api.github.com/users/richardjrossiii/following{/other_user}","gists_url":"https://api.github.com/users/richardjrossiii/gists{/gist_id}","starred_url":"https://api.github.com/users/richardjrossiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardjrossiii/subscriptions","organizations_url":"https://api.github.com/users/richardjrossiii/orgs","repos_url":"https://api.github.com/users/richardjrossiii/repos","events_url":"https://api.github.com/users/richardjrossiii/events{/privacy}","received_events_url":"https://api.github.com/users/richardjrossiii/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"commits":1,"additions":8,"deletions":5,"changed_files":1}}