{"action":"created","issue":{"url":"https://api.github.com/repos/mikeaboody/phishing-research/issues/43","repository_url":"https://api.github.com/repos/mikeaboody/phishing-research","labels_url":"https://api.github.com/repos/mikeaboody/phishing-research/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/mikeaboody/phishing-research/issues/43/comments","events_url":"https://api.github.com/repos/mikeaboody/phishing-research/issues/43/events","html_url":"https://github.com/mikeaboody/phishing-research/issues/43","id":178182457,"number":43,"title":"progress.log contains confidential information","user":{"login":"davidwagner","id":3349841,"avatar_url":"https://avatars.githubusercontent.com/u/3349841?v=3","gravatar_id":"","url":"https://api.github.com/users/davidwagner","html_url":"https://github.com/davidwagner","followers_url":"https://api.github.com/users/davidwagner/followers","following_url":"https://api.github.com/users/davidwagner/following{/other_user}","gists_url":"https://api.github.com/users/davidwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwagner/subscriptions","organizations_url":"https://api.github.com/users/davidwagner/orgs","repos_url":"https://api.github.com/users/davidwagner/repos","events_url":"https://api.github.com/users/davidwagner/events{/privacy}","received_events_url":"https://api.github.com/users/davidwagner/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mikeaboody/phishing-research/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"MatthewChow","id":6220630,"avatar_url":"https://avatars.githubusercontent.com/u/6220630?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewChow","html_url":"https://github.com/MatthewChow","followers_url":"https://api.github.com/users/MatthewChow/followers","following_url":"https://api.github.com/users/MatthewChow/following{/other_user}","gists_url":"https://api.github.com/users/MatthewChow/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewChow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewChow/subscriptions","organizations_url":"https://api.github.com/users/MatthewChow/orgs","repos_url":"https://api.github.com/users/MatthewChow/repos","events_url":"https://api.github.com/users/MatthewChow/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewChow/received_events","type":"User","site_admin":false},"assignees":[{"login":"MatthewChow","id":6220630,"avatar_url":"https://avatars.githubusercontent.com/u/6220630?v=3","gravatar_id":"","url":"https://api.github.com/users/MatthewChow","html_url":"https://github.com/MatthewChow","followers_url":"https://api.github.com/users/MatthewChow/followers","following_url":"https://api.github.com/users/MatthewChow/following{/other_user}","gists_url":"https://api.github.com/users/MatthewChow/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthewChow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthewChow/subscriptions","organizations_url":"https://api.github.com/users/MatthewChow/orgs","repos_url":"https://api.github.com/users/MatthewChow/repos","events_url":"https://api.github.com/users/MatthewChow/events{/privacy}","received_events_url":"https://api.github.com/users/MatthewChow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-09-20T21:16:38Z","updated_at":"2016-09-30T21:05:18Z","closed_at":null,"body":"`progress.log` contains confidential information:\r\n\r\n    Creating Output Directory for John Smith\r\n    broScripts/output/Joh/the/Matthew Chow/matthewchow95@gmail.com generated.\r\n\r\nI suspect we shouldn't have names or email addresses in there.  Suggestion: use just the first 3 letters of the name, and truncate the rest, so we get something like:\r\n\r\n    Creating Output Directory for Mat...\r\n    broScripts/output/Mat/... generated.\r\n\r\nThat's probably enough to see that progress is being made, without disclosing sensitive information.\r\n\r\nAlso I see:\r\n\r\n    [[['/home/daw/phishing-research/broScripts/output/Apo/orv/Apoorva Dornadula/a_dornadula@yahoo.com/legit_emails.log', ...\r\n\r\nThat also looks like it has confidential information in it.\r\n\r\nActually, I'm not too clear what that latter stuff is.  If it's trying to dump a data structure that contains information about every email address seen and convert it to JSON, I suspect that's bad news: that sounds like the sort of thing that's not going to scale well and might cause the CPU to explode.  Not sure it makes sense to put this in `progress.log`."},"comment":{"url":"https://api.github.com/repos/mikeaboody/phishing-research/issues/comments/250852060","html_url":"https://github.com/mikeaboody/phishing-research/issues/43#issuecomment-250852060","issue_url":"https://api.github.com/repos/mikeaboody/phishing-research/issues/43","id":250852060,"user":{"login":"davidwagner","id":3349841,"avatar_url":"https://avatars.githubusercontent.com/u/3349841?v=3","gravatar_id":"","url":"https://api.github.com/users/davidwagner","html_url":"https://github.com/davidwagner","followers_url":"https://api.github.com/users/davidwagner/followers","following_url":"https://api.github.com/users/davidwagner/following{/other_user}","gists_url":"https://api.github.com/users/davidwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwagner/subscriptions","organizations_url":"https://api.github.com/users/davidwagner/orgs","repos_url":"https://api.github.com/users/davidwagner/repos","events_url":"https://api.github.com/users/davidwagner/events{/privacy}","received_events_url":"https://api.github.com/users/davidwagner/received_events","type":"User","site_admin":false},"created_at":"2016-09-30T21:05:18Z","updated_at":"2016-09-30T21:05:18Z","body":"Not fully fixed yet -- I still see\r\n\r\n    [[['/home/daw/phishing-research/broScripts/output/Apo/orv/Apoorva Dornadula/...@yahoo.com/legit_emails.log',\r\n\r\nin progress.log, and that contains confidential information (indeed, entire headers for some emails)."}}
{"actor":{"display_login":"davidwagner"}}