{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/74965534","id":74965534,"diff_hunk":"@@ -16,25 +16,25 @@\n package com.palantir.atlasdb.transaction.api;\n \n public enum AtlasDbConstraintCheckingMode {\n-    FULL_CONSTRAINT_CHECKING_THROWS_EXCEPTIONS(ShouldThrowException.YES),\n-    FULL_CONSTRAINT_CHECKING_LOGS_EXCEPTIONS(ShouldThrowException.NO),\n-    PERFORMANCE_OPTIMAL_CONSTRAINT_CHECKING_THROWS_EXCEPTIONS(ShouldThrowException.YES),\n-    PERFORMANCE_OPTIMAL_CONSTRAINT_CHECKING_LOGS_EXCEPTIONS(ShouldThrowException.NO),\n-    NO_CONSTRAINT_CHECKING(ShouldThrowException.NO);\n+    FULL_CONSTRAINT_CHECKING_THROWS_EXCEPTIONS(ShouldThrow.YES),\n+    FULL_CONSTRAINT_CHECKING_LOGS_EXCEPTIONS(ShouldThrow.NO),\n+    PERFORMANCE_OPTIMAL_CONSTRAINT_CHECKING_THROWS_EXCEPTIONS(ShouldThrow.YES),\n+    PERFORMANCE_OPTIMAL_CONSTRAINT_CHECKING_LOGS_EXCEPTIONS(ShouldThrow.NO),\n+    NO_CONSTRAINT_CHECKING(ShouldThrow.NO);\n \n-    private static enum ShouldThrowException {\n+    private enum ShouldThrow {\n         YES,\n         NO\n     }\n \n-    private final ShouldThrowException shouldThrowException;\n+    private final ShouldThrow shouldThrowException;","path":"atlasdb-api/src/main/java/com/palantir/atlasdb/transaction/api/AtlasDbConstraintCheckingMode.java","position":22,"original_position":22,"commit_id":"9aa791cf24672500a605ba996badbd83ee6eef58","original_commit_id":"c92684dea92b258ca31cc5ac47b9ff5329a860bc","user":{"login":"joelea","id":1621411,"avatar_url":"https://avatars.githubusercontent.com/u/1621411?v=3","gravatar_id":"","url":"https://api.github.com/users/joelea","html_url":"https://github.com/joelea","followers_url":"https://api.github.com/users/joelea/followers","following_url":"https://api.github.com/users/joelea/following{/other_user}","gists_url":"https://api.github.com/users/joelea/gists{/gist_id}","starred_url":"https://api.github.com/users/joelea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelea/subscriptions","organizations_url":"https://api.github.com/users/joelea/orgs","repos_url":"https://api.github.com/users/joelea/repos","events_url":"https://api.github.com/users/joelea/events{/privacy}","received_events_url":"https://api.github.com/users/joelea/received_events","type":"User","site_admin":false},"body":"Can we bias towards deleting rules that don't buy us anything?","created_at":"2016-08-16T16:04:38Z","updated_at":"2016-08-16T16:04:38Z","html_url":"https://github.com/palantir/atlasdb/pull/778#discussion_r74965534","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/778","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/74965534"},"html":{"href":"https://github.com/palantir/atlasdb/pull/778#discussion_r74965534"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/778"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/778","id":81107709,"html_url":"https://github.com/palantir/atlasdb/pull/778","diff_url":"https://github.com/palantir/atlasdb/pull/778.diff","patch_url":"https://github.com/palantir/atlasdb/pull/778.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/778","number":778,"state":"open","locked":false,"title":"Enable baseline for atlasdb-api","user":{"login":"SerialVelocity","id":422338,"avatar_url":"https://avatars.githubusercontent.com/u/422338?v=3","gravatar_id":"","url":"https://api.github.com/users/SerialVelocity","html_url":"https://github.com/SerialVelocity","followers_url":"https://api.github.com/users/SerialVelocity/followers","following_url":"https://api.github.com/users/SerialVelocity/following{/other_user}","gists_url":"https://api.github.com/users/SerialVelocity/gists{/gist_id}","starred_url":"https://api.github.com/users/SerialVelocity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SerialVelocity/subscriptions","organizations_url":"https://api.github.com/users/SerialVelocity/orgs","repos_url":"https://api.github.com/users/SerialVelocity/repos","events_url":"https://api.github.com/users/SerialVelocity/events{/privacy}","received_events_url":"https://api.github.com/users/SerialVelocity/received_events","type":"User","site_admin":false},"body":"Changes:\r\n  - Mainly cosmetic to match baseline style\r\n\r\nLooking through by commit is probably easier.\r\n\r\n| Project | Checkstyle main bugs | Checkstyle test bugs |\r\n| --- | --- | --- |\r\n| atlasdb-api | 209 | 2 |\r\n\r\n**Baseline modifications**\r\n  - Checkstyle\r\n    - /Checker/JavadocMethod/suppressLoadErrors\r\n  - Findbugs suppressions\r\n    - EI_EXPOSE_REP\r\n    - MS_EXPOSE_REP\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/778)\r\n<!-- Reviewable:end -->\r\n","created_at":"2016-08-12T11:56:05Z","updated_at":"2016-08-16T16:04:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c92ad56de668c9277176db90ccd8f40dbd29ecf4","assignee":{"login":"jboreiko","id":837571,"avatar_url":"https://avatars.githubusercontent.com/u/837571?v=3","gravatar_id":"","url":"https://api.github.com/users/jboreiko","html_url":"https://github.com/jboreiko","followers_url":"https://api.github.com/users/jboreiko/followers","following_url":"https://api.github.com/users/jboreiko/following{/other_user}","gists_url":"https://api.github.com/users/jboreiko/gists{/gist_id}","starred_url":"https://api.github.com/users/jboreiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboreiko/subscriptions","organizations_url":"https://api.github.com/users/jboreiko/orgs","repos_url":"https://api.github.com/users/jboreiko/repos","events_url":"https://api.github.com/users/jboreiko/events{/privacy}","received_events_url":"https://api.github.com/users/jboreiko/received_events","type":"User","site_admin":false},"assignees":[{"login":"jboreiko","id":837571,"avatar_url":"https://avatars.githubusercontent.com/u/837571?v=3","gravatar_id":"","url":"https://api.github.com/users/jboreiko","html_url":"https://github.com/jboreiko","followers_url":"https://api.github.com/users/jboreiko/followers","following_url":"https://api.github.com/users/jboreiko/following{/other_user}","gists_url":"https://api.github.com/users/jboreiko/gists{/gist_id}","starred_url":"https://api.github.com/users/jboreiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jboreiko/subscriptions","organizations_url":"https://api.github.com/users/jboreiko/orgs","repos_url":"https://api.github.com/users/jboreiko/repos","events_url":"https://api.github.com/users/jboreiko/events{/privacy}","received_events_url":"https://api.github.com/users/jboreiko/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/778/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/778/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/778/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/9aa791cf24672500a605ba996badbd83ee6eef58","head":{"label":"palantir:feature/enable-baseline-for-atlasdb-api","ref":"feature/enable-baseline-for-atlasdb-api","sha":"9aa791cf24672500a605ba996badbd83ee6eef58","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-08-14T03:41:00Z","pushed_at":"2016-08-16T15:55:57Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":24324,"stargazers_count":358,"watchers_count":358,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":76,"forks":56,"open_issues":76,"watchers":358,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"518785e13cca2b731cd801544e176d65f814adba","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars.githubusercontent.com/u/303157?v=3","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2016-08-14T03:41:00Z","pushed_at":"2016-08-16T15:55:57Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":24324,"stargazers_count":358,"watchers_count":358,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":56,"mirror_url":null,"open_issues_count":76,"forks":56,"open_issues":76,"watchers":358,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/778"},"html":{"href":"https://github.com/palantir/atlasdb/pull/778"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/778"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/778/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/778/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/778/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/9aa791cf24672500a605ba996badbd83ee6eef58"}}}}
{"actor":{"display_login":"joelea"}}