{"action":"created","issue":{"url":"https://api.github.com/repos/underdogio/pup/issues/73","repository_url":"https://api.github.com/repos/underdogio/pup","labels_url":"https://api.github.com/repos/underdogio/pup/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/underdogio/pup/issues/73/comments","events_url":"https://api.github.com/repos/underdogio/pup/issues/73/events","html_url":"https://github.com/underdogio/pup/pull/73","id":195044029,"number":73,"title":".inline-center and .dot take 2","user":{"login":"brettlangdon","id":1320353,"avatar_url":"https://avatars.githubusercontent.com/u/1320353?v=3","gravatar_id":"","url":"https://api.github.com/users/brettlangdon","html_url":"https://github.com/brettlangdon","followers_url":"https://api.github.com/users/brettlangdon/followers","following_url":"https://api.github.com/users/brettlangdon/following{/other_user}","gists_url":"https://api.github.com/users/brettlangdon/gists{/gist_id}","starred_url":"https://api.github.com/users/brettlangdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettlangdon/subscriptions","organizations_url":"https://api.github.com/users/brettlangdon/orgs","repos_url":"https://api.github.com/users/brettlangdon/repos","events_url":"https://api.github.com/users/brettlangdon/events{/privacy}","received_events_url":"https://api.github.com/users/brettlangdon/received_events","type":"User","site_admin":false},"labels":[{"id":469508177,"url":"https://api.github.com/repos/underdogio/pup/labels/approved%20for%20merge","name":"approved for merge","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-12-12T18:04:48Z","updated_at":"2016-12-12T18:28:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/underdogio/pup/pulls/73","html_url":"https://github.com/underdogio/pup/pull/73","diff_url":"https://github.com/underdogio/pup/pull/73.diff","patch_url":"https://github.com/underdogio/pup/pull/73.patch"},"body":"\r\nFixes #72 \r\nA few changes here:\r\n\r\n* Fix `.inline-center` to actually center things\r\n  * New changes mean we have to apply `.inline-center` on each child element, not on the parent\r\n* Restructure how we create `.dot`s\r\n  * This also include support for having a label, so no longer uses `.inline-center`\r\n\r\n```html\r\n<div class=\"dot\">\r\n  Label:&nbsp;\r\n  <span class=\"dot__icon\"></span>\r\n</div>\r\n```\r\n\r\nOr as a stand alone dot with no label\r\n\r\n```html\r\n<div class=\"dot dot__icon\"></div>\r\n```\r\n\r\nAlthough, I don't see too much use for them as a stand alone element... but suppose if you needed it.\r\n\r\n\r\n### Inline center\r\n![image](https://cloud.githubusercontent.com/assets/1320353/21110507/7481456a-c06b-11e6-82e5-f2bdce9da9d0.png)\r\n\r\n### Dot\r\n![image](https://cloud.githubusercontent.com/assets/1320353/21110520/82e11180-c06b-11e6-95ce-fc59bd66b894.png)\r\n\r\n\r\n\r\n/cc @underdogio/engineering "},"comment":{"url":"https://api.github.com/repos/underdogio/pup/issues/comments/266510677","html_url":"https://github.com/underdogio/pup/pull/73#issuecomment-266510677","issue_url":"https://api.github.com/repos/underdogio/pup/issues/73","id":266510677,"user":{"login":"restlessbit","id":6979137,"avatar_url":"https://avatars.githubusercontent.com/u/6979137?v=3","gravatar_id":"","url":"https://api.github.com/users/restlessbit","html_url":"https://github.com/restlessbit","followers_url":"https://api.github.com/users/restlessbit/followers","following_url":"https://api.github.com/users/restlessbit/following{/other_user}","gists_url":"https://api.github.com/users/restlessbit/gists{/gist_id}","starred_url":"https://api.github.com/users/restlessbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restlessbit/subscriptions","organizations_url":"https://api.github.com/users/restlessbit/orgs","repos_url":"https://api.github.com/users/restlessbit/repos","events_url":"https://api.github.com/users/restlessbit/events{/privacy}","received_events_url":"https://api.github.com/users/restlessbit/received_events","type":"User","site_admin":false},"created_at":"2016-12-12T18:28:19Z","updated_at":"2016-12-12T18:28:19Z","body":"Now that I think about, it's probably better to separate `.inline-center` from `.dot`, in case we needed to use `.dot` on its own and don't want or need it to be centered.\r\n\r\nIf you think `vertical-align: baseline` looks better, you could create a dedicated class just for that and apply it to both the label and dot individually. And if we took that approach we could create a dot with a single element `<div class=\"dot\"></div>` \r\n\r\n![giphy](https://cloud.githubusercontent.com/assets/6979137/21111300/d53f5f38-c06e-11e6-8784-a51080b41b61.gif)\r\n"}}
{"actor":{"display_login":"restlessbit"}}