{"action":"created","issue":{"url":"https://api.github.com/repos/idaholab/moose/issues/8190","repository_url":"https://api.github.com/repos/idaholab/moose","labels_url":"https://api.github.com/repos/idaholab/moose/issues/8190/labels{/name}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/8190/comments","events_url":"https://api.github.com/repos/idaholab/moose/issues/8190/events","html_url":"https://github.com/idaholab/moose/issues/8190","id":194164614,"number":8190,"title":"Cleanup Assembly constructor","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"assignees":[{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2016-12-07T20:46:34Z","updated_at":"2016-12-07T23:09:06Z","closed_at":null,"body":"### Description of the enhancement or error report\r\n\r\nRight now we pass a reference to a pointer to the CouplingMatrix in Assembly. It turns out that we only ever update this pointer one time before we init so it's just a bad design. Instead, a `const CouplingMatrix` reference or pointer can be passed into the `init()` method where it is actually set and used for the first and only time.\r\n\r\n### Rationale for the enhancement or information for reproducing the error\r\n\r\nThis effectively removes another \"global variable reference \" from the MOOSE framework making maintenance easier. It'll also enable me to change these raw pointers which are created in various places in MOOSE whose ownership is transferred into the problem and used by Assembly. \r\n\r\n### Identified impact\r\n(i.e. Internal object changes, limited interface changes, public API change, or a list of specific applications impacted)\r\n\r\nLots of good cleanup and semantic ownership will be cleaner.\r\n\r\nThis change will have to be handled in multiple commits. I'll have to add the new interface while supporting the old interface so that Yak won't break... "},"comment":{"url":"https://api.github.com/repos/idaholab/moose/issues/comments/265603006","html_url":"https://github.com/idaholab/moose/issues/8190#issuecomment-265603006","issue_url":"https://api.github.com/repos/idaholab/moose/issues/8190","id":265603006,"user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"created_at":"2016-12-07T23:09:06Z","updated_at":"2016-12-07T23:09:06Z","body":"@andrsd - I pushed it up here: https://github.com/idaholab/moose/pull/8180/files\r\n\r\nThis will fail though because I have to patch Yak first to use the Interface that this removes. I just wanted to see if the final version breaks anything else. If only Yak fails, I'll restore the old interface to Assembly and commit these patches in an interleaved order so we don't have to do an integration branch."}}
{"actor":{"display_login":"permcody"}}