{"action":"created","comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/comments/70892078","id":70892078,"diff_hunk":"@@ -187,7 +188,15 @@ public void setParameters(List<IParameter> parameters) {\n \t\t  parameters.forEach(p -> paramsMap.put(p.getName(), p.getValue()));\n \t\t}\n \t\toriginalValueMap = paramsMap;\n-\t\tfirePropertyChange(PROPERTY_PARAMETERS, this.parameters, this.parameters = injectProjectParameters(this.eclipseProject, parameters));\n+\t\t/*\n+\t\t * firePropertyChange will send an event if the array are differents so we need to check\n+\t\t * otherwise we will risk the ObservableList to be based on the wrong list as it is assigned\n+\t\t * in the call.\n+\t\t */\n+\t\tList<IParameter> newParameters = injectProjectParameters(this.eclipseProject, parameters);\n+\t\tif (!Objects.equals(this.parameters, newParameters)) {\n+\t        firePropertyChange(PROPERTY_PARAMETERS, this.parameters, this.parameters = newParameters);","path":"plugins/org.jboss.tools.openshift.ui/src/org/jboss/tools/openshift/internal/ui/wizard/newapp/fromtemplate/ApplicationSourceFromTemplateModel.java","position":20,"original_position":20,"commit_id":"ac68e58d67b10520ebf8d2e38209f5331ede48db","original_commit_id":"ac68e58d67b10520ebf8d2e38209f5331ede48db","user":{"login":"scabanovich","id":620747,"avatar_url":"https://avatars.githubusercontent.com/u/620747?v=3","gravatar_id":"","url":"https://api.github.com/users/scabanovich","html_url":"https://github.com/scabanovich","followers_url":"https://api.github.com/users/scabanovich/followers","following_url":"https://api.github.com/users/scabanovich/following{/other_user}","gists_url":"https://api.github.com/users/scabanovich/gists{/gist_id}","starred_url":"https://api.github.com/users/scabanovich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scabanovich/subscriptions","organizations_url":"https://api.github.com/users/scabanovich/orgs","repos_url":"https://api.github.com/users/scabanovich/repos","events_url":"https://api.github.com/users/scabanovich/events{/privacy}","received_events_url":"https://api.github.com/users/scabanovich/received_events","type":"User","site_admin":false},"body":"An example of another solution that is applied several times in openshift ui:\r\n\r\n\t\tList<org.eclipse.core.resources.IProject> oldProjects = new ArrayList<>(this.projects);\r\n\t\tList<org.eclipse.core.resources.IProject> newProjects = new ArrayList<>();\r\n\t\tif (projects != null) {\r\n\t\t\tnewProjects.addAll(projects);\r\n\t\t}\r\n\t\tthis.projects.clear();\r\n\t\tthis.projects.addAll(newProjects);\r\n\t\tfirePropertyChange(PROPERTY_PROJECTS, oldProjects, this.projects);\r\n\r\nIt is verbose, but it has an advantage of always providing for clients the same instance of list. If this solution works, it might be applied in all similar cases. It can be moved to one utility method to reduce its usage by a single call.","created_at":"2016-07-14T21:58:26Z","updated_at":"2016-07-14T21:58:26Z","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1250#discussion_r70892078","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/comments/70892078"},"html":{"href":"https://github.com/jbosstools/jbosstools-openshift/pull/1250#discussion_r70892078"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250"}}},"pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250","id":77089669,"html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1250","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1250.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1250.patch","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1250","number":1250,"state":"open","locked":false,"title":"[JBIDE-22592] Application wizard: Failed even though provided required value to parameters","user":{"login":"jeffmaury","id":695993,"avatar_url":"https://avatars.githubusercontent.com/u/695993?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmaury","html_url":"https://github.com/jeffmaury","followers_url":"https://api.github.com/users/jeffmaury/followers","following_url":"https://api.github.com/users/jeffmaury/following{/other_user}","gists_url":"https://api.github.com/users/jeffmaury/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmaury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmaury/subscriptions","organizations_url":"https://api.github.com/users/jeffmaury/orgs","repos_url":"https://api.github.com/users/jeffmaury/repos","events_url":"https://api.github.com/users/jeffmaury/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmaury/received_events","type":"User","site_admin":false},"body":"\r\n- Change parameters list if values are different\r\n\r\nSigned-off-by: Jeff MAURY <jmaury@redhat.com>","created_at":"2016-07-12T09:41:33Z","updated_at":"2016-07-14T21:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9ccabdb1449677b5915977e87e33a422c1f9917","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250/commits","review_comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250/comments","review_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1250/comments","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/statuses/ac68e58d67b10520ebf8d2e38209f5331ede48db","head":{"label":"jeffmaury:JBIDE-22592","ref":"JBIDE-22592","sha":"ac68e58d67b10520ebf8d2e38209f5331ede48db","user":{"login":"jeffmaury","id":695993,"avatar_url":"https://avatars.githubusercontent.com/u/695993?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmaury","html_url":"https://github.com/jeffmaury","followers_url":"https://api.github.com/users/jeffmaury/followers","following_url":"https://api.github.com/users/jeffmaury/following{/other_user}","gists_url":"https://api.github.com/users/jeffmaury/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmaury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmaury/subscriptions","organizations_url":"https://api.github.com/users/jeffmaury/orgs","repos_url":"https://api.github.com/users/jeffmaury/repos","events_url":"https://api.github.com/users/jeffmaury/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmaury/received_events","type":"User","site_admin":false},"repo":{"id":55131851,"name":"jbosstools-openshift","full_name":"jeffmaury/jbosstools-openshift","owner":{"login":"jeffmaury","id":695993,"avatar_url":"https://avatars.githubusercontent.com/u/695993?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffmaury","html_url":"https://github.com/jeffmaury","followers_url":"https://api.github.com/users/jeffmaury/followers","following_url":"https://api.github.com/users/jeffmaury/following{/other_user}","gists_url":"https://api.github.com/users/jeffmaury/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmaury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmaury/subscriptions","organizations_url":"https://api.github.com/users/jeffmaury/orgs","repos_url":"https://api.github.com/users/jeffmaury/repos","events_url":"https://api.github.com/users/jeffmaury/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmaury/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmaury/jbosstools-openshift","description":"JBoss Tools :: OpenShift { openshift }","fork":true,"url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift","forks_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/forks","keys_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/teams","hooks_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/hooks","issue_events_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/events","assignees_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/tags","blobs_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/languages","stargazers_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/stargazers","contributors_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/contributors","subscribers_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/subscribers","subscription_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/subscription","commits_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/merges","archive_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/downloads","issues_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/labels{/name}","releases_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/jeffmaury/jbosstools-openshift/deployments","created_at":"2016-03-31T08:04:09Z","updated_at":"2016-03-31T08:04:12Z","pushed_at":"2016-07-13T13:11:55Z","git_url":"git://github.com/jeffmaury/jbosstools-openshift.git","ssh_url":"git@github.com:jeffmaury/jbosstools-openshift.git","clone_url":"https://github.com/jeffmaury/jbosstools-openshift.git","svn_url":"https://github.com/jeffmaury/jbosstools-openshift","homepage":"","size":16950,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbosstools:master","ref":"master","sha":"0a9319f6c8237199bb12cb929826de98a9e00682","user":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"repo":{"id":6308288,"name":"jbosstools-openshift","full_name":"jbosstools/jbosstools-openshift","owner":{"login":"jbosstools","id":619871,"avatar_url":"https://avatars.githubusercontent.com/u/619871?v=3","gravatar_id":"","url":"https://api.github.com/users/jbosstools","html_url":"https://github.com/jbosstools","followers_url":"https://api.github.com/users/jbosstools/followers","following_url":"https://api.github.com/users/jbosstools/following{/other_user}","gists_url":"https://api.github.com/users/jbosstools/gists{/gist_id}","starred_url":"https://api.github.com/users/jbosstools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbosstools/subscriptions","organizations_url":"https://api.github.com/users/jbosstools/orgs","repos_url":"https://api.github.com/users/jbosstools/repos","events_url":"https://api.github.com/users/jbosstools/events{/privacy}","received_events_url":"https://api.github.com/users/jbosstools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jbosstools/jbosstools-openshift","description":"JBoss Tools :: OpenShift { openshift }","fork":false,"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","forks_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/forks","keys_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/teams","hooks_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/hooks","issue_events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/events{/number}","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/events","assignees_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/assignees{/user}","branches_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/branches{/branch}","tags_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/tags","blobs_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/statuses/{sha}","languages_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/languages","stargazers_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/stargazers","contributors_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/contributors","subscribers_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/subscribers","subscription_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/subscription","commits_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/contents/{+path}","compare_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/merges","archive_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/downloads","issues_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues{/number}","pulls_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls{/number}","milestones_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/milestones{/number}","notifications_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/labels{/name}","releases_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/releases{/id}","deployments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/deployments","created_at":"2012-10-20T11:23:01Z","updated_at":"2016-01-11T16:23:14Z","pushed_at":"2016-07-13T17:15:25Z","git_url":"git://github.com/jbosstools/jbosstools-openshift.git","ssh_url":"git@github.com:jbosstools/jbosstools-openshift.git","clone_url":"https://github.com/jbosstools/jbosstools-openshift.git","svn_url":"https://github.com/jbosstools/jbosstools-openshift","homepage":"","size":20074,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":16,"forks":41,"open_issues":16,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250"},"html":{"href":"https://github.com/jbosstools/jbosstools-openshift/pull/1250"},"issue":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1250"},"comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1250/comments"},"review_comments":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250/comments"},"review_comment":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1250/commits"},"statuses":{"href":"https://api.github.com/repos/jbosstools/jbosstools-openshift/statuses/ac68e58d67b10520ebf8d2e38209f5331ede48db"}}}}
{"actor":{"display_login":"scabanovich"}}