{"push_id":1175146549,"size":1,"distinct_size":1,"ref":"refs/heads/develop","head":"8b5b9803e73f0aa2a3576c95a2c4167d1b10cf69","before":"8fb44558aa056086b3466de7cb8aa925be01e646","commits":[{"sha":"8b5b9803e73f0aa2a3576c95a2c4167d1b10cf69","author":{"name":"Aaron Mahan","email":"0ea57831a6aee87faae8cf48eb3fed040f8dc3de@forerunnergames.com"},"message":"DieRange improvements.\n\nDieRange:\n\n- Check max die count for negativity, which is not allowed, but was\n  missing.\n\n- Make default constructor public, and initialize min/max die counts to\n  0, so it can be used to create empty / uninitialized DieRange's.\n\n- Add some convenience methods, #includes (int dieCount), #excludesLow\n  (int dieCount), & #excludesHigh (int dieCount), which check if the\n  specified dieCount is within the range, or excluded above or below.\n  Reduces code verbosity & duplication, increases readability.\n\n- Rename #get[Min|Max]DieCount to #[min|max] to increase readability &\n  decrease verbosity.\n\nBattleResultPacket:\n\n- Add convenience methods #get[Attacker|Defender]DieRange.\n\nGameRules:\n\n- Rename #get[Min|Max]Total[Attacker|Defender]DieCount methods to\n  #getAbsolute[Min|Max][Attacker|Defender]DieCount, which takes away the\n  confusion with other die count methods requiring country army counts.\n  Also rename the associated public constants in ClassicGameRules.\n\n- Add missing #getAbsolute[Attacker|Defender]DieRange methods &\n  associated constants.\n\nClassicGameRulesTest:\n\n- Add tests for methods involving DieRange.\n\nJIRA:\n\nPERIL-781 #time 1h","distinct":true,"url":"https://api.github.com/repos/forerunnergames/peril/commits/8b5b9803e73f0aa2a3576c95a2c4167d1b10cf69"}]}
{"actor":{"display_login":"3xp0n3nt"}}