{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12726","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12726/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12726/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12726/events","html_url":"https://github.com/ManageIQ/manageiq/pull/12726","id":190158661,"number":12726,"title":"Move snapshot code to Vm in service model.","user":{"login":"lfu","id":2593270,"avatar_url":"https://avatars.githubusercontent.com/u/2593270?v=3","gravatar_id":"","url":"https://api.github.com/users/lfu","html_url":"https://github.com/lfu","followers_url":"https://api.github.com/users/lfu/followers","following_url":"https://api.github.com/users/lfu/following{/other_user}","gists_url":"https://api.github.com/users/lfu/gists{/gist_id}","starred_url":"https://api.github.com/users/lfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfu/subscriptions","organizations_url":"https://api.github.com/users/lfu/orgs","repos_url":"https://api.github.com/users/lfu/repos","events_url":"https://api.github.com/users/lfu/events{/privacy}","received_events_url":"https://api.github.com/users/lfu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-17T20:43:40Z","updated_at":"2016-11-21T14:57:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/12726","html_url":"https://github.com/ManageIQ/manageiq/pull/12726","diff_url":"https://github.com/ManageIQ/manageiq/pull/12726.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/12726.patch"},"body":"The snapshot code in automate was moved from VmOrTemplate to VMware specific class by PR https://github.com/ManageIQ/manageiq/pull/3707 when VMware was the only class that supported snapshot.\r\n\r\nBut snapshot support has been added to RHEVM and Openstack as of version Euwe.\r\nThe snapshot code in automate should be made available at Vm level.\r\n\r\nLinks\r\n----------------\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1395175\r\n\r\ncc @gmcculloug @mkanoor "},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/261960220","html_url":"https://github.com/ManageIQ/manageiq/pull/12726#issuecomment-261960220","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/12726","id":261960220,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2016-11-21T14:57:28Z","updated_at":"2016-11-21T14:57:28Z","body":"<rubocop />Checked commit https://github.com/lfu/manageiq/commit/e98295c7b9ca4cd24c773a0614457cd3e07739ee with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1\n4 files checked, 4 offenses detected\n\n**lib/miq_automation_engine/service_models/miq_ae_service_vm.rb**\n- [ ] :exclamation: - [Line 13](https://github.com/lfu/manageiq/blob/e98295c7b9ca4cd24c773a0614457cd3e07739ee/lib/miq_automation_engine/service_models/miq_ae_service_vm.rb#L13), Col 92 - [Style/DoubleNegation](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/DoubleNegation) - Avoid the use of double negation (`!!`).\n\n**spec/lib/miq_automation_engine/service_methods/miq_ae_service_manageiq-providers-vmware-infra_manager-vm_spec.rb**\n- [ ] :exclamation: - [Line 1](https://github.com/lfu/manageiq/blob/e98295c7b9ca4cd24c773a0614457cd3e07739ee/spec/lib/miq_automation_engine/service_methods/miq_ae_service_manageiq-providers-vmware-infra_manager-vm_spec.rb#L1), Col 1 - [Style/FileName](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/FileName) - Use snake_case for source file names.\n- [ ] :exclamation: - [Line 1](https://github.com/lfu/manageiq/blob/e98295c7b9ca4cd24c773a0614457cd3e07739ee/spec/lib/miq_automation_engine/service_methods/miq_ae_service_manageiq-providers-vmware-infra_manager-vm_spec.rb#L1), Col 8 - [Style/ClassAndModuleCamelCase](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/ClassAndModuleCamelCase) - Use CamelCase for classes and modules.\n\n**spec/lib/miq_automation_engine/service_methods/miq_ae_service_vm_spec.rb**\n- [ ] :exclamation: - [Line 221](https://github.com/lfu/manageiq/blob/e98295c7b9ca4cd24c773a0614457cd3e07739ee/spec/lib/miq_automation_engine/service_methods/miq_ae_service_vm_spec.rb#L221), Col 1 - [Style/EmptyLinesAroundBlockBody](http://rubydoc.info/gems/rubocop/0.37.2/RuboCop/Cop/Style/EmptyLinesAroundBlockBody) - Extra empty line detected at block body beginning.\n"}}
{"actor":{"display_login":"miq-bot"}}