{"action":"closed","number":46,"pull_request":{"url":"https://api.github.com/repos/mbroadst/qamqp/pulls/46","id":68305859,"html_url":"https://github.com/mbroadst/qamqp/pull/46","diff_url":"https://github.com/mbroadst/qamqp/pull/46.diff","patch_url":"https://github.com/mbroadst/qamqp/pull/46.patch","issue_url":"https://api.github.com/repos/mbroadst/qamqp/issues/46","number":46,"state":"closed","locked":false,"title":"timestamp in AMQP-0-9-1 should be seconds other than milliseconds","user":{"login":"johnzhanghua","id":17587759,"avatar_url":"https://avatars.githubusercontent.com/u/17587759?v=3","gravatar_id":"","url":"https://api.github.com/users/johnzhanghua","html_url":"https://github.com/johnzhanghua","followers_url":"https://api.github.com/users/johnzhanghua/followers","following_url":"https://api.github.com/users/johnzhanghua/following{/other_user}","gists_url":"https://api.github.com/users/johnzhanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/johnzhanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnzhanghua/subscriptions","organizations_url":"https://api.github.com/users/johnzhanghua/orgs","repos_url":"https://api.github.com/users/johnzhanghua/repos","events_url":"https://api.github.com/users/johnzhanghua/events{/privacy}","received_events_url":"https://api.github.com/users/johnzhanghua/received_events","type":"User","site_admin":false},"body":"As per the spec of AMQP 0-9-1, the timestamp value should be :\r\n\r\n4.2.5.4 Timestamps\r\nTime stamps are held in the 64-bit POSIX time_t format with an accuracy of one second. By using 64 bits\r\nwe avoid future wraparound issues associated with 31-bit and 32-bit time_t values.\r\n\r\nSo the qampqframe.cpp should be changed as the commit \r\n\r\nThanks,\r\nJohn Zhang","created_at":"2016-04-28T23:20:33Z","updated_at":"2016-05-26T02:31:38Z","closed_at":"2016-05-26T02:31:38Z","merged_at":"2016-05-26T02:31:38Z","merge_commit_sha":"9e8d9b7254da4614f3223fb5844c81daa87b4591","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mbroadst/qamqp/pulls/46/commits","review_comments_url":"https://api.github.com/repos/mbroadst/qamqp/pulls/46/comments","review_comment_url":"https://api.github.com/repos/mbroadst/qamqp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mbroadst/qamqp/issues/46/comments","statuses_url":"https://api.github.com/repos/mbroadst/qamqp/statuses/3dad5e76611102eddeeaac0dedcddf4548d7a730","head":{"label":"johnzhanghua:master","ref":"master","sha":"3dad5e76611102eddeeaac0dedcddf4548d7a730","user":{"login":"johnzhanghua","id":17587759,"avatar_url":"https://avatars.githubusercontent.com/u/17587759?v=3","gravatar_id":"","url":"https://api.github.com/users/johnzhanghua","html_url":"https://github.com/johnzhanghua","followers_url":"https://api.github.com/users/johnzhanghua/followers","following_url":"https://api.github.com/users/johnzhanghua/following{/other_user}","gists_url":"https://api.github.com/users/johnzhanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/johnzhanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnzhanghua/subscriptions","organizations_url":"https://api.github.com/users/johnzhanghua/orgs","repos_url":"https://api.github.com/users/johnzhanghua/repos","events_url":"https://api.github.com/users/johnzhanghua/events{/privacy}","received_events_url":"https://api.github.com/users/johnzhanghua/received_events","type":"User","site_admin":false},"repo":{"id":57339485,"name":"qamqp","full_name":"johnzhanghua/qamqp","owner":{"login":"johnzhanghua","id":17587759,"avatar_url":"https://avatars.githubusercontent.com/u/17587759?v=3","gravatar_id":"","url":"https://api.github.com/users/johnzhanghua","html_url":"https://github.com/johnzhanghua","followers_url":"https://api.github.com/users/johnzhanghua/followers","following_url":"https://api.github.com/users/johnzhanghua/following{/other_user}","gists_url":"https://api.github.com/users/johnzhanghua/gists{/gist_id}","starred_url":"https://api.github.com/users/johnzhanghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnzhanghua/subscriptions","organizations_url":"https://api.github.com/users/johnzhanghua/orgs","repos_url":"https://api.github.com/users/johnzhanghua/repos","events_url":"https://api.github.com/users/johnzhanghua/events{/privacy}","received_events_url":"https://api.github.com/users/johnzhanghua/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnzhanghua/qamqp","description":"AMQP 0.9.1 implementation for Qt","fork":true,"url":"https://api.github.com/repos/johnzhanghua/qamqp","forks_url":"https://api.github.com/repos/johnzhanghua/qamqp/forks","keys_url":"https://api.github.com/repos/johnzhanghua/qamqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnzhanghua/qamqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnzhanghua/qamqp/teams","hooks_url":"https://api.github.com/repos/johnzhanghua/qamqp/hooks","issue_events_url":"https://api.github.com/repos/johnzhanghua/qamqp/issues/events{/number}","events_url":"https://api.github.com/repos/johnzhanghua/qamqp/events","assignees_url":"https://api.github.com/repos/johnzhanghua/qamqp/assignees{/user}","branches_url":"https://api.github.com/repos/johnzhanghua/qamqp/branches{/branch}","tags_url":"https://api.github.com/repos/johnzhanghua/qamqp/tags","blobs_url":"https://api.github.com/repos/johnzhanghua/qamqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnzhanghua/qamqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnzhanghua/qamqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnzhanghua/qamqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnzhanghua/qamqp/statuses/{sha}","languages_url":"https://api.github.com/repos/johnzhanghua/qamqp/languages","stargazers_url":"https://api.github.com/repos/johnzhanghua/qamqp/stargazers","contributors_url":"https://api.github.com/repos/johnzhanghua/qamqp/contributors","subscribers_url":"https://api.github.com/repos/johnzhanghua/qamqp/subscribers","subscription_url":"https://api.github.com/repos/johnzhanghua/qamqp/subscription","commits_url":"https://api.github.com/repos/johnzhanghua/qamqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnzhanghua/qamqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnzhanghua/qamqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnzhanghua/qamqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnzhanghua/qamqp/contents/{+path}","compare_url":"https://api.github.com/repos/johnzhanghua/qamqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnzhanghua/qamqp/merges","archive_url":"https://api.github.com/repos/johnzhanghua/qamqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnzhanghua/qamqp/downloads","issues_url":"https://api.github.com/repos/johnzhanghua/qamqp/issues{/number}","pulls_url":"https://api.github.com/repos/johnzhanghua/qamqp/pulls{/number}","milestones_url":"https://api.github.com/repos/johnzhanghua/qamqp/milestones{/number}","notifications_url":"https://api.github.com/repos/johnzhanghua/qamqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnzhanghua/qamqp/labels{/name}","releases_url":"https://api.github.com/repos/johnzhanghua/qamqp/releases{/id}","deployments_url":"https://api.github.com/repos/johnzhanghua/qamqp/deployments","created_at":"2016-04-28T23:11:00Z","updated_at":"2016-04-28T23:11:01Z","pushed_at":"2016-04-28T23:14:28Z","git_url":"git://github.com/johnzhanghua/qamqp.git","ssh_url":"git@github.com:johnzhanghua/qamqp.git","clone_url":"https://github.com/johnzhanghua/qamqp.git","svn_url":"https://github.com/johnzhanghua/qamqp","homepage":"","size":687,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mbroadst:master","ref":"master","sha":"aa2b9894385a77ae9972cb60cfaf82b4dc316873","user":{"login":"mbroadst","id":312966,"avatar_url":"https://avatars.githubusercontent.com/u/312966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},"repo":{"id":20227488,"name":"qamqp","full_name":"mbroadst/qamqp","owner":{"login":"mbroadst","id":312966,"avatar_url":"https://avatars.githubusercontent.com/u/312966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbroadst/qamqp","description":"AMQP 0.9.1 implementation for Qt","fork":false,"url":"https://api.github.com/repos/mbroadst/qamqp","forks_url":"https://api.github.com/repos/mbroadst/qamqp/forks","keys_url":"https://api.github.com/repos/mbroadst/qamqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbroadst/qamqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbroadst/qamqp/teams","hooks_url":"https://api.github.com/repos/mbroadst/qamqp/hooks","issue_events_url":"https://api.github.com/repos/mbroadst/qamqp/issues/events{/number}","events_url":"https://api.github.com/repos/mbroadst/qamqp/events","assignees_url":"https://api.github.com/repos/mbroadst/qamqp/assignees{/user}","branches_url":"https://api.github.com/repos/mbroadst/qamqp/branches{/branch}","tags_url":"https://api.github.com/repos/mbroadst/qamqp/tags","blobs_url":"https://api.github.com/repos/mbroadst/qamqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbroadst/qamqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbroadst/qamqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbroadst/qamqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbroadst/qamqp/statuses/{sha}","languages_url":"https://api.github.com/repos/mbroadst/qamqp/languages","stargazers_url":"https://api.github.com/repos/mbroadst/qamqp/stargazers","contributors_url":"https://api.github.com/repos/mbroadst/qamqp/contributors","subscribers_url":"https://api.github.com/repos/mbroadst/qamqp/subscribers","subscription_url":"https://api.github.com/repos/mbroadst/qamqp/subscription","commits_url":"https://api.github.com/repos/mbroadst/qamqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbroadst/qamqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbroadst/qamqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbroadst/qamqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbroadst/qamqp/contents/{+path}","compare_url":"https://api.github.com/repos/mbroadst/qamqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbroadst/qamqp/merges","archive_url":"https://api.github.com/repos/mbroadst/qamqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbroadst/qamqp/downloads","issues_url":"https://api.github.com/repos/mbroadst/qamqp/issues{/number}","pulls_url":"https://api.github.com/repos/mbroadst/qamqp/pulls{/number}","milestones_url":"https://api.github.com/repos/mbroadst/qamqp/milestones{/number}","notifications_url":"https://api.github.com/repos/mbroadst/qamqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbroadst/qamqp/labels{/name}","releases_url":"https://api.github.com/repos/mbroadst/qamqp/releases{/id}","deployments_url":"https://api.github.com/repos/mbroadst/qamqp/deployments","created_at":"2014-05-27T16:46:56Z","updated_at":"2016-05-24T21:55:33Z","pushed_at":"2016-05-26T02:31:38Z","git_url":"git://github.com/mbroadst/qamqp.git","ssh_url":"git@github.com:mbroadst/qamqp.git","clone_url":"https://github.com/mbroadst/qamqp.git","svn_url":"https://github.com/mbroadst/qamqp","homepage":"","size":742,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"open_issues_count":10,"forks":37,"open_issues":10,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mbroadst/qamqp/pulls/46"},"html":{"href":"https://github.com/mbroadst/qamqp/pull/46"},"issue":{"href":"https://api.github.com/repos/mbroadst/qamqp/issues/46"},"comments":{"href":"https://api.github.com/repos/mbroadst/qamqp/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/mbroadst/qamqp/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/mbroadst/qamqp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mbroadst/qamqp/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/mbroadst/qamqp/statuses/3dad5e76611102eddeeaac0dedcddf4548d7a730"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mbroadst","id":312966,"avatar_url":"https://avatars.githubusercontent.com/u/312966?v=3","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mbroadst"}}