{"action":"created","issue":{"url":"https://api.github.com/repos/Wikia/app/issues/11557","repository_url":"https://api.github.com/repos/Wikia/app","labels_url":"https://api.github.com/repos/Wikia/app/issues/11557/labels{/name}","comments_url":"https://api.github.com/repos/Wikia/app/issues/11557/comments","events_url":"https://api.github.com/repos/Wikia/app/issues/11557/events","html_url":"https://github.com/Wikia/app/pull/11557","id":180762478,"number":11557,"title":"Update the cake PHP recirculation client to use the new \"authors\" element","user":{"login":"drsnyder","id":21621,"avatar_url":"https://avatars.githubusercontent.com/u/21621?v=3","gravatar_id":"","url":"https://api.github.com/users/drsnyder","html_url":"https://github.com/drsnyder","followers_url":"https://api.github.com/users/drsnyder/followers","following_url":"https://api.github.com/users/drsnyder/following{/other_user}","gists_url":"https://api.github.com/users/drsnyder/gists{/gist_id}","starred_url":"https://api.github.com/users/drsnyder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drsnyder/subscriptions","organizations_url":"https://api.github.com/users/drsnyder/orgs","repos_url":"https://api.github.com/users/drsnyder/repos","events_url":"https://api.github.com/users/drsnyder/events{/privacy}","received_events_url":"https://api.github.com/users/drsnyder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-03T22:23:55Z","updated_at":"2016-10-04T17:02:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/11557","html_url":"https://github.com/Wikia/app/pull/11557","diff_url":"https://github.com/Wikia/app/pull/11557.diff","patch_url":"https://github.com/Wikia/app/pull/11557.patch"},"body":"https://wikia-inc.atlassian.net/browse/CAKE-670\r\n\r\nWe added an `authors` element to the related content API that supersedes the metadata author values. This PR pulls in the new `author` to the CAKE recirculation payload and updates the rail widget to use the first author supplied.\r\n\r\nNote: Most of this PR contains swagger generated client code updates. In order to retrieve `content.authors` we needed to update the swagger generated client.\r\n\r\nQuestion: will mustache fail gracefully if `authors` is an empty array? It would appear that the answer is yes, but I'm not certain.\r\n\r\nTODO:\r\n - [x] remove the existing `author` from the recirculation API payload\r\n\r\n\r\n@Wikia/cake @pauloslund "},"comment":{"url":"https://api.github.com/repos/Wikia/app/issues/comments/251448872","html_url":"https://github.com/Wikia/app/pull/11557#issuecomment-251448872","issue_url":"https://api.github.com/repos/Wikia/app/issues/11557","id":251448872,"user":{"login":"nmonterroso","id":325800,"avatar_url":"https://avatars.githubusercontent.com/u/325800?v=3","gravatar_id":"","url":"https://api.github.com/users/nmonterroso","html_url":"https://github.com/nmonterroso","followers_url":"https://api.github.com/users/nmonterroso/followers","following_url":"https://api.github.com/users/nmonterroso/following{/other_user}","gists_url":"https://api.github.com/users/nmonterroso/gists{/gist_id}","starred_url":"https://api.github.com/users/nmonterroso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmonterroso/subscriptions","organizations_url":"https://api.github.com/users/nmonterroso/orgs","repos_url":"https://api.github.com/users/nmonterroso/repos","events_url":"https://api.github.com/users/nmonterroso/events{/privacy}","received_events_url":"https://api.github.com/users/nmonterroso/received_events","type":"User","site_admin":false},"created_at":"2016-10-04T17:02:44Z","updated_at":"2016-10-04T17:02:44Z","body":">Question: will mustache fail gracefully if authors is an empty array? It would appear that the answer is yes, but I'm not certain.\r\nThis seems like something you can answer by forcefully emptying the array.\r\n\r\nWhat version of Swagger did you use to generate the client? There are changes in the core files (client, exception, etc) that are shared among all the generated clients, which has caused problems in the past with backwards-incompatible changes in the function signatures. The [README](https://github.com/Wikia/app/tree/dev/lib/Swagger#code-generation-settings) has the version that was last used (or should be - on the PHP side this is hard to enforce). So I'd recommend only merging the changes to core files if you're sure the newly generated code doesn't break anything else. From looking at the changes they seem inconsequential except for changing static functions to instance functions [here](https://github.com/Wikia/app/pull/11557/files#diff-5f895d988a812621d21f59f514a6e3a4L278). "}}
{"actor":{"display_login":"nmonterroso"}}