{"action":"created","comment":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/comments/90796495","pull_request_review_id":11311750,"id":90796495,"diff_hunk":"@@ -19,21 +19,38 @@\n     #define GearMotor_h\n \n     #include \"Arduino.h\"\n-\n+    \n+    struct LinSegment{\n+        float slope  = 1;\n+        float intercept = 0;\n+        //The bounds are strict, so if the bounds are 0,1 .9 would work\n+        //but 1 and 0 will not\n+        int positiveBound = 0;\n+        int negativeBound = 0;\n+    };\n+    \n+    \n+    \n     class GearMotor{\n         public:\n             GearMotor();\n             void attach(int pin);\n             int  setupMotor(int pwmPin, int pin1, int pin2);\n             void detach();\n             void write(int speed);\n-            int attached();\n+            int  attached();\n+            void setBoost(int negBoost, int posBoost);\n+            int  _convolve(int input);\n+            void setSegment(int index, float slope, float intercept, int negativeBound, int positiveBound);\n         private:\n             int _pwmPin;\n             int _pin1;\n             int _pin2;\n             bool _attachedState;\n-            int _deadBand = 15;\n+            int _posBoost = 0;\n+            int _negBoost = 0;","path":"cnc_ctrl_v1/libraries/GearMotor/GearMotor.h","position":36,"original_position":36,"commit_id":"f3cbc7f780a3671fb0fba7271e1e48d25beab98d","original_commit_id":"f3cbc7f780a3671fb0fba7271e1e48d25beab98d","user":{"login":"BarbourSmith","id":9359447,"avatar_url":"https://avatars.githubusercontent.com/u/9359447?v=3","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false},"body":"💥 ","created_at":"2016-12-05T02:41:37Z","updated_at":"2016-12-05T02:41:47Z","html_url":"https://github.com/MaslowCNC/Firmware/pull/70#discussion_r90796495","pull_request_url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/comments/90796495"},"html":{"href":"https://github.com/MaslowCNC/Firmware/pull/70#discussion_r90796495"},"pull_request":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70","id":96460941,"html_url":"https://github.com/MaslowCNC/Firmware/pull/70","diff_url":"https://github.com/MaslowCNC/Firmware/pull/70.diff","patch_url":"https://github.com/MaslowCNC/Firmware/pull/70.patch","issue_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/70","number":70,"state":"open","locked":false,"title":"Linearize the motor response","user":{"login":"BarbourSmith","id":9359447,"avatar_url":"https://avatars.githubusercontent.com/u/9359447?v=3","gravatar_id":"","url":"https://api.github.com/users/BarbourSmith","html_url":"https://github.com/BarbourSmith","followers_url":"https://api.github.com/users/BarbourSmith/followers","following_url":"https://api.github.com/users/BarbourSmith/following{/other_user}","gists_url":"https://api.github.com/users/BarbourSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/BarbourSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BarbourSmith/subscriptions","organizations_url":"https://api.github.com/users/BarbourSmith/orgs","repos_url":"https://api.github.com/users/BarbourSmith/repos","events_url":"https://api.github.com/users/BarbourSmith/events{/privacy}","received_events_url":"https://api.github.com/users/BarbourSmith/received_events","type":"User","site_admin":false},"body":null,"created_at":"2016-12-05T02:38:25Z","updated_at":"2016-12-05T02:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"185c697360cfac5de891e6a85ec71ca66fb466ba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70/commits","review_comments_url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70/comments","review_comment_url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/70/comments","statuses_url":"https://api.github.com/repos/MaslowCNC/Firmware/statuses/f3cbc7f780a3671fb0fba7271e1e48d25beab98d","head":{"label":"MaslowCNC:symetry2","ref":"symetry2","sha":"f3cbc7f780a3671fb0fba7271e1e48d25beab98d","user":{"login":"MaslowCNC","id":9359461,"avatar_url":"https://avatars.githubusercontent.com/u/9359461?v=3","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"repo":{"id":25615246,"name":"Firmware","full_name":"MaslowCNC/Firmware","owner":{"login":"MaslowCNC","id":9359461,"avatar_url":"https://avatars.githubusercontent.com/u/9359461?v=3","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MaslowCNC/Firmware","description":"Maslow Firmware","fork":false,"url":"https://api.github.com/repos/MaslowCNC/Firmware","forks_url":"https://api.github.com/repos/MaslowCNC/Firmware/forks","keys_url":"https://api.github.com/repos/MaslowCNC/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaslowCNC/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaslowCNC/Firmware/teams","hooks_url":"https://api.github.com/repos/MaslowCNC/Firmware/hooks","issue_events_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/MaslowCNC/Firmware/events","assignees_url":"https://api.github.com/repos/MaslowCNC/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/MaslowCNC/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/MaslowCNC/Firmware/tags","blobs_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaslowCNC/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/MaslowCNC/Firmware/languages","stargazers_url":"https://api.github.com/repos/MaslowCNC/Firmware/stargazers","contributors_url":"https://api.github.com/repos/MaslowCNC/Firmware/contributors","subscribers_url":"https://api.github.com/repos/MaslowCNC/Firmware/subscribers","subscription_url":"https://api.github.com/repos/MaslowCNC/Firmware/subscription","commits_url":"https://api.github.com/repos/MaslowCNC/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaslowCNC/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaslowCNC/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/MaslowCNC/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaslowCNC/Firmware/merges","archive_url":"https://api.github.com/repos/MaslowCNC/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaslowCNC/Firmware/downloads","issues_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/MaslowCNC/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/MaslowCNC/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaslowCNC/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/MaslowCNC/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/MaslowCNC/Firmware/deployments","created_at":"2014-10-23T02:27:28Z","updated_at":"2016-12-03T19:32:45Z","pushed_at":"2016-12-05T02:38:25Z","git_url":"git://github.com/MaslowCNC/Firmware.git","ssh_url":"git@github.com:MaslowCNC/Firmware.git","clone_url":"https://github.com/MaslowCNC/Firmware.git","svn_url":"https://github.com/MaslowCNC/Firmware","homepage":"","size":382,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":38,"default_branch":"master"}},"base":{"label":"MaslowCNC:master","ref":"master","sha":"de6e96b30283339eb0b775da4bcfd29c054b779e","user":{"login":"MaslowCNC","id":9359461,"avatar_url":"https://avatars.githubusercontent.com/u/9359461?v=3","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"repo":{"id":25615246,"name":"Firmware","full_name":"MaslowCNC/Firmware","owner":{"login":"MaslowCNC","id":9359461,"avatar_url":"https://avatars.githubusercontent.com/u/9359461?v=3","gravatar_id":"","url":"https://api.github.com/users/MaslowCNC","html_url":"https://github.com/MaslowCNC","followers_url":"https://api.github.com/users/MaslowCNC/followers","following_url":"https://api.github.com/users/MaslowCNC/following{/other_user}","gists_url":"https://api.github.com/users/MaslowCNC/gists{/gist_id}","starred_url":"https://api.github.com/users/MaslowCNC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaslowCNC/subscriptions","organizations_url":"https://api.github.com/users/MaslowCNC/orgs","repos_url":"https://api.github.com/users/MaslowCNC/repos","events_url":"https://api.github.com/users/MaslowCNC/events{/privacy}","received_events_url":"https://api.github.com/users/MaslowCNC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MaslowCNC/Firmware","description":"Maslow Firmware","fork":false,"url":"https://api.github.com/repos/MaslowCNC/Firmware","forks_url":"https://api.github.com/repos/MaslowCNC/Firmware/forks","keys_url":"https://api.github.com/repos/MaslowCNC/Firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaslowCNC/Firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaslowCNC/Firmware/teams","hooks_url":"https://api.github.com/repos/MaslowCNC/Firmware/hooks","issue_events_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/events{/number}","events_url":"https://api.github.com/repos/MaslowCNC/Firmware/events","assignees_url":"https://api.github.com/repos/MaslowCNC/Firmware/assignees{/user}","branches_url":"https://api.github.com/repos/MaslowCNC/Firmware/branches{/branch}","tags_url":"https://api.github.com/repos/MaslowCNC/Firmware/tags","blobs_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaslowCNC/Firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/MaslowCNC/Firmware/languages","stargazers_url":"https://api.github.com/repos/MaslowCNC/Firmware/stargazers","contributors_url":"https://api.github.com/repos/MaslowCNC/Firmware/contributors","subscribers_url":"https://api.github.com/repos/MaslowCNC/Firmware/subscribers","subscription_url":"https://api.github.com/repos/MaslowCNC/Firmware/subscription","commits_url":"https://api.github.com/repos/MaslowCNC/Firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaslowCNC/Firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaslowCNC/Firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaslowCNC/Firmware/contents/{+path}","compare_url":"https://api.github.com/repos/MaslowCNC/Firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaslowCNC/Firmware/merges","archive_url":"https://api.github.com/repos/MaslowCNC/Firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaslowCNC/Firmware/downloads","issues_url":"https://api.github.com/repos/MaslowCNC/Firmware/issues{/number}","pulls_url":"https://api.github.com/repos/MaslowCNC/Firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/MaslowCNC/Firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/MaslowCNC/Firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaslowCNC/Firmware/labels{/name}","releases_url":"https://api.github.com/repos/MaslowCNC/Firmware/releases{/id}","deployments_url":"https://api.github.com/repos/MaslowCNC/Firmware/deployments","created_at":"2014-10-23T02:27:28Z","updated_at":"2016-12-03T19:32:45Z","pushed_at":"2016-12-05T02:38:25Z","git_url":"git://github.com/MaslowCNC/Firmware.git","ssh_url":"git@github.com:MaslowCNC/Firmware.git","clone_url":"https://github.com/MaslowCNC/Firmware.git","svn_url":"https://github.com/MaslowCNC/Firmware","homepage":"","size":382,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70"},"html":{"href":"https://github.com/MaslowCNC/Firmware/pull/70"},"issue":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/issues/70"},"comments":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/MaslowCNC/Firmware/statuses/f3cbc7f780a3671fb0fba7271e1e48d25beab98d"}}}}
{"actor":{"display_login":"BarbourSmith"}}