{"action":"created","issue":{"url":"https://api.github.com/repos/websharks/comment-mail/issues/298","repository_url":"https://api.github.com/repos/websharks/comment-mail","labels_url":"https://api.github.com/repos/websharks/comment-mail/issues/298/labels{/name}","comments_url":"https://api.github.com/repos/websharks/comment-mail/issues/298/comments","events_url":"https://api.github.com/repos/websharks/comment-mail/issues/298/events","html_url":"https://github.com/websharks/comment-mail/issues/298","id":174399819,"number":298,"title":"Comment Mail  PHP7 Compatibility","user":{"login":"renzms","id":13220018,"avatar_url":"https://avatars.githubusercontent.com/u/13220018?v=3","gravatar_id":"","url":"https://api.github.com/users/renzms","html_url":"https://github.com/renzms","followers_url":"https://api.github.com/users/renzms/followers","following_url":"https://api.github.com/users/renzms/following{/other_user}","gists_url":"https://api.github.com/users/renzms/gists{/gist_id}","starred_url":"https://api.github.com/users/renzms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renzms/subscriptions","organizations_url":"https://api.github.com/users/renzms/orgs","repos_url":"https://api.github.com/users/renzms/repos","events_url":"https://api.github.com/users/renzms/events{/privacy}","received_events_url":"https://api.github.com/users/renzms/received_events","type":"User","site_admin":false},"labels":[{"id":130483306,"url":"https://api.github.com/repos/websharks/comment-mail/labels/todo","name":"todo","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-31T23:05:02Z","updated_at":"2016-12-13T22:00:47Z","closed_at":"2016-12-13T22:00:47Z","body":"Using the [PHP compatibility checker](https://wordpress.org/plugins/php-compatibility-checker/) against Comment Mail Pro in WordPress yields the following results:\n\n**Comment Mail Pro**\n\n```\nFILE: /wp-content/plugins/comment-mail-pro/src/vendor/lusitanian/oauth/src/OAuth/Common/Http/Uri/UriFactoryInterface.php\n-------------------------------------------------------------------------------------------------------------------------------------------------------\nFOUND 1 ERROR AFFECTING 1 LINE\n-------------------------------------------------------------------------------------------------------------------------------------------------------\n 17 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n-------------------------------------------------------------------------------------------------------------------------------------------------------\n\n\nFILE: /wp-content/plugins/comment-mail-pro/src/vendor/lusitanian/oauth/src/OAuth/Common/Http/Uri/UriFactory.php\n----------------------------------------------------------------------------------------------------------------------------------------------\nFOUND 7 ERRORS AFFECTING 7 LINES\n----------------------------------------------------------------------------------------------------------------------------------------------\n  19 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n  76 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n  95 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n 118 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n 134 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n 144 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n 160 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\n----------------------------------------------------------------------------------------------------------------------------------------------\n```\n\nSee Jason's findings here:\n\n> The error in a Comment Mail library: \"Parameter shadowing super global ($_server) causes fatal error since PHP 5.4\", is worth taking a closer look at. I suspect this is a false-positive as well, but it won't hurt to dig deeper on this one and be sure. That's being triggered in a library dependency in Comment Mail and not in the Comment Mail codebase itself.\n> \n> If you're looking for problems, you'd want to put your attention on the `composer.json` file and do a review of the external library dependencies that it has.\n"},"comment":{"url":"https://api.github.com/repos/websharks/comment-mail/issues/comments/266875635","html_url":"https://github.com/websharks/comment-mail/issues/298#issuecomment-266875635","issue_url":"https://api.github.com/repos/websharks/comment-mail/issues/298","id":266875635,"user":{"login":"raamdev","id":53005,"avatar_url":"https://avatars.githubusercontent.com/u/53005?v=3","gravatar_id":"","url":"https://api.github.com/users/raamdev","html_url":"https://github.com/raamdev","followers_url":"https://api.github.com/users/raamdev/followers","following_url":"https://api.github.com/users/raamdev/following{/other_user}","gists_url":"https://api.github.com/users/raamdev/gists{/gist_id}","starred_url":"https://api.github.com/users/raamdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raamdev/subscriptions","organizations_url":"https://api.github.com/users/raamdev/orgs","repos_url":"https://api.github.com/users/raamdev/repos","events_url":"https://api.github.com/users/raamdev/events{/privacy}","received_events_url":"https://api.github.com/users/raamdev/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T22:00:47Z","updated_at":"2016-12-13T22:00:47Z","body":"Closing this, as Comment Mail has now been whitelisted in the PHP Compatibility Checker plugin as compatible with PHP 7: https://wordpress.org/support/topic/false-positive-comment-mail/"}}
{"actor":{"display_login":"raamdev"}}