{"action":"created","issue":{"url":"https://api.github.com/repos/inspirehep/inspire-next/issues/1200","repository_url":"https://api.github.com/repos/inspirehep/inspire-next","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/1200/labels{/name}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/1200/comments","events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/1200/events","html_url":"https://github.com/inspirehep/inspire-next/pull/1200","id":159576080,"number":1200,"title":"WIP tests: unit tests for DoJSON","user":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars.githubusercontent.com/u/381280?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars.githubusercontent.com/u/381280?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2016-06-10T07:33:44Z","updated_at":"2016-06-20T20:14:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/1200","html_url":"https://github.com/inspirehep/inspire-next/pull/1200","diff_url":"https://github.com/inspirehep/inspire-next/pull/1200.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/1200.patch"},"body":"This PR adds more tests to the DoJSON conversions for the \"minor\" collections: Institutions, Conferences, Experiments, Jobs, and Journals.\r\n\r\nThe main purpose is to see what we actually have in the data and discover its quirks. Some will have to be solved in Legacy (like https://github.com/inspirehep/inspire/issues/170), others will have to be taken in account when building the DoJSON rules.\r\n\r\nOnly the assertions will have to be changed when we finalise the schemas, the test cases will stay the same (which is why this work will not be wasted).\r\n\r\n- [ ] Institutions\r\n    - [ ] Fix population of `name_variants`\r\n    - [ ] Test `name_variants`\r\n    - [ ] Test `hidden_notes`\r\n    - [ ] Solve https://github.com/inspirehep/inspire/issues/170 on Legacy\r\n- [ ] Conferences\r\n    - [ ] Test `acronym`\r\n    - [ ] Test `keywords`\r\n    - [ ] Test `nonpublic_note`\r\n    - [ ] Test `note`\r\n    - [ ] Test `series`\r\n    - [ ] Test `short_description`\r\n    - [ ] ~~Test `extra_place_info`~~ (should be merged with `contact_details`)\r\n- [ ] Experiments\r\n    - [ ] Test `experiment_names`\r\n    - [ ] Test `titles`\r\n    - [ ] Test `title_variants`\r\n    - [ ] Test `contact_details`\r\n    - [ ] Test `name_variants`\r\n    - [ ] Test `description`\r\n    - [ ] Test `spokeperson`\r\n    - [ ] Test `collaboration`\r\n    - [ ] Test `related_experiments`\r\n    - [ ] Test `date_started`\r\n    - [ ] Test `accelerator`\r\n- [ ] Jobs\r\n    - [ ] Test `date_closed`\r\n    - [ ] Test `contact_details`\r\n    - [ ] Test `continent`\r\n    - [ ] Test `experiments`\r\n    - [ ] Test `institution`\r\n    - [ ] Test `description`\r\n    - [ ] Test `position`\r\n    - [ ] Test `ranks`\r\n    - [x] ~~Test `experiment`~~ (obsolete rule)\r\n- [x] Journals\r\n    - [x] Test `issn`\r\n    - [x] Test `coden`\r\n    - [x] Test `publisher`\r\n    - [x] Test `titles`\r\n    - [x] Test `short_titles`\r\n    - [x] Test `title_variants`\r\n    - [x] ~~Test `name_variants`~~ (obsolete rule)\r\n- [ ] Cleanup\r\n    - [ ] Remove obsolete rules\r\n    - [x] Remove unused `inspirehep/dojson/processors.py`"},"comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments/227255674","html_url":"https://github.com/inspirehep/inspire-next/pull/1200#issuecomment-227255674","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/1200","id":227255674,"user":{"login":"jacquerie","id":381280,"avatar_url":"https://avatars.githubusercontent.com/u/381280?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquerie","html_url":"https://github.com/jacquerie","followers_url":"https://api.github.com/users/jacquerie/followers","following_url":"https://api.github.com/users/jacquerie/following{/other_user}","gists_url":"https://api.github.com/users/jacquerie/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquerie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquerie/subscriptions","organizations_url":"https://api.github.com/users/jacquerie/orgs","repos_url":"https://api.github.com/users/jacquerie/repos","events_url":"https://api.github.com/users/jacquerie/events{/privacy}","received_events_url":"https://api.github.com/users/jacquerie/received_events","type":"User","site_admin":false},"created_at":"2016-06-20T20:14:02Z","updated_at":"2016-06-20T20:14:02Z","body":"This is becoming way too complicated for a single PR, and might get split in 5 (one per collection) + 1 for cleaning up."}}
{"actor":{"display_login":"jacquerie"}}