{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/65690450","id":65690450,"diff_hunk":"@@ -0,0 +1,78 @@\n+// Copyright 2016 The rkt Authors\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+// +build hv_lkvm\n+\n+package hypervisor\n+\n+import (\n+\t\"fmt\"\n+\t\"path/filepath\"\n+\t\"strconv\"\n+\n+\t\"github.com/coreos/rkt/stage1/init/kvm\"\n+\t\"strings\"\n+)\n+\n+var (\n+\tdriverConfiguration = KvmHypervisor{\n+\t\tBin: \"./lkvm\",\n+\t\tKernelParams: []string{\n+\t\t\t\"systemd.default_standard_error=journal+console\",\n+\t\t\t\"systemd.default_standard_output=journal+console\",\n+\t\t},\n+\t}\n+)\n+\n+func StartCmd(wdPath, name, kernelPath string, nds []kvm.NetDescriber, cpu, mem int64, debug bool) ([]string, error) {","path":"stage1/init/kvm/hypervisor/lkvm_driver.go","position":38,"original_position":38,"commit_id":"4c52578751418df6e9aa90a875e0b097355c029c","original_commit_id":"4c52578751418df6e9aa90a875e0b097355c029c","user":{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},"body":"maybe group in separate lines for better readability (if that's what the newline has been for)","created_at":"2016-06-03T10:58:23Z","updated_at":"2016-06-03T10:58:23Z","html_url":"https://github.com/coreos/rkt/pull/2684#discussion_r65690450","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2684","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/65690450"},"html":{"href":"https://github.com/coreos/rkt/pull/2684#discussion_r65690450"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2684","id":71243753,"html_url":"https://github.com/coreos/rkt/pull/2684","diff_url":"https://github.com/coreos/rkt/pull/2684.diff","patch_url":"https://github.com/coreos/rkt/pull/2684.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2684","number":2684,"state":"open","locked":false,"title":"KVM: Hypervisor support for KVM flavor","user":{"login":"jjlakis","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/jjlakis","html_url":"https://github.com/jjlakis","followers_url":"https://api.github.com/users/jjlakis/followers","following_url":"https://api.github.com/users/jjlakis/following{/other_user}","gists_url":"https://api.github.com/users/jjlakis/gists{/gist_id}","starred_url":"https://api.github.com/users/jjlakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjlakis/subscriptions","organizations_url":"https://api.github.com/users/jjlakis/orgs","repos_url":"https://api.github.com/users/jjlakis/repos","events_url":"https://api.github.com/users/jjlakis/events{/privacy}","received_events_url":"https://api.github.com/users/jjlakis/received_events","type":"User","site_admin":false},"body":"Here's the first PR in our plan to put some focus on qemu as a KVM hypervisor. Whole code is based on Michał Stachowski's (@mstachowski) work in https://github.com/coreos/rkt/pull/2592 ,and it's taken by me, due to the other activities inside our company that Michał must handle. We're also closing #2592.\r\nThis code provides a generic mechanism to use different kvm hypervisors (such as lkvm, qemu-kvm), to set it by passing proper option to ./configure (New configure option --with-stage1-kvm-hypervisor). This PR covers only implementation of KvmHypervisor type and a small refactor of kvm's part of init.go to match the new KvmHypervisor interface (lkvm is the only option that could be passed to --with-stage1-kvm-hypervisor and it's also default)\r\nI fixed most of the review suggestions from #2592 ","created_at":"2016-05-24T15:40:57Z","updated_at":"2016-06-03T10:58:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d144f08e32d96f02a8ebe9161144beafe69622c7","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/41","html_url":"https://github.com/coreos/rkt/milestones/v1.9.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/41/labels","id":1782386,"number":41,"title":"v1.9.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":0,"state":"open","created_at":"2016-05-23T10:26:08Z","updated_at":"2016-06-01T10:04:41Z","due_on":"2016-06-22T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2684/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2684/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2684/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/4c52578751418df6e9aa90a875e0b097355c029c","head":{"label":"intelsdi-x:jlakis-hypervisor","ref":"jlakis-hypervisor","sha":"4c52578751418df6e9aa90a875e0b097355c029c","user":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"repo":{"id":38779722,"name":"rkt","full_name":"intelsdi-x/rkt","owner":{"login":"intelsdi-x","id":8398747,"avatar_url":"https://avatars.githubusercontent.com/u/8398747?v=3","gravatar_id":"","url":"https://api.github.com/users/intelsdi-x","html_url":"https://github.com/intelsdi-x","followers_url":"https://api.github.com/users/intelsdi-x/followers","following_url":"https://api.github.com/users/intelsdi-x/following{/other_user}","gists_url":"https://api.github.com/users/intelsdi-x/gists{/gist_id}","starred_url":"https://api.github.com/users/intelsdi-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intelsdi-x/subscriptions","organizations_url":"https://api.github.com/users/intelsdi-x/orgs","repos_url":"https://api.github.com/users/intelsdi-x/repos","events_url":"https://api.github.com/users/intelsdi-x/events{/privacy}","received_events_url":"https://api.github.com/users/intelsdi-x/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intelsdi-x/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/intelsdi-x/rkt","forks_url":"https://api.github.com/repos/intelsdi-x/rkt/forks","keys_url":"https://api.github.com/repos/intelsdi-x/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intelsdi-x/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intelsdi-x/rkt/teams","hooks_url":"https://api.github.com/repos/intelsdi-x/rkt/hooks","issue_events_url":"https://api.github.com/repos/intelsdi-x/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/intelsdi-x/rkt/events","assignees_url":"https://api.github.com/repos/intelsdi-x/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/intelsdi-x/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/intelsdi-x/rkt/tags","blobs_url":"https://api.github.com/repos/intelsdi-x/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intelsdi-x/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intelsdi-x/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/intelsdi-x/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intelsdi-x/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/intelsdi-x/rkt/languages","stargazers_url":"https://api.github.com/repos/intelsdi-x/rkt/stargazers","contributors_url":"https://api.github.com/repos/intelsdi-x/rkt/contributors","subscribers_url":"https://api.github.com/repos/intelsdi-x/rkt/subscribers","subscription_url":"https://api.github.com/repos/intelsdi-x/rkt/subscription","commits_url":"https://api.github.com/repos/intelsdi-x/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/intelsdi-x/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/intelsdi-x/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/intelsdi-x/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/intelsdi-x/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/intelsdi-x/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intelsdi-x/rkt/merges","archive_url":"https://api.github.com/repos/intelsdi-x/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intelsdi-x/rkt/downloads","issues_url":"https://api.github.com/repos/intelsdi-x/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/intelsdi-x/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/intelsdi-x/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/intelsdi-x/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intelsdi-x/rkt/labels{/name}","releases_url":"https://api.github.com/repos/intelsdi-x/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/intelsdi-x/rkt/deployments","created_at":"2015-07-08T21:00:32Z","updated_at":"2016-02-13T13:35:14Z","pushed_at":"2016-06-02T08:44:00Z","git_url":"git://github.com/intelsdi-x/rkt.git","ssh_url":"git@github.com:intelsdi-x/rkt.git","clone_url":"https://github.com/intelsdi-x/rkt.git","svn_url":"https://github.com/intelsdi-x/rkt","homepage":"","size":21481,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"d35d18680db176df5f1b2e70f706a1ea2add7381","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-06-03T04:11:15Z","pushed_at":"2016-06-03T08:15:04Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":25477,"stargazers_count":5557,"watchers_count":5557,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":322,"forks":518,"open_issues":322,"watchers":5557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684"},"html":{"href":"https://github.com/coreos/rkt/pull/2684"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2684"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2684/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2684/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/4c52578751418df6e9aa90a875e0b097355c029c"}}}}
{"actor":{"display_login":"s-urbaniak"}}