{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/81255061","pull_request_review_id":2249276,"id":81255061,"diff_hunk":"@@ -2376,7 +2376,9 @@ static void add_assoc_image_info(zval *value, int sub_array, image_info_type *im\n \t\t\t\t\t\tif (section_index==SECTION_COMMENT) {\n \t\t\t\t\t\t\tadd_index_string(&tmpi, idx++, val);\n \t\t\t\t\t\t} else {\n-\t\t\t\t\t\t\tadd_assoc_string(&tmpi, name, val);\n+\t\t\t\t\t\t\tzval zv;\n+\t\t\t\t\t\t\tZVAL_STRING(&zv, val);\n+\t\t\t\t\t\t\tzend_hash_str_update_exception(Z_ARRVAL(tmpi), name, strlen(name), &zv);","path":"ext/exif/exif.c","position":7,"original_position":7,"commit_id":"6e1a29aaf7f7254abe8b9504e0e74d3bace48beb","original_commit_id":"5042212ef50143803262bbeff1a2b3e91867ce5d","user":{"login":"nikic","id":216080,"avatar_url":"https://avatars.githubusercontent.com/u/216080?v=3","gravatar_id":"","url":"https://api.github.com/users/nikic","html_url":"https://github.com/nikic","followers_url":"https://api.github.com/users/nikic/followers","following_url":"https://api.github.com/users/nikic/following{/other_user}","gists_url":"https://api.github.com/users/nikic/gists{/gist_id}","starred_url":"https://api.github.com/users/nikic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikic/subscriptions","organizations_url":"https://api.github.com/users/nikic/orgs","repos_url":"https://api.github.com/users/nikic/repos","events_url":"https://api.github.com/users/nikic/events{/privacy}","received_events_url":"https://api.github.com/users/nikic/received_events","type":"User","site_admin":false},"body":"To clarify, are you saying that this is the only branch that takes user-input? Not being familiar with exif, they all look the same to me.","created_at":"2016-09-29T23:23:13Z","updated_at":"2016-09-29T23:23:13Z","html_url":"https://github.com/php/php-src/pull/1706#discussion_r81255061","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/1706","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/81255061"},"html":{"href":"https://github.com/php/php-src/pull/1706#discussion_r81255061"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/1706"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1706","id":54833707,"html_url":"https://github.com/php/php-src/pull/1706","diff_url":"https://github.com/php/php-src/pull/1706.diff","patch_url":"https://github.com/php/php-src/pull/1706.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/1706","number":1706,"state":"open","locked":false,"title":"Collision counting against HashDos attacks","user":{"login":"bwoebi","id":3154871,"avatar_url":"https://avatars.githubusercontent.com/u/3154871?v=3","gravatar_id":"","url":"https://api.github.com/users/bwoebi","html_url":"https://github.com/bwoebi","followers_url":"https://api.github.com/users/bwoebi/followers","following_url":"https://api.github.com/users/bwoebi/following{/other_user}","gists_url":"https://api.github.com/users/bwoebi/gists{/gist_id}","starred_url":"https://api.github.com/users/bwoebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwoebi/subscriptions","organizations_url":"https://api.github.com/users/bwoebi/orgs","repos_url":"https://api.github.com/users/bwoebi/repos","events_url":"https://api.github.com/users/bwoebi/events{/privacy}","received_events_url":"https://api.github.com/users/bwoebi/received_events","type":"User","site_admin":false},"body":"This PR supersedes #1565.\r\n\r\nIt adds graceful handling with exceptions on necessary places:\r\narray_combine, array_column, array_flip, array_merge(_recursive) and the trivial array modification (`$a[\"key\"] = $val;`)\r\nand general graceful handling for:\r\nparse_str and json_decode","created_at":"2015-12-30T22:11:17Z","updated_at":"2016-09-29T23:23:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d1344b9c7768dd2942a72fa9022526b29b5e7f1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/1706/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/1706/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/1706/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/6e1a29aaf7f7254abe8b9504e0e74d3bace48beb","head":{"label":"bwoebi:collisionCount","ref":"collisionCount","sha":"6e1a29aaf7f7254abe8b9504e0e74d3bace48beb","user":{"login":"bwoebi","id":3154871,"avatar_url":"https://avatars.githubusercontent.com/u/3154871?v=3","gravatar_id":"","url":"https://api.github.com/users/bwoebi","html_url":"https://github.com/bwoebi","followers_url":"https://api.github.com/users/bwoebi/followers","following_url":"https://api.github.com/users/bwoebi/following{/other_user}","gists_url":"https://api.github.com/users/bwoebi/gists{/gist_id}","starred_url":"https://api.github.com/users/bwoebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwoebi/subscriptions","organizations_url":"https://api.github.com/users/bwoebi/orgs","repos_url":"https://api.github.com/users/bwoebi/repos","events_url":"https://api.github.com/users/bwoebi/events{/privacy}","received_events_url":"https://api.github.com/users/bwoebi/received_events","type":"User","site_admin":false},"repo":{"id":8383424,"name":"php-src","full_name":"bwoebi/php-src","owner":{"login":"bwoebi","id":3154871,"avatar_url":"https://avatars.githubusercontent.com/u/3154871?v=3","gravatar_id":"","url":"https://api.github.com/users/bwoebi","html_url":"https://github.com/bwoebi","followers_url":"https://api.github.com/users/bwoebi/followers","following_url":"https://api.github.com/users/bwoebi/following{/other_user}","gists_url":"https://api.github.com/users/bwoebi/gists{/gist_id}","starred_url":"https://api.github.com/users/bwoebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwoebi/subscriptions","organizations_url":"https://api.github.com/users/bwoebi/orgs","repos_url":"https://api.github.com/users/bwoebi/repos","events_url":"https://api.github.com/users/bwoebi/events{/privacy}","received_events_url":"https://api.github.com/users/bwoebi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwoebi/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/bwoebi/php-src","forks_url":"https://api.github.com/repos/bwoebi/php-src/forks","keys_url":"https://api.github.com/repos/bwoebi/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwoebi/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwoebi/php-src/teams","hooks_url":"https://api.github.com/repos/bwoebi/php-src/hooks","issue_events_url":"https://api.github.com/repos/bwoebi/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/bwoebi/php-src/events","assignees_url":"https://api.github.com/repos/bwoebi/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/bwoebi/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/bwoebi/php-src/tags","blobs_url":"https://api.github.com/repos/bwoebi/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwoebi/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwoebi/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwoebi/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwoebi/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/bwoebi/php-src/languages","stargazers_url":"https://api.github.com/repos/bwoebi/php-src/stargazers","contributors_url":"https://api.github.com/repos/bwoebi/php-src/contributors","subscribers_url":"https://api.github.com/repos/bwoebi/php-src/subscribers","subscription_url":"https://api.github.com/repos/bwoebi/php-src/subscription","commits_url":"https://api.github.com/repos/bwoebi/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwoebi/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwoebi/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwoebi/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwoebi/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/bwoebi/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwoebi/php-src/merges","archive_url":"https://api.github.com/repos/bwoebi/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwoebi/php-src/downloads","issues_url":"https://api.github.com/repos/bwoebi/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/bwoebi/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/bwoebi/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/bwoebi/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwoebi/php-src/labels{/name}","releases_url":"https://api.github.com/repos/bwoebi/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/bwoebi/php-src/deployments","created_at":"2013-02-23T23:09:56Z","updated_at":"2015-01-24T18:08:15Z","pushed_at":"2016-09-29T23:18:39Z","git_url":"git://github.com/bwoebi/php-src.git","ssh_url":"git@github.com:bwoebi/php-src.git","clone_url":"https://github.com/bwoebi/php-src.git","svn_url":"https://github.com/bwoebi/php-src","homepage":"http://www.php.net","size":260702,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"9f128ef5f4e294d76850b969c1f44551207307b9","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2016-09-29T22:27:11Z","pushed_at":"2016-09-29T23:18:40Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":428235,"stargazers_count":10073,"watchers_count":10073,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3525,"mirror_url":null,"open_issues_count":315,"forks":3525,"open_issues":315,"watchers":10073,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/1706"},"html":{"href":"https://github.com/php/php-src/pull/1706"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/1706"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/1706/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/1706/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/1706/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/6e1a29aaf7f7254abe8b9504e0e74d3bace48beb"}}}}
{"actor":{"display_login":"nikic"}}