{"action":"created","issue":{"url":"https://api.github.com/repos/afollestad/material-camera/issues/130","repository_url":"https://api.github.com/repos/afollestad/material-camera","labels_url":"https://api.github.com/repos/afollestad/material-camera/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/afollestad/material-camera/issues/130/comments","events_url":"https://api.github.com/repos/afollestad/material-camera/issues/130/events","html_url":"https://github.com/afollestad/material-camera/pull/130","id":183585576,"number":130,"title":"Various Bug Fixes","user":{"login":"sugarmanz","id":9255651,"avatar_url":"https://avatars.githubusercontent.com/u/9255651?v=3","gravatar_id":"","url":"https://api.github.com/users/sugarmanz","html_url":"https://github.com/sugarmanz","followers_url":"https://api.github.com/users/sugarmanz/followers","following_url":"https://api.github.com/users/sugarmanz/following{/other_user}","gists_url":"https://api.github.com/users/sugarmanz/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarmanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarmanz/subscriptions","organizations_url":"https://api.github.com/users/sugarmanz/orgs","repos_url":"https://api.github.com/users/sugarmanz/repos","events_url":"https://api.github.com/users/sugarmanz/events{/privacy}","received_events_url":"https://api.github.com/users/sugarmanz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-10-18T04:06:02Z","updated_at":"2016-10-18T15:29:37Z","closed_at":"2016-10-18T15:23:58Z","pull_request":{"url":"https://api.github.com/repos/afollestad/material-camera/pulls/130","html_url":"https://github.com/afollestad/material-camera/pull/130","diff_url":"https://github.com/afollestad/material-camera/pull/130.diff","patch_url":"https://github.com/afollestad/material-camera/pull/130.patch"},"body":"## Changelog\r\n\r\nWe've submitted a number of bug fixes that resolve all of the issues we were seeing with the stillshot branch. @tylerkrupicka and I tested these changes on a range of devices, and this patch should iron out some of the issues with icons, memory, and autosubmit.\r\n\r\n#### Camera Facing Button Fix\r\n\r\nThe issue of the camera \"facing\" button not being drawn on retry was due to missing logic in the `openCamera()` function which caused the image resource to only be loaded when the camera \"facing\" mode was unknown (or toggled).\r\n\r\n#### Fix autoSubmit() and allowRetry() on Stillshot\r\n\r\nPreviously, the auto submit function would have no effect when launching for stillshot. This functionality has been fixed to follow the same behavior as video.\r\n\r\n#### Fix Out of Memory Errors\r\n\r\nWe were able to dramatically reduce the amount of memory used when displaying bitmaps by fixing the sample size calculation. This fix has since been added to master, however we've included some images from testing on the 6p.\r\n\r\n![Before](http://i.imgur.com/TrwrUFE.png)\r\n![After](http://i.imgur.com/dpGR0wt.png)\r\n\r\nAdditionally, we've added a patch to the sample size calculation that correctly adjusts the width and height when the image is rotated. Without this fix, our Samsung devices would use the incorrect width and height in the calculation and still use way too much memory.\r\n\r\n#### Fix Flash Toggle Bug\r\n\r\nWe've fixed a bug that would cause the flash state to toggle when using the back button. We've also fixed a related bug which cause the flash icon to not match the selected mode for Camera 1 devices.\r\n\r\n#### Test Galaxy S4\r\n\r\nWe were able to get our hands on a Galaxy S4 and were unable to reproduce any bugs with the preview size. We were able to verify the memory fix. \r\n\r\n### Testing\r\n\r\n| Device              | Manufacturer | OS  | Video | Stillshot | Flash | Front & Back |\r\n| ------------------- |:------------:|:---:|:-----:|:---------:|:-----:|:------------:|\r\n| Nexus 6p            | Huewei       |6.0.1|   ✓  |      ✓    |   ✓   |       ✓     |\r\n| Nexus 5             | LG           |6.0.1|   ✓  |      ✓    |   ✓   |       ✓     |\r\n| Nexus 6             | Motorolla    |6.0.1|   ✓  |      ✓    |   ✓   |       ✓     |\r\n| Droid Razr Maxx     | Motorolla    |4.4.2|   _X_* |      ✓    |   ✓   |       ✓     |\r\n| Galaxy S6           | Samsung      |6.0.1|   ✓  |      ✓    |   ✓   |       ✓     |\r\n| Galaxy S5           | Samsung      |6.0.1|   ✓  |      ✓    |   ✓   |       ✓     |\r\n| Galaxy S4           | Samsung      |5.0.1|   ✓  |      ✓    |   ✓   |       ✓     |\r\n| Galaxy S3 (SCH-I525)| Samsung      |4.4.2|   _X_* |      ✓    |   ✓   |       ✓     |\r\n\r\n*These are existing issues in the main repo (`invalid drawable tag vector` while creating the `PlaybackVideoFragment`)\r\n\r\n### Going Forward\r\n\r\nWe have plans to add torch flash mode to video and try to fix the upside down preview bug when time permits. We hope @afollestad can take a look and verify these changes before merging them in. Hope this helps!\r\n"},"comment":{"url":"https://api.github.com/repos/afollestad/material-camera/issues/comments/254544684","html_url":"https://github.com/afollestad/material-camera/pull/130#issuecomment-254544684","issue_url":"https://api.github.com/repos/afollestad/material-camera/issues/130","id":254544684,"user":{"login":"sugarmanz","id":9255651,"avatar_url":"https://avatars.githubusercontent.com/u/9255651?v=3","gravatar_id":"","url":"https://api.github.com/users/sugarmanz","html_url":"https://github.com/sugarmanz","followers_url":"https://api.github.com/users/sugarmanz/followers","following_url":"https://api.github.com/users/sugarmanz/following{/other_user}","gists_url":"https://api.github.com/users/sugarmanz/gists{/gist_id}","starred_url":"https://api.github.com/users/sugarmanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sugarmanz/subscriptions","organizations_url":"https://api.github.com/users/sugarmanz/orgs","repos_url":"https://api.github.com/users/sugarmanz/repos","events_url":"https://api.github.com/users/sugarmanz/events{/privacy}","received_events_url":"https://api.github.com/users/sugarmanz/received_events","type":"User","site_admin":false},"created_at":"2016-10-18T15:29:37Z","updated_at":"2016-10-18T15:29:37Z","body":"We didn't address that explicitly, but as far as I can tell it doesn't happen on my S6. I'll test on the Nexus 5 we have when I get a chance."}}
{"actor":{"display_login":"sugarmanz"}}