{"push_id":1465545987,"size":3,"distinct_size":3,"ref":"refs/heads/nimble/find_by_type_fix","head":"9d6bf94c5b8cff88cfc062ad187ea230d6b775b1","before":"419df3a12d8e4e96a8ae99ae9ccc43aa9bf1ae52","commits":[{"sha":"1f2b6bb2661d95421a00c4c01d75866bde7ba8f1","author":{"name":"Andrzej Kaczmarek","email":"e131340d9fc2c4f7e184f30be377ee5b9de63086@codecoup.pl"},"message":"nimble/test: Fix ble_att_svr_test_find_type_value test cases\n\nTest cases for \"Find By Type Value\" are incorrect since they are based\non an assumption that attribute group is a sequence of consecutive\nattributes with the same type and value.\n\nThis fixes the test cases to check for proper grouping as defined by\nBluetooth Specification 4.2, Vol 3, Part G, Section 2.5.3.\n\nSince the actual ATT implementation is based on the same incorrect\nassumtpion, the test cases will now fail until ATT is fixed as well.","distinct":true,"url":"https://api.github.com/repos/andrzej-kaczmarek/incubator-mynewt-core/commits/1f2b6bb2661d95421a00c4c01d75866bde7ba8f1"},{"sha":"0b81089fc7554cea59aa503905a193c008de70da","author":{"name":"Andrzej Kaczmarek","email":"e131340d9fc2c4f7e184f30be377ee5b9de63086@codecoup.pl"},"message":"nimble/att: Rename ble_att_svr_is_valid_group_type\n\nThe ble_att_svr_is_valid_read_group_type() checks if given type is\nvalid for Read By Group Type Request only, not if it is valid group\ntype in general. Rename this function so it is more clear what it\ndoes.","distinct":true,"url":"https://api.github.com/repos/andrzej-kaczmarek/incubator-mynewt-core/commits/0b81089fc7554cea59aa503905a193c008de70da"},{"sha":"9d6bf94c5b8cff88cfc062ad187ea230d6b775b1","author":{"name":"Andrzej Kaczmarek","email":"e131340d9fc2c4f7e184f30be377ee5b9de63086@codecoup.pl"},"message":"nimble/att: Refactor Find By Type Value handling\n\nCurrent implementation of \"Find By Type Value\" handler is broken as it\nassumes that group is a sequence of consecutive attributes with the\nsame type and value. This is incorrect and it breaks \"Discover Primary\nServices By Service UUID\" GATT procedure effectively making impossible\nto search for service by UUID on local GATT server.\n\nThis fixes the problem by refactoring ble_att_svr_fill_type_value() to\nuse proper grouping as defined by Bluetooth Specification, Vol 3, Part\nG, Section 2.5.3.","distinct":true,"url":"https://api.github.com/repos/andrzej-kaczmarek/incubator-mynewt-core/commits/9d6bf94c5b8cff88cfc062ad187ea230d6b775b1"}]}
{"actor":{"display_login":"andrzej-kaczmarek"}}