{"action":"created","issue":{"url":"https://api.github.com/repos/deis/workflow-cli/issues/110","repository_url":"https://api.github.com/repos/deis/workflow-cli","labels_url":"https://api.github.com/repos/deis/workflow-cli/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/deis/workflow-cli/issues/110/comments","events_url":"https://api.github.com/repos/deis/workflow-cli/issues/110/events","html_url":"https://github.com/deis/workflow-cli/pull/110","id":163483511,"number":110,"title":"bug(cmd): add more advanced handling of app urls","user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/deis/workflow-cli/labels/awaiting%20review","name":"awaiting review","color":"e11d21"},{"url":"https://api.github.com/repos/deis/workflow-cli/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"assignees":[{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/deis/workflow-cli/milestones/10","html_url":"https://github.com/deis/workflow-cli/milestones/v2.2","labels_url":"https://api.github.com/repos/deis/workflow-cli/milestones/10/labels","id":1853725,"number":10,"title":"v2.2","description":null,"creator":{"login":"deis-admin","id":12703824,"avatar_url":"https://avatars.githubusercontent.com/u/12703824?v=3","gravatar_id":"","url":"https://api.github.com/users/deis-admin","html_url":"https://github.com/deis-admin","followers_url":"https://api.github.com/users/deis-admin/followers","following_url":"https://api.github.com/users/deis-admin/following{/other_user}","gists_url":"https://api.github.com/users/deis-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/deis-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deis-admin/subscriptions","organizations_url":"https://api.github.com/users/deis-admin/orgs","repos_url":"https://api.github.com/users/deis-admin/repos","events_url":"https://api.github.com/users/deis-admin/events{/privacy}","received_events_url":"https://api.github.com/users/deis-admin/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":15,"state":"open","created_at":"2016-06-28T20:56:36Z","updated_at":"2016-07-15T20:01:38Z","due_on":"2016-07-20T06:00:00Z","closed_at":null},"comments":3,"created_at":"2016-07-01T22:21:25Z","updated_at":"2016-07-18T17:31:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/deis/workflow-cli/pulls/110","html_url":"https://github.com/deis/workflow-cli/pull/110","diff_url":"https://github.com/deis/workflow-cli/pull/110.diff","patch_url":"https://github.com/deis/workflow-cli/pull/110.patch"},"body":"Previously, we took a very naive approach to determining the app url. We did appID**~~deis~~**.cluster.com\r\n\r\nThis approach has a problem however, because you can assign subdomains to an app that mask another app:\r\n\r\n```console\r\n$ deis domains:add a -a t\r\n$ deis apps:create a --no-remote\r\n$ deis apps:open -a a # opens a.cluster.com, which actually points to t\r\n```\r\n\r\nNow, `apps:open` and `apps:info` use the app's first domain, usually the one that is assigned by default. If the app doesn't have any domains, like `a` in the example does, it'll print that the app doesn't have any domains.\r\n\r\nThis also allows me to remove `api.Apps.URL` from the SDK laster, removing the naive behavior in a way that doesn't break anything."},"comment":{"url":"https://api.github.com/repos/deis/workflow-cli/issues/comments/233399197","html_url":"https://github.com/deis/workflow-cli/pull/110#issuecomment-233399197","issue_url":"https://api.github.com/repos/deis/workflow-cli/issues/110","id":233399197,"user":{"login":"Joshua-Anderson","id":3526404,"avatar_url":"https://avatars.githubusercontent.com/u/3526404?v=3","gravatar_id":"","url":"https://api.github.com/users/Joshua-Anderson","html_url":"https://github.com/Joshua-Anderson","followers_url":"https://api.github.com/users/Joshua-Anderson/followers","following_url":"https://api.github.com/users/Joshua-Anderson/following{/other_user}","gists_url":"https://api.github.com/users/Joshua-Anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/Joshua-Anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joshua-Anderson/subscriptions","organizations_url":"https://api.github.com/users/Joshua-Anderson/orgs","repos_url":"https://api.github.com/users/Joshua-Anderson/repos","events_url":"https://api.github.com/users/Joshua-Anderson/events{/privacy}","received_events_url":"https://api.github.com/users/Joshua-Anderson/received_events","type":"User","site_admin":false},"created_at":"2016-07-18T17:31:14Z","updated_at":"2016-07-18T17:31:14Z","body":"@bacongobbler This doesn't affect the behavior of `-a` at all... this behavior is for looking up the URL for an app when using `app:open` and `app:info`. There were a few edge cases where what the previously the *assumed* app url could actually point to another app. Now, `apps:open` and `apps:info` look up the app domain from the controller rather than try to guess it.\r\n\r\n"}}
{"actor":{"display_login":"Joshua-Anderson"}}