{"action":"created","comment":{"url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/comments/89851493","pull_request_review_id":10383460,"id":89851493,"diff_hunk":"@@ -53,6 +53,10 @@ def web_uri(path=None):\n     return None\n \n \n+# Prefixes of repositories that can be edited via the web editor UI\n+# Defaults to no prefixes allowed. If None, all prefixes editable via the UI.\n+web_editor_prefixes = []","path":"knowledge_repo/config_defaults.py","position":6,"original_position":6,"commit_id":"b209d72179cede7a15ea5694493565b9de975184","original_commit_id":"b209d72179cede7a15ea5694493565b9de975184","user":{"login":"matthewwardrop","id":124910,"avatar_url":"https://avatars.githubusercontent.com/u/124910?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewwardrop","html_url":"https://github.com/matthewwardrop","followers_url":"https://api.github.com/users/matthewwardrop/followers","following_url":"https://api.github.com/users/matthewwardrop/following{/other_user}","gists_url":"https://api.github.com/users/matthewwardrop/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewwardrop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewwardrop/subscriptions","organizations_url":"https://api.github.com/users/matthewwardrop/orgs","repos_url":"https://api.github.com/users/matthewwardrop/repos","events_url":"https://api.github.com/users/matthewwardrop/events{/privacy}","received_events_url":"https://api.github.com/users/matthewwardrop/received_events","type":"User","site_admin":false},"body":"Shouldn't this key be specified in the server configuration, not the repository configuration? If not, then we need to propagate this configuration into methods on the `KnowledgeRepository` class and delegate in the `MetaKnowledgeRepository` class.","created_at":"2016-11-28T18:50:45Z","updated_at":"2016-11-28T18:51:00Z","html_url":"https://github.com/airbnb/knowledge-repo/pull/140#discussion_r89851493","pull_request_url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140","_links":{"self":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/comments/89851493"},"html":{"href":"https://github.com/airbnb/knowledge-repo/pull/140#discussion_r89851493"},"pull_request":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140","id":93254360,"html_url":"https://github.com/airbnb/knowledge-repo/pull/140","diff_url":"https://github.com/airbnb/knowledge-repo/pull/140.diff","patch_url":"https://github.com/airbnb/knowledge-repo/pull/140.patch","issue_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues/140","number":140,"state":"open","locked":false,"title":"a quick fix for handling of prefixes that are web-editable","user":{"login":"danfrankj","id":616139,"avatar_url":"https://avatars.githubusercontent.com/u/616139?v=3","gravatar_id":"","url":"https://api.github.com/users/danfrankj","html_url":"https://github.com/danfrankj","followers_url":"https://api.github.com/users/danfrankj/followers","following_url":"https://api.github.com/users/danfrankj/following{/other_user}","gists_url":"https://api.github.com/users/danfrankj/gists{/gist_id}","starred_url":"https://api.github.com/users/danfrankj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfrankj/subscriptions","organizations_url":"https://api.github.com/users/danfrankj/orgs","repos_url":"https://api.github.com/users/danfrankj/repos","events_url":"https://api.github.com/users/danfrankj/events{/privacy}","received_events_url":"https://api.github.com/users/danfrankj/received_events","type":"User","site_admin":false},"body":"WIP\r\n\r\nDo we only want to allow webeditor if the WEB_EDITOR_PREFIXES has a list of prefixes? \r\n\r\n@NiharikaRay @matthewwardrop @earthmancash \r\n","created_at":"2016-11-10T23:46:45Z","updated_at":"2016-11-28T18:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4239fbc0c581d4318fb30dcc66d5bfd898789f07","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140/commits","review_comments_url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140/comments","review_comment_url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues/140/comments","statuses_url":"https://api.github.com/repos/airbnb/knowledge-repo/statuses/b209d72179cede7a15ea5694493565b9de975184","head":{"label":"airbnb:df_quickfix_webeditor_prefix","ref":"df_quickfix_webeditor_prefix","sha":"b209d72179cede7a15ea5694493565b9de975184","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":65949398,"name":"knowledge-repo","full_name":"airbnb/knowledge-repo","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/knowledge-repo","description":"A next-generation curated knowledge sharing platform for data scientists and other technical professions.","fork":false,"url":"https://api.github.com/repos/airbnb/knowledge-repo","forks_url":"https://api.github.com/repos/airbnb/knowledge-repo/forks","keys_url":"https://api.github.com/repos/airbnb/knowledge-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/knowledge-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/knowledge-repo/teams","hooks_url":"https://api.github.com/repos/airbnb/knowledge-repo/hooks","issue_events_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/knowledge-repo/events","assignees_url":"https://api.github.com/repos/airbnb/knowledge-repo/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/knowledge-repo/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/knowledge-repo/tags","blobs_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/knowledge-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/knowledge-repo/languages","stargazers_url":"https://api.github.com/repos/airbnb/knowledge-repo/stargazers","contributors_url":"https://api.github.com/repos/airbnb/knowledge-repo/contributors","subscribers_url":"https://api.github.com/repos/airbnb/knowledge-repo/subscribers","subscription_url":"https://api.github.com/repos/airbnb/knowledge-repo/subscription","commits_url":"https://api.github.com/repos/airbnb/knowledge-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/knowledge-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/knowledge-repo/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/knowledge-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/knowledge-repo/merges","archive_url":"https://api.github.com/repos/airbnb/knowledge-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/knowledge-repo/downloads","issues_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/knowledge-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/knowledge-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/knowledge-repo/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/knowledge-repo/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/knowledge-repo/deployments","created_at":"2016-08-17T23:32:50Z","updated_at":"2016-11-28T18:20:10Z","pushed_at":"2016-11-28T18:47:37Z","git_url":"git://github.com/airbnb/knowledge-repo.git","ssh_url":"git@github.com:airbnb/knowledge-repo.git","clone_url":"https://github.com/airbnb/knowledge-repo.git","svn_url":"https://github.com/airbnb/knowledge-repo","homepage":"","size":866,"stargazers_count":1414,"watchers_count":1414,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":36,"forks":104,"open_issues":36,"watchers":1414,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"f1ac68b956e70a40f1fbfefc956b895882305ee2","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":65949398,"name":"knowledge-repo","full_name":"airbnb/knowledge-repo","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars.githubusercontent.com/u/698437?v=3","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/knowledge-repo","description":"A next-generation curated knowledge sharing platform for data scientists and other technical professions.","fork":false,"url":"https://api.github.com/repos/airbnb/knowledge-repo","forks_url":"https://api.github.com/repos/airbnb/knowledge-repo/forks","keys_url":"https://api.github.com/repos/airbnb/knowledge-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/knowledge-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/knowledge-repo/teams","hooks_url":"https://api.github.com/repos/airbnb/knowledge-repo/hooks","issue_events_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/knowledge-repo/events","assignees_url":"https://api.github.com/repos/airbnb/knowledge-repo/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/knowledge-repo/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/knowledge-repo/tags","blobs_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/knowledge-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/knowledge-repo/languages","stargazers_url":"https://api.github.com/repos/airbnb/knowledge-repo/stargazers","contributors_url":"https://api.github.com/repos/airbnb/knowledge-repo/contributors","subscribers_url":"https://api.github.com/repos/airbnb/knowledge-repo/subscribers","subscription_url":"https://api.github.com/repos/airbnb/knowledge-repo/subscription","commits_url":"https://api.github.com/repos/airbnb/knowledge-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/knowledge-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/knowledge-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/knowledge-repo/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/knowledge-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/knowledge-repo/merges","archive_url":"https://api.github.com/repos/airbnb/knowledge-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/knowledge-repo/downloads","issues_url":"https://api.github.com/repos/airbnb/knowledge-repo/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/knowledge-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/knowledge-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/knowledge-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/knowledge-repo/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/knowledge-repo/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/knowledge-repo/deployments","created_at":"2016-08-17T23:32:50Z","updated_at":"2016-11-28T18:20:10Z","pushed_at":"2016-11-28T18:47:37Z","git_url":"git://github.com/airbnb/knowledge-repo.git","ssh_url":"git@github.com:airbnb/knowledge-repo.git","clone_url":"https://github.com/airbnb/knowledge-repo.git","svn_url":"https://github.com/airbnb/knowledge-repo","homepage":"","size":866,"stargazers_count":1414,"watchers_count":1414,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":104,"mirror_url":null,"open_issues_count":36,"forks":104,"open_issues":36,"watchers":1414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140"},"html":{"href":"https://github.com/airbnb/knowledge-repo/pull/140"},"issue":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/issues/140"},"comments":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/knowledge-repo/statuses/b209d72179cede7a15ea5694493565b9de975184"}}}}
{"actor":{"display_login":"matthewwardrop"}}