{"action":"created","issue":{"url":"https://api.github.com/repos/micropython/micropython/issues/2414","repository_url":"https://api.github.com/repos/micropython/micropython","labels_url":"https://api.github.com/repos/micropython/micropython/issues/2414/labels{/name}","comments_url":"https://api.github.com/repos/micropython/micropython/issues/2414/comments","events_url":"https://api.github.com/repos/micropython/micropython/issues/2414/events","html_url":"https://github.com/micropython/micropython/issues/2414","id":176456010,"number":2414,"title":"Establish a no-increase-of-code-size regression check for pull requests","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars.githubusercontent.com/u/500451?v=3","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-09-12T18:59:06Z","updated_at":"2016-09-13T05:27:12Z","closed_at":null,"body":"Recently, we're getting increasing number of pull request, and many of these pull requests add features without paying attention to maintain minimal code size of MicroPython. I'd like to propose to establish a check, similar e.g. to travis or coveralls which would check that size of selected ports does not increase with a patch. If size increased, it would mark check as \"failed\" for further investigation. The list of ports mentioned above is definitely minimal port and minimal unix port, though it would be nice to establish control of main unix port size growth too. It's bound to grow in size, as new features are added constantly. That's exactly why I say that there should be control of the growing size, and the only means to establish it is apparently scrutinize which features are added to unix port, and which don't.\r\n\r\nI'm writing this as someone who works to make sure that the code size at least of the minimal ports decreases over time, and unix port size stays under control (arguably, it's too big, and some features may need to be removed from the default config (like VFS was removed lately)).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/micropython/micropython/issues/comments/246578014","html_url":"https://github.com/micropython/micropython/issues/2414#issuecomment-246578014","issue_url":"https://api.github.com/repos/micropython/micropython/issues/2414","id":246578014,"user":{"login":"dpgeorge","id":6187689,"avatar_url":"https://avatars.githubusercontent.com/u/6187689?v=3","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"created_at":"2016-09-13T05:27:12Z","updated_at":"2016-09-13T05:27:12Z","body":"Features are always going to add size to the firmware :)  But keeping minimal, unix/minimal and bare-arm approx constant does make sense (but even those ports will grow slowly, eg by moving to Python 3.5, 3.6 etc.\r\n\r\nI'm not sure though how to make a custom github hook that mirrors the functionality of coveralls.  Maybe someone with experience writing such hooks can contribute something?"}}
{"actor":{"display_login":"dpgeorge"}}