{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/71656891","id":71656891,"diff_hunk":"@@ -1213,14 +1223,14 @@ parseHookedBuildInfo inp = do\n           lowercase inFieldName /= \"library\" &&\n           lowercase inFieldName /= \"benchmark\" &&\n           lowercase inFieldName /= \"test-suite\"\n-            = liftM (\\bis -> [(CLibName \"\", bis)]) (parseBI bi)\n+            = liftM (\\bis -> [(CLibName, bis)]) (parseBI bi)\n     parseLib _ = return []\n \n     parseStanza :: HookedBuildInfo -> [Field] -> ParseResult HookedBuildInfo\n     parseStanza bis (F line inFieldName mName:bi)\n         | Just k <- case lowercase inFieldName of\n                         \"executable\" -> Just CExeName\n-                        \"library\"    -> Just CLibName\n+                        \"library\"    -> Just CSubLibName","path":"Cabal/Distribution/PackageDescription/Parse.hs","position":173,"original_position":173,"commit_id":"d58137b4cbba9cdf6b9597c1d9bbd2e819c64bdb","original_commit_id":"7321608d017eb9933385f081e76accf58eaa2ef3","user":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?v=3","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"body":"Don't you need to check whether this is a named library here?","created_at":"2016-07-21T07:13:38Z","updated_at":"2016-07-21T07:13:38Z","html_url":"https://github.com/haskell/cabal/pull/3580#discussion_r71656891","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/3580","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/71656891"},"html":{"href":"https://github.com/haskell/cabal/pull/3580#discussion_r71656891"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3580"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/3580","id":78261149,"html_url":"https://github.com/haskell/cabal/pull/3580","diff_url":"https://github.com/haskell/cabal/pull/3580.diff","patch_url":"https://github.com/haskell/cabal/pull/3580.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/3580","number":3580,"state":"open","locked":false,"title":"BC fix: libraries -> library/subLibraries (#3574)","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"The resulting code is more verbose, but it is more backwards-compatible\r\nand actually is simpler to understand in some cases (because\r\nCLibName uniquely identifies the \"public library\"; no faffing\r\nabout with package names to figure it out.)\r\n\r\nSigned-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>","created_at":"2016-07-21T05:49:56Z","updated_at":"2016-07-21T07:13:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b35a6e50a67424ec5f0e70a92d43510ba6ffff9","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/haskell/cabal/milestones/31","html_url":"https://github.com/haskell/cabal/milestones/Cabal%201.26","labels_url":"https://api.github.com/repos/haskell/cabal/milestones/31/labels","id":1556948,"number":31,"title":"Cabal 1.26","description":"","creator":{"login":"23Skidoo","id":47439,"avatar_url":"https://avatars.githubusercontent.com/u/47439?v=3","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"open_issues":170,"closed_issues":10,"state":"open","created_at":"2016-02-01T22:24:32Z","updated_at":"2016-07-21T05:49:56Z","due_on":"2016-11-05T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/3580/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/3580/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/3580/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/d58137b4cbba9cdf6b9597c1d9bbd2e819c64bdb","head":{"label":"ezyang:cabal-convenience-bc","ref":"cabal-convenience-bc","sha":"d58137b4cbba9cdf6b9597c1d9bbd2e819c64bdb","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":6343207,"name":"cabal","full_name":"ezyang/cabal","owner":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/ezyang/cabal","forks_url":"https://api.github.com/repos/ezyang/cabal/forks","keys_url":"https://api.github.com/repos/ezyang/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/cabal/teams","hooks_url":"https://api.github.com/repos/ezyang/cabal/hooks","issue_events_url":"https://api.github.com/repos/ezyang/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/cabal/events","assignees_url":"https://api.github.com/repos/ezyang/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/cabal/tags","blobs_url":"https://api.github.com/repos/ezyang/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/cabal/languages","stargazers_url":"https://api.github.com/repos/ezyang/cabal/stargazers","contributors_url":"https://api.github.com/repos/ezyang/cabal/contributors","subscribers_url":"https://api.github.com/repos/ezyang/cabal/subscribers","subscription_url":"https://api.github.com/repos/ezyang/cabal/subscription","commits_url":"https://api.github.com/repos/ezyang/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezyang/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/cabal/merges","archive_url":"https://api.github.com/repos/ezyang/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/cabal/downloads","issues_url":"https://api.github.com/repos/ezyang/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/cabal/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/ezyang/cabal/deployments","created_at":"2012-10-22T22:12:16Z","updated_at":"2016-07-19T16:21:03Z","pushed_at":"2016-07-21T07:09:51Z","git_url":"git://github.com/ezyang/cabal.git","ssh_url":"git@github.com:ezyang/cabal.git","clone_url":"https://github.com/ezyang/cabal.git","svn_url":"https://github.com/ezyang/cabal","homepage":"http://haskell.org/cabal","size":30988,"stargazers_count":7,"watchers_count":7,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":7,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"487565aa59f026896fafeb2b441c3d0a2e01b495","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-07-19T16:21:18Z","pushed_at":"2016-07-21T07:09:52Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":39342,"stargazers_count":621,"watchers_count":621,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":330,"mirror_url":null,"open_issues_count":726,"forks":330,"open_issues":726,"watchers":621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3580"},"html":{"href":"https://github.com/haskell/cabal/pull/3580"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/3580"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/3580/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3580/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3580/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/d58137b4cbba9cdf6b9597c1d9bbd2e819c64bdb"}}}}
{"actor":{"display_login":"23Skidoo"}}