{"action":"created","comment":{"url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments/84283153","pull_request_review_id":5069626,"id":84283153,"diff_hunk":"@@ -195,10 +199,41 @@ class ComputeVSD : public CommandLineApplication\n \n         VolumePtr output = source->GetOutput();\n         output->SetRegions( fivox::FloatVolume::RegionType( vIndex, vSize ));\n-        output->SetSpacing( volumeHandler.computeSpacing( ));\n \n-        const fivox::AABBf& bbox = vsdLoader->getBoundingBoxSomas();\n-        output->SetOrigin( volumeHandler.computeOrigin( bbox.getCenter( )));\n+        fivox::AABBf bboxSomas;\n+        const auto& somaPositions = vsdLoader->getSomaPositions();\n+        for( const auto& position : somaPositions )\n+            bboxSomas.merge( position );\n+\n+        const auto spacing = volumeHandler.computeSpacing();\n+        const auto origin = volumeHandler.computeOrigin( bboxSomas.getCenter());\n+\n+        if( _vm.count( \"soma-pixels\" ))\n+        {\n+            const auto& fileName = _vm[\"soma-pixels\"].as< std::string >();\n+            std::ofstream file( fileName );\n+            file << \"# Soma position and corresponding pixel index for each \"\n+                    \"cell, in the following format:\\n\"\n+                 << \"#     gid [ posX posY posZ ]: i j\\n\"\n+                 << \"# File version: 1\\n\"\n+                 << \"# Fivox version: \" << fivox::Version::getString()\n+                 << std::endl;","path":"apps/computeVSD/computeVSD.cpp","position":38,"original_position":38,"commit_id":"335907b575a05380e47d7115a82920505c802464","original_commit_id":"335907b575a05380e47d7115a82920505c802464","user":{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false},"body":"There's no error checking after opening or writing the file.","created_at":"2016-10-20T13:36:07Z","updated_at":"2016-10-20T13:36:07Z","html_url":"https://github.com/BlueBrain/Fivox/pull/65#discussion_r84283153","pull_request_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65","_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments/84283153"},"html":{"href":"https://github.com/BlueBrain/Fivox/pull/65#discussion_r84283153"},"pull_request":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65","id":90162025,"html_url":"https://github.com/BlueBrain/Fivox/pull/65","diff_url":"https://github.com/BlueBrain/Fivox/pull/65.diff","patch_url":"https://github.com/BlueBrain/Fivox/pull/65.patch","issue_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/65","number":65,"state":"open","locked":false,"title":"Add soma-pixels option in compute-vsd","user":{"login":"jafyvilla","id":2028982,"avatar_url":"https://avatars.githubusercontent.com/u/2028982?v=3","gravatar_id":"","url":"https://api.github.com/users/jafyvilla","html_url":"https://github.com/jafyvilla","followers_url":"https://api.github.com/users/jafyvilla/followers","following_url":"https://api.github.com/users/jafyvilla/following{/other_user}","gists_url":"https://api.github.com/users/jafyvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jafyvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafyvilla/subscriptions","organizations_url":"https://api.github.com/users/jafyvilla/orgs","repos_url":"https://api.github.com/users/jafyvilla/repos","events_url":"https://api.github.com/users/jafyvilla/events{/privacy}","received_events_url":"https://api.github.com/users/jafyvilla/received_events","type":"User","site_admin":false},"body":"If specified, produce a text file with the GID, position\r\nand corresponding index in the final 2D image for all the\r\ncells loaded","created_at":"2016-10-20T09:19:48Z","updated_at":"2016-10-20T13:38:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3471043ff173195a6f5906d7f06a318b148d826","assignee":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"assignees":[{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},{"login":"hernando","id":791427,"avatar_url":"https://avatars.githubusercontent.com/u/791427?v=3","gravatar_id":"","url":"https://api.github.com/users/hernando","html_url":"https://github.com/hernando","followers_url":"https://api.github.com/users/hernando/followers","following_url":"https://api.github.com/users/hernando/following{/other_user}","gists_url":"https://api.github.com/users/hernando/gists{/gist_id}","starred_url":"https://api.github.com/users/hernando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hernando/subscriptions","organizations_url":"https://api.github.com/users/hernando/orgs","repos_url":"https://api.github.com/users/hernando/repos","events_url":"https://api.github.com/users/hernando/events{/privacy}","received_events_url":"https://api.github.com/users/hernando/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/65/comments","statuses_url":"https://api.github.com/repos/BlueBrain/Fivox/statuses/335907b575a05380e47d7115a82920505c802464","head":{"label":"jafyvilla:soma_pixels","ref":"soma_pixels","sha":"335907b575a05380e47d7115a82920505c802464","user":{"login":"jafyvilla","id":2028982,"avatar_url":"https://avatars.githubusercontent.com/u/2028982?v=3","gravatar_id":"","url":"https://api.github.com/users/jafyvilla","html_url":"https://github.com/jafyvilla","followers_url":"https://api.github.com/users/jafyvilla/followers","following_url":"https://api.github.com/users/jafyvilla/following{/other_user}","gists_url":"https://api.github.com/users/jafyvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jafyvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafyvilla/subscriptions","organizations_url":"https://api.github.com/users/jafyvilla/orgs","repos_url":"https://api.github.com/users/jafyvilla/repos","events_url":"https://api.github.com/users/jafyvilla/events{/privacy}","received_events_url":"https://api.github.com/users/jafyvilla/received_events","type":"User","site_admin":false},"repo":{"id":50598283,"name":"Fivox","full_name":"jafyvilla/Fivox","owner":{"login":"jafyvilla","id":2028982,"avatar_url":"https://avatars.githubusercontent.com/u/2028982?v=3","gravatar_id":"","url":"https://api.github.com/users/jafyvilla","html_url":"https://github.com/jafyvilla","followers_url":"https://api.github.com/users/jafyvilla/followers","following_url":"https://api.github.com/users/jafyvilla/following{/other_user}","gists_url":"https://api.github.com/users/jafyvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/jafyvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafyvilla/subscriptions","organizations_url":"https://api.github.com/users/jafyvilla/orgs","repos_url":"https://api.github.com/users/jafyvilla/repos","events_url":"https://api.github.com/users/jafyvilla/events{/privacy}","received_events_url":"https://api.github.com/users/jafyvilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jafyvilla/Fivox","description":"ITK library to sample events into regular volumes","fork":true,"url":"https://api.github.com/repos/jafyvilla/Fivox","forks_url":"https://api.github.com/repos/jafyvilla/Fivox/forks","keys_url":"https://api.github.com/repos/jafyvilla/Fivox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jafyvilla/Fivox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jafyvilla/Fivox/teams","hooks_url":"https://api.github.com/repos/jafyvilla/Fivox/hooks","issue_events_url":"https://api.github.com/repos/jafyvilla/Fivox/issues/events{/number}","events_url":"https://api.github.com/repos/jafyvilla/Fivox/events","assignees_url":"https://api.github.com/repos/jafyvilla/Fivox/assignees{/user}","branches_url":"https://api.github.com/repos/jafyvilla/Fivox/branches{/branch}","tags_url":"https://api.github.com/repos/jafyvilla/Fivox/tags","blobs_url":"https://api.github.com/repos/jafyvilla/Fivox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jafyvilla/Fivox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jafyvilla/Fivox/git/refs{/sha}","trees_url":"https://api.github.com/repos/jafyvilla/Fivox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jafyvilla/Fivox/statuses/{sha}","languages_url":"https://api.github.com/repos/jafyvilla/Fivox/languages","stargazers_url":"https://api.github.com/repos/jafyvilla/Fivox/stargazers","contributors_url":"https://api.github.com/repos/jafyvilla/Fivox/contributors","subscribers_url":"https://api.github.com/repos/jafyvilla/Fivox/subscribers","subscription_url":"https://api.github.com/repos/jafyvilla/Fivox/subscription","commits_url":"https://api.github.com/repos/jafyvilla/Fivox/commits{/sha}","git_commits_url":"https://api.github.com/repos/jafyvilla/Fivox/git/commits{/sha}","comments_url":"https://api.github.com/repos/jafyvilla/Fivox/comments{/number}","issue_comment_url":"https://api.github.com/repos/jafyvilla/Fivox/issues/comments{/number}","contents_url":"https://api.github.com/repos/jafyvilla/Fivox/contents/{+path}","compare_url":"https://api.github.com/repos/jafyvilla/Fivox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jafyvilla/Fivox/merges","archive_url":"https://api.github.com/repos/jafyvilla/Fivox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jafyvilla/Fivox/downloads","issues_url":"https://api.github.com/repos/jafyvilla/Fivox/issues{/number}","pulls_url":"https://api.github.com/repos/jafyvilla/Fivox/pulls{/number}","milestones_url":"https://api.github.com/repos/jafyvilla/Fivox/milestones{/number}","notifications_url":"https://api.github.com/repos/jafyvilla/Fivox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jafyvilla/Fivox/labels{/name}","releases_url":"https://api.github.com/repos/jafyvilla/Fivox/releases{/id}","deployments_url":"https://api.github.com/repos/jafyvilla/Fivox/deployments","created_at":"2016-01-28T16:55:40Z","updated_at":"2016-01-28T16:55:41Z","pushed_at":"2016-10-20T13:39:54Z","git_url":"git://github.com/jafyvilla/Fivox.git","ssh_url":"git@github.com:jafyvilla/Fivox.git","clone_url":"https://github.com/jafyvilla/Fivox.git","svn_url":"https://github.com/jafyvilla/Fivox","homepage":null,"size":844,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"e1ed5b524a6f60def4b50c67dc3756fd7adfd310","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":50582920,"name":"Fivox","full_name":"BlueBrain/Fivox","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/Fivox","description":"ITK library to sample events into regular volumes","fork":false,"url":"https://api.github.com/repos/BlueBrain/Fivox","forks_url":"https://api.github.com/repos/BlueBrain/Fivox/forks","keys_url":"https://api.github.com/repos/BlueBrain/Fivox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/Fivox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/Fivox/teams","hooks_url":"https://api.github.com/repos/BlueBrain/Fivox/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/Fivox/events","assignees_url":"https://api.github.com/repos/BlueBrain/Fivox/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/Fivox/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/Fivox/tags","blobs_url":"https://api.github.com/repos/BlueBrain/Fivox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/Fivox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/Fivox/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/Fivox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/Fivox/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/Fivox/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/Fivox/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/Fivox/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/Fivox/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/Fivox/subscription","commits_url":"https://api.github.com/repos/BlueBrain/Fivox/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/Fivox/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/Fivox/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/Fivox/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/Fivox/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/Fivox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/Fivox/merges","archive_url":"https://api.github.com/repos/BlueBrain/Fivox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/Fivox/downloads","issues_url":"https://api.github.com/repos/BlueBrain/Fivox/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/Fivox/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/Fivox/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/Fivox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/Fivox/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/Fivox/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/Fivox/deployments","created_at":"2016-01-28T12:56:11Z","updated_at":"2016-01-28T12:57:47Z","pushed_at":"2016-10-20T13:39:54Z","git_url":"git://github.com/BlueBrain/Fivox.git","ssh_url":"git@github.com:BlueBrain/Fivox.git","clone_url":"https://github.com/BlueBrain/Fivox.git","svn_url":"https://github.com/BlueBrain/Fivox","homepage":null,"size":866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65"},"html":{"href":"https://github.com/BlueBrain/Fivox/pull/65"},"issue":{"href":"https://api.github.com/repos/BlueBrain/Fivox/issues/65"},"comments":{"href":"https://api.github.com/repos/BlueBrain/Fivox/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/Fivox/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/Fivox/statuses/335907b575a05380e47d7115a82920505c802464"}}}}
{"actor":{"display_login":"hernando"}}