{"action":"created","issue":{"url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/issues/7","repository_url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob","labels_url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/issues/7/comments","events_url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/issues/7/events","html_url":"https://github.com/jonschlinkert/to-absolute-glob/pull/7","id":178269200,"number":7,"title":"adds isAbsolute","user":{"login":"jonschlinkert","id":383994,"avatar_url":"https://avatars.githubusercontent.com/u/383994?v=3","gravatar_id":"","url":"https://api.github.com/users/jonschlinkert","html_url":"https://github.com/jonschlinkert","followers_url":"https://api.github.com/users/jonschlinkert/followers","following_url":"https://api.github.com/users/jonschlinkert/following{/other_user}","gists_url":"https://api.github.com/users/jonschlinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/jonschlinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonschlinkert/subscriptions","organizations_url":"https://api.github.com/users/jonschlinkert/orgs","repos_url":"https://api.github.com/users/jonschlinkert/repos","events_url":"https://api.github.com/users/jonschlinkert/events{/privacy}","received_events_url":"https://api.github.com/users/jonschlinkert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-21T07:35:26Z","updated_at":"2016-10-13T21:25:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/pulls/7","html_url":"https://github.com/jonschlinkert/to-absolute-glob/pull/7","diff_url":"https://github.com/jonschlinkert/to-absolute-glob/pull/7.diff","patch_url":"https://github.com/jonschlinkert/to-absolute-glob/pull/7.patch"},"body":"this pr adds isAbsolute to ensure that globs are absolute. (TODO: I haven't had a chance to get appveyor running, will do that next along with windows tests. I just wanted to push this up to start discussing).\r\n\r\n**slashes**\r\n\r\nI spent quite a bit of time exploring different approaches to normalizing slashes, but I arrived at the conclusion that it's not a good idea - probably for the same reasons that node-glob disallows backslashes as path separators in globs.\r\n\r\n**escaping**\r\n\r\nSince most glob characters are perfectly valid path characters when used in normal file paths, there are too many scenarios where backslashes would indicate escaping, and not path separators. \r\n\r\nIf we muddy the waters on this, we will never be 100% correct, and users won't have a surefire way to tell us that they're escaping a character.\r\n\r\nOn that same point, I believe the main place where it really matters is if a path has a leading slash (since we need to know if it's absolute or not). But in windows, an absolute path shouldn't being with a slash or backslash, it would begin with a drive letter. Hopefully [this check](https://github.com/jonschlinkert/to-absolute-glob/compare/is-absolute?expand=1#diff-168726dbe96b3ce427e7fedce31bb0bcR30) resolves any issues you were having regarding absolute paths with windows.\r\n\r\n(also, fwiw in node-glob, most of the usage of `makeAbs` is on actual file paths I believe. I only saw one place where it seems to be used on globs. IMHO - if there is no good reason to do that in glob-stream, I'd leave it to node-glob)\r\n\r\ncc @phated"},"comment":{"url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/issues/comments/253643498","html_url":"https://github.com/jonschlinkert/to-absolute-glob/pull/7#issuecomment-253643498","issue_url":"https://api.github.com/repos/jonschlinkert/to-absolute-glob/issues/7","id":253643498,"user":{"login":"phated","id":992373,"avatar_url":"https://avatars.githubusercontent.com/u/992373?v=3","gravatar_id":"","url":"https://api.github.com/users/phated","html_url":"https://github.com/phated","followers_url":"https://api.github.com/users/phated/followers","following_url":"https://api.github.com/users/phated/following{/other_user}","gists_url":"https://api.github.com/users/phated/gists{/gist_id}","starred_url":"https://api.github.com/users/phated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phated/subscriptions","organizations_url":"https://api.github.com/users/phated/orgs","repos_url":"https://api.github.com/users/phated/repos","events_url":"https://api.github.com/users/phated/events{/privacy}","received_events_url":"https://api.github.com/users/phated/received_events","type":"User","site_admin":false},"created_at":"2016-10-13T21:25:22Z","updated_at":"2016-10-13T21:25:22Z","body":"@jonschlinkert any word on if you are going to ship this PR?  I'm currently trying to get path normalization wrapped up in `glob-stream` and was just looking at the base path stuff where this is used."}}
{"actor":{"display_login":"phated"}}