{"action":"opened","number":822,"pull_request":{"url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/822","id":68109862,"html_url":"https://github.com/rsim/oracle-enhanced/pull/822","diff_url":"https://github.com/rsim/oracle-enhanced/pull/822.diff","patch_url":"https://github.com/rsim/oracle-enhanced/pull/822.patch","issue_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/822","number":822,"state":"open","locked":false,"title":"Support ActiveRecord native comment feature","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"body":"This pull request supports ActiveRecord native comment feature.\r\n\r\nIt addresses regressions introduced by #820.\r\n\r\n```ruby\r\nrspec ./spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb:490 # OracleEnhancedAdapter schema dump table comments should dump table comments\r\nrspec ./spec/active_record/connection_adapters/oracle_enhanced_schema_dump_spec.rb:530 # OracleEnhancedAdapter schema dump table comments should dump table comments\r\nrspec ./spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb:347 # OracleEnhancedAdapter schema definition table and column comments should create table with table comment\r\nrspec ./spec/active_record/connection_adapters/oracle_enhanced_schema_statements_spec.rb:369 # OracleEnhancedAdapter schema definition table and column comments should create table with table and columns comment and custom table name prefix\r\n```\r\nExcept for `TestEmployee.columns_hash[attr.to_s].comment` syntax is de-supported due to conflicts with ActiveRecord native comment features.\r\n\r\nStill there are 5 errors / failures to support ActiveRecord native comment feature. Unfortunately this pull request introduces the following regression.\r\n\r\n```ruby\r\n$ ARCONN=oracle bundle exec ruby -W -w -I\"lib:test\" test/cases/comment_test.rb -n test_blank_columns_created_in_block\r\n... snip ...\r\n\r\n  1) Failure:\r\nCommentTest#test_blank_columns_created_in_block [test/cases/comment_test.rb:53]:\r\nExpected \" \" to be nil.\r\n\r\n1 runs, 2 assertions, 1 failures, 0 errors, 0 skips]$\r\n```","created_at":"2016-04-27T19:23:31Z","updated_at":"2016-04-27T19:23:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/822/commits","review_comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/822/comments","review_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/822/comments","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/4c8418f1e74bd6868e12a18cea0e21532473bbec","head":{"label":"yahonda:rails5_ar_comment","ref":"rails5_ar_comment","sha":"4c8418f1e74bd6868e12a18cea0e21532473bbec","user":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"repo":{"id":1907066,"name":"oracle-enhanced","full_name":"yahonda/oracle-enhanced","owner":{"login":"yahonda","id":73684,"avatar_url":"https://avatars.githubusercontent.com/u/73684?v=3","gravatar_id":"","url":"https://api.github.com/users/yahonda","html_url":"https://github.com/yahonda","followers_url":"https://api.github.com/users/yahonda/followers","following_url":"https://api.github.com/users/yahonda/following{/other_user}","gists_url":"https://api.github.com/users/yahonda/gists{/gist_id}","starred_url":"https://api.github.com/users/yahonda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahonda/subscriptions","organizations_url":"https://api.github.com/users/yahonda/orgs","repos_url":"https://api.github.com/users/yahonda/repos","events_url":"https://api.github.com/users/yahonda/events{/privacy}","received_events_url":"https://api.github.com/users/yahonda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yahonda/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":true,"url":"https://api.github.com/repos/yahonda/oracle-enhanced","forks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/yahonda/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahonda/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahonda/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/yahonda/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/yahonda/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/yahonda/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahonda/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/yahonda/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/yahonda/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahonda/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahonda/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/yahonda/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahonda/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/yahonda/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahonda/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/yahonda/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/yahonda/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/yahonda/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/yahonda/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahonda/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/yahonda/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/yahonda/oracle-enhanced/deployments","created_at":"2011-06-16T18:02:51Z","updated_at":"2016-02-16T21:16:51Z","pushed_at":"2016-04-27T19:14:33Z","git_url":"git://github.com/yahonda/oracle-enhanced.git","ssh_url":"git@github.com:yahonda/oracle-enhanced.git","clone_url":"https://github.com/yahonda/oracle-enhanced.git","svn_url":"https://github.com/yahonda/oracle-enhanced","homepage":"","size":4705,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"rsim:rails5","ref":"rails5","sha":"090fd678fcaf02d4df0b9726f84d46ab448573bb","user":{"login":"rsim","id":4736,"avatar_url":"https://avatars.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"repo":{"id":14507,"name":"oracle-enhanced","full_name":"rsim/oracle-enhanced","owner":{"login":"rsim","id":4736,"avatar_url":"https://avatars.githubusercontent.com/u/4736?v=3","gravatar_id":"","url":"https://api.github.com/users/rsim","html_url":"https://github.com/rsim","followers_url":"https://api.github.com/users/rsim/followers","following_url":"https://api.github.com/users/rsim/following{/other_user}","gists_url":"https://api.github.com/users/rsim/gists{/gist_id}","starred_url":"https://api.github.com/users/rsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsim/subscriptions","organizations_url":"https://api.github.com/users/rsim/orgs","repos_url":"https://api.github.com/users/rsim/repos","events_url":"https://api.github.com/users/rsim/events{/privacy}","received_events_url":"https://api.github.com/users/rsim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsim/oracle-enhanced","description":"Oracle enhaced adapter for ActiveRecord","fork":false,"url":"https://api.github.com/repos/rsim/oracle-enhanced","forks_url":"https://api.github.com/repos/rsim/oracle-enhanced/forks","keys_url":"https://api.github.com/repos/rsim/oracle-enhanced/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsim/oracle-enhanced/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsim/oracle-enhanced/teams","hooks_url":"https://api.github.com/repos/rsim/oracle-enhanced/hooks","issue_events_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/events{/number}","events_url":"https://api.github.com/repos/rsim/oracle-enhanced/events","assignees_url":"https://api.github.com/repos/rsim/oracle-enhanced/assignees{/user}","branches_url":"https://api.github.com/repos/rsim/oracle-enhanced/branches{/branch}","tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/tags","blobs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/{sha}","languages_url":"https://api.github.com/repos/rsim/oracle-enhanced/languages","stargazers_url":"https://api.github.com/repos/rsim/oracle-enhanced/stargazers","contributors_url":"https://api.github.com/repos/rsim/oracle-enhanced/contributors","subscribers_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscribers","subscription_url":"https://api.github.com/repos/rsim/oracle-enhanced/subscription","commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsim/oracle-enhanced/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsim/oracle-enhanced/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsim/oracle-enhanced/contents/{+path}","compare_url":"https://api.github.com/repos/rsim/oracle-enhanced/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsim/oracle-enhanced/merges","archive_url":"https://api.github.com/repos/rsim/oracle-enhanced/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsim/oracle-enhanced/downloads","issues_url":"https://api.github.com/repos/rsim/oracle-enhanced/issues{/number}","pulls_url":"https://api.github.com/repos/rsim/oracle-enhanced/pulls{/number}","milestones_url":"https://api.github.com/repos/rsim/oracle-enhanced/milestones{/number}","notifications_url":"https://api.github.com/repos/rsim/oracle-enhanced/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsim/oracle-enhanced/labels{/name}","releases_url":"https://api.github.com/repos/rsim/oracle-enhanced/releases{/id}","deployments_url":"https://api.github.com/repos/rsim/oracle-enhanced/deployments","created_at":"2008-05-04T22:02:14Z","updated_at":"2016-04-26T00:14:47Z","pushed_at":"2016-04-22T19:35:17Z","git_url":"git://github.com/rsim/oracle-enhanced.git","ssh_url":"git@github.com:rsim/oracle-enhanced.git","clone_url":"https://github.com/rsim/oracle-enhanced.git","svn_url":"https://github.com/rsim/oracle-enhanced","homepage":"","size":5464,"stargazers_count":428,"watchers_count":428,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":25,"forks":230,"open_issues":25,"watchers":428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/822"},"html":{"href":"https://github.com/rsim/oracle-enhanced/pull/822"},"issue":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/822"},"comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/issues/822/comments"},"review_comments":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/822/comments"},"review_comment":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/pulls/822/commits"},"statuses":{"href":"https://api.github.com/repos/rsim/oracle-enhanced/statuses/4c8418f1e74bd6868e12a18cea0e21532473bbec"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":50,"deletions":48,"changed_files":4}}