{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/80004024","id":80004024,"diff_hunk":"@@ -0,0 +1,35 @@\n+/*\n+ * Hibernate OGM, Domain model persistence for NoSQL datastores\n+ *\n+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later\n+ * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.\n+ */\n+package org.hibernate.ogm.datastore.neo4j.remote.common.request.impl;\n+\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.Iterator;\n+import java.util.List;\n+\n+/**\n+ * Collects a group of {@link RemoteStatement}.\n+ *\n+ * @author Davide D'Alto\n+ */\n+public class RemoteStatements implements Iterable<RemoteStatement> {\n+\n+\tprivate final List<RemoteStatement> statements = new ArrayList<>();\n+\n+\tpublic void add(RemoteStatement statement) {\n+\t\tstatements.add( statement );\n+\t}\n+\n+\t@Override\n+\tpublic Iterator<RemoteStatement> iterator() {\n+\t\treturn Collections.unmodifiableCollection( statements ).iterator();\n+\t}\n+\n+\tpublic void addStatement(RemoteStatement statement) {\n+\t\tstatements.add( statement );","path":"neo4j/src/main/java/org/hibernate/ogm/datastore/neo4j/remote/common/request/impl/RemoteStatements.java","position":33,"original_position":33,"commit_id":"1386e9dea5b5fb2a8b7d4bc378edac9addcc302b","original_commit_id":"83ef27b5ab20f5483923ee866d8ac6484a86857e","user":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars.githubusercontent.com/u/1279749?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"body":"Why is there a `add` and a `addStatement`? Looks like we should remove one. Btw, maybe we could return `this` so that we could chain the calls?","created_at":"2016-09-22T09:28:33Z","updated_at":"2016-09-22T09:28:33Z","html_url":"https://github.com/hibernate/hibernate-ogm/pull/770#discussion_r80004024","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/80004024"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/770#discussion_r80004024"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770","id":85866277,"html_url":"https://github.com/hibernate/hibernate-ogm/pull/770","diff_url":"https://github.com/hibernate/hibernate-ogm/pull/770.diff","patch_url":"https://github.com/hibernate/hibernate-ogm/pull/770.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/770","number":770,"state":"open","locked":false,"title":"OGM-1089 Integration with Neo4j using Bolt","user":{"login":"DavideD","id":559221,"avatar_url":"https://avatars.githubusercontent.com/u/559221?v=3","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net/browse/OGM-1089\r\n\r\nThis PR will add a new dialect that uses the Bolt protocol instead of the HTTP API.\r\n\r\nI opted for the following prefixes:\r\n- BOLT: for the bolt protocol\r\n- HTTP: for the HTTP api\r\n- REMOTE: for the classes that are common to the Bolt and Http ones\r\n\r\nThe package containing the classes are under \r\n`org.hibernate.ogm.datastore.neo4j.remote.[bolt|http|common]` \r\n\r\nThe mapping is identical to the existing ones, infact it reuses the existing queries. \r\nThe code could be rafctor more but I think this is good as a first stage.\r\n\r\nAt the moment the tests under the integrationtest module will only work if the default port is used for Bolt.\r\n\r\nIs it possible to run the test via:\r\n`mvn install -pl neo4j -P neo4j-bolt`\r\n\r\nThe connection via bolt is manged using the `neo4j-java-driver`","created_at":"2016-09-19T20:46:20Z","updated_at":"2016-09-22T09:28:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"def253cbb6c6cbeb6207db882bc1173310fc8571","assignee":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars.githubusercontent.com/u/1279749?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"assignees":[{"login":"gsmet","id":1279749,"avatar_url":"https://avatars.githubusercontent.com/u/1279749?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/770/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/1386e9dea5b5fb2a8b7d4bc378edac9addcc302b","head":{"label":"DavideD:OGM-1089-Bolt-and-rest","ref":"OGM-1089-Bolt-and-rest","sha":"1386e9dea5b5fb2a8b7d4bc378edac9addcc302b","user":{"login":"DavideD","id":559221,"avatar_url":"https://avatars.githubusercontent.com/u/559221?v=3","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"repo":{"id":1645658,"name":"hibernate-ogm","full_name":"DavideD/hibernate-ogm","owner":{"login":"DavideD","id":559221,"avatar_url":"https://avatars.githubusercontent.com/u/559221?v=3","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DavideD/hibernate-ogm","description":"Hibernate Object/Grid Mapper","fork":true,"url":"https://api.github.com/repos/DavideD/hibernate-ogm","forks_url":"https://api.github.com/repos/DavideD/hibernate-ogm/forks","keys_url":"https://api.github.com/repos/DavideD/hibernate-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DavideD/hibernate-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DavideD/hibernate-ogm/teams","hooks_url":"https://api.github.com/repos/DavideD/hibernate-ogm/hooks","issue_events_url":"https://api.github.com/repos/DavideD/hibernate-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/DavideD/hibernate-ogm/events","assignees_url":"https://api.github.com/repos/DavideD/hibernate-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/DavideD/hibernate-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/DavideD/hibernate-ogm/tags","blobs_url":"https://api.github.com/repos/DavideD/hibernate-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DavideD/hibernate-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DavideD/hibernate-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/DavideD/hibernate-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DavideD/hibernate-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/DavideD/hibernate-ogm/languages","stargazers_url":"https://api.github.com/repos/DavideD/hibernate-ogm/stargazers","contributors_url":"https://api.github.com/repos/DavideD/hibernate-ogm/contributors","subscribers_url":"https://api.github.com/repos/DavideD/hibernate-ogm/subscribers","subscription_url":"https://api.github.com/repos/DavideD/hibernate-ogm/subscription","commits_url":"https://api.github.com/repos/DavideD/hibernate-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/DavideD/hibernate-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/DavideD/hibernate-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/DavideD/hibernate-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/DavideD/hibernate-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/DavideD/hibernate-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DavideD/hibernate-ogm/merges","archive_url":"https://api.github.com/repos/DavideD/hibernate-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DavideD/hibernate-ogm/downloads","issues_url":"https://api.github.com/repos/DavideD/hibernate-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/DavideD/hibernate-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/DavideD/hibernate-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/DavideD/hibernate-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DavideD/hibernate-ogm/labels{/name}","releases_url":"https://api.github.com/repos/DavideD/hibernate-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/DavideD/hibernate-ogm/deployments","created_at":"2011-04-21T14:40:12Z","updated_at":"2016-03-06T05:30:28Z","pushed_at":"2016-09-19T17:50:48Z","git_url":"git://github.com/DavideD/hibernate-ogm.git","ssh_url":"git@github.com:DavideD/hibernate-ogm.git","clone_url":"https://github.com/DavideD/hibernate-ogm.git","svn_url":"https://github.com/DavideD/hibernate-ogm","homepage":"http://community.jboss.org/en/hibernate/ogm","size":15481,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"1c3305f094255bd49ac094154fc64700b3581980","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":1608936,"name":"hibernate-ogm","full_name":"hibernate/hibernate-ogm","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-ogm","description":"Hibernate OGM - Domain model persistence for NoSQL datastores","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-ogm","forks_url":"https://api.github.com/repos/hibernate/hibernate-ogm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-ogm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-ogm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-ogm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-ogm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-ogm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-ogm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-ogm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-ogm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-ogm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-ogm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-ogm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/deployments","created_at":"2011-04-13T11:40:56Z","updated_at":"2016-09-22T00:33:51Z","pushed_at":"2016-09-22T08:22:56Z","git_url":"git://github.com/hibernate/hibernate-ogm.git","ssh_url":"git@github.com:hibernate/hibernate-ogm.git","clone_url":"https://github.com/hibernate/hibernate-ogm.git","svn_url":"https://github.com/hibernate/hibernate-ogm","homepage":"http://hibernate.org/ogm/","size":18387,"stargazers_count":206,"watchers_count":206,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":5,"forks":145,"open_issues":5,"watchers":206,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/770"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/770"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/770/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/770/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/1386e9dea5b5fb2a8b7d4bc378edac9addcc302b"}}}}
{"actor":{"display_login":"gsmet"}}