{"action":"created","issue":{"url":"https://api.github.com/repos/typings/registry/issues/358","repository_url":"https://api.github.com/repos/typings/registry","labels_url":"https://api.github.com/repos/typings/registry/issues/358/labels{/name}","comments_url":"https://api.github.com/repos/typings/registry/issues/358/comments","events_url":"https://api.github.com/repos/typings/registry/issues/358/events","html_url":"https://github.com/typings/registry/pull/358","id":151213409,"number":358,"title":"Add npm/js-sha256","user":{"login":"Demurgos","id":2262218,"avatar_url":"https://avatars.githubusercontent.com/u/2262218?v=3","gravatar_id":"","url":"https://api.github.com/users/Demurgos","html_url":"https://github.com/Demurgos","followers_url":"https://api.github.com/users/Demurgos/followers","following_url":"https://api.github.com/users/Demurgos/following{/other_user}","gists_url":"https://api.github.com/users/Demurgos/gists{/gist_id}","starred_url":"https://api.github.com/users/Demurgos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Demurgos/subscriptions","organizations_url":"https://api.github.com/users/Demurgos/orgs","repos_url":"https://api.github.com/users/Demurgos/repos","events_url":"https://api.github.com/users/Demurgos/events{/privacy}","received_events_url":"https://api.github.com/users/Demurgos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-04-26T19:00:37Z","updated_at":"2016-04-27T16:57:09Z","closed_at":"2016-04-27T05:19:17Z","pull_request":{"url":"https://api.github.com/repos/typings/registry/pulls/358","html_url":"https://github.com/typings/registry/pull/358","diff_url":"https://github.com/typings/registry/pull/358.diff","patch_url":"https://github.com/typings/registry/pull/358.patch"},"body":"Typings URL: https://github.com/Demurgos/typed-js-sha256\r\nSource URL: https://github.com/emn178/js-sha256\r\n\r\nI added a warning in the `README.md` because I had a doubt: this module both uses the Node's \"function as a module\" export and exports a `namespace` being strict-commonjs/ES6 standard-compliant.\r\nWhen both are available, should I still expose the non-standard way ? With Typescript supporting ES6 modules from the beginning, it's does not complicate the import on the consumer side.\r\n\r\nThis way of exporting also has a few side-effects: the object is circular:\r\n````typescript\r\nimport {sha256} from \"js-sha256\";\r\nconsole.log(sha256.sha256 === sha256); // true\r\n````\r\nBut this is not documented.\r\nAlso, the implementation uses an optional parameter but the documentation never mentions it: it's in fact an internal \"flag\". Should I define it as optional or do not expose this private signature ?"},"comment":{"url":"https://api.github.com/repos/typings/registry/issues/comments/215147496","html_url":"https://github.com/typings/registry/pull/358#issuecomment-215147496","issue_url":"https://api.github.com/repos/typings/registry/issues/358","id":215147496,"user":{"login":"blakeembrey","id":1088987,"avatar_url":"https://avatars.githubusercontent.com/u/1088987?v=3","gravatar_id":"","url":"https://api.github.com/users/blakeembrey","html_url":"https://github.com/blakeembrey","followers_url":"https://api.github.com/users/blakeembrey/followers","following_url":"https://api.github.com/users/blakeembrey/following{/other_user}","gists_url":"https://api.github.com/users/blakeembrey/gists{/gist_id}","starred_url":"https://api.github.com/users/blakeembrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blakeembrey/subscriptions","organizations_url":"https://api.github.com/users/blakeembrey/orgs","repos_url":"https://api.github.com/users/blakeembrey/repos","events_url":"https://api.github.com/users/blakeembrey/events{/privacy}","received_events_url":"https://api.github.com/users/blakeembrey/received_events","type":"User","site_admin":false},"created_at":"2016-04-27T16:57:09Z","updated_at":"2016-04-27T16:57:09Z","body":"I think the existing code is fine, as I said. I don't see a need for it to be complicated that way, unless it's how people use it (and here, it's not)"}}