{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/74123408","id":74123408,"diff_hunk":"@@ -4,11 +4,31 @@\n #---------------------------------------------------------------------------------------------\n #pylint: disable=line-too-long\n import azure.cli.commands.parameters #pylint: disable=unused-import\n-\n+from azure.cli.commands import CliArgumentType\n from azure.cli.commands import register_cli_argument\n \n register_cli_argument('ad app', 'application_object_id', options_list=('--object-id',))\n-register_cli_argument('ad app', 'app_id', help='application id')\n+register_cli_argument('ad app', 'display_name', help=' the display name of the application')\n+register_cli_argument('ad app', 'homepage', help='the url where users can sign in and use your app.')\n+register_cli_argument('ad app', 'identifier', options_list=('--id',), help='identifier uri, application id, or object id')\n+register_cli_argument('ad app', 'identifier_uris', nargs='+', help='space separated unique URIs that Azure AD can use for this app.')\n+register_cli_argument('ad app', 'reply_urls', nargs='+',\n+                      help='space separated URIs to which Azure AD will redirect in response to an OAuth 2.0 request. The value does not need to be a physical endpoint, but must be a valid URI.')\n+register_cli_argument('ad app', 'start_date', help='the start date after which password or key would be valid. Default value is current time')\n+register_cli_argument('ad app', 'end_date', help='the end date till which password or key is valid. Default value is one year after current time')\n+register_cli_argument('ad app', 'key_value', help='the value for the key credentials associated with the application')\n+register_cli_argument('ad app', 'key_type', choices=['AsymmetricX509Cert', 'Password', 'Symmetric'], default='AsymmetricX509Cert',","path":"src/command_modules/azure-cli-role/azure/cli/command_modules/role/_params.py","position":19,"original_position":19,"commit_id":"395a2bd22e6f503ea75f5c0d7d3fe9abd9e80c87","original_commit_id":"395a2bd22e6f503ea75f5c0d7d3fe9abd9e80c87","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"body":"I thought about doing you suggested, but as i checked out, the value is not modeled in SDK. \r\n","created_at":"2016-08-09T19:00:12Z","updated_at":"2016-08-09T19:00:12Z","html_url":"https://github.com/Azure/azure-cli/pull/664#discussion_r74123408","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/664","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/74123408"},"html":{"href":"https://github.com/Azure/azure-cli/pull/664#discussion_r74123408"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/664"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/664","id":80526109,"html_url":"https://github.com/Azure/azure-cli/pull/664","diff_url":"https://github.com/Azure/azure-cli/pull/664.diff","patch_url":"https://github.com/Azure/azure-cli/pull/664.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/664","number":664,"state":"open","locked":false,"title":"graph: full support for applications and service principals","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"body":"1. Create\r\n2. Update\r\n3. show and delete get improved by accepting both object id or logic identifier names\r\n4. Move `account create-sp` to `ad sp create-for-rbac`","created_at":"2016-08-08T21:34:26Z","updated_at":"2016-08-09T19:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce802e3a76ba6c506f610ee288701abfd9531e8a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/664/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/664/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/664/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/395a2bd22e6f503ea75f5c0d7d3fe9abd9e80c87","head":{"label":"yugangw-msft:ad","ref":"ad","sha":"395a2bd22e6f503ea75f5c0d7d3fe9abd9e80c87","user":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"repo":{"id":64246644,"name":"azure-cli","full_name":"yugangw-msft/azure-cli","owner":{"login":"yugangw-msft","id":6014209,"avatar_url":"https://avatars.githubusercontent.com/u/6014209?v=3","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yugangw-msft/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/yugangw-msft/azure-cli","forks_url":"https://api.github.com/repos/yugangw-msft/azure-cli/forks","keys_url":"https://api.github.com/repos/yugangw-msft/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yugangw-msft/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yugangw-msft/azure-cli/teams","hooks_url":"https://api.github.com/repos/yugangw-msft/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/yugangw-msft/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/yugangw-msft/azure-cli/events","assignees_url":"https://api.github.com/repos/yugangw-msft/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/yugangw-msft/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/yugangw-msft/azure-cli/tags","blobs_url":"https://api.github.com/repos/yugangw-msft/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yugangw-msft/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yugangw-msft/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/yugangw-msft/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yugangw-msft/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/yugangw-msft/azure-cli/languages","stargazers_url":"https://api.github.com/repos/yugangw-msft/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/yugangw-msft/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/yugangw-msft/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/yugangw-msft/azure-cli/subscription","commits_url":"https://api.github.com/repos/yugangw-msft/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/yugangw-msft/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/yugangw-msft/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/yugangw-msft/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/yugangw-msft/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/yugangw-msft/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yugangw-msft/azure-cli/merges","archive_url":"https://api.github.com/repos/yugangw-msft/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yugangw-msft/azure-cli/downloads","issues_url":"https://api.github.com/repos/yugangw-msft/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/yugangw-msft/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/yugangw-msft/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/yugangw-msft/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yugangw-msft/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/yugangw-msft/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/yugangw-msft/azure-cli/deployments","created_at":"2016-07-26T18:58:36Z","updated_at":"2016-07-26T18:58:39Z","pushed_at":"2016-08-09T18:33:31Z","git_url":"git://github.com/yugangw-msft/azure-cli.git","ssh_url":"git@github.com:yugangw-msft/azure-cli.git","clone_url":"https://github.com/yugangw-msft/azure-cli.git","svn_url":"https://github.com/yugangw-msft/azure-cli","homepage":null,"size":5739,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"ff1407b27909341d7c0f7c4dafa195e055608af1","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2016-08-05T15:02:11Z","pushed_at":"2016-08-09T18:17:44Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":8654,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":124,"forks":10,"open_issues":124,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/664"},"html":{"href":"https://github.com/Azure/azure-cli/pull/664"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/664"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/664/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/664/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/664/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/395a2bd22e6f503ea75f5c0d7d3fe9abd9e80c87"}}}}
{"actor":{"display_login":"yugangw-msft"}}