{"action":"created","comment":{"url":"https://api.github.com/repos/danthorpe/Operations/pulls/comments/63282054","id":63282054,"diff_hunk":"@@ -0,0 +1,129 @@\n+//\n+//  OpenInSafariOperation.swift\n+//  Operations\n+//\n+//  Created by Andreas Braun on 14.05.16.\n+//\n+//\n+\n+import Foundation\n+import UIKit\n+\n+/**\n+ An Operation that opens a given URL in an SFSafariViewController (if the base iOS SDK supports it) or opens it in the Safari app.\n+ \n+ It implements the following behaviour:\n+ \n+ - If the current iOS version supports SFSafariViewController, it opens the provided URL in an SFSafariViewController using WebpageOperation.\n+ - If the app is the secondary app in a SplitView, it opens the provided URL in Safari as the primary app.\n+ - If the current iOS version does not support SFSafariViewController, it opens the URL the old school way.\n+ */\n+\n+public class OpenInSafariOperation<From: PresentingViewController>: GroupOperation {\n+    /// The URL to open.\n+    public var URL: NSURL\n+    /// A flag that determines whether the `SFSafariViewController` should open the `URL` in reader mode or not.\n+    public var entersReaderIfAvailable: Bool\n+    /// The presenting `ViewControllerDisplayStyle`\n+    private var displayControllerFrom: ViewControllerDisplayStyle<From>?","path":"Sources/Features/iOS/OpenInSafariOperation.swift","position":28,"original_position":28,"commit_id":"a2a20d83d93bd8c7b9f51f27e7ab824f0d92f6f1","original_commit_id":"a2a20d83d93bd8c7b9f51f27e7ab824f0d92f6f1","user":{"login":"danthorpe","id":309420,"avatar_url":"https://avatars.githubusercontent.com/u/309420?v=3","gravatar_id":"","url":"https://api.github.com/users/danthorpe","html_url":"https://github.com/danthorpe","followers_url":"https://api.github.com/users/danthorpe/followers","following_url":"https://api.github.com/users/danthorpe/following{/other_user}","gists_url":"https://api.github.com/users/danthorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/danthorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danthorpe/subscriptions","organizations_url":"https://api.github.com/users/danthorpe/orgs","repos_url":"https://api.github.com/users/danthorpe/repos","events_url":"https://api.github.com/users/danthorpe/events{/privacy}","received_events_url":"https://api.github.com/users/danthorpe/received_events","type":"User","site_admin":false},"body":"I think these should be constants `let` yeah?","created_at":"2016-05-14T21:06:31Z","updated_at":"2016-05-14T21:06:31Z","html_url":"https://github.com/danthorpe/Operations/pull/317#discussion_r63282054","pull_request_url":"https://api.github.com/repos/danthorpe/Operations/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/danthorpe/Operations/pulls/comments/63282054"},"html":{"href":"https://github.com/danthorpe/Operations/pull/317#discussion_r63282054"},"pull_request":{"href":"https://api.github.com/repos/danthorpe/Operations/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/danthorpe/Operations/pulls/317","id":70102485,"html_url":"https://github.com/danthorpe/Operations/pull/317","diff_url":"https://github.com/danthorpe/Operations/pull/317.diff","patch_url":"https://github.com/danthorpe/Operations/pull/317.patch","issue_url":"https://api.github.com/repos/danthorpe/Operations/issues/317","number":317,"state":"open","locked":false,"title":"Implemented OpenInSafariOperation","user":{"login":"blg-andreasbraun","id":11517486,"avatar_url":"https://avatars.githubusercontent.com/u/11517486?v=3","gravatar_id":"","url":"https://api.github.com/users/blg-andreasbraun","html_url":"https://github.com/blg-andreasbraun","followers_url":"https://api.github.com/users/blg-andreasbraun/followers","following_url":"https://api.github.com/users/blg-andreasbraun/following{/other_user}","gists_url":"https://api.github.com/users/blg-andreasbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/blg-andreasbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blg-andreasbraun/subscriptions","organizations_url":"https://api.github.com/users/blg-andreasbraun/orgs","repos_url":"https://api.github.com/users/blg-andreasbraun/repos","events_url":"https://api.github.com/users/blg-andreasbraun/events{/privacy}","received_events_url":"https://api.github.com/users/blg-andreasbraun/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-14T20:04:02Z","updated_at":"2016-05-14T21:06:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"476f6c6c021d602bfdba9e8a454e474547ac87e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/danthorpe/Operations/pulls/317/commits","review_comments_url":"https://api.github.com/repos/danthorpe/Operations/pulls/317/comments","review_comment_url":"https://api.github.com/repos/danthorpe/Operations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danthorpe/Operations/issues/317/comments","statuses_url":"https://api.github.com/repos/danthorpe/Operations/statuses/a2a20d83d93bd8c7b9f51f27e7ab824f0d92f6f1","head":{"label":"blg-andreasbraun:development","ref":"development","sha":"a2a20d83d93bd8c7b9f51f27e7ab824f0d92f6f1","user":{"login":"blg-andreasbraun","id":11517486,"avatar_url":"https://avatars.githubusercontent.com/u/11517486?v=3","gravatar_id":"","url":"https://api.github.com/users/blg-andreasbraun","html_url":"https://github.com/blg-andreasbraun","followers_url":"https://api.github.com/users/blg-andreasbraun/followers","following_url":"https://api.github.com/users/blg-andreasbraun/following{/other_user}","gists_url":"https://api.github.com/users/blg-andreasbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/blg-andreasbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blg-andreasbraun/subscriptions","organizations_url":"https://api.github.com/users/blg-andreasbraun/orgs","repos_url":"https://api.github.com/users/blg-andreasbraun/repos","events_url":"https://api.github.com/users/blg-andreasbraun/events{/privacy}","received_events_url":"https://api.github.com/users/blg-andreasbraun/received_events","type":"User","site_admin":false},"repo":{"id":58496109,"name":"Operations","full_name":"blg-andreasbraun/Operations","owner":{"login":"blg-andreasbraun","id":11517486,"avatar_url":"https://avatars.githubusercontent.com/u/11517486?v=3","gravatar_id":"","url":"https://api.github.com/users/blg-andreasbraun","html_url":"https://github.com/blg-andreasbraun","followers_url":"https://api.github.com/users/blg-andreasbraun/followers","following_url":"https://api.github.com/users/blg-andreasbraun/following{/other_user}","gists_url":"https://api.github.com/users/blg-andreasbraun/gists{/gist_id}","starred_url":"https://api.github.com/users/blg-andreasbraun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blg-andreasbraun/subscriptions","organizations_url":"https://api.github.com/users/blg-andreasbraun/orgs","repos_url":"https://api.github.com/users/blg-andreasbraun/repos","events_url":"https://api.github.com/users/blg-andreasbraun/events{/privacy}","received_events_url":"https://api.github.com/users/blg-andreasbraun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blg-andreasbraun/Operations","description":"A Swift framework inspired by WWDC 2015 Advanced NSOperations session.","fork":true,"url":"https://api.github.com/repos/blg-andreasbraun/Operations","forks_url":"https://api.github.com/repos/blg-andreasbraun/Operations/forks","keys_url":"https://api.github.com/repos/blg-andreasbraun/Operations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blg-andreasbraun/Operations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blg-andreasbraun/Operations/teams","hooks_url":"https://api.github.com/repos/blg-andreasbraun/Operations/hooks","issue_events_url":"https://api.github.com/repos/blg-andreasbraun/Operations/issues/events{/number}","events_url":"https://api.github.com/repos/blg-andreasbraun/Operations/events","assignees_url":"https://api.github.com/repos/blg-andreasbraun/Operations/assignees{/user}","branches_url":"https://api.github.com/repos/blg-andreasbraun/Operations/branches{/branch}","tags_url":"https://api.github.com/repos/blg-andreasbraun/Operations/tags","blobs_url":"https://api.github.com/repos/blg-andreasbraun/Operations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blg-andreasbraun/Operations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blg-andreasbraun/Operations/git/refs{/sha}","trees_url":"https://api.github.com/repos/blg-andreasbraun/Operations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blg-andreasbraun/Operations/statuses/{sha}","languages_url":"https://api.github.com/repos/blg-andreasbraun/Operations/languages","stargazers_url":"https://api.github.com/repos/blg-andreasbraun/Operations/stargazers","contributors_url":"https://api.github.com/repos/blg-andreasbraun/Operations/contributors","subscribers_url":"https://api.github.com/repos/blg-andreasbraun/Operations/subscribers","subscription_url":"https://api.github.com/repos/blg-andreasbraun/Operations/subscription","commits_url":"https://api.github.com/repos/blg-andreasbraun/Operations/commits{/sha}","git_commits_url":"https://api.github.com/repos/blg-andreasbraun/Operations/git/commits{/sha}","comments_url":"https://api.github.com/repos/blg-andreasbraun/Operations/comments{/number}","issue_comment_url":"https://api.github.com/repos/blg-andreasbraun/Operations/issues/comments{/number}","contents_url":"https://api.github.com/repos/blg-andreasbraun/Operations/contents/{+path}","compare_url":"https://api.github.com/repos/blg-andreasbraun/Operations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blg-andreasbraun/Operations/merges","archive_url":"https://api.github.com/repos/blg-andreasbraun/Operations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blg-andreasbraun/Operations/downloads","issues_url":"https://api.github.com/repos/blg-andreasbraun/Operations/issues{/number}","pulls_url":"https://api.github.com/repos/blg-andreasbraun/Operations/pulls{/number}","milestones_url":"https://api.github.com/repos/blg-andreasbraun/Operations/milestones{/number}","notifications_url":"https://api.github.com/repos/blg-andreasbraun/Operations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blg-andreasbraun/Operations/labels{/name}","releases_url":"https://api.github.com/repos/blg-andreasbraun/Operations/releases{/id}","deployments_url":"https://api.github.com/repos/blg-andreasbraun/Operations/deployments","created_at":"2016-05-10T21:58:25Z","updated_at":"2016-05-10T21:58:26Z","pushed_at":"2016-05-14T20:02:54Z","git_url":"git://github.com/blg-andreasbraun/Operations.git","ssh_url":"git@github.com:blg-andreasbraun/Operations.git","clone_url":"https://github.com/blg-andreasbraun/Operations.git","svn_url":"https://github.com/blg-andreasbraun/Operations","homepage":"","size":3580,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"danthorpe:development","ref":"development","sha":"6597203fa44d69e8d782ee9c5ff460540938047f","user":{"login":"danthorpe","id":309420,"avatar_url":"https://avatars.githubusercontent.com/u/309420?v=3","gravatar_id":"","url":"https://api.github.com/users/danthorpe","html_url":"https://github.com/danthorpe","followers_url":"https://api.github.com/users/danthorpe/followers","following_url":"https://api.github.com/users/danthorpe/following{/other_user}","gists_url":"https://api.github.com/users/danthorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/danthorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danthorpe/subscriptions","organizations_url":"https://api.github.com/users/danthorpe/orgs","repos_url":"https://api.github.com/users/danthorpe/repos","events_url":"https://api.github.com/users/danthorpe/events{/privacy}","received_events_url":"https://api.github.com/users/danthorpe/received_events","type":"User","site_admin":false},"repo":{"id":38116404,"name":"Operations","full_name":"danthorpe/Operations","owner":{"login":"danthorpe","id":309420,"avatar_url":"https://avatars.githubusercontent.com/u/309420?v=3","gravatar_id":"","url":"https://api.github.com/users/danthorpe","html_url":"https://github.com/danthorpe","followers_url":"https://api.github.com/users/danthorpe/followers","following_url":"https://api.github.com/users/danthorpe/following{/other_user}","gists_url":"https://api.github.com/users/danthorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/danthorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danthorpe/subscriptions","organizations_url":"https://api.github.com/users/danthorpe/orgs","repos_url":"https://api.github.com/users/danthorpe/repos","events_url":"https://api.github.com/users/danthorpe/events{/privacy}","received_events_url":"https://api.github.com/users/danthorpe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danthorpe/Operations","description":"A Swift framework inspired by WWDC 2015 Advanced NSOperations session.","fork":false,"url":"https://api.github.com/repos/danthorpe/Operations","forks_url":"https://api.github.com/repos/danthorpe/Operations/forks","keys_url":"https://api.github.com/repos/danthorpe/Operations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danthorpe/Operations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danthorpe/Operations/teams","hooks_url":"https://api.github.com/repos/danthorpe/Operations/hooks","issue_events_url":"https://api.github.com/repos/danthorpe/Operations/issues/events{/number}","events_url":"https://api.github.com/repos/danthorpe/Operations/events","assignees_url":"https://api.github.com/repos/danthorpe/Operations/assignees{/user}","branches_url":"https://api.github.com/repos/danthorpe/Operations/branches{/branch}","tags_url":"https://api.github.com/repos/danthorpe/Operations/tags","blobs_url":"https://api.github.com/repos/danthorpe/Operations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danthorpe/Operations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danthorpe/Operations/git/refs{/sha}","trees_url":"https://api.github.com/repos/danthorpe/Operations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danthorpe/Operations/statuses/{sha}","languages_url":"https://api.github.com/repos/danthorpe/Operations/languages","stargazers_url":"https://api.github.com/repos/danthorpe/Operations/stargazers","contributors_url":"https://api.github.com/repos/danthorpe/Operations/contributors","subscribers_url":"https://api.github.com/repos/danthorpe/Operations/subscribers","subscription_url":"https://api.github.com/repos/danthorpe/Operations/subscription","commits_url":"https://api.github.com/repos/danthorpe/Operations/commits{/sha}","git_commits_url":"https://api.github.com/repos/danthorpe/Operations/git/commits{/sha}","comments_url":"https://api.github.com/repos/danthorpe/Operations/comments{/number}","issue_comment_url":"https://api.github.com/repos/danthorpe/Operations/issues/comments{/number}","contents_url":"https://api.github.com/repos/danthorpe/Operations/contents/{+path}","compare_url":"https://api.github.com/repos/danthorpe/Operations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danthorpe/Operations/merges","archive_url":"https://api.github.com/repos/danthorpe/Operations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danthorpe/Operations/downloads","issues_url":"https://api.github.com/repos/danthorpe/Operations/issues{/number}","pulls_url":"https://api.github.com/repos/danthorpe/Operations/pulls{/number}","milestones_url":"https://api.github.com/repos/danthorpe/Operations/milestones{/number}","notifications_url":"https://api.github.com/repos/danthorpe/Operations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danthorpe/Operations/labels{/name}","releases_url":"https://api.github.com/repos/danthorpe/Operations/releases{/id}","deployments_url":"https://api.github.com/repos/danthorpe/Operations/deployments","created_at":"2015-06-26T14:44:38Z","updated_at":"2016-05-14T18:18:35Z","pushed_at":"2016-05-14T20:04:02Z","git_url":"git://github.com/danthorpe/Operations.git","ssh_url":"git@github.com:danthorpe/Operations.git","clone_url":"https://github.com/danthorpe/Operations.git","svn_url":"https://github.com/danthorpe/Operations","homepage":"","size":3802,"stargazers_count":241,"watchers_count":241,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":15,"forks":42,"open_issues":15,"watchers":241,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/danthorpe/Operations/pulls/317"},"html":{"href":"https://github.com/danthorpe/Operations/pull/317"},"issue":{"href":"https://api.github.com/repos/danthorpe/Operations/issues/317"},"comments":{"href":"https://api.github.com/repos/danthorpe/Operations/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/danthorpe/Operations/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/danthorpe/Operations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danthorpe/Operations/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/danthorpe/Operations/statuses/a2a20d83d93bd8c7b9f51f27e7ab824f0d92f6f1"}}}}