{"push_id":1137703451,"size":16,"distinct_size":16,"ref":"refs/heads/master","head":"48794eaa6218a12d16ea787bb47458ff84946d30","before":"e82c95915bdd77a36b2d22e5798d0e098ba84d52","commits":[{"sha":"f3f330072aa7263561cb11bb080033a277c6cd8c","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Split parsing function in two\n\nThe old function both opened the file and parsed it. That was very hard\nto run tests on. Now I've split this into two functions, one to open\nand the other to parse so that the parsing can be tested.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/f3f330072aa7263561cb11bb080033a277c6cd8c"},{"sha":"ca6a8d45783ee8c39cb663e286435311d18ba20d","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Clean up song parsing\n\n - Now that I've split the parsing function in two, this file needed to\n   incorporate that change.\n\n - The whole song loading process was verbose and could be simplified\n   to what is in this commit.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/ca6a8d45783ee8c39cb663e286435311d18ba20d"},{"sha":"26e90c666ec7cfe04248758730fc94c480ae2f95","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Test section names\n\nThrow an error when sections names are not recognized. I had attempted\nthis before, but this implementation is much cleaner.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/26e90c666ec7cfe04248758730fc94c480ae2f95"},{"sha":"5847bbb560adfe37be59b893a49e79281527f49a","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Simplify section names\n\nI think that the name \"notes\" can be used for all text (as opposed to\nmusic content).","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/5847bbb560adfe37be59b893a49e79281527f49a"},{"sha":"f59cfe18007bd7ee873947e6bb79f6a41a1cf4ee","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Improve how metadata definitions are recognized\n\n - The issue here is that chords are defined with brackets and lists in\n   the header section are also defined with brackets.\n\n - As it was, the line changed in this commit only allowed the \"genres\"\n   variable of the header section to have a list. I would like to allow\n   this for other header variables as well.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/f59cfe18007bd7ee873947e6bb79f6a41a1cf4ee"},{"sha":"eecf2a08a3b83d3e4002097852ff8a22e036f218","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Test for unmatched brackets in content\n\nBefore, songs with unmatched brackets would not throw errors.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/eecf2a08a3b83d3e4002097852ff8a22e036f218"},{"sha":"7005cdf057d7662c0295a41ac11e560673c32fdc","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Check for errors in the header\n\nTwo types of errors had gone undetected in headers:\n\n - Missing equals signs\n\n - Incorrect type defintion\n\nTese are now both detected.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/7005cdf057d7662c0295a41ac11e560673c32fdc"},{"sha":"a032d509e71cee19957d9b995f4cf4a5d5ca3d66","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Improve style","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/a032d509e71cee19957d9b995f4cf4a5d5ca3d66"},{"sha":"283c6adc405c4ee0573d666b32a24db7a54625d3","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Add functions for parsing notes and chords\n\nPreviously the chord parsing was actually handled by the \"display.py\"\nscript. It makes more sense to me to have the parsing done separately\nfrom the formatting (display), since this will allow for the detection\nor errors in the song before any formatting takes place. These new\nfunctions will replace the original display functions, but are not\nquite complete yet. Here they are built and tested but not yet\nincorporated.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/283c6adc405c4ee0573d666b32a24db7a54625d3"},{"sha":"4b8f95b1850ff2750146fdcbbf8e8116c2e99a1f","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Parse chord quality\n\nBefore all chord qualities were accepted. Now only valid chord\nqualities are accepted. Also, what was previously considered a quality\nhas been subdivided into \"quality\", \"interval\", and \"add\".","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/4b8f95b1850ff2750146fdcbbf8e8116c2e99a1f"},{"sha":"cd72d73d3855a8410210605d046974e716e531e9","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Use new chord parsing\n\nThe function parse_chord() was not used in file parsing. Now it is. The\ndisplay function now needs to be updated so that these newly formatted\nchords will be displayed correctly.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/cd72d73d3855a8410210605d046974e716e531e9"},{"sha":"e83ee8c126baeb477f5a95711b5f186442b04e57","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Correct typo\n\nWhat was written as an interval was meant as a length.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/e83ee8c126baeb477f5a95711b5f186442b04e57"},{"sha":"5abc07979bfad4b76f4d225bb6799a095494470e","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Incorporate new chord parsing and display\n\nAfter working out the note and chord parsing, it was time to bring that\ninto production. With this commit, the processing shifts. Before chords\nwere parsed during the display process. Now files are parsed entirely\nin one go: chords are split from lyrics, and chords are split into\nconstituent parts (root, quality, etc). The benefit of this is that\nall parsing is done at once and all errors can be caught at the same\ntime. Then, in the display process, the information is simply formatted.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/5abc07979bfad4b76f4d225bb6799a095494470e"},{"sha":"7137068abe7693d98bd4a8482f495c535ae71b75","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Clean up","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/7137068abe7693d98bd4a8482f495c535ae71b75"},{"sha":"725ea25b3652dfaca57141b14c6af5a4cb1eb9ef","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Add icons","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/725ea25b3652dfaca57141b14c6af5a4cb1eb9ef"},{"sha":"48794eaa6218a12d16ea787bb47458ff84946d30","author":{"name":"Jason Reeder","email":"616e881177e53541ea47e5917a60deb2554e079d@jasonreeder.com"},"message":"Test if all songs can be successfully parsed\n\nAll of the previous tests check fake data. This one is the first to look\nthrough the real songs in production and make sure that they pass all\ntests.","distinct":true,"url":"https://api.github.com/repos/jlreeder/whsongbook/commits/48794eaa6218a12d16ea787bb47458ff84946d30"}]}
{"actor":{"display_login":"jlreeder"}}