{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/comments/61755362","id":61755362,"diff_hunk":"@@ -0,0 +1,357 @@\n+{\n+  \"version\": \"1.0.0-beta.4\",\n+  \"runs\": [\n+    {\n+      \"tool\": {\n+        \"name\": \"FxCop\"\n+      },\n+      \"files\": {\n+        \"file:///C:/Users/user/Documents/Visual Studio 2015/Projects/WpfApplication5/WpfApplication5/bin/Debug/WpfApplication5.exe\": [\n+          {\n+            \"mimeType\": \"application/octet-stream\"\n+          }\n+        ],\n+        \"file:///c:/users/user/documents/visual studio 2015/Projects/WpfApplication5/WpfApplication5/Foo.cs\": [\n+          {\n+            \"mimeType\": \"text/x-csharp\"\n+          }\n+        ]\n+      },\n+      \"logicalLocations\": {\n+        \"WpfApplication5\": [\n+          {\n+            \"name\": \"WpfApplication5\",\n+            \"kind\": \"namespace\"\n+          }\n+        ],\n+        \"wpfapplication5.exe\": [\n+          {\n+            \"name\": \"wpfapplication5.exe\",\n+            \"kind\": \"module\"\n+          }\n+        ],\n+        \"WpfApplication5.Foo\": [\n+          {\n+            \"name\": \"wpfapplication5.exe\",\n+            \"kind\": \"module\"\n+          },\n+          {\n+            \"name\": \"WpfApplication5\",\n+            \"kind\": \"namespace\"\n+          },\n+          {\n+            \"name\": \"Foo\",\n+            \"kind\": \"type\"\n+          }\n+        ],\n+        \"WpfApplication5.Foo.Baz()\": [\n+          {\n+            \"name\": \"wpfapplication5.exe\",\n+            \"kind\": \"module\"\n+          },\n+          {\n+            \"name\": \"WpfApplication5\",\n+            \"kind\": \"namespace\"\n+          },\n+          {\n+            \"name\": \"Foo\",\n+            \"kind\": \"type\"\n+          },\n+          {\n+            \"name\": \"#Baz()\",\n+            \"kind\": \"member\"\n+          }\n+        ],\n+        \"WpfApplication5.MainWindow.System.Windows.Markup.IComponentConnector.Connect(System.Int32,System.Object)\": [\n+          {\n+            \"name\": \"wpfapplication5.exe\",\n+            \"kind\": \"module\"\n+          },\n+          {\n+            \"name\": \"WpfApplication5\",\n+            \"kind\": \"namespace\"\n+          },\n+          {\n+            \"name\": \"MainWindow\",\n+            \"kind\": \"type\"\n+          },\n+          {\n+            \"name\": \"#System.Windows.Markup.IComponentConnector.Connect(System.Int32,System.Object)\",\n+            \"kind\": \"member\"\n+          }\n+        ],\n+        \"WpfApplication5.Properties.Resources\": [\n+          {\n+            \"name\": \"wpfapplication5.exe\",\n+            \"kind\": \"module\"\n+          },\n+          {\n+            \"name\": \"WpfApplication5.Properties\",\n+            \"kind\": \"namespace\"\n+          },\n+          {\n+            \"name\": \"Resources\",\n+            \"kind\": \"type\"\n+          }\n+        ],\n+        \"WpfApplication5.Properties.Resources..ctor()\": [\n+          {\n+            \"name\": \"wpfapplication5.exe\",\n+            \"kind\": \"module\"\n+          },\n+          {\n+            \"name\": \"WpfApplication5.Properties\",","path":"src/Sarif.FunctionalTests/ConverterTestData/FxCop/FxCopReportAllMessageStates.xml.sarif","position":89,"original_position":103,"commit_id":"f74e855dab37f704c58fc30ccc1f4a6a1102a11d","original_commit_id":"f74e855dab37f704c58fc30ccc1f4a6a1102a11d","user":{"login":"lgolding","id":11762653,"avatar_url":"https://avatars.githubusercontent.com/u/11762653?v=3","gravatar_id":"","url":"https://api.github.com/users/lgolding","html_url":"https://github.com/lgolding","followers_url":"https://api.github.com/users/lgolding/followers","following_url":"https://api.github.com/users/lgolding/following{/other_user}","gists_url":"https://api.github.com/users/lgolding/gists{/gist_id}","starred_url":"https://api.github.com/users/lgolding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgolding/subscriptions","organizations_url":"https://api.github.com/users/lgolding/orgs","repos_url":"https://api.github.com/users/lgolding/repos","events_url":"https://api.github.com/users/lgolding/events{/privacy}","received_events_url":"https://api.github.com/users/lgolding/received_events","type":"User","site_admin":false},"body":"Should this be two namespaces?\r\n\r\n```json\r\n{\r\n  \"name\": \"WpfApplication5\",\r\n  \"kind\": \"namespace\"\r\n},\r\n{\r\n  \"name\": \"Properties\",\r\n  \"kind\": \"namespace\"\r\n}\r\n```\r\n\r\nIf we specify that namespace components should be separated, then we can can ask the question \"How many issues are in namespace N _and all of its sub-namespaces_\", without having to parse a compound name. If we specify that namespace components should be combined (as you did here), then we can ask the question \"How many issues are in namespace N, _excluding its sub-namespaces_\", without having to examine the next logical location component to ensure that it isn't a namespace.\r\n\r\nSo the questions are:\r\n\r\n1. Which is the more useful question to be able to ask easily?\r\n2. If there's no clear answer to (1), do we give producers the choice of whether to separate or combine the components?","created_at":"2016-05-02T15:34:36Z","updated_at":"2016-05-02T15:34:37Z","html_url":"https://github.com/Microsoft/sarif-sdk/pull/227#discussion_r61755362","pull_request_url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/comments/61755362"},"html":{"href":"https://github.com/Microsoft/sarif-sdk/pull/227#discussion_r61755362"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227","id":68301988,"html_url":"https://github.com/Microsoft/sarif-sdk/pull/227","diff_url":"https://github.com/Microsoft/sarif-sdk/pull/227.diff","patch_url":"https://github.com/Microsoft/sarif-sdk/pull/227.patch","issue_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/227","number":227,"state":"open","locked":false,"title":"Change isSuppressedInSource to an enum to better support for 'unknown…","user":{"login":"michaelcfanning","id":13526455,"avatar_url":"https://avatars.githubusercontent.com/u/13526455?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelcfanning","html_url":"https://github.com/michaelcfanning","followers_url":"https://api.github.com/users/michaelcfanning/followers","following_url":"https://api.github.com/users/michaelcfanning/following{/other_user}","gists_url":"https://api.github.com/users/michaelcfanning/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcfanning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcfanning/subscriptions","organizations_url":"https://api.github.com/users/michaelcfanning/orgs","repos_url":"https://api.github.com/users/michaelcfanning/repos","events_url":"https://api.github.com/users/michaelcfanning/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcfanning/received_events","type":"User","site_admin":false},"body":"…' condition (when in-source suppression details aren't available).\r\n\r\n@lgolding @rtaket ","created_at":"2016-04-28T22:39:27Z","updated_at":"2016-05-02T15:34:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fc4845d28e1a5328c94add7402d0e83320fc533","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227/commits","review_comments_url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227/comments","review_comment_url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/227/comments","statuses_url":"https://api.github.com/repos/Microsoft/sarif-sdk/statuses/f74e855dab37f704c58fc30ccc1f4a6a1102a11d","head":{"label":"Microsoft:suppressed","ref":"suppressed","sha":"f74e855dab37f704c58fc30ccc1f4a6a1102a11d","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45640472,"name":"sarif-sdk","full_name":"Microsoft/sarif-sdk","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sarif-sdk","description":".NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/sarif-standard/sarif-spec)","fork":false,"url":"https://api.github.com/repos/Microsoft/sarif-sdk","forks_url":"https://api.github.com/repos/Microsoft/sarif-sdk/forks","keys_url":"https://api.github.com/repos/Microsoft/sarif-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sarif-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sarif-sdk/teams","hooks_url":"https://api.github.com/repos/Microsoft/sarif-sdk/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sarif-sdk/events","assignees_url":"https://api.github.com/repos/Microsoft/sarif-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sarif-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sarif-sdk/tags","blobs_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sarif-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sarif-sdk/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sarif-sdk/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sarif-sdk/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sarif-sdk/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sarif-sdk/subscription","commits_url":"https://api.github.com/repos/Microsoft/sarif-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sarif-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sarif-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sarif-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sarif-sdk/merges","archive_url":"https://api.github.com/repos/Microsoft/sarif-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sarif-sdk/downloads","issues_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sarif-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sarif-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sarif-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sarif-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sarif-sdk/deployments","created_at":"2015-11-05T21:26:46Z","updated_at":"2016-04-08T02:49:15Z","pushed_at":"2016-05-02T14:48:21Z","git_url":"git://github.com/Microsoft/sarif-sdk.git","ssh_url":"git@github.com:Microsoft/sarif-sdk.git","clone_url":"https://github.com/Microsoft/sarif-sdk.git","svn_url":"https://github.com/Microsoft/sarif-sdk","homepage":"","size":18027,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":50,"forks":7,"open_issues":50,"watchers":4,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"46f2efc230fd4414735d58e719183db245673da1","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":45640472,"name":"sarif-sdk","full_name":"Microsoft/sarif-sdk","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/sarif-sdk","description":".NET code and supporting files for working with the 'Static Analysis Results Interchange Format' (SARIF, see https://github.com/sarif-standard/sarif-spec)","fork":false,"url":"https://api.github.com/repos/Microsoft/sarif-sdk","forks_url":"https://api.github.com/repos/Microsoft/sarif-sdk/forks","keys_url":"https://api.github.com/repos/Microsoft/sarif-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/sarif-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/sarif-sdk/teams","hooks_url":"https://api.github.com/repos/Microsoft/sarif-sdk/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/sarif-sdk/events","assignees_url":"https://api.github.com/repos/Microsoft/sarif-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/sarif-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/sarif-sdk/tags","blobs_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/sarif-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/sarif-sdk/languages","stargazers_url":"https://api.github.com/repos/Microsoft/sarif-sdk/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/sarif-sdk/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/sarif-sdk/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/sarif-sdk/subscription","commits_url":"https://api.github.com/repos/Microsoft/sarif-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/sarif-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/sarif-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/sarif-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/sarif-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/sarif-sdk/merges","archive_url":"https://api.github.com/repos/Microsoft/sarif-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/sarif-sdk/downloads","issues_url":"https://api.github.com/repos/Microsoft/sarif-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/sarif-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/sarif-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/sarif-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/sarif-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/sarif-sdk/deployments","created_at":"2015-11-05T21:26:46Z","updated_at":"2016-04-08T02:49:15Z","pushed_at":"2016-05-02T14:48:21Z","git_url":"git://github.com/Microsoft/sarif-sdk.git","ssh_url":"git@github.com:Microsoft/sarif-sdk.git","clone_url":"https://github.com/Microsoft/sarif-sdk.git","svn_url":"https://github.com/Microsoft/sarif-sdk","homepage":"","size":18027,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":50,"forks":7,"open_issues":50,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227"},"html":{"href":"https://github.com/Microsoft/sarif-sdk/pull/227"},"issue":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/227"},"comments":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/sarif-sdk/statuses/f74e855dab37f704c58fc30ccc1f4a6a1102a11d"}}}}