{"action":"created","issue":{"url":"https://api.github.com/repos/koajs/koa-redis/issues/13","labels_url":"https://api.github.com/repos/koajs/koa-redis/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/koajs/koa-redis/issues/13/comments","events_url":"https://api.github.com/repos/koajs/koa-redis/issues/13/events","html_url":"https://github.com/koajs/koa-redis/pull/13","id":125520134,"number":13,"title":"Add complete support for new redis, fix tests and coverage","user":{"login":"DaAwesomeP","id":4472083,"avatar_url":"https://avatars.githubusercontent.com/u/4472083?v=3","gravatar_id":"","url":"https://api.github.com/users/DaAwesomeP","html_url":"https://github.com/DaAwesomeP","followers_url":"https://api.github.com/users/DaAwesomeP/followers","following_url":"https://api.github.com/users/DaAwesomeP/following{/other_user}","gists_url":"https://api.github.com/users/DaAwesomeP/gists{/gist_id}","starred_url":"https://api.github.com/users/DaAwesomeP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaAwesomeP/subscriptions","organizations_url":"https://api.github.com/users/DaAwesomeP/orgs","repos_url":"https://api.github.com/users/DaAwesomeP/repos","events_url":"https://api.github.com/users/DaAwesomeP/events{/privacy}","received_events_url":"https://api.github.com/users/DaAwesomeP/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-08T01:06:13Z","updated_at":"2016-01-09T13:01:40Z","closed_at":"2016-01-09T11:57:30Z","pull_request":{"url":"https://api.github.com/repos/koajs/koa-redis/pulls/13","html_url":"https://github.com/koajs/koa-redis/pull/13","diff_url":"https://github.com/koajs/koa-redis/pull/13.diff","patch_url":"https://github.com/koajs/koa-redis/pull/13.patch"},"body":"This pull:\r\n - New tests, 100% coverage (if you enable Coveralls)\r\n - Update to new `node_redis` version\r\n - Update other dependencies, remove `supertest` and `blanket`\r\n - Add support for all options in `node_redis` while keeping backward compatibility\r\n - Add support for the `duplicate` option\r\n - Add support for `quit()` and `end()` from the object\r\n - Add lots of details in docs (README)\r\n - Adds `hiredis` as an optional dependency (faster parser). Because it is optional, if it fails to build it will not cause any harm (it will use the JS parser as it was before). This is why Travis now has GCC.\r\n\r\n@dead-horse I did not update the benchmarks, which most certainly have changed. It would also be nice if you could release a new version `v1.1.0` with this. This is backwards compatible with previous versions (see [lines 41-42](https://github.com/DaAwesomeP/koa-redis/blob/32a120f6886b9a5ae6661932c5e7a2d13cb04434/index.js#L41-L42), [71](https://github.com/DaAwesomeP/koa-redis/blob/32a120f6886b9a5ae6661932c5e7a2d13cb04434/index.js#L71)) despite the new way that options are passed to `node_redis`.\r\n\r\nThis squashes #12 (sorry @JacksonTian)."},"comment":{"url":"https://api.github.com/repos/koajs/koa-redis/issues/comments/170238307","html_url":"https://github.com/koajs/koa-redis/pull/13#issuecomment-170238307","issue_url":"https://api.github.com/repos/koajs/koa-redis/issues/13","id":170238307,"user":{"login":"DaAwesomeP","id":4472083,"avatar_url":"https://avatars.githubusercontent.com/u/4472083?v=3","gravatar_id":"","url":"https://api.github.com/users/DaAwesomeP","html_url":"https://github.com/DaAwesomeP","followers_url":"https://api.github.com/users/DaAwesomeP/followers","following_url":"https://api.github.com/users/DaAwesomeP/following{/other_user}","gists_url":"https://api.github.com/users/DaAwesomeP/gists{/gist_id}","starred_url":"https://api.github.com/users/DaAwesomeP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaAwesomeP/subscriptions","organizations_url":"https://api.github.com/users/DaAwesomeP/orgs","repos_url":"https://api.github.com/users/DaAwesomeP/repos","events_url":"https://api.github.com/users/DaAwesomeP/events{/privacy}","received_events_url":"https://api.github.com/users/DaAwesomeP/received_events","type":"User","site_admin":false},"created_at":"2016-01-09T13:01:40Z","updated_at":"2016-01-09T13:01:40Z","body":"It's the same: `daawesomep`. Wow. Thank you so much."}}