{"action":"created","comment":{"url":"https://api.github.com/repos/google/blockly/pulls/comments/65636486","id":65636486,"diff_hunk":"@@ -149,12 +149,7 @@ Blockly.Dart.scrubNakedValue = function(line) {\n  * @private\n  */\n Blockly.Dart.quote_ = function(string) {\n-  // TODO: This is a quick hack.  Replace with goog.string.quote\n-  string = string.replace(/\\\\/g, '\\\\\\\\')\n-                 .replace(/\\n/g, '\\\\\\n')\n-                 .replace(/\\$/g, '\\\\$')","path":"generators/dart.js","position":7,"original_position":7,"commit_id":"46f21c0976be9daff32cf93b402bc740bda6c27d","original_commit_id":"46f21c0976be9daff32cf93b402bc740bda6c27d","user":{"login":"NeilFraser","id":250480,"avatar_url":"https://avatars.githubusercontent.com/u/250480?v=3","gravatar_id":"","url":"https://api.github.com/users/NeilFraser","html_url":"https://github.com/NeilFraser","followers_url":"https://api.github.com/users/NeilFraser/followers","following_url":"https://api.github.com/users/NeilFraser/following{/other_user}","gists_url":"https://api.github.com/users/NeilFraser/gists{/gist_id}","starred_url":"https://api.github.com/users/NeilFraser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NeilFraser/subscriptions","organizations_url":"https://api.github.com/users/NeilFraser/orgs","repos_url":"https://api.github.com/users/NeilFraser/repos","events_url":"https://api.github.com/users/NeilFraser/events{/privacy}","received_events_url":"https://api.github.com/users/NeilFraser/received_events","type":"User","site_admin":false},"body":"goog.string.quote does not escape $ (needed for Dart strings).","created_at":"2016-06-02T23:29:33Z","updated_at":"2016-06-02T23:29:33Z","html_url":"https://github.com/google/blockly/pull/394#discussion_r65636486","pull_request_url":"https://api.github.com/repos/google/blockly/pulls/394","_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/comments/65636486"},"html":{"href":"https://github.com/google/blockly/pull/394#discussion_r65636486"},"pull_request":{"href":"https://api.github.com/repos/google/blockly/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/394","id":72274380,"html_url":"https://github.com/google/blockly/pull/394","diff_url":"https://github.com/google/blockly/pull/394.diff","patch_url":"https://github.com/google/blockly/pull/394.patch","issue_url":"https://api.github.com/repos/google/blockly/issues/394","number":394,"state":"open","locked":false,"title":"Quotes properly using goog.string.quote instead of the hacky regex","user":{"login":"Goom11","id":2553377,"avatar_url":"https://avatars.githubusercontent.com/u/2553377?v=3","gravatar_id":"","url":"https://api.github.com/users/Goom11","html_url":"https://github.com/Goom11","followers_url":"https://api.github.com/users/Goom11/followers","following_url":"https://api.github.com/users/Goom11/following{/other_user}","gists_url":"https://api.github.com/users/Goom11/gists{/gist_id}","starred_url":"https://api.github.com/users/Goom11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Goom11/subscriptions","organizations_url":"https://api.github.com/users/Goom11/orgs","repos_url":"https://api.github.com/users/Goom11/repos","events_url":"https://api.github.com/users/Goom11/events{/privacy}","received_events_url":"https://api.github.com/users/Goom11/received_events","type":"User","site_admin":false},"body":"This will make it easier for whomever implements multi-line string blocks in the future.","created_at":"2016-06-02T00:41:53Z","updated_at":"2016-06-02T23:29:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d241d4d666a709671ffdc7f523c1f572ff699f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/blockly/pulls/394/commits","review_comments_url":"https://api.github.com/repos/google/blockly/pulls/394/comments","review_comment_url":"https://api.github.com/repos/google/blockly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/blockly/issues/394/comments","statuses_url":"https://api.github.com/repos/google/blockly/statuses/46f21c0976be9daff32cf93b402bc740bda6c27d","head":{"label":"Goom11:quoteFix","ref":"quoteFix","sha":"46f21c0976be9daff32cf93b402bc740bda6c27d","user":{"login":"Goom11","id":2553377,"avatar_url":"https://avatars.githubusercontent.com/u/2553377?v=3","gravatar_id":"","url":"https://api.github.com/users/Goom11","html_url":"https://github.com/Goom11","followers_url":"https://api.github.com/users/Goom11/followers","following_url":"https://api.github.com/users/Goom11/following{/other_user}","gists_url":"https://api.github.com/users/Goom11/gists{/gist_id}","starred_url":"https://api.github.com/users/Goom11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Goom11/subscriptions","organizations_url":"https://api.github.com/users/Goom11/orgs","repos_url":"https://api.github.com/users/Goom11/repos","events_url":"https://api.github.com/users/Goom11/events{/privacy}","received_events_url":"https://api.github.com/users/Goom11/received_events","type":"User","site_admin":false},"repo":{"id":60052783,"name":"blockly","full_name":"Goom11/blockly","owner":{"login":"Goom11","id":2553377,"avatar_url":"https://avatars.githubusercontent.com/u/2553377?v=3","gravatar_id":"","url":"https://api.github.com/users/Goom11","html_url":"https://github.com/Goom11","followers_url":"https://api.github.com/users/Goom11/followers","following_url":"https://api.github.com/users/Goom11/following{/other_user}","gists_url":"https://api.github.com/users/Goom11/gists{/gist_id}","starred_url":"https://api.github.com/users/Goom11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Goom11/subscriptions","organizations_url":"https://api.github.com/users/Goom11/orgs","repos_url":"https://api.github.com/users/Goom11/repos","events_url":"https://api.github.com/users/Goom11/events{/privacy}","received_events_url":"https://api.github.com/users/Goom11/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Goom11/blockly","description":"The web-based visual programming editor.","fork":true,"url":"https://api.github.com/repos/Goom11/blockly","forks_url":"https://api.github.com/repos/Goom11/blockly/forks","keys_url":"https://api.github.com/repos/Goom11/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Goom11/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Goom11/blockly/teams","hooks_url":"https://api.github.com/repos/Goom11/blockly/hooks","issue_events_url":"https://api.github.com/repos/Goom11/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/Goom11/blockly/events","assignees_url":"https://api.github.com/repos/Goom11/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/Goom11/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/Goom11/blockly/tags","blobs_url":"https://api.github.com/repos/Goom11/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Goom11/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Goom11/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Goom11/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Goom11/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/Goom11/blockly/languages","stargazers_url":"https://api.github.com/repos/Goom11/blockly/stargazers","contributors_url":"https://api.github.com/repos/Goom11/blockly/contributors","subscribers_url":"https://api.github.com/repos/Goom11/blockly/subscribers","subscription_url":"https://api.github.com/repos/Goom11/blockly/subscription","commits_url":"https://api.github.com/repos/Goom11/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Goom11/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Goom11/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Goom11/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Goom11/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/Goom11/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Goom11/blockly/merges","archive_url":"https://api.github.com/repos/Goom11/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Goom11/blockly/downloads","issues_url":"https://api.github.com/repos/Goom11/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/Goom11/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/Goom11/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/Goom11/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Goom11/blockly/labels{/name}","releases_url":"https://api.github.com/repos/Goom11/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/Goom11/blockly/deployments","created_at":"2016-05-31T02:37:04Z","updated_at":"2016-05-31T02:37:06Z","pushed_at":"2016-06-02T00:44:46Z","git_url":"git://github.com/Goom11/blockly.git","ssh_url":"git@github.com:Goom11/blockly.git","clone_url":"https://github.com/Goom11/blockly.git","svn_url":"https://github.com/Goom11/blockly","homepage":"https://developers.google.com/blockly/","size":69372,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"c2368107c54e1f8b50dc748cef0fd406d9a0d619","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":13872231,"name":"blockly","full_name":"google/blockly","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/blockly","description":"The web-based visual programming editor.","fork":false,"url":"https://api.github.com/repos/google/blockly","forks_url":"https://api.github.com/repos/google/blockly/forks","keys_url":"https://api.github.com/repos/google/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/blockly/teams","hooks_url":"https://api.github.com/repos/google/blockly/hooks","issue_events_url":"https://api.github.com/repos/google/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/google/blockly/events","assignees_url":"https://api.github.com/repos/google/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/google/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/google/blockly/tags","blobs_url":"https://api.github.com/repos/google/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/blockly/languages","stargazers_url":"https://api.github.com/repos/google/blockly/stargazers","contributors_url":"https://api.github.com/repos/google/blockly/contributors","subscribers_url":"https://api.github.com/repos/google/blockly/subscribers","subscription_url":"https://api.github.com/repos/google/blockly/subscription","commits_url":"https://api.github.com/repos/google/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/google/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/blockly/merges","archive_url":"https://api.github.com/repos/google/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/blockly/downloads","issues_url":"https://api.github.com/repos/google/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/google/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/blockly/labels{/name}","releases_url":"https://api.github.com/repos/google/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/google/blockly/deployments","created_at":"2013-10-25T21:13:33Z","updated_at":"2016-06-02T00:51:08Z","pushed_at":"2016-06-02T23:28:29Z","git_url":"git://github.com/google/blockly.git","ssh_url":"git@github.com:google/blockly.git","clone_url":"https://github.com/google/blockly.git","svn_url":"https://github.com/google/blockly","homepage":"https://developers.google.com/blockly/","size":103555,"stargazers_count":2348,"watchers_count":2348,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":776,"mirror_url":null,"open_issues_count":90,"forks":776,"open_issues":90,"watchers":2348,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/394"},"html":{"href":"https://github.com/google/blockly/pull/394"},"issue":{"href":"https://api.github.com/repos/google/blockly/issues/394"},"comments":{"href":"https://api.github.com/repos/google/blockly/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/google/blockly/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/google/blockly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/blockly/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/google/blockly/statuses/46f21c0976be9daff32cf93b402bc740bda6c27d"}}}}
{"actor":{"display_login":"NeilFraser"}}