{"push_id":1057160782,"size":46,"distinct_size":0,"ref":"refs/heads/review","head":"6e244c659fb004503fd2a94319dae8fa6fecf045","before":"655209b3f8adbb6233241034914812779255b7d4","commits":[{"sha":"1893b6df117baf785cc568c9b044a849de0ca046","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Simplify calls to qemuDomainSetPrivatePaths\n\nSince commit 9dca74ee6f54, the function can take driver and a vm, no\nneed to overcomplicate.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/1893b6df117baf785cc568c9b044a849de0ca046"},{"sha":"d558fb34fd0e410fdaeb993ea43ba733bfb5c528","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"qemu: Clear generated private paths\n\nThe paths have the domain ID in them.  Without cleaning them, they would\ncontain the same ID even after multiple restarts.  That could cause\nvarious problems, e.g. with access.\n\nAdd function qemuDomainClearPrivatePaths() for this as a counterpart of\nqemuDomainSetPrivatePaths().\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/d558fb34fd0e410fdaeb993ea43ba733bfb5c528"},{"sha":"3992ff14e5a5ce041cb6ba68f317101cee9e47d6","author":{"email":"c23361c43fbf79fed83e8b76173707b083d6caf5@laine.org","name":"Laine Stump"},"message":"network: new function networkGetActualType\n\nThere are times when it's necessary to learn the actual type of a\nnetwork connection before any resources have been allocated\n(e.g. during qemuProcessPrepareDomain()), but in the past it was\nnecessary to call networkAllocateActualDevice() in order to have the\nactual type filled in.\n\nThis new function returns the type of network that *will be* setup\nonce it actually happens, but without making any changes on the host.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3992ff14e5a5ce041cb6ba68f317101cee9e47d6"},{"sha":"f09c7139b0f66fe687ba9fcc823a4837979b05c1","author":{"email":"c23361c43fbf79fed83e8b76173707b083d6caf5@laine.org","name":"Laine Stump"},"message":"qemu: change args to qemuAssignDeviceHostdevAlias()\n\nIn certain cases, we need to assign a hostdevN-style alias in a case\nwhen we don't have a virDomainHostdevDefPtr (instead we have a\nvirDomainNetDefPtr). Since qemuAssignDeviceHostdevAlias() doesn't use\nanything in the virDomainHostdevDef except the alias string itself\nanyway, this patch just changes the arguments to pass a pointer to the\nalias pointer instead.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/f09c7139b0f66fe687ba9fcc823a4837979b05c1"},{"sha":"8f74f5277d33ab791ee5b94f77efbbbebe37c6b1","author":{"email":"c23361c43fbf79fed83e8b76173707b083d6caf5@laine.org","name":"Laine Stump"},"message":"qemu: fix alias name for <interface type='hostdev'>\n\nStarting with commit f8e712fe, if you start a domain that has an\n<interface type='hostdev' (or that has <interface type='network'>\nwhere the network is a pool of devices for hostdev assignment), when\nyou later try to add *another* interface (of any kind) with hotplug,\nthe function qemuAssignDeviceNetAlias() fails as soon as it sees a\n\"hostdevN\" alias in the list of interfaces), causing the attach to\nfail.\n\nThis is because (starting with f8e712fe) the device alias names are\nassigned during the new function qemuProcessPrepareDomain(), which is\ncalled *before* networkAllocateActualDevice() (which is called from\nqemuProcessPrepareHost(), which is called from\nqemuProcessLaunch()). Prior to that commit,\nnetworkAllocateActualDevice() was called first.\n\nThe problem with this is that the alias for interfaces that are really\na hostdev (<interface type='hostdev'>) is of the form \"hostdevN\" (just\nlike other hostdevs), while other interfaces are \"netN\". But if you\ndon't know that the interface is going to be a hostdev at the time you\nassign the alias name, you can't name it differently. (As far as I've\nseen so far, the change in name by itself wouldn't have been a problem\n(other than just an outwardly noticeable change in behavior) except\nfor the abovementioned failure to attach/detach new interfaces.\n\nRather than take the chance that there may be other not-yet-revealed\nproblems associated with changing the alias name, this patch changes\nthe way that aliases are assigned to restore the old behavior.\n\nOld: In the past, assigning an alias to an interface was skipped if it\nwas seen that the interface was type='hostdev' - we knew that the\nhostdev part of the interface was also in the list of hostdevs (that's\npart of what happens in networkAllocateActualDevice()) and it would be\nassigned when all the other hostdev aliases were assigned.\n\nNew: When assigning an alias to an interface, we haven't yet called\nnetworkAllocateActualDevice() to construct the hostdev part of the\ninterface, so we can't just wait for the loop that creates aliases for\nall the hostdevs (there's nothing on that list for this device\nyet!). Instead we handle it immediately in the loop creating interface\naliases, by calling the new function networkGetActualType() to\ndetermine if it is going to be hostdev, and if so calling\nqemuAssignDeviceHostdevAlias() instead.\n\nSome adjustments have to be made to both\nqemuAssignDeviceHostdevAlias() and to qemuAssignDeviceNetAlias() to\naccommodate this. In both of them, an error return from\nqemuDomainDeviceAliasIndex() is no longer considered an error; instead\nit's just ignored (because it almost certainly means that the alias\nstring for the device was \"net\" when we expected \"hostdev\" or vice\nversa). in qemuAssignDeviceHostdevAlias() we have to look at all\ninterface aliases for hostdevN in addition to looking at all hostdev\naliases (this wasn't necessary in the past, because both the interface\nentry and the hostdev entry for the device already pointed at the\ndevice info; no longer the case since the hostdev entry hasn't yet\nbeen setup).\n\nFortunately the buggy behavior hasn't yet been in any official release\nof libvirt.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/8f74f5277d33ab791ee5b94f77efbbbebe37c6b1"},{"sha":"17a94ba70fc11c21f8ea70ff92131d0868f4cde1","author":{"email":"e82f23e74d43760279ebcc505dac4ae70d5627d0@redhat.com","name":"Martin Kletzander"},"message":"nodedev: Fix parsing of generated XMLs\n\nCommit d77ffb6876 added not only reporting of the PCI header type, but\nalso parsing of that information.  However, because there was no parsing\ndone for the other sub-PCI capabilities, if there was any other\ncapability then a valid header type name (like phys_function or\nvirt_functions) the parsing would fail.  This prevented passing node\ndevice XMLs that we generated into our own functions when dealing with,\ne.g. with SRIOV cards.\n\nInstead of reworking the whole parsing, just fix this one occurence and\nremove a test for it for the time being.  Future patches will deal with\nthe rest.\n\nSigned-off-by: Martin Kletzander <mkletzan@redhat.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/17a94ba70fc11c21f8ea70ff92131d0868f4cde1"},{"sha":"344bcd89ebbe0c703716820f781ed9c089851fef","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Fix mis-merge of qemuBuildSmartcardCommandLine\n\nCommit id '858bafeb' misapplied a merge of commit id '019244751'\nto place the \"-chardev\" command after formatting the character\nbackend value.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/344bcd89ebbe0c703716820f781ed9c089851fef"},{"sha":"3281b47e47706d3d31256d92c113fe10ec8e9de9","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Fix mis-merge of qemuBuildSerialCommandLine\n\nCommit id '5ab8640' misapplied a merge of commit id '019244751'\nto place the \"-chardev\" command after formatting the character\nbackend value.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/3281b47e47706d3d31256d92c113fe10ec8e9de9"},{"sha":"6a97e35f827031daecd3258d72fa1d26a9c945e5","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Fix mis-merge of qemuBuildParallelsCommandLine\n\nCommit id '0e1e7ade' misapplied a merge of commit id '019244751'\nto place the \"-chardev\" command after formatting the character\nbackend value.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/6a97e35f827031daecd3258d72fa1d26a9c945e5"},{"sha":"48d5b3d81d06ed9b3441ddd5ad5d3f97b67a7126","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Fix mis-merge of qemuBuildChannelsCommandLine\n\nCommit id '3cdcc910' misapplied a merge of commit id '019244751'\nto place the \"-chardev\" command after formatting the character\nbackend value.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/48d5b3d81d06ed9b3441ddd5ad5d3f97b67a7126"},{"sha":"28e960b691ad239fd41b0138f3d41e295bab51d5","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Fix mis-merge of qemuBuildConsoleCommandLine\n\nCommit id 'e6944a52' misapplied a merge of commit id '019244751'\nto place the \"-chardev\" command after formatting the character\nbackend value.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/28e960b691ad239fd41b0138f3d41e295bab51d5"},{"sha":"2cc91ddd2d3043593172927e49762d3bab28f399","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"qemu: Fix mis-merge of qemuBuildRedirdevCommandLine\n\nCommit id '59e7ef3c' misapplied a merge of commit id '019244751'\nto place the \"-chardev\" command after formatting the character\nbackend value.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/2cc91ddd2d3043593172927e49762d3bab28f399"},{"sha":"0dc49e237ae547119ddd78b4bd1c89fc354a34b6","author":{"email":"87558058f6f829e5ec976c8ef960720af4ff9c7d@redhat.com","name":"John Ferlan"},"message":"network: Remove extraneous ATTRIBUTE_NONNULL\n\nCommit id '3992ff14' added the prototype for networkGetActualType\nwith 1 parameter, but added 2 ATTRIBUTE_NONNULL's (assume from a\ncut-n-paste), just remove (2).","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/0dc49e237ae547119ddd78b4bd1c89fc354a34b6"},{"sha":"2ffa69ca972a7d50f477e437261e87641b6695f0","author":{"email":"2648abdd55bfebf313fd324b464b047e6eea300e@linux.vnet.ibm.com","name":"Boris Fiuczynski"},"message":"docs: fix logfile paragraph\n\nSigned-off-by: Boris Fiuczynski <fiuczy@linux.vnet.ibm.com>","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/2ffa69ca972a7d50f477e437261e87641b6695f0"},{"sha":"0086221cb377c7a1c2df58b8ee5eb8223f989765","author":{"email":"8c3f1b821d9adf233f787f1527ecaa1537ea24a2@redhat.com","name":"Daniel Veillard"},"message":"Release of libvirt-1.3.3\n- docs/news.html.in libvirt.spec.in: update for release\n- po/*.po*: regenerated","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/0086221cb377c7a1c2df58b8ee5eb8223f989765"},{"sha":"953e52a61201efea02c4575f5862a08f6e1193eb","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"Post-release version bump to 1.3.4","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/953e52a61201efea02c4575f5862a08f6e1193eb"},{"sha":"836bf4ba7c49ef57eef4263322499cc4a0e8d2f9","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"conf: Pass the whole device info struct to virDomainDeviceBootParseXML\n\nNo need to extract the single element.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/836bf4ba7c49ef57eef4263322499cc4a0e8d2f9"},{"sha":"e0a34e76ef51c10d284482b32ca0f61559f56742","author":{"email":"2cf5c04c61aa466e4a47bfedc747d17279c72ffc@redhat.com","name":"Peter Krempa"},"message":"conf: store bootindex as unsigned int\n\nThe value is never negative thus there's no need to store it in a signed\ntype.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/e0a34e76ef51c10d284482b32ca0f61559f56742"},{"sha":"ec37cf54866e81b7b94565d1cfda46823315e98a","author":{"email":"3ada0bee826c753786fdbba72243dfba997094cf@redhat.com","name":"Andrea Bolognani"},"message":"spec: Include KVM support on RHEL 7 ppc64 and newer","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/ec37cf54866e81b7b94565d1cfda46823315e98a"},{"sha":"c0726e0708762e571a7883cb0558cfec32459669","author":{"email":"4cab11cfb98d3c937327354a78eb07dbb6ee2bc6@redhat.com","name":"Ján Tomko"},"message":"virsh: read default connection uri from env later\n\nPostpone filling out the default connection in ctl->connname\nafter calling virshInit.\n\nThis allows printing help without a connection to the daemon.","distinct":false,"url":"https://api.github.com/repos/zippy2/libvirt/commits/c0726e0708762e571a7883cb0558cfec32459669"}]}