{"action":"created","comment":{"url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/comments/51973481","id":51973481,"diff_hunk":"@@ -0,0 +1,124 @@\n+require 'rails_helper'\n+\n+RSpec.describe Piece, type: :model do\n+  describe 'is_obstructed?' do\n+    it 'should return false for no horizontal obstructions moving to the right' do","path":"spec/models/piece_spec.rb","position":5,"original_position":5,"commit_id":"ef0197779fb1df285b09e8e5cb4103def81cbffe","original_commit_id":"ef0197779fb1df285b09e8e5cb4103def81cbffe","user":{"login":"mscoutermarsh","id":155044,"avatar_url":"https://avatars.githubusercontent.com/u/155044?v=3","gravatar_id":"","url":"https://api.github.com/users/mscoutermarsh","html_url":"https://github.com/mscoutermarsh","followers_url":"https://api.github.com/users/mscoutermarsh/followers","following_url":"https://api.github.com/users/mscoutermarsh/following{/other_user}","gists_url":"https://api.github.com/users/mscoutermarsh/gists{/gist_id}","starred_url":"https://api.github.com/users/mscoutermarsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mscoutermarsh/subscriptions","organizations_url":"https://api.github.com/users/mscoutermarsh/orgs","repos_url":"https://api.github.com/users/mscoutermarsh/repos","events_url":"https://api.github.com/users/mscoutermarsh/events{/privacy}","received_events_url":"https://api.github.com/users/mscoutermarsh/received_events","type":"User","site_admin":false},"body":"I'll usually leave out `should`\r\n\r\n`it 'returns false...'` works, less typing :)","created_at":"2016-02-05T03:30:49Z","updated_at":"2016-02-05T03:30:49Z","html_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess/pull/14#discussion_r51973481","pull_request_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/comments/51973481"},"html":{"href":"https://github.com/FirehoseProjectTeamOrion/OrionChess/pull/14#discussion_r51973481"},"pull_request":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14","id":58333135,"html_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess/pull/14","diff_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess/pull/14.diff","patch_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess/pull/14.patch","issue_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/14","number":14,"state":"open","locked":false,"title":"Add is_obstructed?","user":{"login":"smlovin2","id":10968038,"avatar_url":"https://avatars.githubusercontent.com/u/10968038?v=3","gravatar_id":"","url":"https://api.github.com/users/smlovin2","html_url":"https://github.com/smlovin2","followers_url":"https://api.github.com/users/smlovin2/followers","following_url":"https://api.github.com/users/smlovin2/following{/other_user}","gists_url":"https://api.github.com/users/smlovin2/gists{/gist_id}","starred_url":"https://api.github.com/users/smlovin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlovin2/subscriptions","organizations_url":"https://api.github.com/users/smlovin2/orgs","repos_url":"https://api.github.com/users/smlovin2/repos","events_url":"https://api.github.com/users/smlovin2/events{/privacy}","received_events_url":"https://api.github.com/users/smlovin2/received_events","type":"User","site_admin":false},"body":"- Adds FactoryGirl gem and as well as a factories folder for /spec and factory files for piece, player and game\r\n- Moves rpsec gem into development and test group along with FactoryGirl\r\n- Adds a model folder to /spec and created a piece_spec.rb file in that folder\r\n- Adds a bunch of tests for the is_obstructed? method in piece model\r\n- Modifies spec/rails_helper.rb so that rspec will automatically migrate before testing if necessary\r\n- Adds .rspec file with --color so that rspec output will be colored which I feel makes it a little more user friendly :smile: \r\n- Adds the is_obstructed? method to piece model to detect if a piece's movement is obstructed when moving between two points\r\n- is_obstructed? returns true if there is piece **between** the starting and ending space and false otherwise\r\n\r\n**Notes and questions:**\r\n- I'm not sure if this it the best solution, seem like it could still be cleaned up some, may be a little overly complicated\r\n- There are still a few issues with rubocop I'm not sure what to do about:\r\n\r\n> app/models/piece.rb:12:7: C: Rename is_obstructed? to obstructed?.\r\n>   def is_obstructed?(row, column)\r\n\r\n- It wants to remove \"is\" from all the methods like is_obstructed? is that fine or do we want it to be is_obstructed for sure?\r\n\r\n> app/models/piece.rb:17:5 Use a guard clause instead of wrapping the code inside a conditional expression.\r\n>     elsif moving_diagonally?(row, column)\r\n\r\n- I'm not sure what to do with this one really\r\n\r\n> spec/factories/game_factory.rb:1:1: C: Carriage return character detected.\r\n> FactoryGirl.define do\r\n\r\n- I'm also confused on how to fix this one as well, can't figure out how to get rid of the carriage return  character","created_at":"2016-02-04T19:07:28Z","updated_at":"2016-02-05T03:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f35efc5fe6050556081957d5e3936d37eb14938","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14/commits","review_comments_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14/comments","review_comment_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/14/comments","statuses_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/statuses/ef0197779fb1df285b09e8e5cb4103def81cbffe","head":{"label":"FirehoseProjectTeamOrion:add-is-obstructed","ref":"add-is-obstructed","sha":"ef0197779fb1df285b09e8e5cb4103def81cbffe","user":{"login":"FirehoseProjectTeamOrion","id":16872996,"avatar_url":"https://avatars.githubusercontent.com/u/16872996?v=3","gravatar_id":"","url":"https://api.github.com/users/FirehoseProjectTeamOrion","html_url":"https://github.com/FirehoseProjectTeamOrion","followers_url":"https://api.github.com/users/FirehoseProjectTeamOrion/followers","following_url":"https://api.github.com/users/FirehoseProjectTeamOrion/following{/other_user}","gists_url":"https://api.github.com/users/FirehoseProjectTeamOrion/gists{/gist_id}","starred_url":"https://api.github.com/users/FirehoseProjectTeamOrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirehoseProjectTeamOrion/subscriptions","organizations_url":"https://api.github.com/users/FirehoseProjectTeamOrion/orgs","repos_url":"https://api.github.com/users/FirehoseProjectTeamOrion/repos","events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/events{/privacy}","received_events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/received_events","type":"Organization","site_admin":false},"repo":{"id":50326447,"name":"OrionChess","full_name":"FirehoseProjectTeamOrion/OrionChess","owner":{"login":"FirehoseProjectTeamOrion","id":16872996,"avatar_url":"https://avatars.githubusercontent.com/u/16872996?v=3","gravatar_id":"","url":"https://api.github.com/users/FirehoseProjectTeamOrion","html_url":"https://github.com/FirehoseProjectTeamOrion","followers_url":"https://api.github.com/users/FirehoseProjectTeamOrion/followers","following_url":"https://api.github.com/users/FirehoseProjectTeamOrion/following{/other_user}","gists_url":"https://api.github.com/users/FirehoseProjectTeamOrion/gists{/gist_id}","starred_url":"https://api.github.com/users/FirehoseProjectTeamOrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirehoseProjectTeamOrion/subscriptions","organizations_url":"https://api.github.com/users/FirehoseProjectTeamOrion/orgs","repos_url":"https://api.github.com/users/FirehoseProjectTeamOrion/repos","events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/events{/privacy}","received_events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess","description":"Agile Team project for Team Orion","fork":false,"url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess","forks_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/forks","keys_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/teams","hooks_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/hooks","issue_events_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/events{/number}","events_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/events","assignees_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/assignees{/user}","branches_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/branches{/branch}","tags_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/tags","blobs_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/statuses/{sha}","languages_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/languages","stargazers_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/stargazers","contributors_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/contributors","subscribers_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/subscribers","subscription_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/subscription","commits_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/contents/{+path}","compare_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/merges","archive_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/downloads","issues_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues{/number}","pulls_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls{/number}","milestones_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/milestones{/number}","notifications_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/labels{/name}","releases_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/releases{/id}","deployments_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/deployments","created_at":"2016-01-25T04:39:31Z","updated_at":"2016-01-25T05:18:59Z","pushed_at":"2016-02-04T19:07:29Z","git_url":"git://github.com/FirehoseProjectTeamOrion/OrionChess.git","ssh_url":"git@github.com:FirehoseProjectTeamOrion/OrionChess.git","clone_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess.git","svn_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess","homepage":"https://orionchess.herokuapp.com/","size":103,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"FirehoseProjectTeamOrion:master","ref":"master","sha":"11b61ba8d6d58dbbdb6177a3a495a7e3e678ca71","user":{"login":"FirehoseProjectTeamOrion","id":16872996,"avatar_url":"https://avatars.githubusercontent.com/u/16872996?v=3","gravatar_id":"","url":"https://api.github.com/users/FirehoseProjectTeamOrion","html_url":"https://github.com/FirehoseProjectTeamOrion","followers_url":"https://api.github.com/users/FirehoseProjectTeamOrion/followers","following_url":"https://api.github.com/users/FirehoseProjectTeamOrion/following{/other_user}","gists_url":"https://api.github.com/users/FirehoseProjectTeamOrion/gists{/gist_id}","starred_url":"https://api.github.com/users/FirehoseProjectTeamOrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirehoseProjectTeamOrion/subscriptions","organizations_url":"https://api.github.com/users/FirehoseProjectTeamOrion/orgs","repos_url":"https://api.github.com/users/FirehoseProjectTeamOrion/repos","events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/events{/privacy}","received_events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/received_events","type":"Organization","site_admin":false},"repo":{"id":50326447,"name":"OrionChess","full_name":"FirehoseProjectTeamOrion/OrionChess","owner":{"login":"FirehoseProjectTeamOrion","id":16872996,"avatar_url":"https://avatars.githubusercontent.com/u/16872996?v=3","gravatar_id":"","url":"https://api.github.com/users/FirehoseProjectTeamOrion","html_url":"https://github.com/FirehoseProjectTeamOrion","followers_url":"https://api.github.com/users/FirehoseProjectTeamOrion/followers","following_url":"https://api.github.com/users/FirehoseProjectTeamOrion/following{/other_user}","gists_url":"https://api.github.com/users/FirehoseProjectTeamOrion/gists{/gist_id}","starred_url":"https://api.github.com/users/FirehoseProjectTeamOrion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirehoseProjectTeamOrion/subscriptions","organizations_url":"https://api.github.com/users/FirehoseProjectTeamOrion/orgs","repos_url":"https://api.github.com/users/FirehoseProjectTeamOrion/repos","events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/events{/privacy}","received_events_url":"https://api.github.com/users/FirehoseProjectTeamOrion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess","description":"Agile Team project for Team Orion","fork":false,"url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess","forks_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/forks","keys_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/teams","hooks_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/hooks","issue_events_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/events{/number}","events_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/events","assignees_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/assignees{/user}","branches_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/branches{/branch}","tags_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/tags","blobs_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/refs{/sha}","trees_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/statuses/{sha}","languages_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/languages","stargazers_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/stargazers","contributors_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/contributors","subscribers_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/subscribers","subscription_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/subscription","commits_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/commits{/sha}","git_commits_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/git/commits{/sha}","comments_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/comments{/number}","issue_comment_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/comments{/number}","contents_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/contents/{+path}","compare_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/merges","archive_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/downloads","issues_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues{/number}","pulls_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls{/number}","milestones_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/milestones{/number}","notifications_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/labels{/name}","releases_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/releases{/id}","deployments_url":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/deployments","created_at":"2016-01-25T04:39:31Z","updated_at":"2016-01-25T05:18:59Z","pushed_at":"2016-02-04T19:07:29Z","git_url":"git://github.com/FirehoseProjectTeamOrion/OrionChess.git","ssh_url":"git@github.com:FirehoseProjectTeamOrion/OrionChess.git","clone_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess.git","svn_url":"https://github.com/FirehoseProjectTeamOrion/OrionChess","homepage":"https://orionchess.herokuapp.com/","size":103,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14"},"html":{"href":"https://github.com/FirehoseProjectTeamOrion/OrionChess/pull/14"},"issue":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/14"},"comments":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/FirehoseProjectTeamOrion/OrionChess/statuses/ef0197779fb1df285b09e8e5cb4103def81cbffe"}}}}