{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/69839557","id":69839557,"diff_hunk":"@@ -196,9 +196,9 @@ func WithTimeout(d time.Duration) DialOption {\n }\n \n // WithDialer returns a DialOption that specifies a function to use for dialing network addresses.\n-func WithDialer(f func(addr string, timeout time.Duration) (net.Conn, error)) DialOption {\n+func WithDialer(d net.Dialer) DialOption {","path":"clientconn.go","position":5,"original_position":5,"commit_id":"497877d020a44cfed1f3b09ceb7e5e4f61ae32a2","original_commit_id":"497877d020a44cfed1f3b09ceb7e5e4f61ae32a2","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"> You can use \"f\" to create a net.Dialer and assign to o.copts.\r\n\r\nHow?","created_at":"2016-07-07T01:27:58Z","updated_at":"2016-07-07T01:27:58Z","html_url":"https://github.com/grpc/grpc-go/pull/751#discussion_r69839557","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/751","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/69839557"},"html":{"href":"https://github.com/grpc/grpc-go/pull/751#discussion_r69839557"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/751"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/751","id":76324764,"html_url":"https://github.com/grpc/grpc-go/pull/751","diff_url":"https://github.com/grpc/grpc-go/pull/751.diff","patch_url":"https://github.com/grpc/grpc-go/pull/751.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/751","number":751,"state":"open","locked":false,"title":"cancel outgoing net.Dial when ClientConn is closed","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"body":"This sometimes manifests as a leaked goroutine when the network stack is stressed on OS X. See https://github.com/cockroachdb/cockroach/issues/7524.\r\n\r\ncc @petermattis @bdarnell ","created_at":"2016-07-05T18:58:23Z","updated_at":"2016-07-07T01:27:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe18c574d01d9f835b54fdfe9427ad892b5c3448","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/751/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/751/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/751/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/497877d020a44cfed1f3b09ceb7e5e4f61ae32a2","head":{"label":"tamird:dialer-cancel","ref":"dialer-cancel","sha":"497877d020a44cfed1f3b09ceb7e5e4f61ae32a2","user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"repo":{"id":42019024,"name":"grpc-go","full_name":"tamird/grpc-go","owner":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tamird/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/tamird/grpc-go","forks_url":"https://api.github.com/repos/tamird/grpc-go/forks","keys_url":"https://api.github.com/repos/tamird/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tamird/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tamird/grpc-go/teams","hooks_url":"https://api.github.com/repos/tamird/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/tamird/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/tamird/grpc-go/events","assignees_url":"https://api.github.com/repos/tamird/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/tamird/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/tamird/grpc-go/tags","blobs_url":"https://api.github.com/repos/tamird/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tamird/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tamird/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/tamird/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tamird/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/tamird/grpc-go/languages","stargazers_url":"https://api.github.com/repos/tamird/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/tamird/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/tamird/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/tamird/grpc-go/subscription","commits_url":"https://api.github.com/repos/tamird/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/tamird/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/tamird/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/tamird/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/tamird/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/tamird/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tamird/grpc-go/merges","archive_url":"https://api.github.com/repos/tamird/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tamird/grpc-go/downloads","issues_url":"https://api.github.com/repos/tamird/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/tamird/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/tamird/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/tamird/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tamird/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/tamird/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/tamird/grpc-go/deployments","created_at":"2015-09-06T21:12:47Z","updated_at":"2016-02-04T22:34:08Z","pushed_at":"2016-07-06T21:11:06Z","git_url":"git://github.com/tamird/grpc-go.git","ssh_url":"git@github.com:tamird/grpc-go.git","clone_url":"https://github.com/tamird/grpc-go.git","svn_url":"https://github.com/tamird/grpc-go","homepage":"","size":1990,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"daeb9cc0f2607997cce611a1458e71b981ce5986","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2016-07-06T20:02:01Z","pushed_at":"2016-07-07T00:18:42Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":2898,"stargazers_count":1921,"watchers_count":1921,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":300,"mirror_url":null,"open_issues_count":79,"forks":300,"open_issues":79,"watchers":1921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/751"},"html":{"href":"https://github.com/grpc/grpc-go/pull/751"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/751"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/751/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/751/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/751/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/497877d020a44cfed1f3b09ceb7e5e4f61ae32a2"}}}}
{"actor":{"display_login":"tamird"}}