{"action":"created","comment":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/90428127","pull_request_review_id":10944736,"id":90428127,"diff_hunk":"@@ -54,7 +54,8 @@ template <typename simple_type>\n bool serializeVectorIntoAdjacencyArray(const std::string &filename,\n                                        const std::vector<std::vector<simple_type>> &data)\n {\n-    std::ofstream out_stream(filename, std::ios::binary);\n+\tstorage::io::FileWriter file(filename, storage::io::FileWriter::HasNoFingerprint);","path":"include/util/io.hpp","position":5,"original_position":5,"commit_id":"156c13b22421d132cb24eb5a942c7a12eed52d8b","original_commit_id":"156c13b22421d132cb24eb5a942c7a12eed52d8b","user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"body":"There's a clang-format script at scripts/format.sh - once your done with changes it would be great to run this.\r\n\r\n(if you don't have clang-format we can do this for you before merging, too)","created_at":"2016-12-01T11:23:07Z","updated_at":"2016-12-01T11:23:17Z","html_url":"https://github.com/Project-OSRM/osrm-backend/pull/3383#discussion_r90428127","pull_request_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383","_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/90428127"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/3383#discussion_r90428127"},"pull_request":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383"}}},"pull_request":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383","id":95942882,"html_url":"https://github.com/Project-OSRM/osrm-backend/pull/3383","diff_url":"https://github.com/Project-OSRM/osrm-backend/pull/3383.diff","patch_url":"https://github.com/Project-OSRM/osrm-backend/pull/3383.patch","issue_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3383","number":3383,"state":"open","locked":false,"title":"(WIP) Feature/file writer","user":{"login":"duizendnegen","id":665795,"avatar_url":"https://avatars.githubusercontent.com/u/665795?v=3","gravatar_id":"","url":"https://api.github.com/users/duizendnegen","html_url":"https://github.com/duizendnegen","followers_url":"https://api.github.com/users/duizendnegen/followers","following_url":"https://api.github.com/users/duizendnegen/following{/other_user}","gists_url":"https://api.github.com/users/duizendnegen/gists{/gist_id}","starred_url":"https://api.github.com/users/duizendnegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duizendnegen/subscriptions","organizations_url":"https://api.github.com/users/duizendnegen/orgs","repos_url":"https://api.github.com/users/duizendnegen/repos","events_url":"https://api.github.com/users/duizendnegen/events{/privacy}","received_events_url":"https://api.github.com/users/duizendnegen/received_events","type":"User","site_admin":false},"body":"# Issue\r\n\r\n`FileWriter` counterpart to `FileReader` and one example implementation. \r\n\r\n## Tasklist\r\n - [ ] add regression / cucumber cases (see docs/testing.md)\r\n - [ ] review\r\n - [ ] adjust for comments\r\n\r\n## Requirements / Relations\r\n- https://github.com/Project-OSRM/osrm-backend/pull/3321 replaces all `iostream` with `FileReader` \r\n- Part of https://github.com/Project-OSRM/osrm-backend/issues/2242, the `File` abstraction","created_at":"2016-11-30T18:02:09Z","updated_at":"2016-12-01T11:23:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1243dac8316ac78b67b3f37e5a07830463469b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383/commits","review_comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383/comments","review_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3383/comments","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/156c13b22421d132cb24eb5a942c7a12eed52d8b","head":{"label":"duizendnegen:feature/file-writer","ref":"feature/file-writer","sha":"156c13b22421d132cb24eb5a942c7a12eed52d8b","user":{"login":"duizendnegen","id":665795,"avatar_url":"https://avatars.githubusercontent.com/u/665795?v=3","gravatar_id":"","url":"https://api.github.com/users/duizendnegen","html_url":"https://github.com/duizendnegen","followers_url":"https://api.github.com/users/duizendnegen/followers","following_url":"https://api.github.com/users/duizendnegen/following{/other_user}","gists_url":"https://api.github.com/users/duizendnegen/gists{/gist_id}","starred_url":"https://api.github.com/users/duizendnegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duizendnegen/subscriptions","organizations_url":"https://api.github.com/users/duizendnegen/orgs","repos_url":"https://api.github.com/users/duizendnegen/repos","events_url":"https://api.github.com/users/duizendnegen/events{/privacy}","received_events_url":"https://api.github.com/users/duizendnegen/received_events","type":"User","site_admin":false},"repo":{"id":72984074,"name":"osrm-backend","full_name":"duizendnegen/osrm-backend","owner":{"login":"duizendnegen","id":665795,"avatar_url":"https://avatars.githubusercontent.com/u/665795?v=3","gravatar_id":"","url":"https://api.github.com/users/duizendnegen","html_url":"https://github.com/duizendnegen","followers_url":"https://api.github.com/users/duizendnegen/followers","following_url":"https://api.github.com/users/duizendnegen/following{/other_user}","gists_url":"https://api.github.com/users/duizendnegen/gists{/gist_id}","starred_url":"https://api.github.com/users/duizendnegen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duizendnegen/subscriptions","organizations_url":"https://api.github.com/users/duizendnegen/orgs","repos_url":"https://api.github.com/users/duizendnegen/repos","events_url":"https://api.github.com/users/duizendnegen/events{/privacy}","received_events_url":"https://api.github.com/users/duizendnegen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duizendnegen/osrm-backend","description":"Open Source Routing Machine - C++ backend","fork":true,"url":"https://api.github.com/repos/duizendnegen/osrm-backend","forks_url":"https://api.github.com/repos/duizendnegen/osrm-backend/forks","keys_url":"https://api.github.com/repos/duizendnegen/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duizendnegen/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duizendnegen/osrm-backend/teams","hooks_url":"https://api.github.com/repos/duizendnegen/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/duizendnegen/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/duizendnegen/osrm-backend/events","assignees_url":"https://api.github.com/repos/duizendnegen/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/duizendnegen/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/duizendnegen/osrm-backend/tags","blobs_url":"https://api.github.com/repos/duizendnegen/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duizendnegen/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duizendnegen/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/duizendnegen/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duizendnegen/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/duizendnegen/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/duizendnegen/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/duizendnegen/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/duizendnegen/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/duizendnegen/osrm-backend/subscription","commits_url":"https://api.github.com/repos/duizendnegen/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/duizendnegen/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/duizendnegen/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/duizendnegen/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/duizendnegen/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/duizendnegen/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duizendnegen/osrm-backend/merges","archive_url":"https://api.github.com/repos/duizendnegen/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duizendnegen/osrm-backend/downloads","issues_url":"https://api.github.com/repos/duizendnegen/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/duizendnegen/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/duizendnegen/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/duizendnegen/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duizendnegen/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/duizendnegen/osrm-backend/releases{/id}","deployments_url":"https://api.github.com/repos/duizendnegen/osrm-backend/deployments","created_at":"2016-11-06T10:40:34Z","updated_at":"2016-11-06T10:40:37Z","pushed_at":"2016-11-30T17:54:23Z","git_url":"git://github.com/duizendnegen/osrm-backend.git","ssh_url":"git@github.com:duizendnegen/osrm-backend.git","clone_url":"https://github.com/duizendnegen/osrm-backend.git","svn_url":"https://github.com/duizendnegen/osrm-backend","homepage":"http://map.project-osrm.org","size":17216,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Project-OSRM:master","ref":"master","sha":"ef087f963d2f50ce7bc7b7019c4cf7170cf8005e","user":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"repo":{"id":2436255,"name":"osrm-backend","full_name":"Project-OSRM/osrm-backend","owner":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Project-OSRM/osrm-backend","description":"Open Source Routing Machine - C++ backend","fork":false,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend","forks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/forks","keys_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/teams","hooks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/events","assignees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/tags","blobs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscription","commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/merges","archive_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/downloads","issues_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/releases{/id}","deployments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/deployments","created_at":"2011-09-22T10:05:08Z","updated_at":"2016-12-01T08:11:32Z","pushed_at":"2016-12-01T11:16:27Z","git_url":"git://github.com/Project-OSRM/osrm-backend.git","ssh_url":"git@github.com:Project-OSRM/osrm-backend.git","clone_url":"https://github.com/Project-OSRM/osrm-backend.git","svn_url":"https://github.com/Project-OSRM/osrm-backend","homepage":"http://map.project-osrm.org","size":32269,"stargazers_count":1453,"watchers_count":1453,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":871,"mirror_url":null,"open_issues_count":342,"forks":871,"open_issues":342,"watchers":1453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/3383"},"issue":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3383"},"comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/3383/comments"},"review_comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383/comments"},"review_comment":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/3383/commits"},"statuses":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/156c13b22421d132cb24eb5a942c7a12eed52d8b"}}}}
{"actor":{"display_login":"daniel-j-h"}}