{"action":"created","comment":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments/64155442","id":64155442,"diff_hunk":"@@ -25,14 +25,14 @@\n     person = FactoryGirl.create(:person_with_multiple_sub_ids)\n     merge_people.person1_wca_id = person.wca_id\n     expect(merge_people).to be_invalid\n-    expect(merge_people.errors.messages[:person1_wca_id]).to eq [\"This person has multiple subIds\"]\n+    expect(merge_people.errors.messages[:person1_wca_id]).to include \"This person has multiple subIds\"\n   end\n \n   it \"requires person2 not have multiple subIds\" do\n     person = FactoryGirl.create(:person_with_multiple_sub_ids)\n     merge_people.person2_wca_id = person.wca_id\n     expect(merge_people).to be_invalid\n-    expect(merge_people.errors.messages[:person2_wca_id]).to eq [\"This person has multiple subIds\", \"Names don't match\"]\n+    expect(merge_people.errors.messages[:person2_wca_id]).to include \"This person has multiple subIds\"","path":"WcaOnRails/spec/models/merge_people_spec.rb","position":13,"original_position":13,"commit_id":"92017f0f41a99c557555e51e1d24126a1324cc59","original_commit_id":"92017f0f41a99c557555e51e1d24126a1324cc59","user":{"login":"jfly","id":277474,"avatar_url":"https://avatars.githubusercontent.com/u/277474?v=3","gravatar_id":"","url":"https://api.github.com/users/jfly","html_url":"https://github.com/jfly","followers_url":"https://api.github.com/users/jfly/followers","following_url":"https://api.github.com/users/jfly/following{/other_user}","gists_url":"https://api.github.com/users/jfly/gists{/gist_id}","starred_url":"https://api.github.com/users/jfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfly/subscriptions","organizations_url":"https://api.github.com/users/jfly/orgs","repos_url":"https://api.github.com/users/jfly/repos","events_url":"https://api.github.com/users/jfly/events{/privacy}","received_events_url":"https://api.github.com/users/jfly/received_events","type":"User","site_admin":false},"body":"Same question as above.","created_at":"2016-05-22T20:07:12Z","updated_at":"2016-05-22T20:07:12Z","html_url":"https://github.com/cubing/worldcubeassociation.org/pull/645#discussion_r64155442","pull_request_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645","_links":{"self":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments/64155442"},"html":{"href":"https://github.com/cubing/worldcubeassociation.org/pull/645#discussion_r64155442"},"pull_request":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645"}}},"pull_request":{"url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645","id":70737257,"html_url":"https://github.com/cubing/worldcubeassociation.org/pull/645","diff_url":"https://github.com/cubing/worldcubeassociation.org/pull/645.diff","patch_url":"https://github.com/cubing/worldcubeassociation.org/pull/645.patch","issue_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/645","number":645,"state":"open","locked":false,"title":"Port change person to rails","user":{"login":"jonatanklosko","id":17034772,"avatar_url":"https://avatars.githubusercontent.com/u/17034772?v=3","gravatar_id":"","url":"https://api.github.com/users/jonatanklosko","html_url":"https://github.com/jonatanklosko","followers_url":"https://api.github.com/users/jonatanklosko/followers","following_url":"https://api.github.com/users/jonatanklosko/following{/other_user}","gists_url":"https://api.github.com/users/jonatanklosko/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatanklosko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatanklosko/subscriptions","organizations_url":"https://api.github.com/users/jonatanklosko/orgs","repos_url":"https://api.github.com/users/jonatanklosko/repos","events_url":"https://api.github.com/users/jonatanklosko/events{/privacy}","received_events_url":"https://api.github.com/users/jonatanklosko/received_events","type":"User","site_admin":false},"body":"This moves the `/admin/change_person.php` script to Rails.\r\n\r\nHighlights of the new interface:\r\n- using wca search to pick the person quickly\r\n- automatic filling the appropriate fields via Ajax when a person is picked\r\n- DateTime picker\r\n- Railsness =)\r\n\r\nVery important part of this PR is addition of `rails_persons` SQL view, which is the solution for #619.\r\n\r\nThe original `Persons` table changes:\r\n- remove the composite primary key\r\n- instead of the above, use an unique index on (id, subId)\r\n- create a standard autoincrement index called `rails_id`\r\n\r\nThe `rails_persons` view:\r\n- selects `id` as `wca_id`\r\n- selects `rails_id` as `id`\r\n\r\nAs a succession of the above all places using person `id` has been changed to use `wca_id`.","created_at":"2016-05-19T17:54:20Z","updated_at":"2016-05-22T20:07:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acdd1728530746c7e80e295a96b5eef681889851","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645/commits","review_comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645/comments","review_comment_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/645/comments","statuses_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/92017f0f41a99c557555e51e1d24126a1324cc59","head":{"label":"jonatanklosko:port-change-person-to-rails","ref":"port-change-person-to-rails","sha":"92017f0f41a99c557555e51e1d24126a1324cc59","user":{"login":"jonatanklosko","id":17034772,"avatar_url":"https://avatars.githubusercontent.com/u/17034772?v=3","gravatar_id":"","url":"https://api.github.com/users/jonatanklosko","html_url":"https://github.com/jonatanklosko","followers_url":"https://api.github.com/users/jonatanklosko/followers","following_url":"https://api.github.com/users/jonatanklosko/following{/other_user}","gists_url":"https://api.github.com/users/jonatanklosko/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatanklosko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatanklosko/subscriptions","organizations_url":"https://api.github.com/users/jonatanklosko/orgs","repos_url":"https://api.github.com/users/jonatanklosko/repos","events_url":"https://api.github.com/users/jonatanklosko/events{/privacy}","received_events_url":"https://api.github.com/users/jonatanklosko/received_events","type":"User","site_admin":false},"repo":{"id":54846746,"name":"worldcubeassociation.org","full_name":"jonatanklosko/worldcubeassociation.org","owner":{"login":"jonatanklosko","id":17034772,"avatar_url":"https://avatars.githubusercontent.com/u/17034772?v=3","gravatar_id":"","url":"https://api.github.com/users/jonatanklosko","html_url":"https://github.com/jonatanklosko","followers_url":"https://api.github.com/users/jonatanklosko/followers","following_url":"https://api.github.com/users/jonatanklosko/following{/other_user}","gists_url":"https://api.github.com/users/jonatanklosko/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatanklosko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatanklosko/subscriptions","organizations_url":"https://api.github.com/users/jonatanklosko/orgs","repos_url":"https://api.github.com/users/jonatanklosko/repos","events_url":"https://api.github.com/users/jonatanklosko/events{/privacy}","received_events_url":"https://api.github.com/users/jonatanklosko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonatanklosko/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":true,"url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org","forks_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/jonatanklosko/worldcubeassociation.org/deployments","created_at":"2016-03-27T20:29:06Z","updated_at":"2016-03-27T20:29:13Z","pushed_at":"2016-05-22T17:17:57Z","git_url":"git://github.com/jonatanklosko/worldcubeassociation.org.git","ssh_url":"git@github.com:jonatanklosko/worldcubeassociation.org.git","clone_url":"https://github.com/jonatanklosko/worldcubeassociation.org.git","svn_url":"https://github.com/jonatanklosko/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":52019,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cubing:master","ref":"master","sha":"b64afe129584446cc8e2ad7e4c633456e684bdf1","user":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"repo":{"id":34161579,"name":"worldcubeassociation.org","full_name":"cubing/worldcubeassociation.org","owner":{"login":"cubing","id":1092267,"avatar_url":"https://avatars.githubusercontent.com/u/1092267?v=3","gravatar_id":"","url":"https://api.github.com/users/cubing","html_url":"https://github.com/cubing","followers_url":"https://api.github.com/users/cubing/followers","following_url":"https://api.github.com/users/cubing/following{/other_user}","gists_url":"https://api.github.com/users/cubing/gists{/gist_id}","starred_url":"https://api.github.com/users/cubing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubing/subscriptions","organizations_url":"https://api.github.com/users/cubing/orgs","repos_url":"https://api.github.com/users/cubing/repos","events_url":"https://api.github.com/users/cubing/events{/privacy}","received_events_url":"https://api.github.com/users/cubing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cubing/worldcubeassociation.org","description":"[WCA Project] All of the code that runs on worldcubeassociation.org","fork":false,"url":"https://api.github.com/repos/cubing/worldcubeassociation.org","forks_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/forks","keys_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/teams","hooks_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/hooks","issue_events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/events{/number}","events_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/events","assignees_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/assignees{/user}","branches_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/branches{/branch}","tags_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/tags","blobs_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/{sha}","languages_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/languages","stargazers_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/stargazers","contributors_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/contributors","subscribers_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/subscribers","subscription_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/subscription","commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/contents/{+path}","compare_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/merges","archive_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/downloads","issues_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues{/number}","pulls_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls{/number}","milestones_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/milestones{/number}","notifications_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/labels{/name}","releases_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/releases{/id}","deployments_url":"https://api.github.com/repos/cubing/worldcubeassociation.org/deployments","created_at":"2015-04-18T10:21:53Z","updated_at":"2016-05-05T14:39:14Z","pushed_at":"2016-05-22T17:24:07Z","git_url":"git://github.com/cubing/worldcubeassociation.org.git","ssh_url":"git@github.com:cubing/worldcubeassociation.org.git","clone_url":"https://github.com/cubing/worldcubeassociation.org.git","svn_url":"https://github.com/cubing/worldcubeassociation.org","homepage":"https://www.worldcubeassociation.org/","size":55179,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":152,"forks":26,"open_issues":152,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645"},"html":{"href":"https://github.com/cubing/worldcubeassociation.org/pull/645"},"issue":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/645"},"comments":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/issues/645/comments"},"review_comments":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645/comments"},"review_comment":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/pulls/645/commits"},"statuses":{"href":"https://api.github.com/repos/cubing/worldcubeassociation.org/statuses/92017f0f41a99c557555e51e1d24126a1324cc59"}}}}
{"actor":{"display_login":"jfly"}}