{"action":"created","comment":{"url":"https://api.github.com/repos/talis/persona-php-client/pulls/comments/58182434","id":58182434,"diff_hunk":"@@ -83,10 +77,7 @@ $profile = $personaClient->getUserByGupid(\"google:123\", \"some token\");\n // create an instance of the client\n $personaClient = new Talis\\Persona\\Client\\Login(array(\n     'persona_host' => 'http://persona',\n-    'persona_oauth_route' => '/oauth/tokens',\n-    'tokencache_redis_host' => 'localhost',\n-    'tokencache_redis_port' => 6379,\n-    'tokencache_redis_db' => 2\n+    'persona_oauth_route' => '/oauth/tokens'","path":"README.md","position":8,"original_position":32,"commit_id":"93990605ba52c80846e33000c34f1d4c23187bfb","original_commit_id":"4bc0fad6ece484cbb31d10f234c0e112507d20a2","user":{"login":"pads","id":557957,"avatar_url":"https://avatars.githubusercontent.com/u/557957?v=3","gravatar_id":"","url":"https://api.github.com/users/pads","html_url":"https://github.com/pads","followers_url":"https://api.github.com/users/pads/followers","following_url":"https://api.github.com/users/pads/following{/other_user}","gists_url":"https://api.github.com/users/pads/gists{/gist_id}","starred_url":"https://api.github.com/users/pads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pads/subscriptions","organizations_url":"https://api.github.com/users/pads/orgs","repos_url":"https://api.github.com/users/pads/repos","events_url":"https://api.github.com/users/pads/events{/privacy}","received_events_url":"https://api.github.com/users/pads/received_events","type":"User","site_admin":false},"body":"Ok makes sense, the README should be updated with an example like this.","created_at":"2016-04-01T09:30:36Z","updated_at":"2016-04-01T09:30:36Z","html_url":"https://github.com/talis/persona-php-client/pull/25#discussion_r58182434","pull_request_url":"https://api.github.com/repos/talis/persona-php-client/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/comments/58182434"},"html":{"href":"https://github.com/talis/persona-php-client/pull/25#discussion_r58182434"},"pull_request":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/talis/persona-php-client/pulls/25","id":64434606,"html_url":"https://github.com/talis/persona-php-client/pull/25","diff_url":"https://github.com/talis/persona-php-client/pull/25.diff","patch_url":"https://github.com/talis/persona-php-client/pull/25.patch","issue_url":"https://api.github.com/repos/talis/persona-php-client/issues/25","number":25,"state":"open","locked":false,"title":"90% - PLAT-163 - Remove Redis Cache & Add Guzzle Cache","user":{"login":"markwallsgrove","id":6328824,"avatar_url":"https://avatars.githubusercontent.com/u/6328824?v=3","gravatar_id":"","url":"https://api.github.com/users/markwallsgrove","html_url":"https://github.com/markwallsgrove","followers_url":"https://api.github.com/users/markwallsgrove/followers","following_url":"https://api.github.com/users/markwallsgrove/following{/other_user}","gists_url":"https://api.github.com/users/markwallsgrove/gists{/gist_id}","starred_url":"https://api.github.com/users/markwallsgrove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markwallsgrove/subscriptions","organizations_url":"https://api.github.com/users/markwallsgrove/orgs","repos_url":"https://api.github.com/users/markwallsgrove/repos","events_url":"https://api.github.com/users/markwallsgrove/events{/privacy}","received_events_url":"https://api.github.com/users/markwallsgrove/received_events","type":"User","site_admin":false},"body":"Remove the mandatory use of a Redis cache & replace with Guzzle cache plugins. This will provide the option of using a variety of different storage options that will be configurable by the client.\r\n - [x] Remove Redis\r\n - [x] Add the ability to provide a cache mechanism\r\n - [x] Check Persona is defining sensible cache headers\r\n - [x] Allow a global TTL override\r\n - [x] Allow per request TTL override\r\n - [x] Double check how the cache keys are created\r\n - [x] useCache has been deprecated - what to do?\r\n - [x] tests\r\n - [ ] Add deprecation warning to release","created_at":"2016-03-29T09:11:30Z","updated_at":"2016-04-01T09:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d54fbe6f87372612f18093ca88bcf1d138028ed","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/talis/persona-php-client/pulls/25/commits","review_comments_url":"https://api.github.com/repos/talis/persona-php-client/pulls/25/comments","review_comment_url":"https://api.github.com/repos/talis/persona-php-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/talis/persona-php-client/issues/25/comments","statuses_url":"https://api.github.com/repos/talis/persona-php-client/statuses/93990605ba52c80846e33000c34f1d4c23187bfb","head":{"label":"talis:PLAT-163-Cache","ref":"PLAT-163-Cache","sha":"93990605ba52c80846e33000c34f1d4c23187bfb","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":16688350,"name":"persona-php-client","full_name":"talis/persona-php-client","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/persona-php-client","description":"This is a php client library for Persona supporting generation, validation and caching of Oauth Tokens","fork":false,"url":"https://api.github.com/repos/talis/persona-php-client","forks_url":"https://api.github.com/repos/talis/persona-php-client/forks","keys_url":"https://api.github.com/repos/talis/persona-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/persona-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/persona-php-client/teams","hooks_url":"https://api.github.com/repos/talis/persona-php-client/hooks","issue_events_url":"https://api.github.com/repos/talis/persona-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/talis/persona-php-client/events","assignees_url":"https://api.github.com/repos/talis/persona-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/talis/persona-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/talis/persona-php-client/tags","blobs_url":"https://api.github.com/repos/talis/persona-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/persona-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/persona-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/persona-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/persona-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/persona-php-client/languages","stargazers_url":"https://api.github.com/repos/talis/persona-php-client/stargazers","contributors_url":"https://api.github.com/repos/talis/persona-php-client/contributors","subscribers_url":"https://api.github.com/repos/talis/persona-php-client/subscribers","subscription_url":"https://api.github.com/repos/talis/persona-php-client/subscription","commits_url":"https://api.github.com/repos/talis/persona-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/persona-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/persona-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/persona-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/persona-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/talis/persona-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/persona-php-client/merges","archive_url":"https://api.github.com/repos/talis/persona-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/persona-php-client/downloads","issues_url":"https://api.github.com/repos/talis/persona-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/talis/persona-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/persona-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/persona-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/persona-php-client/labels{/name}","releases_url":"https://api.github.com/repos/talis/persona-php-client/releases{/id}","deployments_url":"https://api.github.com/repos/talis/persona-php-client/deployments","created_at":"2014-02-10T07:57:51Z","updated_at":"2016-03-04T09:45:34Z","pushed_at":"2016-03-31T22:13:22Z","git_url":"git://github.com/talis/persona-php-client.git","ssh_url":"git@github.com:talis/persona-php-client.git","clone_url":"https://github.com/talis/persona-php-client.git","svn_url":"https://github.com/talis/persona-php-client","homepage":null,"size":158,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"talis:master","ref":"master","sha":"85c2d5b3d4c5c8c9c0450849888cbebeff672b4f","user":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"repo":{"id":16688350,"name":"persona-php-client","full_name":"talis/persona-php-client","owner":{"login":"talis","id":181416,"avatar_url":"https://avatars.githubusercontent.com/u/181416?v=3","gravatar_id":"","url":"https://api.github.com/users/talis","html_url":"https://github.com/talis","followers_url":"https://api.github.com/users/talis/followers","following_url":"https://api.github.com/users/talis/following{/other_user}","gists_url":"https://api.github.com/users/talis/gists{/gist_id}","starred_url":"https://api.github.com/users/talis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talis/subscriptions","organizations_url":"https://api.github.com/users/talis/orgs","repos_url":"https://api.github.com/users/talis/repos","events_url":"https://api.github.com/users/talis/events{/privacy}","received_events_url":"https://api.github.com/users/talis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/talis/persona-php-client","description":"This is a php client library for Persona supporting generation, validation and caching of Oauth Tokens","fork":false,"url":"https://api.github.com/repos/talis/persona-php-client","forks_url":"https://api.github.com/repos/talis/persona-php-client/forks","keys_url":"https://api.github.com/repos/talis/persona-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talis/persona-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talis/persona-php-client/teams","hooks_url":"https://api.github.com/repos/talis/persona-php-client/hooks","issue_events_url":"https://api.github.com/repos/talis/persona-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/talis/persona-php-client/events","assignees_url":"https://api.github.com/repos/talis/persona-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/talis/persona-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/talis/persona-php-client/tags","blobs_url":"https://api.github.com/repos/talis/persona-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talis/persona-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talis/persona-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/talis/persona-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talis/persona-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/talis/persona-php-client/languages","stargazers_url":"https://api.github.com/repos/talis/persona-php-client/stargazers","contributors_url":"https://api.github.com/repos/talis/persona-php-client/contributors","subscribers_url":"https://api.github.com/repos/talis/persona-php-client/subscribers","subscription_url":"https://api.github.com/repos/talis/persona-php-client/subscription","commits_url":"https://api.github.com/repos/talis/persona-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/talis/persona-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/talis/persona-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/talis/persona-php-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/talis/persona-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/talis/persona-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talis/persona-php-client/merges","archive_url":"https://api.github.com/repos/talis/persona-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talis/persona-php-client/downloads","issues_url":"https://api.github.com/repos/talis/persona-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/talis/persona-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/talis/persona-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/talis/persona-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talis/persona-php-client/labels{/name}","releases_url":"https://api.github.com/repos/talis/persona-php-client/releases{/id}","deployments_url":"https://api.github.com/repos/talis/persona-php-client/deployments","created_at":"2014-02-10T07:57:51Z","updated_at":"2016-03-04T09:45:34Z","pushed_at":"2016-03-31T22:13:22Z","git_url":"git://github.com/talis/persona-php-client.git","ssh_url":"git@github.com:talis/persona-php-client.git","clone_url":"https://github.com/talis/persona-php-client.git","svn_url":"https://github.com/talis/persona-php-client","homepage":null,"size":158,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/25"},"html":{"href":"https://github.com/talis/persona-php-client/pull/25"},"issue":{"href":"https://api.github.com/repos/talis/persona-php-client/issues/25"},"comments":{"href":"https://api.github.com/repos/talis/persona-php-client/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/talis/persona-php-client/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/talis/persona-php-client/statuses/93990605ba52c80846e33000c34f1d4c23187bfb"}}}}