{"action":"created","comment":{"url":"https://api.github.com/repos/stripe/librarian-puppet/pulls/comments/51334136","id":51334136,"diff_hunk":"@@ -37,6 +37,11 @@ def cache!\n             raise Error, \"Could not checkout #{uri}#{\" at #{sha}\" unless sha.nil?}: #{e}\"\n           end\n \n+          if environment.config_db[\"install.strip-dot-git\"] == \"1\"\n+            dot_git = filesystem_path.join(\".git\")\n+            dot_git.rmtree if dot_git.directory?\n+          end","path":"lib/librarian/puppet/source/git.rb","position":7,"original_position":7,"commit_id":"38744042595c0c6e66e60b48004e3fd623e944da","original_commit_id":"38744042595c0c6e66e60b48004e3fd623e944da","user":{"login":"kitchen","id":178765,"avatar_url":"https://avatars.githubusercontent.com/u/178765?v=3","gravatar_id":"","url":"https://api.github.com/users/kitchen","html_url":"https://github.com/kitchen","followers_url":"https://api.github.com/users/kitchen/followers","following_url":"https://api.github.com/users/kitchen/following{/other_user}","gists_url":"https://api.github.com/users/kitchen/gists{/gist_id}","starred_url":"https://api.github.com/users/kitchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitchen/subscriptions","organizations_url":"https://api.github.com/users/kitchen/orgs","repos_url":"https://api.github.com/users/kitchen/repos","events_url":"https://api.github.com/users/kitchen/events{/privacy}","received_events_url":"https://api.github.com/users/kitchen/received_events","type":"User","site_admin":false},"body":"question: if you, say, upgrade, does it actually work? I'm not certain how librarian-puppet knows what version exists in the modules directory without the .git directory, so I'd want to make sure that it's not re-cloning the upstream repo every time etc.","created_at":"2016-01-30T00:29:02Z","updated_at":"2016-01-30T00:29:02Z","html_url":"https://github.com/stripe/librarian-puppet/pull/1#discussion_r51334136","pull_request_url":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/stripe/librarian-puppet/pulls/comments/51334136"},"html":{"href":"https://github.com/stripe/librarian-puppet/pull/1#discussion_r51334136"},"pull_request":{"href":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1","id":57719120,"html_url":"https://github.com/stripe/librarian-puppet/pull/1","diff_url":"https://github.com/stripe/librarian-puppet/pull/1.diff","patch_url":"https://github.com/stripe/librarian-puppet/pull/1.patch","issue_url":"https://api.github.com/repos/stripe/librarian-puppet/issues/1","number":1,"state":"open","locked":false,"title":"Adding functionality for the --strip-dot-git flag","user":{"login":"rhwlo","id":315383,"avatar_url":"https://avatars.githubusercontent.com/u/315383?v=3","gravatar_id":"","url":"https://api.github.com/users/rhwlo","html_url":"https://github.com/rhwlo","followers_url":"https://api.github.com/users/rhwlo/followers","following_url":"https://api.github.com/users/rhwlo/following{/other_user}","gists_url":"https://api.github.com/users/rhwlo/gists{/gist_id}","starred_url":"https://api.github.com/users/rhwlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhwlo/subscriptions","organizations_url":"https://api.github.com/users/rhwlo/orgs","repos_url":"https://api.github.com/users/rhwlo/repos","events_url":"https://api.github.com/users/rhwlo/events{/privacy}","received_events_url":"https://api.github.com/users/rhwlo/received_events","type":"User","site_admin":false},"body":"Mirroring https://github.com/rodjek/librarian-puppet/pull/332\r\n\r\nr? @kitchen","created_at":"2016-01-29T23:50:10Z","updated_at":"2016-01-30T00:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cf614062580a410f2f6db58c7bddb4cba66f9b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1/commits","review_comments_url":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1/comments","review_comment_url":"https://api.github.com/repos/stripe/librarian-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stripe/librarian-puppet/issues/1/comments","statuses_url":"https://api.github.com/repos/stripe/librarian-puppet/statuses/38744042595c0c6e66e60b48004e3fd623e944da","head":{"label":"stripe:joshu_add-strip-dot-git","ref":"joshu_add-strip-dot-git","sha":"38744042595c0c6e66e60b48004e3fd623e944da","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":50698349,"name":"librarian-puppet","full_name":"stripe/librarian-puppet","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/librarian-puppet","description":"","fork":true,"url":"https://api.github.com/repos/stripe/librarian-puppet","forks_url":"https://api.github.com/repos/stripe/librarian-puppet/forks","keys_url":"https://api.github.com/repos/stripe/librarian-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/librarian-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/librarian-puppet/teams","hooks_url":"https://api.github.com/repos/stripe/librarian-puppet/hooks","issue_events_url":"https://api.github.com/repos/stripe/librarian-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/librarian-puppet/events","assignees_url":"https://api.github.com/repos/stripe/librarian-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/librarian-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/librarian-puppet/tags","blobs_url":"https://api.github.com/repos/stripe/librarian-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/librarian-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/librarian-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/librarian-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/librarian-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/librarian-puppet/languages","stargazers_url":"https://api.github.com/repos/stripe/librarian-puppet/stargazers","contributors_url":"https://api.github.com/repos/stripe/librarian-puppet/contributors","subscribers_url":"https://api.github.com/repos/stripe/librarian-puppet/subscribers","subscription_url":"https://api.github.com/repos/stripe/librarian-puppet/subscription","commits_url":"https://api.github.com/repos/stripe/librarian-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/librarian-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/librarian-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/librarian-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/librarian-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/librarian-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/librarian-puppet/merges","archive_url":"https://api.github.com/repos/stripe/librarian-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/librarian-puppet/downloads","issues_url":"https://api.github.com/repos/stripe/librarian-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/librarian-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/librarian-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/librarian-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/librarian-puppet/labels{/name}","releases_url":"https://api.github.com/repos/stripe/librarian-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/librarian-puppet/deployments","created_at":"2016-01-29T23:28:26Z","updated_at":"2016-01-29T23:28:27Z","pushed_at":"2016-01-29T23:50:11Z","git_url":"git://github.com/stripe/librarian-puppet.git","ssh_url":"git@github.com:stripe/librarian-puppet.git","clone_url":"https://github.com/stripe/librarian-puppet.git","svn_url":"https://github.com/stripe/librarian-puppet","homepage":"http://librarian-puppet.com","size":706,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"stripe"}},"base":{"label":"stripe:stripe","ref":"stripe","sha":"4112247fc6757f67d10bff9f256fdc82c3bed839","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":50698349,"name":"librarian-puppet","full_name":"stripe/librarian-puppet","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars.githubusercontent.com/u/856813?v=3","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/librarian-puppet","description":"","fork":true,"url":"https://api.github.com/repos/stripe/librarian-puppet","forks_url":"https://api.github.com/repos/stripe/librarian-puppet/forks","keys_url":"https://api.github.com/repos/stripe/librarian-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/librarian-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/librarian-puppet/teams","hooks_url":"https://api.github.com/repos/stripe/librarian-puppet/hooks","issue_events_url":"https://api.github.com/repos/stripe/librarian-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/librarian-puppet/events","assignees_url":"https://api.github.com/repos/stripe/librarian-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/librarian-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/librarian-puppet/tags","blobs_url":"https://api.github.com/repos/stripe/librarian-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/librarian-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/librarian-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/librarian-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/librarian-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/librarian-puppet/languages","stargazers_url":"https://api.github.com/repos/stripe/librarian-puppet/stargazers","contributors_url":"https://api.github.com/repos/stripe/librarian-puppet/contributors","subscribers_url":"https://api.github.com/repos/stripe/librarian-puppet/subscribers","subscription_url":"https://api.github.com/repos/stripe/librarian-puppet/subscription","commits_url":"https://api.github.com/repos/stripe/librarian-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/librarian-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/librarian-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/librarian-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/librarian-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/librarian-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/librarian-puppet/merges","archive_url":"https://api.github.com/repos/stripe/librarian-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/librarian-puppet/downloads","issues_url":"https://api.github.com/repos/stripe/librarian-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/librarian-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/librarian-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/librarian-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/librarian-puppet/labels{/name}","releases_url":"https://api.github.com/repos/stripe/librarian-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/librarian-puppet/deployments","created_at":"2016-01-29T23:28:26Z","updated_at":"2016-01-29T23:28:27Z","pushed_at":"2016-01-29T23:50:11Z","git_url":"git://github.com/stripe/librarian-puppet.git","ssh_url":"git@github.com:stripe/librarian-puppet.git","clone_url":"https://github.com/stripe/librarian-puppet.git","svn_url":"https://github.com/stripe/librarian-puppet","homepage":"http://librarian-puppet.com","size":706,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"stripe"}},"_links":{"self":{"href":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1"},"html":{"href":"https://github.com/stripe/librarian-puppet/pull/1"},"issue":{"href":"https://api.github.com/repos/stripe/librarian-puppet/issues/1"},"comments":{"href":"https://api.github.com/repos/stripe/librarian-puppet/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/stripe/librarian-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stripe/librarian-puppet/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/stripe/librarian-puppet/statuses/38744042595c0c6e66e60b48004e3fd623e944da"}}}}