{"comment":{"url":"https://api.github.com/repos/goebish/cleanflight/comments/16501641","html_url":"https://github.com/goebish/cleanflight/commit/bf14fc44d1a3ad7660c01866281007a5e75dc454#commitcomment-16501641","id":16501641,"user":{"login":"martinbudden","id":194586,"avatar_url":"https://avatars.githubusercontent.com/u/194586?v=3","gravatar_id":"","url":"https://api.github.com/users/martinbudden","html_url":"https://github.com/martinbudden","followers_url":"https://api.github.com/users/martinbudden/followers","following_url":"https://api.github.com/users/martinbudden/following{/other_user}","gists_url":"https://api.github.com/users/martinbudden/gists{/gist_id}","starred_url":"https://api.github.com/users/martinbudden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinbudden/subscriptions","organizations_url":"https://api.github.com/users/martinbudden/orgs","repos_url":"https://api.github.com/users/martinbudden/repos","events_url":"https://api.github.com/users/martinbudden/events{/privacy}","received_events_url":"https://api.github.com/users/martinbudden/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"bf14fc44d1a3ad7660c01866281007a5e75dc454","created_at":"2016-03-04T15:04:36Z","updated_at":"2016-03-04T15:04:36Z","body":"OK, I'll merge your code into mine and make a PR for Cleanflight. I'll do this for both the Crazepony and CJMCU boards. As I said, your code is similar in structure to mine, so I should be able to get the merge in over the weekend.\r\n\r\nAnd, yes, I agree with you on the ROM space thing. ROM size is certainly something I have my eye on. As I said, this NRF24 work is really a subproject of a 32K ROM version of Cleanflight.\r\n\r\nSo the plan is to put each protocol under a build flag and only include the V202 for the CJMCU and Crazepony boards. Having the protocols to the build means that people can build variants or produce forks if they want. For the boards with larger ROMs the procotol can be selectable. I'm not sure where that line lies yet - the CC3D and NAZE boards are also tight on ROM.\r\n\r\nI'll get myself a Crazepony and try and do some ROM reduction work for it - it might be possible to make enough room for the baro driver and code.\r\n\r\nAnd thanks for fixing the CJMCU SPI. I look forward to trying that out (I'm away from home at the moment, so won't actually get to try it for about a week)."}}