{"action":"closed","issue":{"url":"https://api.github.com/repos/socketio/engine.io/issues/396","repository_url":"https://api.github.com/repos/socketio/engine.io","labels_url":"https://api.github.com/repos/socketio/engine.io/issues/396/labels{/name}","comments_url":"https://api.github.com/repos/socketio/engine.io/issues/396/comments","events_url":"https://api.github.com/repos/socketio/engine.io/issues/396/events","html_url":"https://github.com/socketio/engine.io/issues/396","id":156141081,"number":396,"title":"engine.io-client 1.6.9 makes node.js socketio calls hang","user":{"login":"ksylvan","id":1226059,"avatar_url":"https://avatars.githubusercontent.com/u/1226059?v=3","gravatar_id":"","url":"https://api.github.com/users/ksylvan","html_url":"https://github.com/ksylvan","followers_url":"https://api.github.com/users/ksylvan/followers","following_url":"https://api.github.com/users/ksylvan/following{/other_user}","gists_url":"https://api.github.com/users/ksylvan/gists{/gist_id}","starred_url":"https://api.github.com/users/ksylvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksylvan/subscriptions","organizations_url":"https://api.github.com/users/ksylvan/orgs","repos_url":"https://api.github.com/users/ksylvan/repos","events_url":"https://api.github.com/users/ksylvan/events{/privacy}","received_events_url":"https://api.github.com/users/ksylvan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-05-22T08:17:50Z","updated_at":"2016-10-20T14:17:28Z","closed_at":"2016-10-20T14:17:28Z","body":"This is related to https://github.com/socketio/socket.io-client/issues/969\r\n\r\nAgain, not sure why the npm package is 1.6.9 while the source code here is only at version 1.6.8\r\n\r\nI traced the problem down to the engine.io-client 1.6.9 update in the socket.io-client update.\r\n\r\nAfter `npm install --save socket.io-client` I changed the `package.json` reference to be for `1.6.8`:\r\n\r\n    /usr/src/app $ grep engine.io-client node_modules/socket.io-client/package.json \r\n    \"engine.io-client\": \"1.6.8\",\r\n\r\nAnd now my tests work:\r\n\r\n    $ ./test/run_tests InfoController\r\n  \r\n      InfoController\r\n        /version:\r\n      ✓ should return json (57ms)\r\n      ✓ should have valid json info\r\n      InfoController with sockets\r\n        /version:\r\n      ✓ should return data\r\n      3 passing (16s)\r\n\r\nChanging it back to 1.6.9, here is what happens:\r\n\r\n    $ ./test/run_tests InfoController\r\n  \r\n     InfoController\r\n        /version:\r\n      ✓ should return json (41ms)\r\n      ✓ should have valid json info \r\n      InfoController with sockets\r\n        /version:\r\n      1) should return data\r\n      2 passing (12s)\r\n      1 failing    \r\n      1) InfoController with sockets /version: should return data:\r\n         Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.\r\n\r\n"}}
{"actor":{"display_login":"darrachequesne"}}