{"action":"created","comment":{"url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/comments/49246385","id":49246385,"diff_hunk":"@@ -1,4 +1,8 @@\n // See https://en.wikipedia.org/wiki/Tar_%28computing%29#UStar_format\n+// and\n+// https://www-01.ibm.com/support/knowledgecenter/SSLTBW_1.13.0/\n+// com.ibm.zos.r13.bpxa500/pxarchfm.htm\n+","path":"src/entry_type.rs","position":5,"original_position":5,"commit_id":"b573100243c34347fbeba6345bfbba5a47b16dd0","original_commit_id":"b573100243c34347fbeba6345bfbba5a47b16dd0","user":{"login":"aidanhs","id":1050652,"avatar_url":"https://avatars.githubusercontent.com/u/1050652?v=3","gravatar_id":"","url":"https://api.github.com/users/aidanhs","html_url":"https://github.com/aidanhs","followers_url":"https://api.github.com/users/aidanhs/followers","following_url":"https://api.github.com/users/aidanhs/following{/other_user}","gists_url":"https://api.github.com/users/aidanhs/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanhs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanhs/subscriptions","organizations_url":"https://api.github.com/users/aidanhs/orgs","repos_url":"https://api.github.com/users/aidanhs/repos","events_url":"https://api.github.com/users/aidanhs/events{/privacy}","received_events_url":"https://api.github.com/users/aidanhs/received_events","type":"User","site_admin":false},"body":"I propose linking to http://pubs.opengroup.org/onlinepubs/9699919799/utilities/pax.html instead as a more accessible (and complete) page.","created_at":"2016-01-08T22:28:44Z","updated_at":"2016-01-08T22:28:44Z","html_url":"https://github.com/alexcrichton/tar-rs/pull/49#discussion_r49246385","pull_request_url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49","_links":{"self":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/comments/49246385"},"html":{"href":"https://github.com/alexcrichton/tar-rs/pull/49#discussion_r49246385"},"pull_request":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49","id":54830381,"html_url":"https://github.com/alexcrichton/tar-rs/pull/49","diff_url":"https://github.com/alexcrichton/tar-rs/pull/49.diff","patch_url":"https://github.com/alexcrichton/tar-rs/pull/49.patch","issue_url":"https://api.github.com/repos/alexcrichton/tar-rs/issues/49","number":49,"state":"open","locked":false,"title":"Add entry types for pax extended headers","user":{"login":"dbrgn","id":105168,"avatar_url":"https://avatars.githubusercontent.com/u/105168?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"body":"This should handle #48.\r\n\r\nWith this PR, the pax global header is not fully supported yet, the values are simply ignored :wink: Docs can be found [here](https://www-01.ibm.com/support/knowledgecenter/SSLTBW_1.13.0/com.ibm.zos.r13.bpxa500/pxarchfm.htm). But at least it can now unpack files that contain these headers, instead of failing.\r\n\r\nDid you ever think about using proper enums to implement the `EntryType`s instead of using the boolean methods?","created_at":"2015-12-30T21:18:12Z","updated_at":"2016-01-08T22:28:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ab397cb7ce7b70808f4f841894356f27c07582","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49/commits","review_comments_url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49/comments","review_comment_url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexcrichton/tar-rs/issues/49/comments","statuses_url":"https://api.github.com/repos/alexcrichton/tar-rs/statuses/b573100243c34347fbeba6345bfbba5a47b16dd0","head":{"label":"dbrgn:pax_header","ref":"pax_header","sha":"b573100243c34347fbeba6345bfbba5a47b16dd0","user":{"login":"dbrgn","id":105168,"avatar_url":"https://avatars.githubusercontent.com/u/105168?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"repo":{"id":48819690,"name":"tar-rs","full_name":"dbrgn/tar-rs","owner":{"login":"dbrgn","id":105168,"avatar_url":"https://avatars.githubusercontent.com/u/105168?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbrgn/tar-rs","description":"Tar file reading/writing for Rust","fork":true,"url":"https://api.github.com/repos/dbrgn/tar-rs","forks_url":"https://api.github.com/repos/dbrgn/tar-rs/forks","keys_url":"https://api.github.com/repos/dbrgn/tar-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbrgn/tar-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbrgn/tar-rs/teams","hooks_url":"https://api.github.com/repos/dbrgn/tar-rs/hooks","issue_events_url":"https://api.github.com/repos/dbrgn/tar-rs/issues/events{/number}","events_url":"https://api.github.com/repos/dbrgn/tar-rs/events","assignees_url":"https://api.github.com/repos/dbrgn/tar-rs/assignees{/user}","branches_url":"https://api.github.com/repos/dbrgn/tar-rs/branches{/branch}","tags_url":"https://api.github.com/repos/dbrgn/tar-rs/tags","blobs_url":"https://api.github.com/repos/dbrgn/tar-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbrgn/tar-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbrgn/tar-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbrgn/tar-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbrgn/tar-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/dbrgn/tar-rs/languages","stargazers_url":"https://api.github.com/repos/dbrgn/tar-rs/stargazers","contributors_url":"https://api.github.com/repos/dbrgn/tar-rs/contributors","subscribers_url":"https://api.github.com/repos/dbrgn/tar-rs/subscribers","subscription_url":"https://api.github.com/repos/dbrgn/tar-rs/subscription","commits_url":"https://api.github.com/repos/dbrgn/tar-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbrgn/tar-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbrgn/tar-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbrgn/tar-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbrgn/tar-rs/contents/{+path}","compare_url":"https://api.github.com/repos/dbrgn/tar-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbrgn/tar-rs/merges","archive_url":"https://api.github.com/repos/dbrgn/tar-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbrgn/tar-rs/downloads","issues_url":"https://api.github.com/repos/dbrgn/tar-rs/issues{/number}","pulls_url":"https://api.github.com/repos/dbrgn/tar-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/dbrgn/tar-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/dbrgn/tar-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbrgn/tar-rs/labels{/name}","releases_url":"https://api.github.com/repos/dbrgn/tar-rs/releases{/id}","created_at":"2015-12-30T21:13:55Z","updated_at":"2015-12-30T21:13:56Z","pushed_at":"2015-12-30T21:15:10Z","git_url":"git://github.com/dbrgn/tar-rs.git","ssh_url":"git@github.com:dbrgn/tar-rs.git","clone_url":"https://github.com/dbrgn/tar-rs.git","svn_url":"https://github.com/dbrgn/tar-rs","homepage":"http://alexcrichton.com/tar-rs","size":813,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexcrichton:master","ref":"master","sha":"30829858267215e8d9c35f9d3f3ce08052a97a97","user":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":21946092,"name":"tar-rs","full_name":"alexcrichton/tar-rs","owner":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/tar-rs","description":"Tar file reading/writing for Rust","fork":false,"url":"https://api.github.com/repos/alexcrichton/tar-rs","forks_url":"https://api.github.com/repos/alexcrichton/tar-rs/forks","keys_url":"https://api.github.com/repos/alexcrichton/tar-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/tar-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/tar-rs/teams","hooks_url":"https://api.github.com/repos/alexcrichton/tar-rs/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/tar-rs/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/tar-rs/events","assignees_url":"https://api.github.com/repos/alexcrichton/tar-rs/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/tar-rs/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/tar-rs/tags","blobs_url":"https://api.github.com/repos/alexcrichton/tar-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/tar-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/tar-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/tar-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/tar-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/tar-rs/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/tar-rs/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/tar-rs/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/tar-rs/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/tar-rs/subscription","commits_url":"https://api.github.com/repos/alexcrichton/tar-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/tar-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/tar-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/tar-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/tar-rs/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/tar-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/tar-rs/merges","archive_url":"https://api.github.com/repos/alexcrichton/tar-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/tar-rs/downloads","issues_url":"https://api.github.com/repos/alexcrichton/tar-rs/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/tar-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/tar-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/tar-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/tar-rs/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/tar-rs/releases{/id}","created_at":"2014-07-17T14:56:29Z","updated_at":"2015-12-31T11:20:56Z","pushed_at":"2016-01-04T16:06:56Z","git_url":"git://github.com/alexcrichton/tar-rs.git","ssh_url":"git@github.com:alexcrichton/tar-rs.git","clone_url":"https://github.com/alexcrichton/tar-rs.git","svn_url":"https://github.com/alexcrichton/tar-rs","homepage":"http://alexcrichton.com/tar-rs","size":827,"stargazers_count":25,"watchers_count":25,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"open_issues_count":7,"forks":18,"open_issues":7,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49"},"html":{"href":"https://github.com/alexcrichton/tar-rs/pull/49"},"issue":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/issues/49"},"comments":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/alexcrichton/tar-rs/statuses/b573100243c34347fbeba6345bfbba5a47b16dd0"}}}}