{"action":"created","comment":{"url":"https://api.github.com/repos/yargs/yargs-parser/pulls/comments/52836910","id":52836910,"diff_hunk":"@@ -538,18 +548,24 @@ function parse (args, opts) {\n     var type = 'boolean'\n \n     if (flags.strings && flags.strings[key]) type = 'string'\n+    else if (flags.numbers && flags.numbers[key]) type = 'number'\n     else if (flags.arrays && flags.arrays[key]) type = 'array'\n \n     return type\n   }\n \n   function isNumber (x) {\n+    if (flags.numbers && flags.numbers[x] && !isNaN(x)) return true","path":"index.js","position":51,"original_position":51,"commit_id":"1860ee62859ddcb88e621f85a0752e7a39a40f74","original_commit_id":"1860ee62859ddcb88e621f85a0752e7a39a40f74","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"body":"Can we nuke this line? I'm pretty sure it's not having an effect.","created_at":"2016-02-14T02:45:06Z","updated_at":"2016-02-14T02:45:06Z","html_url":"https://github.com/yargs/yargs-parser/pull/7#discussion_r52836910","pull_request_url":"https://api.github.com/repos/yargs/yargs-parser/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/yargs/yargs-parser/pulls/comments/52836910"},"html":{"href":"https://github.com/yargs/yargs-parser/pull/7#discussion_r52836910"},"pull_request":{"href":"https://api.github.com/repos/yargs/yargs-parser/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/yargs/yargs-parser/pulls/7","id":59284947,"html_url":"https://github.com/yargs/yargs-parser/pull/7","diff_url":"https://github.com/yargs/yargs-parser/pull/7.diff","patch_url":"https://github.com/yargs/yargs-parser/pull/7.patch","issue_url":"https://api.github.com/repos/yargs/yargs-parser/issues/7","number":7,"state":"open","locked":false,"title":"New type number","user":{"login":"lrlna","id":8107784,"avatar_url":"https://avatars.githubusercontent.com/u/8107784?v=3","gravatar_id":"","url":"https://api.github.com/users/lrlna","html_url":"https://github.com/lrlna","followers_url":"https://api.github.com/users/lrlna/followers","following_url":"https://api.github.com/users/lrlna/following{/other_user}","gists_url":"https://api.github.com/users/lrlna/gists{/gist_id}","starred_url":"https://api.github.com/users/lrlna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrlna/subscriptions","organizations_url":"https://api.github.com/users/lrlna/orgs","repos_url":"https://api.github.com/users/lrlna/repos","events_url":"https://api.github.com/users/lrlna/events{/privacy}","received_events_url":"https://api.github.com/users/lrlna/received_events","type":"User","site_admin":false},"body":"This PR builds on top of @maxrimue #5 ; I wasn't able to push to his fork, so creating a new one. \r\n\r\nSummary: checks if value is not a number and assigns a `NaN`. ","created_at":"2016-02-14T02:40:36Z","updated_at":"2016-02-14T02:45:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b930ff4f871b6ae2712fbf3878d7a5067b3c57ef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yargs/yargs-parser/pulls/7/commits","review_comments_url":"https://api.github.com/repos/yargs/yargs-parser/pulls/7/comments","review_comment_url":"https://api.github.com/repos/yargs/yargs-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yargs/yargs-parser/issues/7/comments","statuses_url":"https://api.github.com/repos/yargs/yargs-parser/statuses/1860ee62859ddcb88e621f85a0752e7a39a40f74","head":{"label":"yargs:new-type-number","ref":"new-type-number","sha":"1860ee62859ddcb88e621f85a0752e7a39a40f74","user":{"login":"yargs","id":16504989,"avatar_url":"https://avatars.githubusercontent.com/u/16504989?v=3","gravatar_id":"","url":"https://api.github.com/users/yargs","html_url":"https://github.com/yargs","followers_url":"https://api.github.com/users/yargs/followers","following_url":"https://api.github.com/users/yargs/following{/other_user}","gists_url":"https://api.github.com/users/yargs/gists{/gist_id}","starred_url":"https://api.github.com/users/yargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yargs/subscriptions","organizations_url":"https://api.github.com/users/yargs/orgs","repos_url":"https://api.github.com/users/yargs/repos","events_url":"https://api.github.com/users/yargs/events{/privacy}","received_events_url":"https://api.github.com/users/yargs/received_events","type":"Organization","site_admin":false},"repo":{"id":50258379,"name":"yargs-parser","full_name":"yargs/yargs-parser","owner":{"login":"yargs","id":16504989,"avatar_url":"https://avatars.githubusercontent.com/u/16504989?v=3","gravatar_id":"","url":"https://api.github.com/users/yargs","html_url":"https://github.com/yargs","followers_url":"https://api.github.com/users/yargs/followers","following_url":"https://api.github.com/users/yargs/following{/other_user}","gists_url":"https://api.github.com/users/yargs/gists{/gist_id}","starred_url":"https://api.github.com/users/yargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yargs/subscriptions","organizations_url":"https://api.github.com/users/yargs/orgs","repos_url":"https://api.github.com/users/yargs/repos","events_url":"https://api.github.com/users/yargs/events{/privacy}","received_events_url":"https://api.github.com/users/yargs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yargs/yargs-parser","description":":muscle: the mighty option parser used by yargs","fork":false,"url":"https://api.github.com/repos/yargs/yargs-parser","forks_url":"https://api.github.com/repos/yargs/yargs-parser/forks","keys_url":"https://api.github.com/repos/yargs/yargs-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yargs/yargs-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yargs/yargs-parser/teams","hooks_url":"https://api.github.com/repos/yargs/yargs-parser/hooks","issue_events_url":"https://api.github.com/repos/yargs/yargs-parser/issues/events{/number}","events_url":"https://api.github.com/repos/yargs/yargs-parser/events","assignees_url":"https://api.github.com/repos/yargs/yargs-parser/assignees{/user}","branches_url":"https://api.github.com/repos/yargs/yargs-parser/branches{/branch}","tags_url":"https://api.github.com/repos/yargs/yargs-parser/tags","blobs_url":"https://api.github.com/repos/yargs/yargs-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yargs/yargs-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yargs/yargs-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/yargs/yargs-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yargs/yargs-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/yargs/yargs-parser/languages","stargazers_url":"https://api.github.com/repos/yargs/yargs-parser/stargazers","contributors_url":"https://api.github.com/repos/yargs/yargs-parser/contributors","subscribers_url":"https://api.github.com/repos/yargs/yargs-parser/subscribers","subscription_url":"https://api.github.com/repos/yargs/yargs-parser/subscription","commits_url":"https://api.github.com/repos/yargs/yargs-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/yargs/yargs-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/yargs/yargs-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/yargs/yargs-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/yargs/yargs-parser/contents/{+path}","compare_url":"https://api.github.com/repos/yargs/yargs-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yargs/yargs-parser/merges","archive_url":"https://api.github.com/repos/yargs/yargs-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yargs/yargs-parser/downloads","issues_url":"https://api.github.com/repos/yargs/yargs-parser/issues{/number}","pulls_url":"https://api.github.com/repos/yargs/yargs-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/yargs/yargs-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/yargs/yargs-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yargs/yargs-parser/labels{/name}","releases_url":"https://api.github.com/repos/yargs/yargs-parser/releases{/id}","deployments_url":"https://api.github.com/repos/yargs/yargs-parser/deployments","created_at":"2016-01-23T21:03:32Z","updated_at":"2016-02-04T01:00:18Z","pushed_at":"2016-02-14T02:40:36Z","git_url":"git://github.com/yargs/yargs-parser.git","ssh_url":"git@github.com:yargs/yargs-parser.git","clone_url":"https://github.com/yargs/yargs-parser.git","svn_url":"https://github.com/yargs/yargs-parser","homepage":"http://yargs.js.org/","size":48,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":22,"default_branch":"master"}},"base":{"label":"yargs:master","ref":"master","sha":"1c5dcebaa87e28a00d50a9255ea5035549f96d1e","user":{"login":"yargs","id":16504989,"avatar_url":"https://avatars.githubusercontent.com/u/16504989?v=3","gravatar_id":"","url":"https://api.github.com/users/yargs","html_url":"https://github.com/yargs","followers_url":"https://api.github.com/users/yargs/followers","following_url":"https://api.github.com/users/yargs/following{/other_user}","gists_url":"https://api.github.com/users/yargs/gists{/gist_id}","starred_url":"https://api.github.com/users/yargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yargs/subscriptions","organizations_url":"https://api.github.com/users/yargs/orgs","repos_url":"https://api.github.com/users/yargs/repos","events_url":"https://api.github.com/users/yargs/events{/privacy}","received_events_url":"https://api.github.com/users/yargs/received_events","type":"Organization","site_admin":false},"repo":{"id":50258379,"name":"yargs-parser","full_name":"yargs/yargs-parser","owner":{"login":"yargs","id":16504989,"avatar_url":"https://avatars.githubusercontent.com/u/16504989?v=3","gravatar_id":"","url":"https://api.github.com/users/yargs","html_url":"https://github.com/yargs","followers_url":"https://api.github.com/users/yargs/followers","following_url":"https://api.github.com/users/yargs/following{/other_user}","gists_url":"https://api.github.com/users/yargs/gists{/gist_id}","starred_url":"https://api.github.com/users/yargs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yargs/subscriptions","organizations_url":"https://api.github.com/users/yargs/orgs","repos_url":"https://api.github.com/users/yargs/repos","events_url":"https://api.github.com/users/yargs/events{/privacy}","received_events_url":"https://api.github.com/users/yargs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yargs/yargs-parser","description":":muscle: the mighty option parser used by yargs","fork":false,"url":"https://api.github.com/repos/yargs/yargs-parser","forks_url":"https://api.github.com/repos/yargs/yargs-parser/forks","keys_url":"https://api.github.com/repos/yargs/yargs-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yargs/yargs-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yargs/yargs-parser/teams","hooks_url":"https://api.github.com/repos/yargs/yargs-parser/hooks","issue_events_url":"https://api.github.com/repos/yargs/yargs-parser/issues/events{/number}","events_url":"https://api.github.com/repos/yargs/yargs-parser/events","assignees_url":"https://api.github.com/repos/yargs/yargs-parser/assignees{/user}","branches_url":"https://api.github.com/repos/yargs/yargs-parser/branches{/branch}","tags_url":"https://api.github.com/repos/yargs/yargs-parser/tags","blobs_url":"https://api.github.com/repos/yargs/yargs-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yargs/yargs-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yargs/yargs-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/yargs/yargs-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yargs/yargs-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/yargs/yargs-parser/languages","stargazers_url":"https://api.github.com/repos/yargs/yargs-parser/stargazers","contributors_url":"https://api.github.com/repos/yargs/yargs-parser/contributors","subscribers_url":"https://api.github.com/repos/yargs/yargs-parser/subscribers","subscription_url":"https://api.github.com/repos/yargs/yargs-parser/subscription","commits_url":"https://api.github.com/repos/yargs/yargs-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/yargs/yargs-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/yargs/yargs-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/yargs/yargs-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/yargs/yargs-parser/contents/{+path}","compare_url":"https://api.github.com/repos/yargs/yargs-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yargs/yargs-parser/merges","archive_url":"https://api.github.com/repos/yargs/yargs-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yargs/yargs-parser/downloads","issues_url":"https://api.github.com/repos/yargs/yargs-parser/issues{/number}","pulls_url":"https://api.github.com/repos/yargs/yargs-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/yargs/yargs-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/yargs/yargs-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yargs/yargs-parser/labels{/name}","releases_url":"https://api.github.com/repos/yargs/yargs-parser/releases{/id}","deployments_url":"https://api.github.com/repos/yargs/yargs-parser/deployments","created_at":"2016-01-23T21:03:32Z","updated_at":"2016-02-04T01:00:18Z","pushed_at":"2016-02-14T02:40:36Z","git_url":"git://github.com/yargs/yargs-parser.git","ssh_url":"git@github.com:yargs/yargs-parser.git","clone_url":"https://github.com/yargs/yargs-parser.git","svn_url":"https://github.com/yargs/yargs-parser","homepage":"http://yargs.js.org/","size":48,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yargs/yargs-parser/pulls/7"},"html":{"href":"https://github.com/yargs/yargs-parser/pull/7"},"issue":{"href":"https://api.github.com/repos/yargs/yargs-parser/issues/7"},"comments":{"href":"https://api.github.com/repos/yargs/yargs-parser/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/yargs/yargs-parser/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/yargs/yargs-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yargs/yargs-parser/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/yargs/yargs-parser/statuses/1860ee62859ddcb88e621f85a0752e7a39a40f74"}}}}