{"action":"created","issue":{"url":"https://api.github.com/repos/CCExtractor/ccextractor/issues/431","repository_url":"https://api.github.com/repos/CCExtractor/ccextractor","labels_url":"https://api.github.com/repos/CCExtractor/ccextractor/issues/431/labels{/name}","comments_url":"https://api.github.com/repos/CCExtractor/ccextractor/issues/431/comments","events_url":"https://api.github.com/repos/CCExtractor/ccextractor/issues/431/events","html_url":"https://github.com/CCExtractor/ccextractor/issues/431","id":180772444,"number":431,"title":"fps switching in HISTORY channel","user":{"login":"cfsmp3","id":5949913,"avatar_url":"https://avatars.githubusercontent.com/u/5949913?v=3","gravatar_id":"","url":"https://api.github.com/users/cfsmp3","html_url":"https://github.com/cfsmp3","followers_url":"https://api.github.com/users/cfsmp3/followers","following_url":"https://api.github.com/users/cfsmp3/following{/other_user}","gists_url":"https://api.github.com/users/cfsmp3/gists{/gist_id}","starred_url":"https://api.github.com/users/cfsmp3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfsmp3/subscriptions","organizations_url":"https://api.github.com/users/cfsmp3/orgs","repos_url":"https://api.github.com/users/cfsmp3/repos","events_url":"https://api.github.com/users/cfsmp3/events{/privacy}","received_events_url":"https://api.github.com/users/cfsmp3/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"cfsmp3","id":5949913,"avatar_url":"https://avatars.githubusercontent.com/u/5949913?v=3","gravatar_id":"","url":"https://api.github.com/users/cfsmp3","html_url":"https://github.com/cfsmp3","followers_url":"https://api.github.com/users/cfsmp3/followers","following_url":"https://api.github.com/users/cfsmp3/following{/other_user}","gists_url":"https://api.github.com/users/cfsmp3/gists{/gist_id}","starred_url":"https://api.github.com/users/cfsmp3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfsmp3/subscriptions","organizations_url":"https://api.github.com/users/cfsmp3/orgs","repos_url":"https://api.github.com/users/cfsmp3/repos","events_url":"https://api.github.com/users/cfsmp3/events{/privacy}","received_events_url":"https://api.github.com/users/cfsmp3/received_events","type":"User","site_admin":false},"assignees":[{"login":"cfsmp3","id":5949913,"avatar_url":"https://avatars.githubusercontent.com/u/5949913?v=3","gravatar_id":"","url":"https://api.github.com/users/cfsmp3","html_url":"https://github.com/cfsmp3","followers_url":"https://api.github.com/users/cfsmp3/followers","following_url":"https://api.github.com/users/cfsmp3/following{/other_user}","gists_url":"https://api.github.com/users/cfsmp3/gists{/gist_id}","starred_url":"https://api.github.com/users/cfsmp3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfsmp3/subscriptions","organizations_url":"https://api.github.com/users/cfsmp3/orgs","repos_url":"https://api.github.com/users/cfsmp3/repos","events_url":"https://api.github.com/users/cfsmp3/events{/privacy}","received_events_url":"https://api.github.com/users/cfsmp3/received_events","type":"User","site_admin":false},{"login":"anshul1912","id":7376410,"avatar_url":"https://avatars.githubusercontent.com/u/7376410?v=3","gravatar_id":"","url":"https://api.github.com/users/anshul1912","html_url":"https://github.com/anshul1912","followers_url":"https://api.github.com/users/anshul1912/followers","following_url":"https://api.github.com/users/anshul1912/following{/other_user}","gists_url":"https://api.github.com/users/anshul1912/gists{/gist_id}","starred_url":"https://api.github.com/users/anshul1912/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshul1912/subscriptions","organizations_url":"https://api.github.com/users/anshul1912/orgs","repos_url":"https://api.github.com/users/anshul1912/repos","events_url":"https://api.github.com/users/anshul1912/events{/privacy}","received_events_url":"https://api.github.com/users/anshul1912/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-10-03T23:28:14Z","updated_at":"2016-12-13T21:40:27Z","closed_at":"2016-12-13T21:40:27Z","body":"Processing a HISTORY (writing it in uppercase because it seems to be a big deal to them) TS we get this:\n\n 67%  |  00:16Changed fps using NAL to: 29.970030\n 72%  |  00:18Changed fps using NAL to: 29.970030\nrepeated lots of times\n\nA sample file:\nhttps://drive.google.com/file/d/0BxRlGXOr_NhUNmh0NXg3S2dHeFE/view?usp=sharing\n\nThe FPS changes to that value here:\n\nvoid seq_parameter_set_rbsp (struct avc_ctx *ctx, unsigned char *seqbuf, unsigned char *seqend)\n{\n[...]\n                if (current_fps != (double)time_scale / (2 \\* num_units_in_tick))\n                {\n                    current_fps = (double)time_scale / (2 \\* num_units_in_tick); // Based on formula D-2, p. 359 of the ISO/IEC 14496-10:2012(E) spec.\n                    mprint(\"Changed fps using NAL to: %f\\n\", current_fps);\n                }\n            }\n\nHowever it's going back to double that FPS (however it's not logged) here:\n\nvoid slice_header (struct lib_cc_decode *ctx, unsigned char *heabuf, unsigned char *heaend, int nal_unit_type, struct cc_subtitle *sub)\n{\n[...]\n            // TODO - Do this right.\n            // When bottom_field_flag is set the video is interlaced,\n            // override current_fps.\n            current_fps = framerates_values[7];\n\nWhere that TODO comment really seems to apply.\n"},"comment":{"url":"https://api.github.com/repos/CCExtractor/ccextractor/issues/comments/266870394","html_url":"https://github.com/CCExtractor/ccextractor/issues/431#issuecomment-266870394","issue_url":"https://api.github.com/repos/CCExtractor/ccextractor/issues/431","id":266870394,"user":{"login":"cfsmp3","id":5949913,"avatar_url":"https://avatars.githubusercontent.com/u/5949913?v=3","gravatar_id":"","url":"https://api.github.com/users/cfsmp3","html_url":"https://github.com/cfsmp3","followers_url":"https://api.github.com/users/cfsmp3/followers","following_url":"https://api.github.com/users/cfsmp3/following{/other_user}","gists_url":"https://api.github.com/users/cfsmp3/gists{/gist_id}","starred_url":"https://api.github.com/users/cfsmp3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfsmp3/subscriptions","organizations_url":"https://api.github.com/users/cfsmp3/orgs","repos_url":"https://api.github.com/users/cfsmp3/repos","events_url":"https://api.github.com/users/cfsmp3/events{/privacy}","received_events_url":"https://api.github.com/users/cfsmp3/received_events","type":"User","site_admin":false},"created_at":"2016-12-13T21:40:27Z","updated_at":"2016-12-13T21:40:27Z","body":"Confirmed fixed for HISTORY2.TS."}}
{"actor":{"display_login":"cfsmp3"}}