{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5268","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5268/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5268/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5268/events","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5268","id":152661961,"number":5268,"title":"Menus: Views for editing a MenuItem's source.","user":{"login":"kurzee","id":1873422,"avatar_url":"https://avatars.githubusercontent.com/u/1873422?v=3","gravatar_id":"","url":"https://api.github.com/users/kurzee","html_url":"https://github.com/kurzee","followers_url":"https://api.github.com/users/kurzee/followers","following_url":"https://api.github.com/users/kurzee/following{/other_user}","gists_url":"https://api.github.com/users/kurzee/gists{/gist_id}","starred_url":"https://api.github.com/users/kurzee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurzee/subscriptions","organizations_url":"https://api.github.com/users/kurzee/orgs","repos_url":"https://api.github.com/users/kurzee/repos","events_url":"https://api.github.com/users/kurzee/events{/privacy}","received_events_url":"https://api.github.com/users/kurzee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/labels/Menus","name":"Menus","color":"006b75"}],"state":"open","locked":false,"assignee":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/54","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/milestones/6.3","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/milestones/54/labels","id":1562509,"number":54,"title":"6.3","description":"","creator":{"login":"sendhil","id":437043,"avatar_url":"https://avatars.githubusercontent.com/u/437043?v=3","gravatar_id":"","url":"https://api.github.com/users/sendhil","html_url":"https://github.com/sendhil","followers_url":"https://api.github.com/users/sendhil/followers","following_url":"https://api.github.com/users/sendhil/following{/other_user}","gists_url":"https://api.github.com/users/sendhil/gists{/gist_id}","starred_url":"https://api.github.com/users/sendhil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendhil/subscriptions","organizations_url":"https://api.github.com/users/sendhil/orgs","repos_url":"https://api.github.com/users/sendhil/repos","events_url":"https://api.github.com/users/sendhil/events{/privacy}","received_events_url":"https://api.github.com/users/sendhil/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":28,"state":"open","created_at":"2016-02-04T04:45:27Z","updated_at":"2016-05-03T18:42:17Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2016-05-02T22:38:18Z","updated_at":"2016-05-03T18:47:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/pulls/5268","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5268","diff_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5268.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5268.patch"},"body":"Adding a collection of views responsible for handling the loading and selection of different sources a `MenuItem` can point to.\r\n\r\nUltimately, these views live within views not included in this PR: `MenuItemEditingViewController` and `MenuItemSourceContainerView`. I've broken up the PR flow to limit as many lines as possible between reviewers. For the sake of that, this PR focuses only on the source views included that live within the limited red area outlined here:\r\n\r\n![simulator screen shot may 2 2016 5 11 11 pm](https://cloud.githubusercontent.com/assets/1873422/14969656/1bc90ecc-1089-11e6-9c50-f8debd563a39.png)\r\n\r\n**To test:**\r\n\r\n1. Build and run the staging branch `feature/menus-views` to load the complete Menus implementation.\r\n2. Select a .com site with admin rights.\r\n3. Select \"Menus\" under the site options.\r\n4. Select a `MenuItem` to edit its source, such as \"Home\", \"About\", \"Blog\", etc.\r\n5. Source views are loaded as Pages, Posts, Link, Categories, Tags or Posts using [custom content types](https://jetpack.com/support/custom-content-types/).\r\n6. You can select different types by hitting the header area with the left chevron, which loads the corresponding sources in the correct source view.\r\n\r\n![menus_sources](https://cloud.githubusercontent.com/assets/1873422/14970152/73632fde-108c-11e6-8ae2-dc901c0bacd4.gif)\r\n\r\n**Pages**\r\n\r\n1. Test that pages load as expected for a site.\r\n2. Test that searching loads both local and remote pages.\r\n\r\n**Posts**\r\n\r\n1. Test that posts load as expected for a site.\r\n2. Test that searching loads both local and remote posts.\r\n3. Test that posts continue loading via paging when scrolling to the bottom for a site with many posts.\r\n\r\n**Link**\r\n\r\n1. Test that the \"LINK ADDRESS (URL)\" field accepts text as expected.\r\n2. Test that the \"Open new link\" checkbox checks and un-checks as expected.\r\n\r\n**Categories**\r\n\r\n1. Test that the categories load as expected for a site.\r\n2. Ensure the parent/child nesting is as expected for a site.\r\n\r\n**Tags**\r\n\r\n1. Test that the tags load as expected for a site.\r\n2. Test that searching tags loads both local and remote tags for a site as expected.\r\n3. Test that paging a long list of tags loads as expected for a site.\r\n\r\n**Custom Posts**\r\n\r\n1. Load some custom post types for a site/theme as noted in https://jetpack.com/support/custom-content-types/\r\n2. Create posts using these types on the site.\r\n3. Load the associated custom type with the app Menus editing.\r\n4. Test that the custom posts load as expected for the site.\r\n\r\nNeeds review: @aerych (let me know if you'd like me to break this up additionally)"},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/comments/216627137","html_url":"https://github.com/wordpress-mobile/WordPress-iOS/pull/5268#issuecomment-216627137","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-iOS/issues/5268","id":216627137,"user":{"login":"aerych","id":1435271,"avatar_url":"https://avatars.githubusercontent.com/u/1435271?v=3","gravatar_id":"","url":"https://api.github.com/users/aerych","html_url":"https://github.com/aerych","followers_url":"https://api.github.com/users/aerych/followers","following_url":"https://api.github.com/users/aerych/following{/other_user}","gists_url":"https://api.github.com/users/aerych/gists{/gist_id}","starred_url":"https://api.github.com/users/aerych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerych/subscriptions","organizations_url":"https://api.github.com/users/aerych/orgs","repos_url":"https://api.github.com/users/aerych/repos","events_url":"https://api.github.com/users/aerych/events{/privacy}","received_events_url":"https://api.github.com/users/aerych/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T18:47:33Z","updated_at":"2016-05-03T18:47:33Z","body":"Another random observation.  Should the trash icon be red? <img width=\"553\" alt=\"screen shot 2016-05-03 at 1 43 45 pm\" src=\"https://cloud.githubusercontent.com/assets/1435271/14994425/8a0c7e08-1135-11e6-9f8f-24512107b49a.png\">\r\n"}}