{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/86675551","pull_request_review_id":7323745,"id":86675551,"diff_hunk":"@@ -25,15 +25,30 @@ bundle_test_unit() {\n \telse\n \t\tTEST_PATH=./${TESTDIRS}\n \tfi\n-\tpkg_list=$(go list -e \\\n-\t\t-f '{{if ne .Name \"github.com/docker/docker\"}}\n-\t\t\t{{.ImportPath}}\n-\t\t    {{end}}' \\\n-\t\t\"${BUILDFLAGS[@]}\" $TEST_PATH \\\n-\t\t| grep github.com/docker/docker \\\n-\t\t| grep -v github.com/docker/docker/vendor \\\n-\t\t| grep -v github.com/docker/docker/man \\\n-\t\t| grep -v github.com/docker/docker/integration-cli)\n+\n+\tif [ \"$(go env GOHOSTOS)\" = 'solaris' ]; then\n+\t\tpkg_list=$(go list -e \\\n+\t\t\t-f '{{if ne .Name \"github.com/docker/docker\"}}\n+\t\t\t\t{{.ImportPath}}\n+\t\t\t    {{end}}' \\\n+\t\t\t\"${BUILDFLAGS[@]}\" $TEST_PATH \\\n+\t\t\t| grep github.com/docker/docker \\\n+\t\t\t| grep -v github.com/docker/docker/vendor \\\n+\t\t\t| grep -v github.com/docker/docker/daemon/graphdriver \\","path":"hack/make/test-unit","position":22,"original_position":22,"commit_id":"68e6345c9b5638a6840ea6c2cf3217d5369bfe05","original_commit_id":"68e6345c9b5638a6840ea6c2cf3217d5369bfe05","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"@amitkris shouldn't we hide tests behind tag? This really looks bad.","created_at":"2016-11-05T23:41:31Z","updated_at":"2016-11-05T23:41:31Z","html_url":"https://github.com/docker/docker/pull/28056#discussion_r86675551","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/28056","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/86675551"},"html":{"href":"https://github.com/docker/docker/pull/28056#discussion_r86675551"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/28056"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28056","id":92272284,"html_url":"https://github.com/docker/docker/pull/28056","diff_url":"https://github.com/docker/docker/pull/28056.diff","patch_url":"https://github.com/docker/docker/pull/28056.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/28056","number":28056,"state":"open","locked":false,"title":"Add functional support for Docker sub commands on Solaris","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"body":"This is the carry of #23397 to free @amitkris from hell of a rebase. That PR was in merged state, so we can merge this when CI will pass.\r\nCloses #23397 ","created_at":"2016-11-04T01:55:19Z","updated_at":"2016-11-05T23:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"584b6df799426aa1dbaa0d77e66a83b16555d8da","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":112,"closed_issues":596,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-05T22:29:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/docker/docker/pulls/28056/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/28056/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/28056/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/68e6345c9b5638a6840ea6c2cf3217d5369bfe05","head":{"label":"LK4D4:solaris_me","ref":"solaris_me","sha":"68e6345c9b5638a6840ea6c2cf3217d5369bfe05","user":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"repo":{"id":17854886,"name":"docker","full_name":"LK4D4/docker","owner":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LK4D4/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/LK4D4/docker","forks_url":"https://api.github.com/repos/LK4D4/docker/forks","keys_url":"https://api.github.com/repos/LK4D4/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LK4D4/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LK4D4/docker/teams","hooks_url":"https://api.github.com/repos/LK4D4/docker/hooks","issue_events_url":"https://api.github.com/repos/LK4D4/docker/issues/events{/number}","events_url":"https://api.github.com/repos/LK4D4/docker/events","assignees_url":"https://api.github.com/repos/LK4D4/docker/assignees{/user}","branches_url":"https://api.github.com/repos/LK4D4/docker/branches{/branch}","tags_url":"https://api.github.com/repos/LK4D4/docker/tags","blobs_url":"https://api.github.com/repos/LK4D4/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LK4D4/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LK4D4/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/LK4D4/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LK4D4/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/LK4D4/docker/languages","stargazers_url":"https://api.github.com/repos/LK4D4/docker/stargazers","contributors_url":"https://api.github.com/repos/LK4D4/docker/contributors","subscribers_url":"https://api.github.com/repos/LK4D4/docker/subscribers","subscription_url":"https://api.github.com/repos/LK4D4/docker/subscription","commits_url":"https://api.github.com/repos/LK4D4/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/LK4D4/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/LK4D4/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/LK4D4/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/LK4D4/docker/contents/{+path}","compare_url":"https://api.github.com/repos/LK4D4/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LK4D4/docker/merges","archive_url":"https://api.github.com/repos/LK4D4/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LK4D4/docker/downloads","issues_url":"https://api.github.com/repos/LK4D4/docker/issues{/number}","pulls_url":"https://api.github.com/repos/LK4D4/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/LK4D4/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/LK4D4/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LK4D4/docker/labels{/name}","releases_url":"https://api.github.com/repos/LK4D4/docker/releases{/id}","deployments_url":"https://api.github.com/repos/LK4D4/docker/deployments","created_at":"2014-03-18T05:30:16Z","updated_at":"2016-09-22T12:08:34Z","pushed_at":"2016-11-05T23:40:04Z","git_url":"git://github.com/LK4D4/docker.git","ssh_url":"git@github.com:LK4D4/docker.git","clone_url":"https://github.com/LK4D4/docker.git","svn_url":"https://github.com/LK4D4/docker","homepage":"http://www.docker.io","size":108306,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"c5ceb0f945d390500a0045b14ffe4dcecfe46a85","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","deployments_url":"https://api.github.com/repos/docker/docker/deployments","created_at":"2013-01-18T18:10:57Z","updated_at":"2016-11-05T22:35:09Z","pushed_at":"2016-11-05T23:40:06Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":219179,"stargazers_count":36618,"watchers_count":36618,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10800,"mirror_url":null,"open_issues_count":1884,"forks":10800,"open_issues":1884,"watchers":36618,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/28056"},"html":{"href":"https://github.com/docker/docker/pull/28056"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/28056"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/28056/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/28056/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/28056/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/68e6345c9b5638a6840ea6c2cf3217d5369bfe05"}}}}
{"actor":{"display_login":"LK4D4"}}