{"action":"created","issue":{"url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/issues/32","repository_url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework","labels_url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/issues/32/comments","events_url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/issues/32/events","html_url":"https://github.com/IdentityServer/IdentityServer4.EntityFramework/issues/32","id":185803609,"number":32,"title":"Set lengths on indexed fields (for SQL Server, at least)","user":{"login":"ChrisSimmons","id":301247,"avatar_url":"https://avatars.githubusercontent.com/u/301247?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisSimmons","html_url":"https://github.com/ChrisSimmons","followers_url":"https://api.github.com/users/ChrisSimmons/followers","following_url":"https://api.github.com/users/ChrisSimmons/following{/other_user}","gists_url":"https://api.github.com/users/ChrisSimmons/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisSimmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisSimmons/subscriptions","organizations_url":"https://api.github.com/users/ChrisSimmons/orgs","repos_url":"https://api.github.com/users/ChrisSimmons/repos","events_url":"https://api.github.com/users/ChrisSimmons/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisSimmons/received_events","type":"User","site_admin":false},"labels":[{"id":425114649,"url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/labels/question","name":"question","color":"cc317c","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-27T23:17:32Z","updated_at":"2016-11-30T01:34:01Z","closed_at":null,"body":"Perhaps tangentially-related to #1, but the properties on which indexes are based should have reasonable max lengths.  For example, here is the output of the create script after migrating to current:\n\n``` text\nWarning! The maximum key length is 900 bytes. The index 'PK_PersistedGrants' has maximum length of 1800 bytes. For some combination of large values, the insert/update operation will fail.\nWarning! The maximum key length is 900 bytes. The index 'IX_PersistedGrants_SubjectId_ClientId' has maximum length of 1300 bytes. For some combination of large values, the insert/update operation will fail.\nWarning! The maximum key length is 900 bytes. The index 'IX_PersistedGrants_SubjectId_ClientId_Type' has maximum length of 2200 bytes. For some combination of large values, the insert/update operation will fail.\n```\n\nThis is because `PersistedGrant.ClientId` is hard-limited to a width of 200 and `SubjectId`, `Key`, and `Type` are all limited to a length of 450 by EF Core itself (see [this](https://docs.efproject.net/en/latest/modeling/max-length.html#conventions)).\n\nI know there was talk in #1 about putting limits like this in IdentityServer4 itself?\n"},"comment":{"url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/issues/comments/263756186","html_url":"https://github.com/IdentityServer/IdentityServer4.EntityFramework/issues/32#issuecomment-263756186","issue_url":"https://api.github.com/repos/IdentityServer/IdentityServer4.EntityFramework/issues/32","id":263756186,"user":{"login":"brockallen","id":649492,"avatar_url":"https://avatars.githubusercontent.com/u/649492?v=3","gravatar_id":"","url":"https://api.github.com/users/brockallen","html_url":"https://github.com/brockallen","followers_url":"https://api.github.com/users/brockallen/followers","following_url":"https://api.github.com/users/brockallen/following{/other_user}","gists_url":"https://api.github.com/users/brockallen/gists{/gist_id}","starred_url":"https://api.github.com/users/brockallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brockallen/subscriptions","organizations_url":"https://api.github.com/users/brockallen/orgs","repos_url":"https://api.github.com/users/brockallen/repos","events_url":"https://api.github.com/users/brockallen/events{/privacy}","received_events_url":"https://api.github.com/users/brockallen/received_events","type":"User","site_admin":false},"created_at":"2016-11-30T01:34:01Z","updated_at":"2016-11-30T01:34:01Z","body":"Ok, I set Key to 200, Type to 50, Subject to 200, and ClientId was already 200. Sound legit?"}}
{"actor":{"display_login":"brockallen"}}