{"action":"closed","number":17671,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17671","id":81016870,"html_url":"https://github.com/NixOS/nixpkgs/pull/17671","diff_url":"https://github.com/NixOS/nixpkgs/pull/17671.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/17671.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17671","number":17671,"state":"closed","locked":false,"title":"llvm-3.8: build shared library on darwin","user":{"login":"acowley","id":124545,"avatar_url":"https://avatars.githubusercontent.com/u/124545?v=3","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nSupport dynamically linking LLVM as a library on darwin.\r\n\r\n###### Things done\r\n\r\n- [ ] Tested using sandboxing\r\n  ([nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS,\r\n    or option `build-use-chroot` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [x] OS X\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n\r\n- Enable the shared library build on darwin by default to match other\r\n  platforms.\r\n\r\n- Fix the dylib file's name in the store\r\n\r\n- Symlink a versioned name as some tooling expects this.","created_at":"2016-08-11T19:33:35Z","updated_at":"2016-08-17T11:43:57Z","closed_at":"2016-08-17T11:43:57Z","merged_at":"2016-08-17T11:43:57Z","merge_commit_sha":"29572c28a39b6c1aec15fccf324cbb6d75228988","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17671/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17671/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/17671/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/aedb3fcc87051158878a272fff43f9672bf80388","head":{"label":"acowley:llvm_38-shared","ref":"llvm_38-shared","sha":"aedb3fcc87051158878a272fff43f9672bf80388","user":{"login":"acowley","id":124545,"avatar_url":"https://avatars.githubusercontent.com/u/124545?v=3","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"repo":{"id":39473412,"name":"nixpkgs","full_name":"acowley/nixpkgs","owner":{"login":"acowley","id":124545,"avatar_url":"https://avatars.githubusercontent.com/u/124545?v=3","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acowley/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/acowley/nixpkgs","forks_url":"https://api.github.com/repos/acowley/nixpkgs/forks","keys_url":"https://api.github.com/repos/acowley/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acowley/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acowley/nixpkgs/teams","hooks_url":"https://api.github.com/repos/acowley/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/acowley/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/acowley/nixpkgs/events","assignees_url":"https://api.github.com/repos/acowley/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/acowley/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/acowley/nixpkgs/tags","blobs_url":"https://api.github.com/repos/acowley/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acowley/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acowley/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/acowley/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acowley/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/acowley/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/acowley/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/acowley/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/acowley/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/acowley/nixpkgs/subscription","commits_url":"https://api.github.com/repos/acowley/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/acowley/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/acowley/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/acowley/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/acowley/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/acowley/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acowley/nixpkgs/merges","archive_url":"https://api.github.com/repos/acowley/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acowley/nixpkgs/downloads","issues_url":"https://api.github.com/repos/acowley/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/acowley/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/acowley/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/acowley/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acowley/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/acowley/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/acowley/nixpkgs/deployments","created_at":"2015-07-21T22:41:17Z","updated_at":"2016-01-19T22:27:23Z","pushed_at":"2016-08-11T19:32:07Z","git_url":"git://github.com/acowley/nixpkgs.git","ssh_url":"git@github.com:acowley/nixpkgs.git","clone_url":"https://github.com/acowley/nixpkgs.git","svn_url":"https://github.com/acowley/nixpkgs","homepage":null,"size":330661,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"a97df891fee47f9eda8145f2485c0d7673916fde","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-08-16T17:03:43Z","pushed_at":"2016-08-17T11:43:57Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":570274,"stargazers_count":1253,"watchers_count":1253,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1561,"mirror_url":null,"open_issues_count":1494,"forks":1561,"open_issues":1494,"watchers":1253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17671"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/17671"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/17671"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/17671/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17671/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/17671/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/aedb3fcc87051158878a272fff43f9672bf80388"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"garbas","id":20208,"avatar_url":"https://avatars.githubusercontent.com/u/20208?v=3","gravatar_id":"","url":"https://api.github.com/users/garbas","html_url":"https://github.com/garbas","followers_url":"https://api.github.com/users/garbas/followers","following_url":"https://api.github.com/users/garbas/following{/other_user}","gists_url":"https://api.github.com/users/garbas/gists{/gist_id}","starred_url":"https://api.github.com/users/garbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbas/subscriptions","organizations_url":"https://api.github.com/users/garbas/orgs","repos_url":"https://api.github.com/users/garbas/repos","events_url":"https://api.github.com/users/garbas/events{/privacy}","received_events_url":"https://api.github.com/users/garbas/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"garbas"}}