{"action":"created","comment":{"url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/comments/87439607","pull_request_review_id":8053300,"id":87439607,"diff_hunk":"@@ -28,25 +39,27 @@\n     private Node realTimeValue;\n     private String watchedPath;\n \n-    private Node lastWrittenValue;\n     private Node startDate;\n     private Node endDate;\n     private boolean enabled;\n \n     // Values that must be handled before the buffer queue\n     private long lastWrittenTime;\n+\n+    // Used to represent last value to the database\n+    private Node lastWrittenValue;\n+\n+    // Used for POINT_CHANGE\n     private Value lastValue;\n \n     public WatchUpdate getLastWatchUpdate() {\n-        if (lastWatchUpdate == null) {","path":"sdk/historian/src/main/java/org/dsa/iot/historian/database/Watch.java","position":61,"original_position":61,"commit_id":"9a03bdf865345fa93e558160da56e4037f28f5df","original_commit_id":"9a03bdf865345fa93e558160da56e4037f28f5df","user":{"login":"Pacane","id":2762440,"avatar_url":"https://avatars.githubusercontent.com/u/2762440?v=3","gravatar_id":"","url":"https://api.github.com/users/Pacane","html_url":"https://github.com/Pacane","followers_url":"https://api.github.com/users/Pacane/followers","following_url":"https://api.github.com/users/Pacane/following{/other_user}","gists_url":"https://api.github.com/users/Pacane/gists{/gist_id}","starred_url":"https://api.github.com/users/Pacane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pacane/subscriptions","organizations_url":"https://api.github.com/users/Pacane/orgs","repos_url":"https://api.github.com/users/Pacane/repos","events_url":"https://api.github.com/users/Pacane/events{/privacy}","received_events_url":"https://api.github.com/users/Pacane/received_events","type":"User","site_admin":false},"body":"That's basically that. However, I haven't tested changing the value in-between. Could be a great test to write, however it's a bit hard, since this error didn't happen consistant way.","created_at":"2016-11-10T17:07:04Z","updated_at":"2016-11-10T17:07:04Z","html_url":"https://github.com/IOT-DSA/sdk-dslink-java/pull/61#discussion_r87439607","pull_request_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/comments/87439607"},"html":{"href":"https://github.com/IOT-DSA/sdk-dslink-java/pull/61#discussion_r87439607"},"pull_request":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61","id":93053390,"html_url":"https://github.com/IOT-DSA/sdk-dslink-java/pull/61","diff_url":"https://github.com/IOT-DSA/sdk-dslink-java/pull/61.diff","patch_url":"https://github.com/IOT-DSA/sdk-dslink-java/pull/61.patch","issue_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/61","number":61,"state":"open","locked":false,"title":"Fix duplicate data history","user":{"login":"Pacane","id":2762440,"avatar_url":"https://avatars.githubusercontent.com/u/2762440?v=3","gravatar_id":"","url":"https://api.github.com/users/Pacane","html_url":"https://github.com/Pacane","followers_url":"https://api.github.com/users/Pacane/followers","following_url":"https://api.github.com/users/Pacane/following{/other_user}","gists_url":"https://api.github.com/users/Pacane/gists{/gist_id}","starred_url":"https://api.github.com/users/Pacane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pacane/subscriptions","organizations_url":"https://api.github.com/users/Pacane/orgs","repos_url":"https://api.github.com/users/Pacane/repos","events_url":"https://api.github.com/users/Pacane/events{/privacy}","received_events_url":"https://api.github.com/users/Pacane/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-09T22:43:42Z","updated_at":"2016-11-10T17:07:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5855ab288e09d20560638b6fda1eb9c1f93b051e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61/commits","review_comments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61/comments","review_comment_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/61/comments","statuses_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/statuses/9a03bdf865345fa93e558160da56e4037f28f5df","head":{"label":"IOT-DSA:jth_fix_duplicate_data_history","ref":"jth_fix_duplicate_data_history","sha":"9a03bdf865345fa93e558160da56e4037f28f5df","user":{"login":"IOT-DSA","id":10178994,"avatar_url":"https://avatars.githubusercontent.com/u/10178994?v=3","gravatar_id":"","url":"https://api.github.com/users/IOT-DSA","html_url":"https://github.com/IOT-DSA","followers_url":"https://api.github.com/users/IOT-DSA/followers","following_url":"https://api.github.com/users/IOT-DSA/following{/other_user}","gists_url":"https://api.github.com/users/IOT-DSA/gists{/gist_id}","starred_url":"https://api.github.com/users/IOT-DSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOT-DSA/subscriptions","organizations_url":"https://api.github.com/users/IOT-DSA/orgs","repos_url":"https://api.github.com/users/IOT-DSA/repos","events_url":"https://api.github.com/users/IOT-DSA/events{/privacy}","received_events_url":"https://api.github.com/users/IOT-DSA/received_events","type":"Organization","site_admin":false},"repo":{"id":28900548,"name":"sdk-dslink-java","full_name":"IOT-DSA/sdk-dslink-java","owner":{"login":"IOT-DSA","id":10178994,"avatar_url":"https://avatars.githubusercontent.com/u/10178994?v=3","gravatar_id":"","url":"https://api.github.com/users/IOT-DSA","html_url":"https://github.com/IOT-DSA","followers_url":"https://api.github.com/users/IOT-DSA/followers","following_url":"https://api.github.com/users/IOT-DSA/following{/other_user}","gists_url":"https://api.github.com/users/IOT-DSA/gists{/gist_id}","starred_url":"https://api.github.com/users/IOT-DSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOT-DSA/subscriptions","organizations_url":"https://api.github.com/users/IOT-DSA/orgs","repos_url":"https://api.github.com/users/IOT-DSA/repos","events_url":"https://api.github.com/users/IOT-DSA/events{/privacy}","received_events_url":"https://api.github.com/users/IOT-DSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IOT-DSA/sdk-dslink-java","description":"DSLink Java SDK","fork":false,"url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java","forks_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/forks","keys_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/teams","hooks_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/hooks","issue_events_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/events{/number}","events_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/events","assignees_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/assignees{/user}","branches_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/branches{/branch}","tags_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/tags","blobs_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/statuses/{sha}","languages_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/languages","stargazers_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/stargazers","contributors_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/contributors","subscribers_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/subscribers","subscription_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/subscription","commits_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/contents/{+path}","compare_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/merges","archive_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/downloads","issues_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues{/number}","pulls_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls{/number}","milestones_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/milestones{/number}","notifications_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/labels{/name}","releases_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/releases{/id}","deployments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/deployments","created_at":"2015-01-07T05:51:34Z","updated_at":"2016-11-07T07:24:29Z","pushed_at":"2016-11-10T16:57:59Z","git_url":"git://github.com/IOT-DSA/sdk-dslink-java.git","ssh_url":"git@github.com:IOT-DSA/sdk-dslink-java.git","clone_url":"https://github.com/IOT-DSA/sdk-dslink-java.git","svn_url":"https://github.com/IOT-DSA/sdk-dslink-java","homepage":"","size":2553,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":9,"default_branch":"master"}},"base":{"label":"IOT-DSA:master","ref":"master","sha":"238f426642ca608e2b166895f160c1a0c1353718","user":{"login":"IOT-DSA","id":10178994,"avatar_url":"https://avatars.githubusercontent.com/u/10178994?v=3","gravatar_id":"","url":"https://api.github.com/users/IOT-DSA","html_url":"https://github.com/IOT-DSA","followers_url":"https://api.github.com/users/IOT-DSA/followers","following_url":"https://api.github.com/users/IOT-DSA/following{/other_user}","gists_url":"https://api.github.com/users/IOT-DSA/gists{/gist_id}","starred_url":"https://api.github.com/users/IOT-DSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOT-DSA/subscriptions","organizations_url":"https://api.github.com/users/IOT-DSA/orgs","repos_url":"https://api.github.com/users/IOT-DSA/repos","events_url":"https://api.github.com/users/IOT-DSA/events{/privacy}","received_events_url":"https://api.github.com/users/IOT-DSA/received_events","type":"Organization","site_admin":false},"repo":{"id":28900548,"name":"sdk-dslink-java","full_name":"IOT-DSA/sdk-dslink-java","owner":{"login":"IOT-DSA","id":10178994,"avatar_url":"https://avatars.githubusercontent.com/u/10178994?v=3","gravatar_id":"","url":"https://api.github.com/users/IOT-DSA","html_url":"https://github.com/IOT-DSA","followers_url":"https://api.github.com/users/IOT-DSA/followers","following_url":"https://api.github.com/users/IOT-DSA/following{/other_user}","gists_url":"https://api.github.com/users/IOT-DSA/gists{/gist_id}","starred_url":"https://api.github.com/users/IOT-DSA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IOT-DSA/subscriptions","organizations_url":"https://api.github.com/users/IOT-DSA/orgs","repos_url":"https://api.github.com/users/IOT-DSA/repos","events_url":"https://api.github.com/users/IOT-DSA/events{/privacy}","received_events_url":"https://api.github.com/users/IOT-DSA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IOT-DSA/sdk-dslink-java","description":"DSLink Java SDK","fork":false,"url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java","forks_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/forks","keys_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/teams","hooks_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/hooks","issue_events_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/events{/number}","events_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/events","assignees_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/assignees{/user}","branches_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/branches{/branch}","tags_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/tags","blobs_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/statuses/{sha}","languages_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/languages","stargazers_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/stargazers","contributors_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/contributors","subscribers_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/subscribers","subscription_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/subscription","commits_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/contents/{+path}","compare_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/merges","archive_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/downloads","issues_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues{/number}","pulls_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls{/number}","milestones_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/milestones{/number}","notifications_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/labels{/name}","releases_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/releases{/id}","deployments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/deployments","created_at":"2015-01-07T05:51:34Z","updated_at":"2016-11-07T07:24:29Z","pushed_at":"2016-11-10T16:57:59Z","git_url":"git://github.com/IOT-DSA/sdk-dslink-java.git","ssh_url":"git@github.com:IOT-DSA/sdk-dslink-java.git","clone_url":"https://github.com/IOT-DSA/sdk-dslink-java.git","svn_url":"https://github.com/IOT-DSA/sdk-dslink-java","homepage":"","size":2553,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":8,"forks":8,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61"},"html":{"href":"https://github.com/IOT-DSA/sdk-dslink-java/pull/61"},"issue":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/61"},"comments":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/IOT-DSA/sdk-dslink-java/statuses/9a03bdf865345fa93e558160da56e4037f28f5df"}}}}
{"actor":{"display_login":"Pacane"}}