{"action":"opened","issue":{"url":"https://api.github.com/repos/robincornelius/libedssharp/issues/11","repository_url":"https://api.github.com/repos/robincornelius/libedssharp","labels_url":"https://api.github.com/repos/robincornelius/libedssharp/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/robincornelius/libedssharp/issues/11/comments","events_url":"https://api.github.com/repos/robincornelius/libedssharp/issues/11/events","html_url":"https://github.com/robincornelius/libedssharp/issues/11","id":186808565,"number":11,"title":"Arrays of record sets not created correctly in CO_OD.h","user":{"login":"robincornelius","id":159000,"avatar_url":"https://avatars.githubusercontent.com/u/159000?v=3","gravatar_id":"","url":"https://api.github.com/users/robincornelius","html_url":"https://github.com/robincornelius","followers_url":"https://api.github.com/users/robincornelius/followers","following_url":"https://api.github.com/users/robincornelius/following{/other_user}","gists_url":"https://api.github.com/users/robincornelius/gists{/gist_id}","starred_url":"https://api.github.com/users/robincornelius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robincornelius/subscriptions","organizations_url":"https://api.github.com/users/robincornelius/orgs","repos_url":"https://api.github.com/users/robincornelius/repos","events_url":"https://api.github.com/users/robincornelius/events{/privacy}","received_events_url":"https://api.github.com/users/robincornelius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-02T14:01:18Z","updated_at":"2016-11-02T14:01:18Z","closed_at":null,"body":"They are a special case anyway but we currently have :-\r\n\r\n*1600, Data Type: RPDOMappingParameter_t */\r\n        #define OD_RPDOMappingParameter                             CO_OD_ROM.RPDOMappingParameter\r\n\r\n/*1601, Data Type: RPDOMappingParameter_t */\r\n        #define OD_RPDOMappingParameter                             CO_OD_ROM.RPDOMappingParameter\r\n\r\n/*1602, Data Type: RPDOMappingParameter_t */\r\n        #define OD_RPDOMappingParameter                             CO_OD_ROM.RPDOMappingParameter\r\n\r\n/*1603, Data Type: RPDOMappingParameter_t */\r\n        #define OD_RPDOMappingParameter                             CO_OD_ROM.RPDOMappingParameter\r\n\r\n\r\nand if we compare to the reference implementation from CanOpenNode it looks like -\r\n\r\n/*1600[4], Data Type: OD_RPDOMappingParameter_t, Array[4] */\r\n      #define OD_RPDOMappingParameter                    CO_OD_ROM.RPDOMappingParameter\r\n\r\n\r\nNothing is actually broken in the existing code but the defines it is generating are messy and don't reflect its really an array. Not sure the best way to handle this as the whole handling of arrays of records is a odditity anyway and not strictly within the canopen spec but more to do with the CanOpenNode implementation.\r\n"}}
{"actor":{"display_login":"robincornelius"}}