{"action":"created","comment":{"url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/comments/51445483","id":51445483,"diff_hunk":"@@ -1,12 +0,0 @@\n-language: c","path":".travis.yml","position":1,"original_position":1,"commit_id":"0be4b1c2bd01a17302ec625bccf07de083e1963e","original_commit_id":"0be4b1c2bd01a17302ec625bccf07de083e1963e","user":{"login":"toddtreece","id":360020,"avatar_url":"https://avatars.githubusercontent.com/u/360020?v=3","gravatar_id":"","url":"https://api.github.com/users/toddtreece","html_url":"https://github.com/toddtreece","followers_url":"https://api.github.com/users/toddtreece/followers","following_url":"https://api.github.com/users/toddtreece/following{/other_user}","gists_url":"https://api.github.com/users/toddtreece/gists{/gist_id}","starred_url":"https://api.github.com/users/toddtreece/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddtreece/subscriptions","organizations_url":"https://api.github.com/users/toddtreece/orgs","repos_url":"https://api.github.com/users/toddtreece/repos","events_url":"https://api.github.com/users/toddtreece/events{/privacy}","received_events_url":"https://api.github.com/users/toddtreece/received_events","type":"User","site_admin":false},"body":"no worries at all, and thanks for sharing your work! could you add the `.travis.yml` back to your fork when you get a chance? it would help us double check the pull req.","created_at":"2016-02-01T16:57:38Z","updated_at":"2016-02-01T16:57:38Z","html_url":"https://github.com/adafruit/Adafruit_MQTT_Library/pull/28#discussion_r51445483","pull_request_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/comments/51445483"},"html":{"href":"https://github.com/adafruit/Adafruit_MQTT_Library/pull/28#discussion_r51445483"},"pull_request":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28","id":57793497,"html_url":"https://github.com/adafruit/Adafruit_MQTT_Library/pull/28","diff_url":"https://github.com/adafruit/Adafruit_MQTT_Library/pull/28.diff","patch_url":"https://github.com/adafruit/Adafruit_MQTT_Library/pull/28.patch","issue_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues/28","number":28,"state":"open","locked":false,"title":"Arbitrary data publish","user":{"login":"stuthedew","id":3359688,"avatar_url":"https://avatars.githubusercontent.com/u/3359688?v=3","gravatar_id":"","url":"https://api.github.com/users/stuthedew","html_url":"https://github.com/stuthedew","followers_url":"https://api.github.com/users/stuthedew/followers","following_url":"https://api.github.com/users/stuthedew/following{/other_user}","gists_url":"https://api.github.com/users/stuthedew/gists{/gist_id}","starred_url":"https://api.github.com/users/stuthedew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuthedew/subscriptions","organizations_url":"https://api.github.com/users/stuthedew/orgs","repos_url":"https://api.github.com/users/stuthedew/repos","events_url":"https://api.github.com/users/stuthedew/events{/privacy}","received_events_url":"https://api.github.com/users/stuthedew/received_events","type":"User","site_admin":false},"body":"I added a method to publish arbitrary data in addition to the publish methods currently provided (int32_t, double, uint32_t and const char). I've also included a new example sketch showing how to use it. I reworked the backend of the library a little to unify things a little and eliminate redundant code, but I've tested it using Adafruit IO with all existing publish methods, and nothing seems broken! It should (fingers crossed) be a drop-in replacement for the current library.\r\n\r\n![img_2667](https://cloud.githubusercontent.com/assets/3359688/12708161/38fdd316-c862-11e5-9cd9-92597176d7fc.jpg)\r\n\r\nMy motivation for this was wanting to be able to include metadata to a post.\r\nSpecifically, I was playing around with a [Teviso RD3024 radiation sensor](http://www.teviso.com/en/products/radiation-sensor-rd3024.htm) hooked up to your Huzzah ESP8266, and a salvaged Americium radiation source from a smoke detector, at varying distances from the sensor. I wanted a way to associate the collection time, and distance between the source and sensor with the actual radiation reading itself. I wrote a python-based daemon running on a Raspberry Pi (similar to the example mentioned above) to subscribe to the feed (Mosquito-based, also on Raspberry Pi), parse the data and insert it into a MySQL database running on the Pi as well. I then used Tableau on my Macbook to connect to the Pi/MySQL database and graph the data.\r\n\r\n![rad vs distance](https://cloud.githubusercontent.com/assets/3359688/12708116/b67b5fb2-c861-11e5-8fab-c112b5a85c49.png)\r\n\r\nAdafruit's libraries and resources are absolutely awesome, and I'm so appreciative of all the work you guys do. Being an entirely self-taught with no formal coding background (I'm a medical student), I regularly look at the work you guys do to get an idea of what quality coding looks like for my own projects. While I can't promise that this reflects the level of coding you regularly produce, I just thought I would pass this along it might be useful to someone. Thanks!","created_at":"2016-02-01T03:37:28Z","updated_at":"2016-02-01T16:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a960fb2e0f3f4d6117a342828e66642d42e4c06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28/commits","review_comments_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28/comments","review_comment_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues/28/comments","statuses_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/statuses/0be4b1c2bd01a17302ec625bccf07de083e1963e","head":{"label":"stuthedew:Arbitrary_data_publish","ref":"Arbitrary_data_publish","sha":"0be4b1c2bd01a17302ec625bccf07de083e1963e","user":{"login":"stuthedew","id":3359688,"avatar_url":"https://avatars.githubusercontent.com/u/3359688?v=3","gravatar_id":"","url":"https://api.github.com/users/stuthedew","html_url":"https://github.com/stuthedew","followers_url":"https://api.github.com/users/stuthedew/followers","following_url":"https://api.github.com/users/stuthedew/following{/other_user}","gists_url":"https://api.github.com/users/stuthedew/gists{/gist_id}","starred_url":"https://api.github.com/users/stuthedew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuthedew/subscriptions","organizations_url":"https://api.github.com/users/stuthedew/orgs","repos_url":"https://api.github.com/users/stuthedew/repos","events_url":"https://api.github.com/users/stuthedew/events{/privacy}","received_events_url":"https://api.github.com/users/stuthedew/received_events","type":"User","site_admin":false},"repo":{"id":49840595,"name":"Adafruit_MQTT_Library","full_name":"stuthedew/Adafruit_MQTT_Library","owner":{"login":"stuthedew","id":3359688,"avatar_url":"https://avatars.githubusercontent.com/u/3359688?v=3","gravatar_id":"","url":"https://api.github.com/users/stuthedew","html_url":"https://github.com/stuthedew","followers_url":"https://api.github.com/users/stuthedew/followers","following_url":"https://api.github.com/users/stuthedew/following{/other_user}","gists_url":"https://api.github.com/users/stuthedew/gists{/gist_id}","starred_url":"https://api.github.com/users/stuthedew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuthedew/subscriptions","organizations_url":"https://api.github.com/users/stuthedew/orgs","repos_url":"https://api.github.com/users/stuthedew/repos","events_url":"https://api.github.com/users/stuthedew/events{/privacy}","received_events_url":"https://api.github.com/users/stuthedew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stuthedew/Adafruit_MQTT_Library","description":"Arduino library for MQTT support","fork":true,"url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library","forks_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/forks","keys_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/teams","hooks_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/hooks","issue_events_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/issues/events{/number}","events_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/events","assignees_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/assignees{/user}","branches_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/branches{/branch}","tags_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/tags","blobs_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/statuses/{sha}","languages_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/languages","stargazers_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/stargazers","contributors_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/contributors","subscribers_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/subscribers","subscription_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/subscription","commits_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/contents/{+path}","compare_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/merges","archive_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/downloads","issues_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/issues{/number}","pulls_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/pulls{/number}","milestones_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/milestones{/number}","notifications_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/labels{/name}","releases_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/releases{/id}","deployments_url":"https://api.github.com/repos/stuthedew/Adafruit_MQTT_Library/deployments","created_at":"2016-01-17T23:25:12Z","updated_at":"2016-01-18T01:28:09Z","pushed_at":"2016-02-01T03:27:52Z","git_url":"git://github.com/stuthedew/Adafruit_MQTT_Library.git","ssh_url":"git@github.com:stuthedew/Adafruit_MQTT_Library.git","clone_url":"https://github.com/stuthedew/Adafruit_MQTT_Library.git","svn_url":"https://github.com/stuthedew/Adafruit_MQTT_Library","homepage":null,"size":1002,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"adafruit:master","ref":"master","sha":"922f87e3ccaf049f266ae131a54c84cfe9173d14","user":{"login":"adafruit","id":181069,"avatar_url":"https://avatars.githubusercontent.com/u/181069?v=3","gravatar_id":"","url":"https://api.github.com/users/adafruit","html_url":"https://github.com/adafruit","followers_url":"https://api.github.com/users/adafruit/followers","following_url":"https://api.github.com/users/adafruit/following{/other_user}","gists_url":"https://api.github.com/users/adafruit/gists{/gist_id}","starred_url":"https://api.github.com/users/adafruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adafruit/subscriptions","organizations_url":"https://api.github.com/users/adafruit/orgs","repos_url":"https://api.github.com/users/adafruit/repos","events_url":"https://api.github.com/users/adafruit/events{/privacy}","received_events_url":"https://api.github.com/users/adafruit/received_events","type":"Organization","site_admin":false},"repo":{"id":29487890,"name":"Adafruit_MQTT_Library","full_name":"adafruit/Adafruit_MQTT_Library","owner":{"login":"adafruit","id":181069,"avatar_url":"https://avatars.githubusercontent.com/u/181069?v=3","gravatar_id":"","url":"https://api.github.com/users/adafruit","html_url":"https://github.com/adafruit","followers_url":"https://api.github.com/users/adafruit/followers","following_url":"https://api.github.com/users/adafruit/following{/other_user}","gists_url":"https://api.github.com/users/adafruit/gists{/gist_id}","starred_url":"https://api.github.com/users/adafruit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adafruit/subscriptions","organizations_url":"https://api.github.com/users/adafruit/orgs","repos_url":"https://api.github.com/users/adafruit/repos","events_url":"https://api.github.com/users/adafruit/events{/privacy}","received_events_url":"https://api.github.com/users/adafruit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/adafruit/Adafruit_MQTT_Library","description":"Arduino library for MQTT support","fork":false,"url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library","forks_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/forks","keys_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/teams","hooks_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/hooks","issue_events_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues/events{/number}","events_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/events","assignees_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/assignees{/user}","branches_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/branches{/branch}","tags_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/tags","blobs_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/git/refs{/sha}","trees_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/statuses/{sha}","languages_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/languages","stargazers_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/stargazers","contributors_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/contributors","subscribers_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/subscribers","subscription_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/subscription","commits_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/commits{/sha}","git_commits_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/git/commits{/sha}","comments_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/comments{/number}","issue_comment_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues/comments{/number}","contents_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/contents/{+path}","compare_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/merges","archive_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/downloads","issues_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues{/number}","pulls_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls{/number}","milestones_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/milestones{/number}","notifications_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/labels{/name}","releases_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/releases{/id}","deployments_url":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/deployments","created_at":"2015-01-19T19:30:32Z","updated_at":"2016-02-01T13:34:24Z","pushed_at":"2016-02-01T03:37:28Z","git_url":"git://github.com/adafruit/Adafruit_MQTT_Library.git","ssh_url":"git@github.com:adafruit/Adafruit_MQTT_Library.git","clone_url":"https://github.com/adafruit/Adafruit_MQTT_Library.git","svn_url":"https://github.com/adafruit/Adafruit_MQTT_Library","homepage":null,"size":200,"stargazers_count":69,"watchers_count":69,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":3,"forks":31,"open_issues":3,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28"},"html":{"href":"https://github.com/adafruit/Adafruit_MQTT_Library/pull/28"},"issue":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues/28"},"comments":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/adafruit/Adafruit_MQTT_Library/statuses/0be4b1c2bd01a17302ec625bccf07de083e1963e"}}}}