{"action":"created","comment":{"url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/comments/66702134","id":66702134,"diff_hunk":"@@ -56,8 +59,13 @@ export class OptionCtrl {\n       console.log(data);\n       this.patterns = JSON.parse(data.savedPatterns);\n       this.key = data.yandexTranslatorApiKey;\n+\n       this.blacklistedWords = data.userBlacklistedWords.slice(1, -1).split('|');\n+      this.blacklistedWords = this.blacklistedWords.filter(function(n){ return n != '' });\n+\n       this.blacklistedWebsites = data.blacklist.slice(1, -1).split('|');\n+      this.blacklistedWebsites = this.blacklistedWebsites.filter(function(n){ return n != '' });","path":"lib/scripts/controllers/options.js","position":26,"original_position":26,"commit_id":"2313eec4b773f9ed65a3413141e4e4a8b38c2611","original_commit_id":"2313eec4b773f9ed65a3413141e4e4a8b38c2611","user":{"login":"Ceilican","id":1809436,"avatar_url":"https://avatars.githubusercontent.com/u/1809436?v=3","gravatar_id":"","url":"https://api.github.com/users/Ceilican","html_url":"https://github.com/Ceilican","followers_url":"https://api.github.com/users/Ceilican/followers","following_url":"https://api.github.com/users/Ceilican/following{/other_user}","gists_url":"https://api.github.com/users/Ceilican/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceilican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceilican/subscriptions","organizations_url":"https://api.github.com/users/Ceilican/orgs","repos_url":"https://api.github.com/users/Ceilican/repos","events_url":"https://api.github.com/users/Ceilican/events{/privacy}","received_events_url":"https://api.github.com/users/Ceilican/received_events","type":"User","site_admin":false},"body":"Then this corner case should preferably be handled in line 66, instead of fixed in line 67...  Can't the blacklist be sliced and split in a more careful way, so that this problematic corner case doesn't occur?","created_at":"2016-06-11T06:56:15Z","updated_at":"2016-06-11T06:56:15Z","html_url":"https://github.com/OiWorld/MindTheWord/pull/131#discussion_r66702134","pull_request_url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/comments/66702134"},"html":{"href":"https://github.com/OiWorld/MindTheWord/pull/131#discussion_r66702134"},"pull_request":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131","id":73459899,"html_url":"https://github.com/OiWorld/MindTheWord/pull/131","diff_url":"https://github.com/OiWorld/MindTheWord/pull/131.diff","patch_url":"https://github.com/OiWorld/MindTheWord/pull/131.patch","issue_url":"https://api.github.com/repos/OiWorld/MindTheWord/issues/131","number":131,"state":"closed","locked":false,"title":"Ability to mark words as learnt","user":{"login":"rohankatyal29","id":2452426,"avatar_url":"https://avatars.githubusercontent.com/u/2452426?v=3","gravatar_id":"","url":"https://api.github.com/users/rohankatyal29","html_url":"https://github.com/rohankatyal29","followers_url":"https://api.github.com/users/rohankatyal29/followers","following_url":"https://api.github.com/users/rohankatyal29/following{/other_user}","gists_url":"https://api.github.com/users/rohankatyal29/gists{/gist_id}","starred_url":"https://api.github.com/users/rohankatyal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohankatyal29/subscriptions","organizations_url":"https://api.github.com/users/rohankatyal29/orgs","repos_url":"https://api.github.com/users/rohankatyal29/repos","events_url":"https://api.github.com/users/rohankatyal29/events{/privacy}","received_events_url":"https://api.github.com/users/rohankatyal29/received_events","type":"User","site_admin":false},"body":"Words can be now marked as learnt\r\nWords marked as learnt aren't translated\r\n<img width=\"910\" alt=\"screen shot 2016-06-11 at 11 24 42 am\" src=\"https://cloud.githubusercontent.com/assets/2452426/15983502/23ffeaea-2fc7-11e6-84cb-4f8d68e40a7a.png\">\r\n\r\n<img width=\"443\" alt=\"screen shot 2016-06-11 at 11 25 43 am\" src=\"https://cloud.githubusercontent.com/assets/2452426/15983504/45c49b58-2fc7-11e6-822d-8912a0e24134.png\">\r\n\r\n---- Minor Edits -----\r\n\r\n- Changed note displaying hex values into rgba on the options page \r\n\r\n- Fixed bug causing empty values to be displayed on the options page\r\n<img width=\"482\" alt=\"screen shot 2016-06-11 at 11 06 49 am\" src=\"https://cloud.githubusercontent.com/assets/2452426/15983491/d26a8b22-2fc6-11e6-8235-754f888fba13.png\">\r\n\r\n- Suggested changes in the class functions ","created_at":"2016-06-11T05:56:20Z","updated_at":"2016-06-11T06:56:15Z","closed_at":"2016-06-11T06:20:20Z","merged_at":"2016-06-11T06:20:20Z","merge_commit_sha":"fd3e2224fe20bdc45545277064f3324a905cea7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131/commits","review_comments_url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131/comments","review_comment_url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OiWorld/MindTheWord/issues/131/comments","statuses_url":"https://api.github.com/repos/OiWorld/MindTheWord/statuses/2313eec4b773f9ed65a3413141e4e4a8b38c2611","head":{"label":"rohankatyal29:learnt_words","ref":"learnt_words","sha":"2313eec4b773f9ed65a3413141e4e4a8b38c2611","user":{"login":"rohankatyal29","id":2452426,"avatar_url":"https://avatars.githubusercontent.com/u/2452426?v=3","gravatar_id":"","url":"https://api.github.com/users/rohankatyal29","html_url":"https://github.com/rohankatyal29","followers_url":"https://api.github.com/users/rohankatyal29/followers","following_url":"https://api.github.com/users/rohankatyal29/following{/other_user}","gists_url":"https://api.github.com/users/rohankatyal29/gists{/gist_id}","starred_url":"https://api.github.com/users/rohankatyal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohankatyal29/subscriptions","organizations_url":"https://api.github.com/users/rohankatyal29/orgs","repos_url":"https://api.github.com/users/rohankatyal29/repos","events_url":"https://api.github.com/users/rohankatyal29/events{/privacy}","received_events_url":"https://api.github.com/users/rohankatyal29/received_events","type":"User","site_admin":false},"repo":{"id":59722667,"name":"MindTheWord","full_name":"rohankatyal29/MindTheWord","owner":{"login":"rohankatyal29","id":2452426,"avatar_url":"https://avatars.githubusercontent.com/u/2452426?v=3","gravatar_id":"","url":"https://api.github.com/users/rohankatyal29","html_url":"https://github.com/rohankatyal29","followers_url":"https://api.github.com/users/rohankatyal29/followers","following_url":"https://api.github.com/users/rohankatyal29/following{/other_user}","gists_url":"https://api.github.com/users/rohankatyal29/gists{/gist_id}","starred_url":"https://api.github.com/users/rohankatyal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohankatyal29/subscriptions","organizations_url":"https://api.github.com/users/rohankatyal29/orgs","repos_url":"https://api.github.com/users/rohankatyal29/repos","events_url":"https://api.github.com/users/rohankatyal29/events{/privacy}","received_events_url":"https://api.github.com/users/rohankatyal29/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohankatyal29/MindTheWord","description":"An extension for Google Chrome that helps people learn new languages while they browse the web.","fork":true,"url":"https://api.github.com/repos/rohankatyal29/MindTheWord","forks_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/forks","keys_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/teams","hooks_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/hooks","issue_events_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/issues/events{/number}","events_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/events","assignees_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/assignees{/user}","branches_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/branches{/branch}","tags_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/tags","blobs_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/statuses/{sha}","languages_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/languages","stargazers_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/stargazers","contributors_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/contributors","subscribers_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/subscribers","subscription_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/subscription","commits_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/contents/{+path}","compare_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/merges","archive_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/downloads","issues_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/issues{/number}","pulls_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/pulls{/number}","milestones_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/milestones{/number}","notifications_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/labels{/name}","releases_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/releases{/id}","deployments_url":"https://api.github.com/repos/rohankatyal29/MindTheWord/deployments","created_at":"2016-05-26T05:34:24Z","updated_at":"2016-05-26T05:34:24Z","pushed_at":"2016-06-11T05:48:28Z","git_url":"git://github.com/rohankatyal29/MindTheWord.git","ssh_url":"git@github.com:rohankatyal29/MindTheWord.git","clone_url":"https://github.com/rohankatyal29/MindTheWord.git","svn_url":"https://github.com/rohankatyal29/MindTheWord","homepage":null,"size":13088,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OiWorld:master","ref":"master","sha":"4af0dfecc2175f852bf2ca02b879d793e332c86e","user":{"login":"OiWorld","id":3678147,"avatar_url":"https://avatars.githubusercontent.com/u/3678147?v=3","gravatar_id":"","url":"https://api.github.com/users/OiWorld","html_url":"https://github.com/OiWorld","followers_url":"https://api.github.com/users/OiWorld/followers","following_url":"https://api.github.com/users/OiWorld/following{/other_user}","gists_url":"https://api.github.com/users/OiWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/OiWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OiWorld/subscriptions","organizations_url":"https://api.github.com/users/OiWorld/orgs","repos_url":"https://api.github.com/users/OiWorld/repos","events_url":"https://api.github.com/users/OiWorld/events{/privacy}","received_events_url":"https://api.github.com/users/OiWorld/received_events","type":"Organization","site_admin":false},"repo":{"id":8381792,"name":"MindTheWord","full_name":"OiWorld/MindTheWord","owner":{"login":"OiWorld","id":3678147,"avatar_url":"https://avatars.githubusercontent.com/u/3678147?v=3","gravatar_id":"","url":"https://api.github.com/users/OiWorld","html_url":"https://github.com/OiWorld","followers_url":"https://api.github.com/users/OiWorld/followers","following_url":"https://api.github.com/users/OiWorld/following{/other_user}","gists_url":"https://api.github.com/users/OiWorld/gists{/gist_id}","starred_url":"https://api.github.com/users/OiWorld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OiWorld/subscriptions","organizations_url":"https://api.github.com/users/OiWorld/orgs","repos_url":"https://api.github.com/users/OiWorld/repos","events_url":"https://api.github.com/users/OiWorld/events{/privacy}","received_events_url":"https://api.github.com/users/OiWorld/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OiWorld/MindTheWord","description":"An extension for Google Chrome that helps people learn new languages while they browse the web.","fork":false,"url":"https://api.github.com/repos/OiWorld/MindTheWord","forks_url":"https://api.github.com/repos/OiWorld/MindTheWord/forks","keys_url":"https://api.github.com/repos/OiWorld/MindTheWord/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OiWorld/MindTheWord/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OiWorld/MindTheWord/teams","hooks_url":"https://api.github.com/repos/OiWorld/MindTheWord/hooks","issue_events_url":"https://api.github.com/repos/OiWorld/MindTheWord/issues/events{/number}","events_url":"https://api.github.com/repos/OiWorld/MindTheWord/events","assignees_url":"https://api.github.com/repos/OiWorld/MindTheWord/assignees{/user}","branches_url":"https://api.github.com/repos/OiWorld/MindTheWord/branches{/branch}","tags_url":"https://api.github.com/repos/OiWorld/MindTheWord/tags","blobs_url":"https://api.github.com/repos/OiWorld/MindTheWord/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OiWorld/MindTheWord/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OiWorld/MindTheWord/git/refs{/sha}","trees_url":"https://api.github.com/repos/OiWorld/MindTheWord/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OiWorld/MindTheWord/statuses/{sha}","languages_url":"https://api.github.com/repos/OiWorld/MindTheWord/languages","stargazers_url":"https://api.github.com/repos/OiWorld/MindTheWord/stargazers","contributors_url":"https://api.github.com/repos/OiWorld/MindTheWord/contributors","subscribers_url":"https://api.github.com/repos/OiWorld/MindTheWord/subscribers","subscription_url":"https://api.github.com/repos/OiWorld/MindTheWord/subscription","commits_url":"https://api.github.com/repos/OiWorld/MindTheWord/commits{/sha}","git_commits_url":"https://api.github.com/repos/OiWorld/MindTheWord/git/commits{/sha}","comments_url":"https://api.github.com/repos/OiWorld/MindTheWord/comments{/number}","issue_comment_url":"https://api.github.com/repos/OiWorld/MindTheWord/issues/comments{/number}","contents_url":"https://api.github.com/repos/OiWorld/MindTheWord/contents/{+path}","compare_url":"https://api.github.com/repos/OiWorld/MindTheWord/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OiWorld/MindTheWord/merges","archive_url":"https://api.github.com/repos/OiWorld/MindTheWord/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OiWorld/MindTheWord/downloads","issues_url":"https://api.github.com/repos/OiWorld/MindTheWord/issues{/number}","pulls_url":"https://api.github.com/repos/OiWorld/MindTheWord/pulls{/number}","milestones_url":"https://api.github.com/repos/OiWorld/MindTheWord/milestones{/number}","notifications_url":"https://api.github.com/repos/OiWorld/MindTheWord/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OiWorld/MindTheWord/labels{/name}","releases_url":"https://api.github.com/repos/OiWorld/MindTheWord/releases{/id}","deployments_url":"https://api.github.com/repos/OiWorld/MindTheWord/deployments","created_at":"2013-02-23T20:57:46Z","updated_at":"2016-06-03T23:10:20Z","pushed_at":"2016-06-11T06:20:20Z","git_url":"git://github.com/OiWorld/MindTheWord.git","ssh_url":"git@github.com:OiWorld/MindTheWord.git","clone_url":"https://github.com/OiWorld/MindTheWord.git","svn_url":"https://github.com/OiWorld/MindTheWord","homepage":null,"size":13098,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":36,"forks":38,"open_issues":36,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131"},"html":{"href":"https://github.com/OiWorld/MindTheWord/pull/131"},"issue":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/issues/131"},"comments":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/OiWorld/MindTheWord/statuses/2313eec4b773f9ed65a3413141e4e4a8b38c2611"}}}}
{"actor":{"display_login":"Ceilican"}}