{"action":"opened","number":1957,"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/1957","id":81182647,"html_url":"https://github.com/vmware/vic/pull/1957","diff_url":"https://github.com/vmware/vic/pull/1957.diff","patch_url":"https://github.com/vmware/vic/pull/1957.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/1957","number":1957,"state":"open","locked":false,"title":"[WIP] vic-machine uses default datastore if not specified","user":{"login":"andrewtchin","id":1649165,"avatar_url":"https://avatars.githubusercontent.com/u/1649165?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtchin","html_url":"https://github.com/andrewtchin","followers_url":"https://api.github.com/users/andrewtchin/followers","following_url":"https://api.github.com/users/andrewtchin/following{/other_user}","gists_url":"https://api.github.com/users/andrewtchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtchin/subscriptions","organizations_url":"https://api.github.com/users/andrewtchin/orgs","repos_url":"https://api.github.com/users/andrewtchin/repos","events_url":"https://api.github.com/users/andrewtchin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtchin/received_events","type":"User","site_admin":false},"body":"Fixes #1206 \r\n\r\nWIP - I'll add a working integration test after my other open PR is merged\r\n\r\nvC:\r\n```\r\n⇒  bin/vic-machine-linux create --target 10.17.109.115/dc1  --name chin-vic-18 --user administrator@vsphere.local --password password --compute-resource cluster1/chin  --bridge-network vch-test\r\nINFO[2016-08-12T13:50:02-07:00] ### Installing VCH ####                      \r\nINFO[2016-08-12T13:50:02-07:00] Generating certificate/key pair - private key in ./chin-vic-18-key.pem \r\nINFO[2016-08-12T13:50:03-07:00] Validating supplied configuration            \r\nINFO[2016-08-12T13:50:03-07:00] Using default datastore: vsanDatastore  \r\nINFO[2016-08-12T13:50:04-07:00] vDS configuration OK on \"vch-test\"           \r\nINFO[2016-08-12T13:50:04-07:00] Firewall status: ENABLED on \"/dc1/host/cluster1/10.17.109.74\" \r\nINFO[2016-08-12T13:50:05-07:00] Firewall status: ENABLED on \"/dc1/host/cluster1/10.17.109.76\" \r\nINFO[2016-08-12T13:50:05-07:00] Firewall status: ENABLED on \"/dc1/host/cluster1/10.17.109.169\" \r\nINFO[2016-08-12T13:50:05-07:00] Firewall configuration OK on hosts:          \r\nINFO[2016-08-12T13:50:05-07:00]   \"/dc1/host/cluster1/10.17.109.74\"          \r\nINFO[2016-08-12T13:50:05-07:00]   \"/dc1/host/cluster1/10.17.109.76\"          \r\nINFO[2016-08-12T13:50:05-07:00]   \"/dc1/host/cluster1/10.17.109.169\"         \r\nINFO[2016-08-12T13:50:06-07:00] License check OK on hosts:                   \r\nINFO[2016-08-12T13:50:06-07:00]   \"/dc1/host/cluster1/10.17.109.74\"          \r\nINFO[2016-08-12T13:50:06-07:00]   \"/dc1/host/cluster1/10.17.109.76\"          \r\nINFO[2016-08-12T13:50:06-07:00]   \"/dc1/host/cluster1/10.17.109.169\"         \r\nINFO[2016-08-12T13:50:06-07:00] DRS check OK on:                             \r\nINFO[2016-08-12T13:50:06-07:00]   \"/dc1/host/cluster1/Resources/chin\"        \r\nINFO[2016-08-12T13:50:07-07:00] Creating virtual app \"chin-vic-18\"           \r\nINFO[2016-08-12T13:50:07-07:00] Creating appliance on target                 \r\nINFO[2016-08-12T13:50:07-07:00] Network role \"client\" is sharing NIC with \"external\" \r\nINFO[2016-08-12T13:50:07-07:00] Network role \"management\" is sharing NIC with \"external\" \r\nINFO[2016-08-12T13:50:24-07:00] Uploading images for container               \r\nINFO[2016-08-12T13:50:24-07:00] \"/home/chin/go/src/github.com/vmware/vic/bin/bootstrap.iso\" \r\nINFO[2016-08-12T13:50:24-07:00] \"/home/chin/go/src/github.com/vmware/vic/bin/appliance.iso\" \r\nINFO[2016-08-12T13:51:01-07:00] Registering VCH as a vSphere extension       \r\nINFO[2016-08-12T13:51:14-07:00] Waiting for IP information                   \r\nINFO[2016-08-12T13:51:50-07:00] Waiting for major appliance components to launch \r\nINFO[2016-08-12T13:51:51-07:00] Initialization of appliance successful       \r\nINFO[2016-08-12T13:51:51-07:00]                                              \r\nINFO[2016-08-12T13:51:51-07:00] vic-admin portal:                            \r\nINFO[2016-08-12T13:51:51-07:00] https://10.17.109.140:2378                   \r\nINFO[2016-08-12T13:51:51-07:00]                                              \r\nINFO[2016-08-12T13:51:51-07:00] DOCKER_HOST=10.17.109.140:2376               \r\nINFO[2016-08-12T13:51:51-07:00]                                              \r\nINFO[2016-08-12T13:51:51-07:00] Connect to docker:                           \r\nINFO[2016-08-12T13:51:51-07:00] docker -H 10.17.109.140:2376 --tls info      \r\nINFO[2016-08-12T13:51:51-07:00] Installer completed successfully  \r\n```\r\n\r\nESX:\r\n```\r\n⇒  bin/vic-machine-linux create --target 192.168.218.177 --name chin-vic-110 --user root --password password \r\nINFO[2016-08-12T13:52:21-07:00] ### Installing VCH ####                      \r\nINFO[2016-08-12T13:52:21-07:00] Generating certificate/key pair - private key in ./chin-vic-110-key.pem \r\nINFO[2016-08-12T13:52:22-07:00] Validating supplied configuration            \r\nINFO[2016-08-12T13:52:22-07:00] Using default datastore: datastore1     \r\nINFO[2016-08-12T13:52:22-07:00] Firewall status: DISABLED on \"/ha-datacenter/host/localhost.localdomain/localhost.localdomain\" \r\nINFO[2016-08-12T13:52:22-07:00] Firewall configuration OK on hosts:          \r\nINFO[2016-08-12T13:52:22-07:00]   \"/ha-datacenter/host/localhost.localdomain/localhost.localdomain\" \r\nWARN[2016-08-12T13:52:22-07:00] Evaluation license detected. VIC may not function if evaluation expires or insufficient license is later assigned. \r\nINFO[2016-08-12T13:52:22-07:00] License check OK                             \r\nINFO[2016-08-12T13:52:22-07:00] DRS check SKIPPED - target is standalone host \r\nINFO[2016-08-12T13:52:22-07:00] Creating Resource Pool \"chin-vic-110\"        \r\nINFO[2016-08-12T13:52:22-07:00] Creating VirtualSwitch                       \r\nINFO[2016-08-12T13:52:22-07:00] Creating Portgroup                           \r\nINFO[2016-08-12T13:52:23-07:00] Creating appliance on target                 \r\nINFO[2016-08-12T13:52:23-07:00] Network role \"client\" is sharing NIC with \"external\" \r\nINFO[2016-08-12T13:52:23-07:00] Network role \"management\" is sharing NIC with \"external\" \r\nINFO[2016-08-12T13:52:23-07:00] Uploading images for container               \r\nINFO[2016-08-12T13:52:23-07:00] \"/home/chin/go/src/github.com/vmware/vic/bin/bootstrap.iso\" \r\nINFO[2016-08-12T13:52:23-07:00] \"/home/chin/go/src/github.com/vmware/vic/bin/appliance.iso\" \r\nINFO[2016-08-12T13:52:27-07:00] Waiting for IP information                   \r\nINFO[2016-08-12T13:52:38-07:00] Waiting for major appliance components to launch \r\nINFO[2016-08-12T13:52:38-07:00] Initialization of appliance successful       \r\nINFO[2016-08-12T13:52:38-07:00]                                              \r\nINFO[2016-08-12T13:52:38-07:00] vic-admin portal:                            \r\nINFO[2016-08-12T13:52:38-07:00] https://192.168.218.136:2378                 \r\nINFO[2016-08-12T13:52:38-07:00]                                              \r\nINFO[2016-08-12T13:52:38-07:00] DOCKER_HOST=192.168.218.136:2376             \r\nINFO[2016-08-12T13:52:38-07:00]                                              \r\nINFO[2016-08-12T13:52:38-07:00] Connect to docker:                           \r\nINFO[2016-08-12T13:52:38-07:00] docker -H 192.168.218.136:2376 --tls info    \r\nINFO[2016-08-12T13:52:38-07:00] Installer completed successfully \r\n```\r\n\r\nMultiple DS present:\r\n```\r\n⇒  bin/vic-machine-linux create --target 192.168.218.177 --name chin-vic-110 --user root --password password                                                                       \r\nINFO[2016-08-12T13:57:43-07:00] ### Installing VCH ####                      \r\nINFO[2016-08-12T13:57:43-07:00] Generating certificate/key pair - private key in ./chin-vic-110-key.pem \r\nINFO[2016-08-12T13:57:43-07:00] Validating supplied configuration            \r\nINFO[2016-08-12T13:57:43-07:00] Suggesting valid values for --image-store based on \"*\" \r\nINFO[2016-08-12T13:57:43-07:00] Suggested values for --image-store:          \r\nINFO[2016-08-12T13:57:43-07:00]   \"datastore1\"                               \r\nINFO[2016-08-12T13:57:43-07:00]   \"ds2\"                                      \r\nERRO[2016-08-12T13:57:43-07:00] Firewall check SKIPPED                       \r\nERRO[2016-08-12T13:57:43-07:00]   datastore not set                          \r\nERRO[2016-08-12T13:57:43-07:00] License check SKIPPED                        \r\nERRO[2016-08-12T13:57:43-07:00]   datastore not set                          \r\nERRO[2016-08-12T13:57:43-07:00] DRS check SKIPPED                            \r\nERRO[2016-08-12T13:57:43-07:00]   datastore not set                          \r\nERRO[2016-08-12T13:57:43-07:00] Compatibility check SKIPPED                  \r\nERRO[2016-08-12T13:57:43-07:00]   datastore not set                          \r\nERRO[2016-08-12T13:57:43-07:00] --------------------                         \r\nERRO[2016-08-12T13:57:43-07:00] datastore hostname empty                     \r\nERRO[2016-08-12T13:57:43-07:00] Firewall check SKIPPED                       \r\nERRO[2016-08-12T13:57:43-07:00] License check SKIPPED                        \r\nERRO[2016-08-12T13:57:43-07:00] DRS check SKIPPED                            \r\nERRO[2016-08-12T13:57:43-07:00] Compatibility check SKIPPED                  \r\nERRO[2016-08-12T13:57:43-07:00] Create cannot continue: configuration validation failed \r\nERRO[2016-08-12T13:57:43-07:00] --------------------                         \r\nERRO[2016-08-12T13:57:43-07:00] vic-machine-linux failed: validation of configuration failed\r\n\r\n```\r\n\r\n\r\n","created_at":"2016-08-12T21:01:39Z","updated_at":"2016-08-12T21:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/1957/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/1957/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/1957/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/4f055bc45026bd96e63fd24b9c3c699f5799de64","head":{"label":"andrewtchin:1206/default-datastore","ref":"1206/default-datastore","sha":"4f055bc45026bd96e63fd24b9c3c699f5799de64","user":{"login":"andrewtchin","id":1649165,"avatar_url":"https://avatars.githubusercontent.com/u/1649165?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtchin","html_url":"https://github.com/andrewtchin","followers_url":"https://api.github.com/users/andrewtchin/followers","following_url":"https://api.github.com/users/andrewtchin/following{/other_user}","gists_url":"https://api.github.com/users/andrewtchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtchin/subscriptions","organizations_url":"https://api.github.com/users/andrewtchin/orgs","repos_url":"https://api.github.com/users/andrewtchin/repos","events_url":"https://api.github.com/users/andrewtchin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtchin/received_events","type":"User","site_admin":false},"repo":{"id":55440762,"name":"vic","full_name":"andrewtchin/vic","owner":{"login":"andrewtchin","id":1649165,"avatar_url":"https://avatars.githubusercontent.com/u/1649165?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewtchin","html_url":"https://github.com/andrewtchin","followers_url":"https://api.github.com/users/andrewtchin/followers","following_url":"https://api.github.com/users/andrewtchin/following{/other_user}","gists_url":"https://api.github.com/users/andrewtchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewtchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewtchin/subscriptions","organizations_url":"https://api.github.com/users/andrewtchin/orgs","repos_url":"https://api.github.com/users/andrewtchin/repos","events_url":"https://api.github.com/users/andrewtchin/events{/privacy}","received_events_url":"https://api.github.com/users/andrewtchin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewtchin/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/andrewtchin/vic","forks_url":"https://api.github.com/repos/andrewtchin/vic/forks","keys_url":"https://api.github.com/repos/andrewtchin/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewtchin/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewtchin/vic/teams","hooks_url":"https://api.github.com/repos/andrewtchin/vic/hooks","issue_events_url":"https://api.github.com/repos/andrewtchin/vic/issues/events{/number}","events_url":"https://api.github.com/repos/andrewtchin/vic/events","assignees_url":"https://api.github.com/repos/andrewtchin/vic/assignees{/user}","branches_url":"https://api.github.com/repos/andrewtchin/vic/branches{/branch}","tags_url":"https://api.github.com/repos/andrewtchin/vic/tags","blobs_url":"https://api.github.com/repos/andrewtchin/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewtchin/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewtchin/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewtchin/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewtchin/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewtchin/vic/languages","stargazers_url":"https://api.github.com/repos/andrewtchin/vic/stargazers","contributors_url":"https://api.github.com/repos/andrewtchin/vic/contributors","subscribers_url":"https://api.github.com/repos/andrewtchin/vic/subscribers","subscription_url":"https://api.github.com/repos/andrewtchin/vic/subscription","commits_url":"https://api.github.com/repos/andrewtchin/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewtchin/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewtchin/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewtchin/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewtchin/vic/contents/{+path}","compare_url":"https://api.github.com/repos/andrewtchin/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewtchin/vic/merges","archive_url":"https://api.github.com/repos/andrewtchin/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewtchin/vic/downloads","issues_url":"https://api.github.com/repos/andrewtchin/vic/issues{/number}","pulls_url":"https://api.github.com/repos/andrewtchin/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewtchin/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewtchin/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewtchin/vic/labels{/name}","releases_url":"https://api.github.com/repos/andrewtchin/vic/releases{/id}","deployments_url":"https://api.github.com/repos/andrewtchin/vic/deployments","created_at":"2016-04-04T20:01:48Z","updated_at":"2016-04-04T20:02:31Z","pushed_at":"2016-08-12T20:59:47Z","git_url":"git://github.com/andrewtchin/vic.git","ssh_url":"git@github.com:andrewtchin/vic.git","clone_url":"https://github.com/andrewtchin/vic.git","svn_url":"https://github.com/andrewtchin/vic","homepage":null,"size":27220,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"acd3cc87e9353bcf477079d0df8b65126d400bbb","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2016-08-05T22:38:36Z","pushed_at":"2016-08-12T21:01:40Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":null,"size":75067,"stargazers_count":109,"watchers_count":109,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":493,"forks":39,"open_issues":493,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/1957"},"html":{"href":"https://github.com/vmware/vic/pull/1957"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/1957"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/1957/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/1957/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/1957/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/4f055bc45026bd96e63fd24b9c3c699f5799de64"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":20,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"andrewtchin"}}