{"action":"created","comment":{"url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/comments/71828253","id":71828253,"diff_hunk":"@@ -345,6 +349,13 @@ inline void SetN2kProductInformation(tN2kMsg &N2kMsg, unsigned int N2kVersion, u\n                   SertificationLevel,LoadEquivalency);\n }\n \n+\n+void SetN2kPGN59904(tN2kMsg &N2kMsg, uint8_t Destination, unsigned long RequestedPGN);\n+\n+inline void SetN2kPGNISORequest(tN2kMsg &N2kMsg, uint8_t Destination, unsigned long RequestedPGN) {","path":"NMEA2000.h","position":31,"original_position":31,"commit_id":"b5beec26b2f6788ca62e4c20764a1db1d3fb39df","original_commit_id":"b5beec26b2f6788ca62e4c20764a1db1d3fb39df","user":{"login":"thomasonw","id":8771214,"avatar_url":"https://avatars.githubusercontent.com/u/8771214?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasonw","html_url":"https://github.com/thomasonw","followers_url":"https://api.github.com/users/thomasonw/followers","following_url":"https://api.github.com/users/thomasonw/following{/other_user}","gists_url":"https://api.github.com/users/thomasonw/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasonw/subscriptions","organizations_url":"https://api.github.com/users/thomasonw/orgs","repos_url":"https://api.github.com/users/thomasonw/repos","events_url":"https://api.github.com/users/thomasonw/events{/privacy}","received_events_url":"https://api.github.com/users/thomasonw/received_events","type":"User","site_admin":false},"body":"I like that!   I might use 'Requester' instead of 'Destination' for the 2nd parameter.   Destination sounds to me like our address, not the address of the node making the request.  So:\r\n\r\nool(*ISORequestHandler)(unsigned long RequestedPGN, unsigned char Requester, int DeviceIndex);\r\n\r\nA detail:  If the NAK is going to be generated in the NMEA2000.ccp module, It is my understanding the NAK is only sent when the  request was directed to a specific node.  However, for Broadcast Requests (destination address = 0xFF), no such NAK should be sent.","created_at":"2016-07-22T05:21:37Z","updated_at":"2016-07-22T05:21:37Z","html_url":"https://github.com/ttlappalainen/NMEA2000/pull/13#discussion_r71828253","pull_request_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/comments/71828253"},"html":{"href":"https://github.com/ttlappalainen/NMEA2000/pull/13#discussion_r71828253"},"pull_request":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13","id":78320435,"html_url":"https://github.com/ttlappalainen/NMEA2000/pull/13","diff_url":"https://github.com/ttlappalainen/NMEA2000/pull/13.diff","patch_url":"https://github.com/ttlappalainen/NMEA2000/pull/13.patch","issue_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues/13","number":13,"state":"open","locked":false,"title":"User ISO Request Handler","user":{"login":"thomasonw","id":8771214,"avatar_url":"https://avatars.githubusercontent.com/u/8771214?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasonw","html_url":"https://github.com/thomasonw","followers_url":"https://api.github.com/users/thomasonw/followers","following_url":"https://api.github.com/users/thomasonw/following{/other_user}","gists_url":"https://api.github.com/users/thomasonw/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasonw/subscriptions","organizations_url":"https://api.github.com/users/thomasonw/orgs","repos_url":"https://api.github.com/users/thomasonw/repos","events_url":"https://api.github.com/users/thomasonw/events{/privacy}","received_events_url":"https://api.github.com/users/thomasonw/received_events","type":"User","site_admin":false},"body":"Added capability for user to define ISO Request-Message handler.","created_at":"2016-07-21T13:58:23Z","updated_at":"2016-07-22T05:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37fe9c847a01980060d1e43ab2fd34463bf6a055","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues/13/comments","statuses_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/statuses/b5beec26b2f6788ca62e4c20764a1db1d3fb39df","head":{"label":"thomasonw:master","ref":"master","sha":"b5beec26b2f6788ca62e4c20764a1db1d3fb39df","user":{"login":"thomasonw","id":8771214,"avatar_url":"https://avatars.githubusercontent.com/u/8771214?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasonw","html_url":"https://github.com/thomasonw","followers_url":"https://api.github.com/users/thomasonw/followers","following_url":"https://api.github.com/users/thomasonw/following{/other_user}","gists_url":"https://api.github.com/users/thomasonw/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasonw/subscriptions","organizations_url":"https://api.github.com/users/thomasonw/orgs","repos_url":"https://api.github.com/users/thomasonw/repos","events_url":"https://api.github.com/users/thomasonw/events{/privacy}","received_events_url":"https://api.github.com/users/thomasonw/received_events","type":"User","site_admin":false},"repo":{"id":53805197,"name":"NMEA2000","full_name":"thomasonw/NMEA2000","owner":{"login":"thomasonw","id":8771214,"avatar_url":"https://avatars.githubusercontent.com/u/8771214?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasonw","html_url":"https://github.com/thomasonw","followers_url":"https://api.github.com/users/thomasonw/followers","following_url":"https://api.github.com/users/thomasonw/following{/other_user}","gists_url":"https://api.github.com/users/thomasonw/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasonw/subscriptions","organizations_url":"https://api.github.com/users/thomasonw/orgs","repos_url":"https://api.github.com/users/thomasonw/repos","events_url":"https://api.github.com/users/thomasonw/events{/privacy}","received_events_url":"https://api.github.com/users/thomasonw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasonw/NMEA2000","description":"NMEA2000 library for Arduino","fork":true,"url":"https://api.github.com/repos/thomasonw/NMEA2000","forks_url":"https://api.github.com/repos/thomasonw/NMEA2000/forks","keys_url":"https://api.github.com/repos/thomasonw/NMEA2000/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasonw/NMEA2000/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasonw/NMEA2000/teams","hooks_url":"https://api.github.com/repos/thomasonw/NMEA2000/hooks","issue_events_url":"https://api.github.com/repos/thomasonw/NMEA2000/issues/events{/number}","events_url":"https://api.github.com/repos/thomasonw/NMEA2000/events","assignees_url":"https://api.github.com/repos/thomasonw/NMEA2000/assignees{/user}","branches_url":"https://api.github.com/repos/thomasonw/NMEA2000/branches{/branch}","tags_url":"https://api.github.com/repos/thomasonw/NMEA2000/tags","blobs_url":"https://api.github.com/repos/thomasonw/NMEA2000/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasonw/NMEA2000/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasonw/NMEA2000/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasonw/NMEA2000/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasonw/NMEA2000/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasonw/NMEA2000/languages","stargazers_url":"https://api.github.com/repos/thomasonw/NMEA2000/stargazers","contributors_url":"https://api.github.com/repos/thomasonw/NMEA2000/contributors","subscribers_url":"https://api.github.com/repos/thomasonw/NMEA2000/subscribers","subscription_url":"https://api.github.com/repos/thomasonw/NMEA2000/subscription","commits_url":"https://api.github.com/repos/thomasonw/NMEA2000/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasonw/NMEA2000/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasonw/NMEA2000/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasonw/NMEA2000/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasonw/NMEA2000/contents/{+path}","compare_url":"https://api.github.com/repos/thomasonw/NMEA2000/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasonw/NMEA2000/merges","archive_url":"https://api.github.com/repos/thomasonw/NMEA2000/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasonw/NMEA2000/downloads","issues_url":"https://api.github.com/repos/thomasonw/NMEA2000/issues{/number}","pulls_url":"https://api.github.com/repos/thomasonw/NMEA2000/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasonw/NMEA2000/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasonw/NMEA2000/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasonw/NMEA2000/labels{/name}","releases_url":"https://api.github.com/repos/thomasonw/NMEA2000/releases{/id}","deployments_url":"https://api.github.com/repos/thomasonw/NMEA2000/deployments","created_at":"2016-03-13T20:10:02Z","updated_at":"2016-03-13T20:10:03Z","pushed_at":"2016-07-21T13:54:07Z","git_url":"git://github.com/thomasonw/NMEA2000.git","ssh_url":"git@github.com:thomasonw/NMEA2000.git","clone_url":"https://github.com/thomasonw/NMEA2000.git","svn_url":"https://github.com/thomasonw/NMEA2000","homepage":null,"size":1253,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ttlappalainen:master","ref":"master","sha":"8e646fdd92b8de4f2e52d67c6c0fa893d38fc5a8","user":{"login":"ttlappalainen","id":13516389,"avatar_url":"https://avatars.githubusercontent.com/u/13516389?v=3","gravatar_id":"","url":"https://api.github.com/users/ttlappalainen","html_url":"https://github.com/ttlappalainen","followers_url":"https://api.github.com/users/ttlappalainen/followers","following_url":"https://api.github.com/users/ttlappalainen/following{/other_user}","gists_url":"https://api.github.com/users/ttlappalainen/gists{/gist_id}","starred_url":"https://api.github.com/users/ttlappalainen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttlappalainen/subscriptions","organizations_url":"https://api.github.com/users/ttlappalainen/orgs","repos_url":"https://api.github.com/users/ttlappalainen/repos","events_url":"https://api.github.com/users/ttlappalainen/events{/privacy}","received_events_url":"https://api.github.com/users/ttlappalainen/received_events","type":"User","site_admin":false},"repo":{"id":40409157,"name":"NMEA2000","full_name":"ttlappalainen/NMEA2000","owner":{"login":"ttlappalainen","id":13516389,"avatar_url":"https://avatars.githubusercontent.com/u/13516389?v=3","gravatar_id":"","url":"https://api.github.com/users/ttlappalainen","html_url":"https://github.com/ttlappalainen","followers_url":"https://api.github.com/users/ttlappalainen/followers","following_url":"https://api.github.com/users/ttlappalainen/following{/other_user}","gists_url":"https://api.github.com/users/ttlappalainen/gists{/gist_id}","starred_url":"https://api.github.com/users/ttlappalainen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttlappalainen/subscriptions","organizations_url":"https://api.github.com/users/ttlappalainen/orgs","repos_url":"https://api.github.com/users/ttlappalainen/repos","events_url":"https://api.github.com/users/ttlappalainen/events{/privacy}","received_events_url":"https://api.github.com/users/ttlappalainen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ttlappalainen/NMEA2000","description":"NMEA2000 library for Arduino","fork":false,"url":"https://api.github.com/repos/ttlappalainen/NMEA2000","forks_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/forks","keys_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/teams","hooks_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/hooks","issue_events_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues/events{/number}","events_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/events","assignees_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/assignees{/user}","branches_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/branches{/branch}","tags_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/tags","blobs_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/statuses/{sha}","languages_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/languages","stargazers_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/stargazers","contributors_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/contributors","subscribers_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/subscribers","subscription_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/subscription","commits_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/contents/{+path}","compare_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/merges","archive_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/downloads","issues_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues{/number}","pulls_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls{/number}","milestones_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/milestones{/number}","notifications_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/labels{/name}","releases_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/releases{/id}","deployments_url":"https://api.github.com/repos/ttlappalainen/NMEA2000/deployments","created_at":"2015-08-08T16:32:31Z","updated_at":"2016-07-11T08:14:14Z","pushed_at":"2016-07-21T13:58:23Z","git_url":"git://github.com/ttlappalainen/NMEA2000.git","ssh_url":"git@github.com:ttlappalainen/NMEA2000.git","clone_url":"https://github.com/ttlappalainen/NMEA2000.git","svn_url":"https://github.com/ttlappalainen/NMEA2000","homepage":null,"size":1255,"stargazers_count":24,"watchers_count":24,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":2,"forks":7,"open_issues":2,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13"},"html":{"href":"https://github.com/ttlappalainen/NMEA2000/pull/13"},"issue":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues/13"},"comments":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ttlappalainen/NMEA2000/statuses/b5beec26b2f6788ca62e4c20764a1db1d3fb39df"}}}}
{"actor":{"display_login":"thomasonw"}}