{"push_id":1298441207,"size":2,"distinct_size":2,"ref":"refs/heads/5.0","head":"ab5849db7e65111a41f11fde9823e4c4c5412df4","before":"298d01d1f4011cf06d3a7bd25f8e63730ad5ff57","commits":[{"sha":"58eb433b0be12314ff0fefca14dcfe561a25bb29","author":{"name":"Jason Tedor","email":"158e602a35675d2a0b685478824aa5995557a235@tedor.me"},"message":"Simplify Log4j shutdown hack test\n\nThe Log4j shutdown hack test tests that a hack we have in place to\r\nworkaround a bug in Log4j during shutdown is effective. Log4j can use\r\nJMX to control logging levels, but we disable this through the use of a\r\nsystem property log4j2.disable.jmx (mainly because there is no need for\r\nthis feature, but it also means granting additional security\r\npermissions). The bug in Log4j is that during shutdown, it neglects to\r\ncheck whether or not its usage of JMX is disable and so it attempts to\r\nunregister management beans, leading to a permissions violation. The\r\ntest works by attempting to shutdown Log4j and thus triggering the bad\r\ncode path. With the Log4j hack in place, we have introduced jar hell so\r\nthat its our code running instead of code from the Log4j jar. Our code\r\ncorrectly checks that the usage of JMX is disabled and thus does not\r\ntrip on a permissions violation. The test was a little complicated in\r\nthat it attempted to just grant the minimal permissions needed for Log4j\r\nto do its thing, but this can sometimes lead to other unwanted\r\npermissions violations because the permissions put in place are more\r\nrestrictive necessary. This commit simplifies this situation by\r\nrewriting the test to only deny Log4j the sole permission needed to\r\ntrigger the bug.\r\n\r\nRelates #20476","distinct":true,"url":"https://api.github.com/repos/NSIT/elasticsearch/commits/58eb433b0be12314ff0fefca14dcfe561a25bb29"},{"sha":"ab5849db7e65111a41f11fde9823e4c4c5412df4","author":{"name":"Boaz Leskes","email":"daaa071c1d6d35b7f0b1ebbbcc270afab5432337@gmail.com"},"message":"Don't generate html outputs from checkstyle (#20481)\n\nWe run our builds with `gradle --info` and that ends up generating horrific long dumps of xslt.","distinct":true,"url":"https://api.github.com/repos/NSIT/elasticsearch/commits/ab5849db7e65111a41f11fde9823e4c4c5412df4"}]}
{"actor":{"display_login":"pmvs-deploy"}}