{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1765","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1765/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1765/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1765/events","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1765","id":174531265,"number":1765,"title":"[Travis] Add testing of PHP 7.1","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-09-01T14:00:19Z","updated_at":"2016-09-12T19:46:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1765","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1765","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1765.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1765.patch"},"body":"Given PHP 7.1 is entering RC state we should start to have some testing\r\nof it in place for v1.6 (16.10) release.\r\n\r\n\r\n### Todo: Float rounding Issue\r\n\r\nFloat rounding issue in REST, seems something is causing rounding to behave strangly.\r\nChange in 7.1: https://wiki.php.net/rfc/precise_float_value\r\n23.424242424242424242  *Orignal*\r\n23.424242424242  *Expected (according to PHPUnit on PHP 7.1)*\r\n23.424242424242426 *Actual (according to PHPUnit on PHP 7.1), notice the strange rounding*\r\n\r\n\r\n```\r\n1) eZ\\Publish\\Core\\REST\\Common\\Tests\\Output\\Generator\\Json\\FieldTypeHashGeneratorTest::testGenerateFloatValue\r\nFailed asserting that two strings are identical.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-{\"Field\":{\"fieldValue\":23.424242424242}}\r\n+{\"Field\":{\"fieldValue\":23.424242424242426}}\r\n/home/travis/build/ezsystems/ezpublish-kernel/eZ/Publish/Core/REST/Common/Tests/Output/Generator/FieldTypeHashGeneratorBaseTest.php:197\r\n/home/travis/build/ezsystems/ezpublish-kernel/eZ/Publish/Core/REST/Common/Tests/Output/Generator/FieldTypeHashGeneratorBaseTest.php:70\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/246468377","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1765#issuecomment-246468377","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1765","id":246468377,"user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"created_at":"2016-09-12T19:46:35Z","updated_at":"2016-09-12T19:46:35Z","body":"Yes, tests needs to be adjusted here. But look at the numbers, seems the rounding is way off, *that* is why I'm saying there might be some PHP bug at play."}}
{"actor":{"display_login":"andrerom"}}