{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments/70020194","id":70020194,"diff_hunk":"@@ -0,0 +1,51 @@\n+/*\n+ * Copyright 2016 Google Inc. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *       http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.google.apphosting.logging;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+import java.util.logging.Handler;\n+import java.util.logging.LogRecord;\n+\n+public class JsonCaptureHandler extends Handler {","path":"appengine-java-logging/src/test/java/com/google/apphosting/logging/JsonCaptureHandler.java","position":24,"original_position":24,"commit_id":"5f4683b26b257df02f1cfc8abdd9fff5cde0b221","original_commit_id":"fdf95862337874af7c25b40b01b00d23e0c442f5","user":{"login":"aozarov","id":8921691,"avatar_url":"https://avatars.githubusercontent.com/u/8921691?v=3","gravatar_id":"","url":"https://api.github.com/users/aozarov","html_url":"https://github.com/aozarov","followers_url":"https://api.github.com/users/aozarov/followers","following_url":"https://api.github.com/users/aozarov/following{/other_user}","gists_url":"https://api.github.com/users/aozarov/gists{/gist_id}","starred_url":"https://api.github.com/users/aozarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aozarov/subscriptions","organizations_url":"https://api.github.com/users/aozarov/orgs","repos_url":"https://api.github.com/users/aozarov/repos","events_url":"https://api.github.com/users/aozarov/events{/privacy}","received_events_url":"https://api.github.com/users/aozarov/received_events","type":"User","site_admin":false},"body":"Sounds like a good reason to keep as is then.","created_at":"2016-07-08T03:03:31Z","updated_at":"2016-07-08T03:03:31Z","html_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/295#discussion_r70020194","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments/70020194"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/295#discussion_r70020194"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295","id":75751964,"html_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/295","diff_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/295.diff","patch_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/295.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/295","number":295,"state":"open","locked":false,"title":"Issue #231 - Logging Rotation and Levels","user":{"login":"joakime","id":191721,"avatar_url":"https://avatars.githubusercontent.com/u/191721?v=3","gravatar_id":"","url":"https://api.github.com/users/joakime","html_url":"https://github.com/joakime","followers_url":"https://api.github.com/users/joakime/followers","following_url":"https://api.github.com/users/joakime/following{/other_user}","gists_url":"https://api.github.com/users/joakime/gists{/gist_id}","starred_url":"https://api.github.com/users/joakime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakime/subscriptions","organizations_url":"https://api.github.com/users/joakime/orgs","repos_url":"https://api.github.com/users/joakime/repos","events_url":"https://api.github.com/users/joakime/events{/privacy}","received_events_url":"https://api.github.com/users/joakime/received_events","type":"User","site_admin":false},"body":"This PR introduces a bunch of updates to the logging to enable log rotation for both the app*.json and request*.log\r\n\r\nWe can tweak the rotation numbers in a later commit, but its currently setup as ...\r\n\r\n * app-#.json is at 3 total files of 100MB each (max size)\r\n * request-#.log is at 3 total files of 10MB each (max size)\r\n\r\nThis also includes the ability to capture log4j & commons-logging & slf4j and route it to the java.util.logging setup.\r\n\r\nrequest logging is also using this new logging layer (not using the older Jetty FileRollover implementation)","created_at":"2016-06-30T02:37:45Z","updated_at":"2016-07-08T03:03:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7c6719b639064f41aa75efd5c7bcbf67fe482f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/295/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/statuses/5f4683b26b257df02f1cfc8abdd9fff5cde0b221","head":{"label":"jetty-project:bugs/231-julroot","ref":"bugs/231-julroot","sha":"5f4683b26b257df02f1cfc8abdd9fff5cde0b221","user":{"login":"jetty-project","id":903858,"avatar_url":"https://avatars.githubusercontent.com/u/903858?v=3","gravatar_id":"","url":"https://api.github.com/users/jetty-project","html_url":"https://github.com/jetty-project","followers_url":"https://api.github.com/users/jetty-project/followers","following_url":"https://api.github.com/users/jetty-project/following{/other_user}","gists_url":"https://api.github.com/users/jetty-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jetty-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetty-project/subscriptions","organizations_url":"https://api.github.com/users/jetty-project/orgs","repos_url":"https://api.github.com/users/jetty-project/repos","events_url":"https://api.github.com/users/jetty-project/events{/privacy}","received_events_url":"https://api.github.com/users/jetty-project/received_events","type":"Organization","site_admin":false},"repo":{"id":39987516,"name":"appengine-java-vm-runtime","full_name":"jetty-project/appengine-java-vm-runtime","owner":{"login":"jetty-project","id":903858,"avatar_url":"https://avatars.githubusercontent.com/u/903858?v=3","gravatar_id":"","url":"https://api.github.com/users/jetty-project","html_url":"https://github.com/jetty-project","followers_url":"https://api.github.com/users/jetty-project/followers","following_url":"https://api.github.com/users/jetty-project/following{/other_user}","gists_url":"https://api.github.com/users/jetty-project/gists{/gist_id}","starred_url":"https://api.github.com/users/jetty-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetty-project/subscriptions","organizations_url":"https://api.github.com/users/jetty-project/orgs","repos_url":"https://api.github.com/users/jetty-project/repos","events_url":"https://api.github.com/users/jetty-project/events{/privacy}","received_events_url":"https://api.github.com/users/jetty-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetty-project/appengine-java-vm-runtime","description":"","fork":true,"url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime","forks_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/forks","keys_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/teams","hooks_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/hooks","issue_events_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/events","assignees_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/tags","blobs_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/languages","stargazers_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/stargazers","contributors_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/contributors","subscribers_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/subscribers","subscription_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/subscription","commits_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/merges","archive_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/downloads","issues_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/labels{/name}","releases_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/jetty-project/appengine-java-vm-runtime/deployments","created_at":"2015-07-31T05:01:09Z","updated_at":"2016-01-14T03:25:50Z","pushed_at":"2016-07-08T01:58:44Z","git_url":"git://github.com/jetty-project/appengine-java-vm-runtime.git","ssh_url":"git@github.com:jetty-project/appengine-java-vm-runtime.git","clone_url":"https://github.com/jetty-project/appengine-java-vm-runtime.git","svn_url":"https://github.com/jetty-project/appengine-java-vm-runtime","homepage":null,"size":2957,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:async-support","ref":"async-support","sha":"c0207cffac20b0f60f38c903cc121c96b1958f96","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":25889832,"name":"appengine-java-vm-runtime","full_name":"GoogleCloudPlatform/appengine-java-vm-runtime","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime","description":"","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/deployments","created_at":"2014-10-28T20:59:13Z","updated_at":"2016-06-25T10:06:02Z","pushed_at":"2016-07-08T01:58:46Z","git_url":"git://github.com/GoogleCloudPlatform/appengine-java-vm-runtime.git","ssh_url":"git@github.com:GoogleCloudPlatform/appengine-java-vm-runtime.git","clone_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime.git","svn_url":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime","homepage":null,"size":2775,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":49,"forks":26,"open_issues":49,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295"},"html":{"href":"https://github.com/GoogleCloudPlatform/appengine-java-vm-runtime/pull/295"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/295"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/issues/295/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/pulls/295/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/appengine-java-vm-runtime/statuses/5f4683b26b257df02f1cfc8abdd9fff5cde0b221"}}}}
{"actor":{"display_login":"aozarov"}}