{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/49985454","id":49985454,"diff_hunk":"@@ -343,47 +345,47 @@ sub GetPathEntries {\n     my $entries = {};\n \n     # Check the input parameters.\n-    if ( ! defined $path   || $path   eq \"\" ) {\n-\t$? = 1;\n-\t$@ = \"resource path to query empty\";\n-\treturn $entries;\n+    if (!defined $path || $path   eq \"\") {","path":"ncm-iptables/src/main/perl/iptables.pm","position":526,"original_position":526,"commit_id":"aebc65418843d59a75c0805895e8344d770d9ecb","original_commit_id":"aebc65418843d59a75c0805895e8344d770d9ecb","user":{"login":"stdweird","id":1517606,"avatar_url":"https://avatars.githubusercontent.com/u/1517606?v=3","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"where does `$path` come from?","created_at":"2016-01-18T11:01:32Z","updated_at":"2016-01-18T11:01:32Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/688#discussion_r49985454","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/49985454"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/688#discussion_r49985454"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688","id":56325904,"html_url":"https://github.com/quattor/configuration-modules-core/pull/688","diff_url":"https://github.com/quattor/configuration-modules-core/pull/688.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/688.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/688","number":688,"state":"open","locked":false,"title":"ncm-iptables: Add support for per-rule comments","user":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"body":"Fixes #576.\r\n\r\nSeveral commits mixed in to clean up formatting.\r\nI'm going to do some more work on this component, because the source code makes me ill.","created_at":"2016-01-18T10:39:56Z","updated_at":"2016-01-18T11:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c292d8649e99cdf67e7eb575b1887d15f09a4f0","assignee":null,"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/11","html_url":"https://github.com/quattor/configuration-modules-core/milestones/16.2","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/11/labels","id":1034219,"number":11,"title":"16.2","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":19,"state":"open","created_at":"2015-03-23T15:08:20Z","updated_at":"2016-01-18T10:40:03Z","due_on":"2016-02-29T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/688/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/aebc65418843d59a75c0805895e8344d770d9ecb","head":{"label":"jrha:iptables-comments","ref":"iptables-comments","sha":"aebc65418843d59a75c0805895e8344d770d9ecb","user":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"repo":{"id":9372871,"name":"configuration-modules-core","full_name":"jrha/configuration-modules-core","owner":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrha/configuration-modules-core","description":"Core NCM components for Quattor","fork":true,"url":"https://api.github.com/repos/jrha/configuration-modules-core","forks_url":"https://api.github.com/repos/jrha/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/jrha/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrha/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrha/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/jrha/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/jrha/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/jrha/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/jrha/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/jrha/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/jrha/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/jrha/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrha/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrha/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrha/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrha/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jrha/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/jrha/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/jrha/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/jrha/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/jrha/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/jrha/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrha/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrha/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrha/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrha/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/jrha/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrha/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/jrha/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrha/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/jrha/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/jrha/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jrha/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jrha/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrha/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/jrha/configuration-modules-core/releases{/id}","created_at":"2013-04-11T14:56:15Z","updated_at":"2015-04-28T14:14:16Z","pushed_at":"2016-01-18T10:37:14Z","git_url":"git://github.com/jrha/configuration-modules-core.git","ssh_url":"git@github.com:jrha/configuration-modules-core.git","clone_url":"https://github.com/jrha/configuration-modules-core.git","svn_url":"https://github.com/jrha/configuration-modules-core","homepage":null,"size":9565,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"eb960f51864bb9bcb23233795a8c703adee50662","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","created_at":"2012-10-31T09:08:07Z","updated_at":"2016-01-11T13:45:42Z","pushed_at":"2016-01-18T10:39:57Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":10849,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":82,"forks":31,"open_issues":82,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/688"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/688"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/aebc65418843d59a75c0805895e8344d770d9ecb"}}}}