{"action":"created","issue":{"url":"https://api.github.com/repos/PixInsight/PCL/issues/29","repository_url":"https://api.github.com/repos/PixInsight/PCL","labels_url":"https://api.github.com/repos/PixInsight/PCL/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/PixInsight/PCL/issues/29/comments","events_url":"https://api.github.com/repos/PixInsight/PCL/issues/29/events","html_url":"https://github.com/PixInsight/PCL/issues/29","id":158510911,"number":29,"title":"INDIClient version 1.0.12.183","user":{"login":"jconejero","id":9529604,"avatar_url":"https://avatars.githubusercontent.com/u/9529604?v=3","gravatar_id":"","url":"https://api.github.com/users/jconejero","html_url":"https://github.com/jconejero","followers_url":"https://api.github.com/users/jconejero/followers","following_url":"https://api.github.com/users/jconejero/following{/other_user}","gists_url":"https://api.github.com/users/jconejero/gists{/gist_id}","starred_url":"https://api.github.com/users/jconejero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jconejero/subscriptions","organizations_url":"https://api.github.com/users/jconejero/orgs","repos_url":"https://api.github.com/users/jconejero/repos","events_url":"https://api.github.com/users/jconejero/events{/privacy}","received_events_url":"https://api.github.com/users/jconejero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-06-04T16:01:49Z","updated_at":"2016-06-04T19:23:59Z","closed_at":null,"body":"Hi Team, and especially Klaus,\r\n\r\nI have just pushed a complete revision of Klaus' INDIClient module: https://github.com/PixInsight/PCL/commit/48e3476b61035b51df65c983e7e236b590b4847f, where we have a new, fully operational INDIMount process. In first place, congratulations to Klaus for his excellent work. The main changes with respect to Klaus' latest pull request https://github.com/PixInsight/PCL/pull/28 are:\r\n\r\n- Redesigned INDINewPropertyItem class with more flexible template constructors.\r\n\r\n- New template member functions INDIClient::SendNewPropertyItem() and INDIClient::MaybeSendNewPropertyItem() for simplified sending of device properties, including bulk properties.\r\n\r\n- Extensive use of new PCL resources for sexagesimal numeric conversion and representation. See String::SexagesimalToDouble(), String::TrySexagesimalToDouble(), String::ParseSexagesimal(), String::TryParseSexagesimal() and String::ToSexagesimal() member functions (and their IsoString counterparts) in pcl/String.h and pcl/String.cpp. See also the new DecimalToSexagesimal() and  SexagesimalToDecimal() global functions in pcl/Math.h.\r\n\r\n- Redesigned CoordinateSearchDialog class with more powerful online search and interactive information visualization capabilities.\r\n\r\n- Redesigned INDIMountInterface class.\r\n\r\n- Improved AbstractINDIMountExecution (and derived classes) for better GUI interaction.\r\n\r\n- Changed class member and enumeration identifiers for coherence with PCL coding style guidelines.\r\n\r\n- Changed exported parameter identifiers to be more coherent with existing JavaScript interfaces. Of course, I have updated the relevant test scripts accordingly.\r\n\r\n- New IMCCommand::ParkDefault command to park the mount at the current park coordinates (TELESCOPE_PARK_POSITION property). The IMCCommand::Park command now parks at the p_targetRA and p_targetDec parameter values of INDIMountInstance.\r\n\r\n- Bug fixes and performance improvements.\r\n\r\nI have tested this version and it seems to work extremely well. It passes all tests without any problems. There are a couple of very minor issues I'm going to fix, but it is ready for release IMO. Let me know if you agree with the changes.\r\n"},"comment":{"url":"https://api.github.com/repos/PixInsight/PCL/issues/comments/223773392","html_url":"https://github.com/PixInsight/PCL/issues/29#issuecomment-223773392","issue_url":"https://api.github.com/repos/PixInsight/PCL/issues/29","id":223773392,"user":{"login":"kkretzschmar","id":2159270,"avatar_url":"https://avatars.githubusercontent.com/u/2159270?v=3","gravatar_id":"","url":"https://api.github.com/users/kkretzschmar","html_url":"https://github.com/kkretzschmar","followers_url":"https://api.github.com/users/kkretzschmar/followers","following_url":"https://api.github.com/users/kkretzschmar/following{/other_user}","gists_url":"https://api.github.com/users/kkretzschmar/gists{/gist_id}","starred_url":"https://api.github.com/users/kkretzschmar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkretzschmar/subscriptions","organizations_url":"https://api.github.com/users/kkretzschmar/orgs","repos_url":"https://api.github.com/users/kkretzschmar/repos","events_url":"https://api.github.com/users/kkretzschmar/events{/privacy}","received_events_url":"https://api.github.com/users/kkretzschmar/received_events","type":"User","site_admin":false},"created_at":"2016-06-04T19:23:58Z","updated_at":"2016-06-04T19:23:58Z","body":"Hi Juan,\nlooks great!! I'll test it on windows but I don't expect any problems here.\nHowever it turned out that the setup with the windi server sometimes\nbehaves different. I'd like to know where problems can occur. Maybe the\nwheather allows me to test also on real stars.\n\n I am not sure how excatly the current park option really works. As far as\nI remember this option is for setting a custom park position in combination\nwith TELESCOPE_PARK_OPTION -> PARK_WRITE_DATA. For example, if your\ntelescope needs a special park positioin so that the roof of your small\nbackyard observator can be closed (as in my case), then you first move the\ntelescope to your park position, then set  TELESCOPE_PARK_OPTION to\nPARK_CURRENT and then set   TELESCOPE_PARK_OPTION to PARK_WRITE_DATA to\nwrite the encoder data on the file system which is important to calculate\nthe real telescope position in RA and DEC. I am not sure but we should test\non real stars first I think, or did you already test this option?\n\n\n\n\n\n2016-06-04 18:01 GMT+02:00 Juan Conejero <notifications@github.com>:\n\n> Hi Team, and especially Klaus,\n>\n> I have just pushed a complete revision of Klaus' INDIClient module:\n> 48e3476\n> <https://github.com/PixInsight/PCL/commit/48e3476b61035b51df65c983e7e236b590b4847f>,\n> where we have a new, fully operational INDIMount process. In first place,\n> congratulations to Klaus for his excellent work. The main changes with\n> respect to Klaus' latest pull request #28\n> <https://github.com/PixInsight/PCL/pull/28> are:\n>\n>    -\n>\n>    Redesigned INDINewPropertyItem class with more flexible template\n>    constructors.\n>    -\n>\n>    New template member functions INDIClient::SendNewPropertyItem() and\n>    INDIClient::MaybeSendNewPropertyItem() for simplified sending of device\n>    properties, including bulk properties.\n>    -\n>\n>    Extensive use of new PCL resources for sexagesimal numeric conversion\n>    and representation. See String::SexagesimalToDouble(),\n>    String::TrySexagesimalToDouble(), String::ParseSexagesimal(),\n>    String::TryParseSexagesimal() and String::ToSexagesimal() member functions\n>    (and their IsoString counterparts) in pcl/String.h and pcl/String.cpp. See\n>    also the new DecimalToSexagesimal() and SexagesimalToDecimal() global\n>    functions in pcl/Math.h.\n>    -\n>\n>    Redesigned CoordinateSearchDialog class with more powerful online\n>    search and interactive information visualization capabilities.\n>    -\n>\n>    Redesigned INDIMountInterface class.\n>    -\n>\n>    Improved AbstractINDIMountExecution (and derived classes) for better\n>    GUI interaction.\n>    -\n>\n>    Changed class member and enumeration identifiers for coherence with\n>    PCL coding style guidelines.\n>    -\n>\n>    Changed exported parameter identifiers to be more coherent with\n>    existing JavaScript interfaces. Of course, I have updated the relevant test\n>    scripts accordingly.\n>    -\n>\n>    New IMCCommand::ParkDefault command to park the mount at the current\n>    park coordinates (TELESCOPE_PARK_POSITION property). The IMCCommand::Park\n>    command now parks at the p_targetRA and p_targetDec parameter values of\n>    INDIMountInstance.\n>    -\n>\n>    Bug fixes and performance improvements.\n>\n> I have tested this version and it seems to work extremely well. It passes\n> all tests without any problems. There are a couple of very minor issues I'm\n> going to fix, but it is ready for release IMO. Let me know if you agree\n> with the changes.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/PixInsight/PCL/issues/29>, or mute the thread\n> <https://github.com/notifications/unsubscribe/ACDyphM9_JlEGb0tc3_hrL0ZReOm3STJks5qIaFugaJpZM4IuKHR>\n> .\n>\n"}}
{"actor":{"display_login":"kkretzschmar"}}