{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/93993886","pull_request_review_id":14523832,"id":93993886,"diff_hunk":"@@ -32,8 +32,7 @@ ParameterUpdater *ParameterUpdater::createRemoteUpdater(\n     OptimizationConfig *config, int passCount) {\n   auto updater = new ParameterUpdater();\n   std::unique_ptr<paddle::ParameterUpdater> localUpdater;\n-  localUpdater.reset(new paddle::SgdThreadUpdater(config->m->getConfig()));\n-  updater->m->updater.reset(new paddle::ConcurrentRemoteParameterUpdater(\n+  updater->m->updater.reset(new paddle::RemoteParameterUpdater(\n       config->m->getConfig(), passCount, std::move(localUpdater)));","path":"paddle/api/ParameterUpdater.cpp","position":null,"original_position":7,"commit_id":"647f9a0f4e076121012633c33067febb96038284","original_commit_id":"647f9a0f4e076121012633c33067febb96038284","user":{"login":"reyoung","id":728699,"avatar_url":"https://avatars.githubusercontent.com/u/728699?v=3","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},"body":"直接传nullptr就行了","created_at":"2016-12-28T04:22:00Z","updated_at":"2016-12-28T04:22:22Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/1018#discussion_r93993886","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/93993886"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/1018#discussion_r93993886"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018"}}},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018","id":99402986,"html_url":"https://github.com/PaddlePaddle/Paddle/pull/1018","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/1018.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/1018.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1018","number":1018,"state":"open","locked":false,"title":"[in progress]add RemoteUpdater in api for cluster training","user":{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars.githubusercontent.com/u/3048612?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-12-27T03:52:03Z","updated_at":"2016-12-28T04:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"589445a880422c258eead06f26998585556b3811","assignee":{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars.githubusercontent.com/u/3048612?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false},"assignees":[{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars.githubusercontent.com/u/3048612?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1018/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/647f9a0f4e076121012633c33067febb96038284","head":{"label":"jacquesqiao:remote-updater","ref":"remote-updater","sha":"647f9a0f4e076121012633c33067febb96038284","user":{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars.githubusercontent.com/u/3048612?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false},"repo":{"id":75146336,"name":"Paddle","full_name":"jacquesqiao/Paddle","owner":{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars.githubusercontent.com/u/3048612?v=3","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jacquesqiao/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/jacquesqiao/Paddle","forks_url":"https://api.github.com/repos/jacquesqiao/Paddle/forks","keys_url":"https://api.github.com/repos/jacquesqiao/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jacquesqiao/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jacquesqiao/Paddle/teams","hooks_url":"https://api.github.com/repos/jacquesqiao/Paddle/hooks","issue_events_url":"https://api.github.com/repos/jacquesqiao/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/jacquesqiao/Paddle/events","assignees_url":"https://api.github.com/repos/jacquesqiao/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/jacquesqiao/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/jacquesqiao/Paddle/tags","blobs_url":"https://api.github.com/repos/jacquesqiao/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jacquesqiao/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jacquesqiao/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/jacquesqiao/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jacquesqiao/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/jacquesqiao/Paddle/languages","stargazers_url":"https://api.github.com/repos/jacquesqiao/Paddle/stargazers","contributors_url":"https://api.github.com/repos/jacquesqiao/Paddle/contributors","subscribers_url":"https://api.github.com/repos/jacquesqiao/Paddle/subscribers","subscription_url":"https://api.github.com/repos/jacquesqiao/Paddle/subscription","commits_url":"https://api.github.com/repos/jacquesqiao/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/jacquesqiao/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/jacquesqiao/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/jacquesqiao/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/jacquesqiao/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/jacquesqiao/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jacquesqiao/Paddle/merges","archive_url":"https://api.github.com/repos/jacquesqiao/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jacquesqiao/Paddle/downloads","issues_url":"https://api.github.com/repos/jacquesqiao/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/jacquesqiao/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/jacquesqiao/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/jacquesqiao/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jacquesqiao/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/jacquesqiao/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/jacquesqiao/Paddle/deployments","created_at":"2016-11-30T03:13:08Z","updated_at":"2016-11-30T03:13:12Z","pushed_at":"2016-12-27T16:35:37Z","git_url":"git://github.com/jacquesqiao/Paddle.git","ssh_url":"git@github.com:jacquesqiao/Paddle.git","clone_url":"https://github.com/jacquesqiao/Paddle.git","svn_url":"https://github.com/jacquesqiao/Paddle","homepage":"http://www.paddlepaddle.org/","size":17320,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"22454ed47fe5dab708b7611edf34bb43bce3d942","user":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars.githubusercontent.com/u/23534030?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"PaddlePaddle/Paddle","owner":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars.githubusercontent.com/u/23534030?v=3","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2016-12-28T03:36:31Z","pushed_at":"2016-12-28T03:29:44Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"git@github.com:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":17401,"stargazers_count":4031,"watchers_count":4031,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":996,"mirror_url":null,"open_issues_count":167,"forks":996,"open_issues":167,"watchers":4031,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/1018"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1018"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/1018/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/1018/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/647f9a0f4e076121012633c33067febb96038284"}}}}
{"actor":{"display_login":"reyoung"}}