{"action":"opened","issue":{"url":"https://api.github.com/repos/stepmania/stepmania/issues/1089","repository_url":"https://api.github.com/repos/stepmania/stepmania","labels_url":"https://api.github.com/repos/stepmania/stepmania/issues/1089/labels{/name}","comments_url":"https://api.github.com/repos/stepmania/stepmania/issues/1089/comments","events_url":"https://api.github.com/repos/stepmania/stepmania/issues/1089/events","html_url":"https://github.com/stepmania/stepmania/issues/1089","id":153370271,"number":1089,"title":"[Bug] Pump: Holds and TapNotes on the same row","user":{"login":"luizsan","id":2966057,"avatar_url":"https://avatars.githubusercontent.com/u/2966057?v=3","gravatar_id":"","url":"https://api.github.com/users/luizsan","html_url":"https://github.com/luizsan","followers_url":"https://api.github.com/users/luizsan/followers","following_url":"https://api.github.com/users/luizsan/following{/other_user}","gists_url":"https://api.github.com/users/luizsan/gists{/gist_id}","starred_url":"https://api.github.com/users/luizsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luizsan/subscriptions","organizations_url":"https://api.github.com/users/luizsan/orgs","repos_url":"https://api.github.com/users/luizsan/repos","events_url":"https://api.github.com/users/luizsan/events{/privacy}","received_events_url":"https://api.github.com/users/luizsan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-06T03:15:32Z","updated_at":"2016-05-06T03:15:32Z","closed_at":null,"body":"When hold checkpoints are enabled (pump game mode), it's impossible to obtain the maximum possible dance points for a song when you have a hold and a tap note on the same row, assuming that the metric `PercentScoreWeightCheckpointHit` is greater than zero. \r\n\r\nThe function `GetPossibleDancePoints()` counts both CheckpointHit and the TapNote possible dance points on the same row, but when playing, you are unable to get the dance points for both notes, assuming default settings. \r\n\r\nThis probably is a result from some weird interaction in the metric `CheckpointsTapsSeparateJudgment`.\r\n\r\nAn example and how to reproduce the bug: \r\n\r\nI have a chart which contains the following pattern, and nothing else:\r\n![ss 2016-05-06 at 12 02 29](https://cloud.githubusercontent.com/assets/2966057/15063172/0ee05da4-131e-11e6-9c37-a9d89268931d.png)\r\n\r\nThen I go into gameplay and manage to hit all notes with the best possible score:\r\n![ss 2016-05-06 at 12 01 47](https://cloud.githubusercontent.com/assets/2966057/15063190/4bf3dc20-131e-11e6-85e7-128f5fd0f19c.png)\r\n\r\nThe game expected me to obtain the dance points for both the TapNotes and the CheckpointHit on the very last row of the chart, but it's impossible to do so on the default settings, thus, I wasn't able to get a 100% and all the ITG/MIGS DP.\r\n\r\nIt's only possible to obtain every possible dance point if you have the metric `CheckpointsTapsSeparateJudgment` set to `true`.\r\n\r\n\r\n"}}