{"action":"created","issue":{"url":"https://api.github.com/repos/Shopify/shopify_app/issues/266","repository_url":"https://api.github.com/repos/Shopify/shopify_app","labels_url":"https://api.github.com/repos/Shopify/shopify_app/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/Shopify/shopify_app/issues/266/comments","events_url":"https://api.github.com/repos/Shopify/shopify_app/issues/266/events","html_url":"https://github.com/Shopify/shopify_app/pull/266","id":158596116,"number":266,"title":"Add webhook topic whitelist","user":{"login":"alanhill","id":2029560,"avatar_url":"https://avatars.githubusercontent.com/u/2029560?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhill","html_url":"https://github.com/alanhill","followers_url":"https://api.github.com/users/alanhill/followers","following_url":"https://api.github.com/users/alanhill/following{/other_user}","gists_url":"https://api.github.com/users/alanhill/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhill/subscriptions","organizations_url":"https://api.github.com/users/alanhill/orgs","repos_url":"https://api.github.com/users/alanhill/repos","events_url":"https://api.github.com/users/alanhill/events{/privacy}","received_events_url":"https://api.github.com/users/alanhill/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Shopify/shopify_app/labels/in%20progress","name":"in progress","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-06-06T03:48:07Z","updated_at":"2016-06-06T16:10:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Shopify/shopify_app/pulls/266","html_url":"https://github.com/Shopify/shopify_app/pull/266","diff_url":"https://github.com/Shopify/shopify_app/pull/266.diff","patch_url":"https://github.com/Shopify/shopify_app/pull/266.patch"},"body":"##### What's it do\r\n\r\nValidates the topic of the webhook when generating a webhook via console or in the case of mis-typing directly into the config, when the Webhook attempts to install. (https://github.com/Shopify/shopify_app/issues/264)\r\n\r\n##### How\r\n\r\nThere's a list of constants with all the valid webhook topics. In the case of the generator, it will raise an InvalidTopic error and list out the valid topics. If it fails upon creation on a shop, it will log a warning with the valid topics, then fall back to the CreationFailed error like normal. \r\n\r\n@kevinhughes27 is this what you had in mind? I couldn't think of a good way to DRY the list of constants, all ears if you have ideas. "},"comment":{"url":"https://api.github.com/repos/Shopify/shopify_app/issues/comments/224006892","html_url":"https://github.com/Shopify/shopify_app/pull/266#issuecomment-224006892","issue_url":"https://api.github.com/repos/Shopify/shopify_app/issues/266","id":224006892,"user":{"login":"alanhill","id":2029560,"avatar_url":"https://avatars.githubusercontent.com/u/2029560?v=3","gravatar_id":"","url":"https://api.github.com/users/alanhill","html_url":"https://github.com/alanhill","followers_url":"https://api.github.com/users/alanhill/followers","following_url":"https://api.github.com/users/alanhill/following{/other_user}","gists_url":"https://api.github.com/users/alanhill/gists{/gist_id}","starred_url":"https://api.github.com/users/alanhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanhill/subscriptions","organizations_url":"https://api.github.com/users/alanhill/orgs","repos_url":"https://api.github.com/users/alanhill/repos","events_url":"https://api.github.com/users/alanhill/events{/privacy}","received_events_url":"https://api.github.com/users/alanhill/received_events","type":"User","site_admin":false},"created_at":"2016-06-06T16:10:25Z","updated_at":"2016-06-06T16:10:25Z","body":"Moved it into a concern.. can't seem to get `Rails.logger.warn` (or `shell.say`) to work though now that it's been moved. 👀  into it.."}}
{"actor":{"display_login":"alanhill"}}