{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-java/pulls/comments/56891660","id":56891660,"diff_hunk":"@@ -27,8 +27,6 @@\n \n import java.nio.ByteBuffer;\n \n-public interface HandlerWrapper {\n-    Response<ByteBuffer> handle(Request<ByteBuffer> transportRequest) throws RPCException;\n-\n+public interface TransportHandler extends Handler<ByteBuffer, ByteBuffer> {","path":"yarpc-core/src/main/java/io/yarpc/handler/TransportHandler.java","position":7,"original_position":7,"commit_id":"4dc898c59e16c8485ee1989c280a26e38ae5c418","original_commit_id":"4dc898c59e16c8485ee1989c280a26e38ae5c418","user":{"login":"abhinav","id":41730,"avatar_url":"https://avatars.githubusercontent.com/u/41730?v=3","gravatar_id":"","url":"https://api.github.com/users/abhinav","html_url":"https://github.com/abhinav","followers_url":"https://api.github.com/users/abhinav/followers","following_url":"https://api.github.com/users/abhinav/following{/other_user}","gists_url":"https://api.github.com/users/abhinav/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinav/subscriptions","organizations_url":"https://api.github.com/users/abhinav/orgs","repos_url":"https://api.github.com/users/abhinav/repos","events_url":"https://api.github.com/users/abhinav/events{/privacy}","received_events_url":"https://api.github.com/users/abhinav/received_events","type":"User","site_admin":false},"body":"This doesn't really address the problem you mentioned in person. You said you didn't want users to be able to do this (or discourage them from doing this):\r\n\r\n    public class MyHandler implements Handler<ByteBuffer, ByteBuffer> { ... }\r\n    rpc.register(\"foo\", new MyHandler())\r\n\r\nYou said you want users to use handlers built via `{Raw,Json,Thrift}InboundHandler`. This interface doesn't solve that problem. I can still do that with one minor change:\r\n\r\n    public class MyHandler implements TransportHandler { ... }\r\n    rpc.register(\"foo\", new MyHandler())\r\n\r\nTo get what you're trying to achieve, you'd have to do something like,\r\n\r\n    public class TransportHandler {\r\n        private Handler<ByteBuffer, ByteBuffer> handler\r\n        // ...\r\n    }\r\n\r\nThat is, make TransportHandler some sort of opaque container of wrapped handlers that you can get from JsonInboundHandler, etc.","created_at":"2016-03-21T20:33:31Z","updated_at":"2016-03-21T20:33:31Z","html_url":"https://github.com/yarpc/yarpc-java/pull/68#discussion_r56891660","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-java/pulls/comments/56891660"},"html":{"href":"https://github.com/yarpc/yarpc-java/pull/68#discussion_r56891660"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68","id":63626560,"html_url":"https://github.com/yarpc/yarpc-java/pull/68","diff_url":"https://github.com/yarpc/yarpc-java/pull/68.diff","patch_url":"https://github.com/yarpc/yarpc-java/pull/68.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-java/issues/68","number":68,"state":"open","locked":false,"title":"Rename handlerWrapper to transportHandler","user":{"login":"junchaowu","id":3731781,"avatar_url":"https://avatars.githubusercontent.com/u/3731781?v=3","gravatar_id":"","url":"https://api.github.com/users/junchaowu","html_url":"https://github.com/junchaowu","followers_url":"https://api.github.com/users/junchaowu/followers","following_url":"https://api.github.com/users/junchaowu/following{/other_user}","gists_url":"https://api.github.com/users/junchaowu/gists{/gist_id}","starred_url":"https://api.github.com/users/junchaowu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junchaowu/subscriptions","organizations_url":"https://api.github.com/users/junchaowu/orgs","repos_url":"https://api.github.com/users/junchaowu/repos","events_url":"https://api.github.com/users/junchaowu/events{/privacy}","received_events_url":"https://api.github.com/users/junchaowu/received_events","type":"User","site_admin":false},"body":"This is to fix https://github.com/yarpc/yarpc-java/issues/46","created_at":"2016-03-21T20:25:25Z","updated_at":"2016-03-21T20:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d67b565b44dc8cf76fd514bbff418d23dbe97e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-java/issues/68/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-java/statuses/4dc898c59e16c8485ee1989c280a26e38ae5c418","head":{"label":"yarpc:transportHandler","ref":"transportHandler","sha":"4dc898c59e16c8485ee1989c280a26e38ae5c418","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390107,"name":"yarpc-java","full_name":"yarpc/yarpc-java","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-java","description":"YARPC for Java","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-java","forks_url":"https://api.github.com/repos/yarpc/yarpc-java/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-java/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-java/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-java/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-java/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-java/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-java/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-java/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-java/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-java/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-java/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-java/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-java/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-java/deployments","created_at":"2016-01-26T00:04:00Z","updated_at":"2016-03-17T19:55:10Z","pushed_at":"2016-03-21T20:25:25Z","git_url":"git://github.com/yarpc/yarpc-java.git","ssh_url":"git@github.com:yarpc/yarpc-java.git","clone_url":"https://github.com/yarpc/yarpc-java.git","svn_url":"https://github.com/yarpc/yarpc-java","homepage":"","size":224,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"yarpc:master","ref":"master","sha":"ce49128114dda88d322fd48519434f642cbc1ab6","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390107,"name":"yarpc-java","full_name":"yarpc/yarpc-java","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-java","description":"YARPC for Java","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-java","forks_url":"https://api.github.com/repos/yarpc/yarpc-java/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-java/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-java/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-java/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-java/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-java/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-java/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-java/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-java/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-java/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-java/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-java/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-java/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-java/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-java/deployments","created_at":"2016-01-26T00:04:00Z","updated_at":"2016-03-17T19:55:10Z","pushed_at":"2016-03-21T20:25:25Z","git_url":"git://github.com/yarpc/yarpc-java.git","ssh_url":"git@github.com:yarpc/yarpc-java.git","clone_url":"https://github.com/yarpc/yarpc-java.git","svn_url":"https://github.com/yarpc/yarpc-java","homepage":"","size":224,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68"},"html":{"href":"https://github.com/yarpc/yarpc-java/pull/68"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-java/issues/68"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-java/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-java/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-java/statuses/4dc898c59e16c8485ee1989c280a26e38ae5c418"}}}}