{"action":"created","issue":{"url":"https://api.github.com/repos/DeviationTX/deviation/issues/43","repository_url":"https://api.github.com/repos/DeviationTX/deviation","labels_url":"https://api.github.com/repos/DeviationTX/deviation/issues/43/labels{/name}","comments_url":"https://api.github.com/repos/DeviationTX/deviation/issues/43/comments","events_url":"https://api.github.com/repos/DeviationTX/deviation/issues/43/events","html_url":"https://github.com/DeviationTX/deviation/pull/43","id":180479768,"number":43,"title":"Fix FrskyX dropout issue","user":{"login":"hexfet","id":2784240,"avatar_url":"https://avatars.githubusercontent.com/u/2784240?v=3","gravatar_id":"","url":"https://api.github.com/users/hexfet","html_url":"https://github.com/hexfet","followers_url":"https://api.github.com/users/hexfet/followers","following_url":"https://api.github.com/users/hexfet/following{/other_user}","gists_url":"https://api.github.com/users/hexfet/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfet/subscriptions","organizations_url":"https://api.github.com/users/hexfet/orgs","repos_url":"https://api.github.com/users/hexfet/repos","events_url":"https://api.github.com/users/hexfet/events{/privacy}","received_events_url":"https://api.github.com/users/hexfet/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-10-01T20:56:12Z","updated_at":"2016-10-11T05:01:58Z","closed_at":"2016-10-09T23:33:25Z","pull_request":{"url":"https://api.github.com/repos/DeviationTX/deviation/pulls/43","html_url":"https://github.com/DeviationTX/deviation/pull/43","diff_url":"https://github.com/DeviationTX/deviation/pull/43.diff","patch_url":"https://github.com/DeviationTX/deviation/pull/43.patch"},"body":"petsmith discovered that telemetry packets may have corrupted values, including for the s.port data length value in pkt[6].  This length was used for looping over the data and processing incorrect large values caused protocol timing issues resulting in dropouts.\r\n\r\nAdded additional checks on telemetry packet to fix the issue:\r\n- received packet length must match expected value\r\n- crc check on packet contents\r\n- length of s.port data must match expected value\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DeviationTX/deviation/issues/comments/252814548","html_url":"https://github.com/DeviationTX/deviation/pull/43#issuecomment-252814548","issue_url":"https://api.github.com/repos/DeviationTX/deviation/issues/43","id":252814548,"user":{"login":"hexfet","id":2784240,"avatar_url":"https://avatars.githubusercontent.com/u/2784240?v=3","gravatar_id":"","url":"https://api.github.com/users/hexfet","html_url":"https://github.com/hexfet","followers_url":"https://api.github.com/users/hexfet/followers","following_url":"https://api.github.com/users/hexfet/following{/other_user}","gists_url":"https://api.github.com/users/hexfet/gists{/gist_id}","starred_url":"https://api.github.com/users/hexfet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexfet/subscriptions","organizations_url":"https://api.github.com/users/hexfet/orgs","repos_url":"https://api.github.com/users/hexfet/repos","events_url":"https://api.github.com/users/hexfet/events{/privacy}","received_events_url":"https://api.github.com/users/hexfet/received_events","type":"User","site_admin":false},"created_at":"2016-10-11T05:01:58Z","updated_at":"2016-10-11T05:01:58Z","body":"Please connect your 8s in USB mode, save the errors.txt file, and paste here.\r\nThen edit the tx.ini file to change the first line, current_model, to a model that is not set for FrskyX protocol.\r\nTurn the tx off and on to boot normally, go to the model using FrskyX, and change the Fixed ID before trying to bind.\r\n\r\nThis worked for me, though I'm surprised it happened to someone else.  My errors.txt file indicates the get_tx_id function gets stuck in an infinite loop, but haven't looked into it yet.  At first glance don't see how it could happen."}}
{"actor":{"display_login":"hexfet"}}