{"action":"created","issue":{"url":"https://api.github.com/repos/nifty-gui/nifty-gui/issues/396","labels_url":"https://api.github.com/repos/nifty-gui/nifty-gui/issues/396/labels{/name}","comments_url":"https://api.github.com/repos/nifty-gui/nifty-gui/issues/396/comments","events_url":"https://api.github.com/repos/nifty-gui/nifty-gui/issues/396/events","html_url":"https://github.com/nifty-gui/nifty-gui/pull/396","id":126240590,"number":396,"title":"fix: Sampler state ","user":{"login":"dustContributor","id":8086687,"avatar_url":"https://avatars.githubusercontent.com/u/8086687?v=3","gravatar_id":"","url":"https://api.github.com/users/dustContributor","html_url":"https://github.com/dustContributor","followers_url":"https://api.github.com/users/dustContributor/followers","following_url":"https://api.github.com/users/dustContributor/following{/other_user}","gists_url":"https://api.github.com/users/dustContributor/gists{/gist_id}","starred_url":"https://api.github.com/users/dustContributor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustContributor/subscriptions","organizations_url":"https://api.github.com/users/dustContributor/orgs","repos_url":"https://api.github.com/users/dustContributor/repos","events_url":"https://api.github.com/users/dustContributor/events{/privacy}","received_events_url":"https://api.github.com/users/dustContributor/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2016-01-12T18:16:12Z","updated_at":"2016-01-13T20:36:23Z","closed_at":"2016-01-12T19:49:28Z","pull_request":{"url":"https://api.github.com/repos/nifty-gui/nifty-gui/pulls/396","html_url":"https://github.com/nifty-gui/nifty-gui/pull/396","diff_url":"https://github.com/nifty-gui/nifty-gui/pull/396.diff","patch_url":"https://github.com/nifty-gui/nifty-gui/pull/396.patch"},"body":"Sampler state gets stored, then sampler gets unbound so it doesn't overrides per-texture filtering, then it gets restored."},"comment":{"url":"https://api.github.com/repos/nifty-gui/nifty-gui/issues/comments/171424960","html_url":"https://github.com/nifty-gui/nifty-gui/pull/396#issuecomment-171424960","issue_url":"https://api.github.com/repos/nifty-gui/nifty-gui/issues/396","id":171424960,"user":{"login":"void256","id":1095704,"avatar_url":"https://avatars.githubusercontent.com/u/1095704?v=3","gravatar_id":"","url":"https://api.github.com/users/void256","html_url":"https://github.com/void256","followers_url":"https://api.github.com/users/void256/followers","following_url":"https://api.github.com/users/void256/following{/other_user}","gists_url":"https://api.github.com/users/void256/gists{/gist_id}","starred_url":"https://api.github.com/users/void256/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/void256/subscriptions","organizations_url":"https://api.github.com/users/void256/orgs","repos_url":"https://api.github.com/users/void256/repos","events_url":"https://api.github.com/users/void256/events{/privacy}","received_events_url":"https://api.github.com/users/void256/received_events","type":"User","site_admin":false},"created_at":"2016-01-13T20:36:23Z","updated_at":"2016-01-13T20:36:23Z","body":"I agree with @dustContributor especially after what he explained in the original issue (stalling the pipeline with all of our glGet*) as well - btw thanks for the explanation @dustContributor \r\n\r\nMaybe we should make the CoreProfileSaveGLState class available as a somekind of utility class that the user can call when he wants to or sees the need and otherwise require the user to set GL state correctly for Nifty rendering.\r\n\r\nThinking of that it would be possible to make another class available to setup GL state for Nifty rendering as well which can act as documentation as well :smile:\r\n\r\nWe're going to definetely consider this for 2.0 as well!"}}