{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1811","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1811/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1811/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1811/events","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1811","id":184782700,"number":1811,"title":"[WIP] EZP-23281: Add max archive versions limit & enforce on publish","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-10-24T08:50:37Z","updated_at":"2016-11-28T16:32:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/1811","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1811","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1811.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1811.patch"},"body":"> Issue: https://jira.ez.no/browse/EZP-23281\r\n\r\nApproach: Limit archived versions, for now as a flat _default_ setting _(can be per siteaccess/group)_, but could be moved to contentType in the future so it can 1. natuaraly be per content type 2. becomes editorial/changeable via api, hence why there is no per content type setting here.\r\n\r\nTodo:\r\n- [x] Discuss approach _(cc @pspanja @alongosz @bdunogier)_\r\n- [ ] Inject setting from somewhere _(@bdunogier where would you prefer this?)_\r\n- [x] Tests\r\n\r\nFor later:\r\n- ~~Script to enforce version limits of archives on config changes(?), and cronjob for evicting dead drafts, both will have to take into account if Content Item has a published item version as well _(if max limit of archives is 0, and no published exists since it's been unpublished, then one item should be kept. Alternative we document minimum archive limit is 1 and avoid the issue)_~~\r\n"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/263319617","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/1811#issuecomment-263319617","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/1811","id":263319617,"user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T16:32:07Z","updated_at":"2016-11-28T16:32:07Z","body":"> From the outside, it really sounds like a storage option.\r\n\r\nbut if it is storage, that would imply it is the storage engine handling it and not repository right? or am I focusing to much on internals and externals view consistency now? :)\r\n\r\n> This could be a hint that an lightweight version is better, for the user, than a late great version. Implementing this with settings would be pretty straightforward, and we can easily deprecate the settings. It of course depends on how important the option is.\r\n\r\nwhat is the lightweight version? \r\n"}}
{"actor":{"display_login":"andrerom"}}