{"action":"created","issue":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/740","repository_url":"https://api.github.com/repos/OpenCPN/OpenCPN","labels_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/740/comments","events_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/740/events","html_url":"https://github.com/OpenCPN/OpenCPN/pull/740","id":197391800,"number":740,"title":"Disambiguate version.h for plugins.","user":{"login":"SamsonovAnton","id":12662527,"avatar_url":"https://avatars.githubusercontent.com/u/12662527?v=3","gravatar_id":"","url":"https://api.github.com/users/SamsonovAnton","html_url":"https://github.com/SamsonovAnton","followers_url":"https://api.github.com/users/SamsonovAnton/followers","following_url":"https://api.github.com/users/SamsonovAnton/following{/other_user}","gists_url":"https://api.github.com/users/SamsonovAnton/gists{/gist_id}","starred_url":"https://api.github.com/users/SamsonovAnton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamsonovAnton/subscriptions","organizations_url":"https://api.github.com/users/SamsonovAnton/orgs","repos_url":"https://api.github.com/users/SamsonovAnton/repos","events_url":"https://api.github.com/users/SamsonovAnton/events{/privacy}","received_events_url":"https://api.github.com/users/SamsonovAnton/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-23T16:00:12Z","updated_at":"2016-12-29T10:03:38Z","closed_at":"2016-12-29T10:03:38Z","pull_request":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/pulls/740","html_url":"https://github.com/OpenCPN/OpenCPN/pull/740","diff_url":"https://github.com/OpenCPN/OpenCPN/pull/740.diff","patch_url":"https://github.com/OpenCPN/OpenCPN/pull/740.patch"},"body":"Starting from commit 7fb6da5f24984666704aa03d650071a4c23b72b2, ChartLoader and WMM plugins had their *version.h* headers automatically configured in build directory which was additionally inserted into inclusion list. However, because there also was a static *include/version.h* in the root source tree which was naturally at the top of inclusion list, the latter got picked up instead of those the plugins expected, causing `PLUGIN_VERSION_MAJOR` etc. to stay undefined and resulting in compilation failure.\r\n\r\nThis patch attempts to fix that by renaming ambiguous *version.h* into something unique to each plugin."},"comment":{"url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/comments/269607613","html_url":"https://github.com/OpenCPN/OpenCPN/pull/740#issuecomment-269607613","issue_url":"https://api.github.com/repos/OpenCPN/OpenCPN/issues/740","id":269607613,"user":{"login":"SamsonovAnton","id":12662527,"avatar_url":"https://avatars.githubusercontent.com/u/12662527?v=3","gravatar_id":"","url":"https://api.github.com/users/SamsonovAnton","html_url":"https://github.com/SamsonovAnton","followers_url":"https://api.github.com/users/SamsonovAnton/followers","following_url":"https://api.github.com/users/SamsonovAnton/following{/other_user}","gists_url":"https://api.github.com/users/SamsonovAnton/gists{/gist_id}","starred_url":"https://api.github.com/users/SamsonovAnton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamsonovAnton/subscriptions","organizations_url":"https://api.github.com/users/SamsonovAnton/orgs","repos_url":"https://api.github.com/users/SamsonovAnton/repos","events_url":"https://api.github.com/users/SamsonovAnton/events{/privacy}","received_events_url":"https://api.github.com/users/SamsonovAnton/received_events","type":"User","site_admin":false},"created_at":"2016-12-29T10:03:38Z","updated_at":"2016-12-29T10:03:38Z","body":"Looks like the issue I was trying to fix was in fact caused by another issue. Therefore this patch is superseded by PR #742."}}
{"actor":{"display_login":"SamsonovAnton"}}