{"action":"closed","number":291,"pull_request":{"url":"https://api.github.com/repos/fscheck/FsCheck/pulls/291","id":77746036,"html_url":"https://github.com/fscheck/FsCheck/pull/291","diff_url":"https://github.com/fscheck/FsCheck/pull/291.diff","patch_url":"https://github.com/fscheck/FsCheck/pull/291.patch","issue_url":"https://api.github.com/repos/fscheck/FsCheck/issues/291","number":291,"state":"closed","locked":false,"title":"Optimizations for array generation and shrinking","user":{"login":"jack-pappas","id":477287,"avatar_url":"https://avatars.githubusercontent.com/u/477287?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-pappas","html_url":"https://github.com/jack-pappas","followers_url":"https://api.github.com/users/jack-pappas/followers","following_url":"https://api.github.com/users/jack-pappas/following{/other_user}","gists_url":"https://api.github.com/users/jack-pappas/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-pappas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-pappas/subscriptions","organizations_url":"https://api.github.com/users/jack-pappas/orgs","repos_url":"https://api.github.com/users/jack-pappas/repos","events_url":"https://api.github.com/users/jack-pappas/events{/privacy}","received_events_url":"https://api.github.com/users/jack-pappas/received_events","type":"User","site_admin":false},"body":"Modified Gen functions for generating arbitrary array instances to avoid intermediate conversions to F# lists (and resulting allocations).\r\nModified shrinker for 1D arrays to avoid intermediate list allocations.\r\nModified shrinker for strings to use the array shrinker, and subsequently avoid allocating intermediate char lists.\r\n\r\nI noticed these allocations when profiling a slow-running FsCheck test I wrote at one point (for a data type which used both arrays and strings). Running ``build.cmd`` before and after this change seems to show the tests running slightly faster, although I haven't repeated it enough times for statistical significance. In any case, tests which heavily use arrays and strings should notice a performance improvement due to eliminating the conversions to/from F# lists (and also due to spending less time in GCs related to those list allocations).\r\n","created_at":"2016-07-17T21:03:30Z","updated_at":"2016-07-21T12:45:12Z","closed_at":"2016-07-21T12:45:12Z","merged_at":"2016-07-21T12:45:12Z","merge_commit_sha":"30e9050ad3dbc7a10e7ea48cb50e2be945aed693","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/291/commits","review_comments_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/291/comments","review_comment_url":"https://api.github.com/repos/fscheck/FsCheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fscheck/FsCheck/issues/291/comments","statuses_url":"https://api.github.com/repos/fscheck/FsCheck/statuses/b45dacd9a7fe304036761574f87c35eb862b8240","head":{"label":"jack-pappas:array-genshrink-opt","ref":"array-genshrink-opt","sha":"b45dacd9a7fe304036761574f87c35eb862b8240","user":{"login":"jack-pappas","id":477287,"avatar_url":"https://avatars.githubusercontent.com/u/477287?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-pappas","html_url":"https://github.com/jack-pappas","followers_url":"https://api.github.com/users/jack-pappas/followers","following_url":"https://api.github.com/users/jack-pappas/following{/other_user}","gists_url":"https://api.github.com/users/jack-pappas/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-pappas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-pappas/subscriptions","organizations_url":"https://api.github.com/users/jack-pappas/orgs","repos_url":"https://api.github.com/users/jack-pappas/repos","events_url":"https://api.github.com/users/jack-pappas/events{/privacy}","received_events_url":"https://api.github.com/users/jack-pappas/received_events","type":"User","site_admin":false},"repo":{"id":60226004,"name":"FsCheck","full_name":"jack-pappas/FsCheck","owner":{"login":"jack-pappas","id":477287,"avatar_url":"https://avatars.githubusercontent.com/u/477287?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-pappas","html_url":"https://github.com/jack-pappas","followers_url":"https://api.github.com/users/jack-pappas/followers","following_url":"https://api.github.com/users/jack-pappas/following{/other_user}","gists_url":"https://api.github.com/users/jack-pappas/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-pappas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-pappas/subscriptions","organizations_url":"https://api.github.com/users/jack-pappas/orgs","repos_url":"https://api.github.com/users/jack-pappas/repos","events_url":"https://api.github.com/users/jack-pappas/events{/privacy}","received_events_url":"https://api.github.com/users/jack-pappas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jack-pappas/FsCheck","description":"Random Testing for .NET","fork":true,"url":"https://api.github.com/repos/jack-pappas/FsCheck","forks_url":"https://api.github.com/repos/jack-pappas/FsCheck/forks","keys_url":"https://api.github.com/repos/jack-pappas/FsCheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jack-pappas/FsCheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jack-pappas/FsCheck/teams","hooks_url":"https://api.github.com/repos/jack-pappas/FsCheck/hooks","issue_events_url":"https://api.github.com/repos/jack-pappas/FsCheck/issues/events{/number}","events_url":"https://api.github.com/repos/jack-pappas/FsCheck/events","assignees_url":"https://api.github.com/repos/jack-pappas/FsCheck/assignees{/user}","branches_url":"https://api.github.com/repos/jack-pappas/FsCheck/branches{/branch}","tags_url":"https://api.github.com/repos/jack-pappas/FsCheck/tags","blobs_url":"https://api.github.com/repos/jack-pappas/FsCheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jack-pappas/FsCheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jack-pappas/FsCheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/jack-pappas/FsCheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jack-pappas/FsCheck/statuses/{sha}","languages_url":"https://api.github.com/repos/jack-pappas/FsCheck/languages","stargazers_url":"https://api.github.com/repos/jack-pappas/FsCheck/stargazers","contributors_url":"https://api.github.com/repos/jack-pappas/FsCheck/contributors","subscribers_url":"https://api.github.com/repos/jack-pappas/FsCheck/subscribers","subscription_url":"https://api.github.com/repos/jack-pappas/FsCheck/subscription","commits_url":"https://api.github.com/repos/jack-pappas/FsCheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/jack-pappas/FsCheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/jack-pappas/FsCheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/jack-pappas/FsCheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/jack-pappas/FsCheck/contents/{+path}","compare_url":"https://api.github.com/repos/jack-pappas/FsCheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jack-pappas/FsCheck/merges","archive_url":"https://api.github.com/repos/jack-pappas/FsCheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jack-pappas/FsCheck/downloads","issues_url":"https://api.github.com/repos/jack-pappas/FsCheck/issues{/number}","pulls_url":"https://api.github.com/repos/jack-pappas/FsCheck/pulls{/number}","milestones_url":"https://api.github.com/repos/jack-pappas/FsCheck/milestones{/number}","notifications_url":"https://api.github.com/repos/jack-pappas/FsCheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jack-pappas/FsCheck/labels{/name}","releases_url":"https://api.github.com/repos/jack-pappas/FsCheck/releases{/id}","deployments_url":"https://api.github.com/repos/jack-pappas/FsCheck/deployments","created_at":"2016-06-02T02:27:07Z","updated_at":"2016-06-02T02:27:08Z","pushed_at":"2016-07-21T11:04:15Z","git_url":"git://github.com/jack-pappas/FsCheck.git","ssh_url":"git@github.com:jack-pappas/FsCheck.git","clone_url":"https://github.com/jack-pappas/FsCheck.git","svn_url":"https://github.com/jack-pappas/FsCheck","homepage":"https://fscheck.github.io/FsCheck/","size":13877,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fscheck:master","ref":"master","sha":"2fd909be25c69fe297b1228bb7335a1d2d0a56ca","user":{"login":"fscheck","id":12610206,"avatar_url":"https://avatars.githubusercontent.com/u/12610206?v=3","gravatar_id":"","url":"https://api.github.com/users/fscheck","html_url":"https://github.com/fscheck","followers_url":"https://api.github.com/users/fscheck/followers","following_url":"https://api.github.com/users/fscheck/following{/other_user}","gists_url":"https://api.github.com/users/fscheck/gists{/gist_id}","starred_url":"https://api.github.com/users/fscheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscheck/subscriptions","organizations_url":"https://api.github.com/users/fscheck/orgs","repos_url":"https://api.github.com/users/fscheck/repos","events_url":"https://api.github.com/users/fscheck/events{/privacy}","received_events_url":"https://api.github.com/users/fscheck/received_events","type":"Organization","site_admin":false},"repo":{"id":10790442,"name":"FsCheck","full_name":"fscheck/FsCheck","owner":{"login":"fscheck","id":12610206,"avatar_url":"https://avatars.githubusercontent.com/u/12610206?v=3","gravatar_id":"","url":"https://api.github.com/users/fscheck","html_url":"https://github.com/fscheck","followers_url":"https://api.github.com/users/fscheck/followers","following_url":"https://api.github.com/users/fscheck/following{/other_user}","gists_url":"https://api.github.com/users/fscheck/gists{/gist_id}","starred_url":"https://api.github.com/users/fscheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fscheck/subscriptions","organizations_url":"https://api.github.com/users/fscheck/orgs","repos_url":"https://api.github.com/users/fscheck/repos","events_url":"https://api.github.com/users/fscheck/events{/privacy}","received_events_url":"https://api.github.com/users/fscheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fscheck/FsCheck","description":"Random Testing for .NET","fork":false,"url":"https://api.github.com/repos/fscheck/FsCheck","forks_url":"https://api.github.com/repos/fscheck/FsCheck/forks","keys_url":"https://api.github.com/repos/fscheck/FsCheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fscheck/FsCheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fscheck/FsCheck/teams","hooks_url":"https://api.github.com/repos/fscheck/FsCheck/hooks","issue_events_url":"https://api.github.com/repos/fscheck/FsCheck/issues/events{/number}","events_url":"https://api.github.com/repos/fscheck/FsCheck/events","assignees_url":"https://api.github.com/repos/fscheck/FsCheck/assignees{/user}","branches_url":"https://api.github.com/repos/fscheck/FsCheck/branches{/branch}","tags_url":"https://api.github.com/repos/fscheck/FsCheck/tags","blobs_url":"https://api.github.com/repos/fscheck/FsCheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fscheck/FsCheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fscheck/FsCheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/fscheck/FsCheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fscheck/FsCheck/statuses/{sha}","languages_url":"https://api.github.com/repos/fscheck/FsCheck/languages","stargazers_url":"https://api.github.com/repos/fscheck/FsCheck/stargazers","contributors_url":"https://api.github.com/repos/fscheck/FsCheck/contributors","subscribers_url":"https://api.github.com/repos/fscheck/FsCheck/subscribers","subscription_url":"https://api.github.com/repos/fscheck/FsCheck/subscription","commits_url":"https://api.github.com/repos/fscheck/FsCheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/fscheck/FsCheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/fscheck/FsCheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/fscheck/FsCheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/fscheck/FsCheck/contents/{+path}","compare_url":"https://api.github.com/repos/fscheck/FsCheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fscheck/FsCheck/merges","archive_url":"https://api.github.com/repos/fscheck/FsCheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fscheck/FsCheck/downloads","issues_url":"https://api.github.com/repos/fscheck/FsCheck/issues{/number}","pulls_url":"https://api.github.com/repos/fscheck/FsCheck/pulls{/number}","milestones_url":"https://api.github.com/repos/fscheck/FsCheck/milestones{/number}","notifications_url":"https://api.github.com/repos/fscheck/FsCheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fscheck/FsCheck/labels{/name}","releases_url":"https://api.github.com/repos/fscheck/FsCheck/releases{/id}","deployments_url":"https://api.github.com/repos/fscheck/FsCheck/deployments","created_at":"2013-06-19T11:46:46Z","updated_at":"2016-07-13T15:48:33Z","pushed_at":"2016-07-21T12:45:12Z","git_url":"git://github.com/fscheck/FsCheck.git","ssh_url":"git@github.com:fscheck/FsCheck.git","clone_url":"https://github.com/fscheck/FsCheck.git","svn_url":"https://github.com/fscheck/FsCheck","homepage":"https://fscheck.github.io/FsCheck/","size":15772,"stargazers_count":303,"watchers_count":303,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":29,"forks":70,"open_issues":29,"watchers":303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/291"},"html":{"href":"https://github.com/fscheck/FsCheck/pull/291"},"issue":{"href":"https://api.github.com/repos/fscheck/FsCheck/issues/291"},"comments":{"href":"https://api.github.com/repos/fscheck/FsCheck/issues/291/comments"},"review_comments":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/291/comments"},"review_comment":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fscheck/FsCheck/pulls/291/commits"},"statuses":{"href":"https://api.github.com/repos/fscheck/FsCheck/statuses/b45dacd9a7fe304036761574f87c35eb862b8240"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kurtschelfthout","id":164917,"avatar_url":"https://avatars.githubusercontent.com/u/164917?v=3","gravatar_id":"","url":"https://api.github.com/users/kurtschelfthout","html_url":"https://github.com/kurtschelfthout","followers_url":"https://api.github.com/users/kurtschelfthout/followers","following_url":"https://api.github.com/users/kurtschelfthout/following{/other_user}","gists_url":"https://api.github.com/users/kurtschelfthout/gists{/gist_id}","starred_url":"https://api.github.com/users/kurtschelfthout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurtschelfthout/subscriptions","organizations_url":"https://api.github.com/users/kurtschelfthout/orgs","repos_url":"https://api.github.com/users/kurtschelfthout/repos","events_url":"https://api.github.com/users/kurtschelfthout/events{/privacy}","received_events_url":"https://api.github.com/users/kurtschelfthout/received_events","type":"User","site_admin":false},"comments":2,"review_comments":6,"commits":1,"additions":99,"deletions":23,"changed_files":2}}
{"actor":{"display_login":"kurtschelfthout"}}