{"action":"created","comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/52085895","id":52085895,"diff_hunk":"@@ -67,18 +67,17 @@\n \t\tvar/turf/T = get_step(src, direction)\r\n \t\tif(!istype(T))\r\n \t\t\tcontinue\r\n-\t\tvar/counterdir = get_dir(T, src)\r\n \t\tif(CanAtmosPass(T))\r\n \t\t\tatmos_adjacent_turfs_amount += 1\r\n-\t\t\tatmos_adjacent_turfs |= direction\r\n-\t\t\tif(!(T.atmos_adjacent_turfs & counterdir))\r\n+\t\t\tatmos_adjacent_turfs |= T\r\n+\t\t\tif(!(src in T.atmos_adjacent_turfs))\r","path":"code/modules/atmospherics/environmental/LINDA_system.dm","position":10,"original_position":10,"commit_id":"0d1f2d94456101ee87495b46bc59f37265c7a2e7","original_commit_id":"0d1f2d94456101ee87495b46bc59f37265c7a2e7","user":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"body":"This proc is rarely called in atmos, only when something changes air-tightness, so i'm not gonna spend time trying to profile different ways to do the same thing to optimize it.","created_at":"2016-02-05T23:15:39Z","updated_at":"2016-02-05T23:15:39Z","html_url":"https://github.com/tgstation/-tg-station/pull/15218#discussion_r52085895","pull_request_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218","_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/52085895"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/15218#discussion_r52085895"},"pull_request":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218"}}},"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218","id":58466768,"html_url":"https://github.com/tgstation/-tg-station/pull/15218","diff_url":"https://github.com/tgstation/-tg-station/pull/15218.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/15218.patch","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/15218","number":15218,"state":"open","locked":false,"title":"[wip]Speed up process_cell() by caching atmos_adjacent_turfs as a list of nearby turfs and not a bitflag so we can avoid doing a bunch of turf lookups 4 times for each turf in atmos","user":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"body":"todo: \r\n- [ ] Find anything else that treats atmos_adjacent_turfs as a bitflag and switch it over to treating it as a list\r\n- [ ] Test\r\n\r\n","created_at":"2016-02-05T18:35:13Z","updated_at":"2016-02-05T23:15:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da200314f4a66ca504513e21bad3ad477748b92c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218/commits","review_comments_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218/comments","review_comment_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/15218/comments","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/0d1f2d94456101ee87495b46bc59f37265c7a2e7","head":{"label":"MrStonedOne:patch-144","ref":"patch-144","sha":"0d1f2d94456101ee87495b46bc59f37265c7a2e7","user":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"repo":{"id":18158463,"name":"-tg-station","full_name":"MrStonedOne/-tg-station","owner":{"login":"MrStonedOne","id":7069733,"avatar_url":"https://avatars.githubusercontent.com/u/7069733?v=3","gravatar_id":"","url":"https://api.github.com/users/MrStonedOne","html_url":"https://github.com/MrStonedOne","followers_url":"https://api.github.com/users/MrStonedOne/followers","following_url":"https://api.github.com/users/MrStonedOne/following{/other_user}","gists_url":"https://api.github.com/users/MrStonedOne/gists{/gist_id}","starred_url":"https://api.github.com/users/MrStonedOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrStonedOne/subscriptions","organizations_url":"https://api.github.com/users/MrStonedOne/orgs","repos_url":"https://api.github.com/users/MrStonedOne/repos","events_url":"https://api.github.com/users/MrStonedOne/events{/privacy}","received_events_url":"https://api.github.com/users/MrStonedOne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrStonedOne/-tg-station","description":"/tg/'s SS13 branch","fork":true,"url":"https://api.github.com/repos/MrStonedOne/-tg-station","forks_url":"https://api.github.com/repos/MrStonedOne/-tg-station/forks","keys_url":"https://api.github.com/repos/MrStonedOne/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrStonedOne/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrStonedOne/-tg-station/teams","hooks_url":"https://api.github.com/repos/MrStonedOne/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/MrStonedOne/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/MrStonedOne/-tg-station/events","assignees_url":"https://api.github.com/repos/MrStonedOne/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/MrStonedOne/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/MrStonedOne/-tg-station/tags","blobs_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrStonedOne/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/MrStonedOne/-tg-station/languages","stargazers_url":"https://api.github.com/repos/MrStonedOne/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/MrStonedOne/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/MrStonedOne/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/MrStonedOne/-tg-station/subscription","commits_url":"https://api.github.com/repos/MrStonedOne/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrStonedOne/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrStonedOne/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrStonedOne/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrStonedOne/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/MrStonedOne/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrStonedOne/-tg-station/merges","archive_url":"https://api.github.com/repos/MrStonedOne/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrStonedOne/-tg-station/downloads","issues_url":"https://api.github.com/repos/MrStonedOne/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/MrStonedOne/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/MrStonedOne/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/MrStonedOne/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrStonedOne/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/MrStonedOne/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/MrStonedOne/-tg-station/deployments","created_at":"2014-03-26T23:58:37Z","updated_at":"2016-01-22T07:51:41Z","pushed_at":"2016-02-05T18:38:10Z","git_url":"git://github.com/MrStonedOne/-tg-station.git","ssh_url":"git@github.com:MrStonedOne/-tg-station.git","clone_url":"https://github.com/MrStonedOne/-tg-station.git","svn_url":"https://github.com/MrStonedOne/-tg-station","homepage":"","size":618185,"stargazers_count":1,"watchers_count":1,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tgstation:master","ref":"master","sha":"6154334fbc6ecc50b8a63f29ba9b195522ab78b1","user":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"repo":{"id":3234987,"name":"-tg-station","full_name":"tgstation/-tg-station","owner":{"login":"tgstation","id":1363778,"avatar_url":"https://avatars.githubusercontent.com/u/1363778?v=3","gravatar_id":"","url":"https://api.github.com/users/tgstation","html_url":"https://github.com/tgstation","followers_url":"https://api.github.com/users/tgstation/followers","following_url":"https://api.github.com/users/tgstation/following{/other_user}","gists_url":"https://api.github.com/users/tgstation/gists{/gist_id}","starred_url":"https://api.github.com/users/tgstation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgstation/subscriptions","organizations_url":"https://api.github.com/users/tgstation/orgs","repos_url":"https://api.github.com/users/tgstation/repos","events_url":"https://api.github.com/users/tgstation/events{/privacy}","received_events_url":"https://api.github.com/users/tgstation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tgstation/-tg-station","description":"the /tg/station branch of SS13","fork":false,"url":"https://api.github.com/repos/tgstation/-tg-station","forks_url":"https://api.github.com/repos/tgstation/-tg-station/forks","keys_url":"https://api.github.com/repos/tgstation/-tg-station/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgstation/-tg-station/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgstation/-tg-station/teams","hooks_url":"https://api.github.com/repos/tgstation/-tg-station/hooks","issue_events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/events{/number}","events_url":"https://api.github.com/repos/tgstation/-tg-station/events","assignees_url":"https://api.github.com/repos/tgstation/-tg-station/assignees{/user}","branches_url":"https://api.github.com/repos/tgstation/-tg-station/branches{/branch}","tags_url":"https://api.github.com/repos/tgstation/-tg-station/tags","blobs_url":"https://api.github.com/repos/tgstation/-tg-station/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgstation/-tg-station/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgstation/-tg-station/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgstation/-tg-station/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgstation/-tg-station/statuses/{sha}","languages_url":"https://api.github.com/repos/tgstation/-tg-station/languages","stargazers_url":"https://api.github.com/repos/tgstation/-tg-station/stargazers","contributors_url":"https://api.github.com/repos/tgstation/-tg-station/contributors","subscribers_url":"https://api.github.com/repos/tgstation/-tg-station/subscribers","subscription_url":"https://api.github.com/repos/tgstation/-tg-station/subscription","commits_url":"https://api.github.com/repos/tgstation/-tg-station/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgstation/-tg-station/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgstation/-tg-station/contents/{+path}","compare_url":"https://api.github.com/repos/tgstation/-tg-station/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgstation/-tg-station/merges","archive_url":"https://api.github.com/repos/tgstation/-tg-station/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgstation/-tg-station/downloads","issues_url":"https://api.github.com/repos/tgstation/-tg-station/issues{/number}","pulls_url":"https://api.github.com/repos/tgstation/-tg-station/pulls{/number}","milestones_url":"https://api.github.com/repos/tgstation/-tg-station/milestones{/number}","notifications_url":"https://api.github.com/repos/tgstation/-tg-station/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgstation/-tg-station/labels{/name}","releases_url":"https://api.github.com/repos/tgstation/-tg-station/releases{/id}","deployments_url":"https://api.github.com/repos/tgstation/-tg-station/deployments","created_at":"2012-01-21T17:32:47Z","updated_at":"2016-02-05T16:29:28Z","pushed_at":"2016-02-05T23:10:09Z","git_url":"git://github.com/tgstation/-tg-station.git","ssh_url":"git@github.com:tgstation/-tg-station.git","clone_url":"https://github.com/tgstation/-tg-station.git","svn_url":"https://github.com/tgstation/-tg-station","homepage":"http://www.tgstation13.org/","size":762334,"stargazers_count":270,"watchers_count":270,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":946,"mirror_url":null,"open_issues_count":738,"forks":946,"open_issues":738,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/15218"},"issue":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/15218"},"comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/issues/15218/comments"},"review_comments":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218/comments"},"review_comment":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/15218/commits"},"statuses":{"href":"https://api.github.com/repos/tgstation/-tg-station/statuses/0d1f2d94456101ee87495b46bc59f37265c7a2e7"}}}}