{"action":"created","comment":{"url":"https://api.github.com/repos/threatgrid/ctia/pulls/comments/59075046","id":59075046,"diff_hunk":"@@ -101,7 +92,7 @@\n \n (defn url\n   ([path]\n-   (url path http-port))\n+   (url path (get-in @props/properties [:ctia :http :port])))","path":"test/ctia/test_helpers/core.clj","position":45,"original_position":45,"commit_id":"df8ad3897f2916e89b3af1e383e133189851c106","original_commit_id":"df8ad3897f2916e89b3af1e383e133189851c106","user":{"login":"saintx","id":711320,"avatar_url":"https://avatars.githubusercontent.com/u/711320?v=3","gravatar_id":"","url":"https://api.github.com/users/saintx","html_url":"https://github.com/saintx","followers_url":"https://api.github.com/users/saintx/followers","following_url":"https://api.github.com/users/saintx/following{/other_user}","gists_url":"https://api.github.com/users/saintx/gists{/gist_id}","starred_url":"https://api.github.com/users/saintx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saintx/subscriptions","organizations_url":"https://api.github.com/users/saintx/orgs","repos_url":"https://api.github.com/users/saintx/repos","events_url":"https://api.github.com/users/saintx/events{/privacy}","received_events_url":"https://api.github.com/users/saintx/received_events","type":"User","site_admin":false},"body":"...and I'd switch this to ```(url path (get-in @properties [:ctia :http :port])))```","created_at":"2016-04-08T19:10:18Z","updated_at":"2016-04-08T19:10:18Z","html_url":"https://github.com/threatgrid/ctia/pull/187#discussion_r59075046","pull_request_url":"https://api.github.com/repos/threatgrid/ctia/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/threatgrid/ctia/pulls/comments/59075046"},"html":{"href":"https://github.com/threatgrid/ctia/pull/187#discussion_r59075046"},"pull_request":{"href":"https://api.github.com/repos/threatgrid/ctia/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/threatgrid/ctia/pulls/187","id":65721932,"html_url":"https://github.com/threatgrid/ctia/pull/187","diff_url":"https://github.com/threatgrid/ctia/pull/187.diff","patch_url":"https://github.com/threatgrid/ctia/pull/187.patch","issue_url":"https://api.github.com/repos/threatgrid/ctia/issues/187","number":187,"state":"open","locked":false,"title":"Configure HTTP & nREPL servers via properties","user":{"login":"polygloton","id":368005,"avatar_url":"https://avatars.githubusercontent.com/u/368005?v=3","gravatar_id":"","url":"https://api.github.com/users/polygloton","html_url":"https://github.com/polygloton","followers_url":"https://api.github.com/users/polygloton/followers","following_url":"https://api.github.com/users/polygloton/following{/other_user}","gists_url":"https://api.github.com/users/polygloton/gists{/gist_id}","starred_url":"https://api.github.com/users/polygloton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polygloton/subscriptions","organizations_url":"https://api.github.com/users/polygloton/orgs","repos_url":"https://api.github.com/users/polygloton/repos","events_url":"https://api.github.com/users/polygloton/events{/privacy}","received_events_url":"https://api.github.com/users/polygloton/received_events","type":"User","site_admin":false},"body":"Removes the lein-ring plugin and explicitly starts the jetty server.  We lose some automatic features, but gain control.  (Please let me know if you are missing a feature from lein-ring and I can add it).\r\n\r\nServer is started with \"lein run\".\r\n\r\nCloses #186 \r\n\r\nI'm adding this so that we can use the configured port in URL IDs.","created_at":"2016-04-08T00:40:45Z","updated_at":"2016-04-08T19:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1d4009e5ce80396e5f09351587351437539518a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/threatgrid/ctia/pulls/187/commits","review_comments_url":"https://api.github.com/repos/threatgrid/ctia/pulls/187/comments","review_comment_url":"https://api.github.com/repos/threatgrid/ctia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/threatgrid/ctia/issues/187/comments","statuses_url":"https://api.github.com/repos/threatgrid/ctia/statuses/df8ad3897f2916e89b3af1e383e133189851c106","head":{"label":"polygloton:issue-#186","ref":"issue-#186","sha":"df8ad3897f2916e89b3af1e383e133189851c106","user":{"login":"polygloton","id":368005,"avatar_url":"https://avatars.githubusercontent.com/u/368005?v=3","gravatar_id":"","url":"https://api.github.com/users/polygloton","html_url":"https://github.com/polygloton","followers_url":"https://api.github.com/users/polygloton/followers","following_url":"https://api.github.com/users/polygloton/following{/other_user}","gists_url":"https://api.github.com/users/polygloton/gists{/gist_id}","starred_url":"https://api.github.com/users/polygloton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polygloton/subscriptions","organizations_url":"https://api.github.com/users/polygloton/orgs","repos_url":"https://api.github.com/users/polygloton/repos","events_url":"https://api.github.com/users/polygloton/events{/privacy}","received_events_url":"https://api.github.com/users/polygloton/received_events","type":"User","site_admin":false},"repo":{"id":55179930,"name":"ctia","full_name":"polygloton/ctia","owner":{"login":"polygloton","id":368005,"avatar_url":"https://avatars.githubusercontent.com/u/368005?v=3","gravatar_id":"","url":"https://api.github.com/users/polygloton","html_url":"https://github.com/polygloton","followers_url":"https://api.github.com/users/polygloton/followers","following_url":"https://api.github.com/users/polygloton/following{/other_user}","gists_url":"https://api.github.com/users/polygloton/gists{/gist_id}","starred_url":"https://api.github.com/users/polygloton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polygloton/subscriptions","organizations_url":"https://api.github.com/users/polygloton/orgs","repos_url":"https://api.github.com/users/polygloton/repos","events_url":"https://api.github.com/users/polygloton/events{/privacy}","received_events_url":"https://api.github.com/users/polygloton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/polygloton/ctia","description":"Cisco Intel API","fork":true,"url":"https://api.github.com/repos/polygloton/ctia","forks_url":"https://api.github.com/repos/polygloton/ctia/forks","keys_url":"https://api.github.com/repos/polygloton/ctia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polygloton/ctia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polygloton/ctia/teams","hooks_url":"https://api.github.com/repos/polygloton/ctia/hooks","issue_events_url":"https://api.github.com/repos/polygloton/ctia/issues/events{/number}","events_url":"https://api.github.com/repos/polygloton/ctia/events","assignees_url":"https://api.github.com/repos/polygloton/ctia/assignees{/user}","branches_url":"https://api.github.com/repos/polygloton/ctia/branches{/branch}","tags_url":"https://api.github.com/repos/polygloton/ctia/tags","blobs_url":"https://api.github.com/repos/polygloton/ctia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polygloton/ctia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polygloton/ctia/git/refs{/sha}","trees_url":"https://api.github.com/repos/polygloton/ctia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polygloton/ctia/statuses/{sha}","languages_url":"https://api.github.com/repos/polygloton/ctia/languages","stargazers_url":"https://api.github.com/repos/polygloton/ctia/stargazers","contributors_url":"https://api.github.com/repos/polygloton/ctia/contributors","subscribers_url":"https://api.github.com/repos/polygloton/ctia/subscribers","subscription_url":"https://api.github.com/repos/polygloton/ctia/subscription","commits_url":"https://api.github.com/repos/polygloton/ctia/commits{/sha}","git_commits_url":"https://api.github.com/repos/polygloton/ctia/git/commits{/sha}","comments_url":"https://api.github.com/repos/polygloton/ctia/comments{/number}","issue_comment_url":"https://api.github.com/repos/polygloton/ctia/issues/comments{/number}","contents_url":"https://api.github.com/repos/polygloton/ctia/contents/{+path}","compare_url":"https://api.github.com/repos/polygloton/ctia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polygloton/ctia/merges","archive_url":"https://api.github.com/repos/polygloton/ctia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polygloton/ctia/downloads","issues_url":"https://api.github.com/repos/polygloton/ctia/issues{/number}","pulls_url":"https://api.github.com/repos/polygloton/ctia/pulls{/number}","milestones_url":"https://api.github.com/repos/polygloton/ctia/milestones{/number}","notifications_url":"https://api.github.com/repos/polygloton/ctia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polygloton/ctia/labels{/name}","releases_url":"https://api.github.com/repos/polygloton/ctia/releases{/id}","deployments_url":"https://api.github.com/repos/polygloton/ctia/deployments","created_at":"2016-03-31T20:13:27Z","updated_at":"2016-03-31T20:13:28Z","pushed_at":"2016-04-08T18:42:32Z","git_url":"git://github.com/polygloton/ctia.git","ssh_url":"git@github.com:polygloton/ctia.git","clone_url":"https://github.com/polygloton/ctia.git","svn_url":"https://github.com/polygloton/ctia","homepage":"","size":833,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"threatgrid:master","ref":"master","sha":"016a80fda97dbcef0ebf563b6fb0705e854d72c9","user":{"login":"threatgrid","id":337733,"avatar_url":"https://avatars.githubusercontent.com/u/337733?v=3","gravatar_id":"","url":"https://api.github.com/users/threatgrid","html_url":"https://github.com/threatgrid","followers_url":"https://api.github.com/users/threatgrid/followers","following_url":"https://api.github.com/users/threatgrid/following{/other_user}","gists_url":"https://api.github.com/users/threatgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/threatgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threatgrid/subscriptions","organizations_url":"https://api.github.com/users/threatgrid/orgs","repos_url":"https://api.github.com/users/threatgrid/repos","events_url":"https://api.github.com/users/threatgrid/events{/privacy}","received_events_url":"https://api.github.com/users/threatgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":47668849,"name":"ctia","full_name":"threatgrid/ctia","owner":{"login":"threatgrid","id":337733,"avatar_url":"https://avatars.githubusercontent.com/u/337733?v=3","gravatar_id":"","url":"https://api.github.com/users/threatgrid","html_url":"https://github.com/threatgrid","followers_url":"https://api.github.com/users/threatgrid/followers","following_url":"https://api.github.com/users/threatgrid/following{/other_user}","gists_url":"https://api.github.com/users/threatgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/threatgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threatgrid/subscriptions","organizations_url":"https://api.github.com/users/threatgrid/orgs","repos_url":"https://api.github.com/users/threatgrid/repos","events_url":"https://api.github.com/users/threatgrid/events{/privacy}","received_events_url":"https://api.github.com/users/threatgrid/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/threatgrid/ctia","description":"Cisco Threat Intelligence API","fork":false,"url":"https://api.github.com/repos/threatgrid/ctia","forks_url":"https://api.github.com/repos/threatgrid/ctia/forks","keys_url":"https://api.github.com/repos/threatgrid/ctia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threatgrid/ctia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threatgrid/ctia/teams","hooks_url":"https://api.github.com/repos/threatgrid/ctia/hooks","issue_events_url":"https://api.github.com/repos/threatgrid/ctia/issues/events{/number}","events_url":"https://api.github.com/repos/threatgrid/ctia/events","assignees_url":"https://api.github.com/repos/threatgrid/ctia/assignees{/user}","branches_url":"https://api.github.com/repos/threatgrid/ctia/branches{/branch}","tags_url":"https://api.github.com/repos/threatgrid/ctia/tags","blobs_url":"https://api.github.com/repos/threatgrid/ctia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threatgrid/ctia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threatgrid/ctia/git/refs{/sha}","trees_url":"https://api.github.com/repos/threatgrid/ctia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threatgrid/ctia/statuses/{sha}","languages_url":"https://api.github.com/repos/threatgrid/ctia/languages","stargazers_url":"https://api.github.com/repos/threatgrid/ctia/stargazers","contributors_url":"https://api.github.com/repos/threatgrid/ctia/contributors","subscribers_url":"https://api.github.com/repos/threatgrid/ctia/subscribers","subscription_url":"https://api.github.com/repos/threatgrid/ctia/subscription","commits_url":"https://api.github.com/repos/threatgrid/ctia/commits{/sha}","git_commits_url":"https://api.github.com/repos/threatgrid/ctia/git/commits{/sha}","comments_url":"https://api.github.com/repos/threatgrid/ctia/comments{/number}","issue_comment_url":"https://api.github.com/repos/threatgrid/ctia/issues/comments{/number}","contents_url":"https://api.github.com/repos/threatgrid/ctia/contents/{+path}","compare_url":"https://api.github.com/repos/threatgrid/ctia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threatgrid/ctia/merges","archive_url":"https://api.github.com/repos/threatgrid/ctia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threatgrid/ctia/downloads","issues_url":"https://api.github.com/repos/threatgrid/ctia/issues{/number}","pulls_url":"https://api.github.com/repos/threatgrid/ctia/pulls{/number}","milestones_url":"https://api.github.com/repos/threatgrid/ctia/milestones{/number}","notifications_url":"https://api.github.com/repos/threatgrid/ctia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threatgrid/ctia/labels{/name}","releases_url":"https://api.github.com/repos/threatgrid/ctia/releases{/id}","deployments_url":"https://api.github.com/repos/threatgrid/ctia/deployments","created_at":"2015-12-09T04:41:06Z","updated_at":"2016-03-31T20:24:35Z","pushed_at":"2016-04-08T18:56:48Z","git_url":"git://github.com/threatgrid/ctia.git","ssh_url":"git@github.com:threatgrid/ctia.git","clone_url":"https://github.com/threatgrid/ctia.git","svn_url":"https://github.com/threatgrid/ctia","homepage":"","size":861,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":60,"forks":7,"open_issues":60,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/threatgrid/ctia/pulls/187"},"html":{"href":"https://github.com/threatgrid/ctia/pull/187"},"issue":{"href":"https://api.github.com/repos/threatgrid/ctia/issues/187"},"comments":{"href":"https://api.github.com/repos/threatgrid/ctia/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/threatgrid/ctia/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/threatgrid/ctia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/threatgrid/ctia/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/threatgrid/ctia/statuses/df8ad3897f2916e89b3af1e383e133189851c106"}}}}