{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8823","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8823/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8823/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8823/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8823","id":173227188,"number":8823,"title":"*: reformat according to STYLE.md","user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars.githubusercontent.com/u/43821?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"assignees":[{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-25T14:59:23Z","updated_at":"2016-08-25T19:38:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8823","html_url":"https://github.com/cockroachdb/cockroach/pull/8823","diff_url":"https://github.com/cockroachdb/cockroach/pull/8823.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8823.patch"},"body":"This is a large automated change produced by running\r\n`crlfmt -ignore \"pb.go\" -w .`\r\n\r\nAdditionally, `crlfmt` has been added to `GLOCKFILE` and will run in`make check`, failing if any reformats are created. Currently, `crlfmt` only checks for and fixes incorrectly wrapped function declarations.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8823)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/242511443","html_url":"https://github.com/cockroachdb/cockroach/pull/8823#issuecomment-242511443","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8823","id":242511443,"user":{"login":"paperstreet","id":52528,"avatar_url":"https://avatars.githubusercontent.com/u/52528?v=3","gravatar_id":"","url":"https://api.github.com/users/paperstreet","html_url":"https://github.com/paperstreet","followers_url":"https://api.github.com/users/paperstreet/followers","following_url":"https://api.github.com/users/paperstreet/following{/other_user}","gists_url":"https://api.github.com/users/paperstreet/gists{/gist_id}","starred_url":"https://api.github.com/users/paperstreet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paperstreet/subscriptions","organizations_url":"https://api.github.com/users/paperstreet/orgs","repos_url":"https://api.github.com/users/paperstreet/repos","events_url":"https://api.github.com/users/paperstreet/events{/privacy}","received_events_url":"https://api.github.com/users/paperstreet/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T19:38:44Z","updated_at":"2016-08-25T19:38:44Z","body":"I'm abstaining on now vs after code-yellow.\r\n\r\n@RaduBerinde The Before is a little more readable, but (for my money) it's only a _little_ more readable and the overhead of having to pick between the two every time you write a function (and potentially having a disagreement with a reviewer) isn't worth it. One of the big benefits of a style guide is eliminating bikeshedding over these sorts of marginal calls.\r\n\r\nAnd fwiw, I don't think `gofmt` is a strong example. I _hate_ that it reformats `if err != nil { return err }`, but overall its strong opinions do more good than harm"}}
{"actor":{"display_login":"paperstreet"}}