{"action":"created","issue":{"url":"https://api.github.com/repos/shelljs/shelljs/issues/347","repository_url":"https://api.github.com/repos/shelljs/shelljs","labels_url":"https://api.github.com/repos/shelljs/shelljs/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/shelljs/shelljs/issues/347/comments","events_url":"https://api.github.com/repos/shelljs/shelljs/issues/347/events","html_url":"https://github.com/shelljs/shelljs/issues/347","id":132336881,"number":347,"title":"Improve test coverage","user":{"login":"nfischer","id":5801521,"avatar_url":"https://avatars.githubusercontent.com/u/5801521?v=3","gravatar_id":"","url":"https://api.github.com/users/nfischer","html_url":"https://github.com/nfischer","followers_url":"https://api.github.com/users/nfischer/followers","following_url":"https://api.github.com/users/nfischer/following{/other_user}","gists_url":"https://api.github.com/users/nfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfischer/subscriptions","organizations_url":"https://api.github.com/users/nfischer/orgs","repos_url":"https://api.github.com/users/nfischer/repos","events_url":"https://api.github.com/users/nfischer/events{/privacy}","received_events_url":"https://api.github.com/users/nfischer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/shelljs/shelljs/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/shelljs/shelljs/labels/low%20priority","name":"low priority","color":"aaaaaa"},{"url":"https://api.github.com/repos/shelljs/shelljs/labels/test","name":"test","color":"000000"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/shelljs/shelljs/milestones/2","html_url":"https://github.com/shelljs/shelljs/milestones/v1.0.0","labels_url":"https://api.github.com/repos/shelljs/shelljs/milestones/2/labels","id":1548250,"number":2,"title":"v1.0.0","description":null,"creator":{"login":"nfischer","id":5801521,"avatar_url":"https://avatars.githubusercontent.com/u/5801521?v=3","gravatar_id":"","url":"https://api.github.com/users/nfischer","html_url":"https://github.com/nfischer","followers_url":"https://api.github.com/users/nfischer/followers","following_url":"https://api.github.com/users/nfischer/following{/other_user}","gists_url":"https://api.github.com/users/nfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfischer/subscriptions","organizations_url":"https://api.github.com/users/nfischer/orgs","repos_url":"https://api.github.com/users/nfischer/repos","events_url":"https://api.github.com/users/nfischer/events{/privacy}","received_events_url":"https://api.github.com/users/nfischer/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":0,"state":"open","created_at":"2016-01-28T04:45:24Z","updated_at":"2016-02-09T09:14:30Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2016-02-09T05:45:22Z","updated_at":"2016-02-13T04:43:05Z","closed_at":null,"body":"This is a general issue that our unit tests should be more comprehensive. I've noticed that sometimes unit tests don't actually test correct behavior (this was the issue with some tests in `touch.js` that I fixed. I'm sure there are also many options/edge cases for functions that are not tested very comprehensively.\r\n\r\nAs we work toward future releases, we should also work on improving our test framework, to prevent regressions. Also, we should probably add more sanity checks in the `run-tests.js` script, since because this uses ShellJS to test ShellJS, a major break (for example: if `ls()` returns the empty array every time) can cause the test runner to give a false positive.\r\n\r\nI'm putting the \"help wanted\" label on here, so if anyone is looking for something to contribute on, more test cases would be welcome.\r\n\r\nIf you'd like to contribute, please try to isolate your changes to one file per PR (it makes it much easier to review). Also, it helps if you tag this issue number in your PR. We're also interested in refactoring test cases (so as long as you know JS, you'd be able to help) :+1:"},"comment":{"url":"https://api.github.com/repos/shelljs/shelljs/issues/comments/183588380","html_url":"https://github.com/shelljs/shelljs/issues/347#issuecomment-183588380","issue_url":"https://api.github.com/repos/shelljs/shelljs/issues/347","id":183588380,"user":{"login":"blockloop","id":3022496,"avatar_url":"https://avatars.githubusercontent.com/u/3022496?v=3","gravatar_id":"","url":"https://api.github.com/users/blockloop","html_url":"https://github.com/blockloop","followers_url":"https://api.github.com/users/blockloop/followers","following_url":"https://api.github.com/users/blockloop/following{/other_user}","gists_url":"https://api.github.com/users/blockloop/gists{/gist_id}","starred_url":"https://api.github.com/users/blockloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockloop/subscriptions","organizations_url":"https://api.github.com/users/blockloop/orgs","repos_url":"https://api.github.com/users/blockloop/repos","events_url":"https://api.github.com/users/blockloop/events{/privacy}","received_events_url":"https://api.github.com/users/blockloop/received_events","type":"User","site_admin":false},"created_at":"2016-02-13T04:43:05Z","updated_at":"2016-02-13T04:43:05Z","body":"Are you opposed to adding mocha?"}}