{"action":"created","comment":{"url":"https://api.github.com/repos/cpputest/cpputest/pulls/comments/60026469","id":60026469,"diff_hunk":"@@ -199,6 +199,27 @@\n #define CPPUTEST_CHAR_BIT 8\n #endif\n \n+/* Support for \"long long\" type */\n+#ifdef CPPUTEST_USE_LONG_LONG","path":"include/CppUTest/CppUTestConfig.h","position":5,"original_position":5,"commit_id":"328dfeb0383d4e9bde973e0b21065f1042fd12ee","original_commit_id":"328dfeb0383d4e9bde973e0b21065f1042fd12ee","user":{"login":"uecasm","id":539951,"avatar_url":"https://avatars.githubusercontent.com/u/539951?v=3","gravatar_id":"","url":"https://api.github.com/users/uecasm","html_url":"https://github.com/uecasm","followers_url":"https://api.github.com/users/uecasm/followers","following_url":"https://api.github.com/users/uecasm/following{/other_user}","gists_url":"https://api.github.com/users/uecasm/gists{/gist_id}","starred_url":"https://api.github.com/users/uecasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uecasm/subscriptions","organizations_url":"https://api.github.com/users/uecasm/orgs","repos_url":"https://api.github.com/users/uecasm/repos","events_url":"https://api.github.com/users/uecasm/events{/privacy}","received_events_url":"https://api.github.com/users/uecasm/received_events","type":"User","site_admin":false},"body":"Ah.  No.  In the original January version of the patch I tried to be more clever and autodetect compiler support (there's still a few traces of that lingering in this version, such as `AC_TYPE_LONG_LONG_INT` that's not actually used other than to taunt people who read `config.h`).  But as you may recall that sometimes ended up with weird behaviour when eg. the C++ and C compilers detected differently.  So now it's just a simple manually-specified toggle.\r\n\r\nHaving said that, there **is** a basic auto-detection I could add back in, possibly -- just a few lines up you do (conditionally) include `limits.h`.  This does contain something that should theoretically tell us whether the compiler supports `long long`s (if `LLONG_MAX` is defined).\r\n\r\nAlthough it's possible that some CRT libs define this even if the compiler doesn't support it, or that the application wants to build without them because they want to compile against an older C/C++ standard.  So for those reasons it might still be better to stick with a manual define.\r\n\r\n(Though again, in the January PR I had it tristate -- you could define `CPPUTEST_USE_LONG_LONG` to force support on, `CPPUTEST_NO_LONG_LONG` to force support off, and neither to let it try to auto-detect.)","created_at":"2016-04-18T09:06:58Z","updated_at":"2016-04-18T09:06:58Z","html_url":"https://github.com/cpputest/cpputest/pull/935#discussion_r60026469","pull_request_url":"https://api.github.com/repos/cpputest/cpputest/pulls/935","_links":{"self":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/comments/60026469"},"html":{"href":"https://github.com/cpputest/cpputest/pull/935#discussion_r60026469"},"pull_request":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/935"}}},"pull_request":{"url":"https://api.github.com/repos/cpputest/cpputest/pulls/935","id":66787217,"html_url":"https://github.com/cpputest/cpputest/pull/935","diff_url":"https://github.com/cpputest/cpputest/pull/935.diff","patch_url":"https://github.com/cpputest/cpputest/pull/935.patch","issue_url":"https://api.github.com/repos/cpputest/cpputest/issues/935","number":935,"state":"open","locked":false,"title":"Test support for long-long","user":{"login":"uecasm","id":539951,"avatar_url":"https://avatars.githubusercontent.com/u/539951?v=3","gravatar_id":"","url":"https://api.github.com/users/uecasm","html_url":"https://github.com/uecasm","followers_url":"https://api.github.com/users/uecasm/followers","following_url":"https://api.github.com/users/uecasm/following{/other_user}","gists_url":"https://api.github.com/users/uecasm/gists{/gist_id}","starred_url":"https://api.github.com/users/uecasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uecasm/subscriptions","organizations_url":"https://api.github.com/users/uecasm/orgs","repos_url":"https://api.github.com/users/uecasm/repos","events_url":"https://api.github.com/users/uecasm/events{/privacy}","received_events_url":"https://api.github.com/users/uecasm/received_events","type":"User","site_admin":false},"body":"Unit testing support for long long, extracted from #847 (mock support excluded).\r\n\r\nSupport is enabled by default for the Visual Studio projects (but still needs to be manually enabled on the user side by defining `CPPUTEST_USE_LONG_LONG` in the user project settings).\r\n\r\nAutoTools and CMake disable support by default but include an option to enable it (which will end up in `config.h` and will thus be automatically picked up by user code).\r\n\r\nSupport is enabled when Travis compiles for coverage testing.\r\n\r\nIf support is disabled, the APIs still exist but have a dummy placeholder type such that user code should fail to compile if they're trying to use long longs.  If support is enabled on the user side but disabled on the library side then the code will compile but will raise an \"unsupported feature\" test failure at runtime.","created_at":"2016-04-18T00:35:34Z","updated_at":"2016-04-18T09:06:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"635f6371df93ba163ab07c271ff5f15058411e54","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cpputest/cpputest/pulls/935/commits","review_comments_url":"https://api.github.com/repos/cpputest/cpputest/pulls/935/comments","review_comment_url":"https://api.github.com/repos/cpputest/cpputest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cpputest/cpputest/issues/935/comments","statuses_url":"https://api.github.com/repos/cpputest/cpputest/statuses/328dfeb0383d4e9bde973e0b21065f1042fd12ee","head":{"label":"uecasm:longlong-test","ref":"longlong-test","sha":"328dfeb0383d4e9bde973e0b21065f1042fd12ee","user":{"login":"uecasm","id":539951,"avatar_url":"https://avatars.githubusercontent.com/u/539951?v=3","gravatar_id":"","url":"https://api.github.com/users/uecasm","html_url":"https://github.com/uecasm","followers_url":"https://api.github.com/users/uecasm/followers","following_url":"https://api.github.com/users/uecasm/following{/other_user}","gists_url":"https://api.github.com/users/uecasm/gists{/gist_id}","starred_url":"https://api.github.com/users/uecasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uecasm/subscriptions","organizations_url":"https://api.github.com/users/uecasm/orgs","repos_url":"https://api.github.com/users/uecasm/repos","events_url":"https://api.github.com/users/uecasm/events{/privacy}","received_events_url":"https://api.github.com/users/uecasm/received_events","type":"User","site_admin":false},"repo":{"id":50543337,"name":"cpputest","full_name":"uecasm/cpputest","owner":{"login":"uecasm","id":539951,"avatar_url":"https://avatars.githubusercontent.com/u/539951?v=3","gravatar_id":"","url":"https://api.github.com/users/uecasm","html_url":"https://github.com/uecasm","followers_url":"https://api.github.com/users/uecasm/followers","following_url":"https://api.github.com/users/uecasm/following{/other_user}","gists_url":"https://api.github.com/users/uecasm/gists{/gist_id}","starred_url":"https://api.github.com/users/uecasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uecasm/subscriptions","organizations_url":"https://api.github.com/users/uecasm/orgs","repos_url":"https://api.github.com/users/uecasm/repos","events_url":"https://api.github.com/users/uecasm/events{/privacy}","received_events_url":"https://api.github.com/users/uecasm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uecasm/cpputest","description":"CppUTest unit testing and mocking framework for C/C++","fork":true,"url":"https://api.github.com/repos/uecasm/cpputest","forks_url":"https://api.github.com/repos/uecasm/cpputest/forks","keys_url":"https://api.github.com/repos/uecasm/cpputest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uecasm/cpputest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uecasm/cpputest/teams","hooks_url":"https://api.github.com/repos/uecasm/cpputest/hooks","issue_events_url":"https://api.github.com/repos/uecasm/cpputest/issues/events{/number}","events_url":"https://api.github.com/repos/uecasm/cpputest/events","assignees_url":"https://api.github.com/repos/uecasm/cpputest/assignees{/user}","branches_url":"https://api.github.com/repos/uecasm/cpputest/branches{/branch}","tags_url":"https://api.github.com/repos/uecasm/cpputest/tags","blobs_url":"https://api.github.com/repos/uecasm/cpputest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uecasm/cpputest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uecasm/cpputest/git/refs{/sha}","trees_url":"https://api.github.com/repos/uecasm/cpputest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uecasm/cpputest/statuses/{sha}","languages_url":"https://api.github.com/repos/uecasm/cpputest/languages","stargazers_url":"https://api.github.com/repos/uecasm/cpputest/stargazers","contributors_url":"https://api.github.com/repos/uecasm/cpputest/contributors","subscribers_url":"https://api.github.com/repos/uecasm/cpputest/subscribers","subscription_url":"https://api.github.com/repos/uecasm/cpputest/subscription","commits_url":"https://api.github.com/repos/uecasm/cpputest/commits{/sha}","git_commits_url":"https://api.github.com/repos/uecasm/cpputest/git/commits{/sha}","comments_url":"https://api.github.com/repos/uecasm/cpputest/comments{/number}","issue_comment_url":"https://api.github.com/repos/uecasm/cpputest/issues/comments{/number}","contents_url":"https://api.github.com/repos/uecasm/cpputest/contents/{+path}","compare_url":"https://api.github.com/repos/uecasm/cpputest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uecasm/cpputest/merges","archive_url":"https://api.github.com/repos/uecasm/cpputest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uecasm/cpputest/downloads","issues_url":"https://api.github.com/repos/uecasm/cpputest/issues{/number}","pulls_url":"https://api.github.com/repos/uecasm/cpputest/pulls{/number}","milestones_url":"https://api.github.com/repos/uecasm/cpputest/milestones{/number}","notifications_url":"https://api.github.com/repos/uecasm/cpputest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uecasm/cpputest/labels{/name}","releases_url":"https://api.github.com/repos/uecasm/cpputest/releases{/id}","deployments_url":"https://api.github.com/repos/uecasm/cpputest/deployments","created_at":"2016-01-27T22:43:44Z","updated_at":"2016-01-27T22:43:47Z","pushed_at":"2016-04-18T07:38:49Z","git_url":"git://github.com/uecasm/cpputest.git","ssh_url":"git@github.com:uecasm/cpputest.git","clone_url":"https://github.com/uecasm/cpputest.git","svn_url":"https://github.com/uecasm/cpputest","homepage":"http://cpputest.github.com","size":9726,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cpputest:master","ref":"master","sha":"98e073635f2cc7d03967a7d42f5ef2e1fcbda145","user":{"login":"cpputest","id":2120339,"avatar_url":"https://avatars.githubusercontent.com/u/2120339?v=3","gravatar_id":"","url":"https://api.github.com/users/cpputest","html_url":"https://github.com/cpputest","followers_url":"https://api.github.com/users/cpputest/followers","following_url":"https://api.github.com/users/cpputest/following{/other_user}","gists_url":"https://api.github.com/users/cpputest/gists{/gist_id}","starred_url":"https://api.github.com/users/cpputest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpputest/subscriptions","organizations_url":"https://api.github.com/users/cpputest/orgs","repos_url":"https://api.github.com/users/cpputest/repos","events_url":"https://api.github.com/users/cpputest/events{/privacy}","received_events_url":"https://api.github.com/users/cpputest/received_events","type":"Organization","site_admin":false},"repo":{"id":5269602,"name":"cpputest","full_name":"cpputest/cpputest","owner":{"login":"cpputest","id":2120339,"avatar_url":"https://avatars.githubusercontent.com/u/2120339?v=3","gravatar_id":"","url":"https://api.github.com/users/cpputest","html_url":"https://github.com/cpputest","followers_url":"https://api.github.com/users/cpputest/followers","following_url":"https://api.github.com/users/cpputest/following{/other_user}","gists_url":"https://api.github.com/users/cpputest/gists{/gist_id}","starred_url":"https://api.github.com/users/cpputest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpputest/subscriptions","organizations_url":"https://api.github.com/users/cpputest/orgs","repos_url":"https://api.github.com/users/cpputest/repos","events_url":"https://api.github.com/users/cpputest/events{/privacy}","received_events_url":"https://api.github.com/users/cpputest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cpputest/cpputest","description":"CppUTest unit testing and mocking framework for C/C++","fork":false,"url":"https://api.github.com/repos/cpputest/cpputest","forks_url":"https://api.github.com/repos/cpputest/cpputest/forks","keys_url":"https://api.github.com/repos/cpputest/cpputest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpputest/cpputest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpputest/cpputest/teams","hooks_url":"https://api.github.com/repos/cpputest/cpputest/hooks","issue_events_url":"https://api.github.com/repos/cpputest/cpputest/issues/events{/number}","events_url":"https://api.github.com/repos/cpputest/cpputest/events","assignees_url":"https://api.github.com/repos/cpputest/cpputest/assignees{/user}","branches_url":"https://api.github.com/repos/cpputest/cpputest/branches{/branch}","tags_url":"https://api.github.com/repos/cpputest/cpputest/tags","blobs_url":"https://api.github.com/repos/cpputest/cpputest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpputest/cpputest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpputest/cpputest/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpputest/cpputest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpputest/cpputest/statuses/{sha}","languages_url":"https://api.github.com/repos/cpputest/cpputest/languages","stargazers_url":"https://api.github.com/repos/cpputest/cpputest/stargazers","contributors_url":"https://api.github.com/repos/cpputest/cpputest/contributors","subscribers_url":"https://api.github.com/repos/cpputest/cpputest/subscribers","subscription_url":"https://api.github.com/repos/cpputest/cpputest/subscription","commits_url":"https://api.github.com/repos/cpputest/cpputest/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpputest/cpputest/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpputest/cpputest/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpputest/cpputest/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpputest/cpputest/contents/{+path}","compare_url":"https://api.github.com/repos/cpputest/cpputest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpputest/cpputest/merges","archive_url":"https://api.github.com/repos/cpputest/cpputest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpputest/cpputest/downloads","issues_url":"https://api.github.com/repos/cpputest/cpputest/issues{/number}","pulls_url":"https://api.github.com/repos/cpputest/cpputest/pulls{/number}","milestones_url":"https://api.github.com/repos/cpputest/cpputest/milestones{/number}","notifications_url":"https://api.github.com/repos/cpputest/cpputest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpputest/cpputest/labels{/name}","releases_url":"https://api.github.com/repos/cpputest/cpputest/releases{/id}","deployments_url":"https://api.github.com/repos/cpputest/cpputest/deployments","created_at":"2012-08-02T07:32:25Z","updated_at":"2016-04-18T03:50:36Z","pushed_at":"2016-04-18T07:38:49Z","git_url":"git://github.com/cpputest/cpputest.git","ssh_url":"git@github.com:cpputest/cpputest.git","clone_url":"https://github.com/cpputest/cpputest.git","svn_url":"https://github.com/cpputest/cpputest","homepage":"http://cpputest.github.com","size":11994,"stargazers_count":310,"watchers_count":310,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":127,"forks":178,"open_issues":127,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/935"},"html":{"href":"https://github.com/cpputest/cpputest/pull/935"},"issue":{"href":"https://api.github.com/repos/cpputest/cpputest/issues/935"},"comments":{"href":"https://api.github.com/repos/cpputest/cpputest/issues/935/comments"},"review_comments":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/935/comments"},"review_comment":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cpputest/cpputest/pulls/935/commits"},"statuses":{"href":"https://api.github.com/repos/cpputest/cpputest/statuses/328dfeb0383d4e9bde973e0b21065f1042fd12ee"}}}}