{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/84140079","pull_request_review_id":4936459,"id":84140079,"diff_hunk":"@@ -0,0 +1,60 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Component\\HttpKernel\\DependencyInjection;\n+\n+use Symfony\\Component\\DependencyInjection\\Compiler\\PriorityTaggedServiceTrait;\n+use Symfony\\Component\\DependencyInjection\\ContainerBuilder;\n+use Symfony\\Component\\DependencyInjection\\Compiler\\CompilerPassInterface;\n+\n+/**\n+ * Registers the cache warmers.\n+ *\n+ * @author Fabien Potencier <fabien@symfony.com>\n+ */\n+class AddCacheWarmerPass implements CompilerPassInterface\n+{\n+    use PriorityTaggedServiceTrait;\n+\n+    private $tag;\n+    private $definition;\n+\n+    public function __construct($definition = null, $tag = null)","path":"src/Symfony/Component/HttpKernel/DependencyInjection/AddCacheWarmerPass.php","position":30,"original_position":30,"commit_id":"38aa51025370fe9b77e5f5049bc9e46f332dfd90","original_commit_id":"38aa51025370fe9b77e5f5049bc9e46f332dfd90","user":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"body":"Yes, but I wanted to add a deprecation on the fact that one should add arguments","created_at":"2016-10-19T18:46:42Z","updated_at":"2016-10-19T18:46:42Z","html_url":"https://github.com/symfony/symfony/pull/20250#discussion_r84140079","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/20250","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/84140079"},"html":{"href":"https://github.com/symfony/symfony/pull/20250#discussion_r84140079"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20250"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/20250","id":90042870,"html_url":"https://github.com/symfony/symfony/pull/20250","diff_url":"https://github.com/symfony/symfony/pull/20250.diff","patch_url":"https://github.com/symfony/symfony/pull/20250.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/20250","number":20250,"state":"open","locked":false,"title":"[Kernel] Move the cache compiler passes into the Kernel component","user":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | \"master\"\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | --\r\n| License       | MIT\r\n| Doc PR        | --\r\n\r\nLooking at the passes, for one who doesn't want to use the Framework Bundle (like me, in a minimal app) but has still need some accesses to part of it (such as cache clearers / cache warmers), and as these two passes are not tied to the framwork bundle (but are to the kernel component), I thought it would be better to move these two passes in the Kernel.\r\n\r\nNot sure what branch I should target, so I targetted master... And I am not sure if this is a bc break, as these two classes are not final but not tagged `@api`\r\n\r\n","created_at":"2016-10-19T16:15:18Z","updated_at":"2016-10-19T18:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"633eb9677897e93cf38f508d65d1344d4027c264","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/20250/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/20250/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/20250/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/38aa51025370fe9b77e5f5049bc9e46f332dfd90","head":{"label":"Taluu:move-cache-passes","ref":"move-cache-passes","sha":"38aa51025370fe9b77e5f5049bc9e46f332dfd90","user":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"repo":{"id":2191230,"name":"symfony","full_name":"Taluu/symfony","owner":{"login":"Taluu","id":239685,"avatar_url":"https://avatars.githubusercontent.com/u/239685?v=3","gravatar_id":"","url":"https://api.github.com/users/Taluu","html_url":"https://github.com/Taluu","followers_url":"https://api.github.com/users/Taluu/followers","following_url":"https://api.github.com/users/Taluu/following{/other_user}","gists_url":"https://api.github.com/users/Taluu/gists{/gist_id}","starred_url":"https://api.github.com/users/Taluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Taluu/subscriptions","organizations_url":"https://api.github.com/users/Taluu/orgs","repos_url":"https://api.github.com/users/Taluu/repos","events_url":"https://api.github.com/users/Taluu/events{/privacy}","received_events_url":"https://api.github.com/users/Taluu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Taluu/symfony","description":"The Symfony2 PHP framework","fork":true,"url":"https://api.github.com/repos/Taluu/symfony","forks_url":"https://api.github.com/repos/Taluu/symfony/forks","keys_url":"https://api.github.com/repos/Taluu/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Taluu/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Taluu/symfony/teams","hooks_url":"https://api.github.com/repos/Taluu/symfony/hooks","issue_events_url":"https://api.github.com/repos/Taluu/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/Taluu/symfony/events","assignees_url":"https://api.github.com/repos/Taluu/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/Taluu/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/Taluu/symfony/tags","blobs_url":"https://api.github.com/repos/Taluu/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Taluu/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Taluu/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/Taluu/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Taluu/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/Taluu/symfony/languages","stargazers_url":"https://api.github.com/repos/Taluu/symfony/stargazers","contributors_url":"https://api.github.com/repos/Taluu/symfony/contributors","subscribers_url":"https://api.github.com/repos/Taluu/symfony/subscribers","subscription_url":"https://api.github.com/repos/Taluu/symfony/subscription","commits_url":"https://api.github.com/repos/Taluu/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/Taluu/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/Taluu/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/Taluu/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/Taluu/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/Taluu/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Taluu/symfony/merges","archive_url":"https://api.github.com/repos/Taluu/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Taluu/symfony/downloads","issues_url":"https://api.github.com/repos/Taluu/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/Taluu/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/Taluu/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/Taluu/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Taluu/symfony/labels{/name}","releases_url":"https://api.github.com/repos/Taluu/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/Taluu/symfony/deployments","created_at":"2011-08-11T13:20:40Z","updated_at":"2016-10-19T15:50:59Z","pushed_at":"2016-10-19T18:33:36Z","git_url":"git://github.com/Taluu/symfony.git","ssh_url":"git@github.com:Taluu/symfony.git","clone_url":"https://github.com/Taluu/symfony.git","svn_url":"https://github.com/Taluu/symfony","homepage":"symfony.com","size":73709,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"b819518898bcdb6d30c65e642ccb86aa565f13c9","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-10-19T16:11:59Z","pushed_at":"2016-10-19T18:33:40Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":138180,"stargazers_count":13137,"watchers_count":13137,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5090,"mirror_url":null,"open_issues_count":741,"forks":5090,"open_issues":741,"watchers":13137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20250"},"html":{"href":"https://github.com/symfony/symfony/pull/20250"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/20250"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/20250/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20250/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/20250/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/38aa51025370fe9b77e5f5049bc9e46f332dfd90"}}}}
{"actor":{"display_login":"Taluu"}}