{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/template-library-core/pulls/comments/86946708","pull_request_review_id":7577571,"id":86946708,"diff_hunk":"@@ -39,84 +20,92 @@ function num_of_harddisks = {\n # returns the disk where grub must be installed\n ############################################################\n function boot_disk = {\n-    base = \"/hardware/harddisks\";\n-    dsk = value(base);\n-    device = \"\";\n-    ok = first(dsk,i,v);\n-    while (ok) {\n-        path = base+\"/\"+to_string(i)+\"/boot\";\n-        if (exists(to_string(path))) {\n-            if (value(path)) {\n-                device = i;\n-            };\n-        };\n-        ok = next(dsk,i,v);\n+  base = \"/hardware/harddisks\";\n+  dsk = value(base);\n+  device = \"\";\n+  foreach (i;v;dsk) {\n+    path = base+\"/\"+to_string(i)+\"/boot\";","path":"quattor/functions/filesystem.pan","position":53,"original_position":53,"commit_id":"3aa8647c3ca2bb9e0b551d6760dad7609e08bfb8","original_commit_id":"3aa8647c3ca2bb9e0b551d6760dad7609e08bfb8","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"body":"idem","created_at":"2016-11-08T08:59:56Z","updated_at":"2016-11-08T08:59:56Z","html_url":"https://github.com/quattor/template-library-core/pull/126#discussion_r86946708","pull_request_url":"https://api.github.com/repos/quattor/template-library-core/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/comments/86946708"},"html":{"href":"https://github.com/quattor/template-library-core/pull/126#discussion_r86946708"},"pull_request":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/template-library-core/pulls/126","id":88349170,"html_url":"https://github.com/quattor/template-library-core/pull/126","diff_url":"https://github.com/quattor/template-library-core/pull/126.diff","patch_url":"https://github.com/quattor/template-library-core/pull/126.patch","issue_url":"https://api.github.com/repos/quattor/template-library-core/issues/126","number":126,"state":"open","locked":false,"title":"Improved interface for partitions_add()","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"body":"Originally, `partitions_add` was only able to configure the size of a partition. The interface has been improved to received a dict of partition attributes rather than a number (partition size). For backward compatibility, the previous interface is still valid.\n\nPartly fixes #72 (the complete fix requires the complementary improvement in template-library-core).\n","created_at":"2016-10-06T22:00:40Z","updated_at":"2016-11-08T08:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01a3dbce48414ce3a15953c72f46398ad5acc31d","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/quattor/template-library-core/milestones/11","html_url":"https://github.com/quattor/template-library-core/milestones/16.10","labels_url":"https://api.github.com/repos/quattor/template-library-core/milestones/11/labels","id":1497796,"number":11,"title":"16.10","description":null,"creator":{"login":"jrha","id":323309,"avatar_url":"https://avatars.githubusercontent.com/u/323309?v=3","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2016-01-11T17:06:41Z","updated_at":"2016-11-08T08:53:23Z","due_on":"2016-10-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/template-library-core/pulls/126/commits","review_comments_url":"https://api.github.com/repos/quattor/template-library-core/pulls/126/comments","review_comment_url":"https://api.github.com/repos/quattor/template-library-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/template-library-core/issues/126/comments","statuses_url":"https://api.github.com/repos/quattor/template-library-core/statuses/3aa8647c3ca2bb9e0b551d6760dad7609e08bfb8","head":{"label":"jouvin:partitions_add","ref":"partitions_add","sha":"3aa8647c3ca2bb9e0b551d6760dad7609e08bfb8","user":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"repo":{"id":13266717,"name":"template-library-core","full_name":"jouvin/template-library-core","owner":{"login":"jouvin","id":1511937,"avatar_url":"https://avatars.githubusercontent.com/u/1511937?v=3","gravatar_id":"","url":"https://api.github.com/users/jouvin","html_url":"https://github.com/jouvin","followers_url":"https://api.github.com/users/jouvin/followers","following_url":"https://api.github.com/users/jouvin/following{/other_user}","gists_url":"https://api.github.com/users/jouvin/gists{/gist_id}","starred_url":"https://api.github.com/users/jouvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jouvin/subscriptions","organizations_url":"https://api.github.com/users/jouvin/orgs","repos_url":"https://api.github.com/users/jouvin/repos","events_url":"https://api.github.com/users/jouvin/events{/privacy}","received_events_url":"https://api.github.com/users/jouvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jouvin/template-library-core","description":"Pan templates for the configuration modules","fork":true,"url":"https://api.github.com/repos/jouvin/template-library-core","forks_url":"https://api.github.com/repos/jouvin/template-library-core/forks","keys_url":"https://api.github.com/repos/jouvin/template-library-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jouvin/template-library-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jouvin/template-library-core/teams","hooks_url":"https://api.github.com/repos/jouvin/template-library-core/hooks","issue_events_url":"https://api.github.com/repos/jouvin/template-library-core/issues/events{/number}","events_url":"https://api.github.com/repos/jouvin/template-library-core/events","assignees_url":"https://api.github.com/repos/jouvin/template-library-core/assignees{/user}","branches_url":"https://api.github.com/repos/jouvin/template-library-core/branches{/branch}","tags_url":"https://api.github.com/repos/jouvin/template-library-core/tags","blobs_url":"https://api.github.com/repos/jouvin/template-library-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jouvin/template-library-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jouvin/template-library-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jouvin/template-library-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jouvin/template-library-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jouvin/template-library-core/languages","stargazers_url":"https://api.github.com/repos/jouvin/template-library-core/stargazers","contributors_url":"https://api.github.com/repos/jouvin/template-library-core/contributors","subscribers_url":"https://api.github.com/repos/jouvin/template-library-core/subscribers","subscription_url":"https://api.github.com/repos/jouvin/template-library-core/subscription","commits_url":"https://api.github.com/repos/jouvin/template-library-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jouvin/template-library-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jouvin/template-library-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jouvin/template-library-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jouvin/template-library-core/contents/{+path}","compare_url":"https://api.github.com/repos/jouvin/template-library-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jouvin/template-library-core/merges","archive_url":"https://api.github.com/repos/jouvin/template-library-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jouvin/template-library-core/downloads","issues_url":"https://api.github.com/repos/jouvin/template-library-core/issues{/number}","pulls_url":"https://api.github.com/repos/jouvin/template-library-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jouvin/template-library-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jouvin/template-library-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jouvin/template-library-core/labels{/name}","releases_url":"https://api.github.com/repos/jouvin/template-library-core/releases{/id}","deployments_url":"https://api.github.com/repos/jouvin/template-library-core/deployments","created_at":"2013-10-02T09:00:58Z","updated_at":"2015-04-30T15:36:50Z","pushed_at":"2016-10-06T21:41:14Z","git_url":"git://github.com/jouvin/template-library-core.git","ssh_url":"git@github.com:jouvin/template-library-core.git","clone_url":"https://github.com/jouvin/template-library-core.git","svn_url":"https://github.com/jouvin/template-library-core","homepage":null,"size":5053,"stargazers_count":0,"watchers_count":0,"language":"Pan","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"ff6a9e46dba2f07ba6936a807de73d9d8597b6a8","user":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":12486277,"name":"template-library-core","full_name":"quattor/template-library-core","owner":{"login":"quattor","id":1557169,"avatar_url":"https://avatars.githubusercontent.com/u/1557169?v=3","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quattor/template-library-core","description":"Pan templates for the configuration modules","fork":false,"url":"https://api.github.com/repos/quattor/template-library-core","forks_url":"https://api.github.com/repos/quattor/template-library-core/forks","keys_url":"https://api.github.com/repos/quattor/template-library-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/template-library-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/template-library-core/teams","hooks_url":"https://api.github.com/repos/quattor/template-library-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/template-library-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/template-library-core/events","assignees_url":"https://api.github.com/repos/quattor/template-library-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/template-library-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/template-library-core/tags","blobs_url":"https://api.github.com/repos/quattor/template-library-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/template-library-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/template-library-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/template-library-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/template-library-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/template-library-core/languages","stargazers_url":"https://api.github.com/repos/quattor/template-library-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/template-library-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/template-library-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/template-library-core/subscription","commits_url":"https://api.github.com/repos/quattor/template-library-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/template-library-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/template-library-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/template-library-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/template-library-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/template-library-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/template-library-core/merges","archive_url":"https://api.github.com/repos/quattor/template-library-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/template-library-core/downloads","issues_url":"https://api.github.com/repos/quattor/template-library-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/template-library-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/template-library-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/template-library-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/template-library-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/template-library-core/releases{/id}","deployments_url":"https://api.github.com/repos/quattor/template-library-core/deployments","created_at":"2013-08-30T12:52:11Z","updated_at":"2016-11-02T16:09:17Z","pushed_at":"2016-11-03T11:34:00Z","git_url":"git://github.com/quattor/template-library-core.git","ssh_url":"git@github.com:quattor/template-library-core.git","clone_url":"https://github.com/quattor/template-library-core.git","svn_url":"https://github.com/quattor/template-library-core","homepage":null,"size":5505,"stargazers_count":2,"watchers_count":2,"language":"Pan","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":20,"forks":20,"open_issues":20,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/126"},"html":{"href":"https://github.com/quattor/template-library-core/pull/126"},"issue":{"href":"https://api.github.com/repos/quattor/template-library-core/issues/126"},"comments":{"href":"https://api.github.com/repos/quattor/template-library-core/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/template-library-core/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/template-library-core/statuses/3aa8647c3ca2bb9e0b551d6760dad7609e08bfb8"}}}}
{"actor":{"display_login":"jouvin"}}