{"action":"closed","number":1028,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1028","id":67386785,"html_url":"https://github.com/puppetlabs/puppetserver/pull/1028","diff_url":"https://github.com/puppetlabs/puppetserver/pull/1028.diff","patch_url":"https://github.com/puppetlabs/puppetserver/pull/1028.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1028","number":1028,"state":"closed","locked":false,"title":"Take up ring-middleware helpers","user":{"login":"justinstoller","id":241423,"avatar_url":"https://avatars.githubusercontent.com/u/241423?v=3","gravatar_id":"","url":"https://api.github.com/users/justinstoller","html_url":"https://github.com/justinstoller","followers_url":"https://api.github.com/users/justinstoller/followers","following_url":"https://api.github.com/users/justinstoller/following{/other_user}","gists_url":"https://api.github.com/users/justinstoller/gists{/gist_id}","starred_url":"https://api.github.com/users/justinstoller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinstoller/subscriptions","organizations_url":"https://api.github.com/users/justinstoller/orgs","repos_url":"https://api.github.com/users/justinstoller/repos","events_url":"https://api.github.com/users/justinstoller/events{/privacy}","received_events_url":"https://api.github.com/users/justinstoller/received_events","type":"User","site_admin":false},"body":"Previously we copied and pasted (with slight changes) much of what made\r\nup our ringutils.\r\n\r\nAs part of TK-214, the re-usable portions have moved to\r\npuppetlabs/ring-middleware. This patch updates puppetserver to use those\r\ncommon library functions and removes the outdated vendored functions.","created_at":"2016-04-21T16:48:19Z","updated_at":"2016-05-12T18:00:56Z","closed_at":"2016-05-12T18:00:56Z","merged_at":"2016-05-12T18:00:56Z","merge_commit_sha":"049b1f0137528e6f4ebb6f50210d8bb18848eb0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1028/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1028/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1028/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetserver/statuses/33ad1421a40a96b51ef3d75d312649ba478e1a2e","head":{"label":"justinstoller:consolidate-ringutils","ref":"consolidate-ringutils","sha":"33ad1421a40a96b51ef3d75d312649ba478e1a2e","user":{"login":"justinstoller","id":241423,"avatar_url":"https://avatars.githubusercontent.com/u/241423?v=3","gravatar_id":"","url":"https://api.github.com/users/justinstoller","html_url":"https://github.com/justinstoller","followers_url":"https://api.github.com/users/justinstoller/followers","following_url":"https://api.github.com/users/justinstoller/following{/other_user}","gists_url":"https://api.github.com/users/justinstoller/gists{/gist_id}","starred_url":"https://api.github.com/users/justinstoller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinstoller/subscriptions","organizations_url":"https://api.github.com/users/justinstoller/orgs","repos_url":"https://api.github.com/users/justinstoller/repos","events_url":"https://api.github.com/users/justinstoller/events{/privacy}","received_events_url":"https://api.github.com/users/justinstoller/received_events","type":"User","site_admin":false},"repo":{"id":56716965,"name":"puppetserver","full_name":"justinstoller/puppetserver","owner":{"login":"justinstoller","id":241423,"avatar_url":"https://avatars.githubusercontent.com/u/241423?v=3","gravatar_id":"","url":"https://api.github.com/users/justinstoller","html_url":"https://github.com/justinstoller","followers_url":"https://api.github.com/users/justinstoller/followers","following_url":"https://api.github.com/users/justinstoller/following{/other_user}","gists_url":"https://api.github.com/users/justinstoller/gists{/gist_id}","starred_url":"https://api.github.com/users/justinstoller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinstoller/subscriptions","organizations_url":"https://api.github.com/users/justinstoller/orgs","repos_url":"https://api.github.com/users/justinstoller/repos","events_url":"https://api.github.com/users/justinstoller/events{/privacy}","received_events_url":"https://api.github.com/users/justinstoller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinstoller/puppetserver","description":"Server automation framework and application","fork":true,"url":"https://api.github.com/repos/justinstoller/puppetserver","forks_url":"https://api.github.com/repos/justinstoller/puppetserver/forks","keys_url":"https://api.github.com/repos/justinstoller/puppetserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinstoller/puppetserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinstoller/puppetserver/teams","hooks_url":"https://api.github.com/repos/justinstoller/puppetserver/hooks","issue_events_url":"https://api.github.com/repos/justinstoller/puppetserver/issues/events{/number}","events_url":"https://api.github.com/repos/justinstoller/puppetserver/events","assignees_url":"https://api.github.com/repos/justinstoller/puppetserver/assignees{/user}","branches_url":"https://api.github.com/repos/justinstoller/puppetserver/branches{/branch}","tags_url":"https://api.github.com/repos/justinstoller/puppetserver/tags","blobs_url":"https://api.github.com/repos/justinstoller/puppetserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinstoller/puppetserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinstoller/puppetserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinstoller/puppetserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinstoller/puppetserver/statuses/{sha}","languages_url":"https://api.github.com/repos/justinstoller/puppetserver/languages","stargazers_url":"https://api.github.com/repos/justinstoller/puppetserver/stargazers","contributors_url":"https://api.github.com/repos/justinstoller/puppetserver/contributors","subscribers_url":"https://api.github.com/repos/justinstoller/puppetserver/subscribers","subscription_url":"https://api.github.com/repos/justinstoller/puppetserver/subscription","commits_url":"https://api.github.com/repos/justinstoller/puppetserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinstoller/puppetserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinstoller/puppetserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinstoller/puppetserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinstoller/puppetserver/contents/{+path}","compare_url":"https://api.github.com/repos/justinstoller/puppetserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinstoller/puppetserver/merges","archive_url":"https://api.github.com/repos/justinstoller/puppetserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinstoller/puppetserver/downloads","issues_url":"https://api.github.com/repos/justinstoller/puppetserver/issues{/number}","pulls_url":"https://api.github.com/repos/justinstoller/puppetserver/pulls{/number}","milestones_url":"https://api.github.com/repos/justinstoller/puppetserver/milestones{/number}","notifications_url":"https://api.github.com/repos/justinstoller/puppetserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinstoller/puppetserver/labels{/name}","releases_url":"https://api.github.com/repos/justinstoller/puppetserver/releases{/id}","deployments_url":"https://api.github.com/repos/justinstoller/puppetserver/deployments","created_at":"2016-04-20T19:56:32Z","updated_at":"2016-04-20T19:56:33Z","pushed_at":"2016-05-12T17:40:42Z","git_url":"git://github.com/justinstoller/puppetserver.git","ssh_url":"git@github.com:justinstoller/puppetserver.git","clone_url":"https://github.com/justinstoller/puppetserver.git","svn_url":"https://github.com/justinstoller/puppetserver","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":3912,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"c4f9efb66fc5a88990c59643c83932c7d57d756a","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19546488,"name":"puppetserver","full_name":"puppetlabs/puppetserver","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetserver","description":"Server automation framework and application","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetserver","forks_url":"https://api.github.com/repos/puppetlabs/puppetserver/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetserver/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetserver/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetserver/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetserver/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetserver/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetserver/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetserver/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetserver/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetserver/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetserver/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetserver/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetserver/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetserver/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetserver/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetserver/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetserver/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetserver/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetserver/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetserver/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetserver/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetserver/deployments","created_at":"2014-05-07T19:00:24Z","updated_at":"2016-05-10T02:42:41Z","pushed_at":"2016-05-12T18:00:56Z","git_url":"git://github.com/puppetlabs/puppetserver.git","ssh_url":"git@github.com:puppetlabs/puppetserver.git","clone_url":"https://github.com/puppetlabs/puppetserver.git","svn_url":"https://github.com/puppetlabs/puppetserver","homepage":"https://tickets.puppetlabs.com/browse/SERVER","size":6377,"stargazers_count":137,"watchers_count":137,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":90,"mirror_url":null,"open_issues_count":10,"forks":90,"open_issues":10,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1028"},"html":{"href":"https://github.com/puppetlabs/puppetserver/pull/1028"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1028"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/issues/1028/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1028/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/pulls/1028/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetserver/statuses/33ad1421a40a96b51ef3d75d312649ba478e1a2e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rlinehan","id":1530016,"avatar_url":"https://avatars.githubusercontent.com/u/1530016?v=3","gravatar_id":"","url":"https://api.github.com/users/rlinehan","html_url":"https://github.com/rlinehan","followers_url":"https://api.github.com/users/rlinehan/followers","following_url":"https://api.github.com/users/rlinehan/following{/other_user}","gists_url":"https://api.github.com/users/rlinehan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlinehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlinehan/subscriptions","organizations_url":"https://api.github.com/users/rlinehan/orgs","repos_url":"https://api.github.com/users/rlinehan/repos","events_url":"https://api.github.com/users/rlinehan/events{/privacy}","received_events_url":"https://api.github.com/users/rlinehan/received_events","type":"User","site_admin":false},"comments":7,"review_comments":7,"commits":3,"additions":38,"deletions":110,"changed_files":10}}