{"action":"created","comment":{"url":"https://api.github.com/repos/seattlerb/minitest/pulls/comments/73618842","id":73618842,"diff_hunk":"@@ -45,6 +45,12 @@ module Minitest\n   mc.send :attr_accessor, :info_signal\n   self.info_signal = \"INFO\"\n \n+  SUITE_ORDERINGS = [:sorted, :random]\n+\n+  def self.suite_order\n+    @@suite_order || :random","path":"lib/minitest.rb","position":7,"original_position":7,"commit_id":"72137a1568c26fd8ce691d3f6dcf50da539f91bc","original_commit_id":"72137a1568c26fd8ce691d3f6dcf50da539f91bc","user":{"login":"chrisnicola","id":156449,"avatar_url":"https://avatars.githubusercontent.com/u/156449?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisnicola","html_url":"https://github.com/chrisnicola","followers_url":"https://api.github.com/users/chrisnicola/followers","following_url":"https://api.github.com/users/chrisnicola/following{/other_user}","gists_url":"https://api.github.com/users/chrisnicola/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnicola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnicola/subscriptions","organizations_url":"https://api.github.com/users/chrisnicola/orgs","repos_url":"https://api.github.com/users/chrisnicola/repos","events_url":"https://api.github.com/users/chrisnicola/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnicola/received_events","type":"User","site_admin":false},"body":"Yes that's a good idea. I didn't see that.","created_at":"2016-08-04T23:11:46Z","updated_at":"2016-08-04T23:11:46Z","html_url":"https://github.com/seattlerb/minitest/pull/636#discussion_r73618842","pull_request_url":"https://api.github.com/repos/seattlerb/minitest/pulls/636","_links":{"self":{"href":"https://api.github.com/repos/seattlerb/minitest/pulls/comments/73618842"},"html":{"href":"https://github.com/seattlerb/minitest/pull/636#discussion_r73618842"},"pull_request":{"href":"https://api.github.com/repos/seattlerb/minitest/pulls/636"}}},"pull_request":{"url":"https://api.github.com/repos/seattlerb/minitest/pulls/636","id":80123068,"html_url":"https://github.com/seattlerb/minitest/pull/636","diff_url":"https://github.com/seattlerb/minitest/pull/636.diff","patch_url":"https://github.com/seattlerb/minitest/pull/636.patch","issue_url":"https://api.github.com/repos/seattlerb/minitest/issues/636","number":636,"state":"open","locked":false,"title":"Don't shuffle runnables unless :random or :parallel","user":{"login":"chrisnicola","id":156449,"avatar_url":"https://avatars.githubusercontent.com/u/156449?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisnicola","html_url":"https://github.com/chrisnicola","followers_url":"https://api.github.com/users/chrisnicola/followers","following_url":"https://api.github.com/users/chrisnicola/following{/other_user}","gists_url":"https://api.github.com/users/chrisnicola/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnicola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnicola/subscriptions","organizations_url":"https://api.github.com/users/chrisnicola/orgs","repos_url":"https://api.github.com/users/chrisnicola/repos","events_url":"https://api.github.com/users/chrisnicola/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnicola/received_events","type":"User","site_admin":false},"body":"Don't shuffle Runnable.runnables when running tests with test_order set to :random or :parallel.\r\n\r\nI have not added any test for this as there doesn't seem to be any place where this part of the test runner is currently being tested.\r\n\r\nI also considered it might make sense to encapsulate this logic in the `Runnable` class. This would probably be easier to write unit tests for as well.","created_at":"2016-08-04T18:05:07Z","updated_at":"2016-08-04T23:11:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8893da04cd5eea558842708ccfaaeb549464c08f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/seattlerb/minitest/pulls/636/commits","review_comments_url":"https://api.github.com/repos/seattlerb/minitest/pulls/636/comments","review_comment_url":"https://api.github.com/repos/seattlerb/minitest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seattlerb/minitest/issues/636/comments","statuses_url":"https://api.github.com/repos/seattlerb/minitest/statuses/72137a1568c26fd8ce691d3f6dcf50da539f91bc","head":{"label":"chrisnicola:allow-alpha-order-of-runables","ref":"allow-alpha-order-of-runables","sha":"72137a1568c26fd8ce691d3f6dcf50da539f91bc","user":{"login":"chrisnicola","id":156449,"avatar_url":"https://avatars.githubusercontent.com/u/156449?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisnicola","html_url":"https://github.com/chrisnicola","followers_url":"https://api.github.com/users/chrisnicola/followers","following_url":"https://api.github.com/users/chrisnicola/following{/other_user}","gists_url":"https://api.github.com/users/chrisnicola/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnicola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnicola/subscriptions","organizations_url":"https://api.github.com/users/chrisnicola/orgs","repos_url":"https://api.github.com/users/chrisnicola/repos","events_url":"https://api.github.com/users/chrisnicola/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnicola/received_events","type":"User","site_admin":false},"repo":{"id":38080422,"name":"minitest","full_name":"chrisnicola/minitest","owner":{"login":"chrisnicola","id":156449,"avatar_url":"https://avatars.githubusercontent.com/u/156449?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisnicola","html_url":"https://github.com/chrisnicola","followers_url":"https://api.github.com/users/chrisnicola/followers","following_url":"https://api.github.com/users/chrisnicola/following{/other_user}","gists_url":"https://api.github.com/users/chrisnicola/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisnicola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisnicola/subscriptions","organizations_url":"https://api.github.com/users/chrisnicola/orgs","repos_url":"https://api.github.com/users/chrisnicola/repos","events_url":"https://api.github.com/users/chrisnicola/events{/privacy}","received_events_url":"https://api.github.com/users/chrisnicola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisnicola/minitest","description":"minitest provides a complete suite of testing facilities supporting TDD, BDD, mocking, and benchmarking.","fork":true,"url":"https://api.github.com/repos/chrisnicola/minitest","forks_url":"https://api.github.com/repos/chrisnicola/minitest/forks","keys_url":"https://api.github.com/repos/chrisnicola/minitest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisnicola/minitest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisnicola/minitest/teams","hooks_url":"https://api.github.com/repos/chrisnicola/minitest/hooks","issue_events_url":"https://api.github.com/repos/chrisnicola/minitest/issues/events{/number}","events_url":"https://api.github.com/repos/chrisnicola/minitest/events","assignees_url":"https://api.github.com/repos/chrisnicola/minitest/assignees{/user}","branches_url":"https://api.github.com/repos/chrisnicola/minitest/branches{/branch}","tags_url":"https://api.github.com/repos/chrisnicola/minitest/tags","blobs_url":"https://api.github.com/repos/chrisnicola/minitest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisnicola/minitest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisnicola/minitest/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisnicola/minitest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisnicola/minitest/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisnicola/minitest/languages","stargazers_url":"https://api.github.com/repos/chrisnicola/minitest/stargazers","contributors_url":"https://api.github.com/repos/chrisnicola/minitest/contributors","subscribers_url":"https://api.github.com/repos/chrisnicola/minitest/subscribers","subscription_url":"https://api.github.com/repos/chrisnicola/minitest/subscription","commits_url":"https://api.github.com/repos/chrisnicola/minitest/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisnicola/minitest/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisnicola/minitest/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisnicola/minitest/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisnicola/minitest/contents/{+path}","compare_url":"https://api.github.com/repos/chrisnicola/minitest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisnicola/minitest/merges","archive_url":"https://api.github.com/repos/chrisnicola/minitest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisnicola/minitest/downloads","issues_url":"https://api.github.com/repos/chrisnicola/minitest/issues{/number}","pulls_url":"https://api.github.com/repos/chrisnicola/minitest/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisnicola/minitest/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisnicola/minitest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisnicola/minitest/labels{/name}","releases_url":"https://api.github.com/repos/chrisnicola/minitest/releases{/id}","deployments_url":"https://api.github.com/repos/chrisnicola/minitest/deployments","created_at":"2015-06-25T23:49:25Z","updated_at":"2016-08-04T01:57:36Z","pushed_at":"2016-08-04T23:03:34Z","git_url":"git://github.com/chrisnicola/minitest.git","ssh_url":"git@github.com:chrisnicola/minitest.git","clone_url":"https://github.com/chrisnicola/minitest.git","svn_url":"https://github.com/chrisnicola/minitest","homepage":"http://docs.seattlerb.org/minitest/","size":1269,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seattlerb:master","ref":"master","sha":"fc96854d3bf6495ea9f7dad821bb64f6bf03440f","user":{"login":"seattlerb","id":55277,"avatar_url":"https://avatars.githubusercontent.com/u/55277?v=3","gravatar_id":"","url":"https://api.github.com/users/seattlerb","html_url":"https://github.com/seattlerb","followers_url":"https://api.github.com/users/seattlerb/followers","following_url":"https://api.github.com/users/seattlerb/following{/other_user}","gists_url":"https://api.github.com/users/seattlerb/gists{/gist_id}","starred_url":"https://api.github.com/users/seattlerb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seattlerb/subscriptions","organizations_url":"https://api.github.com/users/seattlerb/orgs","repos_url":"https://api.github.com/users/seattlerb/repos","events_url":"https://api.github.com/users/seattlerb/events{/privacy}","received_events_url":"https://api.github.com/users/seattlerb/received_events","type":"Organization","site_admin":false},"repo":{"id":131505,"name":"minitest","full_name":"seattlerb/minitest","owner":{"login":"seattlerb","id":55277,"avatar_url":"https://avatars.githubusercontent.com/u/55277?v=3","gravatar_id":"","url":"https://api.github.com/users/seattlerb","html_url":"https://github.com/seattlerb","followers_url":"https://api.github.com/users/seattlerb/followers","following_url":"https://api.github.com/users/seattlerb/following{/other_user}","gists_url":"https://api.github.com/users/seattlerb/gists{/gist_id}","starred_url":"https://api.github.com/users/seattlerb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seattlerb/subscriptions","organizations_url":"https://api.github.com/users/seattlerb/orgs","repos_url":"https://api.github.com/users/seattlerb/repos","events_url":"https://api.github.com/users/seattlerb/events{/privacy}","received_events_url":"https://api.github.com/users/seattlerb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seattlerb/minitest","description":"minitest provides a complete suite of testing facilities supporting TDD, BDD, mocking, and benchmarking.","fork":false,"url":"https://api.github.com/repos/seattlerb/minitest","forks_url":"https://api.github.com/repos/seattlerb/minitest/forks","keys_url":"https://api.github.com/repos/seattlerb/minitest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seattlerb/minitest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seattlerb/minitest/teams","hooks_url":"https://api.github.com/repos/seattlerb/minitest/hooks","issue_events_url":"https://api.github.com/repos/seattlerb/minitest/issues/events{/number}","events_url":"https://api.github.com/repos/seattlerb/minitest/events","assignees_url":"https://api.github.com/repos/seattlerb/minitest/assignees{/user}","branches_url":"https://api.github.com/repos/seattlerb/minitest/branches{/branch}","tags_url":"https://api.github.com/repos/seattlerb/minitest/tags","blobs_url":"https://api.github.com/repos/seattlerb/minitest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seattlerb/minitest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seattlerb/minitest/git/refs{/sha}","trees_url":"https://api.github.com/repos/seattlerb/minitest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seattlerb/minitest/statuses/{sha}","languages_url":"https://api.github.com/repos/seattlerb/minitest/languages","stargazers_url":"https://api.github.com/repos/seattlerb/minitest/stargazers","contributors_url":"https://api.github.com/repos/seattlerb/minitest/contributors","subscribers_url":"https://api.github.com/repos/seattlerb/minitest/subscribers","subscription_url":"https://api.github.com/repos/seattlerb/minitest/subscription","commits_url":"https://api.github.com/repos/seattlerb/minitest/commits{/sha}","git_commits_url":"https://api.github.com/repos/seattlerb/minitest/git/commits{/sha}","comments_url":"https://api.github.com/repos/seattlerb/minitest/comments{/number}","issue_comment_url":"https://api.github.com/repos/seattlerb/minitest/issues/comments{/number}","contents_url":"https://api.github.com/repos/seattlerb/minitest/contents/{+path}","compare_url":"https://api.github.com/repos/seattlerb/minitest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seattlerb/minitest/merges","archive_url":"https://api.github.com/repos/seattlerb/minitest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seattlerb/minitest/downloads","issues_url":"https://api.github.com/repos/seattlerb/minitest/issues{/number}","pulls_url":"https://api.github.com/repos/seattlerb/minitest/pulls{/number}","milestones_url":"https://api.github.com/repos/seattlerb/minitest/milestones{/number}","notifications_url":"https://api.github.com/repos/seattlerb/minitest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seattlerb/minitest/labels{/name}","releases_url":"https://api.github.com/repos/seattlerb/minitest/releases{/id}","deployments_url":"https://api.github.com/repos/seattlerb/minitest/deployments","created_at":"2009-02-18T07:40:21Z","updated_at":"2016-08-04T12:17:31Z","pushed_at":"2016-08-04T23:03:50Z","git_url":"git://github.com/seattlerb/minitest.git","ssh_url":"git@github.com:seattlerb/minitest.git","clone_url":"https://github.com/seattlerb/minitest.git","svn_url":"https://github.com/seattlerb/minitest","homepage":"http://docs.seattlerb.org/minitest/","size":2305,"stargazers_count":1944,"watchers_count":1944,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":14,"forks":331,"open_issues":14,"watchers":1944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seattlerb/minitest/pulls/636"},"html":{"href":"https://github.com/seattlerb/minitest/pull/636"},"issue":{"href":"https://api.github.com/repos/seattlerb/minitest/issues/636"},"comments":{"href":"https://api.github.com/repos/seattlerb/minitest/issues/636/comments"},"review_comments":{"href":"https://api.github.com/repos/seattlerb/minitest/pulls/636/comments"},"review_comment":{"href":"https://api.github.com/repos/seattlerb/minitest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seattlerb/minitest/pulls/636/commits"},"statuses":{"href":"https://api.github.com/repos/seattlerb/minitest/statuses/72137a1568c26fd8ce691d3f6dcf50da539f91bc"}}}}
{"actor":{"display_login":"chrisnicola"}}