{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/88777895","pull_request_review_id":9343978,"id":88777895,"diff_hunk":"@@ -81,5 +83,8 @@ protected void configure() {\n     bind(PreviewManager.class).to(DefaultPreviewManager.class).in(Scopes.SINGLETON);\n \n     bind(Scheduler.class).to(NoopScheduler.class);\n+\n+    bind(PreviewStore.class).to(DefaultPreviewStore.class).in(Scopes.SINGLETON);\n+    expose(PreviewStore.class);","path":"cdap-app-fabric/src/main/java/co/cask/cdap/app/preview/PreviewModule.java","position":22,"original_position":22,"commit_id":"4717b661763d97b2061e4b46926641c1506416b6","original_commit_id":"4717b661763d97b2061e4b46926641c1506416b6","user":{"login":"yaojiefeng","id":12615579,"avatar_url":"https://avatars.githubusercontent.com/u/12615579?v=3","gravatar_id":"","url":"https://api.github.com/users/yaojiefeng","html_url":"https://github.com/yaojiefeng","followers_url":"https://api.github.com/users/yaojiefeng/followers","following_url":"https://api.github.com/users/yaojiefeng/following{/other_user}","gists_url":"https://api.github.com/users/yaojiefeng/gists{/gist_id}","starred_url":"https://api.github.com/users/yaojiefeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaojiefeng/subscriptions","organizations_url":"https://api.github.com/users/yaojiefeng/orgs","repos_url":"https://api.github.com/users/yaojiefeng/repos","events_url":"https://api.github.com/users/yaojiefeng/events{/privacy}","received_events_url":"https://api.github.com/users/yaojiefeng/received_events","type":"User","site_admin":false},"body":"It is needed since we will have one injector for each preview run. So need to it to be exposed. The `PreviewManager` in line 83 also need to be exposed for same reason. Think the change will come later with the implementation of `DefaultPreviewManager`","created_at":"2016-11-19T11:35:42Z","updated_at":"2016-11-19T11:35:42Z","html_url":"https://github.com/caskdata/cdap/pull/7141#discussion_r88777895","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/7141","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/88777895"},"html":{"href":"https://github.com/caskdata/cdap/pull/7141#discussion_r88777895"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7141"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/7141","id":94462147,"html_url":"https://github.com/caskdata/cdap/pull/7141","diff_url":"https://github.com/caskdata/cdap/pull/7141.diff","patch_url":"https://github.com/caskdata/cdap/pull/7141.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/7141","number":7141,"state":"open","locked":false,"title":"CDAP-7673 Add DataTracerFactoryProvider to get the correct DataTracer…","user":{"login":"yaojiefeng","id":12615579,"avatar_url":"https://avatars.githubusercontent.com/u/12615579?v=3","gravatar_id":"","url":"https://api.github.com/users/yaojiefeng","html_url":"https://github.com/yaojiefeng","followers_url":"https://api.github.com/users/yaojiefeng/followers","following_url":"https://api.github.com/users/yaojiefeng/following{/other_user}","gists_url":"https://api.github.com/users/yaojiefeng/gists{/gist_id}","starred_url":"https://api.github.com/users/yaojiefeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaojiefeng/subscriptions","organizations_url":"https://api.github.com/users/yaojiefeng/orgs","repos_url":"https://api.github.com/users/yaojiefeng/repos","events_url":"https://api.github.com/users/yaojiefeng/events{/privacy}","received_events_url":"https://api.github.com/users/yaojiefeng/received_events","type":"User","site_admin":false},"body":"…Factory\r\nJIRA: https://issues.cask.co/browse/CDAP-7673\r\nBuild: http://builds.cask.co/browse/CDAP-DUT5089-1\r\nAdded a DataTracerFactoryProvider class which preserve the DataTracerFactory type for each preview run. Each preview run will need to set the DataTracerFactory before the preview run. ","created_at":"2016-11-19T00:52:28Z","updated_at":"2016-11-19T11:35:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73af70d793eee48a184dfd65c873d508fe0dcbb7","assignee":{"login":"chtyim","id":885032,"avatar_url":"https://avatars.githubusercontent.com/u/885032?v=3","gravatar_id":"","url":"https://api.github.com/users/chtyim","html_url":"https://github.com/chtyim","followers_url":"https://api.github.com/users/chtyim/followers","following_url":"https://api.github.com/users/chtyim/following{/other_user}","gists_url":"https://api.github.com/users/chtyim/gists{/gist_id}","starred_url":"https://api.github.com/users/chtyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtyim/subscriptions","organizations_url":"https://api.github.com/users/chtyim/orgs","repos_url":"https://api.github.com/users/chtyim/repos","events_url":"https://api.github.com/users/chtyim/events{/privacy}","received_events_url":"https://api.github.com/users/chtyim/received_events","type":"User","site_admin":false},"assignees":[{"login":"chtyim","id":885032,"avatar_url":"https://avatars.githubusercontent.com/u/885032?v=3","gravatar_id":"","url":"https://api.github.com/users/chtyim","html_url":"https://github.com/chtyim","followers_url":"https://api.github.com/users/chtyim/followers","following_url":"https://api.github.com/users/chtyim/following{/other_user}","gists_url":"https://api.github.com/users/chtyim/gists{/gist_id}","starred_url":"https://api.github.com/users/chtyim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtyim/subscriptions","organizations_url":"https://api.github.com/users/chtyim/orgs","repos_url":"https://api.github.com/users/chtyim/repos","events_url":"https://api.github.com/users/chtyim/events{/privacy}","received_events_url":"https://api.github.com/users/chtyim/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/7141/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/7141/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/7141/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/4717b661763d97b2061e4b46926641c1506416b6","head":{"label":"caskdata:feature/addDataTracerFactoryProvider","ref":"feature/addDataTracerFactoryProvider","sha":"4717b661763d97b2061e4b46926641c1506416b6","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-11-16T23:35:12Z","pushed_at":"2016-11-19T09:47:39Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":667984,"stargazers_count":144,"watchers_count":144,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":17,"forks":64,"open_issues":17,"watchers":144,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"19455d3d999c8b900fabf7ec82d5c46c151bbbfe","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars.githubusercontent.com/u/8123023?v=3","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2016-11-16T23:35:12Z","pushed_at":"2016-11-19T09:47:39Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"http://cdap.io","size":667984,"stargazers_count":144,"watchers_count":144,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":17,"forks":64,"open_issues":17,"watchers":144,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7141"},"html":{"href":"https://github.com/caskdata/cdap/pull/7141"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/7141"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/7141/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7141/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/7141/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/4717b661763d97b2061e4b46926641c1506416b6"}}}}
{"actor":{"display_login":"yaojiefeng"}}