{"action":"created","issue":{"url":"https://api.github.com/repos/snabbco/snabb/issues/953","repository_url":"https://api.github.com/repos/snabbco/snabb","labels_url":"https://api.github.com/repos/snabbco/snabb/issues/953/labels{/name}","comments_url":"https://api.github.com/repos/snabbco/snabb/issues/953/comments","events_url":"https://api.github.com/repos/snabbco/snabb/issues/953/events","html_url":"https://github.com/snabbco/snabb/pull/953","id":162143945,"number":953,"title":"Various statistics counters for NFV apps","user":{"login":"eugeneia","id":4933566,"avatar_url":"https://avatars.githubusercontent.com/u/4933566?v=3","gravatar_id":"","url":"https://api.github.com/users/eugeneia","html_url":"https://github.com/eugeneia","followers_url":"https://api.github.com/users/eugeneia/followers","following_url":"https://api.github.com/users/eugeneia/following{/other_user}","gists_url":"https://api.github.com/users/eugeneia/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneia/subscriptions","organizations_url":"https://api.github.com/users/eugeneia/orgs","repos_url":"https://api.github.com/users/eugeneia/repos","events_url":"https://api.github.com/users/eugeneia/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneia/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/snabbco/snabb/labels/merged","name":"merged","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"kbara","id":1588250,"avatar_url":"https://avatars.githubusercontent.com/u/1588250?v=3","gravatar_id":"","url":"https://api.github.com/users/kbara","html_url":"https://github.com/kbara","followers_url":"https://api.github.com/users/kbara/followers","following_url":"https://api.github.com/users/kbara/following{/other_user}","gists_url":"https://api.github.com/users/kbara/gists{/gist_id}","starred_url":"https://api.github.com/users/kbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbara/subscriptions","organizations_url":"https://api.github.com/users/kbara/orgs","repos_url":"https://api.github.com/users/kbara/repos","events_url":"https://api.github.com/users/kbara/events{/privacy}","received_events_url":"https://api.github.com/users/kbara/received_events","type":"User","site_admin":false},"assignees":[{"login":"kbara","id":1588250,"avatar_url":"https://avatars.githubusercontent.com/u/1588250?v=3","gravatar_id":"","url":"https://api.github.com/users/kbara","html_url":"https://github.com/kbara","followers_url":"https://api.github.com/users/kbara/followers","following_url":"https://api.github.com/users/kbara/following{/other_user}","gists_url":"https://api.github.com/users/kbara/gists{/gist_id}","starred_url":"https://api.github.com/users/kbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbara/subscriptions","organizations_url":"https://api.github.com/users/kbara/orgs","repos_url":"https://api.github.com/users/kbara/repos","events_url":"https://api.github.com/users/kbara/events{/privacy}","received_events_url":"https://api.github.com/users/kbara/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-06-24T13:14:01Z","updated_at":"2016-07-05T16:59:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/snabbco/snabb/pulls/953","html_url":"https://github.com/snabbco/snabb/pull/953","diff_url":"https://github.com/snabbco/snabb/pull/953.diff","patch_url":"https://github.com/snabbco/snabb/pull/953.patch"},"body":"Depends on: #931 #949 \r\n\r\nThis adds statistics/diagnostics counters for various NFV apps.\r\n\r\n- L2TPv3 app counts `rxerrors`  broken down into why\r\n- ESP tunnel counts `rxerrors` (not insanely useful, can most of the time be inferred from link statistics)\r\n- nd_light has `status` (initially link down, link up once neighbor established), `rxerrors` (erroneous packets from south dropped, boken down into why), `txerrors` (erroneous packets from north), and `txdrop` (packets from north dropped while link down)\r\n- pcap_filter counts `rxerrors` and `sessions_established`\r\n- rate_limiter counts `txdrop` (again, not insanely useful)\r\n\r\nIf the recurring boilerplate code wasn't obvious until now, this PR shows it pretty prominently. My next step will be to abstract away the boilerplate I added in my recent PRs... :-)"},"comment":{"url":"https://api.github.com/repos/snabbco/snabb/issues/comments/230537916","html_url":"https://github.com/snabbco/snabb/pull/953#issuecomment-230537916","issue_url":"https://api.github.com/repos/snabbco/snabb/issues/953","id":230537916,"user":{"login":"kbara","id":1588250,"avatar_url":"https://avatars.githubusercontent.com/u/1588250?v=3","gravatar_id":"","url":"https://api.github.com/users/kbara","html_url":"https://github.com/kbara","followers_url":"https://api.github.com/users/kbara/followers","following_url":"https://api.github.com/users/kbara/following{/other_user}","gists_url":"https://api.github.com/users/kbara/gists{/gist_id}","starred_url":"https://api.github.com/users/kbara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbara/subscriptions","organizations_url":"https://api.github.com/users/kbara/orgs","repos_url":"https://api.github.com/users/kbara/repos","events_url":"https://api.github.com/users/kbara/events{/privacy}","received_events_url":"https://api.github.com/users/kbara/received_events","type":"User","site_admin":false},"created_at":"2016-07-05T16:59:33Z","updated_at":"2016-07-05T16:59:33Z","body":"Good idea; I've done so."}}
{"actor":{"display_login":"kbara"}}