{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/55084418","id":55084418,"diff_hunk":"@@ -145,11 +145,17 @@ private SchematronValidationService getService(boolean suppressWarnings, String\n \n         ArrayList<String> schemaFiles = new ArrayList<>();\n         for (String schematronFile : schematronFiles) {\n-            String path = schematronFile;\n             if (useClassLoader) {\n-                path = SchematronValidationServiceTest.class.getClassLoader().getResource(schematronFile).getPath();\n+                URL schematronResource = SchematronValidationServiceTest.class.getClassLoader().getResource(schematronFile);\n+                if (schematronResource == null) {\n+                    throw new NullPointerException(\n+                            \"The Schematron Resource came back null. Did you remove the resources folder?\");","path":"catalog/schematron/catalog-schematron-plugin/src/test/java/ddf/services/schematron/SchematronValidationServiceTest.java","position":10,"original_position":10,"commit_id":"f9d2806a129cf49d8ddabe1a8b2ed6294d76ae02","original_commit_id":"f9d2806a129cf49d8ddabe1a8b2ed6294d76ae02","user":{"login":"Lambeaux","id":7215534,"avatar_url":"https://avatars.githubusercontent.com/u/7215534?v=3","gravatar_id":"","url":"https://api.github.com/users/Lambeaux","html_url":"https://github.com/Lambeaux","followers_url":"https://api.github.com/users/Lambeaux/followers","following_url":"https://api.github.com/users/Lambeaux/following{/other_user}","gists_url":"https://api.github.com/users/Lambeaux/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambeaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambeaux/subscriptions","organizations_url":"https://api.github.com/users/Lambeaux/orgs","repos_url":"https://api.github.com/users/Lambeaux/repos","events_url":"https://api.github.com/users/Lambeaux/events{/privacy}","received_events_url":"https://api.github.com/users/Lambeaux/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2016-03-04T20:28:41Z","updated_at":"2016-03-04T20:28:41Z","html_url":"https://github.com/codice/ddf/pull/595#discussion_r55084418","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/595","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/55084418"},"html":{"href":"https://github.com/codice/ddf/pull/595#discussion_r55084418"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/595"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/595","id":61646857,"html_url":"https://github.com/codice/ddf/pull/595","diff_url":"https://github.com/codice/ddf/pull/595.diff","patch_url":"https://github.com/codice/ddf/pull/595.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/595","number":595,"state":"open","locked":false,"title":"DDF-1919: Updated unit tests so DDF can build on Windows","user":{"login":"Lambeaux","id":7215534,"avatar_url":"https://avatars.githubusercontent.com/u/7215534?v=3","gravatar_id":"","url":"https://api.github.com/users/Lambeaux","html_url":"https://github.com/Lambeaux","followers_url":"https://api.github.com/users/Lambeaux/followers","following_url":"https://api.github.com/users/Lambeaux/following{/other_user}","gists_url":"https://api.github.com/users/Lambeaux/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambeaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambeaux/subscriptions","organizations_url":"https://api.github.com/users/Lambeaux/orgs","repos_url":"https://api.github.com/users/Lambeaux/repos","events_url":"https://api.github.com/users/Lambeaux/events{/privacy}","received_events_url":"https://api.github.com/users/Lambeaux/received_events","type":"User","site_admin":false},"body":"_XMLUtilsTest Hard Coded \\n Removed_\r\nI changed the hard-coded line delimiter in some tests to use the\r\nSystem.lineSeparator for platform independence. Tests were failing due\r\nto a \"\\n\" and a \"\\r\\n\" mismatch.\r\n\r\n_URI Constructor Not Cross-Platform_\r\nApplicationFileInstaller.install now returns Paths.get() instead of a\r\nnew URI. This ensures the URI is properly created for the path based on\r\nthe operating system. Also refactored test code to optimize readability.\r\n\r\n_Checkstyle Rules Prevent Build_\r\nUpdated source for checkstyle:\r\n* Consolidated some exception throwing for better readability\r\n* Removed extraneous import statements\r\n* Deleted unnecessary code that was commented out for testing purposes\r\n* Fixed some JAVADOC spelling and grammar\r\n\r\n_Paths Exception from System Property Value Containing Unix Start-Slash_\r\nThis will require its own ticket to fix, since the system property\r\n\"javax.net.ssl.keyStore\" is set in multiple locations and tests. For\r\nnow, in order to preserve code coverage, I filtered out the troublesome\r\ninitial slash that should not be on windows by detecting the colon using\r\na regex.\r\n\r\n_Pathing and resource acquisition was done incorrectly._\r\nSee work-in-progress article: https://codice.atlassian.net/wiki/display/DDF/Preserving+Windows+Compatibility","created_at":"2016-03-04T00:00:38Z","updated_at":"2016-03-04T20:28:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a24b9b012aefafdfb884b718cb85a20c74d1d161","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/595/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/595/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/595/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/f9d2806a129cf49d8ddabe1a8b2ed6294d76ae02","head":{"label":"Lambeaux:DDF-1919","ref":"DDF-1919","sha":"f9d2806a129cf49d8ddabe1a8b2ed6294d76ae02","user":{"login":"Lambeaux","id":7215534,"avatar_url":"https://avatars.githubusercontent.com/u/7215534?v=3","gravatar_id":"","url":"https://api.github.com/users/Lambeaux","html_url":"https://github.com/Lambeaux","followers_url":"https://api.github.com/users/Lambeaux/followers","following_url":"https://api.github.com/users/Lambeaux/following{/other_user}","gists_url":"https://api.github.com/users/Lambeaux/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambeaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambeaux/subscriptions","organizations_url":"https://api.github.com/users/Lambeaux/orgs","repos_url":"https://api.github.com/users/Lambeaux/repos","events_url":"https://api.github.com/users/Lambeaux/events{/privacy}","received_events_url":"https://api.github.com/users/Lambeaux/received_events","type":"User","site_admin":false},"repo":{"id":47577497,"name":"ddf","full_name":"Lambeaux/ddf","owner":{"login":"Lambeaux","id":7215534,"avatar_url":"https://avatars.githubusercontent.com/u/7215534?v=3","gravatar_id":"","url":"https://api.github.com/users/Lambeaux","html_url":"https://github.com/Lambeaux","followers_url":"https://api.github.com/users/Lambeaux/followers","following_url":"https://api.github.com/users/Lambeaux/following{/other_user}","gists_url":"https://api.github.com/users/Lambeaux/gists{/gist_id}","starred_url":"https://api.github.com/users/Lambeaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lambeaux/subscriptions","organizations_url":"https://api.github.com/users/Lambeaux/orgs","repos_url":"https://api.github.com/users/Lambeaux/repos","events_url":"https://api.github.com/users/Lambeaux/events{/privacy}","received_events_url":"https://api.github.com/users/Lambeaux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lambeaux/ddf","description":"The Distributed Data Framework - Distribution, SDK, and Test","fork":true,"url":"https://api.github.com/repos/Lambeaux/ddf","forks_url":"https://api.github.com/repos/Lambeaux/ddf/forks","keys_url":"https://api.github.com/repos/Lambeaux/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lambeaux/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lambeaux/ddf/teams","hooks_url":"https://api.github.com/repos/Lambeaux/ddf/hooks","issue_events_url":"https://api.github.com/repos/Lambeaux/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/Lambeaux/ddf/events","assignees_url":"https://api.github.com/repos/Lambeaux/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/Lambeaux/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/Lambeaux/ddf/tags","blobs_url":"https://api.github.com/repos/Lambeaux/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lambeaux/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lambeaux/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lambeaux/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lambeaux/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/Lambeaux/ddf/languages","stargazers_url":"https://api.github.com/repos/Lambeaux/ddf/stargazers","contributors_url":"https://api.github.com/repos/Lambeaux/ddf/contributors","subscribers_url":"https://api.github.com/repos/Lambeaux/ddf/subscribers","subscription_url":"https://api.github.com/repos/Lambeaux/ddf/subscription","commits_url":"https://api.github.com/repos/Lambeaux/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lambeaux/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lambeaux/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lambeaux/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lambeaux/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/Lambeaux/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lambeaux/ddf/merges","archive_url":"https://api.github.com/repos/Lambeaux/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lambeaux/ddf/downloads","issues_url":"https://api.github.com/repos/Lambeaux/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/Lambeaux/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/Lambeaux/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/Lambeaux/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lambeaux/ddf/labels{/name}","releases_url":"https://api.github.com/repos/Lambeaux/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/Lambeaux/ddf/deployments","created_at":"2015-12-07T20:30:44Z","updated_at":"2016-01-11T17:33:30Z","pushed_at":"2016-03-04T18:08:47Z","git_url":"git://github.com/Lambeaux/ddf.git","ssh_url":"git@github.com:Lambeaux/ddf.git","clone_url":"https://github.com/Lambeaux/ddf.git","svn_url":"https://github.com/Lambeaux/ddf","homepage":"","size":130239,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"232fa50c65b1940bf269a6dd17ff41ccd90db40e","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars.githubusercontent.com/u/2386734?v=3","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"The Distributed Data Framework - Federated Open Geospatial Consortium (OGC) filter powered metadata catalog with SAML Web SSO secured container","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2016-02-23T03:59:25Z","pushed_at":"2016-03-04T20:23:14Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"","size":146185,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":70,"mirror_url":null,"open_issues_count":16,"forks":70,"open_issues":16,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/595"},"html":{"href":"https://github.com/codice/ddf/pull/595"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/595"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/595/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/595/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/595/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/f9d2806a129cf49d8ddabe1a8b2ed6294d76ae02"}}}}