{"action":"created","comment":{"url":"https://api.github.com/repos/phstc/shoryuken/pulls/comments/66248732","id":66248732,"diff_hunk":"@@ -64,21 +64,27 @@ def run(args)\n     private\n \n     def load_celluloid\n-      raise \"Celluloid cannot be required until here, or it will break Shoryuken's daemonization\" if defined?(::Celluloid) && Shoryuken.options[:daemon]\n-\n-      # Celluloid can't be loaded until after we've daemonized\n-      # because it spins up threads and creates locks which get\n-      # into a very bad state if forked.\n       require 'celluloid/autostart'\n-      Celluloid.logger = (Shoryuken.options[:verbose] ? Shoryuken.logger : nil)\n+      Celluloid.logger = (options[:verbose] ? Shoryuken.logger : nil)\n \n       require 'shoryuken/manager'\n     end\n \n-    def daemonize\n-      return unless Shoryuken.options[:daemon]\n+    def celluloid_loaded?\n+      defined?(::Celluloid)\n+    end\n+\n+    def daemonize(options)\n+      return unless options[:daemon]\n \n-      fail ArgumentError, \"You really should set a logfile if you're going to daemonize\" unless Shoryuken.options[:logfile]\n+      fail ArgumentError, \"You really should set a logfile if you're going to daemonize\" unless options[:logfile]\n+\n+      if celluloid_loaded?\n+        # Celluloid can't be loaded until after we've daemonized\n+        # because it spins up threads and creates locks which get\n+        # into a very bad state if forked.\n+        fail RuntimeError, \"Celluloid cannot be required until here, or it will break Shoryuken's daemonization\"","path":"lib/shoryuken/cli.rb","position":50,"original_position":50,"commit_id":"a2079fd1093398231a018665643f01b32d38c003","original_commit_id":"a2079fd1093398231a018665643f01b32d38c003","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Redundant `RuntimeError` argument can be removed.","created_at":"2016-06-08T12:51:55Z","updated_at":"2016-06-08T12:51:55Z","html_url":"https://github.com/phstc/shoryuken/pull/224#discussion_r66248732","pull_request_url":"https://api.github.com/repos/phstc/shoryuken/pulls/224","_links":{"self":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/comments/66248732"},"html":{"href":"https://github.com/phstc/shoryuken/pull/224#discussion_r66248732"},"pull_request":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/224"}}},"pull_request":{"url":"https://api.github.com/repos/phstc/shoryuken/pulls/224","id":73040444,"html_url":"https://github.com/phstc/shoryuken/pull/224","diff_url":"https://github.com/phstc/shoryuken/pull/224.diff","patch_url":"https://github.com/phstc/shoryuken/pull/224.patch","issue_url":"https://api.github.com/repos/phstc/shoryuken/issues/224","number":224,"state":"open","locked":false,"title":"Fix daemonization broken in #219","user":{"login":"mariokostelac","id":1917451,"avatar_url":"https://avatars.githubusercontent.com/u/1917451?v=3","gravatar_id":"","url":"https://api.github.com/users/mariokostelac","html_url":"https://github.com/mariokostelac","followers_url":"https://api.github.com/users/mariokostelac/followers","following_url":"https://api.github.com/users/mariokostelac/following{/other_user}","gists_url":"https://api.github.com/users/mariokostelac/gists{/gist_id}","starred_url":"https://api.github.com/users/mariokostelac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariokostelac/subscriptions","organizations_url":"https://api.github.com/users/mariokostelac/orgs","repos_url":"https://api.github.com/users/mariokostelac/repos","events_url":"https://api.github.com/users/mariokostelac/events{/privacy}","received_events_url":"https://api.github.com/users/mariokostelac/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-06-08T12:51:52Z","updated_at":"2016-06-08T12:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"825ad4b1b1e2b48535827c5ef071ceb0e08bc584","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phstc/shoryuken/pulls/224/commits","review_comments_url":"https://api.github.com/repos/phstc/shoryuken/pulls/224/comments","review_comment_url":"https://api.github.com/repos/phstc/shoryuken/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phstc/shoryuken/issues/224/comments","statuses_url":"https://api.github.com/repos/phstc/shoryuken/statuses/a2079fd1093398231a018665643f01b32d38c003","head":{"label":"phstc:fix_daemonization","ref":"fix_daemonization","sha":"a2079fd1093398231a018665643f01b32d38c003","user":{"login":"phstc","id":105652,"avatar_url":"https://avatars.githubusercontent.com/u/105652?v=3","gravatar_id":"","url":"https://api.github.com/users/phstc","html_url":"https://github.com/phstc","followers_url":"https://api.github.com/users/phstc/followers","following_url":"https://api.github.com/users/phstc/following{/other_user}","gists_url":"https://api.github.com/users/phstc/gists{/gist_id}","starred_url":"https://api.github.com/users/phstc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phstc/subscriptions","organizations_url":"https://api.github.com/users/phstc/orgs","repos_url":"https://api.github.com/users/phstc/repos","events_url":"https://api.github.com/users/phstc/events{/privacy}","received_events_url":"https://api.github.com/users/phstc/received_events","type":"User","site_admin":false},"repo":{"id":23578850,"name":"shoryuken","full_name":"phstc/shoryuken","owner":{"login":"phstc","id":105652,"avatar_url":"https://avatars.githubusercontent.com/u/105652?v=3","gravatar_id":"","url":"https://api.github.com/users/phstc","html_url":"https://github.com/phstc","followers_url":"https://api.github.com/users/phstc/followers","following_url":"https://api.github.com/users/phstc/following{/other_user}","gists_url":"https://api.github.com/users/phstc/gists{/gist_id}","starred_url":"https://api.github.com/users/phstc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phstc/subscriptions","organizations_url":"https://api.github.com/users/phstc/orgs","repos_url":"https://api.github.com/users/phstc/repos","events_url":"https://api.github.com/users/phstc/events{/privacy}","received_events_url":"https://api.github.com/users/phstc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phstc/shoryuken","description":"A super efficient AWS SQS thread based message processor for Ruby","fork":false,"url":"https://api.github.com/repos/phstc/shoryuken","forks_url":"https://api.github.com/repos/phstc/shoryuken/forks","keys_url":"https://api.github.com/repos/phstc/shoryuken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phstc/shoryuken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phstc/shoryuken/teams","hooks_url":"https://api.github.com/repos/phstc/shoryuken/hooks","issue_events_url":"https://api.github.com/repos/phstc/shoryuken/issues/events{/number}","events_url":"https://api.github.com/repos/phstc/shoryuken/events","assignees_url":"https://api.github.com/repos/phstc/shoryuken/assignees{/user}","branches_url":"https://api.github.com/repos/phstc/shoryuken/branches{/branch}","tags_url":"https://api.github.com/repos/phstc/shoryuken/tags","blobs_url":"https://api.github.com/repos/phstc/shoryuken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phstc/shoryuken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phstc/shoryuken/git/refs{/sha}","trees_url":"https://api.github.com/repos/phstc/shoryuken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phstc/shoryuken/statuses/{sha}","languages_url":"https://api.github.com/repos/phstc/shoryuken/languages","stargazers_url":"https://api.github.com/repos/phstc/shoryuken/stargazers","contributors_url":"https://api.github.com/repos/phstc/shoryuken/contributors","subscribers_url":"https://api.github.com/repos/phstc/shoryuken/subscribers","subscription_url":"https://api.github.com/repos/phstc/shoryuken/subscription","commits_url":"https://api.github.com/repos/phstc/shoryuken/commits{/sha}","git_commits_url":"https://api.github.com/repos/phstc/shoryuken/git/commits{/sha}","comments_url":"https://api.github.com/repos/phstc/shoryuken/comments{/number}","issue_comment_url":"https://api.github.com/repos/phstc/shoryuken/issues/comments{/number}","contents_url":"https://api.github.com/repos/phstc/shoryuken/contents/{+path}","compare_url":"https://api.github.com/repos/phstc/shoryuken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phstc/shoryuken/merges","archive_url":"https://api.github.com/repos/phstc/shoryuken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phstc/shoryuken/downloads","issues_url":"https://api.github.com/repos/phstc/shoryuken/issues{/number}","pulls_url":"https://api.github.com/repos/phstc/shoryuken/pulls{/number}","milestones_url":"https://api.github.com/repos/phstc/shoryuken/milestones{/number}","notifications_url":"https://api.github.com/repos/phstc/shoryuken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phstc/shoryuken/labels{/name}","releases_url":"https://api.github.com/repos/phstc/shoryuken/releases{/id}","deployments_url":"https://api.github.com/repos/phstc/shoryuken/deployments","created_at":"2014-09-02T13:04:10Z","updated_at":"2016-06-08T08:47:54Z","pushed_at":"2016-06-08T12:51:52Z","git_url":"git://github.com/phstc/shoryuken.git","ssh_url":"git@github.com:phstc/shoryuken.git","clone_url":"https://github.com/phstc/shoryuken.git","svn_url":"https://github.com/phstc/shoryuken","homepage":"","size":472,"stargazers_count":700,"watchers_count":700,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":12,"forks":93,"open_issues":12,"watchers":700,"default_branch":"master"}},"base":{"label":"phstc:master","ref":"master","sha":"5ce82150db9d076d056c144b8b4fe0a5f78f2336","user":{"login":"phstc","id":105652,"avatar_url":"https://avatars.githubusercontent.com/u/105652?v=3","gravatar_id":"","url":"https://api.github.com/users/phstc","html_url":"https://github.com/phstc","followers_url":"https://api.github.com/users/phstc/followers","following_url":"https://api.github.com/users/phstc/following{/other_user}","gists_url":"https://api.github.com/users/phstc/gists{/gist_id}","starred_url":"https://api.github.com/users/phstc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phstc/subscriptions","organizations_url":"https://api.github.com/users/phstc/orgs","repos_url":"https://api.github.com/users/phstc/repos","events_url":"https://api.github.com/users/phstc/events{/privacy}","received_events_url":"https://api.github.com/users/phstc/received_events","type":"User","site_admin":false},"repo":{"id":23578850,"name":"shoryuken","full_name":"phstc/shoryuken","owner":{"login":"phstc","id":105652,"avatar_url":"https://avatars.githubusercontent.com/u/105652?v=3","gravatar_id":"","url":"https://api.github.com/users/phstc","html_url":"https://github.com/phstc","followers_url":"https://api.github.com/users/phstc/followers","following_url":"https://api.github.com/users/phstc/following{/other_user}","gists_url":"https://api.github.com/users/phstc/gists{/gist_id}","starred_url":"https://api.github.com/users/phstc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phstc/subscriptions","organizations_url":"https://api.github.com/users/phstc/orgs","repos_url":"https://api.github.com/users/phstc/repos","events_url":"https://api.github.com/users/phstc/events{/privacy}","received_events_url":"https://api.github.com/users/phstc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phstc/shoryuken","description":"A super efficient AWS SQS thread based message processor for Ruby","fork":false,"url":"https://api.github.com/repos/phstc/shoryuken","forks_url":"https://api.github.com/repos/phstc/shoryuken/forks","keys_url":"https://api.github.com/repos/phstc/shoryuken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phstc/shoryuken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phstc/shoryuken/teams","hooks_url":"https://api.github.com/repos/phstc/shoryuken/hooks","issue_events_url":"https://api.github.com/repos/phstc/shoryuken/issues/events{/number}","events_url":"https://api.github.com/repos/phstc/shoryuken/events","assignees_url":"https://api.github.com/repos/phstc/shoryuken/assignees{/user}","branches_url":"https://api.github.com/repos/phstc/shoryuken/branches{/branch}","tags_url":"https://api.github.com/repos/phstc/shoryuken/tags","blobs_url":"https://api.github.com/repos/phstc/shoryuken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phstc/shoryuken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phstc/shoryuken/git/refs{/sha}","trees_url":"https://api.github.com/repos/phstc/shoryuken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phstc/shoryuken/statuses/{sha}","languages_url":"https://api.github.com/repos/phstc/shoryuken/languages","stargazers_url":"https://api.github.com/repos/phstc/shoryuken/stargazers","contributors_url":"https://api.github.com/repos/phstc/shoryuken/contributors","subscribers_url":"https://api.github.com/repos/phstc/shoryuken/subscribers","subscription_url":"https://api.github.com/repos/phstc/shoryuken/subscription","commits_url":"https://api.github.com/repos/phstc/shoryuken/commits{/sha}","git_commits_url":"https://api.github.com/repos/phstc/shoryuken/git/commits{/sha}","comments_url":"https://api.github.com/repos/phstc/shoryuken/comments{/number}","issue_comment_url":"https://api.github.com/repos/phstc/shoryuken/issues/comments{/number}","contents_url":"https://api.github.com/repos/phstc/shoryuken/contents/{+path}","compare_url":"https://api.github.com/repos/phstc/shoryuken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phstc/shoryuken/merges","archive_url":"https://api.github.com/repos/phstc/shoryuken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phstc/shoryuken/downloads","issues_url":"https://api.github.com/repos/phstc/shoryuken/issues{/number}","pulls_url":"https://api.github.com/repos/phstc/shoryuken/pulls{/number}","milestones_url":"https://api.github.com/repos/phstc/shoryuken/milestones{/number}","notifications_url":"https://api.github.com/repos/phstc/shoryuken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phstc/shoryuken/labels{/name}","releases_url":"https://api.github.com/repos/phstc/shoryuken/releases{/id}","deployments_url":"https://api.github.com/repos/phstc/shoryuken/deployments","created_at":"2014-09-02T13:04:10Z","updated_at":"2016-06-08T08:47:54Z","pushed_at":"2016-06-08T12:51:52Z","git_url":"git://github.com/phstc/shoryuken.git","ssh_url":"git@github.com:phstc/shoryuken.git","clone_url":"https://github.com/phstc/shoryuken.git","svn_url":"https://github.com/phstc/shoryuken","homepage":"","size":472,"stargazers_count":700,"watchers_count":700,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":12,"forks":93,"open_issues":12,"watchers":700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/224"},"html":{"href":"https://github.com/phstc/shoryuken/pull/224"},"issue":{"href":"https://api.github.com/repos/phstc/shoryuken/issues/224"},"comments":{"href":"https://api.github.com/repos/phstc/shoryuken/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/phstc/shoryuken/statuses/a2079fd1093398231a018665643f01b32d38c003"}}}}
{"actor":{"display_login":"houndci-bot"}}