{"push_id":1393668674,"size":2,"distinct_size":2,"ref":"refs/heads/dongsu/fleetctl-capi-unitstate-single","head":"b438a2c855d1db0c3a9d77f6d35d5aaffd89762a","before":"2c014f064b1b8305a03e534455455414e4514c0b","commits":[{"sha":"57443caca363b4045c8f2ccc895696b4dcf09fb2","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"fleetctl: periodically check for systemd states using waitForState\n\nAlthough checkSystemdActiveState() doesn't have to depend on\ncAPI.UnitStates(), it's still impossible to remove additional sleep\nin case of error from assertSystemdActiveState(). That's actually a\nknown issue. Sometimes it simply takes much time until fleetctl became\nable to get valid unit states. Adding additional sleeps or tuning the\nsleep time wouldn't be a good approach, as an optimal sleep interval\ncould vary a lot case by case.\n\nTo gracefully handle this case, let's do similar checking as done in\nfunctional tests.\n\n* Introduce a new helper waitForState(), just like util.WaitForState()\n  from functional tests.\n* Squash assertFetchSystemdActiveState() into assertSystemdActiveState()\n  to make it retry the assertion periodically up to defaultSleepTime.\n* Increase defaultSleepTime from 500 to 2000 msec.\n* Remove the additional sleep call as well as cAPI.UnitState() call.","distinct":true,"url":"https://api.github.com/repos/endocode/fleet/commits/57443caca363b4045c8f2ccc895696b4dcf09fb2"},{"sha":"b438a2c855d1db0c3a9d77f6d35d5aaffd89762a","author":{"name":"Dongsu Park","email":"05027982863758b025583251fb48dd2be12881c1@endocode.com"},"message":"fleetctl: make use of waitForState also in assertUnitState()\n\nwaitForUnitState() has been making use of an additional sleep, in case\nassertUnitState() returned error. Now that a helper waitForState() is\navailable for fleetctl, we don't need to sleep there.\n\nSo remove the sleep calls, and instead make assertUnitState() a wrapper\nof waitForState() over fetchUnitState(). That way, assertUnitState()\ncan periodically retry to get a unit, up to defaultSleepTime.\nThis is also good for consistency in the entire code, as\nassertSystemdActiveState() already depends on waitForState().","distinct":true,"url":"https://api.github.com/repos/endocode/fleet/commits/b438a2c855d1db0c3a9d77f6d35d5aaffd89762a"}]}
{"actor":{"display_login":"dongsupark"}}