{"action":"closed","number":3807,"pull_request":{"url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3807","id":84754889,"html_url":"https://github.com/pioneerspacesim/pioneer/pull/3807","diff_url":"https://github.com/pioneerspacesim/pioneer/pull/3807.diff","patch_url":"https://github.com/pioneerspacesim/pioneer/pull/3807.patch","issue_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3807","number":3807,"state":"closed","locked":false,"title":"Opengl 2.1 renderer","user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"body":"<!-- Please describe new feature, possible with screenshot if needed. -->\r\n# Opengl 2.1\r\nAn alternative Opengl 2.1 render in place of the standard Opengl 3.x (_'x' because of extensions etc_) for the following reasons:\r\n\r\n- compatibility with older hardware\r\n- improved separation between renderer & engine\r\n- ...I saw that 'jumpdrive' did it and I wanted it...\r\n\r\n# Missing bits\r\nI couldn't get all of the Opengl 3.x stuff to work exactly the same in Opengl 2.1 so there are visual differences and some performance differences like:\r\n\r\n- No GPU gas giant texture generation\r\n- No Instanced rendering\r\n- Starfield looks strange as points don't appear to resize correctly\r\n- Probably other bugs / visual issues\r\n\r\n# Nasty bits\r\nThe program [glLoadGen](https://bitbucket.org/alfonse/glloadgen/wiki/Home)(_ver 2.0.5_) was used to generate the header files used but at the top of each of these it defines a list of identifiers to prevent other Opengl loaders from being used/mixed in.\r\nThis is mostly fine except that I want to include 2 instances of these headers, for gl 3.x and 2.1 each.\r\nSo at the top of 'Pi.cpp' and 'ModelViewer.cpp' I must first '#undef' those symbols.\r\nI wonder if it would instead be acceptable to just remove them from the generated '.hpp' files instead?\r\n\r\nAlso of note is how long this has taken in fits and spurts, some of this branch is from 'November 9th 2015'. No doubt some of the rendering changes will have errors and problems.\r\n\r\n# Summary\r\nThis should allow the game to run lower end GPU's in laptops that cannot be upgraded.\r\nAlthough due to the lack of instanced rendering in the 2.1 branch it will perform worse around cities.\r\n\r\n<!-- Please make sure you've read documentation on contributing -->\r\n\r\n","created_at":"2016-09-10T13:01:29Z","updated_at":"2016-09-10T15:13:47Z","closed_at":"2016-09-10T15:13:47Z","merged_at":null,"merge_commit_sha":"1777edab9048bbf6dbb51ae55ac59cb8f077bf02","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3807/commits","review_comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3807/comments","review_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3807/comments","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/ca7f9f221813ecefe45e4f100603659df0a708e1","head":{"label":"fluffyfreak:gl21","ref":"gl21","sha":"ca7f9f221813ecefe45e4f100603659df0a708e1","user":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"repo":{"id":1836647,"name":"pioneer","full_name":"fluffyfreak/pioneer","owner":{"login":"fluffyfreak","id":825083,"avatar_url":"https://avatars.githubusercontent.com/u/825083?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffyfreak","html_url":"https://github.com/fluffyfreak","followers_url":"https://api.github.com/users/fluffyfreak/followers","following_url":"https://api.github.com/users/fluffyfreak/following{/other_user}","gists_url":"https://api.github.com/users/fluffyfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffyfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffyfreak/subscriptions","organizations_url":"https://api.github.com/users/fluffyfreak/orgs","repos_url":"https://api.github.com/users/fluffyfreak/repos","events_url":"https://api.github.com/users/fluffyfreak/events{/privacy}","received_events_url":"https://api.github.com/users/fluffyfreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fluffyfreak/pioneer","description":"space simulation adventure game","fork":true,"url":"https://api.github.com/repos/fluffyfreak/pioneer","forks_url":"https://api.github.com/repos/fluffyfreak/pioneer/forks","keys_url":"https://api.github.com/repos/fluffyfreak/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fluffyfreak/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fluffyfreak/pioneer/teams","hooks_url":"https://api.github.com/repos/fluffyfreak/pioneer/hooks","issue_events_url":"https://api.github.com/repos/fluffyfreak/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/fluffyfreak/pioneer/events","assignees_url":"https://api.github.com/repos/fluffyfreak/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/fluffyfreak/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/fluffyfreak/pioneer/tags","blobs_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fluffyfreak/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/fluffyfreak/pioneer/languages","stargazers_url":"https://api.github.com/repos/fluffyfreak/pioneer/stargazers","contributors_url":"https://api.github.com/repos/fluffyfreak/pioneer/contributors","subscribers_url":"https://api.github.com/repos/fluffyfreak/pioneer/subscribers","subscription_url":"https://api.github.com/repos/fluffyfreak/pioneer/subscription","commits_url":"https://api.github.com/repos/fluffyfreak/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fluffyfreak/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fluffyfreak/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fluffyfreak/pioneer/issues/comments{/number}","contents_url":"https://api.github.com/repos/fluffyfreak/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/fluffyfreak/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fluffyfreak/pioneer/merges","archive_url":"https://api.github.com/repos/fluffyfreak/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fluffyfreak/pioneer/downloads","issues_url":"https://api.github.com/repos/fluffyfreak/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/fluffyfreak/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/fluffyfreak/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/fluffyfreak/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fluffyfreak/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/fluffyfreak/pioneer/releases{/id}","deployments_url":"https://api.github.com/repos/fluffyfreak/pioneer/deployments","created_at":"2011-06-02T10:53:44Z","updated_at":"2016-09-03T19:05:10Z","pushed_at":"2016-09-10T14:17:16Z","git_url":"git://github.com/fluffyfreak/pioneer.git","ssh_url":"git@github.com:fluffyfreak/pioneer.git","clone_url":"https://github.com/fluffyfreak/pioneer.git","svn_url":"https://github.com/fluffyfreak/pioneer","homepage":"http://pioneerspacesim.net/","size":853725,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":3,"default_branch":"master"}},"base":{"label":"pioneerspacesim:master","ref":"master","sha":"480a59ef2608b8cadd161abbd9a65b8263417332","user":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"repo":{"id":1593053,"name":"pioneer","full_name":"pioneerspacesim/pioneer","owner":{"login":"pioneerspacesim","id":719820,"avatar_url":"https://avatars.githubusercontent.com/u/719820?v=3","gravatar_id":"","url":"https://api.github.com/users/pioneerspacesim","html_url":"https://github.com/pioneerspacesim","followers_url":"https://api.github.com/users/pioneerspacesim/followers","following_url":"https://api.github.com/users/pioneerspacesim/following{/other_user}","gists_url":"https://api.github.com/users/pioneerspacesim/gists{/gist_id}","starred_url":"https://api.github.com/users/pioneerspacesim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pioneerspacesim/subscriptions","organizations_url":"https://api.github.com/users/pioneerspacesim/orgs","repos_url":"https://api.github.com/users/pioneerspacesim/repos","events_url":"https://api.github.com/users/pioneerspacesim/events{/privacy}","received_events_url":"https://api.github.com/users/pioneerspacesim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pioneerspacesim/pioneer","description":"A game of lonely space adventure","fork":false,"url":"https://api.github.com/repos/pioneerspacesim/pioneer","forks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/forks","keys_url":"https://api.github.com/repos/pioneerspacesim/pioneer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pioneerspacesim/pioneer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pioneerspacesim/pioneer/teams","hooks_url":"https://api.github.com/repos/pioneerspacesim/pioneer/hooks","issue_events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/events{/number}","events_url":"https://api.github.com/repos/pioneerspacesim/pioneer/events","assignees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/assignees{/user}","branches_url":"https://api.github.com/repos/pioneerspacesim/pioneer/branches{/branch}","tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/tags","blobs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/{sha}","languages_url":"https://api.github.com/repos/pioneerspacesim/pioneer/languages","stargazers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/stargazers","contributors_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contributors","subscribers_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscribers","subscription_url":"https://api.github.com/repos/pioneerspacesim/pioneer/subscription","commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pioneerspacesim/pioneer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/comments{/number}","contents_url":"https://api.github.com/repos/pioneerspacesim/pioneer/contents/{+path}","compare_url":"https://api.github.com/repos/pioneerspacesim/pioneer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pioneerspacesim/pioneer/merges","archive_url":"https://api.github.com/repos/pioneerspacesim/pioneer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pioneerspacesim/pioneer/downloads","issues_url":"https://api.github.com/repos/pioneerspacesim/pioneer/issues{/number}","pulls_url":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls{/number}","milestones_url":"https://api.github.com/repos/pioneerspacesim/pioneer/milestones{/number}","notifications_url":"https://api.github.com/repos/pioneerspacesim/pioneer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pioneerspacesim/pioneer/labels{/name}","releases_url":"https://api.github.com/repos/pioneerspacesim/pioneer/releases{/id}","deployments_url":"https://api.github.com/repos/pioneerspacesim/pioneer/deployments","created_at":"2011-04-09T22:17:05Z","updated_at":"2016-09-08T18:12:44Z","pushed_at":"2016-09-10T14:17:17Z","git_url":"git://github.com/pioneerspacesim/pioneer.git","ssh_url":"git@github.com:pioneerspacesim/pioneer.git","clone_url":"https://github.com/pioneerspacesim/pioneer.git","svn_url":"https://github.com/pioneerspacesim/pioneer","homepage":"http://pioneerspacesim.net/","size":1445783,"stargazers_count":548,"watchers_count":548,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":294,"forks":238,"open_issues":294,"watchers":548,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3807"},"html":{"href":"https://github.com/pioneerspacesim/pioneer/pull/3807"},"issue":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3807"},"comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/issues/3807/comments"},"review_comments":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3807/comments"},"review_comment":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/pulls/3807/commits"},"statuses":{"href":"https://api.github.com/repos/pioneerspacesim/pioneer/statuses/ca7f9f221813ecefe45e4f100603659df0a708e1"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":27,"additions":16762,"deletions":4864,"changed_files":111}}
{"actor":{"display_login":"fluffyfreak"}}