{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/64402582","id":64402582,"diff_hunk":"@@ -27,55 +27,53 @@\n \n import org.apache.log4j.Logger;\n \n+import com.cloud.utils.StringUtils;\n+import com.google.common.base.Preconditions;\n+\n public class VmdkFileDescriptor {\n     private static final Logger s_logger = Logger.getLogger(VmdkFileDescriptor.class);\n     private static final String VMDK_PROPERTY_CREATE_TYPE = \"createType\";\n     private static final String VMDK_CREATE_TYPE_VMFSSPARSE = \"vmfsSparse\";\n     private static final String VMDK_PROPERTY_ADAPTER_TYPE = \"ddb.adapterType\";\n \n-    private Properties _properties = new Properties();\n+    private final Properties _properties = new Properties();\n     private String _baseFileName;\n \n     public VmdkFileDescriptor() {\n     }\n \n     public void parse(byte[] vmdkFileContent) throws IOException {\n-        BufferedReader in = null;\n-        try {\n-            in = new BufferedReader(new InputStreamReader(new ByteArrayInputStream(vmdkFileContent),\"UTF-8\"));\n+        try (BufferedReader in = new BufferedReader(new InputStreamReader(new ByteArrayInputStream(vmdkFileContent),\"UTF-8\"));) {\n             String line;\n             while ((line = in.readLine()) != null) {\n                 // ignore empty and comment lines\n                 line = line.trim();\n-                if (line.isEmpty())\n-                    continue;\n-                if (line.charAt(0) == '#')\n+                if (line.isEmpty() | line.charAt(0) == '#') {","path":"vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java","position":32,"original_position":32,"commit_id":"760ed0532e2c1a602529f1ac8aca5db33a7b0276","original_commit_id":"760ed0532e2c1a602529f1ac8aca5db33a7b0276","user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"body":"will redo the travis thing as well ;)","created_at":"2016-05-24T14:34:36Z","updated_at":"2016-05-24T14:34:36Z","html_url":"https://github.com/apache/cloudstack/pull/1530#discussion_r64402582","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/1530","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/64402582"},"html":{"href":"https://github.com/apache/cloudstack/pull/1530#discussion_r64402582"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1530"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/1530","id":68699800,"html_url":"https://github.com/apache/cloudstack/pull/1530","diff_url":"https://github.com/apache/cloudstack/pull/1530.diff","patch_url":"https://github.com/apache/cloudstack/pull/1530.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/1530","number":1530,"state":"open","locked":false,"title":"Vmdk findbugs","user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"body":"replacing #1351 ","created_at":"2016-05-03T12:46:36Z","updated_at":"2016-05-24T14:34:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52dcd53295a0f42c198c0a5c2b53c30fe981248d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/1530/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/1530/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/1530/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/760ed0532e2c1a602529f1ac8aca5db33a7b0276","head":{"label":"DaanHoogland:vmdk-findbugs","ref":"vmdk-findbugs","sha":"760ed0532e2c1a602529f1ac8aca5db33a7b0276","user":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"repo":{"id":25298400,"name":"cloudstack","full_name":"DaanHoogland/cloudstack","owner":{"login":"DaanHoogland","id":2486961,"avatar_url":"https://avatars.githubusercontent.com/u/2486961?v=3","gravatar_id":"","url":"https://api.github.com/users/DaanHoogland","html_url":"https://github.com/DaanHoogland","followers_url":"https://api.github.com/users/DaanHoogland/followers","following_url":"https://api.github.com/users/DaanHoogland/following{/other_user}","gists_url":"https://api.github.com/users/DaanHoogland/gists{/gist_id}","starred_url":"https://api.github.com/users/DaanHoogland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaanHoogland/subscriptions","organizations_url":"https://api.github.com/users/DaanHoogland/orgs","repos_url":"https://api.github.com/users/DaanHoogland/repos","events_url":"https://api.github.com/users/DaanHoogland/events{/privacy}","received_events_url":"https://api.github.com/users/DaanHoogland/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaanHoogland/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/DaanHoogland/cloudstack","forks_url":"https://api.github.com/repos/DaanHoogland/cloudstack/forks","keys_url":"https://api.github.com/repos/DaanHoogland/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaanHoogland/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaanHoogland/cloudstack/teams","hooks_url":"https://api.github.com/repos/DaanHoogland/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/DaanHoogland/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/DaanHoogland/cloudstack/events","assignees_url":"https://api.github.com/repos/DaanHoogland/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/DaanHoogland/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/DaanHoogland/cloudstack/tags","blobs_url":"https://api.github.com/repos/DaanHoogland/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaanHoogland/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaanHoogland/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaanHoogland/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaanHoogland/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/DaanHoogland/cloudstack/languages","stargazers_url":"https://api.github.com/repos/DaanHoogland/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/DaanHoogland/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/DaanHoogland/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/DaanHoogland/cloudstack/subscription","commits_url":"https://api.github.com/repos/DaanHoogland/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaanHoogland/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaanHoogland/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaanHoogland/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaanHoogland/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/DaanHoogland/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaanHoogland/cloudstack/merges","archive_url":"https://api.github.com/repos/DaanHoogland/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaanHoogland/cloudstack/downloads","issues_url":"https://api.github.com/repos/DaanHoogland/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/DaanHoogland/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/DaanHoogland/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/DaanHoogland/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaanHoogland/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/DaanHoogland/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/DaanHoogland/cloudstack/deployments","created_at":"2014-10-16T11:05:07Z","updated_at":"2016-01-17T19:05:42Z","pushed_at":"2016-05-24T09:11:09Z","git_url":"git://github.com/DaanHoogland/cloudstack.git","ssh_url":"git@github.com:DaanHoogland/cloudstack.git","clone_url":"https://github.com/DaanHoogland/cloudstack.git","svn_url":"https://github.com/DaanHoogland/cloudstack","homepage":null,"size":483427,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"570b676b1fd9bb932825e43f1844e147b1ddf7f6","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cloudstack/deployments","created_at":"2013-04-29T22:27:12Z","updated_at":"2016-05-23T12:54:08Z","pushed_at":"2016-05-24T12:34:15Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":554166,"stargazers_count":375,"watchers_count":375,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":489,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":149,"forks":489,"open_issues":149,"watchers":375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1530"},"html":{"href":"https://github.com/apache/cloudstack/pull/1530"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1530"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/1530/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1530/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/1530/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/760ed0532e2c1a602529f1ac8aca5db33a7b0276"}}}}
{"actor":{"display_login":"DaanHoogland"}}