{"push_id":1181061223,"size":2,"distinct_size":1,"ref":"refs/heads/develop","head":"e93a856d3e177aed015b02ca7a61cdd92c280783","before":"85d6eb008f95e729a49b08139e8da2de22b1ed8f","commits":[{"sha":"cc9829c6008afcb6b90dac24fe1c0fe3f74463ef","author":{"name":"Peter TB Brett","email":"6214814a67b9688a08e8c6dc7fa5dee076dddc8d@peter-b.co.uk"},"message":"[CID 127518] Only release MCObjectProxy with references\n\nThe assertion in `MCObjectProxy::Release()` was incorrect for two reasons.\r\n\r\n- It had no effect; `m_refcount` is unsigned and therefore `m_refcount >= 0` is always true\r\n- It asserted the wrong thing; if `m_refcount` was actually 0, then the following decrement would overflow, preventing a release\r\n- Nothing should ever try to release an `MCObjectProxy` with 0 references, because by definition the caller wouldn't own a reference to it\r\n\r\nThis patch strengthens the assertion to `m_refcount > 0`.\r\n\r\nCoverity-ID: 127518","distinct":false,"url":"https://api.github.com/repos/livecode/livecode/commits/cc9829c6008afcb6b90dac24fe1c0fe3f74463ef"},{"sha":"e93a856d3e177aed015b02ca7a61cdd92c280783","author":{"name":"livecodepanos","email":"c3db7a379f84f8fe67aa3040c7c70e9a972c365d@runrev.com"},"message":"Merge pull request #4208 from livecode/peter-b/cid-127518\n\n[CID 127518] Only release MCObjectProxy with references","distinct":true,"url":"https://api.github.com/repos/livecode/livecode/commits/e93a856d3e177aed015b02ca7a61cdd92c280783"}]}
{"actor":{"display_login":"livecodepanos"}}