{"action":"created","comment":{"url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/comments/73403828","id":73403828,"diff_hunk":"@@ -0,0 +1,85 @@\n+---\n+author: v4hn\n+comments: true\n+date: 2016-8-3 13:24:00+00:00\n+layout: page\n+slug: pullrequests\n+title: Pullrequests\n+---\n+\n+# Handling Contributions\n+\n+MoveIt is a huge project with multiple maintainers and many contributing users.\n+Thus, sometimes it becomes quite hard to keep track of all open requests and their current state.\n+To ease the process of getting your contribution merged into the project, the following provides a guideline for contributors as well as maintainers.\n+\n+## Contributor/User Side\n+\n+Your pull-requests might target any branch of a MoveIt repository that supports an [OSRF-supported ROS distribution](http://wiki.ros.org/Distributions).\n+The most important point about your request is that you verified it is working. Obviously, the best way to do that is with the setup/distribution you use.\n+\n+### keep requests clean and independent\n+\n+Different commits in a request should correspond to logical units that build up on each other. Feel free to rebase and force-push your feature-branch to address feedback.\n+If your request consists of multiple commits with titles like \"cleanup braces\" or \"address xyz's feedback\", the maintainer who merges the request will squash-merge and your changes will end up as a single commit in the project.\n+\n+Logically independent changes should be separated into multiple pull-requests. E.g. don't create a pull-request that changes plan execution and planning scene updates at the same time if there is no direct connection between the two changesets. If there *is* a connection that is not immediately obvious, please explain it in your request. \"I had to change it to get my setup to work\" is no connection. You might experience separate independent issues.\n+This makes it much more likely to get your changes merged soon, because if maintainers are unsure about one change, they can still merge the other one after review.\n+\n+### ping\n+\n+If you feel everyone forgot about your request, add a short note saying \"ping\" or \"Could someone please review/merge this?\" to the request. It might be that the item dropped of everyone's TODO list for no reason.\n+\n+### review requests and +1\n+\n+All feedback on existing pull-requests is welcome and appreciated. If you are familiar with the code someone requests to change, please step up and review their requests. The maintainer's time is often quite limited. This usually boils down to answering the following questions and provide feedback in the request:\n+\n+ - Does the patch do what the author claims it does?\n+ - Is it general enough to work with everyones use-case and not only the requestor's setup?\n+ - Does it address all edge-cases you are aware of?\n+ - If a new interface is introduced: Is this interface general enough for likely future modifications? Otherwise we might have to break API later on if we wish to add more useful features to the same module.\n+ - Is the change [ABI compatible](https://en.wikipedia.org/wiki/Application_binary_interface) or is there a good reason (e.g. safety) to break it?\n+ - Does the patch respect the [MoveIt! Code Style](code.html)?\n+\n+If (and only if) you answer all these questions with \"yes\", add a note saying \"+1\" to the request. This does **not** mean you like to have the claimed feature in MoveIt!. If it's not the first message you ever sent on a public channel concerning MoveIt, it means the next maintainer who reviews this request is free to merge it after review.","path":"documentation/contributing/pullrequests.markdown","position":44,"original_position":44,"commit_id":"d63e14413d3b12746cd0c9b7a94cbf9605669052","original_commit_id":"d63e14413d3b12746cd0c9b7a94cbf9605669052","user":{"login":"davetcoleman","id":561060,"avatar_url":"https://avatars.githubusercontent.com/u/561060?v=3","gravatar_id":"","url":"https://api.github.com/users/davetcoleman","html_url":"https://github.com/davetcoleman","followers_url":"https://api.github.com/users/davetcoleman/followers","following_url":"https://api.github.com/users/davetcoleman/following{/other_user}","gists_url":"https://api.github.com/users/davetcoleman/gists{/gist_id}","starred_url":"https://api.github.com/users/davetcoleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davetcoleman/subscriptions","organizations_url":"https://api.github.com/users/davetcoleman/orgs","repos_url":"https://api.github.com/users/davetcoleman/repos","events_url":"https://api.github.com/users/davetcoleman/events{/privacy}","received_events_url":"https://api.github.com/users/davetcoleman/received_events","type":"User","site_admin":false},"body":"This sentence confused me because it could also mean that:\r\n\r\n> This does **not** mean you like to have the claimed feature in MoveIt!.\r\n\r\nReword to:\r\n\r\n> Do **not** +1 if you are only confirming you would like the the claimed feature in MoveIt! - this may mislead maintainers to think it has been reviewed when it has not.","created_at":"2016-08-03T19:27:08Z","updated_at":"2016-08-03T19:27:08Z","html_url":"https://github.com/ros-planning/moveit.ros.org/pull/28#discussion_r73403828","pull_request_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/comments/73403828"},"html":{"href":"https://github.com/ros-planning/moveit.ros.org/pull/28#discussion_r73403828"},"pull_request":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28","id":79923496,"html_url":"https://github.com/ros-planning/moveit.ros.org/pull/28","diff_url":"https://github.com/ros-planning/moveit.ros.org/pull/28.diff","patch_url":"https://github.com/ros-planning/moveit.ros.org/pull/28.patch","issue_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues/28","number":28,"state":"open","locked":false,"title":"Add guidelines on handling contributions","user":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"body":"This is basically what most of us have in mind anyway,\nspelled out with a few polite suggestions on top.\n\nWaiting for feedback.","created_at":"2016-08-03T15:08:56Z","updated_at":"2016-08-03T19:27:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52feb64fd0325bcb057d828b1362a95e94c853bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28/commits","review_comments_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28/comments","review_comment_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues/28/comments","statuses_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/statuses/d63e14413d3b12746cd0c9b7a94cbf9605669052","head":{"label":"v4hn:on-handling-contributions","ref":"on-handling-contributions","sha":"d63e14413d3b12746cd0c9b7a94cbf9605669052","user":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"repo":{"id":64664939,"name":"moveit.ros.org","full_name":"v4hn/moveit.ros.org","owner":{"login":"v4hn","id":680358,"avatar_url":"https://avatars.githubusercontent.com/u/680358?v=3","gravatar_id":"","url":"https://api.github.com/users/v4hn","html_url":"https://github.com/v4hn","followers_url":"https://api.github.com/users/v4hn/followers","following_url":"https://api.github.com/users/v4hn/following{/other_user}","gists_url":"https://api.github.com/users/v4hn/gists{/gist_id}","starred_url":"https://api.github.com/users/v4hn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v4hn/subscriptions","organizations_url":"https://api.github.com/users/v4hn/orgs","repos_url":"https://api.github.com/users/v4hn/repos","events_url":"https://api.github.com/users/v4hn/events{/privacy}","received_events_url":"https://api.github.com/users/v4hn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/v4hn/moveit.ros.org","description":"This is the MoveIt! website","fork":true,"url":"https://api.github.com/repos/v4hn/moveit.ros.org","forks_url":"https://api.github.com/repos/v4hn/moveit.ros.org/forks","keys_url":"https://api.github.com/repos/v4hn/moveit.ros.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/v4hn/moveit.ros.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/v4hn/moveit.ros.org/teams","hooks_url":"https://api.github.com/repos/v4hn/moveit.ros.org/hooks","issue_events_url":"https://api.github.com/repos/v4hn/moveit.ros.org/issues/events{/number}","events_url":"https://api.github.com/repos/v4hn/moveit.ros.org/events","assignees_url":"https://api.github.com/repos/v4hn/moveit.ros.org/assignees{/user}","branches_url":"https://api.github.com/repos/v4hn/moveit.ros.org/branches{/branch}","tags_url":"https://api.github.com/repos/v4hn/moveit.ros.org/tags","blobs_url":"https://api.github.com/repos/v4hn/moveit.ros.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/v4hn/moveit.ros.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/v4hn/moveit.ros.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/v4hn/moveit.ros.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/v4hn/moveit.ros.org/statuses/{sha}","languages_url":"https://api.github.com/repos/v4hn/moveit.ros.org/languages","stargazers_url":"https://api.github.com/repos/v4hn/moveit.ros.org/stargazers","contributors_url":"https://api.github.com/repos/v4hn/moveit.ros.org/contributors","subscribers_url":"https://api.github.com/repos/v4hn/moveit.ros.org/subscribers","subscription_url":"https://api.github.com/repos/v4hn/moveit.ros.org/subscription","commits_url":"https://api.github.com/repos/v4hn/moveit.ros.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/v4hn/moveit.ros.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/v4hn/moveit.ros.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/v4hn/moveit.ros.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/v4hn/moveit.ros.org/contents/{+path}","compare_url":"https://api.github.com/repos/v4hn/moveit.ros.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/v4hn/moveit.ros.org/merges","archive_url":"https://api.github.com/repos/v4hn/moveit.ros.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/v4hn/moveit.ros.org/downloads","issues_url":"https://api.github.com/repos/v4hn/moveit.ros.org/issues{/number}","pulls_url":"https://api.github.com/repos/v4hn/moveit.ros.org/pulls{/number}","milestones_url":"https://api.github.com/repos/v4hn/moveit.ros.org/milestones{/number}","notifications_url":"https://api.github.com/repos/v4hn/moveit.ros.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/v4hn/moveit.ros.org/labels{/name}","releases_url":"https://api.github.com/repos/v4hn/moveit.ros.org/releases{/id}","deployments_url":"https://api.github.com/repos/v4hn/moveit.ros.org/deployments","created_at":"2016-08-01T12:27:58Z","updated_at":"2016-08-01T12:28:00Z","pushed_at":"2016-08-03T18:13:44Z","git_url":"git://github.com/v4hn/moveit.ros.org.git","ssh_url":"git@github.com:v4hn/moveit.ros.org.git","clone_url":"https://github.com/v4hn/moveit.ros.org.git","svn_url":"https://github.com/v4hn/moveit.ros.org","homepage":"http://moveit.ros.org","size":61429,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"ros-planning:gh-pages","ref":"gh-pages","sha":"0f69e0d1152cde689150fafdfde3a0d047be89e3","user":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"repo":{"id":42494159,"name":"moveit.ros.org","full_name":"ros-planning/moveit.ros.org","owner":{"login":"ros-planning","id":2328631,"avatar_url":"https://avatars.githubusercontent.com/u/2328631?v=3","gravatar_id":"","url":"https://api.github.com/users/ros-planning","html_url":"https://github.com/ros-planning","followers_url":"https://api.github.com/users/ros-planning/followers","following_url":"https://api.github.com/users/ros-planning/following{/other_user}","gists_url":"https://api.github.com/users/ros-planning/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-planning/subscriptions","organizations_url":"https://api.github.com/users/ros-planning/orgs","repos_url":"https://api.github.com/users/ros-planning/repos","events_url":"https://api.github.com/users/ros-planning/events{/privacy}","received_events_url":"https://api.github.com/users/ros-planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-planning/moveit.ros.org","description":"This is the MoveIt! website","fork":false,"url":"https://api.github.com/repos/ros-planning/moveit.ros.org","forks_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/forks","keys_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/teams","hooks_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/hooks","issue_events_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues/events{/number}","events_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/events","assignees_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/assignees{/user}","branches_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/branches{/branch}","tags_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/tags","blobs_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/languages","stargazers_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/stargazers","contributors_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/contributors","subscribers_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/subscribers","subscription_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/subscription","commits_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/contents/{+path}","compare_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/merges","archive_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/downloads","issues_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues{/number}","pulls_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/labels{/name}","releases_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/releases{/id}","deployments_url":"https://api.github.com/repos/ros-planning/moveit.ros.org/deployments","created_at":"2015-09-15T03:59:04Z","updated_at":"2016-08-01T00:39:36Z","pushed_at":"2016-08-03T19:02:10Z","git_url":"git://github.com/ros-planning/moveit.ros.org.git","ssh_url":"git@github.com:ros-planning/moveit.ros.org.git","clone_url":"https://github.com/ros-planning/moveit.ros.org.git","svn_url":"https://github.com/ros-planning/moveit.ros.org","homepage":"http://moveit.ros.org","size":61430,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":4,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28"},"html":{"href":"https://github.com/ros-planning/moveit.ros.org/pull/28"},"issue":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues/28"},"comments":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/ros-planning/moveit.ros.org/statuses/d63e14413d3b12746cd0c9b7a94cbf9605669052"}}}}
{"actor":{"display_login":"davetcoleman"}}