{"action":"created","comment":{"url":"https://api.github.com/repos/Igalia/snabb/pulls/comments/66244967","id":66244967,"diff_hunk":"@@ -52,7 +51,6 @@ function VirtioNetDriver:new(args)\n \n    if args.use_checksum then\n       self.transmit = self._transmit_checksum\n-      self.want_features = self.want_features + C.VIRTIO_NET_F_CSUM","path":"src/lib/virtio/net_driver.lua","position":27,"original_position":27,"commit_id":"69a29ad15935e80a88a8961ae1c1a215a74deaa6","original_commit_id":"69a29ad15935e80a88a8961ae1c1a215a74deaa6","user":{"login":"dpino","id":11567,"avatar_url":"https://avatars.githubusercontent.com/u/11567?v=3","gravatar_id":"","url":"https://api.github.com/users/dpino","html_url":"https://github.com/dpino","followers_url":"https://api.github.com/users/dpino/followers","following_url":"https://api.github.com/users/dpino/following{/other_user}","gists_url":"https://api.github.com/users/dpino/gists{/gist_id}","starred_url":"https://api.github.com/users/dpino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpino/subscriptions","organizations_url":"https://api.github.com/users/dpino/orgs","repos_url":"https://api.github.com/users/dpino/repos","events_url":"https://api.github.com/users/dpino/events{/privacy}","received_events_url":"https://api.github.com/users/dpino/received_events","type":"User","site_admin":false},"body":"If `use_checksum` needs `C.VIRTIO_NET_F_CSUM` and `C.VIRTIO_NET_F_CSUM` is now a minimum feature. Shouldn't transmit always be `transmit_checksum`, or C.VIRTIO_NET_F_CSUM shouldn't be in the minimum feature set?","created_at":"2016-06-08T12:25:23Z","updated_at":"2016-06-08T12:25:23Z","html_url":"https://github.com/Igalia/snabb/pull/356#discussion_r66244967","pull_request_url":"https://api.github.com/repos/Igalia/snabb/pulls/356","_links":{"self":{"href":"https://api.github.com/repos/Igalia/snabb/pulls/comments/66244967"},"html":{"href":"https://github.com/Igalia/snabb/pull/356#discussion_r66244967"},"pull_request":{"href":"https://api.github.com/repos/Igalia/snabb/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/Igalia/snabb/pulls/356","id":73031650,"html_url":"https://github.com/Igalia/snabb/pull/356","diff_url":"https://github.com/Igalia/snabb/pull/356.diff","patch_url":"https://github.com/Igalia/snabb/pull/356.patch","issue_url":"https://api.github.com/repos/Igalia/snabb/issues/356","number":356,"state":"open","locked":false,"title":"Virtio headroom","user":{"login":"wingo","id":1745903,"avatar_url":"https://avatars.githubusercontent.com/u/1745903?v=3","gravatar_id":"","url":"https://api.github.com/users/wingo","html_url":"https://github.com/wingo","followers_url":"https://api.github.com/users/wingo/followers","following_url":"https://api.github.com/users/wingo/following{/other_user}","gists_url":"https://api.github.com/users/wingo/gists{/gist_id}","starred_url":"https://api.github.com/users/wingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingo/subscriptions","organizations_url":"https://api.github.com/users/wingo/orgs","repos_url":"https://api.github.com/users/wingo/repos","events_url":"https://api.github.com/users/wingo/events{/privacy}","received_events_url":"https://api.github.com/users/wingo/received_events","type":"User","site_admin":false},"body":"This patch needs testing :)  It adds 32 bytes onto the beginning of `struct packet'.  Virtio-net can scribble in these bytes, avoiding the need for two virtq buffers, effectively making our queue size 256 instead of 128.  This was done before via indirect buffers, which maybe was not as cheap.\r\n\r\nI show around a 10% performance boost locally.  Needs #354 and #355 on the Snabb NFV side, to work well -- otherwise we run into various Snabb NFV bugs that prevent this branch from working at all.  Need to measure also on a bare-metal setup to see if the \"struct packet\" changes do anything bad.","created_at":"2016-06-08T11:43:25Z","updated_at":"2016-06-08T12:25:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16163f16290190eeb304dab4352400e2e8da2081","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Igalia/snabb/pulls/356/commits","review_comments_url":"https://api.github.com/repos/Igalia/snabb/pulls/356/comments","review_comment_url":"https://api.github.com/repos/Igalia/snabb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Igalia/snabb/issues/356/comments","statuses_url":"https://api.github.com/repos/Igalia/snabb/statuses/69a29ad15935e80a88a8961ae1c1a215a74deaa6","head":{"label":"Igalia:virtio-headroom","ref":"virtio-headroom","sha":"69a29ad15935e80a88a8961ae1c1a215a74deaa6","user":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"repo":{"id":34452469,"name":"snabb","full_name":"Igalia/snabb","owner":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Igalia/snabb","description":"Snabb Switch: Fast open source packet processing","fork":true,"url":"https://api.github.com/repos/Igalia/snabb","forks_url":"https://api.github.com/repos/Igalia/snabb/forks","keys_url":"https://api.github.com/repos/Igalia/snabb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igalia/snabb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igalia/snabb/teams","hooks_url":"https://api.github.com/repos/Igalia/snabb/hooks","issue_events_url":"https://api.github.com/repos/Igalia/snabb/issues/events{/number}","events_url":"https://api.github.com/repos/Igalia/snabb/events","assignees_url":"https://api.github.com/repos/Igalia/snabb/assignees{/user}","branches_url":"https://api.github.com/repos/Igalia/snabb/branches{/branch}","tags_url":"https://api.github.com/repos/Igalia/snabb/tags","blobs_url":"https://api.github.com/repos/Igalia/snabb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igalia/snabb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igalia/snabb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igalia/snabb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igalia/snabb/statuses/{sha}","languages_url":"https://api.github.com/repos/Igalia/snabb/languages","stargazers_url":"https://api.github.com/repos/Igalia/snabb/stargazers","contributors_url":"https://api.github.com/repos/Igalia/snabb/contributors","subscribers_url":"https://api.github.com/repos/Igalia/snabb/subscribers","subscription_url":"https://api.github.com/repos/Igalia/snabb/subscription","commits_url":"https://api.github.com/repos/Igalia/snabb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igalia/snabb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igalia/snabb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igalia/snabb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igalia/snabb/contents/{+path}","compare_url":"https://api.github.com/repos/Igalia/snabb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igalia/snabb/merges","archive_url":"https://api.github.com/repos/Igalia/snabb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igalia/snabb/downloads","issues_url":"https://api.github.com/repos/Igalia/snabb/issues{/number}","pulls_url":"https://api.github.com/repos/Igalia/snabb/pulls{/number}","milestones_url":"https://api.github.com/repos/Igalia/snabb/milestones{/number}","notifications_url":"https://api.github.com/repos/Igalia/snabb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igalia/snabb/labels{/name}","releases_url":"https://api.github.com/repos/Igalia/snabb/releases{/id}","deployments_url":"https://api.github.com/repos/Igalia/snabb/deployments","created_at":"2015-04-23T11:35:43Z","updated_at":"2016-05-31T10:54:03Z","pushed_at":"2016-06-08T11:43:25Z","git_url":"git://github.com/Igalia/snabb.git","ssh_url":"git@github.com:Igalia/snabb.git","clone_url":"https://github.com/Igalia/snabb.git","svn_url":"https://github.com/Igalia/snabb","homepage":"","size":10749,"stargazers_count":10,"watchers_count":10,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":10,"default_branch":"lwaftr"}},"base":{"label":"Igalia:lwaftr_starfruit","ref":"lwaftr_starfruit","sha":"2e9df8f9c9f6d15762f606486c29a3ab1487b91e","user":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"repo":{"id":34452469,"name":"snabb","full_name":"Igalia/snabb","owner":{"login":"Igalia","id":1576566,"avatar_url":"https://avatars.githubusercontent.com/u/1576566?v=3","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Igalia/snabb","description":"Snabb Switch: Fast open source packet processing","fork":true,"url":"https://api.github.com/repos/Igalia/snabb","forks_url":"https://api.github.com/repos/Igalia/snabb/forks","keys_url":"https://api.github.com/repos/Igalia/snabb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igalia/snabb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igalia/snabb/teams","hooks_url":"https://api.github.com/repos/Igalia/snabb/hooks","issue_events_url":"https://api.github.com/repos/Igalia/snabb/issues/events{/number}","events_url":"https://api.github.com/repos/Igalia/snabb/events","assignees_url":"https://api.github.com/repos/Igalia/snabb/assignees{/user}","branches_url":"https://api.github.com/repos/Igalia/snabb/branches{/branch}","tags_url":"https://api.github.com/repos/Igalia/snabb/tags","blobs_url":"https://api.github.com/repos/Igalia/snabb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igalia/snabb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igalia/snabb/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igalia/snabb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igalia/snabb/statuses/{sha}","languages_url":"https://api.github.com/repos/Igalia/snabb/languages","stargazers_url":"https://api.github.com/repos/Igalia/snabb/stargazers","contributors_url":"https://api.github.com/repos/Igalia/snabb/contributors","subscribers_url":"https://api.github.com/repos/Igalia/snabb/subscribers","subscription_url":"https://api.github.com/repos/Igalia/snabb/subscription","commits_url":"https://api.github.com/repos/Igalia/snabb/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igalia/snabb/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igalia/snabb/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igalia/snabb/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igalia/snabb/contents/{+path}","compare_url":"https://api.github.com/repos/Igalia/snabb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igalia/snabb/merges","archive_url":"https://api.github.com/repos/Igalia/snabb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igalia/snabb/downloads","issues_url":"https://api.github.com/repos/Igalia/snabb/issues{/number}","pulls_url":"https://api.github.com/repos/Igalia/snabb/pulls{/number}","milestones_url":"https://api.github.com/repos/Igalia/snabb/milestones{/number}","notifications_url":"https://api.github.com/repos/Igalia/snabb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igalia/snabb/labels{/name}","releases_url":"https://api.github.com/repos/Igalia/snabb/releases{/id}","deployments_url":"https://api.github.com/repos/Igalia/snabb/deployments","created_at":"2015-04-23T11:35:43Z","updated_at":"2016-05-31T10:54:03Z","pushed_at":"2016-06-08T11:43:25Z","git_url":"git://github.com/Igalia/snabb.git","ssh_url":"git@github.com:Igalia/snabb.git","clone_url":"https://github.com/Igalia/snabb.git","svn_url":"https://github.com/Igalia/snabb","homepage":"","size":10749,"stargazers_count":10,"watchers_count":10,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":29,"forks":3,"open_issues":29,"watchers":10,"default_branch":"lwaftr"}},"_links":{"self":{"href":"https://api.github.com/repos/Igalia/snabb/pulls/356"},"html":{"href":"https://github.com/Igalia/snabb/pull/356"},"issue":{"href":"https://api.github.com/repos/Igalia/snabb/issues/356"},"comments":{"href":"https://api.github.com/repos/Igalia/snabb/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/Igalia/snabb/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/Igalia/snabb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Igalia/snabb/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/Igalia/snabb/statuses/69a29ad15935e80a88a8961ae1c1a215a74deaa6"}}}}
{"actor":{"display_login":"dpino"}}