{"action":"created","comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/70560150","id":70560150,"diff_hunk":"@@ -267,6 +272,62 @@ sub check_genesis_file {\n     return $rst_f;\n }\n \n+sub check_node_ip {\n+    my $currentnode;\n+    my $ip_def;\n+    my $ip_net;\n+    my @node_info = `lsdef $noderange -i ip 2>&1`;","path":"xCAT-probe/subcmds/discovery","position":20,"original_position":20,"commit_id":"2227b880eee10fea0662125d289193543a4b64cb","original_commit_id":"2227b880eee10fea0662125d289193543a4b64cb","user":{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},"body":"If use below command, maybe code logic of line283-297 will be easier.\r\n\r\n    lsdef $noderange -i ip -c 2>&1\r\n","created_at":"2016-07-13T03:32:21Z","updated_at":"2016-07-13T03:32:21Z","html_url":"https://github.com/xcat2/xcat-core/pull/1512#discussion_r70560150","pull_request_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512","_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/70560150"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/1512#discussion_r70560150"},"pull_request":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512"}}},"pull_request":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512","id":76904519,"html_url":"https://github.com/xcat2/xcat-core/pull/1512","diff_url":"https://github.com/xcat2/xcat-core/pull/1512.diff","patch_url":"https://github.com/xcat2/xcat-core/pull/1512.patch","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/1512","number":1512,"state":"open","locked":false,"title":"Fix xcatprobe issue, discovery and osdeploy","user":{"login":"xuweibj","id":15208204,"avatar_url":"https://avatars.githubusercontent.com/u/15208204?v=3","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"body":"1. issue #1508 , check if rc label when check genesis packages.\r\n2. issue #1507 , modified dynamic range check.\r\n3. issue #1487 , if log in /var/log/message has tag \"xcat\", using \"handle_cluster_msg\" subroutine.\r\n4. issue #1479 , check whether the status was installing.\r\nWhen receive the status is booted, check the status in hash whether installing. If so, it completes os provision. If not, it did not do os provision.","created_at":"2016-07-11T06:22:29Z","updated_at":"2016-07-13T03:32:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"187d05ea62afcf22c8982029d7bc2b0bad8c00a0","assignee":{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},"assignees":[{"login":"hu-weihua","id":7370626,"avatar_url":"https://avatars.githubusercontent.com/u/7370626?v=3","gravatar_id":"","url":"https://api.github.com/users/hu-weihua","html_url":"https://github.com/hu-weihua","followers_url":"https://api.github.com/users/hu-weihua/followers","following_url":"https://api.github.com/users/hu-weihua/following{/other_user}","gists_url":"https://api.github.com/users/hu-weihua/gists{/gist_id}","starred_url":"https://api.github.com/users/hu-weihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hu-weihua/subscriptions","organizations_url":"https://api.github.com/users/hu-weihua/orgs","repos_url":"https://api.github.com/users/hu-weihua/repos","events_url":"https://api.github.com/users/hu-weihua/events{/privacy}","received_events_url":"https://api.github.com/users/hu-weihua/received_events","type":"User","site_admin":false},{"login":"daniceexi","id":10385985,"avatar_url":"https://avatars.githubusercontent.com/u/10385985?v=3","gravatar_id":"","url":"https://api.github.com/users/daniceexi","html_url":"https://github.com/daniceexi","followers_url":"https://api.github.com/users/daniceexi/followers","following_url":"https://api.github.com/users/daniceexi/following{/other_user}","gists_url":"https://api.github.com/users/daniceexi/gists{/gist_id}","starred_url":"https://api.github.com/users/daniceexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniceexi/subscriptions","organizations_url":"https://api.github.com/users/daniceexi/orgs","repos_url":"https://api.github.com/users/daniceexi/repos","events_url":"https://api.github.com/users/daniceexi/events{/privacy}","received_events_url":"https://api.github.com/users/daniceexi/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/17","html_url":"https://github.com/xcat2/xcat-core/milestones/2.12.2","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/17/labels","id":1854029,"number":17,"title":"2.12.2","description":"","creator":{"login":"daniceexi","id":10385985,"avatar_url":"https://avatars.githubusercontent.com/u/10385985?v=3","gravatar_id":"","url":"https://api.github.com/users/daniceexi","html_url":"https://github.com/daniceexi","followers_url":"https://api.github.com/users/daniceexi/followers","following_url":"https://api.github.com/users/daniceexi/following{/other_user}","gists_url":"https://api.github.com/users/daniceexi/gists{/gist_id}","starred_url":"https://api.github.com/users/daniceexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniceexi/subscriptions","organizations_url":"https://api.github.com/users/daniceexi/orgs","repos_url":"https://api.github.com/users/daniceexi/repos","events_url":"https://api.github.com/users/daniceexi/events{/privacy}","received_events_url":"https://api.github.com/users/daniceexi/received_events","type":"User","site_admin":false},"open_issues":73,"closed_issues":6,"state":"open","created_at":"2016-06-29T01:21:43Z","updated_at":"2016-07-13T02:51:44Z","due_on":"2016-08-26T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512/commits","review_comments_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512/comments","review_comment_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/1512/comments","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/2227b880eee10fea0662125d289193543a4b64cb","head":{"label":"xuweibj:myprobe","ref":"myprobe","sha":"2227b880eee10fea0662125d289193543a4b64cb","user":{"login":"xuweibj","id":15208204,"avatar_url":"https://avatars.githubusercontent.com/u/15208204?v=3","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"repo":{"id":45444036,"name":"xcat-core","full_name":"xuweibj/xcat-core","owner":{"login":"xuweibj","id":15208204,"avatar_url":"https://avatars.githubusercontent.com/u/15208204?v=3","gravatar_id":"","url":"https://api.github.com/users/xuweibj","html_url":"https://github.com/xuweibj","followers_url":"https://api.github.com/users/xuweibj/followers","following_url":"https://api.github.com/users/xuweibj/following{/other_user}","gists_url":"https://api.github.com/users/xuweibj/gists{/gist_id}","starred_url":"https://api.github.com/users/xuweibj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuweibj/subscriptions","organizations_url":"https://api.github.com/users/xuweibj/orgs","repos_url":"https://api.github.com/users/xuweibj/repos","events_url":"https://api.github.com/users/xuweibj/events{/privacy}","received_events_url":"https://api.github.com/users/xuweibj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuweibj/xcat-core","description":"Code repo for xCAT core packages","fork":true,"url":"https://api.github.com/repos/xuweibj/xcat-core","forks_url":"https://api.github.com/repos/xuweibj/xcat-core/forks","keys_url":"https://api.github.com/repos/xuweibj/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuweibj/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuweibj/xcat-core/teams","hooks_url":"https://api.github.com/repos/xuweibj/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xuweibj/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xuweibj/xcat-core/events","assignees_url":"https://api.github.com/repos/xuweibj/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xuweibj/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xuweibj/xcat-core/tags","blobs_url":"https://api.github.com/repos/xuweibj/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuweibj/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuweibj/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuweibj/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuweibj/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xuweibj/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xuweibj/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xuweibj/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xuweibj/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xuweibj/xcat-core/subscription","commits_url":"https://api.github.com/repos/xuweibj/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuweibj/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuweibj/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuweibj/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuweibj/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xuweibj/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuweibj/xcat-core/merges","archive_url":"https://api.github.com/repos/xuweibj/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuweibj/xcat-core/downloads","issues_url":"https://api.github.com/repos/xuweibj/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xuweibj/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xuweibj/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xuweibj/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuweibj/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xuweibj/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xuweibj/xcat-core/deployments","created_at":"2015-11-03T05:30:52Z","updated_at":"2016-01-21T01:11:56Z","pushed_at":"2016-07-11T08:33:53Z","git_url":"git://github.com/xuweibj/xcat-core.git","ssh_url":"git@github.com:xuweibj/xcat-core.git","clone_url":"https://github.com/xuweibj/xcat-core.git","svn_url":"https://github.com/xuweibj/xcat-core","homepage":null,"size":185504,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcat2:master","ref":"master","sha":"72571f4444c67c1049b714685f49b0c0a224e77e","user":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"repo":{"id":27747508,"name":"xcat-core","full_name":"xcat2/xcat-core","owner":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcat2/xcat-core","description":"Code repo for xCAT core packages","fork":false,"url":"https://api.github.com/repos/xcat2/xcat-core","forks_url":"https://api.github.com/repos/xcat2/xcat-core/forks","keys_url":"https://api.github.com/repos/xcat2/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcat2/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcat2/xcat-core/teams","hooks_url":"https://api.github.com/repos/xcat2/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xcat2/xcat-core/events","assignees_url":"https://api.github.com/repos/xcat2/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xcat2/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xcat2/xcat-core/tags","blobs_url":"https://api.github.com/repos/xcat2/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcat2/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcat2/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcat2/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xcat2/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xcat2/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xcat2/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xcat2/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xcat2/xcat-core/subscription","commits_url":"https://api.github.com/repos/xcat2/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcat2/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcat2/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xcat2/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcat2/xcat-core/merges","archive_url":"https://api.github.com/repos/xcat2/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcat2/xcat-core/downloads","issues_url":"https://api.github.com/repos/xcat2/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xcat2/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xcat2/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xcat2/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcat2/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xcat2/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xcat2/xcat-core/deployments","created_at":"2014-12-09T03:21:50Z","updated_at":"2016-07-06T10:00:10Z","pushed_at":"2016-07-13T02:51:44Z","git_url":"git://github.com/xcat2/xcat-core.git","ssh_url":"git@github.com:xcat2/xcat-core.git","clone_url":"https://github.com/xcat2/xcat-core.git","svn_url":"https://github.com/xcat2/xcat-core","homepage":null,"size":186182,"stargazers_count":46,"watchers_count":46,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":145,"forks":57,"open_issues":145,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/1512"},"issue":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/1512"},"comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/1512/comments"},"review_comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512/comments"},"review_comment":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/1512/commits"},"statuses":{"href":"https://api.github.com/repos/xcat2/xcat-core/statuses/2227b880eee10fea0662125d289193543a4b64cb"}}}}
{"actor":{"display_login":"hu-weihua"}}