{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/83926196","pull_request_review_id":4736708,"id":83926196,"diff_hunk":"@@ -779,18 +779,20 @@ tests config = do\n                 uid = componentUnitId (targetCLBI target)\n                 dir = libdir (absoluteComponentInstallDirs pkg_descr lbi uid\n                               NoCopyDest)\n+                dyndir = dynlibdir (absoluteComponentInstallDirs pkg_descr lbi\n+                                    uid NoCopyDest)","path":"Cabal/tests/PackageTests/Tests.hs","position":14,"original_position":14,"commit_id":"389039a31cdb6847945a0de137dbe65634125639","original_commit_id":"389039a31cdb6847945a0de137dbe65634125639","user":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"body":"we should share this better, e.g.\r\n```\r\nInstallDirs{libdir,dynlibdir} = absoluteComponentInstallDirs pkg_descr lbi uid NoCopyDest\r\n```","created_at":"2016-10-18T18:58:22Z","updated_at":"2016-10-18T19:02:30Z","html_url":"https://github.com/haskell/cabal/pull/3979#discussion_r83926196","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/3979","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/83926196"},"html":{"href":"https://github.com/haskell/cabal/pull/3979#discussion_r83926196"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3979"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/3979","id":89195627,"html_url":"https://github.com/haskell/cabal/pull/3979","diff_url":"https://github.com/haskell/cabal/pull/3979.diff","patch_url":"https://github.com/haskell/cabal/pull/3979.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/3979","number":3979,"state":"open","locked":false,"title":"Add `--dynlibdir`","user":{"login":"christiaanb","id":93169,"avatar_url":"https://avatars.githubusercontent.com/u/93169?v=3","gravatar_id":"","url":"https://api.github.com/users/christiaanb","html_url":"https://github.com/christiaanb","followers_url":"https://api.github.com/users/christiaanb/followers","following_url":"https://api.github.com/users/christiaanb/following{/other_user}","gists_url":"https://api.github.com/users/christiaanb/gists{/gist_id}","starred_url":"https://api.github.com/users/christiaanb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiaanb/subscriptions","organizations_url":"https://api.github.com/users/christiaanb/orgs","repos_url":"https://api.github.com/users/christiaanb/repos","events_url":"https://api.github.com/users/christiaanb/events{/privacy}","received_events_url":"https://api.github.com/users/christiaanb/received_events","type":"User","site_admin":false},"body":"`--dynlibdir` indicates the directory in which dynamic libraries\r\nare installed. By default this setting is equal to:\r\n\r\n`$libdir/$abi`\r\n\r\nThe static libraries will still end up in:\r\n\r\n`$libdir/$libsubdir`\r\n\r\nWith `$libsubdir/$abi` as the default directory for dynamic\r\nlibraries, dynamic libraries will by default end up in a\r\nsingle shared directory (per package database). This has the\r\npotential to reduce start-up times for dynamically linked\r\nexecutable as only one RPATH per package database will be\r\nneeded.","created_at":"2016-10-13T12:51:21Z","updated_at":"2016-10-18T19:02:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2e5f884a9249339105aacd5ad63c80e395d7819","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/3979/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/3979/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/3979/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/389039a31cdb6847945a0de137dbe65634125639","head":{"label":"christiaanb:dynlibdir","ref":"dynlibdir","sha":"389039a31cdb6847945a0de137dbe65634125639","user":{"login":"christiaanb","id":93169,"avatar_url":"https://avatars.githubusercontent.com/u/93169?v=3","gravatar_id":"","url":"https://api.github.com/users/christiaanb","html_url":"https://github.com/christiaanb","followers_url":"https://api.github.com/users/christiaanb/followers","following_url":"https://api.github.com/users/christiaanb/following{/other_user}","gists_url":"https://api.github.com/users/christiaanb/gists{/gist_id}","starred_url":"https://api.github.com/users/christiaanb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiaanb/subscriptions","organizations_url":"https://api.github.com/users/christiaanb/orgs","repos_url":"https://api.github.com/users/christiaanb/repos","events_url":"https://api.github.com/users/christiaanb/events{/privacy}","received_events_url":"https://api.github.com/users/christiaanb/received_events","type":"User","site_admin":false},"repo":{"id":26811362,"name":"cabal","full_name":"christiaanb/cabal","owner":{"login":"christiaanb","id":93169,"avatar_url":"https://avatars.githubusercontent.com/u/93169?v=3","gravatar_id":"","url":"https://api.github.com/users/christiaanb","html_url":"https://github.com/christiaanb","followers_url":"https://api.github.com/users/christiaanb/followers","following_url":"https://api.github.com/users/christiaanb/following{/other_user}","gists_url":"https://api.github.com/users/christiaanb/gists{/gist_id}","starred_url":"https://api.github.com/users/christiaanb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christiaanb/subscriptions","organizations_url":"https://api.github.com/users/christiaanb/orgs","repos_url":"https://api.github.com/users/christiaanb/repos","events_url":"https://api.github.com/users/christiaanb/events{/privacy}","received_events_url":"https://api.github.com/users/christiaanb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christiaanb/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/christiaanb/cabal","forks_url":"https://api.github.com/repos/christiaanb/cabal/forks","keys_url":"https://api.github.com/repos/christiaanb/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christiaanb/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christiaanb/cabal/teams","hooks_url":"https://api.github.com/repos/christiaanb/cabal/hooks","issue_events_url":"https://api.github.com/repos/christiaanb/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/christiaanb/cabal/events","assignees_url":"https://api.github.com/repos/christiaanb/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/christiaanb/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/christiaanb/cabal/tags","blobs_url":"https://api.github.com/repos/christiaanb/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christiaanb/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christiaanb/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/christiaanb/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christiaanb/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/christiaanb/cabal/languages","stargazers_url":"https://api.github.com/repos/christiaanb/cabal/stargazers","contributors_url":"https://api.github.com/repos/christiaanb/cabal/contributors","subscribers_url":"https://api.github.com/repos/christiaanb/cabal/subscribers","subscription_url":"https://api.github.com/repos/christiaanb/cabal/subscription","commits_url":"https://api.github.com/repos/christiaanb/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/christiaanb/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/christiaanb/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/christiaanb/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/christiaanb/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/christiaanb/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christiaanb/cabal/merges","archive_url":"https://api.github.com/repos/christiaanb/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christiaanb/cabal/downloads","issues_url":"https://api.github.com/repos/christiaanb/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/christiaanb/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/christiaanb/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/christiaanb/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christiaanb/cabal/labels{/name}","releases_url":"https://api.github.com/repos/christiaanb/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/christiaanb/cabal/deployments","created_at":"2014-11-18T13:51:46Z","updated_at":"2015-03-16T08:42:46Z","pushed_at":"2016-10-16T17:20:59Z","git_url":"git://github.com/christiaanb/cabal.git","ssh_url":"git@github.com:christiaanb/cabal.git","clone_url":"https://github.com/christiaanb/cabal.git","svn_url":"https://github.com/christiaanb/cabal","homepage":"http://haskell.org/cabal","size":24279,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"3ece1013df8ba4c9719d2183afd2b03c4bddf851","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-10-14T14:39:29Z","pushed_at":"2016-10-18T19:01:34Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":33983,"stargazers_count":652,"watchers_count":652,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":351,"mirror_url":null,"open_issues_count":751,"forks":351,"open_issues":751,"watchers":652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3979"},"html":{"href":"https://github.com/haskell/cabal/pull/3979"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/3979"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/3979/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3979/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3979/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/389039a31cdb6847945a0de137dbe65634125639"}}}}
{"actor":{"display_login":"dcoutts"}}