{"action":"created","issue":{"url":"https://api.github.com/repos/choderalab/openpathsampling/issues/451","repository_url":"https://api.github.com/repos/choderalab/openpathsampling","labels_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/451/labels{/name}","comments_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/451/comments","events_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/451/events","html_url":"https://github.com/choderalab/openpathsampling/pull/451","id":142699250,"number":451,"title":"More cleanup of Single Trajectory Analysis","user":{"login":"dwhswenson","id":8178546,"avatar_url":"https://avatars.githubusercontent.com/u/8178546?v=3","gravatar_id":"","url":"https://api.github.com/users/dwhswenson","html_url":"https://github.com/dwhswenson","followers_url":"https://api.github.com/users/dwhswenson/followers","following_url":"https://api.github.com/users/dwhswenson/following{/other_user}","gists_url":"https://api.github.com/users/dwhswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/dwhswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwhswenson/subscriptions","organizations_url":"https://api.github.com/users/dwhswenson/orgs","repos_url":"https://api.github.com/users/dwhswenson/repos","events_url":"https://api.github.com/users/dwhswenson/events{/privacy}","received_events_url":"https://api.github.com/users/dwhswenson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2016-03-22T16:12:13Z","updated_at":"2016-03-23T10:11:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/choderalab/openpathsampling/pulls/451","html_url":"https://github.com/choderalab/openpathsampling/pull/451","diff_url":"https://github.com/choderalab/openpathsampling/pull/451.diff","patch_url":"https://github.com/choderalab/openpathsampling/pull/451.patch"},"body":"Just a few more things to make `SingleTrajectoryAnalysis` easier to use in practice.\r\n\r\n- [x] Create results object which has a few useful extra routines. Currently, we have a bunch of functions that variously return lists of trajectory segments, the lengths of those segments, or the time duration of those segments. All of this gets grouped into one class, although the old versions still work (they just call the specific class)\r\n- [x] Switch from directly storing instance variables to returning the results (except for the `analyze` function, which runs everything). This makes it easier to use this stuff in interactive analysis.\r\n\r\nQuestion: Renaming? Neither of the names of classes in `single_trajectory_analysis.py` are very good (`SingleTrajectoryAnalysis` and `TrajectorySegmentContainer`), but I don’t have any better names either. The functionality is definitely useful, though. "},"comment":{"url":"https://api.github.com/repos/choderalab/openpathsampling/issues/comments/200281242","html_url":"https://github.com/choderalab/openpathsampling/pull/451#issuecomment-200281242","issue_url":"https://api.github.com/repos/choderalab/openpathsampling/issues/451","id":200281242,"user":{"login":"jhprinz","id":5091934,"avatar_url":"https://avatars.githubusercontent.com/u/5091934?v=3","gravatar_id":"","url":"https://api.github.com/users/jhprinz","html_url":"https://github.com/jhprinz","followers_url":"https://api.github.com/users/jhprinz/followers","following_url":"https://api.github.com/users/jhprinz/following{/other_user}","gists_url":"https://api.github.com/users/jhprinz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhprinz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhprinz/subscriptions","organizations_url":"https://api.github.com/users/jhprinz/orgs","repos_url":"https://api.github.com/users/jhprinz/repos","events_url":"https://api.github.com/users/jhprinz/events{/privacy}","received_events_url":"https://api.github.com/users/jhprinz/received_events","type":"User","site_admin":false},"created_at":"2016-03-23T10:11:03Z","updated_at":"2016-03-23T10:11:03Z","body":"Looks good.\r\n\r\nMaybe we should not worry about the naming too much for now. We can later to one overhaul of renaming before 1.0 release..."}}