{"action":"created","issue":{"url":"https://api.github.com/repos/fail2ban/fail2ban/issues/1515","repository_url":"https://api.github.com/repos/fail2ban/fail2ban","labels_url":"https://api.github.com/repos/fail2ban/fail2ban/issues/1515/labels{/name}","comments_url":"https://api.github.com/repos/fail2ban/fail2ban/issues/1515/comments","events_url":"https://api.github.com/repos/fail2ban/fail2ban/issues/1515/events","html_url":"https://github.com/fail2ban/fail2ban/pull/1515","id":171638940,"number":1515,"title":" 0.10 fix sporadically test case assertion error in MonitorJournalFailures","user":{"login":"sebres","id":3769657,"avatar_url":"https://avatars.githubusercontent.com/u/3769657?v=3","gravatar_id":"","url":"https://api.github.com/users/sebres","html_url":"https://github.com/sebres","followers_url":"https://api.github.com/users/sebres/followers","following_url":"https://api.github.com/users/sebres/following{/other_user}","gists_url":"https://api.github.com/users/sebres/gists{/gist_id}","starred_url":"https://api.github.com/users/sebres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebres/subscriptions","organizations_url":"https://api.github.com/users/sebres/orgs","repos_url":"https://api.github.com/users/sebres/repos","events_url":"https://api.github.com/users/sebres/events{/privacy}","received_events_url":"https://api.github.com/users/sebres/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fail2ban/fail2ban/milestones/14","html_url":"https://github.com/fail2ban/fail2ban/milestones/0.10.0","labels_url":"https://api.github.com/repos/fail2ban/fail2ban/milestones/14/labels","id":1759181,"number":14,"title":"0.10.0","description":"Major functionality and performance boosts: semantic times, IPv6 support etc","creator":{"login":"yarikoptic","id":39889,"avatar_url":"https://avatars.githubusercontent.com/u/39889?v=3","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":17,"state":"open","created_at":"2016-05-11T01:19:51Z","updated_at":"2016-08-17T11:52:30Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2016-08-17T11:52:30Z","updated_at":"2016-08-17T13:55:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fail2ban/fail2ban/pulls/1515","html_url":"https://github.com/fail2ban/fail2ban/pull/1515","diff_url":"https://github.com/fail2ban/fail2ban/pull/1515.diff","patch_url":"https://github.com/fail2ban/fail2ban/pull/1515.patch"},"body":"- fixed sporadically test cases assertion error \"AssertionError: 3 != 4\" (see below), occurred because of multi-threaded execution, if getFailTicket() called after 3th failure (before 4th failure was monitored), so we will wait now in new method waitFailTotal (instead of isFilled) for expected failure count...\r\n```\r\nFAIL: MonitorJournalFailures<class 'fail2ban.server.filtersystemd.FilterSystemd'>...\r\n----------------------------------------------------------------------\r\nTraceback (most recent call last):\r\n  File \"./fail2ban/tests/filtertestcase.py\", line 1015, in test_delJournalMatch\r\n    self.assert_correct_ban(\"193.168.0.128\", 4)\r\n  File \"./fail2ban/tests/filtertestcase.py\", line 960, in assert_correct_ban\r\n    self.assertEqual(attempts, test_attempts)\r\nAssertionError: 3 != 4\r\n```\r\n- some duplicate code united (CommonMonitorTestCase, see second commit)"},"comment":{"url":"https://api.github.com/repos/fail2ban/fail2ban/issues/comments/240418610","html_url":"https://github.com/fail2ban/fail2ban/pull/1515#issuecomment-240418610","issue_url":"https://api.github.com/repos/fail2ban/fail2ban/issues/1515","id":240418610,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2016-08-17T13:55:49Z","updated_at":"2016-08-17T13:55:49Z","body":"## [Current coverage](https://codecov.io/gh/fail2ban/fail2ban/pull/1515?src=pr) is 92.13% (diff: 100%)\n> Merging [#1515](https://codecov.io/gh/fail2ban/fail2ban/pull/1515?src=pr) into [0.10](https://codecov.io/gh/fail2ban/fail2ban/branch/0.10?src=pr) will decrease coverage by **0.05%**\n\n\n```diff\n@@               0.10      #1515   diff @@\n==========================================\n  Files            76         76          \n  Lines         10347      10355     +8   \n  Methods           0          0          \n  Messages          0          0          \n  Branches       1576       1577     +1   \n==========================================\n+ Hits           9539       9541     +2   \n- Misses          535        543     +8   \n+ Partials        273        271     -2   \n```\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [e3f4ea7...f7a9ad4](https://codecov.io/gh/fail2ban/fail2ban/compare/e3f4ea7284113be25ac2040487ffd7ba9d5604e3...f7a9ad487a61b0f8aef60a474c069527c9265953?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}