{"action":"created","issue":{"url":"https://api.github.com/repos/neighborland/resque_solo/issues/10","repository_url":"https://api.github.com/repos/neighborland/resque_solo","labels_url":"https://api.github.com/repos/neighborland/resque_solo/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/neighborland/resque_solo/issues/10/comments","events_url":"https://api.github.com/repos/neighborland/resque_solo/issues/10/events","html_url":"https://github.com/neighborland/resque_solo/pull/10","id":189295746,"number":10,"title":"Use after hook","user":{"login":"brucek","id":82603,"avatar_url":"https://avatars.githubusercontent.com/u/82603?v=3","gravatar_id":"","url":"https://api.github.com/users/brucek","html_url":"https://github.com/brucek","followers_url":"https://api.github.com/users/brucek/followers","following_url":"https://api.github.com/users/brucek/following{/other_user}","gists_url":"https://api.github.com/users/brucek/gists{/gist_id}","starred_url":"https://api.github.com/users/brucek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brucek/subscriptions","organizations_url":"https://api.github.com/users/brucek/orgs","repos_url":"https://api.github.com/users/brucek/repos","events_url":"https://api.github.com/users/brucek/events{/privacy}","received_events_url":"https://api.github.com/users/brucek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-15T04:12:56Z","updated_at":"2016-11-28T21:47:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neighborland/resque_solo/pulls/10","html_url":"https://github.com/neighborland/resque_solo/pull/10","diff_url":"https://github.com/neighborland/resque_solo/pull/10.diff","patch_url":"https://github.com/neighborland/resque_solo/pull/10.patch"},"body":"Gets rid of most of the monkeypatching in favor of before and around hooks, as per https://github.com/neighborland/resque_solo/issues/7\r\n\r\nNote that resque hooks don't give the queue that the job was pulled from, so there's no way to ensure a unique job across multiple queues, but it didn't look like that was in scope as far as I could see from the existing tests.\r\n"},"comment":{"url":"https://api.github.com/repos/neighborland/resque_solo/issues/comments/263404795","html_url":"https://github.com/neighborland/resque_solo/pull/10#issuecomment-263404795","issue_url":"https://api.github.com/repos/neighborland/resque_solo/issues/10","id":263404795,"user":{"login":"bmckeough","id":73149,"avatar_url":"https://avatars.githubusercontent.com/u/73149?v=3","gravatar_id":"","url":"https://api.github.com/users/bmckeough","html_url":"https://github.com/bmckeough","followers_url":"https://api.github.com/users/bmckeough/followers","following_url":"https://api.github.com/users/bmckeough/following{/other_user}","gists_url":"https://api.github.com/users/bmckeough/gists{/gist_id}","starred_url":"https://api.github.com/users/bmckeough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmckeough/subscriptions","organizations_url":"https://api.github.com/users/bmckeough/orgs","repos_url":"https://api.github.com/users/bmckeough/repos","events_url":"https://api.github.com/users/bmckeough/events{/privacy}","received_events_url":"https://api.github.com/users/bmckeough/received_events","type":"User","site_admin":false},"created_at":"2016-11-28T21:47:34Z","updated_at":"2016-11-28T21:47:34Z","body":"One implication of this change is that a job could be marked enqueued when it wasn't actually enqueued because a different before_enqueue hook returned false.\r\n\r\nI'll try to provide a test case to demonstrate, but can express it more quickly in a written example.\r\n\r\nGiven a job class that includes Resque::Plugins::UniqueJob and also implements a before_enqueue hook that always returns false, before_enqueue_solo_job will mark the job enqueued even though it wasn't actually created."}}
{"actor":{"display_login":"bmckeough"}}