{"action":"closed","number":795,"pull_request":{"url":"https://api.github.com/repos/nfephp-org/nfephp/pulls/795","id":65363695,"html_url":"https://github.com/nfephp-org/nfephp/pull/795","diff_url":"https://github.com/nfephp-org/nfephp/pull/795.diff","patch_url":"https://github.com/nfephp-org/nfephp/pull/795.patch","issue_url":"https://api.github.com/repos/nfephp-org/nfephp/issues/795","number":795,"state":"closed","locked":false,"title":"Correção de cálculo de altura e quebra de página","user":{"login":"philgruneich","id":3649691,"avatar_url":"https://avatars.githubusercontent.com/u/3649691?v=3","gravatar_id":"","url":"https://api.github.com/users/philgruneich","html_url":"https://github.com/philgruneich","followers_url":"https://api.github.com/users/philgruneich/followers","following_url":"https://api.github.com/users/philgruneich/following{/other_user}","gists_url":"https://api.github.com/users/philgruneich/gists{/gist_id}","starred_url":"https://api.github.com/users/philgruneich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philgruneich/subscriptions","organizations_url":"https://api.github.com/users/philgruneich/orgs","repos_url":"https://api.github.com/users/philgruneich/repos","events_url":"https://api.github.com/users/philgruneich/events{/privacy}","received_events_url":"https://api.github.com/users/philgruneich/received_events","type":"User","site_admin":false},"body":"No loop da linha 698, o total da altura era minimamente maior que o disponível, em nosso caso, 57.45 para 57 disponíveis. Isso criava uma nova página, todavia, o problema era que nesta segunda página os itens eram uma repetição dos itens da primeira página, ou seja, duplicavam.\r\n\r\nAnalisando o código chegamos a diversos valores que eram relacionados, mas absolutos e que definiam a altura do cabeçalho da tabela de produtos, o qual no código para a segunda página era 7, enquanto iniciava como 4 e na função que gerava os itens também era 4 (linha 2421).\r\n\r\nEsta alteração regulariza todos e inclui o valor como parâmetro da função. Regularizando todos os itens com altura usada de 7 ao invés de 4 criou a paginação correta em nossos testes.","created_at":"2016-04-05T19:50:59Z","updated_at":"2016-04-05T19:58:53Z","closed_at":"2016-04-05T19:58:53Z","merged_at":"2016-04-05T19:58:53Z","merge_commit_sha":"498d7f0a5a5d7c567329c6141da89329a8f2bb82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nfephp-org/nfephp/pulls/795/commits","review_comments_url":"https://api.github.com/repos/nfephp-org/nfephp/pulls/795/comments","review_comment_url":"https://api.github.com/repos/nfephp-org/nfephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nfephp-org/nfephp/issues/795/comments","statuses_url":"https://api.github.com/repos/nfephp-org/nfephp/statuses/a5cb5c5d084f08024b1dcfcf92d5b3976a4da8e9","head":{"label":"philgruneich:master","ref":"master","sha":"a5cb5c5d084f08024b1dcfcf92d5b3976a4da8e9","user":{"login":"philgruneich","id":3649691,"avatar_url":"https://avatars.githubusercontent.com/u/3649691?v=3","gravatar_id":"","url":"https://api.github.com/users/philgruneich","html_url":"https://github.com/philgruneich","followers_url":"https://api.github.com/users/philgruneich/followers","following_url":"https://api.github.com/users/philgruneich/following{/other_user}","gists_url":"https://api.github.com/users/philgruneich/gists{/gist_id}","starred_url":"https://api.github.com/users/philgruneich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philgruneich/subscriptions","organizations_url":"https://api.github.com/users/philgruneich/orgs","repos_url":"https://api.github.com/users/philgruneich/repos","events_url":"https://api.github.com/users/philgruneich/events{/privacy}","received_events_url":"https://api.github.com/users/philgruneich/received_events","type":"User","site_admin":false},"repo":{"id":55538974,"name":"nfephp","full_name":"philgruneich/nfephp","owner":{"login":"philgruneich","id":3649691,"avatar_url":"https://avatars.githubusercontent.com/u/3649691?v=3","gravatar_id":"","url":"https://api.github.com/users/philgruneich","html_url":"https://github.com/philgruneich","followers_url":"https://api.github.com/users/philgruneich/followers","following_url":"https://api.github.com/users/philgruneich/following{/other_user}","gists_url":"https://api.github.com/users/philgruneich/gists{/gist_id}","starred_url":"https://api.github.com/users/philgruneich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philgruneich/subscriptions","organizations_url":"https://api.github.com/users/philgruneich/orgs","repos_url":"https://api.github.com/users/philgruneich/repos","events_url":"https://api.github.com/users/philgruneich/events{/privacy}","received_events_url":"https://api.github.com/users/philgruneich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philgruneich/nfephp","description":"API para comunicação entre o emitente de NFe e os serviços dos SEFAZ estaduais. Inteiramente construído em PHP, roda em qualquer sistema operacional.","fork":true,"url":"https://api.github.com/repos/philgruneich/nfephp","forks_url":"https://api.github.com/repos/philgruneich/nfephp/forks","keys_url":"https://api.github.com/repos/philgruneich/nfephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philgruneich/nfephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philgruneich/nfephp/teams","hooks_url":"https://api.github.com/repos/philgruneich/nfephp/hooks","issue_events_url":"https://api.github.com/repos/philgruneich/nfephp/issues/events{/number}","events_url":"https://api.github.com/repos/philgruneich/nfephp/events","assignees_url":"https://api.github.com/repos/philgruneich/nfephp/assignees{/user}","branches_url":"https://api.github.com/repos/philgruneich/nfephp/branches{/branch}","tags_url":"https://api.github.com/repos/philgruneich/nfephp/tags","blobs_url":"https://api.github.com/repos/philgruneich/nfephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philgruneich/nfephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philgruneich/nfephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/philgruneich/nfephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philgruneich/nfephp/statuses/{sha}","languages_url":"https://api.github.com/repos/philgruneich/nfephp/languages","stargazers_url":"https://api.github.com/repos/philgruneich/nfephp/stargazers","contributors_url":"https://api.github.com/repos/philgruneich/nfephp/contributors","subscribers_url":"https://api.github.com/repos/philgruneich/nfephp/subscribers","subscription_url":"https://api.github.com/repos/philgruneich/nfephp/subscription","commits_url":"https://api.github.com/repos/philgruneich/nfephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/philgruneich/nfephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/philgruneich/nfephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/philgruneich/nfephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/philgruneich/nfephp/contents/{+path}","compare_url":"https://api.github.com/repos/philgruneich/nfephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philgruneich/nfephp/merges","archive_url":"https://api.github.com/repos/philgruneich/nfephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philgruneich/nfephp/downloads","issues_url":"https://api.github.com/repos/philgruneich/nfephp/issues{/number}","pulls_url":"https://api.github.com/repos/philgruneich/nfephp/pulls{/number}","milestones_url":"https://api.github.com/repos/philgruneich/nfephp/milestones{/number}","notifications_url":"https://api.github.com/repos/philgruneich/nfephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philgruneich/nfephp/labels{/name}","releases_url":"https://api.github.com/repos/philgruneich/nfephp/releases{/id}","deployments_url":"https://api.github.com/repos/philgruneich/nfephp/deployments","created_at":"2016-04-05T19:24:26Z","updated_at":"2016-04-05T19:24:28Z","pushed_at":"2016-04-05T19:49:30Z","git_url":"git://github.com/philgruneich/nfephp.git","ssh_url":"git@github.com:philgruneich/nfephp.git","clone_url":"https://github.com/philgruneich/nfephp.git","svn_url":"https://github.com/philgruneich/nfephp","homepage":"http://www.nfephp.org/","size":35319,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nfephp-org:master","ref":"master","sha":"29cb6dfa45465455f0ebe4f1aedd4cc7952e9d49","user":{"login":"nfephp-org","id":1618675,"avatar_url":"https://avatars.githubusercontent.com/u/1618675?v=3","gravatar_id":"","url":"https://api.github.com/users/nfephp-org","html_url":"https://github.com/nfephp-org","followers_url":"https://api.github.com/users/nfephp-org/followers","following_url":"https://api.github.com/users/nfephp-org/following{/other_user}","gists_url":"https://api.github.com/users/nfephp-org/gists{/gist_id}","starred_url":"https://api.github.com/users/nfephp-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfephp-org/subscriptions","organizations_url":"https://api.github.com/users/nfephp-org/orgs","repos_url":"https://api.github.com/users/nfephp-org/repos","events_url":"https://api.github.com/users/nfephp-org/events{/privacy}","received_events_url":"https://api.github.com/users/nfephp-org/received_events","type":"Organization","site_admin":false},"repo":{"id":6009557,"name":"nfephp","full_name":"nfephp-org/nfephp","owner":{"login":"nfephp-org","id":1618675,"avatar_url":"https://avatars.githubusercontent.com/u/1618675?v=3","gravatar_id":"","url":"https://api.github.com/users/nfephp-org","html_url":"https://github.com/nfephp-org","followers_url":"https://api.github.com/users/nfephp-org/followers","following_url":"https://api.github.com/users/nfephp-org/following{/other_user}","gists_url":"https://api.github.com/users/nfephp-org/gists{/gist_id}","starred_url":"https://api.github.com/users/nfephp-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfephp-org/subscriptions","organizations_url":"https://api.github.com/users/nfephp-org/orgs","repos_url":"https://api.github.com/users/nfephp-org/repos","events_url":"https://api.github.com/users/nfephp-org/events{/privacy}","received_events_url":"https://api.github.com/users/nfephp-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nfephp-org/nfephp","description":"API para comunicação entre o emitente de NFe e os serviços dos SEFAZ estaduais. Inteiramente construído em PHP, roda em qualquer sistema operacional.","fork":false,"url":"https://api.github.com/repos/nfephp-org/nfephp","forks_url":"https://api.github.com/repos/nfephp-org/nfephp/forks","keys_url":"https://api.github.com/repos/nfephp-org/nfephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nfephp-org/nfephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nfephp-org/nfephp/teams","hooks_url":"https://api.github.com/repos/nfephp-org/nfephp/hooks","issue_events_url":"https://api.github.com/repos/nfephp-org/nfephp/issues/events{/number}","events_url":"https://api.github.com/repos/nfephp-org/nfephp/events","assignees_url":"https://api.github.com/repos/nfephp-org/nfephp/assignees{/user}","branches_url":"https://api.github.com/repos/nfephp-org/nfephp/branches{/branch}","tags_url":"https://api.github.com/repos/nfephp-org/nfephp/tags","blobs_url":"https://api.github.com/repos/nfephp-org/nfephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nfephp-org/nfephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nfephp-org/nfephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/nfephp-org/nfephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nfephp-org/nfephp/statuses/{sha}","languages_url":"https://api.github.com/repos/nfephp-org/nfephp/languages","stargazers_url":"https://api.github.com/repos/nfephp-org/nfephp/stargazers","contributors_url":"https://api.github.com/repos/nfephp-org/nfephp/contributors","subscribers_url":"https://api.github.com/repos/nfephp-org/nfephp/subscribers","subscription_url":"https://api.github.com/repos/nfephp-org/nfephp/subscription","commits_url":"https://api.github.com/repos/nfephp-org/nfephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/nfephp-org/nfephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/nfephp-org/nfephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/nfephp-org/nfephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/nfephp-org/nfephp/contents/{+path}","compare_url":"https://api.github.com/repos/nfephp-org/nfephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nfephp-org/nfephp/merges","archive_url":"https://api.github.com/repos/nfephp-org/nfephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nfephp-org/nfephp/downloads","issues_url":"https://api.github.com/repos/nfephp-org/nfephp/issues{/number}","pulls_url":"https://api.github.com/repos/nfephp-org/nfephp/pulls{/number}","milestones_url":"https://api.github.com/repos/nfephp-org/nfephp/milestones{/number}","notifications_url":"https://api.github.com/repos/nfephp-org/nfephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nfephp-org/nfephp/labels{/name}","releases_url":"https://api.github.com/repos/nfephp-org/nfephp/releases{/id}","deployments_url":"https://api.github.com/repos/nfephp-org/nfephp/deployments","created_at":"2012-09-29T14:05:16Z","updated_at":"2016-04-04T14:19:06Z","pushed_at":"2016-04-05T19:58:52Z","git_url":"git://github.com/nfephp-org/nfephp.git","ssh_url":"git@github.com:nfephp-org/nfephp.git","clone_url":"https://github.com/nfephp-org/nfephp.git","svn_url":"https://github.com/nfephp-org/nfephp","homepage":"http://www.nfephp.org/","size":35319,"stargazers_count":471,"watchers_count":471,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":546,"mirror_url":null,"open_issues_count":2,"forks":546,"open_issues":2,"watchers":471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nfephp-org/nfephp/pulls/795"},"html":{"href":"https://github.com/nfephp-org/nfephp/pull/795"},"issue":{"href":"https://api.github.com/repos/nfephp-org/nfephp/issues/795"},"comments":{"href":"https://api.github.com/repos/nfephp-org/nfephp/issues/795/comments"},"review_comments":{"href":"https://api.github.com/repos/nfephp-org/nfephp/pulls/795/comments"},"review_comment":{"href":"https://api.github.com/repos/nfephp-org/nfephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nfephp-org/nfephp/pulls/795/commits"},"statuses":{"href":"https://api.github.com/repos/nfephp-org/nfephp/statuses/a5cb5c5d084f08024b1dcfcf92d5b3976a4da8e9"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"robmachado","id":1437008,"avatar_url":"https://avatars.githubusercontent.com/u/1437008?v=3","gravatar_id":"","url":"https://api.github.com/users/robmachado","html_url":"https://github.com/robmachado","followers_url":"https://api.github.com/users/robmachado/followers","following_url":"https://api.github.com/users/robmachado/following{/other_user}","gists_url":"https://api.github.com/users/robmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/robmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmachado/subscriptions","organizations_url":"https://api.github.com/users/robmachado/orgs","repos_url":"https://api.github.com/users/robmachado/repos","events_url":"https://api.github.com/users/robmachado/events{/privacy}","received_events_url":"https://api.github.com/users/robmachado/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":5,"deletions":5,"changed_files":1}}