{"action":"created","issue":{"url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/issues/29","repository_url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet","labels_url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/issues/29/comments","events_url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/issues/29/events","html_url":"https://github.com/sdl/dxa-web-application-dotnet/pull/29","id":167578332,"number":29,"title":"Add route values to Region MvcData and Controller Actions","user":{"login":"willprice76","id":2182588,"avatar_url":"https://avatars.githubusercontent.com/u/2182588?v=3","gravatar_id":"","url":"https://api.github.com/users/willprice76","html_url":"https://github.com/willprice76","followers_url":"https://api.github.com/users/willprice76/followers","following_url":"https://api.github.com/users/willprice76/following{/other_user}","gists_url":"https://api.github.com/users/willprice76/gists{/gist_id}","starred_url":"https://api.github.com/users/willprice76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willprice76/subscriptions","organizations_url":"https://api.github.com/users/willprice76/orgs","repos_url":"https://api.github.com/users/willprice76/repos","events_url":"https://api.github.com/users/willprice76/events{/privacy}","received_events_url":"https://api.github.com/users/willprice76/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-26T10:51:10Z","updated_at":"2016-07-26T11:35:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/pulls/29","html_url":"https://github.com/sdl/dxa-web-application-dotnet/pull/29","diff_url":"https://github.com/sdl/dxa-web-application-dotnet/pull/29.diff","patch_url":"https://github.com/sdl/dxa-web-application-dotnet/pull/29.patch"},"body":"Update to allow Region MvcData to also have route Values (similar to Entity MvcData). This allows for the parameterisation of Region views (see issue #28). The implementation in the DefaultModelBuilder is to get the route values from the CT metadata (routeValues), as for entities. In future this can be updated to a more normalised method when Regions are properly modelled in the CM.\r\n\r\nNow I can create a single generic N-Column region view and specify **regionCols** and **regionType** route values on the CT metadata (and different region names like 3-Column, 2-Column etc.), which enable me to configure the view column layout logic and render different class and other HTML attributes depending on the regionType."},"comment":{"url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/issues/comments/235242533","html_url":"https://github.com/sdl/dxa-web-application-dotnet/pull/29#issuecomment-235242533","issue_url":"https://api.github.com/repos/sdl/dxa-web-application-dotnet/issues/29","id":235242533,"user":{"login":"rpannekoek","id":4688784,"avatar_url":"https://avatars.githubusercontent.com/u/4688784?v=3","gravatar_id":"","url":"https://api.github.com/users/rpannekoek","html_url":"https://github.com/rpannekoek","followers_url":"https://api.github.com/users/rpannekoek/followers","following_url":"https://api.github.com/users/rpannekoek/following{/other_user}","gists_url":"https://api.github.com/users/rpannekoek/gists{/gist_id}","starred_url":"https://api.github.com/users/rpannekoek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpannekoek/subscriptions","organizations_url":"https://api.github.com/users/rpannekoek/orgs","repos_url":"https://api.github.com/users/rpannekoek/repos","events_url":"https://api.github.com/users/rpannekoek/events{/privacy}","received_events_url":"https://api.github.com/users/rpannekoek/received_events","type":"User","site_admin":false},"created_at":"2016-07-26T11:35:46Z","updated_at":"2016-07-26T11:35:46Z","body":"We should deal with \"conflicts\": multiple CTs for the same Region (name), but with different route values; the first one will \"win\", but we should log the fact that there are conflicts (like we do for Region view name).\r\nI think it would be better to distinguish Region route values from Entity route values; either by using a separate metadata field (my preference) or using prefixes in the route value keys. That will reduce the chance of such conflicts and enable us to detect them.\r\nFor example, I may want to use two Entities with different Entity route values in the same Region. They may have the same Region route values (if any), so don't conflict on that level, but currently we can't tell if there is a conflict or not."}}
{"actor":{"display_login":"rpannekoek"}}