{"action":"created","comment":{"url":"https://api.github.com/repos/wix/react-native-controllers/pulls/comments/55645040","id":55645040,"diff_hunk":"@@ -106,6 +106,43 @@ var Controllers = {\n     };\n   },\n \n+  TabBarControllerIOS: function (id) {\n+    return {\n+      setHidden: function (params) {\n+        return RCCManager.TabBarControllerIOS(id, \"setTabBarHidden\", params);\n+      }\n+    };\n+  },\n+\n+  Modal: {\n+    showLightBox: function(componentId, style) {","path":"index.js","position":13,"original_position":13,"commit_id":"79d44838c35c9638a433cc0f84b6d2e8faa143fd","original_commit_id":"79d44838c35c9638a433cc0f84b6d2e8faa143fd","user":{"login":"talkol","id":6762255,"avatar_url":"https://avatars.githubusercontent.com/u/6762255?v=3","gravatar_id":"","url":"https://api.github.com/users/talkol","html_url":"https://github.com/talkol","followers_url":"https://api.github.com/users/talkol/followers","following_url":"https://api.github.com/users/talkol/following{/other_user}","gists_url":"https://api.github.com/users/talkol/gists{/gist_id}","starred_url":"https://api.github.com/users/talkol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talkol/subscriptions","organizations_url":"https://api.github.com/users/talkol/orgs","repos_url":"https://api.github.com/users/talkol/repos","events_url":"https://api.github.com/users/talkol/events{/privacy}","received_events_url":"https://api.github.com/users/talkol/received_events","type":"User","site_admin":false},"body":"Let's change the signature here to be similar to `Controllers.NavigationControllerIOS(id).push()`\r\nSo it's something like this:\r\n`showLightBox: function(params)`\r\nand you call it with:\r\n`Modal.showLightBox({\r\n  component: 'LightBoxExample',\r\n  style: {}\r\n});`\r\n\r\nI found that this format is much better because it allows you and me to add more optional features in the future and maintain backwards compatibility in the signature.","created_at":"2016-03-10T08:07:43Z","updated_at":"2016-03-10T08:07:43Z","html_url":"https://github.com/wix/react-native-controllers/pull/4#discussion_r55645040","pull_request_url":"https://api.github.com/repos/wix/react-native-controllers/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/wix/react-native-controllers/pulls/comments/55645040"},"html":{"href":"https://github.com/wix/react-native-controllers/pull/4#discussion_r55645040"},"pull_request":{"href":"https://api.github.com/repos/wix/react-native-controllers/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/wix/react-native-controllers/pulls/4","id":61842773,"html_url":"https://github.com/wix/react-native-controllers/pull/4","diff_url":"https://github.com/wix/react-native-controllers/pull/4.diff","patch_url":"https://github.com/wix/react-native-controllers/pull/4.patch","issue_url":"https://api.github.com/repos/wix/react-native-controllers/issues/4","number":4,"state":"open","locked":false,"title":"Support showing a LightBox and a modal screen","user":{"login":"artald","id":8604256,"avatar_url":"https://avatars.githubusercontent.com/u/8604256?v=3","gravatar_id":"","url":"https://api.github.com/users/artald","html_url":"https://github.com/artald","followers_url":"https://api.github.com/users/artald/followers","following_url":"https://api.github.com/users/artald/following{/other_user}","gists_url":"https://api.github.com/users/artald/gists{/gist_id}","starred_url":"https://api.github.com/users/artald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artald/subscriptions","organizations_url":"https://api.github.com/users/artald/orgs","repos_url":"https://api.github.com/users/artald/repos","events_url":"https://api.github.com/users/artald/events{/privacy}","received_events_url":"https://api.github.com/users/artald/received_events","type":"User","site_admin":false},"body":"Initial suggestion for showing a LightBox and a Modal screen","created_at":"2016-03-06T13:30:23Z","updated_at":"2016-03-10T08:07:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e24d4ea13490c6adc4a8b9eaf0a1fcfaee7f1bc2","assignee":{"login":"talkol","id":6762255,"avatar_url":"https://avatars.githubusercontent.com/u/6762255?v=3","gravatar_id":"","url":"https://api.github.com/users/talkol","html_url":"https://github.com/talkol","followers_url":"https://api.github.com/users/talkol/followers","following_url":"https://api.github.com/users/talkol/following{/other_user}","gists_url":"https://api.github.com/users/talkol/gists{/gist_id}","starred_url":"https://api.github.com/users/talkol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talkol/subscriptions","organizations_url":"https://api.github.com/users/talkol/orgs","repos_url":"https://api.github.com/users/talkol/repos","events_url":"https://api.github.com/users/talkol/events{/privacy}","received_events_url":"https://api.github.com/users/talkol/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/wix/react-native-controllers/pulls/4/commits","review_comments_url":"https://api.github.com/repos/wix/react-native-controllers/pulls/4/comments","review_comment_url":"https://api.github.com/repos/wix/react-native-controllers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/react-native-controllers/issues/4/comments","statuses_url":"https://api.github.com/repos/wix/react-native-controllers/statuses/79d44838c35c9638a433cc0f84b6d2e8faa143fd","head":{"label":"wix:modals","ref":"modals","sha":"79d44838c35c9638a433cc0f84b6d2e8faa143fd","user":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":45825353,"name":"react-native-controllers","full_name":"wix/react-native-controllers","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/react-native-controllers","description":"Native IOS Navigation for React Native (navbar, tabs, drawer)","fork":false,"url":"https://api.github.com/repos/wix/react-native-controllers","forks_url":"https://api.github.com/repos/wix/react-native-controllers/forks","keys_url":"https://api.github.com/repos/wix/react-native-controllers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/react-native-controllers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/react-native-controllers/teams","hooks_url":"https://api.github.com/repos/wix/react-native-controllers/hooks","issue_events_url":"https://api.github.com/repos/wix/react-native-controllers/issues/events{/number}","events_url":"https://api.github.com/repos/wix/react-native-controllers/events","assignees_url":"https://api.github.com/repos/wix/react-native-controllers/assignees{/user}","branches_url":"https://api.github.com/repos/wix/react-native-controllers/branches{/branch}","tags_url":"https://api.github.com/repos/wix/react-native-controllers/tags","blobs_url":"https://api.github.com/repos/wix/react-native-controllers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/react-native-controllers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/react-native-controllers/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/react-native-controllers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/react-native-controllers/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/react-native-controllers/languages","stargazers_url":"https://api.github.com/repos/wix/react-native-controllers/stargazers","contributors_url":"https://api.github.com/repos/wix/react-native-controllers/contributors","subscribers_url":"https://api.github.com/repos/wix/react-native-controllers/subscribers","subscription_url":"https://api.github.com/repos/wix/react-native-controllers/subscription","commits_url":"https://api.github.com/repos/wix/react-native-controllers/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/react-native-controllers/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/react-native-controllers/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/react-native-controllers/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/react-native-controllers/contents/{+path}","compare_url":"https://api.github.com/repos/wix/react-native-controllers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/react-native-controllers/merges","archive_url":"https://api.github.com/repos/wix/react-native-controllers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/react-native-controllers/downloads","issues_url":"https://api.github.com/repos/wix/react-native-controllers/issues{/number}","pulls_url":"https://api.github.com/repos/wix/react-native-controllers/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/react-native-controllers/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/react-native-controllers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/react-native-controllers/labels{/name}","releases_url":"https://api.github.com/repos/wix/react-native-controllers/releases{/id}","deployments_url":"https://api.github.com/repos/wix/react-native-controllers/deployments","created_at":"2015-11-09T08:33:57Z","updated_at":"2016-03-09T14:37:43Z","pushed_at":"2016-03-09T16:05:42Z","git_url":"git://github.com/wix/react-native-controllers.git","ssh_url":"git@github.com:wix/react-native-controllers.git","clone_url":"https://github.com/wix/react-native-controllers.git","svn_url":"https://github.com/wix/react-native-controllers","homepage":"","size":251,"stargazers_count":98,"watchers_count":98,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":98,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"a2d248fae501f7a196688ebbf559ddf979a61377","user":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":45825353,"name":"react-native-controllers","full_name":"wix/react-native-controllers","owner":{"login":"wix","id":686511,"avatar_url":"https://avatars.githubusercontent.com/u/686511?v=3","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wix/react-native-controllers","description":"Native IOS Navigation for React Native (navbar, tabs, drawer)","fork":false,"url":"https://api.github.com/repos/wix/react-native-controllers","forks_url":"https://api.github.com/repos/wix/react-native-controllers/forks","keys_url":"https://api.github.com/repos/wix/react-native-controllers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/react-native-controllers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/react-native-controllers/teams","hooks_url":"https://api.github.com/repos/wix/react-native-controllers/hooks","issue_events_url":"https://api.github.com/repos/wix/react-native-controllers/issues/events{/number}","events_url":"https://api.github.com/repos/wix/react-native-controllers/events","assignees_url":"https://api.github.com/repos/wix/react-native-controllers/assignees{/user}","branches_url":"https://api.github.com/repos/wix/react-native-controllers/branches{/branch}","tags_url":"https://api.github.com/repos/wix/react-native-controllers/tags","blobs_url":"https://api.github.com/repos/wix/react-native-controllers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/react-native-controllers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/react-native-controllers/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/react-native-controllers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/react-native-controllers/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/react-native-controllers/languages","stargazers_url":"https://api.github.com/repos/wix/react-native-controllers/stargazers","contributors_url":"https://api.github.com/repos/wix/react-native-controllers/contributors","subscribers_url":"https://api.github.com/repos/wix/react-native-controllers/subscribers","subscription_url":"https://api.github.com/repos/wix/react-native-controllers/subscription","commits_url":"https://api.github.com/repos/wix/react-native-controllers/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/react-native-controllers/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/react-native-controllers/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/react-native-controllers/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/react-native-controllers/contents/{+path}","compare_url":"https://api.github.com/repos/wix/react-native-controllers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/react-native-controllers/merges","archive_url":"https://api.github.com/repos/wix/react-native-controllers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/react-native-controllers/downloads","issues_url":"https://api.github.com/repos/wix/react-native-controllers/issues{/number}","pulls_url":"https://api.github.com/repos/wix/react-native-controllers/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/react-native-controllers/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/react-native-controllers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/react-native-controllers/labels{/name}","releases_url":"https://api.github.com/repos/wix/react-native-controllers/releases{/id}","deployments_url":"https://api.github.com/repos/wix/react-native-controllers/deployments","created_at":"2015-11-09T08:33:57Z","updated_at":"2016-03-09T14:37:43Z","pushed_at":"2016-03-09T16:05:42Z","git_url":"git://github.com/wix/react-native-controllers.git","ssh_url":"git@github.com:wix/react-native-controllers.git","clone_url":"https://github.com/wix/react-native-controllers.git","svn_url":"https://github.com/wix/react-native-controllers","homepage":"","size":251,"stargazers_count":98,"watchers_count":98,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/react-native-controllers/pulls/4"},"html":{"href":"https://github.com/wix/react-native-controllers/pull/4"},"issue":{"href":"https://api.github.com/repos/wix/react-native-controllers/issues/4"},"comments":{"href":"https://api.github.com/repos/wix/react-native-controllers/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/react-native-controllers/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/react-native-controllers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/react-native-controllers/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/wix/react-native-controllers/statuses/79d44838c35c9638a433cc0f84b6d2e8faa143fd"}}}}