{"comment":{"url":"https://api.github.com/repos/thelastpickle/brave/comments/17580109","html_url":"https://github.com/thelastpickle/brave/commit/81c16b6802128128277afd1be0d4dfb04c9be31e#commitcomment-17580109","id":17580109,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars.githubusercontent.com/u/64215?v=3","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"position":60,"line":60,"path":"brave-spancollector-cassandra/src/main/java/com/github/kristofa/brave/cassandra/CassandraSpanCollector.java","commit_id":"81c16b6802128128277afd1be0d4dfb04c9be31e","created_at":"2016-05-23T14:33:11Z","updated_at":"2016-05-23T14:33:11Z","body":"general thoughts are this..\r\n\r\nThe AbstractCollector thing is going to be pretty maintained code, and avoid some tests needing to be redone in each module. It might need work to support this use case, but that work is probably worthwhile. I'd see about how to use it\r\nhttps://github.com/openzipkin/brave/blob/master/brave-spancollector-kafka/src/main/java/com/github/kristofa/brave/kafka/KafkaSpanCollector.java"}}
{"actor":{"display_login":"adriancole"}}