{"action":"created","comment":{"url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/comments/83567602","pull_request_review_id":4402910,"id":83567602,"diff_hunk":"@@ -324,13 +346,14 @@ default void insertTagToTrans(int tagID, int transID) {\n \n     default Note getNoteForTransactionID(int transactionID) throws StorageException {\n         try {\n-            PreparedStatement stmt = getDatabase().prepareStatement(\"SELECT * FROM NOTE WHERE NOTE_TRANS_ID=?\");\n+            PreparedStatement stmt = getDatabase().prepareStatement(\"SELECT * FROM \" + NoteTable.TABLE_NAME +","path":"src/main/java/ledger/database/storage/ISQLiteDatabaseTransaction.java","position":176,"original_position":176,"commit_id":"b192b5792eaa25481dad7b27b7971a55f845c9d9","original_commit_id":"b192b5792eaa25481dad7b27b7971a55f845c9d9","user":{"login":"shellajt","id":11395587,"avatar_url":"https://avatars.githubusercontent.com/u/11395587?v=3","gravatar_id":"","url":"https://api.github.com/users/shellajt","html_url":"https://github.com/shellajt","followers_url":"https://api.github.com/users/shellajt/followers","following_url":"https://api.github.com/users/shellajt/following{/other_user}","gists_url":"https://api.github.com/users/shellajt/gists{/gist_id}","starred_url":"https://api.github.com/users/shellajt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellajt/subscriptions","organizations_url":"https://api.github.com/users/shellajt/orgs","repos_url":"https://api.github.com/users/shellajt/repos","events_url":"https://api.github.com/users/shellajt/events{/privacy}","received_events_url":"https://api.github.com/users/shellajt/received_events","type":"User","site_admin":false},"body":"Lets get rid of SELECT * like Sriram was advised","created_at":"2016-10-17T01:45:22Z","updated_at":"2016-10-17T01:47:15Z","html_url":"https://github.com/Ledger-Software/Ledger/pull/26#discussion_r83567602","pull_request_url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/comments/83567602"},"html":{"href":"https://github.com/Ledger-Software/Ledger/pull/26#discussion_r83567602"},"pull_request":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26","id":89548285,"html_url":"https://github.com/Ledger-Software/Ledger/pull/26","diff_url":"https://github.com/Ledger-Software/Ledger/pull/26.diff","patch_url":"https://github.com/Ledger-Software/Ledger/pull/26.patch","issue_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues/26","number":26,"state":"open","locked":false,"title":"Move Each Table to Own Class with constants and dynamic SQL Generation","user":{"login":"cjm721","id":2738614,"avatar_url":"https://avatars.githubusercontent.com/u/2738614?v=3","gravatar_id":"","url":"https://api.github.com/users/cjm721","html_url":"https://github.com/cjm721","followers_url":"https://api.github.com/users/cjm721/followers","following_url":"https://api.github.com/users/cjm721/following{/other_user}","gists_url":"https://api.github.com/users/cjm721/gists{/gist_id}","starred_url":"https://api.github.com/users/cjm721/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjm721/subscriptions","organizations_url":"https://api.github.com/users/cjm721/orgs","repos_url":"https://api.github.com/users/cjm721/repos","events_url":"https://api.github.com/users/cjm721/events{/privacy}","received_events_url":"https://api.github.com/users/cjm721/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-17T01:09:29Z","updated_at":"2016-10-17T01:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e58d2c9c8ef23ff1dfc0f8be1cf871708c07de00","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26/commits","review_comments_url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26/comments","review_comment_url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues/26/comments","statuses_url":"https://api.github.com/repos/Ledger-Software/Ledger/statuses/b192b5792eaa25481dad7b27b7971a55f845c9d9","head":{"label":"Ledger-Software:f_2refactoring_constants","ref":"f_2refactoring_constants","sha":"b192b5792eaa25481dad7b27b7971a55f845c9d9","user":{"login":"Ledger-Software","id":21131744,"avatar_url":"https://avatars.githubusercontent.com/u/21131744?v=3","gravatar_id":"","url":"https://api.github.com/users/Ledger-Software","html_url":"https://github.com/Ledger-Software","followers_url":"https://api.github.com/users/Ledger-Software/followers","following_url":"https://api.github.com/users/Ledger-Software/following{/other_user}","gists_url":"https://api.github.com/users/Ledger-Software/gists{/gist_id}","starred_url":"https://api.github.com/users/Ledger-Software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ledger-Software/subscriptions","organizations_url":"https://api.github.com/users/Ledger-Software/orgs","repos_url":"https://api.github.com/users/Ledger-Software/repos","events_url":"https://api.github.com/users/Ledger-Software/events{/privacy}","received_events_url":"https://api.github.com/users/Ledger-Software/received_events","type":"Organization","site_admin":false},"repo":{"id":66108741,"name":"Ledger","full_name":"Ledger-Software/Ledger","owner":{"login":"Ledger-Software","id":21131744,"avatar_url":"https://avatars.githubusercontent.com/u/21131744?v=3","gravatar_id":"","url":"https://api.github.com/users/Ledger-Software","html_url":"https://github.com/Ledger-Software","followers_url":"https://api.github.com/users/Ledger-Software/followers","following_url":"https://api.github.com/users/Ledger-Software/following{/other_user}","gists_url":"https://api.github.com/users/Ledger-Software/gists{/gist_id}","starred_url":"https://api.github.com/users/Ledger-Software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ledger-Software/subscriptions","organizations_url":"https://api.github.com/users/Ledger-Software/orgs","repos_url":"https://api.github.com/users/Ledger-Software/repos","events_url":"https://api.github.com/users/Ledger-Software/events{/privacy}","received_events_url":"https://api.github.com/users/Ledger-Software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ledger-Software/Ledger","description":null,"fork":false,"url":"https://api.github.com/repos/Ledger-Software/Ledger","forks_url":"https://api.github.com/repos/Ledger-Software/Ledger/forks","keys_url":"https://api.github.com/repos/Ledger-Software/Ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ledger-Software/Ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ledger-Software/Ledger/teams","hooks_url":"https://api.github.com/repos/Ledger-Software/Ledger/hooks","issue_events_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues/events{/number}","events_url":"https://api.github.com/repos/Ledger-Software/Ledger/events","assignees_url":"https://api.github.com/repos/Ledger-Software/Ledger/assignees{/user}","branches_url":"https://api.github.com/repos/Ledger-Software/Ledger/branches{/branch}","tags_url":"https://api.github.com/repos/Ledger-Software/Ledger/tags","blobs_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ledger-Software/Ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/Ledger-Software/Ledger/languages","stargazers_url":"https://api.github.com/repos/Ledger-Software/Ledger/stargazers","contributors_url":"https://api.github.com/repos/Ledger-Software/Ledger/contributors","subscribers_url":"https://api.github.com/repos/Ledger-Software/Ledger/subscribers","subscription_url":"https://api.github.com/repos/Ledger-Software/Ledger/subscription","commits_url":"https://api.github.com/repos/Ledger-Software/Ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ledger-Software/Ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ledger-Software/Ledger/contents/{+path}","compare_url":"https://api.github.com/repos/Ledger-Software/Ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ledger-Software/Ledger/merges","archive_url":"https://api.github.com/repos/Ledger-Software/Ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ledger-Software/Ledger/downloads","issues_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues{/number}","pulls_url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/Ledger-Software/Ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/Ledger-Software/Ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ledger-Software/Ledger/labels{/name}","releases_url":"https://api.github.com/repos/Ledger-Software/Ledger/releases{/id}","deployments_url":"https://api.github.com/repos/Ledger-Software/Ledger/deployments","created_at":"2016-08-19T19:57:31Z","updated_at":"2016-09-27T00:16:13Z","pushed_at":"2016-10-17T01:24:33Z","git_url":"git://github.com/Ledger-Software/Ledger.git","ssh_url":"git@github.com:Ledger-Software/Ledger.git","clone_url":"https://github.com/Ledger-Software/Ledger.git","svn_url":"https://github.com/Ledger-Software/Ledger","homepage":null,"size":314,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"Ledger-Software:f_2refactoring","ref":"f_2refactoring","sha":"a988ec2cf3114b499b63411f0250902bb4e1302f","user":{"login":"Ledger-Software","id":21131744,"avatar_url":"https://avatars.githubusercontent.com/u/21131744?v=3","gravatar_id":"","url":"https://api.github.com/users/Ledger-Software","html_url":"https://github.com/Ledger-Software","followers_url":"https://api.github.com/users/Ledger-Software/followers","following_url":"https://api.github.com/users/Ledger-Software/following{/other_user}","gists_url":"https://api.github.com/users/Ledger-Software/gists{/gist_id}","starred_url":"https://api.github.com/users/Ledger-Software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ledger-Software/subscriptions","organizations_url":"https://api.github.com/users/Ledger-Software/orgs","repos_url":"https://api.github.com/users/Ledger-Software/repos","events_url":"https://api.github.com/users/Ledger-Software/events{/privacy}","received_events_url":"https://api.github.com/users/Ledger-Software/received_events","type":"Organization","site_admin":false},"repo":{"id":66108741,"name":"Ledger","full_name":"Ledger-Software/Ledger","owner":{"login":"Ledger-Software","id":21131744,"avatar_url":"https://avatars.githubusercontent.com/u/21131744?v=3","gravatar_id":"","url":"https://api.github.com/users/Ledger-Software","html_url":"https://github.com/Ledger-Software","followers_url":"https://api.github.com/users/Ledger-Software/followers","following_url":"https://api.github.com/users/Ledger-Software/following{/other_user}","gists_url":"https://api.github.com/users/Ledger-Software/gists{/gist_id}","starred_url":"https://api.github.com/users/Ledger-Software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ledger-Software/subscriptions","organizations_url":"https://api.github.com/users/Ledger-Software/orgs","repos_url":"https://api.github.com/users/Ledger-Software/repos","events_url":"https://api.github.com/users/Ledger-Software/events{/privacy}","received_events_url":"https://api.github.com/users/Ledger-Software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ledger-Software/Ledger","description":null,"fork":false,"url":"https://api.github.com/repos/Ledger-Software/Ledger","forks_url":"https://api.github.com/repos/Ledger-Software/Ledger/forks","keys_url":"https://api.github.com/repos/Ledger-Software/Ledger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ledger-Software/Ledger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ledger-Software/Ledger/teams","hooks_url":"https://api.github.com/repos/Ledger-Software/Ledger/hooks","issue_events_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues/events{/number}","events_url":"https://api.github.com/repos/Ledger-Software/Ledger/events","assignees_url":"https://api.github.com/repos/Ledger-Software/Ledger/assignees{/user}","branches_url":"https://api.github.com/repos/Ledger-Software/Ledger/branches{/branch}","tags_url":"https://api.github.com/repos/Ledger-Software/Ledger/tags","blobs_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ledger-Software/Ledger/statuses/{sha}","languages_url":"https://api.github.com/repos/Ledger-Software/Ledger/languages","stargazers_url":"https://api.github.com/repos/Ledger-Software/Ledger/stargazers","contributors_url":"https://api.github.com/repos/Ledger-Software/Ledger/contributors","subscribers_url":"https://api.github.com/repos/Ledger-Software/Ledger/subscribers","subscription_url":"https://api.github.com/repos/Ledger-Software/Ledger/subscription","commits_url":"https://api.github.com/repos/Ledger-Software/Ledger/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ledger-Software/Ledger/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ledger-Software/Ledger/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ledger-Software/Ledger/contents/{+path}","compare_url":"https://api.github.com/repos/Ledger-Software/Ledger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ledger-Software/Ledger/merges","archive_url":"https://api.github.com/repos/Ledger-Software/Ledger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ledger-Software/Ledger/downloads","issues_url":"https://api.github.com/repos/Ledger-Software/Ledger/issues{/number}","pulls_url":"https://api.github.com/repos/Ledger-Software/Ledger/pulls{/number}","milestones_url":"https://api.github.com/repos/Ledger-Software/Ledger/milestones{/number}","notifications_url":"https://api.github.com/repos/Ledger-Software/Ledger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ledger-Software/Ledger/labels{/name}","releases_url":"https://api.github.com/repos/Ledger-Software/Ledger/releases{/id}","deployments_url":"https://api.github.com/repos/Ledger-Software/Ledger/deployments","created_at":"2016-08-19T19:57:31Z","updated_at":"2016-09-27T00:16:13Z","pushed_at":"2016-10-17T01:24:33Z","git_url":"git://github.com/Ledger-Software/Ledger.git","ssh_url":"git@github.com:Ledger-Software/Ledger.git","clone_url":"https://github.com/Ledger-Software/Ledger.git","svn_url":"https://github.com/Ledger-Software/Ledger","homepage":null,"size":314,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26"},"html":{"href":"https://github.com/Ledger-Software/Ledger/pull/26"},"issue":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/issues/26"},"comments":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/Ledger-Software/Ledger/statuses/b192b5792eaa25481dad7b27b7971a55f845c9d9"}}}}
{"actor":{"display_login":"shellajt"}}