{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/85957186","pull_request_review_id":6640698,"id":85957186,"diff_hunk":"@@ -52,9 +52,9 @@ func generic_metatypes<T : SomeProtocol>(_ x: T)\n }\n \n // Inferring a variable's type from a call to a generic.\n-struct Pair<T, U> { } // expected-note 5 {{'T' declared as parameter to type 'Pair'}}\n+struct Pair<T, U> { } // expected-note 4 {{'T' declared as parameter to type 'Pair'}} expected-note {{'U' declared as parameter to type 'Pair'}}","path":"test/Constraints/generics.swift","position":5,"original_position":5,"commit_id":"b4eac5f78067bf981f55a3fdb9b2f9c3a4596c07","original_commit_id":"b4eac5f78067bf981f55a3fdb9b2f9c3a4596c07","user":{"login":"jrose-apple","id":15097531,"avatar_url":"https://avatars.githubusercontent.com/u/15097531?v=3","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I think it's just diagnosing the correct parameter in more cases now. The total number of notes on this line is still the same.","created_at":"2016-11-01T15:51:26Z","updated_at":"2016-11-01T15:51:26Z","html_url":"https://github.com/apple/swift/pull/5238#discussion_r85957186","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/5238","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/85957186"},"html":{"href":"https://github.com/apple/swift/pull/5238#discussion_r85957186"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/5238"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/5238","id":88916840,"html_url":"https://github.com/apple/swift/pull/5238","diff_url":"https://github.com/apple/swift/pull/5238.diff","patch_url":"https://github.com/apple/swift/pull/5238.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/5238","number":5238,"state":"open","locked":false,"title":"SR-2164: Fix erroneous diagnostic when unable to infer generic parameter","user":{"login":"xedin","id":21240,"avatar_url":"https://avatars.githubusercontent.com/u/21240?v=3","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\n\nThis patch attempts to improve diagnostics related to generic type construction when\nsome of the generic parameters are not provided by constructor and, as a result, are unbound.\n\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\n\nResolves [SR-2164](https://bugs.swift.org/browse/SR-2164).\n\n<!--\nBefore merging this pull request, you must run the Swift continuous integration tests.\nFor information about triggering CI builds via @swift-ci, see:\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\n\nThank you for your contribution to Swift!\n-->\n","created_at":"2016-10-11T21:42:52Z","updated_at":"2016-11-01T15:51:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7a5d27589bae232f1fd15b3e9e2faa31a5b6b79","assignee":{"login":"rudkx","id":162784,"avatar_url":"https://avatars.githubusercontent.com/u/162784?v=3","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false},"assignees":[{"login":"rudkx","id":162784,"avatar_url":"https://avatars.githubusercontent.com/u/162784?v=3","gravatar_id":"","url":"https://api.github.com/users/rudkx","html_url":"https://github.com/rudkx","followers_url":"https://api.github.com/users/rudkx/followers","following_url":"https://api.github.com/users/rudkx/following{/other_user}","gists_url":"https://api.github.com/users/rudkx/gists{/gist_id}","starred_url":"https://api.github.com/users/rudkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudkx/subscriptions","organizations_url":"https://api.github.com/users/rudkx/orgs","repos_url":"https://api.github.com/users/rudkx/repos","events_url":"https://api.github.com/users/rudkx/events{/privacy}","received_events_url":"https://api.github.com/users/rudkx/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/5238/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/5238/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/5238/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/b4eac5f78067bf981f55a3fdb9b2f9c3a4596c07","head":{"label":"xedin:SR-2164","ref":"SR-2164","sha":"b4eac5f78067bf981f55a3fdb9b2f9c3a4596c07","user":{"login":"xedin","id":21240,"avatar_url":"https://avatars.githubusercontent.com/u/21240?v=3","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"repo":{"id":66491687,"name":"swift","full_name":"xedin/swift","owner":{"login":"xedin","id":21240,"avatar_url":"https://avatars.githubusercontent.com/u/21240?v=3","gravatar_id":"","url":"https://api.github.com/users/xedin","html_url":"https://github.com/xedin","followers_url":"https://api.github.com/users/xedin/followers","following_url":"https://api.github.com/users/xedin/following{/other_user}","gists_url":"https://api.github.com/users/xedin/gists{/gist_id}","starred_url":"https://api.github.com/users/xedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xedin/subscriptions","organizations_url":"https://api.github.com/users/xedin/orgs","repos_url":"https://api.github.com/users/xedin/repos","events_url":"https://api.github.com/users/xedin/events{/privacy}","received_events_url":"https://api.github.com/users/xedin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xedin/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/xedin/swift","forks_url":"https://api.github.com/repos/xedin/swift/forks","keys_url":"https://api.github.com/repos/xedin/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xedin/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xedin/swift/teams","hooks_url":"https://api.github.com/repos/xedin/swift/hooks","issue_events_url":"https://api.github.com/repos/xedin/swift/issues/events{/number}","events_url":"https://api.github.com/repos/xedin/swift/events","assignees_url":"https://api.github.com/repos/xedin/swift/assignees{/user}","branches_url":"https://api.github.com/repos/xedin/swift/branches{/branch}","tags_url":"https://api.github.com/repos/xedin/swift/tags","blobs_url":"https://api.github.com/repos/xedin/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xedin/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xedin/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/xedin/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xedin/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/xedin/swift/languages","stargazers_url":"https://api.github.com/repos/xedin/swift/stargazers","contributors_url":"https://api.github.com/repos/xedin/swift/contributors","subscribers_url":"https://api.github.com/repos/xedin/swift/subscribers","subscription_url":"https://api.github.com/repos/xedin/swift/subscription","commits_url":"https://api.github.com/repos/xedin/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/xedin/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/xedin/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/xedin/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/xedin/swift/contents/{+path}","compare_url":"https://api.github.com/repos/xedin/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xedin/swift/merges","archive_url":"https://api.github.com/repos/xedin/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xedin/swift/downloads","issues_url":"https://api.github.com/repos/xedin/swift/issues{/number}","pulls_url":"https://api.github.com/repos/xedin/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/xedin/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/xedin/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xedin/swift/labels{/name}","releases_url":"https://api.github.com/repos/xedin/swift/releases{/id}","deployments_url":"https://api.github.com/repos/xedin/swift/deployments","created_at":"2016-08-24T19:04:17Z","updated_at":"2016-08-24T19:04:41Z","pushed_at":"2016-10-31T05:28:55Z","git_url":"git://github.com/xedin/swift.git","ssh_url":"git@github.com:xedin/swift.git","clone_url":"https://github.com/xedin/swift.git","svn_url":"https://github.com/xedin/swift","homepage":"https://swift.org/","size":126794,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"874eb165119780c372fde50aa90aacefe829245c","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2016-11-01T15:43:41Z","pushed_at":"2016-11-01T15:48:56Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":194503,"stargazers_count":34944,"watchers_count":34944,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5019,"mirror_url":null,"open_issues_count":114,"forks":5019,"open_issues":114,"watchers":34944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/5238"},"html":{"href":"https://github.com/apple/swift/pull/5238"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/5238"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/5238/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/5238/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/5238/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/b4eac5f78067bf981f55a3fdb9b2f9c3a4596c07"}}}}
{"actor":{"display_login":"jrose-apple"}}