{"action":"created","comment":{"url":"https://api.github.com/repos/guard/guard-rspec/pulls/comments/58294793","id":58294793,"diff_hunk":"@@ -255,5 +255,20 @@ def expected_output(spec_filename)\n         end\n       end\n     end\n+\n+    context \"when RSpec 3.0 is configured to use multiple patterns\" do\n+      before do\n+        allow(::RSpec.configuration).to receive(:pattern).\n+          and_return(\"**{,/*/**}/*_spec.rb,**/*.feature\")\n+      end\n+\n+      it \"matches a spec file with the first pattern\" do\n+        expect(described_class.spec_path?('./spec/foo_spec.rb')).to be_truthy","path":"spec/lib/guard/rspec_formatter_spec.rb","position":12,"original_position":12,"commit_id":"8b8bfc1e6f665902ba429fd510554aa3a2f78648","original_commit_id":"8b8bfc1e6f665902ba429fd510554aa3a2f78648","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2016-04-02T15:26:21Z","updated_at":"2016-04-02T15:26:21Z","html_url":"https://github.com/guard/guard-rspec/pull/363#discussion_r58294793","pull_request_url":"https://api.github.com/repos/guard/guard-rspec/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/comments/58294793"},"html":{"href":"https://github.com/guard/guard-rspec/pull/363#discussion_r58294793"},"pull_request":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/363"}}},"pull_request":{"url":"https://api.github.com/repos/guard/guard-rspec/pulls/363","id":65037965,"html_url":"https://github.com/guard/guard-rspec/pull/363","diff_url":"https://github.com/guard/guard-rspec/pull/363.diff","patch_url":"https://github.com/guard/guard-rspec/pull/363.patch","issue_url":"https://api.github.com/repos/guard/guard-rspec/issues/363","number":363,"state":"open","locked":false,"title":"Fix spec path verification with multiple pattern","user":{"login":"thedoritos","id":1067891,"avatar_url":"https://avatars.githubusercontent.com/u/1067891?v=3","gravatar_id":"","url":"https://api.github.com/users/thedoritos","html_url":"https://github.com/thedoritos","followers_url":"https://api.github.com/users/thedoritos/followers","following_url":"https://api.github.com/users/thedoritos/following{/other_user}","gists_url":"https://api.github.com/users/thedoritos/gists{/gist_id}","starred_url":"https://api.github.com/users/thedoritos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedoritos/subscriptions","organizations_url":"https://api.github.com/users/thedoritos/orgs","repos_url":"https://api.github.com/users/thedoritos/repos","events_url":"https://api.github.com/users/thedoritos/events{/privacy}","received_events_url":"https://api.github.com/users/thedoritos/received_events","type":"User","site_admin":false},"body":"The value from `RSpec.configuration.pattern` may not satisfy a glob pattern\r\nif multiple pattern is set (e.g. `'**{,/*/**}/*_spec.rb,**/*.feature'`).\r\n\r\nAnd the formatter prints `no spec file location` warnings on STDOUT for each failed examples\r\nbecause `spec_path?` method can't find the spec file location with a non-glob pattern.\r\n\r\nThis PR fixes `spec_path?` method to be able to find spec files even if a multiple pattern set.\r\nThe implementation is written referencing RSpec::Core::Configuration.\r\n\r\n[rspec-core/configuration.rb at master · rspec/rspec-core · GitHub](https://github.com/rspec/rspec-core/blob/master/lib/rspec/core/configuration.rb#L1790)","created_at":"2016-04-02T13:24:59Z","updated_at":"2016-04-02T15:26:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b39721d3ad9a91b9607b9972e899b0ff3d29b688","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guard/guard-rspec/pulls/363/commits","review_comments_url":"https://api.github.com/repos/guard/guard-rspec/pulls/363/comments","review_comment_url":"https://api.github.com/repos/guard/guard-rspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guard/guard-rspec/issues/363/comments","statuses_url":"https://api.github.com/repos/guard/guard-rspec/statuses/8b8bfc1e6f665902ba429fd510554aa3a2f78648","head":{"label":"thedoritos:fix_spec_path_verification","ref":"fix_spec_path_verification","sha":"8b8bfc1e6f665902ba429fd510554aa3a2f78648","user":{"login":"thedoritos","id":1067891,"avatar_url":"https://avatars.githubusercontent.com/u/1067891?v=3","gravatar_id":"","url":"https://api.github.com/users/thedoritos","html_url":"https://github.com/thedoritos","followers_url":"https://api.github.com/users/thedoritos/followers","following_url":"https://api.github.com/users/thedoritos/following{/other_user}","gists_url":"https://api.github.com/users/thedoritos/gists{/gist_id}","starred_url":"https://api.github.com/users/thedoritos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedoritos/subscriptions","organizations_url":"https://api.github.com/users/thedoritos/orgs","repos_url":"https://api.github.com/users/thedoritos/repos","events_url":"https://api.github.com/users/thedoritos/events{/privacy}","received_events_url":"https://api.github.com/users/thedoritos/received_events","type":"User","site_admin":false},"repo":{"id":55294011,"name":"guard-rspec","full_name":"thedoritos/guard-rspec","owner":{"login":"thedoritos","id":1067891,"avatar_url":"https://avatars.githubusercontent.com/u/1067891?v=3","gravatar_id":"","url":"https://api.github.com/users/thedoritos","html_url":"https://github.com/thedoritos","followers_url":"https://api.github.com/users/thedoritos/followers","following_url":"https://api.github.com/users/thedoritos/following{/other_user}","gists_url":"https://api.github.com/users/thedoritos/gists{/gist_id}","starred_url":"https://api.github.com/users/thedoritos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedoritos/subscriptions","organizations_url":"https://api.github.com/users/thedoritos/orgs","repos_url":"https://api.github.com/users/thedoritos/repos","events_url":"https://api.github.com/users/thedoritos/events{/privacy}","received_events_url":"https://api.github.com/users/thedoritos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thedoritos/guard-rspec","description":"Guard::RSpec automatically run your specs (much like autotest)","fork":true,"url":"https://api.github.com/repos/thedoritos/guard-rspec","forks_url":"https://api.github.com/repos/thedoritos/guard-rspec/forks","keys_url":"https://api.github.com/repos/thedoritos/guard-rspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thedoritos/guard-rspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thedoritos/guard-rspec/teams","hooks_url":"https://api.github.com/repos/thedoritos/guard-rspec/hooks","issue_events_url":"https://api.github.com/repos/thedoritos/guard-rspec/issues/events{/number}","events_url":"https://api.github.com/repos/thedoritos/guard-rspec/events","assignees_url":"https://api.github.com/repos/thedoritos/guard-rspec/assignees{/user}","branches_url":"https://api.github.com/repos/thedoritos/guard-rspec/branches{/branch}","tags_url":"https://api.github.com/repos/thedoritos/guard-rspec/tags","blobs_url":"https://api.github.com/repos/thedoritos/guard-rspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thedoritos/guard-rspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thedoritos/guard-rspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/thedoritos/guard-rspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thedoritos/guard-rspec/statuses/{sha}","languages_url":"https://api.github.com/repos/thedoritos/guard-rspec/languages","stargazers_url":"https://api.github.com/repos/thedoritos/guard-rspec/stargazers","contributors_url":"https://api.github.com/repos/thedoritos/guard-rspec/contributors","subscribers_url":"https://api.github.com/repos/thedoritos/guard-rspec/subscribers","subscription_url":"https://api.github.com/repos/thedoritos/guard-rspec/subscription","commits_url":"https://api.github.com/repos/thedoritos/guard-rspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/thedoritos/guard-rspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/thedoritos/guard-rspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/thedoritos/guard-rspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/thedoritos/guard-rspec/contents/{+path}","compare_url":"https://api.github.com/repos/thedoritos/guard-rspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thedoritos/guard-rspec/merges","archive_url":"https://api.github.com/repos/thedoritos/guard-rspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thedoritos/guard-rspec/downloads","issues_url":"https://api.github.com/repos/thedoritos/guard-rspec/issues{/number}","pulls_url":"https://api.github.com/repos/thedoritos/guard-rspec/pulls{/number}","milestones_url":"https://api.github.com/repos/thedoritos/guard-rspec/milestones{/number}","notifications_url":"https://api.github.com/repos/thedoritos/guard-rspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thedoritos/guard-rspec/labels{/name}","releases_url":"https://api.github.com/repos/thedoritos/guard-rspec/releases{/id}","deployments_url":"https://api.github.com/repos/thedoritos/guard-rspec/deployments","created_at":"2016-04-02T12:45:20Z","updated_at":"2016-04-02T12:45:21Z","pushed_at":"2016-04-02T15:26:19Z","git_url":"git://github.com/thedoritos/guard-rspec.git","ssh_url":"git@github.com:thedoritos/guard-rspec.git","clone_url":"https://github.com/thedoritos/guard-rspec.git","svn_url":"https://github.com/thedoritos/guard-rspec","homepage":"https://rubygems.org/gems/guard-rspec","size":657,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guard:master","ref":"master","sha":"7b775662e3fa782e170a4665f8e50bb602be32dc","user":{"login":"guard","id":351846,"avatar_url":"https://avatars.githubusercontent.com/u/351846?v=3","gravatar_id":"","url":"https://api.github.com/users/guard","html_url":"https://github.com/guard","followers_url":"https://api.github.com/users/guard/followers","following_url":"https://api.github.com/users/guard/following{/other_user}","gists_url":"https://api.github.com/users/guard/gists{/gist_id}","starred_url":"https://api.github.com/users/guard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guard/subscriptions","organizations_url":"https://api.github.com/users/guard/orgs","repos_url":"https://api.github.com/users/guard/repos","events_url":"https://api.github.com/users/guard/events{/privacy}","received_events_url":"https://api.github.com/users/guard/received_events","type":"Organization","site_admin":false},"repo":{"id":959090,"name":"guard-rspec","full_name":"guard/guard-rspec","owner":{"login":"guard","id":351846,"avatar_url":"https://avatars.githubusercontent.com/u/351846?v=3","gravatar_id":"","url":"https://api.github.com/users/guard","html_url":"https://github.com/guard","followers_url":"https://api.github.com/users/guard/followers","following_url":"https://api.github.com/users/guard/following{/other_user}","gists_url":"https://api.github.com/users/guard/gists{/gist_id}","starred_url":"https://api.github.com/users/guard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guard/subscriptions","organizations_url":"https://api.github.com/users/guard/orgs","repos_url":"https://api.github.com/users/guard/repos","events_url":"https://api.github.com/users/guard/events{/privacy}","received_events_url":"https://api.github.com/users/guard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guard/guard-rspec","description":"Guard::RSpec automatically run your specs (much like autotest)","fork":false,"url":"https://api.github.com/repos/guard/guard-rspec","forks_url":"https://api.github.com/repos/guard/guard-rspec/forks","keys_url":"https://api.github.com/repos/guard/guard-rspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guard/guard-rspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guard/guard-rspec/teams","hooks_url":"https://api.github.com/repos/guard/guard-rspec/hooks","issue_events_url":"https://api.github.com/repos/guard/guard-rspec/issues/events{/number}","events_url":"https://api.github.com/repos/guard/guard-rspec/events","assignees_url":"https://api.github.com/repos/guard/guard-rspec/assignees{/user}","branches_url":"https://api.github.com/repos/guard/guard-rspec/branches{/branch}","tags_url":"https://api.github.com/repos/guard/guard-rspec/tags","blobs_url":"https://api.github.com/repos/guard/guard-rspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guard/guard-rspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guard/guard-rspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/guard/guard-rspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guard/guard-rspec/statuses/{sha}","languages_url":"https://api.github.com/repos/guard/guard-rspec/languages","stargazers_url":"https://api.github.com/repos/guard/guard-rspec/stargazers","contributors_url":"https://api.github.com/repos/guard/guard-rspec/contributors","subscribers_url":"https://api.github.com/repos/guard/guard-rspec/subscribers","subscription_url":"https://api.github.com/repos/guard/guard-rspec/subscription","commits_url":"https://api.github.com/repos/guard/guard-rspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/guard/guard-rspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/guard/guard-rspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/guard/guard-rspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/guard/guard-rspec/contents/{+path}","compare_url":"https://api.github.com/repos/guard/guard-rspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guard/guard-rspec/merges","archive_url":"https://api.github.com/repos/guard/guard-rspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guard/guard-rspec/downloads","issues_url":"https://api.github.com/repos/guard/guard-rspec/issues{/number}","pulls_url":"https://api.github.com/repos/guard/guard-rspec/pulls{/number}","milestones_url":"https://api.github.com/repos/guard/guard-rspec/milestones{/number}","notifications_url":"https://api.github.com/repos/guard/guard-rspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guard/guard-rspec/labels{/name}","releases_url":"https://api.github.com/repos/guard/guard-rspec/releases{/id}","deployments_url":"https://api.github.com/repos/guard/guard-rspec/deployments","created_at":"2010-10-03T21:10:16Z","updated_at":"2016-04-01T23:35:11Z","pushed_at":"2016-04-02T15:26:20Z","git_url":"git://github.com/guard/guard-rspec.git","ssh_url":"git@github.com:guard/guard-rspec.git","clone_url":"https://github.com/guard/guard-rspec.git","svn_url":"https://github.com/guard/guard-rspec","homepage":"https://rubygems.org/gems/guard-rspec","size":710,"stargazers_count":919,"watchers_count":919,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":194,"mirror_url":null,"open_issues_count":14,"forks":194,"open_issues":14,"watchers":919,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/363"},"html":{"href":"https://github.com/guard/guard-rspec/pull/363"},"issue":{"href":"https://api.github.com/repos/guard/guard-rspec/issues/363"},"comments":{"href":"https://api.github.com/repos/guard/guard-rspec/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guard/guard-rspec/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/guard/guard-rspec/statuses/8b8bfc1e6f665902ba429fd510554aa3a2f78648"}}}}