{"action":"created","issue":{"url":"https://api.github.com/repos/resibots/limbo/issues/154","repository_url":"https://api.github.com/repos/resibots/limbo","labels_url":"https://api.github.com/repos/resibots/limbo/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/resibots/limbo/issues/154/comments","events_url":"https://api.github.com/repos/resibots/limbo/issues/154/events","html_url":"https://github.com/resibots/limbo/pull/154","id":173148655,"number":154,"title":"Fix for #151","user":{"login":"costashatz","id":1283922,"avatar_url":"https://avatars.githubusercontent.com/u/1283922?v=3","gravatar_id":"","url":"https://api.github.com/users/costashatz","html_url":"https://github.com/costashatz","followers_url":"https://api.github.com/users/costashatz/followers","following_url":"https://api.github.com/users/costashatz/following{/other_user}","gists_url":"https://api.github.com/users/costashatz/gists{/gist_id}","starred_url":"https://api.github.com/users/costashatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costashatz/subscriptions","organizations_url":"https://api.github.com/users/costashatz/orgs","repos_url":"https://api.github.com/users/costashatz/repos","events_url":"https://api.github.com/users/costashatz/events{/privacy}","received_events_url":"https://api.github.com/users/costashatz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-08-25T08:57:59Z","updated_at":"2016-08-25T09:11:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/resibots/limbo/pulls/154","html_url":"https://github.com/resibots/limbo/pull/154","diff_url":"https://github.com/resibots/limbo/pull/154.diff","patch_url":"https://github.com/resibots/limbo/pull/154.patch"},"body":"As discussed in #151, I added a question in the FAQ. Probably it needs some rephrasing..\r\n"},"comment":{"url":"https://api.github.com/repos/resibots/limbo/issues/comments/242325493","html_url":"https://github.com/resibots/limbo/pull/154#issuecomment-242325493","issue_url":"https://api.github.com/repos/resibots/limbo/issues/154","id":242325493,"user":{"login":"jbmouret","id":6012095,"avatar_url":"https://avatars.githubusercontent.com/u/6012095?v=3","gravatar_id":"","url":"https://api.github.com/users/jbmouret","html_url":"https://github.com/jbmouret","followers_url":"https://api.github.com/users/jbmouret/followers","following_url":"https://api.github.com/users/jbmouret/following{/other_user}","gists_url":"https://api.github.com/users/jbmouret/gists{/gist_id}","starred_url":"https://api.github.com/users/jbmouret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbmouret/subscriptions","organizations_url":"https://api.github.com/users/jbmouret/orgs","repos_url":"https://api.github.com/users/jbmouret/repos","events_url":"https://api.github.com/users/jbmouret/events{/privacy}","received_events_url":"https://api.github.com/users/jbmouret/received_events","type":"User","site_admin":false},"created_at":"2016-08-25T09:11:56Z","updated_at":"2016-08-25T09:11:56Z","body":"Didn't we have a long thread about where to call the optimization?\n\nOn Thu, Aug 25, 2016 at 11:09 AM Konstantinos Chatzilygeroudis <\nnotifications@github.com> wrote:\n\n> Should we add the opposite assertion (for consistency): throw an assert if\n> we do not have NoLFOpt but hp_period == -1?\n>\n> We could. But this would go into BOptimizer and thus it is not that easy\n> to check the model type. An alternative solution would be to transfer all\n> the HP Optimization to the GP. This would mean that the hp_period would\n> be a parameter of the GP model. Then it is easy to create both assertions\n> and I think it could be cleaner for the user. What do you think?\n>\n> —\n> You are receiving this because you commented.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/resibots/limbo/pull/154#issuecomment-242324799>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AFu8v75OdbueQe_NdG3maKkWFeg4XrnEks5qjVusgaJpZM4Js14C>\n> .\n>\n"}}
{"actor":{"display_login":"jbmouret"}}