{"action":"created","comment":{"url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/comments/59054973","id":59054973,"diff_hunk":"@@ -22,7 +22,6 @@ - (void)viewDidLoad {\n - (IBAction)publisherCallButtonPressed:(UIButton *)sender {\n     if (self.oneToOneCommunicator.isCallEnabled) {\n         [self.mainView callHolderDisconnected];\n-        self.oneToOneCommunicator.isCallEnabled = NO;","path":"one-to-one-sample-app/iOS/SampleApp/MainViewController.m","position":4,"original_position":4,"commit_id":"a1f52e882e8ed4cd35f55a81c53d4fb677dd89be","original_commit_id":"a1f52e882e8ed4cd35f55a81c53d4fb677dd89be","user":{"login":"aradiquez","id":180813,"avatar_url":"https://avatars.githubusercontent.com/u/180813?v=3","gravatar_id":"","url":"https://api.github.com/users/aradiquez","html_url":"https://github.com/aradiquez","followers_url":"https://api.github.com/users/aradiquez/followers","following_url":"https://api.github.com/users/aradiquez/following{/other_user}","gists_url":"https://api.github.com/users/aradiquez/gists{/gist_id}","starred_url":"https://api.github.com/users/aradiquez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aradiquez/subscriptions","organizations_url":"https://api.github.com/users/aradiquez/orgs","repos_url":"https://api.github.com/users/aradiquez/repos","events_url":"https://api.github.com/users/aradiquez/events{/privacy}","received_events_url":"https://api.github.com/users/aradiquez/received_events","type":"User","site_admin":false},"body":"Nice, you include this code inside the connect and disconnect methods, really cool\r\n","created_at":"2016-04-08T16:49:08Z","updated_at":"2016-04-08T16:49:08Z","html_url":"https://github.com/opentok/one-to-one-sample-apps/pull/59#discussion_r59054973","pull_request_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/comments/59054973"},"html":{"href":"https://github.com/opentok/one-to-one-sample-apps/pull/59#discussion_r59054973"},"pull_request":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59","id":65743566,"html_url":"https://github.com/opentok/one-to-one-sample-apps/pull/59","diff_url":"https://github.com/opentok/one-to-one-sample-apps/pull/59.diff","patch_url":"https://github.com/opentok/one-to-one-sample-apps/pull/59.patch","issue_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues/59","number":59,"state":"open","locked":false,"title":"Hide OT logic inside the implementation file","user":{"login":"Lucashuang0802","id":3754490,"avatar_url":"https://avatars.githubusercontent.com/u/3754490?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucashuang0802","html_url":"https://github.com/Lucashuang0802","followers_url":"https://api.github.com/users/Lucashuang0802/followers","following_url":"https://api.github.com/users/Lucashuang0802/following{/other_user}","gists_url":"https://api.github.com/users/Lucashuang0802/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucashuang0802/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucashuang0802/subscriptions","organizations_url":"https://api.github.com/users/Lucashuang0802/orgs","repos_url":"https://api.github.com/users/Lucashuang0802/repos","events_url":"https://api.github.com/users/Lucashuang0802/events{/privacy}","received_events_url":"https://api.github.com/users/Lucashuang0802/received_events","type":"User","site_admin":false},"body":"***Goal***: \r\nTry to reduce the confusion from the OpenTok platform SDK\r\n\r\n***Approach***:\r\n- hide all the OpenTok logic into the implement files in `oneToOneCommunicator`\r\n- expose developer friendly APIs in `oneToOneCommunicator`\r\n\r\n***Benefit***:\r\n- developers can grab the `oneToOneCommunicator` directly and use it\r\n- convenient for us to integrate into other sample apps\r\n\r\n@marinaserranomontes @aradiquez, please review and consider give :+1:. We can follow this guide in order to allow contribution.","created_at":"2016-04-08T06:49:06Z","updated_at":"2016-04-08T16:49:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0eb3d0d056efe783230d5ccf0b84f271bc8dade8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59/commits","review_comments_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59/comments","review_comment_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues/59/comments","statuses_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/statuses/a1f52e882e8ed4cd35f55a81c53d4fb677dd89be","head":{"label":"Lucashuang0802:develop","ref":"develop","sha":"a1f52e882e8ed4cd35f55a81c53d4fb677dd89be","user":{"login":"Lucashuang0802","id":3754490,"avatar_url":"https://avatars.githubusercontent.com/u/3754490?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucashuang0802","html_url":"https://github.com/Lucashuang0802","followers_url":"https://api.github.com/users/Lucashuang0802/followers","following_url":"https://api.github.com/users/Lucashuang0802/following{/other_user}","gists_url":"https://api.github.com/users/Lucashuang0802/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucashuang0802/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucashuang0802/subscriptions","organizations_url":"https://api.github.com/users/Lucashuang0802/orgs","repos_url":"https://api.github.com/users/Lucashuang0802/repos","events_url":"https://api.github.com/users/Lucashuang0802/events{/privacy}","received_events_url":"https://api.github.com/users/Lucashuang0802/received_events","type":"User","site_admin":false},"repo":{"id":55736970,"name":"one-to-one-sample-apps-1","full_name":"Lucashuang0802/one-to-one-sample-apps-1","owner":{"login":"Lucashuang0802","id":3754490,"avatar_url":"https://avatars.githubusercontent.com/u/3754490?v=3","gravatar_id":"","url":"https://api.github.com/users/Lucashuang0802","html_url":"https://github.com/Lucashuang0802","followers_url":"https://api.github.com/users/Lucashuang0802/followers","following_url":"https://api.github.com/users/Lucashuang0802/following{/other_user}","gists_url":"https://api.github.com/users/Lucashuang0802/gists{/gist_id}","starred_url":"https://api.github.com/users/Lucashuang0802/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lucashuang0802/subscriptions","organizations_url":"https://api.github.com/users/Lucashuang0802/orgs","repos_url":"https://api.github.com/users/Lucashuang0802/repos","events_url":"https://api.github.com/users/Lucashuang0802/events{/privacy}","received_events_url":"https://api.github.com/users/Lucashuang0802/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lucashuang0802/one-to-one-sample-apps-1","description":"It includes the audio/video call component on iOS","fork":true,"url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1","forks_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/forks","keys_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/teams","hooks_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/hooks","issue_events_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/issues/events{/number}","events_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/events","assignees_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/assignees{/user}","branches_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/branches{/branch}","tags_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/tags","blobs_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/languages","stargazers_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/stargazers","contributors_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/contributors","subscribers_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/subscribers","subscription_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/subscription","commits_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/contents/{+path}","compare_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/merges","archive_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/downloads","issues_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/issues{/number}","pulls_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/labels{/name}","releases_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/releases{/id}","deployments_url":"https://api.github.com/repos/Lucashuang0802/one-to-one-sample-apps-1/deployments","created_at":"2016-04-08T00:21:39Z","updated_at":"2016-04-08T00:21:41Z","pushed_at":"2016-04-08T06:39:46Z","git_url":"git://github.com/Lucashuang0802/one-to-one-sample-apps-1.git","ssh_url":"git@github.com:Lucashuang0802/one-to-one-sample-apps-1.git","clone_url":"https://github.com/Lucashuang0802/one-to-one-sample-apps-1.git","svn_url":"https://github.com/Lucashuang0802/one-to-one-sample-apps-1","homepage":null,"size":11934,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentok:develop","ref":"develop","sha":"3753137dd20de419a31745b820f58d1cb9ef8c1b","user":{"login":"opentok","id":759567,"avatar_url":"https://avatars.githubusercontent.com/u/759567?v=3","gravatar_id":"","url":"https://api.github.com/users/opentok","html_url":"https://github.com/opentok","followers_url":"https://api.github.com/users/opentok/followers","following_url":"https://api.github.com/users/opentok/following{/other_user}","gists_url":"https://api.github.com/users/opentok/gists{/gist_id}","starred_url":"https://api.github.com/users/opentok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentok/subscriptions","organizations_url":"https://api.github.com/users/opentok/orgs","repos_url":"https://api.github.com/users/opentok/repos","events_url":"https://api.github.com/users/opentok/events{/privacy}","received_events_url":"https://api.github.com/users/opentok/received_events","type":"Organization","site_admin":false},"repo":{"id":50168495,"name":"one-to-one-sample-apps","full_name":"opentok/one-to-one-sample-apps","owner":{"login":"opentok","id":759567,"avatar_url":"https://avatars.githubusercontent.com/u/759567?v=3","gravatar_id":"","url":"https://api.github.com/users/opentok","html_url":"https://github.com/opentok","followers_url":"https://api.github.com/users/opentok/followers","following_url":"https://api.github.com/users/opentok/following{/other_user}","gists_url":"https://api.github.com/users/opentok/gists{/gist_id}","starred_url":"https://api.github.com/users/opentok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentok/subscriptions","organizations_url":"https://api.github.com/users/opentok/orgs","repos_url":"https://api.github.com/users/opentok/repos","events_url":"https://api.github.com/users/opentok/events{/privacy}","received_events_url":"https://api.github.com/users/opentok/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentok/one-to-one-sample-apps","description":"It includes the audio/video call component on iOS","fork":false,"url":"https://api.github.com/repos/opentok/one-to-one-sample-apps","forks_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/forks","keys_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/teams","hooks_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/hooks","issue_events_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues/events{/number}","events_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/events","assignees_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/assignees{/user}","branches_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/branches{/branch}","tags_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/tags","blobs_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/languages","stargazers_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/stargazers","contributors_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/contributors","subscribers_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/subscribers","subscription_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/subscription","commits_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/contents/{+path}","compare_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/merges","archive_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/downloads","issues_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues{/number}","pulls_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/labels{/name}","releases_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/releases{/id}","deployments_url":"https://api.github.com/repos/opentok/one-to-one-sample-apps/deployments","created_at":"2016-01-22T08:33:01Z","updated_at":"2016-04-04T21:15:48Z","pushed_at":"2016-04-08T08:10:31Z","git_url":"git://github.com/opentok/one-to-one-sample-apps.git","ssh_url":"git@github.com:opentok/one-to-one-sample-apps.git","clone_url":"https://github.com/opentok/one-to-one-sample-apps.git","svn_url":"https://github.com/opentok/one-to-one-sample-apps","homepage":null,"size":12865,"stargazers_count":81,"watchers_count":81,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59"},"html":{"href":"https://github.com/opentok/one-to-one-sample-apps/pull/59"},"issue":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues/59"},"comments":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/opentok/one-to-one-sample-apps/statuses/a1f52e882e8ed4cd35f55a81c53d4fb677dd89be"}}}}