{"action":"created","issue":{"url":"https://api.github.com/repos/uber/ringpop-go/issues/130","repository_url":"https://api.github.com/repos/uber/ringpop-go","labels_url":"https://api.github.com/repos/uber/ringpop-go/issues/130/labels{/name}","comments_url":"https://api.github.com/repos/uber/ringpop-go/issues/130/comments","events_url":"https://api.github.com/repos/uber/ringpop-go/issues/130/events","html_url":"https://github.com/uber/ringpop-go/pull/130","id":143218925,"number":130,"title":"Ws refactor calls disco provider wait for convergence","user":{"login":"CorgiMan","id":2640140,"avatar_url":"https://avatars.githubusercontent.com/u/2640140?v=3","gravatar_id":"","url":"https://api.github.com/users/CorgiMan","html_url":"https://github.com/CorgiMan","followers_url":"https://api.github.com/users/CorgiMan/followers","following_url":"https://api.github.com/users/CorgiMan/following{/other_user}","gists_url":"https://api.github.com/users/CorgiMan/gists{/gist_id}","starred_url":"https://api.github.com/users/CorgiMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CorgiMan/subscriptions","organizations_url":"https://api.github.com/users/CorgiMan/orgs","repos_url":"https://api.github.com/users/CorgiMan/repos","events_url":"https://api.github.com/users/CorgiMan/events{/privacy}","received_events_url":"https://api.github.com/users/CorgiMan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-24T11:12:28Z","updated_at":"2016-03-24T17:38:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uber/ringpop-go/pulls/130","html_url":"https://github.com/uber/ringpop-go/pull/130","diff_url":"https://github.com/uber/ringpop-go/pull/130.diff","patch_url":"https://github.com/uber/ringpop-go/pull/130.patch"},"body":"Some refactoring, mostly to make it easier to make calls. This is useful for the implementation of bidirectional full syncs and partition healing which will follow after this has landed.\r\n\r\n1. remove unnecessary concurrency in waitForConvergence\r\n2. add stats for tree construction time\r\n3. make discover provider part of the node and no longer part of the join sender\r\n4. add sendPingWithChanges and sendJoinRequest method\r\n5. refactor MakeCall to easier to understand sendJoinRequest/sendPing\r\n (also adds timeout via ctx.Done to sendPingWithChanges)"},"comment":{"url":"https://api.github.com/repos/uber/ringpop-go/issues/comments/200943416","html_url":"https://github.com/uber/ringpop-go/pull/130#issuecomment-200943416","issue_url":"https://api.github.com/repos/uber/ringpop-go/issues/130","id":200943416,"user":{"login":"thanodnl","id":273145,"avatar_url":"https://avatars.githubusercontent.com/u/273145?v=3","gravatar_id":"","url":"https://api.github.com/users/thanodnl","html_url":"https://github.com/thanodnl","followers_url":"https://api.github.com/users/thanodnl/followers","following_url":"https://api.github.com/users/thanodnl/following{/other_user}","gists_url":"https://api.github.com/users/thanodnl/gists{/gist_id}","starred_url":"https://api.github.com/users/thanodnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thanodnl/subscriptions","organizations_url":"https://api.github.com/users/thanodnl/orgs","repos_url":"https://api.github.com/users/thanodnl/repos","events_url":"https://api.github.com/users/thanodnl/events{/privacy}","received_events_url":"https://api.github.com/users/thanodnl/received_events","type":"User","site_admin":false},"created_at":"2016-03-24T17:38:55Z","updated_at":"2016-03-24T17:38:55Z","body":"LGTM"}}