{"action":"created","comment":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/50588103","id":50588103,"diff_hunk":"@@ -35,10 +35,10 @@ class SubversionRepository < Repository::AbstractRepository\n     # created using SubversionRepository.create(), it it is not yet existent\n     def initialize(connect_string)\n       # Check if configuration is in order\n-      if Repository.conf[:IS_REPOSITORY_ADMIN].nil?\n-        raise ConfigurationError.new(\"Required config 'IS_REPOSITORY_ADMIN' not set\")\n+      if !MarkusConfigurator.markus_config_repository_admin?","path":"lib/repo/subversion_repository.rb","position":6,"original_position":6,"commit_id":"cc683de39e9a5a1007e2d74ad6aab8a040c36357","original_commit_id":"cc683de39e9a5a1007e2d74ad6aab8a040c36357","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Favor `unless` over `if` for negative conditions.","created_at":"2016-01-22T20:41:49Z","updated_at":"2016-01-22T20:41:49Z","html_url":"https://github.com/MarkUsProject/Markus/pull/2437#discussion_r50588103","pull_request_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437","_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments/50588103"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2437#discussion_r50588103"},"pull_request":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437"}}},"pull_request":{"url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437","id":56938969,"html_url":"https://github.com/MarkUsProject/Markus/pull/2437","diff_url":"https://github.com/MarkUsProject/Markus/pull/2437.diff","patch_url":"https://github.com/MarkUsProject/Markus/pull/2437.patch","issue_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2437","number":2437,"state":"open","locked":false,"title":"All group creation bug","user":{"login":"reidka","id":420794,"avatar_url":"https://avatars.githubusercontent.com/u/420794?v=3","gravatar_id":"","url":"https://api.github.com/users/reidka","html_url":"https://github.com/reidka","followers_url":"https://api.github.com/users/reidka/followers","following_url":"https://api.github.com/users/reidka/following{/other_user}","gists_url":"https://api.github.com/users/reidka/gists{/gist_id}","starred_url":"https://api.github.com/users/reidka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidka/subscriptions","organizations_url":"https://api.github.com/users/reidka/orgs","repos_url":"https://api.github.com/users/reidka/repos","events_url":"https://api.github.com/users/reidka/events{/privacy}","received_events_url":"https://api.github.com/users/reidka/received_events","type":"User","site_admin":false},"body":"This fixes a bug where clicking on create all groups the second time (after the groups have been created) fails.  It has to do with when the Repository.conf hash gets created.\r\n\r\nThe solution is to remove the Repository.conf hash and always use MarkusConfigurator to check global settings.  This is partially accomplished in this PR.  There are still some tests that need to be changed so that they start passing again.","created_at":"2016-01-22T20:41:37Z","updated_at":"2016-01-22T20:41:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d221247bae4545c2ac3462858ab4d57ff70969ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437/commits","review_comments_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437/comments","review_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/2437/comments","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/cc683de39e9a5a1007e2d74ad6aab8a040c36357","head":{"label":"reidka:all_group_creation_bug","ref":"all_group_creation_bug","sha":"cc683de39e9a5a1007e2d74ad6aab8a040c36357","user":{"login":"reidka","id":420794,"avatar_url":"https://avatars.githubusercontent.com/u/420794?v=3","gravatar_id":"","url":"https://api.github.com/users/reidka","html_url":"https://github.com/reidka","followers_url":"https://api.github.com/users/reidka/followers","following_url":"https://api.github.com/users/reidka/following{/other_user}","gists_url":"https://api.github.com/users/reidka/gists{/gist_id}","starred_url":"https://api.github.com/users/reidka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidka/subscriptions","organizations_url":"https://api.github.com/users/reidka/orgs","repos_url":"https://api.github.com/users/reidka/repos","events_url":"https://api.github.com/users/reidka/events{/privacy}","received_events_url":"https://api.github.com/users/reidka/received_events","type":"User","site_admin":false},"repo":{"id":1260689,"name":"Markus","full_name":"reidka/Markus","owner":{"login":"reidka","id":420794,"avatar_url":"https://avatars.githubusercontent.com/u/420794?v=3","gravatar_id":"","url":"https://api.github.com/users/reidka","html_url":"https://github.com/reidka","followers_url":"https://api.github.com/users/reidka/followers","following_url":"https://api.github.com/users/reidka/following{/other_user}","gists_url":"https://api.github.com/users/reidka/gists{/gist_id}","starred_url":"https://api.github.com/users/reidka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reidka/subscriptions","organizations_url":"https://api.github.com/users/reidka/orgs","repos_url":"https://api.github.com/users/reidka/repos","events_url":"https://api.github.com/users/reidka/events{/privacy}","received_events_url":"https://api.github.com/users/reidka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reidka/Markus","description":"Git repository of MarkUs","fork":true,"url":"https://api.github.com/repos/reidka/Markus","forks_url":"https://api.github.com/repos/reidka/Markus/forks","keys_url":"https://api.github.com/repos/reidka/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reidka/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reidka/Markus/teams","hooks_url":"https://api.github.com/repos/reidka/Markus/hooks","issue_events_url":"https://api.github.com/repos/reidka/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/reidka/Markus/events","assignees_url":"https://api.github.com/repos/reidka/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/reidka/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/reidka/Markus/tags","blobs_url":"https://api.github.com/repos/reidka/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reidka/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reidka/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/reidka/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reidka/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/reidka/Markus/languages","stargazers_url":"https://api.github.com/repos/reidka/Markus/stargazers","contributors_url":"https://api.github.com/repos/reidka/Markus/contributors","subscribers_url":"https://api.github.com/repos/reidka/Markus/subscribers","subscription_url":"https://api.github.com/repos/reidka/Markus/subscription","commits_url":"https://api.github.com/repos/reidka/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/reidka/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/reidka/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/reidka/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/reidka/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/reidka/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reidka/Markus/merges","archive_url":"https://api.github.com/repos/reidka/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reidka/Markus/downloads","issues_url":"https://api.github.com/repos/reidka/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/reidka/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/reidka/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/reidka/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reidka/Markus/labels{/name}","releases_url":"https://api.github.com/repos/reidka/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/reidka/Markus/deployments","created_at":"2011-01-16T16:10:09Z","updated_at":"2015-04-11T14:35:11Z","pushed_at":"2016-01-22T20:39:11Z","git_url":"git://github.com/reidka/Markus.git","ssh_url":"git@github.com:reidka/Markus.git","clone_url":"https://github.com/reidka/Markus.git","svn_url":"https://github.com/reidka/Markus","homepage":"http://www.markusproject.org","size":23497,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"MarkUsProject:master","ref":"master","sha":"62ac821a9599113aa0fba9fe322c8c0b52f9af54","user":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":940538,"name":"Markus","full_name":"MarkUsProject/Markus","owner":{"login":"MarkUsProject","id":415874,"avatar_url":"https://avatars.githubusercontent.com/u/415874?v=3","gravatar_id":"","url":"https://api.github.com/users/MarkUsProject","html_url":"https://github.com/MarkUsProject","followers_url":"https://api.github.com/users/MarkUsProject/followers","following_url":"https://api.github.com/users/MarkUsProject/following{/other_user}","gists_url":"https://api.github.com/users/MarkUsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkUsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkUsProject/subscriptions","organizations_url":"https://api.github.com/users/MarkUsProject/orgs","repos_url":"https://api.github.com/users/MarkUsProject/repos","events_url":"https://api.github.com/users/MarkUsProject/events{/privacy}","received_events_url":"https://api.github.com/users/MarkUsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarkUsProject/Markus","description":"Git repository of MarkUs","fork":false,"url":"https://api.github.com/repos/MarkUsProject/Markus","forks_url":"https://api.github.com/repos/MarkUsProject/Markus/forks","keys_url":"https://api.github.com/repos/MarkUsProject/Markus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarkUsProject/Markus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarkUsProject/Markus/teams","hooks_url":"https://api.github.com/repos/MarkUsProject/Markus/hooks","issue_events_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/events{/number}","events_url":"https://api.github.com/repos/MarkUsProject/Markus/events","assignees_url":"https://api.github.com/repos/MarkUsProject/Markus/assignees{/user}","branches_url":"https://api.github.com/repos/MarkUsProject/Markus/branches{/branch}","tags_url":"https://api.github.com/repos/MarkUsProject/Markus/tags","blobs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarkUsProject/Markus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarkUsProject/Markus/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarkUsProject/Markus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarkUsProject/Markus/statuses/{sha}","languages_url":"https://api.github.com/repos/MarkUsProject/Markus/languages","stargazers_url":"https://api.github.com/repos/MarkUsProject/Markus/stargazers","contributors_url":"https://api.github.com/repos/MarkUsProject/Markus/contributors","subscribers_url":"https://api.github.com/repos/MarkUsProject/Markus/subscribers","subscription_url":"https://api.github.com/repos/MarkUsProject/Markus/subscription","commits_url":"https://api.github.com/repos/MarkUsProject/Markus/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarkUsProject/Markus/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarkUsProject/Markus/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarkUsProject/Markus/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarkUsProject/Markus/contents/{+path}","compare_url":"https://api.github.com/repos/MarkUsProject/Markus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarkUsProject/Markus/merges","archive_url":"https://api.github.com/repos/MarkUsProject/Markus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarkUsProject/Markus/downloads","issues_url":"https://api.github.com/repos/MarkUsProject/Markus/issues{/number}","pulls_url":"https://api.github.com/repos/MarkUsProject/Markus/pulls{/number}","milestones_url":"https://api.github.com/repos/MarkUsProject/Markus/milestones{/number}","notifications_url":"https://api.github.com/repos/MarkUsProject/Markus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarkUsProject/Markus/labels{/name}","releases_url":"https://api.github.com/repos/MarkUsProject/Markus/releases{/id}","deployments_url":"https://api.github.com/repos/MarkUsProject/Markus/deployments","created_at":"2010-09-26T16:18:08Z","updated_at":"2016-01-13T17:46:31Z","pushed_at":"2016-01-22T20:41:37Z","git_url":"git://github.com/MarkUsProject/Markus.git","ssh_url":"git@github.com:MarkUsProject/Markus.git","clone_url":"https://github.com/MarkUsProject/Markus.git","svn_url":"https://github.com/MarkUsProject/Markus","homepage":"http://www.markusproject.org","size":32765,"stargazers_count":134,"watchers_count":134,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":92,"forks":167,"open_issues":92,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437"},"html":{"href":"https://github.com/MarkUsProject/Markus/pull/2437"},"issue":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2437"},"comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/issues/2437/comments"},"review_comments":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437/comments"},"review_comment":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarkUsProject/Markus/pulls/2437/commits"},"statuses":{"href":"https://api.github.com/repos/MarkUsProject/Markus/statuses/cc683de39e9a5a1007e2d74ad6aab8a040c36357"}}}}