{"action":"closed","number":6152,"pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/6152","id":74605675,"html_url":"https://github.com/sequelize/sequelize/pull/6152","diff_url":"https://github.com/sequelize/sequelize/pull/6152.diff","patch_url":"https://github.com/sequelize/sequelize/pull/6152.patch","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/6152","number":6152,"state":"closed","locked":false,"title":"Fix #6148, Ignore the group on findAndCountAll","user":{"login":"sushantdhiman","id":9989487,"avatar_url":"https://avatars.githubusercontent.com/u/9989487?v=3","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"body":"### Pull Request check-list\r\n\r\n- [x] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [x] Does your issue contain a link to existing issue (Closes #[issue]) or a description of the issue you are solving?\r\n- [x] Have you added new tests to prevent regressions?\r\n- [x] Have you added an entry under `Future` in the changelog?\r\n\r\n### Description of change\r\n\r\nCloses #6148\r\n\r\n`findAndCountAll` now ignores `group` for count\r\n\r\n","created_at":"2016-06-21T12:51:03Z","updated_at":"2016-06-21T13:17:45Z","closed_at":"2016-06-21T13:17:45Z","merged_at":null,"merge_commit_sha":"d8b2b4ecf26c9efb2e085d72eab0c048783a62b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sequelize/sequelize/pulls/6152/commits","review_comments_url":"https://api.github.com/repos/sequelize/sequelize/pulls/6152/comments","review_comment_url":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/6152/comments","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/4b99c51a2c8e1f095baa3d08d3c58bd9500d82f9","head":{"label":"sushantdhiman:fix-6148","ref":"fix-6148","sha":"4b99c51a2c8e1f095baa3d08d3c58bd9500d82f9","user":{"login":"sushantdhiman","id":9989487,"avatar_url":"https://avatars.githubusercontent.com/u/9989487?v=3","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"repo":{"id":40614166,"name":"sequelize","full_name":"sushantdhiman/sequelize","owner":{"login":"sushantdhiman","id":9989487,"avatar_url":"https://avatars.githubusercontent.com/u/9989487?v=3","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sushantdhiman/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":true,"url":"https://api.github.com/repos/sushantdhiman/sequelize","forks_url":"https://api.github.com/repos/sushantdhiman/sequelize/forks","keys_url":"https://api.github.com/repos/sushantdhiman/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sushantdhiman/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sushantdhiman/sequelize/teams","hooks_url":"https://api.github.com/repos/sushantdhiman/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sushantdhiman/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sushantdhiman/sequelize/events","assignees_url":"https://api.github.com/repos/sushantdhiman/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sushantdhiman/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sushantdhiman/sequelize/tags","blobs_url":"https://api.github.com/repos/sushantdhiman/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sushantdhiman/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sushantdhiman/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sushantdhiman/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sushantdhiman/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sushantdhiman/sequelize/languages","stargazers_url":"https://api.github.com/repos/sushantdhiman/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sushantdhiman/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sushantdhiman/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sushantdhiman/sequelize/subscription","commits_url":"https://api.github.com/repos/sushantdhiman/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sushantdhiman/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sushantdhiman/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sushantdhiman/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sushantdhiman/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sushantdhiman/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sushantdhiman/sequelize/merges","archive_url":"https://api.github.com/repos/sushantdhiman/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sushantdhiman/sequelize/downloads","issues_url":"https://api.github.com/repos/sushantdhiman/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sushantdhiman/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sushantdhiman/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sushantdhiman/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sushantdhiman/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sushantdhiman/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sushantdhiman/sequelize/deployments","created_at":"2015-08-12T17:19:43Z","updated_at":"2016-01-14T12:44:05Z","pushed_at":"2016-06-21T12:49:22Z","git_url":"git://github.com/sushantdhiman/sequelize.git","ssh_url":"git@github.com:sushantdhiman/sequelize.git","clone_url":"https://github.com/sushantdhiman/sequelize.git","svn_url":"https://github.com/sushantdhiman/sequelize","homepage":"http://sequelizejs.com","size":18137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sequelize:master","ref":"master","sha":"1a56d7e8cf0e9b9ae1a4aee2f5052e11bb09e64f","user":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"repo":{"id":790359,"name":"sequelize","full_name":"sequelize/sequelize","owner":{"login":"sequelize","id":3591786,"avatar_url":"https://avatars.githubusercontent.com/u/3591786?v=3","gravatar_id":"","url":"https://api.github.com/users/sequelize","html_url":"https://github.com/sequelize","followers_url":"https://api.github.com/users/sequelize/followers","following_url":"https://api.github.com/users/sequelize/following{/other_user}","gists_url":"https://api.github.com/users/sequelize/gists{/gist_id}","starred_url":"https://api.github.com/users/sequelize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sequelize/subscriptions","organizations_url":"https://api.github.com/users/sequelize/orgs","repos_url":"https://api.github.com/users/sequelize/repos","events_url":"https://api.github.com/users/sequelize/events{/privacy}","received_events_url":"https://api.github.com/users/sequelize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sequelize/sequelize","description":"Sequelize is an easy-to-use multi sql dialect ORM for Node.js & io.js. It currently supports MySQL, MariaDB, SQLite, PostgreSQL and MSSQL.","fork":false,"url":"https://api.github.com/repos/sequelize/sequelize","forks_url":"https://api.github.com/repos/sequelize/sequelize/forks","keys_url":"https://api.github.com/repos/sequelize/sequelize/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sequelize/sequelize/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sequelize/sequelize/teams","hooks_url":"https://api.github.com/repos/sequelize/sequelize/hooks","issue_events_url":"https://api.github.com/repos/sequelize/sequelize/issues/events{/number}","events_url":"https://api.github.com/repos/sequelize/sequelize/events","assignees_url":"https://api.github.com/repos/sequelize/sequelize/assignees{/user}","branches_url":"https://api.github.com/repos/sequelize/sequelize/branches{/branch}","tags_url":"https://api.github.com/repos/sequelize/sequelize/tags","blobs_url":"https://api.github.com/repos/sequelize/sequelize/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sequelize/sequelize/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sequelize/sequelize/git/refs{/sha}","trees_url":"https://api.github.com/repos/sequelize/sequelize/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sequelize/sequelize/statuses/{sha}","languages_url":"https://api.github.com/repos/sequelize/sequelize/languages","stargazers_url":"https://api.github.com/repos/sequelize/sequelize/stargazers","contributors_url":"https://api.github.com/repos/sequelize/sequelize/contributors","subscribers_url":"https://api.github.com/repos/sequelize/sequelize/subscribers","subscription_url":"https://api.github.com/repos/sequelize/sequelize/subscription","commits_url":"https://api.github.com/repos/sequelize/sequelize/commits{/sha}","git_commits_url":"https://api.github.com/repos/sequelize/sequelize/git/commits{/sha}","comments_url":"https://api.github.com/repos/sequelize/sequelize/comments{/number}","issue_comment_url":"https://api.github.com/repos/sequelize/sequelize/issues/comments{/number}","contents_url":"https://api.github.com/repos/sequelize/sequelize/contents/{+path}","compare_url":"https://api.github.com/repos/sequelize/sequelize/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sequelize/sequelize/merges","archive_url":"https://api.github.com/repos/sequelize/sequelize/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sequelize/sequelize/downloads","issues_url":"https://api.github.com/repos/sequelize/sequelize/issues{/number}","pulls_url":"https://api.github.com/repos/sequelize/sequelize/pulls{/number}","milestones_url":"https://api.github.com/repos/sequelize/sequelize/milestones{/number}","notifications_url":"https://api.github.com/repos/sequelize/sequelize/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sequelize/sequelize/labels{/name}","releases_url":"https://api.github.com/repos/sequelize/sequelize/releases{/id}","deployments_url":"https://api.github.com/repos/sequelize/sequelize/deployments","created_at":"2010-07-22T07:11:11Z","updated_at":"2016-06-21T11:57:38Z","pushed_at":"2016-06-21T12:51:04Z","git_url":"git://github.com/sequelize/sequelize.git","ssh_url":"git@github.com:sequelize/sequelize.git","clone_url":"https://github.com/sequelize/sequelize.git","svn_url":"https://github.com/sequelize/sequelize","homepage":"http://sequelizejs.com","size":54833,"stargazers_count":6818,"watchers_count":6818,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1413,"mirror_url":null,"open_issues_count":675,"forks":1413,"open_issues":675,"watchers":6818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6152"},"html":{"href":"https://github.com/sequelize/sequelize/pull/6152"},"issue":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/6152"},"comments":{"href":"https://api.github.com/repos/sequelize/sequelize/issues/6152/comments"},"review_comments":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6152/comments"},"review_comment":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sequelize/sequelize/pulls/6152/commits"},"statuses":{"href":"https://api.github.com/repos/sequelize/sequelize/statuses/4b99c51a2c8e1f095baa3d08d3c58bd9500d82f9"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":12,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"sushantdhiman"}}