{"action":"created","issue":{"url":"https://api.github.com/repos/akiran/react-slick/issues/272","repository_url":"https://api.github.com/repos/akiran/react-slick","labels_url":"https://api.github.com/repos/akiran/react-slick/issues/272/labels{/name}","comments_url":"https://api.github.com/repos/akiran/react-slick/issues/272/comments","events_url":"https://api.github.com/repos/akiran/react-slick/issues/272/events","html_url":"https://github.com/akiran/react-slick/pull/272","id":145373847,"number":272,"title":"Improve slide movement trigger logic","user":{"login":"jonathanewerner","id":3755413,"avatar_url":"https://avatars.githubusercontent.com/u/3755413?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanewerner","html_url":"https://github.com/jonathanewerner","followers_url":"https://api.github.com/users/jonathanewerner/followers","following_url":"https://api.github.com/users/jonathanewerner/following{/other_user}","gists_url":"https://api.github.com/users/jonathanewerner/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanewerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanewerner/subscriptions","organizations_url":"https://api.github.com/users/jonathanewerner/orgs","repos_url":"https://api.github.com/users/jonathanewerner/repos","events_url":"https://api.github.com/users/jonathanewerner/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanewerner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-04-02T13:36:40Z","updated_at":"2016-11-03T10:30:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/akiran/react-slick/pulls/272","html_url":"https://github.com/akiran/react-slick/pull/272","diff_url":"https://github.com/akiran/react-slick/pull/272.diff","patch_url":"https://github.com/akiran/react-slick/pull/272.patch"},"body":"We're using react-slick for http://wish.technology/en/features. It's been quite nice, so thanks for your work on this library!\nThere have been some minor issues, though. One of them is the slide movement trigger logic. As you might see when using our website on a touch device (i'll switch the npm version with this PR though soon, so it might not be visible in 2 days), the sliders are way to \"trigger-happy\", meaning that they activate although i just want to scroll down the page. \nI tried to grok the code and optimize the behaviour so that this trigger-happyness is not an issue anymore.\nI would assume that this could be a general benefit for the library, which is why i PR'd this and not just left it in a private fork.\n\nInterestingly, the relevant check had been implemented _after_ the `setState` that modifies the tracks left position, making it effectively a noop if i'm not mistaken.\n\nSo basically, i changed the code order so that the check comes _before_ said `setState` and tuned the constant to be more \"ergonomic\" + explained in code what makes it ergonomic (imo). :)\n\nWhat do you think?\n"},"comment":{"url":"https://api.github.com/repos/akiran/react-slick/issues/comments/258107939","html_url":"https://github.com/akiran/react-slick/pull/272#issuecomment-258107939","issue_url":"https://api.github.com/repos/akiran/react-slick/issues/272","id":258107939,"user":{"login":"daniel-rabe","id":4725895,"avatar_url":"https://avatars.githubusercontent.com/u/4725895?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-rabe","html_url":"https://github.com/daniel-rabe","followers_url":"https://api.github.com/users/daniel-rabe/followers","following_url":"https://api.github.com/users/daniel-rabe/following{/other_user}","gists_url":"https://api.github.com/users/daniel-rabe/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-rabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-rabe/subscriptions","organizations_url":"https://api.github.com/users/daniel-rabe/orgs","repos_url":"https://api.github.com/users/daniel-rabe/repos","events_url":"https://api.github.com/users/daniel-rabe/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-rabe/received_events","type":"User","site_admin":false},"created_at":"2016-11-03T10:30:07Z","updated_at":"2016-11-03T10:30:07Z","body":"we have the same problem; if scrolled in a slide the slide shouldn´t move. your solution helps, but has one problem; if the user swipes the \"correct\" way and continues to swipe in the \"incorrect\" way (e.g. to left and then down) the slider stucks in between two slides"}}
{"actor":{"display_login":"daniel-rabe"}}