{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/tslint/issues/1701","repository_url":"https://api.github.com/repos/palantir/tslint","labels_url":"https://api.github.com/repos/palantir/tslint/issues/1701/labels{/name}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/1701/comments","events_url":"https://api.github.com/repos/palantir/tslint/issues/1701/events","html_url":"https://github.com/palantir/tslint/pull/1701","id":188401470,"number":1701,"title":"Use denormalized path in test (fixes Windows build)","user":{"login":"IllusionMH","id":1312662,"avatar_url":"https://avatars.githubusercontent.com/u/1312662?v=3","gravatar_id":"","url":"https://api.github.com/users/IllusionMH","html_url":"https://github.com/IllusionMH","followers_url":"https://api.github.com/users/IllusionMH/followers","following_url":"https://api.github.com/users/IllusionMH/following{/other_user}","gists_url":"https://api.github.com/users/IllusionMH/gists{/gist_id}","starred_url":"https://api.github.com/users/IllusionMH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllusionMH/subscriptions","organizations_url":"https://api.github.com/users/IllusionMH/orgs","repos_url":"https://api.github.com/users/IllusionMH/repos","events_url":"https://api.github.com/users/IllusionMH/events{/privacy}","received_events_url":"https://api.github.com/users/IllusionMH/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-10T01:59:08Z","updated_at":"2016-11-10T03:59:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/1701","html_url":"https://github.com/palantir/tslint/pull/1701","diff_url":"https://github.com/palantir/tslint/pull/1701.diff","patch_url":"https://github.com/palantir/tslint/pull/1701.patch"},"body":"#### PR checklist\r\n\r\n- [ ] Addresses an existing issue: #0000\r\n- [X] ~~New feature,~~ bugfix, ~~or enhancement~~\r\n  - [ ] Includes tests\r\n- [ ] Documentation update\r\n\r\n#### What changes did you make?\r\n\r\nCurrently build fails since normalized path returned from Node.js API (with `\\` as path separator) is compared to deormalized one (with `/` as path separator, which is also valid on Windows) which was picked from TypeScript.\r\n\r\nThis PR fixes build on Windows by converting normalized path to denormalized and using it in comparison.\r\n\r\n\r\n#### Is there anything you'd like reviewers to focus on?\r\n\r\nI've reviewed 3 possible solutions:\r\n\r\n1. Normalize `fileName`'s when they are stored in `RuleFailure` class (used only in formatters) \r\n\r\n1. Normalize only absolute `fileName`'s when they are stored in `RuleFailure` class (probably rare case, but matches problem in test)\r\n\r\n1. Use denormalized path in test\r\n\r\nWhile first two solution fix problem, I think they bring almost no value and will lead to inconsistency in paths output between platforms."},"comment":{"url":"https://api.github.com/repos/palantir/tslint/issues/comments/259596279","html_url":"https://github.com/palantir/tslint/pull/1701#issuecomment-259596279","issue_url":"https://api.github.com/repos/palantir/tslint/issues/1701","id":259596279,"user":{"login":"IllusionMH","id":1312662,"avatar_url":"https://avatars.githubusercontent.com/u/1312662?v=3","gravatar_id":"","url":"https://api.github.com/users/IllusionMH","html_url":"https://github.com/IllusionMH","followers_url":"https://api.github.com/users/IllusionMH/followers","following_url":"https://api.github.com/users/IllusionMH/following{/other_user}","gists_url":"https://api.github.com/users/IllusionMH/gists{/gist_id}","starred_url":"https://api.github.com/users/IllusionMH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IllusionMH/subscriptions","organizations_url":"https://api.github.com/users/IllusionMH/orgs","repos_url":"https://api.github.com/users/IllusionMH/repos","events_url":"https://api.github.com/users/IllusionMH/events{/privacy}","received_events_url":"https://api.github.com/users/IllusionMH/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T03:59:02Z","updated_at":"2016-11-10T03:59:02Z","body":"@nchen63 thank you for review. Next time I will look more carefully to avoid such typos."}}
{"actor":{"display_login":"IllusionMH"}}