{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/loop/pulls/comments/64776134","id":64776134,"diff_hunk":"@@ -149,6 +152,18 @@ loop.DataDriver = function() {\n             console.log(`Error handling EventSource.put: ${event.data}`, ex);\n           }\n           break;\n+\n+        // Handle an error from being unable to initially connect or\n+        // unexpected disconnection of an open connection.\n+        case \"error\":\n+          if (this._sse.readyState === this._sse.CLOSED) {\n+            this._sse.removeEventListener(\"open\", this);\n+            this._sse.removeEventListener(\"put\", this);\n+            this._sse.removeEventListener(\"error\", this);\n+            setTimeout(() => this._connectToRoom(this._roomToken), this._retryTimeout);","path":"shared/js/dataDriver.js","position":29,"original_position":29,"commit_id":"2cea4d49ceb65ec3f7c11fd67cb67a502751bcd8","original_commit_id":"2cea4d49ceb65ec3f7c11fd67cb67a502751bcd8","user":{"login":"Mardak","id":438537,"avatar_url":"https://avatars.githubusercontent.com/u/438537?v=3","gravatar_id":"","url":"https://api.github.com/users/Mardak","html_url":"https://github.com/Mardak","followers_url":"https://api.github.com/users/Mardak/followers","following_url":"https://api.github.com/users/Mardak/following{/other_user}","gists_url":"https://api.github.com/users/Mardak/gists{/gist_id}","starred_url":"https://api.github.com/users/Mardak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mardak/subscriptions","organizations_url":"https://api.github.com/users/Mardak/orgs","repos_url":"https://api.github.com/users/Mardak/repos","events_url":"https://api.github.com/users/Mardak/events{/privacy}","received_events_url":"https://api.github.com/users/Mardak/received_events","type":"User","site_admin":false},"body":"Eh.. given that this is an internal API, might as well shorten this to `this._connectToRoom()` and update the definition `_connectToRoom(token = this._roomToken)` and updated doc comments for the method.","created_at":"2016-05-26T16:22:41Z","updated_at":"2016-05-26T16:22:41Z","html_url":"https://github.com/mozilla/loop/pull/441#discussion_r64776134","pull_request_url":"https://api.github.com/repos/mozilla/loop/pulls/441","_links":{"self":{"href":"https://api.github.com/repos/mozilla/loop/pulls/comments/64776134"},"html":{"href":"https://github.com/mozilla/loop/pull/441#discussion_r64776134"},"pull_request":{"href":"https://api.github.com/repos/mozilla/loop/pulls/441"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/loop/pulls/441","id":70778477,"html_url":"https://github.com/mozilla/loop/pull/441","diff_url":"https://github.com/mozilla/loop/pull/441.diff","patch_url":"https://github.com/mozilla/loop/pull/441.patch","issue_url":"https://api.github.com/repos/mozilla/loop/issues/441","number":441,"state":"open","locked":false,"title":"Bug 1274182 - Handle unexpected closing/disconnection from firebase a…","user":{"login":"fzzzy","id":46048,"avatar_url":"https://avatars.githubusercontent.com/u/46048?v=3","gravatar_id":"","url":"https://api.github.com/users/fzzzy","html_url":"https://github.com/fzzzy","followers_url":"https://api.github.com/users/fzzzy/followers","following_url":"https://api.github.com/users/fzzzy/following{/other_user}","gists_url":"https://api.github.com/users/fzzzy/gists{/gist_id}","starred_url":"https://api.github.com/users/fzzzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzzzy/subscriptions","organizations_url":"https://api.github.com/users/fzzzy/orgs","repos_url":"https://api.github.com/users/fzzzy/repos","events_url":"https://api.github.com/users/fzzzy/events{/privacy}","received_events_url":"https://api.github.com/users/fzzzy/received_events","type":"User","site_admin":false},"body":"…nd reconnect","created_at":"2016-05-19T22:53:27Z","updated_at":"2016-05-26T16:22:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36ce7ff75fb0f563161f66373715264178133aad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/loop/pulls/441/commits","review_comments_url":"https://api.github.com/repos/mozilla/loop/pulls/441/comments","review_comment_url":"https://api.github.com/repos/mozilla/loop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/loop/issues/441/comments","statuses_url":"https://api.github.com/repos/mozilla/loop/statuses/2cea4d49ceb65ec3f7c11fd67cb67a502751bcd8","head":{"label":"fzzzy:firebaseReconnect","ref":"firebaseReconnect","sha":"2cea4d49ceb65ec3f7c11fd67cb67a502751bcd8","user":{"login":"fzzzy","id":46048,"avatar_url":"https://avatars.githubusercontent.com/u/46048?v=3","gravatar_id":"","url":"https://api.github.com/users/fzzzy","html_url":"https://github.com/fzzzy","followers_url":"https://api.github.com/users/fzzzy/followers","following_url":"https://api.github.com/users/fzzzy/following{/other_user}","gists_url":"https://api.github.com/users/fzzzy/gists{/gist_id}","starred_url":"https://api.github.com/users/fzzzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzzzy/subscriptions","organizations_url":"https://api.github.com/users/fzzzy/orgs","repos_url":"https://api.github.com/users/fzzzy/repos","events_url":"https://api.github.com/users/fzzzy/events{/privacy}","received_events_url":"https://api.github.com/users/fzzzy/received_events","type":"User","site_admin":false},"repo":{"id":56186573,"name":"loop","full_name":"fzzzy/loop","owner":{"login":"fzzzy","id":46048,"avatar_url":"https://avatars.githubusercontent.com/u/46048?v=3","gravatar_id":"","url":"https://api.github.com/users/fzzzy","html_url":"https://github.com/fzzzy","followers_url":"https://api.github.com/users/fzzzy/followers","following_url":"https://api.github.com/users/fzzzy/following{/other_user}","gists_url":"https://api.github.com/users/fzzzy/gists{/gist_id}","starred_url":"https://api.github.com/users/fzzzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fzzzy/subscriptions","organizations_url":"https://api.github.com/users/fzzzy/orgs","repos_url":"https://api.github.com/users/fzzzy/repos","events_url":"https://api.github.com/users/fzzzy/events{/privacy}","received_events_url":"https://api.github.com/users/fzzzy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fzzzy/loop","description":"This is the development repository for Firefox Hello","fork":true,"url":"https://api.github.com/repos/fzzzy/loop","forks_url":"https://api.github.com/repos/fzzzy/loop/forks","keys_url":"https://api.github.com/repos/fzzzy/loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fzzzy/loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fzzzy/loop/teams","hooks_url":"https://api.github.com/repos/fzzzy/loop/hooks","issue_events_url":"https://api.github.com/repos/fzzzy/loop/issues/events{/number}","events_url":"https://api.github.com/repos/fzzzy/loop/events","assignees_url":"https://api.github.com/repos/fzzzy/loop/assignees{/user}","branches_url":"https://api.github.com/repos/fzzzy/loop/branches{/branch}","tags_url":"https://api.github.com/repos/fzzzy/loop/tags","blobs_url":"https://api.github.com/repos/fzzzy/loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fzzzy/loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fzzzy/loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/fzzzy/loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fzzzy/loop/statuses/{sha}","languages_url":"https://api.github.com/repos/fzzzy/loop/languages","stargazers_url":"https://api.github.com/repos/fzzzy/loop/stargazers","contributors_url":"https://api.github.com/repos/fzzzy/loop/contributors","subscribers_url":"https://api.github.com/repos/fzzzy/loop/subscribers","subscription_url":"https://api.github.com/repos/fzzzy/loop/subscription","commits_url":"https://api.github.com/repos/fzzzy/loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/fzzzy/loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/fzzzy/loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/fzzzy/loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/fzzzy/loop/contents/{+path}","compare_url":"https://api.github.com/repos/fzzzy/loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fzzzy/loop/merges","archive_url":"https://api.github.com/repos/fzzzy/loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fzzzy/loop/downloads","issues_url":"https://api.github.com/repos/fzzzy/loop/issues{/number}","pulls_url":"https://api.github.com/repos/fzzzy/loop/pulls{/number}","milestones_url":"https://api.github.com/repos/fzzzy/loop/milestones{/number}","notifications_url":"https://api.github.com/repos/fzzzy/loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fzzzy/loop/labels{/name}","releases_url":"https://api.github.com/repos/fzzzy/loop/releases{/id}","deployments_url":"https://api.github.com/repos/fzzzy/loop/deployments","created_at":"2016-04-13T21:13:57Z","updated_at":"2016-04-13T21:13:59Z","pushed_at":"2016-05-25T17:24:05Z","git_url":"git://github.com/fzzzy/loop.git","ssh_url":"git@github.com:fzzzy/loop.git","clone_url":"https://github.com/fzzzy/loop.git","svn_url":"https://github.com/fzzzy/loop","homepage":"https://wiki.mozilla.org/Loop","size":16602,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:akita","ref":"akita","sha":"e120d3248ebcb2c155c0b64d0ef9ff904fa362ea","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":45496273,"name":"loop","full_name":"mozilla/loop","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/loop","description":"This is the development repository for Firefox Hello","fork":false,"url":"https://api.github.com/repos/mozilla/loop","forks_url":"https://api.github.com/repos/mozilla/loop/forks","keys_url":"https://api.github.com/repos/mozilla/loop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/loop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/loop/teams","hooks_url":"https://api.github.com/repos/mozilla/loop/hooks","issue_events_url":"https://api.github.com/repos/mozilla/loop/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/loop/events","assignees_url":"https://api.github.com/repos/mozilla/loop/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/loop/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/loop/tags","blobs_url":"https://api.github.com/repos/mozilla/loop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/loop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/loop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/loop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/loop/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/loop/languages","stargazers_url":"https://api.github.com/repos/mozilla/loop/stargazers","contributors_url":"https://api.github.com/repos/mozilla/loop/contributors","subscribers_url":"https://api.github.com/repos/mozilla/loop/subscribers","subscription_url":"https://api.github.com/repos/mozilla/loop/subscription","commits_url":"https://api.github.com/repos/mozilla/loop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/loop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/loop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/loop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/loop/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/loop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/loop/merges","archive_url":"https://api.github.com/repos/mozilla/loop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/loop/downloads","issues_url":"https://api.github.com/repos/mozilla/loop/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/loop/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/loop/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/loop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/loop/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/loop/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/loop/deployments","created_at":"2015-11-03T21:18:47Z","updated_at":"2016-05-21T23:46:25Z","pushed_at":"2016-05-26T14:37:56Z","git_url":"git://github.com/mozilla/loop.git","ssh_url":"git@github.com:mozilla/loop.git","clone_url":"https://github.com/mozilla/loop.git","svn_url":"https://github.com/mozilla/loop","homepage":"https://wiki.mozilla.org/Loop","size":17036,"stargazers_count":12,"watchers_count":12,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":15,"forks":29,"open_issues":15,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/loop/pulls/441"},"html":{"href":"https://github.com/mozilla/loop/pull/441"},"issue":{"href":"https://api.github.com/repos/mozilla/loop/issues/441"},"comments":{"href":"https://api.github.com/repos/mozilla/loop/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/loop/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/loop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/loop/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/loop/statuses/2cea4d49ceb65ec3f7c11fd67cb67a502751bcd8"}}}}
{"actor":{"display_login":"Mardak"}}