{"action":"created","issue":{"url":"https://api.github.com/repos/priologic/easyrtc/issues/281","repository_url":"https://api.github.com/repos/priologic/easyrtc","labels_url":"https://api.github.com/repos/priologic/easyrtc/issues/281/labels{/name}","comments_url":"https://api.github.com/repos/priologic/easyrtc/issues/281/comments","events_url":"https://api.github.com/repos/priologic/easyrtc/issues/281/events","html_url":"https://github.com/priologic/easyrtc/issues/281","id":187930506,"number":281,"title":"Large file transfer is not reliable.","user":{"login":"MariasStory","id":6576335,"avatar_url":"https://avatars.githubusercontent.com/u/6576335?v=3","gravatar_id":"","url":"https://api.github.com/users/MariasStory","html_url":"https://github.com/MariasStory","followers_url":"https://api.github.com/users/MariasStory/followers","following_url":"https://api.github.com/users/MariasStory/following{/other_user}","gists_url":"https://api.github.com/users/MariasStory/gists{/gist_id}","starred_url":"https://api.github.com/users/MariasStory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MariasStory/subscriptions","organizations_url":"https://api.github.com/users/MariasStory/orgs","repos_url":"https://api.github.com/users/MariasStory/repos","events_url":"https://api.github.com/users/MariasStory/events{/privacy}","received_events_url":"https://api.github.com/users/MariasStory/received_events","type":"User","site_admin":false},"labels":[{"id":21753491,"url":"https://api.github.com/repos/priologic/easyrtc/labels/bug","name":"bug","color":"fc2929","default":true},{"id":28464372,"url":"https://api.github.com/repos/priologic/easyrtc/labels/client%20api","name":"client api","color":"e102d8","default":false},{"id":360461144,"url":"https://api.github.com/repos/priologic/easyrtc/labels/regression","name":"regression","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2016-11-08T08:32:50Z","updated_at":"2016-11-10T17:01:41Z","closed_at":null,"body":"Hi,\r\n\r\nThe file transfer was reasonably working with reasonably big files till the last update. After the last stable update, I had the file transfer stopped after several hundreds of kilobytes. I did not do detailed testing yet.\r\n\r\nI would really like to have the file transfer function streamlined. I hope that you will have the time and desire to update the file transfer functionality, so that transfer of big files and continuation of transfer will be feasible.\r\n\r\nSome ideas?\r\n\r\nGreetings,\r\nTolik"},"comment":{"url":"https://api.github.com/repos/priologic/easyrtc/issues/comments/259746364","html_url":"https://github.com/priologic/easyrtc/issues/281#issuecomment-259746364","issue_url":"https://api.github.com/repos/priologic/easyrtc/issues/281","id":259746364,"user":{"login":"EricDavies","id":2856071,"avatar_url":"https://avatars.githubusercontent.com/u/2856071?v=3","gravatar_id":"","url":"https://api.github.com/users/EricDavies","html_url":"https://github.com/EricDavies","followers_url":"https://api.github.com/users/EricDavies/followers","following_url":"https://api.github.com/users/EricDavies/following{/other_user}","gists_url":"https://api.github.com/users/EricDavies/gists{/gist_id}","starred_url":"https://api.github.com/users/EricDavies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricDavies/subscriptions","organizations_url":"https://api.github.com/users/EricDavies/orgs","repos_url":"https://api.github.com/users/EricDavies/repos","events_url":"https://api.github.com/users/EricDavies/events{/privacy}","received_events_url":"https://api.github.com/users/EricDavies/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T17:01:41Z","updated_at":"2016-11-10T17:01:41Z","body":"@gloryknight\r\nI'm happy to see community contributions. You won't be the first. In general, I would suggest posting about a planned improvement/enhancement first to make sure somebody else isn't working on the same issue first. Harold is pretty much in charge of handling pull requests (which is to say, I'm pretty certain I'll break something if I try to merge a pull).\r\n    guidelines:\r\n       1)  easyrtc.js is built from adapter.js and easyrtc_int.js, so never edit easyrtc.js. Either edit easyrtc_int.js or coordinate with the people who manage adapter.js (it's a different project, different people).\r\n       2) the master branch is a snapshot of the beta branch, so never edit the master branch, always edit from the beta branch.\r\n       3) Optional functionality (stuff that is built on top of the the core easyrtc.js) goes into the labs folder. Yes, we know that easyrtc_app.js should have gone into the labs folder but it used to be part of easyrtc_int.js and we didn't want to break people's existing code so we made it a special case.\r\n      4) Changing existing APIs so that people using easyrtc have to change their code is \"darth vader level of evil\". Breaking APIs requires a major version number change and isn't done without extremely good reason. Occasionally we will add an extra optional parameter to a method, but even that is rare (and a bit scary). Adding extra methods or classes doesn't break existing code and hence is generally safe.\r\n     5) I believe there is also a form you need to sign that says you won't put anything into the code base that is inconsistent with the license (ie, nothing that is GPLed or somebody else's property). This should be obvious to anyone with half a brain, but lawyers always want it to be explicit so we can say we've done something in the way of due-diligence :-).\r\n    6) Harold may have something more to add here.\r\n\r\nFor your binary data channel file transfer, I'd create an entirely new file in the labs directory. Your call as to whether it uses the same api as the existing file transfer, but if switching over to your version is just a matter of a file name change, then people are more likely to do it."}}
{"actor":{"display_login":"EricDavies"}}