{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/2636","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/2636/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/2636/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/2636/events","html_url":"https://github.com/catapult-project/catapult/issues/2636","id":170255208,"number":2636,"title":"Systrace has gotten slower","user":{"login":"ChrisCraik","id":384439,"avatar_url":"https://avatars.githubusercontent.com/u/384439?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisCraik","html_url":"https://github.com/ChrisCraik","followers_url":"https://api.github.com/users/ChrisCraik/followers","following_url":"https://api.github.com/users/ChrisCraik/following{/other_user}","gists_url":"https://api.github.com/users/ChrisCraik/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisCraik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisCraik/subscriptions","organizations_url":"https://api.github.com/users/ChrisCraik/orgs","repos_url":"https://api.github.com/users/ChrisCraik/repos","events_url":"https://api.github.com/users/ChrisCraik/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisCraik/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/catapult-project/catapult/labels/Systrace","name":"Systrace","color":"207de5"}],"state":"open","locked":false,"assignee":{"login":"peterwashington","id":2219236,"avatar_url":"https://avatars.githubusercontent.com/u/2219236?v=3","gravatar_id":"","url":"https://api.github.com/users/peterwashington","html_url":"https://github.com/peterwashington","followers_url":"https://api.github.com/users/peterwashington/followers","following_url":"https://api.github.com/users/peterwashington/following{/other_user}","gists_url":"https://api.github.com/users/peterwashington/gists{/gist_id}","starred_url":"https://api.github.com/users/peterwashington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterwashington/subscriptions","organizations_url":"https://api.github.com/users/peterwashington/orgs","repos_url":"https://api.github.com/users/peterwashington/repos","events_url":"https://api.github.com/users/peterwashington/events{/privacy}","received_events_url":"https://api.github.com/users/peterwashington/received_events","type":"User","site_admin":false},"assignees":[{"login":"peterwashington","id":2219236,"avatar_url":"https://avatars.githubusercontent.com/u/2219236?v=3","gravatar_id":"","url":"https://api.github.com/users/peterwashington","html_url":"https://github.com/peterwashington","followers_url":"https://api.github.com/users/peterwashington/followers","following_url":"https://api.github.com/users/peterwashington/following{/other_user}","gists_url":"https://api.github.com/users/peterwashington/gists{/gist_id}","starred_url":"https://api.github.com/users/peterwashington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterwashington/subscriptions","organizations_url":"https://api.github.com/users/peterwashington/orgs","repos_url":"https://api.github.com/users/peterwashington/repos","events_url":"https://api.github.com/users/peterwashington/events{/privacy}","received_events_url":"https://api.github.com/users/peterwashington/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2016-08-09T19:53:03Z","updated_at":"2016-08-13T00:07:17Z","closed_at":null,"body":"Systrace has gotten noticably slower since the last sync into AOSP / Android SDK, which was before the big refactor for async capture and synchronization. On my linux desktop, it's regularly about a second slower.\r\n\r\n> time ./systrace/systrace.py -t 1\r\n\r\nAndroid SDK version:\r\n\r\n> real\t0m2.153s\r\n> user\t0m0.065s\r\n> sys\t0m0.031s\r\n\r\nTOT catapult:\r\n\r\n> real\t0m3.154s\r\n> user\t0m0.238s\r\n> sys\t0m0.186s\r\n\r\nI'm guessing this is mostly an increased number of adb commands (we now query for device list, async capture requires another query), but it would be good to know where this is coming from.\r\n\r\n@wangzhen127 @peterwashington @Alex319 "},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/239587643","html_url":"https://github.com/catapult-project/catapult/issues/2636#issuecomment-239587643","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/2636","id":239587643,"user":{"login":"ChrisCraik","id":384439,"avatar_url":"https://avatars.githubusercontent.com/u/384439?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisCraik","html_url":"https://github.com/ChrisCraik","followers_url":"https://api.github.com/users/ChrisCraik/followers","following_url":"https://api.github.com/users/ChrisCraik/following{/other_user}","gists_url":"https://api.github.com/users/ChrisCraik/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisCraik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisCraik/subscriptions","organizations_url":"https://api.github.com/users/ChrisCraik/orgs","repos_url":"https://api.github.com/users/ChrisCraik/repos","events_url":"https://api.github.com/users/ChrisCraik/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisCraik/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T00:07:17Z","updated_at":"2016-08-13T00:07:17Z","body":"There are a few other adb commands that don't go through devil (mostly because they predate it in the tree - should probably fix that). Check check run_adb_shell in util.py.\r\n\r\n\r\nI see a couple before the trace:\r\n\r\n```\r\nadb devices\r\nadb shell getprop ro.build.version.sdk\r\n```\r\nNote - that second one should probably be run with \"-s <SERIAL>\"\r\n\r\nAnd a couple afterwards:\r\n\r\n```\r\nadb -s <SERIAL> shell ps -t\r\nadb -s <SERIAL> shell printf \"%s\\n\" /proc/[0-9]*/task/[0-9]*\r\n```\r\n\r\nI wonder if we couldn't prune the command list a bit."}}
{"actor":{"display_login":"ChrisCraik"}}