{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27028","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27028/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27028/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27028/events","html_url":"https://github.com/kubernetes/kubernetes/pull/27028","id":159090013,"number":27028,"title":"federation service controller: fixing a bug so that existing services are created in newly registered clusters","user":{"login":"mfanjie","id":16643108,"avatar_url":"https://avatars.githubusercontent.com/u/16643108?v=3","gravatar_id":"","url":"https://api.github.com/users/mfanjie","html_url":"https://github.com/mfanjie","followers_url":"https://api.github.com/users/mfanjie/followers","following_url":"https://api.github.com/users/mfanjie/following{/other_user}","gists_url":"https://api.github.com/users/mfanjie/gists{/gist_id}","starred_url":"https://api.github.com/users/mfanjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfanjie/subscriptions","organizations_url":"https://api.github.com/users/mfanjie/orgs","repos_url":"https://api.github.com/users/mfanjie/repos","events_url":"https://api.github.com/users/mfanjie/events{/privacy}","received_events_url":"https://api.github.com/users/mfanjie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/cluster-federation","name":"area/cluster-federation","color":"fad8c7"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00"}],"state":"open","locked":false,"assignee":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars.githubusercontent.com/u/10199099?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18","html_url":"https://github.com/kubernetes/kubernetes/milestones/v1.3","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/18/labels","id":1638460,"number":18,"title":"v1.3","description":"https://github.com/kubernetes/kubernetes/wiki/Release-1.3","creator":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"open_issues":189,"closed_issues":609,"state":"open","created_at":"2016-03-11T07:40:20Z","updated_at":"2016-06-11T04:49:57Z","due_on":"2016-06-24T07:00:00Z","closed_at":null},"comments":14,"created_at":"2016-06-08T06:39:02Z","updated_at":"2016-06-11T05:11:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/27028","html_url":"https://github.com/kubernetes/kubernetes/pull/27028","diff_url":"https://github.com/kubernetes/kubernetes/pull/27028.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/27028.patch"},"body":"A defect on federation service controller.\r\nSteps to recreate:\r\n1. boot federation control plane\r\n2. create a service and then register a new cluster\r\n\r\nRoot cause:\r\nthe right sequence should be  \r\n```\r\nservicesToUpdate = s.serviceCache.allServices()\r\n```\r\nthen\r\n```\r\ns.updateAllServicesToCluster(servicesToUpdate, newCluster) \r\n```\r\nthen\r\n```\r\nservicesToUpdate = s.updateDNSRecords(servicesToUpdate, newClusters)\r\n```\r\nNow the first two lines' sequence is on the contrary, so when updateDNSRecords return no error, the service will be removed from  servicesToUpdate, and updateAllServicesToCluster get nothing to update.\r\n\r\nThis PR make the call sequence correct.\r\n\r\n[![Analytics](https://kubernetes-site.appspot.com/UA-36037335-10/GitHub/.github/PULL_REQUEST_TEMPLATE.md?pixel)]()\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/225337498","html_url":"https://github.com/kubernetes/kubernetes/pull/27028#issuecomment-225337498","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/27028","id":225337498,"user":{"login":"k8s-bot","id":12551979,"avatar_url":"https://avatars.githubusercontent.com/u/12551979?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-bot","html_url":"https://github.com/k8s-bot","followers_url":"https://api.github.com/users/k8s-bot/followers","following_url":"https://api.github.com/users/k8s-bot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-bot/subscriptions","organizations_url":"https://api.github.com/users/k8s-bot/orgs","repos_url":"https://api.github.com/users/k8s-bot/repos","events_url":"https://api.github.com/users/k8s-bot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-bot/received_events","type":"User","site_admin":false},"created_at":"2016-06-11T05:11:45Z","updated_at":"2016-06-11T05:11:45Z","body":"GCE e2e build/test **passed** for commit 640d7dc7d1c3358a07599088ab21062f8b329373.\n* [Build Log](http://pr-test.k8s.io/27028/kubernetes-pull-build-test-e2e-gce/44248/build-log.txt)\n* [Test Artifacts](https://console.developers.google.com/storage/browser/kubernetes-jenkins/pr-logs/pull/27028/kubernetes-pull-build-test-e2e-gce/44248/artifacts/)\n* [Internal Jenkins Results](http://goto.google.com/prkubekins/job/kubernetes-pull-build-test-e2e-gce//44248)\n"}}
{"actor":{"display_login":"k8s-bot"}}