{"action":"closed","number":68,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/68","id":97806018,"html_url":"https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/68","diff_url":"https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/68.diff","patch_url":"https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/68.patch","issue_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues/68","number":68,"state":"closed","locked":false,"title":"[FIXED JENKINS-40418] Fix validation for a number of extended types","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"body":"[JENKINS-40418](https://issues.jenkins-ci.org/browse/JENKINS-40418)\r\n\r\nTurns out we do need validate methods on child classes - the parent\r\nvalidate method will end up calling\r\nvalidator.validateElement(ParentClass) which is...not what we\r\nwant. So, fixing that in a bunch of places and adding tests.\r\n\r\nAlso, added an expectError convenience method.\r\n\r\ncc @reviewbybees esp @rsandell","created_at":"2016-12-13T18:16:07Z","updated_at":"2016-12-14T18:12:26Z","closed_at":"2016-12-14T18:12:26Z","merged_at":"2016-12-14T18:12:26Z","merge_commit_sha":"1596f6e2f18321e7a79c42e0290b1c74b6a7912e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/68/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/68/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues/68/comments","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/statuses/6bfbffd5260ed4f219cba21cdba809b205390e82","head":{"label":"abayer:add-invalid-trigger-test","ref":"add-invalid-trigger-test","sha":"6bfbffd5260ed4f219cba21cdba809b205390e82","user":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"repo":{"id":66791984,"name":"pipeline-model-definition-plugin","full_name":"abayer/pipeline-model-definition-plugin","owner":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abayer/pipeline-model-definition-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin","forks_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/forks","keys_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/teams","hooks_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/hooks","issue_events_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/events","assignees_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/tags","blobs_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/languages","stargazers_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/stargazers","contributors_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/contributors","subscribers_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/subscribers","subscription_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/subscription","commits_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/merges","archive_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/downloads","issues_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/labels{/name}","releases_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/abayer/pipeline-model-definition-plugin/deployments","created_at":"2016-08-28T21:35:16Z","updated_at":"2016-12-14T16:40:34Z","pushed_at":"2016-12-13T23:17:58Z","git_url":"git://github.com/abayer/pipeline-model-definition-plugin.git","ssh_url":"git@github.com:abayer/pipeline-model-definition-plugin.git","clone_url":"https://github.com/abayer/pipeline-model-definition-plugin.git","svn_url":"https://github.com/abayer/pipeline-model-definition-plugin","homepage":"","size":990,"stargazers_count":2,"watchers_count":2,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"6c8318a67075bf0621f5096d4f574a24b7ee0a3c","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":66677338,"name":"pipeline-model-definition-plugin","full_name":"jenkinsci/pipeline-model-definition-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/pipeline-model-definition-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin","forks_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/deployments","created_at":"2016-08-26T20:28:39Z","updated_at":"2016-12-13T12:03:55Z","pushed_at":"2016-12-14T18:12:26Z","git_url":"git://github.com/jenkinsci/pipeline-model-definition-plugin.git","ssh_url":"git@github.com:jenkinsci/pipeline-model-definition-plugin.git","clone_url":"https://github.com/jenkinsci/pipeline-model-definition-plugin.git","svn_url":"https://github.com/jenkinsci/pipeline-model-definition-plugin","homepage":"","size":892,"stargazers_count":39,"watchers_count":39,"language":"Groovy","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":4,"forks":16,"open_issues":4,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/68"},"html":{"href":"https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/68"},"issue":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues/68"},"comments":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/pipeline-model-definition-plugin/statuses/6bfbffd5260ed4f219cba21cdba809b205390e82"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"abayer","id":120218,"avatar_url":"https://avatars.githubusercontent.com/u/120218?v=3","gravatar_id":"","url":"https://api.github.com/users/abayer","html_url":"https://github.com/abayer","followers_url":"https://api.github.com/users/abayer/followers","following_url":"https://api.github.com/users/abayer/following{/other_user}","gists_url":"https://api.github.com/users/abayer/gists{/gist_id}","starred_url":"https://api.github.com/users/abayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abayer/subscriptions","organizations_url":"https://api.github.com/users/abayer/orgs","repos_url":"https://api.github.com/users/abayer/repos","events_url":"https://api.github.com/users/abayer/events{/privacy}","received_events_url":"https://api.github.com/users/abayer/received_events","type":"User","site_admin":false},"comments":2,"review_comments":1,"commits":1,"additions":250,"deletions":55,"changed_files":12}}
{"actor":{"display_login":"abayer"}}