{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/53893649","id":53893649,"diff_hunk":"@@ -64,11 +64,31 @@ def fit(self, X, y=None):\n             check_array(X, self.accept_sparse)\n         return self\n \n+    def get_feature_names(self, input_features=None):\n+        \"\"\"\n+        Return feature names for output features\n+\n+        Parameters\n+        ----------\n+        input_features : list of string, length len(input_features), optional\n+            String names for input features if available. By default,\n+            \"x0\", \"x1\", ... \"xn_features\" is used.","path":"sklearn/preprocessing/_function_transformer.py","position":12,"original_position":12,"commit_id":"90c6f20c2dca0ac936e9a5fa949fced98876eb0e","original_commit_id":"90c6f20c2dca0ac936e9a5fa949fced98876eb0e","user":{"login":"yenchenlin1994","id":7057863,"avatar_url":"https://avatars.githubusercontent.com/u/7057863?v=3","gravatar_id":"","url":"https://api.github.com/users/yenchenlin1994","html_url":"https://github.com/yenchenlin1994","followers_url":"https://api.github.com/users/yenchenlin1994/followers","following_url":"https://api.github.com/users/yenchenlin1994/following{/other_user}","gists_url":"https://api.github.com/users/yenchenlin1994/gists{/gist_id}","starred_url":"https://api.github.com/users/yenchenlin1994/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenchenlin1994/subscriptions","organizations_url":"https://api.github.com/users/yenchenlin1994/orgs","repos_url":"https://api.github.com/users/yenchenlin1994/repos","events_url":"https://api.github.com/users/yenchenlin1994/events{/privacy}","received_events_url":"https://api.github.com/users/yenchenlin1994/received_events","type":"User","site_admin":false},"body":"Hello @nelson-liu ,\r\nI think doc here need to be modified since it returns None by default?","created_at":"2016-02-24T04:43:22Z","updated_at":"2016-02-24T04:43:22Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/6436#discussion_r53893649","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/53893649"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6436#discussion_r53893649"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436","id":60389008,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/6436","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/6436.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/6436.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6436","number":6436,"state":"open","locked":false,"title":"feature: add get_feature_names() and tests to FunctionTransformer","user":{"login":"nelson-liu","id":7272031,"avatar_url":"https://avatars.githubusercontent.com/u/7272031?v=3","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"body":"Adds `get_feature_names()` to `FunctionTransformer` as outlined in https://github.com/scikit-learn/scikit-learn/issues/6425. I'm not sure if I did this properly -- is the point of this function to maintain compatibility when `get_feature_names()` is implemented in `Pipeline`? Seems quite trivial otherwise / maybe I'm missing something.","created_at":"2016-02-23T18:48:13Z","updated_at":"2016-02-24T04:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"42c4072fb450c33750595d259156a39903d528bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6436/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/90c6f20c2dca0ac936e9a5fa949fced98876eb0e","head":{"label":"nelson-liu:add_get_feature_names_to_function_transformer","ref":"add_get_feature_names_to_function_transformer","sha":"90c6f20c2dca0ac936e9a5fa949fced98876eb0e","user":{"login":"nelson-liu","id":7272031,"avatar_url":"https://avatars.githubusercontent.com/u/7272031?v=3","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"repo":{"id":46840245,"name":"scikit-learn","full_name":"nelson-liu/scikit-learn","owner":{"login":"nelson-liu","id":7272031,"avatar_url":"https://avatars.githubusercontent.com/u/7272031?v=3","gravatar_id":"","url":"https://api.github.com/users/nelson-liu","html_url":"https://github.com/nelson-liu","followers_url":"https://api.github.com/users/nelson-liu/followers","following_url":"https://api.github.com/users/nelson-liu/following{/other_user}","gists_url":"https://api.github.com/users/nelson-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/nelson-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelson-liu/subscriptions","organizations_url":"https://api.github.com/users/nelson-liu/orgs","repos_url":"https://api.github.com/users/nelson-liu/repos","events_url":"https://api.github.com/users/nelson-liu/events{/privacy}","received_events_url":"https://api.github.com/users/nelson-liu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nelson-liu/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/nelson-liu/scikit-learn","forks_url":"https://api.github.com/repos/nelson-liu/scikit-learn/forks","keys_url":"https://api.github.com/repos/nelson-liu/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelson-liu/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelson-liu/scikit-learn/teams","hooks_url":"https://api.github.com/repos/nelson-liu/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/nelson-liu/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/nelson-liu/scikit-learn/events","assignees_url":"https://api.github.com/repos/nelson-liu/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/nelson-liu/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/nelson-liu/scikit-learn/tags","blobs_url":"https://api.github.com/repos/nelson-liu/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelson-liu/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelson-liu/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelson-liu/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelson-liu/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/nelson-liu/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/nelson-liu/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/nelson-liu/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/nelson-liu/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/nelson-liu/scikit-learn/subscription","commits_url":"https://api.github.com/repos/nelson-liu/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelson-liu/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelson-liu/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelson-liu/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelson-liu/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/nelson-liu/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelson-liu/scikit-learn/merges","archive_url":"https://api.github.com/repos/nelson-liu/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelson-liu/scikit-learn/downloads","issues_url":"https://api.github.com/repos/nelson-liu/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/nelson-liu/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/nelson-liu/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/nelson-liu/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelson-liu/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/nelson-liu/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/nelson-liu/scikit-learn/deployments","created_at":"2015-11-25T05:44:49Z","updated_at":"2016-01-11T20:26:31Z","pushed_at":"2016-02-24T04:41:29Z","git_url":"git://github.com/nelson-liu/scikit-learn.git","ssh_url":"git@github.com:nelson-liu/scikit-learn.git","clone_url":"https://github.com/nelson-liu/scikit-learn.git","svn_url":"https://github.com/nelson-liu/scikit-learn","homepage":"http://scikit-learn.org","size":66473,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"323bcea80d394a276d51dc017abde5de1e0767a3","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2016-02-24T04:41:12Z","pushed_at":"2016-02-24T04:41:34Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":101089,"stargazers_count":9870,"watchers_count":9870,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5797,"mirror_url":null,"open_issues_count":1081,"forks":5797,"open_issues":1081,"watchers":9870,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/6436"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6436"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/6436/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/6436/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/90c6f20c2dca0ac936e9a5fa949fced98876eb0e"}}}}