{"action":"created","issue":{"url":"https://api.github.com/repos/apache/zeppelin/issues/1596","repository_url":"https://api.github.com/repos/apache/zeppelin","labels_url":"https://api.github.com/repos/apache/zeppelin/issues/1596/labels{/name}","comments_url":"https://api.github.com/repos/apache/zeppelin/issues/1596/comments","events_url":"https://api.github.com/repos/apache/zeppelin/issues/1596/events","html_url":"https://github.com/apache/zeppelin/pull/1596","id":187264639,"number":1596,"title":"ZEPPELIN-1616. Interpreter open happens in jobRun","user":{"login":"zjffdu","id":164491,"avatar_url":"https://avatars.githubusercontent.com/u/164491?v=3","gravatar_id":"","url":"https://api.github.com/users/zjffdu","html_url":"https://github.com/zjffdu","followers_url":"https://api.github.com/users/zjffdu/followers","following_url":"https://api.github.com/users/zjffdu/following{/other_user}","gists_url":"https://api.github.com/users/zjffdu/gists{/gist_id}","starred_url":"https://api.github.com/users/zjffdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjffdu/subscriptions","organizations_url":"https://api.github.com/users/zjffdu/orgs","repos_url":"https://api.github.com/users/zjffdu/repos","events_url":"https://api.github.com/users/zjffdu/events{/privacy}","received_events_url":"https://api.github.com/users/zjffdu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-11-04T06:47:48Z","updated_at":"2016-11-04T10:09:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/zeppelin/pulls/1596","html_url":"https://github.com/apache/zeppelin/pull/1596","diff_url":"https://github.com/apache/zeppelin/pull/1596.diff","patch_url":"https://github.com/apache/zeppelin/pull/1596.patch"},"body":"### What is this PR for?\r\nNot sure why we put interpreter open in jobRun, that means the thrift service method open is never used. I think open method in remote interpreter process should be called when RemoteInterpreter call open method in client side. \r\n\r\n\r\n### What type of PR is it?\r\n[Improvement]\r\n\r\n### Todos\r\n* [ ] - Task\r\n\r\n### What is the Jira issue?\r\n* https://issues.apache.org/jira/browse/ZEPPELIN-1616\r\n\r\n\r\n### How should this be tested?\r\nOutline the steps to test the PR here.\r\n\r\n### Screenshots (if appropriate)\r\n\r\n### Questions:\r\n* Does the licenses files need update? No\r\n* Is there breaking changes for older versions? No\r\n* Does this needs documentation? No\r\n"},"comment":{"url":"https://api.github.com/repos/apache/zeppelin/issues/comments/258389669","html_url":"https://github.com/apache/zeppelin/pull/1596#issuecomment-258389669","issue_url":"https://api.github.com/repos/apache/zeppelin/issues/1596","id":258389669,"user":{"login":"agoodm","id":5179430,"avatar_url":"https://avatars.githubusercontent.com/u/5179430?v=3","gravatar_id":"","url":"https://api.github.com/users/agoodm","html_url":"https://github.com/agoodm","followers_url":"https://api.github.com/users/agoodm/followers","following_url":"https://api.github.com/users/agoodm/following{/other_user}","gists_url":"https://api.github.com/users/agoodm/gists{/gist_id}","starred_url":"https://api.github.com/users/agoodm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agoodm/subscriptions","organizations_url":"https://api.github.com/users/agoodm/orgs","repos_url":"https://api.github.com/users/agoodm/repos","events_url":"https://api.github.com/users/agoodm/events{/privacy}","received_events_url":"https://api.github.com/users/agoodm/received_events","type":"User","site_admin":false},"created_at":"2016-11-04T10:09:16Z","updated_at":"2016-11-04T10:09:16Z","body":"Well to be precise, the other reason I made the call to `open()` was to make sure the hook registry was in effect before the first call to `interpret()` from within `jobRun()`, and therefore, the first attempt at running a paragraph with that interpreter. If this PR doesn't change that, then I think it should be fine, and if it doesn't work I am fairly sure the other solution I just mentioned would be a good alternative. I can test it on my PR branch tomorrow."}}
{"actor":{"display_login":"agoodm"}}