{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/58614514","id":58614514,"diff_hunk":"@@ -1,24 +1,32 @@\n-### Pull Request check-list\n+<!--\n+Thank you for submitting a pull request to Node.js. Before you submit, please\n+review below requirements and walk through the checklist.\n \n-_Please make sure to review and check all of these items:_\n+You can run the test suite by invoking: `make -j4 lint test` on linux or\n+`vcbuild test nosign` on Windows.\n \n-- [ ] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\n-  this change (including linting)?\n-- [ ] Is the commit message formatted according to [CONTRIBUTING.md][0]?\n-- [ ] If this change fixes a bug (or a performance problem), is a regression\n-  test (or a benchmark) included?\n-- [ ] Is a documentation update included (if this change modifies\n-  existing APIs, or introduces new ones)?\n+If this aims to fix a regression or you’re adding a feature, make sure you also\n+write a test. Finally – if possible – a benchmark that quantifies your changes.\n \n-_NOTE: these things are not required to open a PR and can be done\n-afterwards / while the PR is open._\n+Finally, read through our contributors guide and make adjustments as necessary:\n+https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\n+-->\n \n-### Affected core subsystem(s)\n+##### Checklist\n \n-_Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)_\n+<!-- remove lines that does not apply to you -->\n \n-[0]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit\n+- tests and code linting passes\n+- a test and/or benchmark is included\n+- documentation is changed or added\n+- the commit message follows commit guidelines","path":".github/PULL_REQUEST_TEMPLATE.md","position":36,"original_position":36,"commit_id":"811870b33a15484d80aa627f3c2545b85ca93a6c","original_commit_id":"38083be13e757023769dec37c09c4b22c6ceecd8","user":{"login":"jbergstroem","id":176984,"avatar_url":"https://avatars.githubusercontent.com/u/176984?v=3","gravatar_id":"","url":"https://api.github.com/users/jbergstroem","html_url":"https://github.com/jbergstroem","followers_url":"https://api.github.com/users/jbergstroem/followers","following_url":"https://api.github.com/users/jbergstroem/following{/other_user}","gists_url":"https://api.github.com/users/jbergstroem/gists{/gist_id}","starred_url":"https://api.github.com/users/jbergstroem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbergstroem/subscriptions","organizations_url":"https://api.github.com/users/jbergstroem/orgs","repos_url":"https://api.github.com/users/jbergstroem/repos","events_url":"https://api.github.com/users/jbergstroem/events{/privacy}","received_events_url":"https://api.github.com/users/jbergstroem/received_events","type":"User","site_admin":false},"body":"ok; lets re-add them in the name of progress and move forward.","created_at":"2016-04-05T21:06:36Z","updated_at":"2016-04-05T21:06:36Z","html_url":"https://github.com/nodejs/node/pull/5710#discussion_r58614514","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/5710","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/58614514"},"html":{"href":"https://github.com/nodejs/node/pull/5710#discussion_r58614514"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/5710"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/5710","id":62856220,"html_url":"https://github.com/nodejs/node/pull/5710","diff_url":"https://github.com/nodejs/node/pull/5710.diff","patch_url":"https://github.com/nodejs/node/pull/5710.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/5710","number":5710,"state":"open","locked":false,"title":"doc: improve github templates by using comments","user":{"login":"jbergstroem","id":176984,"avatar_url":"https://avatars.githubusercontent.com/u/176984?v=3","gravatar_id":"","url":"https://api.github.com/users/jbergstroem","html_url":"https://github.com/jbergstroem","followers_url":"https://api.github.com/users/jbergstroem/followers","following_url":"https://api.github.com/users/jbergstroem/following{/other_user}","gists_url":"https://api.github.com/users/jbergstroem/gists{/gist_id}","starred_url":"https://api.github.com/users/jbergstroem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbergstroem/subscriptions","organizations_url":"https://api.github.com/users/jbergstroem/orgs","repos_url":"https://api.github.com/users/jbergstroem/repos","events_url":"https://api.github.com/users/jbergstroem/events{/privacy}","received_events_url":"https://api.github.com/users/jbergstroem/received_events","type":"User","site_admin":false},"body":"### Pull Request check-list\r\n\r\n- [x] Does `make -j8 test` (UNIX) or `vcbuild test nosign` (Windows) pass with\r\n  this change (including linting)?\r\n- [x] Is the commit message formatted according to [CONTRIBUTING.md][0]?\r\n- [ ] If this change fixes a bug (or a performance problem), is a regression\r\n  test (or a benchmark) included?\r\n- [x] Is a documentation update included (if this change modifies\r\n  existing APIs, or introduces new ones)?\r\n\r\n### Affected core subsystem(s)\r\n\r\ndoc\r\n\r\n### Description of change\r\n\r\nHad a look around other open source projects and came to the conclusion that using html commens (`<!-- foo -->`) successfully reduces clutter.\r\n\r\nWhile at it, I also came to the conclusion that its easier to read:\r\n\r\n- [x] tests and linting pass\r\n\r\n..than:\r\n\r\n- [x] Is the commit message formatted according to CONTRIBUTING.md?\r\n\r\nso, I moved some of the instructions to the top instead.\r\n\r\nGuessing this is bikeshedding but at least I get to paint it first!","created_at":"2016-03-15T05:14:14Z","updated_at":"2016-04-05T21:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fd6e71fc98688abc3c1b7a0a7f14b93422d1c6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/5710/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/5710/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/5710/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/811870b33a15484d80aa627f3c2545b85ca93a6c","head":{"label":"jbergstroem:feature/improve-pr-commit-template","ref":"feature/improve-pr-commit-template","sha":"811870b33a15484d80aa627f3c2545b85ca93a6c","user":{"login":"jbergstroem","id":176984,"avatar_url":"https://avatars.githubusercontent.com/u/176984?v=3","gravatar_id":"","url":"https://api.github.com/users/jbergstroem","html_url":"https://github.com/jbergstroem","followers_url":"https://api.github.com/users/jbergstroem/followers","following_url":"https://api.github.com/users/jbergstroem/following{/other_user}","gists_url":"https://api.github.com/users/jbergstroem/gists{/gist_id}","starred_url":"https://api.github.com/users/jbergstroem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbergstroem/subscriptions","organizations_url":"https://api.github.com/users/jbergstroem/orgs","repos_url":"https://api.github.com/users/jbergstroem/repos","events_url":"https://api.github.com/users/jbergstroem/events{/privacy}","received_events_url":"https://api.github.com/users/jbergstroem/received_events","type":"User","site_admin":false},"repo":{"id":27474763,"name":"node","full_name":"jbergstroem/node","owner":{"login":"jbergstroem","id":176984,"avatar_url":"https://avatars.githubusercontent.com/u/176984?v=3","gravatar_id":"","url":"https://api.github.com/users/jbergstroem","html_url":"https://github.com/jbergstroem","followers_url":"https://api.github.com/users/jbergstroem/followers","following_url":"https://api.github.com/users/jbergstroem/following{/other_user}","gists_url":"https://api.github.com/users/jbergstroem/gists{/gist_id}","starred_url":"https://api.github.com/users/jbergstroem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbergstroem/subscriptions","organizations_url":"https://api.github.com/users/jbergstroem/orgs","repos_url":"https://api.github.com/users/jbergstroem/repos","events_url":"https://api.github.com/users/jbergstroem/events{/privacy}","received_events_url":"https://api.github.com/users/jbergstroem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbergstroem/node","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/jbergstroem/node","forks_url":"https://api.github.com/repos/jbergstroem/node/forks","keys_url":"https://api.github.com/repos/jbergstroem/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbergstroem/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbergstroem/node/teams","hooks_url":"https://api.github.com/repos/jbergstroem/node/hooks","issue_events_url":"https://api.github.com/repos/jbergstroem/node/issues/events{/number}","events_url":"https://api.github.com/repos/jbergstroem/node/events","assignees_url":"https://api.github.com/repos/jbergstroem/node/assignees{/user}","branches_url":"https://api.github.com/repos/jbergstroem/node/branches{/branch}","tags_url":"https://api.github.com/repos/jbergstroem/node/tags","blobs_url":"https://api.github.com/repos/jbergstroem/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbergstroem/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbergstroem/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbergstroem/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbergstroem/node/statuses/{sha}","languages_url":"https://api.github.com/repos/jbergstroem/node/languages","stargazers_url":"https://api.github.com/repos/jbergstroem/node/stargazers","contributors_url":"https://api.github.com/repos/jbergstroem/node/contributors","subscribers_url":"https://api.github.com/repos/jbergstroem/node/subscribers","subscription_url":"https://api.github.com/repos/jbergstroem/node/subscription","commits_url":"https://api.github.com/repos/jbergstroem/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbergstroem/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbergstroem/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbergstroem/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbergstroem/node/contents/{+path}","compare_url":"https://api.github.com/repos/jbergstroem/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbergstroem/node/merges","archive_url":"https://api.github.com/repos/jbergstroem/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbergstroem/node/downloads","issues_url":"https://api.github.com/repos/jbergstroem/node/issues{/number}","pulls_url":"https://api.github.com/repos/jbergstroem/node/pulls{/number}","milestones_url":"https://api.github.com/repos/jbergstroem/node/milestones{/number}","notifications_url":"https://api.github.com/repos/jbergstroem/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbergstroem/node/labels{/name}","releases_url":"https://api.github.com/repos/jbergstroem/node/releases{/id}","deployments_url":"https://api.github.com/repos/jbergstroem/node/deployments","created_at":"2014-12-03T07:21:08Z","updated_at":"2015-10-18T22:29:43Z","pushed_at":"2016-04-05T19:09:09Z","git_url":"git://github.com/jbergstroem/node.git","ssh_url":"git@github.com:jbergstroem/node.git","clone_url":"https://github.com/jbergstroem/node.git","svn_url":"https://github.com/jbergstroem/node","homepage":null,"size":178551,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"39de601e1c3eda92eb2e37eca4e6aa960f206f39","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2016-04-05T20:49:42Z","pushed_at":"2016-04-05T20:19:26Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":225611,"stargazers_count":21746,"watchers_count":21746,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2913,"mirror_url":null,"open_issues_count":678,"forks":2913,"open_issues":678,"watchers":21746,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/5710"},"html":{"href":"https://github.com/nodejs/node/pull/5710"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/5710"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/5710/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/5710/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/5710/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/811870b33a15484d80aa627f3c2545b85ca93a6c"}}}}