{"action":"created","comment":{"url":"https://api.github.com/repos/ppy/osu/pulls/comments/94010835","pull_request_review_id":14540582,"id":94010835,"diff_hunk":"@@ -18,7 +18,6 @@ protected override void InitialiseDefaults()\n             Set(OsuConfig.MouseSpeed, 1.0);\r\n \r\n             Set(OsuConfig.Username, string.Empty);\r\n-            Set(OsuConfig.Password, string.Empty);\r","path":"osu.Game/Configuration/OsuConfigManager.cs","position":4,"original_position":4,"commit_id":"acc50e34734840e5666dc9046e5b001c075d16a5","original_commit_id":"acc50e34734840e5666dc9046e5b001c075d16a5","user":{"login":"EVAST9919","id":22874522,"avatar_url":"https://avatars.githubusercontent.com/u/22874522?v=3","gravatar_id":"","url":"https://api.github.com/users/EVAST9919","html_url":"https://github.com/EVAST9919","followers_url":"https://api.github.com/users/EVAST9919/followers","following_url":"https://api.github.com/users/EVAST9919/following{/other_user}","gists_url":"https://api.github.com/users/EVAST9919/gists{/gist_id}","starred_url":"https://api.github.com/users/EVAST9919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EVAST9919/subscriptions","organizations_url":"https://api.github.com/users/EVAST9919/orgs","repos_url":"https://api.github.com/users/EVAST9919/repos","events_url":"https://api.github.com/users/EVAST9919/events{/privacy}","received_events_url":"https://api.github.com/users/EVAST9919/received_events","type":"User","site_admin":false},"body":"But we don't use password filed anywhere, so why we still need it at all? Doesn't it pointless to keep line in the file, which will be empty all the time?","created_at":"2016-12-28T09:25:19Z","updated_at":"2016-12-28T09:25:19Z","html_url":"https://github.com/ppy/osu/pull/268#discussion_r94010835","pull_request_url":"https://api.github.com/repos/ppy/osu/pulls/268","_links":{"self":{"href":"https://api.github.com/repos/ppy/osu/pulls/comments/94010835"},"html":{"href":"https://github.com/ppy/osu/pull/268#discussion_r94010835"},"pull_request":{"href":"https://api.github.com/repos/ppy/osu/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/ppy/osu/pulls/268","id":98762974,"html_url":"https://github.com/ppy/osu/pull/268","diff_url":"https://github.com/ppy/osu/pull/268.diff","patch_url":"https://github.com/ppy/osu/pull/268.patch","issue_url":"https://api.github.com/repos/ppy/osu/issues/268","number":268,"state":"open","locked":false,"title":"Login improvements","user":{"login":"EVAST9919","id":22874522,"avatar_url":"https://avatars.githubusercontent.com/u/22874522?v=3","gravatar_id":"","url":"https://api.github.com/users/EVAST9919","html_url":"https://github.com/EVAST9919","followers_url":"https://api.github.com/users/EVAST9919/followers","following_url":"https://api.github.com/users/EVAST9919/following{/other_user}","gists_url":"https://api.github.com/users/EVAST9919/gists{/gist_id}","starred_url":"https://api.github.com/users/EVAST9919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EVAST9919/subscriptions","organizations_url":"https://api.github.com/users/EVAST9919/orgs","repos_url":"https://api.github.com/users/EVAST9919/repos","events_url":"https://api.github.com/users/EVAST9919/events{/privacy}","received_events_url":"https://api.github.com/users/EVAST9919/received_events","type":"User","site_admin":false},"body":"Main changes: \r\n- checkboxes \"Save Username\" and \"Save Password\"\r\n- removed a password field in a game.ini","created_at":"2016-12-20T14:54:59Z","updated_at":"2016-12-28T09:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ac0cea1b959921a00b5f8a38f5e9ec788f08d3b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ppy/osu/pulls/268/commits","review_comments_url":"https://api.github.com/repos/ppy/osu/pulls/268/comments","review_comment_url":"https://api.github.com/repos/ppy/osu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ppy/osu/issues/268/comments","statuses_url":"https://api.github.com/repos/ppy/osu/statuses/acc50e34734840e5666dc9046e5b001c075d16a5","head":{"label":"EVAST9919:login_fix","ref":"login_fix","sha":"acc50e34734840e5666dc9046e5b001c075d16a5","user":{"login":"EVAST9919","id":22874522,"avatar_url":"https://avatars.githubusercontent.com/u/22874522?v=3","gravatar_id":"","url":"https://api.github.com/users/EVAST9919","html_url":"https://github.com/EVAST9919","followers_url":"https://api.github.com/users/EVAST9919/followers","following_url":"https://api.github.com/users/EVAST9919/following{/other_user}","gists_url":"https://api.github.com/users/EVAST9919/gists{/gist_id}","starred_url":"https://api.github.com/users/EVAST9919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EVAST9919/subscriptions","organizations_url":"https://api.github.com/users/EVAST9919/orgs","repos_url":"https://api.github.com/users/EVAST9919/repos","events_url":"https://api.github.com/users/EVAST9919/events{/privacy}","received_events_url":"https://api.github.com/users/EVAST9919/received_events","type":"User","site_admin":false},"repo":{"id":75373923,"name":"osu","full_name":"EVAST9919/osu","owner":{"login":"EVAST9919","id":22874522,"avatar_url":"https://avatars.githubusercontent.com/u/22874522?v=3","gravatar_id":"","url":"https://api.github.com/users/EVAST9919","html_url":"https://github.com/EVAST9919","followers_url":"https://api.github.com/users/EVAST9919/followers","following_url":"https://api.github.com/users/EVAST9919/following{/other_user}","gists_url":"https://api.github.com/users/EVAST9919/gists{/gist_id}","starred_url":"https://api.github.com/users/EVAST9919/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EVAST9919/subscriptions","organizations_url":"https://api.github.com/users/EVAST9919/orgs","repos_url":"https://api.github.com/users/EVAST9919/repos","events_url":"https://api.github.com/users/EVAST9919/events{/privacy}","received_events_url":"https://api.github.com/users/EVAST9919/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EVAST9919/osu","description":"rhythm is just a *click* away!","fork":true,"url":"https://api.github.com/repos/EVAST9919/osu","forks_url":"https://api.github.com/repos/EVAST9919/osu/forks","keys_url":"https://api.github.com/repos/EVAST9919/osu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EVAST9919/osu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EVAST9919/osu/teams","hooks_url":"https://api.github.com/repos/EVAST9919/osu/hooks","issue_events_url":"https://api.github.com/repos/EVAST9919/osu/issues/events{/number}","events_url":"https://api.github.com/repos/EVAST9919/osu/events","assignees_url":"https://api.github.com/repos/EVAST9919/osu/assignees{/user}","branches_url":"https://api.github.com/repos/EVAST9919/osu/branches{/branch}","tags_url":"https://api.github.com/repos/EVAST9919/osu/tags","blobs_url":"https://api.github.com/repos/EVAST9919/osu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EVAST9919/osu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EVAST9919/osu/git/refs{/sha}","trees_url":"https://api.github.com/repos/EVAST9919/osu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EVAST9919/osu/statuses/{sha}","languages_url":"https://api.github.com/repos/EVAST9919/osu/languages","stargazers_url":"https://api.github.com/repos/EVAST9919/osu/stargazers","contributors_url":"https://api.github.com/repos/EVAST9919/osu/contributors","subscribers_url":"https://api.github.com/repos/EVAST9919/osu/subscribers","subscription_url":"https://api.github.com/repos/EVAST9919/osu/subscription","commits_url":"https://api.github.com/repos/EVAST9919/osu/commits{/sha}","git_commits_url":"https://api.github.com/repos/EVAST9919/osu/git/commits{/sha}","comments_url":"https://api.github.com/repos/EVAST9919/osu/comments{/number}","issue_comment_url":"https://api.github.com/repos/EVAST9919/osu/issues/comments{/number}","contents_url":"https://api.github.com/repos/EVAST9919/osu/contents/{+path}","compare_url":"https://api.github.com/repos/EVAST9919/osu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EVAST9919/osu/merges","archive_url":"https://api.github.com/repos/EVAST9919/osu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EVAST9919/osu/downloads","issues_url":"https://api.github.com/repos/EVAST9919/osu/issues{/number}","pulls_url":"https://api.github.com/repos/EVAST9919/osu/pulls{/number}","milestones_url":"https://api.github.com/repos/EVAST9919/osu/milestones{/number}","notifications_url":"https://api.github.com/repos/EVAST9919/osu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EVAST9919/osu/labels{/name}","releases_url":"https://api.github.com/repos/EVAST9919/osu/releases{/id}","deployments_url":"https://api.github.com/repos/EVAST9919/osu/deployments","created_at":"2016-12-02T07:56:04Z","updated_at":"2016-12-02T07:56:06Z","pushed_at":"2016-12-27T20:11:25Z","git_url":"git://github.com/EVAST9919/osu.git","ssh_url":"git@github.com:EVAST9919/osu.git","clone_url":"https://github.com/EVAST9919/osu.git","svn_url":"https://github.com/EVAST9919/osu","homepage":"https://osu.ppy.sh","size":1585,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ppy:master","ref":"master","sha":"561b0928bbcf28365ca3843f5870df99c590fbaa","user":{"login":"ppy","id":995763,"avatar_url":"https://avatars.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"repo":{"id":22456440,"name":"osu","full_name":"ppy/osu","owner":{"login":"ppy","id":995763,"avatar_url":"https://avatars.githubusercontent.com/u/995763?v=3","gravatar_id":"","url":"https://api.github.com/users/ppy","html_url":"https://github.com/ppy","followers_url":"https://api.github.com/users/ppy/followers","following_url":"https://api.github.com/users/ppy/following{/other_user}","gists_url":"https://api.github.com/users/ppy/gists{/gist_id}","starred_url":"https://api.github.com/users/ppy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppy/subscriptions","organizations_url":"https://api.github.com/users/ppy/orgs","repos_url":"https://api.github.com/users/ppy/repos","events_url":"https://api.github.com/users/ppy/events{/privacy}","received_events_url":"https://api.github.com/users/ppy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ppy/osu","description":"rhythm is just a *click* away!","fork":false,"url":"https://api.github.com/repos/ppy/osu","forks_url":"https://api.github.com/repos/ppy/osu/forks","keys_url":"https://api.github.com/repos/ppy/osu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ppy/osu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ppy/osu/teams","hooks_url":"https://api.github.com/repos/ppy/osu/hooks","issue_events_url":"https://api.github.com/repos/ppy/osu/issues/events{/number}","events_url":"https://api.github.com/repos/ppy/osu/events","assignees_url":"https://api.github.com/repos/ppy/osu/assignees{/user}","branches_url":"https://api.github.com/repos/ppy/osu/branches{/branch}","tags_url":"https://api.github.com/repos/ppy/osu/tags","blobs_url":"https://api.github.com/repos/ppy/osu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ppy/osu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ppy/osu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ppy/osu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ppy/osu/statuses/{sha}","languages_url":"https://api.github.com/repos/ppy/osu/languages","stargazers_url":"https://api.github.com/repos/ppy/osu/stargazers","contributors_url":"https://api.github.com/repos/ppy/osu/contributors","subscribers_url":"https://api.github.com/repos/ppy/osu/subscribers","subscription_url":"https://api.github.com/repos/ppy/osu/subscription","commits_url":"https://api.github.com/repos/ppy/osu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ppy/osu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ppy/osu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ppy/osu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ppy/osu/contents/{+path}","compare_url":"https://api.github.com/repos/ppy/osu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ppy/osu/merges","archive_url":"https://api.github.com/repos/ppy/osu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ppy/osu/downloads","issues_url":"https://api.github.com/repos/ppy/osu/issues{/number}","pulls_url":"https://api.github.com/repos/ppy/osu/pulls{/number}","milestones_url":"https://api.github.com/repos/ppy/osu/milestones{/number}","notifications_url":"https://api.github.com/repos/ppy/osu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ppy/osu/labels{/name}","releases_url":"https://api.github.com/repos/ppy/osu/releases{/id}","deployments_url":"https://api.github.com/repos/ppy/osu/deployments","created_at":"2014-07-31T04:26:30Z","updated_at":"2016-12-28T04:23:36Z","pushed_at":"2016-12-28T05:08:23Z","git_url":"git://github.com/ppy/osu.git","ssh_url":"git@github.com:ppy/osu.git","clone_url":"https://github.com/ppy/osu.git","svn_url":"https://github.com/ppy/osu","homepage":"https://osu.ppy.sh","size":1577,"stargazers_count":582,"watchers_count":582,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":32,"forks":128,"open_issues":32,"watchers":582,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ppy/osu/pulls/268"},"html":{"href":"https://github.com/ppy/osu/pull/268"},"issue":{"href":"https://api.github.com/repos/ppy/osu/issues/268"},"comments":{"href":"https://api.github.com/repos/ppy/osu/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/ppy/osu/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/ppy/osu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ppy/osu/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/ppy/osu/statuses/acc50e34734840e5666dc9046e5b001c075d16a5"}}}}
{"actor":{"display_login":"EVAST9919"}}