{"action":"opened","number":1960,"pull_request":{"url":"https://api.github.com/repos/docker/kitematic/pulls/1960","id":83591829,"html_url":"https://github.com/docker/kitematic/pull/1960","diff_url":"https://github.com/docker/kitematic/pull/1960.diff","patch_url":"https://github.com/docker/kitematic/pull/1960.patch","issue_url":"https://api.github.com/repos/docker/kitematic/issues/1960","number":1960,"state":"open","locked":false,"title":"Add engines entry to package.json","user":{"login":"Fahrradflucht","id":13237661,"avatar_url":"https://avatars.githubusercontent.com/u/13237661?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahrradflucht","html_url":"https://github.com/Fahrradflucht","followers_url":"https://api.github.com/users/Fahrradflucht/followers","following_url":"https://api.github.com/users/Fahrradflucht/following{/other_user}","gists_url":"https://api.github.com/users/Fahrradflucht/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahrradflucht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahrradflucht/subscriptions","organizations_url":"https://api.github.com/users/Fahrradflucht/orgs","repos_url":"https://api.github.com/users/Fahrradflucht/repos","events_url":"https://api.github.com/users/Fahrradflucht/events{/privacy}","received_events_url":"https://api.github.com/users/Fahrradflucht/received_events","type":"User","site_admin":false},"body":"Fixes #1944\r\n\r\nThis adds an engines entry to package.json. It's set to 4.1.1 which is the node version used in all electron versions between [0.33.2](https://github.com/electron/electron/releases/tag/v0.33.2) and [0.36.0](https://github.com/electron/electron/releases/tag/v0.36.0) what covers the current ([0.35.4](https://github.com/docker/kitematic/blob/master/package.json#L23)).\r\n\r\n--\r\n\r\nThis actually brings up the question why the tests on travis [run against 4.2.2](https://github.com/docker/kitematic/blob/master/.travis.yml#L5) as that isn't the node version kitematic actually runs on doesn't it?","created_at":"2016-09-01T08:40:45Z","updated_at":"2016-09-01T08:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c972dad595f02740f7e4a3eb2fad5b0b913615ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/kitematic/pulls/1960/commits","review_comments_url":"https://api.github.com/repos/docker/kitematic/pulls/1960/comments","review_comment_url":"https://api.github.com/repos/docker/kitematic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/kitematic/issues/1960/comments","statuses_url":"https://api.github.com/repos/docker/kitematic/statuses/317180e0cc2a98b0307f2e96ecc2c4a900d46211","head":{"label":"Fahrradflucht:1944-specify-required-node-version","ref":"1944-specify-required-node-version","sha":"317180e0cc2a98b0307f2e96ecc2c4a900d46211","user":{"login":"Fahrradflucht","id":13237661,"avatar_url":"https://avatars.githubusercontent.com/u/13237661?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahrradflucht","html_url":"https://github.com/Fahrradflucht","followers_url":"https://api.github.com/users/Fahrradflucht/followers","following_url":"https://api.github.com/users/Fahrradflucht/following{/other_user}","gists_url":"https://api.github.com/users/Fahrradflucht/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahrradflucht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahrradflucht/subscriptions","organizations_url":"https://api.github.com/users/Fahrradflucht/orgs","repos_url":"https://api.github.com/users/Fahrradflucht/repos","events_url":"https://api.github.com/users/Fahrradflucht/events{/privacy}","received_events_url":"https://api.github.com/users/Fahrradflucht/received_events","type":"User","site_admin":false},"repo":{"id":66729814,"name":"kitematic","full_name":"Fahrradflucht/kitematic","owner":{"login":"Fahrradflucht","id":13237661,"avatar_url":"https://avatars.githubusercontent.com/u/13237661?v=3","gravatar_id":"","url":"https://api.github.com/users/Fahrradflucht","html_url":"https://github.com/Fahrradflucht","followers_url":"https://api.github.com/users/Fahrradflucht/followers","following_url":"https://api.github.com/users/Fahrradflucht/following{/other_user}","gists_url":"https://api.github.com/users/Fahrradflucht/gists{/gist_id}","starred_url":"https://api.github.com/users/Fahrradflucht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fahrradflucht/subscriptions","organizations_url":"https://api.github.com/users/Fahrradflucht/orgs","repos_url":"https://api.github.com/users/Fahrradflucht/repos","events_url":"https://api.github.com/users/Fahrradflucht/events{/privacy}","received_events_url":"https://api.github.com/users/Fahrradflucht/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fahrradflucht/kitematic","description":"Visual Docker Container Management on Mac & Windows","fork":true,"url":"https://api.github.com/repos/Fahrradflucht/kitematic","forks_url":"https://api.github.com/repos/Fahrradflucht/kitematic/forks","keys_url":"https://api.github.com/repos/Fahrradflucht/kitematic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fahrradflucht/kitematic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fahrradflucht/kitematic/teams","hooks_url":"https://api.github.com/repos/Fahrradflucht/kitematic/hooks","issue_events_url":"https://api.github.com/repos/Fahrradflucht/kitematic/issues/events{/number}","events_url":"https://api.github.com/repos/Fahrradflucht/kitematic/events","assignees_url":"https://api.github.com/repos/Fahrradflucht/kitematic/assignees{/user}","branches_url":"https://api.github.com/repos/Fahrradflucht/kitematic/branches{/branch}","tags_url":"https://api.github.com/repos/Fahrradflucht/kitematic/tags","blobs_url":"https://api.github.com/repos/Fahrradflucht/kitematic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fahrradflucht/kitematic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fahrradflucht/kitematic/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fahrradflucht/kitematic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fahrradflucht/kitematic/statuses/{sha}","languages_url":"https://api.github.com/repos/Fahrradflucht/kitematic/languages","stargazers_url":"https://api.github.com/repos/Fahrradflucht/kitematic/stargazers","contributors_url":"https://api.github.com/repos/Fahrradflucht/kitematic/contributors","subscribers_url":"https://api.github.com/repos/Fahrradflucht/kitematic/subscribers","subscription_url":"https://api.github.com/repos/Fahrradflucht/kitematic/subscription","commits_url":"https://api.github.com/repos/Fahrradflucht/kitematic/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fahrradflucht/kitematic/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fahrradflucht/kitematic/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fahrradflucht/kitematic/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fahrradflucht/kitematic/contents/{+path}","compare_url":"https://api.github.com/repos/Fahrradflucht/kitematic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fahrradflucht/kitematic/merges","archive_url":"https://api.github.com/repos/Fahrradflucht/kitematic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fahrradflucht/kitematic/downloads","issues_url":"https://api.github.com/repos/Fahrradflucht/kitematic/issues{/number}","pulls_url":"https://api.github.com/repos/Fahrradflucht/kitematic/pulls{/number}","milestones_url":"https://api.github.com/repos/Fahrradflucht/kitematic/milestones{/number}","notifications_url":"https://api.github.com/repos/Fahrradflucht/kitematic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fahrradflucht/kitematic/labels{/name}","releases_url":"https://api.github.com/repos/Fahrradflucht/kitematic/releases{/id}","deployments_url":"https://api.github.com/repos/Fahrradflucht/kitematic/deployments","created_at":"2016-08-27T18:35:46Z","updated_at":"2016-08-27T18:35:49Z","pushed_at":"2016-09-01T08:35:18Z","git_url":"git://github.com/Fahrradflucht/kitematic.git","ssh_url":"git@github.com:Fahrradflucht/kitematic.git","clone_url":"https://github.com/Fahrradflucht/kitematic.git","svn_url":"https://github.com/Fahrradflucht/kitematic","homepage":"https://kitematic.com","size":103367,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"f3df7247ef5d3abb0de4bef8d807cbbbdfab6441","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":23404839,"name":"kitematic","full_name":"docker/kitematic","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/kitematic","description":"Visual Docker Container Management on Mac & Windows","fork":false,"url":"https://api.github.com/repos/docker/kitematic","forks_url":"https://api.github.com/repos/docker/kitematic/forks","keys_url":"https://api.github.com/repos/docker/kitematic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/kitematic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/kitematic/teams","hooks_url":"https://api.github.com/repos/docker/kitematic/hooks","issue_events_url":"https://api.github.com/repos/docker/kitematic/issues/events{/number}","events_url":"https://api.github.com/repos/docker/kitematic/events","assignees_url":"https://api.github.com/repos/docker/kitematic/assignees{/user}","branches_url":"https://api.github.com/repos/docker/kitematic/branches{/branch}","tags_url":"https://api.github.com/repos/docker/kitematic/tags","blobs_url":"https://api.github.com/repos/docker/kitematic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/kitematic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/kitematic/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/kitematic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/kitematic/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/kitematic/languages","stargazers_url":"https://api.github.com/repos/docker/kitematic/stargazers","contributors_url":"https://api.github.com/repos/docker/kitematic/contributors","subscribers_url":"https://api.github.com/repos/docker/kitematic/subscribers","subscription_url":"https://api.github.com/repos/docker/kitematic/subscription","commits_url":"https://api.github.com/repos/docker/kitematic/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/kitematic/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/kitematic/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/kitematic/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/kitematic/contents/{+path}","compare_url":"https://api.github.com/repos/docker/kitematic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/kitematic/merges","archive_url":"https://api.github.com/repos/docker/kitematic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/kitematic/downloads","issues_url":"https://api.github.com/repos/docker/kitematic/issues{/number}","pulls_url":"https://api.github.com/repos/docker/kitematic/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/kitematic/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/kitematic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/kitematic/labels{/name}","releases_url":"https://api.github.com/repos/docker/kitematic/releases{/id}","deployments_url":"https://api.github.com/repos/docker/kitematic/deployments","created_at":"2014-08-27T20:44:59Z","updated_at":"2016-09-01T06:48:48Z","pushed_at":"2016-09-01T08:40:45Z","git_url":"git://github.com/docker/kitematic.git","ssh_url":"git@github.com:docker/kitematic.git","clone_url":"https://github.com/docker/kitematic.git","svn_url":"https://github.com/docker/kitematic","homepage":"https://kitematic.com","size":103378,"stargazers_count":6354,"watchers_count":6354,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":636,"mirror_url":null,"open_issues_count":154,"forks":636,"open_issues":154,"watchers":6354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/kitematic/pulls/1960"},"html":{"href":"https://github.com/docker/kitematic/pull/1960"},"issue":{"href":"https://api.github.com/repos/docker/kitematic/issues/1960"},"comments":{"href":"https://api.github.com/repos/docker/kitematic/issues/1960/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/kitematic/pulls/1960/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/kitematic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/kitematic/pulls/1960/commits"},"statuses":{"href":"https://api.github.com/repos/docker/kitematic/statuses/317180e0cc2a98b0307f2e96ecc2c4a900d46211"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"Fahrradflucht"}}