{"action":"created","issue":{"url":"https://api.github.com/repos/Kunde21/numgo/issues/5","repository_url":"https://api.github.com/repos/Kunde21/numgo","labels_url":"https://api.github.com/repos/Kunde21/numgo/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/Kunde21/numgo/issues/5/comments","events_url":"https://api.github.com/repos/Kunde21/numgo/issues/5/events","html_url":"https://github.com/Kunde21/numgo/issues/5","id":191494552,"number":5,"title":"Use of internal package","user":{"login":"binaryplease","id":1719781,"avatar_url":"https://avatars.githubusercontent.com/u/1719781?v=3","gravatar_id":"","url":"https://api.github.com/users/binaryplease","html_url":"https://github.com/binaryplease","followers_url":"https://api.github.com/users/binaryplease/followers","following_url":"https://api.github.com/users/binaryplease/following{/other_user}","gists_url":"https://api.github.com/users/binaryplease/gists{/gist_id}","starred_url":"https://api.github.com/users/binaryplease/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binaryplease/subscriptions","organizations_url":"https://api.github.com/users/binaryplease/orgs","repos_url":"https://api.github.com/users/binaryplease/repos","events_url":"https://api.github.com/users/binaryplease/events{/privacy}","received_events_url":"https://api.github.com/users/binaryplease/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-24T11:17:11Z","updated_at":"2016-11-24T22:34:06Z","closed_at":null,"body":"Hi, \r\nthis is just for discussion, not a real bug or issue.\r\n\r\nIs the use of a \"internal\" package needed/useful? I find it unnecessarily complicated to contribute, for every change I have to fork, pull fork, change package import path to my user, make changes, change package import back, push.  Otherwise I get an error when trying to run the tests:\r\n\r\n```\r\nbinaryplease➜github.com/binaryplease/numgo(master)» go test .                                                                                                                                            \r\npackage github.com/binaryplease/numgo\r\n\timports github.com/Kunde21/numgo/internal: use of internal package not allowed\r\n```\r\n\r\nThis might be a stupid mistake as I'm pretty new to go. Is there a common workaround for this rather than changing the import path in the code forth and back all the time? I must admit I don't really understand the code in that folder very well though."},"comment":{"url":"https://api.github.com/repos/Kunde21/numgo/issues/comments/262851991","html_url":"https://github.com/Kunde21/numgo/issues/5#issuecomment-262851991","issue_url":"https://api.github.com/repos/Kunde21/numgo/issues/5","id":262851991,"user":{"login":"Kunde21","id":10493268,"avatar_url":"https://avatars.githubusercontent.com/u/10493268?v=3","gravatar_id":"","url":"https://api.github.com/users/Kunde21","html_url":"https://github.com/Kunde21","followers_url":"https://api.github.com/users/Kunde21/followers","following_url":"https://api.github.com/users/Kunde21/following{/other_user}","gists_url":"https://api.github.com/users/Kunde21/gists{/gist_id}","starred_url":"https://api.github.com/users/Kunde21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kunde21/subscriptions","organizations_url":"https://api.github.com/users/Kunde21/orgs","repos_url":"https://api.github.com/users/Kunde21/repos","events_url":"https://api.github.com/users/Kunde21/events{/privacy}","received_events_url":"https://api.github.com/users/Kunde21/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T22:34:06Z","updated_at":"2016-11-24T22:34:06Z","body":"The internal package is more for organization and cleanliness than functionality.  It's all of the assembly code for vector operations specific to numgo.  Since assembly isn't very user-friendly, I thought it best to keep it separate.  I need to go through and put each asm function in its own file, as well.\r\n\r\nFor development, it's much easier to add your fork's remote to the original clone than juggle different copies:\r\n\r\n```\r\ngo get github.com/Kunde21/numgo\r\ncd $GOPATH/src/github.com/Kunde21/numgo\r\ngit remote add <RemoteName> git@github.com:binaryplease/numgo\r\n```\r\n\r\nThen, the only change to your workflow is specifying the remote in push/pull commands.\r\n\r\n```\r\ngit branch <BranchName>\r\nedit/compile/test\r\ngit push <RemoteName>\r\n```\r\n"}}
{"actor":{"display_login":"Kunde21"}}