{"action":"created","comment":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/92585493","pull_request_review_id":13103022,"id":92585493,"diff_hunk":"@@ -60,11 +59,12 @@ def cleanup_tables(request, node_config):\n     def fin():\n         conn = connect()\n         try:\n-            conn.run(r.db(db_name).table('bigchain').delete())\n-            conn.run(r.db(db_name).table('backlog').delete())\n-            conn.run(r.db(db_name).table('votes').delete())\n-        except r.ReqlOpFailedError as e:\n-            if e.message != 'Database `{}` does not exist.'.format(db_name):\n+            schema.drop_database(conn, db_name)\n+            schema.create_database(conn, db_name)\n+            schema.create_tables(conn, db_name)\n+            schema.create_indexes(conn, db_name)","path":"tests/db/conftest.py","position":58,"original_position":58,"commit_id":"7dd5e29890a36b1efc95e6659520c31d3be77dcf","original_commit_id":"7dd5e29890a36b1efc95e6659520c31d3be77dcf","user":{"login":"rhsimplex","id":6517700,"avatar_url":"https://avatars.githubusercontent.com/u/6517700?v=3","gravatar_id":"","url":"https://api.github.com/users/rhsimplex","html_url":"https://github.com/rhsimplex","followers_url":"https://api.github.com/users/rhsimplex/followers","following_url":"https://api.github.com/users/rhsimplex/following{/other_user}","gists_url":"https://api.github.com/users/rhsimplex/gists{/gist_id}","starred_url":"https://api.github.com/users/rhsimplex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhsimplex/subscriptions","organizations_url":"https://api.github.com/users/rhsimplex/orgs","repos_url":"https://api.github.com/users/rhsimplex/repos","events_url":"https://api.github.com/users/rhsimplex/events{/privacy}","received_events_url":"https://api.github.com/users/rhsimplex/received_events","type":"User","site_admin":false},"body":"No, that's the annoying thing -- in the RDB specific verison, you could do that, but since the API doesn't expose dropping tables (just the whole db) you have to set it up from scratch each time.","created_at":"2016-12-15T10:49:35Z","updated_at":"2016-12-15T10:49:35Z","html_url":"https://github.com/bigchaindb/bigchaindb/pull/953#discussion_r92585493","pull_request_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953","_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments/92585493"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/953#discussion_r92585493"},"pull_request":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953"}}},"pull_request":{"url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953","id":97985568,"html_url":"https://github.com/bigchaindb/bigchaindb/pull/953","diff_url":"https://github.com/bigchaindb/bigchaindb/pull/953.diff","patch_url":"https://github.com/bigchaindb/bigchaindb/pull/953.patch","issue_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/953","number":953,"state":"open","locked":false,"title":"remove rethinkdb calls","user":{"login":"rhsimplex","id":6517700,"avatar_url":"https://avatars.githubusercontent.com/u/6517700?v=3","gravatar_id":"","url":"https://api.github.com/users/rhsimplex","html_url":"https://github.com/rhsimplex","followers_url":"https://api.github.com/users/rhsimplex/followers","following_url":"https://api.github.com/users/rhsimplex/following{/other_user}","gists_url":"https://api.github.com/users/rhsimplex/gists{/gist_id}","starred_url":"https://api.github.com/users/rhsimplex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhsimplex/subscriptions","organizations_url":"https://api.github.com/users/rhsimplex/orgs","repos_url":"https://api.github.com/users/rhsimplex/repos","events_url":"https://api.github.com/users/rhsimplex/events{/privacy}","received_events_url":"https://api.github.com/users/rhsimplex/received_events","type":"User","site_admin":false},"body":"Remove explicit rethinkdb calls.  A little slower, because we can't just tear down tables each time; the whole db has to be regenerated","created_at":"2016-12-14T16:22:50Z","updated_at":"2016-12-15T10:49:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d12f70306dd651f5e7eb37baeb51b2a89ba79121","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953/commits","review_comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953/comments","review_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/953/comments","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/7dd5e29890a36b1efc95e6659520c31d3be77dcf","head":{"label":"bigchaindb:remove-rethinkdb-calls-from-dbtestconf","ref":"remove-rethinkdb-calls-from-dbtestconf","sha":"7dd5e29890a36b1efc95e6659520c31d3be77dcf","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2016-12-15T08:25:58Z","pushed_at":"2016-12-15T10:45:32Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":6120,"stargazers_count":845,"watchers_count":845,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":180,"forks":164,"open_issues":180,"watchers":845,"default_branch":"master"}},"base":{"label":"bigchaindb:master","ref":"master","sha":"588d6eb177b55537e67ffcd485640ef3832fd088","user":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"repo":{"id":51290852,"name":"bigchaindb","full_name":"bigchaindb/bigchaindb","owner":{"login":"bigchaindb","id":17097586,"avatar_url":"https://avatars.githubusercontent.com/u/17097586?v=3","gravatar_id":"","url":"https://api.github.com/users/bigchaindb","html_url":"https://github.com/bigchaindb","followers_url":"https://api.github.com/users/bigchaindb/followers","following_url":"https://api.github.com/users/bigchaindb/following{/other_user}","gists_url":"https://api.github.com/users/bigchaindb/gists{/gist_id}","starred_url":"https://api.github.com/users/bigchaindb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigchaindb/subscriptions","organizations_url":"https://api.github.com/users/bigchaindb/orgs","repos_url":"https://api.github.com/users/bigchaindb/repos","events_url":"https://api.github.com/users/bigchaindb/events{/privacy}","received_events_url":"https://api.github.com/users/bigchaindb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bigchaindb/bigchaindb","description":"BigchainDB is a scalable blockchain database","fork":false,"url":"https://api.github.com/repos/bigchaindb/bigchaindb","forks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/forks","keys_url":"https://api.github.com/repos/bigchaindb/bigchaindb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigchaindb/bigchaindb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigchaindb/bigchaindb/teams","hooks_url":"https://api.github.com/repos/bigchaindb/bigchaindb/hooks","issue_events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/events{/number}","events_url":"https://api.github.com/repos/bigchaindb/bigchaindb/events","assignees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/assignees{/user}","branches_url":"https://api.github.com/repos/bigchaindb/bigchaindb/branches{/branch}","tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/tags","blobs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/{sha}","languages_url":"https://api.github.com/repos/bigchaindb/bigchaindb/languages","stargazers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/stargazers","contributors_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contributors","subscribers_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscribers","subscription_url":"https://api.github.com/repos/bigchaindb/bigchaindb/subscription","commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigchaindb/bigchaindb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigchaindb/bigchaindb/contents/{+path}","compare_url":"https://api.github.com/repos/bigchaindb/bigchaindb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigchaindb/bigchaindb/merges","archive_url":"https://api.github.com/repos/bigchaindb/bigchaindb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigchaindb/bigchaindb/downloads","issues_url":"https://api.github.com/repos/bigchaindb/bigchaindb/issues{/number}","pulls_url":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls{/number}","milestones_url":"https://api.github.com/repos/bigchaindb/bigchaindb/milestones{/number}","notifications_url":"https://api.github.com/repos/bigchaindb/bigchaindb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigchaindb/bigchaindb/labels{/name}","releases_url":"https://api.github.com/repos/bigchaindb/bigchaindb/releases{/id}","deployments_url":"https://api.github.com/repos/bigchaindb/bigchaindb/deployments","created_at":"2016-02-08T10:12:58Z","updated_at":"2016-12-15T08:25:58Z","pushed_at":"2016-12-15T10:45:32Z","git_url":"git://github.com/bigchaindb/bigchaindb.git","ssh_url":"git@github.com:bigchaindb/bigchaindb.git","clone_url":"https://github.com/bigchaindb/bigchaindb.git","svn_url":"https://github.com/bigchaindb/bigchaindb","homepage":"https://www.bigchaindb.com/","size":6120,"stargazers_count":845,"watchers_count":845,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"open_issues_count":180,"forks":164,"open_issues":180,"watchers":845,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953"},"html":{"href":"https://github.com/bigchaindb/bigchaindb/pull/953"},"issue":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/953"},"comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/issues/953/comments"},"review_comments":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953/comments"},"review_comment":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/pulls/953/commits"},"statuses":{"href":"https://api.github.com/repos/bigchaindb/bigchaindb/statuses/7dd5e29890a36b1efc95e6659520c31d3be77dcf"}}}}
{"actor":{"display_login":"rhsimplex"}}