{"action":"closed","issue":{"url":"https://api.github.com/repos/DiscordFM/shortwave-radio/issues/4","repository_url":"https://api.github.com/repos/DiscordFM/shortwave-radio","labels_url":"https://api.github.com/repos/DiscordFM/shortwave-radio/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/DiscordFM/shortwave-radio/issues/4/comments","events_url":"https://api.github.com/repos/DiscordFM/shortwave-radio/issues/4/events","html_url":"https://github.com/DiscordFM/shortwave-radio/issues/4","id":182187544,"number":4,"title":"Channels aren't being reordered correctly","user":{"login":"deansheather","id":11241812,"avatar_url":"https://avatars.githubusercontent.com/u/11241812?v=3","gravatar_id":"","url":"https://api.github.com/users/deansheather","html_url":"https://github.com/deansheather","followers_url":"https://api.github.com/users/deansheather/followers","following_url":"https://api.github.com/users/deansheather/following{/other_user}","gists_url":"https://api.github.com/users/deansheather/gists{/gist_id}","starred_url":"https://api.github.com/users/deansheather/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deansheather/subscriptions","organizations_url":"https://api.github.com/users/deansheather/orgs","repos_url":"https://api.github.com/users/deansheather/repos","events_url":"https://api.github.com/users/deansheather/events{/privacy}","received_events_url":"https://api.github.com/users/deansheather/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/DiscordFM/shortwave-radio/labels/bug","name":"bug","color":"ee0701"}],"state":"closed","locked":false,"assignee":{"login":"pyraxo","id":4499470,"avatar_url":"https://avatars.githubusercontent.com/u/4499470?v=3","gravatar_id":"","url":"https://api.github.com/users/pyraxo","html_url":"https://github.com/pyraxo","followers_url":"https://api.github.com/users/pyraxo/followers","following_url":"https://api.github.com/users/pyraxo/following{/other_user}","gists_url":"https://api.github.com/users/pyraxo/gists{/gist_id}","starred_url":"https://api.github.com/users/pyraxo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyraxo/subscriptions","organizations_url":"https://api.github.com/users/pyraxo/orgs","repos_url":"https://api.github.com/users/pyraxo/repos","events_url":"https://api.github.com/users/pyraxo/events{/privacy}","received_events_url":"https://api.github.com/users/pyraxo/received_events","type":"User","site_admin":false},"assignees":[{"login":"pyraxo","id":4499470,"avatar_url":"https://avatars.githubusercontent.com/u/4499470?v=3","gravatar_id":"","url":"https://api.github.com/users/pyraxo","html_url":"https://github.com/pyraxo","followers_url":"https://api.github.com/users/pyraxo/followers","following_url":"https://api.github.com/users/pyraxo/following{/other_user}","gists_url":"https://api.github.com/users/pyraxo/gists{/gist_id}","starred_url":"https://api.github.com/users/pyraxo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyraxo/subscriptions","organizations_url":"https://api.github.com/users/pyraxo/orgs","repos_url":"https://api.github.com/users/pyraxo/repos","events_url":"https://api.github.com/users/pyraxo/events{/privacy}","received_events_url":"https://api.github.com/users/pyraxo/received_events","type":"User","site_admin":false},{"login":"Ovyerus","id":18654005,"avatar_url":"https://avatars.githubusercontent.com/u/18654005?v=3","gravatar_id":"","url":"https://api.github.com/users/Ovyerus","html_url":"https://github.com/Ovyerus","followers_url":"https://api.github.com/users/Ovyerus/followers","following_url":"https://api.github.com/users/Ovyerus/following{/other_user}","gists_url":"https://api.github.com/users/Ovyerus/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovyerus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovyerus/subscriptions","organizations_url":"https://api.github.com/users/Ovyerus/orgs","repos_url":"https://api.github.com/users/Ovyerus/repos","events_url":"https://api.github.com/users/Ovyerus/events{/privacy}","received_events_url":"https://api.github.com/users/Ovyerus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2016-10-11T06:58:28Z","updated_at":"2016-10-22T09:57:09Z","closed_at":"2016-10-22T09:57:09Z","body":"When the bot finishes streaming, it fails to reorder the channels correctly. This means that a staff member needs to reorder channels manually after transmission.\r\n\r\nThe code that *should* be handling reordering can be found at https://github.com/DiscordFM/shortwave-radio/blob/master/src/lib/numbers.js#L40 and https://github.com/DiscordFM/shortwave-radio/blob/master/src/lib/numbers.js#L130-L152.\r\n\r\nI suspect the problem is that the code does not wait for the voice channel to be deleted, we should wait for the promise to finish (resolved or rejected) before we send the batch channel update request."}}
{"actor":{"display_login":"Ovyerus"}}