{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/24100","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/24100/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/24100/comments","events_url":"https://api.github.com/repos/docker/docker/issues/24100/events","html_url":"https://github.com/docker/docker/pull/24100","id":162847952,"number":24100,"title":"Revert tasksmax workaround to avoid unsupported bins","user":{"login":"StefanScherer","id":207759,"avatar_url":"https://avatars.githubusercontent.com/u/207759?v=3","gravatar_id":"","url":"https://api.github.com/users/StefanScherer","html_url":"https://github.com/StefanScherer","followers_url":"https://api.github.com/users/StefanScherer/followers","following_url":"https://api.github.com/users/StefanScherer/following{/other_user}","gists_url":"https://api.github.com/users/StefanScherer/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanScherer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanScherer/subscriptions","organizations_url":"https://api.github.com/users/StefanScherer/orgs","repos_url":"https://api.github.com/users/StefanScherer/repos","events_url":"https://api.github.com/users/StefanScherer/events{/privacy}","received_events_url":"https://api.github.com/users/StefanScherer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/docker/labels/priority/P1","name":"priority/P1","color":"eb6420"},{"url":"https://api.github.com/repos/docker/docker/labels/status/1-design-review","name":"status/1-design-review","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/53","html_url":"https://github.com/docker/docker/milestones/1.12.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/53/labels","id":1657301,"number":53,"title":"1.12.0","description":"feature/code freeze: June 14th, 2016","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":104,"closed_issues":444,"state":"open","created_at":"2016-03-21T13:47:53Z","updated_at":"2016-06-30T18:24:12Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2016-06-29T06:08:12Z","updated_at":"2016-06-30T18:26:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/24100","html_url":"https://github.com/docker/docker/pull/24100","diff_url":"https://github.com/docker/docker/pull/24100.diff","patch_url":"https://github.com/docker/docker/pull/24100.patch"},"body":"This PR reverts PR #21628 and does no longer modify the git source tree for any OS until we come up with a better solution setting tasksmax differently for specific OS.\r\n\r\nThe modification of 21628 while building the binaries for each DEB package result in binaries with the \"unsupported\" tag if checked with `docker --version` or `docker version`.\r\n\r\n**- What I did**\r\n\r\nI compiled all DEB packages with `make deb` for v1.12.0-rc2 and found out that some OS have unsupported binaries. So I reverted that commit that introduced the code change.\r\n\r\n**- How I did it**\r\n\r\n```\r\ngit clone https://github.com/docker/docker\r\ncd docker\r\ngit checkout v1.12.0-rc2\r\nmake deb\r\n```\r\n\r\n**- How to verify it**\r\n\r\nYou can reproduce this problem by installing eg. the 1.12.0-rc2 DEB package on eg. ubuntu:xenial or debian:stretch with `curl -fsSL https://test.docker.com/ | sh`.\r\n\r\n```\r\n+ sh -c docker version\r\nClient:\r\n Version:      1.12.0-rc2\r\n API version:  1.24\r\n Go version:   go1.6.2\r\n Git commit:   906eacd-unsupported\r\n Built:        Fri Jun 17 21:21:56 2016\r\n OS/Arch:      linux/amd64\r\n\r\nServer:\r\n Version:      1.12.0-rc2\r\n API version:  1.24\r\n Go version:   go1.6.2\r\n Git commit:   906eacd-unsupported\r\n Built:        Fri Jun 17 21:21:56 2016\r\n OS/Arch:      linux/amd64\r\n\r\nroot@ubuntu-xenial:/home/ubuntu# \r\n```\r\n\r\nThe same steps with a debian/jessie64 Vagrant box shows clean binaries.\r\n\r\n**- Description for the changelog**\r\n\r\nRevert tasksmax hack to avoid unsupported binaries in DEB packages.\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n![flop](https://cloud.githubusercontent.com/assets/207759/16441967/e0a36a90-3dce-11e6-9a06-20fee814ee60.jpg)\r\n\r\n(mirrored image of 21628 :-) )\r\n\r\nPS: You can't take a shortcut and remove some directories in the contrib/builder/deb/amd64 directory as this also leeds to a git code change and unsupported binaries.\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/229746809","html_url":"https://github.com/docker/docker/pull/24100#issuecomment-229746809","issue_url":"https://api.github.com/repos/docker/docker/issues/24100","id":229746809,"user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"created_at":"2016-06-30T18:26:30Z","updated_at":"2016-06-30T18:26:30Z","body":"Uh, this shouldn't cause the build to be marked `unsupported`. The file being modified is generated by the `build-deb' script and as such shouldn't be part of the git repository.\r\n\r\nLMTAL."}}
{"actor":{"display_login":"mlaventure"}}