{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/comments/64690180","id":64690180,"diff_hunk":"@@ -5,35 +5,22 @@ VAGRANTFILE_API_VERSION = '2'\n \n @script = <<SCRIPT\n DOCUMENT_ROOT_ZEND=\"/var/www/zf/public\"","path":"Vagrantfile","position":3,"original_position":3,"commit_id":"28ba4f482de3baf63a8f9bda63884b7b3c4f3df6","original_commit_id":"28ba4f482de3baf63a8f9bda63884b7b3c4f3df6","user":{"login":"Maks3w","id":1301698,"avatar_url":"https://avatars.githubusercontent.com/u/1301698?v=3","gravatar_id":"","url":"https://api.github.com/users/Maks3w","html_url":"https://github.com/Maks3w","followers_url":"https://api.github.com/users/Maks3w/followers","following_url":"https://api.github.com/users/Maks3w/following{/other_user}","gists_url":"https://api.github.com/users/Maks3w/gists{/gist_id}","starred_url":"https://api.github.com/users/Maks3w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maks3w/subscriptions","organizations_url":"https://api.github.com/users/Maks3w/orgs","repos_url":"https://api.github.com/users/Maks3w/repos","events_url":"https://api.github.com/users/Maks3w/events{/privacy}","received_events_url":"https://api.github.com/users/Maks3w/received_events","type":"User","site_admin":false},"body":"This env var is now unused","created_at":"2016-05-26T04:25:16Z","updated_at":"2016-05-26T04:25:16Z","html_url":"https://github.com/zendframework/ZendSkeletonApplication/pull/329#discussion_r64690180","pull_request_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329","_links":{"self":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/comments/64690180"},"html":{"href":"https://github.com/zendframework/ZendSkeletonApplication/pull/329#discussion_r64690180"},"pull_request":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329","id":66914847,"html_url":"https://github.com/zendframework/ZendSkeletonApplication/pull/329","diff_url":"https://github.com/zendframework/ZendSkeletonApplication/pull/329.diff","patch_url":"https://github.com/zendframework/ZendSkeletonApplication/pull/329.patch","issue_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues/329","number":329,"state":"open","locked":false,"title":"Prepare for zend-mvc v3","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"body":"For the v3 release, we will be pulling in a smaller set of components out-of-the-box. These are primarily defined by zend-mvc, but also include:\r\n\r\n- ~~zend-config (used by the zend-modulemanager `ConfigListener` by default)~~ (zend-modulemanager now defines the zend-config requirement)\r\n- [zend-skeleton-installer](https://zendframework.github.io/zend-skeleton-installer/) for prompting for optional packages/capabilities.\r\n- [zend-component-installer](https://zendframework.github.io/zend-component-installer), to automate registration of components as modules.\r\n\r\nAdditionally, we plan to leverage Composer for all autoloading, which means:\r\n\r\n- we can register a PSR-4 entry for the `Application` module, and remove one directory level;\r\n- the `Application` module no longer needs to setup autoloading.\r\n\r\nFor a minimal application, we do not want or need internationalization. As such, this patch also *removes all translations* and calls to translate strings in templates. We can explore re-adding them later, or offering an alternative skeleton application with more default features (including i18n, forms, databases, etc.).\r\n\r\nAt the time of submission, this patch provides a working skeleton with the current zend-mvc develop branch.\r\n\r\n## Testing\r\n\r\nIf you wish to test:\r\n\r\n- Clone the repository locally\r\n- Enter the cloned repository\r\n- Switch to the develop branch: `git checkout -b develop origin/develop`\r\n- Apply the changes: `wget https://patch-diff.githubusercontent.com/raw/zendframework/ZendSkeletonApplication/pull/329.patch && git am 329.patch` (or, if you use the hub command: `git merge https://github.com/zendframework/ZendSkeletonApplication/pull/329`)\r\n- Execute `composer install`\r\n\r\nIf you want to use vagrant:\r\n\r\n- Start it: `vagrant up`\r\n- Run composer within it: `vagrant ssh -c 'cd /var/www ; composer install'`\r\n- Start testing\r\n\r\nIf you want to use docker:\r\n\r\n- Build it: `docker build -t zend-skeleton-application .`\r\n- Run composer within it: `docker run -v $(pwd):/var/www zend-skeleton-application composer install`\r\n- Run the web server: `docker run -d -v $(pwd):/var/www -p 8080:80`\r\n- Start testing.\r\n\r\nIf you want to use docker-compose:\r\n\r\n- Build it: `docker-compose build`\r\n- Run composer within it: `docker-compose run dev composer install`\r\n- Run the web server: `docker-compose up -d`\r\n- Start testing.\r\n\r\nPlease report any issues you notice or provide constructive feedback via comments to this pull request, or issue a pull request against my branch.\r\n\r\n## TODO\r\n\r\n### Installer\r\n\r\n- [x] Prompt for caching\r\n  - will install zend-cache\r\n- [x] Prompt for console\r\n  - prompt should indicate users should migrate to zf-console\r\n  - will install zend-mvc-console\r\n- [x] Prompt for database\r\n  - will install zend-db\r\n- [x] Prompt for forms\r\n  - will install zend-form\r\n- [x] Prompt for i18n\r\n  - will install zend-mvc-i18n\r\n- [x] Prompt for JSON\r\n  - will install zend-json\r\n- [x] Prompt for logging\r\n  - will install zend-log\r\n- [x] Prompt for PSR-7 middleware dispatcher\r\n  - will install zend-psr7bridge\r\n- [x] Prompt for sessions\r\n  - will install zend-session\r\n- [x] Prompt for testing facilities\r\n  - will install zend-test *as dev requirement*\r\n- [x] Prompt for plugins\r\n  - will install zend-mvc-plugin-*\r\n- [x] Prompt for zend-di integration\r\n  - will install zend-servicemanager-di\r\n\r\nIn each case, this should register the module(s) with the application, so that the user does not need to be prompted twice.\r\n\r\n### Documentation\r\n\r\n- ModuleRouteListener is removed from the skeleton. This won't affect existing users, but *will* affect experienced users who originally relied on it being active in new skeleton projects.\r\n- The `/[:controller][/:action]]` route was removed from the skeleton. Again, it will not affect existing users, but *will* affect experienced users who originally relied on it being active in new skeleton projects.\r\n\r\nThese items have been added to the [maintainers wiki](https://github.com/zendframework/maintainers/wiki/Tutorials-and-documentation-tasks-for-v3).\r\n\r\n\r\n## Updates\r\n\r\n- *2016-05-17: added TODO list tracking installer and documentation tasks remaining.*","created_at":"2016-04-18T20:17:49Z","updated_at":"2016-05-26T04:25:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c40e1028b509f72df14f7d55ce5e1fbb35fadcbd","assignee":null,"milestone":{"url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/milestones/1","html_url":"https://github.com/zendframework/ZendSkeletonApplication/milestones/3.0.0","labels_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/milestones/1/labels","id":1715279,"number":1,"title":"3.0.0","description":null,"creator":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":0,"state":"open","created_at":"2016-04-18T20:18:00Z","updated_at":"2016-04-18T20:18:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329/commits","review_comments_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329/comments","review_comment_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues/329/comments","statuses_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/statuses/28ba4f482de3baf63a8f9bda63884b7b3c4f3df6","head":{"label":"weierophinney:feature/zend-mvc-v3-minimal","ref":"feature/zend-mvc-v3-minimal","sha":"28ba4f482de3baf63a8f9bda63884b7b3c4f3df6","user":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"repo":{"id":3426250,"name":"ZendSkeletonApplication","full_name":"weierophinney/ZendSkeletonApplication","owner":{"login":"weierophinney","id":25943,"avatar_url":"https://avatars.githubusercontent.com/u/25943?v=3","gravatar_id":"","url":"https://api.github.com/users/weierophinney","html_url":"https://github.com/weierophinney","followers_url":"https://api.github.com/users/weierophinney/followers","following_url":"https://api.github.com/users/weierophinney/following{/other_user}","gists_url":"https://api.github.com/users/weierophinney/gists{/gist_id}","starred_url":"https://api.github.com/users/weierophinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weierophinney/subscriptions","organizations_url":"https://api.github.com/users/weierophinney/orgs","repos_url":"https://api.github.com/users/weierophinney/repos","events_url":"https://api.github.com/users/weierophinney/events{/privacy}","received_events_url":"https://api.github.com/users/weierophinney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weierophinney/ZendSkeletonApplication","description":"Sample application skeleton using the ZF2 MVC layer","fork":true,"url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication","forks_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/forks","keys_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/teams","hooks_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/hooks","issue_events_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/issues/events{/number}","events_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/events","assignees_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/assignees{/user}","branches_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/branches{/branch}","tags_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/tags","blobs_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/git/refs{/sha}","trees_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/statuses/{sha}","languages_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/languages","stargazers_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/stargazers","contributors_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/contributors","subscribers_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/subscribers","subscription_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/subscription","commits_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/commits{/sha}","git_commits_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/git/commits{/sha}","comments_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/comments{/number}","issue_comment_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/issues/comments{/number}","contents_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/contents/{+path}","compare_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/merges","archive_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/downloads","issues_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/issues{/number}","pulls_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/pulls{/number}","milestones_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/milestones{/number}","notifications_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/labels{/name}","releases_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/releases{/id}","deployments_url":"https://api.github.com/repos/weierophinney/ZendSkeletonApplication/deployments","created_at":"2012-02-13T01:29:37Z","updated_at":"2016-04-26T02:12:06Z","pushed_at":"2016-05-25T22:18:00Z","git_url":"git://github.com/weierophinney/ZendSkeletonApplication.git","ssh_url":"git@github.com:weierophinney/ZendSkeletonApplication.git","clone_url":"https://github.com/weierophinney/ZendSkeletonApplication.git","svn_url":"https://github.com/weierophinney/ZendSkeletonApplication","homepage":"http://framework.zend.com/zf2","size":1738,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":13,"default_branch":"master"}},"base":{"label":"zendframework:master","ref":"master","sha":"57c1011bb356546d0b4b8b6b3b26bd5e870acbcf","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2484971,"name":"ZendSkeletonApplication","full_name":"zendframework/ZendSkeletonApplication","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars.githubusercontent.com/u/296074?v=3","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/ZendSkeletonApplication","description":"Sample application skeleton using the ZF2 MVC layer","fork":false,"url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication","forks_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/forks","keys_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/teams","hooks_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/hooks","issue_events_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/events","assignees_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/tags","blobs_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/languages","stargazers_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/stargazers","contributors_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/contributors","subscribers_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/subscribers","subscription_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/subscription","commits_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/merges","archive_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/downloads","issues_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/deployments","created_at":"2011-09-29T21:14:22Z","updated_at":"2016-05-25T21:59:27Z","pushed_at":"2016-05-25T22:18:00Z","git_url":"git://github.com/zendframework/ZendSkeletonApplication.git","ssh_url":"git@github.com:zendframework/ZendSkeletonApplication.git","clone_url":"https://github.com/zendframework/ZendSkeletonApplication.git","svn_url":"https://github.com/zendframework/ZendSkeletonApplication","homepage":"http://framework.zend.com/zf2","size":5022,"stargazers_count":1471,"watchers_count":1471,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1603,"mirror_url":null,"open_issues_count":16,"forks":1603,"open_issues":16,"watchers":1471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329"},"html":{"href":"https://github.com/zendframework/ZendSkeletonApplication/pull/329"},"issue":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues/329"},"comments":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/issues/329/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/pulls/329/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/ZendSkeletonApplication/statuses/28ba4f482de3baf63a8f9bda63884b7b3c4f3df6"}}}}
{"actor":{"display_login":"Maks3w"}}