{"action":"created","issue":{"url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/issues/5","repository_url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool","labels_url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/issues/5/comments","events_url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/issues/5/events","html_url":"https://github.com/AndiDittrich/NodeMCU-Tool/pull/5","id":137083101,"number":5,"title":"Add the ability to provide remote destination filename or keep relative path in destination filename","user":{"login":"loicortola","id":2526081,"avatar_url":"https://avatars.githubusercontent.com/u/2526081?v=3","gravatar_id":"","url":"https://api.github.com/users/loicortola","html_url":"https://github.com/loicortola","followers_url":"https://api.github.com/users/loicortola/followers","following_url":"https://api.github.com/users/loicortola/following{/other_user}","gists_url":"https://api.github.com/users/loicortola/gists{/gist_id}","starred_url":"https://api.github.com/users/loicortola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loicortola/subscriptions","organizations_url":"https://api.github.com/users/loicortola/orgs","repos_url":"https://api.github.com/users/loicortola/repos","events_url":"https://api.github.com/users/loicortola/events{/privacy}","received_events_url":"https://api.github.com/users/loicortola/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-28T19:01:06Z","updated_at":"2016-03-02T14:24:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/pulls/5","html_url":"https://github.com/AndiDittrich/NodeMCU-Tool/pull/5","diff_url":"https://github.com/AndiDittrich/NodeMCU-Tool/pull/5.diff","patch_url":"https://github.com/AndiDittrich/NodeMCU-Tool/pull/5.patch"},"body":"First, let me thank you for this awesome tool that you have provided.\r\nI use it a lot and I think it is a great replacement for the python tool.\r\n\r\nFor many use-cases (especially webservers and static files), it is important for an upload script to keep the paths in the filenames.\r\n\r\nAs you know, NodeMCU's filesystem is key/value based and it is possible to have slashes in a filename.\r\n\r\nThe default behaviour for this was to strip the path, and only keep the filename.\r\n\r\nI propose this PR which gives the user two more options in the CLI: --keeppath and --remotename.\r\n\r\nN.B: This changes the upload function signature a little. If you have important concerts about backward compatibility, thanks for letting me know, and I will rearrange the code to trick it."},"comment":{"url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/issues/comments/191257373","html_url":"https://github.com/AndiDittrich/NodeMCU-Tool/pull/5#issuecomment-191257373","issue_url":"https://api.github.com/repos/AndiDittrich/NodeMCU-Tool/issues/5","id":191257373,"user":{"login":"AndiDittrich","id":1474107,"avatar_url":"https://avatars.githubusercontent.com/u/1474107?v=3","gravatar_id":"","url":"https://api.github.com/users/AndiDittrich","html_url":"https://github.com/AndiDittrich","followers_url":"https://api.github.com/users/AndiDittrich/followers","following_url":"https://api.github.com/users/AndiDittrich/following{/other_user}","gists_url":"https://api.github.com/users/AndiDittrich/gists{/gist_id}","starred_url":"https://api.github.com/users/AndiDittrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndiDittrich/subscriptions","organizations_url":"https://api.github.com/users/AndiDittrich/orgs","repos_url":"https://api.github.com/users/AndiDittrich/repos","events_url":"https://api.github.com/users/AndiDittrich/events{/privacy}","received_events_url":"https://api.github.com/users/AndiDittrich/received_events","type":"User","site_admin":false},"created_at":"2016-03-02T14:24:30Z","updated_at":"2016-03-02T14:24:30Z","body":"In `lib/NodeMcuConnector.js` line 21\r\n```js\r\ncompile: 'node.comgpile(\"?\")'\r\n```\r\nis this a typo or a new NodeMCU core function ?"}}