{"action":"created","comment":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/comments/84033977","pull_request_review_id":4836212,"id":84033977,"diff_hunk":"@@ -146,11 +127,11 @@ def hillas_parameters_1(pix_x, pix_y, image):\n     a = d2 / d1\n     # Angle between ellipse major ax. and x-axis of camera. Will be used for\n     # disp\n-    delta = np.pi / 2.0 + np.arctan(a)\n+    delta = ((np.pi / 2.0) + np.arctan(a)) * u.rad","path":"ctapipe/image/hillas.py","position":null,"original_position":65,"commit_id":"e6bbbc4941b44e25b281e2d864466d3fc9db5cab","original_commit_id":"c3792bbd709288c912dcae4c25b3d76eb94a4f95","user":{"login":"wrijupan","id":17830542,"avatar_url":"https://avatars.githubusercontent.com/u/17830542?v=3","gravatar_id":"","url":"https://api.github.com/users/wrijupan","html_url":"https://github.com/wrijupan","followers_url":"https://api.github.com/users/wrijupan/followers","following_url":"https://api.github.com/users/wrijupan/following{/other_user}","gists_url":"https://api.github.com/users/wrijupan/gists{/gist_id}","starred_url":"https://api.github.com/users/wrijupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrijupan/subscriptions","organizations_url":"https://api.github.com/users/wrijupan/orgs","repos_url":"https://api.github.com/users/wrijupan/repos","events_url":"https://api.github.com/users/wrijupan/events{/privacy}","received_events_url":"https://api.github.com/users/wrijupan/received_events","type":"User","site_admin":false},"body":"The motivation to introduce units to delta is because it is returned in degrees as psi. But it is true that this just slows down the computation. To make more sense, I have just now made a new commit where the entire code uses the angle values in radians and at the return line deals with all the units and unit conversions. \r\n\r\nAnd also, I realized the name 'delta' might create confusion. Hence I renamed it to psi, since it is returned as psi in the output.","created_at":"2016-10-19T09:50:02Z","updated_at":"2016-10-19T09:50:02Z","html_url":"https://github.com/cta-observatory/ctapipe/pull/193#discussion_r84033977","pull_request_url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/comments/84033977"},"html":{"href":"https://github.com/cta-observatory/ctapipe/pull/193#discussion_r84033977"},"pull_request":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193","id":89038635,"html_url":"https://github.com/cta-observatory/ctapipe/pull/193","diff_url":"https://github.com/cta-observatory/ctapipe/pull/193.diff","patch_url":"https://github.com/cta-observatory/ctapipe/pull/193.patch","issue_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/193","number":193,"state":"open","locked":false,"title":"higher order moments in version 2","user":{"login":"wrijupan","id":17830542,"avatar_url":"https://avatars.githubusercontent.com/u/17830542?v=3","gravatar_id":"","url":"https://api.github.com/users/wrijupan","html_url":"https://github.com/wrijupan","followers_url":"https://api.github.com/users/wrijupan/followers","following_url":"https://api.github.com/users/wrijupan/following{/other_user}","gists_url":"https://api.github.com/users/wrijupan/gists{/gist_id}","starred_url":"https://api.github.com/users/wrijupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrijupan/subscriptions","organizations_url":"https://api.github.com/users/wrijupan/orgs","repos_url":"https://api.github.com/users/wrijupan/repos","events_url":"https://api.github.com/users/wrijupan/events{/privacy}","received_events_url":"https://api.github.com/users/wrijupan/received_events","type":"User","site_admin":false},"body":"hillas_parameters_1 and hillas_parameters_2 are now compatible in units","created_at":"2016-10-12T15:31:37Z","updated_at":"2016-10-19T09:50:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9aad1e45ff8b8811fc2f5d940f3caddafa146bb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193/commits","review_comments_url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193/comments","review_comment_url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/193/comments","statuses_url":"https://api.github.com/repos/cta-observatory/ctapipe/statuses/e6bbbc4941b44e25b281e2d864466d3fc9db5cab","head":{"label":"wrijupan:master","ref":"master","sha":"e6bbbc4941b44e25b281e2d864466d3fc9db5cab","user":{"login":"wrijupan","id":17830542,"avatar_url":"https://avatars.githubusercontent.com/u/17830542?v=3","gravatar_id":"","url":"https://api.github.com/users/wrijupan","html_url":"https://github.com/wrijupan","followers_url":"https://api.github.com/users/wrijupan/followers","following_url":"https://api.github.com/users/wrijupan/following{/other_user}","gists_url":"https://api.github.com/users/wrijupan/gists{/gist_id}","starred_url":"https://api.github.com/users/wrijupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrijupan/subscriptions","organizations_url":"https://api.github.com/users/wrijupan/orgs","repos_url":"https://api.github.com/users/wrijupan/repos","events_url":"https://api.github.com/users/wrijupan/events{/privacy}","received_events_url":"https://api.github.com/users/wrijupan/received_events","type":"User","site_admin":false},"repo":{"id":53866924,"name":"ctapipe","full_name":"wrijupan/ctapipe","owner":{"login":"wrijupan","id":17830542,"avatar_url":"https://avatars.githubusercontent.com/u/17830542?v=3","gravatar_id":"","url":"https://api.github.com/users/wrijupan","html_url":"https://github.com/wrijupan","followers_url":"https://api.github.com/users/wrijupan/followers","following_url":"https://api.github.com/users/wrijupan/following{/other_user}","gists_url":"https://api.github.com/users/wrijupan/gists{/gist_id}","starred_url":"https://api.github.com/users/wrijupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wrijupan/subscriptions","organizations_url":"https://api.github.com/users/wrijupan/orgs","repos_url":"https://api.github.com/users/wrijupan/repos","events_url":"https://api.github.com/users/wrijupan/events{/privacy}","received_events_url":"https://api.github.com/users/wrijupan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wrijupan/ctapipe","description":"CTA Python pipeline experimental version","fork":true,"url":"https://api.github.com/repos/wrijupan/ctapipe","forks_url":"https://api.github.com/repos/wrijupan/ctapipe/forks","keys_url":"https://api.github.com/repos/wrijupan/ctapipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wrijupan/ctapipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wrijupan/ctapipe/teams","hooks_url":"https://api.github.com/repos/wrijupan/ctapipe/hooks","issue_events_url":"https://api.github.com/repos/wrijupan/ctapipe/issues/events{/number}","events_url":"https://api.github.com/repos/wrijupan/ctapipe/events","assignees_url":"https://api.github.com/repos/wrijupan/ctapipe/assignees{/user}","branches_url":"https://api.github.com/repos/wrijupan/ctapipe/branches{/branch}","tags_url":"https://api.github.com/repos/wrijupan/ctapipe/tags","blobs_url":"https://api.github.com/repos/wrijupan/ctapipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wrijupan/ctapipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wrijupan/ctapipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/wrijupan/ctapipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wrijupan/ctapipe/statuses/{sha}","languages_url":"https://api.github.com/repos/wrijupan/ctapipe/languages","stargazers_url":"https://api.github.com/repos/wrijupan/ctapipe/stargazers","contributors_url":"https://api.github.com/repos/wrijupan/ctapipe/contributors","subscribers_url":"https://api.github.com/repos/wrijupan/ctapipe/subscribers","subscription_url":"https://api.github.com/repos/wrijupan/ctapipe/subscription","commits_url":"https://api.github.com/repos/wrijupan/ctapipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/wrijupan/ctapipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/wrijupan/ctapipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/wrijupan/ctapipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/wrijupan/ctapipe/contents/{+path}","compare_url":"https://api.github.com/repos/wrijupan/ctapipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wrijupan/ctapipe/merges","archive_url":"https://api.github.com/repos/wrijupan/ctapipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wrijupan/ctapipe/downloads","issues_url":"https://api.github.com/repos/wrijupan/ctapipe/issues{/number}","pulls_url":"https://api.github.com/repos/wrijupan/ctapipe/pulls{/number}","milestones_url":"https://api.github.com/repos/wrijupan/ctapipe/milestones{/number}","notifications_url":"https://api.github.com/repos/wrijupan/ctapipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wrijupan/ctapipe/labels{/name}","releases_url":"https://api.github.com/repos/wrijupan/ctapipe/releases{/id}","deployments_url":"https://api.github.com/repos/wrijupan/ctapipe/deployments","created_at":"2016-03-14T15:13:14Z","updated_at":"2016-03-14T15:13:15Z","pushed_at":"2016-10-19T09:34:18Z","git_url":"git://github.com/wrijupan/ctapipe.git","ssh_url":"git@github.com:wrijupan/ctapipe.git","clone_url":"https://github.com/wrijupan/ctapipe.git","svn_url":"https://github.com/wrijupan/ctapipe","homepage":"https://cta-observatory.github.io/ctapipe/","size":13646,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cta-observatory:master","ref":"master","sha":"f814e9d702e91da4f44c145fc33debfdb164ceea","user":{"login":"cta-observatory","id":13019529,"avatar_url":"https://avatars.githubusercontent.com/u/13019529?v=3","gravatar_id":"","url":"https://api.github.com/users/cta-observatory","html_url":"https://github.com/cta-observatory","followers_url":"https://api.github.com/users/cta-observatory/followers","following_url":"https://api.github.com/users/cta-observatory/following{/other_user}","gists_url":"https://api.github.com/users/cta-observatory/gists{/gist_id}","starred_url":"https://api.github.com/users/cta-observatory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cta-observatory/subscriptions","organizations_url":"https://api.github.com/users/cta-observatory/orgs","repos_url":"https://api.github.com/users/cta-observatory/repos","events_url":"https://api.github.com/users/cta-observatory/events{/privacy}","received_events_url":"https://api.github.com/users/cta-observatory/received_events","type":"Organization","site_admin":false},"repo":{"id":37927055,"name":"ctapipe","full_name":"cta-observatory/ctapipe","owner":{"login":"cta-observatory","id":13019529,"avatar_url":"https://avatars.githubusercontent.com/u/13019529?v=3","gravatar_id":"","url":"https://api.github.com/users/cta-observatory","html_url":"https://github.com/cta-observatory","followers_url":"https://api.github.com/users/cta-observatory/followers","following_url":"https://api.github.com/users/cta-observatory/following{/other_user}","gists_url":"https://api.github.com/users/cta-observatory/gists{/gist_id}","starred_url":"https://api.github.com/users/cta-observatory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cta-observatory/subscriptions","organizations_url":"https://api.github.com/users/cta-observatory/orgs","repos_url":"https://api.github.com/users/cta-observatory/repos","events_url":"https://api.github.com/users/cta-observatory/events{/privacy}","received_events_url":"https://api.github.com/users/cta-observatory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cta-observatory/ctapipe","description":"CTA Python pipeline experimental version","fork":false,"url":"https://api.github.com/repos/cta-observatory/ctapipe","forks_url":"https://api.github.com/repos/cta-observatory/ctapipe/forks","keys_url":"https://api.github.com/repos/cta-observatory/ctapipe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cta-observatory/ctapipe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cta-observatory/ctapipe/teams","hooks_url":"https://api.github.com/repos/cta-observatory/ctapipe/hooks","issue_events_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/events{/number}","events_url":"https://api.github.com/repos/cta-observatory/ctapipe/events","assignees_url":"https://api.github.com/repos/cta-observatory/ctapipe/assignees{/user}","branches_url":"https://api.github.com/repos/cta-observatory/ctapipe/branches{/branch}","tags_url":"https://api.github.com/repos/cta-observatory/ctapipe/tags","blobs_url":"https://api.github.com/repos/cta-observatory/ctapipe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cta-observatory/ctapipe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cta-observatory/ctapipe/git/refs{/sha}","trees_url":"https://api.github.com/repos/cta-observatory/ctapipe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cta-observatory/ctapipe/statuses/{sha}","languages_url":"https://api.github.com/repos/cta-observatory/ctapipe/languages","stargazers_url":"https://api.github.com/repos/cta-observatory/ctapipe/stargazers","contributors_url":"https://api.github.com/repos/cta-observatory/ctapipe/contributors","subscribers_url":"https://api.github.com/repos/cta-observatory/ctapipe/subscribers","subscription_url":"https://api.github.com/repos/cta-observatory/ctapipe/subscription","commits_url":"https://api.github.com/repos/cta-observatory/ctapipe/commits{/sha}","git_commits_url":"https://api.github.com/repos/cta-observatory/ctapipe/git/commits{/sha}","comments_url":"https://api.github.com/repos/cta-observatory/ctapipe/comments{/number}","issue_comment_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues/comments{/number}","contents_url":"https://api.github.com/repos/cta-observatory/ctapipe/contents/{+path}","compare_url":"https://api.github.com/repos/cta-observatory/ctapipe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cta-observatory/ctapipe/merges","archive_url":"https://api.github.com/repos/cta-observatory/ctapipe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cta-observatory/ctapipe/downloads","issues_url":"https://api.github.com/repos/cta-observatory/ctapipe/issues{/number}","pulls_url":"https://api.github.com/repos/cta-observatory/ctapipe/pulls{/number}","milestones_url":"https://api.github.com/repos/cta-observatory/ctapipe/milestones{/number}","notifications_url":"https://api.github.com/repos/cta-observatory/ctapipe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cta-observatory/ctapipe/labels{/name}","releases_url":"https://api.github.com/repos/cta-observatory/ctapipe/releases{/id}","deployments_url":"https://api.github.com/repos/cta-observatory/ctapipe/deployments","created_at":"2015-06-23T15:18:48Z","updated_at":"2016-08-31T21:54:13Z","pushed_at":"2016-10-19T09:34:18Z","git_url":"git://github.com/cta-observatory/ctapipe.git","ssh_url":"git@github.com:cta-observatory/ctapipe.git","clone_url":"https://github.com/cta-observatory/ctapipe.git","svn_url":"https://github.com/cta-observatory/ctapipe","homepage":"https://cta-observatory.github.io/ctapipe/","size":15794,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":52,"forks":51,"open_issues":52,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193"},"html":{"href":"https://github.com/cta-observatory/ctapipe/pull/193"},"issue":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/issues/193"},"comments":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/cta-observatory/ctapipe/statuses/e6bbbc4941b44e25b281e2d864466d3fc9db5cab"}}}}
{"actor":{"display_login":"wrijupan"}}