{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332/events","html_url":"https://github.com/kubernetes/kubernetes/pull/37332","id":191171145,"number":37332,"title":"kubernetes attempts to unmount a wrong vSphere volume and stops making any progress after that","user":{"login":"BaluDontu","id":22899615,"avatar_url":"https://avatars.githubusercontent.com/u/22899615?v=3","gravatar_id":"","url":"https://api.github.com/users/BaluDontu","html_url":"https://github.com/BaluDontu","followers_url":"https://api.github.com/users/BaluDontu/followers","following_url":"https://api.github.com/users/BaluDontu/following{/other_user}","gists_url":"https://api.github.com/users/BaluDontu/gists{/gist_id}","starred_url":"https://api.github.com/users/BaluDontu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaluDontu/subscriptions","organizations_url":"https://api.github.com/users/BaluDontu/orgs","repos_url":"https://api.github.com/users/BaluDontu/repos","events_url":"https://api.github.com/users/BaluDontu/events{/privacy}","received_events_url":"https://api.github.com/users/BaluDontu/received_events","type":"User","site_admin":false},"labels":[{"id":477397085,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20no","name":"cncf-cla: no","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-23T01:49:14Z","updated_at":"2016-11-23T01:49:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/37332","html_url":"https://github.com/kubernetes/kubernetes/pull/37332","diff_url":"https://github.com/kubernetes/kubernetes/pull/37332.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/37332.patch"},"body":"Kubernetes attempts to unmount a wrong vSphere volume in v1.4.5. \r\n\r\nThe following steps are made to reproduce the issue:\r\n1. kubectl create -f guestbook.yaml\r\nA deployment is created with a volume spec - \"hello-master\" and volumePath - \"[datastore1] kubevols/sample-volume\". At this point, the pod has the volume \"[datastore1]kubevols/sample-volume\" mounted on it.\r\n\r\n2. kubectl delete -f guestbook.yaml\r\nWhen the deployment is deleted, kubernetes attempts to unmount the volume with volumeName - hello-master. Since it cannot find the volume \"hello-master\" mounted on the node, it stalls and doesn't make any progress after it.\r\n\r\nBecause of this, any subsequent recreation of deployments fails to mount the volume on the node as  the node stalls.\r\n\r\nThis problem occurred after fixing for issue #33203 on kubernetes repo -  Fix volume states out of sync problem after kubelet restarts. There were changes to SYNC loop logic in this fix.\r\n\r\nThere are 2 fixes that needs to made on 1.4.5 branch\r\n1. The changes to constructVolumeSpec() in the vSphere plugin to get the volumePath instead of volumeName.\r\n2. The changes to getDeviceNameFromMount() to get the full volumePath - \"[datastore1]kubevols/sample-volume\" instead of the just base of the volumePath -\"sample-volume\". I just observed that this function is fixed as a part of #36840 on master branch.\r\n\r\nAfter these changes, the deployment creations and deletions worked perfectly fine. Also the recreation of the deployment worked fine. The volumes are mounted to the pods correctly."},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/262417623","html_url":"https://github.com/kubernetes/kubernetes/pull/37332#issuecomment-262417623","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/37332","id":262417623,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars.githubusercontent.com/u/20407524?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2016-11-23T01:49:16Z","updated_at":"2016-11-23T01:49:16Z","body":"Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).\n\n:memo: **Please follow instructions at <https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ> to sign the CLA.**\n\nOnce you've signed, please reply here (e.g. \"I signed it!\") and we'll verify.  Thanks.\n\n---\n\n- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your [email is set on your git commits](https://help.github.com/articles/setting-your-email-in-git/).\n- If you signed the CLA as a corporation, please sign in with your organization's credentials at <https://identity.linuxfoundation.org/projects/cncf> to be authorized.\n\n<!-- need_sender_cla -->\n\n<details>\nIf you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n\t"}}
{"actor":{"display_login":"k8s-ci-robot"}}