{"action":"created","comment":{"url":"https://api.github.com/repos/forge/furnace/pulls/comments/85613823","pull_request_review_id":6322908,"id":85613823,"diff_hunk":"@@ -163,14 +163,18 @@ private ModuleSpec findAddonModule(ModuleIdentifier id)\n                {\n                   Builder builder = ModuleSpec.build(id);\n \n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(SystemClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(XPathJDKClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(JAXBJDKClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(CORBAClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(SunJDKClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(NashornJDKClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(JavaFXClasspathSpec.ID));\n-                  builder.addDependency(DependencySpec.createModuleDependencySpec(AppleScriptClasspathSpec.ID));\n+                  for (ModuleSpecProvider moduleSpec : getModuleProviders())\n+                  {\n+                      builder.addDependency(DependencySpec.createModuleDependencySpec(moduleSpec.getId()));\n+                  }\n+                  //builder.addDependency(DependencySpec.createModuleDependencySpec(SystemClasspathSpec.ID));\n+                  //builder.addDependency(DependencySpec.createModuleDependencySpec(XPathJDKClasspathSpec.ID));","path":"container/src/main/java/org/jboss/forge/furnace/impl/modules/AddonModuleLoader.java","position":17,"original_position":17,"commit_id":"806d6f9c708c4ea409e1b4455a3b147bdb702574","original_commit_id":"806d6f9c708c4ea409e1b4455a3b147bdb702574","user":{"login":"jsight","id":1181549,"avatar_url":"https://avatars.githubusercontent.com/u/1181549?v=3","gravatar_id":"","url":"https://api.github.com/users/jsight","html_url":"https://github.com/jsight","followers_url":"https://api.github.com/users/jsight/followers","following_url":"https://api.github.com/users/jsight/following{/other_user}","gists_url":"https://api.github.com/users/jsight/gists{/gist_id}","starred_url":"https://api.github.com/users/jsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsight/subscriptions","organizations_url":"https://api.github.com/users/jsight/orgs","repos_url":"https://api.github.com/users/jsight/repos","events_url":"https://api.github.com/users/jsight/events{/privacy}","received_events_url":"https://api.github.com/users/jsight/received_events","type":"User","site_admin":false},"body":"Doh, of course. Will do.","created_at":"2016-10-28T21:31:42Z","updated_at":"2016-10-28T21:31:42Z","html_url":"https://github.com/forge/furnace/pull/39#discussion_r85613823","pull_request_url":"https://api.github.com/repos/forge/furnace/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/forge/furnace/pulls/comments/85613823"},"html":{"href":"https://github.com/forge/furnace/pull/39#discussion_r85613823"},"pull_request":{"href":"https://api.github.com/repos/forge/furnace/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/forge/furnace/pulls/39","id":91455130,"html_url":"https://github.com/forge/furnace/pull/39","diff_url":"https://github.com/forge/furnace/pull/39.diff","patch_url":"https://github.com/forge/furnace/pull/39.patch","issue_url":"https://api.github.com/repos/forge/furnace/issues/39","number":39,"state":"open","locked":false,"title":"FURNACE-126: Make the module spec dependencies get loaded dynamically","user":{"login":"jsight","id":1181549,"avatar_url":"https://avatars.githubusercontent.com/u/1181549?v=3","gravatar_id":"","url":"https://api.github.com/users/jsight","html_url":"https://github.com/jsight","followers_url":"https://api.github.com/users/jsight/followers","following_url":"https://api.github.com/users/jsight/following{/other_user}","gists_url":"https://api.github.com/users/jsight/gists{/gist_id}","starred_url":"https://api.github.com/users/jsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsight/subscriptions","organizations_url":"https://api.github.com/users/jsight/orgs","repos_url":"https://api.github.com/users/jsight/repos","events_url":"https://api.github.com/users/jsight/events{/privacy}","received_events_url":"https://api.github.com/users/jsight/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-10-28T21:26:25Z","updated_at":"2016-10-28T21:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b02f8ab4c070b7e86f52286d3b2957afb9eb398b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/forge/furnace/pulls/39/commits","review_comments_url":"https://api.github.com/repos/forge/furnace/pulls/39/comments","review_comment_url":"https://api.github.com/repos/forge/furnace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forge/furnace/issues/39/comments","statuses_url":"https://api.github.com/repos/forge/furnace/statuses/806d6f9c708c4ea409e1b4455a3b147bdb702574","head":{"label":"jsight:furnace-126","ref":"furnace-126","sha":"806d6f9c708c4ea409e1b4455a3b147bdb702574","user":{"login":"jsight","id":1181549,"avatar_url":"https://avatars.githubusercontent.com/u/1181549?v=3","gravatar_id":"","url":"https://api.github.com/users/jsight","html_url":"https://github.com/jsight","followers_url":"https://api.github.com/users/jsight/followers","following_url":"https://api.github.com/users/jsight/following{/other_user}","gists_url":"https://api.github.com/users/jsight/gists{/gist_id}","starred_url":"https://api.github.com/users/jsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsight/subscriptions","organizations_url":"https://api.github.com/users/jsight/orgs","repos_url":"https://api.github.com/users/jsight/repos","events_url":"https://api.github.com/users/jsight/events{/privacy}","received_events_url":"https://api.github.com/users/jsight/received_events","type":"User","site_admin":false},"repo":{"id":25316736,"name":"furnace","full_name":"jsight/furnace","owner":{"login":"jsight","id":1181549,"avatar_url":"https://avatars.githubusercontent.com/u/1181549?v=3","gravatar_id":"","url":"https://api.github.com/users/jsight","html_url":"https://github.com/jsight","followers_url":"https://api.github.com/users/jsight/followers","following_url":"https://api.github.com/users/jsight/following{/other_user}","gists_url":"https://api.github.com/users/jsight/gists{/gist_id}","starred_url":"https://api.github.com/users/jsight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsight/subscriptions","organizations_url":"https://api.github.com/users/jsight/orgs","repos_url":"https://api.github.com/users/jsight/repos","events_url":"https://api.github.com/users/jsight/events{/privacy}","received_events_url":"https://api.github.com/users/jsight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsight/furnace","description":"Lightweight Modular Service Container - Based on existing Maven and CDI Standard Technologies. ","fork":true,"url":"https://api.github.com/repos/jsight/furnace","forks_url":"https://api.github.com/repos/jsight/furnace/forks","keys_url":"https://api.github.com/repos/jsight/furnace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsight/furnace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsight/furnace/teams","hooks_url":"https://api.github.com/repos/jsight/furnace/hooks","issue_events_url":"https://api.github.com/repos/jsight/furnace/issues/events{/number}","events_url":"https://api.github.com/repos/jsight/furnace/events","assignees_url":"https://api.github.com/repos/jsight/furnace/assignees{/user}","branches_url":"https://api.github.com/repos/jsight/furnace/branches{/branch}","tags_url":"https://api.github.com/repos/jsight/furnace/tags","blobs_url":"https://api.github.com/repos/jsight/furnace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsight/furnace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsight/furnace/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsight/furnace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsight/furnace/statuses/{sha}","languages_url":"https://api.github.com/repos/jsight/furnace/languages","stargazers_url":"https://api.github.com/repos/jsight/furnace/stargazers","contributors_url":"https://api.github.com/repos/jsight/furnace/contributors","subscribers_url":"https://api.github.com/repos/jsight/furnace/subscribers","subscription_url":"https://api.github.com/repos/jsight/furnace/subscription","commits_url":"https://api.github.com/repos/jsight/furnace/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsight/furnace/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsight/furnace/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsight/furnace/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsight/furnace/contents/{+path}","compare_url":"https://api.github.com/repos/jsight/furnace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsight/furnace/merges","archive_url":"https://api.github.com/repos/jsight/furnace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsight/furnace/downloads","issues_url":"https://api.github.com/repos/jsight/furnace/issues{/number}","pulls_url":"https://api.github.com/repos/jsight/furnace/pulls{/number}","milestones_url":"https://api.github.com/repos/jsight/furnace/milestones{/number}","notifications_url":"https://api.github.com/repos/jsight/furnace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsight/furnace/labels{/name}","releases_url":"https://api.github.com/repos/jsight/furnace/releases{/id}","deployments_url":"https://api.github.com/repos/jsight/furnace/deployments","created_at":"2014-10-16T18:54:42Z","updated_at":"2014-09-29T07:57:38Z","pushed_at":"2016-10-28T21:26:05Z","git_url":"git://github.com/jsight/furnace.git","ssh_url":"git@github.com:jsight/furnace.git","clone_url":"https://github.com/jsight/furnace.git","svn_url":"https://github.com/jsight/furnace","homepage":null,"size":2781,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"forge:master","ref":"master","sha":"4a0a6ec49e2783b91054af3319de7706feaf9097","user":{"login":"forge","id":711249,"avatar_url":"https://avatars.githubusercontent.com/u/711249?v=3","gravatar_id":"","url":"https://api.github.com/users/forge","html_url":"https://github.com/forge","followers_url":"https://api.github.com/users/forge/followers","following_url":"https://api.github.com/users/forge/following{/other_user}","gists_url":"https://api.github.com/users/forge/gists{/gist_id}","starred_url":"https://api.github.com/users/forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forge/subscriptions","organizations_url":"https://api.github.com/users/forge/orgs","repos_url":"https://api.github.com/users/forge/repos","events_url":"https://api.github.com/users/forge/events{/privacy}","received_events_url":"https://api.github.com/users/forge/received_events","type":"Organization","site_admin":false},"repo":{"id":10085184,"name":"furnace","full_name":"forge/furnace","owner":{"login":"forge","id":711249,"avatar_url":"https://avatars.githubusercontent.com/u/711249?v=3","gravatar_id":"","url":"https://api.github.com/users/forge","html_url":"https://github.com/forge","followers_url":"https://api.github.com/users/forge/followers","following_url":"https://api.github.com/users/forge/following{/other_user}","gists_url":"https://api.github.com/users/forge/gists{/gist_id}","starred_url":"https://api.github.com/users/forge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forge/subscriptions","organizations_url":"https://api.github.com/users/forge/orgs","repos_url":"https://api.github.com/users/forge/repos","events_url":"https://api.github.com/users/forge/events{/privacy}","received_events_url":"https://api.github.com/users/forge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forge/furnace","description":"Lightweight Modular Service Container - Based on existing JBoss Modules, Maven, and CDI Standard Technologies. ","fork":false,"url":"https://api.github.com/repos/forge/furnace","forks_url":"https://api.github.com/repos/forge/furnace/forks","keys_url":"https://api.github.com/repos/forge/furnace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forge/furnace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forge/furnace/teams","hooks_url":"https://api.github.com/repos/forge/furnace/hooks","issue_events_url":"https://api.github.com/repos/forge/furnace/issues/events{/number}","events_url":"https://api.github.com/repos/forge/furnace/events","assignees_url":"https://api.github.com/repos/forge/furnace/assignees{/user}","branches_url":"https://api.github.com/repos/forge/furnace/branches{/branch}","tags_url":"https://api.github.com/repos/forge/furnace/tags","blobs_url":"https://api.github.com/repos/forge/furnace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forge/furnace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forge/furnace/git/refs{/sha}","trees_url":"https://api.github.com/repos/forge/furnace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forge/furnace/statuses/{sha}","languages_url":"https://api.github.com/repos/forge/furnace/languages","stargazers_url":"https://api.github.com/repos/forge/furnace/stargazers","contributors_url":"https://api.github.com/repos/forge/furnace/contributors","subscribers_url":"https://api.github.com/repos/forge/furnace/subscribers","subscription_url":"https://api.github.com/repos/forge/furnace/subscription","commits_url":"https://api.github.com/repos/forge/furnace/commits{/sha}","git_commits_url":"https://api.github.com/repos/forge/furnace/git/commits{/sha}","comments_url":"https://api.github.com/repos/forge/furnace/comments{/number}","issue_comment_url":"https://api.github.com/repos/forge/furnace/issues/comments{/number}","contents_url":"https://api.github.com/repos/forge/furnace/contents/{+path}","compare_url":"https://api.github.com/repos/forge/furnace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forge/furnace/merges","archive_url":"https://api.github.com/repos/forge/furnace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forge/furnace/downloads","issues_url":"https://api.github.com/repos/forge/furnace/issues{/number}","pulls_url":"https://api.github.com/repos/forge/furnace/pulls{/number}","milestones_url":"https://api.github.com/repos/forge/furnace/milestones{/number}","notifications_url":"https://api.github.com/repos/forge/furnace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forge/furnace/labels{/name}","releases_url":"https://api.github.com/repos/forge/furnace/releases{/id}","deployments_url":"https://api.github.com/repos/forge/furnace/deployments","created_at":"2013-05-15T18:26:15Z","updated_at":"2016-10-03T18:48:13Z","pushed_at":"2016-10-28T21:26:26Z","git_url":"git://github.com/forge/furnace.git","ssh_url":"git@github.com:forge/furnace.git","clone_url":"https://github.com/forge/furnace.git","svn_url":"https://github.com/forge/furnace","homepage":"http://forge.jboss.org","size":3022,"stargazers_count":21,"watchers_count":21,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":1,"forks":25,"open_issues":1,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/forge/furnace/pulls/39"},"html":{"href":"https://github.com/forge/furnace/pull/39"},"issue":{"href":"https://api.github.com/repos/forge/furnace/issues/39"},"comments":{"href":"https://api.github.com/repos/forge/furnace/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/forge/furnace/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/forge/furnace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forge/furnace/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/forge/furnace/statuses/806d6f9c708c4ea409e1b4455a3b147bdb702574"}}}}
{"actor":{"display_login":"jsight"}}