{"action":"created","comment":{"url":"https://api.github.com/repos/symengine/symengine/pulls/comments/72116541","id":72116541,"diff_hunk":"@@ -33,8 +33,12 @@ class Precedence : public BaseVisitor<Precedence>\n     template <typename Poly>\n     void bvisit_upoly(const Poly &x)\n     {\n-        if (x.get_dict().size() == 1) {\n-            auto it = x.get_dict().begin();\n+        auto begin = x.begin();\n+        auto it = x.begin();\n+        auto end = x.end();\n+\n+        if (end == ++begin) {","path":"symengine/printer.h","position":10,"original_position":10,"commit_id":"41df503ba5d4d3b078eb6430d0332b9af5c9ec33","original_commit_id":"41df503ba5d4d3b078eb6430d0332b9af5c9ec33","user":{"login":"srajangarg","id":8615180,"avatar_url":"https://avatars.githubusercontent.com/u/8615180?v=3","gravatar_id":"","url":"https://api.github.com/users/srajangarg","html_url":"https://github.com/srajangarg","followers_url":"https://api.github.com/users/srajangarg/followers","following_url":"https://api.github.com/users/srajangarg/following{/other_user}","gists_url":"https://api.github.com/users/srajangarg/gists{/gist_id}","starred_url":"https://api.github.com/users/srajangarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajangarg/subscriptions","organizations_url":"https://api.github.com/users/srajangarg/orgs","repos_url":"https://api.github.com/users/srajangarg/repos","events_url":"https://api.github.com/users/srajangarg/events{/privacy}","received_events_url":"https://api.github.com/users/srajangarg/received_events","type":"User","site_admin":false},"body":"The \"polynomial size\" is defined as `0` if it's a zero poly otherwise `degree+1`  (as used by flint)\r\nThis was the only way I can think of to make it work for all the upolys.","created_at":"2016-07-25T18:20:32Z","updated_at":"2016-07-25T18:20:32Z","html_url":"https://github.com/symengine/symengine/pull/1028#discussion_r72116541","pull_request_url":"https://api.github.com/repos/symengine/symengine/pulls/1028","_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments/72116541"},"html":{"href":"https://github.com/symengine/symengine/pull/1028#discussion_r72116541"},"pull_request":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1028"}}},"pull_request":{"url":"https://api.github.com/repos/symengine/symengine/pulls/1028","id":76631231,"html_url":"https://github.com/symengine/symengine/pull/1028","diff_url":"https://github.com/symengine/symengine/pull/1028.diff","patch_url":"https://github.com/symengine/symengine/pull/1028.patch","issue_url":"https://api.github.com/repos/symengine/symengine/issues/1028","number":1028,"state":"open","locked":false,"title":"[WIP] Uratpoly","user":{"login":"srajangarg","id":8615180,"avatar_url":"https://avatars.githubusercontent.com/u/8615180?v=3","gravatar_id":"","url":"https://api.github.com/users/srajangarg","html_url":"https://github.com/srajangarg","followers_url":"https://api.github.com/users/srajangarg/followers","following_url":"https://api.github.com/users/srajangarg/following{/other_user}","gists_url":"https://api.github.com/users/srajangarg/gists{/gist_id}","starred_url":"https://api.github.com/users/srajangarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajangarg/subscriptions","organizations_url":"https://api.github.com/users/srajangarg/orgs","repos_url":"https://api.github.com/users/srajangarg/repos","events_url":"https://api.github.com/users/srajangarg/events{/privacy}","received_events_url":"https://api.github.com/users/srajangarg/received_events","type":"User","site_admin":false},"body":"SymEngine rational polys added\r\nYet to add piranha and flint rat polys, and all tests\r\n\r\nAlso some functions like `is_zero`, `is_mul` etc. have been removed temporarily. I will add them for all classes later on.","created_at":"2016-07-07T17:06:20Z","updated_at":"2016-07-25T18:20:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c90b73944265082535efd9c9416e8764d73db400","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/symengine/symengine/pulls/1028/commits","review_comments_url":"https://api.github.com/repos/symengine/symengine/pulls/1028/comments","review_comment_url":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symengine/symengine/issues/1028/comments","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/41df503ba5d4d3b078eb6430d0332b9af5c9ec33","head":{"label":"srajangarg:uratpoly","ref":"uratpoly","sha":"41df503ba5d4d3b078eb6430d0332b9af5c9ec33","user":{"login":"srajangarg","id":8615180,"avatar_url":"https://avatars.githubusercontent.com/u/8615180?v=3","gravatar_id":"","url":"https://api.github.com/users/srajangarg","html_url":"https://github.com/srajangarg","followers_url":"https://api.github.com/users/srajangarg/followers","following_url":"https://api.github.com/users/srajangarg/following{/other_user}","gists_url":"https://api.github.com/users/srajangarg/gists{/gist_id}","starred_url":"https://api.github.com/users/srajangarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajangarg/subscriptions","organizations_url":"https://api.github.com/users/srajangarg/orgs","repos_url":"https://api.github.com/users/srajangarg/repos","events_url":"https://api.github.com/users/srajangarg/events{/privacy}","received_events_url":"https://api.github.com/users/srajangarg/received_events","type":"User","site_admin":false},"repo":{"id":48808814,"name":"symengine","full_name":"srajangarg/symengine","owner":{"login":"srajangarg","id":8615180,"avatar_url":"https://avatars.githubusercontent.com/u/8615180?v=3","gravatar_id":"","url":"https://api.github.com/users/srajangarg","html_url":"https://github.com/srajangarg","followers_url":"https://api.github.com/users/srajangarg/followers","following_url":"https://api.github.com/users/srajangarg/following{/other_user}","gists_url":"https://api.github.com/users/srajangarg/gists{/gist_id}","starred_url":"https://api.github.com/users/srajangarg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srajangarg/subscriptions","organizations_url":"https://api.github.com/users/srajangarg/orgs","repos_url":"https://api.github.com/users/srajangarg/repos","events_url":"https://api.github.com/users/srajangarg/events{/privacy}","received_events_url":"https://api.github.com/users/srajangarg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srajangarg/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":true,"url":"https://api.github.com/repos/srajangarg/symengine","forks_url":"https://api.github.com/repos/srajangarg/symengine/forks","keys_url":"https://api.github.com/repos/srajangarg/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srajangarg/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srajangarg/symengine/teams","hooks_url":"https://api.github.com/repos/srajangarg/symengine/hooks","issue_events_url":"https://api.github.com/repos/srajangarg/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/srajangarg/symengine/events","assignees_url":"https://api.github.com/repos/srajangarg/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/srajangarg/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/srajangarg/symengine/tags","blobs_url":"https://api.github.com/repos/srajangarg/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srajangarg/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srajangarg/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/srajangarg/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srajangarg/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/srajangarg/symengine/languages","stargazers_url":"https://api.github.com/repos/srajangarg/symengine/stargazers","contributors_url":"https://api.github.com/repos/srajangarg/symengine/contributors","subscribers_url":"https://api.github.com/repos/srajangarg/symengine/subscribers","subscription_url":"https://api.github.com/repos/srajangarg/symengine/subscription","commits_url":"https://api.github.com/repos/srajangarg/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/srajangarg/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/srajangarg/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/srajangarg/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/srajangarg/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/srajangarg/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srajangarg/symengine/merges","archive_url":"https://api.github.com/repos/srajangarg/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srajangarg/symengine/downloads","issues_url":"https://api.github.com/repos/srajangarg/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/srajangarg/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/srajangarg/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/srajangarg/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srajangarg/symengine/labels{/name}","releases_url":"https://api.github.com/repos/srajangarg/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/srajangarg/symengine/deployments","created_at":"2015-12-30T16:15:29Z","updated_at":"2016-01-20T17:21:48Z","pushed_at":"2016-07-25T18:04:09Z","git_url":"git://github.com/srajangarg/symengine.git","ssh_url":"git@github.com:srajangarg/symengine.git","clone_url":"https://github.com/srajangarg/symengine.git","svn_url":"https://github.com/srajangarg/symengine","homepage":"http://sympy.org","size":6115,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symengine:master","ref":"master","sha":"253bf6b393cdb6207551dd1525ec6ba0cc4ab5eb","user":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"repo":{"id":42376,"name":"symengine","full_name":"symengine/symengine","owner":{"login":"symengine","id":11509221,"avatar_url":"https://avatars.githubusercontent.com/u/11509221?v=3","gravatar_id":"","url":"https://api.github.com/users/symengine","html_url":"https://github.com/symengine","followers_url":"https://api.github.com/users/symengine/followers","following_url":"https://api.github.com/users/symengine/following{/other_user}","gists_url":"https://api.github.com/users/symengine/gists{/gist_id}","starred_url":"https://api.github.com/users/symengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symengine/subscriptions","organizations_url":"https://api.github.com/users/symengine/orgs","repos_url":"https://api.github.com/users/symengine/repos","events_url":"https://api.github.com/users/symengine/events{/privacy}","received_events_url":"https://api.github.com/users/symengine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symengine/symengine","description":"SymEngine is a fast symbolic manipulation library, written in C++","fork":false,"url":"https://api.github.com/repos/symengine/symengine","forks_url":"https://api.github.com/repos/symengine/symengine/forks","keys_url":"https://api.github.com/repos/symengine/symengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symengine/symengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symengine/symengine/teams","hooks_url":"https://api.github.com/repos/symengine/symengine/hooks","issue_events_url":"https://api.github.com/repos/symengine/symengine/issues/events{/number}","events_url":"https://api.github.com/repos/symengine/symengine/events","assignees_url":"https://api.github.com/repos/symengine/symengine/assignees{/user}","branches_url":"https://api.github.com/repos/symengine/symengine/branches{/branch}","tags_url":"https://api.github.com/repos/symengine/symengine/tags","blobs_url":"https://api.github.com/repos/symengine/symengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symengine/symengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symengine/symengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/symengine/symengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symengine/symengine/statuses/{sha}","languages_url":"https://api.github.com/repos/symengine/symengine/languages","stargazers_url":"https://api.github.com/repos/symengine/symengine/stargazers","contributors_url":"https://api.github.com/repos/symengine/symengine/contributors","subscribers_url":"https://api.github.com/repos/symengine/symengine/subscribers","subscription_url":"https://api.github.com/repos/symengine/symengine/subscription","commits_url":"https://api.github.com/repos/symengine/symengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/symengine/symengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/symengine/symengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/symengine/symengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/symengine/symengine/contents/{+path}","compare_url":"https://api.github.com/repos/symengine/symengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symengine/symengine/merges","archive_url":"https://api.github.com/repos/symengine/symengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symengine/symengine/downloads","issues_url":"https://api.github.com/repos/symengine/symengine/issues{/number}","pulls_url":"https://api.github.com/repos/symengine/symengine/pulls{/number}","milestones_url":"https://api.github.com/repos/symengine/symengine/milestones{/number}","notifications_url":"https://api.github.com/repos/symengine/symengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symengine/symengine/labels{/name}","releases_url":"https://api.github.com/repos/symengine/symengine/releases{/id}","deployments_url":"https://api.github.com/repos/symengine/symengine/deployments","created_at":"2008-08-13T18:40:14Z","updated_at":"2016-07-22T20:30:58Z","pushed_at":"2016-07-25T18:17:04Z","git_url":"git://github.com/symengine/symengine.git","ssh_url":"git@github.com:symengine/symengine.git","clone_url":"https://github.com/symengine/symengine.git","svn_url":"https://github.com/symengine/symengine","homepage":"http://sympy.org","size":37628,"stargazers_count":161,"watchers_count":161,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"open_issues_count":112,"forks":112,"open_issues":112,"watchers":161,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1028"},"html":{"href":"https://github.com/symengine/symengine/pull/1028"},"issue":{"href":"https://api.github.com/repos/symengine/symengine/issues/1028"},"comments":{"href":"https://api.github.com/repos/symengine/symengine/issues/1028/comments"},"review_comments":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1028/comments"},"review_comment":{"href":"https://api.github.com/repos/symengine/symengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symengine/symengine/pulls/1028/commits"},"statuses":{"href":"https://api.github.com/repos/symengine/symengine/statuses/41df503ba5d4d3b078eb6430d0332b9af5c9ec33"}}}}
{"actor":{"display_login":"srajangarg"}}