{"action":"created","issue":{"url":"https://api.github.com/repos/openvstorage/alba/issues/326","repository_url":"https://api.github.com/repos/openvstorage/alba","labels_url":"https://api.github.com/repos/openvstorage/alba/issues/326/labels{/name}","comments_url":"https://api.github.com/repos/openvstorage/alba/issues/326/comments","events_url":"https://api.github.com/repos/openvstorage/alba/issues/326/events","html_url":"https://github.com/openvstorage/alba/issues/326","id":170875162,"number":326,"title":"RORA fetcher logging improvements","user":{"login":"redlicha","id":405850,"avatar_url":"https://avatars.githubusercontent.com/u/405850?v=3","gravatar_id":"","url":"https://api.github.com/users/redlicha","html_url":"https://github.com/redlicha","followers_url":"https://api.github.com/users/redlicha/followers","following_url":"https://api.github.com/users/redlicha/following{/other_user}","gists_url":"https://api.github.com/users/redlicha/gists{/gist_id}","starred_url":"https://api.github.com/users/redlicha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redlicha/subscriptions","organizations_url":"https://api.github.com/users/redlicha/orgs","repos_url":"https://api.github.com/users/redlicha/repos","events_url":"https://api.github.com/users/redlicha/events{/privacy}","received_events_url":"https://api.github.com/users/redlicha/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openvstorage/alba/labels/type_bug","name":"type_bug","color":"fef2c0"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-12T13:48:14Z","updated_at":"2016-08-12T14:15:53Z","closed_at":null,"body":"During tests we've seen the following in the volumedriver log:\r\n```\r\n2016-08-12 15:00:12 602232 +0200 - cmp02 - 26398/0x00007f48d9ffb700 - volumedriverfs/AlbaProxyClient - 000000000000058f -  info - logMessage: RDMAProxy_client(172.19.12.141, 26204)\r\n2016-08-12 15:00:12 602526 +0200 - cmp02 - 26398/0x00007f48d9ffb700 - volumedriverfs/AlbaProxyClient - 0000000000000590 -  info - logMessage: connecting\r\n2016-08-12 15:00:12 605926 +0200 - cmp02 - 26398/0x00007f48d9ffb700 - volumedriverfs/AlbaProxyClient - 0000000000000591 -  info - logMessage: RoraProxy_client(...)\r\n2016-08-12 15:00:12 624812 +0200 - cmp02 - 26398/0x00007f48d97fa700 - volumedriverfs/(UnspecifiedComponent) - 0000000000000592 -  error - \r\n Alert !!imsg has error in retval\r\n\r\n2016-08-12 15:00:12 624988 +0200 - cmp02 - 26398/0x00007f48d9ffb700 - volumedriverfs/(UnspecifiedComponent) - 0000000000000593 -  error - giocbp->request_->_failed is true. Error is -5\r\n2016-08-12 15:00:12 625080 +0200 - cmp02 - 26398/0x00007f48d9ffb700 - volumedriverfs/AlbaProxyClient - 0000000000000594 -  info - logMessage: retcode:-5\r\n2016-08-12 15:00:12 626663 +0200 - cmp02 - 26398/0x00007f48d9ffb700 - volumedriverfs/AlbaProxyClient - 0000000000000595 -  info - logMessage: ~RDMAProxy_client\r\n```\r\n\r\nThe \"retcode:-5\" message comes from the RORA fetcher and should be at `error` level and should if possible also provide information about the target (ASD) of the failed request."},"comment":{"url":"https://api.github.com/repos/openvstorage/alba/issues/comments/239457942","html_url":"https://github.com/openvstorage/alba/issues/326#issuecomment-239457942","issue_url":"https://api.github.com/repos/openvstorage/alba/issues/326","id":239457942,"user":{"login":"redlicha","id":405850,"avatar_url":"https://avatars.githubusercontent.com/u/405850?v=3","gravatar_id":"","url":"https://api.github.com/users/redlicha","html_url":"https://github.com/redlicha","followers_url":"https://api.github.com/users/redlicha/followers","following_url":"https://api.github.com/users/redlicha/following{/other_user}","gists_url":"https://api.github.com/users/redlicha/gists{/gist_id}","starred_url":"https://api.github.com/users/redlicha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redlicha/subscriptions","organizations_url":"https://api.github.com/users/redlicha/orgs","repos_url":"https://api.github.com/users/redlicha/repos","events_url":"https://api.github.com/users/redlicha/events{/privacy}","received_events_url":"https://api.github.com/users/redlicha/received_events","type":"User","site_admin":false},"created_at":"2016-08-12T14:15:53Z","updated_at":"2016-08-12T14:15:53Z","body":"```\r\nint OsdAccess::_read_osd_slices(osd_t osd, std::vector<asd_slice> &slices) {\r\n  // ...\r\n  int ret = aio_readv(ctx, key_vec, iocb_vec);\r\n  if (ret == 0) {\r\n    ret = aio_suspendv(ctx, iocb_vec, nullptr /* timeout */);\r\n  }\r\n  for (auto &elem : iocb_vec) {\r\n    auto retcode = aio_return(ctx, elem);\r\n    if (ret != 0) {\r\n      ALBA_LOG(INFO, \"retcode:\" << retcode);\r\n    }\r\n    aio_finish(ctx, elem);\r\n  }\r\n```\r\nThe message should be emitted on `retcode != 0`"}}
{"actor":{"display_login":"redlicha"}}