{"action":"created","issue":{"url":"https://api.github.com/repos/Mudlet/Mudlet/issues/314","repository_url":"https://api.github.com/repos/Mudlet/Mudlet","labels_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/314/labels{/name}","comments_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/314/comments","events_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/314/events","html_url":"https://github.com/Mudlet/Mudlet/pull/314","id":163492397,"number":314,"title":"(release_30)bugFix: correctly identify no area/room user data in searchXXXXUserDa…","user":{"login":"SlySven","id":6163092,"avatar_url":"https://avatars.githubusercontent.com/u/6163092?v=3","gravatar_id":"","url":"https://api.github.com/users/SlySven","html_url":"https://github.com/SlySven","followers_url":"https://api.github.com/users/SlySven/followers","following_url":"https://api.github.com/users/SlySven/following{/other_user}","gists_url":"https://api.github.com/users/SlySven/gists{/gist_id}","starred_url":"https://api.github.com/users/SlySven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SlySven/subscriptions","organizations_url":"https://api.github.com/users/SlySven/orgs","repos_url":"https://api.github.com/users/SlySven/repos","events_url":"https://api.github.com/users/SlySven/events{/privacy}","received_events_url":"https://api.github.com/users/SlySven/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-07-02T00:12:21Z","updated_at":"2016-07-02T00:13:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Mudlet/Mudlet/pulls/314","html_url":"https://github.com/Mudlet/Mudlet/pull/314","diff_url":"https://github.com/Mudlet/Mudlet/pull/314.diff","patch_url":"https://github.com/Mudlet/Mudlet/pull/314.patch"},"body":"…ta(...)\r\n\r\nThere was a bug in my previous code in both:\r\n* `TLuaInterpreter::searchRoomUserData(...)`\r\n* `TLuaInterpreter::searchRoomUserData(...)`\r\n  when searching for given key and value when value is an empty string\r\n  in that all rooms or areas WITHOUT the given key were being misidentified\r\n  as being a room or area WITH the matching key and a value that was empty;\r\n  this would return all those rooms if a search for an empty value `\"\"` was\r\n  being done.  This was cause by the `QString::compare(...)` method returning\r\n  zero when one of the things being compared is a NULL (no value assigned)\r\n  QString and the other an EMPTY QString (assigned \"\") - I have raised a\r\n  (documentation) bug report at Qt on this:\r\n  https://bugreports.qt.io/browse/QTBUG-54505\r\n  though in other places they do point out that null and empty QStrings are\r\n  treated the same (except for the `QString::isNull()` method) but it is not\r\n  explicitly documented for the `QString::compare()` method!\r\n\r\nNote this may or may not be the possible bug reported in:\r\nhttp://forums.mudlet.org/viewtopic.php?f=13&t=4856\r\n\r\nSigned-off-by: Stephen Lyons <slysven@virginmedia.com>"},"comment":{"url":"https://api.github.com/repos/Mudlet/Mudlet/issues/comments/230071757","html_url":"https://github.com/Mudlet/Mudlet/pull/314#issuecomment-230071757","issue_url":"https://api.github.com/repos/Mudlet/Mudlet/issues/314","id":230071757,"user":{"login":"vadi2","id":110988,"avatar_url":"https://avatars.githubusercontent.com/u/110988?v=3","gravatar_id":"","url":"https://api.github.com/users/vadi2","html_url":"https://github.com/vadi2","followers_url":"https://api.github.com/users/vadi2/followers","following_url":"https://api.github.com/users/vadi2/following{/other_user}","gists_url":"https://api.github.com/users/vadi2/gists{/gist_id}","starred_url":"https://api.github.com/users/vadi2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadi2/subscriptions","organizations_url":"https://api.github.com/users/vadi2/orgs","repos_url":"https://api.github.com/users/vadi2/repos","events_url":"https://api.github.com/users/vadi2/events{/privacy}","received_events_url":"https://api.github.com/users/vadi2/received_events","type":"User","site_admin":false},"created_at":"2016-07-02T00:13:34Z","updated_at":"2016-07-02T00:13:34Z","body":"+1\n\nOn Sat, Jul 2, 2016 at 10:12 AM Stephen Lyons <notifications@github.com>\nwrote:\n\n> …ta(...)\n>\n> There was a bug in my previous code in both:\n>\n>    - TLuaInterpreter::searchRoomUserData(...)\n>    - TLuaInterpreter::searchRoomUserData(...) when searching for given\n>    key and value when value is an empty string in that all rooms or areas\n>    WITHOUT the given key were being misidentified as being a room or area WITH\n>    the matching key and a value that was empty; this would return all those\n>    rooms if a search for an empty value \"\" was being done. This was cause\n>    by the QString::compare(...) method returning zero when one of the\n>    things being compared is a NULL (no value assigned) QString and the other\n>    an EMPTY QString (assigned \"\") - I have raised a (documentation) bug report\n>    at Qt on this: https://bugreports.qt.io/browse/QTBUG-54505 though in\n>    other places they do point out that null and empty QStrings are treated the\n>    same (except for the QString::isNull() method) but it is not\n>    explicitly documented for the QString::compare() method!\n>\n> Note this may or may not be the possible bug reported in:\n> http://forums.mudlet.org/viewtopic.php?f=13&t=4856\n>\n> Signed-off-by: Stephen Lyons slysven@virginmedia.com\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/Mudlet/Mudlet/pull/314\n> Commit Summary\n>\n>    - BugFix: correctly identify no area/room user data in\n>    searchXXXXUserData(...)\n>\n> File Changes\n>\n>    - *M* src/TLuaInterpreter.cpp\n>    <https://github.com/Mudlet/Mudlet/pull/314/files#diff-0> (28)\n>\n> Patch Links:\n>\n>    - https://github.com/Mudlet/Mudlet/pull/314.patch\n>    - https://github.com/Mudlet/Mudlet/pull/314.diff\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/Mudlet/Mudlet/pull/314>, or mute the thread\n> <https://github.com/notifications/unsubscribe/AAGxjObMS9e8wya6AgqMjXoHXMvMMjiXks5qRazmgaJpZM4JDjtu>\n> .\n>\n"}}
{"actor":{"display_login":"vadi2"}}