{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/72286564","id":72286564,"diff_hunk":"@@ -43,7 +41,7 @@ function getInertElement() {\n \n function tagSet(tags: string): {[k: string]: boolean} {\n   let res: {[k: string]: boolean} = {};\n-  for (let t of tags.split(',')) res[t.toLowerCase()] = true;","path":"modules/@angular/platform-browser/src/security/html_sanitizer.ts","position":13,"original_position":13,"commit_id":"1bc9258cd8b7633a745e10a368e618281be0ad76","original_commit_id":"1bc9258cd8b7633a745e10a368e618281be0ad76","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"Yes, `security_integration_spec.ts` and `html_sanitizer_spec.ts` both would be affected. Nothing changed there, because this code was never doing anything - all the tags passed in in the source are already lower case.","created_at":"2016-07-26T16:32:05Z","updated_at":"2016-07-26T16:32:05Z","html_url":"https://github.com/angular/angular/pull/10272#discussion_r72286564","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/10272","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/72286564"},"html":{"href":"https://github.com/angular/angular/pull/10272#discussion_r72286564"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/10272"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/10272","id":78720466,"html_url":"https://github.com/angular/angular/pull/10272","diff_url":"https://github.com/angular/angular/pull/10272.diff","patch_url":"https://github.com/angular/angular/pull/10272.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/10272","number":10272,"state":"open","locked":false,"title":"feat(security): only warn when actually sanitizing HTML.","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"Previously, Angular would warn users when simply re-encoding text\r\noutside of the ASCII range. While harmless, the log spam was annoying.\r\n\r\nWith this change, Angular specifically tracks whether anything was\r\nstripped during sanitization, and only reports a warning if so.\r\n\r\nFixes #10206.","created_at":"2016-07-25T17:30:49Z","updated_at":"2016-07-26T16:32:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b03fd6587a77448205c61082ced85d17aecec5c6","assignee":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"assignees":[{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/10272/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/10272/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/10272/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/1bc9258cd8b7633a745e10a368e618281be0ad76","head":{"label":"mprobst:no-warn-sanitize","ref":"no-warn-sanitize","sha":"1bc9258cd8b7633a745e10a368e618281be0ad76","user":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"repo":{"id":31006722,"name":"angular","full_name":"mprobst/angular","owner":{"login":"mprobst","id":7208,"avatar_url":"https://avatars.githubusercontent.com/u/7208?v=3","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mprobst/angular","description":"","fork":true,"url":"https://api.github.com/repos/mprobst/angular","forks_url":"https://api.github.com/repos/mprobst/angular/forks","keys_url":"https://api.github.com/repos/mprobst/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mprobst/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mprobst/angular/teams","hooks_url":"https://api.github.com/repos/mprobst/angular/hooks","issue_events_url":"https://api.github.com/repos/mprobst/angular/issues/events{/number}","events_url":"https://api.github.com/repos/mprobst/angular/events","assignees_url":"https://api.github.com/repos/mprobst/angular/assignees{/user}","branches_url":"https://api.github.com/repos/mprobst/angular/branches{/branch}","tags_url":"https://api.github.com/repos/mprobst/angular/tags","blobs_url":"https://api.github.com/repos/mprobst/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mprobst/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mprobst/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/mprobst/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mprobst/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/mprobst/angular/languages","stargazers_url":"https://api.github.com/repos/mprobst/angular/stargazers","contributors_url":"https://api.github.com/repos/mprobst/angular/contributors","subscribers_url":"https://api.github.com/repos/mprobst/angular/subscribers","subscription_url":"https://api.github.com/repos/mprobst/angular/subscription","commits_url":"https://api.github.com/repos/mprobst/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/mprobst/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/mprobst/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/mprobst/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/mprobst/angular/contents/{+path}","compare_url":"https://api.github.com/repos/mprobst/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mprobst/angular/merges","archive_url":"https://api.github.com/repos/mprobst/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mprobst/angular/downloads","issues_url":"https://api.github.com/repos/mprobst/angular/issues{/number}","pulls_url":"https://api.github.com/repos/mprobst/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/mprobst/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/mprobst/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mprobst/angular/labels{/name}","releases_url":"https://api.github.com/repos/mprobst/angular/releases{/id}","deployments_url":"https://api.github.com/repos/mprobst/angular/deployments","created_at":"2015-02-19T08:23:36Z","updated_at":"2016-04-28T18:26:33Z","pushed_at":"2016-07-25T17:34:06Z","git_url":"git://github.com/mprobst/angular.git","ssh_url":"git@github.com:mprobst/angular.git","clone_url":"https://github.com/mprobst/angular.git","svn_url":"https://github.com/mprobst/angular","homepage":null,"size":26161,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"2b63330a361a9832a73f59c2104758990dea889c","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2016-07-26T16:29:37Z","pushed_at":"2016-07-26T14:52:48Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":641823,"stargazers_count":14243,"watchers_count":14243,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3664,"mirror_url":null,"open_issues_count":1257,"forks":3664,"open_issues":1257,"watchers":14243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/10272"},"html":{"href":"https://github.com/angular/angular/pull/10272"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/10272"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/10272/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/10272/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/10272/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/1bc9258cd8b7633a745e10a368e618281be0ad76"}}}}
{"actor":{"display_login":"mprobst"}}