{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/492","repository_url":"https://api.github.com/repos/junit-team/junit5","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/492/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/492/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/492/events","html_url":"https://github.com/junit-team/junit5/issues/492","id":174957913,"number":492,"title":"[SUREFIRE] Questionable asserts in TestPlanScannerFilterTests","user":{"login":"britter","id":1327662,"avatar_url":"https://avatars.githubusercontent.com/u/1327662?v=3","gravatar_id":"","url":"https://api.github.com/users/britter","html_url":"https://github.com/britter","followers_url":"https://api.github.com/users/britter/followers","following_url":"https://api.github.com/users/britter/following{/other_user}","gists_url":"https://api.github.com/users/britter/gists{/gist_id}","starred_url":"https://api.github.com/users/britter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britter/subscriptions","organizations_url":"https://api.github.com/users/britter/orgs","repos_url":"https://api.github.com/users/britter/repos","events_url":"https://api.github.com/users/britter/events{/privacy}","received_events_url":"https://api.github.com/users/britter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-09-04T16:47:40Z","updated_at":"2016-09-04T17:36:35Z","closed_at":null,"body":"The following assert in `TestPlanScannerFilterTests ` does not seem to make sense.\r\n\r\n```java\r\n\t@Test\r\n\tvoid emptyClassAccepted() {\r\n\t\tassertTrue(newFilter().accept(EmptyClass.class), \"accepts empty class because it is a container\");\r\n\t}\r\n```\r\n\r\nIn this case, when you debug into `TestPlan.countTestIdentifiers`, it will return true because the test plan contains the two root identifiers for the Jupiter and the Vintage Engine. Since `EmptyClass` is empty, it should not be accepted by the filter."},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/244616707","html_url":"https://github.com/junit-team/junit5/issues/492#issuecomment-244616707","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/492","id":244616707,"user":{"login":"britter","id":1327662,"avatar_url":"https://avatars.githubusercontent.com/u/1327662?v=3","gravatar_id":"","url":"https://api.github.com/users/britter","html_url":"https://github.com/britter","followers_url":"https://api.github.com/users/britter/followers","following_url":"https://api.github.com/users/britter/following{/other_user}","gists_url":"https://api.github.com/users/britter/gists{/gist_id}","starred_url":"https://api.github.com/users/britter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britter/subscriptions","organizations_url":"https://api.github.com/users/britter/orgs","repos_url":"https://api.github.com/users/britter/repos","events_url":"https://api.github.com/users/britter/events{/privacy}","received_events_url":"https://api.github.com/users/britter/received_events","type":"User","site_admin":false},"created_at":"2016-09-04T17:36:35Z","updated_at":"2016-09-04T17:36:35Z","body":"Actually the `TestPlanScannerFilter` will accept any class as long as the platform discovers any engines."}}
{"actor":{"display_login":"britter"}}