{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/teles/frontpress/pulls/10","id":75051507,"html_url":"https://github.com/teles/frontpress/pull/10","diff_url":"https://github.com/teles/frontpress/pull/10.diff","patch_url":"https://github.com/teles/frontpress/pull/10.patch","issue_url":"https://api.github.com/repos/teles/frontpress/issues/10","number":10,"state":"closed","locked":false,"title":"Sugestão de padronização e refatoração","user":{"login":"alisonmonteiro","id":3016692,"avatar_url":"https://avatars.githubusercontent.com/u/3016692?v=3","gravatar_id":"","url":"https://api.github.com/users/alisonmonteiro","html_url":"https://github.com/alisonmonteiro","followers_url":"https://api.github.com/users/alisonmonteiro/followers","following_url":"https://api.github.com/users/alisonmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/alisonmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/alisonmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisonmonteiro/subscriptions","organizations_url":"https://api.github.com/users/alisonmonteiro/orgs","repos_url":"https://api.github.com/users/alisonmonteiro/repos","events_url":"https://api.github.com/users/alisonmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/alisonmonteiro/received_events","type":"User","site_admin":false},"body":"Não há nada de muito especial com este PR. ⚠️ \r\n\r\nA única coisa que altera um pouco a \"lógica\" do código, é uma pequena alteração que fiz [aqui](https://github.com/alisonmonteiro/frontpress/blob/padrao/src/js/components/ajax/models/ajax.model.js#L7-L29) para remover a repetição de código que ocorria, no caso, com este arquivo.\r\n\r\nNa verdade, @teles, a ideia é tentar sugerir um padrão de código para o projeto (que também pretendo contribuir), e tornar ele mais simples e previsível.\r\n\r\nPor exemplo, em alguns arquivos, percebi que vários trechos de códigos bem parecidos eram utilizados de formas diferentes, o que, com o crescimento do projeto, poderia ser algo que dificultasse a leitura/compreensão do código.\r\n\r\nUm recurso que pode ajudar também, é o [editorconfig](http://editorconfig.org/), que ajudar a evitar problemas de incompatibilidade com espaços vs tabs, por exemplo.\r\n\r\nNo mais, achei o repositório muito interessante.\r\n\r\nValeu, abraço! 😄 ","created_at":"2016-06-24T01:13:36Z","updated_at":"2016-06-25T12:45:15Z","closed_at":"2016-06-25T12:45:15Z","merged_at":"2016-06-25T12:45:15Z","merge_commit_sha":"fa105a8409ff72344804c6a81847353d5ca35dac","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/teles/frontpress/pulls/10/commits","review_comments_url":"https://api.github.com/repos/teles/frontpress/pulls/10/comments","review_comment_url":"https://api.github.com/repos/teles/frontpress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/teles/frontpress/issues/10/comments","statuses_url":"https://api.github.com/repos/teles/frontpress/statuses/b8d73f2b20a4ffb2dcca608765a588436af0b8f3","head":{"label":"alisonmonteiro:padrao","ref":"padrao","sha":"b8d73f2b20a4ffb2dcca608765a588436af0b8f3","user":{"login":"alisonmonteiro","id":3016692,"avatar_url":"https://avatars.githubusercontent.com/u/3016692?v=3","gravatar_id":"","url":"https://api.github.com/users/alisonmonteiro","html_url":"https://github.com/alisonmonteiro","followers_url":"https://api.github.com/users/alisonmonteiro/followers","following_url":"https://api.github.com/users/alisonmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/alisonmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/alisonmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisonmonteiro/subscriptions","organizations_url":"https://api.github.com/users/alisonmonteiro/orgs","repos_url":"https://api.github.com/users/alisonmonteiro/repos","events_url":"https://api.github.com/users/alisonmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/alisonmonteiro/received_events","type":"User","site_admin":false},"repo":{"id":61846411,"name":"frontpress","full_name":"alisonmonteiro/frontpress","owner":{"login":"alisonmonteiro","id":3016692,"avatar_url":"https://avatars.githubusercontent.com/u/3016692?v=3","gravatar_id":"","url":"https://api.github.com/users/alisonmonteiro","html_url":"https://github.com/alisonmonteiro","followers_url":"https://api.github.com/users/alisonmonteiro/followers","following_url":"https://api.github.com/users/alisonmonteiro/following{/other_user}","gists_url":"https://api.github.com/users/alisonmonteiro/gists{/gist_id}","starred_url":"https://api.github.com/users/alisonmonteiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alisonmonteiro/subscriptions","organizations_url":"https://api.github.com/users/alisonmonteiro/orgs","repos_url":"https://api.github.com/users/alisonmonteiro/repos","events_url":"https://api.github.com/users/alisonmonteiro/events{/privacy}","received_events_url":"https://api.github.com/users/alisonmonteiro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alisonmonteiro/frontpress","description":":zap: Full front-end AngularJS template for WordPress API.","fork":true,"url":"https://api.github.com/repos/alisonmonteiro/frontpress","forks_url":"https://api.github.com/repos/alisonmonteiro/frontpress/forks","keys_url":"https://api.github.com/repos/alisonmonteiro/frontpress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alisonmonteiro/frontpress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alisonmonteiro/frontpress/teams","hooks_url":"https://api.github.com/repos/alisonmonteiro/frontpress/hooks","issue_events_url":"https://api.github.com/repos/alisonmonteiro/frontpress/issues/events{/number}","events_url":"https://api.github.com/repos/alisonmonteiro/frontpress/events","assignees_url":"https://api.github.com/repos/alisonmonteiro/frontpress/assignees{/user}","branches_url":"https://api.github.com/repos/alisonmonteiro/frontpress/branches{/branch}","tags_url":"https://api.github.com/repos/alisonmonteiro/frontpress/tags","blobs_url":"https://api.github.com/repos/alisonmonteiro/frontpress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alisonmonteiro/frontpress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alisonmonteiro/frontpress/git/refs{/sha}","trees_url":"https://api.github.com/repos/alisonmonteiro/frontpress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alisonmonteiro/frontpress/statuses/{sha}","languages_url":"https://api.github.com/repos/alisonmonteiro/frontpress/languages","stargazers_url":"https://api.github.com/repos/alisonmonteiro/frontpress/stargazers","contributors_url":"https://api.github.com/repos/alisonmonteiro/frontpress/contributors","subscribers_url":"https://api.github.com/repos/alisonmonteiro/frontpress/subscribers","subscription_url":"https://api.github.com/repos/alisonmonteiro/frontpress/subscription","commits_url":"https://api.github.com/repos/alisonmonteiro/frontpress/commits{/sha}","git_commits_url":"https://api.github.com/repos/alisonmonteiro/frontpress/git/commits{/sha}","comments_url":"https://api.github.com/repos/alisonmonteiro/frontpress/comments{/number}","issue_comment_url":"https://api.github.com/repos/alisonmonteiro/frontpress/issues/comments{/number}","contents_url":"https://api.github.com/repos/alisonmonteiro/frontpress/contents/{+path}","compare_url":"https://api.github.com/repos/alisonmonteiro/frontpress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alisonmonteiro/frontpress/merges","archive_url":"https://api.github.com/repos/alisonmonteiro/frontpress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alisonmonteiro/frontpress/downloads","issues_url":"https://api.github.com/repos/alisonmonteiro/frontpress/issues{/number}","pulls_url":"https://api.github.com/repos/alisonmonteiro/frontpress/pulls{/number}","milestones_url":"https://api.github.com/repos/alisonmonteiro/frontpress/milestones{/number}","notifications_url":"https://api.github.com/repos/alisonmonteiro/frontpress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alisonmonteiro/frontpress/labels{/name}","releases_url":"https://api.github.com/repos/alisonmonteiro/frontpress/releases{/id}","deployments_url":"https://api.github.com/repos/alisonmonteiro/frontpress/deployments","created_at":"2016-06-24T00:56:40Z","updated_at":"2016-06-24T00:56:41Z","pushed_at":"2016-06-24T00:58:43Z","git_url":"git://github.com/alisonmonteiro/frontpress.git","ssh_url":"git@github.com:alisonmonteiro/frontpress.git","clone_url":"https://github.com/alisonmonteiro/frontpress.git","svn_url":"https://github.com/alisonmonteiro/frontpress","homepage":"","size":38,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"teles:master","ref":"master","sha":"75a43fe89438b1a190deae220fe8decce02ba059","user":{"login":"teles","id":762639,"avatar_url":"https://avatars.githubusercontent.com/u/762639?v=3","gravatar_id":"","url":"https://api.github.com/users/teles","html_url":"https://github.com/teles","followers_url":"https://api.github.com/users/teles/followers","following_url":"https://api.github.com/users/teles/following{/other_user}","gists_url":"https://api.github.com/users/teles/gists{/gist_id}","starred_url":"https://api.github.com/users/teles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teles/subscriptions","organizations_url":"https://api.github.com/users/teles/orgs","repos_url":"https://api.github.com/users/teles/repos","events_url":"https://api.github.com/users/teles/events{/privacy}","received_events_url":"https://api.github.com/users/teles/received_events","type":"User","site_admin":false},"repo":{"id":61548092,"name":"frontpress","full_name":"teles/frontpress","owner":{"login":"teles","id":762639,"avatar_url":"https://avatars.githubusercontent.com/u/762639?v=3","gravatar_id":"","url":"https://api.github.com/users/teles","html_url":"https://github.com/teles","followers_url":"https://api.github.com/users/teles/followers","following_url":"https://api.github.com/users/teles/following{/other_user}","gists_url":"https://api.github.com/users/teles/gists{/gist_id}","starred_url":"https://api.github.com/users/teles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teles/subscriptions","organizations_url":"https://api.github.com/users/teles/orgs","repos_url":"https://api.github.com/users/teles/repos","events_url":"https://api.github.com/users/teles/events{/privacy}","received_events_url":"https://api.github.com/users/teles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teles/frontpress","description":":zap: Full front-end AngularJS template for WordPress API.","fork":false,"url":"https://api.github.com/repos/teles/frontpress","forks_url":"https://api.github.com/repos/teles/frontpress/forks","keys_url":"https://api.github.com/repos/teles/frontpress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teles/frontpress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teles/frontpress/teams","hooks_url":"https://api.github.com/repos/teles/frontpress/hooks","issue_events_url":"https://api.github.com/repos/teles/frontpress/issues/events{/number}","events_url":"https://api.github.com/repos/teles/frontpress/events","assignees_url":"https://api.github.com/repos/teles/frontpress/assignees{/user}","branches_url":"https://api.github.com/repos/teles/frontpress/branches{/branch}","tags_url":"https://api.github.com/repos/teles/frontpress/tags","blobs_url":"https://api.github.com/repos/teles/frontpress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teles/frontpress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teles/frontpress/git/refs{/sha}","trees_url":"https://api.github.com/repos/teles/frontpress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teles/frontpress/statuses/{sha}","languages_url":"https://api.github.com/repos/teles/frontpress/languages","stargazers_url":"https://api.github.com/repos/teles/frontpress/stargazers","contributors_url":"https://api.github.com/repos/teles/frontpress/contributors","subscribers_url":"https://api.github.com/repos/teles/frontpress/subscribers","subscription_url":"https://api.github.com/repos/teles/frontpress/subscription","commits_url":"https://api.github.com/repos/teles/frontpress/commits{/sha}","git_commits_url":"https://api.github.com/repos/teles/frontpress/git/commits{/sha}","comments_url":"https://api.github.com/repos/teles/frontpress/comments{/number}","issue_comment_url":"https://api.github.com/repos/teles/frontpress/issues/comments{/number}","contents_url":"https://api.github.com/repos/teles/frontpress/contents/{+path}","compare_url":"https://api.github.com/repos/teles/frontpress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teles/frontpress/merges","archive_url":"https://api.github.com/repos/teles/frontpress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teles/frontpress/downloads","issues_url":"https://api.github.com/repos/teles/frontpress/issues{/number}","pulls_url":"https://api.github.com/repos/teles/frontpress/pulls{/number}","milestones_url":"https://api.github.com/repos/teles/frontpress/milestones{/number}","notifications_url":"https://api.github.com/repos/teles/frontpress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teles/frontpress/labels{/name}","releases_url":"https://api.github.com/repos/teles/frontpress/releases{/id}","deployments_url":"https://api.github.com/repos/teles/frontpress/deployments","created_at":"2016-06-20T13:02:52Z","updated_at":"2016-06-23T20:09:37Z","pushed_at":"2016-06-25T12:45:15Z","git_url":"git://github.com/teles/frontpress.git","ssh_url":"git@github.com:teles/frontpress.git","clone_url":"https://github.com/teles/frontpress.git","svn_url":"https://github.com/teles/frontpress","homepage":"","size":37,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/teles/frontpress/pulls/10"},"html":{"href":"https://github.com/teles/frontpress/pull/10"},"issue":{"href":"https://api.github.com/repos/teles/frontpress/issues/10"},"comments":{"href":"https://api.github.com/repos/teles/frontpress/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/teles/frontpress/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/teles/frontpress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/teles/frontpress/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/teles/frontpress/statuses/b8d73f2b20a4ffb2dcca608765a588436af0b8f3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"teles","id":762639,"avatar_url":"https://avatars.githubusercontent.com/u/762639?v=3","gravatar_id":"","url":"https://api.github.com/users/teles","html_url":"https://github.com/teles","followers_url":"https://api.github.com/users/teles/followers","following_url":"https://api.github.com/users/teles/following{/other_user}","gists_url":"https://api.github.com/users/teles/gists{/gist_id}","starred_url":"https://api.github.com/users/teles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teles/subscriptions","organizations_url":"https://api.github.com/users/teles/orgs","repos_url":"https://api.github.com/users/teles/repos","events_url":"https://api.github.com/users/teles/events{/privacy}","received_events_url":"https://api.github.com/users/teles/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":63,"deletions":79,"changed_files":2}}
{"actor":{"display_login":"teles"}}