{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8513","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8513/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8513/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8513/events","html_url":"https://github.com/cockroachdb/cockroach/pull/8513","id":170984380,"number":8513,"title":"build: use a tmp file for forbidden.log","user":{"login":"petermattis","id":6201335,"avatar_url":"https://avatars.githubusercontent.com/u/6201335?v=3","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-13T00:52:15Z","updated_at":"2016-08-13T02:07:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/8513","html_url":"https://github.com/cockroachdb/cockroach/pull/8513","diff_url":"https://github.com/cockroachdb/cockroach/pull/8513.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/8513.patch"},"body":"This avoids placing a file temporarily in the user's source directory\nwhich can confuse other checks when run concurrently.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/8513)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/239595968","html_url":"https://github.com/cockroachdb/cockroach/pull/8513#issuecomment-239595968","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/8513","id":239595968,"user":{"login":"tamird","id":1535036,"avatar_url":"https://avatars.githubusercontent.com/u/1535036?v=3","gravatar_id":"","url":"https://api.github.com/users/tamird","html_url":"https://github.com/tamird","followers_url":"https://api.github.com/users/tamird/followers","following_url":"https://api.github.com/users/tamird/following{/other_user}","gists_url":"https://api.github.com/users/tamird/gists{/gist_id}","starred_url":"https://api.github.com/users/tamird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamird/subscriptions","organizations_url":"https://api.github.com/users/tamird/orgs","repos_url":"https://api.github.com/users/tamird/repos","events_url":"https://api.github.com/users/tamird/events{/privacy}","received_events_url":"https://api.github.com/users/tamird/received_events","type":"User","site_admin":false},"created_at":"2016-08-13T02:07:37Z","updated_at":"2016-08-13T02:07:37Z","body":"\n\n\n\nReviewed 1 of 1 files at r2.\nReview status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[build/check-style.sh, line 81 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/8513#-KP0Nu1oFlycPooojphi:-KP0dkVZV9jfk0r7Degr:byi4vjz) ([raw file](https://github.com/cockroachdb/cockroach/blob/d9a14bd5a666f1579a584c18958e2768e96153c3/build/check-style.sh#L81)):*\n<details><summary><i>Previously, petermattis (Peter Mattis) wrote…</i></summary>\n> How do you do that safely in a shell script where you don't know if other parts of the script might be hooking exit?\n</details>\nWhat do you mean? I don't actually know how multiple exit hooks would interact, but what's stopping you from knowing if other parts are hooking?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/8513)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"tamird"}}