{"action":"created","comment":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/76743842","id":76743842,"diff_hunk":"@@ -95,4 +99,14 @@ open class InMemoryContactRepository : ContactRepository {\n             identities.put(it.keyIdentifier, it)\n         }\n     }\n+\n+    fun attach(observer: ContactObserver) {","path":"core/src/test/java/de/qabel/core/repository/inmemory/InMemoryContactRepository.kt","position":36,"original_position":36,"commit_id":"b77bcc3095a928ec5b5eb6d765fc413290bfaedb","original_commit_id":"b77bcc3095a928ec5b5eb6d765fc413290bfaedb","user":{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false},"body":"to apply some kind of collective code ownership, try to use the short notation for method bodies if they consist of only one line:\r\n\r\n`fun attach(observer: ContactObserver) = observers.add(observer)`\r\nthat should work here, is much shorter and tells the reader that there is no more logic than that","created_at":"2016-08-30T07:40:45Z","updated_at":"2016-08-30T07:40:45Z","html_url":"https://github.com/Qabel/qabel-core/pull/573#discussion_r76743842","pull_request_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/76743842"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/573#discussion_r76743842"},"pull_request":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/573","id":83079793,"html_url":"https://github.com/Qabel/qabel-core/pull/573","diff_url":"https://github.com/Qabel/qabel-core/pull/573.diff","patch_url":"https://github.com/Qabel/qabel-core/pull/573.patch","issue_url":"https://api.github.com/repos/Qabel/qabel-core/issues/573","number":573,"state":"open","locked":false,"title":"contact repository observable","user":{"login":"taynaps","id":14896154,"avatar_url":"https://avatars.githubusercontent.com/u/14896154?v=3","gravatar_id":"","url":"https://api.github.com/users/taynaps","html_url":"https://github.com/taynaps","followers_url":"https://api.github.com/users/taynaps/followers","following_url":"https://api.github.com/users/taynaps/following{/other_user}","gists_url":"https://api.github.com/users/taynaps/gists{/gist_id}","starred_url":"https://api.github.com/users/taynaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taynaps/subscriptions","organizations_url":"https://api.github.com/users/taynaps/orgs","repos_url":"https://api.github.com/users/taynaps/repos","events_url":"https://api.github.com/users/taynaps/events{/privacy}","received_events_url":"https://api.github.com/users/taynaps/received_events","type":"User","site_admin":false},"body":"#387 implemented contact repository observable","created_at":"2016-08-29T10:51:39Z","updated_at":"2016-08-30T07:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5c8ae5dbe050b34f10359ca8f65e84d340b672b","assignee":{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false},"assignees":[{"login":"julianseeger","id":3258762,"avatar_url":"https://avatars.githubusercontent.com/u/3258762?v=3","gravatar_id":"","url":"https://api.github.com/users/julianseeger","html_url":"https://github.com/julianseeger","followers_url":"https://api.github.com/users/julianseeger/followers","following_url":"https://api.github.com/users/julianseeger/following{/other_user}","gists_url":"https://api.github.com/users/julianseeger/gists{/gist_id}","starred_url":"https://api.github.com/users/julianseeger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianseeger/subscriptions","organizations_url":"https://api.github.com/users/julianseeger/orgs","repos_url":"https://api.github.com/users/julianseeger/repos","events_url":"https://api.github.com/users/julianseeger/events{/privacy}","received_events_url":"https://api.github.com/users/julianseeger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/573/commits","review_comments_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/573/comments","review_comment_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/issues/573/comments","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/b77bcc3095a928ec5b5eb6d765fc413290bfaedb","head":{"label":"taynaps:submenu_contact_387","ref":"submenu_contact_387","sha":"b77bcc3095a928ec5b5eb6d765fc413290bfaedb","user":{"login":"taynaps","id":14896154,"avatar_url":"https://avatars.githubusercontent.com/u/14896154?v=3","gravatar_id":"","url":"https://api.github.com/users/taynaps","html_url":"https://github.com/taynaps","followers_url":"https://api.github.com/users/taynaps/followers","following_url":"https://api.github.com/users/taynaps/following{/other_user}","gists_url":"https://api.github.com/users/taynaps/gists{/gist_id}","starred_url":"https://api.github.com/users/taynaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taynaps/subscriptions","organizations_url":"https://api.github.com/users/taynaps/orgs","repos_url":"https://api.github.com/users/taynaps/repos","events_url":"https://api.github.com/users/taynaps/events{/privacy}","received_events_url":"https://api.github.com/users/taynaps/received_events","type":"User","site_admin":false},"repo":{"id":63155698,"name":"qabel-core","full_name":"taynaps/qabel-core","owner":{"login":"taynaps","id":14896154,"avatar_url":"https://avatars.githubusercontent.com/u/14896154?v=3","gravatar_id":"","url":"https://api.github.com/users/taynaps","html_url":"https://github.com/taynaps","followers_url":"https://api.github.com/users/taynaps/followers","following_url":"https://api.github.com/users/taynaps/following{/other_user}","gists_url":"https://api.github.com/users/taynaps/gists{/gist_id}","starred_url":"https://api.github.com/users/taynaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taynaps/subscriptions","organizations_url":"https://api.github.com/users/taynaps/orgs","repos_url":"https://api.github.com/users/taynaps/repos","events_url":"https://api.github.com/users/taynaps/events{/privacy}","received_events_url":"https://api.github.com/users/taynaps/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taynaps/qabel-core","description":":cloud: Implementation of Qabel-Core in Java","fork":true,"url":"https://api.github.com/repos/taynaps/qabel-core","forks_url":"https://api.github.com/repos/taynaps/qabel-core/forks","keys_url":"https://api.github.com/repos/taynaps/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taynaps/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taynaps/qabel-core/teams","hooks_url":"https://api.github.com/repos/taynaps/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/taynaps/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/taynaps/qabel-core/events","assignees_url":"https://api.github.com/repos/taynaps/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/taynaps/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/taynaps/qabel-core/tags","blobs_url":"https://api.github.com/repos/taynaps/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taynaps/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taynaps/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/taynaps/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taynaps/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/taynaps/qabel-core/languages","stargazers_url":"https://api.github.com/repos/taynaps/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/taynaps/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/taynaps/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/taynaps/qabel-core/subscription","commits_url":"https://api.github.com/repos/taynaps/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/taynaps/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/taynaps/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/taynaps/qabel-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/taynaps/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/taynaps/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taynaps/qabel-core/merges","archive_url":"https://api.github.com/repos/taynaps/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taynaps/qabel-core/downloads","issues_url":"https://api.github.com/repos/taynaps/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/taynaps/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/taynaps/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/taynaps/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taynaps/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/taynaps/qabel-core/releases{/id}","deployments_url":"https://api.github.com/repos/taynaps/qabel-core/deployments","created_at":"2016-07-12T12:23:28Z","updated_at":"2016-07-12T12:23:30Z","pushed_at":"2016-08-30T07:36:14Z","git_url":"git://github.com/taynaps/qabel-core.git","ssh_url":"git@github.com:taynaps/qabel-core.git","clone_url":"https://github.com/taynaps/qabel-core.git","svn_url":"https://github.com/taynaps/qabel-core","homepage":"","size":4750,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qabel:master","ref":"master","sha":"49f743fdd9a125a73f397194a86e0bad9962d41c","user":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"repo":{"id":22873447,"name":"qabel-core","full_name":"Qabel/qabel-core","owner":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qabel/qabel-core","description":":cloud: Implementation of Qabel-Core in Java","fork":false,"url":"https://api.github.com/repos/Qabel/qabel-core","forks_url":"https://api.github.com/repos/Qabel/qabel-core/forks","keys_url":"https://api.github.com/repos/Qabel/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qabel/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qabel/qabel-core/teams","hooks_url":"https://api.github.com/repos/Qabel/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/Qabel/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/Qabel/qabel-core/events","assignees_url":"https://api.github.com/repos/Qabel/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/Qabel/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/Qabel/qabel-core/tags","blobs_url":"https://api.github.com/repos/Qabel/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qabel/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qabel/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qabel/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Qabel/qabel-core/languages","stargazers_url":"https://api.github.com/repos/Qabel/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/Qabel/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/Qabel/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/Qabel/qabel-core/subscription","commits_url":"https://api.github.com/repos/Qabel/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qabel/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qabel/qabel-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qabel/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/Qabel/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qabel/qabel-core/merges","archive_url":"https://api.github.com/repos/Qabel/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qabel/qabel-core/downloads","issues_url":"https://api.github.com/repos/Qabel/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/Qabel/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Qabel/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Qabel/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qabel/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/Qabel/qabel-core/releases{/id}","deployments_url":"https://api.github.com/repos/Qabel/qabel-core/deployments","created_at":"2014-08-12T10:25:10Z","updated_at":"2016-06-01T13:57:28Z","pushed_at":"2016-08-30T07:36:14Z","git_url":"git://github.com/Qabel/qabel-core.git","ssh_url":"git@github.com:Qabel/qabel-core.git","clone_url":"https://github.com/Qabel/qabel-core.git","svn_url":"https://github.com/Qabel/qabel-core","homepage":"","size":6350,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":47,"forks":15,"open_issues":47,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/573"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/573"},"issue":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/573"},"comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/Qabel/qabel-core/statuses/b77bcc3095a928ec5b5eb6d765fc413290bfaedb"}}}}
{"actor":{"display_login":"julianseeger"}}