{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/15793","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15793/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15793/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15793/events","html_url":"https://github.com/elastic/elasticsearch/pull/15793","id":125221185,"number":15793,"title":"Don't override originalQuery with request filters","user":{"login":"nik9000","id":215970,"avatar_url":"https://avatars.githubusercontent.com/u/215970?v=3","gravatar_id":"","url":"https://api.github.com/users/nik9000","html_url":"https://github.com/nik9000","followers_url":"https://api.github.com/users/nik9000/followers","following_url":"https://api.github.com/users/nik9000/following{/other_user}","gists_url":"https://api.github.com/users/nik9000/gists{/gist_id}","starred_url":"https://api.github.com/users/nik9000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nik9000/subscriptions","organizations_url":"https://api.github.com/users/nik9000/orgs","repos_url":"https://api.github.com/users/nik9000/repos","events_url":"https://api.github.com/users/nik9000/events{/privacy}","received_events_url":"https://api.github.com/users/nik9000/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Highlighting","name":":Highlighting","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/bug","name":"bug","color":"9e2c2c"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v2.3.0","name":"v2.3.0","color":"dddddd"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v3.0.0","name":"v3.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-01-06T17:15:42Z","updated_at":"2016-01-12T15:17:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15793","html_url":"https://github.com/elastic/elasticsearch/pull/15793","diff_url":"https://github.com/elastic/elasticsearch/pull/15793.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/15793.patch"},"body":"These filters leak into highlighting and probably other places and cause things like the type name to be highlighted when using requireFieldMatch=false. We could have special hacks to keep them out of highlighting but it feals better to keep them out of any variable named \"originalQuery\".\r\n    \r\nCloses #15689\r\n"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/170944132","html_url":"https://github.com/elastic/elasticsearch/pull/15793#issuecomment-170944132","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15793","id":170944132,"user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"created_at":"2016-01-12T15:17:28Z","updated_at":"2016-01-12T15:17:28Z","body":"I found this a bit scary at first as it adds a new method to be used to retrieve the query that we previously relied one (the filtered one) while the default one (parsedQuery) is not filtered anymore. That said I looked at where we call what and it seems ok, also if tests are green I suppose we are good :) LGTM then"}}