{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/80192588","id":80192588,"diff_hunk":"@@ -11,7 +11,7 @@\n     ts4Max                = cms.vdouble(100.,70000.), #fC # this is roughly 20 GeV\n     pulseJitter           = cms.double(1.),           #GeV/bin \n     ###\n-    meanTime              = cms.double(0.),   #ns \n+    meanTime              = cms.double(2.),   #ns ","path":"RecoLocalCalo/HcalRecProducers/python/HBHEMethod2Parameters_cfi.py","position":5,"original_position":5,"commit_id":"6368a32393ce9b5e2ff8de56799c3af7414563a8","original_commit_id":"c8475394e75e24d25da15bff8068cba9e5bd3e74","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"``` I will remove this modification (c847539) from this PR ... ``` makes sense to me.\r\n[some possibly relevant text follows]\r\n\r\nIs p3 (the carpet plots) made for unconstrained chi2? (the formula on the page says so, but M2 we use in reco is constrained).\r\n\r\nThe slides from HCAL DPG p6 look like the same template is used for data and MC and the template matches data very well. \r\nBTW, fine time binning or continuous curve overlay here would help to understand what is happening better. Due to very sharp rise of the expected pulse shape, anything significant that shows up to the left of the TS4 will very likely  trigger 3-pulse fit which will call this early entry an OOT hit that we do not record as an output of the fit. The result may give smaller bias in time, but it will give a significant bias in energy. I'd sacrifice few ns bias in time for a decreased bias in energy. Calibrations can correct the biases, but it seems to me to be more important to integrate more true signal pulse as signal to not loose resolution in E and probably loose something in t.\r\n\r\nThis \"timeMean\" enters in two places: \r\n- starting point for the fit\r\n- constraint parameter for the fit\r\nIf MC disagrees so badly, then biases are \"natural\" and playing with fitting parameters without changing the expected shape is not very productive.\r\n","created_at":"2016-09-23T07:18:22Z","updated_at":"2016-09-23T07:18:22Z","html_url":"https://github.com/cms-sw/cmssw/pull/15959#discussion_r80192588","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/80192588"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15959#discussion_r80192588"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959","id":86365510,"html_url":"https://github.com/cms-sw/cmssw/pull/15959","diff_url":"https://github.com/cms-sw/cmssw/pull/15959.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/15959.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959","number":15959,"state":"open","locked":false,"title":"HBHE: siPM M2 reco fixes ","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"body":"FIX the initialization of the siPM pulse (Run2-phase1). \r\nBefore the M2 siPM fits was done with the HPD pulse and parameters.\r\n\r\nAdd extra features:\r\nAdd the ADC granularity or siPM (phase1)\r\nMove the initial time of the M2 fit to 2ns (Run2-phase1 )\r\n\r\nThis PR save 40% of CPU time on single particle no PU\r\n\r\nSome reference slide\r\nhttps://indico.cern.ch/event/570231/contributions/2306435/attachments/1341696/2021200/PR15959.pdf","created_at":"2016-09-22T15:55:38Z","updated_at":"2016-09-23T07:18:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aadf1c0b7f8f6c8fe3160a84cb714b2341c0775e","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_8_1_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/59/labels","id":1590252,"number":59,"title":"Next CMSSW_8_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":1517,"state":"open","created_at":"2016-02-18T09:12:12Z","updated_at":"2016-09-23T06:45:04Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/15959/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/6368a32393ce9b5e2ff8de56799c3af7414563a8","head":{"label":"mariadalfonso:siPMfixes","ref":"siPMfixes","sha":"6368a32393ce9b5e2ff8de56799c3af7414563a8","user":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"repo":{"id":18758083,"name":"cmssw","full_name":"mariadalfonso/cmssw","owner":{"login":"mariadalfonso","id":5656714,"avatar_url":"https://avatars.githubusercontent.com/u/5656714?v=3","gravatar_id":"","url":"https://api.github.com/users/mariadalfonso","html_url":"https://github.com/mariadalfonso","followers_url":"https://api.github.com/users/mariadalfonso/followers","following_url":"https://api.github.com/users/mariadalfonso/following{/other_user}","gists_url":"https://api.github.com/users/mariadalfonso/gists{/gist_id}","starred_url":"https://api.github.com/users/mariadalfonso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariadalfonso/subscriptions","organizations_url":"https://api.github.com/users/mariadalfonso/orgs","repos_url":"https://api.github.com/users/mariadalfonso/repos","events_url":"https://api.github.com/users/mariadalfonso/events{/privacy}","received_events_url":"https://api.github.com/users/mariadalfonso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariadalfonso/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/mariadalfonso/cmssw","forks_url":"https://api.github.com/repos/mariadalfonso/cmssw/forks","keys_url":"https://api.github.com/repos/mariadalfonso/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariadalfonso/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariadalfonso/cmssw/teams","hooks_url":"https://api.github.com/repos/mariadalfonso/cmssw/hooks","issue_events_url":"https://api.github.com/repos/mariadalfonso/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/mariadalfonso/cmssw/events","assignees_url":"https://api.github.com/repos/mariadalfonso/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/mariadalfonso/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/mariadalfonso/cmssw/tags","blobs_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariadalfonso/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/mariadalfonso/cmssw/languages","stargazers_url":"https://api.github.com/repos/mariadalfonso/cmssw/stargazers","contributors_url":"https://api.github.com/repos/mariadalfonso/cmssw/contributors","subscribers_url":"https://api.github.com/repos/mariadalfonso/cmssw/subscribers","subscription_url":"https://api.github.com/repos/mariadalfonso/cmssw/subscription","commits_url":"https://api.github.com/repos/mariadalfonso/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariadalfonso/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariadalfonso/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariadalfonso/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariadalfonso/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/mariadalfonso/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariadalfonso/cmssw/merges","archive_url":"https://api.github.com/repos/mariadalfonso/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariadalfonso/cmssw/downloads","issues_url":"https://api.github.com/repos/mariadalfonso/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/mariadalfonso/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/mariadalfonso/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/mariadalfonso/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariadalfonso/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/mariadalfonso/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/mariadalfonso/cmssw/deployments","created_at":"2014-04-14T11:20:12Z","updated_at":"2014-04-14T11:22:34Z","pushed_at":"2016-09-22T20:56:41Z","git_url":"git://github.com/mariadalfonso/cmssw.git","ssh_url":"git@github.com:mariadalfonso/cmssw.git","clone_url":"https://github.com/mariadalfonso/cmssw.git","svn_url":"https://github.com/mariadalfonso/cmssw","homepage":"cms-sw.github.io/cmssw","size":871222,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_1_X"}},"base":{"label":"cms-sw:CMSSW_8_1_X","ref":"CMSSW_8_1_X","sha":"f0a1f43a4e0a5dd281b2ca463f3ea9222362b502","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2016-09-22T22:35:32Z","pushed_at":"2016-09-23T06:46:38Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1108815,"stargazers_count":344,"watchers_count":344,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1982,"mirror_url":null,"open_issues_count":349,"forks":1982,"open_issues":349,"watchers":344,"default_branch":"CMSSW_8_1_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/15959"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15959"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/15959/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/15959/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/6368a32393ce9b5e2ff8de56799c3af7414563a8"}}}}
{"actor":{"display_login":"slava77"}}