{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/8140","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/8140/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/8140/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/8140/events","html_url":"https://github.com/nodejs/node/pull/8140","id":171652811,"number":8140,"title":"benchmark: support for multiple http benchmarkers","user":{"login":"bzoz","id":17704638,"avatar_url":"https://avatars.githubusercontent.com/u/17704638?v=3","gravatar_id":"","url":"https://api.github.com/users/bzoz","html_url":"https://github.com/bzoz","followers_url":"https://api.github.com/users/bzoz/followers","following_url":"https://api.github.com/users/bzoz/following{/other_user}","gists_url":"https://api.github.com/users/bzoz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzoz/subscriptions","organizations_url":"https://api.github.com/users/bzoz/orgs","repos_url":"https://api.github.com/users/bzoz/repos","events_url":"https://api.github.com/users/bzoz/events{/privacy}","received_events_url":"https://api.github.com/users/bzoz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/benchmark","name":"benchmark","color":"009800"},{"url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"fad8c7"},{"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"bfdadc"},{"url":"https://api.github.com/repos/nodejs/node/labels/windows","name":"windows","color":"9944dd"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2016-08-17T13:08:21Z","updated_at":"2016-08-26T08:59:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/8140","html_url":"https://github.com/nodejs/node/pull/8140","diff_url":"https://github.com/nodejs/node/pull/8140.diff","patch_url":"https://github.com/nodejs/node/pull/8140.patch"},"body":"##### Checklist\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\nbenchmark\r\n\r\n##### Description of change\r\nContinued from https://github.com/nodejs/node/pull/7180\r\n\r\nAdd support for multiple HTTP benchmarkers. Adds [autocannon](https://github.com/mcollina/autocannon) as the secondary benchmarker.\r\n\r\nThis allows for all http benchmarks to be executed under Windows. All available tools (`wrk` and `autocannon`) will be used to run HTTP benchmarks. It will fail if none of the tools is installed.\r\n\r\ncc @nodejs/benchmarking "},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/242672479","html_url":"https://github.com/nodejs/node/pull/8140#issuecomment-242672479","issue_url":"https://api.github.com/repos/nodejs/node/issues/8140","id":242672479,"user":{"login":"bzoz","id":17704638,"avatar_url":"https://avatars.githubusercontent.com/u/17704638?v=3","gravatar_id":"","url":"https://api.github.com/users/bzoz","html_url":"https://github.com/bzoz","followers_url":"https://api.github.com/users/bzoz/followers","following_url":"https://api.github.com/users/bzoz/following{/other_user}","gists_url":"https://api.github.com/users/bzoz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzoz/subscriptions","organizations_url":"https://api.github.com/users/bzoz/orgs","repos_url":"https://api.github.com/users/bzoz/repos","events_url":"https://api.github.com/users/bzoz/events{/privacy}","received_events_url":"https://api.github.com/users/bzoz/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T08:59:31Z","updated_at":"2016-08-26T08:59:31Z","body":"I think it would be better to just add this as string. Otherwise I think it would be confusing for users - it would seem that sometimes it does not work. Also, no feedback when one would misspell config option.\r\n\r\nAnyhow - I'll change `common.js` so that it will assume string type and drop the ENV thing. "}}
{"actor":{"display_login":"bzoz"}}