{"action":"created","issue":{"url":"https://api.github.com/repos/ageuk/companion-app/issues/42","repository_url":"https://api.github.com/repos/ageuk/companion-app","labels_url":"https://api.github.com/repos/ageuk/companion-app/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/ageuk/companion-app/issues/42/comments","events_url":"https://api.github.com/repos/ageuk/companion-app/issues/42/events","html_url":"https://github.com/ageuk/companion-app/issues/42","id":162914816,"number":42,"title":"Bcrypt problems with CircleCi","user":{"login":"andrewMacmurray","id":14013616,"avatar_url":"https://avatars.githubusercontent.com/u/14013616?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewMacmurray","html_url":"https://github.com/andrewMacmurray","followers_url":"https://api.github.com/users/andrewMacmurray/followers","following_url":"https://api.github.com/users/andrewMacmurray/following{/other_user}","gists_url":"https://api.github.com/users/andrewMacmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewMacmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewMacmurray/subscriptions","organizations_url":"https://api.github.com/users/andrewMacmurray/orgs","repos_url":"https://api.github.com/users/andrewMacmurray/repos","events_url":"https://api.github.com/users/andrewMacmurray/events{/privacy}","received_events_url":"https://api.github.com/users/andrewMacmurray/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ageuk/companion-app/labels/bug","name":"bug","color":"ee0701"},{"url":"https://api.github.com/repos/ageuk/companion-app/labels/help%20wanted","name":"help wanted","color":"128A0C"},{"url":"https://api.github.com/repos/ageuk/companion-app/labels/technical","name":"technical","color":"D4C5F9"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-06-29T12:39:29Z","updated_at":"2016-06-29T12:41:11Z","closed_at":null,"body":"we've been having problems getting the tests to pass on circle when using bcrypt to verify a password\r\n\r\n+ on OSX 10.11 the tests work (my computer)\r\n+ on Ubuntu 15.10 @katbow 's computer the tests were failing when comparing passwords using `bcrypt.compare(password, passwordHash, cb)` (the async version) but passed using the sync version (`bcrypt.compareSync(.....)`)\r\n+ on Circle (on both Ubuntu 12.04 & 14.04 build environments) both methods fail 😭 \r\n\r\nHas anyone encountered this problem before?\r\n\r\nthe problem is here\r\nhttps://github.com/ageuk/companion-app/blob/hapi-login/lib/login/hapiLoginConfig.js#L13\r\n\r\nthis is the test that fails\r\nhttps://github.com/ageuk/companion-app/blob/hapi-login/test/server/login.test.js#L34\r\n\r\nit returns `wrong password` instead of `good credentials` on circleCi\r\n\r\nAny help would be amazing 😄  👾  ✨ "},"comment":{"url":"https://api.github.com/repos/ageuk/companion-app/issues/comments/229343915","html_url":"https://github.com/ageuk/companion-app/issues/42#issuecomment-229343915","issue_url":"https://api.github.com/repos/ageuk/companion-app/issues/42","id":229343915,"user":{"login":"nelsonic","id":194400,"avatar_url":"https://avatars.githubusercontent.com/u/194400?v=3","gravatar_id":"","url":"https://api.github.com/users/nelsonic","html_url":"https://github.com/nelsonic","followers_url":"https://api.github.com/users/nelsonic/followers","following_url":"https://api.github.com/users/nelsonic/following{/other_user}","gists_url":"https://api.github.com/users/nelsonic/gists{/gist_id}","starred_url":"https://api.github.com/users/nelsonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelsonic/subscriptions","organizations_url":"https://api.github.com/users/nelsonic/orgs","repos_url":"https://api.github.com/users/nelsonic/repos","events_url":"https://api.github.com/users/nelsonic/events{/privacy}","received_events_url":"https://api.github.com/users/nelsonic/received_events","type":"User","site_admin":false},"created_at":"2016-06-29T12:41:11Z","updated_at":"2016-06-29T12:41:11Z","body":"@andrewMacmurray we've had this before. sample _working_ `circle.yml` file (from OxAbs):\r\n```yml\r\nmachine:\r\n  pre:\r\n    - sudo apt-get update; sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.9 10\r\n  environment:\r\n    DATABASE_URL: postgres://ubuntu:@127.0.0.1:5432/circle_test\r\n  node:\r\n    version: 6.0.0\r\ngeneral:\r\n  artifacts:\r\n    - \"coverage\"\r\ntest:\r\n  post:\r\n    - pip install --user codecov\r\n    - codecov --file coverage/lcov.info --disable search --token=f054ae63-f930-4ad8-ba09-e2b2be42b2d6\r\n\r\ndependencies:\r\n  pre:\r\n    - sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.8 20\r\n    - sudo update-alternatives --install /usr/bin/g++ g++ /usr/bin/g++-4.8 20\r\n```"}}
{"actor":{"display_login":"nelsonic"}}