{"action":"created","issue":{"url":"https://api.github.com/repos/laravel/laravel/issues/3642","labels_url":"https://api.github.com/repos/laravel/laravel/issues/3642/labels{/name}","comments_url":"https://api.github.com/repos/laravel/laravel/issues/3642/comments","events_url":"https://api.github.com/repos/laravel/laravel/issues/3642/events","html_url":"https://github.com/laravel/laravel/pull/3642","id":129760959,"number":3642,"title":"Replaced \"@return void\" in constructor phpdocs with \"@return self\"","user":{"login":"deframe","id":559698,"avatar_url":"https://avatars.githubusercontent.com/u/559698?v=3","gravatar_id":"","url":"https://api.github.com/users/deframe","html_url":"https://github.com/deframe","followers_url":"https://api.github.com/users/deframe/followers","following_url":"https://api.github.com/users/deframe/following{/other_user}","gists_url":"https://api.github.com/users/deframe/gists{/gist_id}","starred_url":"https://api.github.com/users/deframe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deframe/subscriptions","organizations_url":"https://api.github.com/users/deframe/orgs","repos_url":"https://api.github.com/users/deframe/repos","events_url":"https://api.github.com/users/deframe/events{/privacy}","received_events_url":"https://api.github.com/users/deframe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-01-29T13:04:45Z","updated_at":"2016-01-29T14:21:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/laravel/laravel/pulls/3642","html_url":"https://github.com/laravel/laravel/pull/3642","diff_url":"https://github.com/laravel/laravel/pull/3642.diff","patch_url":"https://github.com/laravel/laravel/pull/3642.patch"},"body":"The phpDocumentor documentation states that the **@return** tag for a constructor must either be omitted or have a description of **self**. Laravel incorrectly uses **@return void**, which causes syntax warnings in IDEs such as PHPStorm.\r\n\r\nhttp://www.phpdoc.org/docs/latest/references/phpdoc/tags/return.html\r\n\r\nI have also submitted a PR for the _laravel/framework_ repository to patch up the stub files used by artisan's scaffolding.\r\n\r\nHopefully I'm right in branching master for this (there doesn't appear to be a 5.2 branch?)"},"comment":{"url":"https://api.github.com/repos/laravel/laravel/issues/comments/176779173","html_url":"https://github.com/laravel/laravel/pull/3642#issuecomment-176779173","issue_url":"https://api.github.com/repos/laravel/laravel/issues/3642","id":176779173,"user":{"login":"deframe","id":559698,"avatar_url":"https://avatars.githubusercontent.com/u/559698?v=3","gravatar_id":"","url":"https://api.github.com/users/deframe","html_url":"https://github.com/deframe","followers_url":"https://api.github.com/users/deframe/followers","following_url":"https://api.github.com/users/deframe/following{/other_user}","gists_url":"https://api.github.com/users/deframe/gists{/gist_id}","starred_url":"https://api.github.com/users/deframe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deframe/subscriptions","organizations_url":"https://api.github.com/users/deframe/orgs","repos_url":"https://api.github.com/users/deframe/repos","events_url":"https://api.github.com/users/deframe/events{/privacy}","received_events_url":"https://api.github.com/users/deframe/received_events","type":"User","site_admin":false},"created_at":"2016-01-29T14:21:16Z","updated_at":"2016-01-29T14:21:16Z","body":"@w2pc I see what you mean. I'll leave it open for a short period as I don't think the actual phpDocumentor documentation has been referenced in this way before. If the implied return type of a constructor is 'self' then that would seem to be what the creators expect, regardless of whether it makes sense or not."}}