{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/69485602","id":69485602,"diff_hunk":"@@ -60,7 +60,7 @@ public static bool ValidateCommand(S server, Connection conn, Session.Client cli\n \n \t\tstatic void CheckAutoStart(S server)\n \t\t{\n-\t\t\tvar playerClients = server.LobbyInfo.Clients.Where(c => c.Bot == null && c.Slot != null);\n+\t\t\tvar playerClients = server.LobbyInfo.Clients.Where(c => (c.Bot == null && c.Slot != null) || c.IsAdmin);","path":"OpenRA.Mods.Common/ServerTraits/LobbyCommands.cs","position":5,"original_position":5,"commit_id":"37888796d81556e373a037a379c62024dfdff9cd","original_commit_id":"37888796d81556e373a037a379c62024dfdff9cd","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars.githubusercontent.com/u/167819?v=3","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Can you please add a comment here explaining that spectating admins are an exception to the normal rules?","created_at":"2016-07-04T18:55:05Z","updated_at":"2016-07-04T18:55:05Z","html_url":"https://github.com/OpenRA/OpenRA/pull/11559#discussion_r69485602","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/69485602"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/11559#discussion_r69485602"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559","id":76063379,"html_url":"https://github.com/OpenRA/OpenRA/pull/11559","diff_url":"https://github.com/OpenRA/OpenRA/pull/11559.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/11559.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/11559","number":11559,"state":"open","locked":false,"title":"Added ready checkbox for spectating admins","user":{"login":"MUzzell","id":2963387,"avatar_url":"https://avatars.githubusercontent.com/u/2963387?v=3","gravatar_id":"","url":"https://api.github.com/users/MUzzell","html_url":"https://github.com/MUzzell","followers_url":"https://api.github.com/users/MUzzell/followers","following_url":"https://api.github.com/users/MUzzell/following{/other_user}","gists_url":"https://api.github.com/users/MUzzell/gists{/gist_id}","starred_url":"https://api.github.com/users/MUzzell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUzzell/subscriptions","organizations_url":"https://api.github.com/users/MUzzell/orgs","repos_url":"https://api.github.com/users/MUzzell/repos","events_url":"https://api.github.com/users/MUzzell/events{/privacy}","received_events_url":"https://api.github.com/users/MUzzell/received_events","type":"User","site_admin":false},"body":"Feature #10416\r\n\r\nAn admin is now able to spectate a game and is provided with a ready checkbox.\r\n![ra](https://cloud.githubusercontent.com/assets/2963387/16540205/fc82fbc2-4053-11e6-8d19-64a44798b561.png)\r\n\r\nGame does not start until the spectating admin is ready.\r\n![spec_admin_not_ready](https://cloud.githubusercontent.com/assets/2963387/16540204/fade3e94-4053-11e6-9ca2-2f4329ac30ce.png)\r\n\r\nAn admin spectating still has the start game option.\r\n![two_spectators](https://cloud.githubusercontent.com/assets/2963387/16540206/fe09b4ea-4053-11e6-8485-4009549c0d56.png)\r\n\r\n![cnc](https://cloud.githubusercontent.com/assets/2963387/16540211/21c6033e-4054-11e6-8af1-2cf1e4d1aaae.png)\r\n\r\n\r\n","created_at":"2016-07-02T11:56:39Z","updated_at":"2016-07-04T18:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80590ba0d67c59141900ad469baa2cc22b4e7b53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/11559/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/37888796d81556e373a037a379c62024dfdff9cd","head":{"label":"MUzzell:feature-10416","ref":"feature-10416","sha":"37888796d81556e373a037a379c62024dfdff9cd","user":{"login":"MUzzell","id":2963387,"avatar_url":"https://avatars.githubusercontent.com/u/2963387?v=3","gravatar_id":"","url":"https://api.github.com/users/MUzzell","html_url":"https://github.com/MUzzell","followers_url":"https://api.github.com/users/MUzzell/followers","following_url":"https://api.github.com/users/MUzzell/following{/other_user}","gists_url":"https://api.github.com/users/MUzzell/gists{/gist_id}","starred_url":"https://api.github.com/users/MUzzell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUzzell/subscriptions","organizations_url":"https://api.github.com/users/MUzzell/orgs","repos_url":"https://api.github.com/users/MUzzell/repos","events_url":"https://api.github.com/users/MUzzell/events{/privacy}","received_events_url":"https://api.github.com/users/MUzzell/received_events","type":"User","site_admin":false},"repo":{"id":62255282,"name":"OpenRA","full_name":"MUzzell/OpenRA","owner":{"login":"MUzzell","id":2963387,"avatar_url":"https://avatars.githubusercontent.com/u/2963387?v=3","gravatar_id":"","url":"https://api.github.com/users/MUzzell","html_url":"https://github.com/MUzzell","followers_url":"https://api.github.com/users/MUzzell/followers","following_url":"https://api.github.com/users/MUzzell/following{/other_user}","gists_url":"https://api.github.com/users/MUzzell/gists{/gist_id}","starred_url":"https://api.github.com/users/MUzzell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MUzzell/subscriptions","organizations_url":"https://api.github.com/users/MUzzell/orgs","repos_url":"https://api.github.com/users/MUzzell/repos","events_url":"https://api.github.com/users/MUzzell/events{/privacy}","received_events_url":"https://api.github.com/users/MUzzell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MUzzell/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":true,"url":"https://api.github.com/repos/MUzzell/OpenRA","forks_url":"https://api.github.com/repos/MUzzell/OpenRA/forks","keys_url":"https://api.github.com/repos/MUzzell/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MUzzell/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MUzzell/OpenRA/teams","hooks_url":"https://api.github.com/repos/MUzzell/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/MUzzell/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/MUzzell/OpenRA/events","assignees_url":"https://api.github.com/repos/MUzzell/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/MUzzell/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/MUzzell/OpenRA/tags","blobs_url":"https://api.github.com/repos/MUzzell/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MUzzell/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MUzzell/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/MUzzell/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MUzzell/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/MUzzell/OpenRA/languages","stargazers_url":"https://api.github.com/repos/MUzzell/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/MUzzell/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/MUzzell/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/MUzzell/OpenRA/subscription","commits_url":"https://api.github.com/repos/MUzzell/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/MUzzell/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/MUzzell/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/MUzzell/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/MUzzell/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/MUzzell/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MUzzell/OpenRA/merges","archive_url":"https://api.github.com/repos/MUzzell/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MUzzell/OpenRA/downloads","issues_url":"https://api.github.com/repos/MUzzell/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/MUzzell/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/MUzzell/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/MUzzell/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MUzzell/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/MUzzell/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/MUzzell/OpenRA/deployments","created_at":"2016-06-29T20:21:33Z","updated_at":"2016-06-29T20:21:42Z","pushed_at":"2016-07-02T13:09:19Z","git_url":"git://github.com/MUzzell/OpenRA.git","ssh_url":"git@github.com:MUzzell/OpenRA.git","clone_url":"https://github.com/MUzzell/OpenRA.git","svn_url":"https://github.com/MUzzell/OpenRA","homepage":"http://www.openra.net","size":105796,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"2640b5df80f6d521dea4565b8aebdb91bc4f4a9b","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/OpenRA/deployments","created_at":"2010-10-04T07:38:05Z","updated_at":"2016-07-04T09:13:42Z","pushed_at":"2016-07-04T16:37:31Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":171816,"stargazers_count":3136,"watchers_count":3136,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1022,"mirror_url":null,"open_issues_count":1008,"forks":1022,"open_issues":1008,"watchers":3136,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/11559"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/11559"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/11559/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/11559/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/37888796d81556e373a037a379c62024dfdff9cd"}}}}
{"actor":{"display_login":"pchote"}}