{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/75183597","id":75183597,"diff_hunk":"@@ -63,6 +63,7 @@\n     <BuildToolsTaskDir Condition=\"'$(BuildToolsTargets45)' == 'true'\">$(ToolsDir)net45/</BuildToolsTaskDir>\n     <BuildToolsTaskDir Condition=\"'$(BuildToolsTaskDir)'==''\">$(ToolsDir)</BuildToolsTaskDir>\n     <UseRoslynCompilers Condition=\"'$(UseRoslynCompilers)'=='' and '$(OSEnvironment)'!='Windows_NT'\">false</UseRoslynCompilers>\n+    <UseSharedCompilation Condition=\"'$(UseSharedCompilation)' == '' and '$(OSEnvironment)' == 'Windows_NT' and '$(UseRoslynCompilers)' != 'true'\">true</UseSharedCompilation>","path":"dir.props","position":15,"original_position":15,"commit_id":"1ec6349e18b94053acb19652d40505855519ea99","original_commit_id":"1ec6349e18b94053acb19652d40505855519ea99","user":{"login":"joperezr","id":13854455,"avatar_url":"https://avatars.githubusercontent.com/u/13854455?v=3","gravatar_id":"","url":"https://api.github.com/users/joperezr","html_url":"https://github.com/joperezr","followers_url":"https://api.github.com/users/joperezr/followers","following_url":"https://api.github.com/users/joperezr/following{/other_user}","gists_url":"https://api.github.com/users/joperezr/gists{/gist_id}","starred_url":"https://api.github.com/users/joperezr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joperezr/subscriptions","organizations_url":"https://api.github.com/users/joperezr/orgs","repos_url":"https://api.github.com/users/joperezr/repos","events_url":"https://api.github.com/users/joperezr/events{/privacy}","received_events_url":"https://api.github.com/users/joperezr/received_events","type":"User","site_admin":false},"body":"I don't think the part of `'$(UseRoslynCompilers)'!='true'` is right. I believe you actually want the opposite and have it to be != false","created_at":"2016-08-17T18:51:17Z","updated_at":"2016-08-17T18:51:17Z","html_url":"https://github.com/dotnet/corefx/pull/10928#discussion_r75183597","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/10928","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/75183597"},"html":{"href":"https://github.com/dotnet/corefx/pull/10928#discussion_r75183597"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10928"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/10928","id":81678559,"html_url":"https://github.com/dotnet/corefx/pull/10928","diff_url":"https://github.com/dotnet/corefx/pull/10928.diff","patch_url":"https://github.com/dotnet/corefx/pull/10928.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/10928","number":10928,"state":"open","locked":false,"title":"Compiler","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"body":"**Windows**\r\nBuildTools defines what version of the Roslyn compiler it restores (to tools\\Microsoft.NETCore.Compilers) via buildtools:src/Microsoft.DotNet.Build.Tasks/PackageFiles/init-tools.cmd.  BuildTools then copies Microsoft.NETCore.Compilers to tools\\net45\\roslyn for use.  CoreFx imports Microsoft.NETCore.Compilers.props from buildtools using the RoslynVersion / RoslynPackageName properties defined in corefx:dir.props, and Microsoft.NETCore.Compilers.props tell msbuild where to get run csc.exe from. \r\n\r\nWith SharedCompilation enabled, VBCSCompiler is run from tools\\net45\\Roslyn, otherwise csc.exe is used.\r\n\r\n**Linux**\r\nVersion of Roslyn used is determined by the BuildTools:src\\Microsoft.DotNet.Build.Tasks\\PackageFiles\\tools-runtime\\project.json file which gets restored on the host OS to the Tools directory (tools\\csc.exe).  Linux uses the Microsoft.Net.Compilers.netcore package (vs Microsoft.Net.Compilers on Windows).\r\n\r\n-\tThe Microsoft.Net.ToolSetCompilers package has been replaced with the Microsoft.Net.Compilers package.\r\n\r\n-\tThe “UseSharedCompilation” property which toggles some of this functionality, was broken due to a change in the default behavior defined in Microsoft.NetCore.props.  \r\n\r\n/cc @weshaggard @joperezr \r\n","created_at":"2016-08-17T16:55:19Z","updated_at":"2016-08-17T18:51:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d7f443a615f2bbbdf132fe8bdbb6569390b12e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/10928/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/10928/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/10928/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/1ec6349e18b94053acb19652d40505855519ea99","head":{"label":"chcosta:compiler","ref":"compiler","sha":"1ec6349e18b94053acb19652d40505855519ea99","user":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"repo":{"id":38846544,"name":"corefx","full_name":"chcosta/corefx","owner":{"login":"chcosta","id":10092143,"avatar_url":"https://avatars.githubusercontent.com/u/10092143?v=3","gravatar_id":"","url":"https://api.github.com/users/chcosta","html_url":"https://github.com/chcosta","followers_url":"https://api.github.com/users/chcosta/followers","following_url":"https://api.github.com/users/chcosta/following{/other_user}","gists_url":"https://api.github.com/users/chcosta/gists{/gist_id}","starred_url":"https://api.github.com/users/chcosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chcosta/subscriptions","organizations_url":"https://api.github.com/users/chcosta/orgs","repos_url":"https://api.github.com/users/chcosta/repos","events_url":"https://api.github.com/users/chcosta/events{/privacy}","received_events_url":"https://api.github.com/users/chcosta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chcosta/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/chcosta/corefx","forks_url":"https://api.github.com/repos/chcosta/corefx/forks","keys_url":"https://api.github.com/repos/chcosta/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chcosta/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chcosta/corefx/teams","hooks_url":"https://api.github.com/repos/chcosta/corefx/hooks","issue_events_url":"https://api.github.com/repos/chcosta/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/chcosta/corefx/events","assignees_url":"https://api.github.com/repos/chcosta/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/chcosta/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/chcosta/corefx/tags","blobs_url":"https://api.github.com/repos/chcosta/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chcosta/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chcosta/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/chcosta/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chcosta/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/chcosta/corefx/languages","stargazers_url":"https://api.github.com/repos/chcosta/corefx/stargazers","contributors_url":"https://api.github.com/repos/chcosta/corefx/contributors","subscribers_url":"https://api.github.com/repos/chcosta/corefx/subscribers","subscription_url":"https://api.github.com/repos/chcosta/corefx/subscription","commits_url":"https://api.github.com/repos/chcosta/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/chcosta/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/chcosta/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/chcosta/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/chcosta/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/chcosta/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chcosta/corefx/merges","archive_url":"https://api.github.com/repos/chcosta/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chcosta/corefx/downloads","issues_url":"https://api.github.com/repos/chcosta/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/chcosta/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/chcosta/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/chcosta/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chcosta/corefx/labels{/name}","releases_url":"https://api.github.com/repos/chcosta/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/chcosta/corefx/deployments","created_at":"2015-07-09T21:37:18Z","updated_at":"2016-02-17T21:55:35Z","pushed_at":"2016-08-17T16:50:18Z","git_url":"git://github.com/chcosta/corefx.git","ssh_url":"git@github.com:chcosta/corefx.git","clone_url":"https://github.com/chcosta/corefx.git","svn_url":"https://github.com/chcosta/corefx","homepage":"http://dotnet.github.io/core/","size":91910,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1493710b5eaa39d525ec9c069f6cdd1ad9b5c1fb","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2016-08-17T09:17:07Z","pushed_at":"2016-08-17T18:18:10Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/","size":128245,"stargazers_count":10385,"watchers_count":10385,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2550,"mirror_url":null,"open_issues_count":1380,"forks":2550,"open_issues":1380,"watchers":10385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10928"},"html":{"href":"https://github.com/dotnet/corefx/pull/10928"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10928"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/10928/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10928/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/10928/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/1ec6349e18b94053acb19652d40505855519ea99"}}}}
{"actor":{"display_login":"joperezr"}}