{"action":"closed","issue":{"url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/610","repository_url":"https://api.github.com/repos/iea-annex60/modelica-annex60","labels_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/610/labels{/name}","comments_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/610/comments","events_url":"https://api.github.com/repos/iea-annex60/modelica-annex60/issues/610/events","html_url":"https://github.com/iea-annex60/modelica-annex60/issues/610","id":193854759,"number":610,"title":"ThermalZones.ReducedOrder tests","user":{"login":"mwetter","id":1329080,"avatar_url":"https://avatars.githubusercontent.com/u/1329080?v=3","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"mlauster","id":6892690,"avatar_url":"https://avatars.githubusercontent.com/u/6892690?v=3","gravatar_id":"","url":"https://api.github.com/users/mlauster","html_url":"https://github.com/mlauster","followers_url":"https://api.github.com/users/mlauster/followers","following_url":"https://api.github.com/users/mlauster/following{/other_user}","gists_url":"https://api.github.com/users/mlauster/gists{/gist_id}","starred_url":"https://api.github.com/users/mlauster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlauster/subscriptions","organizations_url":"https://api.github.com/users/mlauster/orgs","repos_url":"https://api.github.com/users/mlauster/repos","events_url":"https://api.github.com/users/mlauster/events{/privacy}","received_events_url":"https://api.github.com/users/mlauster/received_events","type":"User","site_admin":false},"assignees":[{"login":"mlauster","id":6892690,"avatar_url":"https://avatars.githubusercontent.com/u/6892690?v=3","gravatar_id":"","url":"https://api.github.com/users/mlauster","html_url":"https://github.com/mlauster","followers_url":"https://api.github.com/users/mlauster/followers","following_url":"https://api.github.com/users/mlauster/following{/other_user}","gists_url":"https://api.github.com/users/mlauster/gists{/gist_id}","starred_url":"https://api.github.com/users/mlauster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlauster/subscriptions","organizations_url":"https://api.github.com/users/mlauster/orgs","repos_url":"https://api.github.com/users/mlauster/repos","events_url":"https://api.github.com/users/mlauster/events{/privacy}","received_events_url":"https://api.github.com/users/mlauster/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2016-12-06T18:55:39Z","updated_at":"2016-12-07T18:07:34Z","closed_at":"2016-12-07T18:07:34Z","body":"@mlauster \r\nThere are two things that need to be cleaned up in `Annex60.ThermalZones.ReducedOrder`\r\n\r\n1. There are various `each` attributes wrong or missing, see below.\r\n2. In the examples in `Annex60.ThermalZones.ReducedOrder.Validation.VDI6007`, the `experiment` annotation is missing. This needs to be added, otherwise they will not be tested by JModelica and OpenModelica.\r\n\r\nHere is an output from JModelica, search for \"each\":\r\n```\r\nIn components:\r\n    eqAirTemp\r\n    eqAirTempVDI\r\n  Assuming 'each' for the modification 'final quantity = \"RadiantEnergyFluenceRate\"'\r\nWarning at line 32, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\EquivalentAirTemperature\\BaseClasses\\PartialVDI6007.mo',\r\nIn components:\r\n    eqAirTemp\r\n    eqAirTempVDI\r\n  Assuming 'each' for the modification 'final unit = \"W/m2\"'\r\nWarning at line 160, column 43, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\Examples\\SimpleRoomFourElements.mo':\r\n  The 'each' keyword should not be applied to a modification of a scalar component: each k = 0\r\nWarning at line 59, column 61, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\RC\\OneElement.mo',\r\nIn component thermalZoneFourElements:\r\n  Assuming 'each' for the modification 'final quantity = \"RadiantEnergyFluenceRate\"'\r\nWarning at line 60, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\RC\\OneElement.mo',\r\nIn component thermalZoneFourElements:\r\n  Assuming 'each' for the modification 'final unit = \"W/m2\"'\r\nWarning at line 9, column 53, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final quantity = \"RadiantEnergyFluenceRate\"'\r\nWarning at line 10, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final unit = \"W/m2\"'\r\nWarning at line 15, column 50, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final quantity = \"RadiantEnergyFluenceRate\"'\r\nWarning at line 16, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final unit = \"W/m2\"'\r\nWarning at line 21, column 53, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final quantity = \"RadiantEnergyFluenceRate\"'\r\nWarning at line 22, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final unit = \"W/m2\"'\r\nWarning at line 27, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final quantity = \"Angle\"'\r\nWarning at line 28, column 27, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final unit = \"rad\"'\r\nWarning at line 29, column 21, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'displayUnit = \"deg\"'\r\nWarning at line 33, column 60, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final quantity = \"RadiantEnergyFluenceRate\"'\r\nWarning at line 34, column 46, in file 'R:\\jmodelica-jenkins\\workspace\\Annex60-Compliance-Simulate\\Annex60\\ThermalZones\\ReducedOrder\\SolarGain\\BaseClasses\\PartialCorrectionG.mo',\r\nIn component corGDouPan:\r\n  Assuming 'each' for the modification 'final unit = \"W/m2\"'\r\n```"}}
{"actor":{"display_login":"mwetter"}}