{"action":"created","issue":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/7165","repository_url":"https://api.github.com/repos/fastlane/fastlane","labels_url":"https://api.github.com/repos/fastlane/fastlane/issues/7165/labels{/name}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/7165/comments","events_url":"https://api.github.com/repos/fastlane/fastlane/issues/7165/events","html_url":"https://github.com/fastlane/fastlane/issues/7165","id":191556171,"number":7165,"title":"Deliver needs to be updated to support app_version.upload_screenshot!(…, is_messages)","user":{"login":"carlosefonseca","id":14120,"avatar_url":"https://avatars.githubusercontent.com/u/14120?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosefonseca","html_url":"https://github.com/carlosefonseca","followers_url":"https://api.github.com/users/carlosefonseca/followers","following_url":"https://api.github.com/users/carlosefonseca/following{/other_user}","gists_url":"https://api.github.com/users/carlosefonseca/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosefonseca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosefonseca/subscriptions","organizations_url":"https://api.github.com/users/carlosefonseca/orgs","repos_url":"https://api.github.com/users/carlosefonseca/repos","events_url":"https://api.github.com/users/carlosefonseca/events{/privacy}","received_events_url":"https://api.github.com/users/carlosefonseca/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-24T16:13:21Z","updated_at":"2016-11-24T21:58:50Z","closed_at":null,"body":"### New Issue Checklist\r\n\r\n- [x] Updated fastlane to the latest version\r\n- [x] I have read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n\r\n### Issue Description\r\nJust updated spaceship to 0.38 and now I can't upload screenshots using deliver.\r\n\r\nThe error is a missing parameter on the method\r\n\r\n```\r\nArgumentError: wrong number of arguments (given 4, expected 5)\r\nfrom /Users/carlos/.gems/gems/spaceship-0.38.0/lib/spaceship/tunes/app_version.rb:383:in `upload_screenshot!'\r\n```\r\n\r\nhttps://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/tunes/app_version.rb#L383\r\nwhich is:\r\n`def upload_screenshot!(screenshot_path, sort_order, language, device, is_messages)`\r\n\r\nI'm not getting a backtrace for some reason but my code is calling \r\n`Deliver::UploadScreenshots.new.upload(options, screenshots)`\r\nand that isn't yet updated to support `is_messages`:\r\nhttps://github.com/fastlane/fastlane/blob/master/deliver/lib/deliver/upload_screenshots.rb#L20\r\n`v.upload_screenshot!(nil, index, t.language, t.device_type)`\r\n\r\n### Environment\r\n\r\nPlease run `fastlane env` and copy the output below. This will help us help you :+1:\r\nIf you used `--capture_output` option please remove this block - as it is already included there.\r\n\r\n<details><summary>✅ fastlane environment ✅</summary>\r\n\r\n### Stack\r\n\r\n| Key                 | Value                                       |\r\n| ------------------- | ------------------------------------------- |\r\n| OS                  | 10.12.1                                     |\r\n| Ruby                | 2.3.1                                       |\r\n| Bundler?            | false                                       |\r\n| Git                 | git version 2.9.3 (Apple Git-75)            |\r\n| Installation Source | /Users/carlos/.gems/bin/fastlane            |\r\n| Host                | Mac OS X 10.12.1 (16B2555)                  |\r\n| Ruby Lib Dir        | /usr/local/Cellar/ruby/2.3.1_2/lib          |\r\n| OpenSSL Version     | OpenSSL 1.0.2j  26 Sep 2016                 |\r\n| Is contained        | false                                       |\r\n| Xcode Path          | /Applications/Xcode.app/Contents/Developer/ |\r\n| Xcode Version       | 8.1                                         |\r\n\r\n\r\n### System Locale\r\n\r\n| Variable | Value       |   |\r\n| -------- | ----------- | - |\r\n| LANG     | en_US.UTF-8 | ✅ |\r\n| LC_ALL   |             |   |\r\n| LANGUAGE |             |   |\r\n\r\n\r\n### fastlane files:\r\n\r\n<details><summary>`./fastlane/Fastfile`</summary>\r\n\r\n```ruby\r\n# Customise this file, documentation can be found here:\r\n# https://github.com/fastlane/fastlane/tree/master/docs\r\n# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md\r\n# can also be listed using the `fastlane actions` command\r\n\r\n# Change the syntax highlighting to Ruby\r\n# All lines starting with a # are ignored when running `fastlane`\r\n\r\n# By default, fastlane will send which actions are used\r\n# No personal data is shared, more information on https://github.com/fastlane/enhancer\r\n# Uncomment the following line to opt out\r\n# opt_out_usage\r\n\r\n# If you want to automatically update fastlane if a new version is available:\r\n# update_fastlane unless Helper.is_ci?\r\n\r\n# This is the minimum version number required.\r\n# Update this, if you use features of a newer version\r\nfastlane_version \"1.67.0\"\r\n\r\ndefault_platform :android\r\n\r\nplatform :android do\r\n  before_all do\r\n    ENV[\"SLACK_URL\"] = \"https://hooks.slack.com/services/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\"\r\n    ENV[\"MANIFEST\"] = \"WDAA/src/main/AndroidManifest.xml\"\r\n  end\r\n\r\n  # desc \"Runs all the tests\"\r\n  # lane :test do\r\n  #   gradle(task: \"test\")\r\n  # end\r\n\r\n\r\n\r\n  desc \"Does the stuff before a deploy.\"\r\n  desc \"Generates a changelog, bumps the build number, commits the bump.\"\r\n  lane :predeploy do\r\n    # raise \"Latest Live Version == Current Version. -> Use `patch_bump`, `minor_bump` or `major_bump` to change the version.\" if latest_live_version == get_version_number\r\n    gitchangelog\r\n    git_add(path: \"fastlane/changelog.txt\")\r\n\r\n    code = bump\r\n\r\n    git_add(path:ENV[\"MANIFEST\"])\r\n    git_add(path:\"gradle.properties\")\r\n    git_add(path:\"Gemfile.lock\")\r\n    \r\n    log = Actions.lane_context[SharedValues::FL_CHANGELOG].gsub(/'/, \"'\\\\\\\\''\")\r\n    git_commit(path: [], message: \"Build #{code}\\n\\n#{log}\".strip)\r\n\r\n    add_git_tag(tag: \"builds/#{code}\")\r\n  end\r\n\r\n  desc \"Automatically increment version code\"\r\n  lane :bump do\r\n    (n, c) = android_manifest_version(android_manifest: ENV[\"MANIFEST\"], bump: true)\r\n    sh \"perl -i -pe 's/^(sourceVersion)=\\\\d+$/\\\\1=#{c}/g' ../gradle.properties\"\r\n    c\r\n  end\r\n\r\n  desc \"Automatically increment major version number (1.2.3 > 2.0.0)\"\r\n  lane :major_bump do\r\n    android_manifest_version(android_manifest: ENV[\"MANIFEST\"], major_bump: true)\r\n  end\r\n\r\n  desc \"Automatically increment minor version number (1.2.3 > 1.3.0)\"\r\n  lane :minor_bump do\r\n    android_manifest_version(android_manifest: ENV[\"MANIFEST\"], minor_bump: true)\r\n  end\r\n\r\n  desc \"Automatically increment patch version number  (1.2.3 > 1.2.4)\"\r\n  lane :patch_bump do\r\n    android_manifest_version(android_manifest: ENV[\"MANIFEST\"], patch_bump: true)\r\n  end\r\n\r\n\r\n  lane :guestu_major_bump do\r\n    sh \"perl -p00e 's/(GuestU {[\\s\\S]+versionName \\\")(\\d+)[\\d.]+/$1.($2+1).\\\".0.0\\\"/e' WDAA/build.gradle\"\r\n  end\r\n\r\n  lane :guestu_minor_bump do\r\n    sh \"perl -p00e 's/(GuestU {[\\s\\S]+versionName \\\"\\d+\\.)(\\d+)\\.\\d+/$1.($2+1).\\\".0\\\"/e' WDAA/build.gradle\"\r\n  end\r\n\r\n  lane :guestu_patch_bump do\r\n    sh \"perl -p00e 's/(GuestU {[\\s\\S]+versionName \\\"\\d+\\.\\d+\\.)(\\d+)/$1.($2+1)/e' WDAA/build.gradle\"\r\n  end\r\n\r\n\r\n  desc \"Generates a changelog file with all the commits since the last git tag and opens on an editor\"\r\n  lane :gitchangelog do\r\n    notes = changelog_from_git_commits(\r\n      pretty: \"%s\\n%b\\n\", # Optional, lets you provide a custom format to apply to each commit when generating the changelog text\r\n      # tag_match_pattern: nil, # Optional, lets you search for a tag name that matches a glob(7) pattern\r\n      # match_lightweight_tag: false, # Optional, lets you ignore lightweight (non-annotated) tags when searching for the last tag\r\n      merge_commit_filtering: \"exclude_merges\" # Optional, lets you filter out merge commits\r\n    )\r\n    puts File.write('changelog.txt', notes)\r\n    if ENV[\"EDITOR\"].start_with? \"subl\"\r\n      sh \"$EDITOR changelog.txt\" \r\n    else\r\n      sh \"open -W -n changelog.txt\"\r\n    end\r\n    Actions.lane_context[SharedValues::FL_CHANGELOG] = File.read('changelog.txt')\r\n  end\r\n\r\n\r\n\r\n\r\n  desc \"Resets and badges all icons\"\r\n  lane :badge_all do\r\n    unbadge\r\n    version, build = android_manifest_version(android_manifest: ENV[\"MANIFEST\"])\r\n    [\"B2B\", \"B2B_QA\", \"B2C\", \"B2C_QA\"].each { |f| badger(flavor:f, version:version, build:build) }\r\n  end\r\n\r\n\r\n\r\n\r\n  desc \"Badges all icons of a flavor, with a build number\"\r\n  lane :badger do |options|\r\n    flavor = options[:flavor]\r\n    dir = flavor\r\n    flavor += \"_PROD\" unless flavor.include? \"QA\"\r\n\r\n    version = options[:version]\r\n    build = options[:build]\r\n\r\n    puts \"#{flavor} [#{dir}] - #{version} (#{build})\"\r\n\r\n    if false\r\n      badge(shield:\"#{flavor}-_#{build}-995533\",\r\n            no_badge: true,\r\n            glob:\"/**/src/#{dir}/**/mipmap-x*/*.{png,PNG}\",\r\n            shield_no_resize: false,\r\n            shield_gravity: \"South\")\r\n\r\n      badge(shield:\"#{flavor}-#{build}-995533\",\r\n            no_badge: true,\r\n            glob:\"/**/src/#{dir}/**/mipmap-[mh]*/*.{png,PNG}\",\r\n            shield_no_resize: false,\r\n            shield_gravity: \"South\")\r\n    else\r\n      badge(shield:\"#{flavor}-#{build}-995533\",\r\n            no_badge: true,\r\n            glob:\"/**/src/#{dir}/**/mipmap*/*.{png,PNG}\",\r\n            shield_no_resize: false,\r\n            shield_gravity: \"South\")\r\n    end\r\n    # TO DO: Play around with\r\n    # /Applications/Inkscape.app/Contents/Resources/bin/inkscape -z -e badge.png -w 1024 badge.svg\r\n  end\r\n\r\n  desc \"Resets all icons\"\r\n  lane :unbadge do\r\n    last_dir = Dir.pwd\r\n    Dir.chdir(\"..\")\r\n    x = [\"B2B\", \"B2B_QA\", \"B2C\", \"B2C_QA\"].map { |f| Dir.glob(\"*/src/#{f}/**/mipmap*/*\") }.flatten\r\n    Dir.chdir(last_dir)\r\n    reset_git_repo(force: true, files: x) unless x.empty?\r\n  end\r\n\r\n\r\n\r\n\r\n  # desc \"Deploy a new version to the Google Play\"\r\n  # lane :deploy do\r\n  #   gradle(task: \"assembleRelease\")\r\n  #   supply\r\n  # end\r\n\r\n\r\n\r\n\r\n\r\n  desc \"Build all versions and upload to Crashlytics' Beta and post on Slack\"\r\n  lane :beta do\r\n    # Delete old APK's\r\n    sh \"find .. -iname \\\"*.apk\\\" -exec rm {} \\\\;\"\r\n\r\n    # flavors =   [       \"B2B\", \"B2C_QA\", \"B2B_QA\", \"Clarice\", \"GuestU\"]\r\n    flavors = [\"B2C\", \"B2B\", \"B2C_QA\", \"B2B_QA\", \"Clarice\", \"GuestU\"]\r\n\r\n    # Assemble all flavors at once, slack if error\r\n    assemble = flavors.map { |f| \"assemble#{f}Release\" }.join(\" \")\r\n    gradled(task:assemble, quiet:true, slack_error:true)\r\n    notification(subtitle:\"Beta\", message:\"Assemble ✅\") unless Helper.is_ci?\r\n\r\n    # Upload each build, try each one twice, slack if error\r\n    upload = flavors.map { |f| \"crashlyticsUploadDistribution#{f}Release\" }\r\n    upload.each do |f|\r\n      gradled(task:f, slack_error:true, tries:3)\r\n      notification(subtitle:\"Beta\", message:\"#{f} uploaded ✅\") unless Helper.is_ci?\r\n    end\r\n\r\n    # slack success\r\n    name, code = android_manifest_version(android_manifest: ENV[\"MANIFEST\"])\r\n\r\n    f = flavors.join(\", \")\r\n    slack(\r\n      message: \"#{f} were successfully uploaded to Crashlytics' Beta.\",\r\n      channel: \"#android\",\r\n      default_payloads: [],\r\n      payload: {\r\n        'Version' => \"#{name} (#{code})\",\r\n        'What\\'s New' => txt = File.read('changelog.txt')\r\n    })\r\n    notification(subtitle:\"Beta\", message:\"🚀 Finished ✅\") unless Helper.is_ci?\r\n  end\r\n\r\n\r\n\r\n\r\n  desc \"Compiles and installs flavors B2C, B2B, B2C_QA, B2B_QA\"\r\n  lane :install do |options|\r\n    buildType = options[:buildType] || \"Debug\"\r\n    flvs = [\"B2C\", \"B2B\", \"B2C_QA\", \"B2B_QA\"].map { |f| \"install#{f}#{buildType}\" }.join(\" \")\r\n    gradle(task:flvs)\r\n  end\r\n\r\n\r\n\r\n  desc \"Uninstalls all flavors, via gradle.\"\r\n  lane :uninstall do\r\n    gradle(task:\"uninstallAll\")\r\n  end\r\n\r\n\r\n\r\n\r\n\r\n\r\n  desc \"Runs a 'gradlew --daemon' command. Params and default values: task, quiet:false, tries:1, slack_error:false\"\r\n  lane :gradled do |options|\r\n    tasks = options[:task]\r\n    quiet = (options[:quiet] || false) ? \"-q\" : \"\"\r\n    tries = options[:tries] || 1\r\n    begin\r\n      sh \"cd .. && ./gradlew --daemon #{quiet} #{tasks}\"\r\n    rescue Exception => e\r\n      tries -= 1\r\n      if tries == 0\r\n        slack_error(task:tasks, error:e) if options[:slack_error]\r\n        raise e\r\n      else\r\n        notification(subtitle:task, message:\"🔁 Retrying...\") unless Helper.is_ci?\r\n        retry\r\n      end\r\n    end\r\n  end\r\n\r\n\r\n\r\n\r\n  desc \"Default slack message from an exception. Params: task, error\"\r\n  private_lane :slack_error do |options|\r\n    task = options[:task]\r\n    e = options[:error]\r\n    \r\n    notification(subtitle:task, message:\"❌ Error!\") unless Helper.is_ci?\r\n    \r\n    log_split = e.to_s.strip.split(/\\n/)\r\n    log = (log_split.length > 20 ? log_split[-20..-1] : log_split).join(\"\\n\")\r\n\r\n    begin\r\n      slack(\r\n        message: \":warning: Error during :android: #{task}! :warning:\",\r\n        channel: \"@carlos\",\r\n        success: false,\r\n        default_payloads: [],\r\n        payload: {\r\n          'Tail of log' => log\r\n        }\r\n      )\r\n    rescue Exception => e\r\n      puts \"Can't slack!\"      \r\n    end\r\n  end\r\n\r\n\r\n  desc \"Moves the latest tag to the latest commit.\"\r\n  desc \"Use if a build failed and you fixed something.\"\r\n  lane :retag do\r\n    tag = sh \"git describe --tags `git rev-list --tags --max-count=1`\"\r\n    sh \"git tag --force #{tag}\"\r\n    sh \"git push --tags --force\"\r\n  end\r\n\r\n\r\n  # You can define as many lanes as you want\r\n\r\n  after_all do |lane|\r\n    # This block is called, only if the executed lane was successful\r\n    \r\n    # slack(\r\n    #   message: \"Successfully deployed new App Update.\"\r\n    # )\r\n  end\r\n\r\n  error do |lane, exception|\r\n    # slack(\r\n    #   message: exception.message,\r\n    #   success: false\r\n    # )\r\n  end\r\nend\r\n\r\n\r\n# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/docs/Platforms.md\r\n# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md\r\n```\r\n</details>\r\n\r\n**No Appfile found**\r\n\r\n\r\n### fastlane gems\r\n\r\n| Gem                 | Version | Update-Status |\r\n| ------------------- | ------- | ------------- |\r\n| credentials_manager | 0.16.2  | ✅ Up-To-Date  |\r\n| spaceship           | 0.38.0  | ✅ Up-To-Date  |\r\n| fastlane_core       | 0.57.1  | ✅ Up-To-Date  |\r\n| deliver             | 1.15.1  | ✅ Up-To-Date  |\r\n| snapshot            | 1.16.4  | ✅ Up-To-Date  |\r\n| frameit             | 3.0.0   | ✅ Up-To-Date  |\r\n| pem                 | 1.4.0   | ✅ Up-To-Date  |\r\n| cert                | 1.4.4   | ✅ Up-To-Date  |\r\n| sigh                | 1.11.2  | ✅ Up-To-Date  |\r\n| produce             | 1.3.0   | ✅ Up-To-Date  |\r\n| gym                 | 1.12.1  | ✅ Up-To-Date  |\r\n| pilot               | 1.12.1  | ✅ Up-To-Date  |\r\n| scan                | 0.14.2  | ✅ Up-To-Date  |\r\n| supply              | 0.7.1   | ✅ Up-To-Date  |\r\n| match               | 0.11.0  | ✅ Up-To-Date  |\r\n| screengrab          | 0.5.6   | ✅ Up-To-Date  |\r\n| fastlane            | 1.110.0 | ✅ Up-To-Date  |\r\n\r\n\r\n### Loaded fastlane plugins:\r\n\r\n**No plugins Loaded**\r\n\r\n\r\n<details><summary><b>Loaded gems</b></summary>\r\n\r\n| Gem                       | Version      |\r\n| ------------------------- | ------------ |\r\n| did_you_mean              | 1.0.0        |\r\n| highline                  | 1.7.8        |\r\n| commander                 | 4.4.0        |\r\n| terminal-table            | 1.4.5        |\r\n| json                      | 1.8.3        |\r\n| multipart-post            | 2.0.0        |\r\n| faraday                   | 0.10.0       |\r\n| faraday_middleware        | 0.10.1       |\r\n| dotenv                    | 2.1.1        |\r\n| net-ssh                   | 3.2.0        |\r\n| net-sftp                  | 2.1.2        |\r\n| plist                     | 3.2.0        |\r\n| rubyzip                   | 1.1.7        |\r\n| security                  | 0.1.3        |\r\n| krausefx-shenzhen         | 0.14.11      |\r\n| slack-notifier            | 1.5.1        |\r\n| i18n                      | 0.7.0        |\r\n| thread_safe               | 0.3.5        |\r\n| tzinfo                    | 1.2.2        |\r\n| minitest                  | 5.9.1        |\r\n| activesupport             | 4.2.7.1      |\r\n| CFPropertyList            | 2.3.3        |\r\n| claide                    | 1.0.1        |\r\n| colored                   | 1.2          |\r\n| nanaimo                   | 0.2.2        |\r\n| xcodeproj                 | 1.4.1        |\r\n| rouge                     | 1.11.1       |\r\n| xcpretty                  | 0.2.4        |\r\n| terminal-notifier         | 1.7.1        |\r\n| public_suffix             | 2.0.4        |\r\n| addressable               | 2.5.0        |\r\n| credentials_manager       | 0.16.2       |\r\n| multi_xml                 | 0.5.5        |\r\n| unf_ext                   | 0.0.7.2      |\r\n| unf                       | 0.1.4        |\r\n| domain_name               | 0.5.20161021 |\r\n| http-cookie               | 1.0.3        |\r\n| faraday-cookie_jar        | 0.0.6        |\r\n| fastimage                 | 1.6.8        |\r\n| xcode-install             | 2.0.9        |\r\n| word_wrap                 | 1.0.0        |\r\n| multi_json                | 1.12.1       |\r\n| babosa                    | 1.0.2        |\r\n| excon                     | 0.54.0       |\r\n| gh_inspector              | 1.0.2        |\r\n| fastlane_core             | 0.57.1       |\r\n| bundler                   | 1.13.5       |\r\n| mini_magick               | 4.5.1        |\r\n| xcpretty-travis-formatter | 0.0.4        |\r\n| uber                      | 0.0.15       |\r\n| representable             | 2.3.0        |\r\n| retriable                 | 2.1.0        |\r\n| mime-types-data           | 3.2016.0521  |\r\n| mime-types                | 3.1          |\r\n| hurley                    | 0.2          |\r\n| little-plugger            | 1.1.4        |\r\n| logging                   | 2.1.0        |\r\n| jwt                       | 1.5.6        |\r\n| memoist                   | 0.15.0       |\r\n| os                        | 0.9.6        |\r\n| signet                    | 0.7.3        |\r\n| googleauth                | 0.5.1        |\r\n| httpclient                | 2.8.2.4      |\r\n| google-api-client         | 0.9.20       |\r\n| io-console                | 0.4.5        |\r\n</details>\r\n\r\n\r\n*generated on:* **2016-11-24**\r\n</details>\r\n"},"comment":{"url":"https://api.github.com/repos/fastlane/fastlane/issues/comments/262849180","html_url":"https://github.com/fastlane/fastlane/issues/7165#issuecomment-262849180","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/7165","id":262849180,"user":{"login":"getreup","id":5514818,"avatar_url":"https://avatars.githubusercontent.com/u/5514818?v=3","gravatar_id":"","url":"https://api.github.com/users/getreup","html_url":"https://github.com/getreup","followers_url":"https://api.github.com/users/getreup/followers","following_url":"https://api.github.com/users/getreup/following{/other_user}","gists_url":"https://api.github.com/users/getreup/gists{/gist_id}","starred_url":"https://api.github.com/users/getreup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getreup/subscriptions","organizations_url":"https://api.github.com/users/getreup/orgs","repos_url":"https://api.github.com/users/getreup/repos","events_url":"https://api.github.com/users/getreup/events{/privacy}","received_events_url":"https://api.github.com/users/getreup/received_events","type":"User","site_admin":false},"created_at":"2016-11-24T21:58:50Z","updated_at":"2016-11-24T21:58:50Z","body":"Thanks for tackling this so quickly guys.\r\n\r\nIn the mean time, what would be a work around to release today?"}}
{"actor":{"display_login":"getreup"}}