{"action":"created","comment":{"url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/comments/90972149","pull_request_review_id":11485496,"id":90972149,"diff_hunk":"@@ -2,14 +2,36 @@\n \n var websocket = require('websocket-stream')\n var _URL = require('url')\n-var wssProperties = [\n-  'rejectUnauthorized',\n-  'ca',\n-  'cert',\n-  'key',\n-  'pfx',\n-  'passphrase'\n-]\n+var mqttProperties = [\n+'keepalive',\n+'reschedulePings',\n+'clientId',\n+'protocolId',\n+'protocolVersion',\n+'clean',\n+'reconnectPeriod',\n+'connectTimeout',\n+'username',\n+'password',\n+'incomingStore',\n+'outgoingStore',\n+'queueQoSZero',\n+'will',\n+];\n+\n+var urlKeys = [\n+'href',\n+'slashes',\n+'path',\n+'protocol',\n+'auth',\n+'hostname',\n+'port',\n+'host',\n+'pathname',\n+'search',\n+'query',\n+'hash' ];","path":"lib/connect/ws.js","position":41,"original_position":41,"commit_id":"9a4825813e293fd164a5b245d06a271ff3d82158","original_commit_id":"9a4825813e293fd164a5b245d06a271ff3d82158","user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars.githubusercontent.com/u/52195?v=3","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"body":"Ok, this is the first, correct?","created_at":"2016-12-05T22:38:05Z","updated_at":"2016-12-05T22:38:05Z","html_url":"https://github.com/mqttjs/MQTT.js/pull/511#discussion_r90972149","pull_request_url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511","_links":{"self":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/comments/90972149"},"html":{"href":"https://github.com/mqttjs/MQTT.js/pull/511#discussion_r90972149"},"pull_request":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511"}}},"pull_request":{"url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511","id":96621838,"html_url":"https://github.com/mqttjs/MQTT.js/pull/511","diff_url":"https://github.com/mqttjs/MQTT.js/pull/511.diff","patch_url":"https://github.com/mqttjs/MQTT.js/pull/511.patch","issue_url":"https://api.github.com/repos/mqttjs/MQTT.js/issues/511","number":511,"state":"open","locked":false,"title":"manage ws(s) options (proxy agent e.g.)","user":{"login":"Manu3756","id":14175088,"avatar_url":"https://avatars.githubusercontent.com/u/14175088?v=3","gravatar_id":"","url":"https://api.github.com/users/Manu3756","html_url":"https://github.com/Manu3756","followers_url":"https://api.github.com/users/Manu3756/followers","following_url":"https://api.github.com/users/Manu3756/following{/other_user}","gists_url":"https://api.github.com/users/Manu3756/gists{/gist_id}","starred_url":"https://api.github.com/users/Manu3756/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manu3756/subscriptions","organizations_url":"https://api.github.com/users/Manu3756/orgs","repos_url":"https://api.github.com/users/Manu3756/repos","events_url":"https://api.github.com/users/Manu3756/events{/privacy}","received_events_url":"https://api.github.com/users/Manu3756/received_events","type":"User","site_admin":false},"body":"feedback welcome\r\nbadly tested","created_at":"2016-12-05T22:23:38Z","updated_at":"2016-12-05T22:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2008d0d343cdde8b1698b99a002e46263935ab1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511/commits","review_comments_url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511/comments","review_comment_url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mqttjs/MQTT.js/issues/511/comments","statuses_url":"https://api.github.com/repos/mqttjs/MQTT.js/statuses/9a4825813e293fd164a5b245d06a271ff3d82158","head":{"label":"Manu3756:fix-452","ref":"fix-452","sha":"9a4825813e293fd164a5b245d06a271ff3d82158","user":{"login":"Manu3756","id":14175088,"avatar_url":"https://avatars.githubusercontent.com/u/14175088?v=3","gravatar_id":"","url":"https://api.github.com/users/Manu3756","html_url":"https://github.com/Manu3756","followers_url":"https://api.github.com/users/Manu3756/followers","following_url":"https://api.github.com/users/Manu3756/following{/other_user}","gists_url":"https://api.github.com/users/Manu3756/gists{/gist_id}","starred_url":"https://api.github.com/users/Manu3756/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manu3756/subscriptions","organizations_url":"https://api.github.com/users/Manu3756/orgs","repos_url":"https://api.github.com/users/Manu3756/repos","events_url":"https://api.github.com/users/Manu3756/events{/privacy}","received_events_url":"https://api.github.com/users/Manu3756/received_events","type":"User","site_admin":false},"repo":{"id":75663951,"name":"MQTT.js","full_name":"Manu3756/MQTT.js","owner":{"login":"Manu3756","id":14175088,"avatar_url":"https://avatars.githubusercontent.com/u/14175088?v=3","gravatar_id":"","url":"https://api.github.com/users/Manu3756","html_url":"https://github.com/Manu3756","followers_url":"https://api.github.com/users/Manu3756/followers","following_url":"https://api.github.com/users/Manu3756/following{/other_user}","gists_url":"https://api.github.com/users/Manu3756/gists{/gist_id}","starred_url":"https://api.github.com/users/Manu3756/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manu3756/subscriptions","organizations_url":"https://api.github.com/users/Manu3756/orgs","repos_url":"https://api.github.com/users/Manu3756/repos","events_url":"https://api.github.com/users/Manu3756/events{/privacy}","received_events_url":"https://api.github.com/users/Manu3756/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Manu3756/MQTT.js","description":"The MQTT client for Node.js and the browser","fork":true,"url":"https://api.github.com/repos/Manu3756/MQTT.js","forks_url":"https://api.github.com/repos/Manu3756/MQTT.js/forks","keys_url":"https://api.github.com/repos/Manu3756/MQTT.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Manu3756/MQTT.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Manu3756/MQTT.js/teams","hooks_url":"https://api.github.com/repos/Manu3756/MQTT.js/hooks","issue_events_url":"https://api.github.com/repos/Manu3756/MQTT.js/issues/events{/number}","events_url":"https://api.github.com/repos/Manu3756/MQTT.js/events","assignees_url":"https://api.github.com/repos/Manu3756/MQTT.js/assignees{/user}","branches_url":"https://api.github.com/repos/Manu3756/MQTT.js/branches{/branch}","tags_url":"https://api.github.com/repos/Manu3756/MQTT.js/tags","blobs_url":"https://api.github.com/repos/Manu3756/MQTT.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Manu3756/MQTT.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Manu3756/MQTT.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Manu3756/MQTT.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Manu3756/MQTT.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Manu3756/MQTT.js/languages","stargazers_url":"https://api.github.com/repos/Manu3756/MQTT.js/stargazers","contributors_url":"https://api.github.com/repos/Manu3756/MQTT.js/contributors","subscribers_url":"https://api.github.com/repos/Manu3756/MQTT.js/subscribers","subscription_url":"https://api.github.com/repos/Manu3756/MQTT.js/subscription","commits_url":"https://api.github.com/repos/Manu3756/MQTT.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Manu3756/MQTT.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Manu3756/MQTT.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Manu3756/MQTT.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Manu3756/MQTT.js/contents/{+path}","compare_url":"https://api.github.com/repos/Manu3756/MQTT.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Manu3756/MQTT.js/merges","archive_url":"https://api.github.com/repos/Manu3756/MQTT.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Manu3756/MQTT.js/downloads","issues_url":"https://api.github.com/repos/Manu3756/MQTT.js/issues{/number}","pulls_url":"https://api.github.com/repos/Manu3756/MQTT.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Manu3756/MQTT.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Manu3756/MQTT.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Manu3756/MQTT.js/labels{/name}","releases_url":"https://api.github.com/repos/Manu3756/MQTT.js/releases{/id}","deployments_url":"https://api.github.com/repos/Manu3756/MQTT.js/deployments","created_at":"2016-12-05T20:35:32Z","updated_at":"2016-12-05T20:35:33Z","pushed_at":"2016-12-05T22:20:56Z","git_url":"git://github.com/Manu3756/MQTT.js.git","ssh_url":"git@github.com:Manu3756/MQTT.js.git","clone_url":"https://github.com/Manu3756/MQTT.js.git","svn_url":"https://github.com/Manu3756/MQTT.js","homepage":"","size":1142,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mqttjs:master","ref":"master","sha":"7c328bef54a8e3f593c40669871b4f483b6416db","user":{"login":"mqttjs","id":10424911,"avatar_url":"https://avatars.githubusercontent.com/u/10424911?v=3","gravatar_id":"","url":"https://api.github.com/users/mqttjs","html_url":"https://github.com/mqttjs","followers_url":"https://api.github.com/users/mqttjs/followers","following_url":"https://api.github.com/users/mqttjs/following{/other_user}","gists_url":"https://api.github.com/users/mqttjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mqttjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqttjs/subscriptions","organizations_url":"https://api.github.com/users/mqttjs/orgs","repos_url":"https://api.github.com/users/mqttjs/repos","events_url":"https://api.github.com/users/mqttjs/events{/privacy}","received_events_url":"https://api.github.com/users/mqttjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1569980,"name":"MQTT.js","full_name":"mqttjs/MQTT.js","owner":{"login":"mqttjs","id":10424911,"avatar_url":"https://avatars.githubusercontent.com/u/10424911?v=3","gravatar_id":"","url":"https://api.github.com/users/mqttjs","html_url":"https://github.com/mqttjs","followers_url":"https://api.github.com/users/mqttjs/followers","following_url":"https://api.github.com/users/mqttjs/following{/other_user}","gists_url":"https://api.github.com/users/mqttjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mqttjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqttjs/subscriptions","organizations_url":"https://api.github.com/users/mqttjs/orgs","repos_url":"https://api.github.com/users/mqttjs/repos","events_url":"https://api.github.com/users/mqttjs/events{/privacy}","received_events_url":"https://api.github.com/users/mqttjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mqttjs/MQTT.js","description":"The MQTT client for Node.js and the browser","fork":false,"url":"https://api.github.com/repos/mqttjs/MQTT.js","forks_url":"https://api.github.com/repos/mqttjs/MQTT.js/forks","keys_url":"https://api.github.com/repos/mqttjs/MQTT.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqttjs/MQTT.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqttjs/MQTT.js/teams","hooks_url":"https://api.github.com/repos/mqttjs/MQTT.js/hooks","issue_events_url":"https://api.github.com/repos/mqttjs/MQTT.js/issues/events{/number}","events_url":"https://api.github.com/repos/mqttjs/MQTT.js/events","assignees_url":"https://api.github.com/repos/mqttjs/MQTT.js/assignees{/user}","branches_url":"https://api.github.com/repos/mqttjs/MQTT.js/branches{/branch}","tags_url":"https://api.github.com/repos/mqttjs/MQTT.js/tags","blobs_url":"https://api.github.com/repos/mqttjs/MQTT.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqttjs/MQTT.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqttjs/MQTT.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqttjs/MQTT.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqttjs/MQTT.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mqttjs/MQTT.js/languages","stargazers_url":"https://api.github.com/repos/mqttjs/MQTT.js/stargazers","contributors_url":"https://api.github.com/repos/mqttjs/MQTT.js/contributors","subscribers_url":"https://api.github.com/repos/mqttjs/MQTT.js/subscribers","subscription_url":"https://api.github.com/repos/mqttjs/MQTT.js/subscription","commits_url":"https://api.github.com/repos/mqttjs/MQTT.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqttjs/MQTT.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqttjs/MQTT.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqttjs/MQTT.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqttjs/MQTT.js/contents/{+path}","compare_url":"https://api.github.com/repos/mqttjs/MQTT.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqttjs/MQTT.js/merges","archive_url":"https://api.github.com/repos/mqttjs/MQTT.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqttjs/MQTT.js/downloads","issues_url":"https://api.github.com/repos/mqttjs/MQTT.js/issues{/number}","pulls_url":"https://api.github.com/repos/mqttjs/MQTT.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mqttjs/MQTT.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mqttjs/MQTT.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqttjs/MQTT.js/labels{/name}","releases_url":"https://api.github.com/repos/mqttjs/MQTT.js/releases{/id}","deployments_url":"https://api.github.com/repos/mqttjs/MQTT.js/deployments","created_at":"2011-04-05T00:33:23Z","updated_at":"2016-12-05T12:53:00Z","pushed_at":"2016-12-05T22:23:38Z","git_url":"git://github.com/mqttjs/MQTT.js.git","ssh_url":"git@github.com:mqttjs/MQTT.js.git","clone_url":"https://github.com/mqttjs/MQTT.js.git","svn_url":"https://github.com/mqttjs/MQTT.js","homepage":"","size":1550,"stargazers_count":1797,"watchers_count":1797,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":379,"mirror_url":null,"open_issues_count":17,"forks":379,"open_issues":17,"watchers":1797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511"},"html":{"href":"https://github.com/mqttjs/MQTT.js/pull/511"},"issue":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/issues/511"},"comments":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/mqttjs/MQTT.js/statuses/9a4825813e293fd164a5b245d06a271ff3d82158"}}}}
{"actor":{"display_login":"mcollina"}}