{"action":"created","issue":{"url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/issues/120","repository_url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema","labels_url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/issues/120/comments","events_url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/issues/120/events","html_url":"https://github.com/FasterXML/jackson-module-jsonSchema/pull/120","id":184965069,"number":120,"title":"Altered ObjectSchema to make \"dependencies\" an object instead of list.","user":{"login":"seanstaley","id":1566268,"avatar_url":"https://avatars.githubusercontent.com/u/1566268?v=3","gravatar_id":"","url":"https://api.github.com/users/seanstaley","html_url":"https://github.com/seanstaley","followers_url":"https://api.github.com/users/seanstaley/followers","following_url":"https://api.github.com/users/seanstaley/following{/other_user}","gists_url":"https://api.github.com/users/seanstaley/gists{/gist_id}","starred_url":"https://api.github.com/users/seanstaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanstaley/subscriptions","organizations_url":"https://api.github.com/users/seanstaley/orgs","repos_url":"https://api.github.com/users/seanstaley/repos","events_url":"https://api.github.com/users/seanstaley/events{/privacy}","received_events_url":"https://api.github.com/users/seanstaley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-24T21:53:44Z","updated_at":"2016-10-24T22:38:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/pulls/120","html_url":"https://github.com/FasterXML/jackson-module-jsonSchema/pull/120","diff_url":"https://github.com/FasterXML/jackson-module-jsonSchema/pull/120.diff","patch_url":"https://github.com/FasterXML/jackson-module-jsonSchema/pull/120.patch"},"body":"In the JSON schema the dependencies variable is declared an object instead of a collection or array of items. Therefore, when the JSON schema is generated for an object it is invalid because dependencies is a list.\r\n```javascript\r\n{\r\n  ...,\r\n  \"dependencies\": [],\r\n  ...\r\n}\r\n``` \r\n\r\nThis should be instead:\r\n```javascript\r\n{\r\n  ...,\r\n  \"dependencies\": {},\r\n  ...\r\n}\r\n```\r\n\r\nEssentially, I changed ObjectSchema.java to have a Map of String keys and Object values. The Dependency objects provided do not have a JSON creation implementation defined as of yet so I thought that a map should do for now to conform to the [spec](https://tools.ietf.org/html/draft-zyp-json-schema-03#section-5.8)."},"comment":{"url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/issues/comments/255886163","html_url":"https://github.com/FasterXML/jackson-module-jsonSchema/pull/120#issuecomment-255886163","issue_url":"https://api.github.com/repos/FasterXML/jackson-module-jsonSchema/issues/120","id":255886163,"user":{"login":"cowtowncoder","id":55065,"avatar_url":"https://avatars.githubusercontent.com/u/55065?v=3","gravatar_id":"","url":"https://api.github.com/users/cowtowncoder","html_url":"https://github.com/cowtowncoder","followers_url":"https://api.github.com/users/cowtowncoder/followers","following_url":"https://api.github.com/users/cowtowncoder/following{/other_user}","gists_url":"https://api.github.com/users/cowtowncoder/gists{/gist_id}","starred_url":"https://api.github.com/users/cowtowncoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowtowncoder/subscriptions","organizations_url":"https://api.github.com/users/cowtowncoder/orgs","repos_url":"https://api.github.com/users/cowtowncoder/repos","events_url":"https://api.github.com/users/cowtowncoder/events{/privacy}","received_events_url":"https://api.github.com/users/cowtowncoder/received_events","type":"User","site_admin":false},"created_at":"2016-10-24T22:38:23Z","updated_at":"2016-10-24T22:38:23Z","body":"@seanstaley unit test(s) would be very useful.\r\n\r\nI am worried about backwards compatibility mostly because regardless of whether result is compliant with specification (it isn't), there's a good chance someone somewhere is using and relying on existing behavior. I can not really evaluate likelihood of that (or severity of breakage), but have learnt that reliance on observed behavior is one of prime laws of nature in software implementaiton world.... :-)\r\n(alas!)\r\n\r\n\r\n"}}
{"actor":{"display_login":"cowtowncoder"}}