{"action":"opened","number":942,"pull_request":{"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/942","id":85131086,"html_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation/pull/942","diff_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation/pull/942.diff","patch_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation/pull/942.patch","issue_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/942","number":942,"state":"open","locked":false,"title":"Added biome support for Agricultural Revolution.","user":{"login":"whichonespink44","id":10927161,"avatar_url":"https://avatars.githubusercontent.com/u/10927161?v=3","gravatar_id":"","url":"https://api.github.com/users/whichonespink44","html_url":"https://github.com/whichonespink44","followers_url":"https://api.github.com/users/whichonespink44/followers","following_url":"https://api.github.com/users/whichonespink44/following{/other_user}","gists_url":"https://api.github.com/users/whichonespink44/gists{/gist_id}","starred_url":"https://api.github.com/users/whichonespink44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whichonespink44/subscriptions","organizations_url":"https://api.github.com/users/whichonespink44/orgs","repos_url":"https://api.github.com/users/whichonespink44/repos","events_url":"https://api.github.com/users/whichonespink44/events{/privacy}","received_events_url":"https://api.github.com/users/whichonespink44/received_events","type":"User","site_admin":false},"body":"This is ready to go, except for one major show-stopper: all of the ocean biomes crash:\r\n\r\nhttp://pastebin.com/qquQtyrB\r\n\r\nI've tried adding a try/catch to the biome's call to DecoBaseBiomeDecorations, but the crash is happening before then, during chunk population.\r\n\r\nAgricultural Revolution is closed source, but using JD-GUI, I inspected the code causing the crash but didn't spot anything that could be causing the crash. However, the code is a bit all over the place, and without a global search function, it was difficult to see how everything fits together.\r\n\r\nAll other world gen (including world gen that spawns in vanilla Ocean and Deep Ocean) is generating fine, so I think it must be crashing when trying to generate structures in AR's oceanic biomes.\r\n\r\nI'm posting this here in case anyone wants to take it for a test drive. Everything else is ready to go - just need to get to the bottom of the oceanic biome crashes.\r\n\r\nWorst-case scenario, we could always just *not* support those oceanic biomes, but I'd like to get to the bottom of these crashes at some point. (This is OceanCraft all over again!) :sob: ","created_at":"2016-09-13T21:43:34Z","updated_at":"2016-09-13T21:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/942/commits","review_comments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/942/comments","review_comment_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/942/comments","statuses_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/statuses/27c55a7b62560007cc899e82821e61fd1108f217","head":{"label":"Team-RTG:1.10.2/agricultural-revolution","ref":"1.10.2/agricultural-revolution","sha":"27c55a7b62560007cc899e82821e61fd1108f217","user":{"login":"Team-RTG","id":14605851,"avatar_url":"https://avatars.githubusercontent.com/u/14605851?v=3","gravatar_id":"","url":"https://api.github.com/users/Team-RTG","html_url":"https://github.com/Team-RTG","followers_url":"https://api.github.com/users/Team-RTG/followers","following_url":"https://api.github.com/users/Team-RTG/following{/other_user}","gists_url":"https://api.github.com/users/Team-RTG/gists{/gist_id}","starred_url":"https://api.github.com/users/Team-RTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team-RTG/subscriptions","organizations_url":"https://api.github.com/users/Team-RTG/orgs","repos_url":"https://api.github.com/users/Team-RTG/repos","events_url":"https://api.github.com/users/Team-RTG/events{/privacy}","received_events_url":"https://api.github.com/users/Team-RTG/received_events","type":"Organization","site_admin":false},"repo":{"id":42006308,"name":"Realistic-Terrain-Generation","full_name":"Team-RTG/Realistic-Terrain-Generation","owner":{"login":"Team-RTG","id":14605851,"avatar_url":"https://avatars.githubusercontent.com/u/14605851?v=3","gravatar_id":"","url":"https://api.github.com/users/Team-RTG","html_url":"https://github.com/Team-RTG","followers_url":"https://api.github.com/users/Team-RTG/followers","following_url":"https://api.github.com/users/Team-RTG/following{/other_user}","gists_url":"https://api.github.com/users/Team-RTG/gists{/gist_id}","starred_url":"https://api.github.com/users/Team-RTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team-RTG/subscriptions","organizations_url":"https://api.github.com/users/Team-RTG/orgs","repos_url":"https://api.github.com/users/Team-RTG/repos","events_url":"https://api.github.com/users/Team-RTG/events{/privacy}","received_events_url":"https://api.github.com/users/Team-RTG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation","description":"The Realistic Terrain Generation mod for Minecraft.","fork":false,"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation","forks_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/forks","keys_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/teams","hooks_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/hooks","issue_events_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/events{/number}","events_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/events","assignees_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/assignees{/user}","branches_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/branches{/branch}","tags_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/tags","blobs_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/statuses/{sha}","languages_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/languages","stargazers_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/stargazers","contributors_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/contributors","subscribers_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/subscribers","subscription_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/subscription","commits_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/contents/{+path}","compare_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/merges","archive_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/downloads","issues_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues{/number}","pulls_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls{/number}","milestones_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/milestones{/number}","notifications_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/labels{/name}","releases_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/releases{/id}","deployments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/deployments","created_at":"2015-09-06T14:52:31Z","updated_at":"2016-09-10T18:35:15Z","pushed_at":"2016-09-13T21:43:34Z","git_url":"git://github.com/Team-RTG/Realistic-Terrain-Generation.git","ssh_url":"git@github.com:Team-RTG/Realistic-Terrain-Generation.git","clone_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation.git","svn_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation","homepage":"","size":24200,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":43,"forks":38,"open_issues":43,"watchers":76,"default_branch":"1.10.2-dev"}},"base":{"label":"Team-RTG:1.10.2-dev","ref":"1.10.2-dev","sha":"819c0e2f2d5694f0a353d61401929ab07f5591d1","user":{"login":"Team-RTG","id":14605851,"avatar_url":"https://avatars.githubusercontent.com/u/14605851?v=3","gravatar_id":"","url":"https://api.github.com/users/Team-RTG","html_url":"https://github.com/Team-RTG","followers_url":"https://api.github.com/users/Team-RTG/followers","following_url":"https://api.github.com/users/Team-RTG/following{/other_user}","gists_url":"https://api.github.com/users/Team-RTG/gists{/gist_id}","starred_url":"https://api.github.com/users/Team-RTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team-RTG/subscriptions","organizations_url":"https://api.github.com/users/Team-RTG/orgs","repos_url":"https://api.github.com/users/Team-RTG/repos","events_url":"https://api.github.com/users/Team-RTG/events{/privacy}","received_events_url":"https://api.github.com/users/Team-RTG/received_events","type":"Organization","site_admin":false},"repo":{"id":42006308,"name":"Realistic-Terrain-Generation","full_name":"Team-RTG/Realistic-Terrain-Generation","owner":{"login":"Team-RTG","id":14605851,"avatar_url":"https://avatars.githubusercontent.com/u/14605851?v=3","gravatar_id":"","url":"https://api.github.com/users/Team-RTG","html_url":"https://github.com/Team-RTG","followers_url":"https://api.github.com/users/Team-RTG/followers","following_url":"https://api.github.com/users/Team-RTG/following{/other_user}","gists_url":"https://api.github.com/users/Team-RTG/gists{/gist_id}","starred_url":"https://api.github.com/users/Team-RTG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Team-RTG/subscriptions","organizations_url":"https://api.github.com/users/Team-RTG/orgs","repos_url":"https://api.github.com/users/Team-RTG/repos","events_url":"https://api.github.com/users/Team-RTG/events{/privacy}","received_events_url":"https://api.github.com/users/Team-RTG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation","description":"The Realistic Terrain Generation mod for Minecraft.","fork":false,"url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation","forks_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/forks","keys_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/teams","hooks_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/hooks","issue_events_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/events{/number}","events_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/events","assignees_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/assignees{/user}","branches_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/branches{/branch}","tags_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/tags","blobs_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/refs{/sha}","trees_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/statuses/{sha}","languages_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/languages","stargazers_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/stargazers","contributors_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/contributors","subscribers_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/subscribers","subscription_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/subscription","commits_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/commits{/sha}","git_commits_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/git/commits{/sha}","comments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/comments{/number}","issue_comment_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/comments{/number}","contents_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/contents/{+path}","compare_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/merges","archive_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/downloads","issues_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues{/number}","pulls_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls{/number}","milestones_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/milestones{/number}","notifications_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/labels{/name}","releases_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/releases{/id}","deployments_url":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/deployments","created_at":"2015-09-06T14:52:31Z","updated_at":"2016-09-10T18:35:15Z","pushed_at":"2016-09-13T21:43:34Z","git_url":"git://github.com/Team-RTG/Realistic-Terrain-Generation.git","ssh_url":"git@github.com:Team-RTG/Realistic-Terrain-Generation.git","clone_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation.git","svn_url":"https://github.com/Team-RTG/Realistic-Terrain-Generation","homepage":"","size":24200,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":43,"forks":38,"open_issues":43,"watchers":76,"default_branch":"1.10.2-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/942"},"html":{"href":"https://github.com/Team-RTG/Realistic-Terrain-Generation/pull/942"},"issue":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/942"},"comments":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/issues/942/comments"},"review_comments":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/942/comments"},"review_comment":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/pulls/942/commits"},"statuses":{"href":"https://api.github.com/repos/Team-RTG/Realistic-Terrain-Generation/statuses/27c55a7b62560007cc899e82821e61fd1108f217"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":1157,"deletions":1,"changed_files":33}}
{"actor":{"display_login":"whichonespink44"}}