{"action":"created","issue":{"url":"https://api.github.com/repos/docker/compose/issues/3980","repository_url":"https://api.github.com/repos/docker/compose","labels_url":"https://api.github.com/repos/docker/compose/issues/3980/labels{/name}","comments_url":"https://api.github.com/repos/docker/compose/issues/3980/comments","events_url":"https://api.github.com/repos/docker/compose/issues/3980/events","html_url":"https://github.com/docker/compose/pull/3980","id":179213470,"number":3980,"title":"Attach interactively on Windows by shelling out","user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/docker/compose/labels/area/logs","name":"area/logs","color":"c7def8"},{"url":"https://api.github.com/repos/docker/compose/labels/group/windows-client","name":"group/windows-client","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/docker/compose/milestones/19","html_url":"https://github.com/docker/compose/milestones/1.9.0","labels_url":"https://api.github.com/repos/docker/compose/milestones/19/labels","id":1858024,"number":19,"title":"1.9.0","description":"","creator":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":30,"state":"open","created_at":"2016-06-30T17:13:21Z","updated_at":"2016-10-20T22:03:55Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2016-09-26T12:21:30Z","updated_at":"2016-10-21T01:40:28Z","closed_at":"2016-10-19T18:14:36Z","pull_request":{"url":"https://api.github.com/repos/docker/compose/pulls/3980","html_url":"https://github.com/docker/compose/pull/3980","diff_url":"https://github.com/docker/compose/pull/3980.diff","patch_url":"https://github.com/docker/compose/pull/3980.patch"},"body":"As discussed in https://github.com/docker/docker/issues/26705, we can shell out to `docker start --attach` instead of using dockerpty.\r\n\r\nThe change is conservatively scoped to interactive mode on Windows so that no existing use cases are broken. Once we're more confident, we can expand outwards.\r\n\r\nTODO:\r\n\r\n- [x] User testing ([here's the binary!](https://ci.appveyor.com/api/buildjobs/raq027fhnl0c1xjn/artifacts/dist%2Fdocker-compose-Windows-x86_64.exe))\r\n- [x] Sensible error message when no `docker` binary is found\r\n- [x] <s>Find out if we need to do version checking on the `docker` binary (when was `docker start --attach` introduced?)</s> We don't - it's been there since 1.0.\r\n\r\nCloses #3194."},"comment":{"url":"https://api.github.com/repos/docker/compose/issues/comments/255272764","html_url":"https://github.com/docker/compose/pull/3980#issuecomment-255272764","issue_url":"https://api.github.com/repos/docker/compose/issues/3980","id":255272764,"user":{"login":"laggingreflex","id":2523987,"avatar_url":"https://avatars.githubusercontent.com/u/2523987?v=3","gravatar_id":"","url":"https://api.github.com/users/laggingreflex","html_url":"https://github.com/laggingreflex","followers_url":"https://api.github.com/users/laggingreflex/followers","following_url":"https://api.github.com/users/laggingreflex/following{/other_user}","gists_url":"https://api.github.com/users/laggingreflex/gists{/gist_id}","starred_url":"https://api.github.com/users/laggingreflex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laggingreflex/subscriptions","organizations_url":"https://api.github.com/users/laggingreflex/orgs","repos_url":"https://api.github.com/users/laggingreflex/repos","events_url":"https://api.github.com/users/laggingreflex/events{/privacy}","received_events_url":"https://api.github.com/users/laggingreflex/received_events","type":"User","site_admin":false},"created_at":"2016-10-21T01:40:28Z","updated_at":"2016-10-21T01:40:28Z","body":"I tried this but I'm getting error\r\n```sh\r\n> docker-compose up --build\r\nTraceback (most recent call last):\r\n  File \"<string>\", line 3, in <module>\r\n  File \"compose\\cli\\main.py\", line 64, in main\r\n  File \"compose\\cli\\main.py\", line 116, in perform_command\r\n  File \"compose\\cli\\main.py\", line 848, in up\r\n  File \"compose\\project.py\", line 372, in up\r\n  File \"compose\\project.py\", line 539, in warn_for_swarm_mode\r\n  File \"site-packages\\docker\\api\\daemon.py\", line 33, in info\r\n  File \"site-packages\\docker\\utils\\decorators.py\", line 47, in inner\r\n  File \"site-packages\\docker\\client.py\", line 139, in _get\r\n  File \"site-packages\\requests\\sessions.py\", line 477, in get\r\n  File \"site-packages\\requests\\sessions.py\", line 465, in request\r\n  File \"site-packages\\requests\\sessions.py\", line 573, in send\r\n  File \"site-packages\\requests\\adapters.py\", line 370, in send\r\n  File \"site-packages\\requests\\packages\\urllib3\\connectionpool.py\", line 544, in urlopen\r\n  File \"site-packages\\requests\\packages\\urllib3\\connectionpool.py\", line 374, in _make_request\r\n  File \"httplib.py\", line 1133, in getresponse\r\n  File \"httplib.py\", line 390, in __init__\r\n  File \"site-packages\\docker\\transport\\npipesocket.py\", line 99, in makefile\r\nValueError: buffer size must be strictly positive\r\ndocker-compose returned -1\r\n```\r\n\r\nOn Windows 10 Preview 14946\r\n\r\nI also tried building from the [latest master branch][1] and it too gives error:\r\n```sh\r\nTraceback (most recent call last):\r\n  File \"<string>\", line 3, in <module>\r\n  File \"compose\\cli\\main.py\", line 64, in main\r\n  File \"compose\\cli\\main.py\", line 116, in perform_command\r\n  File \"compose\\cli\\main.py\", line 711, in run\r\n  File \"compose\\cli\\main.py\", line 986, in run_one_off_container\r\n  File \"compose\\cli\\main.py\", line 1067, in call_docker\r\n  File \"subprocess.py\", line 567, in check_output\r\n  File \"subprocess.py\", line 711, in __init__\r\n  File \"subprocess.py\", line 959, in _execute_child\r\nWindowsError: [Error 2] The system cannot find the file specified\r\ndocker-compose returned -1\r\n```\r\n\r\n\r\n[1]:https://github.com/docker/compose/commit/3147090fb4e58f48b2c596fe42bede8bd01613e4\r\n"}}
{"actor":{"display_login":"laggingreflex"}}