{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/68532145","id":68532145,"diff_hunk":"@@ -8,7 +8,53 @@\n     expect(described_class).to implement_interface_of(LogStash::Instrument::NamespacedMetric)\n   end\n \n+  let(:key) { \"galaxy\" }\n+\n+  describe \"#increment\" do","path":"logstash-core/spec/logstash/instrument/null_metric_spec.rb","position":6,"original_position":6,"commit_id":"c4c7cc6b3e75cb900168d5ef291e550f5d98d748","original_commit_id":"c4c7cc6b3e75cb900168d5ef291e550f5d98d748","user":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"body":"same with these specs, most of the specs for the nullmetric are also valid for the Namespaced metric (the `.to_not raise_error`, namespacing resulting in an instance of self.class, etc)","created_at":"2016-06-27T07:26:01Z","updated_at":"2016-06-27T07:26:01Z","html_url":"https://github.com/elastic/logstash/pull/5545#discussion_r68532145","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/5545","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/68532145"},"html":{"href":"https://github.com/elastic/logstash/pull/5545#discussion_r68532145"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5545"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/5545","id":74976308,"html_url":"https://github.com/elastic/logstash/pull/5545","diff_url":"https://github.com/elastic/logstash/pull/5545.diff","patch_url":"https://github.com/elastic/logstash/pull/5545.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/5545","number":5545,"state":"open","locked":false,"title":"Add more tests around the metric classes","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"This PR improves the quality of the metric library:\r\n- Add more tests coverage for the `Namespaced` class\r\n- Add more tests coverage for the `NullMetric` class\r\n- Fix an issue when `#increment` was called with more arguments than required on both the `NullMetric` and the `namespaced` class.\r\n\r\nI've send this your way @jsvd since you already know a bit of this code.","created_at":"2016-06-23T15:32:45Z","updated_at":"2016-06-27T07:26:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ce0dba2bd2090ecffa8b550b1f40698a8af0fab","assignee":{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsvd","id":31809,"avatar_url":"https://avatars.githubusercontent.com/u/31809?v=3","gravatar_id":"","url":"https://api.github.com/users/jsvd","html_url":"https://github.com/jsvd","followers_url":"https://api.github.com/users/jsvd/followers","following_url":"https://api.github.com/users/jsvd/following{/other_user}","gists_url":"https://api.github.com/users/jsvd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsvd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsvd/subscriptions","organizations_url":"https://api.github.com/users/jsvd/orgs","repos_url":"https://api.github.com/users/jsvd/repos","events_url":"https://api.github.com/users/jsvd/events{/privacy}","received_events_url":"https://api.github.com/users/jsvd/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/5545/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/5545/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/5545/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/c4c7cc6b3e75cb900168d5ef291e550f5d98d748","head":{"label":"ph:fix/more-test-for-metric-classes","ref":"fix/more-test-for-metric-classes","sha":"c4c7cc6b3e75cb900168d5ef291e550f5d98d748","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"repo":{"id":24861697,"name":"logstash","full_name":"ph/logstash","owner":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/ph/logstash","forks_url":"https://api.github.com/repos/ph/logstash/forks","keys_url":"https://api.github.com/repos/ph/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph/logstash/teams","hooks_url":"https://api.github.com/repos/ph/logstash/hooks","issue_events_url":"https://api.github.com/repos/ph/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/ph/logstash/events","assignees_url":"https://api.github.com/repos/ph/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/ph/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/ph/logstash/tags","blobs_url":"https://api.github.com/repos/ph/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/ph/logstash/languages","stargazers_url":"https://api.github.com/repos/ph/logstash/stargazers","contributors_url":"https://api.github.com/repos/ph/logstash/contributors","subscribers_url":"https://api.github.com/repos/ph/logstash/subscribers","subscription_url":"https://api.github.com/repos/ph/logstash/subscription","commits_url":"https://api.github.com/repos/ph/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/ph/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph/logstash/merges","archive_url":"https://api.github.com/repos/ph/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph/logstash/downloads","issues_url":"https://api.github.com/repos/ph/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/ph/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/ph/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/ph/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph/logstash/labels{/name}","releases_url":"https://api.github.com/repos/ph/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/ph/logstash/deployments","created_at":"2014-10-06T19:37:59Z","updated_at":"2015-06-05T14:18:00Z","pushed_at":"2016-06-23T20:09:45Z","git_url":"git://github.com/ph/logstash.git","ssh_url":"git@github.com:ph/logstash.git","clone_url":"https://github.com/ph/logstash.git","svn_url":"https://github.com/ph/logstash","homepage":"http://logstash.net/","size":76213,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"645eee4a70fdc484752e2ce9ef0ff4fcec0bdf06","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2016-06-27T03:32:57Z","pushed_at":"2016-06-25T17:32:12Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":88693,"stargazers_count":6062,"watchers_count":6062,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1809,"mirror_url":null,"open_issues_count":761,"forks":1809,"open_issues":761,"watchers":6062,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5545"},"html":{"href":"https://github.com/elastic/logstash/pull/5545"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/5545"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/5545/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5545/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/5545/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/c4c7cc6b3e75cb900168d5ef291e550f5d98d748"}}}}
{"actor":{"display_login":"jsvd"}}