{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/sims_catUtils/pulls/comments/89020318","pull_request_review_id":9571958,"id":89020318,"diff_hunk":"@@ -16,13 +23,296 @@ def calcADUwrapper(sedName=None, magNorm=None, redshift=None, internalAv=None, i\n         if internalAv != 0.0 and internalRv != 0.0:\n             a_int, b_int = sed.setupCCMab()\n             sed.addCCMDust(a_int, b_int, A_v=internalAv, R_v=internalRv)\n-    \n+\n     if redshift is not None and redshift != 0.0:\n         sed.redshiftSED(redshift, dimming=True)\n-    \n+\n     a_int, b_int = sed.setupCCMab()\n     sed.addCCMDust(a_int, b_int, A_v=galacticAv, R_v=galacticRv)\n-    \n+\n     adu = sed.calcADU(bandpass, photParams=PhotometricParameters())\n-    \n+\n     return adu\n+\n+\n+def makePhoSimTestDB(filename='PhoSimTestDatabase.db', size=1000, seedVal=32, radius=0.1,\n+                     displacedRA=None, displacedDec=None,\n+                     bandpass='r', m5=None, seeing=None, **kwargs):\n+    \"\"\"\n+    Make a test database to storing cartoon information for the test phoSim input\n+    catalog to use.\n+\n+    The method will return an ObservationMetaData object guaranteed to encompass the\n+    objects in this database.\n+\n+    @param [in] filename is a string indicating the name of the DB file to be created\n+\n+    @param [in] size is the number of objects int he database\n+\n+    @param [in] seedVal is the seed passed to the random number generator\n+\n+    @param [in] radius is the radius (in degrees) of the field of view to be returned\n+\n+    @param [in] bandpass is the bandpas(es) of the observation to be passed to\n+    ObservationMetaData (optional)\n+\n+    @param [in] m5 is the m5 value(s) to be passed to ObservationMetaData\n+    (optional)\n+\n+    @param [in] seeing is the seeing value(s) in arcseconds to be passed to\n+    ObservationMetaData (optional)\n+\n+    @param [in] displacedRA/Dec are numpy arrays that indicate where (in relation to the center","path":"python/lsst/sims/catUtils/utils/testUtils.py","position":62,"original_position":62,"commit_id":"39f6d583e655b737595279a128089339698406dc","original_commit_id":"39f6d583e655b737595279a128089339698406dc","user":{"login":"rbiswas4","id":2281358,"avatar_url":"https://avatars.githubusercontent.com/u/2281358?v=3","gravatar_id":"","url":"https://api.github.com/users/rbiswas4","html_url":"https://github.com/rbiswas4","followers_url":"https://api.github.com/users/rbiswas4/followers","following_url":"https://api.github.com/users/rbiswas4/following{/other_user}","gists_url":"https://api.github.com/users/rbiswas4/gists{/gist_id}","starred_url":"https://api.github.com/users/rbiswas4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbiswas4/subscriptions","organizations_url":"https://api.github.com/users/rbiswas4/orgs","repos_url":"https://api.github.com/users/rbiswas4/repos","events_url":"https://api.github.com/users/rbiswas4/events{/privacy}","received_events_url":"https://api.github.com/users/rbiswas4/received_events","type":"User","site_admin":false},"body":"It might be possible to clarify the meaning of this being a deviation from the center rather than the absolute position of the displaced radius if we use something like `deltaRA`. (\"in relation to the center\" helps, but might be hard to catch)","created_at":"2016-11-22T00:26:34Z","updated_at":"2016-11-22T00:28:49Z","html_url":"https://github.com/lsst/sims_catUtils/pull/72#discussion_r89020318","pull_request_url":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_catUtils/pulls/comments/89020318"},"html":{"href":"https://github.com/lsst/sims_catUtils/pull/72#discussion_r89020318"},"pull_request":{"href":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72","id":91708200,"html_url":"https://github.com/lsst/sims_catUtils/pull/72","diff_url":"https://github.com/lsst/sims_catUtils/pull/72.diff","patch_url":"https://github.com/lsst/sims_catUtils/pull/72.patch","issue_url":"https://api.github.com/repos/lsst/sims_catUtils/issues/72","number":72,"state":"open","locked":false,"title":"U/danielsf/fix phosim extinction","user":{"login":"danielsf","id":1682854,"avatar_url":"https://avatars.githubusercontent.com/u/1682854?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsf","html_url":"https://github.com/danielsf","followers_url":"https://api.github.com/users/danielsf/followers","following_url":"https://api.github.com/users/danielsf/following{/other_user}","gists_url":"https://api.github.com/users/danielsf/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsf/subscriptions","organizations_url":"https://api.github.com/users/danielsf/orgs","repos_url":"https://api.github.com/users/danielsf/repos","events_url":"https://api.github.com/users/danielsf/events{/privacy}","received_events_url":"https://api.github.com/users/danielsf/received_events","type":"User","site_admin":false},"body":"I have\r\n\r\n1) fixed the order of extinction parameters in PhoSim InstanceCatalogs\r\n2) added unit tests to test the output of PhoSim InstanceCatalog classes, so we will catch it the next time we break something\r\n\r\nThere are small supporting PRs in sims_catalogs and sims_GalSimInterface","created_at":"2016-10-31T23:11:25Z","updated_at":"2016-11-22T00:28:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70bf4a795abd6133ed89dd341d20728bed8af510","assignee":{"login":"rbiswas4","id":2281358,"avatar_url":"https://avatars.githubusercontent.com/u/2281358?v=3","gravatar_id":"","url":"https://api.github.com/users/rbiswas4","html_url":"https://github.com/rbiswas4","followers_url":"https://api.github.com/users/rbiswas4/followers","following_url":"https://api.github.com/users/rbiswas4/following{/other_user}","gists_url":"https://api.github.com/users/rbiswas4/gists{/gist_id}","starred_url":"https://api.github.com/users/rbiswas4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbiswas4/subscriptions","organizations_url":"https://api.github.com/users/rbiswas4/orgs","repos_url":"https://api.github.com/users/rbiswas4/repos","events_url":"https://api.github.com/users/rbiswas4/events{/privacy}","received_events_url":"https://api.github.com/users/rbiswas4/received_events","type":"User","site_admin":false},"assignees":[{"login":"rbiswas4","id":2281358,"avatar_url":"https://avatars.githubusercontent.com/u/2281358?v=3","gravatar_id":"","url":"https://api.github.com/users/rbiswas4","html_url":"https://github.com/rbiswas4","followers_url":"https://api.github.com/users/rbiswas4/followers","following_url":"https://api.github.com/users/rbiswas4/following{/other_user}","gists_url":"https://api.github.com/users/rbiswas4/gists{/gist_id}","starred_url":"https://api.github.com/users/rbiswas4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbiswas4/subscriptions","organizations_url":"https://api.github.com/users/rbiswas4/orgs","repos_url":"https://api.github.com/users/rbiswas4/repos","events_url":"https://api.github.com/users/rbiswas4/events{/privacy}","received_events_url":"https://api.github.com/users/rbiswas4/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72/commits","review_comments_url":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72/comments","review_comment_url":"https://api.github.com/repos/lsst/sims_catUtils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/sims_catUtils/issues/72/comments","statuses_url":"https://api.github.com/repos/lsst/sims_catUtils/statuses/39f6d583e655b737595279a128089339698406dc","head":{"label":"lsst:u/danielsf/fix_phosim_extinction","ref":"u/danielsf/fix_phosim_extinction","sha":"39f6d583e655b737595279a128089339698406dc","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668130,"name":"sims_catUtils","full_name":"lsst/sims_catUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_catUtils","description":"LSST Simulations package for catalog utilities","fork":false,"url":"https://api.github.com/repos/lsst/sims_catUtils","forks_url":"https://api.github.com/repos/lsst/sims_catUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_catUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_catUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_catUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_catUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_catUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_catUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_catUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_catUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_catUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_catUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_catUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_catUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_catUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_catUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_catUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_catUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_catUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_catUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_catUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_catUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_catUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_catUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_catUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_catUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_catUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_catUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_catUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_catUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_catUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_catUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_catUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_catUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_catUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_catUtils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_catUtils/deployments","created_at":"2015-04-27T13:25:00Z","updated_at":"2016-11-03T20:04:44Z","pushed_at":"2016-11-21T23:59:17Z","git_url":"git://github.com/lsst/sims_catUtils.git","ssh_url":"git@github.com:lsst/sims_catUtils.git","clone_url":"https://github.com/lsst/sims_catUtils.git","svn_url":"https://github.com/lsst/sims_catUtils","homepage":null,"size":9998,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"d0952e39c502e0746e25f0cfbfa1a3dc15ae3db1","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":34668130,"name":"sims_catUtils","full_name":"lsst/sims_catUtils","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/sims_catUtils","description":"LSST Simulations package for catalog utilities","fork":false,"url":"https://api.github.com/repos/lsst/sims_catUtils","forks_url":"https://api.github.com/repos/lsst/sims_catUtils/forks","keys_url":"https://api.github.com/repos/lsst/sims_catUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/sims_catUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/sims_catUtils/teams","hooks_url":"https://api.github.com/repos/lsst/sims_catUtils/hooks","issue_events_url":"https://api.github.com/repos/lsst/sims_catUtils/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/sims_catUtils/events","assignees_url":"https://api.github.com/repos/lsst/sims_catUtils/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/sims_catUtils/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/sims_catUtils/tags","blobs_url":"https://api.github.com/repos/lsst/sims_catUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/sims_catUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/sims_catUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/sims_catUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/sims_catUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/sims_catUtils/languages","stargazers_url":"https://api.github.com/repos/lsst/sims_catUtils/stargazers","contributors_url":"https://api.github.com/repos/lsst/sims_catUtils/contributors","subscribers_url":"https://api.github.com/repos/lsst/sims_catUtils/subscribers","subscription_url":"https://api.github.com/repos/lsst/sims_catUtils/subscription","commits_url":"https://api.github.com/repos/lsst/sims_catUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/sims_catUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/sims_catUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/sims_catUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/sims_catUtils/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/sims_catUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/sims_catUtils/merges","archive_url":"https://api.github.com/repos/lsst/sims_catUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/sims_catUtils/downloads","issues_url":"https://api.github.com/repos/lsst/sims_catUtils/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/sims_catUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/sims_catUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/sims_catUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/sims_catUtils/labels{/name}","releases_url":"https://api.github.com/repos/lsst/sims_catUtils/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/sims_catUtils/deployments","created_at":"2015-04-27T13:25:00Z","updated_at":"2016-11-03T20:04:44Z","pushed_at":"2016-11-21T23:59:17Z","git_url":"git://github.com/lsst/sims_catUtils.git","ssh_url":"git@github.com:lsst/sims_catUtils.git","clone_url":"https://github.com/lsst/sims_catUtils.git","svn_url":"https://github.com/lsst/sims_catUtils","homepage":null,"size":9998,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72"},"html":{"href":"https://github.com/lsst/sims_catUtils/pull/72"},"issue":{"href":"https://api.github.com/repos/lsst/sims_catUtils/issues/72"},"comments":{"href":"https://api.github.com/repos/lsst/sims_catUtils/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/sims_catUtils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/sims_catUtils/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/sims_catUtils/statuses/39f6d583e655b737595279a128089339698406dc"}}}}
{"actor":{"display_login":"rbiswas4"}}