{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cordova-windows/pulls/comments/73100316","id":73100316,"diff_hunk":"@@ -105,7 +105,7 @@ var handlers = {\n             var type = obj.type;\n \n             if(type === 'projectReference') {\n-                project.removeProjectReference(path.join(plugin.dir, src), getTargetConditions(obj));\n+                project.removeProjectReference(path.join('..', '..', 'plugins', plugin.id, src), getTargetConditions(obj));","path":"template/cordova/lib/PluginHandler.js","position":5,"original_position":5,"commit_id":"ee570036bc8faddc7d63e2830144c3d007d8e904","original_commit_id":"ee570036bc8faddc7d63e2830144c3d007d8e904","user":{"login":"daserge","id":4272078,"avatar_url":"https://avatars.githubusercontent.com/u/4272078?v=3","gravatar_id":"","url":"https://api.github.com/users/daserge","html_url":"https://github.com/daserge","followers_url":"https://api.github.com/users/daserge/followers","following_url":"https://api.github.com/users/daserge/following{/other_user}","gists_url":"https://api.github.com/users/daserge/gists{/gist_id}","starred_url":"https://api.github.com/users/daserge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daserge/subscriptions","organizations_url":"https://api.github.com/users/daserge/orgs","repos_url":"https://api.github.com/users/daserge/repos","events_url":"https://api.github.com/users/daserge/events{/privacy}","received_events_url":"https://api.github.com/users/daserge/received_events","type":"User","site_admin":false},"body":"Regarding `targetDir` - this is [not supported](https://github.com/daserge/cordova-windows/blob/ee570036bc8faddc7d63e2830144c3d007d8e904/spec/unit/pluginHandler/windows.spec.js#L140) for projectReferences.\r\nRegarding hardcoded `../..` - using `path.join(path.relative(project.projectFolder, plugin.dir), src)` instead is causing some issues with tests related to project and plugin different drives location, investigating.","created_at":"2016-08-02T06:27:03Z","updated_at":"2016-08-02T06:27:03Z","html_url":"https://github.com/apache/cordova-windows/pull/185#discussion_r73100316","pull_request_url":"https://api.github.com/repos/apache/cordova-windows/pulls/185","_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/comments/73100316"},"html":{"href":"https://github.com/apache/cordova-windows/pull/185#discussion_r73100316"},"pull_request":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cordova-windows/pulls/185","id":77108805,"html_url":"https://github.com/apache/cordova-windows/pull/185","diff_url":"https://github.com/apache/cordova-windows/pull/185.diff","patch_url":"https://github.com/apache/cordova-windows/pull/185.patch","issue_url":"https://api.github.com/repos/apache/cordova-windows/issues/185","number":185,"state":"open","locked":false,"title":"CB-11558 Make windows plugin rm remove ProjectReference items","user":{"login":"daserge","id":4272078,"avatar_url":"https://avatars.githubusercontent.com/u/4272078?v=3","gravatar_id":"","url":"https://api.github.com/users/daserge","html_url":"https://github.com/daserge","followers_url":"https://api.github.com/users/daserge/followers","following_url":"https://api.github.com/users/daserge/following{/other_user}","gists_url":"https://api.github.com/users/daserge/gists{/gist_id}","starred_url":"https://api.github.com/users/daserge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daserge/subscriptions","organizations_url":"https://api.github.com/users/daserge/orgs","repos_url":"https://api.github.com/users/daserge/repos","events_url":"https://api.github.com/users/daserge/events{/privacy}","received_events_url":"https://api.github.com/users/daserge/received_events","type":"User","site_admin":false},"body":"The issue was that we have been passing a relative path during `JsprojManager`.`addProjectReference` and an absolute path during `JsprojManager`.`removeProjectReference` so that regexp failed to find and remove it.\r\nThe tests were passing as they were also using absolute paths to the dummy plugin (it was not being added to the test project at all).\r\n\r\nInitial idea was to use relative paths instead for project sharing: [CB-10927 Framework references in plugin.xml file prevent Windows Universal projects from being used on other machines](https://issues.apache.org/jira/browse/CB-10927)\r\n\r\nAlso updated the tests to use relative paths to the ProjectReferences.\r\n\r\n[Jira issue](https://issues.apache.org/jira/browse/CB-11558)","created_at":"2016-07-12T12:10:54Z","updated_at":"2016-08-02T06:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e76e01af9f2848adb42ee35cc546ab1c6cf876a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/cordova-windows/pulls/185/commits","review_comments_url":"https://api.github.com/repos/apache/cordova-windows/pulls/185/comments","review_comment_url":"https://api.github.com/repos/apache/cordova-windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cordova-windows/issues/185/comments","statuses_url":"https://api.github.com/repos/apache/cordova-windows/statuses/ee570036bc8faddc7d63e2830144c3d007d8e904","head":{"label":"daserge:CB-11558","ref":"CB-11558","sha":"ee570036bc8faddc7d63e2830144c3d007d8e904","user":{"login":"daserge","id":4272078,"avatar_url":"https://avatars.githubusercontent.com/u/4272078?v=3","gravatar_id":"","url":"https://api.github.com/users/daserge","html_url":"https://github.com/daserge","followers_url":"https://api.github.com/users/daserge/followers","following_url":"https://api.github.com/users/daserge/following{/other_user}","gists_url":"https://api.github.com/users/daserge/gists{/gist_id}","starred_url":"https://api.github.com/users/daserge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daserge/subscriptions","organizations_url":"https://api.github.com/users/daserge/orgs","repos_url":"https://api.github.com/users/daserge/repos","events_url":"https://api.github.com/users/daserge/events{/privacy}","received_events_url":"https://api.github.com/users/daserge/received_events","type":"User","site_admin":false},"repo":{"id":32146111,"name":"cordova-windows","full_name":"daserge/cordova-windows","owner":{"login":"daserge","id":4272078,"avatar_url":"https://avatars.githubusercontent.com/u/4272078?v=3","gravatar_id":"","url":"https://api.github.com/users/daserge","html_url":"https://github.com/daserge","followers_url":"https://api.github.com/users/daserge/followers","following_url":"https://api.github.com/users/daserge/following{/other_user}","gists_url":"https://api.github.com/users/daserge/gists{/gist_id}","starred_url":"https://api.github.com/users/daserge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daserge/subscriptions","organizations_url":"https://api.github.com/users/daserge/orgs","repos_url":"https://api.github.com/users/daserge/repos","events_url":"https://api.github.com/users/daserge/events{/privacy}","received_events_url":"https://api.github.com/users/daserge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daserge/cordova-windows","description":"Mirror of Apache Cordova Windows","fork":true,"url":"https://api.github.com/repos/daserge/cordova-windows","forks_url":"https://api.github.com/repos/daserge/cordova-windows/forks","keys_url":"https://api.github.com/repos/daserge/cordova-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daserge/cordova-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daserge/cordova-windows/teams","hooks_url":"https://api.github.com/repos/daserge/cordova-windows/hooks","issue_events_url":"https://api.github.com/repos/daserge/cordova-windows/issues/events{/number}","events_url":"https://api.github.com/repos/daserge/cordova-windows/events","assignees_url":"https://api.github.com/repos/daserge/cordova-windows/assignees{/user}","branches_url":"https://api.github.com/repos/daserge/cordova-windows/branches{/branch}","tags_url":"https://api.github.com/repos/daserge/cordova-windows/tags","blobs_url":"https://api.github.com/repos/daserge/cordova-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daserge/cordova-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daserge/cordova-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/daserge/cordova-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daserge/cordova-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/daserge/cordova-windows/languages","stargazers_url":"https://api.github.com/repos/daserge/cordova-windows/stargazers","contributors_url":"https://api.github.com/repos/daserge/cordova-windows/contributors","subscribers_url":"https://api.github.com/repos/daserge/cordova-windows/subscribers","subscription_url":"https://api.github.com/repos/daserge/cordova-windows/subscription","commits_url":"https://api.github.com/repos/daserge/cordova-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/daserge/cordova-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/daserge/cordova-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/daserge/cordova-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/daserge/cordova-windows/contents/{+path}","compare_url":"https://api.github.com/repos/daserge/cordova-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daserge/cordova-windows/merges","archive_url":"https://api.github.com/repos/daserge/cordova-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daserge/cordova-windows/downloads","issues_url":"https://api.github.com/repos/daserge/cordova-windows/issues{/number}","pulls_url":"https://api.github.com/repos/daserge/cordova-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/daserge/cordova-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/daserge/cordova-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daserge/cordova-windows/labels{/name}","releases_url":"https://api.github.com/repos/daserge/cordova-windows/releases{/id}","deployments_url":"https://api.github.com/repos/daserge/cordova-windows/deployments","created_at":"2015-03-13T09:04:31Z","updated_at":"2015-03-13T09:15:19Z","pushed_at":"2016-07-12T12:00:42Z","git_url":"git://github.com/daserge/cordova-windows.git","ssh_url":"git@github.com:daserge/cordova-windows.git","clone_url":"https://github.com/daserge/cordova-windows.git","svn_url":"https://github.com/daserge/cordova-windows","homepage":null,"size":37947,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2c3bf8b7627d080af7ea51f6758fbe66be21e74b","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":6898394,"name":"cordova-windows","full_name":"apache/cordova-windows","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cordova-windows","description":"Mirror of Apache Cordova Windows","fork":false,"url":"https://api.github.com/repos/apache/cordova-windows","forks_url":"https://api.github.com/repos/apache/cordova-windows/forks","keys_url":"https://api.github.com/repos/apache/cordova-windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cordova-windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cordova-windows/teams","hooks_url":"https://api.github.com/repos/apache/cordova-windows/hooks","issue_events_url":"https://api.github.com/repos/apache/cordova-windows/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cordova-windows/events","assignees_url":"https://api.github.com/repos/apache/cordova-windows/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cordova-windows/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cordova-windows/tags","blobs_url":"https://api.github.com/repos/apache/cordova-windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cordova-windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cordova-windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cordova-windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cordova-windows/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cordova-windows/languages","stargazers_url":"https://api.github.com/repos/apache/cordova-windows/stargazers","contributors_url":"https://api.github.com/repos/apache/cordova-windows/contributors","subscribers_url":"https://api.github.com/repos/apache/cordova-windows/subscribers","subscription_url":"https://api.github.com/repos/apache/cordova-windows/subscription","commits_url":"https://api.github.com/repos/apache/cordova-windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cordova-windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cordova-windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cordova-windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cordova-windows/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cordova-windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cordova-windows/merges","archive_url":"https://api.github.com/repos/apache/cordova-windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cordova-windows/downloads","issues_url":"https://api.github.com/repos/apache/cordova-windows/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cordova-windows/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cordova-windows/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cordova-windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cordova-windows/labels{/name}","releases_url":"https://api.github.com/repos/apache/cordova-windows/releases{/id}","deployments_url":"https://api.github.com/repos/apache/cordova-windows/deployments","created_at":"2012-11-28T08:00:28Z","updated_at":"2016-07-27T04:47:38Z","pushed_at":"2016-07-29T13:51:21Z","git_url":"git://github.com/apache/cordova-windows.git","ssh_url":"git@github.com:apache/cordova-windows.git","clone_url":"https://github.com/apache/cordova-windows.git","svn_url":"https://github.com/apache/cordova-windows","homepage":null,"size":38826,"stargazers_count":134,"watchers_count":134,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":"git://git.apache.org/cordova-windows.git","open_issues_count":3,"forks":144,"open_issues":3,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/185"},"html":{"href":"https://github.com/apache/cordova-windows/pull/185"},"issue":{"href":"https://api.github.com/repos/apache/cordova-windows/issues/185"},"comments":{"href":"https://api.github.com/repos/apache/cordova-windows/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cordova-windows/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cordova-windows/statuses/ee570036bc8faddc7d63e2830144c3d007d8e904"}}}}
{"actor":{"display_login":"daserge"}}