{"action":"created","issue":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/10087","repository_url":"https://api.github.com/repos/gitlabhq/gitlabhq","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/10087/labels{/name}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/10087/comments","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/10087/events","html_url":"https://github.com/gitlabhq/gitlabhq/pull/10087","id":141216796,"number":10087,"title":"Fix unintuitive logic in which a canceled Allowed To Fail build will …","user":{"login":"jefesaurus","id":1454657,"avatar_url":"https://avatars.githubusercontent.com/u/1454657?v=3","gravatar_id":"","url":"https://api.github.com/users/jefesaurus","html_url":"https://github.com/jefesaurus","followers_url":"https://api.github.com/users/jefesaurus/followers","following_url":"https://api.github.com/users/jefesaurus/following{/other_user}","gists_url":"https://api.github.com/users/jefesaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/jefesaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jefesaurus/subscriptions","organizations_url":"https://api.github.com/users/jefesaurus/orgs","repos_url":"https://api.github.com/users/jefesaurus/repos","events_url":"https://api.github.com/users/jefesaurus/events{/privacy}","received_events_url":"https://api.github.com/users/jefesaurus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-16T09:30:12Z","updated_at":"2016-03-16T14:28:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/10087","html_url":"https://github.com/gitlabhq/gitlabhq/pull/10087","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/10087.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/10087.patch"},"body":"…always fail the build.\r\n\r\nTL;DR this commit expands the meaning of \"Allowed to fail\" to also include \"Allowed to be canceled\", which in my opinion as a user is far more intuitive.\r\n\r\nFor background, I was extremely surprised and frustrated when I found that by canceling a build marked \"Allowed to fail\", my build still failed even though all of the other test suites passed. My kneejerk understanding of the \"Allowed to fail\" tag is that under no circumstances will that build cause the entire combined status to be a failure. This is not the case apparently, as \"Canceled\" status takes precedence and will cause the entire build to fail.\r\n\r\nSee how the \"fail\" status becomes \"ignored\", which them becomes \"success\" within lib/ci/status.rb, whereas canceled ends up as \"canceled\" even if they are marked as allowed to fail.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/197354542","html_url":"https://github.com/gitlabhq/gitlabhq/pull/10087#issuecomment-197354542","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/10087","id":197354542,"user":{"login":"stanhu","id":963826,"avatar_url":"https://avatars.githubusercontent.com/u/963826?v=3","gravatar_id":"","url":"https://api.github.com/users/stanhu","html_url":"https://github.com/stanhu","followers_url":"https://api.github.com/users/stanhu/followers","following_url":"https://api.github.com/users/stanhu/following{/other_user}","gists_url":"https://api.github.com/users/stanhu/gists{/gist_id}","starred_url":"https://api.github.com/users/stanhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanhu/subscriptions","organizations_url":"https://api.github.com/users/stanhu/orgs","repos_url":"https://api.github.com/users/stanhu/repos","events_url":"https://api.github.com/users/stanhu/events{/privacy}","received_events_url":"https://api.github.com/users/stanhu/received_events","type":"User","site_admin":false},"created_at":"2016-03-16T14:28:49Z","updated_at":"2016-03-16T14:28:49Z","body":"Looks reasonable to me.\r\n\r\n/cc: @ayufan "}}