{"action":"created","comment":{"url":"https://api.github.com/repos/substack/tape/pulls/comments/84178740","pull_request_review_id":4972417,"id":84178740,"diff_hunk":"@@ -0,0 +1,19 @@\n+var yaml = require('js-yaml');\n+\n+module.exports.getDiag = function (body) {\n+    var yamlStart = body.indexOf('  ---');\n+    var yamlEnd = body.indexOf('  ...\\n');\n+    var diag = body.slice(yamlStart, yamlEnd).split('\\n').map(function (line) {\n+        return line.slice(2);\n+    }).join('\\n');\n+\n+    // The stack trace will vary depending on where the code is run, so just\n+    // strip it out.\n+    var withStack = yaml.safeLoad(diag);\n+    delete withStack.stack;\n+    return withStack;\n+}\n+\n+module.exports.stripFullStack = function (output) {\n+    return output.replace(/^\\W+at.*:\\d+:\\d+.*$\\W/gm, '');","path":"test/common.js","position":18,"original_position":18,"commit_id":"4472fc45cdee41bc75782f669ef3c7dd58607673","original_commit_id":"4472fc45cdee41bc75782f669ef3c7dd58607673","user":{"login":"AnIrishDuck","id":289125,"avatar_url":"https://avatars.githubusercontent.com/u/289125?v=3","gravatar_id":"","url":"https://api.github.com/users/AnIrishDuck","html_url":"https://github.com/AnIrishDuck","followers_url":"https://api.github.com/users/AnIrishDuck/followers","following_url":"https://api.github.com/users/AnIrishDuck/following{/other_user}","gists_url":"https://api.github.com/users/AnIrishDuck/gists{/gist_id}","starred_url":"https://api.github.com/users/AnIrishDuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnIrishDuck/subscriptions","organizations_url":"https://api.github.com/users/AnIrishDuck/orgs","repos_url":"https://api.github.com/users/AnIrishDuck/repos","events_url":"https://api.github.com/users/AnIrishDuck/events{/privacy}","received_events_url":"https://api.github.com/users/AnIrishDuck/received_events","type":"User","site_admin":false},"body":"We could strip out all frames that don't involve the `test/` directory. So the result would look like this:\r\n\r\n```\r\n           Error: should be equivalent                                         \r\n              [... frames omitted ...]\r\n              at Test.<anonymous> (/Users/fmurphy/src/tape/test/undef.js:36:11)\r\n              [... frames omitted ...]\r\n```\r\n\r\nWould that be a good compromise?","created_at":"2016-10-19T22:11:25Z","updated_at":"2016-10-19T22:11:25Z","html_url":"https://github.com/substack/tape/pull/330#discussion_r84178740","pull_request_url":"https://api.github.com/repos/substack/tape/pulls/330","_links":{"self":{"href":"https://api.github.com/repos/substack/tape/pulls/comments/84178740"},"html":{"href":"https://github.com/substack/tape/pull/330#discussion_r84178740"},"pull_request":{"href":"https://api.github.com/repos/substack/tape/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/substack/tape/pulls/330","id":89708879,"html_url":"https://github.com/substack/tape/pull/330","diff_url":"https://github.com/substack/tape/pull/330.diff","patch_url":"https://github.com/substack/tape/pull/330.patch","issue_url":"https://api.github.com/repos/substack/tape/issues/330","number":330,"state":"open","locked":false,"title":"Show full stack on failure","user":{"login":"AnIrishDuck","id":289125,"avatar_url":"https://avatars.githubusercontent.com/u/289125?v=3","gravatar_id":"","url":"https://api.github.com/users/AnIrishDuck","html_url":"https://github.com/AnIrishDuck","followers_url":"https://api.github.com/users/AnIrishDuck/followers","following_url":"https://api.github.com/users/AnIrishDuck/following{/other_user}","gists_url":"https://api.github.com/users/AnIrishDuck/gists{/gist_id}","starred_url":"https://api.github.com/users/AnIrishDuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnIrishDuck/subscriptions","organizations_url":"https://api.github.com/users/AnIrishDuck/orgs","repos_url":"https://api.github.com/users/AnIrishDuck/repos","events_url":"https://api.github.com/users/AnIrishDuck/events{/privacy}","received_events_url":"https://api.github.com/users/AnIrishDuck/received_events","type":"User","site_admin":false},"body":"I rebased #265 and fixed all the tests. The easiest solution to fixing most tests was to strip out the stack trace parts that will change from machine to machine.\r\n\r\n@devTristan @ljharb ","created_at":"2016-10-17T21:41:33Z","updated_at":"2016-10-19T22:11:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"688eb23a29c0a54f4d354ae2bb7f4ccb41089b0a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/substack/tape/pulls/330/commits","review_comments_url":"https://api.github.com/repos/substack/tape/pulls/330/comments","review_comment_url":"https://api.github.com/repos/substack/tape/pulls/comments{/number}","comments_url":"https://api.github.com/repos/substack/tape/issues/330/comments","statuses_url":"https://api.github.com/repos/substack/tape/statuses/4472fc45cdee41bc75782f669ef3c7dd58607673","head":{"label":"AnIrishDuck:complete-stack","ref":"complete-stack","sha":"4472fc45cdee41bc75782f669ef3c7dd58607673","user":{"login":"AnIrishDuck","id":289125,"avatar_url":"https://avatars.githubusercontent.com/u/289125?v=3","gravatar_id":"","url":"https://api.github.com/users/AnIrishDuck","html_url":"https://github.com/AnIrishDuck","followers_url":"https://api.github.com/users/AnIrishDuck/followers","following_url":"https://api.github.com/users/AnIrishDuck/following{/other_user}","gists_url":"https://api.github.com/users/AnIrishDuck/gists{/gist_id}","starred_url":"https://api.github.com/users/AnIrishDuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnIrishDuck/subscriptions","organizations_url":"https://api.github.com/users/AnIrishDuck/orgs","repos_url":"https://api.github.com/users/AnIrishDuck/repos","events_url":"https://api.github.com/users/AnIrishDuck/events{/privacy}","received_events_url":"https://api.github.com/users/AnIrishDuck/received_events","type":"User","site_admin":false},"repo":{"id":71172578,"name":"tape","full_name":"AnIrishDuck/tape","owner":{"login":"AnIrishDuck","id":289125,"avatar_url":"https://avatars.githubusercontent.com/u/289125?v=3","gravatar_id":"","url":"https://api.github.com/users/AnIrishDuck","html_url":"https://github.com/AnIrishDuck","followers_url":"https://api.github.com/users/AnIrishDuck/followers","following_url":"https://api.github.com/users/AnIrishDuck/following{/other_user}","gists_url":"https://api.github.com/users/AnIrishDuck/gists{/gist_id}","starred_url":"https://api.github.com/users/AnIrishDuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnIrishDuck/subscriptions","organizations_url":"https://api.github.com/users/AnIrishDuck/orgs","repos_url":"https://api.github.com/users/AnIrishDuck/repos","events_url":"https://api.github.com/users/AnIrishDuck/events{/privacy}","received_events_url":"https://api.github.com/users/AnIrishDuck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnIrishDuck/tape","description":"tap-producing test harness for node and browsers","fork":true,"url":"https://api.github.com/repos/AnIrishDuck/tape","forks_url":"https://api.github.com/repos/AnIrishDuck/tape/forks","keys_url":"https://api.github.com/repos/AnIrishDuck/tape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnIrishDuck/tape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnIrishDuck/tape/teams","hooks_url":"https://api.github.com/repos/AnIrishDuck/tape/hooks","issue_events_url":"https://api.github.com/repos/AnIrishDuck/tape/issues/events{/number}","events_url":"https://api.github.com/repos/AnIrishDuck/tape/events","assignees_url":"https://api.github.com/repos/AnIrishDuck/tape/assignees{/user}","branches_url":"https://api.github.com/repos/AnIrishDuck/tape/branches{/branch}","tags_url":"https://api.github.com/repos/AnIrishDuck/tape/tags","blobs_url":"https://api.github.com/repos/AnIrishDuck/tape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnIrishDuck/tape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnIrishDuck/tape/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnIrishDuck/tape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnIrishDuck/tape/statuses/{sha}","languages_url":"https://api.github.com/repos/AnIrishDuck/tape/languages","stargazers_url":"https://api.github.com/repos/AnIrishDuck/tape/stargazers","contributors_url":"https://api.github.com/repos/AnIrishDuck/tape/contributors","subscribers_url":"https://api.github.com/repos/AnIrishDuck/tape/subscribers","subscription_url":"https://api.github.com/repos/AnIrishDuck/tape/subscription","commits_url":"https://api.github.com/repos/AnIrishDuck/tape/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnIrishDuck/tape/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnIrishDuck/tape/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnIrishDuck/tape/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnIrishDuck/tape/contents/{+path}","compare_url":"https://api.github.com/repos/AnIrishDuck/tape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnIrishDuck/tape/merges","archive_url":"https://api.github.com/repos/AnIrishDuck/tape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnIrishDuck/tape/downloads","issues_url":"https://api.github.com/repos/AnIrishDuck/tape/issues{/number}","pulls_url":"https://api.github.com/repos/AnIrishDuck/tape/pulls{/number}","milestones_url":"https://api.github.com/repos/AnIrishDuck/tape/milestones{/number}","notifications_url":"https://api.github.com/repos/AnIrishDuck/tape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnIrishDuck/tape/labels{/name}","releases_url":"https://api.github.com/repos/AnIrishDuck/tape/releases{/id}","deployments_url":"https://api.github.com/repos/AnIrishDuck/tape/deployments","created_at":"2016-10-17T19:16:21Z","updated_at":"2016-10-17T19:16:22Z","pushed_at":"2016-10-17T22:53:32Z","git_url":"git://github.com/AnIrishDuck/tape.git","ssh_url":"git@github.com:AnIrishDuck/tape.git","clone_url":"https://github.com/AnIrishDuck/tape.git","svn_url":"https://github.com/AnIrishDuck/tape","homepage":null,"size":357,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"substack:master","ref":"master","sha":"c9b8ce83e875f556acdb0cc46d6cec9a3c057bd3","user":{"login":"substack","id":12631,"avatar_url":"https://avatars.githubusercontent.com/u/12631?v=3","gravatar_id":"","url":"https://api.github.com/users/substack","html_url":"https://github.com/substack","followers_url":"https://api.github.com/users/substack/followers","following_url":"https://api.github.com/users/substack/following{/other_user}","gists_url":"https://api.github.com/users/substack/gists{/gist_id}","starred_url":"https://api.github.com/users/substack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substack/subscriptions","organizations_url":"https://api.github.com/users/substack/orgs","repos_url":"https://api.github.com/users/substack/repos","events_url":"https://api.github.com/users/substack/events{/privacy}","received_events_url":"https://api.github.com/users/substack/received_events","type":"User","site_admin":false},"repo":{"id":6853358,"name":"tape","full_name":"substack/tape","owner":{"login":"substack","id":12631,"avatar_url":"https://avatars.githubusercontent.com/u/12631?v=3","gravatar_id":"","url":"https://api.github.com/users/substack","html_url":"https://github.com/substack","followers_url":"https://api.github.com/users/substack/followers","following_url":"https://api.github.com/users/substack/following{/other_user}","gists_url":"https://api.github.com/users/substack/gists{/gist_id}","starred_url":"https://api.github.com/users/substack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/substack/subscriptions","organizations_url":"https://api.github.com/users/substack/orgs","repos_url":"https://api.github.com/users/substack/repos","events_url":"https://api.github.com/users/substack/events{/privacy}","received_events_url":"https://api.github.com/users/substack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/substack/tape","description":"tap-producing test harness for node and browsers","fork":false,"url":"https://api.github.com/repos/substack/tape","forks_url":"https://api.github.com/repos/substack/tape/forks","keys_url":"https://api.github.com/repos/substack/tape/keys{/key_id}","collaborators_url":"https://api.github.com/repos/substack/tape/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/substack/tape/teams","hooks_url":"https://api.github.com/repos/substack/tape/hooks","issue_events_url":"https://api.github.com/repos/substack/tape/issues/events{/number}","events_url":"https://api.github.com/repos/substack/tape/events","assignees_url":"https://api.github.com/repos/substack/tape/assignees{/user}","branches_url":"https://api.github.com/repos/substack/tape/branches{/branch}","tags_url":"https://api.github.com/repos/substack/tape/tags","blobs_url":"https://api.github.com/repos/substack/tape/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/substack/tape/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/substack/tape/git/refs{/sha}","trees_url":"https://api.github.com/repos/substack/tape/git/trees{/sha}","statuses_url":"https://api.github.com/repos/substack/tape/statuses/{sha}","languages_url":"https://api.github.com/repos/substack/tape/languages","stargazers_url":"https://api.github.com/repos/substack/tape/stargazers","contributors_url":"https://api.github.com/repos/substack/tape/contributors","subscribers_url":"https://api.github.com/repos/substack/tape/subscribers","subscription_url":"https://api.github.com/repos/substack/tape/subscription","commits_url":"https://api.github.com/repos/substack/tape/commits{/sha}","git_commits_url":"https://api.github.com/repos/substack/tape/git/commits{/sha}","comments_url":"https://api.github.com/repos/substack/tape/comments{/number}","issue_comment_url":"https://api.github.com/repos/substack/tape/issues/comments{/number}","contents_url":"https://api.github.com/repos/substack/tape/contents/{+path}","compare_url":"https://api.github.com/repos/substack/tape/compare/{base}...{head}","merges_url":"https://api.github.com/repos/substack/tape/merges","archive_url":"https://api.github.com/repos/substack/tape/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/substack/tape/downloads","issues_url":"https://api.github.com/repos/substack/tape/issues{/number}","pulls_url":"https://api.github.com/repos/substack/tape/pulls{/number}","milestones_url":"https://api.github.com/repos/substack/tape/milestones{/number}","notifications_url":"https://api.github.com/repos/substack/tape/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/substack/tape/labels{/name}","releases_url":"https://api.github.com/repos/substack/tape/releases{/id}","deployments_url":"https://api.github.com/repos/substack/tape/deployments","created_at":"2012-11-25T17:08:02Z","updated_at":"2016-10-19T10:01:39Z","pushed_at":"2016-10-17T22:53:33Z","git_url":"git://github.com/substack/tape.git","ssh_url":"git@github.com:substack/tape.git","clone_url":"https://github.com/substack/tape.git","svn_url":"https://github.com/substack/tape","homepage":null,"size":1805,"stargazers_count":3033,"watchers_count":3033,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":74,"forks":167,"open_issues":74,"watchers":3033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/substack/tape/pulls/330"},"html":{"href":"https://github.com/substack/tape/pull/330"},"issue":{"href":"https://api.github.com/repos/substack/tape/issues/330"},"comments":{"href":"https://api.github.com/repos/substack/tape/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/substack/tape/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/substack/tape/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/substack/tape/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/substack/tape/statuses/4472fc45cdee41bc75782f669ef3c7dd58607673"}}}}
{"actor":{"display_login":"AnIrishDuck"}}