{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4033","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4033/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4033/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4033/events","html_url":"https://github.com/home-assistant/home-assistant/pull/4033","id":184956415,"number":4033,"title":"Geyser component","user":{"login":"PollieKrismis","id":19325937,"avatar_url":"https://avatars.githubusercontent.com/u/19325937?v=3","gravatar_id":"","url":"https://api.github.com/users/PollieKrismis","html_url":"https://github.com/PollieKrismis","followers_url":"https://api.github.com/users/PollieKrismis/followers","following_url":"https://api.github.com/users/PollieKrismis/following{/other_user}","gists_url":"https://api.github.com/users/PollieKrismis/gists{/gist_id}","starred_url":"https://api.github.com/users/PollieKrismis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PollieKrismis/subscriptions","organizations_url":"https://api.github.com/users/PollieKrismis/orgs","repos_url":"https://api.github.com/users/PollieKrismis/repos","events_url":"https://api.github.com/users/PollieKrismis/events{/privacy}","received_events_url":"https://api.github.com/users/PollieKrismis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/Hacktoberfest","name":"Hacktoberfest","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2016-10-24T21:13:41Z","updated_at":"2016-10-27T07:06:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/4033","html_url":"https://github.com/home-assistant/home-assistant/pull/4033","diff_url":"https://github.com/home-assistant/home-assistant/pull/4033.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/4033.patch"},"body":"**Description:**\r\nThis is a proposal for a hot water heater (geyser) component that can be used to add geyser controllers like the GeyserWise, QwikSwitch and other types of geyser controllers. It should also allow people to develop their own raspberry pi controllers.\r\n\r\nCurrently, it only has the demo controller as I suspect there will be many changes before I can start adding the first controller.\r\n\r\nI based it on the climate component which is a close match but it does deviate enough I think to justify a new class of component.\r\n\r\n**Related issue (if applicable):** initial component and demo only\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):**will start on it if component will be accepted (in principle) as I'm not sure this will be accepted as a new component.\r\n\r\n**Example entry for `configuration.yaml` (if applicable):**\r\n```\r\nhot_water_heater:\r\n  platform: demo\r\n```\r\n\r\n**Checklist:**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n (runs forever on pi/travis will give me an answer quicker)\r\n  - [ ] Tests have been added to verify that the new code works.\r\n(Does this refer to the demo controller I added?)\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L16\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L51\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/256563576","html_url":"https://github.com/home-assistant/home-assistant/pull/4033#issuecomment-256563576","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/4033","id":256563576,"user":{"login":"balloob","id":1444314,"avatar_url":"https://avatars.githubusercontent.com/u/1444314?v=3","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T07:06:51Z","updated_at":"2016-10-27T07:06:51Z","body":"In Dutch we call it a geiser indeed but I prefer the name boiler too. The name \"hot water heater\" contains twice a word for heating/warmth, that feels weird.\r\n\r\nThat's a lot of options for a boiler btw, never realised it could have so many options 😮 \r\n\r\nAny new component will also require tests to be written. The tests will need to use the service helper methods on the component to control the demo component. That way all code paths will be tested in both files."}}
{"actor":{"display_login":"balloob"}}