{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/60048210","id":60048210,"diff_hunk":"@@ -36,13 +40,18 @@ import (\n \t\"github.com/coreos/rkt/common\"\n \t\"github.com/coreos/rkt/networking/netinfo\"\n \t\"github.com/coreos/rkt/networking/tuntap\"\n+\t\"github.com/coreos/rkt/pkg/lock\"\n )\n \n const (\n-\tdefaultBrName     = \"kvm-cni0\"\n-\tdefaultSubnetFile = \"/run/flannel/subnet.env\"\n-\tdefaultMTU        = 1500\n-\tmasqComment       = \"rkt-lkvm masquerading\"\n+\tdefaultBrName         = \"kvm-cni0\"\n+\tdefaultSubnetFile     = \"/run/flannel/subnet.env\"\n+\tdefaultMTU            = 1500\n+\tmasqComment           = \"rkt-lkvm masquerading\"\n+\tkvmSettingsDir        = \"/var/lib/rkt-stage1-kvm\"","path":"networking/kvm.go","position":29,"original_position":29,"commit_id":"824f027a0a258177c096c7eecdc0a55d95c623e6","original_commit_id":"824f027a0a258177c096c7eecdc0a55d95c623e6","user":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"body":"Hmmm... I didn't know we had this hardcoded :scream:\r\n\r\nWe should probably make it part of `--local_config` or `--dir` (not sure which one is best) although we don't have a way to access those from here now.\r\n\r\n /cc @krnowak ","created_at":"2016-04-18T12:23:56Z","updated_at":"2016-04-18T12:23:56Z","html_url":"https://github.com/coreos/rkt/pull/2438#discussion_r60048210","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/2438","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/60048210"},"html":{"href":"https://github.com/coreos/rkt/pull/2438#discussion_r60048210"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2438"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/2438","id":66646620,"html_url":"https://github.com/coreos/rkt/pull/2438","diff_url":"https://github.com/coreos/rkt/pull/2438.diff","patch_url":"https://github.com/coreos/rkt/pull/2438.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/2438","number":2438,"state":"open","locked":false,"title":"rkt: rkt stop with ssh-based kvm stop","user":{"login":"0003ydlom","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/0003ydlom","html_url":"https://github.com/0003ydlom","followers_url":"https://api.github.com/users/0003ydlom/followers","following_url":"https://api.github.com/users/0003ydlom/following{/other_user}","gists_url":"https://api.github.com/users/0003ydlom/gists{/gist_id}","starred_url":"https://api.github.com/users/0003ydlom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0003ydlom/subscriptions","organizations_url":"https://api.github.com/users/0003ydlom/orgs","repos_url":"https://api.github.com/users/0003ydlom/repos","events_url":"https://api.github.com/users/0003ydlom/events{/privacy}","received_events_url":"https://api.github.com/users/0003ydlom/received_events","type":"User","site_admin":false},"body":"Idea of stopping pod with KVM flavor based on discussion in https://github.com/coreos/rkt/pull/1959 (I used most of the commits from this PR):\r\nMoving SSH functionalities from enter_kvm.go to networking/kvm.go for reuse purposes, and also reusing this code in stop_kvm to provide proper shutting down mechanism (systemctl halt).\r\n@iaguis @jellonek ","created_at":"2016-04-15T13:57:18Z","updated_at":"2016-04-18T12:23:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f65107a9ec48f1b888ad631f8531ebdb4aaa45c","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/36","html_url":"https://github.com/coreos/rkt/milestones/v1.5.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/36/labels","id":1676113,"number":36,"title":"v1.5.0","description":"","creator":{"login":"alban","id":27575,"avatar_url":"https://avatars.githubusercontent.com/u/27575?v=3","gravatar_id":"","url":"https://api.github.com/users/alban","html_url":"https://github.com/alban","followers_url":"https://api.github.com/users/alban/followers","following_url":"https://api.github.com/users/alban/following{/other_user}","gists_url":"https://api.github.com/users/alban/gists{/gist_id}","starred_url":"https://api.github.com/users/alban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alban/subscriptions","organizations_url":"https://api.github.com/users/alban/orgs","repos_url":"https://api.github.com/users/alban/repos","events_url":"https://api.github.com/users/alban/events{/privacy}","received_events_url":"https://api.github.com/users/alban/received_events","type":"User","site_admin":false},"open_issues":69,"closed_issues":5,"state":"open","created_at":"2016-03-31T14:05:09Z","updated_at":"2016-04-18T11:09:29Z","due_on":"2016-04-27T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/2438/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/2438/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/2438/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/824f027a0a258177c096c7eecdc0a55d95c623e6","head":{"label":"0003ydlom:kinvolk-rkt-stop2","ref":"kinvolk-rkt-stop2","sha":"824f027a0a258177c096c7eecdc0a55d95c623e6","user":{"login":"0003ydlom","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/0003ydlom","html_url":"https://github.com/0003ydlom","followers_url":"https://api.github.com/users/0003ydlom/followers","following_url":"https://api.github.com/users/0003ydlom/following{/other_user}","gists_url":"https://api.github.com/users/0003ydlom/gists{/gist_id}","starred_url":"https://api.github.com/users/0003ydlom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0003ydlom/subscriptions","organizations_url":"https://api.github.com/users/0003ydlom/orgs","repos_url":"https://api.github.com/users/0003ydlom/repos","events_url":"https://api.github.com/users/0003ydlom/events{/privacy}","received_events_url":"https://api.github.com/users/0003ydlom/received_events","type":"User","site_admin":false},"repo":{"id":56220031,"name":"rkt","full_name":"0003ydlom/rkt","owner":{"login":"0003ydlom","id":12859079,"avatar_url":"https://avatars.githubusercontent.com/u/12859079?v=3","gravatar_id":"","url":"https://api.github.com/users/0003ydlom","html_url":"https://github.com/0003ydlom","followers_url":"https://api.github.com/users/0003ydlom/followers","following_url":"https://api.github.com/users/0003ydlom/following{/other_user}","gists_url":"https://api.github.com/users/0003ydlom/gists{/gist_id}","starred_url":"https://api.github.com/users/0003ydlom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0003ydlom/subscriptions","organizations_url":"https://api.github.com/users/0003ydlom/orgs","repos_url":"https://api.github.com/users/0003ydlom/repos","events_url":"https://api.github.com/users/0003ydlom/events{/privacy}","received_events_url":"https://api.github.com/users/0003ydlom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0003ydlom/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/0003ydlom/rkt","forks_url":"https://api.github.com/repos/0003ydlom/rkt/forks","keys_url":"https://api.github.com/repos/0003ydlom/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0003ydlom/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0003ydlom/rkt/teams","hooks_url":"https://api.github.com/repos/0003ydlom/rkt/hooks","issue_events_url":"https://api.github.com/repos/0003ydlom/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/0003ydlom/rkt/events","assignees_url":"https://api.github.com/repos/0003ydlom/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/0003ydlom/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/0003ydlom/rkt/tags","blobs_url":"https://api.github.com/repos/0003ydlom/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0003ydlom/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0003ydlom/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/0003ydlom/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0003ydlom/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/0003ydlom/rkt/languages","stargazers_url":"https://api.github.com/repos/0003ydlom/rkt/stargazers","contributors_url":"https://api.github.com/repos/0003ydlom/rkt/contributors","subscribers_url":"https://api.github.com/repos/0003ydlom/rkt/subscribers","subscription_url":"https://api.github.com/repos/0003ydlom/rkt/subscription","commits_url":"https://api.github.com/repos/0003ydlom/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/0003ydlom/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/0003ydlom/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/0003ydlom/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/0003ydlom/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/0003ydlom/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0003ydlom/rkt/merges","archive_url":"https://api.github.com/repos/0003ydlom/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0003ydlom/rkt/downloads","issues_url":"https://api.github.com/repos/0003ydlom/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/0003ydlom/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/0003ydlom/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/0003ydlom/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0003ydlom/rkt/labels{/name}","releases_url":"https://api.github.com/repos/0003ydlom/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/0003ydlom/rkt/deployments","created_at":"2016-04-14T08:23:44Z","updated_at":"2016-04-14T08:23:46Z","pushed_at":"2016-04-15T15:00:32Z","git_url":"git://github.com/0003ydlom/rkt.git","ssh_url":"git@github.com:0003ydlom/rkt.git","clone_url":"https://github.com/0003ydlom/rkt.git","svn_url":"https://github.com/0003ydlom/rkt","homepage":"","size":19813,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"02438c55fbd406cadd6dfc4292f05336d1f86cbe","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/rkt/deployments","created_at":"2014-11-11T23:13:18Z","updated_at":"2016-04-18T09:11:26Z","pushed_at":"2016-04-18T11:40:41Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":23716,"stargazers_count":5411,"watchers_count":5411,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":497,"mirror_url":null,"open_issues_count":290,"forks":497,"open_issues":290,"watchers":5411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2438"},"html":{"href":"https://github.com/coreos/rkt/pull/2438"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/2438"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/2438/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2438/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/2438/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/824f027a0a258177c096c7eecdc0a55d95c623e6"}}}}