{"action":"created","comment":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments/72659352","id":72659352,"diff_hunk":"@@ -18,7 +18,8 @@\n # GregorioRef.tex must be the first source file\n SRCFILES = GregorioRef.tex Command_Index_gregorio.tex \\\n \t\t   Command_Index_internal.tex Command_Index_User.tex \\\n-\t\t   Gabc.tex Appendix_Font_Tables.tex GregorioRef.lua factus.gabc\n+\t\t   Gabc.tex Appendix_Font_Tables.tex GregorioRef.lua factus.gabc \\\n+\t\t   scorefonttable.lua extrafonttable.lua\n NABCSRCFILES = GregorioNabcRef.tex veni.gabc","path":"doc/Makefile.am","position":7,"original_position":7,"commit_id":"367eceeae2452eb6c40b0fab1dd7e9545713d13c","original_commit_id":"367eceeae2452eb6c40b0fab1dd7e9545713d13c","user":{"login":"rpspringuel","id":7671682,"avatar_url":"https://avatars.githubusercontent.com/u/7671682?v=3","gravatar_id":"","url":"https://api.github.com/users/rpspringuel","html_url":"https://github.com/rpspringuel","followers_url":"https://api.github.com/users/rpspringuel/followers","following_url":"https://api.github.com/users/rpspringuel/following{/other_user}","gists_url":"https://api.github.com/users/rpspringuel/gists{/gist_id}","starred_url":"https://api.github.com/users/rpspringuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpspringuel/subscriptions","organizations_url":"https://api.github.com/users/rpspringuel/orgs","repos_url":"https://api.github.com/users/rpspringuel/repos","events_url":"https://api.github.com/users/rpspringuel/events{/privacy}","received_events_url":"https://api.github.com/users/rpspringuel/received_events","type":"User","site_admin":false},"body":"There are a couple of other places where the new files may needed to be added to manifests.  Off-hand, I think the installers for Mac and Windows might need them (though, since the new files are lua file, they may be picked up by wild cards).  You should also check `install-gtex.sh`.","created_at":"2016-07-28T16:53:38Z","updated_at":"2016-07-28T16:53:38Z","html_url":"https://github.com/gregorio-project/gregorio/pull/1194#discussion_r72659352","pull_request_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194","_links":{"self":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments/72659352"},"html":{"href":"https://github.com/gregorio-project/gregorio/pull/1194#discussion_r72659352"},"pull_request":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194"}}},"pull_request":{"url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194","id":79134695,"html_url":"https://github.com/gregorio-project/gregorio/pull/1194","diff_url":"https://github.com/gregorio-project/gregorio/pull/1194.diff","patch_url":"https://github.com/gregorio-project/gregorio/pull/1194.patch","issue_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/1194","number":1194,"state":"open","locked":false,"title":"Switched to generating font tables as input files.","user":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"body":"An attempt to fix #1188.\r\n\r\nThis works around the font loader issue, allowing the document to be built under TeX Live 2016.\r\n\r\nHowever, doing it this way causes a segfault under (Gentoo's packaged version of) TeX Live 2015 unless the luatex font cache is cleared between runs of lualatex or if I `\\input` the Dominican font table before the \"normal\" font table.  Since this doesn't happen under 2016, the bug is obviously fixed.\r\n\r\nIs it good enough to abandon building the document under 2015, knowing that we build it anyway for distribution?  If so, then I think this is ready for review/merge.","created_at":"2016-07-28T04:09:31Z","updated_at":"2016-07-28T16:53:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77e1d5a58ce19e8ee008428e1d0aeb09430a63b5","assignee":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"assignees":[{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gregorio-project/gregorio/milestones/7","html_url":"https://github.com/gregorio-project/gregorio/milestones/4.2","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/milestones/7/labels","id":1618956,"number":7,"title":"4.2","description":"Feature enhancements to 4.1 that won't require a major version","creator":{"login":"rpspringuel","id":7671682,"avatar_url":"https://avatars.githubusercontent.com/u/7671682?v=3","gravatar_id":"","url":"https://api.github.com/users/rpspringuel","html_url":"https://github.com/rpspringuel","followers_url":"https://api.github.com/users/rpspringuel/followers","following_url":"https://api.github.com/users/rpspringuel/following{/other_user}","gists_url":"https://api.github.com/users/rpspringuel/gists{/gist_id}","starred_url":"https://api.github.com/users/rpspringuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpspringuel/subscriptions","organizations_url":"https://api.github.com/users/rpspringuel/orgs","repos_url":"https://api.github.com/users/rpspringuel/repos","events_url":"https://api.github.com/users/rpspringuel/events{/privacy}","received_events_url":"https://api.github.com/users/rpspringuel/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":85,"state":"open","created_at":"2016-03-02T22:16:58Z","updated_at":"2016-07-28T04:09:31Z","due_on":"2016-04-29T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194/commits","review_comments_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194/comments","review_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/1194/comments","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/367eceeae2452eb6c40b0fab1dd7e9545713d13c","head":{"label":"henryso:fix-1188","ref":"fix-1188","sha":"367eceeae2452eb6c40b0fab1dd7e9545713d13c","user":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"repo":{"id":32427414,"name":"gregorio","full_name":"henryso/gregorio","owner":{"login":"henryso","id":421318,"avatar_url":"https://avatars.githubusercontent.com/u/421318?v=3","gravatar_id":"","url":"https://api.github.com/users/henryso","html_url":"https://github.com/henryso","followers_url":"https://api.github.com/users/henryso/followers","following_url":"https://api.github.com/users/henryso/following{/other_user}","gists_url":"https://api.github.com/users/henryso/gists{/gist_id}","starred_url":"https://api.github.com/users/henryso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryso/subscriptions","organizations_url":"https://api.github.com/users/henryso/orgs","repos_url":"https://api.github.com/users/henryso/repos","events_url":"https://api.github.com/users/henryso/events{/privacy}","received_events_url":"https://api.github.com/users/henryso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henryso/gregorio","description":"source for the gregorio project","fork":true,"url":"https://api.github.com/repos/henryso/gregorio","forks_url":"https://api.github.com/repos/henryso/gregorio/forks","keys_url":"https://api.github.com/repos/henryso/gregorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henryso/gregorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henryso/gregorio/teams","hooks_url":"https://api.github.com/repos/henryso/gregorio/hooks","issue_events_url":"https://api.github.com/repos/henryso/gregorio/issues/events{/number}","events_url":"https://api.github.com/repos/henryso/gregorio/events","assignees_url":"https://api.github.com/repos/henryso/gregorio/assignees{/user}","branches_url":"https://api.github.com/repos/henryso/gregorio/branches{/branch}","tags_url":"https://api.github.com/repos/henryso/gregorio/tags","blobs_url":"https://api.github.com/repos/henryso/gregorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henryso/gregorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henryso/gregorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/henryso/gregorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henryso/gregorio/statuses/{sha}","languages_url":"https://api.github.com/repos/henryso/gregorio/languages","stargazers_url":"https://api.github.com/repos/henryso/gregorio/stargazers","contributors_url":"https://api.github.com/repos/henryso/gregorio/contributors","subscribers_url":"https://api.github.com/repos/henryso/gregorio/subscribers","subscription_url":"https://api.github.com/repos/henryso/gregorio/subscription","commits_url":"https://api.github.com/repos/henryso/gregorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/henryso/gregorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/henryso/gregorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/henryso/gregorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/henryso/gregorio/contents/{+path}","compare_url":"https://api.github.com/repos/henryso/gregorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henryso/gregorio/merges","archive_url":"https://api.github.com/repos/henryso/gregorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henryso/gregorio/downloads","issues_url":"https://api.github.com/repos/henryso/gregorio/issues{/number}","pulls_url":"https://api.github.com/repos/henryso/gregorio/pulls{/number}","milestones_url":"https://api.github.com/repos/henryso/gregorio/milestones{/number}","notifications_url":"https://api.github.com/repos/henryso/gregorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henryso/gregorio/labels{/name}","releases_url":"https://api.github.com/repos/henryso/gregorio/releases{/id}","deployments_url":"https://api.github.com/repos/henryso/gregorio/deployments","created_at":"2015-03-17T23:57:54Z","updated_at":"2016-01-12T05:32:43Z","pushed_at":"2016-07-28T10:43:58Z","git_url":"git://github.com/henryso/gregorio.git","ssh_url":"git@github.com:henryso/gregorio.git","clone_url":"https://github.com/henryso/gregorio.git","svn_url":"https://github.com/henryso/gregorio","homepage":"http://home.gna.org/gregorio/","size":83384,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gregorio-project:release-4.2","ref":"release-4.2","sha":"c5bc27387d1b7f9daa64c9c0537fe5506879060f","user":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"repo":{"id":20884374,"name":"gregorio","full_name":"gregorio-project/gregorio","owner":{"login":"gregorio-project","id":7902256,"avatar_url":"https://avatars.githubusercontent.com/u/7902256?v=3","gravatar_id":"","url":"https://api.github.com/users/gregorio-project","html_url":"https://github.com/gregorio-project","followers_url":"https://api.github.com/users/gregorio-project/followers","following_url":"https://api.github.com/users/gregorio-project/following{/other_user}","gists_url":"https://api.github.com/users/gregorio-project/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorio-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorio-project/subscriptions","organizations_url":"https://api.github.com/users/gregorio-project/orgs","repos_url":"https://api.github.com/users/gregorio-project/repos","events_url":"https://api.github.com/users/gregorio-project/events{/privacy}","received_events_url":"https://api.github.com/users/gregorio-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gregorio-project/gregorio","description":"The Gregorio Project","fork":false,"url":"https://api.github.com/repos/gregorio-project/gregorio","forks_url":"https://api.github.com/repos/gregorio-project/gregorio/forks","keys_url":"https://api.github.com/repos/gregorio-project/gregorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregorio-project/gregorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregorio-project/gregorio/teams","hooks_url":"https://api.github.com/repos/gregorio-project/gregorio/hooks","issue_events_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/events{/number}","events_url":"https://api.github.com/repos/gregorio-project/gregorio/events","assignees_url":"https://api.github.com/repos/gregorio-project/gregorio/assignees{/user}","branches_url":"https://api.github.com/repos/gregorio-project/gregorio/branches{/branch}","tags_url":"https://api.github.com/repos/gregorio-project/gregorio/tags","blobs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregorio-project/gregorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregorio-project/gregorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregorio-project/gregorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregorio-project/gregorio/statuses/{sha}","languages_url":"https://api.github.com/repos/gregorio-project/gregorio/languages","stargazers_url":"https://api.github.com/repos/gregorio-project/gregorio/stargazers","contributors_url":"https://api.github.com/repos/gregorio-project/gregorio/contributors","subscribers_url":"https://api.github.com/repos/gregorio-project/gregorio/subscribers","subscription_url":"https://api.github.com/repos/gregorio-project/gregorio/subscription","commits_url":"https://api.github.com/repos/gregorio-project/gregorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregorio-project/gregorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregorio-project/gregorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregorio-project/gregorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregorio-project/gregorio/contents/{+path}","compare_url":"https://api.github.com/repos/gregorio-project/gregorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregorio-project/gregorio/merges","archive_url":"https://api.github.com/repos/gregorio-project/gregorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregorio-project/gregorio/downloads","issues_url":"https://api.github.com/repos/gregorio-project/gregorio/issues{/number}","pulls_url":"https://api.github.com/repos/gregorio-project/gregorio/pulls{/number}","milestones_url":"https://api.github.com/repos/gregorio-project/gregorio/milestones{/number}","notifications_url":"https://api.github.com/repos/gregorio-project/gregorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregorio-project/gregorio/labels{/name}","releases_url":"https://api.github.com/repos/gregorio-project/gregorio/releases{/id}","deployments_url":"https://api.github.com/repos/gregorio-project/gregorio/deployments","created_at":"2014-06-16T12:41:52Z","updated_at":"2016-07-12T07:56:21Z","pushed_at":"2016-07-28T10:43:59Z","git_url":"git://github.com/gregorio-project/gregorio.git","ssh_url":"git@github.com:gregorio-project/gregorio.git","clone_url":"https://github.com/gregorio-project/gregorio.git","svn_url":"https://github.com/gregorio-project/gregorio","homepage":"http://gregorio-project.github.io","size":85134,"stargazers_count":35,"watchers_count":35,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":29,"forks":15,"open_issues":29,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194"},"html":{"href":"https://github.com/gregorio-project/gregorio/pull/1194"},"issue":{"href":"https://api.github.com/repos/gregorio-project/gregorio/issues/1194"},"comments":{"href":"https://api.github.com/repos/gregorio-project/gregorio/issues/1194/comments"},"review_comments":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194/comments"},"review_comment":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gregorio-project/gregorio/pulls/1194/commits"},"statuses":{"href":"https://api.github.com/repos/gregorio-project/gregorio/statuses/367eceeae2452eb6c40b0fab1dd7e9545713d13c"}}}}
{"actor":{"display_login":"rpspringuel"}}