{"action":"closed","number":167,"pull_request":{"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/167","id":76934036,"html_url":"https://github.com/jitsi/lib-jitsi-meet/pull/167","diff_url":"https://github.com/jitsi/lib-jitsi-meet/pull/167.diff","patch_url":"https://github.com/jitsi/lib-jitsi-meet/pull/167.patch","issue_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/167","number":167,"state":"closed","locked":false,"title":"Clean up event listeners attached inside JitsiConference and related classes","user":{"login":"tsareg","id":1167285,"avatar_url":"https://avatars.githubusercontent.com/u/1167285?v=3","gravatar_id":"","url":"https://api.github.com/users/tsareg","html_url":"https://github.com/tsareg","followers_url":"https://api.github.com/users/tsareg/followers","following_url":"https://api.github.com/users/tsareg/following{/other_user}","gists_url":"https://api.github.com/users/tsareg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsareg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsareg/subscriptions","organizations_url":"https://api.github.com/users/tsareg/orgs","repos_url":"https://api.github.com/users/tsareg/repos","events_url":"https://api.github.com/users/tsareg/events{/privacy}","received_events_url":"https://api.github.com/users/tsareg/received_events","type":"User","site_admin":false},"body":"Since we are moving to single page web app and native app in scope of jitsi-meet-react project, it's important for us to work better with memory and do not allow possible memory leaks.\r\n\r\nThis PR is the first step towards better memory management. Here we clean up all event listeners attached to JitsiConference and some other related classes like ChatRoom, RTC, Moderator, JitsiTrack etc.\r\nAlso we clean up events attached to window.\r\n\r\nFuture PRs will address JitsiConference and XMPP classes and also some static classes like JitsiMeetJS, RTC, RTCUtils.","created_at":"2016-07-11T10:52:13Z","updated_at":"2016-07-20T15:07:57Z","closed_at":"2016-07-20T15:07:57Z","merged_at":null,"merge_commit_sha":"a066393bb4662cae68bf0646bd6eec7998708238","assignee":{"login":"hristoterezov","id":1729265,"avatar_url":"https://avatars.githubusercontent.com/u/1729265?v=3","gravatar_id":"","url":"https://api.github.com/users/hristoterezov","html_url":"https://github.com/hristoterezov","followers_url":"https://api.github.com/users/hristoterezov/followers","following_url":"https://api.github.com/users/hristoterezov/following{/other_user}","gists_url":"https://api.github.com/users/hristoterezov/gists{/gist_id}","starred_url":"https://api.github.com/users/hristoterezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hristoterezov/subscriptions","organizations_url":"https://api.github.com/users/hristoterezov/orgs","repos_url":"https://api.github.com/users/hristoterezov/repos","events_url":"https://api.github.com/users/hristoterezov/events{/privacy}","received_events_url":"https://api.github.com/users/hristoterezov/received_events","type":"User","site_admin":false},"assignees":[{"login":"hristoterezov","id":1729265,"avatar_url":"https://avatars.githubusercontent.com/u/1729265?v=3","gravatar_id":"","url":"https://api.github.com/users/hristoterezov","html_url":"https://github.com/hristoterezov","followers_url":"https://api.github.com/users/hristoterezov/followers","following_url":"https://api.github.com/users/hristoterezov/following{/other_user}","gists_url":"https://api.github.com/users/hristoterezov/gists{/gist_id}","starred_url":"https://api.github.com/users/hristoterezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hristoterezov/subscriptions","organizations_url":"https://api.github.com/users/hristoterezov/orgs","repos_url":"https://api.github.com/users/hristoterezov/repos","events_url":"https://api.github.com/users/hristoterezov/events{/privacy}","received_events_url":"https://api.github.com/users/hristoterezov/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/167/commits","review_comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/167/comments","review_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/167/comments","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/b32807b932b86b60489c0c8c4e7a5aeb1a27fccb","head":{"label":"tsareg:conference_dispose","ref":"conference_dispose","sha":"b32807b932b86b60489c0c8c4e7a5aeb1a27fccb","user":{"login":"tsareg","id":1167285,"avatar_url":"https://avatars.githubusercontent.com/u/1167285?v=3","gravatar_id":"","url":"https://api.github.com/users/tsareg","html_url":"https://github.com/tsareg","followers_url":"https://api.github.com/users/tsareg/followers","following_url":"https://api.github.com/users/tsareg/following{/other_user}","gists_url":"https://api.github.com/users/tsareg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsareg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsareg/subscriptions","organizations_url":"https://api.github.com/users/tsareg/orgs","repos_url":"https://api.github.com/users/tsareg/repos","events_url":"https://api.github.com/users/tsareg/events{/privacy}","received_events_url":"https://api.github.com/users/tsareg/received_events","type":"User","site_admin":false},"repo":{"id":58113471,"name":"lib-jitsi-meet","full_name":"tsareg/lib-jitsi-meet","owner":{"login":"tsareg","id":1167285,"avatar_url":"https://avatars.githubusercontent.com/u/1167285?v=3","gravatar_id":"","url":"https://api.github.com/users/tsareg","html_url":"https://github.com/tsareg","followers_url":"https://api.github.com/users/tsareg/followers","following_url":"https://api.github.com/users/tsareg/following{/other_user}","gists_url":"https://api.github.com/users/tsareg/gists{/gist_id}","starred_url":"https://api.github.com/users/tsareg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsareg/subscriptions","organizations_url":"https://api.github.com/users/tsareg/orgs","repos_url":"https://api.github.com/users/tsareg/repos","events_url":"https://api.github.com/users/tsareg/events{/privacy}","received_events_url":"https://api.github.com/users/tsareg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsareg/lib-jitsi-meet","description":"","fork":true,"url":"https://api.github.com/repos/tsareg/lib-jitsi-meet","forks_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/tsareg/lib-jitsi-meet/deployments","created_at":"2016-05-05T07:42:00Z","updated_at":"2016-05-05T07:42:02Z","pushed_at":"2016-07-20T12:08:08Z","git_url":"git://github.com/tsareg/lib-jitsi-meet.git","ssh_url":"git@github.com:tsareg/lib-jitsi-meet.git","clone_url":"https://github.com/tsareg/lib-jitsi-meet.git","svn_url":"https://github.com/tsareg/lib-jitsi-meet","homepage":null,"size":3702,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:master","ref":"master","sha":"568475fa07282b861e56d3c1ab5ad58a8f991c5d","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":50543360,"name":"lib-jitsi-meet","full_name":"jitsi/lib-jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/lib-jitsi-meet","description":"","fork":false,"url":"https://api.github.com/repos/jitsi/lib-jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/releases{/id}","deployments_url":"https://api.github.com/repos/jitsi/lib-jitsi-meet/deployments","created_at":"2016-01-27T22:44:09Z","updated_at":"2016-07-10T11:37:57Z","pushed_at":"2016-07-19T16:55:19Z","git_url":"git://github.com/jitsi/lib-jitsi-meet.git","ssh_url":"git@github.com:jitsi/lib-jitsi-meet.git","clone_url":"https://github.com/jitsi/lib-jitsi-meet.git","svn_url":"https://github.com/jitsi/lib-jitsi-meet","homepage":null,"size":3780,"stargazers_count":15,"watchers_count":15,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":15,"forks":33,"open_issues":15,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/167"},"html":{"href":"https://github.com/jitsi/lib-jitsi-meet/pull/167"},"issue":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/167"},"comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/lib-jitsi-meet/statuses/b32807b932b86b60489c0c8c4e7a5aeb1a27fccb"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":2,"commits":1,"additions":202,"deletions":101,"changed_files":7}}
{"actor":{"display_login":"tsareg"}}