{"push_id":1185838728,"size":40,"distinct_size":40,"ref":"refs/heads/master","head":"edc5603b1d0987ab60637d562c82c8f2ca9fd8f9","before":"49a881e0db1ef64fcbae2b7ddccfd5ccea26ae01","commits":[{"sha":"b50f5a5ac6fc554eaad3138cb42f678a41794771","author":{"name":"Matthew Draper","email":"4dc1fb8cebf1553ab7fd31206f1e48fe4714fa6e@trebex.net"},"message":"Don't inherit from Concurrent::CountDownLatch\n\nThat class mangles .new, which interferes with our deprecation warning.\n\nMore generally, it suggests we shouldn't be subclassing without a very\ngood reason, and avoiding one allocation doesn't seem to meet that\ncriteria.\n\nIn passing, recommend the simpler Concurrent::Event for the common\ncount=1 case.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/b50f5a5ac6fc554eaad3138cb42f678a41794771"},{"sha":"0d3cf26b673fafa950472aa4718de9a6630b45b4","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"- Renamed NestedParametersTest to NestedParametersPermitTest, to indicate what we are actually testing in this file","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/0d3cf26b673fafa950472aa4718de9a6630b45b4"},{"sha":"16bb3d6f122c32e828a23ba24ffb14d60fdb9ba3","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Make `foreign_keys` queries to `SCHEMA`","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/16bb3d6f122c32e828a23ba24ffb14d60fdb9ba3"},{"sha":"7b7b7c5ce62e1ede29dad4ae1ce613bd12f8089c","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Extract foreign key action from `information_schema`\n\nFixes #25300.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/7b7b7c5ce62e1ede29dad4ae1ce613bd12f8089c"},{"sha":"04b4a0666bdf900f9a4e797022dfe0197eebef6a","author":{"name":"Matthew Draper","email":"4dc1fb8cebf1553ab7fd31206f1e48fe4714fa6e@trebex.net"},"message":"Provide a middleware to debug misbehaving locks\n\nOnly intended to be enabled when in use; by necessity, it sits above any\nreasonable access control.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/04b4a0666bdf900f9a4e797022dfe0197eebef6a"},{"sha":"e292ce8a4f4559aed6faef58e03ced649513cf2f","author":{"name":"Benjamin Quorning","email":"1732970c1f51020a107e1f6d2aa981e54dceaf3d@quorning.net"},"message":"Add ActiveRecord::Result#first\n\nWhen you only need the first element of a result set, you shouldn't need to\ninstantiate all of hash_rows.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/e292ce8a4f4559aed6faef58e03ced649513cf2f"},{"sha":"af834fb2c03358fe9a1b8fd9ec36eb5658a63260","author":{"name":"Benjamin Quorning","email":"1732970c1f51020a107e1f6d2aa981e54dceaf3d@quorning.net"},"message":"Remove MySQL::DatabaseStatements#select_one\n\nThe implementation from abstract/database_statements.rb seems to work just fine.\nAnd with ActiveRecord::Result now implementing an optimized #first method, the\nperformance concerns previously addressed in\nhttps://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f\nshould not be an issue.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/af834fb2c03358fe9a1b8fd9ec36eb5658a63260"},{"sha":"763de2ac1c85d3e9f82639783a55244d6c0517c2","author":{"name":"Benjamin Quorning","email":"1732970c1f51020a107e1f6d2aa981e54dceaf3d@quorning.net"},"message":"Optimize ActiveRecord::Result#last\n\nIf you only want the last element of a result set, there's no need to create all\nof hash_rows. Also, add a test.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/763de2ac1c85d3e9f82639783a55244d6c0517c2"},{"sha":"37232f6d43540ff9fb3a88e35070cf7899173ad6","author":{"name":"Pan GaoYong","email":"cac6a237ecd47a8d64886224b7017e9486ce81a4@gmail.com"},"message":"fix ActiveSupport::Infector.constantize usage API doc [ci skip]","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/37232f6d43540ff9fb3a88e35070cf7899173ad6"},{"sha":"5d3a0b14c0439beab8e3af946dec88fddc07f896","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Pass `pk: false` to `connection.insert` explicitly if do not have a primary key\n\nBecause causing an extra query by `sql_for_insert` for guessing a\nprimary key.\nhttps://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/5d3a0b14c0439beab8e3af946dec88fddc07f896"},{"sha":"6119a9524ba07031771ed80b79798cc27263979c","author":{"name":"Vít Ondruch","email":"38d3dfcaf83a3c3816380adc95476334f4f35076@redhat.com"},"message":"Do not depend on Rails git repository layout in ActiveSupport tests.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/6119a9524ba07031771ed80b79798cc27263979c"},{"sha":"297e262035ce9dce9c33f8bebc778f36760a5e40","author":{"name":"eileencodes","email":"707c9cbace6a6803e8005e53f8194409d6a9d8e6@gmail.com"},"message":"Fix release task now that NPM is part of the build\n\nNote: this commit looks super weird becuase git. I'm moving the entire\nNPM section to the part where we actually push the gems/npm package for\nthe reasons below. That's not how the git diff looks though.\n\nWhen we release Rails we run `rake prep_release` which calls\n`update_versions`. This was updating the NPM version as well. But when we\nwould later run `rake install` to test the installed gem\n`update_versions` gets called again which causes the install to fail\nbecause NPM sees the version is the same as the last run and refuses to\ncontinue. If you forget to stash this will then cause the push to\nRubyGems to fail because `update_versions` is called again and then NPM\nwill not continue because it thinks the version hasn't been changed even\nthough it has.\n\nThe correct solution would be to not update the NPM verion if it matches\nthe version already in the file but after an hour I could not find a\nsimple way to use NPM to read the current version. Honestly that's not\nthe best way to do it either because say you forget to update something\nelse and then the script thinks it's already been updated.\n\nWith that in mind I think the best solution is to not update the NPM\nversion until right before we are going to push to NPM because then that\nwon't cause the push to RubyGems to fail.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/297e262035ce9dce9c33f8bebc778f36760a5e40"},{"sha":"4abd389ef77cf8f8b45793451c6d4429ca08062e","author":{"name":"Eileen M. Uchitelle","email":"707c9cbace6a6803e8005e53f8194409d6a9d8e6@gmail.com"},"message":"Merge pull request #25307 from kamipo/extract_foreign_key_action_from_information_schema\n\nExtract foreign key action from `information_schema`","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/4abd389ef77cf8f8b45793451c6d4429ca08062e"},{"sha":"0d8d64e9d09cf37ae302fed17f5cd872b4053a4f","author":{"name":"eileencodes","email":"707c9cbace6a6803e8005e53f8194409d6a9d8e6@gmail.com"},"message":"Add regression test for foreign key schema dump caching\n\nIf you had a foreign key set and then decided to add `on_delete:\n:cascade` later in another migration that migration would run but\nwouldn't refresh the schema dump.\n\nThe reason for this was because `create_table_info` caches the statement\nand sets it to be the same as the original declaration for the foreign\nkey (without the `on_delete: :cascade`.\n\nPR #25307 ended up fixing this bug because it removes the check for\n`create_table_info` and relies on reading from `information_schema`. The\nfix however was intended to patch another bug. The reason this fixes the\nissue is we're no longer parsing the regex from the cached\n`create_table_info`.\n\nThis regression test is to ensure that the issue does not return if we\nfor some reason go back to using `create_table_info` to set the foreign\nkeys.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/0d8d64e9d09cf37ae302fed17f5cd872b4053a4f"},{"sha":"545583d773800fbfd434d94fee00ec842fd4e9f8","author":{"name":"Yasuo Honda","email":"1b1551c59d1a55e034555b0b38c5e20ae26bf6de@gmail.com"},"message":"Revert \"Rename `active_record_internal_metadatas` to `ar_internal_metadata`\"\n\nThis reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/545583d773800fbfd434d94fee00ec842fd4e9f8"},{"sha":"fa10787447162c662e72b653f1d114834efddfb5","author":{"name":"Volmer","email":"5bf00c93c9250d44d769b81890fa6584403ae7e0@radicaos.com"},"message":"Fix request encoding in tests when string literals are frozen\n\nWhen running tests with `--enable-frozen-string-literal` or\n`# frozen_string_literal: true`, it's currently attempted to mutate the path\nstring in order to append the format, causing a `RuntimeError`.\n\n```ruby\nget '/posts', as: :json\n```\n\n```\nRuntimeError:\n can't modify frozen String\n```\n\nThis commit fixes the problem by replacing the mutation with a concatenation,\nreturning a new string.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/fa10787447162c662e72b653f1d114834efddfb5"},{"sha":"bf63bc7b41219c17e4e20f7963994bbf5a718a9f","author":{"name":"Ryuta Kamizono","email":"eaaec3c25cb0fb33a7ca3dcb58ed29b01ce2c843@gmail.com"},"message":"Remove `create_table_info_cache` because it not be reused\n\n`create_table_info_cache` is used for sharing `create_table_info` both\n`table_options` and `foreign_keys`. But `foreign_keys` no longer uses\n`create_table_info_cache` by #25307. No need caching anymore.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/bf63bc7b41219c17e4e20f7963994bbf5a718a9f"},{"sha":"d7a7a2561a6e10f2c82ab06202c88638ca213c6c","author":{"name":"Vipul A M","email":"eed064c2f96e1e85a9ee3713d4325f5e37f2084b@gmail.com"},"message":"Merge pull request #25600 from pan/constantize-docfix\n\nfix ActiveSupport::Infector.constantize usage API doc [ci skip]","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/d7a7a2561a6e10f2c82ab06202c88638ca213c6c"},{"sha":"7f0d415eb7ea058d70ffb9e77510727f4bbd2c7e","author":{"name":"Kasper Timm Hansen","email":"e8140a2fc82ae7ffe21cdbfaa9bddf73bdec8a9d@gmail.com"},"message":"Merge pull request #25632 from volmer/fix-integration-test-frozen-literals\n\nFix request encoding in tests when string literals are frozen","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/7f0d415eb7ea058d70ffb9e77510727f4bbd2c7e"},{"sha":"ea40ec56ba9bb44c91ffd8b621718faf960f340d","author":{"name":"Kasper Timm Hansen","email":"e8140a2fc82ae7ffe21cdbfaa9bddf73bdec8a9d@gmail.com"},"message":"Make mutation stand out some more.\n\nFelt that += overwriting the path variable was a little too hidden.\n\nMake the outcomes easier to spot with an if-else branch.","distinct":true,"url":"https://api.github.com/repos/rlugojr/rails/commits/ea40ec56ba9bb44c91ffd8b621718faf960f340d"}]}
{"actor":{"display_login":"rlugojr"}}