{"action":"closed","number":232,"pull_request":{"url":"https://api.github.com/repos/bokeh/datashader/pulls/232","id":84376891,"html_url":"https://github.com/bokeh/datashader/pull/232","diff_url":"https://github.com/bokeh/datashader/pull/232.diff","patch_url":"https://github.com/bokeh/datashader/pull/232.patch","issue_url":"https://api.github.com/repos/bokeh/datashader/issues/232","number":232,"state":"closed","locked":false,"title":"Fixed handling of NaN between line segments","user":{"login":"jbednar","id":1695496,"avatar_url":"https://avatars.githubusercontent.com/u/1695496?v=3","gravatar_id":"","url":"https://api.github.com/users/jbednar","html_url":"https://github.com/jbednar","followers_url":"https://api.github.com/users/jbednar/followers","following_url":"https://api.github.com/users/jbednar/following{/other_user}","gists_url":"https://api.github.com/users/jbednar/gists{/gist_id}","starred_url":"https://api.github.com/users/jbednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbednar/subscriptions","organizations_url":"https://api.github.com/users/jbednar/orgs","repos_url":"https://api.github.com/users/jbednar/repos","events_url":"https://api.github.com/users/jbednar/events{/privacy}","received_events_url":"https://api.github.com/users/jbednar/received_events","type":"User","site_admin":false},"body":"As reported in #230, the behavior for line segments separated by NaN does not appear to be consistent:\r\n\r\n```python\r\nimport datashader\r\nimport datashader.transfer_functions as tf\r\nimport numpy as np\r\nimport pandas as pd\r\n\r\ny = [1, 0, 1, np.NaN, np.NaN, 0, 1, 0]\r\nx = range(len(y))\r\n\r\ndf = pd.DataFrame(dict(x=x, y=y))\r\ncvs = datashader.Canvas(x_range=[min(x), max(x)], y_range=[-1, 2], plot_width=100, plot_height=100)\r\nagg = cvs.line(df, \"x\", \"y\")\r\ntf.shade(agg)\r\n```\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1695496/18329010/4612a6aa-7517-11e6-80c2-1c89b25b13df.png)\r\n\r\nHere there should be two V shapes, but the first part of the second one is cut off.  Turns out that the first sample after np.NaN was erroneously being ignored.  After fixing that (applying this PR) it works fine:\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1695496/18329149/bd9c1b48-7517-11e6-9d54-34e5784fa719.png)","created_at":"2016-09-07T21:28:04Z","updated_at":"2016-09-07T21:43:41Z","closed_at":"2016-09-07T21:43:41Z","merged_at":"2016-09-07T21:43:41Z","merge_commit_sha":"8ee071de5622b6b8b03b5f2c403d4af2602e6fc5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bokeh/datashader/pulls/232/commits","review_comments_url":"https://api.github.com/repos/bokeh/datashader/pulls/232/comments","review_comment_url":"https://api.github.com/repos/bokeh/datashader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bokeh/datashader/issues/232/comments","statuses_url":"https://api.github.com/repos/bokeh/datashader/statuses/5cb70796a3c9679843660c8fcd30a80999502985","head":{"label":"bokeh:linebug","ref":"linebug","sha":"5cb70796a3c9679843660c8fcd30a80999502985","user":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"repo":{"id":48504165,"name":"datashader","full_name":"bokeh/datashader","owner":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bokeh/datashader","description":"Bin based rendering toolchain","fork":false,"url":"https://api.github.com/repos/bokeh/datashader","forks_url":"https://api.github.com/repos/bokeh/datashader/forks","keys_url":"https://api.github.com/repos/bokeh/datashader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bokeh/datashader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bokeh/datashader/teams","hooks_url":"https://api.github.com/repos/bokeh/datashader/hooks","issue_events_url":"https://api.github.com/repos/bokeh/datashader/issues/events{/number}","events_url":"https://api.github.com/repos/bokeh/datashader/events","assignees_url":"https://api.github.com/repos/bokeh/datashader/assignees{/user}","branches_url":"https://api.github.com/repos/bokeh/datashader/branches{/branch}","tags_url":"https://api.github.com/repos/bokeh/datashader/tags","blobs_url":"https://api.github.com/repos/bokeh/datashader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bokeh/datashader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bokeh/datashader/git/refs{/sha}","trees_url":"https://api.github.com/repos/bokeh/datashader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bokeh/datashader/statuses/{sha}","languages_url":"https://api.github.com/repos/bokeh/datashader/languages","stargazers_url":"https://api.github.com/repos/bokeh/datashader/stargazers","contributors_url":"https://api.github.com/repos/bokeh/datashader/contributors","subscribers_url":"https://api.github.com/repos/bokeh/datashader/subscribers","subscription_url":"https://api.github.com/repos/bokeh/datashader/subscription","commits_url":"https://api.github.com/repos/bokeh/datashader/commits{/sha}","git_commits_url":"https://api.github.com/repos/bokeh/datashader/git/commits{/sha}","comments_url":"https://api.github.com/repos/bokeh/datashader/comments{/number}","issue_comment_url":"https://api.github.com/repos/bokeh/datashader/issues/comments{/number}","contents_url":"https://api.github.com/repos/bokeh/datashader/contents/{+path}","compare_url":"https://api.github.com/repos/bokeh/datashader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bokeh/datashader/merges","archive_url":"https://api.github.com/repos/bokeh/datashader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bokeh/datashader/downloads","issues_url":"https://api.github.com/repos/bokeh/datashader/issues{/number}","pulls_url":"https://api.github.com/repos/bokeh/datashader/pulls{/number}","milestones_url":"https://api.github.com/repos/bokeh/datashader/milestones{/number}","notifications_url":"https://api.github.com/repos/bokeh/datashader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bokeh/datashader/labels{/name}","releases_url":"https://api.github.com/repos/bokeh/datashader/releases{/id}","deployments_url":"https://api.github.com/repos/bokeh/datashader/deployments","created_at":"2015-12-23T18:02:20Z","updated_at":"2016-09-07T07:22:27Z","pushed_at":"2016-09-07T21:43:41Z","git_url":"git://github.com/bokeh/datashader.git","ssh_url":"git@github.com:bokeh/datashader.git","clone_url":"https://github.com/bokeh/datashader.git","svn_url":"https://github.com/bokeh/datashader","homepage":"http://datashader.readthedocs.org/en/latest/","size":10659,"stargazers_count":295,"watchers_count":295,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":40,"forks":67,"open_issues":40,"watchers":295,"default_branch":"master"}},"base":{"label":"bokeh:master","ref":"master","sha":"c22f43786bb49b79e2aa065cb2cd09fa1c48c93f","user":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"repo":{"id":48504165,"name":"datashader","full_name":"bokeh/datashader","owner":{"login":"bokeh","id":8440965,"avatar_url":"https://avatars.githubusercontent.com/u/8440965?v=3","gravatar_id":"","url":"https://api.github.com/users/bokeh","html_url":"https://github.com/bokeh","followers_url":"https://api.github.com/users/bokeh/followers","following_url":"https://api.github.com/users/bokeh/following{/other_user}","gists_url":"https://api.github.com/users/bokeh/gists{/gist_id}","starred_url":"https://api.github.com/users/bokeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokeh/subscriptions","organizations_url":"https://api.github.com/users/bokeh/orgs","repos_url":"https://api.github.com/users/bokeh/repos","events_url":"https://api.github.com/users/bokeh/events{/privacy}","received_events_url":"https://api.github.com/users/bokeh/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bokeh/datashader","description":"Bin based rendering toolchain","fork":false,"url":"https://api.github.com/repos/bokeh/datashader","forks_url":"https://api.github.com/repos/bokeh/datashader/forks","keys_url":"https://api.github.com/repos/bokeh/datashader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bokeh/datashader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bokeh/datashader/teams","hooks_url":"https://api.github.com/repos/bokeh/datashader/hooks","issue_events_url":"https://api.github.com/repos/bokeh/datashader/issues/events{/number}","events_url":"https://api.github.com/repos/bokeh/datashader/events","assignees_url":"https://api.github.com/repos/bokeh/datashader/assignees{/user}","branches_url":"https://api.github.com/repos/bokeh/datashader/branches{/branch}","tags_url":"https://api.github.com/repos/bokeh/datashader/tags","blobs_url":"https://api.github.com/repos/bokeh/datashader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bokeh/datashader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bokeh/datashader/git/refs{/sha}","trees_url":"https://api.github.com/repos/bokeh/datashader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bokeh/datashader/statuses/{sha}","languages_url":"https://api.github.com/repos/bokeh/datashader/languages","stargazers_url":"https://api.github.com/repos/bokeh/datashader/stargazers","contributors_url":"https://api.github.com/repos/bokeh/datashader/contributors","subscribers_url":"https://api.github.com/repos/bokeh/datashader/subscribers","subscription_url":"https://api.github.com/repos/bokeh/datashader/subscription","commits_url":"https://api.github.com/repos/bokeh/datashader/commits{/sha}","git_commits_url":"https://api.github.com/repos/bokeh/datashader/git/commits{/sha}","comments_url":"https://api.github.com/repos/bokeh/datashader/comments{/number}","issue_comment_url":"https://api.github.com/repos/bokeh/datashader/issues/comments{/number}","contents_url":"https://api.github.com/repos/bokeh/datashader/contents/{+path}","compare_url":"https://api.github.com/repos/bokeh/datashader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bokeh/datashader/merges","archive_url":"https://api.github.com/repos/bokeh/datashader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bokeh/datashader/downloads","issues_url":"https://api.github.com/repos/bokeh/datashader/issues{/number}","pulls_url":"https://api.github.com/repos/bokeh/datashader/pulls{/number}","milestones_url":"https://api.github.com/repos/bokeh/datashader/milestones{/number}","notifications_url":"https://api.github.com/repos/bokeh/datashader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bokeh/datashader/labels{/name}","releases_url":"https://api.github.com/repos/bokeh/datashader/releases{/id}","deployments_url":"https://api.github.com/repos/bokeh/datashader/deployments","created_at":"2015-12-23T18:02:20Z","updated_at":"2016-09-07T07:22:27Z","pushed_at":"2016-09-07T21:43:41Z","git_url":"git://github.com/bokeh/datashader.git","ssh_url":"git@github.com:bokeh/datashader.git","clone_url":"https://github.com/bokeh/datashader.git","svn_url":"https://github.com/bokeh/datashader","homepage":"http://datashader.readthedocs.org/en/latest/","size":10659,"stargazers_count":295,"watchers_count":295,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":40,"forks":67,"open_issues":40,"watchers":295,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bokeh/datashader/pulls/232"},"html":{"href":"https://github.com/bokeh/datashader/pull/232"},"issue":{"href":"https://api.github.com/repos/bokeh/datashader/issues/232"},"comments":{"href":"https://api.github.com/repos/bokeh/datashader/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/bokeh/datashader/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/bokeh/datashader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bokeh/datashader/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/bokeh/datashader/statuses/5cb70796a3c9679843660c8fcd30a80999502985"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jbednar","id":1695496,"avatar_url":"https://avatars.githubusercontent.com/u/1695496?v=3","gravatar_id":"","url":"https://api.github.com/users/jbednar","html_url":"https://github.com/jbednar","followers_url":"https://api.github.com/users/jbednar/followers","following_url":"https://api.github.com/users/jbednar/following{/other_user}","gists_url":"https://api.github.com/users/jbednar/gists{/gist_id}","starred_url":"https://api.github.com/users/jbednar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbednar/subscriptions","organizations_url":"https://api.github.com/users/jbednar/orgs","repos_url":"https://api.github.com/users/jbednar/repos","events_url":"https://api.github.com/users/jbednar/events{/privacy}","received_events_url":"https://api.github.com/users/jbednar/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"jbednar"}}