{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/3232","repository_url":"https://api.github.com/repos/videojs/video.js","labels_url":"https://api.github.com/repos/videojs/video.js/issues/3232/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/3232/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/3232/events","html_url":"https://github.com/videojs/video.js/pull/3232","id":145134511,"number":3232,"title":"Is chrome on edge return true","user":{"login":"benjipott","id":3854951,"avatar_url":"https://avatars.githubusercontent.com/u/3854951?v=3","gravatar_id":"","url":"https://api.github.com/users/benjipott","html_url":"https://github.com/benjipott","followers_url":"https://api.github.com/users/benjipott/followers","following_url":"https://api.github.com/users/benjipott/following{/other_user}","gists_url":"https://api.github.com/users/benjipott/gists{/gist_id}","starred_url":"https://api.github.com/users/benjipott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjipott/subscriptions","organizations_url":"https://api.github.com/users/benjipott/orgs","repos_url":"https://api.github.com/users/benjipott/repos","events_url":"https://api.github.com/users/benjipott/events{/privacy}","received_events_url":"https://api.github.com/users/benjipott/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/videojs/video.js/labels/minor","name":"minor","color":"009800"},{"url":"https://api.github.com/repos/videojs/video.js/labels/needs:%20LGTM","name":"needs: LGTM","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-04-01T09:38:27Z","updated_at":"2016-04-04T18:10:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/3232","html_url":"https://github.com/videojs/video.js/pull/3232","diff_url":"https://github.com/videojs/video.js/pull/3232.diff","patch_url":"https://github.com/videojs/video.js/pull/3232.patch"},"body":"## Description\r\nFix videojs.isChrome() on windows 10 edge return true\r\n\r\nMozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) **Chrome**/42.0.2311.135 Safari/537.36 Edge/12.10136"},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/205426116","html_url":"https://github.com/videojs/video.js/pull/3232#issuecomment-205426116","issue_url":"https://api.github.com/repos/videojs/video.js/issues/3232","id":205426116,"user":{"login":"nickygerritsen","id":550145,"avatar_url":"https://avatars.githubusercontent.com/u/550145?v=3","gravatar_id":"","url":"https://api.github.com/users/nickygerritsen","html_url":"https://github.com/nickygerritsen","followers_url":"https://api.github.com/users/nickygerritsen/followers","following_url":"https://api.github.com/users/nickygerritsen/following{/other_user}","gists_url":"https://api.github.com/users/nickygerritsen/gists{/gist_id}","starred_url":"https://api.github.com/users/nickygerritsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickygerritsen/subscriptions","organizations_url":"https://api.github.com/users/nickygerritsen/orgs","repos_url":"https://api.github.com/users/nickygerritsen/repos","events_url":"https://api.github.com/users/nickygerritsen/events{/privacy}","received_events_url":"https://api.github.com/users/nickygerritsen/received_events","type":"User","site_admin":false},"created_at":"2016-04-04T18:10:25Z","updated_at":"2016-04-04T18:10:25Z","body":"@benjipott I was thinking: because Edge has kinda a strange UA string, isn't it better to put some `IS_EDGE` check at the top and for others add an `!IS_EDGE && ...`?\r\n\r\nI can imagine we later add a Safari check and it will break again, because Edge also contains `Safari`.\r\n\r\nSo i.e.:\r\n\r\n```javascript\r\nexport const IS_EDGE = (/Edge/i).test(USER_AGENT);\r\nexport const IS_CHROME = !IS_EDGE && (/Chrome/i).test(USER_AGENT);\r\n// etc.\r\n```"}}