{"action":"created","comment":{"url":"https://api.github.com/repos/uqbar-project/wollok/pulls/comments/69588292","id":69588292,"diff_hunk":"@@ -0,0 +1,11 @@\n+package org.uqbar.project.wollok.scoping.cache\n+\n+import java.util.List\n+import org.eclipse.emf.common.util.URI\n+import org.eclipse.xtext.xbase.lib.Functions.Function0\n+import org.uqbar.project.wollok.wollokDsl.Import\n+import org.eclipse.xtext.resource.IEObjectDescription\n+\n+interface WollokGlobalScopeCache {","path":"org.uqbar.project.wollok/src/org/uqbar/project/wollok/scoping/cache/WollokGlobalScopeCache.xtend","position":9,"original_position":9,"commit_id":"c6943169430dc7a6583ee48e470b43ed6c7fb999","original_commit_id":"c6943169430dc7a6583ee48e470b43ed6c7fb999","user":{"login":"tesonep","id":355455,"avatar_url":"https://avatars.githubusercontent.com/u/355455?v=3","gravatar_id":"","url":"https://api.github.com/users/tesonep","html_url":"https://github.com/tesonep","followers_url":"https://api.github.com/users/tesonep/followers","following_url":"https://api.github.com/users/tesonep/following{/other_user}","gists_url":"https://api.github.com/users/tesonep/gists{/gist_id}","starred_url":"https://api.github.com/users/tesonep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tesonep/subscriptions","organizations_url":"https://api.github.com/users/tesonep/orgs","repos_url":"https://api.github.com/users/tesonep/repos","events_url":"https://api.github.com/users/tesonep/events{/privacy}","received_events_url":"https://api.github.com/users/tesonep/received_events","type":"User","site_admin":false},"body":"There is two caches:\r\n\r\n- One for the location of the \"root file\", the key here is the string representation of the path of the containing directory, so if there are many files in the same folder it will resolve only once. If you move the .wlk file to other directory it will recalculate for that directory. If you move the \"root file\" everything is doom. That is why I have put it hidden. I rather prefer not to be visible. \r\n\r\n- The other cache is for the imported objects, this cache use as key the string representation of the URI. In the cache I'm storing an object having the URI, the imports and the EObjectDescriptions. So before returning the value the list of imports is checked. If the list of imports changes the imported references are reloaded.\r\n\r\nNow I am thinking if you change the imported file in the other world, it maybe is not updated. Maybe I should invalidate all the cache when a file is saved. I will do that.  ","created_at":"2016-07-05T15:51:51Z","updated_at":"2016-07-05T15:51:51Z","html_url":"https://github.com/uqbar-project/wollok/pull/787#discussion_r69588292","pull_request_url":"https://api.github.com/repos/uqbar-project/wollok/pulls/787","_links":{"self":{"href":"https://api.github.com/repos/uqbar-project/wollok/pulls/comments/69588292"},"html":{"href":"https://github.com/uqbar-project/wollok/pull/787#discussion_r69588292"},"pull_request":{"href":"https://api.github.com/repos/uqbar-project/wollok/pulls/787"}}},"pull_request":{"url":"https://api.github.com/repos/uqbar-project/wollok/pulls/787","id":76271063,"html_url":"https://github.com/uqbar-project/wollok/pull/787","diff_url":"https://github.com/uqbar-project/wollok/pull/787.diff","patch_url":"https://github.com/uqbar-project/wollok/pull/787.patch","issue_url":"https://api.github.com/repos/uqbar-project/wollok/issues/787","number":787,"state":"open","locked":false,"title":"Fixing the implementation of Imports","user":{"login":"tesonep","id":355455,"avatar_url":"https://avatars.githubusercontent.com/u/355455?v=3","gravatar_id":"","url":"https://api.github.com/users/tesonep","html_url":"https://github.com/tesonep","followers_url":"https://api.github.com/users/tesonep/followers","following_url":"https://api.github.com/users/tesonep/following{/other_user}","gists_url":"https://api.github.com/users/tesonep/gists{/gist_id}","starred_url":"https://api.github.com/users/tesonep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tesonep/subscriptions","organizations_url":"https://api.github.com/users/tesonep/orgs","repos_url":"https://api.github.com/users/tesonep/repos","events_url":"https://api.github.com/users/tesonep/events{/privacy}","received_events_url":"https://api.github.com/users/tesonep/received_events","type":"User","site_admin":false},"body":"This includes a number of things:\r\n\r\n- Divides the Wollok SDK in different files (#431)\r\n- Allows the use of different nesting packages\r\n- Adds a cache in the lookup of manifest and root marker file. ","created_at":"2016-07-05T13:09:54Z","updated_at":"2016-07-05T15:51:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d988481217c0f5d880db129b4498eba802dd9401","assignee":{"login":"Juancete","id":1617224,"avatar_url":"https://avatars.githubusercontent.com/u/1617224?v=3","gravatar_id":"","url":"https://api.github.com/users/Juancete","html_url":"https://github.com/Juancete","followers_url":"https://api.github.com/users/Juancete/followers","following_url":"https://api.github.com/users/Juancete/following{/other_user}","gists_url":"https://api.github.com/users/Juancete/gists{/gist_id}","starred_url":"https://api.github.com/users/Juancete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juancete/subscriptions","organizations_url":"https://api.github.com/users/Juancete/orgs","repos_url":"https://api.github.com/users/Juancete/repos","events_url":"https://api.github.com/users/Juancete/events{/privacy}","received_events_url":"https://api.github.com/users/Juancete/received_events","type":"User","site_admin":false},"assignees":[{"login":"Juancete","id":1617224,"avatar_url":"https://avatars.githubusercontent.com/u/1617224?v=3","gravatar_id":"","url":"https://api.github.com/users/Juancete","html_url":"https://github.com/Juancete","followers_url":"https://api.github.com/users/Juancete/followers","following_url":"https://api.github.com/users/Juancete/following{/other_user}","gists_url":"https://api.github.com/users/Juancete/gists{/gist_id}","starred_url":"https://api.github.com/users/Juancete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Juancete/subscriptions","organizations_url":"https://api.github.com/users/Juancete/orgs","repos_url":"https://api.github.com/users/Juancete/repos","events_url":"https://api.github.com/users/Juancete/events{/privacy}","received_events_url":"https://api.github.com/users/Juancete/received_events","type":"User","site_admin":false},{"login":"javierfernandes","id":4428120,"avatar_url":"https://avatars.githubusercontent.com/u/4428120?v=3","gravatar_id":"","url":"https://api.github.com/users/javierfernandes","html_url":"https://github.com/javierfernandes","followers_url":"https://api.github.com/users/javierfernandes/followers","following_url":"https://api.github.com/users/javierfernandes/following{/other_user}","gists_url":"https://api.github.com/users/javierfernandes/gists{/gist_id}","starred_url":"https://api.github.com/users/javierfernandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierfernandes/subscriptions","organizations_url":"https://api.github.com/users/javierfernandes/orgs","repos_url":"https://api.github.com/users/javierfernandes/repos","events_url":"https://api.github.com/users/javierfernandes/events{/privacy}","received_events_url":"https://api.github.com/users/javierfernandes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uqbar-project/wollok/pulls/787/commits","review_comments_url":"https://api.github.com/repos/uqbar-project/wollok/pulls/787/comments","review_comment_url":"https://api.github.com/repos/uqbar-project/wollok/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uqbar-project/wollok/issues/787/comments","statuses_url":"https://api.github.com/repos/uqbar-project/wollok/statuses/c6943169430dc7a6583ee48e470b43ed6c7fb999","head":{"label":"uqbar-project:dev-fixing-imports","ref":"dev-fixing-imports","sha":"c6943169430dc7a6583ee48e470b43ed6c7fb999","user":{"login":"uqbar-project","id":2975634,"avatar_url":"https://avatars.githubusercontent.com/u/2975634?v=3","gravatar_id":"","url":"https://api.github.com/users/uqbar-project","html_url":"https://github.com/uqbar-project","followers_url":"https://api.github.com/users/uqbar-project/followers","following_url":"https://api.github.com/users/uqbar-project/following{/other_user}","gists_url":"https://api.github.com/users/uqbar-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uqbar-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uqbar-project/subscriptions","organizations_url":"https://api.github.com/users/uqbar-project/orgs","repos_url":"https://api.github.com/users/uqbar-project/repos","events_url":"https://api.github.com/users/uqbar-project/events{/privacy}","received_events_url":"https://api.github.com/users/uqbar-project/received_events","type":"Organization","site_admin":false},"repo":{"id":30089538,"name":"wollok","full_name":"uqbar-project/wollok","owner":{"login":"uqbar-project","id":2975634,"avatar_url":"https://avatars.githubusercontent.com/u/2975634?v=3","gravatar_id":"","url":"https://api.github.com/users/uqbar-project","html_url":"https://github.com/uqbar-project","followers_url":"https://api.github.com/users/uqbar-project/followers","following_url":"https://api.github.com/users/uqbar-project/following{/other_user}","gists_url":"https://api.github.com/users/uqbar-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uqbar-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uqbar-project/subscriptions","organizations_url":"https://api.github.com/users/uqbar-project/orgs","repos_url":"https://api.github.com/users/uqbar-project/repos","events_url":"https://api.github.com/users/uqbar-project/events{/privacy}","received_events_url":"https://api.github.com/users/uqbar-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uqbar-project/wollok","description":"Wollok Programming Language","fork":false,"url":"https://api.github.com/repos/uqbar-project/wollok","forks_url":"https://api.github.com/repos/uqbar-project/wollok/forks","keys_url":"https://api.github.com/repos/uqbar-project/wollok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uqbar-project/wollok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uqbar-project/wollok/teams","hooks_url":"https://api.github.com/repos/uqbar-project/wollok/hooks","issue_events_url":"https://api.github.com/repos/uqbar-project/wollok/issues/events{/number}","events_url":"https://api.github.com/repos/uqbar-project/wollok/events","assignees_url":"https://api.github.com/repos/uqbar-project/wollok/assignees{/user}","branches_url":"https://api.github.com/repos/uqbar-project/wollok/branches{/branch}","tags_url":"https://api.github.com/repos/uqbar-project/wollok/tags","blobs_url":"https://api.github.com/repos/uqbar-project/wollok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uqbar-project/wollok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uqbar-project/wollok/git/refs{/sha}","trees_url":"https://api.github.com/repos/uqbar-project/wollok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uqbar-project/wollok/statuses/{sha}","languages_url":"https://api.github.com/repos/uqbar-project/wollok/languages","stargazers_url":"https://api.github.com/repos/uqbar-project/wollok/stargazers","contributors_url":"https://api.github.com/repos/uqbar-project/wollok/contributors","subscribers_url":"https://api.github.com/repos/uqbar-project/wollok/subscribers","subscription_url":"https://api.github.com/repos/uqbar-project/wollok/subscription","commits_url":"https://api.github.com/repos/uqbar-project/wollok/commits{/sha}","git_commits_url":"https://api.github.com/repos/uqbar-project/wollok/git/commits{/sha}","comments_url":"https://api.github.com/repos/uqbar-project/wollok/comments{/number}","issue_comment_url":"https://api.github.com/repos/uqbar-project/wollok/issues/comments{/number}","contents_url":"https://api.github.com/repos/uqbar-project/wollok/contents/{+path}","compare_url":"https://api.github.com/repos/uqbar-project/wollok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uqbar-project/wollok/merges","archive_url":"https://api.github.com/repos/uqbar-project/wollok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uqbar-project/wollok/downloads","issues_url":"https://api.github.com/repos/uqbar-project/wollok/issues{/number}","pulls_url":"https://api.github.com/repos/uqbar-project/wollok/pulls{/number}","milestones_url":"https://api.github.com/repos/uqbar-project/wollok/milestones{/number}","notifications_url":"https://api.github.com/repos/uqbar-project/wollok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uqbar-project/wollok/labels{/name}","releases_url":"https://api.github.com/repos/uqbar-project/wollok/releases{/id}","deployments_url":"https://api.github.com/repos/uqbar-project/wollok/deployments","created_at":"2015-01-30T20:31:27Z","updated_at":"2016-05-27T08:11:42Z","pushed_at":"2016-07-05T13:09:54Z","git_url":"git://github.com/uqbar-project/wollok.git","ssh_url":"git@github.com:uqbar-project/wollok.git","clone_url":"https://github.com/uqbar-project/wollok.git","svn_url":"https://github.com/uqbar-project/wollok","homepage":null,"size":23497,"stargazers_count":17,"watchers_count":17,"language":"Xtend","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":276,"forks":3,"open_issues":276,"watchers":17,"default_branch":"master"}},"base":{"label":"uqbar-project:dev","ref":"dev","sha":"705aba54b0263647b4ed12c10b769c61769e7c7d","user":{"login":"uqbar-project","id":2975634,"avatar_url":"https://avatars.githubusercontent.com/u/2975634?v=3","gravatar_id":"","url":"https://api.github.com/users/uqbar-project","html_url":"https://github.com/uqbar-project","followers_url":"https://api.github.com/users/uqbar-project/followers","following_url":"https://api.github.com/users/uqbar-project/following{/other_user}","gists_url":"https://api.github.com/users/uqbar-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uqbar-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uqbar-project/subscriptions","organizations_url":"https://api.github.com/users/uqbar-project/orgs","repos_url":"https://api.github.com/users/uqbar-project/repos","events_url":"https://api.github.com/users/uqbar-project/events{/privacy}","received_events_url":"https://api.github.com/users/uqbar-project/received_events","type":"Organization","site_admin":false},"repo":{"id":30089538,"name":"wollok","full_name":"uqbar-project/wollok","owner":{"login":"uqbar-project","id":2975634,"avatar_url":"https://avatars.githubusercontent.com/u/2975634?v=3","gravatar_id":"","url":"https://api.github.com/users/uqbar-project","html_url":"https://github.com/uqbar-project","followers_url":"https://api.github.com/users/uqbar-project/followers","following_url":"https://api.github.com/users/uqbar-project/following{/other_user}","gists_url":"https://api.github.com/users/uqbar-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uqbar-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uqbar-project/subscriptions","organizations_url":"https://api.github.com/users/uqbar-project/orgs","repos_url":"https://api.github.com/users/uqbar-project/repos","events_url":"https://api.github.com/users/uqbar-project/events{/privacy}","received_events_url":"https://api.github.com/users/uqbar-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uqbar-project/wollok","description":"Wollok Programming Language","fork":false,"url":"https://api.github.com/repos/uqbar-project/wollok","forks_url":"https://api.github.com/repos/uqbar-project/wollok/forks","keys_url":"https://api.github.com/repos/uqbar-project/wollok/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uqbar-project/wollok/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uqbar-project/wollok/teams","hooks_url":"https://api.github.com/repos/uqbar-project/wollok/hooks","issue_events_url":"https://api.github.com/repos/uqbar-project/wollok/issues/events{/number}","events_url":"https://api.github.com/repos/uqbar-project/wollok/events","assignees_url":"https://api.github.com/repos/uqbar-project/wollok/assignees{/user}","branches_url":"https://api.github.com/repos/uqbar-project/wollok/branches{/branch}","tags_url":"https://api.github.com/repos/uqbar-project/wollok/tags","blobs_url":"https://api.github.com/repos/uqbar-project/wollok/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uqbar-project/wollok/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uqbar-project/wollok/git/refs{/sha}","trees_url":"https://api.github.com/repos/uqbar-project/wollok/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uqbar-project/wollok/statuses/{sha}","languages_url":"https://api.github.com/repos/uqbar-project/wollok/languages","stargazers_url":"https://api.github.com/repos/uqbar-project/wollok/stargazers","contributors_url":"https://api.github.com/repos/uqbar-project/wollok/contributors","subscribers_url":"https://api.github.com/repos/uqbar-project/wollok/subscribers","subscription_url":"https://api.github.com/repos/uqbar-project/wollok/subscription","commits_url":"https://api.github.com/repos/uqbar-project/wollok/commits{/sha}","git_commits_url":"https://api.github.com/repos/uqbar-project/wollok/git/commits{/sha}","comments_url":"https://api.github.com/repos/uqbar-project/wollok/comments{/number}","issue_comment_url":"https://api.github.com/repos/uqbar-project/wollok/issues/comments{/number}","contents_url":"https://api.github.com/repos/uqbar-project/wollok/contents/{+path}","compare_url":"https://api.github.com/repos/uqbar-project/wollok/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uqbar-project/wollok/merges","archive_url":"https://api.github.com/repos/uqbar-project/wollok/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uqbar-project/wollok/downloads","issues_url":"https://api.github.com/repos/uqbar-project/wollok/issues{/number}","pulls_url":"https://api.github.com/repos/uqbar-project/wollok/pulls{/number}","milestones_url":"https://api.github.com/repos/uqbar-project/wollok/milestones{/number}","notifications_url":"https://api.github.com/repos/uqbar-project/wollok/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uqbar-project/wollok/labels{/name}","releases_url":"https://api.github.com/repos/uqbar-project/wollok/releases{/id}","deployments_url":"https://api.github.com/repos/uqbar-project/wollok/deployments","created_at":"2015-01-30T20:31:27Z","updated_at":"2016-05-27T08:11:42Z","pushed_at":"2016-07-05T13:09:54Z","git_url":"git://github.com/uqbar-project/wollok.git","ssh_url":"git@github.com:uqbar-project/wollok.git","clone_url":"https://github.com/uqbar-project/wollok.git","svn_url":"https://github.com/uqbar-project/wollok","homepage":null,"size":23497,"stargazers_count":17,"watchers_count":17,"language":"Xtend","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":276,"forks":3,"open_issues":276,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uqbar-project/wollok/pulls/787"},"html":{"href":"https://github.com/uqbar-project/wollok/pull/787"},"issue":{"href":"https://api.github.com/repos/uqbar-project/wollok/issues/787"},"comments":{"href":"https://api.github.com/repos/uqbar-project/wollok/issues/787/comments"},"review_comments":{"href":"https://api.github.com/repos/uqbar-project/wollok/pulls/787/comments"},"review_comment":{"href":"https://api.github.com/repos/uqbar-project/wollok/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uqbar-project/wollok/pulls/787/commits"},"statuses":{"href":"https://api.github.com/repos/uqbar-project/wollok/statuses/c6943169430dc7a6583ee48e470b43ed6c7fb999"}}}}
{"actor":{"display_login":"tesonep"}}