{"action":"opened","issue":{"url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/523","repository_url":"https://api.github.com/repos/ethereum/webthree-umbrella","labels_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/523/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/523/comments","events_url":"https://api.github.com/repos/ethereum/webthree-umbrella/issues/523/events","html_url":"https://github.com/ethereum/webthree-umbrella/issues/523","id":156129763,"number":523,"title":"Remove Frontier canaries","user":{"login":"bobsummerwill","id":3788156,"avatar_url":"https://avatars.githubusercontent.com/u/3788156?v=3","gravatar_id":"","url":"https://api.github.com/users/bobsummerwill","html_url":"https://github.com/bobsummerwill","followers_url":"https://api.github.com/users/bobsummerwill/followers","following_url":"https://api.github.com/users/bobsummerwill/following{/other_user}","gists_url":"https://api.github.com/users/bobsummerwill/gists{/gist_id}","starred_url":"https://api.github.com/users/bobsummerwill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobsummerwill/subscriptions","organizations_url":"https://api.github.com/users/bobsummerwill/orgs","repos_url":"https://api.github.com/users/bobsummerwill/repos","events_url":"https://api.github.com/users/bobsummerwill/events{/privacy}","received_events_url":"https://api.github.com/users/bobsummerwill/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ethereum/webthree-umbrella/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2016-05-22T01:24:08Z","updated_at":"2016-05-22T01:24:08Z","closed_at":null,"body":"It appears that `geth` removed the Frontier canaries, but this work was neglected for `eth`, as highlighted by @theymos (thank you!) in https://www.reddit.com/r/Bitcoin/comments/4k2kki/stalling_time_for_what_bitcoins_needs_segwit_or/d3comb5.\r\n\r\n`geth` removal happened on April 4th in https://github.com/ethereum/go-ethereum/pull/2416 (as pinpointed by @karalabe), and as `geth` has ~99% of client market share, any triggering of the canaries in `eth` would only kill the `eth` clients.\r\n\r\nBut no two ways about it, this was a fuck-up and we should fix it right now.\r\n\r\nNot sure if pyethapp had the canary too?   Or other clients too?   They should be fixed too.\r\n\r\nSearch for `shouldSeal` and `canaries` in webthree-umbrella to find the references.\r\n\r\nHere are the key line which needs fixing:\r\n\r\nhttps://github.com/ethereum/libethereum/blob/develop/libethashseal/Ethash.cpp#L297"}}
{"actor":{"display_login":"bobsummerwill"}}