{"action":"created","comment":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/87193235","pull_request_review_id":7810357,"id":87193235,"diff_hunk":"@@ -471,41 +469,39 @@ function GlobeControls(camera, domElement, engine) {\n     var update = function() {\n \n         if (state === CONTROL_STATE.MOVE_GLOBE) {\n-            offset.copy(snapShotCamera.position);\n-        } else {\n-            // get camera position\n-            offset.copy(this.camera.position);\n-            // transform to local globeTarget\n-            offset.applyMatrix4( globeTarget.matrixWorldInverse );\n-        }\n-\n-        offGT.copy(globeTarget.position);\n \n-        if (state === CONTROL_STATE.MOVE_GLOBE) {\n+            movingGlobeTarget.copy(this.getCenter()).applyQuaternion(quatGlobe);\n+            this.camera.position.copy(snapShotCamera.position).applyQuaternion(quatGlobe);\n+            this.camera.up.copy(movingGlobeTarget.clone().normalize());","path":"src/Renderer/ThreeExtented/GlobeControls.js","position":68,"original_position":68,"commit_id":"c2b34aaab7c4c5ea85d1b3f5642c9b214feb9b50","original_commit_id":"c2b34aaab7c4c5ea85d1b3f5642c9b214feb9b50","user":{"login":"peppsac","id":2198295,"avatar_url":"https://avatars.githubusercontent.com/u/2198295?v=3","gravatar_id":"","url":"https://api.github.com/users/peppsac","html_url":"https://github.com/peppsac","followers_url":"https://api.github.com/users/peppsac/followers","following_url":"https://api.github.com/users/peppsac/following{/other_user}","gists_url":"https://api.github.com/users/peppsac/gists{/gist_id}","starred_url":"https://api.github.com/users/peppsac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peppsac/subscriptions","organizations_url":"https://api.github.com/users/peppsac/orgs","repos_url":"https://api.github.com/users/peppsac/repos","events_url":"https://api.github.com/users/peppsac/events{/privacy}","received_events_url":"https://api.github.com/users/peppsac/received_events","type":"User","site_admin":false},"body":"The controls are still buggy (even after this PR: try clicking outside the globe), so adding comments explaining what the code is supposed to do will help us fix the problems.","created_at":"2016-11-09T13:39:30Z","updated_at":"2016-11-09T13:57:29Z","html_url":"https://github.com/iTowns/itowns2/pull/194#discussion_r87193235","pull_request_url":"https://api.github.com/repos/iTowns/itowns2/pulls/194","_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments/87193235"},"html":{"href":"https://github.com/iTowns/itowns2/pull/194#discussion_r87193235"},"pull_request":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/194"}}},"pull_request":{"url":"https://api.github.com/repos/iTowns/itowns2/pulls/194","id":88640144,"html_url":"https://github.com/iTowns/itowns2/pull/194","diff_url":"https://github.com/iTowns/itowns2/pull/194.diff","patch_url":"https://github.com/iTowns/itowns2/pull/194.patch","issue_url":"https://api.github.com/repos/iTowns/itowns2/issues/194","number":194,"state":"open","locked":false,"title":"New Api Functions","user":{"login":"gchoqueux","id":11291849,"avatar_url":"https://avatars.githubusercontent.com/u/11291849?v=3","gravatar_id":"","url":"https://api.github.com/users/gchoqueux","html_url":"https://github.com/gchoqueux","followers_url":"https://api.github.com/users/gchoqueux/followers","following_url":"https://api.github.com/users/gchoqueux/following{/other_user}","gists_url":"https://api.github.com/users/gchoqueux/gists{/gist_id}","starred_url":"https://api.github.com/users/gchoqueux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchoqueux/subscriptions","organizations_url":"https://api.github.com/users/gchoqueux/orgs","repos_url":"https://api.github.com/users/gchoqueux/repos","events_url":"https://api.github.com/users/gchoqueux/events{/privacy}","received_events_url":"https://api.github.com/users/gchoqueux/received_events","type":"User","site_admin":false},"body":"Api functions\n- Add ApiGlobe.setZoomLevel()\n- ApiGlobe.getZoomScale()\n- Add ApiGlobe.setZoomScale(zoomScale)\n- Add ApiGlobe.pan(pVector)\n- Fix bug ApiGlobe.removeImageryLayer()\n\nFramework\n- Three js v80 to 82\n","created_at":"2016-10-10T10:30:01Z","updated_at":"2016-11-09T13:57:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f4b9d5166b12c7e316d1c846fed900679e265a2","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/iTowns/itowns2/milestones/1","html_url":"https://github.com/iTowns/itowns2/milestones/2.0","labels_url":"https://api.github.com/repos/iTowns/itowns2/milestones/1/labels","id":1977044,"number":1,"title":"2.0","description":"First release of major version iTowns 2.0 ","creator":{"login":"vpicavet","id":76112,"avatar_url":"https://avatars.githubusercontent.com/u/76112?v=3","gravatar_id":"","url":"https://api.github.com/users/vpicavet","html_url":"https://github.com/vpicavet","followers_url":"https://api.github.com/users/vpicavet/followers","following_url":"https://api.github.com/users/vpicavet/following{/other_user}","gists_url":"https://api.github.com/users/vpicavet/gists{/gist_id}","starred_url":"https://api.github.com/users/vpicavet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpicavet/subscriptions","organizations_url":"https://api.github.com/users/vpicavet/orgs","repos_url":"https://api.github.com/users/vpicavet/repos","events_url":"https://api.github.com/users/vpicavet/events{/privacy}","received_events_url":"https://api.github.com/users/vpicavet/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":4,"state":"open","created_at":"2016-09-01T08:37:19Z","updated_at":"2016-11-08T18:46:38Z","due_on":"2016-12-25T00:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/iTowns/itowns2/pulls/194/commits","review_comments_url":"https://api.github.com/repos/iTowns/itowns2/pulls/194/comments","review_comment_url":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iTowns/itowns2/issues/194/comments","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/c2b34aaab7c4c5ea85d1b3f5642c9b214feb9b50","head":{"label":"iTowns:ApiZoomScale","ref":"ApiZoomScale","sha":"c2b34aaab7c4c5ea85d1b3f5642c9b214feb9b50","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-10-25T15:07:13Z","pushed_at":"2016-11-09T11:06:36Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":68946,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":87,"forks":15,"open_issues":87,"watchers":20,"default_branch":"master"}},"base":{"label":"iTowns:master","ref":"master","sha":"60214d1d528f6c2d53cbc810883102674cde7260","user":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"repo":{"id":43068275,"name":"itowns2","full_name":"iTowns/itowns2","owner":{"login":"iTowns","id":14266889,"avatar_url":"https://avatars.githubusercontent.com/u/14266889?v=3","gravatar_id":"","url":"https://api.github.com/users/iTowns","html_url":"https://github.com/iTowns","followers_url":"https://api.github.com/users/iTowns/followers","following_url":"https://api.github.com/users/iTowns/following{/other_user}","gists_url":"https://api.github.com/users/iTowns/gists{/gist_id}","starred_url":"https://api.github.com/users/iTowns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iTowns/subscriptions","organizations_url":"https://api.github.com/users/iTowns/orgs","repos_url":"https://api.github.com/users/iTowns/repos","events_url":"https://api.github.com/users/iTowns/events{/privacy}","received_events_url":"https://api.github.com/users/iTowns/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iTowns/itowns2","description":"iTowns 2 is the next generation of iTowns, a JS/WebGL framework for 3D geospatial data visualization","fork":false,"url":"https://api.github.com/repos/iTowns/itowns2","forks_url":"https://api.github.com/repos/iTowns/itowns2/forks","keys_url":"https://api.github.com/repos/iTowns/itowns2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iTowns/itowns2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iTowns/itowns2/teams","hooks_url":"https://api.github.com/repos/iTowns/itowns2/hooks","issue_events_url":"https://api.github.com/repos/iTowns/itowns2/issues/events{/number}","events_url":"https://api.github.com/repos/iTowns/itowns2/events","assignees_url":"https://api.github.com/repos/iTowns/itowns2/assignees{/user}","branches_url":"https://api.github.com/repos/iTowns/itowns2/branches{/branch}","tags_url":"https://api.github.com/repos/iTowns/itowns2/tags","blobs_url":"https://api.github.com/repos/iTowns/itowns2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iTowns/itowns2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iTowns/itowns2/git/refs{/sha}","trees_url":"https://api.github.com/repos/iTowns/itowns2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iTowns/itowns2/statuses/{sha}","languages_url":"https://api.github.com/repos/iTowns/itowns2/languages","stargazers_url":"https://api.github.com/repos/iTowns/itowns2/stargazers","contributors_url":"https://api.github.com/repos/iTowns/itowns2/contributors","subscribers_url":"https://api.github.com/repos/iTowns/itowns2/subscribers","subscription_url":"https://api.github.com/repos/iTowns/itowns2/subscription","commits_url":"https://api.github.com/repos/iTowns/itowns2/commits{/sha}","git_commits_url":"https://api.github.com/repos/iTowns/itowns2/git/commits{/sha}","comments_url":"https://api.github.com/repos/iTowns/itowns2/comments{/number}","issue_comment_url":"https://api.github.com/repos/iTowns/itowns2/issues/comments{/number}","contents_url":"https://api.github.com/repos/iTowns/itowns2/contents/{+path}","compare_url":"https://api.github.com/repos/iTowns/itowns2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iTowns/itowns2/merges","archive_url":"https://api.github.com/repos/iTowns/itowns2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iTowns/itowns2/downloads","issues_url":"https://api.github.com/repos/iTowns/itowns2/issues{/number}","pulls_url":"https://api.github.com/repos/iTowns/itowns2/pulls{/number}","milestones_url":"https://api.github.com/repos/iTowns/itowns2/milestones{/number}","notifications_url":"https://api.github.com/repos/iTowns/itowns2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iTowns/itowns2/labels{/name}","releases_url":"https://api.github.com/repos/iTowns/itowns2/releases{/id}","deployments_url":"https://api.github.com/repos/iTowns/itowns2/deployments","created_at":"2015-09-24T13:24:26Z","updated_at":"2016-10-25T15:07:13Z","pushed_at":"2016-11-09T11:06:36Z","git_url":"git://github.com/iTowns/itowns2.git","ssh_url":"git@github.com:iTowns/itowns2.git","clone_url":"https://github.com/iTowns/itowns2.git","svn_url":"https://github.com/iTowns/itowns2","homepage":"","size":68946,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":87,"forks":15,"open_issues":87,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/194"},"html":{"href":"https://github.com/iTowns/itowns2/pull/194"},"issue":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/194"},"comments":{"href":"https://api.github.com/repos/iTowns/itowns2/issues/194/comments"},"review_comments":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/194/comments"},"review_comment":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iTowns/itowns2/pulls/194/commits"},"statuses":{"href":"https://api.github.com/repos/iTowns/itowns2/statuses/c2b34aaab7c4c5ea85d1b3f5642c9b214feb9b50"}}}}
{"actor":{"display_login":"peppsac"}}