{"action":"created","comment":{"url":"https://api.github.com/repos/grevory/angular-local-storage/pulls/comments/53482936","id":53482936,"diff_hunk":"@@ -302,7 +302,10 @@ angularLocalStorage.provider('localStorageService', function() {\n           expiryDate.setTime(expiryDate.getTime() + (-1 * 24 * 60 * 60 * 1000));\n           expiry = \"; expires=\" + expiryDate.toGMTString();\n           value = '';\n-        } else if (isNumber(daysToExpiry) && daysToExpiry !== 0) {\n+          //if the value is undefined set the cookie to session cookie\n+        } else if (daysToExpiry == undefined) {","path":"src/angular-local-storage.js","position":6,"original_position":6,"commit_id":"984866085c9bce4ed8db02ce57cc877aa8753482","original_commit_id":"984866085c9bce4ed8db02ce57cc877aa8753482","user":{"login":"jhenaoz","id":2055110,"avatar_url":"https://avatars.githubusercontent.com/u/2055110?v=3","gravatar_id":"","url":"https://api.github.com/users/jhenaoz","html_url":"https://github.com/jhenaoz","followers_url":"https://api.github.com/users/jhenaoz/followers","following_url":"https://api.github.com/users/jhenaoz/following{/other_user}","gists_url":"https://api.github.com/users/jhenaoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenaoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenaoz/subscriptions","organizations_url":"https://api.github.com/users/jhenaoz/orgs","repos_url":"https://api.github.com/users/jhenaoz/repos","events_url":"https://api.github.com/users/jhenaoz/events{/privacy}","received_events_url":"https://api.github.com/users/jhenaoz/received_events","type":"User","site_admin":false},"body":"but in this case i need to have a Session cookie for handle Oauth 2.0, so any other solution with this lib?","created_at":"2016-02-19T16:31:32Z","updated_at":"2016-02-19T16:31:32Z","html_url":"https://github.com/grevory/angular-local-storage/pull/269#discussion_r53482936","pull_request_url":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/grevory/angular-local-storage/pulls/comments/53482936"},"html":{"href":"https://github.com/grevory/angular-local-storage/pull/269#discussion_r53482936"},"pull_request":{"href":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269","id":56062412,"html_url":"https://github.com/grevory/angular-local-storage/pull/269","diff_url":"https://github.com/grevory/angular-local-storage/pull/269.diff","patch_url":"https://github.com/grevory/angular-local-storage/pull/269.patch","issue_url":"https://api.github.com/repos/grevory/angular-local-storage/issues/269","number":269,"state":"open","locked":false,"title":"change to support Session cookies","user":{"login":"jhenaoz","id":2055110,"avatar_url":"https://avatars.githubusercontent.com/u/2055110?v=3","gravatar_id":"","url":"https://api.github.com/users/jhenaoz","html_url":"https://github.com/jhenaoz","followers_url":"https://api.github.com/users/jhenaoz/followers","following_url":"https://api.github.com/users/jhenaoz/following{/other_user}","gists_url":"https://api.github.com/users/jhenaoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenaoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenaoz/subscriptions","organizations_url":"https://api.github.com/users/jhenaoz/orgs","repos_url":"https://api.github.com/users/jhenaoz/repos","events_url":"https://api.github.com/users/jhenaoz/events{/privacy}","received_events_url":"https://api.github.com/users/jhenaoz/received_events","type":"User","site_admin":false},"body":"if expiracy date of cookie is undefined, then is a session cookie, ju…","created_at":"2016-01-14T16:55:55Z","updated_at":"2016-02-19T16:31:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c31f626930206dc22f0179e4cfd818fdf10f164d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269/commits","review_comments_url":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269/comments","review_comment_url":"https://api.github.com/repos/grevory/angular-local-storage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grevory/angular-local-storage/issues/269/comments","statuses_url":"https://api.github.com/repos/grevory/angular-local-storage/statuses/984866085c9bce4ed8db02ce57cc877aa8753482","head":{"label":"jhenaoz:master","ref":"master","sha":"984866085c9bce4ed8db02ce57cc877aa8753482","user":{"login":"jhenaoz","id":2055110,"avatar_url":"https://avatars.githubusercontent.com/u/2055110?v=3","gravatar_id":"","url":"https://api.github.com/users/jhenaoz","html_url":"https://github.com/jhenaoz","followers_url":"https://api.github.com/users/jhenaoz/followers","following_url":"https://api.github.com/users/jhenaoz/following{/other_user}","gists_url":"https://api.github.com/users/jhenaoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenaoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenaoz/subscriptions","organizations_url":"https://api.github.com/users/jhenaoz/orgs","repos_url":"https://api.github.com/users/jhenaoz/repos","events_url":"https://api.github.com/users/jhenaoz/events{/privacy}","received_events_url":"https://api.github.com/users/jhenaoz/received_events","type":"User","site_admin":false},"repo":{"id":49658187,"name":"angular-local-storage","full_name":"jhenaoz/angular-local-storage","owner":{"login":"jhenaoz","id":2055110,"avatar_url":"https://avatars.githubusercontent.com/u/2055110?v=3","gravatar_id":"","url":"https://api.github.com/users/jhenaoz","html_url":"https://github.com/jhenaoz","followers_url":"https://api.github.com/users/jhenaoz/followers","following_url":"https://api.github.com/users/jhenaoz/following{/other_user}","gists_url":"https://api.github.com/users/jhenaoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jhenaoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhenaoz/subscriptions","organizations_url":"https://api.github.com/users/jhenaoz/orgs","repos_url":"https://api.github.com/users/jhenaoz/repos","events_url":"https://api.github.com/users/jhenaoz/events{/privacy}","received_events_url":"https://api.github.com/users/jhenaoz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhenaoz/angular-local-storage","description":"An AngularJS module that gives you access to the browsers local storage with cookie fallback","fork":true,"url":"https://api.github.com/repos/jhenaoz/angular-local-storage","forks_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/forks","keys_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/teams","hooks_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/hooks","issue_events_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/issues/events{/number}","events_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/events","assignees_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/assignees{/user}","branches_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/branches{/branch}","tags_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/tags","blobs_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/languages","stargazers_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/stargazers","contributors_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/contributors","subscribers_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/subscribers","subscription_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/subscription","commits_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/contents/{+path}","compare_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/merges","archive_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/downloads","issues_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/issues{/number}","pulls_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/labels{/name}","releases_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/releases{/id}","deployments_url":"https://api.github.com/repos/jhenaoz/angular-local-storage/deployments","created_at":"2016-01-14T16:06:21Z","updated_at":"2016-01-14T16:06:21Z","pushed_at":"2016-01-14T19:56:14Z","git_url":"git://github.com/jhenaoz/angular-local-storage.git","ssh_url":"git@github.com:jhenaoz/angular-local-storage.git","clone_url":"https://github.com/jhenaoz/angular-local-storage.git","svn_url":"https://github.com/jhenaoz/angular-local-storage","homepage":"http://gregpike.net/demos/angular-local-storage/demo.html","size":204,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grevory:master","ref":"master","sha":"ff233e43be10f55adc56b27a9cad0f42f3fd5675","user":{"login":"grevory","id":1222666,"avatar_url":"https://avatars.githubusercontent.com/u/1222666?v=3","gravatar_id":"","url":"https://api.github.com/users/grevory","html_url":"https://github.com/grevory","followers_url":"https://api.github.com/users/grevory/followers","following_url":"https://api.github.com/users/grevory/following{/other_user}","gists_url":"https://api.github.com/users/grevory/gists{/gist_id}","starred_url":"https://api.github.com/users/grevory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grevory/subscriptions","organizations_url":"https://api.github.com/users/grevory/orgs","repos_url":"https://api.github.com/users/grevory/repos","events_url":"https://api.github.com/users/grevory/events{/privacy}","received_events_url":"https://api.github.com/users/grevory/received_events","type":"User","site_admin":false},"repo":{"id":5567476,"name":"angular-local-storage","full_name":"grevory/angular-local-storage","owner":{"login":"grevory","id":1222666,"avatar_url":"https://avatars.githubusercontent.com/u/1222666?v=3","gravatar_id":"","url":"https://api.github.com/users/grevory","html_url":"https://github.com/grevory","followers_url":"https://api.github.com/users/grevory/followers","following_url":"https://api.github.com/users/grevory/following{/other_user}","gists_url":"https://api.github.com/users/grevory/gists{/gist_id}","starred_url":"https://api.github.com/users/grevory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grevory/subscriptions","organizations_url":"https://api.github.com/users/grevory/orgs","repos_url":"https://api.github.com/users/grevory/repos","events_url":"https://api.github.com/users/grevory/events{/privacy}","received_events_url":"https://api.github.com/users/grevory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grevory/angular-local-storage","description":"An AngularJS module that gives you access to the browsers local storage with cookie fallback","fork":false,"url":"https://api.github.com/repos/grevory/angular-local-storage","forks_url":"https://api.github.com/repos/grevory/angular-local-storage/forks","keys_url":"https://api.github.com/repos/grevory/angular-local-storage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grevory/angular-local-storage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grevory/angular-local-storage/teams","hooks_url":"https://api.github.com/repos/grevory/angular-local-storage/hooks","issue_events_url":"https://api.github.com/repos/grevory/angular-local-storage/issues/events{/number}","events_url":"https://api.github.com/repos/grevory/angular-local-storage/events","assignees_url":"https://api.github.com/repos/grevory/angular-local-storage/assignees{/user}","branches_url":"https://api.github.com/repos/grevory/angular-local-storage/branches{/branch}","tags_url":"https://api.github.com/repos/grevory/angular-local-storage/tags","blobs_url":"https://api.github.com/repos/grevory/angular-local-storage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grevory/angular-local-storage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grevory/angular-local-storage/git/refs{/sha}","trees_url":"https://api.github.com/repos/grevory/angular-local-storage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grevory/angular-local-storage/statuses/{sha}","languages_url":"https://api.github.com/repos/grevory/angular-local-storage/languages","stargazers_url":"https://api.github.com/repos/grevory/angular-local-storage/stargazers","contributors_url":"https://api.github.com/repos/grevory/angular-local-storage/contributors","subscribers_url":"https://api.github.com/repos/grevory/angular-local-storage/subscribers","subscription_url":"https://api.github.com/repos/grevory/angular-local-storage/subscription","commits_url":"https://api.github.com/repos/grevory/angular-local-storage/commits{/sha}","git_commits_url":"https://api.github.com/repos/grevory/angular-local-storage/git/commits{/sha}","comments_url":"https://api.github.com/repos/grevory/angular-local-storage/comments{/number}","issue_comment_url":"https://api.github.com/repos/grevory/angular-local-storage/issues/comments{/number}","contents_url":"https://api.github.com/repos/grevory/angular-local-storage/contents/{+path}","compare_url":"https://api.github.com/repos/grevory/angular-local-storage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grevory/angular-local-storage/merges","archive_url":"https://api.github.com/repos/grevory/angular-local-storage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grevory/angular-local-storage/downloads","issues_url":"https://api.github.com/repos/grevory/angular-local-storage/issues{/number}","pulls_url":"https://api.github.com/repos/grevory/angular-local-storage/pulls{/number}","milestones_url":"https://api.github.com/repos/grevory/angular-local-storage/milestones{/number}","notifications_url":"https://api.github.com/repos/grevory/angular-local-storage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grevory/angular-local-storage/labels{/name}","releases_url":"https://api.github.com/repos/grevory/angular-local-storage/releases{/id}","deployments_url":"https://api.github.com/repos/grevory/angular-local-storage/deployments","created_at":"2012-08-27T06:31:44Z","updated_at":"2016-02-19T16:28:12Z","pushed_at":"2016-02-19T16:07:24Z","git_url":"git://github.com/grevory/angular-local-storage.git","ssh_url":"git@github.com:grevory/angular-local-storage.git","clone_url":"https://github.com/grevory/angular-local-storage.git","svn_url":"https://github.com/grevory/angular-local-storage","homepage":"http://gregpike.net/demos/angular-local-storage/demo.html","size":1873,"stargazers_count":2216,"watchers_count":2216,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":58,"forks":450,"open_issues":58,"watchers":2216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269"},"html":{"href":"https://github.com/grevory/angular-local-storage/pull/269"},"issue":{"href":"https://api.github.com/repos/grevory/angular-local-storage/issues/269"},"comments":{"href":"https://api.github.com/repos/grevory/angular-local-storage/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/grevory/angular-local-storage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grevory/angular-local-storage/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/grevory/angular-local-storage/statuses/984866085c9bce4ed8db02ce57cc877aa8753482"}}}}