{"action":"closed","number":378,"pull_request":{"url":"https://api.github.com/repos/buchen/portfolio/pulls/378","id":53471645,"html_url":"https://github.com/buchen/portfolio/pull/378","diff_url":"https://github.com/buchen/portfolio/pull/378.diff","patch_url":"https://github.com/buchen/portfolio/pull/378.patch","issue_url":"https://api.github.com/repos/buchen/portfolio/issues/378","number":378,"state":"closed","locked":false,"title":"Feature Rickshaw (HTML Charts)","user":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"body":"**This pull requests supersedes the #356**\r\n\r\nHi @fuchsst,\r\n\r\nIch habe Deinen Pull Request von #356 aufgenommen und als neuen, separaten Branch [feature_rickshaw](https://github.com/buchen/portfolio/tree/feature_rickshaw) eingecheckt. Als erstes habe ich alle Deine Commits in einen zusammengefasst (a9265c9e777e9bc5ae7446783c68e0a7953664d0 - squashed und rebase auf master) und dann kleine Formatierungen vorgenommen (192d2cbf18f2e2d4d5fe03f55444072e53cee507 - siehe Commit Message). Ich schlage vor, wir arbeiten jetzt auf diesem Branch weiter.\r\n\r\nJetzt zu den Punkten die mir aufgefallen sind:\r\n\r\nAls aller erstes ist die **Browser Implementierung unter Windows** echt bescheiden. Die Achsen fehlen komplett, und vor allem dauert es merklich bis überhaupt die Ansicht geöffnet wird. Und dann bekommt man auch noch einen bescheuerten \"Klick\" aus dem Lautsprecher wenn man das Browserfenster schliesst - sprich: wenn man in eine andere Ansicht wechselt. IE ist echt Mist. Ich selber nutze das ja nicht, aber 70% der Downloads sind für Windows. Darum ist das für mich trotzdem kritisch.\r\n\r\nIch habe jetzt etwas recherchiert und bin über diesen Kommentar in [Eclipse Bug 405031](https://bugs.eclipse.org/bugs/show_bug.cgi?id=405031#c9) gestolpert. Der JavaFX Browser sollte WebKit auch unter Windows unterstützen.\r\n\r\nIch werde jetzt als Erstes probieren, ob ich a) den JavaFX Browser aktiviert bekomme und b) ob damit das Verhalten besser ist.\r\n\r\nHier ein Screenshot unter Windows:\r\n<img width=\"596\" alt=\"bildschirmfoto 2015-12-12 um 08 01 17\" src=\"https://cloud.githubusercontent.com/assets/587976/11760964/d58adf46-a0b0-11e5-9351-c7d265665b0d.png\">\r\n\r\n\r\nNeben dem Windows Support habe ich mir jetzt folgendes notiert:\r\n* Speicher Kontextmenü unter Mac kollidiert mit \"Anzeige von Wert der Datenreihe\"\r\n* Export Funktionalität entfernen (bei mir kommt sowieso eine Exception)\r\n* Diagramm der Verbraucherpreise zeigt nix an / ist leer\r\n* Resizing des Diagramms wenn man die Fenstergrösse ändert (siehe Screenshot)\r\n* (optional) vielleicht irgendwie Hilfe zu der Diagrammsteuerung einbauen\r\n* (optional) Tastatur Steuerung\r\n* (optional) eine Bereich zum Zoom per Maus auswählen\r\n\r\nAus dem anderen Pull Request #356 habe ich noch folgendes notiert:\r\n> [...] die Zeitachse noch anpassen. Die ist in der Form nicht sehr Hilfreich (z.B. wenn nur die Monatsnamen eingeblendet werden) - vor allem wenn man Zoomt und hin und her schiebt.\r\nDas ist für mich eher auch optional weil man ja immer das komplette Datum unter dem Mauszeiger sieht.\r\n\r\n<img width=\"755\" alt=\"bildschirmfoto 2015-12-12 um 08 17 11\" src=\"https://cloud.githubusercontent.com/assets/587976/11760977/416c3d04-a0b1-11e5-9736-9e76881c8e32.png\">","created_at":"2015-12-12T08:22:50Z","updated_at":"2016-01-16T12:41:35Z","closed_at":"2016-01-16T12:41:35Z","merged_at":null,"merge_commit_sha":"3743bf8fc1125964d3874d568628f8a7a313d0d7","assignee":null,"milestone":{"url":"https://api.github.com/repos/buchen/portfolio/milestones/8","html_url":"https://github.com/buchen/portfolio/milestones/2016%20Q1%20Short-List","labels_url":"https://api.github.com/repos/buchen/portfolio/milestones/8/labels","id":1470956,"number":8,"title":"2016 Q1 Short-List","description":"","creator":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":5,"state":"open","created_at":"2015-12-22T10:13:08Z","updated_at":"2016-01-16T12:41:35Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/buchen/portfolio/pulls/378/commits","review_comments_url":"https://api.github.com/repos/buchen/portfolio/pulls/378/comments","review_comment_url":"https://api.github.com/repos/buchen/portfolio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/buchen/portfolio/issues/378/comments","statuses_url":"https://api.github.com/repos/buchen/portfolio/statuses/68c97968ce62812b30e196292f3741b10a1e45ba","head":{"label":"buchen:feature_rickshaw","ref":"feature_rickshaw","sha":"68c97968ce62812b30e196292f3741b10a1e45ba","user":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"repo":{"id":3816238,"name":"portfolio","full_name":"buchen/portfolio","owner":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buchen/portfolio","description":"A simple tool to calculate the overall performance of an investment portfolio.","fork":false,"url":"https://api.github.com/repos/buchen/portfolio","forks_url":"https://api.github.com/repos/buchen/portfolio/forks","keys_url":"https://api.github.com/repos/buchen/portfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buchen/portfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buchen/portfolio/teams","hooks_url":"https://api.github.com/repos/buchen/portfolio/hooks","issue_events_url":"https://api.github.com/repos/buchen/portfolio/issues/events{/number}","events_url":"https://api.github.com/repos/buchen/portfolio/events","assignees_url":"https://api.github.com/repos/buchen/portfolio/assignees{/user}","branches_url":"https://api.github.com/repos/buchen/portfolio/branches{/branch}","tags_url":"https://api.github.com/repos/buchen/portfolio/tags","blobs_url":"https://api.github.com/repos/buchen/portfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buchen/portfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buchen/portfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/buchen/portfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buchen/portfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/buchen/portfolio/languages","stargazers_url":"https://api.github.com/repos/buchen/portfolio/stargazers","contributors_url":"https://api.github.com/repos/buchen/portfolio/contributors","subscribers_url":"https://api.github.com/repos/buchen/portfolio/subscribers","subscription_url":"https://api.github.com/repos/buchen/portfolio/subscription","commits_url":"https://api.github.com/repos/buchen/portfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/buchen/portfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/buchen/portfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/buchen/portfolio/issues/comments{/number}","contents_url":"https://api.github.com/repos/buchen/portfolio/contents/{+path}","compare_url":"https://api.github.com/repos/buchen/portfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buchen/portfolio/merges","archive_url":"https://api.github.com/repos/buchen/portfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buchen/portfolio/downloads","issues_url":"https://api.github.com/repos/buchen/portfolio/issues{/number}","pulls_url":"https://api.github.com/repos/buchen/portfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/buchen/portfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/buchen/portfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buchen/portfolio/labels{/name}","releases_url":"https://api.github.com/repos/buchen/portfolio/releases{/id}","created_at":"2012-03-24T09:43:08Z","updated_at":"2016-01-12T02:43:07Z","pushed_at":"2016-01-16T12:41:26Z","git_url":"git://github.com/buchen/portfolio.git","ssh_url":"git@github.com:buchen/portfolio.git","clone_url":"https://github.com/buchen/portfolio.git","svn_url":"https://github.com/buchen/portfolio","homepage":"http://buchen.github.io/portfolio/","size":18745,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":118,"forks":34,"open_issues":118,"watchers":63,"default_branch":"master"}},"base":{"label":"buchen:master","ref":"master","sha":"e557e9d61354bf137cff7b1523f2384e7462de3e","user":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"repo":{"id":3816238,"name":"portfolio","full_name":"buchen/portfolio","owner":{"login":"buchen","id":587976,"avatar_url":"https://avatars.githubusercontent.com/u/587976?v=3","gravatar_id":"","url":"https://api.github.com/users/buchen","html_url":"https://github.com/buchen","followers_url":"https://api.github.com/users/buchen/followers","following_url":"https://api.github.com/users/buchen/following{/other_user}","gists_url":"https://api.github.com/users/buchen/gists{/gist_id}","starred_url":"https://api.github.com/users/buchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchen/subscriptions","organizations_url":"https://api.github.com/users/buchen/orgs","repos_url":"https://api.github.com/users/buchen/repos","events_url":"https://api.github.com/users/buchen/events{/privacy}","received_events_url":"https://api.github.com/users/buchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buchen/portfolio","description":"A simple tool to calculate the overall performance of an investment portfolio.","fork":false,"url":"https://api.github.com/repos/buchen/portfolio","forks_url":"https://api.github.com/repos/buchen/portfolio/forks","keys_url":"https://api.github.com/repos/buchen/portfolio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buchen/portfolio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buchen/portfolio/teams","hooks_url":"https://api.github.com/repos/buchen/portfolio/hooks","issue_events_url":"https://api.github.com/repos/buchen/portfolio/issues/events{/number}","events_url":"https://api.github.com/repos/buchen/portfolio/events","assignees_url":"https://api.github.com/repos/buchen/portfolio/assignees{/user}","branches_url":"https://api.github.com/repos/buchen/portfolio/branches{/branch}","tags_url":"https://api.github.com/repos/buchen/portfolio/tags","blobs_url":"https://api.github.com/repos/buchen/portfolio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buchen/portfolio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buchen/portfolio/git/refs{/sha}","trees_url":"https://api.github.com/repos/buchen/portfolio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buchen/portfolio/statuses/{sha}","languages_url":"https://api.github.com/repos/buchen/portfolio/languages","stargazers_url":"https://api.github.com/repos/buchen/portfolio/stargazers","contributors_url":"https://api.github.com/repos/buchen/portfolio/contributors","subscribers_url":"https://api.github.com/repos/buchen/portfolio/subscribers","subscription_url":"https://api.github.com/repos/buchen/portfolio/subscription","commits_url":"https://api.github.com/repos/buchen/portfolio/commits{/sha}","git_commits_url":"https://api.github.com/repos/buchen/portfolio/git/commits{/sha}","comments_url":"https://api.github.com/repos/buchen/portfolio/comments{/number}","issue_comment_url":"https://api.github.com/repos/buchen/portfolio/issues/comments{/number}","contents_url":"https://api.github.com/repos/buchen/portfolio/contents/{+path}","compare_url":"https://api.github.com/repos/buchen/portfolio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buchen/portfolio/merges","archive_url":"https://api.github.com/repos/buchen/portfolio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buchen/portfolio/downloads","issues_url":"https://api.github.com/repos/buchen/portfolio/issues{/number}","pulls_url":"https://api.github.com/repos/buchen/portfolio/pulls{/number}","milestones_url":"https://api.github.com/repos/buchen/portfolio/milestones{/number}","notifications_url":"https://api.github.com/repos/buchen/portfolio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buchen/portfolio/labels{/name}","releases_url":"https://api.github.com/repos/buchen/portfolio/releases{/id}","created_at":"2012-03-24T09:43:08Z","updated_at":"2016-01-12T02:43:07Z","pushed_at":"2016-01-16T12:41:26Z","git_url":"git://github.com/buchen/portfolio.git","ssh_url":"git@github.com:buchen/portfolio.git","clone_url":"https://github.com/buchen/portfolio.git","svn_url":"https://github.com/buchen/portfolio","homepage":"http://buchen.github.io/portfolio/","size":18745,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":118,"forks":34,"open_issues":118,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/buchen/portfolio/pulls/378"},"html":{"href":"https://github.com/buchen/portfolio/pull/378"},"issue":{"href":"https://api.github.com/repos/buchen/portfolio/issues/378"},"comments":{"href":"https://api.github.com/repos/buchen/portfolio/issues/378/comments"},"review_comments":{"href":"https://api.github.com/repos/buchen/portfolio/pulls/378/comments"},"review_comment":{"href":"https://api.github.com/repos/buchen/portfolio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/buchen/portfolio/pulls/378/commits"},"statuses":{"href":"https://api.github.com/repos/buchen/portfolio/statuses/68c97968ce62812b30e196292f3741b10a1e45ba"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":10,"review_comments":0,"commits":6,"additions":37858,"deletions":301,"changed_files":49}}