{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments/85737413","pull_request_review_id":6434864,"id":85737413,"diff_hunk":"@@ -15,6 +15,11 @@ public void ConnectTo(string url)\n         {\n             Url = url;\n \n+            if (url == null)","path":"src/ServiceInsight/ServiceControl/ServiceControlConnectionProvider.cs","position":4,"original_position":4,"commit_id":"a5bf6ea5746350d193f9fa5266ac9c248b8bd855","original_commit_id":"a5bf6ea5746350d193f9fa5266ac9c248b8bd855","user":{"login":"adamralph","id":677704,"avatar_url":"https://avatars.githubusercontent.com/u/677704?v=3","gravatar_id":"","url":"https://api.github.com/users/adamralph","html_url":"https://github.com/adamralph","followers_url":"https://api.github.com/users/adamralph/followers","following_url":"https://api.github.com/users/adamralph/following{/other_user}","gists_url":"https://api.github.com/users/adamralph/gists{/gist_id}","starred_url":"https://api.github.com/users/adamralph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamralph/subscriptions","organizations_url":"https://api.github.com/users/adamralph/orgs","repos_url":"https://api.github.com/users/adamralph/repos","events_url":"https://api.github.com/users/adamralph/events{/privacy}","received_events_url":"https://api.github.com/users/adamralph/received_events","type":"User","site_admin":false},"body":"Would it be better to throw an exception in this case? I guess we're fixing the problem at the call site below?","created_at":"2016-10-31T13:28:50Z","updated_at":"2016-10-31T13:28:50Z","html_url":"https://github.com/Particular/ServiceInsight/pull/614#discussion_r85737413","pull_request_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614","_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments/85737413"},"html":{"href":"https://github.com/Particular/ServiceInsight/pull/614#discussion_r85737413"},"pull_request":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614","id":91550013,"html_url":"https://github.com/Particular/ServiceInsight/pull/614","diff_url":"https://github.com/Particular/ServiceInsight/pull/614.diff","patch_url":"https://github.com/Particular/ServiceInsight/pull/614.patch","issue_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/614","number":614,"state":"closed","locked":false,"title":"Fixes #613.","user":{"login":"HEskandari","id":132117,"avatar_url":"https://avatars.githubusercontent.com/u/132117?v=3","gravatar_id":"","url":"https://api.github.com/users/HEskandari","html_url":"https://github.com/HEskandari","followers_url":"https://api.github.com/users/HEskandari/followers","following_url":"https://api.github.com/users/HEskandari/following{/other_user}","gists_url":"https://api.github.com/users/HEskandari/gists{/gist_id}","starred_url":"https://api.github.com/users/HEskandari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEskandari/subscriptions","organizations_url":"https://api.github.com/users/HEskandari/orgs","repos_url":"https://api.github.com/users/HEskandari/repos","events_url":"https://api.github.com/users/HEskandari/events{/privacy}","received_events_url":"https://api.github.com/users/HEskandari/received_events","type":"User","site_admin":false},"body":"Doing a null check on the url SI connects to. Also doing that on OnInitialize to fix the auto-connect on startup issue.\r\n\r\n---\r\n\r\nFixes #613","created_at":"2016-10-31T02:47:53Z","updated_at":"2016-10-31T13:28:50Z","closed_at":"2016-10-31T05:12:31Z","merged_at":"2016-10-31T05:12:31Z","merge_commit_sha":"4d43c526c9d01ee84631d84bdff977f5a70bca9a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614/commits","review_comments_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614/comments","review_comment_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/614/comments","statuses_url":"https://api.github.com/repos/Particular/ServiceInsight/statuses/a5bf6ea5746350d193f9fa5266ac9c248b8bd855","head":{"label":"Particular:fixing-previous-connection-issue","ref":"fixing-previous-connection-issue","sha":"a5bf6ea5746350d193f9fa5266ac9c248b8bd855","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":8025385,"name":"ServiceInsight","full_name":"Particular/ServiceInsight","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceInsight","description":"Profiler for NServiceBus ","fork":false,"url":"https://api.github.com/repos/Particular/ServiceInsight","forks_url":"https://api.github.com/repos/Particular/ServiceInsight/forks","keys_url":"https://api.github.com/repos/Particular/ServiceInsight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceInsight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceInsight/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceInsight/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceInsight/events","assignees_url":"https://api.github.com/repos/Particular/ServiceInsight/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceInsight/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceInsight/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceInsight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceInsight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceInsight/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceInsight/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceInsight/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceInsight/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceInsight/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceInsight/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceInsight/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceInsight/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceInsight/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceInsight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceInsight/merges","archive_url":"https://api.github.com/repos/Particular/ServiceInsight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceInsight/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceInsight/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceInsight/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceInsight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceInsight/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceInsight/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceInsight/deployments","created_at":"2013-02-05T08:37:02Z","updated_at":"2016-10-31T05:12:35Z","pushed_at":"2016-10-31T05:19:20Z","git_url":"git://github.com/Particular/ServiceInsight.git","ssh_url":"git@github.com:Particular/ServiceInsight.git","clone_url":"https://github.com/Particular/ServiceInsight.git","svn_url":"https://github.com/Particular/ServiceInsight","homepage":"http://particular.net/serviceinsight","size":68945,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":75,"forks":21,"open_issues":75,"watchers":11,"default_branch":"master"}},"base":{"label":"Particular:master","ref":"master","sha":"4a1562e044cb19177cc7a7a4d57b6b2ad88596ad","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":8025385,"name":"ServiceInsight","full_name":"Particular/ServiceInsight","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/ServiceInsight","description":"Profiler for NServiceBus ","fork":false,"url":"https://api.github.com/repos/Particular/ServiceInsight","forks_url":"https://api.github.com/repos/Particular/ServiceInsight/forks","keys_url":"https://api.github.com/repos/Particular/ServiceInsight/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/ServiceInsight/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/ServiceInsight/teams","hooks_url":"https://api.github.com/repos/Particular/ServiceInsight/hooks","issue_events_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/ServiceInsight/events","assignees_url":"https://api.github.com/repos/Particular/ServiceInsight/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/ServiceInsight/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/ServiceInsight/tags","blobs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/ServiceInsight/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/ServiceInsight/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/ServiceInsight/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/ServiceInsight/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/ServiceInsight/languages","stargazers_url":"https://api.github.com/repos/Particular/ServiceInsight/stargazers","contributors_url":"https://api.github.com/repos/Particular/ServiceInsight/contributors","subscribers_url":"https://api.github.com/repos/Particular/ServiceInsight/subscribers","subscription_url":"https://api.github.com/repos/Particular/ServiceInsight/subscription","commits_url":"https://api.github.com/repos/Particular/ServiceInsight/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/ServiceInsight/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/ServiceInsight/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/ServiceInsight/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/ServiceInsight/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/ServiceInsight/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/ServiceInsight/merges","archive_url":"https://api.github.com/repos/Particular/ServiceInsight/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/ServiceInsight/downloads","issues_url":"https://api.github.com/repos/Particular/ServiceInsight/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/ServiceInsight/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/ServiceInsight/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/ServiceInsight/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/ServiceInsight/labels{/name}","releases_url":"https://api.github.com/repos/Particular/ServiceInsight/releases{/id}","deployments_url":"https://api.github.com/repos/Particular/ServiceInsight/deployments","created_at":"2013-02-05T08:37:02Z","updated_at":"2016-10-31T05:12:35Z","pushed_at":"2016-10-31T05:19:20Z","git_url":"git://github.com/Particular/ServiceInsight.git","ssh_url":"git@github.com:Particular/ServiceInsight.git","clone_url":"https://github.com/Particular/ServiceInsight.git","svn_url":"https://github.com/Particular/ServiceInsight","homepage":"http://particular.net/serviceinsight","size":68945,"stargazers_count":11,"watchers_count":11,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":75,"forks":21,"open_issues":75,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614"},"html":{"href":"https://github.com/Particular/ServiceInsight/pull/614"},"issue":{"href":"https://api.github.com/repos/Particular/ServiceInsight/issues/614"},"comments":{"href":"https://api.github.com/repos/Particular/ServiceInsight/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/ServiceInsight/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/ServiceInsight/statuses/a5bf6ea5746350d193f9fa5266ac9c248b8bd855"}}}}
{"actor":{"display_login":"adamralph"}}