{"push_id":1450563563,"size":14,"distinct_size":9,"ref":"refs/heads/backbone","head":"1292daa22b0e78a8331c93c90b9adb8d4548905e","before":"060bb52b7b0828e64c5cea17c08fb862f3c5db2d","commits":[{"sha":"7b762b8fdd278bbd16e8f7c7005a3e8923d18fe2","author":{"name":"Meitar M","email":"6e13892de41862cdb7eecf2efa49d15477b6cc53@gmail.com"},"message":"Merge pull request #189 from meitar/develop\n\nUpdate translations.","distinct":false,"url":"https://api.github.com/repos/meitar/buoy/commits/7b762b8fdd278bbd16e8f7c7005a3e8923d18fe2"},{"sha":"115060c3e804148702f30a17cecbf2316ea9ccad","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Fix chat bug where responders repeatedly received old messages.\n\nThis bug was only visible to users of browsers that did not support\nHTML5 SSE and Buoy's chat room was therefore polling the WP REST API to\ndownload new comments (chat messages) in the incident chat room. When a\nuser sent a new chat message, other users whose browsers were not\nSSE-capable received the *first* chat message sent to the room instead\nof the *newest* (latest/last) chat message sent to the room.\n\nThe bug was fixed by correctly ordering the result set of the API query.","distinct":false,"url":"https://api.github.com/repos/meitar/buoy/commits/115060c3e804148702f30a17cecbf2316ea9ccad"},{"sha":"1c3937caac7112ea99f661c1e874275015a85495","author":{"name":"Meitar M","email":"6e13892de41862cdb7eecf2efa49d15477b6cc53@gmail.com"},"message":"Merge pull request #196 from meitar/fix-wrong-last-chat\n\nFix chat bug where responders repeatedly received old messages.","distinct":false,"url":"https://api.github.com/repos/meitar/buoy/commits/1c3937caac7112ea99f661c1e874275015a85495"},{"sha":"b6e0ec8fa19293a5570ad9a96a38c5d40a54708f","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Fixes #163, #140: Simpler SSE handling now that Firefox behaves better.\n\nThe explicit `RESTART` messages have been removed in this commit because\nFirefox's behavior upon a server disconnect is now standards-compliant,\nmeaning it correctly reconnects automatically. The code handling the\n`RESTART` messages has thus been moved to the `.onerror` handler.\n\nThis also means we no longer need to show the confusing \"Click here to\nmanually reconnect\" error notices to users.","distinct":false,"url":"https://api.github.com/repos/meitar/buoy/commits/b6e0ec8fa19293a5570ad9a96a38c5d40a54708f"},{"sha":"9f192c92bdaeaa0b3c62f96597be0d8a2a11dc77","author":{"name":"Meitar M","email":"6e13892de41862cdb7eecf2efa49d15477b6cc53@gmail.com"},"message":"Merge pull request #197 from meitar/fix-sse-chat\n\nFixes #163, #140: Simpler SSE handling now that Firefox behaves better.","distinct":false,"url":"https://api.github.com/repos/meitar/buoy/commits/9f192c92bdaeaa0b3c62f96597be0d8a2a11dc77"},{"sha":"e4d2047ce1d04ac96317e6b595ff1523cdbf8039","author":{"name":"mcverter","email":"d0e5e084d0d1a24765daf234b82f135e1e884261@gmail.com"},"message":"Beginning Backbone Implementation (#199)\n\n* changed buoy-alert to use backbone.  removed requirement of attach handlers from buoy.js.  added dependencies in php\r\n\r\n* removing 'addhandlers' because it no longer exists in buoy-alert.js\r\n\r\n* fixed id on submittingalertmodal\r\n\r\n* fixing schedule alert\r\n\r\n* Did not work on menu bar.  Removing my edits and replacing with original code\r\n\r\n* removing unused event\r\n\r\n* linting\r\n\r\n* linting\r\n\r\n* properly injecting global dependencies\r\n\r\n* linting\r\n\r\n* two space indent\r\n\r\n* linting","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/e4d2047ce1d04ac96317e6b595ff1523cdbf8039"},{"sha":"0cd4e617187818ce9810d6470b8a04409e13fed6","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Revert \"Beginning Backbone Implementation (#199)\"\n\nThis reverts commit e4d2047ce1d04ac96317e6b595ff1523cdbf8039.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/0cd4e617187818ce9810d6470b8a04409e13fed6"},{"sha":"6d047e034f41046ae2838424fc38849a3af50a7c","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Let's actually test if we can activate/deactivate without erroring.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/6d047e034f41046ae2838424fc38849a3af50a7c"},{"sha":"032bc1f53bf10f55c47b874dc6317fd7a27a2830","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"DRY'er DOM hooks in `buoy.js`, all related to the Alert thingies.\n\nBecause JavaScript is a fucking mess, and this also DRYs the front-end\ntesting, Karma will always report failure when running JS tests since\nthe new global JavaScript object to hold the DOM hooks\n(`buoy_dom_hooks`) isn't being loaded in the test runner's container.\nSince this object is now dynamically constructed by using WordPress's\n`wp_localize_script()`, I don't actually know how to include this in the\ntest runner. So, it'd be nice if we figured that out at some point.\n\nMeanwhile, we can either:\n\n* Repeat ourselves in the test runner and just *hope* things work.\n* DRY the tests and manually duplicate a JS object in the test runner.\n\nI hate both of these options so basically my approach right now is: fuck\nJavaScript, and fuck these tests, since we're not actually failing\nbuilds with the JS tests in Travis (yet) anyway. shrug.gif and stuff.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/032bc1f53bf10f55c47b874dc6317fd7a27a2830"},{"sha":"c86f8cda23cc8bb3e1163ec456b576993adf4589","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"DRY the `BUOY_MAP` module.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/c86f8cda23cc8bb3e1163ec456b576993adf4589"},{"sha":"533d82aca7f3fbd5daa5567475ae4313ed9942b3","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"DRY the `BUOY_ALERT` module.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/533d82aca7f3fbd5daa5567475ae4313ed9942b3"},{"sha":"d710556c37f1be111aca9be6477fed5aae083fed","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Typo: `strinct` should be `strict`, lol.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/d710556c37f1be111aca9be6477fed5aae083fed"},{"sha":"38e8217e8921e194fe14aa910ae0e43596beb810","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Begin lightweight Backbone refactor. This commit does the following:\n\n* Marks BackboneJS as a dependency of Buoy, so WordPress will load it.\n* Creates a `Backbone.View` for the \"Activate Alert\" screen.\n* Migrates JavaScript code from the `buoy-alert.js` module to Backbone.\n* Renames ID for the Immediate Alert button to `immediate-alert-button`\n* Updates all stylesheet references to point to this new ID.\n* Removes this ID from `buoy_dom_hooks`, not needed with Backbone!\n* Re-orders \"main\" script file code to group TODO tasks more logically.\n\nThis is just a beginning to show how we can *simply* (i.e., gradually\nand without adding any complexity) refactor the existing client-side\ncode while also avoiding creating dependencies on JavaScript.\n\nTL;DR: We can use Backbone to structure our  code without requiring the\nuse of JavaScript. Buoy currently can (and should continue to remain)\nusable *WITHOUT JAVASCRIPT ENABLED*.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/38e8217e8921e194fe14aa910ae0e43596beb810"},{"sha":"1292daa22b0e78a8331c93c90b9adb8d4548905e","author":{"name":"Meitar Moscovitz","email":"76145e930fa2ed809d643f2f4408db9ae7608397@gmail.com"},"message":"Complete first pass of the UI conversion to Backbone.\n\nThis commit continues in the pattern from the previous commit, removing\nthe `buoy_dom_hooks` where they are no longer needed and converting each\nindividual user interface element to a `Backbone.View` object. Notably:\n\n* Alert button names have been standardized across the codebase.\n* The `attachHandlers` method was replaced with Backbone constructors.\n* Bug in `class-buoy-alert.php` when scheduling Timed Alerts was fixed.\n* JSDoc syntax is now used thoroughly across the `alert.js` file. Yay!\n\nThis isn't perfect yet. There are a few parts where the lack of a real\n`Backbone.Model` for our alerts are requiring some hacky things. But the\npurpose of this commit was to begin the migration to a Backbone-based\nstructure as gradually as is sensible to do so. Models will come later.","distinct":true,"url":"https://api.github.com/repos/meitar/buoy/commits/1292daa22b0e78a8331c93c90b9adb8d4548905e"}]}
{"actor":{"display_login":"meitar"}}