{"action":"created","issue":{"url":"https://api.github.com/repos/brianc/node-pg-copy-streams/issues/35","repository_url":"https://api.github.com/repos/brianc/node-pg-copy-streams","labels_url":"https://api.github.com/repos/brianc/node-pg-copy-streams/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/brianc/node-pg-copy-streams/issues/35/comments","events_url":"https://api.github.com/repos/brianc/node-pg-copy-streams/issues/35/events","html_url":"https://github.com/brianc/node-pg-copy-streams/pull/35","id":122604690,"number":35,"title":"Fix pg-copy-stream to work with node-postgres 4.x and node 4.2.2","user":{"login":"chriskinsman","id":1522018,"avatar_url":"https://avatars.githubusercontent.com/u/1522018?v=3","gravatar_id":"","url":"https://api.github.com/users/chriskinsman","html_url":"https://github.com/chriskinsman","followers_url":"https://api.github.com/users/chriskinsman/followers","following_url":"https://api.github.com/users/chriskinsman/following{/other_user}","gists_url":"https://api.github.com/users/chriskinsman/gists{/gist_id}","starred_url":"https://api.github.com/users/chriskinsman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriskinsman/subscriptions","organizations_url":"https://api.github.com/users/chriskinsman/orgs","repos_url":"https://api.github.com/users/chriskinsman/repos","events_url":"https://api.github.com/users/chriskinsman/events{/privacy}","received_events_url":"https://api.github.com/users/chriskinsman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-12-16T21:21:16Z","updated_at":"2016-05-03T21:32:56Z","closed_at":"2016-05-03T18:23:22Z","pull_request":{"url":"https://api.github.com/repos/brianc/node-pg-copy-streams/pulls/35","html_url":"https://github.com/brianc/node-pg-copy-streams/pull/35","diff_url":"https://github.com/brianc/node-pg-copy-streams/pull/35.diff","patch_url":"https://github.com/brianc/node-pg-copy-streams/pull/35.patch"},"body":"- Eliminate unwiring/rewiring of listeners.  Not possible to get right due to .on() for some and .once() for others.  Reattaching listeners in some node versions switches flowing mode and loses data.  Instead just fork stream and send it to pg-copy-stream and the existing pg.connection.stream.  Ending pg-copy-stream is just an unpipe() call\r\n- Upgade devDependency to pg v4.4.3\r\n- Change test references from pg.js to pg\r\n- Remove unneeded listener test due to change in strategy\r\n- Require Postgres 9.2 for Travis tests"},"comment":{"url":"https://api.github.com/repos/brianc/node-pg-copy-streams/issues/comments/216671319","html_url":"https://github.com/brianc/node-pg-copy-streams/pull/35#issuecomment-216671319","issue_url":"https://api.github.com/repos/brianc/node-pg-copy-streams/issues/35","id":216671319,"user":{"login":"cbaron","id":1652906,"avatar_url":"https://avatars.githubusercontent.com/u/1652906?v=3","gravatar_id":"","url":"https://api.github.com/users/cbaron","html_url":"https://github.com/cbaron","followers_url":"https://api.github.com/users/cbaron/followers","following_url":"https://api.github.com/users/cbaron/following{/other_user}","gists_url":"https://api.github.com/users/cbaron/gists{/gist_id}","starred_url":"https://api.github.com/users/cbaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbaron/subscriptions","organizations_url":"https://api.github.com/users/cbaron/orgs","repos_url":"https://api.github.com/users/cbaron/repos","events_url":"https://api.github.com/users/cbaron/events{/privacy}","received_events_url":"https://api.github.com/users/cbaron/received_events","type":"User","site_admin":false},"created_at":"2016-05-03T21:32:56Z","updated_at":"2016-05-03T21:32:56Z","body":"@brianc, Unfortunately, I believe there is still a lingering issue regarding this pull request.\r\n\r\nhttps://gist.github.com/cbaron/963311847387b96925cb628a62907c82\r\n\r\nRun this code, the last query will not occur until.\r\n\r\nIf you make a change so that only 9 copy-streams are made, all queries are run.  Can you confirm ?"}}