{"push_id":1419753665,"size":151,"distinct_size":4,"ref":"refs/heads/round6","head":"02d7bc18dac23d127dc9a531e63764f6d0d6a3fc","before":"c8fa5f52c6f4cc618a519e934d96cdb109fcd459","commits":[{"sha":"7537718460c7b964ffbbc0910b12eaff9cd8b7a8","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"tools: enforce function name matching in linter\n\nESLint has a `func-name-matching` rule that requires that function names\nmatch the variable or property to which they are being assigned.\n\nThe code base currently has 100% compliance with this rule.\n\nEnable the rule to keep it that way.\n\nPR-URL: https://github.com/nodejs/node/pull/9408\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Teddy Katz <teddy.katz@gmail.com>\nReviewed-By: Prince John Wesley <princejohnwesley@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/7537718460c7b964ffbbc0910b12eaff9cd8b7a8"},{"sha":"dc88d19380b9b05f6bee7d61d87398f08124c861","author":{"name":"Roman Reiss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@silverwind.io"},"message":"benchmark: add trailing newline for consistency\n\nPR-URL: https://github.com/nodejs/node/pull/9410\nFixes: https://github.com/nodejs/node/issues/9402\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Minwoo Jung <jmwsoft@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/dc88d19380b9b05f6bee7d61d87398f08124c861"},{"sha":"15b83b967a12115464af7461678cea709943f2f9","author":{"name":"Roman Reiss","email":"b4a5ea001e047040e8c9075b67a268293138da2c@silverwind.io"},"message":"tools: enable final newline in .editorconfig\n\nPR-URL: https://github.com/nodejs/node/pull/9410\nFixes: https://github.com/nodejs/node/issues/9402\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Minwoo Jung <jmwsoft@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/15b83b967a12115464af7461678cea709943f2f9"},{"sha":"1a55e9a5672ec654a6cfdd694c20b7067368f5e9","author":{"name":"Steven R. Loomis","email":"206678a99b6250080805d5f3efcc631c730f0ad3@us.ibm.com"},"message":"src: default --icu_case_mapping on as a v8 option\n\n* toLocaleUpperCase() and toLocaleLowerCase() do not function properly\nwithout this flag.\n* basic test case. The test case would fail if `--no_icu_case_mapping`\nwas set.\n\nFixes: https://github.com/nodejs/node/issues/9445\nPR-URL: https://github.com/nodejs/node/pull/9454\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/1a55e9a5672ec654a6cfdd694c20b7067368f5e9"},{"sha":"379097850d714494b3cfb92803d79d9999c983ef","author":{"name":"Kat Marchán","email":"2bcb50a2e73ae3cb4fb416c1b26bfe9599769850@sykosomatic.org"},"message":"deps: upgrade npm to 3.10.9\n\nPR-URL: https://github.com/nodejs/node/pull/9286\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/379097850d714494b3cfb92803d79d9999c983ef"},{"sha":"a02b13fe9bc13c59a2410c65ce13f7e68a36ccda","author":{"name":"cjihrig","email":"b0a62289a2635542c30e3402b36d8cbeb000fe3e@gmail.com"},"message":"buffer: coerce offset using Math.trunc()\n\nThis is a partial revert of\n14d1a8a631a58408f1e85365a5f2aaa047cc0a5f, which coerced the offset\nof Buffer#slice() using the | operator. This causes some edge\ncases to be handled incorrectly. This commit restores the old\nbehavior, but converts offsets to integers using Math.trunc().\nThis commit does not revert any tests, and adds an additional\nregression test.\n\nRefs: https://github.com/nodejs/node/issues/9096\nRefs: https://github.com/nodejs/node/pull/9101\nPR-URL: https://github.com/nodejs/node/pull/9341\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Brian White <mscdex@mscdex.net>\nReviewed-By: Trevor Norris <trev.norris@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/a02b13fe9bc13c59a2410c65ce13f7e68a36ccda"},{"sha":"9fa94237c87d4310c2c60077d4b3d58dbac95d13","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"test: move timer-dependent test to sequential\n\nTimer-dependent tests fail frequently on certain platforms in CI when\nrun in parallel with other tests, likely due to competition for\nresources. Move test-repl-timeout-throw to sequential to avoid this\nproblem. Also did some minor refactoring (var->const and more use of\nassert.strictEqual of looser assertions).\n\nPR-URL: https://github.com/nodejs/node/pull/9431\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Johan Bergstrom <bugs@bergstroem.nu>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/9fa94237c87d4310c2c60077d4b3d58dbac95d13"},{"sha":"981e10619a98dc7dd7a017ba4cbd0ad1fba752f6","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: update GOVERNANCE.md to use \"meeting chair\"\n\nThe governance documentation refers to a CTC meeting \"moderator\" but\nthat is a confusing term. \"Meeting chair\" seems more correctly\ndescriptive. Change instances of \"moderator\" to \"meeting chair\".\n\nRefs: https://github.com/nodejs/CTC/issues/23\nPR-URL: https://github.com/nodejs/node/pull/9432\nReviewed-By: Rod Vagg <rod@vagg.org>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Josh Gavant <josh.gavant@outlook.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/981e10619a98dc7dd7a017ba4cbd0ad1fba752f6"},{"sha":"f9504a549e6e82427f2d8204eb3c9152b5cc9eae","author":{"name":"Sakthipriyan Vairamani (thefourtheye)","email":"ba18b85e82922189d925c062dfd7133985d7a46c@gmail.com"},"message":"build: start comments at beginning of line\n\nAs the comments are indented in Makefile, they are actually echoed\non the screen. This patch makes sure that the comments actually start\nat the beginning of the line, and so not echoed and ignored.\n\nPR-URL: https://github.com/nodejs/node/pull/9375\n\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Prince John Wesley <princejohnwesley@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/f9504a549e6e82427f2d8204eb3c9152b5cc9eae"},{"sha":"5d0761f5f72980ab70f1fa95a82038c64846c659","author":{"name":"Sakthipriyan Vairamani (thefourtheye)","email":"ba18b85e82922189d925c062dfd7133985d7a46c@gmail.com"},"message":"doc: do not link in the headings\n\nIf there is a link in the headings, when the ToC is generated, that is\nnot properly linked and the square brackets are left as they are.\n\nEven if we fix this, different parts of the heading will link to\ndifferent sections or even different pages. For example,\n\n    ### What makes [`Buffer.allocUnsafe()`] and\n          [`Buffer.allocUnsafeSlow()`] \"unsafe\"?\n\nwill point to three different sections. `allocUnsafe` and\n`allocUnsafeSlow` will link to their corresponding sections and all\nother words actually link to the heading in the document. This could be\nvisually confusing.\n\nPR-URL: https://github.com/nodejs/node/pull/9416\nFixes: https://github.com/nodejs/node/issues/9331\n\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Minwoo Jung <jmwsoft@gmail.com>\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Brian White <mscdex@mscdex.net>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/5d0761f5f72980ab70f1fa95a82038c64846c659"},{"sha":"3e6cc607b0346e9428db9d72abe04c2aa7bfdb1e","author":{"name":"Gibson Fahnestock","email":"8e6e2648be098370abb61ac74fcbde6dcd9dbb62@uk.ibm.com"},"message":"doc: note that tests should include a description\n\nUpdate the Writing Tests guide to specify that tests should include a\nbrief description of what they are designed to test.\n\nPR-URL: https://github.com/nodejs/node/pull/9415\n\nReviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>oc","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/3e6cc607b0346e9428db9d72abe04c2aa7bfdb1e"},{"sha":"a99b441c2c102d84f7e1fb6d73c0cfa6b4dc0e58","author":{"name":"Gibson Fahnestock","email":"8e6e2648be098370abb61ac74fcbde6dcd9dbb62@uk.ibm.com"},"message":"test: update http-header-obstext\n\nPR-URL: https://github.com/nodejs/node/pull/9415\n\nReviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/a99b441c2c102d84f7e1fb6d73c0cfa6b4dc0e58"},{"sha":"7dd3fb872d21a64f44b602b2092a4c2328e2d819","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: update minute-taking procedure for CTC\n\nThe doc says that the CTC moderator is responsible for taking minutes.\n\nThis change updates the doc to say that the moderator is responsible for\nmaking sure that notes are taken, but not necessarily taking the notes\nthemselves.\n\nPR-URL: https://github.com/nodejs/node/pull/9425\nReviewed-By: Josh Gavant <josh.gavant@outlook.com>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/7dd3fb872d21a64f44b602b2092a4c2328e2d819"},{"sha":"686b334836d0bfb1a83b61ba0a674dcd72d58727","author":{"name":"Santiago Gimeno","email":"1ff54bfafcdd5f2b451c162cce52249507ed2a36@gmail.com"},"message":"test: fix flaky test-force-repl-with-eval\n\nRemove the timer just in case the test takes longer to complete.\n\nPR-URL: https://github.com/nodejs/node/pull/9460\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/686b334836d0bfb1a83b61ba0a674dcd72d58727"},{"sha":"f8f67d253eb80ae213f331a3d7c57171053867fd","author":{"name":"Santiago Gimeno","email":"1ff54bfafcdd5f2b451c162cce52249507ed2a36@gmail.com"},"message":"test: fix flaky test-net-GH-5504\n\nThe test is failing on `SmartOS` quite often. Removing the timeout seems\nto fix it.\n\nFixes: https://github.com/nodejs/node/issues/8930\nPR-URL: https://github.com/nodejs/node/pull/9461\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/f8f67d253eb80ae213f331a3d7c57171053867fd"},{"sha":"5079763ce7454da2f9147e814fc1b3668b644f94","author":{"name":"solebox","email":"bdf3826c51ea3c3f6d0c3a727c9a4d555c660545@gmail.com"},"message":"vm: name anonymous functions\n\nName anonymous arrow function in vm module to improve readability\n\nPR-URL: https://github.com/nodejs/node/pull/9388\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James Snell <jasnell@gmail.com>\nReviewed-By: Benjamin Gruenbaum <inglor@gmail.com>\nRef: #8913","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/5079763ce7454da2f9147e814fc1b3668b644f94"},{"sha":"4463d2b36003fd58a8e4c9a231f073e92e7d477e","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"benchmark,lib,test,tools: remove unneeded . escape\n\nThe `.` character does not need to be escaped when it appears inside a\nregular expression character class. This removes instances of\nunnecessary escapes of the `.` character.\n\nThis also removes a few unnecessary escapes of the `(` and `)`\ncharacters within character classes too.\n\nPR-URL: https://github.com/nodejs/node/pull/9449\nReviewed-By: Roman Reiss <me@silverwind.io>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Minwoo Jung <jmwsoft@gmail.com>\nReviewed-By: James Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/4463d2b36003fd58a8e4c9a231f073e92e7d477e"},{"sha":"bc229d08678908ff43340b60b53cac57a0fcd346","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"build: reduce noise from doc target\n\nThe doc target currently echos the complete shell command, which might\nproduces a lot of output. Using this change the actual commands run\nare still shown.\n\nBefore:\n[ -e tools/doc/node_modules/js-yaml/package.json ] || \\\n        [ -e tools/eslint/node_modules/js-yaml/package.json ] || \\\n        if [ -x ./node ]; then \\\n            cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js\ninstall; \\\n        else \\\n            cd tools/doc && node ../.././deps/npm/bin/npm-cli.js\ninstall; \\\n        fi\n[ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0\n--format=html --template=doc/template.html doc/api/assert.md >\nout/doc/api/assert.html || node tools/doc/generate.js\n--node-version=v8.0.0 --format=html --template=doc/template.html\ndoc/api/assert.md > out/doc/api/assert.html\nInput file = doc/api/assert.md\n\nAfter:\n[ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0\n--format=html --template=doc/template.html doc/api/assert.md >\nout/doc/api/assert.html || node tools/doc/generate.js\n--node-version=v8.0.0 --format=html --template=doc/template.html\ndoc/api/assert.md > out/doc/api/assert.html\nInput file = doc/api/assert.md\n\nTo verify run:\n$ make docclean\n$ make doc\n\nPR-URL: https://github.com/nodejs/node/pull/9457\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: James Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/bc229d08678908ff43340b60b53cac57a0fcd346"},{"sha":"1b889894ce9f900aef9110eaef48daabd95a9b44","author":{"name":"Santiago Gimeno","email":"1ff54bfafcdd5f2b451c162cce52249507ed2a36@gmail.com"},"message":"test: improve test-debugger-util-regression\n\nAvoid the `exit` command to be sent more than once. It prevents from\nundesired errors emitted on `proc.stdin`.\nRemove the watchdog timer so the test does not fail in case it takes\nlonger to complete.\n\nPR-URL: https://github.com/nodejs/node/pull/9490\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: James Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/1b889894ce9f900aef9110eaef48daabd95a9b44"},{"sha":"a5045167823e4c02a0d6343304a2832514e7a9a7","author":{"name":"Daniel Bevenius","email":"0483e8046c15b05e6d26859e234440186c783ac8@gmail.com"},"message":"build: add MAKEFLAGS=\"-j1\" to node-gyp\n\nCurrently, when building the addons the following warning is displayed:\nmake[2]: warning: jobserver unavailable: using -j1.  Add `+' to parent\nmake rule.\n\nAdding the MAKEFLAGS=\"-j1\" to avoid the warning.\n\nAlso updated the log message to say that it is building the addon and\nnot running the test as I think that is more accurate.\n\nPR-URL: https://github.com/nodejs/node/pull/9450\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":false,"url":"https://api.github.com/repos/jasnell/http2-1/commits/a5045167823e4c02a0d6343304a2832514e7a9a7"}]}
{"actor":{"display_login":"jasnell"}}