{"action":"created","comment":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/76448589","id":76448589,"diff_hunk":"@@ -599,7 +602,580 @@ public void queryInfoObjectFromOptmizedParsedTree(QueryInfo qInfo,\n     }\n \n   }\n-  \n+\n+  /**\n+   * Tests if the where clause containing multiple fields with primary keys and extra\n+   * conditions\n+   */\n+  public void testUpdatePutConvertibleExtraAnds() throws Exception {\n+    Connection conn = getConnection();\n+    Statement s = conn.createStatement();\n+    s.execute(\"create table src_tab (col1 varchar(10), col2 int , \" +\n+        \"col3 int, col4 int, PRIMARY KEY (col1, col2)) partition by column (col1)\");\n+    String query = \"update src_tab set col3=? where col2=? and col1=? and col3=?\";\n+    GemFireXDQueryObserver old = null;","path":"gemfirexd/tools/src/test/java/com/pivotal/gemfirexd/internal/engine/distributed/metadata/UpdateQueryInfoInternalsTest.java","position":26,"original_position":26,"commit_id":"263237b9134ec45defbc8d9ec499498e3fad47b6","original_commit_id":"263237b9134ec45defbc8d9ec499498e3fad47b6","user":{"login":"soubhik-c","id":11516481,"avatar_url":"https://avatars.githubusercontent.com/u/11516481?v=3","gravatar_id":"","url":"https://api.github.com/users/soubhik-c","html_url":"https://github.com/soubhik-c","followers_url":"https://api.github.com/users/soubhik-c/followers","following_url":"https://api.github.com/users/soubhik-c/following{/other_user}","gists_url":"https://api.github.com/users/soubhik-c/gists{/gist_id}","starred_url":"https://api.github.com/users/soubhik-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soubhik-c/subscriptions","organizations_url":"https://api.github.com/users/soubhik-c/orgs","repos_url":"https://api.github.com/users/soubhik-c/repos","events_url":"https://api.github.com/users/soubhik-c/events{/privacy}","received_events_url":"https://api.github.com/users/soubhik-c/received_events","type":"User","site_admin":false},"body":"lets try to update some other column than in the predicate. pick multiple column update along with 'where timestamp < CURRENT_TIME' kind of additional where clause.","created_at":"2016-08-26T16:36:17Z","updated_at":"2016-08-26T16:36:17Z","html_url":"https://github.com/SnappyDataInc/snappy-store/pull/95#discussion_r76448589","pull_request_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments/76448589"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/95#discussion_r76448589"},"pull_request":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95","id":79731657,"html_url":"https://github.com/SnappyDataInc/snappy-store/pull/95","diff_url":"https://github.com/SnappyDataInc/snappy-store/pull/95.diff","patch_url":"https://github.com/SnappyDataInc/snappy-store/pull/95.patch","issue_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/95","number":95,"state":"open","locked":false,"title":"Snap 891","user":{"login":"rishitesh","id":793775,"avatar_url":"https://avatars.githubusercontent.com/u/793775?v=3","gravatar_id":"","url":"https://api.github.com/users/rishitesh","html_url":"https://github.com/rishitesh","followers_url":"https://api.github.com/users/rishitesh/followers","following_url":"https://api.github.com/users/rishitesh/following{/other_user}","gists_url":"https://api.github.com/users/rishitesh/gists{/gist_id}","starred_url":"https://api.github.com/users/rishitesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rishitesh/subscriptions","organizations_url":"https://api.github.com/users/rishitesh/orgs","repos_url":"https://api.github.com/users/rishitesh/repos","events_url":"https://api.github.com/users/rishitesh/events{/privacy}","received_events_url":"https://api.github.com/users/rishitesh/received_events","type":"User","site_admin":false},"body":"## Changes proposed in this pull request\r\n\r\nThis PR deals with a change which will take care of updates with extra where conditions apart from primary keys. This will ensure that the where clause is still before updating, without using transactions. \r\ne.g. update table set col1 = s1 where pk = 1 and not_pk = 2;\r\nIf we don't use transactions there is no guarantee that not_pk = 2 will hold true , if two different threads work on the same Primary key. \r\n\r\nAt first cut I have only taken care of AND conditions. Others needed ?\r\n\r\n## Patch testing\r\nThis is a very 1st cut of PR to gather early feedback about approach and to identify any pitfalls. Will be adding more tests and performance tests.\r\n\r\n## ReleaseNotes changes\r\nNA\r\n\r\n## Other PRs \r\nNA\r\n","created_at":"2016-08-02T13:06:58Z","updated_at":"2016-08-26T16:36:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4c07089b0e6b8db8efe2249b45f02123f63e847","assignee":{"login":"soubhik-c","id":11516481,"avatar_url":"https://avatars.githubusercontent.com/u/11516481?v=3","gravatar_id":"","url":"https://api.github.com/users/soubhik-c","html_url":"https://github.com/soubhik-c","followers_url":"https://api.github.com/users/soubhik-c/followers","following_url":"https://api.github.com/users/soubhik-c/following{/other_user}","gists_url":"https://api.github.com/users/soubhik-c/gists{/gist_id}","starred_url":"https://api.github.com/users/soubhik-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soubhik-c/subscriptions","organizations_url":"https://api.github.com/users/soubhik-c/orgs","repos_url":"https://api.github.com/users/soubhik-c/repos","events_url":"https://api.github.com/users/soubhik-c/events{/privacy}","received_events_url":"https://api.github.com/users/soubhik-c/received_events","type":"User","site_admin":false},"assignees":[{"login":"soubhik-c","id":11516481,"avatar_url":"https://avatars.githubusercontent.com/u/11516481?v=3","gravatar_id":"","url":"https://api.github.com/users/soubhik-c","html_url":"https://github.com/soubhik-c","followers_url":"https://api.github.com/users/soubhik-c/followers","following_url":"https://api.github.com/users/soubhik-c/following{/other_user}","gists_url":"https://api.github.com/users/soubhik-c/gists{/gist_id}","starred_url":"https://api.github.com/users/soubhik-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soubhik-c/subscriptions","organizations_url":"https://api.github.com/users/soubhik-c/orgs","repos_url":"https://api.github.com/users/soubhik-c/repos","events_url":"https://api.github.com/users/soubhik-c/events{/privacy}","received_events_url":"https://api.github.com/users/soubhik-c/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95/commits","review_comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95/comments","review_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/95/comments","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/263237b9134ec45defbc8d9ec499498e3fad47b6","head":{"label":"SnappyDataInc:SNAP-891","ref":"SNAP-891","sha":"263237b9134ec45defbc8d9ec499498e3fad47b6","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2016-07-24T12:24:19Z","pushed_at":"2016-08-26T15:27:56Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":116723,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":15,"forks":4,"open_issues":15,"watchers":26,"default_branch":"snappy/master"}},"base":{"label":"SnappyDataInc:snappy/master","ref":"snappy/master","sha":"3122fa9e200aa38cd8d35f2f4f2e45d58439da7f","user":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"repo":{"id":48800286,"name":"snappy-store","full_name":"SnappyDataInc/snappy-store","owner":{"login":"SnappyDataInc","id":11342682,"avatar_url":"https://avatars.githubusercontent.com/u/11342682?v=3","gravatar_id":"","url":"https://api.github.com/users/SnappyDataInc","html_url":"https://github.com/SnappyDataInc","followers_url":"https://api.github.com/users/SnappyDataInc/followers","following_url":"https://api.github.com/users/SnappyDataInc/following{/other_user}","gists_url":"https://api.github.com/users/SnappyDataInc/gists{/gist_id}","starred_url":"https://api.github.com/users/SnappyDataInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SnappyDataInc/subscriptions","organizations_url":"https://api.github.com/users/SnappyDataInc/orgs","repos_url":"https://api.github.com/users/SnappyDataInc/repos","events_url":"https://api.github.com/users/SnappyDataInc/events{/privacy}","received_events_url":"https://api.github.com/users/SnappyDataInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SnappyDataInc/snappy-store","description":"SnappyStore","fork":true,"url":"https://api.github.com/repos/SnappyDataInc/snappy-store","forks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/forks","keys_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/teams","hooks_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/hooks","issue_events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/events{/number}","events_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/events","assignees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/assignees{/user}","branches_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/branches{/branch}","tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/tags","blobs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/languages","stargazers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/stargazers","contributors_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contributors","subscribers_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscribers","subscription_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/subscription","commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/contents/{+path}","compare_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/merges","archive_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/downloads","issues_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues{/number}","pulls_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/labels{/name}","releases_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/releases{/id}","deployments_url":"https://api.github.com/repos/SnappyDataInc/snappy-store/deployments","created_at":"2015-12-30T12:44:56Z","updated_at":"2016-07-24T12:24:19Z","pushed_at":"2016-08-26T15:27:56Z","git_url":"git://github.com/SnappyDataInc/snappy-store.git","ssh_url":"git@github.com:SnappyDataInc/snappy-store.git","clone_url":"https://github.com/SnappyDataInc/snappy-store.git","svn_url":"https://github.com/SnappyDataInc/snappy-store","homepage":"","size":116723,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":15,"forks":4,"open_issues":15,"watchers":26,"default_branch":"snappy/master"}},"_links":{"self":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95"},"html":{"href":"https://github.com/SnappyDataInc/snappy-store/pull/95"},"issue":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/95"},"comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/SnappyDataInc/snappy-store/statuses/263237b9134ec45defbc8d9ec499498e3fad47b6"}}}}
{"actor":{"display_login":"soubhik-c"}}