{"push_id":1072645636,"size":1,"distinct_size":1,"ref":"refs/heads/branch-1.6","head":"cd812143d350fd059e5d9db5d6065fdf6b0c88a7","before":"58dfba66ee9b87cdbce6bc2b01324025c7514669","commits":[{"sha":"cd812143d350fd059e5d9db5d6065fdf6b0c88a7","author":{"email":"fd726277649d3b2e3ee5d332dca6c89739b68aa5@gmail.com","name":"CodingCat"},"message":"[SPARK-13227] Risky apply() in OpenHashMap\n\nhttps://issues.apache.org/jira/browse/SPARK-13227\n\nIt might confuse the future developers when they use OpenHashMap.apply() with a numeric value type.\n\nnull.asInstance[Int], null.asInstance[Long], null.asInstace[Float] and null.asInstance[Double] will return 0/0.0/0L, which might confuse the developer if the value set contains 0/0.0/0L with an existing key\n\nThe current patch only adds the comments describing the issue, with the respect to apply the minimum changes to the code base\n\nThe more direct, yet more aggressive, approach is use Option as the return type\n\nandrewor14  JoshRosen  any thoughts about how to avoid the potential issue?\n\nAuthor: CodingCat <zhunansjtu@gmail.com>\n\nCloses #11107 from CodingCat/SPARK-13227.\n\n(cherry picked from commit 4b3d1294aeecc0001a7fa48c92796e6075d34540)\nSigned-off-by: Reynold Xin <rxin@databricks.com>","distinct":true,"url":"https://api.github.com/repos/ueshin/apache-spark/commits/cd812143d350fd059e5d9db5d6065fdf6b0c88a7"}]}