{"action":"created","comment":{"url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments/71994354","id":71994354,"diff_hunk":"@@ -766,11 +775,48 @@ class BtcUtils\n       return (8 + viLen + scrLen);\n    }\n \n+   static uint32_t TxWitnessCalcLength(uint8_t const * ptr)","path":"cppForSwig/BtcUtils.h","position":36,"original_position":36,"commit_id":"aaa2ba663209737910fa12e481874bbbbd699c2f","original_commit_id":"5edf9ecd72bf859e8c735fdbfcc00f9f26f8844d","user":{"login":"goatpig","id":5758209,"avatar_url":"https://avatars.githubusercontent.com/u/5758209?v=3","gravatar_id":"","url":"https://api.github.com/users/goatpig","html_url":"https://github.com/goatpig","followers_url":"https://api.github.com/users/goatpig/followers","following_url":"https://api.github.com/users/goatpig/following{/other_user}","gists_url":"https://api.github.com/users/goatpig/gists{/gist_id}","starred_url":"https://api.github.com/users/goatpig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatpig/subscriptions","organizations_url":"https://api.github.com/users/goatpig/orgs","repos_url":"https://api.github.com/users/goatpig/repos","events_url":"https://api.github.com/users/goatpig/events{/privacy}","received_events_url":"https://api.github.com/users/goatpig/received_events","type":"User","site_admin":false},"body":"will deprectae calclength methods without size arg, make sure to avoid those as you progress forward","created_at":"2016-07-24T19:58:44Z","updated_at":"2016-07-24T19:58:44Z","html_url":"https://github.com/goatpig/BitcoinArmory/pull/47#discussion_r71994354","pull_request_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments/71994354"},"html":{"href":"https://github.com/goatpig/BitcoinArmory/pull/47#discussion_r71994354"},"pull_request":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47","id":78560085,"html_url":"https://github.com/goatpig/BitcoinArmory/pull/47","diff_url":"https://github.com/goatpig/BitcoinArmory/pull/47.diff","patch_url":"https://github.com/goatpig/BitcoinArmory/pull/47.patch","issue_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/47","number":47,"state":"open","locked":false,"title":"Segwit Compatibility","user":{"login":"achow101","id":3782274,"avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=3","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"body":"This PR should be everything that is needed in order to be compatible with segwit. This means that Armory will still be able to work with the changes to block and transaction formats. However it does not actually use segwit yet; that is the next step.\r\n\r\nThis PR also merges #22 for the regtest mode. This was done in order to test the segwit compatibility in an isolated environment where I could control everything.","created_at":"2016-07-23T02:00:17Z","updated_at":"2016-07-24T19:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"36364e35d6972f73ca1075857ac6d915ee1e3253","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47/commits","review_comments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47/comments","review_comment_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/47/comments","statuses_url":"https://api.github.com/repos/goatpig/BitcoinArmory/statuses/aaa2ba663209737910fa12e481874bbbbd699c2f","head":{"label":"achow101:segwit-dev-rebase","ref":"segwit-dev-rebase","sha":"aaa2ba663209737910fa12e481874bbbbd699c2f","user":{"login":"achow101","id":3782274,"avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=3","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"repo":{"id":51033419,"name":"BitcoinArmory","full_name":"achow101/BitcoinArmory","owner":{"login":"achow101","id":3782274,"avatar_url":"https://avatars.githubusercontent.com/u/3782274?v=3","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achow101/BitcoinArmory","description":"Python-Based Bitcoin Software","fork":true,"url":"https://api.github.com/repos/achow101/BitcoinArmory","forks_url":"https://api.github.com/repos/achow101/BitcoinArmory/forks","keys_url":"https://api.github.com/repos/achow101/BitcoinArmory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achow101/BitcoinArmory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achow101/BitcoinArmory/teams","hooks_url":"https://api.github.com/repos/achow101/BitcoinArmory/hooks","issue_events_url":"https://api.github.com/repos/achow101/BitcoinArmory/issues/events{/number}","events_url":"https://api.github.com/repos/achow101/BitcoinArmory/events","assignees_url":"https://api.github.com/repos/achow101/BitcoinArmory/assignees{/user}","branches_url":"https://api.github.com/repos/achow101/BitcoinArmory/branches{/branch}","tags_url":"https://api.github.com/repos/achow101/BitcoinArmory/tags","blobs_url":"https://api.github.com/repos/achow101/BitcoinArmory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achow101/BitcoinArmory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achow101/BitcoinArmory/git/refs{/sha}","trees_url":"https://api.github.com/repos/achow101/BitcoinArmory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achow101/BitcoinArmory/statuses/{sha}","languages_url":"https://api.github.com/repos/achow101/BitcoinArmory/languages","stargazers_url":"https://api.github.com/repos/achow101/BitcoinArmory/stargazers","contributors_url":"https://api.github.com/repos/achow101/BitcoinArmory/contributors","subscribers_url":"https://api.github.com/repos/achow101/BitcoinArmory/subscribers","subscription_url":"https://api.github.com/repos/achow101/BitcoinArmory/subscription","commits_url":"https://api.github.com/repos/achow101/BitcoinArmory/commits{/sha}","git_commits_url":"https://api.github.com/repos/achow101/BitcoinArmory/git/commits{/sha}","comments_url":"https://api.github.com/repos/achow101/BitcoinArmory/comments{/number}","issue_comment_url":"https://api.github.com/repos/achow101/BitcoinArmory/issues/comments{/number}","contents_url":"https://api.github.com/repos/achow101/BitcoinArmory/contents/{+path}","compare_url":"https://api.github.com/repos/achow101/BitcoinArmory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achow101/BitcoinArmory/merges","archive_url":"https://api.github.com/repos/achow101/BitcoinArmory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achow101/BitcoinArmory/downloads","issues_url":"https://api.github.com/repos/achow101/BitcoinArmory/issues{/number}","pulls_url":"https://api.github.com/repos/achow101/BitcoinArmory/pulls{/number}","milestones_url":"https://api.github.com/repos/achow101/BitcoinArmory/milestones{/number}","notifications_url":"https://api.github.com/repos/achow101/BitcoinArmory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achow101/BitcoinArmory/labels{/name}","releases_url":"https://api.github.com/repos/achow101/BitcoinArmory/releases{/id}","deployments_url":"https://api.github.com/repos/achow101/BitcoinArmory/deployments","created_at":"2016-02-03T21:54:41Z","updated_at":"2016-02-03T21:54:44Z","pushed_at":"2016-07-24T19:36:27Z","git_url":"git://github.com/achow101/BitcoinArmory.git","ssh_url":"git@github.com:achow101/BitcoinArmory.git","clone_url":"https://github.com/achow101/BitcoinArmory.git","svn_url":"https://github.com/achow101/BitcoinArmory","homepage":"","size":99250,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"goatpig:dev","ref":"dev","sha":"bf2f0ef7d05a018f8dc7875cbf3abb75d3fd8f66","user":{"login":"goatpig","id":5758209,"avatar_url":"https://avatars.githubusercontent.com/u/5758209?v=3","gravatar_id":"","url":"https://api.github.com/users/goatpig","html_url":"https://github.com/goatpig","followers_url":"https://api.github.com/users/goatpig/followers","following_url":"https://api.github.com/users/goatpig/following{/other_user}","gists_url":"https://api.github.com/users/goatpig/gists{/gist_id}","starred_url":"https://api.github.com/users/goatpig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatpig/subscriptions","organizations_url":"https://api.github.com/users/goatpig/orgs","repos_url":"https://api.github.com/users/goatpig/repos","events_url":"https://api.github.com/users/goatpig/events{/privacy}","received_events_url":"https://api.github.com/users/goatpig/received_events","type":"User","site_admin":false},"repo":{"id":13808777,"name":"BitcoinArmory","full_name":"goatpig/BitcoinArmory","owner":{"login":"goatpig","id":5758209,"avatar_url":"https://avatars.githubusercontent.com/u/5758209?v=3","gravatar_id":"","url":"https://api.github.com/users/goatpig","html_url":"https://github.com/goatpig","followers_url":"https://api.github.com/users/goatpig/followers","following_url":"https://api.github.com/users/goatpig/following{/other_user}","gists_url":"https://api.github.com/users/goatpig/gists{/gist_id}","starred_url":"https://api.github.com/users/goatpig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatpig/subscriptions","organizations_url":"https://api.github.com/users/goatpig/orgs","repos_url":"https://api.github.com/users/goatpig/repos","events_url":"https://api.github.com/users/goatpig/events{/privacy}","received_events_url":"https://api.github.com/users/goatpig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goatpig/BitcoinArmory","description":"Python-Based Bitcoin Software","fork":true,"url":"https://api.github.com/repos/goatpig/BitcoinArmory","forks_url":"https://api.github.com/repos/goatpig/BitcoinArmory/forks","keys_url":"https://api.github.com/repos/goatpig/BitcoinArmory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goatpig/BitcoinArmory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goatpig/BitcoinArmory/teams","hooks_url":"https://api.github.com/repos/goatpig/BitcoinArmory/hooks","issue_events_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/events{/number}","events_url":"https://api.github.com/repos/goatpig/BitcoinArmory/events","assignees_url":"https://api.github.com/repos/goatpig/BitcoinArmory/assignees{/user}","branches_url":"https://api.github.com/repos/goatpig/BitcoinArmory/branches{/branch}","tags_url":"https://api.github.com/repos/goatpig/BitcoinArmory/tags","blobs_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/refs{/sha}","trees_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goatpig/BitcoinArmory/statuses/{sha}","languages_url":"https://api.github.com/repos/goatpig/BitcoinArmory/languages","stargazers_url":"https://api.github.com/repos/goatpig/BitcoinArmory/stargazers","contributors_url":"https://api.github.com/repos/goatpig/BitcoinArmory/contributors","subscribers_url":"https://api.github.com/repos/goatpig/BitcoinArmory/subscribers","subscription_url":"https://api.github.com/repos/goatpig/BitcoinArmory/subscription","commits_url":"https://api.github.com/repos/goatpig/BitcoinArmory/commits{/sha}","git_commits_url":"https://api.github.com/repos/goatpig/BitcoinArmory/git/commits{/sha}","comments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/comments{/number}","issue_comment_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/comments{/number}","contents_url":"https://api.github.com/repos/goatpig/BitcoinArmory/contents/{+path}","compare_url":"https://api.github.com/repos/goatpig/BitcoinArmory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goatpig/BitcoinArmory/merges","archive_url":"https://api.github.com/repos/goatpig/BitcoinArmory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goatpig/BitcoinArmory/downloads","issues_url":"https://api.github.com/repos/goatpig/BitcoinArmory/issues{/number}","pulls_url":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls{/number}","milestones_url":"https://api.github.com/repos/goatpig/BitcoinArmory/milestones{/number}","notifications_url":"https://api.github.com/repos/goatpig/BitcoinArmory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goatpig/BitcoinArmory/labels{/name}","releases_url":"https://api.github.com/repos/goatpig/BitcoinArmory/releases{/id}","deployments_url":"https://api.github.com/repos/goatpig/BitcoinArmory/deployments","created_at":"2013-10-23T16:52:19Z","updated_at":"2016-07-21T22:34:30Z","pushed_at":"2016-07-24T19:36:28Z","git_url":"git://github.com/goatpig/BitcoinArmory.git","ssh_url":"git@github.com:goatpig/BitcoinArmory.git","clone_url":"https://github.com/goatpig/BitcoinArmory.git","svn_url":"https://github.com/goatpig/BitcoinArmory","homepage":"","size":98080,"stargazers_count":38,"watchers_count":38,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":14,"forks":6,"open_issues":14,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47"},"html":{"href":"https://github.com/goatpig/BitcoinArmory/pull/47"},"issue":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/47"},"comments":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/goatpig/BitcoinArmory/statuses/aaa2ba663209737910fa12e481874bbbbd699c2f"}}}}
{"actor":{"display_login":"goatpig"}}