{"action":"created","issue":{"url":"https://api.github.com/repos/pi-hole/AdminLTE/issues/191","repository_url":"https://api.github.com/repos/pi-hole/AdminLTE","labels_url":"https://api.github.com/repos/pi-hole/AdminLTE/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/pi-hole/AdminLTE/issues/191/comments","events_url":"https://api.github.com/repos/pi-hole/AdminLTE/issues/191/events","html_url":"https://github.com/pi-hole/AdminLTE/pull/191","id":188269485,"number":191,"title":"Increase temporal resolution in main diagram from 1h to 10min","user":{"login":"DL6ER","id":16748619,"avatar_url":"https://avatars.githubusercontent.com/u/16748619?v=3","gravatar_id":"","url":"https://api.github.com/users/DL6ER","html_url":"https://github.com/DL6ER","followers_url":"https://api.github.com/users/DL6ER/followers","following_url":"https://api.github.com/users/DL6ER/following{/other_user}","gists_url":"https://api.github.com/users/DL6ER/gists{/gist_id}","starred_url":"https://api.github.com/users/DL6ER/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DL6ER/subscriptions","organizations_url":"https://api.github.com/users/DL6ER/orgs","repos_url":"https://api.github.com/users/DL6ER/repos","events_url":"https://api.github.com/users/DL6ER/events{/privacy}","received_events_url":"https://api.github.com/users/DL6ER/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-09T15:06:34Z","updated_at":"2016-11-16T22:14:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pi-hole/AdminLTE/pulls/191","html_url":"https://github.com/pi-hole/AdminLTE/pull/191","diff_url":"https://github.com/pi-hole/AdminLTE/pull/191.diff","patch_url":"https://github.com/pi-hole/AdminLTE/pull/191.patch"},"body":"Changes proposed in this pull request:\r\n\r\n- Increase temporal resolution in main diagram from 1h to 10min.\r\n\r\nBefore:\r\n![screenshot at 2016-11-09 15-19-08](https://cloud.githubusercontent.com/assets/16748619/20141413/878137e6-a690-11e6-99a6-e956ea67e13d.png)\r\n\r\nProposed:\r\n![screenshot at 2016-11-09 15-53-58](https://cloud.githubusercontent.com/assets/16748619/20142419/edf41e40-a694-11e6-8305-2086d52aeec7.png)\r\n\r\n\r\nI added a new API call in order to keep backwards-compatibility. There is no speed/memory drawback as the functions are very similar, the only difference being in the way they put intervals on the acquired data.\r\n\r\nNumerical confirmation that everything works as it should:\r\n\r\napi.php?overTimeData\r\n\r\n> {\"domains_over_time\":[\"854\",\"854\",\"828\",\"862\",\"834\",\"852\",\"840\",\"854\",\"831\",\"843\",\"857\",\"970\",\"1399\",\"1732\",\"1033\",\"391\"],\"ads_over_time\":[\"2\",\"0\",\"1\",\"0\",\"3\",\"0\",\"1\",\"0\",\"1\",\"0\",\"2\",\"15\",\"82\",\"194\",\"46\",\"9\"]}\r\n\r\napi.php?overTimeData10mins\r\n\r\n> {\"domains_over_time\":[\"144\",\"142\",\"146\",\"141\",\"135\",\"146\",\"140\",\"140\",\"143\",\"134\",\"154\",\"143\",\"141\",\"141\",\"134\",\"137\",\"139\",\"136\",\"140\",\"146\",\"138\",\"141\",\"151\",\"146\",\"147\",\"141\",\"134\",\"143\",\"137\",\"132\",\"136\",\"144\",\"137\",\"143\",\"149\",\"143\",\"142\",\"136\",\"135\",\"146\",\"144\",\"137\",\"134\",\"142\",\"139\",\"143\",\"153\",\"143\",\"140\",\"137\",\"143\",\"138\",\"132\",\"141\",\"136\",\"140\",\"135\",\"137\",\"154\",\"141\",\"140\",\"141\",\"138\",\"161\",\"145\",\"132\",\"138\",\"144\",\"137\",\"140\",\"177\",\"234\",\"226\",\"258\",\"312\",\"218\",\"167\",\"218\",\"185\",\"145\",\"175\",\"703\",\"366\",\"158\",\"150\",\"197\",\"189\",\"136\",\"168\",\"193\",\"155\",\"200\",\"168\",\"160\",\"104\"],\"ads_over_time\":[\"0\",\"1\",\"0\",\"1\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"1\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"1\",\"1\",\"0\",\"1\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"1\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"1\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"1\",\"1\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"0\",\"15\",\"17\",\"22\",\"22\",\"12\",\"1\",\"8\",\"7\",\"5\",\"9\",\"95\",\"71\",\"7\",\"4\",\"15\",\"10\",\"0\",\"6\",\"11\",\"1\",\"8\",\"10\",\"5\",\"4\"]}\r\n\r\nLet me verify correctness for some of the data shown above\r\n\r\n- 00:00 - 00:59\r\n1 h resolution: 854\r\n10min resolution: 144+142+146+141+135+146 = 854\r\n\r\n- 02:00 - 02:59\r\n1 h resolution: 828\r\n10min resolution: 141+141+134+137+139+136 = 828\r\n\r\n- 08:00 - 08:59\r\n1 h resolution: 831\r\n10min resolution: 140+137+143+138+132+141 = 831\r\n\r\n- 13:00 - 13:59\r\n1 h resolution: 1732\r\n10min resolution: 185+145+175+703+366+158 = 1732\r\n\r\n\r\n@pi-hole/dashboard\r\n"},"comment":{"url":"https://api.github.com/repos/pi-hole/AdminLTE/issues/comments/261089476","html_url":"https://github.com/pi-hole/AdminLTE/pull/191#issuecomment-261089476","issue_url":"https://api.github.com/repos/pi-hole/AdminLTE/issues/191","id":261089476,"user":{"login":"PromoFaux","id":1998970,"avatar_url":"https://avatars.githubusercontent.com/u/1998970?v=3","gravatar_id":"","url":"https://api.github.com/users/PromoFaux","html_url":"https://github.com/PromoFaux","followers_url":"https://api.github.com/users/PromoFaux/followers","following_url":"https://api.github.com/users/PromoFaux/following{/other_user}","gists_url":"https://api.github.com/users/PromoFaux/gists{/gist_id}","starred_url":"https://api.github.com/users/PromoFaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromoFaux/subscriptions","organizations_url":"https://api.github.com/users/PromoFaux/orgs","repos_url":"https://api.github.com/users/PromoFaux/repos","events_url":"https://api.github.com/users/PromoFaux/events{/privacy}","received_events_url":"https://api.github.com/users/PromoFaux/received_events","type":"User","site_admin":false},"created_at":"2016-11-16T22:14:07Z","updated_at":"2016-11-16T22:14:07Z","body":"Approved*"}}
{"actor":{"display_login":"PromoFaux"}}