{"action":"created","issue":{"url":"https://api.github.com/repos/10up/ElasticPress/issues/372","labels_url":"https://api.github.com/repos/10up/ElasticPress/issues/372/labels{/name}","comments_url":"https://api.github.com/repos/10up/ElasticPress/issues/372/comments","events_url":"https://api.github.com/repos/10up/ElasticPress/issues/372/events","html_url":"https://github.com/10up/ElasticPress/pull/372","id":109601989,"number":372,"title":"Add support for orderby => meta_value and meta_value_num","user":{"login":"sc0ttkclark","id":709662,"avatar_url":"https://avatars.githubusercontent.com/u/709662?v=3","gravatar_id":"","url":"https://api.github.com/users/sc0ttkclark","html_url":"https://github.com/sc0ttkclark","followers_url":"https://api.github.com/users/sc0ttkclark/followers","following_url":"https://api.github.com/users/sc0ttkclark/following{/other_user}","gists_url":"https://api.github.com/users/sc0ttkclark/gists{/gist_id}","starred_url":"https://api.github.com/users/sc0ttkclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sc0ttkclark/subscriptions","organizations_url":"https://api.github.com/users/sc0ttkclark/orgs","repos_url":"https://api.github.com/users/sc0ttkclark/repos","events_url":"https://api.github.com/users/sc0ttkclark/events{/privacy}","received_events_url":"https://api.github.com/users/sc0ttkclark/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dkotter","id":916738,"avatar_url":"https://avatars.githubusercontent.com/u/916738?v=3","gravatar_id":"","url":"https://api.github.com/users/dkotter","html_url":"https://github.com/dkotter","followers_url":"https://api.github.com/users/dkotter/followers","following_url":"https://api.github.com/users/dkotter/following{/other_user}","gists_url":"https://api.github.com/users/dkotter/gists{/gist_id}","starred_url":"https://api.github.com/users/dkotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkotter/subscriptions","organizations_url":"https://api.github.com/users/dkotter/orgs","repos_url":"https://api.github.com/users/dkotter/repos","events_url":"https://api.github.com/users/dkotter/events{/privacy}","received_events_url":"https://api.github.com/users/dkotter/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/10up/ElasticPress/milestones/19","html_url":"https://github.com/10up/ElasticPress/milestones/1.9","labels_url":"https://api.github.com/repos/10up/ElasticPress/milestones/19/labels","id":1435813,"number":19,"title":"1.9","description":"User friendly dashboard","creator":{"login":"tlovett1","id":1844351,"avatar_url":"https://avatars.githubusercontent.com/u/1844351?v=3","gravatar_id":"","url":"https://api.github.com/users/tlovett1","html_url":"https://github.com/tlovett1","followers_url":"https://api.github.com/users/tlovett1/followers","following_url":"https://api.github.com/users/tlovett1/following{/other_user}","gists_url":"https://api.github.com/users/tlovett1/gists{/gist_id}","starred_url":"https://api.github.com/users/tlovett1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlovett1/subscriptions","organizations_url":"https://api.github.com/users/tlovett1/orgs","repos_url":"https://api.github.com/users/tlovett1/repos","events_url":"https://api.github.com/users/tlovett1/events{/privacy}","received_events_url":"https://api.github.com/users/tlovett1/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":10,"state":"open","created_at":"2015-11-30T18:40:43Z","updated_at":"2016-02-01T03:32:33Z","due_on":"2016-03-31T04:00:00Z","closed_at":null},"comments":14,"created_at":"2015-10-03T04:46:58Z","updated_at":"2016-02-02T00:05:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/10up/ElasticPress/pulls/372","html_url":"https://github.com/10up/ElasticPress/pull/372","diff_url":"https://github.com/10up/ElasticPress/pull/372.diff","patch_url":"https://github.com/10up/ElasticPress/pull/372.patch"},"body":"Fixes #329\r\n\r\nSomething to note, in order to sort by meta_value_num, a sort _script has to kick off. It seems to run okay in terms of speed, but we should note about it's performance in the readme, just as MySQL CAST().\r\n\r\n- [x] Unit tests (meta_value / meta_value_num / asc+desc variations)\r\n- [x] README.md documentation update\r\n- [ ] Update `@since` if needed"},"comment":{"url":"https://api.github.com/repos/10up/ElasticPress/issues/comments/178267205","html_url":"https://github.com/10up/ElasticPress/pull/372#issuecomment-178267205","issue_url":"https://api.github.com/repos/10up/ElasticPress/issues/372","id":178267205,"user":{"login":"sc0ttkclark","id":709662,"avatar_url":"https://avatars.githubusercontent.com/u/709662?v=3","gravatar_id":"","url":"https://api.github.com/users/sc0ttkclark","html_url":"https://github.com/sc0ttkclark","followers_url":"https://api.github.com/users/sc0ttkclark/followers","following_url":"https://api.github.com/users/sc0ttkclark/following{/other_user}","gists_url":"https://api.github.com/users/sc0ttkclark/gists{/gist_id}","starred_url":"https://api.github.com/users/sc0ttkclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sc0ttkclark/subscriptions","organizations_url":"https://api.github.com/users/sc0ttkclark/orgs","repos_url":"https://api.github.com/users/sc0ttkclark/repos","events_url":"https://api.github.com/users/sc0ttkclark/events{/privacy}","received_events_url":"https://api.github.com/users/sc0ttkclark/received_events","type":"User","site_admin":false},"created_at":"2016-02-02T00:05:44Z","updated_at":"2016-02-02T00:05:44Z","body":"Oh I see what you mean, yeah it's sorting on that meta_key but EP doesn't care that there's no value -- it's not restricting results to only those with that value.\r\n\r\nSounds like there's a little more work to be done here then. I'll look at that next."}}