{"action":"created","issue":{"url":"https://api.github.com/repos/zeroc-ice/ice/issues/13","repository_url":"https://api.github.com/repos/zeroc-ice/ice","labels_url":"https://api.github.com/repos/zeroc-ice/ice/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/zeroc-ice/ice/issues/13/comments","events_url":"https://api.github.com/repos/zeroc-ice/ice/issues/13/events","html_url":"https://github.com/zeroc-ice/ice/pull/13","id":184724826,"number":13,"title":"fix building with libressl","user":{"login":"Dessa","id":110693,"avatar_url":"https://avatars.githubusercontent.com/u/110693?v=3","gravatar_id":"","url":"https://api.github.com/users/Dessa","html_url":"https://github.com/Dessa","followers_url":"https://api.github.com/users/Dessa/followers","following_url":"https://api.github.com/users/Dessa/following{/other_user}","gists_url":"https://api.github.com/users/Dessa/gists{/gist_id}","starred_url":"https://api.github.com/users/Dessa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dessa/subscriptions","organizations_url":"https://api.github.com/users/Dessa/orgs","repos_url":"https://api.github.com/users/Dessa/repos","events_url":"https://api.github.com/users/Dessa/events{/privacy}","received_events_url":"https://api.github.com/users/Dessa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-23T23:47:31Z","updated_at":"2016-10-27T15:11:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zeroc-ice/ice/pulls/13","html_url":"https://github.com/zeroc-ice/ice/pull/13","diff_url":"https://github.com/zeroc-ice/ice/pull/13.diff","patch_url":"https://github.com/zeroc-ice/ice/pull/13.patch"},"body":"libressl sets its OPENSSL_VERSION_NUMBER to 0x20000000L, fix the conditional to not match in these cases"},"comment":{"url":"https://api.github.com/repos/zeroc-ice/ice/issues/comments/256670079","html_url":"https://github.com/zeroc-ice/ice/pull/13#issuecomment-256670079","issue_url":"https://api.github.com/repos/zeroc-ice/ice/issues/13","id":256670079,"user":{"login":"externl","id":2126835,"avatar_url":"https://avatars.githubusercontent.com/u/2126835?v=3","gravatar_id":"","url":"https://api.github.com/users/externl","html_url":"https://github.com/externl","followers_url":"https://api.github.com/users/externl/followers","following_url":"https://api.github.com/users/externl/following{/other_user}","gists_url":"https://api.github.com/users/externl/gists{/gist_id}","starred_url":"https://api.github.com/users/externl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/externl/subscriptions","organizations_url":"https://api.github.com/users/externl/orgs","repos_url":"https://api.github.com/users/externl/repos","events_url":"https://api.github.com/users/externl/events{/privacy}","received_events_url":"https://api.github.com/users/externl/received_events","type":"User","site_admin":false},"created_at":"2016-10-27T15:11:19Z","updated_at":"2016-10-27T15:11:19Z","body":"Thanks for the PR @Dessa!\r\n\r\nI noticed a few issues which should be addressed before we can merge.\r\n\r\nThere are several `OPENSSL_VERSION_NUMBER` checks which are missing a corresponding `LIBRESSL_VERSION_NUMBER` check.\r\n\r\n```\r\nsrc/IceSSL/OpenSSLEngine.cpp:#if OPENSSL_VERSION_NUMBER < 0x10100000L\r\nsrc/IceSSL/OpenSSLEngine.cpp:#if OPENSSL_VERSION_NUMBER < 0x10100000L\r\nsrc/IceSSL/OpenSSLEngine.cpp:#if OPENSSL_VERSION_NUMBER < 0x10100000L\r\nsrc/IceSSL/OpenSSLEngine.cpp:#if OPENSSL_VERSION_NUMBER < 0x10100000L\r\nsrc/IceSSL/OpenSSLEngine.cpp:#if OPENSSL_VERSION_NUMBER < 0x10100000L\r\nsrc/IceSSL/OpenSSLTransceiverI.cpp:#if defined(OPENSSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER < 0x100000bfL\r\nsrc/IceSSL/OpenSSLTransceiverI.cpp:#if defined(OPENSSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER < 0x100000bfL\r\nsrc/IceSSL/OpenSSLTransceiverI.cpp:#if defined(OPENSSL_VERSION_NUMBER) && OPENSSL_VERSION_NUMBER < 0x100000bfL\r\nsrc/IceSSL/Util.cpp:#    if OPENSSL_VERSION_NUMBER < 0x10100000L\r\nsrc/IceSSL/Util.cpp:#    if OPENSSL_VERSION_NUMBER >= 0x10100000L\r\nsrc/IceSSL/Util.cpp:#    if OPENSSL_VERSION_NUMBER >= 0x10100000L\r\n```"}}
{"actor":{"display_login":"externl"}}