{"action":"created","issue":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2249","repository_url":"https://api.github.com/repos/fish-shell/fish-shell","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2249/labels{/name}","comments_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2249/comments","events_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2249/events","html_url":"https://github.com/fish-shell/fish-shell/issues/2249","id":97661236,"number":2249,"title":"Pager search shouldn’t trigger when an entry is already selected","user":{"login":"Grimy","id":3199732,"avatar_url":"https://avatars.githubusercontent.com/u/3199732?v=3","gravatar_id":"","url":"https://api.github.com/users/Grimy","html_url":"https://github.com/Grimy","followers_url":"https://api.github.com/users/Grimy/followers","following_url":"https://api.github.com/users/Grimy/following{/other_user}","gists_url":"https://api.github.com/users/Grimy/gists{/gist_id}","starred_url":"https://api.github.com/users/Grimy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Grimy/subscriptions","organizations_url":"https://api.github.com/users/Grimy/orgs","repos_url":"https://api.github.com/users/Grimy/repos","events_url":"https://api.github.com/users/Grimy/events{/privacy}","received_events_url":"https://api.github.com/users/Grimy/received_events","type":"User","site_admin":false},"labels":[{"id":4724778,"url":"https://api.github.com/repos/fish-shell/fish-shell/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/13","html_url":"https://github.com/fish-shell/fish-shell/milestones/fish%202.5.0","labels_url":"https://api.github.com/repos/fish-shell/fish-shell/milestones/13/labels","id":1624432,"number":13,"title":"fish 2.5.0","description":"next release in the 2.x series (minor releases)\r\nin general, no backward incompatible changes should be accepted for this release","creator":{"login":"zanchey","id":520741,"avatar_url":"https://avatars.githubusercontent.com/u/520741?v=3","gravatar_id":"","url":"https://api.github.com/users/zanchey","html_url":"https://github.com/zanchey","followers_url":"https://api.github.com/users/zanchey/followers","following_url":"https://api.github.com/users/zanchey/following{/other_user}","gists_url":"https://api.github.com/users/zanchey/gists{/gist_id}","starred_url":"https://api.github.com/users/zanchey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zanchey/subscriptions","organizations_url":"https://api.github.com/users/zanchey/orgs","repos_url":"https://api.github.com/users/zanchey/repos","events_url":"https://api.github.com/users/zanchey/events{/privacy}","received_events_url":"https://api.github.com/users/zanchey/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":15,"state":"open","created_at":"2016-03-06T13:32:50Z","updated_at":"2016-11-09T14:38:05Z","due_on":"2017-01-08T00:00:00Z","closed_at":null},"comments":9,"created_at":"2015-07-28T09:52:16Z","updated_at":"2016-11-10T16:40:06Z","closed_at":null,"body":"Up to db0506c1df540639d330a33a9a8c86b0748a593c, fish had nice completion behavior. You could type the beginning of an argument, tab until the correct completion is selected, and then immediately start typing the next argument.\n\nNowadays, fish’s behavior is quite different. Once you have selected the desired completion, typing _anything_ (even a space!) will enter the dreaded “search” mode, an unbelievably jarring mode that makes reverse-history-search look user-friendly in comparison. You then have to backspace, tab shift-tab to reselect the current completion and hit enter before you can start typing the next argument. That’s six wasted keypresses.\n\nAs soon as there are at least two completion possibilities, the search mode will jump at you to steal your time, focus and peace of mind. There seems to be only two ways to avoid it:\n- After selecting the correct completion, hit Enter. For some unfathomable reason, in this context, hitting Enter doesn’t actually run the command or insert a carriage return or anything, like it _always_ does in every shell I’ve ever used. It just clears the list of possible completions and lets you keep typing in relative sanity. Due to the considerable counter-intuitiveness, I’d rather avoid this option.\n- Hit backspace, then space. This actually makes sense, but wastes two keypresses.\n\nNow, I can understand how the search mode could possibly be useful to some people in some situations, so I’m not asking for it to be removed altogether. However, if you really want to search, it stands to reason that you would do so _before_ selecting the desired completion. Therefore, it would be nice if the search mode wasn’t triggered when the user already selected a completion with tab/shift-tab.\n\nAlternatively, I’d be happy with a configuration option that lets me completely disable the search mode. However, I believe such an option would go against fish’s philosophy.\n"},"comment":{"url":"https://api.github.com/repos/fish-shell/fish-shell/issues/comments/259740181","html_url":"https://github.com/fish-shell/fish-shell/issues/2249#issuecomment-259740181","issue_url":"https://api.github.com/repos/fish-shell/fish-shell/issues/2249","id":259740181,"user":{"login":"netmute","id":574582,"avatar_url":"https://avatars.githubusercontent.com/u/574582?v=3","gravatar_id":"","url":"https://api.github.com/users/netmute","html_url":"https://github.com/netmute","followers_url":"https://api.github.com/users/netmute/followers","following_url":"https://api.github.com/users/netmute/following{/other_user}","gists_url":"https://api.github.com/users/netmute/gists{/gist_id}","starred_url":"https://api.github.com/users/netmute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netmute/subscriptions","organizations_url":"https://api.github.com/users/netmute/orgs","repos_url":"https://api.github.com/users/netmute/repos","events_url":"https://api.github.com/users/netmute/events{/privacy}","received_events_url":"https://api.github.com/users/netmute/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T16:40:06Z","updated_at":"2016-11-10T16:40:06Z","body":"I run into this pretty much every time I use the autocomplete pager.\r\n\r\nI type something, hit tab to select the option I want, then continue typing the command. At this point I'm confused for a few seconds, realize I'm in some kind of search mode, spend a few seconds to figure out how to exit it, and then remember I have to hit Return to accept the autocomplete selection.\r\n\r\nI have to double check every time that hitting Return is safe in this case, because I'm afraid it will accidentally execute the unfinished command, possibly deleting the wrong file or do other unintended things.\r\n\r\nPersonally, I wouldn't mind losing this feature. But not automatically activating search mode when I type would solve this issue for me as well. Every keypress, except the arrow keys and tab, should accept the selection.\r\n\r\nFish is my everyday shell, and this is one of very few minor annoyances. I'm grateful for all the love and hard work you put into this, and I'm sure this will be resolved soon :)"}}
{"actor":{"display_login":"netmute"}}