{"push_id":966155149,"size":2,"distinct_size":1,"ref":"refs/heads/gmalmquist/clean-and-improve-shading","head":"719db7fda0d82ef255652798f414fe5bceeaed1b","before":"127060cde950fcbd71550cc8aa02bddc00dbdaf2","commits":[{"sha":"37fdcb7d35b8673223ae77a5747c678b8e4c13d5","author":{"email":"5496d4fd32b46dcb22e495b96a73063ce8ea956b@gmail.com","name":"Garrett Malmquist"},"message":"Retain file permissions when shading monolithic jars.\n\nOn some systems (macos at least), the atomic_copy function at the\nend of the jar shading process would cause the file permissions to\nbe set to '-rw-------', instead of the normal '-rw-r--r--', because\nof the permissions of the temporary file that atomic_copy creates.\n\nThis change simply records the permissions of the jar before\nshading, and chmod's the shaded jar to have whatever permissions it\nhad previously.\n\nTesting Done:\nAdded an integration test to `test_shader_integration.py`.\n\nCI went green here: https://travis-ci.org/pantsbuild/pants/builds/107310100\n\nBugs closed: 2885\n\nReviewed at https://rbcommons.com/s/twitter/r/3420/","distinct":false,"url":"https://api.github.com/repos/gmalmquist/pants/commits/37fdcb7d35b8673223ae77a5747c678b8e4c13d5"},{"sha":"719db7fda0d82ef255652798f414fe5bceeaed1b","author":{"email":"de99e07effbff7db9225ec5b93e59cadc57850c4@squareup.com","name":"Garrett Malmquist"},"message":"Cleaning up jarjar rules, and adding support for keep and zap.\n\nThe shading subsystem had some extraneous indirection, which used\nto be necessary but now very much isn't.\n\nI also added support for defining `keep` and `zap` rules, which we\nnow have some use-cases for internally.","distinct":true,"url":"https://api.github.com/repos/gmalmquist/pants/commits/719db7fda0d82ef255652798f414fe5bceeaed1b"}]}