{"action":"created","comment":{"url":"https://api.github.com/repos/SasView/sasview/pulls/comments/93777973","pull_request_review_id":14313753,"id":93777973,"diff_hunk":"@@ -348,13 +350,146 @@ def clone(self):\n         obj.npts = copy.deepcopy(self.npts)\r\n         obj.cb1 = copy.deepcopy(self.cb1)\r\n         obj.smearer = copy.deepcopy(self.smearer)\r\n+        obj.version = copy.deepcopy(self.version)\r\n \r\n         for name, state in self.saved_states.iteritems():\r\n             copy_name = copy.deepcopy(name)\r\n             copy_state = state.clone()\r\n             obj.saved_states[copy_name] = copy_state\r\n         return obj\r\n \r\n+    def _old_first_model(self):\r\n+        \"\"\"\r\n+        Handle save states from 4.0.1 and before where the first item in the\r\n+        selection boxes of category, formfactor and structurefactor were not\r\n+        saved.\r\n+        :return: None\r\n+        \"\"\"\r\n+        if self.formfactorcombobox == '':\r\n+            if self.categorycombobox == '' and len(self.parameters) == 3:\r\n+                self.categorycombobox = \"Shape-Independent\"\r\n+                self.formfactorcombobox = 'PowerLawAbsModel'\r\n+            elif self.categorycombobox == '' and len(self.parameters) == 9:\r\n+                self.categorycombobox = 'Cylinder'\r\n+                self.formfactorcombobox = 'barbell'\r\n+            elif self.categorycombobox == 'Shapes':\r\n+                self.formfactorcombobox = 'BCCrystalModel'\r\n+            elif self.categorycombobox == 'Uncategorized':\r\n+                self.formfactorcombobox = 'LineModel'\r\n+            elif self.categorycombobox == 'StructureFactor':\r\n+                self.structurecombobox = 'HardsphereStructure'\r\n+            elif self.categorycombobox == 'Customized Models':\r\n+                self.formfactorcombobox = 'MySumFunction'\r\n+            elif self.categorycombobox == 'Ellipsoid':\r\n+                self.formfactorcombobox = 'core_shell_ellipsoid'\r\n+            elif self.categorycombobox == 'Lamellae':\r\n+                self.formfactorcombobox = 'lamellar'\r\n+            elif self.categorycombobox == 'Paracrystal':\r\n+                self.formfactorcombobox = 'bcc_paracrystal'\r\n+            elif self.categorycombobox == 'Parallelepiped':\r\n+                self.formfactorcombobox = 'core_shell_parallelepiped'\r\n+            elif self.categorycombobox == 'Shape Independent':\r\n+                self.formfactorcombobox = 'be_polyelectrolyte'\r\n+            elif self.categorycombobox == 'Sphere':\r\n+                self.formfactorcombobox = 'adsorbed_layer'\r\n+            elif self.categorycombobox == 'Structure Factor':\r\n+                self.formfactorcombobox = 'hardsphere'\r\n+\r\n+    @staticmethod\r","path":"src/sas/sasgui/perspectives/fitting/pagestate.py","position":65,"original_position":65,"commit_id":"12361fdbc5e39477eb96b1b8744cf20d36a4f405","original_commit_id":"fa487d9329c2380588a8be342822ff1667d3323c","user":{"login":"krzywon","id":10947925,"avatar_url":"https://avatars.githubusercontent.com/u/10947925?v=3","gravatar_id":"","url":"https://api.github.com/users/krzywon","html_url":"https://github.com/krzywon","followers_url":"https://api.github.com/users/krzywon/followers","following_url":"https://api.github.com/users/krzywon/following{/other_user}","gists_url":"https://api.github.com/users/krzywon/gists{/gist_id}","starred_url":"https://api.github.com/users/krzywon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzywon/subscriptions","organizations_url":"https://api.github.com/users/krzywon/orgs","repos_url":"https://api.github.com/users/krzywon/repos","events_url":"https://api.github.com/users/krzywon/events{/privacy}","received_events_url":"https://api.github.com/users/krzywon/received_events","type":"User","site_admin":false},"body":"I'm not sure how to get rid of this character. It doesn't show up in any of my editors and completely removing and adding the line again puts it back.","created_at":"2016-12-23T15:41:33Z","updated_at":"2016-12-23T15:41:33Z","html_url":"https://github.com/SasView/sasview/pull/22#discussion_r93777973","pull_request_url":"https://api.github.com/repos/SasView/sasview/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/SasView/sasview/pulls/comments/93777973"},"html":{"href":"https://github.com/SasView/sasview/pull/22#discussion_r93777973"},"pull_request":{"href":"https://api.github.com/repos/SasView/sasview/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/SasView/sasview/pulls/22","id":97365173,"html_url":"https://github.com/SasView/sasview/pull/22","diff_url":"https://github.com/SasView/sasview/pull/22.diff","patch_url":"https://github.com/SasView/sasview/pull/22.patch","issue_url":"https://api.github.com/repos/SasView/sasview/issues/22","number":22,"state":"open","locked":false,"title":"Ticket 795","user":{"login":"krzywon","id":10947925,"avatar_url":"https://avatars.githubusercontent.com/u/10947925?v=3","gravatar_id":"","url":"https://api.github.com/users/krzywon","html_url":"https://github.com/krzywon","followers_url":"https://api.github.com/users/krzywon/followers","following_url":"https://api.github.com/users/krzywon/following{/other_user}","gists_url":"https://api.github.com/users/krzywon/gists{/gist_id}","starred_url":"https://api.github.com/users/krzywon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzywon/subscriptions","organizations_url":"https://api.github.com/users/krzywon/orgs","repos_url":"https://api.github.com/users/krzywon/repos","events_url":"https://api.github.com/users/krzywon/events{/privacy}","received_events_url":"https://api.github.com/users/krzywon/received_events","type":"User","site_admin":false},"body":"The save file converter is complete and ready for testing by others. This is dependent on sasmodels branch ticket-795.","created_at":"2016-12-09T19:22:59Z","updated_at":"2016-12-23T15:41:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be753483ddb1e633120b4fffda3cdc9e6196f145","assignee":{"login":"pkienzle","id":473456,"avatar_url":"https://avatars.githubusercontent.com/u/473456?v=3","gravatar_id":"","url":"https://api.github.com/users/pkienzle","html_url":"https://github.com/pkienzle","followers_url":"https://api.github.com/users/pkienzle/followers","following_url":"https://api.github.com/users/pkienzle/following{/other_user}","gists_url":"https://api.github.com/users/pkienzle/gists{/gist_id}","starred_url":"https://api.github.com/users/pkienzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkienzle/subscriptions","organizations_url":"https://api.github.com/users/pkienzle/orgs","repos_url":"https://api.github.com/users/pkienzle/repos","events_url":"https://api.github.com/users/pkienzle/events{/privacy}","received_events_url":"https://api.github.com/users/pkienzle/received_events","type":"User","site_admin":false},"assignees":[{"login":"pkienzle","id":473456,"avatar_url":"https://avatars.githubusercontent.com/u/473456?v=3","gravatar_id":"","url":"https://api.github.com/users/pkienzle","html_url":"https://github.com/pkienzle","followers_url":"https://api.github.com/users/pkienzle/followers","following_url":"https://api.github.com/users/pkienzle/following{/other_user}","gists_url":"https://api.github.com/users/pkienzle/gists{/gist_id}","starred_url":"https://api.github.com/users/pkienzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkienzle/subscriptions","organizations_url":"https://api.github.com/users/pkienzle/orgs","repos_url":"https://api.github.com/users/pkienzle/repos","events_url":"https://api.github.com/users/pkienzle/events{/privacy}","received_events_url":"https://api.github.com/users/pkienzle/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SasView/sasview/pulls/22/commits","review_comments_url":"https://api.github.com/repos/SasView/sasview/pulls/22/comments","review_comment_url":"https://api.github.com/repos/SasView/sasview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SasView/sasview/issues/22/comments","statuses_url":"https://api.github.com/repos/SasView/sasview/statuses/12361fdbc5e39477eb96b1b8744cf20d36a4f405","head":{"label":"SasView:ticket-795","ref":"ticket-795","sha":"12361fdbc5e39477eb96b1b8744cf20d36a4f405","user":{"login":"SasView","id":10882470,"avatar_url":"https://avatars.githubusercontent.com/u/10882470?v=3","gravatar_id":"","url":"https://api.github.com/users/SasView","html_url":"https://github.com/SasView","followers_url":"https://api.github.com/users/SasView/followers","following_url":"https://api.github.com/users/SasView/following{/other_user}","gists_url":"https://api.github.com/users/SasView/gists{/gist_id}","starred_url":"https://api.github.com/users/SasView/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SasView/subscriptions","organizations_url":"https://api.github.com/users/SasView/orgs","repos_url":"https://api.github.com/users/SasView/repos","events_url":"https://api.github.com/users/SasView/events{/privacy}","received_events_url":"https://api.github.com/users/SasView/received_events","type":"Organization","site_admin":false},"repo":{"id":30505546,"name":"sasview","full_name":"SasView/sasview","owner":{"login":"SasView","id":10882470,"avatar_url":"https://avatars.githubusercontent.com/u/10882470?v=3","gravatar_id":"","url":"https://api.github.com/users/SasView","html_url":"https://github.com/SasView","followers_url":"https://api.github.com/users/SasView/followers","following_url":"https://api.github.com/users/SasView/following{/other_user}","gists_url":"https://api.github.com/users/SasView/gists{/gist_id}","starred_url":"https://api.github.com/users/SasView/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SasView/subscriptions","organizations_url":"https://api.github.com/users/SasView/orgs","repos_url":"https://api.github.com/users/SasView/repos","events_url":"https://api.github.com/users/SasView/events{/privacy}","received_events_url":"https://api.github.com/users/SasView/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SasView/sasview","description":"Code for the SasView application. Builds can be found here: https://jenkins.esss.dk/sasview/","fork":false,"url":"https://api.github.com/repos/SasView/sasview","forks_url":"https://api.github.com/repos/SasView/sasview/forks","keys_url":"https://api.github.com/repos/SasView/sasview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SasView/sasview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SasView/sasview/teams","hooks_url":"https://api.github.com/repos/SasView/sasview/hooks","issue_events_url":"https://api.github.com/repos/SasView/sasview/issues/events{/number}","events_url":"https://api.github.com/repos/SasView/sasview/events","assignees_url":"https://api.github.com/repos/SasView/sasview/assignees{/user}","branches_url":"https://api.github.com/repos/SasView/sasview/branches{/branch}","tags_url":"https://api.github.com/repos/SasView/sasview/tags","blobs_url":"https://api.github.com/repos/SasView/sasview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SasView/sasview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SasView/sasview/git/refs{/sha}","trees_url":"https://api.github.com/repos/SasView/sasview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SasView/sasview/statuses/{sha}","languages_url":"https://api.github.com/repos/SasView/sasview/languages","stargazers_url":"https://api.github.com/repos/SasView/sasview/stargazers","contributors_url":"https://api.github.com/repos/SasView/sasview/contributors","subscribers_url":"https://api.github.com/repos/SasView/sasview/subscribers","subscription_url":"https://api.github.com/repos/SasView/sasview/subscription","commits_url":"https://api.github.com/repos/SasView/sasview/commits{/sha}","git_commits_url":"https://api.github.com/repos/SasView/sasview/git/commits{/sha}","comments_url":"https://api.github.com/repos/SasView/sasview/comments{/number}","issue_comment_url":"https://api.github.com/repos/SasView/sasview/issues/comments{/number}","contents_url":"https://api.github.com/repos/SasView/sasview/contents/{+path}","compare_url":"https://api.github.com/repos/SasView/sasview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SasView/sasview/merges","archive_url":"https://api.github.com/repos/SasView/sasview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SasView/sasview/downloads","issues_url":"https://api.github.com/repos/SasView/sasview/issues{/number}","pulls_url":"https://api.github.com/repos/SasView/sasview/pulls{/number}","milestones_url":"https://api.github.com/repos/SasView/sasview/milestones{/number}","notifications_url":"https://api.github.com/repos/SasView/sasview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SasView/sasview/labels{/name}","releases_url":"https://api.github.com/repos/SasView/sasview/releases{/id}","deployments_url":"https://api.github.com/repos/SasView/sasview/deployments","created_at":"2015-02-08T20:59:10Z","updated_at":"2016-10-22T03:34:39Z","pushed_at":"2016-12-23T15:38:48Z","git_url":"git://github.com/SasView/sasview.git","ssh_url":"git@github.com:SasView/sasview.git","clone_url":"https://github.com/SasView/sasview.git","svn_url":"https://github.com/SasView/sasview","homepage":"","size":125761,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":8,"default_branch":"master"}},"base":{"label":"SasView:master","ref":"master","sha":"bb3eb744d36cf7da91a525ce66ffaeba2a6849a7","user":{"login":"SasView","id":10882470,"avatar_url":"https://avatars.githubusercontent.com/u/10882470?v=3","gravatar_id":"","url":"https://api.github.com/users/SasView","html_url":"https://github.com/SasView","followers_url":"https://api.github.com/users/SasView/followers","following_url":"https://api.github.com/users/SasView/following{/other_user}","gists_url":"https://api.github.com/users/SasView/gists{/gist_id}","starred_url":"https://api.github.com/users/SasView/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SasView/subscriptions","organizations_url":"https://api.github.com/users/SasView/orgs","repos_url":"https://api.github.com/users/SasView/repos","events_url":"https://api.github.com/users/SasView/events{/privacy}","received_events_url":"https://api.github.com/users/SasView/received_events","type":"Organization","site_admin":false},"repo":{"id":30505546,"name":"sasview","full_name":"SasView/sasview","owner":{"login":"SasView","id":10882470,"avatar_url":"https://avatars.githubusercontent.com/u/10882470?v=3","gravatar_id":"","url":"https://api.github.com/users/SasView","html_url":"https://github.com/SasView","followers_url":"https://api.github.com/users/SasView/followers","following_url":"https://api.github.com/users/SasView/following{/other_user}","gists_url":"https://api.github.com/users/SasView/gists{/gist_id}","starred_url":"https://api.github.com/users/SasView/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SasView/subscriptions","organizations_url":"https://api.github.com/users/SasView/orgs","repos_url":"https://api.github.com/users/SasView/repos","events_url":"https://api.github.com/users/SasView/events{/privacy}","received_events_url":"https://api.github.com/users/SasView/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SasView/sasview","description":"Code for the SasView application. Builds can be found here: https://jenkins.esss.dk/sasview/","fork":false,"url":"https://api.github.com/repos/SasView/sasview","forks_url":"https://api.github.com/repos/SasView/sasview/forks","keys_url":"https://api.github.com/repos/SasView/sasview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SasView/sasview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SasView/sasview/teams","hooks_url":"https://api.github.com/repos/SasView/sasview/hooks","issue_events_url":"https://api.github.com/repos/SasView/sasview/issues/events{/number}","events_url":"https://api.github.com/repos/SasView/sasview/events","assignees_url":"https://api.github.com/repos/SasView/sasview/assignees{/user}","branches_url":"https://api.github.com/repos/SasView/sasview/branches{/branch}","tags_url":"https://api.github.com/repos/SasView/sasview/tags","blobs_url":"https://api.github.com/repos/SasView/sasview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SasView/sasview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SasView/sasview/git/refs{/sha}","trees_url":"https://api.github.com/repos/SasView/sasview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SasView/sasview/statuses/{sha}","languages_url":"https://api.github.com/repos/SasView/sasview/languages","stargazers_url":"https://api.github.com/repos/SasView/sasview/stargazers","contributors_url":"https://api.github.com/repos/SasView/sasview/contributors","subscribers_url":"https://api.github.com/repos/SasView/sasview/subscribers","subscription_url":"https://api.github.com/repos/SasView/sasview/subscription","commits_url":"https://api.github.com/repos/SasView/sasview/commits{/sha}","git_commits_url":"https://api.github.com/repos/SasView/sasview/git/commits{/sha}","comments_url":"https://api.github.com/repos/SasView/sasview/comments{/number}","issue_comment_url":"https://api.github.com/repos/SasView/sasview/issues/comments{/number}","contents_url":"https://api.github.com/repos/SasView/sasview/contents/{+path}","compare_url":"https://api.github.com/repos/SasView/sasview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SasView/sasview/merges","archive_url":"https://api.github.com/repos/SasView/sasview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SasView/sasview/downloads","issues_url":"https://api.github.com/repos/SasView/sasview/issues{/number}","pulls_url":"https://api.github.com/repos/SasView/sasview/pulls{/number}","milestones_url":"https://api.github.com/repos/SasView/sasview/milestones{/number}","notifications_url":"https://api.github.com/repos/SasView/sasview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SasView/sasview/labels{/name}","releases_url":"https://api.github.com/repos/SasView/sasview/releases{/id}","deployments_url":"https://api.github.com/repos/SasView/sasview/deployments","created_at":"2015-02-08T20:59:10Z","updated_at":"2016-10-22T03:34:39Z","pushed_at":"2016-12-23T15:38:48Z","git_url":"git://github.com/SasView/sasview.git","ssh_url":"git@github.com:SasView/sasview.git","clone_url":"https://github.com/SasView/sasview.git","svn_url":"https://github.com/SasView/sasview","homepage":"","size":125761,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SasView/sasview/pulls/22"},"html":{"href":"https://github.com/SasView/sasview/pull/22"},"issue":{"href":"https://api.github.com/repos/SasView/sasview/issues/22"},"comments":{"href":"https://api.github.com/repos/SasView/sasview/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/SasView/sasview/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/SasView/sasview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SasView/sasview/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/SasView/sasview/statuses/12361fdbc5e39477eb96b1b8744cf20d36a4f405"}}}}
{"actor":{"display_login":"krzywon"}}