{"action":"opened","number":76,"pull_request":{"url":"https://api.github.com/repos/simplesamlphp/saml2/pulls/76","id":84296216,"html_url":"https://github.com/simplesamlphp/saml2/pull/76","diff_url":"https://github.com/simplesamlphp/saml2/pull/76.diff","patch_url":"https://github.com/simplesamlphp/saml2/pull/76.patch","issue_url":"https://api.github.com/repos/simplesamlphp/saml2/issues/76","number":76,"state":"open","locked":false,"title":"Handle EPTI attribute parsing correctly","user":{"login":"DRvanR","id":1422284,"avatar_url":"https://avatars.githubusercontent.com/u/1422284?v=3","gravatar_id":"","url":"https://api.github.com/users/DRvanR","html_url":"https://github.com/DRvanR","followers_url":"https://api.github.com/users/DRvanR/followers","following_url":"https://api.github.com/users/DRvanR/following{/other_user}","gists_url":"https://api.github.com/users/DRvanR/gists{/gist_id}","starred_url":"https://api.github.com/users/DRvanR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DRvanR/subscriptions","organizations_url":"https://api.github.com/users/DRvanR/orgs","repos_url":"https://api.github.com/users/DRvanR/repos","events_url":"https://api.github.com/users/DRvanR/events{/privacy}","received_events_url":"https://api.github.com/users/DRvanR/received_events","type":"User","site_admin":false},"body":"As an eduPersonTargetedID is [specified as always containing a NameID][1], we can detect and handle that case by treating the attribute values as NameID. This also resolves the issue of an EPTI attribute not being serializeable, as reported [here][2] and discussed in #60.\r\n\r\nDo note that this is a BC break and therefor should result in the release of a new major, albeit it arguably can be treated as a bugfix. It the latter case it could be released in the 2.x range.\r\n\r\n[1]: http://software.internet2.edu/eduperson/internet2-mace-dir-eduperson-201310.html#eduPersonTargetedID\r\n[2]: https://groups.google.com/forum/#!msg/simplesamlphp/Zn9KFqflUjU/6yhjPPOeBQAJ","created_at":"2016-09-07T13:04:58Z","updated_at":"2016-09-07T13:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/simplesamlphp/saml2/pulls/76/commits","review_comments_url":"https://api.github.com/repos/simplesamlphp/saml2/pulls/76/comments","review_comment_url":"https://api.github.com/repos/simplesamlphp/saml2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simplesamlphp/saml2/issues/76/comments","statuses_url":"https://api.github.com/repos/simplesamlphp/saml2/statuses/09e41571b53e209c3a96b3f213efdc2da6239d12","head":{"label":"SURFnet:feature/correct-epti-attribute-parsing","ref":"feature/correct-epti-attribute-parsing","sha":"09e41571b53e209c3a96b3f213efdc2da6239d12","user":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"repo":{"id":23867560,"name":"saml2","full_name":"SURFnet/saml2","owner":{"login":"SURFnet","id":1485353,"avatar_url":"https://avatars.githubusercontent.com/u/1485353?v=3","gravatar_id":"","url":"https://api.github.com/users/SURFnet","html_url":"https://github.com/SURFnet","followers_url":"https://api.github.com/users/SURFnet/followers","following_url":"https://api.github.com/users/SURFnet/following{/other_user}","gists_url":"https://api.github.com/users/SURFnet/gists{/gist_id}","starred_url":"https://api.github.com/users/SURFnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SURFnet/subscriptions","organizations_url":"https://api.github.com/users/SURFnet/orgs","repos_url":"https://api.github.com/users/SURFnet/repos","events_url":"https://api.github.com/users/SURFnet/events{/privacy}","received_events_url":"https://api.github.com/users/SURFnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SURFnet/saml2","description":"SimpleSAMLphp low-level SAML2 PHP library","fork":true,"url":"https://api.github.com/repos/SURFnet/saml2","forks_url":"https://api.github.com/repos/SURFnet/saml2/forks","keys_url":"https://api.github.com/repos/SURFnet/saml2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SURFnet/saml2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SURFnet/saml2/teams","hooks_url":"https://api.github.com/repos/SURFnet/saml2/hooks","issue_events_url":"https://api.github.com/repos/SURFnet/saml2/issues/events{/number}","events_url":"https://api.github.com/repos/SURFnet/saml2/events","assignees_url":"https://api.github.com/repos/SURFnet/saml2/assignees{/user}","branches_url":"https://api.github.com/repos/SURFnet/saml2/branches{/branch}","tags_url":"https://api.github.com/repos/SURFnet/saml2/tags","blobs_url":"https://api.github.com/repos/SURFnet/saml2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SURFnet/saml2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SURFnet/saml2/git/refs{/sha}","trees_url":"https://api.github.com/repos/SURFnet/saml2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SURFnet/saml2/statuses/{sha}","languages_url":"https://api.github.com/repos/SURFnet/saml2/languages","stargazers_url":"https://api.github.com/repos/SURFnet/saml2/stargazers","contributors_url":"https://api.github.com/repos/SURFnet/saml2/contributors","subscribers_url":"https://api.github.com/repos/SURFnet/saml2/subscribers","subscription_url":"https://api.github.com/repos/SURFnet/saml2/subscription","commits_url":"https://api.github.com/repos/SURFnet/saml2/commits{/sha}","git_commits_url":"https://api.github.com/repos/SURFnet/saml2/git/commits{/sha}","comments_url":"https://api.github.com/repos/SURFnet/saml2/comments{/number}","issue_comment_url":"https://api.github.com/repos/SURFnet/saml2/issues/comments{/number}","contents_url":"https://api.github.com/repos/SURFnet/saml2/contents/{+path}","compare_url":"https://api.github.com/repos/SURFnet/saml2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SURFnet/saml2/merges","archive_url":"https://api.github.com/repos/SURFnet/saml2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SURFnet/saml2/downloads","issues_url":"https://api.github.com/repos/SURFnet/saml2/issues{/number}","pulls_url":"https://api.github.com/repos/SURFnet/saml2/pulls{/number}","milestones_url":"https://api.github.com/repos/SURFnet/saml2/milestones{/number}","notifications_url":"https://api.github.com/repos/SURFnet/saml2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SURFnet/saml2/labels{/name}","releases_url":"https://api.github.com/repos/SURFnet/saml2/releases{/id}","deployments_url":"https://api.github.com/repos/SURFnet/saml2/deployments","created_at":"2014-09-10T08:53:48Z","updated_at":"2016-09-06T07:04:59Z","pushed_at":"2016-09-07T12:59:41Z","git_url":"git://github.com/SURFnet/saml2.git","ssh_url":"git@github.com:SURFnet/saml2.git","clone_url":"https://github.com/SURFnet/saml2.git","svn_url":"https://github.com/SURFnet/saml2","homepage":"http://www.simplesamlphp.org","size":8678,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"simplesamlphp:master","ref":"master","sha":"e25ed1a7fbedd5a9cea76b494641f325a0351937","user":{"login":"simplesamlphp","id":5774640,"avatar_url":"https://avatars.githubusercontent.com/u/5774640?v=3","gravatar_id":"","url":"https://api.github.com/users/simplesamlphp","html_url":"https://github.com/simplesamlphp","followers_url":"https://api.github.com/users/simplesamlphp/followers","following_url":"https://api.github.com/users/simplesamlphp/following{/other_user}","gists_url":"https://api.github.com/users/simplesamlphp/gists{/gist_id}","starred_url":"https://api.github.com/users/simplesamlphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplesamlphp/subscriptions","organizations_url":"https://api.github.com/users/simplesamlphp/orgs","repos_url":"https://api.github.com/users/simplesamlphp/repos","events_url":"https://api.github.com/users/simplesamlphp/events{/privacy}","received_events_url":"https://api.github.com/users/simplesamlphp/received_events","type":"Organization","site_admin":false},"repo":{"id":14139852,"name":"saml2","full_name":"simplesamlphp/saml2","owner":{"login":"simplesamlphp","id":5774640,"avatar_url":"https://avatars.githubusercontent.com/u/5774640?v=3","gravatar_id":"","url":"https://api.github.com/users/simplesamlphp","html_url":"https://github.com/simplesamlphp","followers_url":"https://api.github.com/users/simplesamlphp/followers","following_url":"https://api.github.com/users/simplesamlphp/following{/other_user}","gists_url":"https://api.github.com/users/simplesamlphp/gists{/gist_id}","starred_url":"https://api.github.com/users/simplesamlphp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simplesamlphp/subscriptions","organizations_url":"https://api.github.com/users/simplesamlphp/orgs","repos_url":"https://api.github.com/users/simplesamlphp/repos","events_url":"https://api.github.com/users/simplesamlphp/events{/privacy}","received_events_url":"https://api.github.com/users/simplesamlphp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/simplesamlphp/saml2","description":"SimpleSAMLphp low-level SAML2 PHP library","fork":false,"url":"https://api.github.com/repos/simplesamlphp/saml2","forks_url":"https://api.github.com/repos/simplesamlphp/saml2/forks","keys_url":"https://api.github.com/repos/simplesamlphp/saml2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simplesamlphp/saml2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simplesamlphp/saml2/teams","hooks_url":"https://api.github.com/repos/simplesamlphp/saml2/hooks","issue_events_url":"https://api.github.com/repos/simplesamlphp/saml2/issues/events{/number}","events_url":"https://api.github.com/repos/simplesamlphp/saml2/events","assignees_url":"https://api.github.com/repos/simplesamlphp/saml2/assignees{/user}","branches_url":"https://api.github.com/repos/simplesamlphp/saml2/branches{/branch}","tags_url":"https://api.github.com/repos/simplesamlphp/saml2/tags","blobs_url":"https://api.github.com/repos/simplesamlphp/saml2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simplesamlphp/saml2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simplesamlphp/saml2/git/refs{/sha}","trees_url":"https://api.github.com/repos/simplesamlphp/saml2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simplesamlphp/saml2/statuses/{sha}","languages_url":"https://api.github.com/repos/simplesamlphp/saml2/languages","stargazers_url":"https://api.github.com/repos/simplesamlphp/saml2/stargazers","contributors_url":"https://api.github.com/repos/simplesamlphp/saml2/contributors","subscribers_url":"https://api.github.com/repos/simplesamlphp/saml2/subscribers","subscription_url":"https://api.github.com/repos/simplesamlphp/saml2/subscription","commits_url":"https://api.github.com/repos/simplesamlphp/saml2/commits{/sha}","git_commits_url":"https://api.github.com/repos/simplesamlphp/saml2/git/commits{/sha}","comments_url":"https://api.github.com/repos/simplesamlphp/saml2/comments{/number}","issue_comment_url":"https://api.github.com/repos/simplesamlphp/saml2/issues/comments{/number}","contents_url":"https://api.github.com/repos/simplesamlphp/saml2/contents/{+path}","compare_url":"https://api.github.com/repos/simplesamlphp/saml2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simplesamlphp/saml2/merges","archive_url":"https://api.github.com/repos/simplesamlphp/saml2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simplesamlphp/saml2/downloads","issues_url":"https://api.github.com/repos/simplesamlphp/saml2/issues{/number}","pulls_url":"https://api.github.com/repos/simplesamlphp/saml2/pulls{/number}","milestones_url":"https://api.github.com/repos/simplesamlphp/saml2/milestones{/number}","notifications_url":"https://api.github.com/repos/simplesamlphp/saml2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simplesamlphp/saml2/labels{/name}","releases_url":"https://api.github.com/repos/simplesamlphp/saml2/releases{/id}","deployments_url":"https://api.github.com/repos/simplesamlphp/saml2/deployments","created_at":"2013-11-05T11:38:43Z","updated_at":"2016-09-02T16:57:00Z","pushed_at":"2016-09-07T13:04:58Z","git_url":"git://github.com/simplesamlphp/saml2.git","ssh_url":"git@github.com:simplesamlphp/saml2.git","clone_url":"https://github.com/simplesamlphp/saml2.git","svn_url":"https://github.com/simplesamlphp/saml2","homepage":"http://www.simplesamlphp.org","size":11074,"stargazers_count":99,"watchers_count":99,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":10,"forks":60,"open_issues":10,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simplesamlphp/saml2/pulls/76"},"html":{"href":"https://github.com/simplesamlphp/saml2/pull/76"},"issue":{"href":"https://api.github.com/repos/simplesamlphp/saml2/issues/76"},"comments":{"href":"https://api.github.com/repos/simplesamlphp/saml2/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/simplesamlphp/saml2/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/simplesamlphp/saml2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simplesamlphp/saml2/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/simplesamlphp/saml2/statuses/09e41571b53e209c3a96b3f213efdc2da6239d12"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":217,"deletions":17,"changed_files":3}}
{"actor":{"display_login":"DRvanR"}}