{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/90964659","pull_request_review_id":11471399,"id":90964659,"diff_hunk":"@@ -0,0 +1,509 @@\n+{\n+  \"build\": [\n+    {\n+      \"enabled\": true,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"Delete 'corert'\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"e213ff0f-5d5c-4791-802d-52ea3e7be1f1\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"scriptType\": \"inlineScript\",\n+        \"scriptName\": \"\",\n+        \"arguments\": \"-path $(build.SourcesDirectory)\\\\corert\",\n+        \"inlineScript\": \"param($path)\\n\\nif (Test-Path $path){\\n    # this will print out an error each time a file can't be deleted.\\n    Remove-Item -Recurse -Force $path\\n }\\n\\nif (Test-Path $path){\\n    # in case corefx is still alive\\n    .\\\\diag_tools\\\\handle.exe -accepteula $path\\n }\",\n+        \"workingFolder\": \"\",\n+        \"failOnStandardError\": \"true\"\n+      }\n+    },\n+    {\n+      \"enabled\": false,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"Delete files from $(build.SourcesDirectory)\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"b7e8b412-0437-4065-9371-edc5881de25b\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"SourceFolder\": \"$(build.SourcesDirectory)\",\n+        \"Contents\": \"**\\n.gitignore\"\n+      }\n+    },\n+    {\n+      \"enabled\": true,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"git clone\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"d9bafed4-0b18-4f58-968d-86655b4d2ce9\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"filename\": \"$(Git)\",\n+        \"arguments\": \"clone $(GitUrl) corert\",\n+        \"workingFolder\": \"\",\n+        \"failOnStandardError\": \"false\"\n+      }\n+    },\n+    {\n+      \"enabled\": true,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"git checkout\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"d9bafed4-0b18-4f58-968d-86655b4d2ce9\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"filename\": \"$(Git)\",\n+        \"arguments\": \"checkout $(SourceVersion)\",\n+        \"workingFolder\": \"corert\",\n+        \"failOnStandardError\": \"false\"\n+      }\n+    },\n+    {\n+      \"enabled\": true,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"Install Signing Plugin\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"30666190-6959-11e5-9f96-f56098202fef\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"signType\": \"$(SignType)\",\n+        \"zipSources\": \"false\",\n+        \"version\": \"\",\n+        \"feedSource\": \"https://devdiv.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json\"\n+      }\n+    },\n+    {\n+      \"enabled\": true,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"Run $(Build.SourcesDirectory)\\\\corert\\\\cibuild\\\\clean.cmd\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"d9bafed4-0b18-4f58-968d-86655b4d2ce9\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"filename\": \"$(Build.SourcesDirectory)\\\\corert\\\\cibuild\\\\clean.cmd\",\n+        \"arguments\": \"-all\",\n+        \"workingFolder\": \"corert\",\n+        \"failOnStandardError\": \"false\"\n+      }\n+    },\n+    {\n+      \"enabled\": false,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"Run $(Build.SourcesDirectory)\\\\corert\\\\sync.cmd\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"d9bafed4-0b18-4f58-968d-86655b4d2ce9\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"filename\": \"$(Build.SourcesDirectory)\\\\corert\\\\sync.cmd\",\n+        \"arguments\": \"-p\",\n+        \"workingFolder\": \"corert\",\n+        \"failOnStandardError\": \"false\"\n+      }\n+    },\n+    {\n+      \"enabled\": true,\n+      \"continueOnError\": false,\n+      \"alwaysRun\": false,\n+      \"displayName\": \"Build\",\n+      \"timeoutInMinutes\": 0,\n+      \"task\": {\n+        \"id\": \"d9bafed4-0b18-4f58-968d-86655b4d2ce9\",\n+        \"versionSpec\": \"*\",\n+        \"definitionType\": \"task\"\n+      },\n+      \"inputs\": {\n+        \"filename\": \"$(Build.SourcesDirectory)\\\\corert\\\\build.cmd\",","path":"buildpipeline/DotNet-CoreRT-Windows.json","position":141,"original_position":141,"commit_id":"811568c6a89ec1cb90db00512f6fc2f55b89f824","original_commit_id":"811568c6a89ec1cb90db00512f6fc2f55b89f824","user":{"login":"SedarG","id":10768076,"avatar_url":"https://avatars.githubusercontent.com/u/10768076?v=3","gravatar_id":"","url":"https://api.github.com/users/SedarG","html_url":"https://github.com/SedarG","followers_url":"https://api.github.com/users/SedarG/followers","following_url":"https://api.github.com/users/SedarG/following{/other_user}","gists_url":"https://api.github.com/users/SedarG/gists{/gist_id}","starred_url":"https://api.github.com/users/SedarG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SedarG/subscriptions","organizations_url":"https://api.github.com/users/SedarG/orgs","repos_url":"https://api.github.com/users/SedarG/repos","events_url":"https://api.github.com/users/SedarG/events{/privacy}","received_events_url":"https://api.github.com/users/SedarG/received_events","type":"User","site_admin":false},"body":"My expectation was to split build.cmd to build-native, build-managed and build-packages. build.cmd currently doesn't call build-*. Is this intentional?","created_at":"2016-12-05T21:56:59Z","updated_at":"2016-12-05T21:56:59Z","html_url":"https://github.com/dotnet/corert/pull/2299#discussion_r90964659","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/2299","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/90964659"},"html":{"href":"https://github.com/dotnet/corert/pull/2299#discussion_r90964659"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2299"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/2299","id":96583261,"html_url":"https://github.com/dotnet/corert/pull/2299","diff_url":"https://github.com/dotnet/corert/pull/2299.diff","patch_url":"https://github.com/dotnet/corert/pull/2299.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/2299","number":2299,"state":"open","locked":false,"title":"Enable pipebuild in CoreRT","user":{"login":"crummel","id":8184470,"avatar_url":"https://avatars.githubusercontent.com/u/8184470?v=3","gravatar_id":"","url":"https://api.github.com/users/crummel","html_url":"https://github.com/crummel","followers_url":"https://api.github.com/users/crummel/followers","following_url":"https://api.github.com/users/crummel/following{/other_user}","gists_url":"https://api.github.com/users/crummel/gists{/gist_id}","starred_url":"https://api.github.com/users/crummel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crummel/subscriptions","organizations_url":"https://api.github.com/users/crummel/orgs","repos_url":"https://api.github.com/users/crummel/repos","events_url":"https://api.github.com/users/crummel/events{/privacy}","received_events_url":"https://api.github.com/users/crummel/received_events","type":"User","site_admin":false},"body":"These are only the changes necessary to enable pipebuild for all platforms on DevDiv VSO: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?definitionId=4582&_a=completed.\r\n- Add checked-in build definitions and pipeline definition.\r\n- Add some extra scripts that are helpful for CI builds.\r\n- Minor change to how runtest.sh determines the test folder, this seems to be a bash version difference on the build machines.","created_at":"2016-12-05T18:28:50Z","updated_at":"2016-12-05T21:59:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ac98002b0e2042f7fe16289f18c73b2b19a6823","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/2299/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/2299/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/2299/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/811568c6a89ec1cb90db00512f6fc2f55b89f824","head":{"label":"crummel:buildChangesOnly","ref":"buildChangesOnly","sha":"811568c6a89ec1cb90db00512f6fc2f55b89f824","user":{"login":"crummel","id":8184470,"avatar_url":"https://avatars.githubusercontent.com/u/8184470?v=3","gravatar_id":"","url":"https://api.github.com/users/crummel","html_url":"https://github.com/crummel","followers_url":"https://api.github.com/users/crummel/followers","following_url":"https://api.github.com/users/crummel/following{/other_user}","gists_url":"https://api.github.com/users/crummel/gists{/gist_id}","starred_url":"https://api.github.com/users/crummel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crummel/subscriptions","organizations_url":"https://api.github.com/users/crummel/orgs","repos_url":"https://api.github.com/users/crummel/repos","events_url":"https://api.github.com/users/crummel/events{/privacy}","received_events_url":"https://api.github.com/users/crummel/received_events","type":"User","site_admin":false},"repo":{"id":72657728,"name":"dotnet_corert","full_name":"crummel/dotnet_corert","owner":{"login":"crummel","id":8184470,"avatar_url":"https://avatars.githubusercontent.com/u/8184470?v=3","gravatar_id":"","url":"https://api.github.com/users/crummel","html_url":"https://github.com/crummel","followers_url":"https://api.github.com/users/crummel/followers","following_url":"https://api.github.com/users/crummel/following{/other_user}","gists_url":"https://api.github.com/users/crummel/gists{/gist_id}","starred_url":"https://api.github.com/users/crummel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crummel/subscriptions","organizations_url":"https://api.github.com/users/crummel/orgs","repos_url":"https://api.github.com/users/crummel/repos","events_url":"https://api.github.com/users/crummel/events{/privacy}","received_events_url":"https://api.github.com/users/crummel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/crummel/dotnet_corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/crummel/dotnet_corert","forks_url":"https://api.github.com/repos/crummel/dotnet_corert/forks","keys_url":"https://api.github.com/repos/crummel/dotnet_corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crummel/dotnet_corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crummel/dotnet_corert/teams","hooks_url":"https://api.github.com/repos/crummel/dotnet_corert/hooks","issue_events_url":"https://api.github.com/repos/crummel/dotnet_corert/issues/events{/number}","events_url":"https://api.github.com/repos/crummel/dotnet_corert/events","assignees_url":"https://api.github.com/repos/crummel/dotnet_corert/assignees{/user}","branches_url":"https://api.github.com/repos/crummel/dotnet_corert/branches{/branch}","tags_url":"https://api.github.com/repos/crummel/dotnet_corert/tags","blobs_url":"https://api.github.com/repos/crummel/dotnet_corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crummel/dotnet_corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crummel/dotnet_corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/crummel/dotnet_corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crummel/dotnet_corert/statuses/{sha}","languages_url":"https://api.github.com/repos/crummel/dotnet_corert/languages","stargazers_url":"https://api.github.com/repos/crummel/dotnet_corert/stargazers","contributors_url":"https://api.github.com/repos/crummel/dotnet_corert/contributors","subscribers_url":"https://api.github.com/repos/crummel/dotnet_corert/subscribers","subscription_url":"https://api.github.com/repos/crummel/dotnet_corert/subscription","commits_url":"https://api.github.com/repos/crummel/dotnet_corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/crummel/dotnet_corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/crummel/dotnet_corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/crummel/dotnet_corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/crummel/dotnet_corert/contents/{+path}","compare_url":"https://api.github.com/repos/crummel/dotnet_corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crummel/dotnet_corert/merges","archive_url":"https://api.github.com/repos/crummel/dotnet_corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crummel/dotnet_corert/downloads","issues_url":"https://api.github.com/repos/crummel/dotnet_corert/issues{/number}","pulls_url":"https://api.github.com/repos/crummel/dotnet_corert/pulls{/number}","milestones_url":"https://api.github.com/repos/crummel/dotnet_corert/milestones{/number}","notifications_url":"https://api.github.com/repos/crummel/dotnet_corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crummel/dotnet_corert/labels{/name}","releases_url":"https://api.github.com/repos/crummel/dotnet_corert/releases{/id}","deployments_url":"https://api.github.com/repos/crummel/dotnet_corert/deployments","created_at":"2016-11-02T16:11:41Z","updated_at":"2016-11-02T16:12:14Z","pushed_at":"2016-12-05T18:05:16Z","git_url":"git://github.com/crummel/dotnet_corert.git","ssh_url":"git@github.com:crummel/dotnet_corert.git","clone_url":"https://github.com/crummel/dotnet_corert.git","svn_url":"https://github.com/crummel/dotnet_corert","homepage":"http://dotnet.github.io/","size":12761,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"724a6434717656bc0eca78d90f1c162b89012734","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2016-12-05T01:40:09Z","pushed_at":"2016-12-05T20:09:45Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dotnet.github.io/","size":22305,"stargazers_count":491,"watchers_count":491,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":170,"forks":159,"open_issues":170,"watchers":491,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2299"},"html":{"href":"https://github.com/dotnet/corert/pull/2299"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/2299"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/2299/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2299/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/2299/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/811568c6a89ec1cb90db00512f6fc2f55b89f824"}}}}
{"actor":{"display_login":"SedarG"}}