{"action":"created","comment":{"url":"https://api.github.com/repos/fxbox/foxbox/pulls/comments/66430172","id":66430172,"diff_hunk":"@@ -1,5 +1,8 @@\n //! Utilities for defining a JSON parser.\n \n+#![allow(identity_op)] // Keep clippy happy with [De]serialize","path":"components/taxonomy/src/parse.rs","position":3,"original_position":3,"commit_id":"4ced0a637b130bc0004abcb5dd4ca7c182b762fd","original_commit_id":"4ced0a637b130bc0004abcb5dd4ca7c182b762fd","user":{"login":"Yoric","id":10190,"avatar_url":"https://avatars.githubusercontent.com/u/10190?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"body":"I haven't checked the generated code.","created_at":"2016-06-09T12:24:25Z","updated_at":"2016-06-09T12:24:26Z","html_url":"https://github.com/fxbox/foxbox/pull/520#discussion_r66430172","pull_request_url":"https://api.github.com/repos/fxbox/foxbox/pulls/520","_links":{"self":{"href":"https://api.github.com/repos/fxbox/foxbox/pulls/comments/66430172"},"html":{"href":"https://github.com/fxbox/foxbox/pull/520#discussion_r66430172"},"pull_request":{"href":"https://api.github.com/repos/fxbox/foxbox/pulls/520"}}},"pull_request":{"url":"https://api.github.com/repos/fxbox/foxbox/pulls/520","id":73124363,"html_url":"https://github.com/fxbox/foxbox/pull/520","diff_url":"https://github.com/fxbox/foxbox/pull/520.diff","patch_url":"https://github.com/fxbox/foxbox/pull/520.patch","issue_url":"https://api.github.com/repos/fxbox/foxbox/issues/520","number":520,"state":"open","locked":false,"title":"Decentralizing: Removing big centralized Value","user":{"login":"Yoric","id":10190,"avatar_url":"https://avatars.githubusercontent.com/u/10190?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"body":"This PR removes the big centralized enum `Value`, effectively ending all centralization in Taxonomy. The first two beneficiaries are Thinkerbell (which now defines its own value type `RuleSource`) and WebPush (which now defines its own value type `WebPushNotify`).\r\n\r\n- [x] r? @fabricedesre for Foxbox.\r\n- [ ] r? @mcav for Thinkerbell.\r\n- [ ] r? @julienw for ZWave.\r\n- [x] r? @cr for Philps Hue.\r\n- [x] r? @dhylands for IP Camera.\r\n- [x] r? @aosmond for WebPush.\r\n- [ ] r? @fabricedesre for TTS.\r\n- [ ] r? @npark-mozilla for integration tests.\r\n- [ ] f? @azasypkin for synchronization with front-end.\r\n\r\nI still have a few PRs planned after this lands, but at this stage, Taxonomy will be Decentralized \\o/","created_at":"2016-06-08T21:34:13Z","updated_at":"2016-06-09T12:24:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa02431de8f2ea9eb7ec0b13a93698cce2fda1e0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fxbox/foxbox/pulls/520/commits","review_comments_url":"https://api.github.com/repos/fxbox/foxbox/pulls/520/comments","review_comment_url":"https://api.github.com/repos/fxbox/foxbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fxbox/foxbox/issues/520/comments","statuses_url":"https://api.github.com/repos/fxbox/foxbox/statuses/4ced0a637b130bc0004abcb5dd4ca7c182b762fd","head":{"label":"Yoric:refactor-7","ref":"refactor-7","sha":"4ced0a637b130bc0004abcb5dd4ca7c182b762fd","user":{"login":"Yoric","id":10190,"avatar_url":"https://avatars.githubusercontent.com/u/10190?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"repo":{"id":55255900,"name":"foxbox","full_name":"Yoric/foxbox","owner":{"login":"Yoric","id":10190,"avatar_url":"https://avatars.githubusercontent.com/u/10190?v=3","gravatar_id":"","url":"https://api.github.com/users/Yoric","html_url":"https://github.com/Yoric","followers_url":"https://api.github.com/users/Yoric/followers","following_url":"https://api.github.com/users/Yoric/following{/other_user}","gists_url":"https://api.github.com/users/Yoric/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoric/subscriptions","organizations_url":"https://api.github.com/users/Yoric/orgs","repos_url":"https://api.github.com/users/Yoric/repos","events_url":"https://api.github.com/users/Yoric/events{/privacy}","received_events_url":"https://api.github.com/users/Yoric/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yoric/foxbox","description":"The FoxBox daemon","fork":true,"url":"https://api.github.com/repos/Yoric/foxbox","forks_url":"https://api.github.com/repos/Yoric/foxbox/forks","keys_url":"https://api.github.com/repos/Yoric/foxbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoric/foxbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoric/foxbox/teams","hooks_url":"https://api.github.com/repos/Yoric/foxbox/hooks","issue_events_url":"https://api.github.com/repos/Yoric/foxbox/issues/events{/number}","events_url":"https://api.github.com/repos/Yoric/foxbox/events","assignees_url":"https://api.github.com/repos/Yoric/foxbox/assignees{/user}","branches_url":"https://api.github.com/repos/Yoric/foxbox/branches{/branch}","tags_url":"https://api.github.com/repos/Yoric/foxbox/tags","blobs_url":"https://api.github.com/repos/Yoric/foxbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoric/foxbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoric/foxbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoric/foxbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoric/foxbox/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoric/foxbox/languages","stargazers_url":"https://api.github.com/repos/Yoric/foxbox/stargazers","contributors_url":"https://api.github.com/repos/Yoric/foxbox/contributors","subscribers_url":"https://api.github.com/repos/Yoric/foxbox/subscribers","subscription_url":"https://api.github.com/repos/Yoric/foxbox/subscription","commits_url":"https://api.github.com/repos/Yoric/foxbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoric/foxbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoric/foxbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoric/foxbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoric/foxbox/contents/{+path}","compare_url":"https://api.github.com/repos/Yoric/foxbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoric/foxbox/merges","archive_url":"https://api.github.com/repos/Yoric/foxbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoric/foxbox/downloads","issues_url":"https://api.github.com/repos/Yoric/foxbox/issues{/number}","pulls_url":"https://api.github.com/repos/Yoric/foxbox/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoric/foxbox/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoric/foxbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoric/foxbox/labels{/name}","releases_url":"https://api.github.com/repos/Yoric/foxbox/releases{/id}","deployments_url":"https://api.github.com/repos/Yoric/foxbox/deployments","created_at":"2016-04-01T19:04:44Z","updated_at":"2016-04-01T19:04:46Z","pushed_at":"2016-06-09T07:02:01Z","git_url":"git://github.com/Yoric/foxbox.git","ssh_url":"git@github.com:Yoric/foxbox.git","clone_url":"https://github.com/Yoric/foxbox.git","svn_url":"https://github.com/Yoric/foxbox","homepage":null,"size":3074,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fxbox:master","ref":"master","sha":"711ea2231729e3fc987a29f470ca892b280cff90","user":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"repo":{"id":50702140,"name":"foxbox","full_name":"fxbox/foxbox","owner":{"login":"fxbox","id":17052474,"avatar_url":"https://avatars.githubusercontent.com/u/17052474?v=3","gravatar_id":"","url":"https://api.github.com/users/fxbox","html_url":"https://github.com/fxbox","followers_url":"https://api.github.com/users/fxbox/followers","following_url":"https://api.github.com/users/fxbox/following{/other_user}","gists_url":"https://api.github.com/users/fxbox/gists{/gist_id}","starred_url":"https://api.github.com/users/fxbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxbox/subscriptions","organizations_url":"https://api.github.com/users/fxbox/orgs","repos_url":"https://api.github.com/users/fxbox/repos","events_url":"https://api.github.com/users/fxbox/events{/privacy}","received_events_url":"https://api.github.com/users/fxbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fxbox/foxbox","description":"The FoxBox daemon","fork":false,"url":"https://api.github.com/repos/fxbox/foxbox","forks_url":"https://api.github.com/repos/fxbox/foxbox/forks","keys_url":"https://api.github.com/repos/fxbox/foxbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fxbox/foxbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fxbox/foxbox/teams","hooks_url":"https://api.github.com/repos/fxbox/foxbox/hooks","issue_events_url":"https://api.github.com/repos/fxbox/foxbox/issues/events{/number}","events_url":"https://api.github.com/repos/fxbox/foxbox/events","assignees_url":"https://api.github.com/repos/fxbox/foxbox/assignees{/user}","branches_url":"https://api.github.com/repos/fxbox/foxbox/branches{/branch}","tags_url":"https://api.github.com/repos/fxbox/foxbox/tags","blobs_url":"https://api.github.com/repos/fxbox/foxbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fxbox/foxbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fxbox/foxbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/fxbox/foxbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fxbox/foxbox/statuses/{sha}","languages_url":"https://api.github.com/repos/fxbox/foxbox/languages","stargazers_url":"https://api.github.com/repos/fxbox/foxbox/stargazers","contributors_url":"https://api.github.com/repos/fxbox/foxbox/contributors","subscribers_url":"https://api.github.com/repos/fxbox/foxbox/subscribers","subscription_url":"https://api.github.com/repos/fxbox/foxbox/subscription","commits_url":"https://api.github.com/repos/fxbox/foxbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/fxbox/foxbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/fxbox/foxbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/fxbox/foxbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/fxbox/foxbox/contents/{+path}","compare_url":"https://api.github.com/repos/fxbox/foxbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fxbox/foxbox/merges","archive_url":"https://api.github.com/repos/fxbox/foxbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fxbox/foxbox/downloads","issues_url":"https://api.github.com/repos/fxbox/foxbox/issues{/number}","pulls_url":"https://api.github.com/repos/fxbox/foxbox/pulls{/number}","milestones_url":"https://api.github.com/repos/fxbox/foxbox/milestones{/number}","notifications_url":"https://api.github.com/repos/fxbox/foxbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fxbox/foxbox/labels{/name}","releases_url":"https://api.github.com/repos/fxbox/foxbox/releases{/id}","deployments_url":"https://api.github.com/repos/fxbox/foxbox/deployments","created_at":"2016-01-30T01:13:10Z","updated_at":"2016-06-03T21:34:09Z","pushed_at":"2016-06-09T07:02:01Z","git_url":"git://github.com/fxbox/foxbox.git","ssh_url":"git@github.com:fxbox/foxbox.git","clone_url":"https://github.com/fxbox/foxbox.git","svn_url":"https://github.com/fxbox/foxbox","homepage":null,"size":3252,"stargazers_count":23,"watchers_count":23,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":83,"forks":29,"open_issues":83,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fxbox/foxbox/pulls/520"},"html":{"href":"https://github.com/fxbox/foxbox/pull/520"},"issue":{"href":"https://api.github.com/repos/fxbox/foxbox/issues/520"},"comments":{"href":"https://api.github.com/repos/fxbox/foxbox/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/fxbox/foxbox/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/fxbox/foxbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fxbox/foxbox/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/fxbox/foxbox/statuses/4ced0a637b130bc0004abcb5dd4ca7c182b762fd"}}}}
{"actor":{"display_login":"Yoric"}}