{"action":"created","comment":{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/comments/76699239","id":76699239,"diff_hunk":"@@ -57,5 +54,5 @@ var localePageFactory = function($log, $http, $q, CONSTANTS) {\n \n };\n \n-localePageFactory.$inject = ['$log', '$http', '$q', 'CONSTANTS'];\n+localePageFactory.$inject = ['$log', '$http', '$q', 'CONSTANTS', 'disclosureApi'];","path":"app/components/appMainModule/localePageModule/localePageFactory.js","position":25,"original_position":25,"commit_id":"b7d2f094af4ba01b7733a503de82361377fee0be","original_commit_id":"cff2687e3e58e4ec59eaec665f1900565dcdc7c0","user":{"login":"jnmarcus","id":1439922,"avatar_url":"https://avatars.githubusercontent.com/u/1439922?v=3","gravatar_id":"","url":"https://api.github.com/users/jnmarcus","html_url":"https://github.com/jnmarcus","followers_url":"https://api.github.com/users/jnmarcus/followers","following_url":"https://api.github.com/users/jnmarcus/following{/other_user}","gists_url":"https://api.github.com/users/jnmarcus/gists{/gist_id}","starred_url":"https://api.github.com/users/jnmarcus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnmarcus/subscriptions","organizations_url":"https://api.github.com/users/jnmarcus/orgs","repos_url":"https://api.github.com/users/jnmarcus/repos","events_url":"https://api.github.com/users/jnmarcus/events{/privacy}","received_events_url":"https://api.github.com/users/jnmarcus/received_events","type":"User","site_admin":false},"body":"please revert","created_at":"2016-08-29T22:23:08Z","updated_at":"2016-08-29T22:23:08Z","html_url":"https://github.com/caciviclab/disclosure-frontend/pull/141#discussion_r76699239","pull_request_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/comments/76699239"},"html":{"href":"https://github.com/caciviclab/disclosure-frontend/pull/141#discussion_r76699239"},"pull_request":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141","id":83025559,"html_url":"https://github.com/caciviclab/disclosure-frontend/pull/141","diff_url":"https://github.com/caciviclab/disclosure-frontend/pull/141.diff","patch_url":"https://github.com/caciviclab/disclosure-frontend/pull/141.patch","issue_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141","number":141,"state":"open","locked":false,"title":"Update upcoming election views for fixed backend serialization","user":{"login":"adborden","id":509703,"avatar_url":"https://avatars.githubusercontent.com/u/509703?v=3","gravatar_id":"","url":"https://api.github.com/users/adborden","html_url":"https://github.com/adborden","followers_url":"https://api.github.com/users/adborden/followers","following_url":"https://api.github.com/users/adborden/following{/other_user}","gists_url":"https://api.github.com/users/adborden/gists{/gist_id}","starred_url":"https://api.github.com/users/adborden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adborden/subscriptions","organizations_url":"https://api.github.com/users/adborden/orgs","repos_url":"https://api.github.com/users/adborden/repos","events_url":"https://api.github.com/users/adborden/events{/privacy}","received_events_url":"https://api.github.com/users/adborden/received_events","type":"User","site_admin":false},"body":"The [backend has fixed](https://github.com/caciviclab/disclosure-backend/pull/272) the ballot serialization, so the frontend needs to change a bit since these are breaking changes.\r\n\r\n- Use `name` for office contests, `number` and `title` for referendums (backend is still missing referendum data, so we still get `null`s).\r\n- Added test for disclosure api around error handling when calling a method that doesn't exist in the swagger spec.\r\n- Use the disclosureApi service so I can develop against a local backend.\r\n\r\nThis should be merged at the same time as https://github.com/caciviclab/disclosure-backend/pull/272","created_at":"2016-08-28T20:05:20Z","updated_at":"2016-08-29T22:23:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6b9aa96f33638dcda0f663827d3227cd67a3bae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141/commits","review_comments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141/comments","review_comment_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141/comments","statuses_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/statuses/b7d2f094af4ba01b7733a503de82361377fee0be","head":{"label":"caciviclab:feature/update-api","ref":"feature/update-api","sha":"b7d2f094af4ba01b7733a503de82361377fee0be","user":{"login":"caciviclab","id":9602455,"avatar_url":"https://avatars.githubusercontent.com/u/9602455?v=3","gravatar_id":"","url":"https://api.github.com/users/caciviclab","html_url":"https://github.com/caciviclab","followers_url":"https://api.github.com/users/caciviclab/followers","following_url":"https://api.github.com/users/caciviclab/following{/other_user}","gists_url":"https://api.github.com/users/caciviclab/gists{/gist_id}","starred_url":"https://api.github.com/users/caciviclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caciviclab/subscriptions","organizations_url":"https://api.github.com/users/caciviclab/orgs","repos_url":"https://api.github.com/users/caciviclab/repos","events_url":"https://api.github.com/users/caciviclab/events{/privacy}","received_events_url":"https://api.github.com/users/caciviclab/received_events","type":"Organization","site_admin":false},"repo":{"id":42682839,"name":"disclosure-frontend","full_name":"caciviclab/disclosure-frontend","owner":{"login":"caciviclab","id":9602455,"avatar_url":"https://avatars.githubusercontent.com/u/9602455?v=3","gravatar_id":"","url":"https://api.github.com/users/caciviclab","html_url":"https://github.com/caciviclab","followers_url":"https://api.github.com/users/caciviclab/followers","following_url":"https://api.github.com/users/caciviclab/following{/other_user}","gists_url":"https://api.github.com/users/caciviclab/gists{/gist_id}","starred_url":"https://api.github.com/users/caciviclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caciviclab/subscriptions","organizations_url":"https://api.github.com/users/caciviclab/orgs","repos_url":"https://api.github.com/users/caciviclab/repos","events_url":"https://api.github.com/users/caciviclab/events{/privacy}","received_events_url":"https://api.github.com/users/caciviclab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caciviclab/disclosure-frontend","description":"open disclosure frontend app","fork":false,"url":"https://api.github.com/repos/caciviclab/disclosure-frontend","forks_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/forks","keys_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/teams","hooks_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/hooks","issue_events_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/events","assignees_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/tags","blobs_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/languages","stargazers_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/stargazers","contributors_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/contributors","subscribers_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/subscribers","subscription_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/subscription","commits_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/merges","archive_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/downloads","issues_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/labels{/name}","releases_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/deployments","created_at":"2015-09-17T21:26:55Z","updated_at":"2016-07-13T03:30:12Z","pushed_at":"2016-08-28T20:05:20Z","git_url":"git://github.com/caciviclab/disclosure-frontend.git","ssh_url":"git@github.com:caciviclab/disclosure-frontend.git","clone_url":"https://github.com/caciviclab/disclosure-frontend.git","svn_url":"https://github.com/caciviclab/disclosure-frontend","homepage":"http://disclosure.caciviclab.org/","size":4809,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":34,"forks":13,"open_issues":34,"watchers":5,"default_branch":"master"}},"base":{"label":"caciviclab:master","ref":"master","sha":"207abbfd365fefee7bca08e65c910f24e764dc6f","user":{"login":"caciviclab","id":9602455,"avatar_url":"https://avatars.githubusercontent.com/u/9602455?v=3","gravatar_id":"","url":"https://api.github.com/users/caciviclab","html_url":"https://github.com/caciviclab","followers_url":"https://api.github.com/users/caciviclab/followers","following_url":"https://api.github.com/users/caciviclab/following{/other_user}","gists_url":"https://api.github.com/users/caciviclab/gists{/gist_id}","starred_url":"https://api.github.com/users/caciviclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caciviclab/subscriptions","organizations_url":"https://api.github.com/users/caciviclab/orgs","repos_url":"https://api.github.com/users/caciviclab/repos","events_url":"https://api.github.com/users/caciviclab/events{/privacy}","received_events_url":"https://api.github.com/users/caciviclab/received_events","type":"Organization","site_admin":false},"repo":{"id":42682839,"name":"disclosure-frontend","full_name":"caciviclab/disclosure-frontend","owner":{"login":"caciviclab","id":9602455,"avatar_url":"https://avatars.githubusercontent.com/u/9602455?v=3","gravatar_id":"","url":"https://api.github.com/users/caciviclab","html_url":"https://github.com/caciviclab","followers_url":"https://api.github.com/users/caciviclab/followers","following_url":"https://api.github.com/users/caciviclab/following{/other_user}","gists_url":"https://api.github.com/users/caciviclab/gists{/gist_id}","starred_url":"https://api.github.com/users/caciviclab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caciviclab/subscriptions","organizations_url":"https://api.github.com/users/caciviclab/orgs","repos_url":"https://api.github.com/users/caciviclab/repos","events_url":"https://api.github.com/users/caciviclab/events{/privacy}","received_events_url":"https://api.github.com/users/caciviclab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caciviclab/disclosure-frontend","description":"open disclosure frontend app","fork":false,"url":"https://api.github.com/repos/caciviclab/disclosure-frontend","forks_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/forks","keys_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/teams","hooks_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/hooks","issue_events_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/events","assignees_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/tags","blobs_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/languages","stargazers_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/stargazers","contributors_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/contributors","subscribers_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/subscribers","subscription_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/subscription","commits_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/merges","archive_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/downloads","issues_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/labels{/name}","releases_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/caciviclab/disclosure-frontend/deployments","created_at":"2015-09-17T21:26:55Z","updated_at":"2016-07-13T03:30:12Z","pushed_at":"2016-08-28T20:05:20Z","git_url":"git://github.com/caciviclab/disclosure-frontend.git","ssh_url":"git@github.com:caciviclab/disclosure-frontend.git","clone_url":"https://github.com/caciviclab/disclosure-frontend.git","svn_url":"https://github.com/caciviclab/disclosure-frontend","homepage":"http://disclosure.caciviclab.org/","size":4809,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":34,"forks":13,"open_issues":34,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141"},"html":{"href":"https://github.com/caciviclab/disclosure-frontend/pull/141"},"issue":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141"},"comments":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/caciviclab/disclosure-frontend/statuses/b7d2f094af4ba01b7733a503de82361377fee0be"}}}}
{"actor":{"display_login":"jnmarcus"}}