{"action":"created","comment":{"url":"https://api.github.com/repos/haskell/cabal/pulls/comments/74748516","id":74748516,"diff_hunk":"@@ -133,6 +134,7 @@ hashedInstalledPackageIdShort pkghashinputs@PackageHashInputs{pkgHashPkgId} =\n --\n data PackageHashInputs = PackageHashInputs {\n        pkgHashPkgId         :: PackageId,\n+       pkgHashComponent     :: Maybe CD.Component,","path":"cabal-install/Distribution/Client/PackageHash.hs","position":39,"original_position":12,"commit_id":"b0b548971643ea11f2c9c33caae0f7efe89811a9","original_commit_id":"587adbce405e80819d8b95b2bad58fa1a6d5aff6","user":{"login":"dcoutts","id":1339423,"avatar_url":"https://avatars.githubusercontent.com/u/1339423?v=3","gravatar_id":"","url":"https://api.github.com/users/dcoutts","html_url":"https://github.com/dcoutts","followers_url":"https://api.github.com/users/dcoutts/followers","following_url":"https://api.github.com/users/dcoutts/following{/other_user}","gists_url":"https://api.github.com/users/dcoutts/gists{/gist_id}","starred_url":"https://api.github.com/users/dcoutts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcoutts/subscriptions","organizations_url":"https://api.github.com/users/dcoutts/orgs","repos_url":"https://api.github.com/users/dcoutts/repos","events_url":"https://api.github.com/users/dcoutts/events{/privacy}","received_events_url":"https://api.github.com/users/dcoutts/received_events","type":"User","site_admin":false},"body":"Yes, this is a lot nicer. Thanks.","created_at":"2016-08-15T11:19:46Z","updated_at":"2016-08-15T11:19:46Z","html_url":"https://github.com/haskell/cabal/pull/3662#discussion_r74748516","pull_request_url":"https://api.github.com/repos/haskell/cabal/pulls/3662","_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments/74748516"},"html":{"href":"https://github.com/haskell/cabal/pull/3662#discussion_r74748516"},"pull_request":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3662"}}},"pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/3662","id":79705481,"html_url":"https://github.com/haskell/cabal/pull/3662","diff_url":"https://github.com/haskell/cabal/pull/3662.diff","patch_url":"https://github.com/haskell/cabal/pull/3662.patch","issue_url":"https://api.github.com/repos/haskell/cabal/issues/3662","number":3662,"state":"open","locked":false,"title":"Per-component new-build support (no Custom support yet)","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"A bit of a megapatch.  Here's what's in it:\r\n\r\n* First, a few miscellaneous utility functions and reexports\r\n  in Cabal.  I could have split these into a separate commit\r\n  but I was too lazy to.\r\n\r\n* Distribution.Client.Install got refactored:\r\n  instead of using PackageFixedDeps, it uses PackageInstalled\r\n  instead.  That's because the install plan was NOT using\r\n  ComponentDeps in any nontrivial way. And it shouldn't.\r\n  So use a more specific type-class.  I also removed the\r\n  invariant checking and error reporting because it was\r\n  being annoying (we check the invariants already in\r\n  SolverInstallPlan).\r\n\r\n* Look at Distribution.Client.ProjectPlanning.Types.\r\n  This contains the primary type change: ElaboratedConfiguredPackage\r\n  is now EITHER a monolithic ElaboratedPackage, or a per-component\r\n  ElaboratedComponent (it should get renamed but I didn't do that\r\n  in this patch.)  These are what we're going to store in our\r\n  plans: if a package we're building has a Setup script which supports\r\n  per-component builds, we'll explode it into a component.  Otherwise\r\n  we'll keep it as a package.  We'll see codepaths for both\r\n  throughout.\r\n\r\n* OK, so the expansion happens in ProjectPlanning, mostly in\r\n  'elaborateAndExpandSolverPackage'.  You should review the\r\n  package hash computation code closely.  When we can separate\r\n  components, we compute a hash for each INDEPENDENTLY.  This\r\n  is good: we get more sharing.\r\n\r\n* We need to adjust the target resolution and pruning code\r\n  in ProjectOrchestration and ProjectPlanning.  I did a dumb\r\n  but easy idea: if a user mentions 'packagename' in a\r\n  target name, I spray the PackageTarget on every\r\n  possibly relevant IPID in buildTargets', and then pare\r\n  it down later.\r\n\r\n* And of course there's code in ProjectBuilding to actual\r\n  do a configure and then build.\r\n\r\nCustom doesn't work yet because I need to give them their own\r\nseparate component, and teach Cabal how to build them specially.","created_at":"2016-08-02T09:47:12Z","updated_at":"2016-08-15T11:19:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1fc362d4165615570f3e04a4f5806da2b70ed17","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/haskell/cabal/pulls/3662/commits","review_comments_url":"https://api.github.com/repos/haskell/cabal/pulls/3662/comments","review_comment_url":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/3662/comments","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/b0b548971643ea11f2c9c33caae0f7efe89811a9","head":{"label":"ezyang:pr/per-component-install","ref":"pr/per-component-install","sha":"b0b548971643ea11f2c9c33caae0f7efe89811a9","user":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":6343207,"name":"cabal","full_name":"ezyang/cabal","owner":{"login":"ezyang","id":13564,"avatar_url":"https://avatars.githubusercontent.com/u/13564?v=3","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":true,"url":"https://api.github.com/repos/ezyang/cabal","forks_url":"https://api.github.com/repos/ezyang/cabal/forks","keys_url":"https://api.github.com/repos/ezyang/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/cabal/teams","hooks_url":"https://api.github.com/repos/ezyang/cabal/hooks","issue_events_url":"https://api.github.com/repos/ezyang/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/cabal/events","assignees_url":"https://api.github.com/repos/ezyang/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/cabal/tags","blobs_url":"https://api.github.com/repos/ezyang/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/cabal/languages","stargazers_url":"https://api.github.com/repos/ezyang/cabal/stargazers","contributors_url":"https://api.github.com/repos/ezyang/cabal/contributors","subscribers_url":"https://api.github.com/repos/ezyang/cabal/subscribers","subscription_url":"https://api.github.com/repos/ezyang/cabal/subscription","commits_url":"https://api.github.com/repos/ezyang/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezyang/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/cabal/merges","archive_url":"https://api.github.com/repos/ezyang/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/cabal/downloads","issues_url":"https://api.github.com/repos/ezyang/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/cabal/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/ezyang/cabal/deployments","created_at":"2012-10-22T22:12:16Z","updated_at":"2016-07-19T16:21:03Z","pushed_at":"2016-08-15T09:10:20Z","git_url":"git://github.com/ezyang/cabal.git","ssh_url":"git@github.com:ezyang/cabal.git","clone_url":"https://github.com/ezyang/cabal.git","svn_url":"https://github.com/ezyang/cabal","homepage":"http://haskell.org/cabal","size":23356,"stargazers_count":7,"watchers_count":7,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"haskell:master","ref":"master","sha":"c2c5d36b7f265acabff63dad9c917a343c7640dc","user":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"repo":{"id":3728161,"name":"cabal","full_name":"haskell/cabal","owner":{"login":"haskell","id":450574,"avatar_url":"https://avatars.githubusercontent.com/u/450574?v=3","gravatar_id":"","url":"https://api.github.com/users/haskell","html_url":"https://github.com/haskell","followers_url":"https://api.github.com/users/haskell/followers","following_url":"https://api.github.com/users/haskell/following{/other_user}","gists_url":"https://api.github.com/users/haskell/gists{/gist_id}","starred_url":"https://api.github.com/users/haskell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haskell/subscriptions","organizations_url":"https://api.github.com/users/haskell/orgs","repos_url":"https://api.github.com/users/haskell/repos","events_url":"https://api.github.com/users/haskell/events{/privacy}","received_events_url":"https://api.github.com/users/haskell/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/haskell/cabal","description":"Official upstream development repository for Cabal and cabal-install","fork":false,"url":"https://api.github.com/repos/haskell/cabal","forks_url":"https://api.github.com/repos/haskell/cabal/forks","keys_url":"https://api.github.com/repos/haskell/cabal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haskell/cabal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haskell/cabal/teams","hooks_url":"https://api.github.com/repos/haskell/cabal/hooks","issue_events_url":"https://api.github.com/repos/haskell/cabal/issues/events{/number}","events_url":"https://api.github.com/repos/haskell/cabal/events","assignees_url":"https://api.github.com/repos/haskell/cabal/assignees{/user}","branches_url":"https://api.github.com/repos/haskell/cabal/branches{/branch}","tags_url":"https://api.github.com/repos/haskell/cabal/tags","blobs_url":"https://api.github.com/repos/haskell/cabal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haskell/cabal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haskell/cabal/git/refs{/sha}","trees_url":"https://api.github.com/repos/haskell/cabal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haskell/cabal/statuses/{sha}","languages_url":"https://api.github.com/repos/haskell/cabal/languages","stargazers_url":"https://api.github.com/repos/haskell/cabal/stargazers","contributors_url":"https://api.github.com/repos/haskell/cabal/contributors","subscribers_url":"https://api.github.com/repos/haskell/cabal/subscribers","subscription_url":"https://api.github.com/repos/haskell/cabal/subscription","commits_url":"https://api.github.com/repos/haskell/cabal/commits{/sha}","git_commits_url":"https://api.github.com/repos/haskell/cabal/git/commits{/sha}","comments_url":"https://api.github.com/repos/haskell/cabal/comments{/number}","issue_comment_url":"https://api.github.com/repos/haskell/cabal/issues/comments{/number}","contents_url":"https://api.github.com/repos/haskell/cabal/contents/{+path}","compare_url":"https://api.github.com/repos/haskell/cabal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haskell/cabal/merges","archive_url":"https://api.github.com/repos/haskell/cabal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haskell/cabal/downloads","issues_url":"https://api.github.com/repos/haskell/cabal/issues{/number}","pulls_url":"https://api.github.com/repos/haskell/cabal/pulls{/number}","milestones_url":"https://api.github.com/repos/haskell/cabal/milestones{/number}","notifications_url":"https://api.github.com/repos/haskell/cabal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haskell/cabal/labels{/name}","releases_url":"https://api.github.com/repos/haskell/cabal/releases{/id}","deployments_url":"https://api.github.com/repos/haskell/cabal/deployments","created_at":"2012-03-15T12:53:38Z","updated_at":"2016-08-10T21:23:12Z","pushed_at":"2016-08-15T09:18:52Z","git_url":"git://github.com/haskell/cabal.git","ssh_url":"git@github.com:haskell/cabal.git","clone_url":"https://github.com/haskell/cabal.git","svn_url":"https://github.com/haskell/cabal","homepage":"http://haskell.org/cabal","size":31737,"stargazers_count":630,"watchers_count":630,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"open_issues_count":755,"forks":334,"open_issues":755,"watchers":630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3662"},"html":{"href":"https://github.com/haskell/cabal/pull/3662"},"issue":{"href":"https://api.github.com/repos/haskell/cabal/issues/3662"},"comments":{"href":"https://api.github.com/repos/haskell/cabal/issues/3662/comments"},"review_comments":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3662/comments"},"review_comment":{"href":"https://api.github.com/repos/haskell/cabal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/haskell/cabal/pulls/3662/commits"},"statuses":{"href":"https://api.github.com/repos/haskell/cabal/statuses/b0b548971643ea11f2c9c33caae0f7efe89811a9"}}}}
{"actor":{"display_login":"dcoutts"}}