{"action":"created","comment":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/69467432","id":69467432,"diff_hunk":"@@ -25,11 +24,11 @@\n public interface CredentialsService {\n \n     /**\n-     * Get the credentials for the given servlet request\n+     * Get the credentials for the given request\n      *\n-     * @param request the servlet request\n+     * @param request the request\n      * @return the JCR credentials for the given request\n      */\n-    Credentials getCredentials(final HttpServletRequest request);\n+    Credentials getCredentials(final Object request);","path":"fcrepo-kernel-api/src/main/java/org/fcrepo/kernel/api/services/CredentialsService.java","position":20,"original_position":20,"commit_id":"dab74947de41a19063b0024cee981a12f6bd849c","original_commit_id":"dab74947de41a19063b0024cee981a12f6bd849c","user":{"login":"ajs6f","id":110994,"avatar_url":"https://avatars.githubusercontent.com/u/110994?v=3","gravatar_id":"","url":"https://api.github.com/users/ajs6f","html_url":"https://github.com/ajs6f","followers_url":"https://api.github.com/users/ajs6f/followers","following_url":"https://api.github.com/users/ajs6f/following{/other_user}","gists_url":"https://api.github.com/users/ajs6f/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs6f/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs6f/subscriptions","organizations_url":"https://api.github.com/users/ajs6f/orgs","repos_url":"https://api.github.com/users/ajs6f/repos","events_url":"https://api.github.com/users/ajs6f/events{/privacy}","received_events_url":"https://api.github.com/users/ajs6f/received_events","type":"User","site_admin":false},"body":"I have no objection-- just wanted to make sure I understood the move correctly. This is better than what we have and blocks no future moves to get even better, so 👍 .","created_at":"2016-07-04T14:44:55Z","updated_at":"2016-07-04T14:44:55Z","html_url":"https://github.com/fcrepo4/fcrepo4/pull/1061#discussion_r69467432","pull_request_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061","_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments/69467432"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1061#discussion_r69467432"},"pull_request":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061"}}},"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061","id":76146111,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/1061","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/1061.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/1061.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1061","number":1061,"state":"open","locked":false,"title":"Remove fcrepo-kernel-api dependency on javax.servlet.http package","user":{"login":"acoburn","id":1265883,"avatar_url":"https://avatars.githubusercontent.com/u/1265883?v=3","gravatar_id":"","url":"https://api.github.com/users/acoburn","html_url":"https://github.com/acoburn","followers_url":"https://api.github.com/users/acoburn/followers","following_url":"https://api.github.com/users/acoburn/following{/other_user}","gists_url":"https://api.github.com/users/acoburn/gists{/gist_id}","starred_url":"https://api.github.com/users/acoburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoburn/subscriptions","organizations_url":"https://api.github.com/users/acoburn/orgs","repos_url":"https://api.github.com/users/acoburn/repos","events_url":"https://api.github.com/users/acoburn/events{/privacy}","received_events_url":"https://api.github.com/users/acoburn/received_events","type":"User","site_admin":false},"body":"Addresses: https://jira.duraspace.org/browse/FCREPO-1664\r\n\r\n`javax.jcr.Credentials` is just a marker class, and as such it there is no need for it to make `fcrepo-kernel-api` depend on `javax.servlet.http`. (Modeshape _does_ require a dependency on `javax.servlet.http`, but this PR isolates that dependency in the `fcrepo-kernel-modeshape` module).","created_at":"2016-07-04T10:55:32Z","updated_at":"2016-07-04T14:44:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e04aacb8a8a123e777f8ffd712f98eca7b3a578e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1061/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/dab74947de41a19063b0024cee981a12f6bd849c","head":{"label":"acoburn:fcrepo-1664.2","ref":"fcrepo-1664.2","sha":"dab74947de41a19063b0024cee981a12f6bd849c","user":{"login":"acoburn","id":1265883,"avatar_url":"https://avatars.githubusercontent.com/u/1265883?v=3","gravatar_id":"","url":"https://api.github.com/users/acoburn","html_url":"https://github.com/acoburn","followers_url":"https://api.github.com/users/acoburn/followers","following_url":"https://api.github.com/users/acoburn/following{/other_user}","gists_url":"https://api.github.com/users/acoburn/gists{/gist_id}","starred_url":"https://api.github.com/users/acoburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoburn/subscriptions","organizations_url":"https://api.github.com/users/acoburn/orgs","repos_url":"https://api.github.com/users/acoburn/repos","events_url":"https://api.github.com/users/acoburn/events{/privacy}","received_events_url":"https://api.github.com/users/acoburn/received_events","type":"User","site_admin":false},"repo":{"id":25535833,"name":"fcrepo4","full_name":"acoburn/fcrepo4","owner":{"login":"acoburn","id":1265883,"avatar_url":"https://avatars.githubusercontent.com/u/1265883?v=3","gravatar_id":"","url":"https://api.github.com/users/acoburn","html_url":"https://github.com/acoburn","followers_url":"https://api.github.com/users/acoburn/followers","following_url":"https://api.github.com/users/acoburn/following{/other_user}","gists_url":"https://api.github.com/users/acoburn/gists{/gist_id}","starred_url":"https://api.github.com/users/acoburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acoburn/subscriptions","organizations_url":"https://api.github.com/users/acoburn/orgs","repos_url":"https://api.github.com/users/acoburn/repos","events_url":"https://api.github.com/users/acoburn/events{/privacy}","received_events_url":"https://api.github.com/users/acoburn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acoburn/fcrepo4","description":"Fedora 4","fork":true,"url":"https://api.github.com/repos/acoburn/fcrepo4","forks_url":"https://api.github.com/repos/acoburn/fcrepo4/forks","keys_url":"https://api.github.com/repos/acoburn/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acoburn/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acoburn/fcrepo4/teams","hooks_url":"https://api.github.com/repos/acoburn/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/acoburn/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/acoburn/fcrepo4/events","assignees_url":"https://api.github.com/repos/acoburn/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/acoburn/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/acoburn/fcrepo4/tags","blobs_url":"https://api.github.com/repos/acoburn/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acoburn/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acoburn/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/acoburn/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acoburn/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/acoburn/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/acoburn/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/acoburn/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/acoburn/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/acoburn/fcrepo4/subscription","commits_url":"https://api.github.com/repos/acoburn/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/acoburn/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/acoburn/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/acoburn/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/acoburn/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/acoburn/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acoburn/fcrepo4/merges","archive_url":"https://api.github.com/repos/acoburn/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acoburn/fcrepo4/downloads","issues_url":"https://api.github.com/repos/acoburn/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/acoburn/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/acoburn/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/acoburn/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acoburn/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/acoburn/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/acoburn/fcrepo4/deployments","created_at":"2014-10-21T17:27:47Z","updated_at":"2016-03-14T20:05:55Z","pushed_at":"2016-07-04T11:01:10Z","git_url":"git://github.com/acoburn/fcrepo4.git","ssh_url":"git@github.com:acoburn/fcrepo4.git","clone_url":"https://github.com/acoburn/fcrepo4.git","svn_url":"https://github.com/acoburn/fcrepo4","homepage":"http://github.com/fcrepo4/fcrepo4","size":14491,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"a762a627eb5dba812de033900bfbc6d241573780","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars.githubusercontent.com/u/3057565?v=3","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/deployments","created_at":"2013-02-03T16:18:55Z","updated_at":"2016-06-21T14:55:55Z","pushed_at":"2016-07-04T11:01:11Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"https://wiki.duraspace.org/display/FF/Fedora+Repository+Home","size":139951,"stargazers_count":65,"watchers_count":65,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":84,"mirror_url":null,"open_issues_count":30,"forks":84,"open_issues":30,"watchers":65,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1061"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1061"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1061/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1061/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/dab74947de41a19063b0024cee981a12f6bd849c"}}}}
{"actor":{"display_login":"ajs6f"}}