{"action":"closed","number":477,"pull_request":{"url":"https://api.github.com/repos/JasperFx/marten/pulls/477","id":80740429,"html_url":"https://github.com/JasperFx/marten/pull/477","diff_url":"https://github.com/JasperFx/marten/pull/477.diff","patch_url":"https://github.com/JasperFx/marten/pull/477.patch","issue_url":"https://api.github.com/repos/JasperFx/marten/issues/477","number":477,"state":"closed","locked":false,"title":"Small fixes for Fetcher","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"- Fetcher assigns EventTypeNames property\r\n- Removed unnecessary awaits\r\n- Fixed continuation bug for logger which would run when proxy is completed\r\n\r\n`Task.Factory.StartNew `with an async lambda will return a proxy task of type `Task<Task>`. This means the continuation would run immediately since the proxy task is completed before the inner task is completed. The simplest solution in the case we have here is to use `Task.Run` since the long-running flag is more harmful than helpful with async lambdas. \r\n\r\nhttp://blog.i3arnon.com/2015/07/02/task-run-long-running/\r\n\r\nI decided to hint the scheduler that the continuation can run synchronously (on the transition of the antecedent task to completed, reusing the worker thread) since I think for logging we don't need to reschedule a task. Thoughts?","created_at":"2016-08-10T06:24:00Z","updated_at":"2016-08-10T11:18:28Z","closed_at":"2016-08-10T11:18:27Z","merged_at":"2016-08-10T11:18:27Z","merge_commit_sha":"ae222c815bea6f882947b44a9a838f383d88f1f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JasperFx/marten/pulls/477/commits","review_comments_url":"https://api.github.com/repos/JasperFx/marten/pulls/477/comments","review_comment_url":"https://api.github.com/repos/JasperFx/marten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JasperFx/marten/issues/477/comments","statuses_url":"https://api.github.com/repos/JasperFx/marten/statuses/4d14df7e591edce2684b6882ed75af03f75cd830","head":{"label":"danielmarbach:Fetcher","ref":"Fetcher","sha":"4d14df7e591edce2684b6882ed75af03f75cd830","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"repo":{"id":50645184,"name":"marten","full_name":"danielmarbach/marten","owner":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielmarbach/marten","description":"Postgresql as a Document Database and Event Store for .Net Applications","fork":true,"url":"https://api.github.com/repos/danielmarbach/marten","forks_url":"https://api.github.com/repos/danielmarbach/marten/forks","keys_url":"https://api.github.com/repos/danielmarbach/marten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielmarbach/marten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielmarbach/marten/teams","hooks_url":"https://api.github.com/repos/danielmarbach/marten/hooks","issue_events_url":"https://api.github.com/repos/danielmarbach/marten/issues/events{/number}","events_url":"https://api.github.com/repos/danielmarbach/marten/events","assignees_url":"https://api.github.com/repos/danielmarbach/marten/assignees{/user}","branches_url":"https://api.github.com/repos/danielmarbach/marten/branches{/branch}","tags_url":"https://api.github.com/repos/danielmarbach/marten/tags","blobs_url":"https://api.github.com/repos/danielmarbach/marten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielmarbach/marten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielmarbach/marten/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielmarbach/marten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielmarbach/marten/statuses/{sha}","languages_url":"https://api.github.com/repos/danielmarbach/marten/languages","stargazers_url":"https://api.github.com/repos/danielmarbach/marten/stargazers","contributors_url":"https://api.github.com/repos/danielmarbach/marten/contributors","subscribers_url":"https://api.github.com/repos/danielmarbach/marten/subscribers","subscription_url":"https://api.github.com/repos/danielmarbach/marten/subscription","commits_url":"https://api.github.com/repos/danielmarbach/marten/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielmarbach/marten/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielmarbach/marten/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielmarbach/marten/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielmarbach/marten/contents/{+path}","compare_url":"https://api.github.com/repos/danielmarbach/marten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielmarbach/marten/merges","archive_url":"https://api.github.com/repos/danielmarbach/marten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielmarbach/marten/downloads","issues_url":"https://api.github.com/repos/danielmarbach/marten/issues{/number}","pulls_url":"https://api.github.com/repos/danielmarbach/marten/pulls{/number}","milestones_url":"https://api.github.com/repos/danielmarbach/marten/milestones{/number}","notifications_url":"https://api.github.com/repos/danielmarbach/marten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielmarbach/marten/labels{/name}","releases_url":"https://api.github.com/repos/danielmarbach/marten/releases{/id}","deployments_url":"https://api.github.com/repos/danielmarbach/marten/deployments","created_at":"2016-01-29T07:11:25Z","updated_at":"2016-01-29T07:11:26Z","pushed_at":"2016-08-10T06:58:15Z","git_url":"git://github.com/danielmarbach/marten.git","ssh_url":"git@github.com:danielmarbach/marten.git","clone_url":"https://github.com/danielmarbach/marten.git","svn_url":"https://github.com/danielmarbach/marten","homepage":"http://jasperfx.github.io/marten","size":11820,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JasperFx:master","ref":"master","sha":"eb59c8068930dbeeed6468d84855fb082ca8dbcc","user":{"login":"JasperFx","id":10048186,"avatar_url":"https://avatars.githubusercontent.com/u/10048186?v=3","gravatar_id":"","url":"https://api.github.com/users/JasperFx","html_url":"https://github.com/JasperFx","followers_url":"https://api.github.com/users/JasperFx/followers","following_url":"https://api.github.com/users/JasperFx/following{/other_user}","gists_url":"https://api.github.com/users/JasperFx/gists{/gist_id}","starred_url":"https://api.github.com/users/JasperFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasperFx/subscriptions","organizations_url":"https://api.github.com/users/JasperFx/orgs","repos_url":"https://api.github.com/users/JasperFx/repos","events_url":"https://api.github.com/users/JasperFx/events{/privacy}","received_events_url":"https://api.github.com/users/JasperFx/received_events","type":"Organization","site_admin":false},"repo":{"id":44125268,"name":"marten","full_name":"JasperFx/marten","owner":{"login":"JasperFx","id":10048186,"avatar_url":"https://avatars.githubusercontent.com/u/10048186?v=3","gravatar_id":"","url":"https://api.github.com/users/JasperFx","html_url":"https://github.com/JasperFx","followers_url":"https://api.github.com/users/JasperFx/followers","following_url":"https://api.github.com/users/JasperFx/following{/other_user}","gists_url":"https://api.github.com/users/JasperFx/gists{/gist_id}","starred_url":"https://api.github.com/users/JasperFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasperFx/subscriptions","organizations_url":"https://api.github.com/users/JasperFx/orgs","repos_url":"https://api.github.com/users/JasperFx/repos","events_url":"https://api.github.com/users/JasperFx/events{/privacy}","received_events_url":"https://api.github.com/users/JasperFx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JasperFx/marten","description":"Postgresql as a Document Database and Event Store for .Net Applications","fork":false,"url":"https://api.github.com/repos/JasperFx/marten","forks_url":"https://api.github.com/repos/JasperFx/marten/forks","keys_url":"https://api.github.com/repos/JasperFx/marten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JasperFx/marten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JasperFx/marten/teams","hooks_url":"https://api.github.com/repos/JasperFx/marten/hooks","issue_events_url":"https://api.github.com/repos/JasperFx/marten/issues/events{/number}","events_url":"https://api.github.com/repos/JasperFx/marten/events","assignees_url":"https://api.github.com/repos/JasperFx/marten/assignees{/user}","branches_url":"https://api.github.com/repos/JasperFx/marten/branches{/branch}","tags_url":"https://api.github.com/repos/JasperFx/marten/tags","blobs_url":"https://api.github.com/repos/JasperFx/marten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JasperFx/marten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JasperFx/marten/git/refs{/sha}","trees_url":"https://api.github.com/repos/JasperFx/marten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JasperFx/marten/statuses/{sha}","languages_url":"https://api.github.com/repos/JasperFx/marten/languages","stargazers_url":"https://api.github.com/repos/JasperFx/marten/stargazers","contributors_url":"https://api.github.com/repos/JasperFx/marten/contributors","subscribers_url":"https://api.github.com/repos/JasperFx/marten/subscribers","subscription_url":"https://api.github.com/repos/JasperFx/marten/subscription","commits_url":"https://api.github.com/repos/JasperFx/marten/commits{/sha}","git_commits_url":"https://api.github.com/repos/JasperFx/marten/git/commits{/sha}","comments_url":"https://api.github.com/repos/JasperFx/marten/comments{/number}","issue_comment_url":"https://api.github.com/repos/JasperFx/marten/issues/comments{/number}","contents_url":"https://api.github.com/repos/JasperFx/marten/contents/{+path}","compare_url":"https://api.github.com/repos/JasperFx/marten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JasperFx/marten/merges","archive_url":"https://api.github.com/repos/JasperFx/marten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JasperFx/marten/downloads","issues_url":"https://api.github.com/repos/JasperFx/marten/issues{/number}","pulls_url":"https://api.github.com/repos/JasperFx/marten/pulls{/number}","milestones_url":"https://api.github.com/repos/JasperFx/marten/milestones{/number}","notifications_url":"https://api.github.com/repos/JasperFx/marten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JasperFx/marten/labels{/name}","releases_url":"https://api.github.com/repos/JasperFx/marten/releases{/id}","deployments_url":"https://api.github.com/repos/JasperFx/marten/deployments","created_at":"2015-10-12T18:11:12Z","updated_at":"2016-08-09T13:01:50Z","pushed_at":"2016-08-10T11:18:27Z","git_url":"git://github.com/JasperFx/marten.git","ssh_url":"git@github.com:JasperFx/marten.git","clone_url":"https://github.com/JasperFx/marten.git","svn_url":"https://github.com/JasperFx/marten","homepage":"http://jasperfx.github.io/marten","size":12213,"stargazers_count":290,"watchers_count":290,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":69,"mirror_url":null,"open_issues_count":27,"forks":69,"open_issues":27,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JasperFx/marten/pulls/477"},"html":{"href":"https://github.com/JasperFx/marten/pull/477"},"issue":{"href":"https://api.github.com/repos/JasperFx/marten/issues/477"},"comments":{"href":"https://api.github.com/repos/JasperFx/marten/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/JasperFx/marten/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/JasperFx/marten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JasperFx/marten/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/JasperFx/marten/statuses/4d14df7e591edce2684b6882ed75af03f75cd830"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jeremydmiller","id":179211,"avatar_url":"https://avatars.githubusercontent.com/u/179211?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremydmiller","html_url":"https://github.com/jeremydmiller","followers_url":"https://api.github.com/users/jeremydmiller/followers","following_url":"https://api.github.com/users/jeremydmiller/following{/other_user}","gists_url":"https://api.github.com/users/jeremydmiller/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremydmiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremydmiller/subscriptions","organizations_url":"https://api.github.com/users/jeremydmiller/orgs","repos_url":"https://api.github.com/users/jeremydmiller/repos","events_url":"https://api.github.com/users/jeremydmiller/events{/privacy}","received_events_url":"https://api.github.com/users/jeremydmiller/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":11,"deletions":18,"changed_files":2}}
{"actor":{"display_login":"jeremydmiller"}}