{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/rr/issues/1757","repository_url":"https://api.github.com/repos/mozilla/rr","labels_url":"https://api.github.com/repos/mozilla/rr/issues/1757/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/rr/issues/1757/comments","events_url":"https://api.github.com/repos/mozilla/rr/issues/1757/events","html_url":"https://github.com/mozilla/rr/pull/1757","id":166101301,"number":1757,"title":"Support qGetTLSAddr","user":{"login":"tromey","id":1557670,"avatar_url":"https://avatars.githubusercontent.com/u/1557670?v=3","gravatar_id":"","url":"https://api.github.com/users/tromey","html_url":"https://github.com/tromey","followers_url":"https://api.github.com/users/tromey/followers","following_url":"https://api.github.com/users/tromey/following{/other_user}","gists_url":"https://api.github.com/users/tromey/gists{/gist_id}","starred_url":"https://api.github.com/users/tromey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tromey/subscriptions","organizations_url":"https://api.github.com/users/tromey/orgs","repos_url":"https://api.github.com/users/tromey/repos","events_url":"https://api.github.com/users/tromey/events{/privacy}","received_events_url":"https://api.github.com/users/tromey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2016-07-18T14:05:20Z","updated_at":"2016-07-21T07:02:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/rr/pulls/1757","html_url":"https://github.com/mozilla/rr/pull/1757","diff_url":"https://github.com/mozilla/rr/pull/1757.diff","patch_url":"https://github.com/mozilla/rr/pull/1757.patch"},"body":"Fixes #146.\r\n\r\nThis adds support for the qGetTLSAddr and qSymbol packets from gdb,\r\nwhich lets gdb access TLS in a replay."},"comment":{"url":"https://api.github.com/repos/mozilla/rr/issues/comments/234173383","html_url":"https://github.com/mozilla/rr/pull/1757#issuecomment-234173383","issue_url":"https://api.github.com/repos/mozilla/rr/issues/1757","id":234173383,"user":{"login":"rocallahan","id":296135,"avatar_url":"https://avatars.githubusercontent.com/u/296135?v=3","gravatar_id":"","url":"https://api.github.com/users/rocallahan","html_url":"https://github.com/rocallahan","followers_url":"https://api.github.com/users/rocallahan/followers","following_url":"https://api.github.com/users/rocallahan/following{/other_user}","gists_url":"https://api.github.com/users/rocallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/rocallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocallahan/subscriptions","organizations_url":"https://api.github.com/users/rocallahan/orgs","repos_url":"https://api.github.com/users/rocallahan/repos","events_url":"https://api.github.com/users/rocallahan/events{/privacy}","received_events_url":"https://api.github.com/users/rocallahan/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T07:02:06Z","updated_at":"2016-07-21T07:02:06Z","body":"This is basically looking good. The major issue remaining is this confusion about whether libthreaddb should see recorded-tids or real-tids. My instinct is that it should always see recorded-tids, in which case a few places need to be changed. E.g. the call to `ThreadDb::get_tls_address` from `Task` needs to pass `rec_tid`."}}
{"actor":{"display_login":"rocallahan"}}