{"push_id":954608402,"size":14,"distinct_size":1,"ref":"refs/heads/attribute_translation_in_adjustment_forms","head":"d25178c880bac7f3a778daf6850d364ffdde394b","before":"fc3e9bcd903a0549ff9d223909875b65e120d13a","commits":[{"sha":"0d4f1703c848dca9e0c14c65de6610228beefced","author":{"email":"5e1c0d6f8a0b550386d5f8342017b9898399fe26@gmail.com","name":"John Hawthorn"},"message":"Remove unnecessary data-update attributes\n\nThe code that used this was removed in 2011 in favour of standard rails\nujs. See 1182daf6e280da87937cb2a44af358462073f728\n\nNB. data-update is still used by the States interface in the admin, but\nthat is different code that is only activated there.","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/0d4f1703c848dca9e0c14c65de6610228beefced"},{"sha":"b0924e6045f0c6235b5780d7c1825c2d8bd3c882","author":{"email":"5e1c0d6f8a0b550386d5f8342017b9898399fe26@gmail.com","name":"John Hawthorn"},"message":"Simplify Order#to_param\n\nThe existing to_param called .to_s.to_url.upcase, however when order is\nfound by an incoming param find_by_number is always used. Therefore\nto_param must always match number exactly. For the default number\ngeneration this was always already the case.\n\nThis makes Order#to_param significantly faster.\n\nCalculating -------------------------------------\n        order.number    42.199k i/100ms\norder.number.to_s.to_url.upcase\n                       176.000  i/100ms\n-------------------------------------------------\n        order.number      2.155M (± 0.7%) i/s -     10.803M\norder.number.to_s.to_url.upcase\n                          1.851k (±14.3%) i/s -      9.152k","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/b0924e6045f0c6235b5780d7c1825c2d8bd3c882"},{"sha":"059d9622dbccec0dbaedb2d78bf3324832d67500","author":{"email":"66b786d87fe61c302608dae75b683f7e919f1bf9@freerunningtechnologies.com","name":"Clarke Brunsdon"},"message":"Group admin payment spec by action\n\nPreviously the actions were not well separated and it was hard to tell\nwhat was testing what.","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/059d9622dbccec0dbaedb2d78bf3324832d67500"},{"sha":"ae88966029b2958ed47a9281196444f434771ef1","author":{"email":"5e1c0d6f8a0b550386d5f8342017b9898399fe26@gmail.com","name":"John Hawthorn"},"message":"Merge pull request #738 from jhawthorn/order_to_param\n\nSimplify Order#to_param","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/ae88966029b2958ed47a9281196444f434771ef1"},{"sha":"905cb5ce8fcc6e4c9bf14c229aa4b9ccacae3b0e","author":{"email":"5e1c0d6f8a0b550386d5f8342017b9898399fe26@gmail.com","name":"John Hawthorn"},"message":"Merge pull request #737 from jhawthorn/data-update\n\nRemove unnecessary data-update attributes","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/905cb5ce8fcc6e4c9bf14c229aa4b9ccacae3b0e"},{"sha":"88f2f96346b0c6a4f7ca4eee23b1425f327009b4","author":{"email":"5e1c0d6f8a0b550386d5f8342017b9898399fe26@gmail.com","name":"John Hawthorn"},"message":"Merge pull request #742 from StemboltHQ/admin_payment_spec_grouping\n\nGroup admin payment spec by action","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/88f2f96346b0c6a4f7ca4eee23b1425f327009b4"},{"sha":"aa27528146b41c0df7867c34e4e4b42eb69dbff8","author":{"email":"a51dda7c7ff50b61eaea0444371f4a6a9301e501@stembolt.com","name":"John Hawthorn"},"message":"Don't automatically add javascripts to dummy app\n\nLIB_NAME is used in the install generator when we are creating the\nspec/dummy app in an extension. Previously it added includes for\nfiles like `spree/backend/$LIB_NAME.js` whether or not they existed.\n\nUnfortunately, as of sprockets-rails 3.0, that will cause an exception\neven if that section (backend/frontend) of solidus isn't visited.\n\nIf that file is needed for the extension to run, it should be added by\nthe extension's own install generator. Most extensions already do this\nand won't be broken by this change.","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/aa27528146b41c0df7867c34e4e4b42eb69dbff8"},{"sha":"ccfd595a9a263353efda5954dec20ecaff008bf3","author":{"email":"5e1c0d6f8a0b550386d5f8342017b9898399fe26@gmail.com","name":"John Hawthorn"},"message":"Merge pull request #744 from jhawthorn/dummy_lib_name\n\nDon't automatically add javascripts to dummy apps in extesions","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/ccfd595a9a263353efda5954dec20ecaff008bf3"},{"sha":"8fbdb63dcd8f31ddcf88a3e819a800f711752d21","author":{"email":"a51dda7c7ff50b61eaea0444371f4a6a9301e501@stembolt.com","name":"John Hawthorn"},"message":"Fix (very, very unlikely) spurious test failure\n\nIt is perfectly valid for to have an address book with id=42. This\nchanges that magic value to 0, which is never a valid id.","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/8fbdb63dcd8f31ddcf88a3e819a800f711752d21"},{"sha":"c5ab7228abf83931337c9144129b235f7eaa6b06","author":{"email":"a51dda7c7ff50b61eaea0444371f4a6a9301e501@stembolt.com","name":"John Hawthorn"},"message":"Use <label class=\"required\"> instead of extra span\n\nThere are a few advantages to this.\n\nPreviously there was a mix of <span class=\"required\"> inside and outside\nof the label. It's now consistent.\n\nWhen the span and text was inside of the label, capybara would consider\nit part of the text of the label. Now it is considered presentation and\nnot part of the label's text. This required changing one spec which had\nfill_in \"NAME *\".\n\nWhen the span and text were outside of the label, clicking the span did\nnot focus the input field. It now does, because the label is the parent\nelement and the click will bubble up.\n\nHow we display a required attribute is a style concern. If we change our\nmind about the way a required attribute's label should work we can now\nchange it everywhere from our CSS.\n\nThis is also much shorter and easier to type in a view.","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/c5ab7228abf83931337c9144129b235f7eaa6b06"},{"sha":"b57f97172de7dc7ea13e1d4c12a00ef50d50298d","author":{"email":"a51dda7c7ff50b61eaea0444371f4a6a9301e501@stembolt.com","name":"John Hawthorn"},"message":"Make form example in style_guide required","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/b57f97172de7dc7ea13e1d4c12a00ef50d50298d"},{"sha":"14cea004afb6f4e481d923c382103af7bc56b044","author":{"email":"66b786d87fe61c302608dae75b683f7e919f1bf9@stembolt.com","name":"Clarke Brunsdon"},"message":"Merge pull request #755 from jhawthorn/label_required\n\nUse <label class=\"required\"> instead of extra span","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/14cea004afb6f4e481d923c382103af7bc56b044"},{"sha":"dcbe157c7236fdc224bdf527562d41b0318fcac0","author":{"email":"66b786d87fe61c302608dae75b683f7e919f1bf9@stembolt.com","name":"Clarke Brunsdon"},"message":"Merge pull request #754 from jhawthorn/answer_to_life_the_univese_and_everything_also_a_primary_key\n\nFix (very, very unlikely) spurious test failure","distinct":false,"url":"https://api.github.com/repos/Murph33/solidus/commits/dcbe157c7236fdc224bdf527562d41b0318fcac0"},{"sha":"d25178c880bac7f3a778daf6850d364ffdde394b","author":{"email":"59a79bc2a1e4a294ac6e78e1549971217f68d636@magiclabs.de","name":"Thomas von Deyen"},"message":"Uses attribute translations in adjustments forms\n\nChange-Id: I1afb74c3fdf137e699874d802276bcf3ad151b06","distinct":true,"url":"https://api.github.com/repos/Murph33/solidus/commits/d25178c880bac7f3a778daf6850d364ffdde394b"}]}