{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleChrome/gulliver/issues/81","repository_url":"https://api.github.com/repos/GoogleChrome/gulliver","labels_url":"https://api.github.com/repos/GoogleChrome/gulliver/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/GoogleChrome/gulliver/issues/81/comments","events_url":"https://api.github.com/repos/GoogleChrome/gulliver/issues/81/events","html_url":"https://github.com/GoogleChrome/gulliver/issues/81","id":173431978,"number":81,"title":"Distinguish between missing keys and datastore errors","user":{"login":"ithinkihaveacat","id":51244,"avatar_url":"https://avatars.githubusercontent.com/u/51244?v=3","gravatar_id":"","url":"https://api.github.com/users/ithinkihaveacat","html_url":"https://github.com/ithinkihaveacat","followers_url":"https://api.github.com/users/ithinkihaveacat/followers","following_url":"https://api.github.com/users/ithinkihaveacat/following{/other_user}","gists_url":"https://api.github.com/users/ithinkihaveacat/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinkihaveacat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinkihaveacat/subscriptions","organizations_url":"https://api.github.com/users/ithinkihaveacat/orgs","repos_url":"https://api.github.com/users/ithinkihaveacat/repos","events_url":"https://api.github.com/users/ithinkihaveacat/events{/privacy}","received_events_url":"https://api.github.com/users/ithinkihaveacat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-08-26T11:29:23Z","updated_at":"2016-08-26T11:33:37Z","closed_at":null,"body":"https://github.com/GoogleChrome/gulliver/blob/master/controllers/pwas/crud.js#L138 assumes that database errors are really more \"expected\" errors like PWAs that can't be found in the datastore. We should distinguish between these two states at a much lower level, such as somewhere within https://github.com/GoogleChrome/gulliver/blob/master/lib/model-datastore.js#L175, so that we can return a 500 or similar for server errors, and 404s for missing PWAs."},"comment":{"url":"https://api.github.com/repos/GoogleChrome/gulliver/issues/comments/242709525","html_url":"https://github.com/GoogleChrome/gulliver/issues/81#issuecomment-242709525","issue_url":"https://api.github.com/repos/GoogleChrome/gulliver/issues/81","id":242709525,"user":{"login":"andreban","id":1733592,"avatar_url":"https://avatars.githubusercontent.com/u/1733592?v=3","gravatar_id":"","url":"https://api.github.com/users/andreban","html_url":"https://github.com/andreban","followers_url":"https://api.github.com/users/andreban/followers","following_url":"https://api.github.com/users/andreban/following{/other_user}","gists_url":"https://api.github.com/users/andreban/gists{/gist_id}","starred_url":"https://api.github.com/users/andreban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreban/subscriptions","organizations_url":"https://api.github.com/users/andreban/orgs","repos_url":"https://api.github.com/users/andreban/repos","events_url":"https://api.github.com/users/andreban/events{/privacy}","received_events_url":"https://api.github.com/users/andreban/received_events","type":"User","site_admin":false},"created_at":"2016-08-26T11:33:37Z","updated_at":"2016-08-26T11:33:37Z","body":"should find just return `resolve(null)` when it's a miss and `reject(err)` when it's an error?"}}
{"actor":{"display_login":"andreban"}}