{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/78214242","id":78214242,"diff_hunk":"@@ -0,0 +1,87 @@\n+const DEFAULT_OPTIONS = {","path":"common/ReduxChannel.js","position":1,"original_position":1,"commit_id":"a16b317189150643318f8642e7d6675f2d88ff94","original_commit_id":"a16b317189150643318f8642e7d6675f2d88ff94","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"This is just moved over from `content-src`, with one change (had to check existence of `window` so it doesn't throw)","created_at":"2016-09-09T17:05:17Z","updated_at":"2016-09-09T17:05:17Z","html_url":"https://github.com/mozilla/activity-stream/pull/1243#discussion_r78214242","pull_request_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243","_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments/78214242"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/1243#discussion_r78214242"},"pull_request":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243","id":84521648,"html_url":"https://github.com/mozilla/activity-stream/pull/1243","diff_url":"https://github.com/mozilla/activity-stream/pull/1243.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/1243.patch","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1243","number":1243,"state":"open","locked":false,"title":"feat(redux): #1090 move store to common","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"body":"This PR moves our store logic from `content-src` to `common`. It includes:\r\n\r\n- a change from a store singleton to a store creator, which can be used both in addon and content\r\n- tests\r\n- replaces the redux logger, which depends on some console-specific stuff (that mostly looked bad in Firefox anyway) with a simple custom logger\r\n- an empty store in addon (will be filled in in future PRs)\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mozilla/activity-stream/1243)\n<!-- Reviewable:end -->\n","created_at":"2016-09-08T17:42:38Z","updated_at":"2016-09-09T17:05:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd034c0ff6da7f7aa6c189f7231fac3a56499a84","assignee":{"login":"sarracini","id":7219526,"avatar_url":"https://avatars.githubusercontent.com/u/7219526?v=3","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false},"assignees":[{"login":"sarracini","id":7219526,"avatar_url":"https://avatars.githubusercontent.com/u/7219526?v=3","gravatar_id":"","url":"https://api.github.com/users/sarracini","html_url":"https://github.com/sarracini","followers_url":"https://api.github.com/users/sarracini/followers","following_url":"https://api.github.com/users/sarracini/following{/other_user}","gists_url":"https://api.github.com/users/sarracini/gists{/gist_id}","starred_url":"https://api.github.com/users/sarracini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarracini/subscriptions","organizations_url":"https://api.github.com/users/sarracini/orgs","repos_url":"https://api.github.com/users/sarracini/repos","events_url":"https://api.github.com/users/sarracini/events{/privacy}","received_events_url":"https://api.github.com/users/sarracini/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243/commits","review_comments_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243/comments","review_comment_url":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/1243/comments","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/a16b317189150643318f8642e7d6675f2d88ff94","head":{"label":"k88hudson:gh1090-store-creator","ref":"gh1090-store-creator","sha":"a16b317189150643318f8642e7d6675f2d88ff94","user":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"repo":{"id":52153556,"name":"activity-stream","full_name":"k88hudson/activity-stream","owner":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k88hudson/activity-stream","description":" MVP prototype add-on for activity streams","fork":true,"url":"https://api.github.com/repos/k88hudson/activity-stream","forks_url":"https://api.github.com/repos/k88hudson/activity-stream/forks","keys_url":"https://api.github.com/repos/k88hudson/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k88hudson/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k88hudson/activity-stream/teams","hooks_url":"https://api.github.com/repos/k88hudson/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/k88hudson/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/k88hudson/activity-stream/events","assignees_url":"https://api.github.com/repos/k88hudson/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/k88hudson/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/k88hudson/activity-stream/tags","blobs_url":"https://api.github.com/repos/k88hudson/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k88hudson/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k88hudson/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/k88hudson/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k88hudson/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/k88hudson/activity-stream/languages","stargazers_url":"https://api.github.com/repos/k88hudson/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/k88hudson/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/k88hudson/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/k88hudson/activity-stream/subscription","commits_url":"https://api.github.com/repos/k88hudson/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/k88hudson/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/k88hudson/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/k88hudson/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/k88hudson/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/k88hudson/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k88hudson/activity-stream/merges","archive_url":"https://api.github.com/repos/k88hudson/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k88hudson/activity-stream/downloads","issues_url":"https://api.github.com/repos/k88hudson/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/k88hudson/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/k88hudson/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/k88hudson/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k88hudson/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/k88hudson/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/k88hudson/activity-stream/deployments","created_at":"2016-02-20T13:02:48Z","updated_at":"2016-05-10T16:02:20Z","pushed_at":"2016-09-08T18:36:16Z","git_url":"git://github.com/k88hudson/activity-stream.git","ssh_url":"git@github.com:k88hudson/activity-stream.git","clone_url":"https://github.com/k88hudson/activity-stream.git","svn_url":"https://github.com/k88hudson/activity-stream","homepage":"","size":2114,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"d1d6b77012199fb1bf6ba19fdae16262cf711ac8","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":50695589,"name":"activity-stream","full_name":"mozilla/activity-stream","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/activity-stream","description":" MVP prototype add-on for activity streams","fork":false,"url":"https://api.github.com/repos/mozilla/activity-stream","forks_url":"https://api.github.com/repos/mozilla/activity-stream/forks","keys_url":"https://api.github.com/repos/mozilla/activity-stream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/activity-stream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/activity-stream/teams","hooks_url":"https://api.github.com/repos/mozilla/activity-stream/hooks","issue_events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/activity-stream/events","assignees_url":"https://api.github.com/repos/mozilla/activity-stream/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/activity-stream/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/activity-stream/tags","blobs_url":"https://api.github.com/repos/mozilla/activity-stream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/activity-stream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/activity-stream/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/activity-stream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/activity-stream/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/activity-stream/languages","stargazers_url":"https://api.github.com/repos/mozilla/activity-stream/stargazers","contributors_url":"https://api.github.com/repos/mozilla/activity-stream/contributors","subscribers_url":"https://api.github.com/repos/mozilla/activity-stream/subscribers","subscription_url":"https://api.github.com/repos/mozilla/activity-stream/subscription","commits_url":"https://api.github.com/repos/mozilla/activity-stream/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/activity-stream/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/activity-stream/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/activity-stream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/activity-stream/merges","archive_url":"https://api.github.com/repos/mozilla/activity-stream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/activity-stream/downloads","issues_url":"https://api.github.com/repos/mozilla/activity-stream/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/activity-stream/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/activity-stream/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/activity-stream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/activity-stream/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/activity-stream/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/activity-stream/deployments","created_at":"2016-01-29T22:28:26Z","updated_at":"2016-09-01T04:51:13Z","pushed_at":"2016-09-09T15:56:10Z","git_url":"git://github.com/mozilla/activity-stream.git","ssh_url":"git@github.com:mozilla/activity-stream.git","clone_url":"https://github.com/mozilla/activity-stream.git","svn_url":"https://github.com/mozilla/activity-stream","homepage":"","size":2569,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":179,"forks":34,"open_issues":179,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243"},"html":{"href":"https://github.com/mozilla/activity-stream/pull/1243"},"issue":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/1243"},"comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/issues/1243/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/activity-stream/pulls/1243/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/activity-stream/statuses/a16b317189150643318f8642e7d6675f2d88ff94"}}}}
{"actor":{"display_login":"k88hudson"}}