{"action":"created","comment":{"url":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments/66612044","id":66612044,"diff_hunk":"@@ -0,0 +1,44 @@\n+use expression::predicates::*;\n+\n+#[cfg(feature = \"postgres\")]\n+pub trait Ordering : Sized {","path":"diesel/src/expression/expression_methods/sort_expression_methods.rs","position":4,"original_position":4,"commit_id":"2acdc815732022fa7fa195d5f67bb007b03194bf","original_commit_id":"2acdc815732022fa7fa195d5f67bb007b03194bf","user":{"login":"kaj","id":358770,"avatar_url":"https://avatars.githubusercontent.com/u/358770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaj","html_url":"https://github.com/kaj","followers_url":"https://api.github.com/users/kaj/followers","following_url":"https://api.github.com/users/kaj/following{/other_user}","gists_url":"https://api.github.com/users/kaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaj/subscriptions","organizations_url":"https://api.github.com/users/kaj/orgs","repos_url":"https://api.github.com/users/kaj/repos","events_url":"https://api.github.com/users/kaj/events{/privacy}","received_events_url":"https://api.github.com/users/kaj/received_events","type":"User","site_admin":false},"body":"I don't know.  I thought about it as a trait _on_ ordering, providing methods that work on orderings (it is implemented for Asc and Desc).  But maybe it should be thought of as a trait _for_ where to put the nulls, and in that case `NullsOrdering` (or something similar) is a better name.","created_at":"2016-06-10T13:26:17Z","updated_at":"2016-06-10T13:26:17Z","html_url":"https://github.com/diesel-rs/diesel/pull/351#discussion_r66612044","pull_request_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments/66612044"},"html":{"href":"https://github.com/diesel-rs/diesel/pull/351#discussion_r66612044"},"pull_request":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/351"}}},"pull_request":{"url":"https://api.github.com/repos/diesel-rs/diesel/pulls/351","id":73355497,"html_url":"https://github.com/diesel-rs/diesel/pull/351","diff_url":"https://github.com/diesel-rs/diesel/pull/351.diff","patch_url":"https://github.com/diesel-rs/diesel/pull/351.patch","issue_url":"https://api.github.com/repos/diesel-rs/diesel/issues/351","number":351,"state":"open","locked":false,"title":"Feature/desc nulls last","user":{"login":"kaj","id":358770,"avatar_url":"https://avatars.githubusercontent.com/u/358770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaj","html_url":"https://github.com/kaj","followers_url":"https://api.github.com/users/kaj/followers","following_url":"https://api.github.com/users/kaj/following{/other_user}","gists_url":"https://api.github.com/users/kaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaj/subscriptions","organizations_url":"https://api.github.com/users/kaj/orgs","repos_url":"https://api.github.com/users/kaj/repos","events_url":"https://api.github.com/users/kaj/events{/privacy}","received_events_url":"https://api.github.com/users/kaj/received_events","type":"User","site_admin":false},"body":"Add support for ordering with NULLS FIRST or NULLS LAST in postgres.\r\n\r\nMethods nulls_first() and nulls_last() can be applied to the result of the asc() and desc() sorting order methods.","created_at":"2016-06-10T10:55:12Z","updated_at":"2016-06-10T13:26:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"945fd244ce294f5552046da3a012c18eac07d4f9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/351/commits","review_comments_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/351/comments","review_comment_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diesel-rs/diesel/issues/351/comments","statuses_url":"https://api.github.com/repos/diesel-rs/diesel/statuses/2acdc815732022fa7fa195d5f67bb007b03194bf","head":{"label":"kaj:feature/desc_nulls_last","ref":"feature/desc_nulls_last","sha":"2acdc815732022fa7fa195d5f67bb007b03194bf","user":{"login":"kaj","id":358770,"avatar_url":"https://avatars.githubusercontent.com/u/358770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaj","html_url":"https://github.com/kaj","followers_url":"https://api.github.com/users/kaj/followers","following_url":"https://api.github.com/users/kaj/following{/other_user}","gists_url":"https://api.github.com/users/kaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaj/subscriptions","organizations_url":"https://api.github.com/users/kaj/orgs","repos_url":"https://api.github.com/users/kaj/repos","events_url":"https://api.github.com/users/kaj/events{/privacy}","received_events_url":"https://api.github.com/users/kaj/received_events","type":"User","site_admin":false},"repo":{"id":60632159,"name":"diesel","full_name":"kaj/diesel","owner":{"login":"kaj","id":358770,"avatar_url":"https://avatars.githubusercontent.com/u/358770?v=3","gravatar_id":"","url":"https://api.github.com/users/kaj","html_url":"https://github.com/kaj","followers_url":"https://api.github.com/users/kaj/followers","following_url":"https://api.github.com/users/kaj/following{/other_user}","gists_url":"https://api.github.com/users/kaj/gists{/gist_id}","starred_url":"https://api.github.com/users/kaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaj/subscriptions","organizations_url":"https://api.github.com/users/kaj/orgs","repos_url":"https://api.github.com/users/kaj/repos","events_url":"https://api.github.com/users/kaj/events{/privacy}","received_events_url":"https://api.github.com/users/kaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaj/diesel","description":"A safe, extensible ORM and Query Builder for Rust","fork":true,"url":"https://api.github.com/repos/kaj/diesel","forks_url":"https://api.github.com/repos/kaj/diesel/forks","keys_url":"https://api.github.com/repos/kaj/diesel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaj/diesel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaj/diesel/teams","hooks_url":"https://api.github.com/repos/kaj/diesel/hooks","issue_events_url":"https://api.github.com/repos/kaj/diesel/issues/events{/number}","events_url":"https://api.github.com/repos/kaj/diesel/events","assignees_url":"https://api.github.com/repos/kaj/diesel/assignees{/user}","branches_url":"https://api.github.com/repos/kaj/diesel/branches{/branch}","tags_url":"https://api.github.com/repos/kaj/diesel/tags","blobs_url":"https://api.github.com/repos/kaj/diesel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaj/diesel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaj/diesel/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaj/diesel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaj/diesel/statuses/{sha}","languages_url":"https://api.github.com/repos/kaj/diesel/languages","stargazers_url":"https://api.github.com/repos/kaj/diesel/stargazers","contributors_url":"https://api.github.com/repos/kaj/diesel/contributors","subscribers_url":"https://api.github.com/repos/kaj/diesel/subscribers","subscription_url":"https://api.github.com/repos/kaj/diesel/subscription","commits_url":"https://api.github.com/repos/kaj/diesel/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaj/diesel/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaj/diesel/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaj/diesel/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaj/diesel/contents/{+path}","compare_url":"https://api.github.com/repos/kaj/diesel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaj/diesel/merges","archive_url":"https://api.github.com/repos/kaj/diesel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaj/diesel/downloads","issues_url":"https://api.github.com/repos/kaj/diesel/issues{/number}","pulls_url":"https://api.github.com/repos/kaj/diesel/pulls{/number}","milestones_url":"https://api.github.com/repos/kaj/diesel/milestones{/number}","notifications_url":"https://api.github.com/repos/kaj/diesel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaj/diesel/labels{/name}","releases_url":"https://api.github.com/repos/kaj/diesel/releases{/id}","deployments_url":"https://api.github.com/repos/kaj/diesel/deployments","created_at":"2016-06-07T17:16:47Z","updated_at":"2016-06-07T17:16:49Z","pushed_at":"2016-06-10T10:51:54Z","git_url":"git://github.com/kaj/diesel.git","ssh_url":"git@github.com:kaj/diesel.git","clone_url":"https://github.com/kaj/diesel.git","svn_url":"https://github.com/kaj/diesel","homepage":"","size":5286,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diesel-rs:master","ref":"master","sha":"6be7a6cd7a59e6be09150479a9d37012a541a8b2","user":{"login":"diesel-rs","id":16763251,"avatar_url":"https://avatars.githubusercontent.com/u/16763251?v=3","gravatar_id":"","url":"https://api.github.com/users/diesel-rs","html_url":"https://github.com/diesel-rs","followers_url":"https://api.github.com/users/diesel-rs/followers","following_url":"https://api.github.com/users/diesel-rs/following{/other_user}","gists_url":"https://api.github.com/users/diesel-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/diesel-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesel-rs/subscriptions","organizations_url":"https://api.github.com/users/diesel-rs/orgs","repos_url":"https://api.github.com/users/diesel-rs/repos","events_url":"https://api.github.com/users/diesel-rs/events{/privacy}","received_events_url":"https://api.github.com/users/diesel-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":41609775,"name":"diesel","full_name":"diesel-rs/diesel","owner":{"login":"diesel-rs","id":16763251,"avatar_url":"https://avatars.githubusercontent.com/u/16763251?v=3","gravatar_id":"","url":"https://api.github.com/users/diesel-rs","html_url":"https://github.com/diesel-rs","followers_url":"https://api.github.com/users/diesel-rs/followers","following_url":"https://api.github.com/users/diesel-rs/following{/other_user}","gists_url":"https://api.github.com/users/diesel-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/diesel-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesel-rs/subscriptions","organizations_url":"https://api.github.com/users/diesel-rs/orgs","repos_url":"https://api.github.com/users/diesel-rs/repos","events_url":"https://api.github.com/users/diesel-rs/events{/privacy}","received_events_url":"https://api.github.com/users/diesel-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diesel-rs/diesel","description":"A safe, extensible ORM and Query Builder for Rust","fork":false,"url":"https://api.github.com/repos/diesel-rs/diesel","forks_url":"https://api.github.com/repos/diesel-rs/diesel/forks","keys_url":"https://api.github.com/repos/diesel-rs/diesel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diesel-rs/diesel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diesel-rs/diesel/teams","hooks_url":"https://api.github.com/repos/diesel-rs/diesel/hooks","issue_events_url":"https://api.github.com/repos/diesel-rs/diesel/issues/events{/number}","events_url":"https://api.github.com/repos/diesel-rs/diesel/events","assignees_url":"https://api.github.com/repos/diesel-rs/diesel/assignees{/user}","branches_url":"https://api.github.com/repos/diesel-rs/diesel/branches{/branch}","tags_url":"https://api.github.com/repos/diesel-rs/diesel/tags","blobs_url":"https://api.github.com/repos/diesel-rs/diesel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diesel-rs/diesel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diesel-rs/diesel/git/refs{/sha}","trees_url":"https://api.github.com/repos/diesel-rs/diesel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diesel-rs/diesel/statuses/{sha}","languages_url":"https://api.github.com/repos/diesel-rs/diesel/languages","stargazers_url":"https://api.github.com/repos/diesel-rs/diesel/stargazers","contributors_url":"https://api.github.com/repos/diesel-rs/diesel/contributors","subscribers_url":"https://api.github.com/repos/diesel-rs/diesel/subscribers","subscription_url":"https://api.github.com/repos/diesel-rs/diesel/subscription","commits_url":"https://api.github.com/repos/diesel-rs/diesel/commits{/sha}","git_commits_url":"https://api.github.com/repos/diesel-rs/diesel/git/commits{/sha}","comments_url":"https://api.github.com/repos/diesel-rs/diesel/comments{/number}","issue_comment_url":"https://api.github.com/repos/diesel-rs/diesel/issues/comments{/number}","contents_url":"https://api.github.com/repos/diesel-rs/diesel/contents/{+path}","compare_url":"https://api.github.com/repos/diesel-rs/diesel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diesel-rs/diesel/merges","archive_url":"https://api.github.com/repos/diesel-rs/diesel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diesel-rs/diesel/downloads","issues_url":"https://api.github.com/repos/diesel-rs/diesel/issues{/number}","pulls_url":"https://api.github.com/repos/diesel-rs/diesel/pulls{/number}","milestones_url":"https://api.github.com/repos/diesel-rs/diesel/milestones{/number}","notifications_url":"https://api.github.com/repos/diesel-rs/diesel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diesel-rs/diesel/labels{/name}","releases_url":"https://api.github.com/repos/diesel-rs/diesel/releases{/id}","deployments_url":"https://api.github.com/repos/diesel-rs/diesel/deployments","created_at":"2015-08-29T22:51:00Z","updated_at":"2016-06-09T16:34:35Z","pushed_at":"2016-06-10T10:55:12Z","git_url":"git://github.com/diesel-rs/diesel.git","ssh_url":"git@github.com:diesel-rs/diesel.git","clone_url":"https://github.com/diesel-rs/diesel.git","svn_url":"https://github.com/diesel-rs/diesel","homepage":"","size":5424,"stargazers_count":931,"watchers_count":931,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":58,"mirror_url":null,"open_issues_count":47,"forks":58,"open_issues":47,"watchers":931,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/351"},"html":{"href":"https://github.com/diesel-rs/diesel/pull/351"},"issue":{"href":"https://api.github.com/repos/diesel-rs/diesel/issues/351"},"comments":{"href":"https://api.github.com/repos/diesel-rs/diesel/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/diesel-rs/diesel/statuses/2acdc815732022fa7fa195d5f67bb007b03194bf"}}}}
{"actor":{"display_login":"kaj"}}