{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/54334028","id":54334028,"diff_hunk":"@@ -1380,6 +1454,16 @@ protected function generateEntityStubMethod(ClassMetadataInfo $metadata, $type,\n             $methodTypeHint =  '\\\\' . $typeHint . ' ';\n         }\n \n+        $methodReturnType = null;\n+        if ($this->generateMethodsTypeHinting) {","path":"lib/Doctrine/ORM/Tools/EntityGenerator.php","position":158,"original_position":166,"commit_id":"197734d6e32cadddaa8c1900723f487ba002920e","original_commit_id":"f519301f1672a6caa6671f5e46a01e0c88af216c","user":{"login":"jdecool","id":433926,"avatar_url":"https://avatars.githubusercontent.com/u/433926?v=3","gravatar_id":"","url":"https://api.github.com/users/jdecool","html_url":"https://github.com/jdecool","followers_url":"https://api.github.com/users/jdecool/followers","following_url":"https://api.github.com/users/jdecool/following{/other_user}","gists_url":"https://api.github.com/users/jdecool/gists{/gist_id}","starred_url":"https://api.github.com/users/jdecool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdecool/subscriptions","organizations_url":"https://api.github.com/users/jdecool/orgs","repos_url":"https://api.github.com/users/jdecool/repos","events_url":"https://api.github.com/users/jdecool/events{/privacy}","received_events_url":"https://api.github.com/users/jdecool/received_events","type":"User","site_admin":false},"body":"This condition calls 2 methods. One for type hinting parameters and the other for the return type.\r\n\r\nIt could not be move in only one method.","created_at":"2016-02-27T14:24:48Z","updated_at":"2016-02-27T14:24:48Z","html_url":"https://github.com/doctrine/doctrine2/pull/5569#discussion_r54334028","pull_request_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/54334028"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/5569#discussion_r54334028"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569","id":54207045,"html_url":"https://github.com/doctrine/doctrine2/pull/5569","diff_url":"https://github.com/doctrine/doctrine2/pull/5569.diff","patch_url":"https://github.com/doctrine/doctrine2/pull/5569.patch","issue_url":"https://api.github.com/repos/doctrine/doctrine2/issues/5569","number":5569,"state":"open","locked":false,"title":"Allow EntityGenerator to create PHP7 compliant methods","user":{"login":"jdecool","id":433926,"avatar_url":"https://avatars.githubusercontent.com/u/433926?v=3","gravatar_id":"","url":"https://api.github.com/users/jdecool","html_url":"https://github.com/jdecool","followers_url":"https://api.github.com/users/jdecool/followers","following_url":"https://api.github.com/users/jdecool/following{/other_user}","gists_url":"https://api.github.com/users/jdecool/gists{/gist_id}","starred_url":"https://api.github.com/users/jdecool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdecool/subscriptions","organizations_url":"https://api.github.com/users/jdecool/orgs","repos_url":"https://api.github.com/users/jdecool/repos","events_url":"https://api.github.com/users/jdecool/events{/privacy}","received_events_url":"https://api.github.com/users/jdecool/received_events","type":"User","site_admin":false},"body":"PHP files are in weak type-checking mode. Since PHP 7, strict type-checking mode is used for function calls and return statements in the the file.\r\n\r\nThis PR add support for generate class with are strict_types compliant.","created_at":"2015-12-20T20:21:50Z","updated_at":"2016-02-27T14:24:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13b8e159d8989a1121a18360c1db06adb4a7e4fd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569/commits","review_comments_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569/comments","review_comment_url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/issues/5569/comments","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/197734d6e32cadddaa8c1900723f487ba002920e","head":{"label":"jdecool:entity-generator-php7-compliant","ref":"entity-generator-php7-compliant","sha":"197734d6e32cadddaa8c1900723f487ba002920e","user":{"login":"jdecool","id":433926,"avatar_url":"https://avatars.githubusercontent.com/u/433926?v=3","gravatar_id":"","url":"https://api.github.com/users/jdecool","html_url":"https://github.com/jdecool","followers_url":"https://api.github.com/users/jdecool/followers","following_url":"https://api.github.com/users/jdecool/following{/other_user}","gists_url":"https://api.github.com/users/jdecool/gists{/gist_id}","starred_url":"https://api.github.com/users/jdecool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdecool/subscriptions","organizations_url":"https://api.github.com/users/jdecool/orgs","repos_url":"https://api.github.com/users/jdecool/repos","events_url":"https://api.github.com/users/jdecool/events{/privacy}","received_events_url":"https://api.github.com/users/jdecool/received_events","type":"User","site_admin":false},"repo":{"id":48329116,"name":"doctrine2","full_name":"jdecool/doctrine2","owner":{"login":"jdecool","id":433926,"avatar_url":"https://avatars.githubusercontent.com/u/433926?v=3","gravatar_id":"","url":"https://api.github.com/users/jdecool","html_url":"https://github.com/jdecool","followers_url":"https://api.github.com/users/jdecool/followers","following_url":"https://api.github.com/users/jdecool/following{/other_user}","gists_url":"https://api.github.com/users/jdecool/gists{/gist_id}","starred_url":"https://api.github.com/users/jdecool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdecool/subscriptions","organizations_url":"https://api.github.com/users/jdecool/orgs","repos_url":"https://api.github.com/users/jdecool/repos","events_url":"https://api.github.com/users/jdecool/events{/privacy}","received_events_url":"https://api.github.com/users/jdecool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jdecool/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":true,"url":"https://api.github.com/repos/jdecool/doctrine2","forks_url":"https://api.github.com/repos/jdecool/doctrine2/forks","keys_url":"https://api.github.com/repos/jdecool/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdecool/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdecool/doctrine2/teams","hooks_url":"https://api.github.com/repos/jdecool/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/jdecool/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/jdecool/doctrine2/events","assignees_url":"https://api.github.com/repos/jdecool/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/jdecool/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/jdecool/doctrine2/tags","blobs_url":"https://api.github.com/repos/jdecool/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdecool/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdecool/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdecool/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdecool/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/jdecool/doctrine2/languages","stargazers_url":"https://api.github.com/repos/jdecool/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/jdecool/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/jdecool/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/jdecool/doctrine2/subscription","commits_url":"https://api.github.com/repos/jdecool/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdecool/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdecool/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdecool/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdecool/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/jdecool/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdecool/doctrine2/merges","archive_url":"https://api.github.com/repos/jdecool/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdecool/doctrine2/downloads","issues_url":"https://api.github.com/repos/jdecool/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/jdecool/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/jdecool/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/jdecool/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdecool/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/jdecool/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/jdecool/doctrine2/deployments","created_at":"2015-12-20T16:42:41Z","updated_at":"2015-12-20T16:42:45Z","pushed_at":"2016-02-27T14:22:31Z","git_url":"git://github.com/jdecool/doctrine2.git","ssh_url":"git@github.com:jdecool/doctrine2.git","clone_url":"https://github.com/jdecool/doctrine2.git","svn_url":"https://github.com/jdecool/doctrine2","homepage":"http://www.doctrine-project.org","size":27347,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"4b45183dbddd30083b2552913f070c909348d333","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":597887,"name":"doctrine2","full_name":"doctrine/doctrine2","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/doctrine2","description":"Doctrine 2 Object Relational Mapper (ORM)","fork":false,"url":"https://api.github.com/repos/doctrine/doctrine2","forks_url":"https://api.github.com/repos/doctrine/doctrine2/forks","keys_url":"https://api.github.com/repos/doctrine/doctrine2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/doctrine2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/doctrine2/teams","hooks_url":"https://api.github.com/repos/doctrine/doctrine2/hooks","issue_events_url":"https://api.github.com/repos/doctrine/doctrine2/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/doctrine2/events","assignees_url":"https://api.github.com/repos/doctrine/doctrine2/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/doctrine2/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/doctrine2/tags","blobs_url":"https://api.github.com/repos/doctrine/doctrine2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/doctrine2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/doctrine2/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/doctrine2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/doctrine2/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/doctrine2/languages","stargazers_url":"https://api.github.com/repos/doctrine/doctrine2/stargazers","contributors_url":"https://api.github.com/repos/doctrine/doctrine2/contributors","subscribers_url":"https://api.github.com/repos/doctrine/doctrine2/subscribers","subscription_url":"https://api.github.com/repos/doctrine/doctrine2/subscription","commits_url":"https://api.github.com/repos/doctrine/doctrine2/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/doctrine2/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/doctrine2/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/doctrine2/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/doctrine2/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/doctrine2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/doctrine2/merges","archive_url":"https://api.github.com/repos/doctrine/doctrine2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/doctrine2/downloads","issues_url":"https://api.github.com/repos/doctrine/doctrine2/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/doctrine2/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/doctrine2/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/doctrine2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/doctrine2/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/doctrine2/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/doctrine2/deployments","created_at":"2010-04-06T21:42:59Z","updated_at":"2016-02-27T12:01:45Z","pushed_at":"2016-02-27T14:22:34Z","git_url":"git://github.com/doctrine/doctrine2.git","ssh_url":"git@github.com:doctrine/doctrine2.git","clone_url":"https://github.com/doctrine/doctrine2.git","svn_url":"https://github.com/doctrine/doctrine2","homepage":"http://www.doctrine-project.org","size":32046,"stargazers_count":2932,"watchers_count":2932,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1446,"mirror_url":null,"open_issues_count":917,"forks":1446,"open_issues":917,"watchers":2932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/5569"},"issue":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/5569"},"comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/issues/5569/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/5569/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/doctrine2/statuses/197734d6e32cadddaa8c1900723f487ba002920e"}}}}