{"action":"created","comment":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments/71072972","id":71072972,"diff_hunk":"@@ -1,6 +1,7 @@\n # Head\n \n - Fixed: bug causing rules in extended configs to be merged with, rather than replaced by, the extending config.\n+- Fixed: bug in `selector-no-type` when using `ignore: [\"descendant\"]`, which now will automatically resolve nested selectors before checking the rule.","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"4055945a0425e042315fbed94b32d2a461500e7b","original_commit_id":"4055945a0425e042315fbed94b32d2a461500e7b","user":{"login":"davidtheclark","id":628431,"avatar_url":"https://avatars.githubusercontent.com/u/628431?v=3","gravatar_id":"","url":"https://api.github.com/users/davidtheclark","html_url":"https://github.com/davidtheclark","followers_url":"https://api.github.com/users/davidtheclark/followers","following_url":"https://api.github.com/users/davidtheclark/following{/other_user}","gists_url":"https://api.github.com/users/davidtheclark/gists{/gist_id}","starred_url":"https://api.github.com/users/davidtheclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidtheclark/subscriptions","organizations_url":"https://api.github.com/users/davidtheclark/orgs","repos_url":"https://api.github.com/users/davidtheclark/repos","events_url":"https://api.github.com/users/davidtheclark/events{/privacy}","received_events_url":"https://api.github.com/users/davidtheclark/received_events","type":"User","site_admin":false},"body":"Let's rephrase/simplify to\r\n\r\n> Fixed: `selector-no-type` with secondary option `ignore: [\"descendant\"]` will now resolve nested selectors.","created_at":"2016-07-16T22:51:09Z","updated_at":"2016-07-16T22:51:09Z","html_url":"https://github.com/stylelint/stylelint/pull/1659#discussion_r71072972","pull_request_url":"https://api.github.com/repos/stylelint/stylelint/pulls/1659","_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments/71072972"},"html":{"href":"https://github.com/stylelint/stylelint/pull/1659#discussion_r71072972"},"pull_request":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1659"}}},"pull_request":{"url":"https://api.github.com/repos/stylelint/stylelint/pulls/1659","id":77556715,"html_url":"https://github.com/stylelint/stylelint/pull/1659","diff_url":"https://github.com/stylelint/stylelint/pull/1659.diff","patch_url":"https://github.com/stylelint/stylelint/pull/1659.patch","issue_url":"https://api.github.com/repos/stylelint/stylelint/issues/1659","number":1659,"state":"open","locked":false,"title":"Changes `selector-no-type` to automatically resolve nested selectors when `ignore: [\"descendant\"]` option is enabled.","user":{"login":"manovotny","id":446260,"avatar_url":"https://avatars.githubusercontent.com/u/446260?v=3","gravatar_id":"","url":"https://api.github.com/users/manovotny","html_url":"https://github.com/manovotny","followers_url":"https://api.github.com/users/manovotny/followers","following_url":"https://api.github.com/users/manovotny/following{/other_user}","gists_url":"https://api.github.com/users/manovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/manovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manovotny/subscriptions","organizations_url":"https://api.github.com/users/manovotny/orgs","repos_url":"https://api.github.com/users/manovotny/repos","events_url":"https://api.github.com/users/manovotny/events{/privacy}","received_events_url":"https://api.github.com/users/manovotny/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis PR addresses #1654.\r\n\r\nThese changes will automatically resolve nested selectors automatically if the `ignore: [\"descendant\"]` option is enabled. \r\n\r\nI am only doing this for `descendant` because `compounded` will work as expected regardless if it's nested or not. \r\n\r\nAnd since this is my first PR on this project, please let me know if there's anything else I may have missed or of there is any other pertinent information I should add to the PR.\r\n\r\n### Benchmarks\r\n\r\n#### Before\r\n\r\n```\r\n❯ npm run benchmark-rule -- selector-no-type \"[true, {\\\"ignore\\\": [\\\"descendant\\\"]}]\"\r\n\r\nWarnings: 406\r\nMean: 171.1881831515151 ms\r\nDeviation: 38.763392889220015 ms\r\n```\r\n\r\n#### After\r\n\r\n```\r\n❯ npm run benchmark-rule -- selector-no-type \"[true, {\\\"ignore\\\": [\\\"descendant\\\"]}]\"\r\n\r\nWarnings: 406\r\nMean: 156.6367916 ms\r\nDeviation: 25.370745159382917 ms\r\n```","created_at":"2016-07-15T02:55:41Z","updated_at":"2016-07-16T22:51:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10e5271e49efc9cbef523f17ff3598f176ee7239","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/stylelint/stylelint/pulls/1659/commits","review_comments_url":"https://api.github.com/repos/stylelint/stylelint/pulls/1659/comments","review_comment_url":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stylelint/stylelint/issues/1659/comments","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/4055945a0425e042315fbed94b32d2a461500e7b","head":{"label":"manovotny:selector-no-type-resolve-nested-selectors","ref":"selector-no-type-resolve-nested-selectors","sha":"4055945a0425e042315fbed94b32d2a461500e7b","user":{"login":"manovotny","id":446260,"avatar_url":"https://avatars.githubusercontent.com/u/446260?v=3","gravatar_id":"","url":"https://api.github.com/users/manovotny","html_url":"https://github.com/manovotny","followers_url":"https://api.github.com/users/manovotny/followers","following_url":"https://api.github.com/users/manovotny/following{/other_user}","gists_url":"https://api.github.com/users/manovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/manovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manovotny/subscriptions","organizations_url":"https://api.github.com/users/manovotny/orgs","repos_url":"https://api.github.com/users/manovotny/repos","events_url":"https://api.github.com/users/manovotny/events{/privacy}","received_events_url":"https://api.github.com/users/manovotny/received_events","type":"User","site_admin":false},"repo":{"id":61680264,"name":"stylelint","full_name":"manovotny/stylelint","owner":{"login":"manovotny","id":446260,"avatar_url":"https://avatars.githubusercontent.com/u/446260?v=3","gravatar_id":"","url":"https://api.github.com/users/manovotny","html_url":"https://github.com/manovotny","followers_url":"https://api.github.com/users/manovotny/followers","following_url":"https://api.github.com/users/manovotny/following{/other_user}","gists_url":"https://api.github.com/users/manovotny/gists{/gist_id}","starred_url":"https://api.github.com/users/manovotny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manovotny/subscriptions","organizations_url":"https://api.github.com/users/manovotny/orgs","repos_url":"https://api.github.com/users/manovotny/repos","events_url":"https://api.github.com/users/manovotny/events{/privacy}","received_events_url":"https://api.github.com/users/manovotny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manovotny/stylelint","description":"A mighty, modern CSS linter","fork":true,"url":"https://api.github.com/repos/manovotny/stylelint","forks_url":"https://api.github.com/repos/manovotny/stylelint/forks","keys_url":"https://api.github.com/repos/manovotny/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manovotny/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manovotny/stylelint/teams","hooks_url":"https://api.github.com/repos/manovotny/stylelint/hooks","issue_events_url":"https://api.github.com/repos/manovotny/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/manovotny/stylelint/events","assignees_url":"https://api.github.com/repos/manovotny/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/manovotny/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/manovotny/stylelint/tags","blobs_url":"https://api.github.com/repos/manovotny/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manovotny/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manovotny/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/manovotny/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manovotny/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/manovotny/stylelint/languages","stargazers_url":"https://api.github.com/repos/manovotny/stylelint/stargazers","contributors_url":"https://api.github.com/repos/manovotny/stylelint/contributors","subscribers_url":"https://api.github.com/repos/manovotny/stylelint/subscribers","subscription_url":"https://api.github.com/repos/manovotny/stylelint/subscription","commits_url":"https://api.github.com/repos/manovotny/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/manovotny/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/manovotny/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/manovotny/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/manovotny/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/manovotny/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manovotny/stylelint/merges","archive_url":"https://api.github.com/repos/manovotny/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manovotny/stylelint/downloads","issues_url":"https://api.github.com/repos/manovotny/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/manovotny/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/manovotny/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/manovotny/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manovotny/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/manovotny/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/manovotny/stylelint/deployments","created_at":"2016-06-22T01:47:44Z","updated_at":"2016-06-22T01:47:46Z","pushed_at":"2016-07-15T17:05:56Z","git_url":"git://github.com/manovotny/stylelint.git","ssh_url":"git@github.com:manovotny/stylelint.git","clone_url":"https://github.com/manovotny/stylelint.git","svn_url":"https://github.com/manovotny/stylelint","homepage":"http://stylelint.io/","size":4829,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stylelint:master","ref":"master","sha":"5b8c311d36e797126d52f6e4097b02405a0aebc2","user":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"repo":{"id":27549019,"name":"stylelint","full_name":"stylelint/stylelint","owner":{"login":"stylelint","id":10076935,"avatar_url":"https://avatars.githubusercontent.com/u/10076935?v=3","gravatar_id":"","url":"https://api.github.com/users/stylelint","html_url":"https://github.com/stylelint","followers_url":"https://api.github.com/users/stylelint/followers","following_url":"https://api.github.com/users/stylelint/following{/other_user}","gists_url":"https://api.github.com/users/stylelint/gists{/gist_id}","starred_url":"https://api.github.com/users/stylelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stylelint/subscriptions","organizations_url":"https://api.github.com/users/stylelint/orgs","repos_url":"https://api.github.com/users/stylelint/repos","events_url":"https://api.github.com/users/stylelint/events{/privacy}","received_events_url":"https://api.github.com/users/stylelint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stylelint/stylelint","description":"A mighty, modern CSS linter","fork":false,"url":"https://api.github.com/repos/stylelint/stylelint","forks_url":"https://api.github.com/repos/stylelint/stylelint/forks","keys_url":"https://api.github.com/repos/stylelint/stylelint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stylelint/stylelint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stylelint/stylelint/teams","hooks_url":"https://api.github.com/repos/stylelint/stylelint/hooks","issue_events_url":"https://api.github.com/repos/stylelint/stylelint/issues/events{/number}","events_url":"https://api.github.com/repos/stylelint/stylelint/events","assignees_url":"https://api.github.com/repos/stylelint/stylelint/assignees{/user}","branches_url":"https://api.github.com/repos/stylelint/stylelint/branches{/branch}","tags_url":"https://api.github.com/repos/stylelint/stylelint/tags","blobs_url":"https://api.github.com/repos/stylelint/stylelint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stylelint/stylelint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stylelint/stylelint/git/refs{/sha}","trees_url":"https://api.github.com/repos/stylelint/stylelint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stylelint/stylelint/statuses/{sha}","languages_url":"https://api.github.com/repos/stylelint/stylelint/languages","stargazers_url":"https://api.github.com/repos/stylelint/stylelint/stargazers","contributors_url":"https://api.github.com/repos/stylelint/stylelint/contributors","subscribers_url":"https://api.github.com/repos/stylelint/stylelint/subscribers","subscription_url":"https://api.github.com/repos/stylelint/stylelint/subscription","commits_url":"https://api.github.com/repos/stylelint/stylelint/commits{/sha}","git_commits_url":"https://api.github.com/repos/stylelint/stylelint/git/commits{/sha}","comments_url":"https://api.github.com/repos/stylelint/stylelint/comments{/number}","issue_comment_url":"https://api.github.com/repos/stylelint/stylelint/issues/comments{/number}","contents_url":"https://api.github.com/repos/stylelint/stylelint/contents/{+path}","compare_url":"https://api.github.com/repos/stylelint/stylelint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stylelint/stylelint/merges","archive_url":"https://api.github.com/repos/stylelint/stylelint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stylelint/stylelint/downloads","issues_url":"https://api.github.com/repos/stylelint/stylelint/issues{/number}","pulls_url":"https://api.github.com/repos/stylelint/stylelint/pulls{/number}","milestones_url":"https://api.github.com/repos/stylelint/stylelint/milestones{/number}","notifications_url":"https://api.github.com/repos/stylelint/stylelint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stylelint/stylelint/labels{/name}","releases_url":"https://api.github.com/repos/stylelint/stylelint/releases{/id}","deployments_url":"https://api.github.com/repos/stylelint/stylelint/deployments","created_at":"2014-12-04T16:25:23Z","updated_at":"2016-07-16T12:30:27Z","pushed_at":"2016-07-16T21:59:39Z","git_url":"git://github.com/stylelint/stylelint.git","ssh_url":"git@github.com:stylelint/stylelint.git","clone_url":"https://github.com/stylelint/stylelint.git","svn_url":"https://github.com/stylelint/stylelint","homepage":"http://stylelint.io/","size":5217,"stargazers_count":1910,"watchers_count":1910,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":41,"forks":124,"open_issues":41,"watchers":1910,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1659"},"html":{"href":"https://github.com/stylelint/stylelint/pull/1659"},"issue":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/1659"},"comments":{"href":"https://api.github.com/repos/stylelint/stylelint/issues/1659/comments"},"review_comments":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1659/comments"},"review_comment":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stylelint/stylelint/pulls/1659/commits"},"statuses":{"href":"https://api.github.com/repos/stylelint/stylelint/statuses/4055945a0425e042315fbed94b32d2a461500e7b"}}}}
{"actor":{"display_login":"davidtheclark"}}