{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/12934","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/12934/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/12934/comments","events_url":"https://api.github.com/repos/servo/servo/issues/12934/events","html_url":"https://github.com/servo/servo/pull/12934","id":172071525,"number":12934,"title":"webgl: object deletion and bindings","user":{"login":"anholt","id":3431811,"avatar_url":"https://avatars.githubusercontent.com/u/3431811?v=3","gravatar_id":"","url":"https://api.github.com/users/anholt","html_url":"https://github.com/anholt","followers_url":"https://api.github.com/users/anholt/followers","following_url":"https://api.github.com/users/anholt/following{/other_user}","gists_url":"https://api.github.com/users/anholt/gists{/gist_id}","starred_url":"https://api.github.com/users/anholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anholt/subscriptions","organizations_url":"https://api.github.com/users/anholt/orgs","repos_url":"https://api.github.com/users/anholt/repos","events_url":"https://api.github.com/users/anholt/events{/privacy}","received_events_url":"https://api.github.com/users/anholt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9"}],"state":"open","locked":false,"assignee":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"assignees":[{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2016-08-19T07:32:13Z","updated_at":"2016-08-19T07:52:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/12934","html_url":"https://github.com/servo/servo/pull/12934","diff_url":"https://github.com/servo/servo/pull/12934.diff","patch_url":"https://github.com/servo/servo/pull/12934.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\nThis PR brings in some fixes to the wpt object-deletion-and-behaviour.html testcase.\r\n\r\nThe test still has many failures, but some of the things that were really getting in the way are fixed.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [X] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/12934)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/240952449","html_url":"https://github.com/servo/servo/pull/12934#issuecomment-240952449","issue_url":"https://api.github.com/repos/servo/servo/issues/12934","id":240952449,"user":{"login":"anholt","id":3431811,"avatar_url":"https://avatars.githubusercontent.com/u/3431811?v=3","gravatar_id":"","url":"https://api.github.com/users/anholt","html_url":"https://github.com/anholt","followers_url":"https://api.github.com/users/anholt/followers","following_url":"https://api.github.com/users/anholt/following{/other_user}","gists_url":"https://api.github.com/users/anholt/gists{/gist_id}","starred_url":"https://api.github.com/users/anholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anholt/subscriptions","organizations_url":"https://api.github.com/users/anholt/orgs","repos_url":"https://api.github.com/users/anholt/repos","events_url":"https://api.github.com/users/anholt/events{/privacy}","received_events_url":"https://api.github.com/users/anholt/received_events","type":"User","site_admin":false},"created_at":"2016-08-19T07:52:34Z","updated_at":"2016-08-19T07:52:34Z","body":"Note that to generate my updates to test expecteds, I'm doing:\r\n\r\n- On master, ./mach update-wpt --ignore-existing <wpt results from master>\r\n- Commit results with \"DO NOT PUSH\" commit message\r\n- Rebase branch on this\r\n- Generate new ./mach update-wpt --ignore-existing <wpt results from branch\r\n- Include these changes in my commit fixing the code.\r\n- Rebase -i branch to drop \"DO NOT PUSH\" commit, fixing conflicts from dropping the other WPT updates.\r\n\r\nIs this a reasonable way to be updating test results?  It seems like we want to be reducing the number of FAILs we'll tolerate, ./mach update-wpt on its own won't do that for the subtests, but ./mach update-wpt --ignore-existing does a *ton* of changes."}}
{"actor":{"display_login":"anholt"}}