{"action":"created","comment":{"url":"https://api.github.com/repos/google/syzkaller/pulls/comments/89538784","pull_request_review_id":10084697,"id":89538784,"diff_hunk":"@@ -11,192 +11,203 @@ import (\n \t\"github.com/google/syzkaller/sys\"\n )\n \n-func (p *Prog) Mutate(rs rand.Source, ncalls int, ct *ChoiceTable) {\n+func (p *Prog) Mutate(rs rand.Source, ncalls int, ct *ChoiceTable, corpus *[]*Prog) {","path":"prog/mutation.go","position":5,"original_position":5,"commit_id":"e0922e463f421d283596f16a804cfc93c2f270c0","original_commit_id":"e0922e463f421d283596f16a804cfc93c2f270c0","user":{"login":"dvyukov","id":1095328,"avatar_url":"https://avatars.githubusercontent.com/u/1095328?v=3","gravatar_id":"","url":"https://api.github.com/users/dvyukov","html_url":"https://github.com/dvyukov","followers_url":"https://api.github.com/users/dvyukov/followers","following_url":"https://api.github.com/users/dvyukov/following{/other_user}","gists_url":"https://api.github.com/users/dvyukov/gists{/gist_id}","starred_url":"https://api.github.com/users/dvyukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvyukov/subscriptions","organizations_url":"https://api.github.com/users/dvyukov/orgs","repos_url":"https://api.github.com/users/dvyukov/repos","events_url":"https://api.github.com/users/dvyukov/events{/privacy}","received_events_url":"https://api.github.com/users/dvyukov/received_events","type":"User","site_admin":false},"body":"Pass []*Prog instead of *[]*Prog.\r\nSlice is 3 words (pointer, length, capacity), copying slice just copies these words, it does not copy the array itself.\r\nPassing pointer to slice header makes sense only iff the function changes the slice itself.\r\nNote that nil is a valid value for a slice, so you don't need to change call sites that pass nil.\r\n","created_at":"2016-11-24T18:53:34Z","updated_at":"2016-11-24T18:57:01Z","html_url":"https://github.com/google/syzkaller/pull/90#discussion_r89538784","pull_request_url":"https://api.github.com/repos/google/syzkaller/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments/89538784"},"html":{"href":"https://github.com/google/syzkaller/pull/90#discussion_r89538784"},"pull_request":{"href":"https://api.github.com/repos/google/syzkaller/pulls/90"}}},"pull_request":{"url":"https://api.github.com/repos/google/syzkaller/pulls/90","id":94832231,"html_url":"https://github.com/google/syzkaller/pull/90","diff_url":"https://github.com/google/syzkaller/pull/90.diff","patch_url":"https://github.com/google/syzkaller/pull/90.patch","issue_url":"https://api.github.com/repos/google/syzkaller/issues/90","number":90,"state":"open","locked":false,"title":"Combine progs from corpus","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-22T15:09:47Z","updated_at":"2016-11-24T18:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4f9edcde69be8b9bef9ce417fdb3a54f9943ea6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/syzkaller/pulls/90/commits","review_comments_url":"https://api.github.com/repos/google/syzkaller/pulls/90/comments","review_comment_url":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/syzkaller/issues/90/comments","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/e0922e463f421d283596f16a804cfc93c2f270c0","head":{"label":"xairy:combine-progs","ref":"combine-progs","sha":"e0922e463f421d283596f16a804cfc93c2f270c0","user":{"login":"xairy","id":4965052,"avatar_url":"https://avatars.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"repo":{"id":68212846,"name":"syzkaller","full_name":"xairy/syzkaller","owner":{"login":"xairy","id":4965052,"avatar_url":"https://avatars.githubusercontent.com/u/4965052?v=3","gravatar_id":"","url":"https://api.github.com/users/xairy","html_url":"https://github.com/xairy","followers_url":"https://api.github.com/users/xairy/followers","following_url":"https://api.github.com/users/xairy/following{/other_user}","gists_url":"https://api.github.com/users/xairy/gists{/gist_id}","starred_url":"https://api.github.com/users/xairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xairy/subscriptions","organizations_url":"https://api.github.com/users/xairy/orgs","repos_url":"https://api.github.com/users/xairy/repos","events_url":"https://api.github.com/users/xairy/events{/privacy}","received_events_url":"https://api.github.com/users/xairy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xairy/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":true,"url":"https://api.github.com/repos/xairy/syzkaller","forks_url":"https://api.github.com/repos/xairy/syzkaller/forks","keys_url":"https://api.github.com/repos/xairy/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xairy/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xairy/syzkaller/teams","hooks_url":"https://api.github.com/repos/xairy/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/xairy/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/xairy/syzkaller/events","assignees_url":"https://api.github.com/repos/xairy/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/xairy/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/xairy/syzkaller/tags","blobs_url":"https://api.github.com/repos/xairy/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xairy/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xairy/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/xairy/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xairy/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/xairy/syzkaller/languages","stargazers_url":"https://api.github.com/repos/xairy/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/xairy/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/xairy/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/xairy/syzkaller/subscription","commits_url":"https://api.github.com/repos/xairy/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/xairy/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/xairy/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/xairy/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/xairy/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/xairy/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xairy/syzkaller/merges","archive_url":"https://api.github.com/repos/xairy/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xairy/syzkaller/downloads","issues_url":"https://api.github.com/repos/xairy/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/xairy/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/xairy/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/xairy/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xairy/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/xairy/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/xairy/syzkaller/deployments","created_at":"2016-09-14T14:22:30Z","updated_at":"2016-09-14T14:22:32Z","pushed_at":"2016-11-24T15:17:22Z","git_url":"git://github.com/xairy/syzkaller.git","ssh_url":"git@github.com:xairy/syzkaller.git","clone_url":"https://github.com/xairy/syzkaller.git","svn_url":"https://github.com/xairy/syzkaller","homepage":"","size":2215,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"3356f68f1a531e194f6fbca5eb02f4f5bc4c218f","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":44087204,"name":"syzkaller","full_name":"google/syzkaller","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/syzkaller","description":"syzkaller is a distributed, unsupervised, coverage-guided Linux syscall fuzzer","fork":false,"url":"https://api.github.com/repos/google/syzkaller","forks_url":"https://api.github.com/repos/google/syzkaller/forks","keys_url":"https://api.github.com/repos/google/syzkaller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/syzkaller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/syzkaller/teams","hooks_url":"https://api.github.com/repos/google/syzkaller/hooks","issue_events_url":"https://api.github.com/repos/google/syzkaller/issues/events{/number}","events_url":"https://api.github.com/repos/google/syzkaller/events","assignees_url":"https://api.github.com/repos/google/syzkaller/assignees{/user}","branches_url":"https://api.github.com/repos/google/syzkaller/branches{/branch}","tags_url":"https://api.github.com/repos/google/syzkaller/tags","blobs_url":"https://api.github.com/repos/google/syzkaller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/syzkaller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/syzkaller/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/syzkaller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/syzkaller/statuses/{sha}","languages_url":"https://api.github.com/repos/google/syzkaller/languages","stargazers_url":"https://api.github.com/repos/google/syzkaller/stargazers","contributors_url":"https://api.github.com/repos/google/syzkaller/contributors","subscribers_url":"https://api.github.com/repos/google/syzkaller/subscribers","subscription_url":"https://api.github.com/repos/google/syzkaller/subscription","commits_url":"https://api.github.com/repos/google/syzkaller/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/syzkaller/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/syzkaller/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/syzkaller/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/syzkaller/contents/{+path}","compare_url":"https://api.github.com/repos/google/syzkaller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/syzkaller/merges","archive_url":"https://api.github.com/repos/google/syzkaller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/syzkaller/downloads","issues_url":"https://api.github.com/repos/google/syzkaller/issues{/number}","pulls_url":"https://api.github.com/repos/google/syzkaller/pulls{/number}","milestones_url":"https://api.github.com/repos/google/syzkaller/milestones{/number}","notifications_url":"https://api.github.com/repos/google/syzkaller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/syzkaller/labels{/name}","releases_url":"https://api.github.com/repos/google/syzkaller/releases{/id}","deployments_url":"https://api.github.com/repos/google/syzkaller/deployments","created_at":"2015-10-12T06:05:05Z","updated_at":"2016-11-23T10:31:55Z","pushed_at":"2016-11-24T15:17:22Z","git_url":"git://github.com/google/syzkaller.git","ssh_url":"git@github.com:google/syzkaller.git","clone_url":"https://github.com/google/syzkaller.git","svn_url":"https://github.com/google/syzkaller","homepage":"","size":2277,"stargazers_count":417,"watchers_count":417,"language":"Go","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":15,"forks":73,"open_issues":15,"watchers":417,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/syzkaller/pulls/90"},"html":{"href":"https://github.com/google/syzkaller/pull/90"},"issue":{"href":"https://api.github.com/repos/google/syzkaller/issues/90"},"comments":{"href":"https://api.github.com/repos/google/syzkaller/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/google/syzkaller/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/google/syzkaller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/syzkaller/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/google/syzkaller/statuses/e0922e463f421d283596f16a804cfc93c2f270c0"}}}}
{"actor":{"display_login":"dvyukov"}}