{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/82997327","pull_request_review_id":3865611,"id":82997327,"diff_hunk":"@@ -277,18 +279,17 @@\n \t\tfor(var/obj/structure/bigDelivery/O in src)\r\n \t\t\tdeliveryCheck = 1\r\n \t\t\tif(O.sortTag == 0)\r\n-\t\t\t\tO.sortTag = 1\r\n+\t\t\t\tO.sortTag = defaultDestinationTag\r\n \t\tfor(var/obj/item/smallDelivery/O in src)\r\n \t\t\tdeliveryCheck = 1\r\n \t\t\tif(O.sortTag == 0)\r\n-\t\t\t\tO.sortTag = 1\r\n+\t\t\t\tO.sortTag = defaultDestinationTag\r\n \t\tif(deliveryCheck == 0)\r\n-\t\t\tH.destinationTag = 1\r\n+\t\t\tH.destinationTag = defaultDestinationTag\r\n \r\n \t\tsleep(10)\r\n \t\tplaysound(src, 'sound/machines/disposalflush.ogg', 50, 0, 0)\r\n \t\tsleep(5) // wait for animation to finish\r\n-\r\n \t\tH.init(src)\t// copy the contents of disposer to holder\r","path":"code/modules/recycling/sortingmachinery.dm","position":101,"original_position":101,"commit_id":"441fcfc28c17d6e2b81085d5ed228d7c11e5c982","original_commit_id":"441fcfc28c17d6e2b81085d5ed228d7c11e5c982","user":{"login":"WhiteHusky","id":3196371,"avatar_url":"https://avatars.githubusercontent.com/u/3196371?v=3","gravatar_id":"","url":"https://api.github.com/users/WhiteHusky","html_url":"https://github.com/WhiteHusky","followers_url":"https://api.github.com/users/WhiteHusky/followers","following_url":"https://api.github.com/users/WhiteHusky/following{/other_user}","gists_url":"https://api.github.com/users/WhiteHusky/gists{/gist_id}","starred_url":"https://api.github.com/users/WhiteHusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhiteHusky/subscriptions","organizations_url":"https://api.github.com/users/WhiteHusky/orgs","repos_url":"https://api.github.com/users/WhiteHusky/repos","events_url":"https://api.github.com/users/WhiteHusky/events{/privacy}","received_events_url":"https://api.github.com/users/WhiteHusky/received_events","type":"User","site_admin":false},"body":"@Fox-McCloud It's part feature/fix in my opinion too. I can revert the code to be pure fix if you'd like.\r\n\r\nTo the other concern, it'll act similar to how it is now since the chutes create a `disposalholder` and dump it's contents into it (except now it's not creating n-1 holders that are just empty because n items bumped into it).\r\n\r\nHowever I might bother with seeing if I can create a `disposalholder` for each item bumping in like I said earlier; making Cargo's life much more easier and not sending expensive items into the trash because a pop-can happened to enter first followed by the shipment.","created_at":"2016-10-12T12:50:51Z","updated_at":"2016-10-12T12:50:52Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/5745#discussion_r82997327","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/82997327"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/5745#discussion_r82997327"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745"}}},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745","id":88182931,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/5745","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/5745.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/5745.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5745","number":5745,"state":"open","locked":false,"title":"Disposal Tweaks & Fixes","user":{"login":"WhiteHusky","id":3196371,"avatar_url":"https://avatars.githubusercontent.com/u/3196371?v=3","gravatar_id":"","url":"https://api.github.com/users/WhiteHusky","html_url":"https://github.com/WhiteHusky","followers_url":"https://api.github.com/users/WhiteHusky/followers","following_url":"https://api.github.com/users/WhiteHusky/following{/other_user}","gists_url":"https://api.github.com/users/WhiteHusky/gists{/gist_id}","starred_url":"https://api.github.com/users/WhiteHusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhiteHusky/subscriptions","organizations_url":"https://api.github.com/users/WhiteHusky/orgs","repos_url":"https://api.github.com/users/WhiteHusky/repos","events_url":"https://api.github.com/users/WhiteHusky/events{/privacy}","received_events_url":"https://api.github.com/users/WhiteHusky/received_events","type":"User","site_admin":false},"body":"- `disposal.dm`.\r\n - Minor tweaks.\r\n - Removed implied `src`.\r\n- `sortingmachinery.dm`\r\n - Adds `defaultDestinationTag` to Delivery Chutes to define a default location for items going into the chute. By default this is `1` or Disposals.\r\n - Delivery Chutes do not fire the `flush` proc while in the process of flushing to prevent sound spam and excessive `disposalholder`s. Previously this was causing it to generate nth amount of `disposalholder`s equal to the amount of items going inside that once arrived to a outlet spammed the `expel` proc, even though one of the `disposalholder`s will actually have the items due to how Delivery Chutes operate _(Move **all** or **no** items inside the chute into a `disposalholder`)_. Now it should simply send one `disposalholder` with all the items.\r\n - Outlets don't stack the alarm sound effect while already expelling. They still play the expel sound as normal.\r\n - Removed implied `src`.\r\n- `cyberiad.dmm`[Waste Disposal](http://nanotrasen.se/wiki/index.php/Waste_Disposal)\r\n - The Delivery Chute was updated to have it's `defaultDestinationTag` to be `2` or the Cargo Bay.\r\n - Reinforced glass was added to prevent items skipping the recycler coming out of the outlet","created_at":"2016-10-06T00:51:10Z","updated_at":"2016-10-12T12:50:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a399c22a206bb1f767ee29028f5e692b9f25dae4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5745/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/441fcfc28c17d6e2b81085d5ed228d7c11e5c982","head":{"label":"WhiteHusky:DifferentDestinationsForChutes","ref":"DifferentDestinationsForChutes","sha":"441fcfc28c17d6e2b81085d5ed228d7c11e5c982","user":{"login":"WhiteHusky","id":3196371,"avatar_url":"https://avatars.githubusercontent.com/u/3196371?v=3","gravatar_id":"","url":"https://api.github.com/users/WhiteHusky","html_url":"https://github.com/WhiteHusky","followers_url":"https://api.github.com/users/WhiteHusky/followers","following_url":"https://api.github.com/users/WhiteHusky/following{/other_user}","gists_url":"https://api.github.com/users/WhiteHusky/gists{/gist_id}","starred_url":"https://api.github.com/users/WhiteHusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhiteHusky/subscriptions","organizations_url":"https://api.github.com/users/WhiteHusky/orgs","repos_url":"https://api.github.com/users/WhiteHusky/repos","events_url":"https://api.github.com/users/WhiteHusky/events{/privacy}","received_events_url":"https://api.github.com/users/WhiteHusky/received_events","type":"User","site_admin":false},"repo":{"id":70106922,"name":"Paradise","full_name":"WhiteHusky/Paradise","owner":{"login":"WhiteHusky","id":3196371,"avatar_url":"https://avatars.githubusercontent.com/u/3196371?v=3","gravatar_id":"","url":"https://api.github.com/users/WhiteHusky","html_url":"https://github.com/WhiteHusky","followers_url":"https://api.github.com/users/WhiteHusky/followers","following_url":"https://api.github.com/users/WhiteHusky/following{/other_user}","gists_url":"https://api.github.com/users/WhiteHusky/gists{/gist_id}","starred_url":"https://api.github.com/users/WhiteHusky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhiteHusky/subscriptions","organizations_url":"https://api.github.com/users/WhiteHusky/orgs","repos_url":"https://api.github.com/users/WhiteHusky/repos","events_url":"https://api.github.com/users/WhiteHusky/events{/privacy}","received_events_url":"https://api.github.com/users/WhiteHusky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WhiteHusky/Paradise","description":"Paradise Station's GitHub main repository.","fork":true,"url":"https://api.github.com/repos/WhiteHusky/Paradise","forks_url":"https://api.github.com/repos/WhiteHusky/Paradise/forks","keys_url":"https://api.github.com/repos/WhiteHusky/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhiteHusky/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhiteHusky/Paradise/teams","hooks_url":"https://api.github.com/repos/WhiteHusky/Paradise/hooks","issue_events_url":"https://api.github.com/repos/WhiteHusky/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/WhiteHusky/Paradise/events","assignees_url":"https://api.github.com/repos/WhiteHusky/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/WhiteHusky/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/WhiteHusky/Paradise/tags","blobs_url":"https://api.github.com/repos/WhiteHusky/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhiteHusky/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhiteHusky/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhiteHusky/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhiteHusky/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/WhiteHusky/Paradise/languages","stargazers_url":"https://api.github.com/repos/WhiteHusky/Paradise/stargazers","contributors_url":"https://api.github.com/repos/WhiteHusky/Paradise/contributors","subscribers_url":"https://api.github.com/repos/WhiteHusky/Paradise/subscribers","subscription_url":"https://api.github.com/repos/WhiteHusky/Paradise/subscription","commits_url":"https://api.github.com/repos/WhiteHusky/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhiteHusky/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhiteHusky/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhiteHusky/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhiteHusky/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/WhiteHusky/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhiteHusky/Paradise/merges","archive_url":"https://api.github.com/repos/WhiteHusky/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhiteHusky/Paradise/downloads","issues_url":"https://api.github.com/repos/WhiteHusky/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/WhiteHusky/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/WhiteHusky/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/WhiteHusky/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhiteHusky/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/WhiteHusky/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/WhiteHusky/Paradise/deployments","created_at":"2016-10-05T23:15:01Z","updated_at":"2016-10-05T23:15:13Z","pushed_at":"2016-10-10T19:06:00Z","git_url":"git://github.com/WhiteHusky/Paradise.git","ssh_url":"git@github.com:WhiteHusky/Paradise.git","clone_url":"https://github.com/WhiteHusky/Paradise.git","svn_url":"https://github.com/WhiteHusky/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":896279,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"45974cf6bda893fe1b834c439b321c78f966cfdc","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars.githubusercontent.com/u/9994901?v=3","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2016-10-01T04:05:59Z","pushed_at":"2016-10-12T12:50:08Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"git@github.com:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":1024192,"stargazers_count":75,"watchers_count":75,"language":"DM","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":283,"forks":207,"open_issues":283,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/5745"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5745"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/5745/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/5745/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/441fcfc28c17d6e2b81085d5ed228d7c11e5c982"}}}}
{"actor":{"display_login":"WhiteHusky"}}