{"action":"created","issue":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/4194","repository_url":"https://api.github.com/repos/mavlink/qgroundcontrol","labels_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/4194/labels{/name}","comments_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/4194/comments","events_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/4194/events","html_url":"https://github.com/mavlink/qgroundcontrol/pull/4194","id":187382259,"number":4194,"title":"Checking for MAVLink 2.0 when first message is received.","user":{"login":"dogmaphobic","id":749243,"avatar_url":"https://avatars.githubusercontent.com/u/749243?v=3","gravatar_id":"","url":"https://api.github.com/users/dogmaphobic","html_url":"https://github.com/dogmaphobic","followers_url":"https://api.github.com/users/dogmaphobic/followers","following_url":"https://api.github.com/users/dogmaphobic/following{/other_user}","gists_url":"https://api.github.com/users/dogmaphobic/gists{/gist_id}","starred_url":"https://api.github.com/users/dogmaphobic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogmaphobic/subscriptions","organizations_url":"https://api.github.com/users/dogmaphobic/orgs","repos_url":"https://api.github.com/users/dogmaphobic/repos","events_url":"https://api.github.com/users/dogmaphobic/events{/privacy}","received_events_url":"https://api.github.com/users/dogmaphobic/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-04T16:42:18Z","updated_at":"2016-11-09T08:34:22Z","closed_at":"2016-11-04T21:35:46Z","pull_request":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/pulls/4194","html_url":"https://github.com/mavlink/qgroundcontrol/pull/4194","diff_url":"https://github.com/mavlink/qgroundcontrol/pull/4194.diff","patch_url":"https://github.com/mavlink/qgroundcontrol/pull/4194.patch"},"body":"Following a comment form @bkueng, enabling a test for MAVLink version test when a message is first decoded.\r\n\r\nNote that I feel this to be a temporary stop-gap fix until @DonLakeFlyer is back. That `decodedFirstPacket` variable is static and it will \"stick\" on subsequent connections. This will certainly not work if you have two vehicles connected or if you disconnect and connect again."},"comment":{"url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/comments/259359179","html_url":"https://github.com/mavlink/qgroundcontrol/pull/4194#issuecomment-259359179","issue_url":"https://api.github.com/repos/mavlink/qgroundcontrol/issues/4194","id":259359179,"user":{"login":"bkueng","id":281593,"avatar_url":"https://avatars.githubusercontent.com/u/281593?v=3","gravatar_id":"","url":"https://api.github.com/users/bkueng","html_url":"https://github.com/bkueng","followers_url":"https://api.github.com/users/bkueng/followers","following_url":"https://api.github.com/users/bkueng/following{/other_user}","gists_url":"https://api.github.com/users/bkueng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkueng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkueng/subscriptions","organizations_url":"https://api.github.com/users/bkueng/orgs","repos_url":"https://api.github.com/users/bkueng/repos","events_url":"https://api.github.com/users/bkueng/events{/privacy}","received_events_url":"https://api.github.com/users/bkueng/received_events","type":"User","site_admin":false},"created_at":"2016-11-09T08:34:22Z","updated_at":"2016-11-09T08:34:22Z","body":"@DonLakeFlyer let me try to explain: there are 2 mechanisms:\r\n- on-the-fly switching: in MAVLinkProtocol.cc: this switches when the vehicle uses a different mavlink version, needed when initializing the connection (did you see that this code was previously commented?)\r\n- capability-based switching: this is done in Vehicle.cc. Both endpoints speak mavlink 1, but the vehicle signals mavlink 2 capability, so QGC switches.\r\n\r\nIMO both mechanisms are necessary. This PR resolves the case where a vehicle can only send/receive mavlink 2, so QGC cannot first request the capabilities and then switch."}}
{"actor":{"display_login":"bkueng"}}