{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/79463153","id":79463153,"diff_hunk":"@@ -62,6 +62,17 @@ def test_hit_w_content_as_str(self):\n         self.assertEqual(exception.message, 'Not Found')\n         self.assertEqual(list(exception.errors), [])\n \n+    def test_hit_w_content_as_unicode(self):\n+        from google.cloud.exceptions import NotFound\n+        response = _Response(404)\n+        content = u'{\"error\": {\"message\": \"That\\u2019s all we know.\"}}'\n+        exception = self._callFUT(response, content)\n+        self.assertTrue(isinstance(exception, NotFound))\n+\n+        self.assertEqual(exception.message, u'That\\u2019s all we know.')","path":"unit_tests/test_exceptions.py","position":11,"original_position":11,"commit_id":"54160b3f1407fba17576c109b22a997acc66e491","original_commit_id":"54160b3f1407fba17576c109b22a997acc66e491","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"You could re-use this value (`u'That\\u2019s all we know.'`) and make the test more modular (DRY)","created_at":"2016-09-19T18:55:08Z","updated_at":"2016-09-19T18:55:08Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348#discussion_r79463153","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/79463153"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348#discussion_r79463153"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348","id":85829227,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2348","number":2348,"state":"open","locked":false,"title":"Fix unicode message in exceptions","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"body":"See https://github.com/GoogleCloudPlatform/google-cloud-python/issues/2346\r\n\r\n@dhermes looking at the magic methods and playing with `__bytes__` and `__unicode__`, the solutions I had felt really hacky. i.e. checking for `six.PY3` in `__str__` and then just calling `self.__bytes__()` instead. \r\n\r\nI'm not sure if it's good form to use `__future__` here but it seems to be a valid way to ]solve the issue](http://python-future.org/unicode_literals.html).","created_at":"2016-09-19T16:48:34Z","updated_at":"2016-09-19T18:55:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53b94d82a0f3a02477d14736f789717f8e5458b6","assignee":{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},"assignees":[{"login":"tseaver","id":242750,"avatar_url":"https://avatars.githubusercontent.com/u/242750?v=3","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false},{"login":"dhermes","id":520669,"avatar_url":"https://avatars.githubusercontent.com/u/520669?v=3","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2348/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/54160b3f1407fba17576c109b22a997acc66e491","head":{"label":"daspecster:fix-google-cloud-error-exception-message","ref":"fix-google-cloud-error-exception-message","sha":"54160b3f1407fba17576c109b22a997acc66e491","user":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"repo":{"id":43923717,"name":"google-cloud-python","full_name":"daspecster/google-cloud-python","owner":{"login":"daspecster","id":192456,"avatar_url":"https://avatars.githubusercontent.com/u/192456?v=3","gravatar_id":"","url":"https://api.github.com/users/daspecster","html_url":"https://github.com/daspecster","followers_url":"https://api.github.com/users/daspecster/followers","following_url":"https://api.github.com/users/daspecster/following{/other_user}","gists_url":"https://api.github.com/users/daspecster/gists{/gist_id}","starred_url":"https://api.github.com/users/daspecster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daspecster/subscriptions","organizations_url":"https://api.github.com/users/daspecster/orgs","repos_url":"https://api.github.com/users/daspecster/repos","events_url":"https://api.github.com/users/daspecster/events{/privacy}","received_events_url":"https://api.github.com/users/daspecster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daspecster/google-cloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/daspecster/google-cloud-python","forks_url":"https://api.github.com/repos/daspecster/google-cloud-python/forks","keys_url":"https://api.github.com/repos/daspecster/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daspecster/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daspecster/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/daspecster/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/daspecster/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/daspecster/google-cloud-python/events","assignees_url":"https://api.github.com/repos/daspecster/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/daspecster/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/daspecster/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daspecster/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/daspecster/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/daspecster/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/daspecster/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/daspecster/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/daspecster/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/daspecster/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/daspecster/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/daspecster/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/daspecster/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/daspecster/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/daspecster/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daspecster/google-cloud-python/merges","archive_url":"https://api.github.com/repos/daspecster/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daspecster/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/daspecster/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/daspecster/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/daspecster/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/daspecster/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daspecster/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/daspecster/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/daspecster/google-cloud-python/deployments","created_at":"2015-10-09T00:31:09Z","updated_at":"2016-09-08T16:00:35Z","pushed_at":"2016-09-19T18:48:32Z","git_url":"git://github.com/daspecster/google-cloud-python.git","ssh_url":"git@github.com:daspecster/google-cloud-python.git","clone_url":"https://github.com/daspecster/google-cloud-python.git","svn_url":"https://github.com/daspecster/google-cloud-python","homepage":"https://googlecloudplatform.github.io/gcloud-python/","size":73146,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6fb2d73ff6350590aa061bcd902422828340f337","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2016-09-17T03:44:29Z","pushed_at":"2016-09-19T18:48:33Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":84742,"stargazers_count":395,"watchers_count":395,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":202,"mirror_url":null,"open_issues_count":194,"forks":202,"open_issues":194,"watchers":395,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2348"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/2348/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/2348/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/54160b3f1407fba17576c109b22a997acc66e491"}}}}
{"actor":{"display_login":"dhermes"}}