{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/74487919","id":74487919,"diff_hunk":"@@ -67,11 +67,23 @@ There will now be a `cluster.yaml` file in the asset directory. This is the main\n \n ### Render contents of the asset directory\n \n-Next, generate a set of cluster assets in the current directory, based on the settings in your `cluster.yaml` file.\n+* In the simplest case, you can have kube-aws generate both your TLS identities and certificate authority for you.\n \n-```sh\n-$ kube-aws render\n-```\n+  ```sh\n+  $ kube-aws render --generate-credentials --generate-ca\n+  ```\n+\n+  This is not recommended for production, but is fine for development or testing purposes.\n+\n+* It is recommended that you supply your own immediate certificate signing authority and let kube-aws take care of generating the cluster TLS credentials.\n+\n+  ```sh\n+  $ kube-aws render --generate-credentials --ca-cert-path=/path/to/ca-cert.pem --ca-key-path=/path/to/ca-key.pem","path":"Documentation/kubernetes-on-aws-render.md","position":19,"original_position":19,"commit_id":"3dff28fb81b90325e6730403b46449634c1fa648","original_commit_id":"3dff28fb81b90325e6730403b46449634c1fa648","user":{"login":"chancez","id":1400401,"avatar_url":"https://avatars.githubusercontent.com/u/1400401?v=3","gravatar_id":"","url":"https://api.github.com/users/chancez","html_url":"https://github.com/chancez","followers_url":"https://api.github.com/users/chancez/followers","following_url":"https://api.github.com/users/chancez/following{/other_user}","gists_url":"https://api.github.com/users/chancez/gists{/gist_id}","starred_url":"https://api.github.com/users/chancez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chancez/subscriptions","organizations_url":"https://api.github.com/users/chancez/orgs","repos_url":"https://api.github.com/users/chancez/repos","events_url":"https://api.github.com/users/chancez/events{/privacy}","received_events_url":"https://api.github.com/users/chancez/received_events","type":"User","site_admin":false},"body":"Agree with @sym3tri , but maybe make it a config file value instead?","created_at":"2016-08-11T19:32:20Z","updated_at":"2016-08-11T19:32:20Z","html_url":"https://github.com/coreos/coreos-kubernetes/pull/608#discussion_r74487919","pull_request_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments/74487919"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/608#discussion_r74487919"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608","id":80714661,"html_url":"https://github.com/coreos/coreos-kubernetes/pull/608","diff_url":"https://github.com/coreos/coreos-kubernetes/pull/608.diff","patch_url":"https://github.com/coreos/coreos-kubernetes/pull/608.patch","issue_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/608","number":608,"state":"open","locked":false,"title":"Cluster upgrades","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"body":"Complete and working upgrade path for kube-aws clusters, minus the discrete etcd cluster instances.\r\n\r\nAs part of this, we now have external CA support for TLS asset generation, along with support for allowing user to generate all TLS assets.\r\n\r\nFixes #104 #161 \r\nDepends #544 #596 #465 \r\n\r\nUnfortunately does not support upgrading clusters that have already launched.\r\n\r\n@mumoshu I'd like to get your work on node draining on shutdown integrated as well.\r\n\r\n\\cc @plange @whereisaaron @robszumski @sym3tri @bfallik \r\n\r\nRef #340 #230 #161","created_at":"2016-08-09T23:55:28Z","updated_at":"2016-08-11T19:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28815920e7ef9fb753f13c7e9d4d9ccf09b6a436","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/608/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/3dff28fb81b90325e6730403b46449634c1fa648","head":{"label":"colhom:cluster-upgrades","ref":"cluster-upgrades","sha":"3dff28fb81b90325e6730403b46449634c1fa648","user":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"repo":{"id":43779482,"name":"coreos-kubernetes","full_name":"colhom/coreos-kubernetes","owner":{"login":"colhom","id":1075028,"avatar_url":"https://avatars.githubusercontent.com/u/1075028?v=3","gravatar_id":"","url":"https://api.github.com/users/colhom","html_url":"https://github.com/colhom","followers_url":"https://api.github.com/users/colhom/followers","following_url":"https://api.github.com/users/colhom/following{/other_user}","gists_url":"https://api.github.com/users/colhom/gists{/gist_id}","starred_url":"https://api.github.com/users/colhom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colhom/subscriptions","organizations_url":"https://api.github.com/users/colhom/orgs","repos_url":"https://api.github.com/users/colhom/repos","events_url":"https://api.github.com/users/colhom/events{/privacy}","received_events_url":"https://api.github.com/users/colhom/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colhom/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":true,"url":"https://api.github.com/repos/colhom/coreos-kubernetes","forks_url":"https://api.github.com/repos/colhom/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/colhom/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colhom/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colhom/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/colhom/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/colhom/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/colhom/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/colhom/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/colhom/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/colhom/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colhom/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/colhom/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/colhom/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/colhom/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/colhom/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/colhom/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/colhom/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/colhom/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/colhom/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/colhom/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/colhom/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/colhom/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colhom/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/colhom/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colhom/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/colhom/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/colhom/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/colhom/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/colhom/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colhom/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/colhom/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/colhom/coreos-kubernetes/deployments","created_at":"2015-10-06T21:21:15Z","updated_at":"2016-02-23T08:59:19Z","pushed_at":"2016-08-09T23:47:49Z","git_url":"git://github.com/colhom/coreos-kubernetes.git","ssh_url":"git@github.com:colhom/coreos-kubernetes.git","clone_url":"https://github.com/colhom/coreos-kubernetes.git","svn_url":"https://github.com/colhom/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":17690,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"125e4611843451c08c9503a0c0c9def3e52cc639","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":41458519,"name":"coreos-kubernetes","full_name":"coreos/coreos-kubernetes","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-kubernetes","description":"CoreOS+Kubernetes documentation, Vagrant & AWS installers","fork":false,"url":"https://api.github.com/repos/coreos/coreos-kubernetes","forks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/forks","keys_url":"https://api.github.com/repos/coreos/coreos-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-kubernetes/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-kubernetes/events","assignees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-kubernetes/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-kubernetes/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-kubernetes/merges","archive_url":"https://api.github.com/repos/coreos/coreos-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-kubernetes/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/coreos-kubernetes/deployments","created_at":"2015-08-27T01:25:24Z","updated_at":"2016-08-10T21:06:40Z","pushed_at":"2016-08-11T18:59:10Z","git_url":"git://github.com/coreos/coreos-kubernetes.git","ssh_url":"git@github.com:coreos/coreos-kubernetes.git","clone_url":"https://github.com/coreos/coreos-kubernetes.git","svn_url":"https://github.com/coreos/coreos-kubernetes","homepage":"https://coreos.com/kubernetes/docs/latest/","size":51991,"stargazers_count":511,"watchers_count":511,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":109,"forks":252,"open_issues":109,"watchers":511,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608"},"html":{"href":"https://github.com/coreos/coreos-kubernetes/pull/608"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/608"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/issues/608/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/pulls/608/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-kubernetes/statuses/3dff28fb81b90325e6730403b46449634c1fa648"}}}}
{"actor":{"display_login":"chancez"}}