{"action":"created","comment":{"url":"https://api.github.com/repos/commercetools/nodejs/pulls/comments/91327034","pull_request_review_id":11835499,"id":91327034,"diff_hunk":"@@ -1,42 +0,0 @@\n-#!/usr/bin/env node\n-\n-'use strict';\n-\n-const fs = require('fs');\n-const path = require('path');\n-\n-const rootBin = '../../node_modules/.bin/';\n-const packageBin = './node_modules/.bin/';\n-\n-const forceSymlink = function (target, destination) {\n-  fs.symlink(target, destination, function (error) {\n-    if (error) {\n-      if (error.code === 'EEXIST') {\n-        fs.unlink(destination, function (error) {\n-          if (error) {\n-            throw error;\n-          }\n-\n-          forceSymlink(target, destination);\n-        });\n-      } else {\n-        throw error;\n-      }\n-    }\n-  });\n-};\n-\n-fs.readdir(rootBin, function (error, files) {\n-  if (error) {\n-    throw error;\n-  }\n-\n-  files.forEach(function (file) {\n-    const rootBinPath = path.resolve(rootBin, file);\n-    const packageBinPath = path.resolve(packageBin, file);\n-\n-    forceSymlink(rootBinPath, packageBinPath);\n-  });\n-\n-  console.log(`Created symlinks for .bin in ${process.cwd()}`);\n-});","path":"scripts/symlink-bin.js","position":42,"original_position":42,"commit_id":"eef9fa51ccbe42bbb53cc0584b4949b5d882114a","original_commit_id":"eef9fa51ccbe42bbb53cc0584b4949b5d882114a","user":{"login":"emmenko","id":1110551,"avatar_url":"https://avatars.githubusercontent.com/u/1110551?v=3","gravatar_id":"","url":"https://api.github.com/users/emmenko","html_url":"https://github.com/emmenko","followers_url":"https://api.github.com/users/emmenko/followers","following_url":"https://api.github.com/users/emmenko/following{/other_user}","gists_url":"https://api.github.com/users/emmenko/gists{/gist_id}","starred_url":"https://api.github.com/users/emmenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmenko/subscriptions","organizations_url":"https://api.github.com/users/emmenko/orgs","repos_url":"https://api.github.com/users/emmenko/repos","events_url":"https://api.github.com/users/emmenko/events{/privacy}","received_events_url":"https://api.github.com/users/emmenko/received_events","type":"User","site_admin":false},"body":"I didn't find this necessary anymore, it was causing a bit of confusion. That's also part of the changes in the main scripts.\r\nAdditionally, packages don't need to define any \"scripts\" themselves, besides is something really specific.","created_at":"2016-12-07T16:14:37Z","updated_at":"2016-12-07T16:14:37Z","html_url":"https://github.com/commercetools/nodejs/pull/2#discussion_r91327034","pull_request_url":"https://api.github.com/repos/commercetools/nodejs/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/commercetools/nodejs/pulls/comments/91327034"},"html":{"href":"https://github.com/commercetools/nodejs/pull/2#discussion_r91327034"},"pull_request":{"href":"https://api.github.com/repos/commercetools/nodejs/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/commercetools/nodejs/pulls/2","id":96951082,"html_url":"https://github.com/commercetools/nodejs/pull/2","diff_url":"https://github.com/commercetools/nodejs/pull/2.diff","patch_url":"https://github.com/commercetools/nodejs/pull/2.patch","issue_url":"https://api.github.com/repos/commercetools/nodejs/issues/2","number":2,"state":"open","locked":false,"title":"Build setup improvements + (WIP) node-sdk packages","user":{"login":"emmenko","id":1110551,"avatar_url":"https://avatars.githubusercontent.com/u/1110551?v=3","gravatar_id":"","url":"https://api.github.com/users/emmenko","html_url":"https://github.com/emmenko","followers_url":"https://api.github.com/users/emmenko/followers","following_url":"https://api.github.com/users/emmenko/following{/other_user}","gists_url":"https://api.github.com/users/emmenko/gists{/gist_id}","starred_url":"https://api.github.com/users/emmenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmenko/subscriptions","organizations_url":"https://api.github.com/users/emmenko/orgs","repos_url":"https://api.github.com/users/emmenko/repos","events_url":"https://api.github.com/users/emmenko/events{/privacy}","received_events_url":"https://api.github.com/users/emmenko/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nI finally took some time to continue work on the new sdk. Since I want to have it split into different packages, what better chance to start doing it in our new monorepo ;)\r\n\r\n> Please **don't bother much** reviewing the `packages/*` stuff, it's still very much in progress. It's just there as a starting point, and **to test the different script commands** for packages usage.\r\n\r\nSo **focus on the setup changes** if you are reviewing this PR 😉 .\r\nI'll add some inline comments to explain some of the changes. Note that some stuff got removed / refactored because it didn't really work as expected with the packages, since we didn't really have proper packages to test it yet.\r\n\r\n","created_at":"2016-12-07T15:56:47Z","updated_at":"2016-12-07T16:14:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1472598bdcb327501eb9d5109fccfd57c218f14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/commercetools/nodejs/pulls/2/commits","review_comments_url":"https://api.github.com/repos/commercetools/nodejs/pulls/2/comments","review_comment_url":"https://api.github.com/repos/commercetools/nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/commercetools/nodejs/issues/2/comments","statuses_url":"https://api.github.com/repos/commercetools/nodejs/statuses/eef9fa51ccbe42bbb53cc0584b4949b5d882114a","head":{"label":"commercetools:packages-node-sdk","ref":"packages-node-sdk","sha":"eef9fa51ccbe42bbb53cc0584b4949b5d882114a","user":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":70048127,"name":"nodejs","full_name":"commercetools/nodejs","owner":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/nodejs","description":"(WIP) Everything related to the Node.js ecosystem for the commercetools platform.","fork":false,"url":"https://api.github.com/repos/commercetools/nodejs","forks_url":"https://api.github.com/repos/commercetools/nodejs/forks","keys_url":"https://api.github.com/repos/commercetools/nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/nodejs/teams","hooks_url":"https://api.github.com/repos/commercetools/nodejs/hooks","issue_events_url":"https://api.github.com/repos/commercetools/nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/nodejs/events","assignees_url":"https://api.github.com/repos/commercetools/nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/nodejs/tags","blobs_url":"https://api.github.com/repos/commercetools/nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/nodejs/languages","stargazers_url":"https://api.github.com/repos/commercetools/nodejs/stargazers","contributors_url":"https://api.github.com/repos/commercetools/nodejs/contributors","subscribers_url":"https://api.github.com/repos/commercetools/nodejs/subscribers","subscription_url":"https://api.github.com/repos/commercetools/nodejs/subscription","commits_url":"https://api.github.com/repos/commercetools/nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/nodejs/merges","archive_url":"https://api.github.com/repos/commercetools/nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/nodejs/downloads","issues_url":"https://api.github.com/repos/commercetools/nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/nodejs/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/nodejs/deployments","created_at":"2016-10-05T09:53:20Z","updated_at":"2016-10-13T07:04:35Z","pushed_at":"2016-12-07T15:56:47Z","git_url":"git://github.com/commercetools/nodejs.git","ssh_url":"git@github.com:commercetools/nodejs.git","clone_url":"https://github.com/commercetools/nodejs.git","svn_url":"https://github.com/commercetools/nodejs","homepage":"","size":26,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"commercetools:master","ref":"master","sha":"bc6263193c6f9a2126aacaa856e9a2f2c2f801c3","user":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"repo":{"id":70048127,"name":"nodejs","full_name":"commercetools/nodejs","owner":{"login":"commercetools","id":1084585,"avatar_url":"https://avatars.githubusercontent.com/u/1084585?v=3","gravatar_id":"","url":"https://api.github.com/users/commercetools","html_url":"https://github.com/commercetools","followers_url":"https://api.github.com/users/commercetools/followers","following_url":"https://api.github.com/users/commercetools/following{/other_user}","gists_url":"https://api.github.com/users/commercetools/gists{/gist_id}","starred_url":"https://api.github.com/users/commercetools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commercetools/subscriptions","organizations_url":"https://api.github.com/users/commercetools/orgs","repos_url":"https://api.github.com/users/commercetools/repos","events_url":"https://api.github.com/users/commercetools/events{/privacy}","received_events_url":"https://api.github.com/users/commercetools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/commercetools/nodejs","description":"(WIP) Everything related to the Node.js ecosystem for the commercetools platform.","fork":false,"url":"https://api.github.com/repos/commercetools/nodejs","forks_url":"https://api.github.com/repos/commercetools/nodejs/forks","keys_url":"https://api.github.com/repos/commercetools/nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commercetools/nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commercetools/nodejs/teams","hooks_url":"https://api.github.com/repos/commercetools/nodejs/hooks","issue_events_url":"https://api.github.com/repos/commercetools/nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/commercetools/nodejs/events","assignees_url":"https://api.github.com/repos/commercetools/nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/commercetools/nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/commercetools/nodejs/tags","blobs_url":"https://api.github.com/repos/commercetools/nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commercetools/nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commercetools/nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/commercetools/nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commercetools/nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/commercetools/nodejs/languages","stargazers_url":"https://api.github.com/repos/commercetools/nodejs/stargazers","contributors_url":"https://api.github.com/repos/commercetools/nodejs/contributors","subscribers_url":"https://api.github.com/repos/commercetools/nodejs/subscribers","subscription_url":"https://api.github.com/repos/commercetools/nodejs/subscription","commits_url":"https://api.github.com/repos/commercetools/nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/commercetools/nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/commercetools/nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/commercetools/nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/commercetools/nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/commercetools/nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commercetools/nodejs/merges","archive_url":"https://api.github.com/repos/commercetools/nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commercetools/nodejs/downloads","issues_url":"https://api.github.com/repos/commercetools/nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/commercetools/nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/commercetools/nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/commercetools/nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commercetools/nodejs/labels{/name}","releases_url":"https://api.github.com/repos/commercetools/nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/commercetools/nodejs/deployments","created_at":"2016-10-05T09:53:20Z","updated_at":"2016-10-13T07:04:35Z","pushed_at":"2016-12-07T15:56:47Z","git_url":"git://github.com/commercetools/nodejs.git","ssh_url":"git@github.com:commercetools/nodejs.git","clone_url":"https://github.com/commercetools/nodejs.git","svn_url":"https://github.com/commercetools/nodejs","homepage":"","size":26,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/commercetools/nodejs/pulls/2"},"html":{"href":"https://github.com/commercetools/nodejs/pull/2"},"issue":{"href":"https://api.github.com/repos/commercetools/nodejs/issues/2"},"comments":{"href":"https://api.github.com/repos/commercetools/nodejs/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/commercetools/nodejs/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/commercetools/nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/commercetools/nodejs/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/commercetools/nodejs/statuses/eef9fa51ccbe42bbb53cc0584b4949b5d882114a"}}}}
{"actor":{"display_login":"emmenko"}}