{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/69","id":28174680,"html_url":"https://github.com/tomojitakasu/RTKLIB/pull/69","diff_url":"https://github.com/tomojitakasu/RTKLIB/pull/69.diff","patch_url":"https://github.com/tomojitakasu/RTKLIB/pull/69.patch","issue_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues/69","number":69,"state":"closed","locked":false,"title":"Ublox FS32 type not correctly written for CFG-USB message","user":{"login":"flobehner","id":6056633,"avatar_url":"https://avatars.githubusercontent.com/u/6056633?v=3","gravatar_id":"","url":"https://api.github.com/users/flobehner","html_url":"https://github.com/flobehner","followers_url":"https://api.github.com/users/flobehner/followers","following_url":"https://api.github.com/users/flobehner/following{/other_user}","gists_url":"https://api.github.com/users/flobehner/gists{/gist_id}","starred_url":"https://api.github.com/users/flobehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flobehner/subscriptions","organizations_url":"https://api.github.com/users/flobehner/orgs","repos_url":"https://api.github.com/users/flobehner/repos","events_url":"https://api.github.com/users/flobehner/events{/privacy}","received_events_url":"https://api.github.com/users/flobehner/received_events","type":"User","site_admin":false},"body":"The FS32 type is not working as expected as the \"argument\" string is not null terminated (The ublox reference manual describes this type as \"32 ASCII bytes including 0-termination\").\r\nFurther using a string length of 32 results in the string terminator of the output string overwritten by the next argument. The changed code will leave the remaining part of the 31 char string uninitialized which should not be a problem.","created_at":"2015-01-28T08:03:06Z","updated_at":"2016-05-27T00:17:54Z","closed_at":"2016-05-27T00:17:54Z","merged_at":null,"merge_commit_sha":"bc0455ca0568c14ee829e707b4c15c96ff1404f8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/69/commits","review_comments_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/69/comments","review_comment_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues/69/comments","statuses_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/statuses/de475514b19a2fddc40682f5dd1919e53892cec5","head":{"label":"flobehner:patch-1","ref":"patch-1","sha":"de475514b19a2fddc40682f5dd1919e53892cec5","user":{"login":"flobehner","id":6056633,"avatar_url":"https://avatars.githubusercontent.com/u/6056633?v=3","gravatar_id":"","url":"https://api.github.com/users/flobehner","html_url":"https://github.com/flobehner","followers_url":"https://api.github.com/users/flobehner/followers","following_url":"https://api.github.com/users/flobehner/following{/other_user}","gists_url":"https://api.github.com/users/flobehner/gists{/gist_id}","starred_url":"https://api.github.com/users/flobehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flobehner/subscriptions","organizations_url":"https://api.github.com/users/flobehner/orgs","repos_url":"https://api.github.com/users/flobehner/repos","events_url":"https://api.github.com/users/flobehner/events{/privacy}","received_events_url":"https://api.github.com/users/flobehner/received_events","type":"User","site_admin":false},"repo":{"id":29956596,"name":"RTKLIB","full_name":"flobehner/RTKLIB","owner":{"login":"flobehner","id":6056633,"avatar_url":"https://avatars.githubusercontent.com/u/6056633?v=3","gravatar_id":"","url":"https://api.github.com/users/flobehner","html_url":"https://github.com/flobehner","followers_url":"https://api.github.com/users/flobehner/followers","following_url":"https://api.github.com/users/flobehner/following{/other_user}","gists_url":"https://api.github.com/users/flobehner/gists{/gist_id}","starred_url":"https://api.github.com/users/flobehner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flobehner/subscriptions","organizations_url":"https://api.github.com/users/flobehner/orgs","repos_url":"https://api.github.com/users/flobehner/repos","events_url":"https://api.github.com/users/flobehner/events{/privacy}","received_events_url":"https://api.github.com/users/flobehner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/flobehner/RTKLIB","description":null,"fork":true,"url":"https://api.github.com/repos/flobehner/RTKLIB","forks_url":"https://api.github.com/repos/flobehner/RTKLIB/forks","keys_url":"https://api.github.com/repos/flobehner/RTKLIB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flobehner/RTKLIB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flobehner/RTKLIB/teams","hooks_url":"https://api.github.com/repos/flobehner/RTKLIB/hooks","issue_events_url":"https://api.github.com/repos/flobehner/RTKLIB/issues/events{/number}","events_url":"https://api.github.com/repos/flobehner/RTKLIB/events","assignees_url":"https://api.github.com/repos/flobehner/RTKLIB/assignees{/user}","branches_url":"https://api.github.com/repos/flobehner/RTKLIB/branches{/branch}","tags_url":"https://api.github.com/repos/flobehner/RTKLIB/tags","blobs_url":"https://api.github.com/repos/flobehner/RTKLIB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flobehner/RTKLIB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flobehner/RTKLIB/git/refs{/sha}","trees_url":"https://api.github.com/repos/flobehner/RTKLIB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flobehner/RTKLIB/statuses/{sha}","languages_url":"https://api.github.com/repos/flobehner/RTKLIB/languages","stargazers_url":"https://api.github.com/repos/flobehner/RTKLIB/stargazers","contributors_url":"https://api.github.com/repos/flobehner/RTKLIB/contributors","subscribers_url":"https://api.github.com/repos/flobehner/RTKLIB/subscribers","subscription_url":"https://api.github.com/repos/flobehner/RTKLIB/subscription","commits_url":"https://api.github.com/repos/flobehner/RTKLIB/commits{/sha}","git_commits_url":"https://api.github.com/repos/flobehner/RTKLIB/git/commits{/sha}","comments_url":"https://api.github.com/repos/flobehner/RTKLIB/comments{/number}","issue_comment_url":"https://api.github.com/repos/flobehner/RTKLIB/issues/comments{/number}","contents_url":"https://api.github.com/repos/flobehner/RTKLIB/contents/{+path}","compare_url":"https://api.github.com/repos/flobehner/RTKLIB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flobehner/RTKLIB/merges","archive_url":"https://api.github.com/repos/flobehner/RTKLIB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flobehner/RTKLIB/downloads","issues_url":"https://api.github.com/repos/flobehner/RTKLIB/issues{/number}","pulls_url":"https://api.github.com/repos/flobehner/RTKLIB/pulls{/number}","milestones_url":"https://api.github.com/repos/flobehner/RTKLIB/milestones{/number}","notifications_url":"https://api.github.com/repos/flobehner/RTKLIB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flobehner/RTKLIB/labels{/name}","releases_url":"https://api.github.com/repos/flobehner/RTKLIB/releases{/id}","deployments_url":"https://api.github.com/repos/flobehner/RTKLIB/deployments","created_at":"2015-01-28T07:50:04Z","updated_at":"2015-05-15T12:12:22Z","pushed_at":"2015-04-29T12:03:17Z","git_url":"git://github.com/flobehner/RTKLIB.git","ssh_url":"git@github.com:flobehner/RTKLIB.git","clone_url":"https://github.com/flobehner/RTKLIB.git","svn_url":"https://github.com/flobehner/RTKLIB","homepage":null,"size":176429,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"tomojitakasu:master","ref":"master","sha":"2e69ad2ed009e1ec895c61515b5244457a23d170","user":{"login":"tomojitakasu","id":4287338,"avatar_url":"https://avatars.githubusercontent.com/u/4287338?v=3","gravatar_id":"","url":"https://api.github.com/users/tomojitakasu","html_url":"https://github.com/tomojitakasu","followers_url":"https://api.github.com/users/tomojitakasu/followers","following_url":"https://api.github.com/users/tomojitakasu/following{/other_user}","gists_url":"https://api.github.com/users/tomojitakasu/gists{/gist_id}","starred_url":"https://api.github.com/users/tomojitakasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomojitakasu/subscriptions","organizations_url":"https://api.github.com/users/tomojitakasu/orgs","repos_url":"https://api.github.com/users/tomojitakasu/repos","events_url":"https://api.github.com/users/tomojitakasu/events{/privacy}","received_events_url":"https://api.github.com/users/tomojitakasu/received_events","type":"User","site_admin":false},"repo":{"id":9743267,"name":"RTKLIB","full_name":"tomojitakasu/RTKLIB","owner":{"login":"tomojitakasu","id":4287338,"avatar_url":"https://avatars.githubusercontent.com/u/4287338?v=3","gravatar_id":"","url":"https://api.github.com/users/tomojitakasu","html_url":"https://github.com/tomojitakasu","followers_url":"https://api.github.com/users/tomojitakasu/followers","following_url":"https://api.github.com/users/tomojitakasu/following{/other_user}","gists_url":"https://api.github.com/users/tomojitakasu/gists{/gist_id}","starred_url":"https://api.github.com/users/tomojitakasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomojitakasu/subscriptions","organizations_url":"https://api.github.com/users/tomojitakasu/orgs","repos_url":"https://api.github.com/users/tomojitakasu/repos","events_url":"https://api.github.com/users/tomojitakasu/events{/privacy}","received_events_url":"https://api.github.com/users/tomojitakasu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomojitakasu/RTKLIB","description":null,"fork":false,"url":"https://api.github.com/repos/tomojitakasu/RTKLIB","forks_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/forks","keys_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/teams","hooks_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/hooks","issue_events_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues/events{/number}","events_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/events","assignees_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/assignees{/user}","branches_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/branches{/branch}","tags_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/tags","blobs_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/statuses/{sha}","languages_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/languages","stargazers_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/stargazers","contributors_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/contributors","subscribers_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/subscribers","subscription_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/subscription","commits_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/contents/{+path}","compare_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/merges","archive_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/downloads","issues_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues{/number}","pulls_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls{/number}","milestones_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/milestones{/number}","notifications_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/labels{/name}","releases_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/releases{/id}","deployments_url":"https://api.github.com/repos/tomojitakasu/RTKLIB/deployments","created_at":"2013-04-29T07:50:56Z","updated_at":"2016-05-25T00:08:43Z","pushed_at":"2016-05-27T00:17:47Z","git_url":"git://github.com/tomojitakasu/RTKLIB.git","ssh_url":"git@github.com:tomojitakasu/RTKLIB.git","clone_url":"https://github.com/tomojitakasu/RTKLIB.git","svn_url":"https://github.com/tomojitakasu/RTKLIB","homepage":null,"size":341321,"stargazers_count":310,"watchers_count":310,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":260,"mirror_url":null,"open_issues_count":83,"forks":260,"open_issues":83,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/69"},"html":{"href":"https://github.com/tomojitakasu/RTKLIB/pull/69"},"issue":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues/69"},"comments":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/tomojitakasu/RTKLIB/statuses/de475514b19a2fddc40682f5dd1919e53892cec5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":35,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"tomojitakasu"}}