{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/imminence/pulls/comments/58530755","id":58530755,"diff_hunk":"@@ -115,8 +137,16 @@\n   save_and_open_page\n end\n \n-Then /^I fill in the form to create the \"(.*?)\" service$/ do |name|\n-  fill_in_form_with(name, csv_path_for_data(name))\n+When /^I fill out the form with the following attributes to create a service:$/ do |table|\n+  params = table.rows_hash.symbolize_keys!\n+  assert params[:name]","path":"features/step_definitions/data_set_steps.rb","position":null,"original_position":56,"commit_id":"862aba242c0a4eb78019d18877805c2a6fec20d2","original_commit_id":"8db4cca43603dbc9f53831ff92b89154bf352487","user":{"login":"h-lame","id":608,"avatar_url":"https://avatars.githubusercontent.com/u/608?v=3","gravatar_id":"","url":"https://api.github.com/users/h-lame","html_url":"https://github.com/h-lame","followers_url":"https://api.github.com/users/h-lame/followers","following_url":"https://api.github.com/users/h-lame/following{/other_user}","gists_url":"https://api.github.com/users/h-lame/gists{/gist_id}","starred_url":"https://api.github.com/users/h-lame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-lame/subscriptions","organizations_url":"https://api.github.com/users/h-lame/orgs","repos_url":"https://api.github.com/users/h-lame/repos","events_url":"https://api.github.com/users/h-lame/events{/privacy}","received_events_url":"https://api.github.com/users/h-lame/received_events","type":"User","site_admin":false},"body":"Your intention is fine, however, it would be better to raise an `ArgumentError` instead.  Not passing in a `:name` param is a failure of the test-harness code, rather than a failure of the code under test.  An `assert` will fail with a test failure, whereas an `ArgumentError` will cause a test error and while the result is the same (the test doesn't pass) the semantic meaning of why is different and should point the developer at the correct place to fix.","created_at":"2016-04-05T12:44:30Z","updated_at":"2016-04-05T12:44:30Z","html_url":"https://github.com/alphagov/imminence/pull/133#discussion_r58530755","pull_request_url":"https://api.github.com/repos/alphagov/imminence/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/alphagov/imminence/pulls/comments/58530755"},"html":{"href":"https://github.com/alphagov/imminence/pull/133#discussion_r58530755"},"pull_request":{"href":"https://api.github.com/repos/alphagov/imminence/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/imminence/pulls/133","id":65159240,"html_url":"https://github.com/alphagov/imminence/pull/133","diff_url":"https://github.com/alphagov/imminence/pull/133.diff","patch_url":"https://github.com/alphagov/imminence/pull/133.patch","issue_url":"https://api.github.com/repos/alphagov/imminence/issues/133","number":133,"state":"open","locked":false,"title":"Add soft validation for snac codes","user":{"login":"davidbasalla","id":5112255,"avatar_url":"https://avatars.githubusercontent.com/u/5112255?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbasalla","html_url":"https://github.com/davidbasalla","followers_url":"https://api.github.com/users/davidbasalla/followers","following_url":"https://api.github.com/users/davidbasalla/following{/other_user}","gists_url":"https://api.github.com/users/davidbasalla/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbasalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbasalla/subscriptions","organizations_url":"https://api.github.com/users/davidbasalla/orgs","repos_url":"https://api.github.com/users/davidbasalla/repos","events_url":"https://api.github.com/users/davidbasalla/events{/privacy}","received_events_url":"https://api.github.com/users/davidbasalla/received_events","type":"User","site_admin":false},"body":"[Link to Trello card](https://trello.com/c/mnwBFd9m/341-improve-imminence-validations-for-la-bounded-services-part-1-2)\r\n\r\nTo make it clearer to the user, we add warnings for when a Service that uses 'Local authority' as location match type (and therefore relies on SNAC codes) has datasets which have missing SNAC entries.\r\n\r\nThis PR implements the following:\r\n1.) A summary of number of places with missing SNACs is shown on the Service 'active data set' tab\r\n2.) A summary of errors is added to each dataset panel on the Service 'history' tab\r\n3.) A warning panel is displayed for each dataset panel to make it easier to spot\r\n\r\nThe actual code to implement these changes are fairly small, but more work had to be done to make the Cucumber tests more comprehensive. See commits for individual steps.\r\n\r\n# 'Active data set' tab - Before\r\n\r\n![screen shot 2016-04-04 at 15 40 52](https://cloud.githubusercontent.com/assets/5112255/14251912/fafc273c-fa7c-11e5-919b-fd51b5bc8f90.png)\r\n\r\n# 'Active data set' tab - After\r\n\r\n![screen shot 2016-04-04 at 15 41 15](https://cloud.githubusercontent.com/assets/5112255/14251914/fd893fc6-fa7c-11e5-842c-30a90b7302bc.png)\r\n\r\n# 'Version history' tab - Before\r\n\r\n![screen shot 2016-04-04 at 15 41 52](https://cloud.githubusercontent.com/assets/5112255/14251918/02a63572-fa7d-11e5-83dd-cdc7443d23c5.png)\r\n\r\n# 'Version history' tab - After\r\n\r\n![screen shot 2016-04-04 at 15 41 31](https://cloud.githubusercontent.com/assets/5112255/14251931/0c4da448-fa7d-11e5-9392-b56767b59f86.png)","created_at":"2016-04-04T14:58:53Z","updated_at":"2016-04-05T12:44:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9d534d1b64ebb558be61236b94449d059028099","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/imminence/pulls/133/commits","review_comments_url":"https://api.github.com/repos/alphagov/imminence/pulls/133/comments","review_comment_url":"https://api.github.com/repos/alphagov/imminence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/imminence/issues/133/comments","statuses_url":"https://api.github.com/repos/alphagov/imminence/statuses/862aba242c0a4eb78019d18877805c2a6fec20d2","head":{"label":"alphagov:add-soft-validation-for-snac-codes","ref":"add-soft-validation-for-snac-codes","sha":"862aba242c0a4eb78019d18877805c2a6fec20d2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2147546,"name":"imminence","full_name":"alphagov/imminence","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/imminence","description":"\"Find My Nearest\" API and management tools","fork":false,"url":"https://api.github.com/repos/alphagov/imminence","forks_url":"https://api.github.com/repos/alphagov/imminence/forks","keys_url":"https://api.github.com/repos/alphagov/imminence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/imminence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/imminence/teams","hooks_url":"https://api.github.com/repos/alphagov/imminence/hooks","issue_events_url":"https://api.github.com/repos/alphagov/imminence/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/imminence/events","assignees_url":"https://api.github.com/repos/alphagov/imminence/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/imminence/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/imminence/tags","blobs_url":"https://api.github.com/repos/alphagov/imminence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/imminence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/imminence/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/imminence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/imminence/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/imminence/languages","stargazers_url":"https://api.github.com/repos/alphagov/imminence/stargazers","contributors_url":"https://api.github.com/repos/alphagov/imminence/contributors","subscribers_url":"https://api.github.com/repos/alphagov/imminence/subscribers","subscription_url":"https://api.github.com/repos/alphagov/imminence/subscription","commits_url":"https://api.github.com/repos/alphagov/imminence/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/imminence/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/imminence/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/imminence/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/imminence/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/imminence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/imminence/merges","archive_url":"https://api.github.com/repos/alphagov/imminence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/imminence/downloads","issues_url":"https://api.github.com/repos/alphagov/imminence/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/imminence/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/imminence/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/imminence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/imminence/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/imminence/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/imminence/deployments","created_at":"2011-08-03T08:52:34Z","updated_at":"2014-12-10T14:07:32Z","pushed_at":"2016-04-04T16:11:30Z","git_url":"git://github.com/alphagov/imminence.git","ssh_url":"git@github.com:alphagov/imminence.git","clone_url":"https://github.com/alphagov/imminence.git","svn_url":"https://github.com/alphagov/imminence","homepage":"","size":1702,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":6,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"01c4ab663ddadd87840ec9c2fb5c8f911e848e07","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2147546,"name":"imminence","full_name":"alphagov/imminence","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/imminence","description":"\"Find My Nearest\" API and management tools","fork":false,"url":"https://api.github.com/repos/alphagov/imminence","forks_url":"https://api.github.com/repos/alphagov/imminence/forks","keys_url":"https://api.github.com/repos/alphagov/imminence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/imminence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/imminence/teams","hooks_url":"https://api.github.com/repos/alphagov/imminence/hooks","issue_events_url":"https://api.github.com/repos/alphagov/imminence/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/imminence/events","assignees_url":"https://api.github.com/repos/alphagov/imminence/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/imminence/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/imminence/tags","blobs_url":"https://api.github.com/repos/alphagov/imminence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/imminence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/imminence/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/imminence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/imminence/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/imminence/languages","stargazers_url":"https://api.github.com/repos/alphagov/imminence/stargazers","contributors_url":"https://api.github.com/repos/alphagov/imminence/contributors","subscribers_url":"https://api.github.com/repos/alphagov/imminence/subscribers","subscription_url":"https://api.github.com/repos/alphagov/imminence/subscription","commits_url":"https://api.github.com/repos/alphagov/imminence/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/imminence/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/imminence/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/imminence/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/imminence/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/imminence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/imminence/merges","archive_url":"https://api.github.com/repos/alphagov/imminence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/imminence/downloads","issues_url":"https://api.github.com/repos/alphagov/imminence/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/imminence/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/imminence/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/imminence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/imminence/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/imminence/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/imminence/deployments","created_at":"2011-08-03T08:52:34Z","updated_at":"2014-12-10T14:07:32Z","pushed_at":"2016-04-04T16:11:30Z","git_url":"git://github.com/alphagov/imminence.git","ssh_url":"git@github.com:alphagov/imminence.git","clone_url":"https://github.com/alphagov/imminence.git","svn_url":"https://github.com/alphagov/imminence","homepage":"","size":1702,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/imminence/pulls/133"},"html":{"href":"https://github.com/alphagov/imminence/pull/133"},"issue":{"href":"https://api.github.com/repos/alphagov/imminence/issues/133"},"comments":{"href":"https://api.github.com/repos/alphagov/imminence/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/imminence/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/imminence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/imminence/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/imminence/statuses/862aba242c0a4eb78019d18877805c2a6fec20d2"}}}}