{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/gecko-dev/issues/339","repository_url":"https://api.github.com/repos/devtools-html/gecko-dev","labels_url":"https://api.github.com/repos/devtools-html/gecko-dev/issues/339/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/gecko-dev/issues/339/comments","events_url":"https://api.github.com/repos/devtools-html/gecko-dev/issues/339/events","html_url":"https://github.com/devtools-html/gecko-dev/pull/339","id":180367326,"number":339,"title":"Add console.group support","user":{"login":"nchevobbe","id":578107,"avatar_url":"https://avatars.githubusercontent.com/u/578107?v=3","gravatar_id":"","url":"https://api.github.com/users/nchevobbe","html_url":"https://github.com/nchevobbe","followers_url":"https://api.github.com/users/nchevobbe/followers","following_url":"https://api.github.com/users/nchevobbe/following{/other_user}","gists_url":"https://api.github.com/users/nchevobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/nchevobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchevobbe/subscriptions","organizations_url":"https://api.github.com/users/nchevobbe/orgs","repos_url":"https://api.github.com/users/nchevobbe/repos","events_url":"https://api.github.com/users/nchevobbe/events{/privacy}","received_events_url":"https://api.github.com/users/nchevobbe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2016-09-30T18:10:16Z","updated_at":"2016-10-05T19:41:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/devtools-html/gecko-dev/pulls/339","html_url":"https://github.com/devtools-html/gecko-dev/pull/339","diff_url":"https://github.com/devtools-html/gecko-dev/pull/339.diff","patch_url":"https://github.com/devtools-html/gecko-dev/pull/339.patch"},"body":"Fixes #44\r\n\r\nTest instructions : \r\n1. `npm test`\r\n\r\n@linclark @bgrins I think this is working pretty well like this. I wanted to have your opinion about it before the weekend, so I can change what needs to be, and write the tests. \r\n\r\nThe main ideas here are: \r\n- we add a `group` property on the state, which is a map which contains the parent groups of a group\r\n- we add a `currentGroup` in order to assign the id of the latest created group in a `groupId` on the message\r\n- we re-use the existing `messagesUiById` to track the open/closed state of the group\r\n- in the selector, we only return the message which are in an opened group\r\n- when pruning, if there is one, we output the last non-closed group\r\n\r\nSince I added a lot of thing in the messages selector, I revamped how we do the filtering to something simpler to understand IMO.\r\n\r\nI tweaked the design a little bit, but I think we could have a follow-up with helen's take on this. \r\n\r\nAnd that's it :) Please tell me what you think about this, I'll do my best to have it done over the week-end. Thanks !\r\n"},"comment":{"url":"https://api.github.com/repos/devtools-html/gecko-dev/issues/comments/251777468","html_url":"https://github.com/devtools-html/gecko-dev/pull/339#issuecomment-251777468","issue_url":"https://api.github.com/repos/devtools-html/gecko-dev/issues/339","id":251777468,"user":{"login":"nchevobbe","id":578107,"avatar_url":"https://avatars.githubusercontent.com/u/578107?v=3","gravatar_id":"","url":"https://api.github.com/users/nchevobbe","html_url":"https://github.com/nchevobbe","followers_url":"https://api.github.com/users/nchevobbe/followers","following_url":"https://api.github.com/users/nchevobbe/following{/other_user}","gists_url":"https://api.github.com/users/nchevobbe/gists{/gist_id}","starred_url":"https://api.github.com/users/nchevobbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nchevobbe/subscriptions","organizations_url":"https://api.github.com/users/nchevobbe/orgs","repos_url":"https://api.github.com/users/nchevobbe/repos","events_url":"https://api.github.com/users/nchevobbe/events{/privacy}","received_events_url":"https://api.github.com/users/nchevobbe/received_events","type":"User","site_admin":false},"created_at":"2016-10-05T19:41:01Z","updated_at":"2016-10-05T19:41:01Z","body":"@linclark I think everything is okay for review here"}}
{"actor":{"display_login":"nchevobbe"}}