{"action":"created","issue":{"url":"https://api.github.com/repos/jsperf/jsperf.com/issues/253","repository_url":"https://api.github.com/repos/jsperf/jsperf.com","labels_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/253/labels{/name}","comments_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/253/comments","events_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/253/events","html_url":"https://github.com/jsperf/jsperf.com/pull/253","id":186446828,"number":253,"title":"Make it easier to contribute","user":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"assignees":[{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2016-11-01T02:10:27Z","updated_at":"2016-11-29T19:26:55Z","closed_at":"2016-11-08T18:14:10Z","pull_request":{"url":"https://api.github.com/repos/jsperf/jsperf.com/pulls/253","html_url":"https://github.com/jsperf/jsperf.com/pull/253","diff_url":"https://github.com/jsperf/jsperf.com/pull/253.diff","patch_url":"https://github.com/jsperf/jsperf.com/pull/253.patch"},"body":"\r\nWe've been seeing more contributions from the community which is great! However, it was noticably difficult due to Docker, OAuth, and other pieces that weren't core to the real functionality of jsperf. This PR aims to address a lot of the hurdles to local development.\r\n\r\n- [x] no more Docker (run node directly)\r\n- [x] no more Docker Compose (bring your own mysql)\r\n- [x] no more end to end tests (that were never being run)\r\n- [x] no more (faulty) setup scripts (define everything in `.env` yourself)\r\n- [x] explicit oauth callback (no more guessing based on scheme, domain, port, etc.)\r\n- [x] replace `debug` with general logger\r\n- [x] log to cloud service in addition to console\r\n- [x] turn off Docker Hub webhooks\r\n- [x] database schema migration (that automatically applies)"},"comment":{"url":"https://api.github.com/repos/jsperf/jsperf.com/issues/comments/263672049","html_url":"https://github.com/jsperf/jsperf.com/pull/253#issuecomment-263672049","issue_url":"https://api.github.com/repos/jsperf/jsperf.com/issues/253","id":263672049,"user":{"login":"maxbeatty","id":93179,"avatar_url":"https://avatars.githubusercontent.com/u/93179?v=3","gravatar_id":"","url":"https://api.github.com/users/maxbeatty","html_url":"https://github.com/maxbeatty","followers_url":"https://api.github.com/users/maxbeatty/followers","following_url":"https://api.github.com/users/maxbeatty/following{/other_user}","gists_url":"https://api.github.com/users/maxbeatty/gists{/gist_id}","starred_url":"https://api.github.com/users/maxbeatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxbeatty/subscriptions","organizations_url":"https://api.github.com/users/maxbeatty/orgs","repos_url":"https://api.github.com/users/maxbeatty/repos","events_url":"https://api.github.com/users/maxbeatty/events{/privacy}","received_events_url":"https://api.github.com/users/maxbeatty/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T19:26:55Z","updated_at":"2016-11-29T19:26:55Z","body":"A few things I noticed:\r\n\r\n- not wanting to learn or use Docker (database host being hardcoded for Docker required local workarounds folks in this camp)\r\n- challenges getting Docker working (there were a lot of moving pieces, underlying dependencies changed over time, spent more time supporting Docker than getting jsPerf built)\r\n- development workflow preference (\"edit file, refresh browser, see changes\" not supported because that's not how we ran Docker in \"production\")\r\n- OAuth callback URLs were a pain because of how ports were appended or not depending on situations or if you were using a VM for Docker\r\n"}}
{"actor":{"display_login":"maxbeatty"}}