{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81079427","pull_request_review_id":2085176,"id":81079427,"diff_hunk":"@@ -56,6 +56,9 @@ func NewCmdJoin(out io.Writer, s *kubeadmapi.KubeadmConfig) *cobra.Command {\n \t\t&s.Secrets.GivenToken, \"token\", \"\",\n \t\t\"(required) Shared secret used to secure bootstrap. Must match the output of 'kubeadm init'\",\n \t)\n+\tcmd.PersistentFlags().DurationVar(&s.JoinFlags.RetryTimeout, \"retry-timeout\", 5,","path":"cmd/kubeadm/app/cmd/join.go","position":4,"original_position":4,"commit_id":"7309ed266d7657379b92428b0a356034e3a0498a","original_commit_id":"7309ed266d7657379b92428b0a356034e3a0498a","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"body":"You are probably right, one conf flag less with a reasonable default sounds practically applicable.","created_at":"2016-09-29T07:35:25Z","updated_at":"2016-09-29T07:35:25Z","html_url":"https://github.com/kubernetes/kubernetes/pull/33543#discussion_r81079427","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/81079427"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33543#discussion_r81079427"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543","id":86891578,"html_url":"https://github.com/kubernetes/kubernetes/pull/33543","diff_url":"https://github.com/kubernetes/kubernetes/pull/33543.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/33543.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543","number":33543,"state":"open","locked":false,"title":"[WIP] Decouple master bootstrap from CSR in kubeadm","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**: enhance `kubeadm` to allow for parallel provisioning of API endpoints and slave nodes\r\n\r\n**Fixes**: https://github.com/kubernetes/kubernetes/issues/33542\r\n\r\n**Special notes for your reviewer**:\r\nThis is work in progress, trying to \r\n\r\n * Introduce a concurrent retry mechanism for bootstrapping\r\n   with a single API endpoint\r\n * Refactor API client creation, decouple from CSR\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kubernetes/33543)\n<!-- Reviewable:end -->\n","created_at":"2016-09-27T09:22:33Z","updated_at":"2016-09-29T07:35:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"674c41d794da481001ba6e3c4e8f1a46dc744acd","assignee":{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},"assignees":[{"login":"krousey","id":157083,"avatar_url":"https://avatars.githubusercontent.com/u/157083?v=3","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars.githubusercontent.com/u/251467?v=3","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7309ed266d7657379b92428b0a356034e3a0498a","head":{"label":"taimir:kubeadm","ref":"kubeadm","sha":"7309ed266d7657379b92428b0a356034e3a0498a","user":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"repo":{"id":52962277,"name":"kubernetes","full_name":"taimir/kubernetes","owner":{"login":"taimir","id":8666527,"avatar_url":"https://avatars.githubusercontent.com/u/8666527?v=3","gravatar_id":"","url":"https://api.github.com/users/taimir","html_url":"https://github.com/taimir","followers_url":"https://api.github.com/users/taimir/followers","following_url":"https://api.github.com/users/taimir/following{/other_user}","gists_url":"https://api.github.com/users/taimir/gists{/gist_id}","starred_url":"https://api.github.com/users/taimir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taimir/subscriptions","organizations_url":"https://api.github.com/users/taimir/orgs","repos_url":"https://api.github.com/users/taimir/repos","events_url":"https://api.github.com/users/taimir/events{/privacy}","received_events_url":"https://api.github.com/users/taimir/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taimir/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/taimir/kubernetes","forks_url":"https://api.github.com/repos/taimir/kubernetes/forks","keys_url":"https://api.github.com/repos/taimir/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taimir/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taimir/kubernetes/teams","hooks_url":"https://api.github.com/repos/taimir/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/taimir/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/taimir/kubernetes/events","assignees_url":"https://api.github.com/repos/taimir/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/taimir/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/taimir/kubernetes/tags","blobs_url":"https://api.github.com/repos/taimir/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taimir/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taimir/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/taimir/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taimir/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/taimir/kubernetes/languages","stargazers_url":"https://api.github.com/repos/taimir/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/taimir/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/taimir/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/taimir/kubernetes/subscription","commits_url":"https://api.github.com/repos/taimir/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/taimir/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/taimir/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/taimir/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/taimir/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/taimir/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taimir/kubernetes/merges","archive_url":"https://api.github.com/repos/taimir/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taimir/kubernetes/downloads","issues_url":"https://api.github.com/repos/taimir/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/taimir/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/taimir/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/taimir/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taimir/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/taimir/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/taimir/kubernetes/deployments","created_at":"2016-03-02T12:48:56Z","updated_at":"2016-03-02T12:49:09Z","pushed_at":"2016-09-27T09:04:11Z","git_url":"git://github.com/taimir/kubernetes.git","ssh_url":"git@github.com:taimir/kubernetes.git","clone_url":"https://github.com/taimir/kubernetes.git","svn_url":"https://github.com/taimir/kubernetes","homepage":"http://kubernetes.io","size":324427,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"69fd1e04b0b02250599d9e1c1dfd9798eac43838","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2016-09-29T07:14:26Z","pushed_at":"2016-09-29T07:23:53Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":573716,"stargazers_count":17166,"watchers_count":17166,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5567,"mirror_url":null,"open_issues_count":4666,"forks":5567,"open_issues":4666,"watchers":17166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/33543"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/33543/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/33543/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/7309ed266d7657379b92428b0a356034e3a0498a"}}}}
{"actor":{"display_login":"taimir"}}