{"action":"created","issue":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2160","repository_url":"https://api.github.com/repos/ReactiveX/rxjs","labels_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2160/labels{/name}","comments_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2160/comments","events_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2160/events","html_url":"https://github.com/ReactiveX/rxjs/issues/2160","id":192373247,"number":2160,"title":"takeUntil specs (or docs) wrong.","user":{"login":"Dorus","id":4461459,"avatar_url":"https://avatars.githubusercontent.com/u/4461459?v=3","gravatar_id":"","url":"https://api.github.com/users/Dorus","html_url":"https://github.com/Dorus","followers_url":"https://api.github.com/users/Dorus/followers","following_url":"https://api.github.com/users/Dorus/following{/other_user}","gists_url":"https://api.github.com/users/Dorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorus/subscriptions","organizations_url":"https://api.github.com/users/Dorus/orgs","repos_url":"https://api.github.com/users/Dorus/repos","events_url":"https://api.github.com/users/Dorus/events{/privacy}","received_events_url":"https://api.github.com/users/Dorus/received_events","type":"User","site_admin":false},"labels":[{"id":187400551,"url":"https://api.github.com/repos/ReactiveX/rxjs/labels/type:%20bug","name":"type: bug","color":"fc2929","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-29T19:17:23Z","updated_at":"2016-11-29T19:37:00Z","closed_at":null,"body":"`takeUntil` on [reactivex.io](http://reactivex.io/documentation/operators/takeuntil.html) states\r\n\r\n> The TakeUntil subscribes and begins mirroring the source Observable. It also monitors a second Observable that you provide. If this second Observable emits an item or **sends a termination notification,** the Observable returned by TakeUntil stops mirroring the source Observable and terminates.\r\n\r\n(emphasise is mine)\r\n\r\nSimilar, [the docs](http://reactivex.io/rxjs/class/es6/Observable.js~Observable.html#instance-method-takeUntil) state: \r\n\r\n> **`takeUntil`** subscribes and begins mirroring the source Observable. It also monitors a second Observable, `notifier` that you provide. If the `notifier` emits a value **or a complete notification**, the output Observable stops mirroring the source Observable and completes.\r\n\r\n(emphasise is mine)\r\n\r\nHowever, in [the specs](http://reactivex.io/rxjs/test-file/spec-js/operators/takeUntil-spec.js.html#lineNumber26): \r\n>```Js\r\n>it('should take all values when notifier is empty', function () {\r\n>```\r\n\r\nI think the correct behaviour would be to terminate when the `notifier` terminates, however at the very least the docs should be in line with the specs."},"comment":{"url":"https://api.github.com/repos/ReactiveX/rxjs/issues/comments/263674994","html_url":"https://github.com/ReactiveX/rxjs/issues/2160#issuecomment-263674994","issue_url":"https://api.github.com/repos/ReactiveX/rxjs/issues/2160","id":263674994,"user":{"login":"Dorus","id":4461459,"avatar_url":"https://avatars.githubusercontent.com/u/4461459?v=3","gravatar_id":"","url":"https://api.github.com/users/Dorus","html_url":"https://github.com/Dorus","followers_url":"https://api.github.com/users/Dorus/followers","following_url":"https://api.github.com/users/Dorus/following{/other_user}","gists_url":"https://api.github.com/users/Dorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorus/subscriptions","organizations_url":"https://api.github.com/users/Dorus/orgs","repos_url":"https://api.github.com/users/Dorus/repos","events_url":"https://api.github.com/users/Dorus/events{/privacy}","received_events_url":"https://api.github.com/users/Dorus/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T19:37:00Z","updated_at":"2016-11-29T19:37:00Z","body":"For what it is worth. Rx.Net does not terminate on `empty`. RxJava does terminate on `empty`. That might explain why reactivex.io is confused on the subject."}}
{"actor":{"display_login":"Dorus"}}