{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/7400","repository_url":"https://api.github.com/repos/mozilla/pdf.js","labels_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7400/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7400/comments","events_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7400/events","html_url":"https://github.com/mozilla/pdf.js/pull/7400","id":159656700,"number":7400,"title":"[Firefox addon] Change the minimum supported version to Firefox 38 and remove a bunch old no longer necessary fallback code","user":{"login":"Snuffleupagus","id":2692120,"avatar_url":"https://avatars.githubusercontent.com/u/2692120?v=3","gravatar_id":"","url":"https://api.github.com/users/Snuffleupagus","html_url":"https://github.com/Snuffleupagus","followers_url":"https://api.github.com/users/Snuffleupagus/followers","following_url":"https://api.github.com/users/Snuffleupagus/following{/other_user}","gists_url":"https://api.github.com/users/Snuffleupagus/gists{/gist_id}","starred_url":"https://api.github.com/users/Snuffleupagus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Snuffleupagus/subscriptions","organizations_url":"https://api.github.com/users/Snuffleupagus/orgs","repos_url":"https://api.github.com/users/Snuffleupagus/repos","events_url":"https://api.github.com/users/Snuffleupagus/events{/privacy}","received_events_url":"https://api.github.com/users/Snuffleupagus/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/1-addon","name":"1-addon","color":"DDDDDD"},{"url":"https://api.github.com/repos/mozilla/pdf.js/labels/4-firefox-specific","name":"4-firefox-specific","color":"e102d8"}],"state":"open","locked":false,"assignee":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"milestone":null,"comments":8,"created_at":"2016-06-10T15:08:47Z","updated_at":"2016-06-15T12:23:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/pdf.js/pulls/7400","html_url":"https://github.com/mozilla/pdf.js/pull/7400","diff_url":"https://github.com/mozilla/pdf.js/pull/7400.diff","patch_url":"https://github.com/mozilla/pdf.js/pull/7400.patch"},"body":"From the discussion in issue #7386, it wasn't really clear if we can restrict addon support to Firefox `45` (i.e. the version that corresponds to the *current* ESR version).\r\n\r\nHowever, we have a bunch of code for *very* old Firefox versions. Hence this patch changes the minimum supported version to Firefox `38` (which was released on `2015-05-12`, and correspond to the *previous* ESR version), and removes code that only applies to old Firefox versions.\r\n\r\nRegardless what we end up deciding regarding addon support for previous Firefox versions, given the amount of code that even the Firefox `>= 38` condition lets us remove, I certainly think that there is value in doing this.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mozilla/pdf.js/7400)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/mozilla/pdf.js/issues/comments/226171318","html_url":"https://github.com/mozilla/pdf.js/pull/7400#issuecomment-226171318","issue_url":"https://api.github.com/repos/mozilla/pdf.js/issues/7400","id":226171318,"user":{"login":"yurydelendik","id":1523410,"avatar_url":"https://avatars.githubusercontent.com/u/1523410?v=3","gravatar_id":"","url":"https://api.github.com/users/yurydelendik","html_url":"https://github.com/yurydelendik","followers_url":"https://api.github.com/users/yurydelendik/followers","following_url":"https://api.github.com/users/yurydelendik/following{/other_user}","gists_url":"https://api.github.com/users/yurydelendik/gists{/gist_id}","starred_url":"https://api.github.com/users/yurydelendik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurydelendik/subscriptions","organizations_url":"https://api.github.com/users/yurydelendik/orgs","repos_url":"https://api.github.com/users/yurydelendik/repos","events_url":"https://api.github.com/users/yurydelendik/events{/privacy}","received_events_url":"https://api.github.com/users/yurydelendik/received_events","type":"User","site_admin":false},"created_at":"2016-06-15T12:23:36Z","updated_at":"2016-06-15T12:23:36Z","body":"/botio-windows preview"}}
{"actor":{"display_login":"yurydelendik"}}