{"action":"created","issue":{"url":"https://api.github.com/repos/slorber/backspace-disabler/issues/4","repository_url":"https://api.github.com/repos/slorber/backspace-disabler","labels_url":"https://api.github.com/repos/slorber/backspace-disabler/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/slorber/backspace-disabler/issues/4/comments","events_url":"https://api.github.com/repos/slorber/backspace-disabler/issues/4/events","html_url":"https://github.com/slorber/backspace-disabler/pull/4","id":167210241,"number":4,"title":"Adding connectedToTheDom","user":{"login":"fresheneesz","id":149531,"avatar_url":"https://avatars.githubusercontent.com/u/149531?v=3","gravatar_id":"","url":"https://api.github.com/users/fresheneesz","html_url":"https://github.com/fresheneesz","followers_url":"https://api.github.com/users/fresheneesz/followers","following_url":"https://api.github.com/users/fresheneesz/following{/other_user}","gists_url":"https://api.github.com/users/fresheneesz/gists{/gist_id}","starred_url":"https://api.github.com/users/fresheneesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fresheneesz/subscriptions","organizations_url":"https://api.github.com/users/fresheneesz/orgs","repos_url":"https://api.github.com/users/fresheneesz/repos","events_url":"https://api.github.com/users/fresheneesz/events{/privacy}","received_events_url":"https://api.github.com/users/fresheneesz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-07-24T00:21:51Z","updated_at":"2016-07-28T17:43:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/slorber/backspace-disabler/pulls/4","html_url":"https://github.com/slorber/backspace-disabler/pull/4","diff_url":"https://github.com/slorber/backspace-disabler/pull/4.diff","patch_url":"https://github.com/slorber/backspace-disabler/pull/4.patch"},"body":"I found another use case that was letting through backspace-related browser history state changes: If a backspace event results in removing the element being typed in from the dom, the default action ends up being a history change. So in the case a field has been removed from the dom, the default must also be prevented.\r\n\r\nI also changed the validInputTypes to an object for performance and readability, and made a number of other minor readability improvements (including taking advantage of function hoisting)."},"comment":{"url":"https://api.github.com/repos/slorber/backspace-disabler/issues/comments/235969865","html_url":"https://github.com/slorber/backspace-disabler/pull/4#issuecomment-235969865","issue_url":"https://api.github.com/repos/slorber/backspace-disabler/issues/4","id":235969865,"user":{"login":"fresheneesz","id":149531,"avatar_url":"https://avatars.githubusercontent.com/u/149531?v=3","gravatar_id":"","url":"https://api.github.com/users/fresheneesz","html_url":"https://github.com/fresheneesz","followers_url":"https://api.github.com/users/fresheneesz/followers","following_url":"https://api.github.com/users/fresheneesz/following{/other_user}","gists_url":"https://api.github.com/users/fresheneesz/gists{/gist_id}","starred_url":"https://api.github.com/users/fresheneesz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fresheneesz/subscriptions","organizations_url":"https://api.github.com/users/fresheneesz/orgs","repos_url":"https://api.github.com/users/fresheneesz/repos","events_url":"https://api.github.com/users/fresheneesz/events{/privacy}","received_events_url":"https://api.github.com/users/fresheneesz/received_events","type":"User","site_admin":false},"created_at":"2016-07-28T17:43:12Z","updated_at":"2016-07-28T17:43:12Z","body":"\"I don't really understand your other changes like validInputTypes\"\r\n\r\nThe validInputTypes change was for speed - checking an object for containing a key is much faster than `indexOf` on an array. The rest are simply changes for readability and don't affect either the logic or the performance. It unfortunate the diff can't show where code was moved, because there really weren't that many changes. I moved the exports to the top for readability, but it makes the diff hard to read."}}
{"actor":{"display_login":"fresheneesz"}}