{"action":"created","comment":{"url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/comments/75413076","id":75413076,"diff_hunk":"@@ -532,41 +571,70 @@ case class Block(center: Array[Double], faces: Seq[Face], generation: Int=0) ext\n         allVertices.map { v => v(2) }.sum / allVertices.size\n       )\n     } else {\n-      Array(\n-        // Factor of 3 comes from: centroid / (2.0 * (volume/6.0))\n-        3.0 * centroidX / totalVolume,\n-        3.0 * centroidY / totalVolume,\n-        3.0 * centroidZ / totalVolume\n-      )\n+      val increments = faces.flatMap { face =>","path":"src/main/scala/edu/berkeley/ce/sparkrocks/Block.scala","position":212,"original_position":212,"commit_id":"1a5adb3f1b0657dd42625c7a0e7eae35ae4cb98c","original_commit_id":"1a5adb3f1b0657dd42625c7a0e7eae35ae4cb98c","user":{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false},"body":"How about just doing `vertices.flatMap { case (face, faceVertices) => ... }` to simplify things and get rid of the annoying `vertices(face)` usages? Also, can we rename `vertices` to something that better reflects the fact that it's a `Map` and not a `Seq`?","created_at":"2016-08-19T00:41:18Z","updated_at":"2016-08-19T00:41:18Z","html_url":"https://github.com/jhkolb/sparkRocks/pull/40#discussion_r75413076","pull_request_url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/comments/75413076"},"html":{"href":"https://github.com/jhkolb/sparkRocks/pull/40#discussion_r75413076"},"pull_request":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40","id":81207488,"html_url":"https://github.com/jhkolb/sparkRocks/pull/40","diff_url":"https://github.com/jhkolb/sparkRocks/pull/40.diff","patch_url":"https://github.com/jhkolb/sparkRocks/pull/40.patch","issue_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues/40","number":40,"state":"open","locked":false,"title":"Remove Delaunay triangulation and use simplex integration instead","user":{"login":"shellshocked2003","id":10856474,"avatar_url":"https://avatars.githubusercontent.com/u/10856474?v=3","gravatar_id":"","url":"https://api.github.com/users/shellshocked2003","html_url":"https://github.com/shellshocked2003","followers_url":"https://api.github.com/users/shellshocked2003/followers","following_url":"https://api.github.com/users/shellshocked2003/following{/other_user}","gists_url":"https://api.github.com/users/shellshocked2003/gists{/gist_id}","starred_url":"https://api.github.com/users/shellshocked2003/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellshocked2003/subscriptions","organizations_url":"https://api.github.com/users/shellshocked2003/orgs","repos_url":"https://api.github.com/users/shellshocked2003/repos","events_url":"https://api.github.com/users/shellshocked2003/events{/privacy}","received_events_url":"https://api.github.com/users/shellshocked2003/received_events","type":"User","site_admin":false},"body":"This branch removes all dependency on `Delaunay` for finding the volume and centroid of a block. It also is no longer necessary to do any meshing of the block faces. Instead, all calculations are done using simplex integration. Some of the logic implemented in `BlockVTK` has been moved into `Block` so that all vertices are oriented counter clockwise - oriented vertices are required to perform simplex integration. \r\n\r\nThis addresses the issues in #32.","created_at":"2016-08-13T05:12:50Z","updated_at":"2016-08-19T00:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c564ff36f8107aa144d7e671abfef0fdaca4b5b","assignee":{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40/commits","review_comments_url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40/comments","review_comment_url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues/40/comments","statuses_url":"https://api.github.com/repos/jhkolb/sparkRocks/statuses/1a5adb3f1b0657dd42625c7a0e7eae35ae4cb98c","head":{"label":"jhkolb:simplex","ref":"simplex","sha":"1a5adb3f1b0657dd42625c7a0e7eae35ae4cb98c","user":{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false},"repo":{"id":36398369,"name":"sparkRocks","full_name":"jhkolb/sparkRocks","owner":{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhkolb/sparkRocks","description":"Parallel rock slicing implementation on Apache Spark","fork":true,"url":"https://api.github.com/repos/jhkolb/sparkRocks","forks_url":"https://api.github.com/repos/jhkolb/sparkRocks/forks","keys_url":"https://api.github.com/repos/jhkolb/sparkRocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhkolb/sparkRocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhkolb/sparkRocks/teams","hooks_url":"https://api.github.com/repos/jhkolb/sparkRocks/hooks","issue_events_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues/events{/number}","events_url":"https://api.github.com/repos/jhkolb/sparkRocks/events","assignees_url":"https://api.github.com/repos/jhkolb/sparkRocks/assignees{/user}","branches_url":"https://api.github.com/repos/jhkolb/sparkRocks/branches{/branch}","tags_url":"https://api.github.com/repos/jhkolb/sparkRocks/tags","blobs_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhkolb/sparkRocks/statuses/{sha}","languages_url":"https://api.github.com/repos/jhkolb/sparkRocks/languages","stargazers_url":"https://api.github.com/repos/jhkolb/sparkRocks/stargazers","contributors_url":"https://api.github.com/repos/jhkolb/sparkRocks/contributors","subscribers_url":"https://api.github.com/repos/jhkolb/sparkRocks/subscribers","subscription_url":"https://api.github.com/repos/jhkolb/sparkRocks/subscription","commits_url":"https://api.github.com/repos/jhkolb/sparkRocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhkolb/sparkRocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhkolb/sparkRocks/contents/{+path}","compare_url":"https://api.github.com/repos/jhkolb/sparkRocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhkolb/sparkRocks/merges","archive_url":"https://api.github.com/repos/jhkolb/sparkRocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhkolb/sparkRocks/downloads","issues_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues{/number}","pulls_url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls{/number}","milestones_url":"https://api.github.com/repos/jhkolb/sparkRocks/milestones{/number}","notifications_url":"https://api.github.com/repos/jhkolb/sparkRocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhkolb/sparkRocks/labels{/name}","releases_url":"https://api.github.com/repos/jhkolb/sparkRocks/releases{/id}","deployments_url":"https://api.github.com/repos/jhkolb/sparkRocks/deployments","created_at":"2015-05-27T21:58:52Z","updated_at":"2016-01-27T07:19:27Z","pushed_at":"2016-08-18T22:37:58Z","git_url":"git://github.com/jhkolb/sparkRocks.git","ssh_url":"git@github.com:jhkolb/sparkRocks.git","clone_url":"https://github.com/jhkolb/sparkRocks.git","svn_url":"https://github.com/jhkolb/sparkRocks","homepage":"","size":641,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"jhkolb:master","ref":"master","sha":"e79ab8e4a2331a220006554e23f763d868839499","user":{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false},"repo":{"id":36398369,"name":"sparkRocks","full_name":"jhkolb/sparkRocks","owner":{"login":"jhkolb","id":9288575,"avatar_url":"https://avatars.githubusercontent.com/u/9288575?v=3","gravatar_id":"","url":"https://api.github.com/users/jhkolb","html_url":"https://github.com/jhkolb","followers_url":"https://api.github.com/users/jhkolb/followers","following_url":"https://api.github.com/users/jhkolb/following{/other_user}","gists_url":"https://api.github.com/users/jhkolb/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkolb/subscriptions","organizations_url":"https://api.github.com/users/jhkolb/orgs","repos_url":"https://api.github.com/users/jhkolb/repos","events_url":"https://api.github.com/users/jhkolb/events{/privacy}","received_events_url":"https://api.github.com/users/jhkolb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhkolb/sparkRocks","description":"Parallel rock slicing implementation on Apache Spark","fork":true,"url":"https://api.github.com/repos/jhkolb/sparkRocks","forks_url":"https://api.github.com/repos/jhkolb/sparkRocks/forks","keys_url":"https://api.github.com/repos/jhkolb/sparkRocks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhkolb/sparkRocks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhkolb/sparkRocks/teams","hooks_url":"https://api.github.com/repos/jhkolb/sparkRocks/hooks","issue_events_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues/events{/number}","events_url":"https://api.github.com/repos/jhkolb/sparkRocks/events","assignees_url":"https://api.github.com/repos/jhkolb/sparkRocks/assignees{/user}","branches_url":"https://api.github.com/repos/jhkolb/sparkRocks/branches{/branch}","tags_url":"https://api.github.com/repos/jhkolb/sparkRocks/tags","blobs_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhkolb/sparkRocks/statuses/{sha}","languages_url":"https://api.github.com/repos/jhkolb/sparkRocks/languages","stargazers_url":"https://api.github.com/repos/jhkolb/sparkRocks/stargazers","contributors_url":"https://api.github.com/repos/jhkolb/sparkRocks/contributors","subscribers_url":"https://api.github.com/repos/jhkolb/sparkRocks/subscribers","subscription_url":"https://api.github.com/repos/jhkolb/sparkRocks/subscription","commits_url":"https://api.github.com/repos/jhkolb/sparkRocks/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhkolb/sparkRocks/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhkolb/sparkRocks/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhkolb/sparkRocks/contents/{+path}","compare_url":"https://api.github.com/repos/jhkolb/sparkRocks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhkolb/sparkRocks/merges","archive_url":"https://api.github.com/repos/jhkolb/sparkRocks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhkolb/sparkRocks/downloads","issues_url":"https://api.github.com/repos/jhkolb/sparkRocks/issues{/number}","pulls_url":"https://api.github.com/repos/jhkolb/sparkRocks/pulls{/number}","milestones_url":"https://api.github.com/repos/jhkolb/sparkRocks/milestones{/number}","notifications_url":"https://api.github.com/repos/jhkolb/sparkRocks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhkolb/sparkRocks/labels{/name}","releases_url":"https://api.github.com/repos/jhkolb/sparkRocks/releases{/id}","deployments_url":"https://api.github.com/repos/jhkolb/sparkRocks/deployments","created_at":"2015-05-27T21:58:52Z","updated_at":"2016-01-27T07:19:27Z","pushed_at":"2016-08-18T22:37:58Z","git_url":"git://github.com/jhkolb/sparkRocks.git","ssh_url":"git@github.com:jhkolb/sparkRocks.git","clone_url":"https://github.com/jhkolb/sparkRocks.git","svn_url":"https://github.com/jhkolb/sparkRocks","homepage":"","size":641,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40"},"html":{"href":"https://github.com/jhkolb/sparkRocks/pull/40"},"issue":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/issues/40"},"comments":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/jhkolb/sparkRocks/statuses/1a5adb3f1b0657dd42625c7a0e7eae35ae4cb98c"}}}}
{"actor":{"display_login":"jhkolb"}}