{"action":"created","issue":{"url":"https://api.github.com/repos/biopython/biopython/issues/1011","repository_url":"https://api.github.com/repos/biopython/biopython","labels_url":"https://api.github.com/repos/biopython/biopython/issues/1011/labels{/name}","comments_url":"https://api.github.com/repos/biopython/biopython/issues/1011/comments","events_url":"https://api.github.com/repos/biopython/biopython/issues/1011/events","html_url":"https://github.com/biopython/biopython/pull/1011","id":191878775,"number":1011,"title":"CEL parser for CEL file version 4","user":{"login":"picrin","id":2790838,"avatar_url":"https://avatars.githubusercontent.com/u/2790838?v=3","gravatar_id":"","url":"https://api.github.com/users/picrin","html_url":"https://github.com/picrin","followers_url":"https://api.github.com/users/picrin/followers","following_url":"https://api.github.com/users/picrin/following{/other_user}","gists_url":"https://api.github.com/users/picrin/gists{/gist_id}","starred_url":"https://api.github.com/users/picrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/picrin/subscriptions","organizations_url":"https://api.github.com/users/picrin/orgs","repos_url":"https://api.github.com/users/picrin/repos","events_url":"https://api.github.com/users/picrin/events{/privacy}","received_events_url":"https://api.github.com/users/picrin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-11-27T19:14:51Z","updated_at":"2016-11-29T11:50:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/biopython/biopython/pulls/1011","html_url":"https://github.com/biopython/biopython/pull/1011","diff_url":"https://github.com/biopython/biopython/pull/1011.diff","patch_url":"https://github.com/biopython/biopython/pull/1011.patch"},"body":"Backwards compatibility with version 3 is maintained.\r\n\r\nA \"strict\" switch is added. By default strict=False. Setting strict=True may break backwards compatibility.\r\n\r\nTest cases for package Affy are added. Both new and old code is now tested.\r\n\r\naffy_v4_example.CEL is added. It is artifically generated and small."},"comment":{"url":"https://api.github.com/repos/biopython/biopython/issues/comments/263550420","html_url":"https://github.com/biopython/biopython/pull/1011#issuecomment-263550420","issue_url":"https://api.github.com/repos/biopython/biopython/issues/1011","id":263550420,"user":{"login":"peterjc","id":63959,"avatar_url":"https://avatars.githubusercontent.com/u/63959?v=3","gravatar_id":"","url":"https://api.github.com/users/peterjc","html_url":"https://github.com/peterjc","followers_url":"https://api.github.com/users/peterjc/followers","following_url":"https://api.github.com/users/peterjc/following{/other_user}","gists_url":"https://api.github.com/users/peterjc/gists{/gist_id}","starred_url":"https://api.github.com/users/peterjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterjc/subscriptions","organizations_url":"https://api.github.com/users/peterjc/orgs","repos_url":"https://api.github.com/users/peterjc/repos","events_url":"https://api.github.com/users/peterjc/events{/privacy}","received_events_url":"https://api.github.com/users/peterjc/received_events","type":"User","site_admin":false},"created_at":"2016-11-29T11:50:03Z","updated_at":"2016-11-29T11:50:03Z","body":"Good work - the automated tests are passing :)\r\n\r\nLooking at this, you are renaming the original v3 ``read`` to ``read3``, adding ``read4``, and adding a new ``read`` function which does version detection.\r\n\r\nI think it might be simpler to remove the ``strict`` option and instead encourage people to use ``read3`` or ``read4`` directly if they know which file format they have... but before asking you to make any further changes I'm hoping for some other perspectives and have asked on the development mailing list for comments:\r\n\r\nhttp://mailman.open-bio.org/pipermail/biopython-dev/2016-November/021608.html\r\n\r\nP.S. do you think ``read_v3`` and ``read_v4`` would be clearer names?"}}
{"actor":{"display_login":"peterjc"}}