{"action":"opened","number":66,"pull_request":{"url":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/66","id":90342056,"html_url":"https://github.com/alphagov/service-manual-frontend/pull/66","diff_url":"https://github.com/alphagov/service-manual-frontend/pull/66.diff","patch_url":"https://github.com/alphagov/service-manual-frontend/pull/66.patch","issue_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/66","number":66,"state":"open","locked":false,"title":"Don’t use HTML5 browser ‘requied’ validation","user":{"login":"36degrees","id":121939,"avatar_url":"https://avatars.githubusercontent.com/u/121939?v=3","gravatar_id":"","url":"https://api.github.com/users/36degrees","html_url":"https://github.com/36degrees","followers_url":"https://api.github.com/users/36degrees/followers","following_url":"https://api.github.com/users/36degrees/following{/other_user}","gists_url":"https://api.github.com/users/36degrees/gists{/gist_id}","starred_url":"https://api.github.com/users/36degrees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/36degrees/subscriptions","organizations_url":"https://api.github.com/users/36degrees/orgs","repos_url":"https://api.github.com/users/36degrees/repos","events_url":"https://api.github.com/users/36degrees/events{/privacy}","received_events_url":"https://api.github.com/users/36degrees/received_events","type":"User","site_admin":false},"body":"The HTML5 validation is provided by the browser and we are not able to style the error messages. This means that the validation experience is inconsistent with other parts of GOV.UK and with any more advanced validation that might happen server side.\r\n\r\nThere is already server side validation for the description being required, so the simplest fix is just to remove the required attribute and fall back to that.\r\n\r\nhttps://trello.com/c/sIU9cdr1/464-consistent-validation-experience-with-improve-this-page-form","created_at":"2016-10-21T08:28:09Z","updated_at":"2016-10-21T08:28:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/66/commits","review_comments_url":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/66/comments","review_comment_url":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/66/comments","statuses_url":"https://api.github.com/repos/alphagov/service-manual-frontend/statuses/2dc62e3979e993904350ac72c8cd7af85b3902c6","head":{"label":"alphagov:remove-html5-required-attribute","ref":"remove-html5-required-attribute","sha":"2dc62e3979e993904350ac72c8cd7af85b3902c6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":53954106,"name":"service-manual-frontend","full_name":"alphagov/service-manual-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/service-manual-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/service-manual-frontend","forks_url":"https://api.github.com/repos/alphagov/service-manual-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/service-manual-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/service-manual-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/service-manual-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/service-manual-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/service-manual-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/service-manual-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/service-manual-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/service-manual-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/service-manual-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/service-manual-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/service-manual-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/service-manual-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/service-manual-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/service-manual-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/service-manual-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/service-manual-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/service-manual-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/service-manual-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/service-manual-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/service-manual-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/service-manual-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/service-manual-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/service-manual-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/service-manual-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/service-manual-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/service-manual-frontend/deployments","created_at":"2016-03-15T15:04:00Z","updated_at":"2016-03-15T19:40:31Z","pushed_at":"2016-10-21T08:28:10Z","git_url":"git://github.com/alphagov/service-manual-frontend.git","ssh_url":"git@github.com:alphagov/service-manual-frontend.git","clone_url":"https://github.com/alphagov/service-manual-frontend.git","svn_url":"https://github.com/alphagov/service-manual-frontend","homepage":null,"size":1142,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"b04b004ef3958d3682fe40d87703877543adb117","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":53954106,"name":"service-manual-frontend","full_name":"alphagov/service-manual-frontend","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/service-manual-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/alphagov/service-manual-frontend","forks_url":"https://api.github.com/repos/alphagov/service-manual-frontend/forks","keys_url":"https://api.github.com/repos/alphagov/service-manual-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/service-manual-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/service-manual-frontend/teams","hooks_url":"https://api.github.com/repos/alphagov/service-manual-frontend/hooks","issue_events_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/service-manual-frontend/events","assignees_url":"https://api.github.com/repos/alphagov/service-manual-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/service-manual-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/service-manual-frontend/tags","blobs_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/service-manual-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/service-manual-frontend/languages","stargazers_url":"https://api.github.com/repos/alphagov/service-manual-frontend/stargazers","contributors_url":"https://api.github.com/repos/alphagov/service-manual-frontend/contributors","subscribers_url":"https://api.github.com/repos/alphagov/service-manual-frontend/subscribers","subscription_url":"https://api.github.com/repos/alphagov/service-manual-frontend/subscription","commits_url":"https://api.github.com/repos/alphagov/service-manual-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/service-manual-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/service-manual-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/service-manual-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/service-manual-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/service-manual-frontend/merges","archive_url":"https://api.github.com/repos/alphagov/service-manual-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/service-manual-frontend/downloads","issues_url":"https://api.github.com/repos/alphagov/service-manual-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/service-manual-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/service-manual-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/service-manual-frontend/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/service-manual-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/service-manual-frontend/deployments","created_at":"2016-03-15T15:04:00Z","updated_at":"2016-03-15T19:40:31Z","pushed_at":"2016-10-21T08:28:10Z","git_url":"git://github.com/alphagov/service-manual-frontend.git","ssh_url":"git@github.com:alphagov/service-manual-frontend.git","clone_url":"https://github.com/alphagov/service-manual-frontend.git","svn_url":"https://github.com/alphagov/service-manual-frontend","homepage":null,"size":1142,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/66"},"html":{"href":"https://github.com/alphagov/service-manual-frontend/pull/66"},"issue":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/66"},"comments":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/service-manual-frontend/statuses/2dc62e3979e993904350ac72c8cd7af85b3902c6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"36degrees"}}