{"action":"created","issue":{"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/24","repository_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited","labels_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/24/comments","events_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/24/events","html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/24","id":139456479,"number":24,"title":"Do not purge orphans on peer disconnect","user":{"login":"ptschip","id":12862928,"avatar_url":"https://avatars.githubusercontent.com/u/12862928?v=3","gravatar_id":"","url":"https://api.github.com/users/ptschip","html_url":"https://github.com/ptschip","followers_url":"https://api.github.com/users/ptschip/followers","following_url":"https://api.github.com/users/ptschip/following{/other_user}","gists_url":"https://api.github.com/users/ptschip/gists{/gist_id}","starred_url":"https://api.github.com/users/ptschip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptschip/subscriptions","organizations_url":"https://api.github.com/users/ptschip/orgs","repos_url":"https://api.github.com/users/ptschip/repos","events_url":"https://api.github.com/users/ptschip/events{/privacy}","received_events_url":"https://api.github.com/users/ptschip/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2016-03-09T02:33:17Z","updated_at":"2016-03-09T22:01:19Z","closed_at":"2016-03-09T20:05:10Z","pull_request":{"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/pulls/24","html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/24","diff_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/24.diff","patch_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/24.patch"},"body":"I'm already seeing what I think are some obvious improvements after running for just a short while.  Putting this out there tonight and share more data in the morning."},"comment":{"url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/comments/194528829","html_url":"https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/24#issuecomment-194528829","issue_url":"https://api.github.com/repos/BitcoinUnlimited/BitcoinUnlimited/issues/24","id":194528829,"user":{"login":"ptschip","id":12862928,"avatar_url":"https://avatars.githubusercontent.com/u/12862928?v=3","gravatar_id":"","url":"https://api.github.com/users/ptschip","html_url":"https://github.com/ptschip","followers_url":"https://api.github.com/users/ptschip/followers","following_url":"https://api.github.com/users/ptschip/following{/other_user}","gists_url":"https://api.github.com/users/ptschip/gists{/gist_id}","starred_url":"https://api.github.com/users/ptschip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptschip/subscriptions","organizations_url":"https://api.github.com/users/ptschip/orgs","repos_url":"https://api.github.com/users/ptschip/repos","events_url":"https://api.github.com/users/ptschip/events{/privacy}","received_events_url":"https://api.github.com/users/ptschip/received_events","type":"User","site_admin":false},"created_at":"2016-03-09T22:01:19Z","updated_at":"2016-03-09T22:01:19Z","body":"thanks, i saw your email too late it's already merged.  I agree, it\ndoesn't make sense...anyway it's out now.  The ophans get purged now\nwhen the block arrives or if the cache overfills..much better IMO.\n\nOn 09/03/2016 11:08 AM, Tom Harding wrote:\n>\n> Some mention should be made of @gavinandresen\n> <https://github.com/gavinandresen>'s bitcoin#4885\n> <https://github.com/bitcoin/bitcoin/pull/4885> which introduced the\n> orphan cleanup at peer disconnect.\n>\n> I don't actually understand the reasoning for that change, because by\n> the time the peer disconnects, it's too late. The damage is done when\n> the peer feeds you a bunch of junk that forces other \"good\" orphans\n> out of mapOrphanTransactions.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/BitcoinUnlimited/BitcoinUnlimited/pull/24#issuecomment-194456251>.\n>\n\n"}}