{"action":"created","issue":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/438","repository_url":"https://api.github.com/repos/nhibernate/nhibernate-core","labels_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/438/labels{/name}","comments_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/438/comments","events_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/438/events","html_url":"https://github.com/nhibernate/nhibernate-core/pull/438","id":95976095,"number":438,"title":"NH-3811 Added [ThreadStatic] to table counter ","user":{"login":"BrettMcGirr","id":12994244,"avatar_url":"https://avatars.githubusercontent.com/u/12994244?v=3","gravatar_id":"","url":"https://api.github.com/users/BrettMcGirr","html_url":"https://github.com/BrettMcGirr","followers_url":"https://api.github.com/users/BrettMcGirr/followers","following_url":"https://api.github.com/users/BrettMcGirr/following{/other_user}","gists_url":"https://api.github.com/users/BrettMcGirr/gists{/gist_id}","starred_url":"https://api.github.com/users/BrettMcGirr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrettMcGirr/subscriptions","organizations_url":"https://api.github.com/users/BrettMcGirr/orgs","repos_url":"https://api.github.com/users/BrettMcGirr/repos","events_url":"https://api.github.com/users/BrettMcGirr/events{/privacy}","received_events_url":"https://api.github.com/users/BrettMcGirr/received_events","type":"User","site_admin":false},"labels":[{"id":153359143,"url":"https://api.github.com/repos/nhibernate/nhibernate-core/labels/To%20Review","name":"To Review","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-07-20T03:16:54Z","updated_at":"2016-11-26T12:19:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/pulls/438","html_url":"https://github.com/nhibernate/nhibernate-core/pull/438","diff_url":"https://github.com/nhibernate/nhibernate-core/pull/438.diff","patch_url":"https://github.com/nhibernate/nhibernate-core/pull/438.patch"},"body":"so that table aliases can be generated consistently in a multi thread environment.\n"},"comment":{"url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/comments/263060423","html_url":"https://github.com/nhibernate/nhibernate-core/pull/438#issuecomment-263060423","issue_url":"https://api.github.com/repos/nhibernate/nhibernate-core/issues/438","id":263060423,"user":{"login":"oskarb","id":482095,"avatar_url":"https://avatars.githubusercontent.com/u/482095?v=3","gravatar_id":"","url":"https://api.github.com/users/oskarb","html_url":"https://github.com/oskarb","followers_url":"https://api.github.com/users/oskarb/followers","following_url":"https://api.github.com/users/oskarb/following{/other_user}","gists_url":"https://api.github.com/users/oskarb/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarb/subscriptions","organizations_url":"https://api.github.com/users/oskarb/orgs","repos_url":"https://api.github.com/users/oskarb/repos","events_url":"https://api.github.com/users/oskarb/events{/privacy}","received_events_url":"https://api.github.com/users/oskarb/received_events","type":"User","site_admin":false},"created_at":"2016-11-26T12:19:06Z","updated_at":"2016-11-26T12:19:06Z","body":"In fact, the table counter is updated using:\r\n\r\n```\r\npublic Table()\r\n{\r\n\tuniqueInteger = tableCounter++;\r\n}\r\n```\r\n\r\nAnd the increment operator is not guaranteed to be thread safe so potentially the problem (in the current code) is even worse. Though in practice no-one seems to have been bothered by that."}}
{"actor":{"display_login":"oskarb"}}