{"action":"created","comment":{"url":"https://api.github.com/repos/Clever/dev-handbook/pulls/comments/49373172","id":49373172,"diff_hunk":"@@ -0,0 +1,121 @@\n+# This is the default Clever Golang Makefile.\n+# Please do not alter this file directly.\n+SHELL := /bin/bash\n+.PHONY: golang-godep-vendor golang-test-deps $(GODEP)\n+\n+# This block checks and confirms that the proper Go toolchain version is installed.\n+# arg1: golang version\n+define golang-version-check\n+GOVERSION := $(shell go version | grep $(1))\n+_ := $(if \\\n+\t$(shell go version | grep $(1)), \\\n+\t@echo \"\", \\\n+\t$(error \"must be running Go version $(1)\"))\n+endef\n+\n+export GO15VENDOREXPERIMENT=1\n+\n+# FGT is a utility that exits with 1 whenever any stderr/stdout output is recieved.\n+FGT := $(GOPATH)/bin/fgt\n+$(FGT):\n+\tgo get github.com/GeertJohan/fgt\n+\n+# Godep is a tool used to manage Golang dependencies in the style of the Go 1.5\n+# vendoring experiment.\n+GODEP := $(GOPATH)/bin/godep\n+$(GODEP):\n+\tgo get -u github.com/tools/godep\n+\n+# Golint is a tool for linting Golang code for common errors.\n+GOLINT := $(GOPATH)/bin/golint\n+$(GOLINT):\n+\tgo get github.com/golang/lint/golint\n+\n+# golang-vendor-deps installs all dependencies needed for different test cases.\n+golang-godep-vendor-deps: $(GODEP)\n+\n+# golang-godep-vendor is a target for saving dependencies with the godep tool\n+# to the vendor/ directory. All nested vendor/ directories are deleted as they\n+# are not handled well by the Go toolchain.\n+# arg1: pkg path\n+define golang-godep-vendor\n+$(GODEP) save $(1)\n+@# remove any nested vendor directories\n+find vendor/ -path '*/vendor' -type d | xargs -IX rm -r X\n+endef\n+\n+# golang-fmt-deps requires the FGT tool for checking output\n+golang-fmt-deps: $(FGT)\n+\n+# golang-fmt checks that all golang files in the pkg are formatted correctly.\n+# arg1: pkg path\n+define golang-fmt\n+@echo \"FORMATTING $(1)...\"\n+@$(FGT) gofmt -l=true $(GOPATH)/src/$(1)/*.go\n+endef\n+\n+# golang-lint-deps requires the golint tool for golang linting.\n+golang-lint-deps: $(GOLINT)\n+\n+# golang-lint calls golint on all golang files in the pkg.\n+# arg1: pkg path\n+define golang-lint\n+@echo \"LINTING $(1)...\"\n+@$(GOLINT) $(GOPATH)/src/$(1)/*.go\n+endef\n+\n+# golang-lint-deps-strict requires the golint tool for golang linting.\n+golang-lint-deps-strict: $(GOLINT) $(FGT)\n+\n+# golang-lint-strict calls golint on all golang files in the pkg and fails if any lint\n+# errors are found.\n+# arg1: pkg path\n+define golang-lint-strict\n+@echo \"LINTING $(1)...\"\n+@$(FGT) $(GOLINT) $(GOPATH)/src/$(1)/*.go\n+endef\n+\n+# golang-test-deps is here for consistency\n+golang-test-deps:\n+\n+# golang-test uses the Go toolchain to run all tests in the pkg.\n+# arg1: pkg path\n+define golang-test\n+@echo \"TESTING $(1)...\"\n+@go test -v $(1)\n+endef\n+\n+# golang-vet-deps is here for consistency\n+golang-vet-deps:\n+\n+# golang-vet uses the Go toolchain to vet all the pkg for common mistakes.\n+# arg1: pkg path\n+define golang-vet\n+@echo \"VETTING $(1)...\"\n+@go vet $(GOPATH)/src/$(1)/*.go\n+endef\n+\n+# golang-test-all-deps installs all dependencies needed for different test cases.\n+golang-test-all-deps: golang-fmt-deps golang-lint-deps golang-test-deps golang-vet-deps\n+\n+# golang-test-all calls fmt, lint, vet and test on the specified pkg.\n+# arg1: pkg path\n+define golang-test-all","path":"make/golang.mk","position":103,"original_position":103,"commit_id":"e66e32848787a8ca790fb3e6d7f0560aad4b1607","original_commit_id":"e66e32848787a8ca790fb3e6d7f0560aad4b1607","user":{"login":"jiancheung","id":2801980,"avatar_url":"https://avatars.githubusercontent.com/u/2801980?v=3","gravatar_id":"","url":"https://api.github.com/users/jiancheung","html_url":"https://github.com/jiancheung","followers_url":"https://api.github.com/users/jiancheung/followers","following_url":"https://api.github.com/users/jiancheung/following{/other_user}","gists_url":"https://api.github.com/users/jiancheung/gists{/gist_id}","starred_url":"https://api.github.com/users/jiancheung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiancheung/subscriptions","organizations_url":"https://api.github.com/users/jiancheung/orgs","repos_url":"https://api.github.com/users/jiancheung/repos","events_url":"https://api.github.com/users/jiancheung/events{/privacy}","received_events_url":"https://api.github.com/users/jiancheung/received_events","type":"User","site_admin":false},"body":"I kind of wonder if only the `test-all`'s should be exported and all the individual stuff (such as `golang-lint`) should be kept \"private\". I haven't thought about it too much, just a passing comment.","created_at":"2016-01-11T20:22:26Z","updated_at":"2016-01-11T20:22:26Z","html_url":"https://github.com/Clever/dev-handbook/pull/53#discussion_r49373172","pull_request_url":"https://api.github.com/repos/Clever/dev-handbook/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/Clever/dev-handbook/pulls/comments/49373172"},"html":{"href":"https://github.com/Clever/dev-handbook/pull/53#discussion_r49373172"},"pull_request":{"href":"https://api.github.com/repos/Clever/dev-handbook/pulls/53"}}},"pull_request":{"url":"https://api.github.com/repos/Clever/dev-handbook/pulls/53","id":55660220,"html_url":"https://github.com/Clever/dev-handbook/pull/53","diff_url":"https://github.com/Clever/dev-handbook/pull/53.diff","patch_url":"https://github.com/Clever/dev-handbook/pull/53.patch","issue_url":"https://api.github.com/repos/Clever/dev-handbook/issues/53","number":53,"state":"open","locked":false,"title":"add README & makefile lbraries","user":{"login":"natebrennand","id":2801090,"avatar_url":"https://avatars.githubusercontent.com/u/2801090?v=3","gravatar_id":"","url":"https://api.github.com/users/natebrennand","html_url":"https://github.com/natebrennand","followers_url":"https://api.github.com/users/natebrennand/followers","following_url":"https://api.github.com/users/natebrennand/following{/other_user}","gists_url":"https://api.github.com/users/natebrennand/gists{/gist_id}","starred_url":"https://api.github.com/users/natebrennand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natebrennand/subscriptions","organizations_url":"https://api.github.com/users/natebrennand/orgs","repos_url":"https://api.github.com/users/natebrennand/repos","events_url":"https://api.github.com/users/natebrennand/events{/privacy}","received_events_url":"https://api.github.com/users/natebrennand/received_events","type":"User","site_admin":false},"body":"This introduces the master copies of the makefile libraries that have been in review on appasaurus.","created_at":"2016-01-11T18:40:03Z","updated_at":"2016-01-11T20:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2138b5ee2ebcd80603d3127bd64e73541d013d9d","assignee":{"login":"mohit","id":244154,"avatar_url":"https://avatars.githubusercontent.com/u/244154?v=3","gravatar_id":"","url":"https://api.github.com/users/mohit","html_url":"https://github.com/mohit","followers_url":"https://api.github.com/users/mohit/followers","following_url":"https://api.github.com/users/mohit/following{/other_user}","gists_url":"https://api.github.com/users/mohit/gists{/gist_id}","starred_url":"https://api.github.com/users/mohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohit/subscriptions","organizations_url":"https://api.github.com/users/mohit/orgs","repos_url":"https://api.github.com/users/mohit/repos","events_url":"https://api.github.com/users/mohit/events{/privacy}","received_events_url":"https://api.github.com/users/mohit/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Clever/dev-handbook/pulls/53/commits","review_comments_url":"https://api.github.com/repos/Clever/dev-handbook/pulls/53/comments","review_comment_url":"https://api.github.com/repos/Clever/dev-handbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Clever/dev-handbook/issues/53/comments","statuses_url":"https://api.github.com/repos/Clever/dev-handbook/statuses/e66e32848787a8ca790fb3e6d7f0560aad4b1607","head":{"label":"Clever:makefile-exp","ref":"makefile-exp","sha":"e66e32848787a8ca790fb3e6d7f0560aad4b1607","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars.githubusercontent.com/u/1885509?v=3","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":16847837,"name":"dev-handbook","full_name":"Clever/dev-handbook","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars.githubusercontent.com/u/1885509?v=3","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/dev-handbook","description":"A guide to the processes, conventions, and philosophies of the Clever dev team.","fork":false,"url":"https://api.github.com/repos/Clever/dev-handbook","forks_url":"https://api.github.com/repos/Clever/dev-handbook/forks","keys_url":"https://api.github.com/repos/Clever/dev-handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/dev-handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/dev-handbook/teams","hooks_url":"https://api.github.com/repos/Clever/dev-handbook/hooks","issue_events_url":"https://api.github.com/repos/Clever/dev-handbook/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/dev-handbook/events","assignees_url":"https://api.github.com/repos/Clever/dev-handbook/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/dev-handbook/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/dev-handbook/tags","blobs_url":"https://api.github.com/repos/Clever/dev-handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/dev-handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/dev-handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/dev-handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/dev-handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/dev-handbook/languages","stargazers_url":"https://api.github.com/repos/Clever/dev-handbook/stargazers","contributors_url":"https://api.github.com/repos/Clever/dev-handbook/contributors","subscribers_url":"https://api.github.com/repos/Clever/dev-handbook/subscribers","subscription_url":"https://api.github.com/repos/Clever/dev-handbook/subscription","commits_url":"https://api.github.com/repos/Clever/dev-handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/dev-handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/dev-handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/dev-handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/dev-handbook/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/dev-handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/dev-handbook/merges","archive_url":"https://api.github.com/repos/Clever/dev-handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/dev-handbook/downloads","issues_url":"https://api.github.com/repos/Clever/dev-handbook/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/dev-handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/dev-handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/dev-handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/dev-handbook/labels{/name}","releases_url":"https://api.github.com/repos/Clever/dev-handbook/releases{/id}","created_at":"2014-02-14T19:58:08Z","updated_at":"2015-08-31T04:07:58Z","pushed_at":"2016-01-11T20:16:02Z","git_url":"git://github.com/Clever/dev-handbook.git","ssh_url":"git@github.com:Clever/dev-handbook.git","clone_url":"https://github.com/Clever/dev-handbook.git","svn_url":"https://github.com/Clever/dev-handbook","homepage":"","size":109,"stargazers_count":23,"watchers_count":23,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":23,"default_branch":"master"}},"base":{"label":"Clever:master","ref":"master","sha":"b3335dc8defc7b5c892610f100081d211357e2d8","user":{"login":"Clever","id":1885509,"avatar_url":"https://avatars.githubusercontent.com/u/1885509?v=3","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"repo":{"id":16847837,"name":"dev-handbook","full_name":"Clever/dev-handbook","owner":{"login":"Clever","id":1885509,"avatar_url":"https://avatars.githubusercontent.com/u/1885509?v=3","gravatar_id":"","url":"https://api.github.com/users/Clever","html_url":"https://github.com/Clever","followers_url":"https://api.github.com/users/Clever/followers","following_url":"https://api.github.com/users/Clever/following{/other_user}","gists_url":"https://api.github.com/users/Clever/gists{/gist_id}","starred_url":"https://api.github.com/users/Clever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clever/subscriptions","organizations_url":"https://api.github.com/users/Clever/orgs","repos_url":"https://api.github.com/users/Clever/repos","events_url":"https://api.github.com/users/Clever/events{/privacy}","received_events_url":"https://api.github.com/users/Clever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Clever/dev-handbook","description":"A guide to the processes, conventions, and philosophies of the Clever dev team.","fork":false,"url":"https://api.github.com/repos/Clever/dev-handbook","forks_url":"https://api.github.com/repos/Clever/dev-handbook/forks","keys_url":"https://api.github.com/repos/Clever/dev-handbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Clever/dev-handbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Clever/dev-handbook/teams","hooks_url":"https://api.github.com/repos/Clever/dev-handbook/hooks","issue_events_url":"https://api.github.com/repos/Clever/dev-handbook/issues/events{/number}","events_url":"https://api.github.com/repos/Clever/dev-handbook/events","assignees_url":"https://api.github.com/repos/Clever/dev-handbook/assignees{/user}","branches_url":"https://api.github.com/repos/Clever/dev-handbook/branches{/branch}","tags_url":"https://api.github.com/repos/Clever/dev-handbook/tags","blobs_url":"https://api.github.com/repos/Clever/dev-handbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Clever/dev-handbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Clever/dev-handbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/Clever/dev-handbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Clever/dev-handbook/statuses/{sha}","languages_url":"https://api.github.com/repos/Clever/dev-handbook/languages","stargazers_url":"https://api.github.com/repos/Clever/dev-handbook/stargazers","contributors_url":"https://api.github.com/repos/Clever/dev-handbook/contributors","subscribers_url":"https://api.github.com/repos/Clever/dev-handbook/subscribers","subscription_url":"https://api.github.com/repos/Clever/dev-handbook/subscription","commits_url":"https://api.github.com/repos/Clever/dev-handbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/Clever/dev-handbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/Clever/dev-handbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/Clever/dev-handbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/Clever/dev-handbook/contents/{+path}","compare_url":"https://api.github.com/repos/Clever/dev-handbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Clever/dev-handbook/merges","archive_url":"https://api.github.com/repos/Clever/dev-handbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Clever/dev-handbook/downloads","issues_url":"https://api.github.com/repos/Clever/dev-handbook/issues{/number}","pulls_url":"https://api.github.com/repos/Clever/dev-handbook/pulls{/number}","milestones_url":"https://api.github.com/repos/Clever/dev-handbook/milestones{/number}","notifications_url":"https://api.github.com/repos/Clever/dev-handbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Clever/dev-handbook/labels{/name}","releases_url":"https://api.github.com/repos/Clever/dev-handbook/releases{/id}","created_at":"2014-02-14T19:58:08Z","updated_at":"2015-08-31T04:07:58Z","pushed_at":"2016-01-11T20:16:02Z","git_url":"git://github.com/Clever/dev-handbook.git","ssh_url":"git@github.com:Clever/dev-handbook.git","clone_url":"https://github.com/Clever/dev-handbook.git","svn_url":"https://github.com/Clever/dev-handbook","homepage":"","size":109,"stargazers_count":23,"watchers_count":23,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":12,"forks":5,"open_issues":12,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Clever/dev-handbook/pulls/53"},"html":{"href":"https://github.com/Clever/dev-handbook/pull/53"},"issue":{"href":"https://api.github.com/repos/Clever/dev-handbook/issues/53"},"comments":{"href":"https://api.github.com/repos/Clever/dev-handbook/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/Clever/dev-handbook/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/Clever/dev-handbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Clever/dev-handbook/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/Clever/dev-handbook/statuses/e66e32848787a8ca790fb3e6d7f0560aad4b1607"}}}}