{"action":"created","issue":{"url":"https://api.github.com/repos/BitFunnel/BitFunnel/issues/256","repository_url":"https://api.github.com/repos/BitFunnel/BitFunnel","labels_url":"https://api.github.com/repos/BitFunnel/BitFunnel/issues/256/labels{/name}","comments_url":"https://api.github.com/repos/BitFunnel/BitFunnel/issues/256/comments","events_url":"https://api.github.com/repos/BitFunnel/BitFunnel/issues/256/events","html_url":"https://github.com/BitFunnel/BitFunnel/issues/256","id":184595173,"number":256,"title":"system rows double counted","user":{"login":"danluu","id":157136,"avatar_url":"https://avatars.githubusercontent.com/u/157136?v=3","gravatar_id":"","url":"https://api.github.com/users/danluu","html_url":"https://github.com/danluu","followers_url":"https://api.github.com/users/danluu/followers","following_url":"https://api.github.com/users/danluu/following{/other_user}","gists_url":"https://api.github.com/users/danluu/gists{/gist_id}","starred_url":"https://api.github.com/users/danluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danluu/subscriptions","organizations_url":"https://api.github.com/users/danluu/orgs","repos_url":"https://api.github.com/users/danluu/repos","events_url":"https://api.github.com/users/danluu/events{/privacy}","received_events_url":"https://api.github.com/users/danluu/received_events","type":"User","site_admin":false},"labels":[{"id":405233788,"url":"https://api.github.com/repos/BitFunnel/BitFunnel/labels/backport","name":"backport","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-10-22T00:14:31Z","updated_at":"2016-10-30T00:12:47Z","closed_at":"2016-10-25T02:58:32Z","body":"In TermTable.cpp\r\n\r\n~~~\r\n    void TermTable::SetFactCount(size_t factCount)\r\n    {\r\n        EnsureSealed(false);\r\n\r\n        // Fact rows include the SystemTerm rows and one row for each user\r\n        // defined fact.\r\n        m_factRowCount = factCount + SystemTerm::Count;\r\n    }\r\n~~~\r\n\r\n~~~\r\n    size_t TermTable::GetTotalRowCount(Rank rank) const\r\n    {\r\n        // System term rows and fact rows are included in Rank 0, but not other\r\n        // ranks.\r\n        return m_sharedRowCounts[rank] +\r\n            ((rank == 0) ? (SystemTerm::Count + m_factRowCount) : 0);\r\n    }\r\n~~~\r\n\r\nSystemTerm::Count is added to m_factRowCount already, but then we add it again to get TotalRowCount."},"comment":{"url":"https://api.github.com/repos/BitFunnel/BitFunnel/issues/comments/257123597","html_url":"https://github.com/BitFunnel/BitFunnel/issues/256#issuecomment-257123597","issue_url":"https://api.github.com/repos/BitFunnel/BitFunnel/issues/256","id":257123597,"user":{"login":"danluu","id":157136,"avatar_url":"https://avatars.githubusercontent.com/u/157136?v=3","gravatar_id":"","url":"https://api.github.com/users/danluu","html_url":"https://github.com/danluu","followers_url":"https://api.github.com/users/danluu/followers","following_url":"https://api.github.com/users/danluu/following{/other_user}","gists_url":"https://api.github.com/users/danluu/gists{/gist_id}","starred_url":"https://api.github.com/users/danluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danluu/subscriptions","organizations_url":"https://api.github.com/users/danluu/orgs","repos_url":"https://api.github.com/users/danluu/repos","events_url":"https://api.github.com/users/danluu/events{/privacy}","received_events_url":"https://api.github.com/users/danluu/received_events","type":"User","site_admin":false},"created_at":"2016-10-30T00:12:47Z","updated_at":"2016-10-30T00:12:47Z","body":"Part of this fix was also committed in d5750e9a17d6184650ef9f389ac789f82b98c0ba"}}
{"actor":{"display_login":"danluu"}}