{"action":"created","issue":{"url":"https://api.github.com/repos/tomopy/tomopy/issues/217","repository_url":"https://api.github.com/repos/tomopy/tomopy","labels_url":"https://api.github.com/repos/tomopy/tomopy/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/tomopy/tomopy/issues/217/comments","events_url":"https://api.github.com/repos/tomopy/tomopy/issues/217/events","html_url":"https://github.com/tomopy/tomopy/pull/217","id":165688862,"number":217,"title":"WIP: Performance improvements","user":{"login":"dmpelt","id":3531031,"avatar_url":"https://avatars.githubusercontent.com/u/3531031?v=3","gravatar_id":"","url":"https://api.github.com/users/dmpelt","html_url":"https://github.com/dmpelt","followers_url":"https://api.github.com/users/dmpelt/followers","following_url":"https://api.github.com/users/dmpelt/following{/other_user}","gists_url":"https://api.github.com/users/dmpelt/gists{/gist_id}","starred_url":"https://api.github.com/users/dmpelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmpelt/subscriptions","organizations_url":"https://api.github.com/users/dmpelt/orgs","repos_url":"https://api.github.com/users/dmpelt/repos","events_url":"https://api.github.com/users/dmpelt/events{/privacy}","received_events_url":"https://api.github.com/users/dmpelt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2016-07-15T00:41:22Z","updated_at":"2016-07-21T00:36:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tomopy/tomopy/pulls/217","html_url":"https://github.com/tomopy/tomopy/pull/217","diff_url":"https://github.com/tomopy/tomopy/pull/217.diff","patch_url":"https://github.com/tomopy/tomopy/pull/217.patch"},"body":"This PR uses `numexpr` to decrease computation time.\r\n\r\nAt the moment I applied it to `normalize` only, but I think the same approach could work on some other functions as well. I still have to check thoroughly whether it produces identical output, but the decrease in computation time seems worth it: for a dataset with 1025 projections with 128 slices and 2000 detector pixels, it reduces the time it takes to perform normalization from 1.61 s to 0.249 s on my machine. On another machine it reduces the normalization time from 4.15 s to 0.96 s for a 1025x256x2000 dataset.\r\n\r\nI am not really sure what the cause is of the relatively slow performance of the current code on my machines: it could be that the `multiprocessing` module is doing some copying that we are not aware of. This could be related to the remarks at the end of #120.\r\n\r\nMaybe the computation time of other functions (such as reconstruction) could be reduced by the same approach. I will investigate this further later, so we can wait with merging this until a later time. \r\n\r\n@dgursoy What are your thoughts on this?"},"comment":{"url":"https://api.github.com/repos/tomopy/tomopy/issues/comments/234125053","html_url":"https://github.com/tomopy/tomopy/pull/217#issuecomment-234125053","issue_url":"https://api.github.com/repos/tomopy/tomopy/issues/217","id":234125053,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T00:36:36Z","updated_at":"2016-07-21T00:36:36Z","body":"\n[![Coverage Status](https://coveralls.io/builds/7096309/badge)](https://coveralls.io/builds/7096309)\n\nCoverage increased (+3.0%) to 51.359% when pulling **b27fa7144f243c238a3114645a6095754cb4af79 on dmpelt:faster_normalize** into **39203ce6e0f4f477fdd0952a57a899c862954c84 on tomopy:master**.\n"}}
{"actor":{"display_login":"coveralls"}}