{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/85775133","pull_request_review_id":6470422,"id":85775133,"diff_hunk":"@@ -631,6 +631,10 @@ Argument_UnmanagedMemAccessorWrapAround = The UnmanagedMemoryAccessor capacity a\n Argument_UnrecognizedLoaderOptimization = Unrecognized LOADER_OPTIMIZATION property value.  Supported values may include \"SingleDomain\", \"MultiDomain\", \"MultiDomainHost\", and \"NotSpecified\".\n ArgumentException_NotAllCustomSortingFuncsDefined = Implementations of all the NLS functions must be provided.\n ArgumentException_MinSortingVersion = The runtime does not support a version of \"{0}\" less than {1}.\n+#if FEATURE_SPAN_OF_T\n+Argument_InvalidTypeWithPointersNotSupported = Cannot use type '{0}'. Only value types without pointers are supported.","path":"src/mscorlib/src/mscorlib.txt","position":null,"original_position":5,"commit_id":"b918157eafbbe6e73b6189dd4ab1d9426e9654fd","original_commit_id":"ed289391e8b573a7358717eb8ba8aa89975b8943","user":{"login":"AtsushiKan","id":13223578,"avatar_url":"https://avatars.githubusercontent.com/u/13223578?v=3","gravatar_id":"","url":"https://api.github.com/users/AtsushiKan","html_url":"https://github.com/AtsushiKan","followers_url":"https://api.github.com/users/AtsushiKan/followers","following_url":"https://api.github.com/users/AtsushiKan/following{/other_user}","gists_url":"https://api.github.com/users/AtsushiKan/gists{/gist_id}","starred_url":"https://api.github.com/users/AtsushiKan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AtsushiKan/subscriptions","organizations_url":"https://api.github.com/users/AtsushiKan/orgs","repos_url":"https://api.github.com/users/AtsushiKan/repos","events_url":"https://api.github.com/users/AtsushiKan/events{/privacy}","received_events_url":"https://api.github.com/users/AtsushiKan/received_events","type":"User","site_admin":false},"body":"Some of the doc comments also contain the text \"type may not contain pointers.\"\r\n\r\nAnd how does runtime enforcement of this (JitHelpers.ContainsGcReferences) happen on the OOB version?\r\n\r\n\r\n","created_at":"2016-10-31T16:20:58Z","updated_at":"2016-10-31T16:20:58Z","html_url":"https://github.com/dotnet/coreclr/pull/7886#discussion_r85775133","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7886","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/85775133"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7886#discussion_r85775133"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7886"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/7886","id":91475727,"html_url":"https://github.com/dotnet/coreclr/pull/7886","diff_url":"https://github.com/dotnet/coreclr/pull/7886.diff","patch_url":"https://github.com/dotnet/coreclr/pull/7886.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/7886","number":7886,"state":"open","locked":false,"title":"Merge SpanOfT branch into master","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"Part of https://github.com/dotnet/coreclr/issues/5851\n","created_at":"2016-10-29T02:23:45Z","updated_at":"2016-10-31T16:20:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0c19ff463d0b330185b079a1457e50221e7cd47","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7886/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/7886/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/7886/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/b918157eafbbe6e73b6189dd4ab1d9426e9654fd","head":{"label":"jkotas:SpanOfT","ref":"SpanOfT","sha":"b918157eafbbe6e73b6189dd4ab1d9426e9654fd","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"repo":{"id":30278571,"name":"coreclr","full_name":"jkotas/coreclr","owner":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkotas/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/jkotas/coreclr","forks_url":"https://api.github.com/repos/jkotas/coreclr/forks","keys_url":"https://api.github.com/repos/jkotas/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkotas/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkotas/coreclr/teams","hooks_url":"https://api.github.com/repos/jkotas/coreclr/hooks","issue_events_url":"https://api.github.com/repos/jkotas/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/jkotas/coreclr/events","assignees_url":"https://api.github.com/repos/jkotas/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/jkotas/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/jkotas/coreclr/tags","blobs_url":"https://api.github.com/repos/jkotas/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkotas/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkotas/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkotas/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkotas/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/jkotas/coreclr/languages","stargazers_url":"https://api.github.com/repos/jkotas/coreclr/stargazers","contributors_url":"https://api.github.com/repos/jkotas/coreclr/contributors","subscribers_url":"https://api.github.com/repos/jkotas/coreclr/subscribers","subscription_url":"https://api.github.com/repos/jkotas/coreclr/subscription","commits_url":"https://api.github.com/repos/jkotas/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkotas/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkotas/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkotas/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkotas/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/jkotas/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkotas/coreclr/merges","archive_url":"https://api.github.com/repos/jkotas/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkotas/coreclr/downloads","issues_url":"https://api.github.com/repos/jkotas/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/jkotas/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/jkotas/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/jkotas/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkotas/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/jkotas/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/jkotas/coreclr/deployments","created_at":"2015-02-04T03:09:04Z","updated_at":"2016-10-22T02:46:15Z","pushed_at":"2016-10-31T16:20:51Z","git_url":"git://github.com/jkotas/coreclr.git","ssh_url":"git@github.com:jkotas/coreclr.git","clone_url":"https://github.com/jkotas/coreclr.git","svn_url":"https://github.com/jkotas/coreclr","homepage":"","size":114099,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"3fc65f37cd4bf5989647f6e1a48da6821ea5adbd","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2016-10-31T11:37:35Z","pushed_at":"2016-10-31T16:20:53Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":129695,"stargazers_count":6997,"watchers_count":6997,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1694,"mirror_url":null,"open_issues_count":992,"forks":1694,"open_issues":992,"watchers":6997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7886"},"html":{"href":"https://github.com/dotnet/coreclr/pull/7886"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7886"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/7886/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7886/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/7886/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/b918157eafbbe6e73b6189dd4ab1d9426e9654fd"}}}}
{"actor":{"display_login":"AtsushiKan"}}