{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/77158951","id":77158951,"diff_hunk":"@@ -87,45 +91,35 @@ def _get_exec(names, is_valid_path=lambda _path: True):\n \n def _get_virtualenv_script_dir():\n     # Virtualenv calls its scripts folder \"bin\" on linux/OSX/MSYS64 but \"Scripts\" on Windows\n-    if os.name == \"nt\" and os.path.sep != \"/\":\n+    if os.name == \"nt\" and os.sep != \"/\":\n         return \"Scripts\"\n     return \"bin\"\n \n \n-# Possible names of executables, sorted from most to least specific\n-PYTHON_NAMES = [\"python-2.7\", \"python2.7\", \"python2\", \"python\"]\n-VIRTUALENV_NAMES = [\"virtualenv-2.7\", \"virtualenv2.7\", \"virtualenv2\", \"virtualenv\"]\n-PIP_NAMES = [\"pip-2.7\", \"pip2.7\", \"pip2\", \"pip\"]\n-\n-\n def _activate_virtualenv(topdir):\n     virtualenv_path = os.path.join(topdir, \"python\", \"_virtualenv\")\n     check_exec_path = lambda path: path.startswith(virtualenv_path)\n-    python = _get_exec(PYTHON_NAMES)\n-    if python is None:\n-        sys.exit(\"Python is not installed. Please install it prior to running mach.\")\n+    python = _get_exec_path(PYTHON_NAMES)   # If there was no python, mach wouldn't have run at all!","path":"python/mach_bootstrap.py","position":null,"original_position":56,"commit_id":"25fb46efc9a95fedc4e9209badccd0eaeacfdbd1","original_commit_id":"25fb46efc9a95fedc4e9209badccd0eaeacfdbd1","user":{"login":"Ms2ger","id":111161,"avatar_url":"https://avatars.githubusercontent.com/u/111161?v=3","gravatar_id":"","url":"https://api.github.com/users/Ms2ger","html_url":"https://github.com/Ms2ger","followers_url":"https://api.github.com/users/Ms2ger/followers","following_url":"https://api.github.com/users/Ms2ger/following{/other_user}","gists_url":"https://api.github.com/users/Ms2ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Ms2ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ms2ger/subscriptions","organizations_url":"https://api.github.com/users/Ms2ger/orgs","repos_url":"https://api.github.com/users/Ms2ger/repos","events_url":"https://api.github.com/users/Ms2ger/events{/privacy}","received_events_url":"https://api.github.com/users/Ms2ger/received_events","type":"User","site_admin":false},"body":"But that doesn't mean we'll find it here; keep the check, but feel free to change the error message","created_at":"2016-09-01T11:50:31Z","updated_at":"2016-09-01T11:50:31Z","html_url":"https://github.com/servo/servo/pull/13151#discussion_r77158951","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/13151","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/77158951"},"html":{"href":"https://github.com/servo/servo/pull/13151#discussion_r77158951"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/13151"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/13151","id":83613957,"html_url":"https://github.com/servo/servo/pull/13151","diff_url":"https://github.com/servo/servo/pull/13151.diff","patch_url":"https://github.com/servo/servo/pull/13151.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/13151","number":13151,"state":"open","locked":false,"title":"Make sure that mach gets the correct paths of executables in virtualenv","user":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [x] `./mach build -d` does not report any errors\r\n- [x] `./mach test-tidy` does not report any errors\r\n- [x] These changes fix #13141 (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [x] These changes do not require tests because it's a cleanup related to `mach`\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/13151)\n<!-- Reviewable:end -->\n","created_at":"2016-09-01T11:16:33Z","updated_at":"2016-09-01T11:50:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3bc7381f8f27ac528ea1fcd776852d670c09b1eb","assignee":{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false},"assignees":[{"login":"metajack","id":28357,"avatar_url":"https://avatars.githubusercontent.com/u/28357?v=3","gravatar_id":"","url":"https://api.github.com/users/metajack","html_url":"https://github.com/metajack","followers_url":"https://api.github.com/users/metajack/followers","following_url":"https://api.github.com/users/metajack/following{/other_user}","gists_url":"https://api.github.com/users/metajack/gists{/gist_id}","starred_url":"https://api.github.com/users/metajack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metajack/subscriptions","organizations_url":"https://api.github.com/users/metajack/orgs","repos_url":"https://api.github.com/users/metajack/repos","events_url":"https://api.github.com/users/metajack/events{/privacy}","received_events_url":"https://api.github.com/users/metajack/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/13151/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/13151/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/13151/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/25fb46efc9a95fedc4e9209badccd0eaeacfdbd1","head":{"label":"Wafflespeanut:mach_cleanup","ref":"mach_cleanup","sha":"25fb46efc9a95fedc4e9209badccd0eaeacfdbd1","user":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"repo":{"id":36719071,"name":"servo","full_name":"Wafflespeanut/servo","owner":{"login":"Wafflespeanut","id":6691262,"avatar_url":"https://avatars.githubusercontent.com/u/6691262?v=3","gravatar_id":"","url":"https://api.github.com/users/Wafflespeanut","html_url":"https://github.com/Wafflespeanut","followers_url":"https://api.github.com/users/Wafflespeanut/followers","following_url":"https://api.github.com/users/Wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/Wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/Wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/Wafflespeanut/orgs","repos_url":"https://api.github.com/users/Wafflespeanut/repos","events_url":"https://api.github.com/users/Wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/Wafflespeanut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wafflespeanut/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/Wafflespeanut/servo","forks_url":"https://api.github.com/repos/Wafflespeanut/servo/forks","keys_url":"https://api.github.com/repos/Wafflespeanut/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wafflespeanut/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wafflespeanut/servo/teams","hooks_url":"https://api.github.com/repos/Wafflespeanut/servo/hooks","issue_events_url":"https://api.github.com/repos/Wafflespeanut/servo/issues/events{/number}","events_url":"https://api.github.com/repos/Wafflespeanut/servo/events","assignees_url":"https://api.github.com/repos/Wafflespeanut/servo/assignees{/user}","branches_url":"https://api.github.com/repos/Wafflespeanut/servo/branches{/branch}","tags_url":"https://api.github.com/repos/Wafflespeanut/servo/tags","blobs_url":"https://api.github.com/repos/Wafflespeanut/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wafflespeanut/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wafflespeanut/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wafflespeanut/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wafflespeanut/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/Wafflespeanut/servo/languages","stargazers_url":"https://api.github.com/repos/Wafflespeanut/servo/stargazers","contributors_url":"https://api.github.com/repos/Wafflespeanut/servo/contributors","subscribers_url":"https://api.github.com/repos/Wafflespeanut/servo/subscribers","subscription_url":"https://api.github.com/repos/Wafflespeanut/servo/subscription","commits_url":"https://api.github.com/repos/Wafflespeanut/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wafflespeanut/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wafflespeanut/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wafflespeanut/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wafflespeanut/servo/contents/{+path}","compare_url":"https://api.github.com/repos/Wafflespeanut/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wafflespeanut/servo/merges","archive_url":"https://api.github.com/repos/Wafflespeanut/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wafflespeanut/servo/downloads","issues_url":"https://api.github.com/repos/Wafflespeanut/servo/issues{/number}","pulls_url":"https://api.github.com/repos/Wafflespeanut/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/Wafflespeanut/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/Wafflespeanut/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wafflespeanut/servo/labels{/name}","releases_url":"https://api.github.com/repos/Wafflespeanut/servo/releases{/id}","deployments_url":"https://api.github.com/repos/Wafflespeanut/servo/deployments","created_at":"2015-06-02T08:27:10Z","updated_at":"2015-10-15T16:10:31Z","pushed_at":"2016-09-01T11:45:03Z","git_url":"git://github.com/Wafflespeanut/servo.git","ssh_url":"git@github.com:Wafflespeanut/servo.git","clone_url":"https://github.com/Wafflespeanut/servo.git","svn_url":"https://github.com/Wafflespeanut/servo","homepage":"","size":167913,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"f787e8ed659babc43c5dd3f5e67e591796ca7a70","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2016-09-01T10:29:46Z","pushed_at":"2016-09-01T11:45:35Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":293614,"stargazers_count":7834,"watchers_count":7834,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1267,"mirror_url":null,"open_issues_count":1731,"forks":1267,"open_issues":1731,"watchers":7834,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/13151"},"html":{"href":"https://github.com/servo/servo/pull/13151"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/13151"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/13151/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/13151/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/13151/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/25fb46efc9a95fedc4e9209badccd0eaeacfdbd1"}}}}
{"actor":{"display_login":"Ms2ger"}}