{"action":"created","issue":{"url":"https://api.github.com/repos/CindyJS/CindyJS/issues/493","repository_url":"https://api.github.com/repos/CindyJS/CindyJS","labels_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/493/labels{/name}","comments_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/493/comments","events_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/493/events","html_url":"https://github.com/CindyJS/CindyJS/pull/493","id":179489192,"number":493,"title":"Various fixes, mostly related to EditableText","user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/CindyJS/CindyJS/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/CindyJS/CindyJS/labels/mc%C2%B2","name":"mc²","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false},"assignees":[{"login":"strobelm","id":14185442,"avatar_url":"https://avatars.githubusercontent.com/u/14185442?v=3","gravatar_id":"","url":"https://api.github.com/users/strobelm","html_url":"https://github.com/strobelm","followers_url":"https://api.github.com/users/strobelm/followers","following_url":"https://api.github.com/users/strobelm/following{/other_user}","gists_url":"https://api.github.com/users/strobelm/gists{/gist_id}","starred_url":"https://api.github.com/users/strobelm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strobelm/subscriptions","organizations_url":"https://api.github.com/users/strobelm/orgs","repos_url":"https://api.github.com/users/strobelm/repos","events_url":"https://api.github.com/users/strobelm/events{/privacy}","received_events_url":"https://api.github.com/users/strobelm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2016-09-27T13:13:07Z","updated_at":"2016-09-27T15:52:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CindyJS/CindyJS/pulls/493","html_url":"https://github.com/CindyJS/CindyJS/pull/493","diff_url":"https://github.com/CindyJS/CindyJS/pull/493.diff","patch_url":"https://github.com/CindyJS/CindyJS/pull/493.patch"},"body":"This fixes some exceptions I observed, and also adds support for the `fillcolor` accessor for `EditableText`. Please read the commit messages for further details."},"comment":{"url":"https://api.github.com/repos/CindyJS/CindyJS/issues/comments/249908354","html_url":"https://github.com/CindyJS/CindyJS/pull/493#issuecomment-249908354","issue_url":"https://api.github.com/repos/CindyJS/CindyJS/issues/493","id":249908354,"user":{"login":"gagern","id":190759,"avatar_url":"https://avatars.githubusercontent.com/u/190759?v=3","gravatar_id":"","url":"https://api.github.com/users/gagern","html_url":"https://github.com/gagern","followers_url":"https://api.github.com/users/gagern/followers","following_url":"https://api.github.com/users/gagern/following{/other_user}","gists_url":"https://api.github.com/users/gagern/gists{/gist_id}","starred_url":"https://api.github.com/users/gagern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gagern/subscriptions","organizations_url":"https://api.github.com/users/gagern/orgs","repos_url":"https://api.github.com/users/gagern/repos","events_url":"https://api.github.com/users/gagern/events{/privacy}","received_events_url":"https://api.github.com/users/gagern/received_events","type":"User","site_admin":false},"created_at":"2016-09-27T15:52:37Z","updated_at":"2016-09-27T15:52:37Z","body":"I'm not sure we want to stress performance over maintainability. I doubt that one `sqrt` per text will make much of a difference in the grand scheme of things. If we were to optimize this kind of thing we should do so in a separate commit, and do it for points and lines and conics as well.\r\n\r\nIs this a breaking change, since it makes texts movable which were fixed so far, which could have adverse effects on existing widgets? I think it's more of a bug fix, and any content which relies on texts not being movable should have been pinning them to ensure that."}}
{"actor":{"display_login":"gagern"}}