{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/28221","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/28221/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/28221/comments","events_url":"https://api.github.com/repos/docker/docker/issues/28221/events","html_url":"https://github.com/docker/docker/pull/28221","id":188379922,"number":28221,"title":"Add local address autodetection on swarm init","user":{"login":"aboch","id":10080882,"avatar_url":"https://avatars.githubusercontent.com/u/10080882?v=3","gravatar_id":"","url":"https://api.github.com/users/aboch","html_url":"https://github.com/aboch","followers_url":"https://api.github.com/users/aboch/followers","following_url":"https://api.github.com/users/aboch/following{/other_user}","gists_url":"https://api.github.com/users/aboch/gists{/gist_id}","starred_url":"https://api.github.com/users/aboch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboch/subscriptions","organizations_url":"https://api.github.com/users/aboch/orgs","repos_url":"https://api.github.com/users/aboch/repos","events_url":"https://api.github.com/users/aboch/events{/privacy}","received_events_url":"https://api.github.com/users/aboch/received_events","type":"User","site_admin":false},"labels":[{"id":175375407,"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"assignees":[{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/docker/docker/milestones/56","html_url":"https://github.com/docker/docker/milestones/1.13.0","labels_url":"https://api.github.com/repos/docker/docker/milestones/56/labels","id":1839404,"number":56,"title":"1.13.0","description":"","creator":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"open_issues":103,"closed_issues":693,"state":"open","created_at":"2016-06-20T22:51:25Z","updated_at":"2016-11-10T03:29:19Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2016-11-09T23:28:54Z","updated_at":"2016-11-10T03:59:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/28221","html_url":"https://github.com/docker/docker/pull/28221","diff_url":"https://github.com/docker/docker/pull/28221.diff","patch_url":"https://github.com/docker/docker/pull/28221.patch"},"body":"**- What I did**\r\nAdded local address auto detection during `swarm init` when `--advertise-addr` is a non local address.\r\nIt is the same best-effort auto detection logic which is being used when advertise address is not specified.\r\n\r\n**- How to verify it**\r\nForm a cluster on AWS with \r\n`swarm init --advertise-addr <this VM public IP>` and\r\n`swarm join ... --advertise-addr <this VM public IP>`\r\n\r\nCreate a service over an encrypted overlay network and make sure tasks can talk to other nodes' tasks. Run a container on the attachable network and make sure it can access the service.\r\n\r\nFixes #27647 \r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![840756455839-cute-wallpapers-animals-nature-cat-animal-pictures-garden](https://cloud.githubusercontent.com/assets/10080882/20158559/cd6a4794-a68f-11e6-81ca-b58ccfea7e75.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/259596338","html_url":"https://github.com/docker/docker/pull/28221#issuecomment-259596338","issue_url":"https://api.github.com/repos/docker/docker/issues/28221","id":259596338,"user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"created_at":"2016-11-10T03:59:46Z","updated_at":"2016-11-10T03:59:46Z","body":"LGTM\r\n\r\n@aboch is it possible to write a integration-test for this ?"}}
{"actor":{"display_login":"mavenugo"}}