{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments/90697370","pull_request_review_id":11217378,"id":90697370,"diff_hunk":"@@ -0,0 +1,36 @@\n+import socket\n+import ssl\n+import httplib\n+\n+# Adapted from http://code.activestate.com/recipes/577548-https-httplib-client-connection-with-certificate-v/\n+# BSD-licensed.\n+\n+\n+class HTTPSCaCertConnection(httplib.HTTPSConnection):\n+    \"\"\" Class to make a HTTPS connection, with support for full client-based SSL Authentication\"\"\"","path":"prestoadmin/util/httpscacertconnection.py","position":10,"original_position":10,"commit_id":"c4d1d2045a4cfcff0e210cb392cdbdca5a723f33","original_commit_id":"ed2c7b9345b6cb00fc2c8ee41e5115631f751616","user":{"login":"ebd2","id":12751788,"avatar_url":"https://avatars.githubusercontent.com/u/12751788?v=3","gravatar_id":"","url":"https://api.github.com/users/ebd2","html_url":"https://github.com/ebd2","followers_url":"https://api.github.com/users/ebd2/followers","following_url":"https://api.github.com/users/ebd2/following{/other_user}","gists_url":"https://api.github.com/users/ebd2/gists{/gist_id}","starred_url":"https://api.github.com/users/ebd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebd2/subscriptions","organizations_url":"https://api.github.com/users/ebd2/orgs","repos_url":"https://api.github.com/users/ebd2/repos","events_url":"https://api.github.com/users/ebd2/events{/privacy}","received_events_url":"https://api.github.com/users/ebd2/received_events","type":"User","site_admin":false},"body":"No, we need this because 2.6.x and < 2.7.9 don't support it. This sets up the ca-certs (using the one from the private key) so that cert validation passes on new versions of python, while *also* working on old versions.","created_at":"2016-12-02T18:48:02Z","updated_at":"2016-12-02T18:48:02Z","html_url":"https://github.com/prestodb/presto-admin/pull/288#discussion_r90697370","pull_request_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/288","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments/90697370"},"html":{"href":"https://github.com/prestodb/presto-admin/pull/288#discussion_r90697370"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto-admin/pulls/288","id":95941179,"html_url":"https://github.com/prestodb/presto-admin/pull/288","diff_url":"https://github.com/prestodb/presto-admin/pull/288.diff","patch_url":"https://github.com/prestodb/presto-admin/pull/288.patch","issue_url":"https://api.github.com/repos/prestodb/presto-admin/issues/288","number":288,"state":"open","locked":false,"title":"Https client","user":{"login":"ebd2","id":12751788,"avatar_url":"https://avatars.githubusercontent.com/u/12751788?v=3","gravatar_id":"","url":"https://api.github.com/users/ebd2","html_url":"https://github.com/ebd2","followers_url":"https://api.github.com/users/ebd2/followers","following_url":"https://api.github.com/users/ebd2/following{/other_user}","gists_url":"https://api.github.com/users/ebd2/gists{/gist_id}","starred_url":"https://api.github.com/users/ebd2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebd2/subscriptions","organizations_url":"https://api.github.com/users/ebd2/orgs","repos_url":"https://api.github.com/users/ebd2/repos","events_url":"https://api.github.com/users/ebd2/events{/privacy}","received_events_url":"https://api.github.com/users/ebd2/received_events","type":"User","site_admin":false},"body":"Super rough for initial feedback.","created_at":"2016-11-30T17:52:03Z","updated_at":"2016-12-02T18:48:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45412d0b584d753b145484b2570e550bfe989500","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/288/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/288/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto-admin/issues/288/comments","statuses_url":"https://api.github.com/repos/prestodb/presto-admin/statuses/c4d1d2045a4cfcff0e210cb392cdbdca5a723f33","head":{"label":"Teradata:https-client","ref":"https-client","sha":"c4d1d2045a4cfcff0e210cb392cdbdca5a723f33","user":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"repo":{"id":49295918,"name":"presto-admin","full_name":"Teradata/presto-admin","owner":{"login":"Teradata","id":1615979,"avatar_url":"https://avatars.githubusercontent.com/u/1615979?v=3","gravatar_id":"","url":"https://api.github.com/users/Teradata","html_url":"https://github.com/Teradata","followers_url":"https://api.github.com/users/Teradata/followers","following_url":"https://api.github.com/users/Teradata/following{/other_user}","gists_url":"https://api.github.com/users/Teradata/gists{/gist_id}","starred_url":"https://api.github.com/users/Teradata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teradata/subscriptions","organizations_url":"https://api.github.com/users/Teradata/orgs","repos_url":"https://api.github.com/users/Teradata/repos","events_url":"https://api.github.com/users/Teradata/events{/privacy}","received_events_url":"https://api.github.com/users/Teradata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Teradata/presto-admin","description":"A tool to install, configure and manage Presto installations","fork":true,"url":"https://api.github.com/repos/Teradata/presto-admin","forks_url":"https://api.github.com/repos/Teradata/presto-admin/forks","keys_url":"https://api.github.com/repos/Teradata/presto-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teradata/presto-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teradata/presto-admin/teams","hooks_url":"https://api.github.com/repos/Teradata/presto-admin/hooks","issue_events_url":"https://api.github.com/repos/Teradata/presto-admin/issues/events{/number}","events_url":"https://api.github.com/repos/Teradata/presto-admin/events","assignees_url":"https://api.github.com/repos/Teradata/presto-admin/assignees{/user}","branches_url":"https://api.github.com/repos/Teradata/presto-admin/branches{/branch}","tags_url":"https://api.github.com/repos/Teradata/presto-admin/tags","blobs_url":"https://api.github.com/repos/Teradata/presto-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teradata/presto-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teradata/presto-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teradata/presto-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teradata/presto-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/Teradata/presto-admin/languages","stargazers_url":"https://api.github.com/repos/Teradata/presto-admin/stargazers","contributors_url":"https://api.github.com/repos/Teradata/presto-admin/contributors","subscribers_url":"https://api.github.com/repos/Teradata/presto-admin/subscribers","subscription_url":"https://api.github.com/repos/Teradata/presto-admin/subscription","commits_url":"https://api.github.com/repos/Teradata/presto-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teradata/presto-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teradata/presto-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teradata/presto-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teradata/presto-admin/contents/{+path}","compare_url":"https://api.github.com/repos/Teradata/presto-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teradata/presto-admin/merges","archive_url":"https://api.github.com/repos/Teradata/presto-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teradata/presto-admin/downloads","issues_url":"https://api.github.com/repos/Teradata/presto-admin/issues{/number}","pulls_url":"https://api.github.com/repos/Teradata/presto-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/Teradata/presto-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/Teradata/presto-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teradata/presto-admin/labels{/name}","releases_url":"https://api.github.com/repos/Teradata/presto-admin/releases{/id}","deployments_url":"https://api.github.com/repos/Teradata/presto-admin/deployments","created_at":"2016-01-08T20:59:23Z","updated_at":"2016-11-14T21:00:06Z","pushed_at":"2016-12-01T22:45:44Z","git_url":"git://github.com/Teradata/presto-admin.git","ssh_url":"git@github.com:Teradata/presto-admin.git","clone_url":"https://github.com/Teradata/presto-admin.git","svn_url":"https://github.com/Teradata/presto-admin","homepage":"http://www.teradata.com/presto","size":39336,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":31,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"fc2470f029338a34b70104f88ce3d7acb612e9a7","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":36050721,"name":"presto-admin","full_name":"prestodb/presto-admin","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/presto-admin","description":"A tool to install, configure and manage Presto installations","fork":false,"url":"https://api.github.com/repos/prestodb/presto-admin","forks_url":"https://api.github.com/repos/prestodb/presto-admin/forks","keys_url":"https://api.github.com/repos/prestodb/presto-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto-admin/teams","hooks_url":"https://api.github.com/repos/prestodb/presto-admin/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto-admin/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto-admin/events","assignees_url":"https://api.github.com/repos/prestodb/presto-admin/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto-admin/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto-admin/tags","blobs_url":"https://api.github.com/repos/prestodb/presto-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto-admin/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto-admin/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto-admin/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto-admin/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto-admin/subscription","commits_url":"https://api.github.com/repos/prestodb/presto-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto-admin/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto-admin/merges","archive_url":"https://api.github.com/repos/prestodb/presto-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto-admin/downloads","issues_url":"https://api.github.com/repos/prestodb/presto-admin/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto-admin/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto-admin/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto-admin/deployments","created_at":"2015-05-22T03:40:42Z","updated_at":"2016-11-22T14:14:22Z","pushed_at":"2016-12-01T22:45:44Z","git_url":"git://github.com/prestodb/presto-admin.git","ssh_url":"git@github.com:prestodb/presto-admin.git","clone_url":"https://github.com/prestodb/presto-admin.git","svn_url":"https://github.com/prestodb/presto-admin","homepage":"http://prestodb.github.io/presto-admin/","size":40177,"stargazers_count":59,"watchers_count":59,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":44,"forks":23,"open_issues":44,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/288"},"html":{"href":"https://github.com/prestodb/presto-admin/pull/288"},"issue":{"href":"https://api.github.com/repos/prestodb/presto-admin/issues/288"},"comments":{"href":"https://api.github.com/repos/prestodb/presto-admin/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto-admin/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto-admin/statuses/c4d1d2045a4cfcff0e210cb392cdbdca5a723f33"}}}}
{"actor":{"display_login":"ebd2"}}