{"action":"created","issue":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/1066","repository_url":"https://api.github.com/repos/habitat-sh/habitat","labels_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1066/labels{/name}","comments_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1066/comments","events_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1066/events","html_url":"https://github.com/habitat-sh/habitat/issues/1066","id":165761887,"number":1066,"title":"Most executables and libraries are not stripped (feature not bug?)","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/habitat-sh/habitat/labels/Feature","name":"Feature","color":"1d76db"},{"url":"https://api.github.com/repos/habitat-sh/habitat/labels/In%20Progress","name":"In Progress","color":"c2e0c6"}],"state":"open","locked":false,"assignee":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"assignees":[{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2016-07-15T11:00:32Z","updated_at":"2016-07-21T16:57:42Z","closed_at":null,"body":"Despite the following log output:\r\n\r\n```\r\nStripping unneeded symbols from binaries and libraries\r\n```\r\n\r\nMost of the executables and libraries are not stripped.  The cause of this is the following invocation of `find` in plan-build:\r\n\r\nhttps://github.com/habitat-sh/habitat/blob/master/components/plan-build/bin/hab-plan-build.sh#L2046\r\n\r\n`-perm u+w` will only match files with mode 0200 which is likely rather rare.  I believe the intent here was probably `-perm -u+w` (note the leading `-`), which will match any permission where the owner has write permissions.  \r\n\r\nBefore I put together a quick PR, I was wondering if, given the fact that most of the packages I've pulled down from `core` aren't currently stripped, if y'all still feel if stripping the executables are the right default behavior.  Stripping the executables reduces their size but at the expense of what can be valuable debugging information.\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/habitat-sh/habitat/issues/comments/234316218","html_url":"https://github.com/habitat-sh/habitat/issues/1066#issuecomment-234316218","issue_url":"https://api.github.com/repos/habitat-sh/habitat/issues/1066","id":234316218,"user":{"login":"fnichol","id":261548,"avatar_url":"https://avatars.githubusercontent.com/u/261548?v=3","gravatar_id":"","url":"https://api.github.com/users/fnichol","html_url":"https://github.com/fnichol","followers_url":"https://api.github.com/users/fnichol/followers","following_url":"https://api.github.com/users/fnichol/following{/other_user}","gists_url":"https://api.github.com/users/fnichol/gists{/gist_id}","starred_url":"https://api.github.com/users/fnichol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnichol/subscriptions","organizations_url":"https://api.github.com/users/fnichol/orgs","repos_url":"https://api.github.com/users/fnichol/repos","events_url":"https://api.github.com/users/fnichol/events{/privacy}","received_events_url":"https://api.github.com/users/fnichol/received_events","type":"User","site_admin":false},"created_at":"2016-07-21T16:57:42Z","updated_at":"2016-07-21T16:57:42Z","body":"Yep, that was a bug--the intended default was to strip as all other OS packaging systems do by default. The easiest \"opt-out\" for Plan authors is to override the `do_strip()` phase like so:\r\n\r\n```sh\r\ndo_strip() {\r\n  return 0\r\n}\r\n```\r\n\r\nI'd advocate that we need to be extremely careful with environment variables that drive different build behaviors. If we push things too far, it will no longer be possible to have a) consistent builds, b) full knowledge about how the package was built. The `DEBUG_BUILD` env var in #1085 but I'm not totally sold yet :) Just thinking on it though"}}
{"actor":{"display_login":"fnichol"}}