{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/10713","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/10713/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/10713/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/10713/events","html_url":"https://github.com/xbmc/xbmc/pull/10713","id":183251125,"number":10713,"title":"configure: fix aarch64 builds","user":{"login":"koenkooi","id":259525,"avatar_url":"https://avatars.githubusercontent.com/u/259525?v=3","gravatar_id":"","url":"https://api.github.com/users/koenkooi","html_url":"https://github.com/koenkooi","followers_url":"https://api.github.com/users/koenkooi/followers","following_url":"https://api.github.com/users/koenkooi/following{/other_user}","gists_url":"https://api.github.com/users/koenkooi/gists{/gist_id}","starred_url":"https://api.github.com/users/koenkooi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koenkooi/subscriptions","organizations_url":"https://api.github.com/users/koenkooi/orgs","repos_url":"https://api.github.com/users/koenkooi/repos","events_url":"https://api.github.com/users/koenkooi/events{/privacy}","received_events_url":"https://api.github.com/users/koenkooi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-10-16T05:55:48Z","updated_at":"2016-10-16T07:25:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/10713","html_url":"https://github.com/xbmc/xbmc/pull/10713","diff_url":"https://github.com/xbmc/xbmc/pull/10713.diff","patch_url":"https://github.com/xbmc/xbmc/pull/10713.patch"},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\nJust like x86* aarch64 has platforms that can be full openGL and/or full openGLES. In the case of mesa/freedreno on Qualcomm SoCs, building against GLES will fail, but full GL works.\r\n\r\nSo stop hardcoding GL/GLES/Wayland and let honour the --enable-gl flags passed to configure.\r\n\r\n## Motivation and Context\r\nAfter running into Keith and @MartijnKaijser last week I wanted to switch from Jarvis to Krypton on my Dragonboard-410c to test the ffmpeg-v4l2 patches. It didn't build, so I tracked the failure down to the point where I replaced the aarch64 patch I wrote with the upstream one.\r\n\r\n## How Has This Been Tested?\r\nConfigure now does the right thing now:\r\n```\r\n------------------------\r\n  Kodi Configuration:\r\n------------------------\r\n  Kodi Version:\t17.0-BETA4\r\n  git Rev.:\t20161015-2f143a8\r\n  Debugging:\tYes\r\n  Profiling:\tNo\r\n  Optimization:\tYes\r\n  SWIG Available:\tYes\r\n  JRE Available:\tYes\r\n  Doxygen Available:\tNo\r\n  Crosscomp.:\tYes\r\n  target ARCH:\taarch64\r\n  target CPU:\t\r\n  OpenGL:\tYes\r\n```\r\nCompilation succeeds, and it runs, see screenshot below.\r\n\r\n## Screenshots (if appropriate):\r\n![img_7394](https://cloud.githubusercontent.com/assets/259525/19415599/06b851ea-9375-11e6-9360-24be9a0597e9.JPG)\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\nI'm not 100% sure this is non-breaking change, but Libreelec always sets the appropriate --enable-opengl/gles, so they won't see breakage.\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/254031992","html_url":"https://github.com/xbmc/xbmc/pull/10713#issuecomment-254031992","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/10713","id":254031992,"user":{"login":"wsnipex","id":909455,"avatar_url":"https://avatars.githubusercontent.com/u/909455?v=3","gravatar_id":"","url":"https://api.github.com/users/wsnipex","html_url":"https://github.com/wsnipex","followers_url":"https://api.github.com/users/wsnipex/followers","following_url":"https://api.github.com/users/wsnipex/following{/other_user}","gists_url":"https://api.github.com/users/wsnipex/gists{/gist_id}","starred_url":"https://api.github.com/users/wsnipex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wsnipex/subscriptions","organizations_url":"https://api.github.com/users/wsnipex/orgs","repos_url":"https://api.github.com/users/wsnipex/repos","events_url":"https://api.github.com/users/wsnipex/events{/privacy}","received_events_url":"https://api.github.com/users/wsnipex/received_events","type":"User","site_admin":false},"created_at":"2016-10-16T07:25:22Z","updated_at":"2016-10-16T07:25:22Z","body":"thanks! Please note that we are moving to a cmake based build system and will deprecate autotools soon, so would be great if you could test https://github.com/xbmc/xbmc/tree/master/project/cmake as well."}}
{"actor":{"display_login":"wsnipex"}}