{"action":"created","comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/comments/56040316","id":56040316,"diff_hunk":"@@ -10,23 +10,39 @@\n Thread.abort_on_exception = true\n describe \"A client\" do\n   let(:certificate) { Flores::PKI.generate }\n-  let(:certificate_file_crt) { \"certificate.crt\" }\n-  let(:certificate_file_key) { \"certificate.key\" }\n+  let(:certificate_file_crt) do","path":"spec/integration_spec.rb","position":6,"original_position":6,"commit_id":"d238cd1bdedd8fd104a106c5c13e9ca3937c1428","original_commit_id":"d238cd1bdedd8fd104a106c5c13e9ca3937c1428","user":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"body":"use `let_tmp_file` here?","created_at":"2016-03-14T17:28:09Z","updated_at":"2016-03-14T17:28:09Z","html_url":"https://github.com/logstash-plugins/logstash-input-beats/pull/56#discussion_r56040316","pull_request_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/comments/56040316"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-beats/pull/56#discussion_r56040316"},"pull_request":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56","id":62245637,"html_url":"https://github.com/logstash-plugins/logstash-input-beats/pull/56","diff_url":"https://github.com/logstash-plugins/logstash-input-beats/pull/56.diff","patch_url":"https://github.com/logstash-plugins/logstash-input-beats/pull/56.patch","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues/56","number":56,"state":"open","locked":false,"title":"TLS Client verification","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"body":"This PR introduce client verification when using `ssl`, when using this\r\noption you need to specify the **Certificate Authority** using the\r\n`ssl_certificate_authorities` option, this configuration take a\r\ncertificate to validate the client with it. You also need to specify a\r\n`ssl_verify_mode`, If you want strict ssl verification use `force_peer`,\r\nwith this value if the client doesn't provide a valid certificate the\r\nplugins will refuse the client.\r\n\r\nOn Filebeat you need to configure the client to declare a certificate using\r\ntheses options.\r\n\r\n```\r\ntls:\r\n  certificate_authorities: [\"/etc/server.crt\"]\r\n  certificate: /etc/server.crt\r\n  certificate_key: /etc/server.key\r\n```\r\n\r\nThis change also introduce testing with travis-ci and an integration\r\nsuite with filebeat and LSF for the SSL options.\r\n\r\nFix: #8","created_at":"2016-03-09T15:31:01Z","updated_at":"2016-03-14T17:28:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60f394b78443e8f0f5208e0ea3127c1ed164b147","assignee":{"login":"jordansissel","id":131818,"avatar_url":"https://avatars.githubusercontent.com/u/131818?v=3","gravatar_id":"","url":"https://api.github.com/users/jordansissel","html_url":"https://github.com/jordansissel","followers_url":"https://api.github.com/users/jordansissel/followers","following_url":"https://api.github.com/users/jordansissel/following{/other_user}","gists_url":"https://api.github.com/users/jordansissel/gists{/gist_id}","starred_url":"https://api.github.com/users/jordansissel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordansissel/subscriptions","organizations_url":"https://api.github.com/users/jordansissel/orgs","repos_url":"https://api.github.com/users/jordansissel/repos","events_url":"https://api.github.com/users/jordansissel/events{/privacy}","received_events_url":"https://api.github.com/users/jordansissel/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56/commits","review_comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56/comments","review_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues/56/comments","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/statuses/d238cd1bdedd8fd104a106c5c13e9ca3937c1428","head":{"label":"ph:fix/certificate-authorities","ref":"fix/certificate-authorities","sha":"d238cd1bdedd8fd104a106c5c13e9ca3937c1428","user":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"repo":{"id":44262675,"name":"logstash-input-beats","full_name":"ph/logstash-input-beats","owner":{"login":"ph","id":640,"avatar_url":"https://avatars.githubusercontent.com/u/640?v=3","gravatar_id":"","url":"https://api.github.com/users/ph","html_url":"https://github.com/ph","followers_url":"https://api.github.com/users/ph/followers","following_url":"https://api.github.com/users/ph/following{/other_user}","gists_url":"https://api.github.com/users/ph/gists{/gist_id}","starred_url":"https://api.github.com/users/ph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ph/subscriptions","organizations_url":"https://api.github.com/users/ph/orgs","repos_url":"https://api.github.com/users/ph/repos","events_url":"https://api.github.com/users/ph/events{/privacy}","received_events_url":"https://api.github.com/users/ph/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ph/logstash-input-beats","description":"","fork":true,"url":"https://api.github.com/repos/ph/logstash-input-beats","forks_url":"https://api.github.com/repos/ph/logstash-input-beats/forks","keys_url":"https://api.github.com/repos/ph/logstash-input-beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ph/logstash-input-beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ph/logstash-input-beats/teams","hooks_url":"https://api.github.com/repos/ph/logstash-input-beats/hooks","issue_events_url":"https://api.github.com/repos/ph/logstash-input-beats/issues/events{/number}","events_url":"https://api.github.com/repos/ph/logstash-input-beats/events","assignees_url":"https://api.github.com/repos/ph/logstash-input-beats/assignees{/user}","branches_url":"https://api.github.com/repos/ph/logstash-input-beats/branches{/branch}","tags_url":"https://api.github.com/repos/ph/logstash-input-beats/tags","blobs_url":"https://api.github.com/repos/ph/logstash-input-beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ph/logstash-input-beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ph/logstash-input-beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/ph/logstash-input-beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ph/logstash-input-beats/statuses/{sha}","languages_url":"https://api.github.com/repos/ph/logstash-input-beats/languages","stargazers_url":"https://api.github.com/repos/ph/logstash-input-beats/stargazers","contributors_url":"https://api.github.com/repos/ph/logstash-input-beats/contributors","subscribers_url":"https://api.github.com/repos/ph/logstash-input-beats/subscribers","subscription_url":"https://api.github.com/repos/ph/logstash-input-beats/subscription","commits_url":"https://api.github.com/repos/ph/logstash-input-beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/ph/logstash-input-beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/ph/logstash-input-beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/ph/logstash-input-beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/ph/logstash-input-beats/contents/{+path}","compare_url":"https://api.github.com/repos/ph/logstash-input-beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ph/logstash-input-beats/merges","archive_url":"https://api.github.com/repos/ph/logstash-input-beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ph/logstash-input-beats/downloads","issues_url":"https://api.github.com/repos/ph/logstash-input-beats/issues{/number}","pulls_url":"https://api.github.com/repos/ph/logstash-input-beats/pulls{/number}","milestones_url":"https://api.github.com/repos/ph/logstash-input-beats/milestones{/number}","notifications_url":"https://api.github.com/repos/ph/logstash-input-beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ph/logstash-input-beats/labels{/name}","releases_url":"https://api.github.com/repos/ph/logstash-input-beats/releases{/id}","deployments_url":"https://api.github.com/repos/ph/logstash-input-beats/deployments","created_at":"2015-10-14T16:55:07Z","updated_at":"2016-03-04T03:26:39Z","pushed_at":"2016-03-10T21:55:57Z","git_url":"git://github.com/ph/logstash-input-beats.git","ssh_url":"git@github.com:ph/logstash-input-beats.git","clone_url":"https://github.com/ph/logstash-input-beats.git","svn_url":"https://github.com/ph/logstash-input-beats","homepage":null,"size":298,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logstash-plugins:master","ref":"master","sha":"706ce324619ec10dadedb1f04611c325e4186c6c","user":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"repo":{"id":44262636,"name":"logstash-input-beats","full_name":"logstash-plugins/logstash-input-beats","owner":{"login":"logstash-plugins","id":8961934,"avatar_url":"https://avatars.githubusercontent.com/u/8961934?v=3","gravatar_id":"","url":"https://api.github.com/users/logstash-plugins","html_url":"https://github.com/logstash-plugins","followers_url":"https://api.github.com/users/logstash-plugins/followers","following_url":"https://api.github.com/users/logstash-plugins/following{/other_user}","gists_url":"https://api.github.com/users/logstash-plugins/gists{/gist_id}","starred_url":"https://api.github.com/users/logstash-plugins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logstash-plugins/subscriptions","organizations_url":"https://api.github.com/users/logstash-plugins/orgs","repos_url":"https://api.github.com/users/logstash-plugins/repos","events_url":"https://api.github.com/users/logstash-plugins/events{/privacy}","received_events_url":"https://api.github.com/users/logstash-plugins/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logstash-plugins/logstash-input-beats","description":"","fork":false,"url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats","forks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/forks","keys_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/teams","hooks_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/hooks","issue_events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues/events{/number}","events_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/events","assignees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/assignees{/user}","branches_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/branches{/branch}","tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/tags","blobs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/git/refs{/sha}","trees_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/statuses/{sha}","languages_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/languages","stargazers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/stargazers","contributors_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/contributors","subscribers_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/subscribers","subscription_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/subscription","commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/commits{/sha}","git_commits_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/git/commits{/sha}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/comments{/number}","issue_comment_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues/comments{/number}","contents_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/contents/{+path}","compare_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/merges","archive_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/downloads","issues_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues{/number}","pulls_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls{/number}","milestones_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/milestones{/number}","notifications_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/labels{/name}","releases_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/releases{/id}","deployments_url":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/deployments","created_at":"2015-10-14T16:54:06Z","updated_at":"2016-03-01T18:25:59Z","pushed_at":"2016-03-10T21:55:57Z","git_url":"git://github.com/logstash-plugins/logstash-input-beats.git","ssh_url":"git@github.com:logstash-plugins/logstash-input-beats.git","clone_url":"https://github.com/logstash-plugins/logstash-input-beats.git","svn_url":"https://github.com/logstash-plugins/logstash-input-beats","homepage":null,"size":257,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":14,"forks":8,"open_issues":14,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56"},"html":{"href":"https://github.com/logstash-plugins/logstash-input-beats/pull/56"},"issue":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues/56"},"comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/logstash-plugins/logstash-input-beats/statuses/d238cd1bdedd8fd104a106c5c13e9ca3937c1428"}}}}