{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15647","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15647/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15647/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15647/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15647","id":138203083,"number":15647,"title":"Acetylene torch reloads using pressurised tanks [WIP]","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2016-03-03T15:02:12Z","updated_at":"2016-03-06T06:36:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/15647","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15647","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15647.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15647.patch"},"body":"This PR removes further direct calls to `charges` replacing them with the `ammo_*` accessors. As a result it is now possible for **some** tools to make use of magazines. The acetylene torch is provided as a demonstration and now accepts pressurised gas cylinders (which are presently disposable).\r\n\r\n88ef83e also starts a cleanup of the `visitable` class with `item::use_charges` using the replacement (two parameter) `visit_items_with_parent`.\r\n\r\nPresently the acetylene torch just accepts `oxyacetylene` as ammo but is an otherwise ideal candidate for accepting multiple ammo types (`oxygen + acetylene` or `oxygen + propane`). Also gas cylinders could be extended to accept multiple alternative ammo types. Suggestions as to possible implementations are welcomed but this would certainly be a separate PR.\r\n\r\nThe small welding tank (`volume 4`) is intended for raiding and the standard size tank (`volume 12`) for fabrication. The acetylene torch drops are updated to ensure it drops with a standard cylinder."},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/192814662","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/15647#issuecomment-192814662","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/15647","id":192814662,"user":{"login":"Soadreqm","id":6437763,"avatar_url":"https://avatars.githubusercontent.com/u/6437763?v=3","gravatar_id":"","url":"https://api.github.com/users/Soadreqm","html_url":"https://github.com/Soadreqm","followers_url":"https://api.github.com/users/Soadreqm/followers","following_url":"https://api.github.com/users/Soadreqm/following{/other_user}","gists_url":"https://api.github.com/users/Soadreqm/gists{/gist_id}","starred_url":"https://api.github.com/users/Soadreqm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soadreqm/subscriptions","organizations_url":"https://api.github.com/users/Soadreqm/orgs","repos_url":"https://api.github.com/users/Soadreqm/repos","events_url":"https://api.github.com/users/Soadreqm/events{/privacy}","received_events_url":"https://api.github.com/users/Soadreqm/received_events","type":"User","site_admin":false},"created_at":"2016-03-06T06:36:53Z","updated_at":"2016-03-06T06:36:53Z","body":"Realistically, you wouldn't ever have a pressurized container of oxygen-acetylene mix, because of what a huge explosion hazard it is. And also because you control the temperature of the flame by adjusting the oxygen-acetylene ratio.\r\nAs a placeholder for actually using multiple types of ammo, I'd suggest changing the magazine description. Make it a pair of tanks instead."}}