{"action":"created","comment":{"url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/comments/77980856","id":77980856,"diff_hunk":"@@ -0,0 +1,62 @@\n+# Copyright (c) 2016 Shotgun Software Inc.\n+#\n+# CONFIDENTIAL AND PROPRIETARY\n+#\n+# This work is provided \"AS IS\" and subject to the Shotgun Pipeline Toolkit\n+# Source Code License included in this distribution package. See LICENSE.\n+# By accessing, using, copying or modifying this work you indicate your\n+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights\n+# not expressly granted therein are reserved by Shotgun Software Inc.\n+\n+\n+# This file contains the plug-in configuration data that will be packaged\n+# into manifest.py by the build_plugin.py script.\n+\n+\n+#\n+# Plug-in information recommended values to specify by convention.\n+#\n+\n+# Plug-in name that will prefix the plug-in messaqges displayed in Maya script editor.\n+name: \"tk-maya-basic\"\n+\n+# Plug-in version number that will be displayed in Maya Plug-in Information window.\n+# This plug-in version number and the one in the Maya module file should be synchronised.\n+version: \"0.0.5\"\n+\n+description:  \"Shotgun toolkit integration into a basic plug-in.\"","path":"plugins/basic/info.yml","position":27,"original_position":27,"commit_id":"1a85011c951c7bb283ebfd329dd2fb988c312ed0","original_commit_id":"34bf1c4c907cf084063372bb789aea24d22eb1d9","user":{"login":"manneohrstrom","id":337710,"avatar_url":"https://avatars.githubusercontent.com/u/337710?v=3","gravatar_id":"","url":"https://api.github.com/users/manneohrstrom","html_url":"https://github.com/manneohrstrom","followers_url":"https://api.github.com/users/manneohrstrom/followers","following_url":"https://api.github.com/users/manneohrstrom/following{/other_user}","gists_url":"https://api.github.com/users/manneohrstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/manneohrstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manneohrstrom/subscriptions","organizations_url":"https://api.github.com/users/manneohrstrom/orgs","repos_url":"https://api.github.com/users/manneohrstrom/repos","events_url":"https://api.github.com/users/manneohrstrom/events{/privacy}","received_events_url":"https://api.github.com/users/manneohrstrom/received_events","type":"User","site_admin":false},"body":"Hmm, if description isn't used by the maya plugin in any way we should drop it. These are optional and implementation specific parameters. Does that make sense?","created_at":"2016-09-08T10:24:10Z","updated_at":"2016-09-08T10:24:10Z","html_url":"https://github.com/shotgunsoftware/tk-maya/pull/19#discussion_r77980856","pull_request_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/comments/77980856"},"html":{"href":"https://github.com/shotgunsoftware/tk-maya/pull/19#discussion_r77980856"},"pull_request":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19","id":82898336,"html_url":"https://github.com/shotgunsoftware/tk-maya/pull/19","diff_url":"https://github.com/shotgunsoftware/tk-maya/pull/19.diff","patch_url":"https://github.com/shotgunsoftware/tk-maya/pull/19.patch","issue_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/19","number":19,"state":"open","locked":false,"title":"#34893: Run toolkit manager bootstrap logic in a background thread.","user":{"login":"fpainchaud","id":20173280,"avatar_url":"https://avatars.githubusercontent.com/u/20173280?v=3","gravatar_id":"","url":"https://api.github.com/users/fpainchaud","html_url":"https://github.com/fpainchaud","followers_url":"https://api.github.com/users/fpainchaud/followers","following_url":"https://api.github.com/users/fpainchaud/following{/other_user}","gists_url":"https://api.github.com/users/fpainchaud/gists{/gist_id}","starred_url":"https://api.github.com/users/fpainchaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpainchaud/subscriptions","organizations_url":"https://api.github.com/users/fpainchaud/orgs","repos_url":"https://api.github.com/users/fpainchaud/repos","events_url":"https://api.github.com/users/fpainchaud/events{/privacy}","received_events_url":"https://api.github.com/users/fpainchaud/received_events","type":"User","site_admin":false},"body":"When logging the TaaP plug-in in Shotgun, bootstrap the toolkit asynchronously in a background thread, followed by launching the engine synchronously in the main application thread.\r\n\r\nThis allows Maya to continue its execution and remain responsive when bootstrapping the toolkit involves downloading files and installing apps from the toolkit app store.\r\n\r\n**Manne - DO NOT MERGE!** \r\nKeeping this PR so we can address the comments. The PR that should be merged is in #20.","created_at":"2016-08-26T14:33:22Z","updated_at":"2016-09-08T10:24:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb85242d115b044f43037214c5d4777d142cdad9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19/commits","review_comments_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19/comments","review_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/19/comments","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/statuses/1a85011c951c7bb283ebfd329dd2fb988c312ed0","head":{"label":"shotgunsoftware:34893_bootstrap_background_thread","ref":"34893_bootstrap_background_thread","sha":"1a85011c951c7bb283ebfd329dd2fb988c312ed0","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":4399199,"name":"tk-maya","full_name":"shotgunsoftware/tk-maya","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-maya","description":"A Shotgun Pipeline Toolkit Engine for Maya","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-maya","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/deployments","created_at":"2012-05-21T21:52:36Z","updated_at":"2016-08-30T14:48:21Z","pushed_at":"2016-09-06T08:29:32Z","git_url":"git://github.com/shotgunsoftware/tk-maya.git","ssh_url":"git@github.com:shotgunsoftware/tk-maya.git","clone_url":"https://github.com/shotgunsoftware/tk-maya.git","svn_url":"https://github.com/shotgunsoftware/tk-maya","homepage":"","size":26641,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":13,"default_branch":"master"}},"base":{"label":"shotgunsoftware:master","ref":"master","sha":"3dce4f0d53bda7774b8f2f6c39fd466e7fb92c7c","user":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":4399199,"name":"tk-maya","full_name":"shotgunsoftware/tk-maya","owner":{"login":"shotgunsoftware","id":317894,"avatar_url":"https://avatars.githubusercontent.com/u/317894?v=3","gravatar_id":"","url":"https://api.github.com/users/shotgunsoftware","html_url":"https://github.com/shotgunsoftware","followers_url":"https://api.github.com/users/shotgunsoftware/followers","following_url":"https://api.github.com/users/shotgunsoftware/following{/other_user}","gists_url":"https://api.github.com/users/shotgunsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/shotgunsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shotgunsoftware/subscriptions","organizations_url":"https://api.github.com/users/shotgunsoftware/orgs","repos_url":"https://api.github.com/users/shotgunsoftware/repos","events_url":"https://api.github.com/users/shotgunsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/shotgunsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shotgunsoftware/tk-maya","description":"A Shotgun Pipeline Toolkit Engine for Maya","fork":false,"url":"https://api.github.com/repos/shotgunsoftware/tk-maya","forks_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/forks","keys_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/teams","hooks_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/hooks","issue_events_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/events{/number}","events_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/events","assignees_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/assignees{/user}","branches_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/branches{/branch}","tags_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/tags","blobs_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/refs{/sha}","trees_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/statuses/{sha}","languages_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/languages","stargazers_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/stargazers","contributors_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/contributors","subscribers_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/subscribers","subscription_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/subscription","commits_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/commits{/sha}","git_commits_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/git/commits{/sha}","comments_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/comments{/number}","issue_comment_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/comments{/number}","contents_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/contents/{+path}","compare_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/merges","archive_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/downloads","issues_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues{/number}","pulls_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls{/number}","milestones_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/milestones{/number}","notifications_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/labels{/name}","releases_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/releases{/id}","deployments_url":"https://api.github.com/repos/shotgunsoftware/tk-maya/deployments","created_at":"2012-05-21T21:52:36Z","updated_at":"2016-08-30T14:48:21Z","pushed_at":"2016-09-06T08:29:32Z","git_url":"git://github.com/shotgunsoftware/tk-maya.git","ssh_url":"git@github.com:shotgunsoftware/tk-maya.git","clone_url":"https://github.com/shotgunsoftware/tk-maya.git","svn_url":"https://github.com/shotgunsoftware/tk-maya","homepage":"","size":26641,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19"},"html":{"href":"https://github.com/shotgunsoftware/tk-maya/pull/19"},"issue":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/19"},"comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/shotgunsoftware/tk-maya/statuses/1a85011c951c7bb283ebfd329dd2fb988c312ed0"}}}}
{"actor":{"display_login":"manneohrstrom"}}