{"action":"created","comment":{"url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/comments/65968140","id":65968140,"diff_hunk":"@@ -575,6 +580,36 @@ protected void updateConnectorsAsSIPNode() {\n \t\t                sipStackProperties.setProperty(LOCAL_SSL_PORT, String.valueOf(sslPort));\n \t\t\t\t\t}\n \t\t\t\t}\n+\t\t\t\t//smpp\n+\t\t\t\tif(smppPortString == null && smppSslPortString == null) {\n+\t\t\t\t\tlogger.logWarning(\"SMPP or secure SMPP port couldn't be retrieved from System properties, trying with JMX\");\n+\t\t\t\t\tInteger smppPort = null;\n+\t\t\t\t\tBoolean smppBound = false;\n+\t\t\t\t\tInteger smppSslPort = null;\n+\t\t\t\t\tBoolean smppSslBound = false;\n+\n+\t\t\t\t\tMBeanServer mBeanServer = ManagementFactory.getPlatformMBeanServer();\n+\t\t\t\t\ttry {\n+\t\t                String socketBindingGroup = sipStackProperties.getProperty(SOCKET_BINDING_GROUP, \"standard-sockets\");\n+\t\t\t\t\t\tObjectName smpp = new ObjectName(\"jboss.as:socket-binding-group=\" + socketBindingGroup + \",socket-binding=smpp\");\n+\t\t\t\t\t\tsmppPort = (Integer) mBeanServer.getAttribute(smpp, \"boundPort\");\n+\t\t\t\t\t\tsmppBound = (Boolean) mBeanServer.getAttribute(smpp, \"bound\");\n+\n+\t\t\t\t\t\tObjectName smppSsl = new ObjectName(\"jboss.as:socket-binding-group=\" + socketBindingGroup + \",socket-binding=smppSsl\");\n+\t\t\t\t\t\tsmppSslPort = (Integer) mBeanServer.getAttribute(smppSsl, \"boundPort\");\n+\t\t\t\t\t\tsmppSslBound = (Boolean) mBeanServer.getAttribute(smppSsl, \"bound\");\n+\t\t\t\t\t\tif(logger.isLoggingEnabled(StackLogger.TRACE_TRACE)) {\n+\t\t\t\t\t\t\tlogger.logTrace(\"Dound smppPort \" + smppPort + \" and smppSslPort \" + smppSslPort);\n+\t\t\t\t\t\t}\n+\t\t\t\t\t} catch (Exception e) {} //Ignore any exceptions\n+\n+\t\t\t\t\tif(smppBound && smppPort!=null){\n+\t\t\t\t\t\tsipStackProperties.setProperty(LOCAL_SMPP_PORT, String.valueOf(smppPort));\n+\t\t\t\t\t} \n+\t\t\t\t\tif (smppSslBound && smppSslPort!=null){\n+\t\t                sipStackProperties.setProperty(LOCAL_SMPP_SSL_PORT, String.valueOf(smppSslPort));\n+\t\t\t\t\t}\n+\t\t\t\t}\n \t\t\t\t","path":"core/src/main/java/org/mobicents/ha/javax/sip/LoadBalancerHeartBeatingServiceImpl.java","position":54,"original_position":54,"commit_id":"c7929ebf3ddc3aa972bc7f040473af3b1f6f118a","original_commit_id":"c7929ebf3ddc3aa972bc7f040473af3b1f6f118a","user":{"login":"deruelle","id":54279,"avatar_url":"https://avatars.githubusercontent.com/u/54279?v=3","gravatar_id":"","url":"https://api.github.com/users/deruelle","html_url":"https://github.com/deruelle","followers_url":"https://api.github.com/users/deruelle/followers","following_url":"https://api.github.com/users/deruelle/following{/other_user}","gists_url":"https://api.github.com/users/deruelle/gists{/gist_id}","starred_url":"https://api.github.com/users/deruelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deruelle/subscriptions","organizations_url":"https://api.github.com/users/deruelle/orgs","repos_url":"https://api.github.com/users/deruelle/repos","events_url":"https://api.github.com/users/deruelle/events{/privacy}","received_events_url":"https://api.github.com/users/deruelle/received_events","type":"User","site_admin":false},"body":"We don't create any SMPP socket binding group for SMPP in standalone-sip.xml right ? If no, then this part of the code should not be present.","created_at":"2016-06-06T21:01:00Z","updated_at":"2016-06-06T21:01:00Z","html_url":"https://github.com/RestComm/jain-sip.ha/pull/11#discussion_r65968140","pull_request_url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/comments/65968140"},"html":{"href":"https://github.com/RestComm/jain-sip.ha/pull/11#discussion_r65968140"},"pull_request":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11","id":72713856,"html_url":"https://github.com/RestComm/jain-sip.ha/pull/11","diff_url":"https://github.com/RestComm/jain-sip.ha/pull/11.diff","patch_url":"https://github.com/RestComm/jain-sip.ha/pull/11.patch","issue_url":"https://api.github.com/repos/RestComm/jain-sip.ha/issues/11","number":11,"state":"open","locked":false,"title":"add SMPP and secure SMPP port to ping","user":{"login":"knosach","id":16386858,"avatar_url":"https://avatars.githubusercontent.com/u/16386858?v=3","gravatar_id":"","url":"https://api.github.com/users/knosach","html_url":"https://github.com/knosach","followers_url":"https://api.github.com/users/knosach/followers","following_url":"https://api.github.com/users/knosach/following{/other_user}","gists_url":"https://api.github.com/users/knosach/gists{/gist_id}","starred_url":"https://api.github.com/users/knosach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knosach/subscriptions","organizations_url":"https://api.github.com/users/knosach/orgs","repos_url":"https://api.github.com/users/knosach/repos","events_url":"https://api.github.com/users/knosach/events{/privacy}","received_events_url":"https://api.github.com/users/knosach/received_events","type":"User","site_admin":false},"body":"add SMPP ports to ping for issue RestComm/load-balancer#29","created_at":"2016-06-06T14:00:15Z","updated_at":"2016-06-06T21:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b12d3932a3fa8a50b45158ec0036e803515d8d8f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11/commits","review_comments_url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11/comments","review_comment_url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RestComm/jain-sip.ha/issues/11/comments","statuses_url":"https://api.github.com/repos/RestComm/jain-sip.ha/statuses/c7929ebf3ddc3aa972bc7f040473af3b1f6f118a","head":{"label":"knosach:master","ref":"master","sha":"c7929ebf3ddc3aa972bc7f040473af3b1f6f118a","user":{"login":"knosach","id":16386858,"avatar_url":"https://avatars.githubusercontent.com/u/16386858?v=3","gravatar_id":"","url":"https://api.github.com/users/knosach","html_url":"https://github.com/knosach","followers_url":"https://api.github.com/users/knosach/followers","following_url":"https://api.github.com/users/knosach/following{/other_user}","gists_url":"https://api.github.com/users/knosach/gists{/gist_id}","starred_url":"https://api.github.com/users/knosach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knosach/subscriptions","organizations_url":"https://api.github.com/users/knosach/orgs","repos_url":"https://api.github.com/users/knosach/repos","events_url":"https://api.github.com/users/knosach/events{/privacy}","received_events_url":"https://api.github.com/users/knosach/received_events","type":"User","site_admin":false},"repo":{"id":60519986,"name":"jain-sip.ha","full_name":"knosach/jain-sip.ha","owner":{"login":"knosach","id":16386858,"avatar_url":"https://avatars.githubusercontent.com/u/16386858?v=3","gravatar_id":"","url":"https://api.github.com/users/knosach","html_url":"https://github.com/knosach","followers_url":"https://api.github.com/users/knosach/followers","following_url":"https://api.github.com/users/knosach/following{/other_user}","gists_url":"https://api.github.com/users/knosach/gists{/gist_id}","starred_url":"https://api.github.com/users/knosach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knosach/subscriptions","organizations_url":"https://api.github.com/users/knosach/orgs","repos_url":"https://api.github.com/users/knosach/repos","events_url":"https://api.github.com/users/knosach/events{/privacy}","received_events_url":"https://api.github.com/users/knosach/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knosach/jain-sip.ha","description":"JAIN-SIP-HA : Provides extensions done by TeleStax, Inc. to provide high availability and fault tolerance through replication of various states of the stack. It supports Call Established Failover or Early Dialog Failover.","fork":true,"url":"https://api.github.com/repos/knosach/jain-sip.ha","forks_url":"https://api.github.com/repos/knosach/jain-sip.ha/forks","keys_url":"https://api.github.com/repos/knosach/jain-sip.ha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knosach/jain-sip.ha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knosach/jain-sip.ha/teams","hooks_url":"https://api.github.com/repos/knosach/jain-sip.ha/hooks","issue_events_url":"https://api.github.com/repos/knosach/jain-sip.ha/issues/events{/number}","events_url":"https://api.github.com/repos/knosach/jain-sip.ha/events","assignees_url":"https://api.github.com/repos/knosach/jain-sip.ha/assignees{/user}","branches_url":"https://api.github.com/repos/knosach/jain-sip.ha/branches{/branch}","tags_url":"https://api.github.com/repos/knosach/jain-sip.ha/tags","blobs_url":"https://api.github.com/repos/knosach/jain-sip.ha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knosach/jain-sip.ha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knosach/jain-sip.ha/git/refs{/sha}","trees_url":"https://api.github.com/repos/knosach/jain-sip.ha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knosach/jain-sip.ha/statuses/{sha}","languages_url":"https://api.github.com/repos/knosach/jain-sip.ha/languages","stargazers_url":"https://api.github.com/repos/knosach/jain-sip.ha/stargazers","contributors_url":"https://api.github.com/repos/knosach/jain-sip.ha/contributors","subscribers_url":"https://api.github.com/repos/knosach/jain-sip.ha/subscribers","subscription_url":"https://api.github.com/repos/knosach/jain-sip.ha/subscription","commits_url":"https://api.github.com/repos/knosach/jain-sip.ha/commits{/sha}","git_commits_url":"https://api.github.com/repos/knosach/jain-sip.ha/git/commits{/sha}","comments_url":"https://api.github.com/repos/knosach/jain-sip.ha/comments{/number}","issue_comment_url":"https://api.github.com/repos/knosach/jain-sip.ha/issues/comments{/number}","contents_url":"https://api.github.com/repos/knosach/jain-sip.ha/contents/{+path}","compare_url":"https://api.github.com/repos/knosach/jain-sip.ha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knosach/jain-sip.ha/merges","archive_url":"https://api.github.com/repos/knosach/jain-sip.ha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knosach/jain-sip.ha/downloads","issues_url":"https://api.github.com/repos/knosach/jain-sip.ha/issues{/number}","pulls_url":"https://api.github.com/repos/knosach/jain-sip.ha/pulls{/number}","milestones_url":"https://api.github.com/repos/knosach/jain-sip.ha/milestones{/number}","notifications_url":"https://api.github.com/repos/knosach/jain-sip.ha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knosach/jain-sip.ha/labels{/name}","releases_url":"https://api.github.com/repos/knosach/jain-sip.ha/releases{/id}","deployments_url":"https://api.github.com/repos/knosach/jain-sip.ha/deployments","created_at":"2016-06-06T10:34:53Z","updated_at":"2016-06-06T10:34:54Z","pushed_at":"2016-06-06T13:53:00Z","git_url":"git://github.com/knosach/jain-sip.ha.git","ssh_url":"git@github.com:knosach/jain-sip.ha.git","clone_url":"https://github.com/knosach/jain-sip.ha.git","svn_url":"https://github.com/knosach/jain-sip.ha","homepage":"","size":959,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RestComm:master","ref":"master","sha":"6cce7af1c99ece9d6c7b6a9ed5ea5a1637cd6adc","user":{"login":"RestComm","id":667380,"avatar_url":"https://avatars.githubusercontent.com/u/667380?v=3","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"repo":{"id":5455342,"name":"jain-sip.ha","full_name":"RestComm/jain-sip.ha","owner":{"login":"RestComm","id":667380,"avatar_url":"https://avatars.githubusercontent.com/u/667380?v=3","gravatar_id":"","url":"https://api.github.com/users/RestComm","html_url":"https://github.com/RestComm","followers_url":"https://api.github.com/users/RestComm/followers","following_url":"https://api.github.com/users/RestComm/following{/other_user}","gists_url":"https://api.github.com/users/RestComm/gists{/gist_id}","starred_url":"https://api.github.com/users/RestComm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RestComm/subscriptions","organizations_url":"https://api.github.com/users/RestComm/orgs","repos_url":"https://api.github.com/users/RestComm/repos","events_url":"https://api.github.com/users/RestComm/events{/privacy}","received_events_url":"https://api.github.com/users/RestComm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RestComm/jain-sip.ha","description":"JAIN-SIP-HA : Provides extensions done by TeleStax, Inc. to provide high availability and fault tolerance through replication of various states of the stack. It supports Call Established Failover or Early Dialog Failover.","fork":false,"url":"https://api.github.com/repos/RestComm/jain-sip.ha","forks_url":"https://api.github.com/repos/RestComm/jain-sip.ha/forks","keys_url":"https://api.github.com/repos/RestComm/jain-sip.ha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RestComm/jain-sip.ha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RestComm/jain-sip.ha/teams","hooks_url":"https://api.github.com/repos/RestComm/jain-sip.ha/hooks","issue_events_url":"https://api.github.com/repos/RestComm/jain-sip.ha/issues/events{/number}","events_url":"https://api.github.com/repos/RestComm/jain-sip.ha/events","assignees_url":"https://api.github.com/repos/RestComm/jain-sip.ha/assignees{/user}","branches_url":"https://api.github.com/repos/RestComm/jain-sip.ha/branches{/branch}","tags_url":"https://api.github.com/repos/RestComm/jain-sip.ha/tags","blobs_url":"https://api.github.com/repos/RestComm/jain-sip.ha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RestComm/jain-sip.ha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RestComm/jain-sip.ha/git/refs{/sha}","trees_url":"https://api.github.com/repos/RestComm/jain-sip.ha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RestComm/jain-sip.ha/statuses/{sha}","languages_url":"https://api.github.com/repos/RestComm/jain-sip.ha/languages","stargazers_url":"https://api.github.com/repos/RestComm/jain-sip.ha/stargazers","contributors_url":"https://api.github.com/repos/RestComm/jain-sip.ha/contributors","subscribers_url":"https://api.github.com/repos/RestComm/jain-sip.ha/subscribers","subscription_url":"https://api.github.com/repos/RestComm/jain-sip.ha/subscription","commits_url":"https://api.github.com/repos/RestComm/jain-sip.ha/commits{/sha}","git_commits_url":"https://api.github.com/repos/RestComm/jain-sip.ha/git/commits{/sha}","comments_url":"https://api.github.com/repos/RestComm/jain-sip.ha/comments{/number}","issue_comment_url":"https://api.github.com/repos/RestComm/jain-sip.ha/issues/comments{/number}","contents_url":"https://api.github.com/repos/RestComm/jain-sip.ha/contents/{+path}","compare_url":"https://api.github.com/repos/RestComm/jain-sip.ha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RestComm/jain-sip.ha/merges","archive_url":"https://api.github.com/repos/RestComm/jain-sip.ha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RestComm/jain-sip.ha/downloads","issues_url":"https://api.github.com/repos/RestComm/jain-sip.ha/issues{/number}","pulls_url":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls{/number}","milestones_url":"https://api.github.com/repos/RestComm/jain-sip.ha/milestones{/number}","notifications_url":"https://api.github.com/repos/RestComm/jain-sip.ha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RestComm/jain-sip.ha/labels{/name}","releases_url":"https://api.github.com/repos/RestComm/jain-sip.ha/releases{/id}","deployments_url":"https://api.github.com/repos/RestComm/jain-sip.ha/deployments","created_at":"2012-08-17T17:36:50Z","updated_at":"2016-01-28T09:54:04Z","pushed_at":"2016-06-06T14:00:15Z","git_url":"git://github.com/RestComm/jain-sip.ha.git","ssh_url":"git@github.com:RestComm/jain-sip.ha.git","clone_url":"https://github.com/RestComm/jain-sip.ha.git","svn_url":"https://github.com/RestComm/jain-sip.ha","homepage":"","size":1153,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11"},"html":{"href":"https://github.com/RestComm/jain-sip.ha/pull/11"},"issue":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/issues/11"},"comments":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/RestComm/jain-sip.ha/statuses/c7929ebf3ddc3aa972bc7f040473af3b1f6f118a"}}}}
{"actor":{"display_login":"deruelle"}}