{"action":"created","issue":{"url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming/issues/3","repository_url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming","labels_url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming/issues/3/comments","events_url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming/issues/3/events","html_url":"https://github.com/cjroth/aframe-phantomjs-continuous-streaming/issues/3","id":193329671,"number":3,"title":"port mentioned in docs for stream doesn't seem to match shell script","user":{"login":"micahstubbs","id":2119400,"avatar_url":"https://avatars.githubusercontent.com/u/2119400?v=3","gravatar_id":"","url":"https://api.github.com/users/micahstubbs","html_url":"https://github.com/micahstubbs","followers_url":"https://api.github.com/users/micahstubbs/followers","following_url":"https://api.github.com/users/micahstubbs/following{/other_user}","gists_url":"https://api.github.com/users/micahstubbs/gists{/gist_id}","starred_url":"https://api.github.com/users/micahstubbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahstubbs/subscriptions","organizations_url":"https://api.github.com/users/micahstubbs/orgs","repos_url":"https://api.github.com/users/micahstubbs/repos","events_url":"https://api.github.com/users/micahstubbs/events{/privacy}","received_events_url":"https://api.github.com/users/micahstubbs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-12-04T03:45:46Z","updated_at":"2016-12-06T19:25:33Z","closed_at":null,"body":"the docs say port `8888`\r\nhttps://github.com/cjroth/aframe-phantomjs-continuous-streaming/blob/master/README.md#run\r\n\r\nbut the shell script seems to use ports `8082` and `8084`\r\nhttps://github.com/cjroth/aframe-phantomjs-continuous-streaming/blob/master/stream-server.js#L13\r\n\r\nwould be nice to clarify the docs 😄 \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming/issues/comments/265246729","html_url":"https://github.com/cjroth/aframe-phantomjs-continuous-streaming/issues/3#issuecomment-265246729","issue_url":"https://api.github.com/repos/cjroth/aframe-phantomjs-continuous-streaming/issues/3","id":265246729,"user":{"login":"cjroth","id":582130,"avatar_url":"https://avatars.githubusercontent.com/u/582130?v=3","gravatar_id":"","url":"https://api.github.com/users/cjroth","html_url":"https://github.com/cjroth","followers_url":"https://api.github.com/users/cjroth/followers","following_url":"https://api.github.com/users/cjroth/following{/other_user}","gists_url":"https://api.github.com/users/cjroth/gists{/gist_id}","starred_url":"https://api.github.com/users/cjroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjroth/subscriptions","organizations_url":"https://api.github.com/users/cjroth/orgs","repos_url":"https://api.github.com/users/cjroth/repos","events_url":"https://api.github.com/users/cjroth/events{/privacy}","received_events_url":"https://api.github.com/users/cjroth/received_events","type":"User","site_admin":false},"created_at":"2016-12-06T19:25:33Z","updated_at":"2016-12-06T19:25:33Z","body":"Oh yeah, this is kind of confusing.\r\n\r\nSo the PhantomJS script (`runner.js`) actually creates its own server on port `8888` to listen for user events eg click/navigate which the browser will forward to it once I get that part working. (For now I've been curling... `curl http://localhost:8888 -d '{ \"type\": \"click\", \"x\": 25, \"y\": 30 }'`.\r\n\r\nThe shell script with ports `8082` and `8084` is the script borrowed from jsmpeg which Phantom streams its output to (see `scripts/phantom-ffmpeg-stream.sh`) on port `8082`. This then sends the mpeg data to the browser via a Websocket on port `8084`.\r\n\r\nYou shouldn't need to worry about the details of this script or ports 8082/4 much unless you need to change the IP from `127.0.01` to your network IP."}}
{"actor":{"display_login":"cjroth"}}