{"action":"created","issue":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357","repository_url":"https://api.github.com/repos/FormidableLabs/victory-chart","labels_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357/labels{/name}","comments_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357/comments","events_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357/events","html_url":"https://github.com/FormidableLabs/victory-chart/pull/357","id":173208394,"number":357,"title":"Feature/Fix label overlap issue.","user":{"login":"nightwolfdu","id":5007467,"avatar_url":"https://avatars.githubusercontent.com/u/5007467?v=3","gravatar_id":"","url":"https://api.github.com/users/nightwolfdu","html_url":"https://github.com/nightwolfdu","followers_url":"https://api.github.com/users/nightwolfdu/followers","following_url":"https://api.github.com/users/nightwolfdu/following{/other_user}","gists_url":"https://api.github.com/users/nightwolfdu/gists{/gist_id}","starred_url":"https://api.github.com/users/nightwolfdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightwolfdu/subscriptions","organizations_url":"https://api.github.com/users/nightwolfdu/orgs","repos_url":"https://api.github.com/users/nightwolfdu/repos","events_url":"https://api.github.com/users/nightwolfdu/events{/privacy}","received_events_url":"https://api.github.com/users/nightwolfdu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-08-25T13:50:35Z","updated_at":"2016-08-31T16:56:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/pulls/357","html_url":"https://github.com/FormidableLabs/victory-chart/pull/357","diff_url":"https://github.com/FormidableLabs/victory-chart/pull/357.diff","patch_url":"https://github.com/FormidableLabs/victory-chart/pull/357.patch"},"body":"Hello! \r\nIt's partial fix 'label overlapping' , in situation when axis.size < sum(labels.size).\r\nAnd 'text size' helper, that predict VictoryLabel size based on text and font-style.\r\nI take out filtering code from \"renderGridAndTicks\" into individual function \"fixLabelOverlap\", that filter \r\n\"renderGridAndTicks\" result.\r\n\r\nWe discuss about it in Gitter, recently.\r\n\r\n> Lauren @boygirl авг. 11 20:05\r\n@deathmandu we could maybe approximate the size of the text based on length, number of lines, font size, padding etc. and filter it in renderGridAndTicks, but it wouldn't be exact. If we went this route, I would want to add a static method to VictoryLabel like getLabelDimensions, and call it in renderGridAndTicks. Option 2 is not viable for us since we use the same code base for victory-native\r\n@traverspinkerton you should style axis stuff on VictoryAxis like...\r\n"},"comment":{"url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/comments/243829246","html_url":"https://github.com/FormidableLabs/victory-chart/pull/357#issuecomment-243829246","issue_url":"https://api.github.com/repos/FormidableLabs/victory-chart/issues/357","id":243829246,"user":{"login":"boygirl","id":3719995,"avatar_url":"https://avatars.githubusercontent.com/u/3719995?v=3","gravatar_id":"","url":"https://api.github.com/users/boygirl","html_url":"https://github.com/boygirl","followers_url":"https://api.github.com/users/boygirl/followers","following_url":"https://api.github.com/users/boygirl/following{/other_user}","gists_url":"https://api.github.com/users/boygirl/gists{/gist_id}","starred_url":"https://api.github.com/users/boygirl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boygirl/subscriptions","organizations_url":"https://api.github.com/users/boygirl/orgs","repos_url":"https://api.github.com/users/boygirl/repos","events_url":"https://api.github.com/users/boygirl/events{/privacy}","received_events_url":"https://api.github.com/users/boygirl/received_events","type":"User","site_admin":false},"created_at":"2016-08-31T16:56:23Z","updated_at":"2016-08-31T16:56:23Z","body":"@nightwolfdu I just released your TextSize changes in `victory-core@6.0.0` so you can depend on it for this branch. I'm mostly out of the office today, but I can get this branch in tomorrow morning."}}
{"actor":{"display_login":"boygirl"}}