{"action":"created","comment":{"url":"https://api.github.com/repos/x64dbg/x64dbg/pulls/comments/69553356","id":69553356,"diff_hunk":"@@ -1079,6 +1098,8 @@ static void cbCreateProcess(CREATE_PROCESS_DEBUG_INFO* CreateProcessInfo)\n             sprintf_s(command, \"bp \" fhex \",\\\"entry breakpoint\\\",ss\", (duint)CreateProcessInfo->lpStartAddress);\r\n             cmddirectexec(command);\r\n         }\r\n+\r\n+        bTraceRecordEnabledDuringTrace = settingboolget(\"Engine\", \"TraceRecordEnabledDuringTrace\");\r","path":"src/dbg/debugger.cpp","position":82,"original_position":82,"commit_id":"aa8d0b5d534b52f039bcf1e4c98ef6245f9bf1ba","original_commit_id":"aa8d0b5d534b52f039bcf1e4c98ef6245f9bf1ba","user":{"login":"mrexodia","id":2458265,"avatar_url":"https://avatars.githubusercontent.com/u/2458265?v=3","gravatar_id":"","url":"https://api.github.com/users/mrexodia","html_url":"https://github.com/mrexodia","followers_url":"https://api.github.com/users/mrexodia/followers","following_url":"https://api.github.com/users/mrexodia/following{/other_user}","gists_url":"https://api.github.com/users/mrexodia/gists{/gist_id}","starred_url":"https://api.github.com/users/mrexodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrexodia/subscriptions","organizations_url":"https://api.github.com/users/mrexodia/orgs","repos_url":"https://api.github.com/users/mrexodia/repos","events_url":"https://api.github.com/users/mrexodia/events{/privacy}","received_events_url":"https://api.github.com/users/mrexodia/received_events","type":"User","site_admin":false},"body":"Oh that's actually quite a bug in that case...\nOn Tue, 5 Jul 2016 at 04:03, Torusrxxx <notifications@github.com> wrote:\n\n> In src/dbg/debugger.cpp\n> <https://github.com/x64dbg/x64dbg/pull/807#discussion_r69500217>:\n>\n> > @@ -1079,6 +1098,8 @@ static void cbCreateProcess(CREATE_PROCESS_DEBUG_INFO* CreateProcessInfo)\n> >              sprintf_s(command, \"bp \" fhex \",\\\"entry breakpoint\\\",ss\", (duint)CreateProcessInfo->lpStartAddress);\n> >              cmddirectexec(command);\n> >          }\n> > +\n> > +        bTraceRecordEnabledDuringTrace = settingboolget(\"Engine\", \"TraceRecordEnabledDuringTrace\");\n>\n> coz DBG_SETTINGS_UPDATED is not triggered when the application initializes\n> so the bTraceRecordEnabledDuringTrace is not initialized. This line of\n> code initializes it.\n>\n> —\n> You are receiving this because you commented.\n>\n>\n> Reply to this email directly, view it on GitHub\n> <https://github.com/x64dbg/x64dbg/pull/807/files/aa8d0b5d534b52f039bcf1e4c98ef6245f9bf1ba#r69500217>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe/ACWCmaYdqr2fKzWzNYJWA9qOE_DY_utZks5qSbtfgaJpZM4I_uk9>\n> .\n>\n","created_at":"2016-07-05T12:25:24Z","updated_at":"2016-07-05T12:25:24Z","html_url":"https://github.com/x64dbg/x64dbg/pull/807#discussion_r69553356","pull_request_url":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/x64dbg/x64dbg/pulls/comments/69553356"},"html":{"href":"https://github.com/x64dbg/x64dbg/pull/807#discussion_r69553356"},"pull_request":{"href":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807","id":75416322,"html_url":"https://github.com/x64dbg/x64dbg/pull/807","diff_url":"https://github.com/x64dbg/x64dbg/pull/807.diff","patch_url":"https://github.com/x64dbg/x64dbg/pull/807.patch","issue_url":"https://api.github.com/repos/x64dbg/x64dbg/issues/807","number":807,"state":"open","locked":false,"title":"trace record during trace","user":{"login":"torusrxxx","id":15761310,"avatar_url":"https://avatars.githubusercontent.com/u/15761310?v=3","gravatar_id":"","url":"https://api.github.com/users/torusrxxx","html_url":"https://github.com/torusrxxx","followers_url":"https://api.github.com/users/torusrxxx/followers","following_url":"https://api.github.com/users/torusrxxx/following{/other_user}","gists_url":"https://api.github.com/users/torusrxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/torusrxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torusrxxx/subscriptions","organizations_url":"https://api.github.com/users/torusrxxx/orgs","repos_url":"https://api.github.com/users/torusrxxx/repos","events_url":"https://api.github.com/users/torusrxxx/events{/privacy}","received_events_url":"https://api.github.com/users/torusrxxx/received_events","type":"User","site_admin":false},"body":"commit selected feature on my local branch once it is stable\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"35\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/x64dbg/x64dbg/807)\n<!-- Reviewable:end -->\n","created_at":"2016-06-28T04:19:06Z","updated_at":"2016-07-05T12:25:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b54f695c4425ba30dbac2b0d7c28cee45afbc5af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807/commits","review_comments_url":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807/comments","review_comment_url":"https://api.github.com/repos/x64dbg/x64dbg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/x64dbg/x64dbg/issues/807/comments","statuses_url":"https://api.github.com/repos/x64dbg/x64dbg/statuses/aa8d0b5d534b52f039bcf1e4c98ef6245f9bf1ba","head":{"label":"torusrxxx:patch-1","ref":"patch-1","sha":"aa8d0b5d534b52f039bcf1e4c98ef6245f9bf1ba","user":{"login":"torusrxxx","id":15761310,"avatar_url":"https://avatars.githubusercontent.com/u/15761310?v=3","gravatar_id":"","url":"https://api.github.com/users/torusrxxx","html_url":"https://github.com/torusrxxx","followers_url":"https://api.github.com/users/torusrxxx/followers","following_url":"https://api.github.com/users/torusrxxx/following{/other_user}","gists_url":"https://api.github.com/users/torusrxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/torusrxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torusrxxx/subscriptions","organizations_url":"https://api.github.com/users/torusrxxx/orgs","repos_url":"https://api.github.com/users/torusrxxx/repos","events_url":"https://api.github.com/users/torusrxxx/events{/privacy}","received_events_url":"https://api.github.com/users/torusrxxx/received_events","type":"User","site_admin":false},"repo":{"id":59453253,"name":"x64dbg","full_name":"torusrxxx/x64dbg","owner":{"login":"torusrxxx","id":15761310,"avatar_url":"https://avatars.githubusercontent.com/u/15761310?v=3","gravatar_id":"","url":"https://api.github.com/users/torusrxxx","html_url":"https://github.com/torusrxxx","followers_url":"https://api.github.com/users/torusrxxx/followers","following_url":"https://api.github.com/users/torusrxxx/following{/other_user}","gists_url":"https://api.github.com/users/torusrxxx/gists{/gist_id}","starred_url":"https://api.github.com/users/torusrxxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torusrxxx/subscriptions","organizations_url":"https://api.github.com/users/torusrxxx/orgs","repos_url":"https://api.github.com/users/torusrxxx/repos","events_url":"https://api.github.com/users/torusrxxx/events{/privacy}","received_events_url":"https://api.github.com/users/torusrxxx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/torusrxxx/x64dbg","description":"An open-source x64/x32 debugger for windows.","fork":true,"url":"https://api.github.com/repos/torusrxxx/x64dbg","forks_url":"https://api.github.com/repos/torusrxxx/x64dbg/forks","keys_url":"https://api.github.com/repos/torusrxxx/x64dbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torusrxxx/x64dbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torusrxxx/x64dbg/teams","hooks_url":"https://api.github.com/repos/torusrxxx/x64dbg/hooks","issue_events_url":"https://api.github.com/repos/torusrxxx/x64dbg/issues/events{/number}","events_url":"https://api.github.com/repos/torusrxxx/x64dbg/events","assignees_url":"https://api.github.com/repos/torusrxxx/x64dbg/assignees{/user}","branches_url":"https://api.github.com/repos/torusrxxx/x64dbg/branches{/branch}","tags_url":"https://api.github.com/repos/torusrxxx/x64dbg/tags","blobs_url":"https://api.github.com/repos/torusrxxx/x64dbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torusrxxx/x64dbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torusrxxx/x64dbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/torusrxxx/x64dbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torusrxxx/x64dbg/statuses/{sha}","languages_url":"https://api.github.com/repos/torusrxxx/x64dbg/languages","stargazers_url":"https://api.github.com/repos/torusrxxx/x64dbg/stargazers","contributors_url":"https://api.github.com/repos/torusrxxx/x64dbg/contributors","subscribers_url":"https://api.github.com/repos/torusrxxx/x64dbg/subscribers","subscription_url":"https://api.github.com/repos/torusrxxx/x64dbg/subscription","commits_url":"https://api.github.com/repos/torusrxxx/x64dbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/torusrxxx/x64dbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/torusrxxx/x64dbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/torusrxxx/x64dbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/torusrxxx/x64dbg/contents/{+path}","compare_url":"https://api.github.com/repos/torusrxxx/x64dbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torusrxxx/x64dbg/merges","archive_url":"https://api.github.com/repos/torusrxxx/x64dbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torusrxxx/x64dbg/downloads","issues_url":"https://api.github.com/repos/torusrxxx/x64dbg/issues{/number}","pulls_url":"https://api.github.com/repos/torusrxxx/x64dbg/pulls{/number}","milestones_url":"https://api.github.com/repos/torusrxxx/x64dbg/milestones{/number}","notifications_url":"https://api.github.com/repos/torusrxxx/x64dbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torusrxxx/x64dbg/labels{/name}","releases_url":"https://api.github.com/repos/torusrxxx/x64dbg/releases{/id}","deployments_url":"https://api.github.com/repos/torusrxxx/x64dbg/deployments","created_at":"2016-05-23T05:01:43Z","updated_at":"2016-05-23T05:01:46Z","pushed_at":"2016-07-05T02:04:52Z","git_url":"git://github.com/torusrxxx/x64dbg.git","ssh_url":"git@github.com:torusrxxx/x64dbg.git","clone_url":"https://github.com/torusrxxx/x64dbg.git","svn_url":"https://github.com/torusrxxx/x64dbg","homepage":"http://x64dbg.com","size":16560,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"x64dbg:development","ref":"development","sha":"347701f8ddc62842d38c584596d1de3c9613be45","user":{"login":"x64dbg","id":7937360,"avatar_url":"https://avatars.githubusercontent.com/u/7937360?v=3","gravatar_id":"","url":"https://api.github.com/users/x64dbg","html_url":"https://github.com/x64dbg","followers_url":"https://api.github.com/users/x64dbg/followers","following_url":"https://api.github.com/users/x64dbg/following{/other_user}","gists_url":"https://api.github.com/users/x64dbg/gists{/gist_id}","starred_url":"https://api.github.com/users/x64dbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x64dbg/subscriptions","organizations_url":"https://api.github.com/users/x64dbg/orgs","repos_url":"https://api.github.com/users/x64dbg/repos","events_url":"https://api.github.com/users/x64dbg/events{/privacy}","received_events_url":"https://api.github.com/users/x64dbg/received_events","type":"Organization","site_admin":false},"repo":{"id":33791743,"name":"x64dbg","full_name":"x64dbg/x64dbg","owner":{"login":"x64dbg","id":7937360,"avatar_url":"https://avatars.githubusercontent.com/u/7937360?v=3","gravatar_id":"","url":"https://api.github.com/users/x64dbg","html_url":"https://github.com/x64dbg","followers_url":"https://api.github.com/users/x64dbg/followers","following_url":"https://api.github.com/users/x64dbg/following{/other_user}","gists_url":"https://api.github.com/users/x64dbg/gists{/gist_id}","starred_url":"https://api.github.com/users/x64dbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x64dbg/subscriptions","organizations_url":"https://api.github.com/users/x64dbg/orgs","repos_url":"https://api.github.com/users/x64dbg/repos","events_url":"https://api.github.com/users/x64dbg/events{/privacy}","received_events_url":"https://api.github.com/users/x64dbg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/x64dbg/x64dbg","description":"An open-source x64/x32 debugger for windows.","fork":false,"url":"https://api.github.com/repos/x64dbg/x64dbg","forks_url":"https://api.github.com/repos/x64dbg/x64dbg/forks","keys_url":"https://api.github.com/repos/x64dbg/x64dbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/x64dbg/x64dbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/x64dbg/x64dbg/teams","hooks_url":"https://api.github.com/repos/x64dbg/x64dbg/hooks","issue_events_url":"https://api.github.com/repos/x64dbg/x64dbg/issues/events{/number}","events_url":"https://api.github.com/repos/x64dbg/x64dbg/events","assignees_url":"https://api.github.com/repos/x64dbg/x64dbg/assignees{/user}","branches_url":"https://api.github.com/repos/x64dbg/x64dbg/branches{/branch}","tags_url":"https://api.github.com/repos/x64dbg/x64dbg/tags","blobs_url":"https://api.github.com/repos/x64dbg/x64dbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/x64dbg/x64dbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/x64dbg/x64dbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/x64dbg/x64dbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/x64dbg/x64dbg/statuses/{sha}","languages_url":"https://api.github.com/repos/x64dbg/x64dbg/languages","stargazers_url":"https://api.github.com/repos/x64dbg/x64dbg/stargazers","contributors_url":"https://api.github.com/repos/x64dbg/x64dbg/contributors","subscribers_url":"https://api.github.com/repos/x64dbg/x64dbg/subscribers","subscription_url":"https://api.github.com/repos/x64dbg/x64dbg/subscription","commits_url":"https://api.github.com/repos/x64dbg/x64dbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/x64dbg/x64dbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/x64dbg/x64dbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/x64dbg/x64dbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/x64dbg/x64dbg/contents/{+path}","compare_url":"https://api.github.com/repos/x64dbg/x64dbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/x64dbg/x64dbg/merges","archive_url":"https://api.github.com/repos/x64dbg/x64dbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/x64dbg/x64dbg/downloads","issues_url":"https://api.github.com/repos/x64dbg/x64dbg/issues{/number}","pulls_url":"https://api.github.com/repos/x64dbg/x64dbg/pulls{/number}","milestones_url":"https://api.github.com/repos/x64dbg/x64dbg/milestones{/number}","notifications_url":"https://api.github.com/repos/x64dbg/x64dbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/x64dbg/x64dbg/labels{/name}","releases_url":"https://api.github.com/repos/x64dbg/x64dbg/releases{/id}","deployments_url":"https://api.github.com/repos/x64dbg/x64dbg/deployments","created_at":"2015-04-11T20:48:23Z","updated_at":"2016-07-05T10:49:28Z","pushed_at":"2016-07-05T09:26:04Z","git_url":"git://github.com/x64dbg/x64dbg.git","ssh_url":"git@github.com:x64dbg/x64dbg.git","clone_url":"https://github.com/x64dbg/x64dbg.git","svn_url":"https://github.com/x64dbg/x64dbg","homepage":"http://x64dbg.com","size":19045,"stargazers_count":1105,"watchers_count":1105,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":191,"forks":213,"open_issues":191,"watchers":1105,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807"},"html":{"href":"https://github.com/x64dbg/x64dbg/pull/807"},"issue":{"href":"https://api.github.com/repos/x64dbg/x64dbg/issues/807"},"comments":{"href":"https://api.github.com/repos/x64dbg/x64dbg/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/x64dbg/x64dbg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/x64dbg/x64dbg/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/x64dbg/x64dbg/statuses/aa8d0b5d534b52f039bcf1e4c98ef6245f9bf1ba"}}}}
{"actor":{"display_login":"mrexodia"}}