{"action":"created","issue":{"url":"https://api.github.com/repos/figo-connect/schwifty/issues/3","repository_url":"https://api.github.com/repos/figo-connect/schwifty","labels_url":"https://api.github.com/repos/figo-connect/schwifty/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/figo-connect/schwifty/issues/3/comments","events_url":"https://api.github.com/repos/figo-connect/schwifty/issues/3/events","html_url":"https://github.com/figo-connect/schwifty/issues/3","id":187675649,"number":3,"title":"Branch_code merged by error in account_code for some country like France","user":{"login":"splanquart","id":1155990,"avatar_url":"https://avatars.githubusercontent.com/u/1155990?v=3","gravatar_id":"","url":"https://api.github.com/users/splanquart","html_url":"https://github.com/splanquart","followers_url":"https://api.github.com/users/splanquart/followers","following_url":"https://api.github.com/users/splanquart/following{/other_user}","gists_url":"https://api.github.com/users/splanquart/gists{/gist_id}","starred_url":"https://api.github.com/users/splanquart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splanquart/subscriptions","organizations_url":"https://api.github.com/users/splanquart/orgs","repos_url":"https://api.github.com/users/splanquart/repos","events_url":"https://api.github.com/users/splanquart/events{/privacy}","received_events_url":"https://api.github.com/users/splanquart/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-11-07T10:31:26Z","updated_at":"2016-11-08T11:00:50Z","closed_at":null,"body":"Hello,\r\n\r\nThanks for your work on this lib. \r\n\r\nI start to test it and I discover that you don't return a branch_code for IBAN start by 'FR'. I discover that the `spec` for FR IBAN is : \r\nOn wikipedia we can read that the official format is `FRkk bbbb bsss sscc cccc cccc cxx` with `sssss` represent the branch code and `xx` the National check digits (ref: https://en.wikipedia.org/wiki/International_Bank_Account_Number).\r\n\r\nWhy you decide to merge bank code and account number ?\r\nWhat is the best way to fix this problem ?\r\n\r\nA+"},"comment":{"url":"https://api.github.com/repos/figo-connect/schwifty/issues/comments/259107894","html_url":"https://github.com/figo-connect/schwifty/issues/3#issuecomment-259107894","issue_url":"https://api.github.com/repos/figo-connect/schwifty/issues/3","id":259107894,"user":{"login":"splanquart","id":1155990,"avatar_url":"https://avatars.githubusercontent.com/u/1155990?v=3","gravatar_id":"","url":"https://api.github.com/users/splanquart","html_url":"https://github.com/splanquart","followers_url":"https://api.github.com/users/splanquart/followers","following_url":"https://api.github.com/users/splanquart/following{/other_user}","gists_url":"https://api.github.com/users/splanquart/gists{/gist_id}","starred_url":"https://api.github.com/users/splanquart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splanquart/subscriptions","organizations_url":"https://api.github.com/users/splanquart/orgs","repos_url":"https://api.github.com/users/splanquart/repos","events_url":"https://api.github.com/users/splanquart/events{/privacy}","received_events_url":"https://api.github.com/users/splanquart/received_events","type":"User","site_admin":false},"created_at":"2016-11-08T11:00:50Z","updated_at":"2016-11-08T11:00:50Z","body":"This document is correct, we can read `FR2!n5!n5!n11!c2!n` for IBAN structure et `5!n5!n11!c2!n` for BBAN structure.\r\n\r\nI try to use `scripts/get_iban_registry.py` without success for moment.\r\n\r\n```\r\n$ python get_iban_registry.py\r\nTraceback (most recent call last):\r\n  File \"get_iban_registry.py\", line 49, in <module>\r\n    codes = re.findall(r'[A-Z]{2}', row['country code as defined in iso 3166'])\r\nKeyError: 'country code as defined in iso 3166'\r\n```\r\n\r\nI suppose the document structure was evolved between the last time that you used it and now but I don't know how to change the parser to read the new document. "}}
{"actor":{"display_login":"splanquart"}}