{"action":"closed","number":370,"pull_request":{"url":"https://api.github.com/repos/lmfit/lmfit-py/pulls/370","id":82091601,"html_url":"https://github.com/lmfit/lmfit-py/pull/370","diff_url":"https://github.com/lmfit/lmfit-py/pull/370.diff","patch_url":"https://github.com/lmfit/lmfit-py/pull/370.patch","issue_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/370","number":370,"state":"closed","locked":false,"title":"Plots: make a better default plot with ModelResult.plot()","user":{"login":"tritemio","id":4156237,"avatar_url":"https://avatars.githubusercontent.com/u/4156237?v=3","gravatar_id":"","url":"https://api.github.com/users/tritemio","html_url":"https://github.com/tritemio","followers_url":"https://api.github.com/users/tritemio/followers","following_url":"https://api.github.com/users/tritemio/following{/other_user}","gists_url":"https://api.github.com/users/tritemio/gists{/gist_id}","starred_url":"https://api.github.com/users/tritemio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tritemio/subscriptions","organizations_url":"https://api.github.com/users/tritemio/orgs","repos_url":"https://api.github.com/users/tritemio/repos","events_url":"https://api.github.com/users/tritemio/events{/privacy}","received_events_url":"https://api.github.com/users/tritemio/received_events","type":"User","site_admin":false},"body":"As the subject says, small tweaks to create better default plots with `ModelResult.plot()`.\r\n\r\nChanges:\r\n\r\n- use `loc='best'` for legend positioning in `plot_fit` and `plot_residuals`\r\n- remove title for bottom axis which is the same of the top axis and can overlap with other labels\r\n- remove x-labels for top axis (we are sharing the x axis so they are redundant)\r\n- return both figure and GridSpec. This is a convenience for easy tweaking the plot. As a side benefit, with this change calling `ModelResult.plot()` without capturing the return object will not display two duplicated figures anymore.\r\n- Use a square figure by default using the default x-size of the figure also as y-size. Since we stack two plots vertically a square figure results in more legible plots in most cases. By using the default x-size we don't set an arbitrary size and respect user preferences.\r\n- Fix typo in docstring.","created_at":"2016-08-20T22:43:48Z","updated_at":"2016-08-23T12:10:00Z","closed_at":"2016-08-23T12:10:00Z","merged_at":"2016-08-23T12:10:00Z","merge_commit_sha":"5c5d085355598cc1b1eafe8718ac650795cd980f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lmfit/lmfit-py/pulls/370/commits","review_comments_url":"https://api.github.com/repos/lmfit/lmfit-py/pulls/370/comments","review_comment_url":"https://api.github.com/repos/lmfit/lmfit-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/370/comments","statuses_url":"https://api.github.com/repos/lmfit/lmfit-py/statuses/9002013a853efa50d11fdbcfafa4b17216bcc3ff","head":{"label":"tritemio:master","ref":"master","sha":"9002013a853efa50d11fdbcfafa4b17216bcc3ff","user":{"login":"tritemio","id":4156237,"avatar_url":"https://avatars.githubusercontent.com/u/4156237?v=3","gravatar_id":"","url":"https://api.github.com/users/tritemio","html_url":"https://github.com/tritemio","followers_url":"https://api.github.com/users/tritemio/followers","following_url":"https://api.github.com/users/tritemio/following{/other_user}","gists_url":"https://api.github.com/users/tritemio/gists{/gist_id}","starred_url":"https://api.github.com/users/tritemio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tritemio/subscriptions","organizations_url":"https://api.github.com/users/tritemio/orgs","repos_url":"https://api.github.com/users/tritemio/repos","events_url":"https://api.github.com/users/tritemio/events{/privacy}","received_events_url":"https://api.github.com/users/tritemio/received_events","type":"User","site_admin":false},"repo":{"id":23434794,"name":"lmfit-py","full_name":"tritemio/lmfit-py","owner":{"login":"tritemio","id":4156237,"avatar_url":"https://avatars.githubusercontent.com/u/4156237?v=3","gravatar_id":"","url":"https://api.github.com/users/tritemio","html_url":"https://github.com/tritemio","followers_url":"https://api.github.com/users/tritemio/followers","following_url":"https://api.github.com/users/tritemio/following{/other_user}","gists_url":"https://api.github.com/users/tritemio/gists{/gist_id}","starred_url":"https://api.github.com/users/tritemio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tritemio/subscriptions","organizations_url":"https://api.github.com/users/tritemio/orgs","repos_url":"https://api.github.com/users/tritemio/repos","events_url":"https://api.github.com/users/tritemio/events{/privacy}","received_events_url":"https://api.github.com/users/tritemio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tritemio/lmfit-py","description":"Simple Least Squares Minimization, with flexible Parameter settings, based on scipy.optimize.leastsq ","fork":true,"url":"https://api.github.com/repos/tritemio/lmfit-py","forks_url":"https://api.github.com/repos/tritemio/lmfit-py/forks","keys_url":"https://api.github.com/repos/tritemio/lmfit-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tritemio/lmfit-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tritemio/lmfit-py/teams","hooks_url":"https://api.github.com/repos/tritemio/lmfit-py/hooks","issue_events_url":"https://api.github.com/repos/tritemio/lmfit-py/issues/events{/number}","events_url":"https://api.github.com/repos/tritemio/lmfit-py/events","assignees_url":"https://api.github.com/repos/tritemio/lmfit-py/assignees{/user}","branches_url":"https://api.github.com/repos/tritemio/lmfit-py/branches{/branch}","tags_url":"https://api.github.com/repos/tritemio/lmfit-py/tags","blobs_url":"https://api.github.com/repos/tritemio/lmfit-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tritemio/lmfit-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tritemio/lmfit-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/tritemio/lmfit-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tritemio/lmfit-py/statuses/{sha}","languages_url":"https://api.github.com/repos/tritemio/lmfit-py/languages","stargazers_url":"https://api.github.com/repos/tritemio/lmfit-py/stargazers","contributors_url":"https://api.github.com/repos/tritemio/lmfit-py/contributors","subscribers_url":"https://api.github.com/repos/tritemio/lmfit-py/subscribers","subscription_url":"https://api.github.com/repos/tritemio/lmfit-py/subscription","commits_url":"https://api.github.com/repos/tritemio/lmfit-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/tritemio/lmfit-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/tritemio/lmfit-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/tritemio/lmfit-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/tritemio/lmfit-py/contents/{+path}","compare_url":"https://api.github.com/repos/tritemio/lmfit-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tritemio/lmfit-py/merges","archive_url":"https://api.github.com/repos/tritemio/lmfit-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tritemio/lmfit-py/downloads","issues_url":"https://api.github.com/repos/tritemio/lmfit-py/issues{/number}","pulls_url":"https://api.github.com/repos/tritemio/lmfit-py/pulls{/number}","milestones_url":"https://api.github.com/repos/tritemio/lmfit-py/milestones{/number}","notifications_url":"https://api.github.com/repos/tritemio/lmfit-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tritemio/lmfit-py/labels{/name}","releases_url":"https://api.github.com/repos/tritemio/lmfit-py/releases{/id}","deployments_url":"https://api.github.com/repos/tritemio/lmfit-py/deployments","created_at":"2014-08-28T16:21:19Z","updated_at":"2016-03-17T04:22:13Z","pushed_at":"2016-08-22T05:45:36Z","git_url":"git://github.com/tritemio/lmfit-py.git","ssh_url":"git@github.com:tritemio/lmfit-py.git","clone_url":"https://github.com/tritemio/lmfit-py.git","svn_url":"https://github.com/tritemio/lmfit-py","homepage":"http:/lmfit.github.io/lmfit-py/","size":8847,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lmfit:master","ref":"master","sha":"44ed207d46ce25de6b5f6ea7e14031e6b141f44e","user":{"login":"lmfit","id":6190878,"avatar_url":"https://avatars.githubusercontent.com/u/6190878?v=3","gravatar_id":"","url":"https://api.github.com/users/lmfit","html_url":"https://github.com/lmfit","followers_url":"https://api.github.com/users/lmfit/followers","following_url":"https://api.github.com/users/lmfit/following{/other_user}","gists_url":"https://api.github.com/users/lmfit/gists{/gist_id}","starred_url":"https://api.github.com/users/lmfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmfit/subscriptions","organizations_url":"https://api.github.com/users/lmfit/orgs","repos_url":"https://api.github.com/users/lmfit/repos","events_url":"https://api.github.com/users/lmfit/events{/privacy}","received_events_url":"https://api.github.com/users/lmfit/received_events","type":"Organization","site_admin":false},"repo":{"id":2136524,"name":"lmfit-py","full_name":"lmfit/lmfit-py","owner":{"login":"lmfit","id":6190878,"avatar_url":"https://avatars.githubusercontent.com/u/6190878?v=3","gravatar_id":"","url":"https://api.github.com/users/lmfit","html_url":"https://github.com/lmfit","followers_url":"https://api.github.com/users/lmfit/followers","following_url":"https://api.github.com/users/lmfit/following{/other_user}","gists_url":"https://api.github.com/users/lmfit/gists{/gist_id}","starred_url":"https://api.github.com/users/lmfit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmfit/subscriptions","organizations_url":"https://api.github.com/users/lmfit/orgs","repos_url":"https://api.github.com/users/lmfit/repos","events_url":"https://api.github.com/users/lmfit/events{/privacy}","received_events_url":"https://api.github.com/users/lmfit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lmfit/lmfit-py","description":"Non-Linear Least Squares Minimization, with flexible Parameter settings, based on scipy.optimize.leastsq, and with many additional classes and methods for curve fitting ","fork":false,"url":"https://api.github.com/repos/lmfit/lmfit-py","forks_url":"https://api.github.com/repos/lmfit/lmfit-py/forks","keys_url":"https://api.github.com/repos/lmfit/lmfit-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmfit/lmfit-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmfit/lmfit-py/teams","hooks_url":"https://api.github.com/repos/lmfit/lmfit-py/hooks","issue_events_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/events{/number}","events_url":"https://api.github.com/repos/lmfit/lmfit-py/events","assignees_url":"https://api.github.com/repos/lmfit/lmfit-py/assignees{/user}","branches_url":"https://api.github.com/repos/lmfit/lmfit-py/branches{/branch}","tags_url":"https://api.github.com/repos/lmfit/lmfit-py/tags","blobs_url":"https://api.github.com/repos/lmfit/lmfit-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmfit/lmfit-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmfit/lmfit-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmfit/lmfit-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmfit/lmfit-py/statuses/{sha}","languages_url":"https://api.github.com/repos/lmfit/lmfit-py/languages","stargazers_url":"https://api.github.com/repos/lmfit/lmfit-py/stargazers","contributors_url":"https://api.github.com/repos/lmfit/lmfit-py/contributors","subscribers_url":"https://api.github.com/repos/lmfit/lmfit-py/subscribers","subscription_url":"https://api.github.com/repos/lmfit/lmfit-py/subscription","commits_url":"https://api.github.com/repos/lmfit/lmfit-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmfit/lmfit-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmfit/lmfit-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmfit/lmfit-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmfit/lmfit-py/contents/{+path}","compare_url":"https://api.github.com/repos/lmfit/lmfit-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmfit/lmfit-py/merges","archive_url":"https://api.github.com/repos/lmfit/lmfit-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmfit/lmfit-py/downloads","issues_url":"https://api.github.com/repos/lmfit/lmfit-py/issues{/number}","pulls_url":"https://api.github.com/repos/lmfit/lmfit-py/pulls{/number}","milestones_url":"https://api.github.com/repos/lmfit/lmfit-py/milestones{/number}","notifications_url":"https://api.github.com/repos/lmfit/lmfit-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmfit/lmfit-py/labels{/name}","releases_url":"https://api.github.com/repos/lmfit/lmfit-py/releases{/id}","deployments_url":"https://api.github.com/repos/lmfit/lmfit-py/deployments","created_at":"2011-08-01T12:13:19Z","updated_at":"2016-08-16T08:24:36Z","pushed_at":"2016-08-23T12:10:00Z","git_url":"git://github.com/lmfit/lmfit-py.git","ssh_url":"git@github.com:lmfit/lmfit-py.git","clone_url":"https://github.com/lmfit/lmfit-py.git","svn_url":"https://github.com/lmfit/lmfit-py","homepage":"http:/lmfit.github.io/lmfit-py/","size":10952,"stargazers_count":137,"watchers_count":137,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":15,"forks":67,"open_issues":15,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lmfit/lmfit-py/pulls/370"},"html":{"href":"https://github.com/lmfit/lmfit-py/pull/370"},"issue":{"href":"https://api.github.com/repos/lmfit/lmfit-py/issues/370"},"comments":{"href":"https://api.github.com/repos/lmfit/lmfit-py/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/lmfit/lmfit-py/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/lmfit/lmfit-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lmfit/lmfit-py/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/lmfit/lmfit-py/statuses/9002013a853efa50d11fdbcfafa4b17216bcc3ff"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"newville","id":304251,"avatar_url":"https://avatars.githubusercontent.com/u/304251?v=3","gravatar_id":"","url":"https://api.github.com/users/newville","html_url":"https://github.com/newville","followers_url":"https://api.github.com/users/newville/followers","following_url":"https://api.github.com/users/newville/following{/other_user}","gists_url":"https://api.github.com/users/newville/gists{/gist_id}","starred_url":"https://api.github.com/users/newville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newville/subscriptions","organizations_url":"https://api.github.com/users/newville/orgs","repos_url":"https://api.github.com/users/newville/repos","events_url":"https://api.github.com/users/newville/events{/privacy}","received_events_url":"https://api.github.com/users/newville/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":17,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"newville"}}