{"action":"created","comment":{"url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/comments/66303015","id":66303015,"diff_hunk":"@@ -4,17 +4,18 @@ var format = require('util').format\n \n var Promise = require('lie')\n \n-var generateSalt = require('./utils/generate-salt')\n-var hashPassword = require('./utils/hash-password')\n+var internals = module.exports.internals = {}\n+internals.hashPassword = require('./utils/hash-password')\n+internals.generateSalt = require('./utils/generate-salt')","path":"lib/set.js","position":8,"original_position":8,"commit_id":"7fc2a4bcb0ddfdf9b28ffda27ece9230c749f8f5","original_commit_id":"7fc2a4bcb0ddfdf9b28ffda27ece9230c749f8f5","user":{"login":"gr2m","id":39992,"avatar_url":"https://avatars.githubusercontent.com/u/39992?v=3","gravatar_id":"","url":"https://api.github.com/users/gr2m","html_url":"https://github.com/gr2m","followers_url":"https://api.github.com/users/gr2m/followers","following_url":"https://api.github.com/users/gr2m/following{/other_user}","gists_url":"https://api.github.com/users/gr2m/gists{/gist_id}","starred_url":"https://api.github.com/users/gr2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gr2m/subscriptions","organizations_url":"https://api.github.com/users/gr2m/orgs","repos_url":"https://api.github.com/users/gr2m/repos","events_url":"https://api.github.com/users/gr2m/events{/privacy}","received_events_url":"https://api.github.com/users/gr2m/received_events","type":"User","site_admin":false},"body":"This is what I meant with exposing `internals`. This way you you do\r\n\r\n```js\r\nvar set = require('./path/to/set')\r\n```\r\n\r\nthen set.internals.hashPassword is accessible. That way we can mock its behavior in tests","created_at":"2016-06-08T17:41:30Z","updated_at":"2016-06-08T17:41:30Z","html_url":"https://github.com/hoodiehq/pouchdb-admins/pull/13#discussion_r66303015","pull_request_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/comments/66303015"},"html":{"href":"https://github.com/hoodiehq/pouchdb-admins/pull/13#discussion_r66303015"},"pull_request":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13","id":72984844,"html_url":"https://github.com/hoodiehq/pouchdb-admins/pull/13","diff_url":"https://github.com/hoodiehq/pouchdb-admins/pull/13.diff","patch_url":"https://github.com/hoodiehq/pouchdb-admins/pull/13.patch","issue_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/13","number":13,"state":"open","locked":false,"title":"WIP: issue 11 code coverage","user":{"login":"kazekagegaara","id":3198086,"avatar_url":"https://avatars.githubusercontent.com/u/3198086?v=3","gravatar_id":"","url":"https://api.github.com/users/kazekagegaara","html_url":"https://github.com/kazekagegaara","followers_url":"https://api.github.com/users/kazekagegaara/followers","following_url":"https://api.github.com/users/kazekagegaara/following{/other_user}","gists_url":"https://api.github.com/users/kazekagegaara/gists{/gist_id}","starred_url":"https://api.github.com/users/kazekagegaara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazekagegaara/subscriptions","organizations_url":"https://api.github.com/users/kazekagegaara/orgs","repos_url":"https://api.github.com/users/kazekagegaara/repos","events_url":"https://api.github.com/users/kazekagegaara/events{/privacy}","received_events_url":"https://api.github.com/users/kazekagegaara/received_events","type":"User","site_admin":false},"body":"This is for issue #11 .\r\nStarted working on `set.js` file. The test passes, but code coverage still shows that `if (error) {\r\n          return reject(error)\r\n        }` (line 22 in set.js) isn't covered.","created_at":"2016-06-08T04:22:02Z","updated_at":"2016-06-08T17:41:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b20373e33bcdd3d3e74db7b1c83c549d20bc96","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13/commits","review_comments_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13/comments","review_comment_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/13/comments","statuses_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/statuses/7fc2a4bcb0ddfdf9b28ffda27ece9230c749f8f5","head":{"label":"hoodiehq:issue11","ref":"issue11","sha":"7fc2a4bcb0ddfdf9b28ffda27ece9230c749f8f5","user":{"login":"hoodiehq","id":1888826,"avatar_url":"https://avatars.githubusercontent.com/u/1888826?v=3","gravatar_id":"","url":"https://api.github.com/users/hoodiehq","html_url":"https://github.com/hoodiehq","followers_url":"https://api.github.com/users/hoodiehq/followers","following_url":"https://api.github.com/users/hoodiehq/following{/other_user}","gists_url":"https://api.github.com/users/hoodiehq/gists{/gist_id}","starred_url":"https://api.github.com/users/hoodiehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoodiehq/subscriptions","organizations_url":"https://api.github.com/users/hoodiehq/orgs","repos_url":"https://api.github.com/users/hoodiehq/repos","events_url":"https://api.github.com/users/hoodiehq/events{/privacy}","received_events_url":"https://api.github.com/users/hoodiehq/received_events","type":"Organization","site_admin":false},"repo":{"id":48332817,"name":"pouchdb-admins","full_name":"hoodiehq/pouchdb-admins","owner":{"login":"hoodiehq","id":1888826,"avatar_url":"https://avatars.githubusercontent.com/u/1888826?v=3","gravatar_id":"","url":"https://api.github.com/users/hoodiehq","html_url":"https://github.com/hoodiehq","followers_url":"https://api.github.com/users/hoodiehq/followers","following_url":"https://api.github.com/users/hoodiehq/following{/other_user}","gists_url":"https://api.github.com/users/hoodiehq/gists{/gist_id}","starred_url":"https://api.github.com/users/hoodiehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoodiehq/subscriptions","organizations_url":"https://api.github.com/users/hoodiehq/orgs","repos_url":"https://api.github.com/users/hoodiehq/repos","events_url":"https://api.github.com/users/hoodiehq/events{/privacy}","received_events_url":"https://api.github.com/users/hoodiehq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hoodiehq/pouchdb-admins","description":"PouchDB plugin to simulate CouchDB’s admin accounts","fork":false,"url":"https://api.github.com/repos/hoodiehq/pouchdb-admins","forks_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/forks","keys_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/teams","hooks_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/hooks","issue_events_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/events{/number}","events_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/events","assignees_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/assignees{/user}","branches_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/branches{/branch}","tags_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/tags","blobs_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/statuses/{sha}","languages_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/languages","stargazers_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/stargazers","contributors_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/contributors","subscribers_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/subscribers","subscription_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/subscription","commits_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/contents/{+path}","compare_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/merges","archive_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/downloads","issues_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues{/number}","pulls_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls{/number}","milestones_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/milestones{/number}","notifications_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/labels{/name}","releases_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/releases{/id}","deployments_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/deployments","created_at":"2015-12-20T18:43:10Z","updated_at":"2016-01-12T15:53:15Z","pushed_at":"2016-06-08T17:39:43Z","git_url":"git://github.com/hoodiehq/pouchdb-admins.git","ssh_url":"git@github.com:hoodiehq/pouchdb-admins.git","clone_url":"https://github.com/hoodiehq/pouchdb-admins.git","svn_url":"https://github.com/hoodiehq/pouchdb-admins","homepage":null,"size":23,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"hoodiehq:master","ref":"master","sha":"ebe28fecd411ae98919093b8f52e5f29396883dc","user":{"login":"hoodiehq","id":1888826,"avatar_url":"https://avatars.githubusercontent.com/u/1888826?v=3","gravatar_id":"","url":"https://api.github.com/users/hoodiehq","html_url":"https://github.com/hoodiehq","followers_url":"https://api.github.com/users/hoodiehq/followers","following_url":"https://api.github.com/users/hoodiehq/following{/other_user}","gists_url":"https://api.github.com/users/hoodiehq/gists{/gist_id}","starred_url":"https://api.github.com/users/hoodiehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoodiehq/subscriptions","organizations_url":"https://api.github.com/users/hoodiehq/orgs","repos_url":"https://api.github.com/users/hoodiehq/repos","events_url":"https://api.github.com/users/hoodiehq/events{/privacy}","received_events_url":"https://api.github.com/users/hoodiehq/received_events","type":"Organization","site_admin":false},"repo":{"id":48332817,"name":"pouchdb-admins","full_name":"hoodiehq/pouchdb-admins","owner":{"login":"hoodiehq","id":1888826,"avatar_url":"https://avatars.githubusercontent.com/u/1888826?v=3","gravatar_id":"","url":"https://api.github.com/users/hoodiehq","html_url":"https://github.com/hoodiehq","followers_url":"https://api.github.com/users/hoodiehq/followers","following_url":"https://api.github.com/users/hoodiehq/following{/other_user}","gists_url":"https://api.github.com/users/hoodiehq/gists{/gist_id}","starred_url":"https://api.github.com/users/hoodiehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoodiehq/subscriptions","organizations_url":"https://api.github.com/users/hoodiehq/orgs","repos_url":"https://api.github.com/users/hoodiehq/repos","events_url":"https://api.github.com/users/hoodiehq/events{/privacy}","received_events_url":"https://api.github.com/users/hoodiehq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hoodiehq/pouchdb-admins","description":"PouchDB plugin to simulate CouchDB’s admin accounts","fork":false,"url":"https://api.github.com/repos/hoodiehq/pouchdb-admins","forks_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/forks","keys_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/teams","hooks_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/hooks","issue_events_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/events{/number}","events_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/events","assignees_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/assignees{/user}","branches_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/branches{/branch}","tags_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/tags","blobs_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/statuses/{sha}","languages_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/languages","stargazers_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/stargazers","contributors_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/contributors","subscribers_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/subscribers","subscription_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/subscription","commits_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/contents/{+path}","compare_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/merges","archive_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/downloads","issues_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues{/number}","pulls_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls{/number}","milestones_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/milestones{/number}","notifications_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/labels{/name}","releases_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/releases{/id}","deployments_url":"https://api.github.com/repos/hoodiehq/pouchdb-admins/deployments","created_at":"2015-12-20T18:43:10Z","updated_at":"2016-01-12T15:53:15Z","pushed_at":"2016-06-08T17:39:43Z","git_url":"git://github.com/hoodiehq/pouchdb-admins.git","ssh_url":"git@github.com:hoodiehq/pouchdb-admins.git","clone_url":"https://github.com/hoodiehq/pouchdb-admins.git","svn_url":"https://github.com/hoodiehq/pouchdb-admins","homepage":null,"size":23,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13"},"html":{"href":"https://github.com/hoodiehq/pouchdb-admins/pull/13"},"issue":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/13"},"comments":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/hoodiehq/pouchdb-admins/statuses/7fc2a4bcb0ddfdf9b28ffda27ece9230c749f8f5"}}}}
{"actor":{"display_login":"gr2m"}}