{"action":"created","issue":{"url":"https://api.github.com/repos/znc/znc/issues/1256","repository_url":"https://api.github.com/repos/znc/znc","labels_url":"https://api.github.com/repos/znc/znc/issues/1256/labels{/name}","comments_url":"https://api.github.com/repos/znc/znc/issues/1256/comments","events_url":"https://api.github.com/repos/znc/znc/issues/1256/events","html_url":"https://github.com/znc/znc/issues/1256","id":144777149,"number":1256,"title":"1.6.3 build broken using OpenSSL built with `no-comp` option","user":{"login":"welwood08","id":377024,"avatar_url":"https://avatars.githubusercontent.com/u/377024?v=3","gravatar_id":"","url":"https://api.github.com/users/welwood08","html_url":"https://github.com/welwood08","followers_url":"https://api.github.com/users/welwood08/followers","following_url":"https://api.github.com/users/welwood08/following{/other_user}","gists_url":"https://api.github.com/users/welwood08/gists{/gist_id}","starred_url":"https://api.github.com/users/welwood08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/welwood08/subscriptions","organizations_url":"https://api.github.com/users/welwood08/orgs","repos_url":"https://api.github.com/users/welwood08/repos","events_url":"https://api.github.com/users/welwood08/events{/privacy}","received_events_url":"https://api.github.com/users/welwood08/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2016-03-31T03:13:13Z","updated_at":"2016-03-31T22:55:18Z","closed_at":null,"body":"Compiling znc 1.6.3 using OpenSSL 1.0.2g built with the `no-comp` option results in the following:\r\n```\r\nLinking znc...\r\nsrc/Csocket.o: In function `InitSSL(ECompType)':\r\n/tmp/tmp.egENlxZFXa/znc-1.6.3/src/Csocket.cpp:587: undefined reference to `COMP_rle'\r\n/tmp/tmp.egENlxZFXa/znc-1.6.3/src/Csocket.cpp:580: undefined reference to `COMP_zlib'\r\ncollect2: error: ld returned 1 exit status\r\nmake: *** [znc] Error 1\r\n```\r\n\r\n* Rebuilding OpenSSL without the `no-comp` option results in successful znc build.\r\n* Applying the OpenBSD Csocket patch linked in #594 and using the earlier, problematic OpenSSL built with `no-comp` option also results in successful znc build.\r\n\r\nDigging around, it would appear that the Csocket submodule on the 1.6.x branch is pointing to an older revision that only partially fixes the problem referred to in #594. I don't know if there is a way to specify a `no-comp` option in LibreSSL, but if there is then that presumably also breaks znc 1.6.3's build. A newer revision of Csocket would also bring support for BoringSSL.\r\n\r\nPlease could c6ed6b2ee47fc43f40f6888c499f6143b0c8cd0f from the master branch (or any later upstream revision) be applied to the 1.6.x branch for the next release?\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/32429835-1-6-3-build-broken-using-openssl-built-with-no-comp-option?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/znc/znc/issues/comments/204163440","html_url":"https://github.com/znc/znc/issues/1256#issuecomment-204163440","issue_url":"https://api.github.com/repos/znc/znc/issues/1256","id":204163440,"user":{"login":"DarthGandalf","id":325092,"avatar_url":"https://avatars.githubusercontent.com/u/325092?v=3","gravatar_id":"","url":"https://api.github.com/users/DarthGandalf","html_url":"https://github.com/DarthGandalf","followers_url":"https://api.github.com/users/DarthGandalf/followers","following_url":"https://api.github.com/users/DarthGandalf/following{/other_user}","gists_url":"https://api.github.com/users/DarthGandalf/gists{/gist_id}","starred_url":"https://api.github.com/users/DarthGandalf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarthGandalf/subscriptions","organizations_url":"https://api.github.com/users/DarthGandalf/orgs","repos_url":"https://api.github.com/users/DarthGandalf/repos","events_url":"https://api.github.com/users/DarthGandalf/events{/privacy}","received_events_url":"https://api.github.com/users/DarthGandalf/received_events","type":"User","site_admin":false},"created_at":"2016-03-31T22:55:18Z","updated_at":"2016-03-31T22:55:18Z","body":"> Csocket submodule on the 1.6.x branch is pointing to an older revision\r\n\r\nCorrect. Master branch of Csocket has too many ABI-breaking changes.\r\n\r\n> Please could c6ed6b2 from the master branch (or any later upstream revision) be applied to the 1.6.x branch for the next release?\r\n\r\nDoes ZNC build for you with this patched in? Note that the OpenBSD patch is different from https://github.com/jimloco/Csocket/pull/49 mentioned in #594 \r\n\r\nProbably noone tried yet to build ZNC with OpenSSL with `no-comp`. If the patch fixes it, the patch should be pushed to upstream Csocket, but in a way compatible with ZNC 1.6.x, if you want to see it in ZNC 1.6.x. Basically, checkout the current commit used by 1.6.x, apply the patch, and merge the result to master. Then ZNC can move its Csocket submodule by this one commit.\r\n\r\nAt some point ZNC 1.7.0 will be released with Csocket from master."}}