{"action":"created","comment":{"url":"https://api.github.com/repos/apache/accumulo/pulls/comments/88543950","pull_request_review_id":9115577,"id":88543950,"diff_hunk":"@@ -147,4 +147,13 @@\n    *              if not supported.\n    */\n   SortedKeyValueIterator<K,V> deepCopy(IteratorEnvironment env);\n+\n+  /**\n+   * Closes the Iterator. This should be overridden by the implementing class that has access to <tt>SortedKeyValueIterator source</tt> provided in the","path":"core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java","position":null,"original_position":15,"commit_id":"2f9f301b6d2e0474299628856debefe99ca857a5","original_commit_id":"77ae4f61c1c08c85e40c59fa12e040ec993fd61d","user":{"login":"joshelser","id":67863,"avatar_url":"https://avatars.githubusercontent.com/u/67863?v=3","gravatar_id":"","url":"https://api.github.com/users/joshelser","html_url":"https://github.com/joshelser","followers_url":"https://api.github.com/users/joshelser/followers","following_url":"https://api.github.com/users/joshelser/following{/other_user}","gists_url":"https://api.github.com/users/joshelser/gists{/gist_id}","starred_url":"https://api.github.com/users/joshelser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshelser/subscriptions","organizations_url":"https://api.github.com/users/joshelser/orgs","repos_url":"https://api.github.com/users/joshelser/repos","events_url":"https://api.github.com/users/joshelser/events{/privacy}","received_events_url":"https://api.github.com/users/joshelser/received_events","type":"User","site_admin":false},"body":"Also, I'm referring to SHOULD and MUST as defined by https://www.ietf.org/rfc/rfc2119.txt in case it was not clear.","created_at":"2016-11-17T20:55:48Z","updated_at":"2016-11-17T20:55:48Z","html_url":"https://github.com/apache/accumulo/pull/159#discussion_r88543950","pull_request_url":"https://api.github.com/repos/apache/accumulo/pulls/159","_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments/88543950"},"html":{"href":"https://github.com/apache/accumulo/pull/159#discussion_r88543950"},"pull_request":{"href":"https://api.github.com/repos/apache/accumulo/pulls/159"}}},"pull_request":{"url":"https://api.github.com/repos/apache/accumulo/pulls/159","id":87529870,"html_url":"https://github.com/apache/accumulo/pull/159","diff_url":"https://github.com/apache/accumulo/pull/159.diff","patch_url":"https://github.com/apache/accumulo/pull/159.patch","issue_url":"https://api.github.com/repos/apache/accumulo/issues/159","number":159,"state":"open","locked":false,"title":"ACCUMULO-1280: many changes for closing iterators","user":{"login":"milleruntime","id":11872539,"avatar_url":"https://avatars.githubusercontent.com/u/11872539?v=3","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"body":"Looking for feedback on first round of changes and if there are more places close can be called.\n- made SortedKeyValueIterator extend AutoCloseable\n- in SKVI - defined default close method so it is not required by implementations\n- in SKVI - defined default closeSafely to allow calling of close in a Java 8 stream\n- implemented close method where Iterator contained a SKVI source\n- modified Scanner and Compactor to utilize AutoCloseable and try-with-resources\n\nTODO: write test to verify close on wrapped iterators will propagate through\n","created_at":"2016-09-30T16:59:15Z","updated_at":"2016-11-17T20:55:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99f34919505080bc56abccfa5fc08607c69dd4ce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/accumulo/pulls/159/commits","review_comments_url":"https://api.github.com/repos/apache/accumulo/pulls/159/comments","review_comment_url":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/accumulo/issues/159/comments","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/2f9f301b6d2e0474299628856debefe99ca857a5","head":{"label":"milleruntime:ACCUMULO-1280","ref":"ACCUMULO-1280","sha":"2f9f301b6d2e0474299628856debefe99ca857a5","user":{"login":"milleruntime","id":11872539,"avatar_url":"https://avatars.githubusercontent.com/u/11872539?v=3","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"repo":{"id":62655047,"name":"accumulo","full_name":"milleruntime/accumulo","owner":{"login":"milleruntime","id":11872539,"avatar_url":"https://avatars.githubusercontent.com/u/11872539?v=3","gravatar_id":"","url":"https://api.github.com/users/milleruntime","html_url":"https://github.com/milleruntime","followers_url":"https://api.github.com/users/milleruntime/followers","following_url":"https://api.github.com/users/milleruntime/following{/other_user}","gists_url":"https://api.github.com/users/milleruntime/gists{/gist_id}","starred_url":"https://api.github.com/users/milleruntime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milleruntime/subscriptions","organizations_url":"https://api.github.com/users/milleruntime/orgs","repos_url":"https://api.github.com/users/milleruntime/repos","events_url":"https://api.github.com/users/milleruntime/events{/privacy}","received_events_url":"https://api.github.com/users/milleruntime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/milleruntime/accumulo","description":"Mirror of Apache Accumulo","fork":true,"url":"https://api.github.com/repos/milleruntime/accumulo","forks_url":"https://api.github.com/repos/milleruntime/accumulo/forks","keys_url":"https://api.github.com/repos/milleruntime/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/milleruntime/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/milleruntime/accumulo/teams","hooks_url":"https://api.github.com/repos/milleruntime/accumulo/hooks","issue_events_url":"https://api.github.com/repos/milleruntime/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/milleruntime/accumulo/events","assignees_url":"https://api.github.com/repos/milleruntime/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/milleruntime/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/milleruntime/accumulo/tags","blobs_url":"https://api.github.com/repos/milleruntime/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/milleruntime/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/milleruntime/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/milleruntime/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/milleruntime/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/milleruntime/accumulo/languages","stargazers_url":"https://api.github.com/repos/milleruntime/accumulo/stargazers","contributors_url":"https://api.github.com/repos/milleruntime/accumulo/contributors","subscribers_url":"https://api.github.com/repos/milleruntime/accumulo/subscribers","subscription_url":"https://api.github.com/repos/milleruntime/accumulo/subscription","commits_url":"https://api.github.com/repos/milleruntime/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/milleruntime/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/milleruntime/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/milleruntime/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/milleruntime/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/milleruntime/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/milleruntime/accumulo/merges","archive_url":"https://api.github.com/repos/milleruntime/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/milleruntime/accumulo/downloads","issues_url":"https://api.github.com/repos/milleruntime/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/milleruntime/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/milleruntime/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/milleruntime/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/milleruntime/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/milleruntime/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/milleruntime/accumulo/deployments","created_at":"2016-07-05T17:11:42Z","updated_at":"2016-07-05T17:11:50Z","pushed_at":"2016-11-17T20:37:48Z","git_url":"git://github.com/milleruntime/accumulo.git","ssh_url":"git@github.com:milleruntime/accumulo.git","clone_url":"https://github.com/milleruntime/accumulo.git","svn_url":"https://github.com/milleruntime/accumulo","homepage":"","size":62212,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e2d21fc9267a9335539daa3f94d30ced78726622","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2524488,"name":"accumulo","full_name":"apache/accumulo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/accumulo","description":"Mirror of Apache Accumulo","fork":false,"url":"https://api.github.com/repos/apache/accumulo","forks_url":"https://api.github.com/repos/apache/accumulo/forks","keys_url":"https://api.github.com/repos/apache/accumulo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/accumulo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/accumulo/teams","hooks_url":"https://api.github.com/repos/apache/accumulo/hooks","issue_events_url":"https://api.github.com/repos/apache/accumulo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/accumulo/events","assignees_url":"https://api.github.com/repos/apache/accumulo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/accumulo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/accumulo/tags","blobs_url":"https://api.github.com/repos/apache/accumulo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/accumulo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/accumulo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/accumulo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/accumulo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/accumulo/languages","stargazers_url":"https://api.github.com/repos/apache/accumulo/stargazers","contributors_url":"https://api.github.com/repos/apache/accumulo/contributors","subscribers_url":"https://api.github.com/repos/apache/accumulo/subscribers","subscription_url":"https://api.github.com/repos/apache/accumulo/subscription","commits_url":"https://api.github.com/repos/apache/accumulo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/accumulo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/accumulo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/accumulo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/accumulo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/accumulo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/accumulo/merges","archive_url":"https://api.github.com/repos/apache/accumulo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/accumulo/downloads","issues_url":"https://api.github.com/repos/apache/accumulo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/accumulo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/accumulo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/accumulo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/accumulo/labels{/name}","releases_url":"https://api.github.com/repos/apache/accumulo/releases{/id}","deployments_url":"https://api.github.com/repos/apache/accumulo/deployments","created_at":"2011-10-06T07:00:09Z","updated_at":"2016-11-08T02:14:59Z","pushed_at":"2016-11-17T20:37:49Z","git_url":"git://github.com/apache/accumulo.git","ssh_url":"git@github.com:apache/accumulo.git","clone_url":"https://github.com/apache/accumulo.git","svn_url":"https://github.com/apache/accumulo","homepage":"","size":71459,"stargazers_count":261,"watchers_count":261,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":143,"mirror_url":"git://git.apache.org/accumulo.git","open_issues_count":8,"forks":143,"open_issues":8,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/accumulo/pulls/159"},"html":{"href":"https://github.com/apache/accumulo/pull/159"},"issue":{"href":"https://api.github.com/repos/apache/accumulo/issues/159"},"comments":{"href":"https://api.github.com/repos/apache/accumulo/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/accumulo/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/accumulo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/accumulo/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/apache/accumulo/statuses/2f9f301b6d2e0474299628856debefe99ca857a5"}}}}
{"actor":{"display_login":"joshelser"}}