{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/608","repository_url":"https://api.github.com/repos/rstudio/rstudio","labels_url":"https://api.github.com/repos/rstudio/rstudio/issues/608/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/608/comments","events_url":"https://api.github.com/repos/rstudio/rstudio/issues/608/events","html_url":"https://github.com/rstudio/rstudio/pull/608","id":136818543,"number":608,"title":"clean up handlers generated by completion manager on save","user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-02-26T21:25:34Z","updated_at":"2016-02-26T22:03:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/608","html_url":"https://github.com/rstudio/rstudio/pull/608","diff_url":"https://github.com/rstudio/rstudio/pull/608.diff","patch_url":"https://github.com/rstudio/rstudio/pull/608.patch"},"body":"This PR fixes an issue where handlers generated by a completion manager would get leaked (and so remain active) after document save, or a language change. This fixes an issue where duplicated tooltip popups could be displayed in a document, but should also improve performance in long-running sessions.\r\n\r\nThe general scope of this PR is just ensuring that we collect any generated handlers in a `HandlerRegistrations` object, and we ensure that we detach those handlers whenever we change the completion manager."},"comment":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/comments/189502923","html_url":"https://github.com/rstudio/rstudio/pull/608#issuecomment-189502923","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/608","id":189502923,"user":{"login":"kevinushey","id":1976582,"avatar_url":"https://avatars.githubusercontent.com/u/1976582?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinushey","html_url":"https://github.com/kevinushey","followers_url":"https://api.github.com/users/kevinushey/followers","following_url":"https://api.github.com/users/kevinushey/following{/other_user}","gists_url":"https://api.github.com/users/kevinushey/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinushey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinushey/subscriptions","organizations_url":"https://api.github.com/users/kevinushey/orgs","repos_url":"https://api.github.com/users/kevinushey/repos","events_url":"https://api.github.com/users/kevinushey/events{/privacy}","received_events_url":"https://api.github.com/users/kevinushey/received_events","type":"User","site_admin":false},"created_at":"2016-02-26T22:03:58Z","updated_at":"2016-02-26T22:03:58Z","body":"Fortunately, cleaning up the stale popups was an easy fix!"}}