{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/51070101","id":51070101,"diff_hunk":"@@ -548,7 +548,7 @@ private function assertUrlPackage(ContainerBuilder $container, DefinitionDecorat\n     private function assertVersionStrategy(ContainerBuilder $container, Reference $reference, $version, $format)\n     {\n         $versionStrategy = $container->getDefinition($reference);\n-        if (null === $version) {\n+        if (null === $version || !$versionStrategy instanceof DefinitionDecorator) {","path":"src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php","position":14,"original_position":14,"commit_id":"3ed3c4cf5578d30ba34d87fb0886793dcc189edc","original_commit_id":"3ed3c4cf5578d30ba34d87fb0886793dcc189edc","user":{"login":"paradajozsef","id":3610051,"avatar_url":"https://avatars.githubusercontent.com/u/3610051?v=3","gravatar_id":"","url":"https://api.github.com/users/paradajozsef","html_url":"https://github.com/paradajozsef","followers_url":"https://api.github.com/users/paradajozsef/followers","following_url":"https://api.github.com/users/paradajozsef/following{/other_user}","gists_url":"https://api.github.com/users/paradajozsef/gists{/gist_id}","starred_url":"https://api.github.com/users/paradajozsef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradajozsef/subscriptions","organizations_url":"https://api.github.com/users/paradajozsef/orgs","repos_url":"https://api.github.com/users/paradajozsef/repos","events_url":"https://api.github.com/users/paradajozsef/events{/privacy}","received_events_url":"https://api.github.com/users/paradajozsef/received_events","type":"User","site_admin":false},"body":"You are right, this fix is wrong.","created_at":"2016-01-27T23:51:52Z","updated_at":"2016-01-27T23:51:52Z","html_url":"https://github.com/symfony/symfony/pull/17582#discussion_r51070101","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/17582","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/51070101"},"html":{"href":"https://github.com/symfony/symfony/pull/17582#discussion_r51070101"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17582"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/17582","id":57439609,"html_url":"https://github.com/symfony/symfony/pull/17582","diff_url":"https://github.com/symfony/symfony/pull/17582.diff","patch_url":"https://github.com/symfony/symfony/pull/17582.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/17582","number":17582,"state":"open","locked":false,"title":"[WIP][FrameworkBundle] Fix FrameworkBundle tests","user":{"login":"paradajozsef","id":3610051,"avatar_url":"https://avatars.githubusercontent.com/u/3610051?v=3","gravatar_id":"","url":"https://api.github.com/users/paradajozsef","html_url":"https://github.com/paradajozsef","followers_url":"https://api.github.com/users/paradajozsef/followers","following_url":"https://api.github.com/users/paradajozsef/following{/other_user}","gists_url":"https://api.github.com/users/paradajozsef/gists{/gist_id}","starred_url":"https://api.github.com/users/paradajozsef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradajozsef/subscriptions","organizations_url":"https://api.github.com/users/paradajozsef/orgs","repos_url":"https://api.github.com/users/paradajozsef/repos","events_url":"https://api.github.com/users/paradajozsef/events{/privacy}","received_events_url":"https://api.github.com/users/paradajozsef/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | yes\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | Let's see Travis results\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | -\r\n\r\nI couldn't run tests in such environment as Travis (e.g. legacy group), so not sure it will fix everything.","created_at":"2016-01-27T23:20:30Z","updated_at":"2016-01-27T23:51:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed9fd4f4a6abdc610411607ede662bfd1f972a32","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/17582/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/17582/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/17582/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/3ed3c4cf5578d30ba34d87fb0886793dcc189edc","head":{"label":"paradajozsef:fix-fwextension-test-2.7","ref":"fix-fwextension-test-2.7","sha":"3ed3c4cf5578d30ba34d87fb0886793dcc189edc","user":{"login":"paradajozsef","id":3610051,"avatar_url":"https://avatars.githubusercontent.com/u/3610051?v=3","gravatar_id":"","url":"https://api.github.com/users/paradajozsef","html_url":"https://github.com/paradajozsef","followers_url":"https://api.github.com/users/paradajozsef/followers","following_url":"https://api.github.com/users/paradajozsef/following{/other_user}","gists_url":"https://api.github.com/users/paradajozsef/gists{/gist_id}","starred_url":"https://api.github.com/users/paradajozsef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradajozsef/subscriptions","organizations_url":"https://api.github.com/users/paradajozsef/orgs","repos_url":"https://api.github.com/users/paradajozsef/repos","events_url":"https://api.github.com/users/paradajozsef/events{/privacy}","received_events_url":"https://api.github.com/users/paradajozsef/received_events","type":"User","site_admin":false},"repo":{"id":49456192,"name":"symfony","full_name":"paradajozsef/symfony","owner":{"login":"paradajozsef","id":3610051,"avatar_url":"https://avatars.githubusercontent.com/u/3610051?v=3","gravatar_id":"","url":"https://api.github.com/users/paradajozsef","html_url":"https://github.com/paradajozsef","followers_url":"https://api.github.com/users/paradajozsef/followers","following_url":"https://api.github.com/users/paradajozsef/following{/other_user}","gists_url":"https://api.github.com/users/paradajozsef/gists{/gist_id}","starred_url":"https://api.github.com/users/paradajozsef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paradajozsef/subscriptions","organizations_url":"https://api.github.com/users/paradajozsef/orgs","repos_url":"https://api.github.com/users/paradajozsef/repos","events_url":"https://api.github.com/users/paradajozsef/events{/privacy}","received_events_url":"https://api.github.com/users/paradajozsef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paradajozsef/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/paradajozsef/symfony","forks_url":"https://api.github.com/repos/paradajozsef/symfony/forks","keys_url":"https://api.github.com/repos/paradajozsef/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paradajozsef/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paradajozsef/symfony/teams","hooks_url":"https://api.github.com/repos/paradajozsef/symfony/hooks","issue_events_url":"https://api.github.com/repos/paradajozsef/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/paradajozsef/symfony/events","assignees_url":"https://api.github.com/repos/paradajozsef/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/paradajozsef/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/paradajozsef/symfony/tags","blobs_url":"https://api.github.com/repos/paradajozsef/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paradajozsef/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paradajozsef/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/paradajozsef/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paradajozsef/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/paradajozsef/symfony/languages","stargazers_url":"https://api.github.com/repos/paradajozsef/symfony/stargazers","contributors_url":"https://api.github.com/repos/paradajozsef/symfony/contributors","subscribers_url":"https://api.github.com/repos/paradajozsef/symfony/subscribers","subscription_url":"https://api.github.com/repos/paradajozsef/symfony/subscription","commits_url":"https://api.github.com/repos/paradajozsef/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/paradajozsef/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/paradajozsef/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/paradajozsef/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/paradajozsef/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/paradajozsef/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paradajozsef/symfony/merges","archive_url":"https://api.github.com/repos/paradajozsef/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paradajozsef/symfony/downloads","issues_url":"https://api.github.com/repos/paradajozsef/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/paradajozsef/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/paradajozsef/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/paradajozsef/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paradajozsef/symfony/labels{/name}","releases_url":"https://api.github.com/repos/paradajozsef/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/paradajozsef/symfony/deployments","created_at":"2016-01-11T21:40:45Z","updated_at":"2016-01-11T21:40:59Z","pushed_at":"2016-01-27T23:29:29Z","git_url":"git://github.com/paradajozsef/symfony.git","ssh_url":"git@github.com:paradajozsef/symfony.git","clone_url":"https://github.com/paradajozsef/symfony.git","svn_url":"https://github.com/paradajozsef/symfony","homepage":"symfony.com","size":66305,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"528572b764ee1bf9676b28c0a3d4bf0bcf1097dd","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2016-01-27T16:08:30Z","pushed_at":"2016-01-27T23:33:10Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":99916,"stargazers_count":11621,"watchers_count":11621,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4569,"mirror_url":null,"open_issues_count":776,"forks":4569,"open_issues":776,"watchers":11621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17582"},"html":{"href":"https://github.com/symfony/symfony/pull/17582"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/17582"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/17582/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17582/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/17582/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/3ed3c4cf5578d30ba34d87fb0886793dcc189edc"}}}}