{"action":"created","comment":{"url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/comments/65810710","id":65810710,"diff_hunk":"@@ -14,7 +14,10 @@\n \t\t// boot the server and start SuperDirt\n \t\tserver.waitForBoot {\n \t\t\t~dirt = SuperDirt(numChannels, server);\n-\t\t\t~dirt.loadSoundFiles(path);   // load samples (path can be passed in)","path":"classes/extSuperDirtStartup.sc","position":4,"original_position":4,"commit_id":"f202b2744969bf2e6f8887706938ada32be88a63","original_commit_id":"f202b2744969bf2e6f8887706938ada32be88a63","user":{"login":"sfradkin","id":1021145,"avatar_url":"https://avatars.githubusercontent.com/u/1021145?v=3","gravatar_id":"","url":"https://api.github.com/users/sfradkin","html_url":"https://github.com/sfradkin","followers_url":"https://api.github.com/users/sfradkin/followers","following_url":"https://api.github.com/users/sfradkin/following{/other_user}","gists_url":"https://api.github.com/users/sfradkin/gists{/gist_id}","starred_url":"https://api.github.com/users/sfradkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfradkin/subscriptions","organizations_url":"https://api.github.com/users/sfradkin/orgs","repos_url":"https://api.github.com/users/sfradkin/repos","events_url":"https://api.github.com/users/sfradkin/events{/privacy}","received_events_url":"https://api.github.com/users/sfradkin/received_events","type":"User","site_admin":false},"body":"Yes. What I found was that when sending a path into SuperDirt.start, it would only load the samples on the path I supplied and did not load the default samples as well.  My change here ensures that the default samples are loaded whether or not a user supplies another path.","created_at":"2016-06-05T03:10:47Z","updated_at":"2016-06-05T03:10:47Z","html_url":"https://github.com/musikinformatik/SuperDirt/pull/21#discussion_r65810710","pull_request_url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/comments/65810710"},"html":{"href":"https://github.com/musikinformatik/SuperDirt/pull/21#discussion_r65810710"},"pull_request":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21","id":72608236,"html_url":"https://github.com/musikinformatik/SuperDirt/pull/21","diff_url":"https://github.com/musikinformatik/SuperDirt/pull/21.diff","patch_url":"https://github.com/musikinformatik/SuperDirt/pull/21.patch","issue_url":"https://api.github.com/repos/musikinformatik/SuperDirt/issues/21","number":21,"state":"open","locked":false,"title":"conditional load of supplied sample path","user":{"login":"sfradkin","id":1021145,"avatar_url":"https://avatars.githubusercontent.com/u/1021145?v=3","gravatar_id":"","url":"https://api.github.com/users/sfradkin","html_url":"https://github.com/sfradkin","followers_url":"https://api.github.com/users/sfradkin/followers","following_url":"https://api.github.com/users/sfradkin/following{/other_user}","gists_url":"https://api.github.com/users/sfradkin/gists{/gist_id}","starred_url":"https://api.github.com/users/sfradkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfradkin/subscriptions","organizations_url":"https://api.github.com/users/sfradkin/orgs","repos_url":"https://api.github.com/users/sfradkin/repos","events_url":"https://api.github.com/users/sfradkin/events{/privacy}","received_events_url":"https://api.github.com/users/sfradkin/received_events","type":"User","site_admin":false},"body":"adding conditional around loading supplied path so that default samples are always loaded and it checks to see if a path was supplied before attempting to load from that path","created_at":"2016-06-04T17:40:40Z","updated_at":"2016-06-05T03:10:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0367bb67fee1557bd851a3ca0ad154882f08bb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21/commits","review_comments_url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21/comments","review_comment_url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/musikinformatik/SuperDirt/issues/21/comments","statuses_url":"https://api.github.com/repos/musikinformatik/SuperDirt/statuses/f202b2744969bf2e6f8887706938ada32be88a63","head":{"label":"sfradkin:master","ref":"master","sha":"f202b2744969bf2e6f8887706938ada32be88a63","user":{"login":"sfradkin","id":1021145,"avatar_url":"https://avatars.githubusercontent.com/u/1021145?v=3","gravatar_id":"","url":"https://api.github.com/users/sfradkin","html_url":"https://github.com/sfradkin","followers_url":"https://api.github.com/users/sfradkin/followers","following_url":"https://api.github.com/users/sfradkin/following{/other_user}","gists_url":"https://api.github.com/users/sfradkin/gists{/gist_id}","starred_url":"https://api.github.com/users/sfradkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfradkin/subscriptions","organizations_url":"https://api.github.com/users/sfradkin/orgs","repos_url":"https://api.github.com/users/sfradkin/repos","events_url":"https://api.github.com/users/sfradkin/events{/privacy}","received_events_url":"https://api.github.com/users/sfradkin/received_events","type":"User","site_admin":false},"repo":{"id":60421368,"name":"SuperDirt","full_name":"sfradkin/SuperDirt","owner":{"login":"sfradkin","id":1021145,"avatar_url":"https://avatars.githubusercontent.com/u/1021145?v=3","gravatar_id":"","url":"https://api.github.com/users/sfradkin","html_url":"https://github.com/sfradkin","followers_url":"https://api.github.com/users/sfradkin/followers","following_url":"https://api.github.com/users/sfradkin/following{/other_user}","gists_url":"https://api.github.com/users/sfradkin/gists{/gist_id}","starred_url":"https://api.github.com/users/sfradkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfradkin/subscriptions","organizations_url":"https://api.github.com/users/sfradkin/orgs","repos_url":"https://api.github.com/users/sfradkin/repos","events_url":"https://api.github.com/users/sfradkin/events{/privacy}","received_events_url":"https://api.github.com/users/sfradkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfradkin/SuperDirt","description":"","fork":true,"url":"https://api.github.com/repos/sfradkin/SuperDirt","forks_url":"https://api.github.com/repos/sfradkin/SuperDirt/forks","keys_url":"https://api.github.com/repos/sfradkin/SuperDirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfradkin/SuperDirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfradkin/SuperDirt/teams","hooks_url":"https://api.github.com/repos/sfradkin/SuperDirt/hooks","issue_events_url":"https://api.github.com/repos/sfradkin/SuperDirt/issues/events{/number}","events_url":"https://api.github.com/repos/sfradkin/SuperDirt/events","assignees_url":"https://api.github.com/repos/sfradkin/SuperDirt/assignees{/user}","branches_url":"https://api.github.com/repos/sfradkin/SuperDirt/branches{/branch}","tags_url":"https://api.github.com/repos/sfradkin/SuperDirt/tags","blobs_url":"https://api.github.com/repos/sfradkin/SuperDirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfradkin/SuperDirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfradkin/SuperDirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfradkin/SuperDirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfradkin/SuperDirt/statuses/{sha}","languages_url":"https://api.github.com/repos/sfradkin/SuperDirt/languages","stargazers_url":"https://api.github.com/repos/sfradkin/SuperDirt/stargazers","contributors_url":"https://api.github.com/repos/sfradkin/SuperDirt/contributors","subscribers_url":"https://api.github.com/repos/sfradkin/SuperDirt/subscribers","subscription_url":"https://api.github.com/repos/sfradkin/SuperDirt/subscription","commits_url":"https://api.github.com/repos/sfradkin/SuperDirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfradkin/SuperDirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfradkin/SuperDirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfradkin/SuperDirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfradkin/SuperDirt/contents/{+path}","compare_url":"https://api.github.com/repos/sfradkin/SuperDirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfradkin/SuperDirt/merges","archive_url":"https://api.github.com/repos/sfradkin/SuperDirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfradkin/SuperDirt/downloads","issues_url":"https://api.github.com/repos/sfradkin/SuperDirt/issues{/number}","pulls_url":"https://api.github.com/repos/sfradkin/SuperDirt/pulls{/number}","milestones_url":"https://api.github.com/repos/sfradkin/SuperDirt/milestones{/number}","notifications_url":"https://api.github.com/repos/sfradkin/SuperDirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfradkin/SuperDirt/labels{/name}","releases_url":"https://api.github.com/repos/sfradkin/SuperDirt/releases{/id}","deployments_url":"https://api.github.com/repos/sfradkin/SuperDirt/deployments","created_at":"2016-06-04T17:11:10Z","updated_at":"2016-06-04T17:11:11Z","pushed_at":"2016-06-04T17:39:11Z","git_url":"git://github.com/sfradkin/SuperDirt.git","ssh_url":"git@github.com:sfradkin/SuperDirt.git","clone_url":"https://github.com/sfradkin/SuperDirt.git","svn_url":"https://github.com/sfradkin/SuperDirt","homepage":null,"size":7682,"stargazers_count":0,"watchers_count":0,"language":"SuperCollider","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"musikinformatik:master","ref":"master","sha":"e283f78c283717ae4213e47acd381235c15c3a11","user":{"login":"musikinformatik","id":12257228,"avatar_url":"https://avatars.githubusercontent.com/u/12257228?v=3","gravatar_id":"","url":"https://api.github.com/users/musikinformatik","html_url":"https://github.com/musikinformatik","followers_url":"https://api.github.com/users/musikinformatik/followers","following_url":"https://api.github.com/users/musikinformatik/following{/other_user}","gists_url":"https://api.github.com/users/musikinformatik/gists{/gist_id}","starred_url":"https://api.github.com/users/musikinformatik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musikinformatik/subscriptions","organizations_url":"https://api.github.com/users/musikinformatik/orgs","repos_url":"https://api.github.com/users/musikinformatik/repos","events_url":"https://api.github.com/users/musikinformatik/events{/privacy}","received_events_url":"https://api.github.com/users/musikinformatik/received_events","type":"Organization","site_admin":false},"repo":{"id":45493054,"name":"SuperDirt","full_name":"musikinformatik/SuperDirt","owner":{"login":"musikinformatik","id":12257228,"avatar_url":"https://avatars.githubusercontent.com/u/12257228?v=3","gravatar_id":"","url":"https://api.github.com/users/musikinformatik","html_url":"https://github.com/musikinformatik","followers_url":"https://api.github.com/users/musikinformatik/followers","following_url":"https://api.github.com/users/musikinformatik/following{/other_user}","gists_url":"https://api.github.com/users/musikinformatik/gists{/gist_id}","starred_url":"https://api.github.com/users/musikinformatik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musikinformatik/subscriptions","organizations_url":"https://api.github.com/users/musikinformatik/orgs","repos_url":"https://api.github.com/users/musikinformatik/repos","events_url":"https://api.github.com/users/musikinformatik/events{/privacy}","received_events_url":"https://api.github.com/users/musikinformatik/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/musikinformatik/SuperDirt","description":"","fork":false,"url":"https://api.github.com/repos/musikinformatik/SuperDirt","forks_url":"https://api.github.com/repos/musikinformatik/SuperDirt/forks","keys_url":"https://api.github.com/repos/musikinformatik/SuperDirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musikinformatik/SuperDirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musikinformatik/SuperDirt/teams","hooks_url":"https://api.github.com/repos/musikinformatik/SuperDirt/hooks","issue_events_url":"https://api.github.com/repos/musikinformatik/SuperDirt/issues/events{/number}","events_url":"https://api.github.com/repos/musikinformatik/SuperDirt/events","assignees_url":"https://api.github.com/repos/musikinformatik/SuperDirt/assignees{/user}","branches_url":"https://api.github.com/repos/musikinformatik/SuperDirt/branches{/branch}","tags_url":"https://api.github.com/repos/musikinformatik/SuperDirt/tags","blobs_url":"https://api.github.com/repos/musikinformatik/SuperDirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musikinformatik/SuperDirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musikinformatik/SuperDirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/musikinformatik/SuperDirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musikinformatik/SuperDirt/statuses/{sha}","languages_url":"https://api.github.com/repos/musikinformatik/SuperDirt/languages","stargazers_url":"https://api.github.com/repos/musikinformatik/SuperDirt/stargazers","contributors_url":"https://api.github.com/repos/musikinformatik/SuperDirt/contributors","subscribers_url":"https://api.github.com/repos/musikinformatik/SuperDirt/subscribers","subscription_url":"https://api.github.com/repos/musikinformatik/SuperDirt/subscription","commits_url":"https://api.github.com/repos/musikinformatik/SuperDirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/musikinformatik/SuperDirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/musikinformatik/SuperDirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/musikinformatik/SuperDirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/musikinformatik/SuperDirt/contents/{+path}","compare_url":"https://api.github.com/repos/musikinformatik/SuperDirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musikinformatik/SuperDirt/merges","archive_url":"https://api.github.com/repos/musikinformatik/SuperDirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musikinformatik/SuperDirt/downloads","issues_url":"https://api.github.com/repos/musikinformatik/SuperDirt/issues{/number}","pulls_url":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls{/number}","milestones_url":"https://api.github.com/repos/musikinformatik/SuperDirt/milestones{/number}","notifications_url":"https://api.github.com/repos/musikinformatik/SuperDirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musikinformatik/SuperDirt/labels{/name}","releases_url":"https://api.github.com/repos/musikinformatik/SuperDirt/releases{/id}","deployments_url":"https://api.github.com/repos/musikinformatik/SuperDirt/deployments","created_at":"2015-11-03T20:18:44Z","updated_at":"2016-06-05T00:49:23Z","pushed_at":"2016-06-04T20:19:19Z","git_url":"git://github.com/musikinformatik/SuperDirt.git","ssh_url":"git@github.com:musikinformatik/SuperDirt.git","clone_url":"https://github.com/musikinformatik/SuperDirt.git","svn_url":"https://github.com/musikinformatik/SuperDirt","homepage":null,"size":7722,"stargazers_count":21,"watchers_count":21,"language":"SuperCollider","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":4,"forks":4,"open_issues":4,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21"},"html":{"href":"https://github.com/musikinformatik/SuperDirt/pull/21"},"issue":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/issues/21"},"comments":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/musikinformatik/SuperDirt/statuses/f202b2744969bf2e6f8887706938ada32be88a63"}}}}
{"actor":{"display_login":"sfradkin"}}