{"action":"created","issue":{"url":"https://api.github.com/repos/OSGeo/proj.4/issues/386","repository_url":"https://api.github.com/repos/OSGeo/proj.4","labels_url":"https://api.github.com/repos/OSGeo/proj.4/issues/386/labels{/name}","comments_url":"https://api.github.com/repos/OSGeo/proj.4/issues/386/comments","events_url":"https://api.github.com/repos/OSGeo/proj.4/issues/386/events","html_url":"https://github.com/OSGeo/proj.4/pull/386","id":156616787,"number":386,"title":"Add GIGS tests.","user":{"login":"micahcochran","id":7433104,"avatar_url":"https://avatars.githubusercontent.com/u/7433104?v=3","gravatar_id":"","url":"https://api.github.com/users/micahcochran","html_url":"https://github.com/micahcochran","followers_url":"https://api.github.com/users/micahcochran/followers","following_url":"https://api.github.com/users/micahcochran/following{/other_user}","gists_url":"https://api.github.com/users/micahcochran/gists{/gist_id}","starred_url":"https://api.github.com/users/micahcochran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micahcochran/subscriptions","organizations_url":"https://api.github.com/users/micahcochran/orgs","repos_url":"https://api.github.com/users/micahcochran/repos","events_url":"https://api.github.com/users/micahcochran/events{/privacy}","received_events_url":"https://api.github.com/users/micahcochran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2016-05-24T21:44:48Z","updated_at":"2016-05-25T13:02:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OSGeo/proj.4/pulls/386","html_url":"https://github.com/OSGeo/proj.4/pull/386","diff_url":"https://github.com/OSGeo/proj.4/pull/386.diff","patch_url":"https://github.com/OSGeo/proj.4/pull/386.patch"},"body":"This is to implement #374 \r\n\r\nThis is a Python framework that uses JSON formatted test files.  It needs pyproj to be installed.\r\n\r\nIt does 2 different kinds of tests.  A simple conversion test and 1,000 roundtrips.\r\n\r\n**Notes:**\r\n* Python 3 seems to pass more of the tests, so I assume that it is more precises, where Python 2.7 seems to have some slight rounding errors with the 1,000 roundtrip tests.  I assume that this is some issue with Python or pyproj.  So, Python 3.3+ is recommended for testing. :smiley:    This was a very recent discovery.\r\n* Some of the tests fail and they are not included in Travis.  Still they are in the commit for testing.  The [TESTNOTES.md](https://github.com/micahcochran/proj.4/blob/py-gigs-test4/test/gigs/TESTNOTES.md) notes how badly they were off.  :arrow_backward: that needs to be reformatted.\r\n* There could still be issues with the testing methods itself.  GIGS uses Degrees Minutes Seconds for lat/long, where I've used Decimal Degrees for lat/long.\r\n* Using cs2cs was attempted, but there were some precision errors and it is a few orders of magnitude slower.  (It seems like a few thousand Python Popen calls per test is expensive.)  18 minute runtime for cs2cs testing, versus the 10 second runtime for pyproj.  The cs2cs code is still in the code. \r\n\r\n\r\nI'd like this to be reviewed at least a little bit before merging, so **this is not yet ready for merging**.\r\n\r\nI have the question:  Should this be a test suite/framework that is outside of Proj.4 project?  BUT I need to ask the International Association of Oil & Gas Producers how their material can be reproduced appropriately."},"comment":{"url":"https://api.github.com/repos/OSGeo/proj.4/issues/comments/221568760","html_url":"https://github.com/OSGeo/proj.4/pull/386#issuecomment-221568760","issue_url":"https://api.github.com/repos/OSGeo/proj.4/issues/386","id":221568760,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2016-05-25T13:02:55Z","updated_at":"2016-05-25T13:02:55Z","body":"\n[![Coverage Status](https://coveralls.io/builds/6327392/badge)](https://coveralls.io/builds/6327392)\n\nCoverage increased (+0.6%) to 73.021% when pulling **0b2d94b76f151504701672cda1a40df55273be69 on micahcochran:py-gigs-test4** into **a112ea3172e89230fa307567be3d70e286b1eeb5 on OSGeo:master**.\n"}}
{"actor":{"display_login":"coveralls"}}