{"action":"created","comment":{"url":"https://api.github.com/repos/horde/horde/pulls/comments/72064075","id":72064075,"diff_hunk":"@@ -265,6 +269,11 @@ public function addRelationship($relationship, $args)\n                 $args['tableAlias'] = $this->_alias($args['table']);\n             }\n         }\n+        // anything other than INNER and LEFT JOINs will cause errors\n+        // as the primary object would have all values filled with null\n+        if (isset($args['join_type']) && !in_array(strtoupper($args['join_type']), array('INNER JOIN', 'LEFT JOIN'))) {","path":"framework/Rdo/lib/Horde/Rdo/Query.php","position":null,"original_position":33,"commit_id":"ad09a14722d6c40abd844aa91a01c4c7f3aca893","original_commit_id":"c0e3021fba2104842f4923646b3858a4b136d7b5","user":{"login":"oakey-b1","id":14907501,"avatar_url":"https://avatars.githubusercontent.com/u/14907501?v=3","gravatar_id":"","url":"https://api.github.com/users/oakey-b1","html_url":"https://github.com/oakey-b1","followers_url":"https://api.github.com/users/oakey-b1/followers","following_url":"https://api.github.com/users/oakey-b1/following{/other_user}","gists_url":"https://api.github.com/users/oakey-b1/gists{/gist_id}","starred_url":"https://api.github.com/users/oakey-b1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakey-b1/subscriptions","organizations_url":"https://api.github.com/users/oakey-b1/orgs","repos_url":"https://api.github.com/users/oakey-b1/repos","events_url":"https://api.github.com/users/oakey-b1/events{/privacy}","received_events_url":"https://api.github.com/users/oakey-b1/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2016-07-25T13:37:07Z","updated_at":"2016-07-25T13:37:07Z","html_url":"https://github.com/horde/horde/pull/198#discussion_r72064075","pull_request_url":"https://api.github.com/repos/horde/horde/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/horde/horde/pulls/comments/72064075"},"html":{"href":"https://github.com/horde/horde/pull/198#discussion_r72064075"},"pull_request":{"href":"https://api.github.com/repos/horde/horde/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/horde/horde/pulls/198","id":78299070,"html_url":"https://github.com/horde/horde/pull/198","diff_url":"https://github.com/horde/horde/pull/198.diff","patch_url":"https://github.com/horde/horde/pull/198.patch","issue_url":"https://api.github.com/repos/horde/horde/issues/198","number":198,"state":"open","locked":false,"title":"make join_type setable over $_relationships array","user":{"login":"oakey-b1","id":14907501,"avatar_url":"https://avatars.githubusercontent.com/u/14907501?v=3","gravatar_id":"","url":"https://api.github.com/users/oakey-b1","html_url":"https://github.com/oakey-b1","followers_url":"https://api.github.com/users/oakey-b1/followers","following_url":"https://api.github.com/users/oakey-b1/following{/other_user}","gists_url":"https://api.github.com/users/oakey-b1/gists{/gist_id}","starred_url":"https://api.github.com/users/oakey-b1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakey-b1/subscriptions","organizations_url":"https://api.github.com/users/oakey-b1/orgs","repos_url":"https://api.github.com/users/oakey-b1/repos","events_url":"https://api.github.com/users/oakey-b1/events{/privacy}","received_events_url":"https://api.github.com/users/oakey-b1/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-07-21T11:22:00Z","updated_at":"2016-07-25T13:37:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f576f211085cd5ca710c9ddf5809e4c5224ea0d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/horde/horde/pulls/198/commits","review_comments_url":"https://api.github.com/repos/horde/horde/pulls/198/comments","review_comment_url":"https://api.github.com/repos/horde/horde/pulls/comments{/number}","comments_url":"https://api.github.com/repos/horde/horde/issues/198/comments","statuses_url":"https://api.github.com/repos/horde/horde/statuses/ad09a14722d6c40abd844aa91a01c4c7f3aca893","head":{"label":"oakey-b1:join-type-support","ref":"join-type-support","sha":"ad09a14722d6c40abd844aa91a01c4c7f3aca893","user":{"login":"oakey-b1","id":14907501,"avatar_url":"https://avatars.githubusercontent.com/u/14907501?v=3","gravatar_id":"","url":"https://api.github.com/users/oakey-b1","html_url":"https://github.com/oakey-b1","followers_url":"https://api.github.com/users/oakey-b1/followers","following_url":"https://api.github.com/users/oakey-b1/following{/other_user}","gists_url":"https://api.github.com/users/oakey-b1/gists{/gist_id}","starred_url":"https://api.github.com/users/oakey-b1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakey-b1/subscriptions","organizations_url":"https://api.github.com/users/oakey-b1/orgs","repos_url":"https://api.github.com/users/oakey-b1/repos","events_url":"https://api.github.com/users/oakey-b1/events{/privacy}","received_events_url":"https://api.github.com/users/oakey-b1/received_events","type":"User","site_admin":false},"repo":{"id":43434651,"name":"horde","full_name":"oakey-b1/horde","owner":{"login":"oakey-b1","id":14907501,"avatar_url":"https://avatars.githubusercontent.com/u/14907501?v=3","gravatar_id":"","url":"https://api.github.com/users/oakey-b1","html_url":"https://github.com/oakey-b1","followers_url":"https://api.github.com/users/oakey-b1/followers","following_url":"https://api.github.com/users/oakey-b1/following{/other_user}","gists_url":"https://api.github.com/users/oakey-b1/gists{/gist_id}","starred_url":"https://api.github.com/users/oakey-b1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oakey-b1/subscriptions","organizations_url":"https://api.github.com/users/oakey-b1/orgs","repos_url":"https://api.github.com/users/oakey-b1/repos","events_url":"https://api.github.com/users/oakey-b1/events{/privacy}","received_events_url":"https://api.github.com/users/oakey-b1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oakey-b1/horde","description":"Horde","fork":true,"url":"https://api.github.com/repos/oakey-b1/horde","forks_url":"https://api.github.com/repos/oakey-b1/horde/forks","keys_url":"https://api.github.com/repos/oakey-b1/horde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oakey-b1/horde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oakey-b1/horde/teams","hooks_url":"https://api.github.com/repos/oakey-b1/horde/hooks","issue_events_url":"https://api.github.com/repos/oakey-b1/horde/issues/events{/number}","events_url":"https://api.github.com/repos/oakey-b1/horde/events","assignees_url":"https://api.github.com/repos/oakey-b1/horde/assignees{/user}","branches_url":"https://api.github.com/repos/oakey-b1/horde/branches{/branch}","tags_url":"https://api.github.com/repos/oakey-b1/horde/tags","blobs_url":"https://api.github.com/repos/oakey-b1/horde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oakey-b1/horde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oakey-b1/horde/git/refs{/sha}","trees_url":"https://api.github.com/repos/oakey-b1/horde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oakey-b1/horde/statuses/{sha}","languages_url":"https://api.github.com/repos/oakey-b1/horde/languages","stargazers_url":"https://api.github.com/repos/oakey-b1/horde/stargazers","contributors_url":"https://api.github.com/repos/oakey-b1/horde/contributors","subscribers_url":"https://api.github.com/repos/oakey-b1/horde/subscribers","subscription_url":"https://api.github.com/repos/oakey-b1/horde/subscription","commits_url":"https://api.github.com/repos/oakey-b1/horde/commits{/sha}","git_commits_url":"https://api.github.com/repos/oakey-b1/horde/git/commits{/sha}","comments_url":"https://api.github.com/repos/oakey-b1/horde/comments{/number}","issue_comment_url":"https://api.github.com/repos/oakey-b1/horde/issues/comments{/number}","contents_url":"https://api.github.com/repos/oakey-b1/horde/contents/{+path}","compare_url":"https://api.github.com/repos/oakey-b1/horde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oakey-b1/horde/merges","archive_url":"https://api.github.com/repos/oakey-b1/horde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oakey-b1/horde/downloads","issues_url":"https://api.github.com/repos/oakey-b1/horde/issues{/number}","pulls_url":"https://api.github.com/repos/oakey-b1/horde/pulls{/number}","milestones_url":"https://api.github.com/repos/oakey-b1/horde/milestones{/number}","notifications_url":"https://api.github.com/repos/oakey-b1/horde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oakey-b1/horde/labels{/name}","releases_url":"https://api.github.com/repos/oakey-b1/horde/releases{/id}","deployments_url":"https://api.github.com/repos/oakey-b1/horde/deployments","created_at":"2015-09-30T13:31:13Z","updated_at":"2016-01-25T10:37:41Z","pushed_at":"2016-07-25T11:00:57Z","git_url":"git://github.com/oakey-b1/horde.git","ssh_url":"git@github.com:oakey-b1/horde.git","clone_url":"https://github.com/oakey-b1/horde.git","svn_url":"https://github.com/oakey-b1/horde","homepage":"http://www.horde.org/","size":296777,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"horde:master","ref":"master","sha":"4dd237461472a546065dee2a8a2332030dc4e766","user":{"login":"horde","id":379293,"avatar_url":"https://avatars.githubusercontent.com/u/379293?v=3","gravatar_id":"","url":"https://api.github.com/users/horde","html_url":"https://github.com/horde","followers_url":"https://api.github.com/users/horde/followers","following_url":"https://api.github.com/users/horde/following{/other_user}","gists_url":"https://api.github.com/users/horde/gists{/gist_id}","starred_url":"https://api.github.com/users/horde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horde/subscriptions","organizations_url":"https://api.github.com/users/horde/orgs","repos_url":"https://api.github.com/users/horde/repos","events_url":"https://api.github.com/users/horde/events{/privacy}","received_events_url":"https://api.github.com/users/horde/received_events","type":"Organization","site_admin":false},"repo":{"id":869096,"name":"horde","full_name":"horde/horde","owner":{"login":"horde","id":379293,"avatar_url":"https://avatars.githubusercontent.com/u/379293?v=3","gravatar_id":"","url":"https://api.github.com/users/horde","html_url":"https://github.com/horde","followers_url":"https://api.github.com/users/horde/followers","following_url":"https://api.github.com/users/horde/following{/other_user}","gists_url":"https://api.github.com/users/horde/gists{/gist_id}","starred_url":"https://api.github.com/users/horde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/horde/subscriptions","organizations_url":"https://api.github.com/users/horde/orgs","repos_url":"https://api.github.com/users/horde/repos","events_url":"https://api.github.com/users/horde/events{/privacy}","received_events_url":"https://api.github.com/users/horde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/horde/horde","description":"Horde","fork":false,"url":"https://api.github.com/repos/horde/horde","forks_url":"https://api.github.com/repos/horde/horde/forks","keys_url":"https://api.github.com/repos/horde/horde/keys{/key_id}","collaborators_url":"https://api.github.com/repos/horde/horde/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/horde/horde/teams","hooks_url":"https://api.github.com/repos/horde/horde/hooks","issue_events_url":"https://api.github.com/repos/horde/horde/issues/events{/number}","events_url":"https://api.github.com/repos/horde/horde/events","assignees_url":"https://api.github.com/repos/horde/horde/assignees{/user}","branches_url":"https://api.github.com/repos/horde/horde/branches{/branch}","tags_url":"https://api.github.com/repos/horde/horde/tags","blobs_url":"https://api.github.com/repos/horde/horde/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/horde/horde/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/horde/horde/git/refs{/sha}","trees_url":"https://api.github.com/repos/horde/horde/git/trees{/sha}","statuses_url":"https://api.github.com/repos/horde/horde/statuses/{sha}","languages_url":"https://api.github.com/repos/horde/horde/languages","stargazers_url":"https://api.github.com/repos/horde/horde/stargazers","contributors_url":"https://api.github.com/repos/horde/horde/contributors","subscribers_url":"https://api.github.com/repos/horde/horde/subscribers","subscription_url":"https://api.github.com/repos/horde/horde/subscription","commits_url":"https://api.github.com/repos/horde/horde/commits{/sha}","git_commits_url":"https://api.github.com/repos/horde/horde/git/commits{/sha}","comments_url":"https://api.github.com/repos/horde/horde/comments{/number}","issue_comment_url":"https://api.github.com/repos/horde/horde/issues/comments{/number}","contents_url":"https://api.github.com/repos/horde/horde/contents/{+path}","compare_url":"https://api.github.com/repos/horde/horde/compare/{base}...{head}","merges_url":"https://api.github.com/repos/horde/horde/merges","archive_url":"https://api.github.com/repos/horde/horde/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/horde/horde/downloads","issues_url":"https://api.github.com/repos/horde/horde/issues{/number}","pulls_url":"https://api.github.com/repos/horde/horde/pulls{/number}","milestones_url":"https://api.github.com/repos/horde/horde/milestones{/number}","notifications_url":"https://api.github.com/repos/horde/horde/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/horde/horde/labels{/name}","releases_url":"https://api.github.com/repos/horde/horde/releases{/id}","deployments_url":"https://api.github.com/repos/horde/horde/deployments","created_at":"2010-08-28T22:06:38Z","updated_at":"2016-07-18T12:54:19Z","pushed_at":"2016-07-25T11:00:58Z","git_url":"git://github.com/horde/horde.git","ssh_url":"git@github.com:horde/horde.git","clone_url":"https://github.com/horde/horde.git","svn_url":"https://github.com/horde/horde","homepage":"http://www.horde.org/","size":381412,"stargazers_count":216,"watchers_count":216,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":8,"forks":128,"open_issues":8,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/horde/horde/pulls/198"},"html":{"href":"https://github.com/horde/horde/pull/198"},"issue":{"href":"https://api.github.com/repos/horde/horde/issues/198"},"comments":{"href":"https://api.github.com/repos/horde/horde/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/horde/horde/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/horde/horde/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/horde/horde/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/horde/horde/statuses/ad09a14722d6c40abd844aa91a01c4c7f3aca893"}}}}
{"actor":{"display_login":"oakey-b1"}}