{"action":"created","comment":{"url":"https://api.github.com/repos/istanbuljs/nyc/pulls/comments/83557633","pull_request_review_id":4394478,"id":83557633,"diff_hunk":"@@ -460,7 +460,24 @@ NYC.prototype.checkCoverage = function (thresholds) {\n }\n \n NYC.prototype._loadProcessInfoTree = function () {\n-  return ProcessInfo.buildProcessTree(this._loadProcessInfos())\n+  var _this = this\n+  var processTree = ProcessInfo.buildProcessTree(this._loadProcessInfos())","path":"index.js","position":6,"original_position":6,"commit_id":"ce440a9d1595d0dee2bf96325efb551ea73f7621","original_commit_id":"ce440a9d1595d0dee2bf96325efb551ea73f7621","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"body":"I'd be tempted to encapsulate this logic inside `process.js`; and all that `index.js` would need to do would be:\r\n\r\n`console.log(processInfo.render())`.","created_at":"2016-10-16T18:58:30Z","updated_at":"2016-10-16T19:01:26Z","html_url":"https://github.com/istanbuljs/nyc/pull/416#discussion_r83557633","pull_request_url":"https://api.github.com/repos/istanbuljs/nyc/pulls/416","_links":{"self":{"href":"https://api.github.com/repos/istanbuljs/nyc/pulls/comments/83557633"},"html":{"href":"https://github.com/istanbuljs/nyc/pull/416#discussion_r83557633"},"pull_request":{"href":"https://api.github.com/repos/istanbuljs/nyc/pulls/416"}}},"pull_request":{"url":"https://api.github.com/repos/istanbuljs/nyc/pulls/416","id":88548790,"html_url":"https://github.com/istanbuljs/nyc/pull/416","diff_url":"https://github.com/istanbuljs/nyc/pull/416.diff","patch_url":"https://github.com/istanbuljs/nyc/pull/416.patch","issue_url":"https://api.github.com/repos/istanbuljs/nyc/issues/416","number":416,"state":"open","locked":false,"title":"feat: implement coverage details for process tree","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"body":"Show line coverage for each subtree of the tree of spawned processes.\r\n\r\nThis is just a start, but while I definitely wanted to begin working in that direction as planned, I’m not too certain about how this is best implemented when it comes to visual display… In theory, a full per-file coverage table could be shown for each subtree, but that seems like overkill, so I’ve just implemented something small. Also, maybe printing this extra information should be optional/configurable, too?\r\n\r\nWhat do you think?","created_at":"2016-10-08T15:15:20Z","updated_at":"2016-10-16T19:01:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b112203a5c39577f794a4962b6f51685fdd3bb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istanbuljs/nyc/pulls/416/commits","review_comments_url":"https://api.github.com/repos/istanbuljs/nyc/pulls/416/comments","review_comment_url":"https://api.github.com/repos/istanbuljs/nyc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istanbuljs/nyc/issues/416/comments","statuses_url":"https://api.github.com/repos/istanbuljs/nyc/statuses/ce440a9d1595d0dee2bf96325efb551ea73f7621","head":{"label":"addaleax:process-tree-per-subtree-coverage","ref":"process-tree-per-subtree-coverage","sha":"ce440a9d1595d0dee2bf96325efb551ea73f7621","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"repo":{"id":55301884,"name":"nyc","full_name":"addaleax/nyc","owner":{"login":"addaleax","id":899444,"avatar_url":"https://avatars.githubusercontent.com/u/899444?v=3","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/addaleax/nyc","description":"a code coverage tool that works well with subprocesses.","fork":true,"url":"https://api.github.com/repos/addaleax/nyc","forks_url":"https://api.github.com/repos/addaleax/nyc/forks","keys_url":"https://api.github.com/repos/addaleax/nyc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addaleax/nyc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addaleax/nyc/teams","hooks_url":"https://api.github.com/repos/addaleax/nyc/hooks","issue_events_url":"https://api.github.com/repos/addaleax/nyc/issues/events{/number}","events_url":"https://api.github.com/repos/addaleax/nyc/events","assignees_url":"https://api.github.com/repos/addaleax/nyc/assignees{/user}","branches_url":"https://api.github.com/repos/addaleax/nyc/branches{/branch}","tags_url":"https://api.github.com/repos/addaleax/nyc/tags","blobs_url":"https://api.github.com/repos/addaleax/nyc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addaleax/nyc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addaleax/nyc/git/refs{/sha}","trees_url":"https://api.github.com/repos/addaleax/nyc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addaleax/nyc/statuses/{sha}","languages_url":"https://api.github.com/repos/addaleax/nyc/languages","stargazers_url":"https://api.github.com/repos/addaleax/nyc/stargazers","contributors_url":"https://api.github.com/repos/addaleax/nyc/contributors","subscribers_url":"https://api.github.com/repos/addaleax/nyc/subscribers","subscription_url":"https://api.github.com/repos/addaleax/nyc/subscription","commits_url":"https://api.github.com/repos/addaleax/nyc/commits{/sha}","git_commits_url":"https://api.github.com/repos/addaleax/nyc/git/commits{/sha}","comments_url":"https://api.github.com/repos/addaleax/nyc/comments{/number}","issue_comment_url":"https://api.github.com/repos/addaleax/nyc/issues/comments{/number}","contents_url":"https://api.github.com/repos/addaleax/nyc/contents/{+path}","compare_url":"https://api.github.com/repos/addaleax/nyc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addaleax/nyc/merges","archive_url":"https://api.github.com/repos/addaleax/nyc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addaleax/nyc/downloads","issues_url":"https://api.github.com/repos/addaleax/nyc/issues{/number}","pulls_url":"https://api.github.com/repos/addaleax/nyc/pulls{/number}","milestones_url":"https://api.github.com/repos/addaleax/nyc/milestones{/number}","notifications_url":"https://api.github.com/repos/addaleax/nyc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addaleax/nyc/labels{/name}","releases_url":"https://api.github.com/repos/addaleax/nyc/releases{/id}","deployments_url":"https://api.github.com/repos/addaleax/nyc/deployments","created_at":"2016-04-02T15:32:31Z","updated_at":"2016-04-02T15:32:32Z","pushed_at":"2016-10-08T15:10:19Z","git_url":"git://github.com/addaleax/nyc.git","ssh_url":"git@github.com:addaleax/nyc.git","clone_url":"https://github.com/addaleax/nyc.git","svn_url":"https://github.com/addaleax/nyc","homepage":"","size":933,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istanbuljs:master","ref":"master","sha":"fad3586cae6ab7f272a2ea5824430c8f9f2a3f9a","user":{"login":"istanbuljs","id":13523395,"avatar_url":"https://avatars.githubusercontent.com/u/13523395?v=3","gravatar_id":"","url":"https://api.github.com/users/istanbuljs","html_url":"https://github.com/istanbuljs","followers_url":"https://api.github.com/users/istanbuljs/followers","following_url":"https://api.github.com/users/istanbuljs/following{/other_user}","gists_url":"https://api.github.com/users/istanbuljs/gists{/gist_id}","starred_url":"https://api.github.com/users/istanbuljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanbuljs/subscriptions","organizations_url":"https://api.github.com/users/istanbuljs/orgs","repos_url":"https://api.github.com/users/istanbuljs/repos","events_url":"https://api.github.com/users/istanbuljs/events{/privacy}","received_events_url":"https://api.github.com/users/istanbuljs/received_events","type":"Organization","site_admin":false},"repo":{"id":35312458,"name":"nyc","full_name":"istanbuljs/nyc","owner":{"login":"istanbuljs","id":13523395,"avatar_url":"https://avatars.githubusercontent.com/u/13523395?v=3","gravatar_id":"","url":"https://api.github.com/users/istanbuljs","html_url":"https://github.com/istanbuljs","followers_url":"https://api.github.com/users/istanbuljs/followers","following_url":"https://api.github.com/users/istanbuljs/following{/other_user}","gists_url":"https://api.github.com/users/istanbuljs/gists{/gist_id}","starred_url":"https://api.github.com/users/istanbuljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanbuljs/subscriptions","organizations_url":"https://api.github.com/users/istanbuljs/orgs","repos_url":"https://api.github.com/users/istanbuljs/repos","events_url":"https://api.github.com/users/istanbuljs/events{/privacy}","received_events_url":"https://api.github.com/users/istanbuljs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istanbuljs/nyc","description":"the Istanbul command line interface","fork":false,"url":"https://api.github.com/repos/istanbuljs/nyc","forks_url":"https://api.github.com/repos/istanbuljs/nyc/forks","keys_url":"https://api.github.com/repos/istanbuljs/nyc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istanbuljs/nyc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istanbuljs/nyc/teams","hooks_url":"https://api.github.com/repos/istanbuljs/nyc/hooks","issue_events_url":"https://api.github.com/repos/istanbuljs/nyc/issues/events{/number}","events_url":"https://api.github.com/repos/istanbuljs/nyc/events","assignees_url":"https://api.github.com/repos/istanbuljs/nyc/assignees{/user}","branches_url":"https://api.github.com/repos/istanbuljs/nyc/branches{/branch}","tags_url":"https://api.github.com/repos/istanbuljs/nyc/tags","blobs_url":"https://api.github.com/repos/istanbuljs/nyc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istanbuljs/nyc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istanbuljs/nyc/git/refs{/sha}","trees_url":"https://api.github.com/repos/istanbuljs/nyc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istanbuljs/nyc/statuses/{sha}","languages_url":"https://api.github.com/repos/istanbuljs/nyc/languages","stargazers_url":"https://api.github.com/repos/istanbuljs/nyc/stargazers","contributors_url":"https://api.github.com/repos/istanbuljs/nyc/contributors","subscribers_url":"https://api.github.com/repos/istanbuljs/nyc/subscribers","subscription_url":"https://api.github.com/repos/istanbuljs/nyc/subscription","commits_url":"https://api.github.com/repos/istanbuljs/nyc/commits{/sha}","git_commits_url":"https://api.github.com/repos/istanbuljs/nyc/git/commits{/sha}","comments_url":"https://api.github.com/repos/istanbuljs/nyc/comments{/number}","issue_comment_url":"https://api.github.com/repos/istanbuljs/nyc/issues/comments{/number}","contents_url":"https://api.github.com/repos/istanbuljs/nyc/contents/{+path}","compare_url":"https://api.github.com/repos/istanbuljs/nyc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istanbuljs/nyc/merges","archive_url":"https://api.github.com/repos/istanbuljs/nyc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istanbuljs/nyc/downloads","issues_url":"https://api.github.com/repos/istanbuljs/nyc/issues{/number}","pulls_url":"https://api.github.com/repos/istanbuljs/nyc/pulls{/number}","milestones_url":"https://api.github.com/repos/istanbuljs/nyc/milestones{/number}","notifications_url":"https://api.github.com/repos/istanbuljs/nyc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istanbuljs/nyc/labels{/name}","releases_url":"https://api.github.com/repos/istanbuljs/nyc/releases{/id}","deployments_url":"https://api.github.com/repos/istanbuljs/nyc/deployments","created_at":"2015-05-09T02:55:45Z","updated_at":"2016-10-16T15:49:25Z","pushed_at":"2016-10-16T18:40:25Z","git_url":"git://github.com/istanbuljs/nyc.git","ssh_url":"git@github.com:istanbuljs/nyc.git","clone_url":"https://github.com/istanbuljs/nyc.git","svn_url":"https://github.com/istanbuljs/nyc","homepage":"https://istanbul.js.org/","size":1065,"stargazers_count":928,"watchers_count":928,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"open_issues_count":40,"forks":57,"open_issues":40,"watchers":928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istanbuljs/nyc/pulls/416"},"html":{"href":"https://github.com/istanbuljs/nyc/pull/416"},"issue":{"href":"https://api.github.com/repos/istanbuljs/nyc/issues/416"},"comments":{"href":"https://api.github.com/repos/istanbuljs/nyc/issues/416/comments"},"review_comments":{"href":"https://api.github.com/repos/istanbuljs/nyc/pulls/416/comments"},"review_comment":{"href":"https://api.github.com/repos/istanbuljs/nyc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istanbuljs/nyc/pulls/416/commits"},"statuses":{"href":"https://api.github.com/repos/istanbuljs/nyc/statuses/ce440a9d1595d0dee2bf96325efb551ea73f7621"}}}}
{"actor":{"display_login":"bcoe"}}