{"action":"created","comment":{"url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/comments/63908116","id":63908116,"diff_hunk":"@@ -1,23 +1,39 @@\n import 'package:angular2/core.dart';\n+import 'package:angular2/common.dart';\n import 'package:angular2/router.dart';\n \n import 'package:angular2_material/src/components/button/button.dart';\n import 'package:SmartPeopleUI/shared/index.dart';\n \n-import 'package:SmartPeopleUI/shared/directives/index.dart';\n-\n @Component(\n     selector: 'change-password',\n     directives: const [\n        ROUTER_DIRECTIVES,\n-       PasswordValidatorDirective,\n+       ValidationNotificationComponent,\n        MdAnchor,\n        InfoComponent\n     ],\n     templateUrl: 'change-password.component.html',\n+    encapsulation: ViewEncapsulation.Native, //TODO it is temporary, in further should remove and avoid\n     styleUrls: const['change-password.component.css'])\n \n class ChangePasswordComponent {\n-   String password1;\n-   String password2;\n+   ControlGroup form;\n+   Map<String, String> messages;\n+\n+   isValid(String control) => form.controls[control].untouched  || form.controls[control].valid;\n+\n+   ChangePasswordComponent() {\n+\n+      this.form = new ControlGroup({\n+         'password': new Control('', Validators.compose([PasswordValidator.validate, Validators.required])),\n+         'passwordRepeat': new Control('', Validators.compose([PasswordValidator.validate, Validators.required])),\n+      });\n+\n+      this.messages = {\n+         'password': 'Password is required',","path":"lib/account/change-password/change-password.component.dart","position":39,"original_position":39,"commit_id":"eaba2bc52025ec4aa584618858ebe073f8b65603","original_commit_id":"eaba2bc52025ec4aa584618858ebe073f8b65603","user":{"login":"sanya-terror","id":13321132,"avatar_url":"https://avatars.githubusercontent.com/u/13321132?v=3","gravatar_id":"","url":"https://api.github.com/users/sanya-terror","html_url":"https://github.com/sanya-terror","followers_url":"https://api.github.com/users/sanya-terror/followers","following_url":"https://api.github.com/users/sanya-terror/following{/other_user}","gists_url":"https://api.github.com/users/sanya-terror/gists{/gist_id}","starred_url":"https://api.github.com/users/sanya-terror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanya-terror/subscriptions","organizations_url":"https://api.github.com/users/sanya-terror/orgs","repos_url":"https://api.github.com/users/sanya-terror/repos","events_url":"https://api.github.com/users/sanya-terror/events{/privacy}","received_events_url":"https://api.github.com/users/sanya-terror/received_events","type":"User","site_admin":false},"body":"@Ne4istb anyway, I think all messages ought to be dynamic, as \"Too short length\" or \"Too long length\", or \"Incorrect input value\" or smth like that. I think it make sence, isn't it?","created_at":"2016-05-19T16:11:48Z","updated_at":"2016-05-19T16:11:48Z","html_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI/pull/5#discussion_r63908116","pull_request_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/comments/63908116"},"html":{"href":"https://github.com/SmartPeopleCompany/SmartPeopleUI/pull/5#discussion_r63908116"},"pull_request":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5","id":70683221,"html_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI/pull/5","diff_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI/pull/5.diff","patch_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI/pull/5.patch","issue_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/5","number":5,"state":"open","locked":false,"title":"[SP-49] Created validation for Change Password form","user":{"login":"sanya-terror","id":13321132,"avatar_url":"https://avatars.githubusercontent.com/u/13321132?v=3","gravatar_id":"","url":"https://api.github.com/users/sanya-terror","html_url":"https://github.com/sanya-terror","followers_url":"https://api.github.com/users/sanya-terror/followers","following_url":"https://api.github.com/users/sanya-terror/following{/other_user}","gists_url":"https://api.github.com/users/sanya-terror/gists{/gist_id}","starred_url":"https://api.github.com/users/sanya-terror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanya-terror/subscriptions","organizations_url":"https://api.github.com/users/sanya-terror/orgs","repos_url":"https://api.github.com/users/sanya-terror/repos","events_url":"https://api.github.com/users/sanya-terror/events{/privacy}","received_events_url":"https://api.github.com/users/sanya-terror/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-05-19T12:12:47Z","updated_at":"2016-05-19T16:11:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d87087c6e12a7a233fcf52b18abf41b20a9f9dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5/commits","review_comments_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5/comments","review_comment_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/5/comments","statuses_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/statuses/eaba2bc52025ec4aa584618858ebe073f8b65603","head":{"label":"SmartPeopleCompany:FET-SP-49","ref":"FET-SP-49","sha":"eaba2bc52025ec4aa584618858ebe073f8b65603","user":{"login":"SmartPeopleCompany","id":19351660,"avatar_url":"https://avatars.githubusercontent.com/u/19351660?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartPeopleCompany","html_url":"https://github.com/SmartPeopleCompany","followers_url":"https://api.github.com/users/SmartPeopleCompany/followers","following_url":"https://api.github.com/users/SmartPeopleCompany/following{/other_user}","gists_url":"https://api.github.com/users/SmartPeopleCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartPeopleCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartPeopleCompany/subscriptions","organizations_url":"https://api.github.com/users/SmartPeopleCompany/orgs","repos_url":"https://api.github.com/users/SmartPeopleCompany/repos","events_url":"https://api.github.com/users/SmartPeopleCompany/events{/privacy}","received_events_url":"https://api.github.com/users/SmartPeopleCompany/received_events","type":"Organization","site_admin":false},"repo":{"id":58765292,"name":"SmartPeopleUI","full_name":"SmartPeopleCompany/SmartPeopleUI","owner":{"login":"SmartPeopleCompany","id":19351660,"avatar_url":"https://avatars.githubusercontent.com/u/19351660?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartPeopleCompany","html_url":"https://github.com/SmartPeopleCompany","followers_url":"https://api.github.com/users/SmartPeopleCompany/followers","following_url":"https://api.github.com/users/SmartPeopleCompany/following{/other_user}","gists_url":"https://api.github.com/users/SmartPeopleCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartPeopleCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartPeopleCompany/subscriptions","organizations_url":"https://api.github.com/users/SmartPeopleCompany/orgs","repos_url":"https://api.github.com/users/SmartPeopleCompany/repos","events_url":"https://api.github.com/users/SmartPeopleCompany/events{/privacy}","received_events_url":"https://api.github.com/users/SmartPeopleCompany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI","description":"","fork":false,"url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI","forks_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/forks","keys_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/teams","hooks_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/hooks","issue_events_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/events{/number}","events_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/events","assignees_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/assignees{/user}","branches_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/branches{/branch}","tags_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/tags","blobs_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/languages","stargazers_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/stargazers","contributors_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/contributors","subscribers_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/subscribers","subscription_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/subscription","commits_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/contents/{+path}","compare_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/merges","archive_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/downloads","issues_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues{/number}","pulls_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/labels{/name}","releases_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/releases{/id}","deployments_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/deployments","created_at":"2016-05-13T18:58:34Z","updated_at":"2016-05-19T11:07:38Z","pushed_at":"2016-05-19T12:12:48Z","git_url":"git://github.com/SmartPeopleCompany/SmartPeopleUI.git","ssh_url":"git@github.com:SmartPeopleCompany/SmartPeopleUI.git","clone_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI.git","svn_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI","homepage":"http://www.smartpeople.in.ua","size":6052,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"SmartPeopleCompany:SP-phase-1-rewriting-front-end-on-dart-angular2.0","ref":"SP-phase-1-rewriting-front-end-on-dart-angular2.0","sha":"b9a047320c9e9ea724c7b554b171ec1c616dd501","user":{"login":"SmartPeopleCompany","id":19351660,"avatar_url":"https://avatars.githubusercontent.com/u/19351660?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartPeopleCompany","html_url":"https://github.com/SmartPeopleCompany","followers_url":"https://api.github.com/users/SmartPeopleCompany/followers","following_url":"https://api.github.com/users/SmartPeopleCompany/following{/other_user}","gists_url":"https://api.github.com/users/SmartPeopleCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartPeopleCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartPeopleCompany/subscriptions","organizations_url":"https://api.github.com/users/SmartPeopleCompany/orgs","repos_url":"https://api.github.com/users/SmartPeopleCompany/repos","events_url":"https://api.github.com/users/SmartPeopleCompany/events{/privacy}","received_events_url":"https://api.github.com/users/SmartPeopleCompany/received_events","type":"Organization","site_admin":false},"repo":{"id":58765292,"name":"SmartPeopleUI","full_name":"SmartPeopleCompany/SmartPeopleUI","owner":{"login":"SmartPeopleCompany","id":19351660,"avatar_url":"https://avatars.githubusercontent.com/u/19351660?v=3","gravatar_id":"","url":"https://api.github.com/users/SmartPeopleCompany","html_url":"https://github.com/SmartPeopleCompany","followers_url":"https://api.github.com/users/SmartPeopleCompany/followers","following_url":"https://api.github.com/users/SmartPeopleCompany/following{/other_user}","gists_url":"https://api.github.com/users/SmartPeopleCompany/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartPeopleCompany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartPeopleCompany/subscriptions","organizations_url":"https://api.github.com/users/SmartPeopleCompany/orgs","repos_url":"https://api.github.com/users/SmartPeopleCompany/repos","events_url":"https://api.github.com/users/SmartPeopleCompany/events{/privacy}","received_events_url":"https://api.github.com/users/SmartPeopleCompany/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI","description":"","fork":false,"url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI","forks_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/forks","keys_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/teams","hooks_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/hooks","issue_events_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/events{/number}","events_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/events","assignees_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/assignees{/user}","branches_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/branches{/branch}","tags_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/tags","blobs_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/languages","stargazers_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/stargazers","contributors_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/contributors","subscribers_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/subscribers","subscription_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/subscription","commits_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/contents/{+path}","compare_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/merges","archive_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/downloads","issues_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues{/number}","pulls_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/labels{/name}","releases_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/releases{/id}","deployments_url":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/deployments","created_at":"2016-05-13T18:58:34Z","updated_at":"2016-05-19T11:07:38Z","pushed_at":"2016-05-19T12:12:48Z","git_url":"git://github.com/SmartPeopleCompany/SmartPeopleUI.git","ssh_url":"git@github.com:SmartPeopleCompany/SmartPeopleUI.git","clone_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI.git","svn_url":"https://github.com/SmartPeopleCompany/SmartPeopleUI","homepage":"http://www.smartpeople.in.ua","size":6052,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5"},"html":{"href":"https://github.com/SmartPeopleCompany/SmartPeopleUI/pull/5"},"issue":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/5"},"comments":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/SmartPeopleCompany/SmartPeopleUI/statuses/eaba2bc52025ec4aa584618858ebe073f8b65603"}}}}