{"action":"closed","number":1293,"pull_request":{"url":"https://api.github.com/repos/obspy/obspy/pulls/1293","id":61722799,"html_url":"https://github.com/obspy/obspy/pull/1293","diff_url":"https://github.com/obspy/obspy/pull/1293.diff","patch_url":"https://github.com/obspy/obspy/pull/1293.patch","issue_url":"https://api.github.com/repos/obspy/obspy/issues/1293","number":1293,"state":"closed","locked":false,"title":"Function arguments which expect tuple are error prone with silent failures.","user":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"body":"The crux is that a tuple with a single item requires a comma after the item\r\n```\r\ntype(('ex'))\r\n<type 'str'>\r\ntype(('ex',))\r\n<type 'tuple'>\r\n```\r\nIf a function expects a tuple, but is passes a single iterable in () without a trailing comma, the single iterable is iterated over instead of the single item.\r\nExamples:\r\nGOOD: `fdsn.mass_downloader.Restrictions(... ,channel_priorities=(\"LH[ZNE]\",), ...)`\r\nGOOD:`fdsn.mass_downloader.Restrictions(... ,channel_priorities=(\"LH[ZNE]\",\"BH[ZNE]\"), ...)`\r\nBAD:`fdsn.mass_downloader.Restrictions(... ,channel_priorities=(\"LH[ZNE]\"), ...)`\r\n        Iterates over string e.g.  Z,H,[,...\r\n\r\nbtw: the same thing happens with taup when using e.g. `phase_list = ('PKKP')` it starts looking for 'P', 'K', 'K', 'P' .","created_at":"2016-03-04T15:00:04Z","updated_at":"2016-03-04T17:24:53Z","closed_at":"2016-03-04T17:24:53Z","merged_at":"2016-03-04T17:24:53Z","merge_commit_sha":"4521259e973cdba45777bd59d37292784ffb51d5","assignee":null,"milestone":{"url":"https://api.github.com/repos/obspy/obspy/milestones/13","html_url":"https://github.com/obspy/obspy/milestones/1.0.x","labels_url":"https://api.github.com/repos/obspy/obspy/milestones/13/labels","id":1383705,"number":13,"title":"1.0.x","description":"","creator":{"login":"megies","id":1842780,"avatar_url":"https://avatars.githubusercontent.com/u/1842780?v=3","gravatar_id":"","url":"https://api.github.com/users/megies","html_url":"https://github.com/megies","followers_url":"https://api.github.com/users/megies/followers","following_url":"https://api.github.com/users/megies/following{/other_user}","gists_url":"https://api.github.com/users/megies/gists{/gist_id}","starred_url":"https://api.github.com/users/megies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/megies/subscriptions","organizations_url":"https://api.github.com/users/megies/orgs","repos_url":"https://api.github.com/users/megies/repos","events_url":"https://api.github.com/users/megies/events{/privacy}","received_events_url":"https://api.github.com/users/megies/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":12,"state":"open","created_at":"2015-10-29T15:43:09Z","updated_at":"2016-03-04T17:24:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/obspy/obspy/pulls/1293/commits","review_comments_url":"https://api.github.com/repos/obspy/obspy/pulls/1293/comments","review_comment_url":"https://api.github.com/repos/obspy/obspy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/obspy/obspy/issues/1293/comments","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/330657bf0aa0c9ff57f03001ca6979da051bd077","head":{"label":"krischer:less-error-prone-mass-downloader","ref":"less-error-prone-mass-downloader","sha":"330657bf0aa0c9ff57f03001ca6979da051bd077","user":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"repo":{"id":5830460,"name":"obspy","full_name":"krischer/obspy","owner":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krischer/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":true,"url":"https://api.github.com/repos/krischer/obspy","forks_url":"https://api.github.com/repos/krischer/obspy/forks","keys_url":"https://api.github.com/repos/krischer/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krischer/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krischer/obspy/teams","hooks_url":"https://api.github.com/repos/krischer/obspy/hooks","issue_events_url":"https://api.github.com/repos/krischer/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/krischer/obspy/events","assignees_url":"https://api.github.com/repos/krischer/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/krischer/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/krischer/obspy/tags","blobs_url":"https://api.github.com/repos/krischer/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krischer/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krischer/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/krischer/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krischer/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/krischer/obspy/languages","stargazers_url":"https://api.github.com/repos/krischer/obspy/stargazers","contributors_url":"https://api.github.com/repos/krischer/obspy/contributors","subscribers_url":"https://api.github.com/repos/krischer/obspy/subscribers","subscription_url":"https://api.github.com/repos/krischer/obspy/subscription","commits_url":"https://api.github.com/repos/krischer/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/krischer/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/krischer/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/krischer/obspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/krischer/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/krischer/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krischer/obspy/merges","archive_url":"https://api.github.com/repos/krischer/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krischer/obspy/downloads","issues_url":"https://api.github.com/repos/krischer/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/krischer/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/krischer/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/krischer/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krischer/obspy/labels{/name}","releases_url":"https://api.github.com/repos/krischer/obspy/releases{/id}","deployments_url":"https://api.github.com/repos/krischer/obspy/deployments","created_at":"2012-09-16T15:34:42Z","updated_at":"2014-11-20T12:15:18Z","pushed_at":"2016-03-04T14:57:31Z","git_url":"git://github.com/krischer/obspy.git","ssh_url":"git@github.com:krischer/obspy.git","clone_url":"https://github.com/krischer/obspy.git","svn_url":"https://github.com/krischer/obspy","homepage":"https://github.com/obspy/obspy/wiki","size":77083,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"obspy:maintenance_1.0.x","ref":"maintenance_1.0.x","sha":"020d0434b2899be7a36707d156926f5ac83b02cc","user":{"login":"obspy","id":1701221,"avatar_url":"https://avatars.githubusercontent.com/u/1701221?v=3","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"repo":{"id":5731348,"name":"obspy","full_name":"obspy/obspy","owner":{"login":"obspy","id":1701221,"avatar_url":"https://avatars.githubusercontent.com/u/1701221?v=3","gravatar_id":"","url":"https://api.github.com/users/obspy","html_url":"https://github.com/obspy","followers_url":"https://api.github.com/users/obspy/followers","following_url":"https://api.github.com/users/obspy/following{/other_user}","gists_url":"https://api.github.com/users/obspy/gists{/gist_id}","starred_url":"https://api.github.com/users/obspy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obspy/subscriptions","organizations_url":"https://api.github.com/users/obspy/orgs","repos_url":"https://api.github.com/users/obspy/repos","events_url":"https://api.github.com/users/obspy/events{/privacy}","received_events_url":"https://api.github.com/users/obspy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/obspy/obspy","description":"ObsPy: A Python Toolbox for seismology/seismological observatories.","fork":false,"url":"https://api.github.com/repos/obspy/obspy","forks_url":"https://api.github.com/repos/obspy/obspy/forks","keys_url":"https://api.github.com/repos/obspy/obspy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obspy/obspy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obspy/obspy/teams","hooks_url":"https://api.github.com/repos/obspy/obspy/hooks","issue_events_url":"https://api.github.com/repos/obspy/obspy/issues/events{/number}","events_url":"https://api.github.com/repos/obspy/obspy/events","assignees_url":"https://api.github.com/repos/obspy/obspy/assignees{/user}","branches_url":"https://api.github.com/repos/obspy/obspy/branches{/branch}","tags_url":"https://api.github.com/repos/obspy/obspy/tags","blobs_url":"https://api.github.com/repos/obspy/obspy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obspy/obspy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obspy/obspy/git/refs{/sha}","trees_url":"https://api.github.com/repos/obspy/obspy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obspy/obspy/statuses/{sha}","languages_url":"https://api.github.com/repos/obspy/obspy/languages","stargazers_url":"https://api.github.com/repos/obspy/obspy/stargazers","contributors_url":"https://api.github.com/repos/obspy/obspy/contributors","subscribers_url":"https://api.github.com/repos/obspy/obspy/subscribers","subscription_url":"https://api.github.com/repos/obspy/obspy/subscription","commits_url":"https://api.github.com/repos/obspy/obspy/commits{/sha}","git_commits_url":"https://api.github.com/repos/obspy/obspy/git/commits{/sha}","comments_url":"https://api.github.com/repos/obspy/obspy/comments{/number}","issue_comment_url":"https://api.github.com/repos/obspy/obspy/issues/comments{/number}","contents_url":"https://api.github.com/repos/obspy/obspy/contents/{+path}","compare_url":"https://api.github.com/repos/obspy/obspy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obspy/obspy/merges","archive_url":"https://api.github.com/repos/obspy/obspy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obspy/obspy/downloads","issues_url":"https://api.github.com/repos/obspy/obspy/issues{/number}","pulls_url":"https://api.github.com/repos/obspy/obspy/pulls{/number}","milestones_url":"https://api.github.com/repos/obspy/obspy/milestones{/number}","notifications_url":"https://api.github.com/repos/obspy/obspy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obspy/obspy/labels{/name}","releases_url":"https://api.github.com/repos/obspy/obspy/releases{/id}","deployments_url":"https://api.github.com/repos/obspy/obspy/deployments","created_at":"2012-09-08T19:17:46Z","updated_at":"2016-03-03T18:56:04Z","pushed_at":"2016-03-04T17:24:53Z","git_url":"git://github.com/obspy/obspy.git","ssh_url":"git@github.com:obspy/obspy.git","clone_url":"https://github.com/obspy/obspy.git","svn_url":"https://github.com/obspy/obspy","homepage":"http://www.obspy.org","size":83887,"stargazers_count":191,"watchers_count":191,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"open_issues_count":135,"forks":141,"open_issues":135,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/obspy/obspy/pulls/1293"},"html":{"href":"https://github.com/obspy/obspy/pull/1293"},"issue":{"href":"https://api.github.com/repos/obspy/obspy/issues/1293"},"comments":{"href":"https://api.github.com/repos/obspy/obspy/issues/1293/comments"},"review_comments":{"href":"https://api.github.com/repos/obspy/obspy/pulls/1293/comments"},"review_comment":{"href":"https://api.github.com/repos/obspy/obspy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/obspy/obspy/pulls/1293/commits"},"statuses":{"href":"https://api.github.com/repos/obspy/obspy/statuses/330657bf0aa0c9ff57f03001ca6979da051bd077"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"krischer","id":800487,"avatar_url":"https://avatars.githubusercontent.com/u/800487?v=3","gravatar_id":"","url":"https://api.github.com/users/krischer","html_url":"https://github.com/krischer","followers_url":"https://api.github.com/users/krischer/followers","following_url":"https://api.github.com/users/krischer/following{/other_user}","gists_url":"https://api.github.com/users/krischer/gists{/gist_id}","starred_url":"https://api.github.com/users/krischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krischer/subscriptions","organizations_url":"https://api.github.com/users/krischer/orgs","repos_url":"https://api.github.com/users/krischer/repos","events_url":"https://api.github.com/users/krischer/events{/privacy}","received_events_url":"https://api.github.com/users/krischer/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"commits":2,"additions":129,"deletions":4,"changed_files":3}}