{"action":"created","issue":{"url":"https://api.github.com/repos/timonreinhard/wemo-client/issues/23","repository_url":"https://api.github.com/repos/timonreinhard/wemo-client","labels_url":"https://api.github.com/repos/timonreinhard/wemo-client/issues/23/labels{/name}","comments_url":"https://api.github.com/repos/timonreinhard/wemo-client/issues/23/comments","events_url":"https://api.github.com/repos/timonreinhard/wemo-client/issues/23/events","html_url":"https://github.com/timonreinhard/wemo-client/pull/23","id":130895325,"number":23,"title":"Error handling and Wemo Bulb Group Enhancements","user":{"login":"rudders","id":104969,"avatar_url":"https://avatars.githubusercontent.com/u/104969?v=3","gravatar_id":"","url":"https://api.github.com/users/rudders","html_url":"https://github.com/rudders","followers_url":"https://api.github.com/users/rudders/followers","following_url":"https://api.github.com/users/rudders/following{/other_user}","gists_url":"https://api.github.com/users/rudders/gists{/gist_id}","starred_url":"https://api.github.com/users/rudders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudders/subscriptions","organizations_url":"https://api.github.com/users/rudders/orgs","repos_url":"https://api.github.com/users/rudders/repos","events_url":"https://api.github.com/users/rudders/events{/privacy}","received_events_url":"https://api.github.com/users/rudders/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2016-02-03T02:59:02Z","updated_at":"2016-02-04T21:50:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/timonreinhard/wemo-client/pulls/23","html_url":"https://github.com/timonreinhard/wemo-client/pull/23","diff_url":"https://github.com/timonreinhard/wemo-client/pull/23.diff","patch_url":"https://github.com/timonreinhard/wemo-client/pull/23.patch"},"body":"Hi Timon,\r\n\r\nLots of changes here and you'll see I struggled to get it working correctly. 3 things to look at.\r\n1. Updated bulb groups to work - it previously only returned the first group, not all of them.\r\n2. Timeout on http.request set to 3 seconds so that homekit didn’t get bored of waiting for a response - this is clearly homekit biased but probably good practice - considered making it an optional parameter on the calls.\r\n3. Recovery from re-subscription to callbacks - I've tested this a lot and it seems to recover from everything I can throw at it - including killing the router for a minute or two and restarting.\r\n\r\nAdrian "},"comment":{"url":"https://api.github.com/repos/timonreinhard/wemo-client/issues/comments/180066328","html_url":"https://github.com/timonreinhard/wemo-client/pull/23#issuecomment-180066328","issue_url":"https://api.github.com/repos/timonreinhard/wemo-client/issues/23","id":180066328,"user":{"login":"timonreinhard","id":724446,"avatar_url":"https://avatars.githubusercontent.com/u/724446?v=3","gravatar_id":"","url":"https://api.github.com/users/timonreinhard","html_url":"https://github.com/timonreinhard","followers_url":"https://api.github.com/users/timonreinhard/followers","following_url":"https://api.github.com/users/timonreinhard/following{/other_user}","gists_url":"https://api.github.com/users/timonreinhard/gists{/gist_id}","starred_url":"https://api.github.com/users/timonreinhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timonreinhard/subscriptions","organizations_url":"https://api.github.com/users/timonreinhard/orgs","repos_url":"https://api.github.com/users/timonreinhard/repos","events_url":"https://api.github.com/users/timonreinhard/events{/privacy}","received_events_url":"https://api.github.com/users/timonreinhard/received_events","type":"User","site_admin":false},"created_at":"2016-02-04T21:50:04Z","updated_at":"2016-02-04T21:50:04Z","body":"No worries, I appreciate your ongoing support and consider your contributions highly valuable. Thank you for taking the time to clean up your pull-request. I will merge it next up."}}