{"action":"closed","number":68,"pull_request":{"url":"https://api.github.com/repos/danielsz/system/pulls/68","id":62667760,"html_url":"https://github.com/danielsz/system/pull/68","diff_url":"https://github.com/danielsz/system/pull/68.diff","patch_url":"https://github.com/danielsz/system/pull/68.patch","issue_url":"https://api.github.com/repos/danielsz/system/issues/68","number":68,"state":"closed","locked":false,"title":"Create WIP on monitoring API","user":{"login":"giorgio-v","id":551484,"avatar_url":"https://avatars.githubusercontent.com/u/551484?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgio-v","html_url":"https://github.com/giorgio-v","followers_url":"https://api.github.com/users/giorgio-v/followers","following_url":"https://api.github.com/users/giorgio-v/following{/other_user}","gists_url":"https://api.github.com/users/giorgio-v/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgio-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgio-v/subscriptions","organizations_url":"https://api.github.com/users/giorgio-v/orgs","repos_url":"https://api.github.com/users/giorgio-v/repos","events_url":"https://api.github.com/users/giorgio-v/events{/privacy}","received_events_url":"https://api.github.com/users/giorgio-v/received_events","type":"User","site_admin":false},"body":"Here’s a first take on #64 \r\n\r\n#### Recap\r\n- Create protocol `system.components.monitoring/Monitoring` with a single function, `-status` and a default implementation on `Object`.\r\n- Modify `system.components.http-kit` to implement the protocol\r\n- Expose `-status` via `system.core/status`\r\n\r\n#### Questions to ponder\r\n- Is `system.components` the correct namespace? Maybe not, maybe should be something like `system.monitoring`?\r\n- Is the exposure in `system.core` desirable? Especially if we move the protocol.\r\n\r\n#### Open items\r\nThese are things to be done if and when we agree on the overall proposal\r\n- Tests\r\n- Docstrings\r\n- Function returning the overall status of a system\r\n- Extending the implementation to the other components","created_at":"2016-03-13T10:42:11Z","updated_at":"2016-04-08T03:17:30Z","closed_at":"2016-04-08T03:17:30Z","merged_at":"2016-04-08T03:17:30Z","merge_commit_sha":"194a35b9e65312c237fc4c01f4861f27029cbb03","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/danielsz/system/pulls/68/commits","review_comments_url":"https://api.github.com/repos/danielsz/system/pulls/68/comments","review_comment_url":"https://api.github.com/repos/danielsz/system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danielsz/system/issues/68/comments","statuses_url":"https://api.github.com/repos/danielsz/system/statuses/194a35b9e65312c237fc4c01f4861f27029cbb03","head":{"label":"giorgio-v:issue-64","ref":"issue-64","sha":"194a35b9e65312c237fc4c01f4861f27029cbb03","user":{"login":"giorgio-v","id":551484,"avatar_url":"https://avatars.githubusercontent.com/u/551484?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgio-v","html_url":"https://github.com/giorgio-v","followers_url":"https://api.github.com/users/giorgio-v/followers","following_url":"https://api.github.com/users/giorgio-v/following{/other_user}","gists_url":"https://api.github.com/users/giorgio-v/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgio-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgio-v/subscriptions","organizations_url":"https://api.github.com/users/giorgio-v/orgs","repos_url":"https://api.github.com/users/giorgio-v/repos","events_url":"https://api.github.com/users/giorgio-v/events{/privacy}","received_events_url":"https://api.github.com/users/giorgio-v/received_events","type":"User","site_admin":false},"repo":{"id":53745247,"name":"system","full_name":"giorgio-v/system","owner":{"login":"giorgio-v","id":551484,"avatar_url":"https://avatars.githubusercontent.com/u/551484?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgio-v","html_url":"https://github.com/giorgio-v","followers_url":"https://api.github.com/users/giorgio-v/followers","following_url":"https://api.github.com/users/giorgio-v/following{/other_user}","gists_url":"https://api.github.com/users/giorgio-v/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgio-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgio-v/subscriptions","organizations_url":"https://api.github.com/users/giorgio-v/orgs","repos_url":"https://api.github.com/users/giorgio-v/repos","events_url":"https://api.github.com/users/giorgio-v/events{/privacy}","received_events_url":"https://api.github.com/users/giorgio-v/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/giorgio-v/system","description":"Reloaded components à la carte","fork":true,"url":"https://api.github.com/repos/giorgio-v/system","forks_url":"https://api.github.com/repos/giorgio-v/system/forks","keys_url":"https://api.github.com/repos/giorgio-v/system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giorgio-v/system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giorgio-v/system/teams","hooks_url":"https://api.github.com/repos/giorgio-v/system/hooks","issue_events_url":"https://api.github.com/repos/giorgio-v/system/issues/events{/number}","events_url":"https://api.github.com/repos/giorgio-v/system/events","assignees_url":"https://api.github.com/repos/giorgio-v/system/assignees{/user}","branches_url":"https://api.github.com/repos/giorgio-v/system/branches{/branch}","tags_url":"https://api.github.com/repos/giorgio-v/system/tags","blobs_url":"https://api.github.com/repos/giorgio-v/system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giorgio-v/system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giorgio-v/system/git/refs{/sha}","trees_url":"https://api.github.com/repos/giorgio-v/system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giorgio-v/system/statuses/{sha}","languages_url":"https://api.github.com/repos/giorgio-v/system/languages","stargazers_url":"https://api.github.com/repos/giorgio-v/system/stargazers","contributors_url":"https://api.github.com/repos/giorgio-v/system/contributors","subscribers_url":"https://api.github.com/repos/giorgio-v/system/subscribers","subscription_url":"https://api.github.com/repos/giorgio-v/system/subscription","commits_url":"https://api.github.com/repos/giorgio-v/system/commits{/sha}","git_commits_url":"https://api.github.com/repos/giorgio-v/system/git/commits{/sha}","comments_url":"https://api.github.com/repos/giorgio-v/system/comments{/number}","issue_comment_url":"https://api.github.com/repos/giorgio-v/system/issues/comments{/number}","contents_url":"https://api.github.com/repos/giorgio-v/system/contents/{+path}","compare_url":"https://api.github.com/repos/giorgio-v/system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giorgio-v/system/merges","archive_url":"https://api.github.com/repos/giorgio-v/system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giorgio-v/system/downloads","issues_url":"https://api.github.com/repos/giorgio-v/system/issues{/number}","pulls_url":"https://api.github.com/repos/giorgio-v/system/pulls{/number}","milestones_url":"https://api.github.com/repos/giorgio-v/system/milestones{/number}","notifications_url":"https://api.github.com/repos/giorgio-v/system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giorgio-v/system/labels{/name}","releases_url":"https://api.github.com/repos/giorgio-v/system/releases{/id}","deployments_url":"https://api.github.com/repos/giorgio-v/system/deployments","created_at":"2016-03-12T17:52:21Z","updated_at":"2016-03-12T17:52:21Z","pushed_at":"2016-04-04T18:32:47Z","git_url":"git://github.com/giorgio-v/system.git","ssh_url":"git@github.com:giorgio-v/system.git","clone_url":"https://github.com/giorgio-v/system.git","svn_url":"https://github.com/giorgio-v/system","homepage":"","size":837,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"danielsz:master","ref":"master","sha":"58acfafb7992e9ceb9d481be2d78dd80647c68c1","user":{"login":"danielsz","id":859131,"avatar_url":"https://avatars.githubusercontent.com/u/859131?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsz","html_url":"https://github.com/danielsz","followers_url":"https://api.github.com/users/danielsz/followers","following_url":"https://api.github.com/users/danielsz/following{/other_user}","gists_url":"https://api.github.com/users/danielsz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsz/subscriptions","organizations_url":"https://api.github.com/users/danielsz/orgs","repos_url":"https://api.github.com/users/danielsz/repos","events_url":"https://api.github.com/users/danielsz/events{/privacy}","received_events_url":"https://api.github.com/users/danielsz/received_events","type":"User","site_admin":false},"repo":{"id":22241341,"name":"system","full_name":"danielsz/system","owner":{"login":"danielsz","id":859131,"avatar_url":"https://avatars.githubusercontent.com/u/859131?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsz","html_url":"https://github.com/danielsz","followers_url":"https://api.github.com/users/danielsz/followers","following_url":"https://api.github.com/users/danielsz/following{/other_user}","gists_url":"https://api.github.com/users/danielsz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsz/subscriptions","organizations_url":"https://api.github.com/users/danielsz/orgs","repos_url":"https://api.github.com/users/danielsz/repos","events_url":"https://api.github.com/users/danielsz/events{/privacy}","received_events_url":"https://api.github.com/users/danielsz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielsz/system","description":"Reloaded components à la carte","fork":false,"url":"https://api.github.com/repos/danielsz/system","forks_url":"https://api.github.com/repos/danielsz/system/forks","keys_url":"https://api.github.com/repos/danielsz/system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielsz/system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielsz/system/teams","hooks_url":"https://api.github.com/repos/danielsz/system/hooks","issue_events_url":"https://api.github.com/repos/danielsz/system/issues/events{/number}","events_url":"https://api.github.com/repos/danielsz/system/events","assignees_url":"https://api.github.com/repos/danielsz/system/assignees{/user}","branches_url":"https://api.github.com/repos/danielsz/system/branches{/branch}","tags_url":"https://api.github.com/repos/danielsz/system/tags","blobs_url":"https://api.github.com/repos/danielsz/system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielsz/system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielsz/system/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielsz/system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielsz/system/statuses/{sha}","languages_url":"https://api.github.com/repos/danielsz/system/languages","stargazers_url":"https://api.github.com/repos/danielsz/system/stargazers","contributors_url":"https://api.github.com/repos/danielsz/system/contributors","subscribers_url":"https://api.github.com/repos/danielsz/system/subscribers","subscription_url":"https://api.github.com/repos/danielsz/system/subscription","commits_url":"https://api.github.com/repos/danielsz/system/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielsz/system/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielsz/system/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielsz/system/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielsz/system/contents/{+path}","compare_url":"https://api.github.com/repos/danielsz/system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielsz/system/merges","archive_url":"https://api.github.com/repos/danielsz/system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielsz/system/downloads","issues_url":"https://api.github.com/repos/danielsz/system/issues{/number}","pulls_url":"https://api.github.com/repos/danielsz/system/pulls{/number}","milestones_url":"https://api.github.com/repos/danielsz/system/milestones{/number}","notifications_url":"https://api.github.com/repos/danielsz/system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielsz/system/labels{/name}","releases_url":"https://api.github.com/repos/danielsz/system/releases{/id}","deployments_url":"https://api.github.com/repos/danielsz/system/deployments","created_at":"2014-07-25T02:05:15Z","updated_at":"2016-04-05T13:20:06Z","pushed_at":"2016-04-08T03:17:29Z","git_url":"git://github.com/danielsz/system.git","ssh_url":"git@github.com:danielsz/system.git","clone_url":"https://github.com/danielsz/system.git","svn_url":"https://github.com/danielsz/system","homepage":"","size":850,"stargazers_count":343,"watchers_count":343,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":9,"forks":43,"open_issues":9,"watchers":343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danielsz/system/pulls/68"},"html":{"href":"https://github.com/danielsz/system/pull/68"},"issue":{"href":"https://api.github.com/repos/danielsz/system/issues/68"},"comments":{"href":"https://api.github.com/repos/danielsz/system/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/danielsz/system/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/danielsz/system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danielsz/system/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/danielsz/system/statuses/194a35b9e65312c237fc4c01f4861f27029cbb03"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"danielsz","id":859131,"avatar_url":"https://avatars.githubusercontent.com/u/859131?v=3","gravatar_id":"","url":"https://api.github.com/users/danielsz","html_url":"https://github.com/danielsz","followers_url":"https://api.github.com/users/danielsz/followers","following_url":"https://api.github.com/users/danielsz/following{/other_user}","gists_url":"https://api.github.com/users/danielsz/gists{/gist_id}","starred_url":"https://api.github.com/users/danielsz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielsz/subscriptions","organizations_url":"https://api.github.com/users/danielsz/orgs","repos_url":"https://api.github.com/users/danielsz/repos","events_url":"https://api.github.com/users/danielsz/events{/privacy}","received_events_url":"https://api.github.com/users/danielsz/received_events","type":"User","site_admin":false},"comments":21,"review_comments":0,"commits":1,"additions":323,"deletions":47,"changed_files":39}}