{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/90717986","pull_request_review_id":11238555,"id":90717986,"diff_hunk":"@@ -0,0 +1,199 @@\n+{ config, lib, pkgs, ... }:\n+\n+with lib;\n+\n+let\n+  cfg = config.virtualisation.glance;\n+  commonConf = ''\n+    [database]\n+    connection = mysql://glance:${cfg.dbPassword}@${cfg.dbHost}/glance","path":"nixos/modules/virtualisation/glance.nix","position":9,"original_position":9,"commit_id":"ac110a1b6a347cc8c2dbc223b4edb089c729e9f3","original_commit_id":"59daf08b6fa388828484e4f01f62c15aa73660a0","user":{"login":"nlewo","id":3425311,"avatar_url":"https://avatars.githubusercontent.com/u/3425311?v=3","gravatar_id":"","url":"https://api.github.com/users/nlewo","html_url":"https://github.com/nlewo","followers_url":"https://api.github.com/users/nlewo/followers","following_url":"https://api.github.com/users/nlewo/following{/other_user}","gists_url":"https://api.github.com/users/nlewo/gists{/gist_id}","starred_url":"https://api.github.com/users/nlewo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlewo/subscriptions","organizations_url":"https://api.github.com/users/nlewo/orgs","repos_url":"https://api.github.com/users/nlewo/repos","events_url":"https://api.github.com/users/nlewo/events{/privacy}","received_events_url":"https://api.github.com/users/nlewo/received_events","type":"User","site_admin":false},"body":"@ip1981 Sorry, I don't understand your point. Could you point me a doc or an example related to the pattern you are suggesting? ","created_at":"2016-12-02T20:55:36Z","updated_at":"2016-12-02T20:55:36Z","html_url":"https://github.com/NixOS/nixpkgs/pull/19529#discussion_r90717986","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/90717986"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/19529#discussion_r90717986"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529","id":89276395,"html_url":"https://github.com/NixOS/nixpkgs/pull/19529","diff_url":"https://github.com/NixOS/nixpkgs/pull/19529.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/19529.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19529","number":19529,"state":"open","locked":false,"title":"Openstack modules","user":{"login":"nlewo","id":3425311,"avatar_url":"https://avatars.githubusercontent.com/u/3425311?v=3","gravatar_id":"","url":"https://api.github.com/users/nlewo","html_url":"https://github.com/nlewo","followers_url":"https://api.github.com/users/nlewo/followers","following_url":"https://api.github.com/users/nlewo/following{/other_user}","gists_url":"https://api.github.com/users/nlewo/gists{/gist_id}","starred_url":"https://api.github.com/users/nlewo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlewo/subscriptions","organizations_url":"https://api.github.com/users/nlewo/orgs","repos_url":"https://api.github.com/users/nlewo/repos","events_url":"https://api.github.com/users/nlewo/events{/privacy}","received_events_url":"https://api.github.com/users/nlewo/received_events","type":"User","site_admin":false},"body":"I continued the works started by @domenkozar on Openstack NixOS modules.\nI'm now able to deploy an Openstack compute node, create a network, a floating IP, boot a VM and ssh to it. So all basic components seem to work well;)\nNote the Neutron driver is currently linuxbridge but I plan to add OVS.\n\nThere is still some (a lot of?) work to have clean modules. \nI would like to know if some people are interested in these modules and if we could define what is required to go to a merge in master.\n\nFor those who are not familiar with Openstack but want to try it, I wrote a short [guide](http://lewo.abesis.fr/posts/2016-09-13-openstack-on-nixos.html) to easily play with these modules, thanks to nixops. \n","created_at":"2016-10-13T20:29:30Z","updated_at":"2016-12-02T20:55:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba18d7d7de5d675e15371a967d062313b5edb0f4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/19529/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ac110a1b6a347cc8c2dbc223b4edb089c729e9f3","head":{"label":"nlewo:openstack","ref":"openstack","sha":"ac110a1b6a347cc8c2dbc223b4edb089c729e9f3","user":{"login":"nlewo","id":3425311,"avatar_url":"https://avatars.githubusercontent.com/u/3425311?v=3","gravatar_id":"","url":"https://api.github.com/users/nlewo","html_url":"https://github.com/nlewo","followers_url":"https://api.github.com/users/nlewo/followers","following_url":"https://api.github.com/users/nlewo/following{/other_user}","gists_url":"https://api.github.com/users/nlewo/gists{/gist_id}","starred_url":"https://api.github.com/users/nlewo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlewo/subscriptions","organizations_url":"https://api.github.com/users/nlewo/orgs","repos_url":"https://api.github.com/users/nlewo/repos","events_url":"https://api.github.com/users/nlewo/events{/privacy}","received_events_url":"https://api.github.com/users/nlewo/received_events","type":"User","site_admin":false},"repo":{"id":47136072,"name":"nixpkgs","full_name":"nlewo/nixpkgs","owner":{"login":"nlewo","id":3425311,"avatar_url":"https://avatars.githubusercontent.com/u/3425311?v=3","gravatar_id":"","url":"https://api.github.com/users/nlewo","html_url":"https://github.com/nlewo","followers_url":"https://api.github.com/users/nlewo/followers","following_url":"https://api.github.com/users/nlewo/following{/other_user}","gists_url":"https://api.github.com/users/nlewo/gists{/gist_id}","starred_url":"https://api.github.com/users/nlewo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlewo/subscriptions","organizations_url":"https://api.github.com/users/nlewo/orgs","repos_url":"https://api.github.com/users/nlewo/repos","events_url":"https://api.github.com/users/nlewo/events{/privacy}","received_events_url":"https://api.github.com/users/nlewo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlewo/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/nlewo/nixpkgs","forks_url":"https://api.github.com/repos/nlewo/nixpkgs/forks","keys_url":"https://api.github.com/repos/nlewo/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlewo/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlewo/nixpkgs/teams","hooks_url":"https://api.github.com/repos/nlewo/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/nlewo/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/nlewo/nixpkgs/events","assignees_url":"https://api.github.com/repos/nlewo/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/nlewo/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/nlewo/nixpkgs/tags","blobs_url":"https://api.github.com/repos/nlewo/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlewo/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlewo/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlewo/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlewo/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/nlewo/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/nlewo/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/nlewo/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/nlewo/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/nlewo/nixpkgs/subscription","commits_url":"https://api.github.com/repos/nlewo/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlewo/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlewo/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlewo/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlewo/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/nlewo/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlewo/nixpkgs/merges","archive_url":"https://api.github.com/repos/nlewo/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlewo/nixpkgs/downloads","issues_url":"https://api.github.com/repos/nlewo/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/nlewo/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/nlewo/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/nlewo/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlewo/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/nlewo/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/nlewo/nixpkgs/deployments","created_at":"2015-11-30T17:56:04Z","updated_at":"2016-01-13T18:09:52Z","pushed_at":"2016-12-02T09:17:09Z","git_url":"git://github.com/nlewo/nixpkgs.git","ssh_url":"git@github.com:nlewo/nixpkgs.git","clone_url":"https://github.com/nlewo/nixpkgs.git","svn_url":"https://github.com/nlewo/nixpkgs","homepage":null,"size":363991,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"acddb5d36745d06b608e71b098ad90d625e9cd5a","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2016-12-02T11:53:58Z","pushed_at":"2016-12-02T20:54:20Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":649176,"stargazers_count":1401,"watchers_count":1401,"language":"Nix","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1734,"mirror_url":null,"open_issues_count":1656,"forks":1734,"open_issues":1656,"watchers":1401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/19529"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19529"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/19529/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/19529/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ac110a1b6a347cc8c2dbc223b4edb089c729e9f3"}}}}
{"actor":{"display_login":"nlewo"}}