{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/68493337","id":68493337,"diff_hunk":"@@ -239,6 +241,18 @@ static int prepare_socket(int fd, const struct sockaddr *addr,\n     goto error;\n   }\n \n+  if (!grpc_set_socket_sndbuf(fd, buffer_size_bytes)) {\n+    gpr_log(GPR_ERROR, \"Failed to set send buffer size to %d bytes\",\n+            buf_size_bytes);\n+    goto error;\n+  }\n+\n+  if (!grpc_set_socket_rcvbuf(fd, buffer_size_bytes)) {\n+    gpr_log(GPR_ERROR, \"Failed to set receive buffer size to %d bytes\",\n+            buf_size_bytes);","path":"src/core/lib/iomgr/udp_server.c","position":21,"original_position":21,"commit_id":"e2b30ebbb321eecb396ecd2934c756aeedd51e98","original_commit_id":"e2b30ebbb321eecb396ecd2934c756aeedd51e98","user":{"login":"jcanizales","id":5120183,"avatar_url":"https://avatars.githubusercontent.com/u/5120183?v=3","gravatar_id":"","url":"https://api.github.com/users/jcanizales","html_url":"https://github.com/jcanizales","followers_url":"https://api.github.com/users/jcanizales/followers","following_url":"https://api.github.com/users/jcanizales/following{/other_user}","gists_url":"https://api.github.com/users/jcanizales/gists{/gist_id}","starred_url":"https://api.github.com/users/jcanizales/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcanizales/subscriptions","organizations_url":"https://api.github.com/users/jcanizales/orgs","repos_url":"https://api.github.com/users/jcanizales/repos","events_url":"https://api.github.com/users/jcanizales/events{/privacy}","received_events_url":"https://api.github.com/users/jcanizales/received_events","type":"User","site_admin":false},"body":"Hi @rjshade, @ctiller, this code is broken (`s/buf_size_bytes/buffer_size_bytes/`).\r\n\r\nDoes none of our tests as much as compile it?","created_at":"2016-06-25T20:15:05Z","updated_at":"2016-06-25T20:15:05Z","html_url":"https://github.com/grpc/grpc/pull/6833#discussion_r68493337","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/6833","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/68493337"},"html":{"href":"https://github.com/grpc/grpc/pull/6833#discussion_r68493337"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6833"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/6833","id":73040328,"html_url":"https://github.com/grpc/grpc/pull/6833","diff_url":"https://github.com/grpc/grpc/pull/6833.diff","patch_url":"https://github.com/grpc/grpc/pull/6833.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/6833","number":6833,"state":"closed","locked":false,"title":"Adds functions to set snd/rcv socket buffer sizes.","user":{"login":"rjshade","id":97579,"avatar_url":"https://avatars.githubusercontent.com/u/97579?v=3","gravatar_id":"","url":"https://api.github.com/users/rjshade","html_url":"https://github.com/rjshade","followers_url":"https://api.github.com/users/rjshade/followers","following_url":"https://api.github.com/users/rjshade/following{/other_user}","gists_url":"https://api.github.com/users/rjshade/gists{/gist_id}","starred_url":"https://api.github.com/users/rjshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjshade/subscriptions","organizations_url":"https://api.github.com/users/rjshade/orgs","repos_url":"https://api.github.com/users/rjshade/repos","events_url":"https://api.github.com/users/rjshade/events{/privacy}","received_events_url":"https://api.github.com/users/rjshade/received_events","type":"User","site_admin":false},"body":"Motivating use case is for non-default 1 MB UDP socket buffers. Also used in fd_posix_test.","created_at":"2016-06-08T12:50:53Z","updated_at":"2016-06-25T20:15:05Z","closed_at":"2016-06-09T02:15:08Z","merged_at":"2016-06-09T02:15:08Z","merge_commit_sha":"4f527d51f9c3a47c110ce03cb7ae88a3d7b76f55","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/6833/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/6833/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/6833/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/e2b30ebbb321eecb396ecd2934c756aeedd51e98","head":{"label":"rjshade:sockopts","ref":"sockopts","sha":"e2b30ebbb321eecb396ecd2934c756aeedd51e98","user":{"login":"rjshade","id":97579,"avatar_url":"https://avatars.githubusercontent.com/u/97579?v=3","gravatar_id":"","url":"https://api.github.com/users/rjshade","html_url":"https://github.com/rjshade","followers_url":"https://api.github.com/users/rjshade/followers","following_url":"https://api.github.com/users/rjshade/following{/other_user}","gists_url":"https://api.github.com/users/rjshade/gists{/gist_id}","starred_url":"https://api.github.com/users/rjshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjshade/subscriptions","organizations_url":"https://api.github.com/users/rjshade/orgs","repos_url":"https://api.github.com/users/rjshade/repos","events_url":"https://api.github.com/users/rjshade/events{/privacy}","received_events_url":"https://api.github.com/users/rjshade/received_events","type":"User","site_admin":false},"repo":{"id":38824869,"name":"grpc","full_name":"rjshade/grpc","owner":{"login":"rjshade","id":97579,"avatar_url":"https://avatars.githubusercontent.com/u/97579?v=3","gravatar_id":"","url":"https://api.github.com/users/rjshade","html_url":"https://github.com/rjshade","followers_url":"https://api.github.com/users/rjshade/followers","following_url":"https://api.github.com/users/rjshade/following{/other_user}","gists_url":"https://api.github.com/users/rjshade/gists{/gist_id}","starred_url":"https://api.github.com/users/rjshade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjshade/subscriptions","organizations_url":"https://api.github.com/users/rjshade/orgs","repos_url":"https://api.github.com/users/rjshade/repos","events_url":"https://api.github.com/users/rjshade/events{/privacy}","received_events_url":"https://api.github.com/users/rjshade/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rjshade/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/rjshade/grpc","forks_url":"https://api.github.com/repos/rjshade/grpc/forks","keys_url":"https://api.github.com/repos/rjshade/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rjshade/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rjshade/grpc/teams","hooks_url":"https://api.github.com/repos/rjshade/grpc/hooks","issue_events_url":"https://api.github.com/repos/rjshade/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/rjshade/grpc/events","assignees_url":"https://api.github.com/repos/rjshade/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/rjshade/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/rjshade/grpc/tags","blobs_url":"https://api.github.com/repos/rjshade/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rjshade/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rjshade/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/rjshade/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rjshade/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/rjshade/grpc/languages","stargazers_url":"https://api.github.com/repos/rjshade/grpc/stargazers","contributors_url":"https://api.github.com/repos/rjshade/grpc/contributors","subscribers_url":"https://api.github.com/repos/rjshade/grpc/subscribers","subscription_url":"https://api.github.com/repos/rjshade/grpc/subscription","commits_url":"https://api.github.com/repos/rjshade/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/rjshade/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/rjshade/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/rjshade/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/rjshade/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/rjshade/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rjshade/grpc/merges","archive_url":"https://api.github.com/repos/rjshade/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rjshade/grpc/downloads","issues_url":"https://api.github.com/repos/rjshade/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/rjshade/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/rjshade/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/rjshade/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rjshade/grpc/labels{/name}","releases_url":"https://api.github.com/repos/rjshade/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/rjshade/grpc/deployments","created_at":"2015-07-09T14:21:20Z","updated_at":"2016-01-25T18:09:45Z","pushed_at":"2016-06-23T18:31:53Z","git_url":"git://github.com/rjshade/grpc.git","ssh_url":"git@github.com:rjshade/grpc.git","clone_url":"https://github.com/rjshade/grpc.git","svn_url":"https://github.com/rjshade/grpc","homepage":"","size":72805,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"2c57371b937e6ac37b2d331a817bb7f1e33b5383","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2016-06-25T08:43:10Z","pushed_at":"2016-06-25T19:55:47Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":195561,"stargazers_count":5273,"watchers_count":5273,"language":"C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":974,"mirror_url":null,"open_issues_count":641,"forks":974,"open_issues":641,"watchers":5273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6833"},"html":{"href":"https://github.com/grpc/grpc/pull/6833"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/6833"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/6833/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6833/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/6833/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/e2b30ebbb321eecb396ecd2934c756aeedd51e98"}}}}
{"actor":{"display_login":"jcanizales"}}