{"action":"opened","number":604,"pull_request":{"url":"https://api.github.com/repos/draios/sysdig/pulls/604","id":72276111,"html_url":"https://github.com/draios/sysdig/pull/604","diff_url":"https://github.com/draios/sysdig/pull/604.diff","patch_url":"https://github.com/draios/sysdig/pull/604.patch","issue_url":"https://api.github.com/repos/draios/sysdig/issues/604","number":604,"state":"open","locked":false,"title":"Add regression tests for proc.sid/proc.sname.","user":{"login":"mstemm","id":13422831,"avatar_url":"https://avatars.githubusercontent.com/u/13422831?v=3","gravatar_id":"","url":"https://api.github.com/users/mstemm","html_url":"https://github.com/mstemm","followers_url":"https://api.github.com/users/mstemm/followers","following_url":"https://api.github.com/users/mstemm/following{/other_user}","gists_url":"https://api.github.com/users/mstemm/gists{/gist_id}","starred_url":"https://api.github.com/users/mstemm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstemm/subscriptions","organizations_url":"https://api.github.com/users/mstemm/orgs","repos_url":"https://api.github.com/users/mstemm/repos","events_url":"https://api.github.com/users/mstemm/events{/privacy}","received_events_url":"https://api.github.com/users/mstemm/received_events","type":"User","site_admin":false},"body":"The actual new change is to add a second trace file sessions.scap which\r\nshows the results of calling \"setsid -w ls\", with results scoped to the\r\nshell where setsid is run. This handles all the cases of tracking a\r\nsession id/name for an existing process (the base shell), execing\r\n\"setsid -w ls\", which changes the sid and sname, and waiting for the ls\r\nto exit.\r\n\r\nIn order to add this new trace file, I needed to change how the\r\nregression tests were run. The current regression tests assumed that for\r\na given input trace file that there would be a corresponding baseline\r\ndirectory with the results of running that trace file with all the sets\r\nof arguments in sysdig_trace_regression.sh. That didn't really handle\r\nforward-looking cases like this, where I don't want to run old files\r\nwith new combinations of arguments and didn't want to use old arguments\r\non the new trace file.\r\n\r\nFix this by changing sysdig_batch_parser to skip running sysdig with a\r\ngiven set of arguments when the corresponding baseline directory doesn't\r\nexist.\r\n\r\nThis change has zip files baseline-add-session-tests.zip and\r\ntraces-add-session-tests.zip, which should work based on my\r\nunderstanding of TRAVIS_BRANCH. After merging this branch to dev I'll\r\nupdate the actual baseline.zip/traces.zip files, and give anyone working\r\non an active branch to rebase.\r\n\r\nThis won't handle the case of the master branch, though. I need to check\r\nto see if sysdig_trace_regression is run outside of travis.\r\n\r\n@ltagliamonte are you familiar with these tests at all? If so does the approach look good to you?","created_at":"2016-06-02T01:09:35Z","updated_at":"2016-06-02T01:09:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/draios/sysdig/pulls/604/commits","review_comments_url":"https://api.github.com/repos/draios/sysdig/pulls/604/comments","review_comment_url":"https://api.github.com/repos/draios/sysdig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/draios/sysdig/issues/604/comments","statuses_url":"https://api.github.com/repos/draios/sysdig/statuses/88ad6b0003b1b724e5682216e7b98459a7515242","head":{"label":"draios:add-session-tests","ref":"add-session-tests","sha":"88ad6b0003b1b724e5682216e7b98459a7515242","user":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"repo":{"id":15926180,"name":"sysdig","full_name":"draios/sysdig","owner":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/draios/sysdig","description":"Linux system exploration and troubleshooting tool with first class support for containers","fork":false,"url":"https://api.github.com/repos/draios/sysdig","forks_url":"https://api.github.com/repos/draios/sysdig/forks","keys_url":"https://api.github.com/repos/draios/sysdig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/draios/sysdig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/draios/sysdig/teams","hooks_url":"https://api.github.com/repos/draios/sysdig/hooks","issue_events_url":"https://api.github.com/repos/draios/sysdig/issues/events{/number}","events_url":"https://api.github.com/repos/draios/sysdig/events","assignees_url":"https://api.github.com/repos/draios/sysdig/assignees{/user}","branches_url":"https://api.github.com/repos/draios/sysdig/branches{/branch}","tags_url":"https://api.github.com/repos/draios/sysdig/tags","blobs_url":"https://api.github.com/repos/draios/sysdig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/draios/sysdig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/draios/sysdig/git/refs{/sha}","trees_url":"https://api.github.com/repos/draios/sysdig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/draios/sysdig/statuses/{sha}","languages_url":"https://api.github.com/repos/draios/sysdig/languages","stargazers_url":"https://api.github.com/repos/draios/sysdig/stargazers","contributors_url":"https://api.github.com/repos/draios/sysdig/contributors","subscribers_url":"https://api.github.com/repos/draios/sysdig/subscribers","subscription_url":"https://api.github.com/repos/draios/sysdig/subscription","commits_url":"https://api.github.com/repos/draios/sysdig/commits{/sha}","git_commits_url":"https://api.github.com/repos/draios/sysdig/git/commits{/sha}","comments_url":"https://api.github.com/repos/draios/sysdig/comments{/number}","issue_comment_url":"https://api.github.com/repos/draios/sysdig/issues/comments{/number}","contents_url":"https://api.github.com/repos/draios/sysdig/contents/{+path}","compare_url":"https://api.github.com/repos/draios/sysdig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/draios/sysdig/merges","archive_url":"https://api.github.com/repos/draios/sysdig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/draios/sysdig/downloads","issues_url":"https://api.github.com/repos/draios/sysdig/issues{/number}","pulls_url":"https://api.github.com/repos/draios/sysdig/pulls{/number}","milestones_url":"https://api.github.com/repos/draios/sysdig/milestones{/number}","notifications_url":"https://api.github.com/repos/draios/sysdig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/draios/sysdig/labels{/name}","releases_url":"https://api.github.com/repos/draios/sysdig/releases{/id}","deployments_url":"https://api.github.com/repos/draios/sysdig/deployments","created_at":"2014-01-15T05:45:17Z","updated_at":"2016-06-01T07:29:55Z","pushed_at":"2016-06-02T00:47:34Z","git_url":"git://github.com/draios/sysdig.git","ssh_url":"git@github.com:draios/sysdig.git","clone_url":"https://github.com/draios/sysdig.git","svn_url":"https://github.com/draios/sysdig","homepage":"http://www.sysdig.org/","size":13958,"stargazers_count":3676,"watchers_count":3676,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":101,"forks":331,"open_issues":101,"watchers":3676,"default_branch":"dev"}},"base":{"label":"draios:dev","ref":"dev","sha":"1f0b9cee1a93de49554f921c1c3378612b30ceb7","user":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"repo":{"id":15926180,"name":"sysdig","full_name":"draios/sysdig","owner":{"login":"draios","id":5068817,"avatar_url":"https://avatars.githubusercontent.com/u/5068817?v=3","gravatar_id":"","url":"https://api.github.com/users/draios","html_url":"https://github.com/draios","followers_url":"https://api.github.com/users/draios/followers","following_url":"https://api.github.com/users/draios/following{/other_user}","gists_url":"https://api.github.com/users/draios/gists{/gist_id}","starred_url":"https://api.github.com/users/draios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/draios/subscriptions","organizations_url":"https://api.github.com/users/draios/orgs","repos_url":"https://api.github.com/users/draios/repos","events_url":"https://api.github.com/users/draios/events{/privacy}","received_events_url":"https://api.github.com/users/draios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/draios/sysdig","description":"Linux system exploration and troubleshooting tool with first class support for containers","fork":false,"url":"https://api.github.com/repos/draios/sysdig","forks_url":"https://api.github.com/repos/draios/sysdig/forks","keys_url":"https://api.github.com/repos/draios/sysdig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/draios/sysdig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/draios/sysdig/teams","hooks_url":"https://api.github.com/repos/draios/sysdig/hooks","issue_events_url":"https://api.github.com/repos/draios/sysdig/issues/events{/number}","events_url":"https://api.github.com/repos/draios/sysdig/events","assignees_url":"https://api.github.com/repos/draios/sysdig/assignees{/user}","branches_url":"https://api.github.com/repos/draios/sysdig/branches{/branch}","tags_url":"https://api.github.com/repos/draios/sysdig/tags","blobs_url":"https://api.github.com/repos/draios/sysdig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/draios/sysdig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/draios/sysdig/git/refs{/sha}","trees_url":"https://api.github.com/repos/draios/sysdig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/draios/sysdig/statuses/{sha}","languages_url":"https://api.github.com/repos/draios/sysdig/languages","stargazers_url":"https://api.github.com/repos/draios/sysdig/stargazers","contributors_url":"https://api.github.com/repos/draios/sysdig/contributors","subscribers_url":"https://api.github.com/repos/draios/sysdig/subscribers","subscription_url":"https://api.github.com/repos/draios/sysdig/subscription","commits_url":"https://api.github.com/repos/draios/sysdig/commits{/sha}","git_commits_url":"https://api.github.com/repos/draios/sysdig/git/commits{/sha}","comments_url":"https://api.github.com/repos/draios/sysdig/comments{/number}","issue_comment_url":"https://api.github.com/repos/draios/sysdig/issues/comments{/number}","contents_url":"https://api.github.com/repos/draios/sysdig/contents/{+path}","compare_url":"https://api.github.com/repos/draios/sysdig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/draios/sysdig/merges","archive_url":"https://api.github.com/repos/draios/sysdig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/draios/sysdig/downloads","issues_url":"https://api.github.com/repos/draios/sysdig/issues{/number}","pulls_url":"https://api.github.com/repos/draios/sysdig/pulls{/number}","milestones_url":"https://api.github.com/repos/draios/sysdig/milestones{/number}","notifications_url":"https://api.github.com/repos/draios/sysdig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/draios/sysdig/labels{/name}","releases_url":"https://api.github.com/repos/draios/sysdig/releases{/id}","deployments_url":"https://api.github.com/repos/draios/sysdig/deployments","created_at":"2014-01-15T05:45:17Z","updated_at":"2016-06-01T07:29:55Z","pushed_at":"2016-06-02T00:47:34Z","git_url":"git://github.com/draios/sysdig.git","ssh_url":"git@github.com:draios/sysdig.git","clone_url":"https://github.com/draios/sysdig.git","svn_url":"https://github.com/draios/sysdig","homepage":"http://www.sysdig.org/","size":13958,"stargazers_count":3676,"watchers_count":3676,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":331,"mirror_url":null,"open_issues_count":101,"forks":331,"open_issues":101,"watchers":3676,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/draios/sysdig/pulls/604"},"html":{"href":"https://github.com/draios/sysdig/pull/604"},"issue":{"href":"https://api.github.com/repos/draios/sysdig/issues/604"},"comments":{"href":"https://api.github.com/repos/draios/sysdig/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/draios/sysdig/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/draios/sysdig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/draios/sysdig/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/draios/sysdig/statuses/88ad6b0003b1b724e5682216e7b98459a7515242"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"mstemm"}}